Build fix after r139357. It was missing a comma.
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Build fix after r139357. It was missing a comma.
4
5         * QueueStatusServer/model/queues.py:
6         (Queue):
7
8 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
9
10         Fixing AuthenticationError when running test-webkitpy as a non-committer.
11         https://bugs.webkit.org/show_bug.cgi?id=106420
12
13         Reviewed by Eric Seidel.
14
15         * Scripts/webkitpy/common/checkout/scm/git.py:
16         (Git.push_local_commits_to_server):
17         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
18         * Scripts/webkitpy/common/checkout/scm/svn.py:
19         (SVNRepository):
20         (SVNRepository.has_authorization_for_realm):
21
22 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
23
24         [EFL][jhbuild] Use tarballs for gstreamer instead of git
25         https://bugs.webkit.org/show_bug.cgi?id=106552
26
27         Reviewed by Laszlo Gombos.
28
29         Use tarballs for gstreamer instead of git in EFL's jhbuild
30         to work around intermittent network issues on our build
31         bots. Tarballs are fully cached and require no network
32         operation if their checksum matches.
33
34         * efl/jhbuild.modules:
35
36 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
37
38         Add Mac WK2 EWS bots
39         https://bugs.webkit.org/show_bug.cgi?id=106590
40
41         Reviewed by Adam Barth.
42
43         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
44         Also add a deprecated MacWK2Port class.
45
46         * QueueStatusServer/model/queues.py:
47         (Queue):
48         * Scripts/webkitpy/common/config/ports.py:
49         (DeprecatedPort.port):
50         (MacWK2Port):
51         (MacWK2Port.run_webkit_tests_command):
52         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
53         (MacEWS):
54         (MacWK2EWS):
55         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
56         (_test_ewses):
57
58 2013-01-10  Dan Carney  <dcarney@google.com>
59
60         [chromium] move webpermissionclient related methods to TestRunner library
61         https://bugs.webkit.org/show_bug.cgi?id=106548
62
63         Reviewed by Jochen Eisinger.
64
65         * DumpRenderTree/DumpRenderTree.gypi:
66         * DumpRenderTree/chromium/DRTTestRunner.cpp:
67         (DRTTestRunner::DRTTestRunner):
68         (DRTTestRunner::reset):
69         * DumpRenderTree/chromium/DRTTestRunner.h:
70         (DRTTestRunner):
71         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
72         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
73         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
74         (WebKit):
75         (WebTestRunner::WebTestRunner::webPermissions):
76         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
77         (WebTestRunner::TestRunner::TestRunner):
78         (WebTestRunner::TestRunner::setDelegate):
79         (WebTestRunner):
80         (WebTestRunner::TestRunner::reset):
81         (WebTestRunner::TestRunner::webPermissions):
82         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
83         (WebTestRunner::TestRunner::setImagesAllowed):
84         (WebTestRunner::TestRunner::setScriptsAllowed):
85         (WebTestRunner::TestRunner::setStorageAllowed):
86         (WebTestRunner::TestRunner::setPluginsAllowed):
87         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
88         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
89         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
90         (WebTestRunner):
91         (TestRunner):
92         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
93         (WebTestRunner):
94         (WebTestRunner::WebPermissions::WebPermissions):
95         (WebTestRunner::WebPermissions::~WebPermissions):
96         (WebTestRunner::WebPermissions::allowImage):
97         (WebTestRunner::WebPermissions::allowScriptFromSource):
98         (WebTestRunner::WebPermissions::allowStorage):
99         (WebTestRunner::WebPermissions::allowPlugins):
100         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
101         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
102         (WebTestRunner::WebPermissions::setImagesAllowed):
103         (WebTestRunner::WebPermissions::setScriptsAllowed):
104         (WebTestRunner::WebPermissions::setStorageAllowed):
105         (WebTestRunner::WebPermissions::setPluginsAllowed):
106         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
107         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
108         (WebTestRunner::WebPermissions::setDelegate):
109         (WebTestRunner::WebPermissions::setDumpCallbacks):
110         (WebTestRunner::WebPermissions::reset):
111         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
112         (WebTestRunner):
113         (WebPermissions):
114         * DumpRenderTree/chromium/TestShell.cpp:
115         (TestShell::initialize):
116         (TestShell::resetTestController):
117         (TestShell::createNewWindow):
118         * DumpRenderTree/chromium/TestShell.h:
119         (TestShell):
120         * DumpRenderTree/chromium/WebViewHost.cpp:
121         (WebViewHost::normalizeLayoutTestURL):
122         * DumpRenderTree/chromium/WebViewHost.h:
123         (WebViewHost):
124
125 2013-01-10  Alan Cutter  <alancutter@chromium.org>
126
127         Split EWS tool cold-boot.sh into modular components
128         https://bugs.webkit.org/show_bug.cgi?id=106527
129
130         Reviewed by Adam Barth.
131
132         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
133         Updated GCE bot build scripts to match.
134         Unable to test scripts directly as they depend on being in the repository to work!
135
136         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
137         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
138         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
139         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
140         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
141
142 2013-01-10  Julie Parent  <jparent@chromium.org>
143
144         Dashboard Cleanup: Do not generate the page if we are about to reload.
145         https://bugs.webkit.org/show_bug.cgi?id=106584
146
147         Reviewed by Dirk Pranke.
148
149         Move the logic to determine if we should generate the page into
150         parseParameters() since that is where we have the knowledge to
151         determine it, and return that value to handleLocationChange, 
152         rather than passing the changed parameters back to handleLocationChange
153         and having it make the decision.
154         
155         This is logically equivalent, save one case: when we are about to do
156         a reload, we know that there is no reason to generate the page.  Old
157         code was causing an extra page generation in this case.
158         
159         * TestResultServer/static-dashboards/dashboard_base.js:
160         (parseParameters):
161         (handleLocationChange):
162
163 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
164
165         [jhbuild] Use the "configure" script to build glib
166         https://bugs.webkit.org/show_bug.cgi?id=106569
167
168         Reviewed by Martin Robinson.
169
170         So far both EFL and GTK have been using autogen.sh to build glib.
171         While that does work most of the time, it's not really needed since
172         we are downloading and building stable releases from tarballs.
173         Additionally, autogen.sh fails to work with automake 1.13 due to the
174         usage of some macros that have been removed (this has already been
175         fixed in glib master).
176
177         * efl/jhbuild.modules:
178         * gtk/jhbuild.modules:
179
180 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
181
182         Changing tests to be consistent and use self.scm rather then recreating the scm object.
183         (Missed a couple)
184         https://bugs.webkit.org/show_bug.cgi?id=106536
185
186         Reviewed by Eric Seidel.
187
188         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
189
190 2013-01-10  Tony Chang  <tony@chromium.org>
191
192         Speed up supplemental dependency computation
193         https://bugs.webkit.org/show_bug.cgi?id=106503
194
195         Reviewed by Adam Barth.
196
197         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
198
199         * WebKitTestRunner/CMakeLists.txt:
200
201 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
202
203         Remove the ENABLE_ANIMATION_API feature define occurences
204         https://bugs.webkit.org/show_bug.cgi?id=106544
205
206         Reviewed by Simon Fraser.
207
208         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
209         feature define handling still lingers in various build systems and configurations
210         but is of no use, so it should be removed.
211
212         * Scripts/webkitperl/FeatureList.pm:
213         * qmake/mkspecs/features/features.pri:
214
215 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
216
217         [GTK] Add support for loading web process extensions
218         https://bugs.webkit.org/show_bug.cgi?id=105631
219
220         Reviewed by Gustavo Noronha Silva.
221
222         * MiniBrowser/gtk/GNUmakefile.am:
223         * MiniBrowser/gtk/main.c:
224         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
225         bundle lib from build dir.
226         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
227         located in WebProcess/InjectedBundle/API/gtk.
228         * gtk/generate-gtkdoc:
229         (get_webkit2_options): Scan also files in
230         WebProcess/InjectedBundle/API/gtk to generate API docs.
231         (get_webkit2_options.injected_bundle_src_path): Helper function to
232         build paths in WebProcess/InjectedBundle/API/gtk.
233
234 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
235
236         [EFL][WK2] Writing immediately to created windows (open) fails
237         https://bugs.webkit.org/show_bug.cgi?id=105276
238
239         Reviewed by Kenneth Rohde Christiansen.
240
241         Do not reset 'about:blank' url for the new pages in mini browser.
242
243         * MiniBrowser/efl/main.c:
244         (window_create):
245
246 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
247
248         Changing tests to be consistent and use self.scm rather then recreating the scm object.
249         https://bugs.webkit.org/show_bug.cgi?id=106536
250
251         Reviewed by Eric Seidel.
252
253         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
254
255 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
256
257         Converting to unittest2 so we can use assertItemsEqual, making tests
258         not dependent on order of items.
259         https://bugs.webkit.org/show_bug.cgi?id=106532
260
261         Before:
262         Ran 1733 tests in 38.385s
263         FAILED (failures=1, errors=22)
264
265         After:
266         Ran 1733 tests in 32.298s
267         FAILED (failures=0, errors=22)
268
269         Reviewed by Eric Seidel.
270
271         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
272         * Scripts/webkitpy/thirdparty/__init__.py:
273         (AutoinstallImportHook._install_unittest2):
274
275 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
276
277         [EFL] Add gstreamer 1.0.5 to jhbuild
278         https://bugs.webkit.org/show_bug.cgi?id=106178
279
280         Reviewed by Laszlo Gombos.
281
282         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
283
284         * efl/jhbuild.modules:
285
286 2013-01-09  Alan Cutter  <alancutter@chromium.org>
287
288         Updated parameters in GCE build scripts so they now work.
289         https://bugs.webkit.org/show_bug.cgi?id=106523
290
291         Reviewed by Adam Barth.
292
293         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
294         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
295         * EWSTools/cold-boot.sh:
296
297 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
298
299         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
300         https://bugs.webkit.org/show_bug.cgi?id=106520
301
302         Reviewed by James Robinson.
303
304         Part of a larger refactoring series. See tracking bug 82948.
305
306         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
307         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
308
309 2013-01-09  Julie Parent  <jparent@chromium.org>
310
311         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
312         https://bugs.webkit.org/show_bug.cgi?id=106514
313
314         This is old code, as these can no longer get out of sync.
315         permmaLinkURLHash is generated from currentState, which is set only
316         from the location.  The commment about how these can get out of sync
317         refers to a function that no longer exists.
318         
319         Reviewed by Dirk Pranke.
320
321         * TestResultServer/static-dashboards/dashboard_base.js:
322         (handleLocationChange):
323
324 2013-01-09  Julie Parent  <jparent@chromium.org>
325
326         Dashboard Cleanup: Reload the page as soon as we know we need to.
327         https://bugs.webkit.org/show_bug.cgi?id=106515
328
329         No need to continue parsing all of the data once we know that
330         we need to do a reload.
331         
332         Reviewed by Dirk Pranke.
333
334         * TestResultServer/static-dashboards/dashboard_base.js:
335         (parseParameters):
336
337 2013-01-09  Eric Seidel  <eric@webkit.org>
338
339         run-perf-tests --chromium-android --profile should show symbols for the kernel
340         https://bugs.webkit.org/show_bug.cgi?id=106498
341
342         Reviewed by Adam Barth.
343
344         Turns out this was easy, once I finally read the output from "perf report".
345         It appears there may be a bug in "perf record" on android, as it complains
346         about not being able to read from /proc/kallsyms even when
347         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
348         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
349         but rather just flip it to 0 long enough to grab the /proc/kallsyms
350         and then flip it back to whatever the device had.
351
352         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
353         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
354         to symbol names.  Its world-readable, but will return all 0s if you
355         don't have permission to see the kernel symbols.  kptr_restrict
356         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
357         1 is only a specific group, and 2 is "no one, not even root".
358         By default kptr_restrict is 2 on Android it seems.
359         More kptr_restrict docs: http://lwn.net/Articles/420403/
360
361         I also took this opportunity to clean up how the perf record command
362         was built for use/display in AndroidPerf.profile_after_exit and
363         change to always using long-form names for the arguments (to hopefully help readability).
364
365         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
366         (AndroidPerf.__init__):
367         (profile_after_exit):
368         (ChromiumAndroidDriver.__init__):
369         (ChromiumAndroidDriver._update_kallsyms_cache):
370         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
371
372 2013-01-09  Julie Parent  <jparent@chromium.org>
373
374         Dashboard cleanup: remove dead code.
375         https://bugs.webkit.org/show_bug.cgi?id=106509
376
377         Reviewed by Dirk Pranke.
378
379         * TestResultServer/static-dashboards/dashboard_base.js:
380         (parseParameters):
381
382 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
383
384         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
385         https://bugs.webkit.org/show_bug.cgi?id=105638
386
387         Reviewed by Martin Robinson.
388
389         The test was failing for two reasons:
390         - AccessibilityRenderObject::correspondingLabelForControlElement() was
391           not ignoring the ARIA labelled-by property
392         - AccessibilityController::accessibleElementById() was not implemented
393
394         Because getting an element by ID cannot be done in the UIProcess, the
395         decision was made to expose the element's ID as an accessible attribute
396         of the object.
397
398         In addition, fixing the bug in AccessibilityRenderObject made it possible
399         to eliminate the Gtk platform-specific expectations for another test.
400
401         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
402         (childElementById): Added. Walks the tree looking for the AtkObject
403         Attribute which exposes the HTML element's ID.
404         (AccessibilityController::accessibleElementById): Implemented.
405         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
406         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
407         when there is no title, as is done with the Mac port.
408         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
409         (WTR):
410         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
411         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
412         Attribute which exposes the HTML element's ID.
413         (WTR):
414         (WTR::AccessibilityController::accessibleElementById): Implemented.
415         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
416         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
417         even when there is no title, as is done with the Mac port.
418
419 2013-01-09  Gregg Tavares  <gman@google.com>
420
421         Add Gregg Tavares as a committer
422         https://bugs.webkit.org/show_bug.cgi?id=106492
423
424         Unreviewed.
425
426         * Scripts/webkitpy/common/config/committers.py:
427
428 2013-01-09  Roger Fong  <roger_fong@apple.com>
429
430         Enable seamless iFrames for Windows DRT.
431         https://bugs.webkit.org/show_bug.cgi?id=106468.
432
433         Rubberstamped by Timothy Horton.
434
435         * DumpRenderTree/win/DumpRenderTree.cpp:
436         (resetDefaultsToConsistentValues):
437
438 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
439
440         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
441         https://bugs.webkit.org/show_bug.cgi?id=93979
442
443         Reviewed by Benjamin Poulain.
444
445         Implement eventSender.scheduleAsynchronousKeyDown() in
446         WebKitTestRunner.
447
448         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
449         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
450         (WTR::createKeyDownMessageBody):
451         (WTR::EventSendingController::keyDown):
452         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
453         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
454         (EventSendingController):
455         * WebKitTestRunner/TestController.cpp:
456         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
457         (WTR::TestController::didReceiveMessageFromInjectedBundle):
458         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
459         * WebKitTestRunner/TestController.h:
460         (TestController):
461
462 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
463
464         [chromium] move resource load callback dumping to TestRunner library
465         https://bugs.webkit.org/show_bug.cgi?id=106449
466
467         Reviewed by Adam Barth.
468
469         * DumpRenderTree/chromium/DRTTestRunner.cpp:
470         (DRTTestRunner::DRTTestRunner):
471         (DRTTestRunner::reset):
472         * DumpRenderTree/chromium/DRTTestRunner.h:
473         (DRTTestRunner):
474         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
475         (WebKit):
476         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
477         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
478         (WebKit):
479         (WebTestProxyBase):
480         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
481         (WebTestRunner::WebTestProxy::willRequestResource):
482         (WebTestRunner::WebTestProxy::willSendRequest):
483         (WebTestRunner::WebTestProxy::didReceiveResponse):
484         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
485         (WebTestRunner::WebTestProxy::didFailResourceLoad):
486         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
487         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
488         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
489         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
490         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
491         (WebTestRunner::TestRunner::TestRunner):
492         (WebTestRunner::TestRunner::reset):
493         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
494         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
495         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
496         (WebTestRunner):
497         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
498         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
499         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
500         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
501         (TestRunner):
502         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
503         (WebTestRunner::WebTestProxyBase::reset):
504         (WebTestRunner):
505         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
506         (WebTestRunner::WebTestProxyBase::willRequestResource):
507         (WebTestRunner::WebTestProxyBase::willSendRequest):
508         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
509         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
510         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
511         * DumpRenderTree/chromium/WebViewHost.cpp:
512         (WebViewHost::willSendRequest):
513         (WebViewHost::makeURLErrorDescription):
514         (WebViewHost::reset):
515         * DumpRenderTree/chromium/WebViewHost.h:
516         (WebViewHost):
517
518 2013-01-09  Dan Carney  <dcarney@google.com>
519
520         [chromium] move dumpcreateview methods to testrunner library
521         https://bugs.webkit.org/show_bug.cgi?id=106434
522
523         Reviewed by Adam Barth.
524
525         * DumpRenderTree/chromium/DRTTestRunner.cpp:
526         (DRTTestRunner::DRTTestRunner):
527         (DRTTestRunner::reset):
528         * DumpRenderTree/chromium/DRTTestRunner.h:
529         (DRTTestRunner):
530         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
531         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
532         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
533         (WebTestRunner::TestRunner::TestRunner):
534         (WebTestRunner::TestRunner::reset):
535         (WebTestRunner::TestRunner::shouldDumpCreateView):
536         (WebTestRunner):
537         (WebTestRunner::TestRunner::dumpCreateView):
538         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
539         (TestRunner):
540
541 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
542
543         webkitpy cleanup: Merge additional_comment_text into comment_text
544         https://bugs.webkit.org/show_bug.cgi?id=106421
545
546         Reviewed by Adam Barth.
547
548         * Scripts/webkitpy/common/config/committervalidator.py:
549         (CommitterValidator.reject_patch_from_commit_queue):
550         (CommitterValidator.reject_patch_from_review_queue):
551         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
552         (Bugzilla.set_flag_on_attachment):
553         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
554         (MockBugzilla.set_flag_on_attachment):
555         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
556         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
557         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
558         * Scripts/webkitpy/tool/commands/queues_unittest.py:
559
560 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
561
562         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
563         https://bugs.webkit.org/show_bug.cgi?id=106464
564
565         Reviewed by Martin Robinson.
566
567         Current version in jhbuild.modules (2.26.0) is giving trouble to
568         when trying to build WebKitGTK from scratch, due to a segmentation
569         fault error in gdk-pixbuf-query-loader during the 'make'
570         phase. Raising the version to 2.26.5 fixes this issue.
571
572         * gtk/jhbuild.modules: Version raised, checksums updated.
573
574 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
575
576         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
577         https://bugs.webkit.org/show_bug.cgi?id=90968.
578
579         Reviewed by Csaba Osztrogonác.
580
581         Added functionality in DRT and WTR to use any timeout value while running
582         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
583         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
584         to indicate whether the current port supports setting timeout value
585         per test (it's False by default; I enabled it only on Qt).
586         Also corrected a typo in driver.py
587
588         * DumpRenderTree/DumpRenderTree.h:
589         (TestCommand::TestCommand):
590         (TestCommand):
591         * DumpRenderTree/DumpRenderTreeCommon.cpp:
592         (parseInputLine):
593         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
594         (WebCore::DumpRenderTree::processLine):
595         * Scripts/webkitpy/layout_tests/port/base.py:
596         (Port.supports_per_test_timeout):
597         * Scripts/webkitpy/layout_tests/port/driver.py:
598         (Driver.run_test):
599         (Driver._command_from_driver_input):
600         * Scripts/webkitpy/layout_tests/port/qt.py:
601         (QtPort.supports_per_test_timeout):
602         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
603         (WTR::InjectedBundle::InjectedBundle):
604         (WTR::InjectedBundle::didReceiveMessage):
605         (WTR::InjectedBundle::beginTesting):
606         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
608         (WTR::TestRunner::setCustomTimeout):
609         (WTR):
610         * WebKitTestRunner/InjectedBundle/TestRunner.h:
611         (TestRunner):
612         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
613         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
614         * WebKitTestRunner/TestController.cpp:
615         (WTR::TestController::TestController):
616         (WTR::TestController::getCustomTimeout):
617         (WTR):
618         (WTR::TestCommand::TestCommand):
619         (TestCommand):
620         (WTR::parseInputLine):
621         (WTR::TestController::runTest):
622         (WTR::TestController::runUntil):
623         * WebKitTestRunner/TestController.h:
624         (TestController):
625         * WebKitTestRunner/TestInvocation.cpp:
626         (WTR::TestInvocation::TestInvocation):
627         (WTR::TestInvocation::setCustomTimeout):
628         (WTR):
629         (WTR::TestInvocation::invoke):
630         * WebKitTestRunner/TestInvocation.h:
631         (TestInvocation):
632
633 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
634
635         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
636         https://bugs.webkit.org/show_bug.cgi?id=106290
637
638         Reviewed by Martin Robinson.
639
640         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
641         the macro isn't enabled.
642
643         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
644
645 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
646
647         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
648         https://bugs.webkit.org/show_bug.cgi?id=103653
649
650         Reviewed by Anders Carlsson.
651
652         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
653         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
654         client callback.
655
656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
657         methods to the JavaScript API.
658         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
659         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
660         (WTR::TestRunner::setAuthenticationUsername): Ditto.
661         (WTR::TestRunner::setAuthenticationPassword): Ditto.
662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
663         (TestRunner): Added new declarations for the above.
664         * WebKitTestRunner/TestController.cpp:
665         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
666         callback.
667         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
668         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
669         the authentication information passed from the InjectedBundle.
670         * WebKitTestRunner/TestController.h:
671         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
672         to communicate with the TestController.
673         (WTR::TestController::setAuthenticationUsername): Ditto.
674         (WTR::TestController::setAuthenticationPassword): Ditto.
675         (TestController):
676         * WebKitTestRunner/TestInvocation.cpp:
677         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
678         information from the InjectedBundle.
679         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
680         text to the TestInvocation text output.
681         * WebKitTestRunner/TestInvocation.h:
682         (TestInvocation): Added declaration for new method.
683
684 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
685
686         Add myself as a watcher for Web Geolocation
687
688         Unreviewed.
689
690         * Scripts/webkitpy/common/config/watchlist:
691
692 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
693
694         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
695         https://bugs.webkit.org/show_bug.cgi?id=106364
696
697         Reviewed by Eric Seidel.
698
699         When the setup_test_run method is called on the subclasses of the base Port
700         interface, the parent method should also be called via super(), despite the
701         parent method not doing anything at the moment.
702
703         The according calls to super() are required in the ChromiumPort, EflPort
704         and GtkPort implementations.
705
706         * Scripts/webkitpy/layout_tests/port/chromium.py:
707         (ChromiumPort.setup_test_run):
708         * Scripts/webkitpy/layout_tests/port/efl.py:
709         (EflPort.setup_test_run):
710         * Scripts/webkitpy/layout_tests/port/gtk.py:
711         (GtkPort.setup_test_run):
712
713 2013-01-08  Julie Parent  <jparent@chromium.org>
714
715         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
716         https://bugs.webkit.org/show_bug.cgi?id=106356
717
718         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
719         dashboard_base, assigned by Loader, and used only by dashboard_base to
720         create error messages.  Moved the variables to be privates on the Loader
721         object, moved error message creation to _getLoadingErrorMessages on the
722         Loader object, and now pass the errors back to dashboard base via the
723         resourceLoadingComplete callback.
724         
725         Also removed the now unused clearError function, it was only being used
726         by unit tests to clean up global state.
727         
728         Reviewed by Dirk Pranke.
729
730         * TestResultServer/static-dashboards/dashboard_base.js:
731         (resourceLoadingComplete):
732         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
733         * TestResultServer/static-dashboards/loader.js:
734         (.):
735         * TestResultServer/static-dashboards/loader_unittests.js:
736
737 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
738
739         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
740         https://bugs.webkit.org/show_bug.cgi?id=106354
741
742         Reviewed by Eric Seidel.
743
744         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
745         instead of those two inheriting from it. Also add a mock object of the
746         sanitizer that's used in unit tests.
747
748         * Scripts/webkitpy/layout_tests/port/efl.py:
749         (EflPort):
750         (EflPort.__init__):
751         (EflPort.setup_test_run):
752         (EflPort.clean_up_test_run):
753         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
754         importing order.
755         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
756         * Scripts/webkitpy/layout_tests/port/gtk.py:
757         (GtkPort):
758         (GtkPort.__init__):
759         (GtkPort.setup_test_run):
760         (GtkPort.clean_up_test_run):
761         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
762         importing order.
763         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
764         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
765         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
766         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
767         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
768         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
769         (PulseAudioSanitizerMock.unload_pulseaudio_module):
770         (PulseAudioSanitizerMock.restore_pulseaudio_module):
771
772 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
773
774         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
775         https://bugs.webkit.org/show_bug.cgi?id=106324
776
777         Reviewed by Adam Barth.
778
779         Since the frame load callbacks are part of the WebFrameClient, the
780         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
781         methods.
782
783         * DumpRenderTree/chromium/DRTTestRunner.cpp:
784         (DRTTestRunner::DRTTestRunner):
785         (DRTTestRunner::reset):
786         * DumpRenderTree/chromium/DRTTestRunner.h:
787         (DRTTestRunner):
788         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
789         (WebTestInterfaces):
790         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
791         (WebKit):
792         (WebTestProxyBase):
793         (WebTestRunner):
794         (WebTestRunner::WebTestProxy::WebTestProxy):
795         (WebTestProxy):
796         (WebTestRunner::WebTestProxy::didInvalidateRect):
797         (WebTestRunner::WebTestProxy::didScrollRect):
798         (WebTestRunner::WebTestProxy::scheduleComposite):
799         (WebTestRunner::WebTestProxy::scheduleAnimation):
800         (WebTestRunner::WebTestProxy::setWindowRect):
801         (WebTestRunner::WebTestProxy::show):
802         (WebTestRunner::WebTestProxy::didAutoResize):
803         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
804         (WebTestRunner::WebTestProxy::startDragging):
805         (WebTestRunner::WebTestProxy::shouldBeginEditing):
806         (WebTestRunner::WebTestProxy::shouldEndEditing):
807         (WebTestRunner::WebTestProxy::shouldInsertNode):
808         (WebTestRunner::WebTestProxy::shouldInsertText):
809         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
810         (WebTestRunner::WebTestProxy::shouldDeleteRange):
811         (WebTestRunner::WebTestProxy::shouldApplyStyle):
812         (WebTestRunner::WebTestProxy::didBeginEditing):
813         (WebTestRunner::WebTestProxy::didChangeSelection):
814         (WebTestRunner::WebTestProxy::didChangeContents):
815         (WebTestRunner::WebTestProxy::didEndEditing):
816         (WebTestRunner::WebTestProxy::registerIntentService):
817         (WebTestRunner::WebTestProxy::dispatchIntent):
818         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
819         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
820         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
821         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
822         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
823         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
824         (WebTestRunner::WebTestProxy::didReceiveTitle):
825         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
826         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
827         (WebTestRunner::WebTestProxy::didFailLoad):
828         (WebTestRunner::WebTestProxy::didFinishLoad):
829         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
830         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
831         (WebTestRunner::WebTestProxy::didRunInsecureContent):
832         (WebTestRunner::WebTestProxy::didDetectXSS):
833         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
834         (WebTestRunner::WebTestRunner::setTestIsRunning):
835         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
836         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
837         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
838         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
839         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
840         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
841         (WebTestRunner::TestRunner::TestRunner):
842         (WebTestRunner::TestRunner::reset):
843         (WebTestRunner::TestRunner::setTestIsRunning):
844         (WebTestRunner):
845         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
846         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
847         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
848         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
849         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
850         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
851         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
852         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
853         (WebTestRunner::TestRunner::dumpTitleChanges):
854         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
855         (TestRunner):
856         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
857         (WebTestInterfaces::Internal):
858         (WebTestRunner::WebTestInterfaces::Internal::webView):
859         (WebTestRunner::WebTestInterfaces::Internal::Internal):
860         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
861         (WebTestRunner):
862         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
863         (WebTestRunner::WebTestInterfaces::setWebView):
864         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
865         (WebTestRunner::WebTestInterfaces::webView):
866         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
867         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
868         (WebTestRunner):
869         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
870         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
871         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
872         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
873         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
874         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
875         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
876         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
877         (WebTestRunner::WebTestProxyBase::didFailLoad):
878         (WebTestRunner::WebTestProxyBase::didFinishLoad):
879         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
880         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
881         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
882         (WebTestRunner::WebTestProxyBase::didDetectXSS):
883         * DumpRenderTree/chromium/TestShell.cpp:
884         (TestShell::runFileTest):
885         (TestShell::testFinished):
886         * DumpRenderTree/chromium/TestShell.h:
887         (TestShell):
888         * DumpRenderTree/chromium/WebViewHost.cpp:
889         (WebViewHost::didStartProvisionalLoad):
890         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
891         (WebViewHost::didFailProvisionalLoad):
892         (WebViewHost::didCommitProvisionalLoad):
893         (WebViewHost::didReceiveTitle):
894         (WebViewHost::didFailLoad):
895         (WebViewHost::didFinishLoad):
896         * DumpRenderTree/chromium/WebViewHost.h:
897         (WebViewHost):
898
899 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
900
901         [GTK] Lower the default timeout value for WebKitTestRunner
902         https://bugs.webkit.org/show_bug.cgi?id=106353
903
904         Reviewed by Dirk Pranke.
905
906         The default timeout value for WebKitTestRunner should be lowered.
907         The current value (80 seconds) is irrational and just leads to producing
908         text failures for layout tests that genuinely time out. This just leads
909         to more deviation from the GTK WK1 port in terms of test expectations.
910
911         The value used is the same as when running the DumpRenderTree, that's
912         6 seconds in release builds and 12 seconds in debug builds.
913
914         * Scripts/webkitpy/layout_tests/port/gtk.py:
915         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
916         (GtkPortTest.test_default_timeout_ms):
917
918 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
919
920         test-webkitpy shows failure output on my linux box
921         https://bugs.webkit.org/show_bug.cgi?id=101261
922
923         Reviewed by Eric Seidel.
924
925         Mock out the PulseAudioSanitizer methods when creating testing instances
926         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
927         PulseAudio output when the sanitizer was trying to unload modules which
928         were already unloaded by another unit test that was being run in parallel.
929
930         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
931         (EflPortTest):
932         (EflPortTest.make_port):
933         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
934         (GtkPortTest):
935         (GtkPortTest.make_port):
936
937 2013-01-08  Julie Parent  <jparent@chromium.org>
938
939         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
940         https://bugs.webkit.org/show_bug.cgi?id=106254
941
942         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
943         only to figure out if we should call addBuilderLoadErrors during
944         handleLocationChange, which was called when the loader completed and on
945         any hash change, but we only ever wanted to call addBuilderLoadErrors
946         on the initial loader load.  Moved the call of addBuilderLoadErrors to
947         resourceLoadingComplete rather than handleLocationChange, so now we
948         only call it when we want to, and the check can go away completely.
949
950         Reviewed by Dirk Pranke.
951
952         * TestResultServer/static-dashboards/dashboard_base.js:
953         (addBuilderLoadErrors):
954         (resourceLoadingComplete):
955         (handleLocationChange):
956         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
957
958 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
959
960         Add aboxhall@chromium.org to accessibility watchlist.
961
962         Unreviewed.
963
964         * Scripts/webkitpy/common/config/watchlist:
965
966 2013-01-08  Dan Winship  <danw@gnome.org>
967
968         Add Apache 2.4 support for Fedora 18
969         https://bugs.webkit.org/show_bug.cgi?id=104478
970
971         Reviewed by Martin Robinson.
972
973         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
974         need a separate config.
975
976         * Scripts/webkitpy/layout_tests/port/base.py:
977         (Port._apache_version):
978         (Port._apache_config_file_name_for_platform):
979         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
980         * Scripts/run-webkit-httpd:
981         * Scripts/webkitperl/httpd.pm:
982         (getApacheVersion):
983         (getDefaultConfigForTestDirectory):
984         (getHTTPDConfigPathForTestDirectory):
985
986 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
987
988         Make the override-feature-defines script compatible with Python v3
989         https://bugs.webkit.org/show_bug.cgi?id=105742
990
991         Reviewed by Martin Robinson.
992
993         Instead of printing output through a statement, use the print function and format
994         the output using the str.format method. This makes the script runnable with Python v3.
995
996         * gtk/override-feature-defines:
997         (adjust_feature_defines_makefile):
998
999 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1000
1001         [Qt] Fix libxml2 config test
1002         https://bugs.webkit.org/show_bug.cgi?id=106317
1003
1004         Reviewed by Simon Hausmann.
1005
1006         Don't assume standard include/libxml2, libxml-2.0.pc should know
1007         where it's headers are.
1008
1009         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1010
1011 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1012
1013         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1014         https://bugs.webkit.org/show_bug.cgi?id=106195
1015
1016         Reviewed by Philippe Normand.
1017
1018         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1019         to make the Python code compatible with Python 3. This includes modifying
1020         print statements, exception handling, dictionary iteration and
1021         byte-sequence-to-string conversion.
1022
1023         * gtk/common.py:
1024         (get_build_path):
1025         (pkg_config_file_variable):
1026         (gtk_version_of_pkg_config_file):
1027         * gtk/generate-gtkdoc:
1028         (print_missing_api):
1029         * gtk/gtkdoc.py:
1030         (GTKDoc.__init__):
1031         (GTKDoc._run_command):
1032
1033 2013-01-02  Steve Block  <steveblock@chromium.org>
1034
1035         Add chromium.org email address for Steve Block.
1036
1037         Unreviewed.
1038
1039         * Scripts/webkitpy/common/config/committers.py:
1040
1041 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1042
1043         Rationalize closure call heuristics and profiling
1044         https://bugs.webkit.org/show_bug.cgi?id=106270
1045
1046         Reviewed by Oliver Hunt.
1047         
1048         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1049         all generated code ('display *' or 'd *').
1050
1051         * Scripts/display-profiler-output:
1052
1053 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1054
1055         Sorted more xcodeproj files.
1056
1057         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1059         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1060
1061 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1062
1063         Sorted xcodeproj files.
1064
1065         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1066         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1067
1068 2013-01-07  Dan Bernstein  <mitz@apple.com>
1069
1070         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1071         https://bugs.webkit.org/show_bug.cgi?id=106261
1072
1073         Reviewed by Simon Fraser.
1074
1075         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1076
1077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1078         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1079         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1080         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1081         (TestWebKitAPI):
1082         (TestWebKitAPI::TEST):
1083
1084 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1085
1086         Add the Apple MountainLion bots to garden-o-matic.
1087         Eventually, we really should move away from hardcoding
1088         the list of bots.
1089
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1091
1092 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1093
1094         [chromium] move web audio related methods to testrunner library
1095         https://bugs.webkit.org/show_bug.cgi?id=106211
1096
1097         Reviewed by Adam Barth.
1098
1099         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1100         (DRTTestRunner::DRTTestRunner):
1101         (DRTTestRunner::reset):
1102         * DumpRenderTree/chromium/DRTTestRunner.h:
1103         (DRTTestRunner):
1104         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1105         (WebKit):
1106         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1107         (WebTestRunner::WebTestRunner::audioData):
1108         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1109         (WebTestRunner::TestRunner::TestRunner):
1110         (WebTestRunner::TestRunner::reset):
1111         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1112         (WebTestRunner):
1113         (WebTestRunner::TestRunner::audioData):
1114         (WebTestRunner::TestRunner::setAudioData):
1115         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1116         (TestRunner):
1117         * DumpRenderTree/chromium/TestShell.cpp:
1118         (TestShell::dump):
1119
1120 2013-01-07  Mike West  <mkwst@chromium.org>
1121
1122         Make the IFRAME_SEAMLESS flag runtime-enabled.
1123         https://bugs.webkit.org/show_bug.cgi?id=106213
1124
1125         Reviewed by Ojan Vafai.
1126
1127         * DumpRenderTree/chromium/TestShell.cpp:
1128         (TestShell::TestShell):
1129         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1130         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1131         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1132         (resetDefaultsToConsistentValues):
1133         * DumpRenderTree/mac/DumpRenderTree.mm:
1134         (resetDefaultsToConsistentValues):
1135         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1136         (WebCore::WebPage::resetSettings):
1137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1138         (WTR::InjectedBundle::beginTesting):
1139             Ensure that seamless IFrames are enabled for layout tests in each of
1140             the ports that support seamless IFrames.
1141
1142 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1143
1144         [chromium] move dumpAsText and friends to the TestRunner library
1145         https://bugs.webkit.org/show_bug.cgi?id=106222
1146
1147         Reviewed by Adam Barth.
1148
1149         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1150
1151         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1152         (DRTTestRunner::DRTTestRunner):
1153         (DRTTestRunner::reset):
1154         * DumpRenderTree/chromium/DRTTestRunner.h:
1155         (DRTTestRunner):
1156         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1157         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1158         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1159         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1160         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1161         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1162         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1163         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1164         (WebTestRunner::TestRunner::TestRunner):
1165         (WebTestRunner::TestRunner::reset):
1166         (WebTestRunner::TestRunner::shouldDumpAsText):
1167         (WebTestRunner):
1168         (WebTestRunner::TestRunner::setShouldDumpAsText):
1169         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1170         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1171         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1172         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1173         (WebTestRunner::TestRunner::dumpAsText):
1174         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1175         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1176         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1177         (TestRunner):
1178
1179 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1180
1181         Build fix attempt after r138810.
1182
1183         Apparently python 2.6 is really bad at floating point computation.
1184
1185         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1186         (MainTest.test_run_memory_test):
1187
1188 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1189
1190         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1191         https://bugs.webkit.org/show_bug.cgi?id=106172
1192
1193         Reviewed by Tony Chang.
1194
1195         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1196         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1197         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1198         test on perf-o-matic and perf. test's results page.
1199
1200         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1201
1202         * Scripts/webkitpy/performance_tests/perftest.py:
1203         (PerfTestMetric): Added.
1204         (PerfTestMetric.__init__): Added.
1205         (PerfTestMetric.metric): Added.
1206         (PerfTestMetric.has_values): Added.
1207         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1208         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1209         conversions to be done on the client side (perf-o-matic and results page).
1210         (PerfTestMetric.append): Added.
1211         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1212         a result for this metric.
1213         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1214         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1215
1216         (PerfTest._create_driver): Extracted from PerfTest.run.
1217         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1218         as needed.
1219         (PerfTest._run_with_driver):
1220         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1221         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1222         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1223
1224         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1225         from other perf tests, there isn't much point in sharing the code here.
1226
1227         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1228         statistics for the measured values.
1229
1230         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1231         (TestPerfTestMetric): Added.
1232         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1233         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1234         (TestPerfTestMetric.test_has_values): Added.
1235         (TestPerfTestMetric.test_append): Added.
1236         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1237         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1238
1239         (TestPerfTest._assert_results_are_correct): Updated as needed.
1240         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1241         in PerfTest.run now after generating the results dictionary.
1242         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1243
1244 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1245
1246         Support size_t multiplication and division operators on LayoutUnit
1247         https://bugs.webkit.org/show_bug.cgi?id=83848
1248
1249         Reviewed by Emil A Eklund.
1250
1251         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1252         Added some simple tests for the new operators using size_t.
1253
1254 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1255
1256         [Qt] run-webkit-tests cleanup for parallel NRWT
1257         https://bugs.webkit.org/show_bug.cgi?id=106220
1258
1259         Reviewed by Dirk Pranke.
1260
1261         * Scripts/run-webkit-tests:
1262         (useNewRunWebKitTests):
1263         * Scripts/webkitpy/layout_tests/port/qt.py:
1264         (QtPort):
1265         (QtPort.default_child_processes):
1266
1267 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1268
1269         Create a GStreamerAudio watchlist and add myself to it.
1270
1271         Unreviewed.
1272
1273         * Scripts/webkitpy/common/config/watchlist:
1274
1275 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1276
1277         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1278         Also removed the empty mac directory.
1279
1280         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1281         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1282         * BuildSlaveSupport/mac: Removed.
1283         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1284
1285 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1286
1287         Add a script to delete stale zero-byte build files
1288         https://bugs.webkit.org/show_bug.cgi?id=106131
1289
1290         Reviewed by Tony Chang.
1291
1292         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1293
1294         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1295         (DeleteStaleBuildFiles): Added.
1296         (Factory.__init__): Add DeleteStaleBuildFiles step.
1297         * BuildSlaveSupport/delete-stale-build-files: Added.
1298         (main): Delete zero-byte files except ones intentionally generated by our build process.
1299         (webkitBuildDirectory): Copied from build-product-archive.
1300
1301 2013-01-04  Michael Pruett  <michael@68k.org>
1302
1303         [GTK] Fix build error on GTK due to r138836
1304         https://bugs.webkit.org/show_bug.cgi?id=106154
1305
1306         Reviewed by Kentaro Hara.
1307
1308         * GNUmakefile.am:
1309
1310 2013-01-04  Dan Bernstein  <mitz@apple.com>
1311
1312         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1313         https://bugs.webkit.org/show_bug.cgi?id=106121
1314
1315         Reviewed by Adele Peterson.
1316
1317         Added test for -[DOMTHMLTableCellElement _cellAbove].
1318
1319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1320         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1321         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1322         (TestWebKitAPI):
1323         (TestWebKitAPI::expectCellAboveCell):
1324         (TestWebKitAPI::TEST):
1325         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1326
1327 2013-01-04  Eric Seidel  <eric@webkit.org>
1328
1329         FlakyTestReporter should be re-enabled and taught how to post patches
1330         https://bugs.webkit.org/show_bug.cgi?id=103839
1331
1332         Reviewed by Adam Barth.
1333
1334         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1335         It also adds a real Port object to the EWS and CommitQueue objects
1336         using a new PatchProcessingQueue superclass.
1337         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1338         but works for this purpose.
1339         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1340         to resolve a FIXME.
1341
1342         This required some hacks/shiming between the non-specific "old"
1343         port names which the EWS system is currently using, and the new
1344         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1345
1346         Hopefully this will fix the flaky test reporter and results uploading.
1347         Certainly it's another small step towards getting rid of the old ports.py
1348         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1349
1350         Now that DeprecatedPort is no longer used for the results directory
1351         I removed all the explicit results-dir code which webkit-patch was using
1352         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1353
1354         * Scripts/webkitpy/common/config/ports.py:
1355         (DeprecatedPort.run_perl_unittests_command):
1356         * Scripts/webkitpy/common/config/ports_mock.py:
1357         (MockPort.name):
1358         * Scripts/webkitpy/common/system/outputcapture.py:
1359         (OutputCapture.assert_outputs):
1360         * Scripts/webkitpy/layout_tests/port/apple.py:
1361         (ApplePort.determine_full_port_name):
1362         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1363         (LayoutTestResultsReader.__init__):
1364         (LayoutTestResultsReader):
1365         (LayoutTestResultsReader._read_file_contents):
1366         (LayoutTestResultsReader._create_layout_test_results):
1367         (LayoutTestResultsReader._create_unit_test_results):
1368         (LayoutTestResultsReader.results):
1369         (LayoutTestResultsReader.archive):
1370         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1371         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1372         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1373         (test_missing_unit_test_results_path):
1374         (test_layout_test_results):
1375         (test_archive_last_layout_test_results):
1376         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1377         (AbstractEarlyWarningSystem):
1378         (AbstractEarlyWarningSystem.__init__):
1379         (AbstractEarlyWarningSystem.begin_work_queue):
1380         (AbstractEarlyWarningSystem.run_command):
1381         * Scripts/webkitpy/tool/commands/queues.py:
1382         (AbstractPatchQueue.work_item_log_path):
1383         (PatchProcessingQueue):
1384         (PatchProcessingQueue._new_port_name_from_old):
1385         (PatchProcessingQueue.begin_work_queue):
1386         (PatchProcessingQueue._upload_results_archive_for_patch):
1387         (CommitQueue):
1388         (CommitQueue.begin_work_queue):
1389         (CommitQueue.run_command):
1390         (AbstractReviewQueue):
1391         (AbstractReviewQueue.__init__):
1392         (AbstractReviewQueue.begin_work_queue):
1393         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1394         (AbstractPatchQueueTest.test_next_patch):
1395         (PatchProcessingQueueTest):
1396         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1397         * Scripts/webkitpy/tool/steps/runtests.py:
1398         (RunTests.run):
1399         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1400
1401 2013-01-04  Dana Jansens  <danakj@chromium.org>
1402
1403         [chromium] Remove lost-compositor-context layout tests
1404         https://bugs.webkit.org/show_bug.cgi?id=106089
1405
1406         Reviewed by James Robinson.
1407
1408         Remove the loseCompositorContext() test function.
1409
1410         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1411         (WebTestRunner::TestRunner::TestRunner):
1412         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1413         (TestRunner):
1414
1415 2013-01-04  Adam Klein  <adamk@chromium.org>
1416
1417         Remove ENABLE_MUTATION_OBSERVERS #define
1418         https://bugs.webkit.org/show_bug.cgi?id=105459
1419
1420         Reviewed by Ryosuke Niwa.
1421
1422         * Scripts/webkitperl/FeatureList.pm:
1423         * qmake/mkspecs/features/features.pri:
1424
1425 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1426
1427         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1428         https://bugs.webkit.org/show_bug.cgi?id=106078
1429
1430         Reviewed by Tony Chang.
1431
1432         This patch updates values for individual iterations in dummy performance tests used in
1433         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1434         statistics such as stdev and median reported in those tests. This change is required
1435         to resolve the bug 97510.
1436
1437         This patch also refactors integration tests by extracting *TestData classes that
1438         centralizes the definitions of each dummy performance test's text (DRT output),
1439         runner output, and parsed results (JSON) so that we may share more data between
1440         python tests.
1441
1442         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1443         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1444         Use self.assertAlmostEqual when comparing the standard deviation.
1445         (MainTest.test_parse_output):
1446         (test_parse_output_with_failing_line):
1447         (test_parse_output_with_description): Use _assert_results_are_correct.
1448         (test_parse_output_with_subtests): Ditto.
1449
1450         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1451         (InspectorPassTestData): Extracted from tests below.
1452         (EventTargetWrapperTestData): Ditto.
1453         (SomeParserTestData): Ditto.
1454         (MemoryTestData): Ditto.
1455         (TestDriver.run_test): Moved test definitions out of the method.
1456         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1457         (MainTest._load_output_json): Extracted from create_runner.
1458         (MainTest.create_runner):
1459         (MainTest.test_run_test_set_for_parser_tests):
1460         (MainTest.test_run_memory_test):
1461         (MainTest._test_run_with_json_output):
1462         (MainTest.test_run_with_json_output):
1463         (MainTest.test_run_with_description):
1464         (MainTest.test_run_generates_json_by_default):
1465         (MainTest.test_run_merges_output_by_default):
1466         (MainTest.test_run_respects_reset_results):
1467         (MainTest.test_run_generates_and_show_results_page):
1468         (MainTest.test_run_with_slave_config_json):
1469         (MainTest.test_run_with_multiple_repositories):
1470
1471 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1472
1473         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1474         https://bugs.webkit.org/show_bug.cgi?id=106045
1475
1476         Reviewed by Carlos Garcia Campos.
1477
1478         Update test results to confirm that compositions without preedits do not trigger
1479         a composition confirmation.
1480
1481         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1482         (TestWebKitAPI::verifyCanceledComposition):
1483
1484 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1485
1486         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1487         https://bugs.webkit.org/show_bug.cgi?id=105958
1488
1489         Reviewed by Alexey Proskuryakov.
1490
1491         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1492
1493         * WebKitTestRunner/mac/EventSenderProxy.mm:
1494         (KeyMappingEntry):
1495         (WTR):
1496         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1497
1498 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1499
1500         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1501         https://bugs.webkit.org/show_bug.cgi?id=106073
1502
1503         Reviewed by Ryosuke Niwa.
1504
1505         Check that the element being compared to is not nil. 
1506         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1507         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1508         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
1509         sometimes before on parallel WebKitTestRunner runs.
1510
1511         * DumpRenderTree/AccessibilityUIElement.cpp:
1512         (AccessibilityUIElement::isEqual):
1513         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1514         (WTR::AccessibilityUIElement::isEqual):
1515
1516 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1517
1518         Downloads can be flaky, so try downloading multiple times.
1519         https://bugs.webkit.org/show_bug.cgi?id=105976
1520
1521         Reviewed by Eric Seidel.
1522
1523         * Scripts/webkitpy/common/system/autoinstall.py:
1524         (AutoInstaller._download_to_stream):
1525
1526 2013-01-03  Eric Seidel  <eric@webkit.org>
1527
1528         Rename Tool.port to deprecated_port in preparation for removing more callers
1529         https://bugs.webkit.org/show_bug.cgi?id=106076
1530
1531         Reviewed by Ryosuke Niwa.
1532
1533         This resolves a long-standing FIXME to rename this method. :)
1534
1535         * Scripts/webkitpy/tool/bot/botinfo.py:
1536         (BotInfo.summary_text):
1537         * Scripts/webkitpy/tool/bot/irc_command.py:
1538         (Rollout._update_working_copy):
1539         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1540         (LayoutTestResultsReader._create_layout_test_results):
1541         (LayoutTestResultsReader._create_unit_test_results):
1542         (LayoutTestResultsReader._results_directory):
1543         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1544         (test_missing_unit_test_results_path):
1545         * Scripts/webkitpy/tool/main.py:
1546         (WebKitPatch.deprecated_port):
1547         * Scripts/webkitpy/tool/mocktool.py:
1548         (MockTool.deprecated_port):
1549         * Scripts/webkitpy/tool/steps/build.py:
1550         (Build.build):
1551         * Scripts/webkitpy/tool/steps/checkstyle.py:
1552         (CheckStyle.run):
1553         * Scripts/webkitpy/tool/steps/commit.py:
1554         (Commit._check_test_expectations):
1555         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1556         (PrepareChangeLog.run):
1557         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1558         (PrepareChangeLogForDEPSRoll.run):
1559         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1560         (PrepareChangeLogForRevert.run):
1561         * Scripts/webkitpy/tool/steps/runtests.py:
1562         (RunTests.run):
1563         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1564         (StepsTest.test_runtests_args):
1565         * Scripts/webkitpy/tool/steps/update.py:
1566         (Update._update_command):
1567
1568 2013-01-03  Eric Seidel  <eric@webkit.org>
1569
1570         Add myself to the webkitpy watchlist.
1571
1572         Unreviewed.
1573
1574         * Scripts/webkitpy/common/config/watchlist:
1575
1576 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1577
1578         Cleanup perftest* tests and add a test for computing statistics
1579         https://bugs.webkit.org/show_bug.cgi?id=105685
1580
1581         Reviewed by Eric Seidel.
1582
1583         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1584         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1585
1586         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1587
1588         * Scripts/webkitpy/performance_tests/perftest.py:
1589         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1590         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1591         accurate result for the mean.
1592         (PageLoadingPerfTest.run_single):
1593         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1594         (MainTest.test_compute_statistics):
1595         (MainTest.test_compute_statistics.compute_statistics): Added.
1596         (TestPageLoadingPerfTest.test_run): floatify values.
1597         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1598         correctly recognizes them as integers.
1599
1600         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1601         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1602         (TestDriver): Moved out of MainTest.
1603         (MainTest): Got rid of assertWritten and all unit tests.
1604         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1605         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1606         (MainTest.test_run_test_set_for_parser_tests):
1607         (MainTest.test_run_memory_test):
1608         (MainTest._test_run_with_json_output):
1609         (MainTest.test_run_generates_json_by_default):
1610         (MainTest.test_run_merges_output_by_default):
1611         (MainTest.test_run_respects_reset_results):
1612         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1613         parsing output JSON files. Just verify that the output path is correct instead.
1614         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1615         (MainTest): Removed all integration tests.
1616         (MainTest.create_runner): Simplified.
1617
1618 2013-01-03  Julie Parent  <jparent@chromium.org>
1619
1620         Dashboard cleanup: remove usage of global g_defaultBuilderName
1621         https://bugs.webkit.org/show_bug.cgi?id=106043
1622
1623         Use now public defaultBuilder() from the BuilderGroup, rather
1624         than global variable.
1625
1626         Also eliminates the setup() and initBuilders() functions since we
1627         no longer need to track the global.
1628
1629         Reviewed by Adam Barth.
1630
1631         * TestResultServer/static-dashboards/builders.js:
1632         (BuilderGroup.prototype.defaultBuilder):
1633         (BuilderGroup.prototype.master):
1634         * TestResultServer/static-dashboards/dashboard_base.js:
1635         (parseParameters):
1636         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1637         (updateDefaultBuilderState):
1638         * TestResultServer/static-dashboards/loader.js:
1639         (.):
1640         * TestResultServer/static-dashboards/loader_unittests.js:
1641
1642 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1643
1644         Disable an intermittently failing unit test for now.
1645         The failure is tracked by the bug 106051.
1646
1647         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1648         (TestWebKitAPI::TEST):
1649
1650 2013-01-03  Dan Bernstein  <mitz@apple.com>
1651
1652         No way to obtain a DOMNode given a JS wrapper for a Node
1653         https://bugs.webkit.org/show_bug.cgi?id=106033
1654
1655         Added a test for +[DOMNode _nodeFromJSWrapper:].
1656
1657         Reviewed by Sam Weinig.
1658
1659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1660         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1661         (TestWebKitAPI):
1662         (TestWebKitAPI::TEST):
1663
1664 2013-01-03  Emil A Eklund  <eae@chromium.org>
1665
1666         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1667         https://bugs.webkit.org/show_bug.cgi?id=105961
1668
1669         Reviewed by Levi Weintraub.
1670         
1671         Add tests for LayoutUnit::ceil and floor.
1672
1673         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1674         (TestWebKitAPI::TEST):
1675         (TestWebKitAPI):
1676
1677 2013-01-03  Julie Parent  <jparent@chromium.org>
1678
1679         Add unit test for default builder for the dashboards.
1680         https://bugs.webkit.org/show_bug.cgi?id=105972
1681
1682         Reviewed by Dirk Pranke.
1683
1684         * TestResultServer/static-dashboards/loader_unittests.js:
1685
1686 2013-01-03  Tony Chang  <tony@chromium.org>
1687
1688         Generate internal.settings from Settings.in
1689         https://bugs.webkit.org/show_bug.cgi?id=104740
1690
1691         Reviewed by Adam Barth.
1692
1693         * GNUmakefile.am: Compile new generated files on GTK+.
1694         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1695         with both extra_sources and add_output_to_sources=false will still
1696         compile the files in extra_sources. This makes it possible to compile
1697         InternalSettingsGenerated.cpp and not be confused by
1698         InternalSettingsGenerated.idl.
1699
1700 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1701
1702         [style] WebIDL-reflecting uppercase enums reported as style violation
1703         https://bugs.webkit.org/show_bug.cgi?id=105832
1704
1705         Reviewed by Tony Chang.
1706
1707         Recognize the enum as WebIDL-reflecting one if there's a comment present that
1708         indicates this. In enums spanning over multiple lines, the comment is expected
1709         on the first line. In enums placed in one line, the comment is expected at the
1710         end of that line.
1711
1712         WebIDL-reflecting enum values are required to be written in uppercase and as such
1713         violate the common rule of these values being written in InterCaps. Annotating
1714         enums this way makes it possible to avoid false style violation reports.
1715
1716         The comment is of form '// Web(?:Kit)?IDL enum'.
1717
1718         * Scripts/webkitpy/style/checkers/cpp.py:
1719         (_EnumState.__init__):
1720         (_EnumState.process_clean_line):
1721         (check_enum_casing):
1722         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1723         (NoNonVirtualDestructorsTest.test_enum_casing):
1724
1725 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1726
1727         Adding favicon.ico to the garden-o-matic.
1728         https://bugs.webkit.org/show_bug.cgi?id=105982
1729
1730         Reviewed by Adam Barth.
1731
1732         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1734
1735 2013-01-03  Jonathan Liu  <net147@gmail.com>
1736
1737         [Qt] Fix library linking order
1738         https://bugs.webkit.org/show_bug.cgi?id=105818
1739
1740         Some Qt libraries are linked before the private static libraries
1741         that depend on them which results in QtWebKit failing to link.
1742
1743         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1744         module to ensure the Qt libraries are linked after the private
1745         static libraries that depend on them.
1746
1747         Reviewed by Tor Arne Vestbø.
1748
1749         * qmake/mkspecs/features/default_post.prf:
1750
1751 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1752
1753         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1754         https://bugs.webkit.org/show_bug.cgi?id=102209
1755
1756         Reviewed by Gyuyoung Kim.
1757
1758         Set tooltip on the elm_window instead of ewk_view, and add delay to
1759         show the tooltip window.
1760
1761         Setting tooltip on the ewk_view makes elementary error message because
1762         ewk_view is not an elementary widget. To remove the error message,
1763         tooltip should be set on the elm_window.
1764
1765         Most browsers show the tooltip after a mouse pointer stays on an
1766         element object that has tooltip text.
1767         But elm_tooltip widget itself doesn't have delay or handle mouse
1768         events to show/hide.
1769
1770         So additional codes are added to show/hide tooltip widget along with
1771         mouse events.
1772           1) When a mouse pointer stays for a second on an element which has
1773              tooltip text, then tooltip widget is displayed.
1774           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1775              widget.
1776
1777         * MiniBrowser/efl/main.c:
1778         (_Tooltip_Information):
1779         (_Browser_Window):
1780         (on_tooltip_show):
1781         (window_tooltip_hide):
1782         (window_tooltip_update):
1783         (on_mouse_in):
1784         (on_mouse_move):
1785         (on_mouse_out):
1786         (window_free):
1787         (on_tooltip_text_set):
1788         (on_tooltip_text_unset):
1789         (window_create):
1790
1791 2013-01-02  Tony Chang  <tony@chromium.org>
1792
1793         Unreviewed, rolling out r138661.
1794         http://trac.webkit.org/changeset/138661
1795         https://bugs.webkit.org/show_bug.cgi?id=104740
1796
1797         Compile problems on EFL
1798
1799         * GNUmakefile.am:
1800         * qmake/mkspecs/features/default_post.prf:
1801
1802 2013-01-02  Tony Chang  <tony@chromium.org>
1803
1804         Generate internal.settings from Settings.in
1805         https://bugs.webkit.org/show_bug.cgi?id=104740
1806
1807         Reviewed by Adam Barth.
1808
1809         * GNUmakefile.am: Compile new generated files on GTK+.
1810         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1811         with both extra_sources and add_output_to_sources=false will still
1812         compile the files in extra_sources. This makes it possible to compile
1813         InternalSettingsGenerated.cpp and not be confused by
1814         InternalSettingsGenerated.idl.
1815
1816 2013-01-02  Adam Barth  <abarth@webkit.org>
1817
1818         Remove old-run-webkit-tests support from webkitpy
1819         https://bugs.webkit.org/show_bug.cgi?id=105619
1820
1821         Reviewed by Eric Seidel.
1822
1823         This patch removes support for webkitpy parsing the
1824         old-run-webkit-tests results format. There doesn't seem to be any
1825         reason to keep this code around anymore now that most bots have
1826         switched to new-run-webkit-tests.
1827
1828         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1829         (Builder.fetch_layout_test_results):
1830         * Scripts/webkitpy/common/net/layouttestresults.py:
1831         (path_for_layout_test):
1832         (LayoutTestResults.results_from_string):
1833         (LayoutTestResults):
1834         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1835         (LayoutTestResultsTest.test_results_from_string):
1836         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1837         (test_flaky_test_failure):
1838         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1839         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1840         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1841         (PatchAnalysisTask._test_patch):
1842         * Scripts/webkitpy/tool/commands/queuestest.py:
1843         (QueuesTest.assert_queue_outputs):
1844
1845 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
1846
1847         [Qt][WK2] Add simple UI to find text from page
1848         https://bugs.webkit.org/show_bug.cgi?id=96481
1849
1850         Reviewed by Jocelyn Turcotte.
1851
1852         Find bar that slides between navigation bar and WebView.
1853
1854         * MiniBrowser/qt/BrowserWindow.cpp:
1855         (BrowserWindow::toggleFind):
1856         * MiniBrowser/qt/BrowserWindow.h:
1857         (BrowserWindow):
1858         * MiniBrowser/qt/MiniBrowser.qrc:
1859         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1860         (MiniBrowserApplication::notify):
1861         * MiniBrowser/qt/icons/find.png: Added.
1862         * MiniBrowser/qt/qml/BrowserWindow.qml:
1863
1864 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
1865
1866         Regression(r138603): Caused 2 webkitpy tests to fail
1867         https://bugs.webkit.org/show_bug.cgi?id=105913
1868
1869         Reviewed by Kentaro Hara.
1870
1871         Fix 2 webkitpy tests that started to fail after
1872         r138603.
1873
1874         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1875         (IRCCommandTest._sheriff_test_data_url): Make sure the
1876         returned test file URL is valid no matter what the
1877         current working directory is.
1878         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1879         (IRCBotTest.test_help): Add "sheriffs" command to the
1880         list of available commands.
1881
1882 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
1883
1884         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
1885         https://bugs.webkit.org/show_bug.cgi?id=105897
1886
1887         Reviewed by Alexey Proskuryakov.
1888
1889         Dump in WebKitTestRunner the message that is expected by layout tests
1890         when the missing plugin button is clicked.
1891
1892         * WebKitTestRunner/TestController.cpp:
1893         (WTR::TestController::createWebViewWithOptions):
1894         (WTR::TestController::unavailablePluginButtonClicked):
1895         (WTR):
1896         * WebKitTestRunner/TestController.h:
1897         (TestController):
1898
1899 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
1900
1901         [EFL] Enable MHTML feature
1902         https://bugs.webkit.org/show_bug.cgi?id=105815
1903
1904         Reviewed by Laszlo Gombos.
1905
1906         Enable MHTML feature for EFL port by default.
1907
1908         * Scripts/webkitperl/FeatureList.pm:
1909
1910 2013-01-01  Alan Cutter  <alancutter@chromium.org>
1911
1912         sheriff-bot should know who the gardeners/sheriffs are
1913         https://bugs.webkit.org/show_bug.cgi?id=105698
1914
1915         Reviewed by Eric Seidel.
1916
1917         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
1918
1919         * Scripts/webkitpy/tool/bot/irc_command.py:
1920         (Current):
1921         (Current._retrieve_webkit_sheriffs):
1922         (Current.execute):
1923         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1924         (IRCCommandTest.test_current):
1925         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
1926         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
1927         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
1928         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
1929         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
1930
1931 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         [GTK] Move ImageDiff to the Tools directory root
1934         https://bugs.webkit.org/show_bug.cgi?id=105421
1935
1936         Reviewed by Kenneth Rohde Christiansen.
1937
1938         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
1939         * GNUmakefile.am:
1940         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
1941
1942 2012-12-30  Mike West  <mkwst@chromium.org>
1943
1944         Add myself to watchlists for CSP and console logs.
1945         https://bugs.webkit.org/show_bug.cgi?id=105874
1946
1947         Reviewed by Dirk Pranke.
1948
1949         Because I really, really, really need more email.
1950
1951         * Scripts/webkitpy/common/config/committers.py:
1952             Add mkwst+watchlist@chromium.org as a contributor.
1953         * Scripts/webkitpy/common/config/watchlist:
1954             Create watchlist categories for 1) the various mechanisms used to
1955             generate console messages, and 2) CSP usage and files.
1956
1957 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1958
1959         [EFL] Enable TEMPLATE_ELEMENT feature
1960         https://bugs.webkit.org/show_bug.cgi?id=105865
1961         
1962         Reviewed by Laszlo Gombos.
1963
1964         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
1965
1966 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
1967
1968         Unreviewed GTK gardening of the unit tests.
1969
1970         Skip the TestInspectorServer unit test that's timing out completely.
1971
1972         * Scripts/run-gtk-tests:
1973         (TestRunner):
1974
1975 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1976
1977         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
1978         https://bugs.webkit.org/show_bug.cgi?id=105855
1979
1980         Reviewed by Vsevolod Vlasov.
1981
1982         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
1983         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
1984
1985         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1986         (ReportMemoryUsageVisitor):
1987         (clang::AddMemberCallVisitor::VisitCallExpr):
1988         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1989         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
1990
1991 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1992
1993         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
1994         https://bugs.webkit.org/show_bug.cgi?id=105852
1995
1996         Reviewed by Alexander Pavlov.
1997
1998         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1999         (clang):
2000         (AddMemberCallVisitor):
2001         (ReportMemoryUsageVisitor):
2002         (clang::ReportMemoryUsageAction::ParseArgs):
2003         (clang::AddMemberCallVisitor::VisitCallExpr):
2004         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2005         (clang::ReportMemoryUsageVisitor::emitWarning):
2006         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2007         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2008         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2009
2010 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2011
2012         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2013         https://bugs.webkit.org/show_bug.cgi?id=105835
2014
2015         Reviewed by Dirk Pranke.
2016
2017         The BeautifulSoup module is a third-party import and as such we don't have much control
2018         over its testing. Because of that it should be omitted from code coverage checking.
2019
2020         * Scripts/webkitpy/test/main.py:
2021         (Tester._run_tests):
2022
2023 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2024
2025         [GTK][WK2] Add support for IME Composition
2026         https://bugs.webkit.org/show_bug.cgi?id=65093
2027
2028         Reviewed by Carlos Garcia Campos.
2029
2030         Update unit tests for GtkInputMethodFilter to note whether or not an event
2031         was a fake event synthesized for composition purposes. This is now used
2032         for WebKit2.
2033
2034         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2035         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2036         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2037         (TestWebKitAPI::TEST):
2038         * gtk/generate-gtkdoc:
2039         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2040         generation.
2041
2042 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2043
2044         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2045         https://bugs.webkit.org/show_bug.cgi?id=105800
2046
2047         Reviewed by Yury Semikhatsky.
2048
2049         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2050         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2051         (clang):
2052
2053 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2054
2055         Create a GTK build system watchlist and add myself to it
2056         https://bugs.webkit.org/show_bug.cgi?id=105769
2057
2058         Reviewed by Dirk Pranke.
2059
2060         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2061         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2062         omitted on purpose due to relatively high change rate they are exposed to.
2063
2064         The new watchlist would be of use to me as the GTK build system recently went
2065         through a series of changes that included a changed policy on adding configuration
2066         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2067         mailing list about this change will be published later, but I'd also like to be
2068         notified of any pending changes to these files just so I can check the changes are
2069         in compliance with the new policy.
2070
2071         * Scripts/webkitpy/common/config/watchlist:
2072
2073 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2074
2075         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2076         As example ..../DevTools/src/third_party/WebKit
2077
2078         * Scripts/webkitpy/common/webkit_finder.py:
2079         (WebKitFinder.webkit_base):
2080
2081 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2082
2083         [EFL][WK2] Refactor snapshot taking code
2084         https://bugs.webkit.org/show_bug.cgi?id=105687
2085
2086         Reviewed by Kenneth Rohde Christiansen.
2087
2088         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2089         since the function was renamed to follow naming style.
2090
2091         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2092         (WTR::PlatformWebView::windowSnapshotImage):
2093
2094 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2095
2096         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2097         https://bugs.webkit.org/show_bug.cgi?id=105725
2098
2099         Reviewed by Yury Semikhatsky.
2100
2101         MemberType value names were adjusted according to Style Guide.
2102         Existing tests were extended with link type validation.
2103
2104         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2105
2106 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2107
2108         [BlackBerry] DRT - Crashed when running pixels tests
2109         https://bugs.webkit.org/show_bug.cgi?id=105711
2110
2111         RIM PR 270003
2112
2113         Reviewed by George Staikos.
2114
2115         Calling window->post() here will result in buffer swapping which is
2116         only allowed in UI thread now, and I found we don't need to call it
2117         for GL renderer.
2118
2119         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2120         (createBitmapContextFromWebView):
2121
2122 2012-12-22  Dan Winship  <danw@gnome.org>
2123
2124         Add a patch to fix libxml2 2.9.0 regression
2125         https://bugs.webkit.org/show_bug.cgi?id=104494
2126
2127         Reviewed by Martin Robinson.
2128
2129         * gtk/jhbuild.modules:
2130         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2131
2132 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2133
2134         Unreviewed update of status to reviewer.
2135
2136         * Scripts/webkitpy/common/config/committers.py:
2137
2138 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2139
2140         [GTK][jhbuild] Bump GStreamer to 1.0.4
2141         https://bugs.webkit.org/show_bug.cgi?id=105640
2142
2143         Reviewed by Martin Robinson.
2144
2145         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2146
2147 2012-12-21  Nico Weber  <thakis@chromium.org>
2148
2149         chromium: webkit-build-directory doesn't handle ninja output dirs
2150         https://bugs.webkit.org/show_bug.cgi?id=105671
2151
2152         Reviewed by Daniel Bates.
2153
2154         Teach webkit-build-directory to detect the ninja build directory.
2155
2156         * Scripts/webkitdirs.pm:
2157         (determineBaseProductDir):
2158         (determineIsChromiumNinja):
2159
2160 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2161
2162         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2163         https://bugs.webkit.org/show_bug.cgi?id=95477
2164
2165         Reviewed by Sam Weinig.
2166
2167         Co-authored by Jia Pu.
2168
2169         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2170         we can have consistent autocorrection behavior when running tests.
2171
2172         * DumpRenderTree/mac/DumpRenderTree.mm:
2173         (resetDefaultsToConsistentValues):
2174         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2175         (WTR::InjectedBundle::platformInitialize):
2176
2177 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2178
2179         [GTK] Add WebKit1-specific TestExpectations file
2180         https://bugs.webkit.org/show_bug.cgi?id=97562
2181
2182         Reviewed by Dirk Pranke.
2183
2184         Implement the expectations_files method inside the GtkPort class that
2185         returns the list of the TestExpectations files the current test configuration
2186         requires. The method is implemented in a similar way as on the EFL port.
2187         A unit test is also added.
2188
2189         * Scripts/webkitpy/layout_tests/port/gtk.py:
2190         (GtkPort._search_paths):
2191         (GtkPort):
2192         (GtkPort.expectations_files):
2193         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2194         (GtkPortTest.test_expectations_files):
2195
2196 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2197
2198         [EFL] Enable feature option for the CSS sticky position
2199         https://bugs.webkit.org/show_bug.cgi?id=105630
2200
2201         Reviewed by Kenneth Rohde Christiansen.
2202
2203         Enable CSS sticky position feature by default for the
2204         EFL port. This feature option was added in r138252.
2205
2206         No new tests. Existing layout tests pass.
2207
2208         * Scripts/webkitperl/FeatureList.pm:
2209
2210 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2211
2212         [WK2] REGRESSION(r138232): It made 4 tests timeout
2213         https://bugs.webkit.org/show_bug.cgi?id=105623
2214
2215         Reviewed by Kenneth Rohde Christiansen.
2216
2217         r138232 changed functionality so that empty text output
2218         no longer leads to a dump() call, which leads to a timeout.
2219         Instead do a text dump if there is text output or if there
2220         is no audio output.
2221
2222         * WebKitTestRunner/TestInvocation.cpp:
2223         (WTR::TestInvocation::dumpResults):
2224
2225 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2226
2227         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2228         https://bugs.webkit.org/show_bug.cgi?id=105309
2229
2230         On Windows the library name is Qt5WebKitWidgets as well.
2231         So r138136 should not have adjusted the library name for Windows.
2232
2233         Reviewed by Simon Hausmann.
2234
2235         * Scripts/webkitdirs.pm:
2236         (builtDylibPathForName):
2237
2238 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2239
2240         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2241         https://bugs.webkit.org/show_bug.cgi?id=105424
2242
2243         This change will allow us to run a very specific
2244         subset of the available LayoutTests on a mac buildbot.
2245         The new baseline search path for mac will look as follows:
2246         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2247
2248         Reviewed by Dirk Pranke.
2249
2250         * Scripts/webkitpy/layout_tests/port/qt.py:
2251         (QtPort._search_paths):
2252         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2253         (QtPortTest):
2254
2255 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2256
2257         [EFL] Build break with latest EFL libraries.
2258         https://bugs.webkit.org/show_bug.cgi?id=104827
2259
2260         Reviewed by Laszlo Gombos.
2261
2262         The eo EFL package is introduced and evas and ecore use it since 1.8.
2263         While introducing Eo, EFL changed several structures of Evas and Ecore
2264         from own specific class to Eo.
2265
2266         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2267         Ecore_Timer to build with latest EFL libraries.
2268
2269         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2270         * EWebLauncher/CMakeLists.txt: Ditto.
2271         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2272         * ImageDiff/PlatformEfl.cmake: Ditto.
2273         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2274         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2275         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2276         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2277         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2278
2279 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2280
2281         TestExpectation fallback is broken
2282         https://bugs.webkit.org/show_bug.cgi?id=105583
2283
2284         Reviewed by Ryosuke Niwa.
2285
2286         When I added support for the -wk2 in port names, it looks
2287         like I broke the way we computed the list of TestExpectations
2288         files so that the implementation-version directory was left out :(.
2289         Fixed and cleaned up the tests.
2290
2291         * Scripts/webkitpy/layout_tests/port/base.py:
2292         (Port.expectations_files):
2293         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2294         (TestWebKitPort.__init__):
2295         (PortTestCase.test_skipped_directories_for_symbols):
2296         (test_skipped_directories_for_features):
2297         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2298         (test_skipped_tests_for_unsupported_features_empty_test_list):
2299         (test_skipped_layout_tests):
2300         (test_expectations_files):
2301
2302 2012-12-20  Anders Carlsson  <andersca@apple.com>
2303
2304         Don't include WebKit2 headers when building TestWebKitAPI on windows
2305         https://bugs.webkit.org/show_bug.cgi?id=105582
2306
2307         Reviewed by Tim Horton.
2308
2309         * TestWebKitAPI/config.h:
2310         * TestWebKitAPI/win/main.cpp:
2311
2312 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2313
2314         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2315         https://bugs.webkit.org/show_bug.cgi?id=105370
2316
2317         Reviewed by Simon Fraser.
2318
2319         Re-enable the test.
2320
2321         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2322         (TestWebKitAPI::TEST):
2323
2324 2012-12-20  Nico Weber  <thakis@chromium.org>
2325
2326         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2327         https://bugs.webkit.org/show_bug.cgi?id=105498
2328
2329         Reviewed by Dirk Pranke.
2330
2331         Use the newest binary available rather than an than always picking one
2332         build directory over another based on iteration order.
2333
2334         * Scripts/webkitpy/layout_tests/port/chromium.py:
2335         (ChromiumPort._static_build_path):
2336         Check for timestamps.
2337         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2338         (ChromiumMacPortTest.test_build_path_timestamps):
2339         Test that out / xcodebuild selection happens based on timestamps
2340         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2341         (ChromiumWinPortTest.test_build_path_timestamps):
2342         Test that out / build selection happens based on timestamps
2343
2344 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2345
2346         Lots of sticky tests failing in WK2
2347         https://bugs.webkit.org/show_bug.cgi?id=105464
2348
2349         Reviewed by Beth Dakin.
2350
2351         WebKitTestRunner had a race between snapshotting in the UI process,
2352         and resettting after the test in the web process. InjectedBundle::done()
2353         was a bad place to call page()->resetAfterTest(), because of this race;
2354         it could reset the scroll position before the UI snapshot had been obtained.
2355         
2356         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2357         for the "Reset" message which will come in before the next test.
2358
2359         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2360         (WTR::InjectedBundle::didReceiveMessage):
2361         (WTR::InjectedBundle::done):
2362
2363 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2364
2365         DFG speculation checks that take JumpList should consolidate OSRExits
2366         https://bugs.webkit.org/show_bug.cgi?id=105401
2367
2368         Reviewed by Oliver Hunt.
2369
2370         Update the profiler to understand that an OSR exit may have multiple
2371         candidate exit sites.
2372
2373         * Scripts/display-profiler-output:
2374
2375 2012-12-20  Eric Seidel  <eric@webkit.org>
2376
2377         EWSes do not need to dump build/test logs when things pass
2378         https://bugs.webkit.org/show_bug.cgi?id=105402
2379
2380         Reviewed by Dirk Pranke.
2381
2382         When we were first writing the commit-queue and EWS system
2383         and running them locally, we thought it was important to see the
2384         build/test output as it happened.  Now these queues have been running
2385         for years, and we don't use this feature anymore.  So this patch
2386         makes us stop tee-ing the output directly to stdout, and instead
2387         only print any output from commands when they fail.
2388
2389         I also added some logging when we execute each command
2390         since we are no longer printing the command output itself.
2391         This should make it much easier to see errors with the EWS
2392         system itself, now that all the passing-build output is removed.
2393
2394         This required updating a zillion unittests, since we have a bunch of
2395         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2396         already approximating this behavior by using a "logging" Executive.
2397         I disabled logging in those cases to avoid redundant logging in those tests.
2398
2399         * Scripts/webkitpy/common/system/executive.py:
2400         (Executive.command_for_printing):
2401         (Executive.run_command):
2402         * Scripts/webkitpy/common/system/executive_mock.py:
2403         (MockExecutive.command_for_printing):
2404         (MockExecutive.run_command):
2405         * Scripts/webkitpy/common/system/executive_unittest.py:
2406         (ExecutiveTest.test_auto_stringify_args):
2407         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2408         (EarlyWarningSytemTest._default_expected_logs):
2409         (_test_ews):
2410         (_test_ewses):
2411         * Scripts/webkitpy/tool/commands/queues.py:
2412         (AbstractQueue.run_webkit_patch):
2413         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2414         (AbstractQueueTest._assert_run_webkit_patch):
2415         (CommitQueueTest.test_commit_queue):
2416         (test_rollout):
2417         (test_rollout_lands):
2418         (test_manual_reject_during_processing):
2419         (StyleQueueTest.test_style_queue_with_style_exception):
2420         (test_style_queue_with_watch_list_exception):
2421
2422 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2423
2424         AX: support clickPoint in DRT for chromium
2425         https://bugs.webkit.org/show_bug.cgi?id=97359
2426
2427         Reviewed by Chris Fleizach.
2428
2429         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2430         several more tests can pass.
2431
2432         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2433         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2434         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2435         (WebTestRunner):
2436         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2437         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2438         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2439         (AccessibilityUIElement):
2440
2441 2012-12-20  Dan Bernstein  <mitz@apple.com>
2442
2443         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2444         https://bugs.webkit.org/show_bug.cgi?id=99268
2445
2446         Reviewed by Alexey Proskuryakov.
2447
2448         * Scripts/prepare-ChangeLog:
2449         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2450
2451 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2452
2453         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2454
2455         * Scripts/run-gtk-tests:
2456         (TestRunner):
2457
2458 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2459
2460         [Qt] Move ImageDiff to the Tools directory root
2461         https://bugs.webkit.org/show_bug.cgi?id=105420
2462
2463         Reviewed by Tor Arne Vestbø.
2464
2465         Moved ImageDiff from outside DumpRenderTree because it is also a
2466         dependency when running pixel tests for WebKit2.
2467
2468         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2469         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2470         * Tools.pro:
2471
2472 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2473
2474         [GTK] Remove the --enable-unstable-features configuration option
2475         https://bugs.webkit.org/show_bug.cgi?id=105327
2476
2477         Reviewed by Martin Robinson.
2478
2479         Add a missing feature option for the CSS sticky position feature.
2480
2481         * Scripts/webkitperl/FeatureList.pm:
2482
2483 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2484
2485         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2486
2487         * Scripts/run-gtk-tests:
2488         (TestRunner):
2489
2490 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2491
2492         [EFL] MiniBrowser does not play Infinite Gangnam Style
2493         https://bugs.webkit.org/show_bug.cgi?id=103531
2494
2495         Reviewed by Kenneth Rohde Christiansen.
2496
2497         For EFL we would like this feature to be built by default.
2498
2499         * Scripts/webkitperl/FeatureList.pm:
2500
2501 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2502
2503         [Qt] EWS bots should call qmake always
2504         https://bugs.webkit.org/show_bug.cgi?id=90049
2505
2506         Reviewed by Simon Hausmann.
2507
2508         * Scripts/webkitdirs.pm:
2509         (buildQMakeProjects):
2510
2511 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2512
2513         [chromium] fix stray printf in TestRunner's WebTestProxy
2514         https://bugs.webkit.org/show_bug.cgi?id=105515
2515
2516         Reviewed by Ryosuke Niwa.
2517
2518         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2519         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2520
2521 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2522
2523         [WK2] WebAudio WKTR support
2524         https://bugs.webkit.org/show_bug.cgi?id=95084
2525
2526         Reviewed by Kenneth Rohde Christiansen.
2527
2528         Implementing audio data dump support for WebKitTestRunner,
2529         by adding the API to the IDL, enabling IPC for transferring
2530         the audio data as bytebuffer and dumping it according
2531         to run-webkit-tests script's expectations.
2532         This enables audio testing on WebKit2 ports.
2533         Based on initial wip-patch from Philippe Normand - thanks.
2534
2535         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2537         (WTR::TestRunner::setAudioData):
2538         (WTR):
2539         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2540         (TestRunner):
2541         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2542         (WTR::InjectedBundle::done):
2543         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2544         (WTR::InjectedBundle::setAudioResult):
2545         (InjectedBundle):
2546         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2547         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2548         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2549         (WTR::TestInvocation::dumpResults):
2550         (WTR):
2551         (WTR::TestInvocation::dumpAudio):
2552         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2553         * WebKitTestRunner/TestInvocation.h:
2554         (TestInvocation):
2555
2556 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2557
2558         [GTK] Count failed and timed out tests separately
2559         https://bugs.webkit.org/show_bug.cgi?id=105448
2560
2561         Reviewed by Carlos Garcia Campos.
2562
2563         Display the number of tests that fail, time out and are skipped
2564         separately in the buildbot page.
2565
2566         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2567         (RunGtkAPITests.commandComplete):
2568         (RunGtkAPITests.evaluateCommand):
2569         (RunGtkAPITests.getText2):
2570         * Scripts/run-gtk-tests:
2571         (TestRunner.run_tests):
2572
2573 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2574
2575         PerfTest.parse_output does too much
2576         https://bugs.webkit.org/show_bug.cgi?id=105391
2577
2578         Reviewed by Tony Chang.
2579
2580         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2581         Also moved the code to output test results into PerfTest._run_with_driver.
2582
2583         * Scripts/webkitpy/performance_tests/perftest.py:
2584         (PerfTest.__init__): Added _description.
2585         (PerfTest.description): Added.
2586         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2587         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2588         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2589         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2590         iteration now since r136492.
2591         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2592         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2593         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2594         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2595         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2596         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2597         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2598         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2599         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2600         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2601         so that it's not string-concatenated with the next line.
2602         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2603         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2604
2605 2012-12-19  Alexis Menard  <alexis@webkit.org>
2606
2607         Implement CSS parsing for CSS transitions unprefixed.
2608         https://bugs.webkit.org/show_bug.cgi?id=104804
2609
2610         Reviewed by Dean Jackson.
2611
2612         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2613         to cover the work of unprefixing Transforms, Animations and 
2614         Transitions. It will let the possibility of each ports to turn it off 
2615         in their release branches until we're confident that these CSS 
2616         properties are ready to be unprefixed.
2617
2618         * Scripts/webkitperl/FeatureList.pm:
2619         * qmake/mkspecs/features/features.pri:
2620
2621 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2622
2623         2 clampTo unit tests are failing
2624         https://bugs.webkit.org/show_bug.cgi?id=105253
2625
2626         Reviewed by Emil A Eklund.
2627
2628         Removed clampToUnsigned as it was actually testing exactly what
2629         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2630         to precision loss (fix suggested by Emil).
2631
2632         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2633
2634 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2635
2636         [EFL] Move ImageDiff to the Tools directory root
2637         https://bugs.webkit.org/show_bug.cgi?id=105305
2638
2639         Reviewed by Laszlo Gombos.
2640
2641         We previously moved this directory from the DRT directory to
2642         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2643         not depend on DumpRenderTree but for legacy reasons was living inside the
2644         DRT folder, even though it is needed when running pixel tests for WK2.
2645
2646         Now we are moving to Tool directory root as other ports agreed to do the same.
2647
2648         * CMakeLists.txt:
2649         * ImageDiff/CMakeLists.txt: Added.
2650         * ImageDiff/PlatformEfl.cmake: Added.
2651         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2652         * efl/ImageDiff/CMakeLists.txt: Removed.
2653
2654 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2655
2656         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2657         https://bugs.webkit.org/show_bug.cgi?id=105309
2658
2659         The version number is only used as a part
2660         of the library name on Linux.
2661
2662         Reviewed by Kenneth Rohde Christiansen.
2663
2664         * Scripts/webkitdirs.pm:
2665         (builtDylibPathForName):
2666
2667 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2668
2669         [GTK] Tests that time out are not considered as failures.
2670         https://bugs.webkit.org/show_bug.cgi?id=105318
2671
2672         Reviewed by Martin Robinson.
2673
2674         Fix parsing of the GTK API tests log files.
2675
2676         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2677         (RunGtkAPITests.commandComplete):
2678
2679 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2680
2681         Unreviewed, rolling out r138061.
2682         https://bugs.webkit.org/show_bug.cgi?id=105396
2683
2684         Original patch:
2685         http://trac.webkit.org/changeset/138061
2686         https://bugs.webkit.org/show_bug.cgi?id=97359
2687
2688         It is crashing on Debug bots
2689
2690         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2691         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2692         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2693         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2694         (AccessibilityUIElement):
2695
2696 2012-12-18  Alice Liu  <alice.liu@apple.com>
2697
2698         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2699         Add SPI to WebKit1 WebFrame for hit testing
2700
2701         Reviewed by Dan Bernstein.
2702
2703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
2704         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
2705         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
2706         Then hit-tests at three points, expecting to hit the two divs and body element. 
2707
2708 2012-12-18  Alice Liu  <alice.liu@apple.com>
2709
2710         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
2711         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2712
2713         Reviewed by Anders Carlsson.
2714
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2716         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2717         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2718         Loads html with a single div element. In an isolated world, creates a property on that node.
2719         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2720             - Existence of the isolated property in the isolated world.
2721             - Existence of the standard property in the standard world.
2722             - Non-existence of the isolated property in the standard world.
2723             - Non-existence of the standard property in the isolated world.
2724
2725 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2726
2727         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2728         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2729         
2730         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2731         (TestWebKitAPI::TEST):
2732
2733 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2734
2735         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2736         https://bugs.webkit.org/show_bug.cgi?id=104279
2737
2738         Reviewed by David Kilzer.
2739
2740         Add a build phase script that checks a framework's header files for
2741         Platform.h and Compiler.h macros. Also add some tests for the script.
2742
2743         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2744         Script to be used in build phases to check for inappropriate macros in headers.
2745
2746         * Scripts/test-webkitruby: Added.
2747         Script that can be used to run all webkitruby tests.
2748
2749         * Scripts/test-webkit-scripts:
2750         Also run the ruby tests.
2751
2752         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2753         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2754         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2755         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2756         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2757         Tests for the new script.
2758
2759 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2760
2761         AX: support clickPoint in DRT for chromium
2762         https://bugs.webkit.org/show_bug.cgi?id=97359
2763
2764         Reviewed by Chris Fleizach.
2765
2766         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2767         several more tests can pass.
2768
2769         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2770         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2771         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2772         (WebTestRunner):
2773         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2774         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2775         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2776         (AccessibilityUIElement):
2777
2778 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2779
2780         Build fix after r138045.
2781
2782         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2783         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2784         is not explicitly specified. The condition was backwards but never matched so we
2785         always ran the test regardless of whether it's listed in the skipped list or not.
2786         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2787         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2788
2789 2012-12-18  Emil A Eklund  <eae@chromium.org>
2790
2791         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2792         https://bugs.webkit.org/show_bug.cgi?id=105332
2793         
2794         Reviewed by Levi Weintraub.
2795         
2796         Create new test suite for LayoutUnit tests as the KURL tests are
2797         of the incompatible TEST_F type.
2798
2799         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2800         (TestWebKitAPI):
2801         (TestWebKitAPI::TEST_F):
2802
2803 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2804
2805         Running a skipped test with run-perf-tests could alert the user
2806         https://bugs.webkit.org/show_bug.cgi?id=105219
2807
2808         Reviewed by Eric Seidel.
2809
2810         Force run skipped performance tests explicitly specified in the command line.
2811         Also warn the user when the specified paths don't exist.
2812
2813         * Scripts/webkitpy/layout_tests/port/base.py:
2814         (Port.relative_test_filename):
2815         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2816         (PerfTestsRunner._parse_args):
2817         (PerfTestsRunner._collect_tests):
2818         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2819         (test_collect_tests_with_skipped_list_and_files):
2820
2821 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
2822
2823         Chrome Android java output is too verbose
2824         https://bugs.webkit.org/show_bug.cgi?id=105247
2825
2826         Reviewed by Tony Chang.
2827
2828         Pass -quiet to ant to suppress extraneous output.
2829
2830         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2831         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2832
2833 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2834
2835         Consider removing --pause-before-testing option
2836         https://bugs.webkit.org/show_bug.cgi?id=105248
2837
2838         Reviewed by Eric Seidel.
2839
2840         Remove --pause-before-testing option.
2841
2842         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
2843         (DriverProxy.start): Removed.
2844         * Scripts/webkitpy/performance_tests/perftest.py:
2845         (PerfTest.__init__):
2846         (PerfTest.test_path): Renamed from path_or_url.
2847         (PerfTest.run):
2848         (PerfTest): Removed "driver" argument.
2849         (PerfTest._run_with_driver):
2850         (PerfTest.run_single):
2851         (ChromiumStylePerfTest.__init__):
2852         (PageLoadingPerfTest.__init__):
2853         (PageLoadingPerfTest.run_single):
2854         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
2855         (ReplayPerfTest.__init__):
2856         (ReplayPerfTest.prepare):
2857         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2858         (TestPageLoadingPerfTest.test_run):
2859         (TestPageLoadingPerfTest.test_run_with_memory_output):
2860         (TestPageLoadingPerfTest.test_run_with_bad_output):
2861         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2862         (PerfTestsRunner._parse_args):
2863         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
2864         (PerfTestsRunner._run_single_test): Removed "driver" argument.
2865         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2866         (run_test):
2867         (test_run_test_pause_before_testing): Removed.
2868
2869 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
2870
2871         [GTK] Tests that time out are not considered as failures.
2872         https://bugs.webkit.org/show_bug.cgi?id=105318
2873
2874         Reviewed by Martin Robinson.
2875
2876         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2877         (RunGtkAPITests.commandComplete):
2878         Consider log lines that end with TIMEOUT as errors.
2879
2880         * Scripts/run-gtk-tests:
2881         (TestRunner.run_tests):
2882         Consider timeouts as failures when returning the number of failed
2883         tests.
2884
2885 2012-12-18  Pravin D  <pravin.d@samsung.com>
2886
2887         Unreviewed, adding secondary email.
2888
2889         * Scripts/webkitpy/common/config/committers.py:
2890
2891 2012-12-18  Pravin D  <pravin.d@samsung.com>
2892
2893         Unreviewed, promoting myself to committer's list.
2894
2895         * Scripts/webkitpy/common/config/committers.py:
2896
2897 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2898
2899         [EFL] ImageDiff does not build on WebKit2 only builds
2900         https://bugs.webkit.org/show_bug.cgi?id=105288
2901
2902         Reviewed by Kenneth Rohde Christiansen.
2903
2904         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
2905         the folder with things which are EFL-specific.
2906
2907         ImageDiff will be built by default now regardless of WebKit API flavor
2908         you choose.
2909
2910         * CMakeLists.txt:
2911         * DumpRenderTree/efl/CMakeLists.txt:
2912         * efl/ImageDiff/CMakeLists.txt: Added.
2913         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
2914
2915 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2916
2917         [EFL][WK2] When creating new windows, use the opener's context
2918         https://bugs.webkit.org/show_bug.cgi?id=105283
2919
2920         Reviewed by Laszlo Gombos.
2921
2922         Use the context of the opener if exists.
2923
2924         * MiniBrowser/efl/main.c:
2925         (on_key_down):
2926         (on_window_create):
2927         (window_create):
2928         (elm_main):
2929
2930 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2931
2932         [EFL][WK2] Gardening of TestWebKitAPI tests
2933         https://bugs.webkit.org/show_bug.cgi?id=105268
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         Some tests were marked as failing but are passing and the newly added
2938         LayoutUnit should have it's own binary because it conflicts with the
2939         fixture used by KURL and is failing on the bots because of that.
2940
2941         * TestWebKitAPI/CMakeLists.txt:
2942         * TestWebKitAPI/PlatformEfl.cmake:
2943
2944 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2945
2946         [chromium] move webintent related methods to TestRunner library
2947         https://bugs.webkit.org/show_bug.cgi?id=105164
2948
2949         Reviewed by Darin Fisher.
2950
2951         Also deleted the unused deliveredIntentFailure and
2952         deliveredIntentResult methods.
2953
2954         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2955         (DRTTestRunner::DRTTestRunner):
2956         * DumpRenderTree/chromium/DRTTestRunner.h:
2957         (DRTTestRunner):
2958         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2959         (WebKit):
2960         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
2961         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
2962         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2963         (WebKit):
2964         (WebTestProxyBase):
2965         (WebTestRunner::WebTestProxy::registerIntentService):
2966         (WebTestRunner::WebTestProxy::dispatchIntent):
2967         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2968         (WebTestRunner::TestRunner::TestRunner):
2969         (WebTestRunner::TestRunner::sendWebIntentResponse):
2970         (WebTestRunner):
2971         (WebTestRunner::TestRunner::deliverWebIntent):
2972         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2973         (TestRunner):
2974         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2975         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2976         (WebTestRunner::WebTestProxyBase::registerIntentService):
2977         (WebTestRunner):
2978         (WebTestRunner::WebTestProxyBase::dispatchIntent):
2979         * DumpRenderTree/chromium/WebViewHost.cpp:
2980         (WebViewHost::setCurrentWebIntentRequest):
2981         (WebViewHost::currentWebIntentRequest):
2982         * DumpRenderTree/chromium/WebViewHost.h:
2983         (WebKit):
2984         (WebViewHost):
2985
2986 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2987
2988         [chromium] move editing callback dumping to the WebTestProxy
2989         https://bugs.webkit.org/show_bug.cgi?id=105013
2990
2991         Reviewed by Darin Fisher.
2992
2993         To decide whether or not to dump the editing callbacks, the WebTestProxy
2994         needs to query the TestRunner. For this purpose, I introduce a
2995         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
2996         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
2997         an interface, and it is not owned by the WebTestInterfaces, but the
2998         embedder of the TestRunner library must provide it. This will change
2999         once all TestRunner methods are in the library.
3000
3001         * DumpRenderTree/DumpRenderTree.gypi:
3002         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3003         (DRTTestRunner::DRTTestRunner):
3004         (DRTTestRunner::reset):
3005         * DumpRenderTree/chromium/DRTTestRunner.h:
3006         (DRTTestRunner):
3007         (DRTTestRunner::taskList):
3008         (DRTTestRunner::WorkQueue::taskList):
3009         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3010         (WebTestRunner):
3011         (WebTestInterfaces):
3012         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3013         (WebKit):
3014         (WebTestRunner):
3015         (WebTestProxyBase):
3016         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3017         (WebTestRunner::WebTestProxy::shouldEndEditing):
3018         (WebTestRunner::WebTestProxy::shouldInsertNode):
3019         (WebTestRunner::WebTestProxy::shouldInsertText):
3020         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3021         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3022         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3023         (WebTestRunner::WebTestProxy::didBeginEditing):
3024         (WebTestRunner::WebTestProxy::didChangeSelection):
3025         (WebTestRunner::WebTestProxy::didChangeContents):
3026         (WebTestRunner::WebTestProxy::didEndEditing):
3027         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3028         (WebTestRunner):
3029         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3030         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3031         (WebTestRunner::TestRunner::TestRunner):
3032         (WebTestRunner::TestRunner::~TestRunner):
3033         (WebTestRunner):
3034         (WebTestRunner::TestRunner::reset):
3035         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3036         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3037         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3038         (TestRunner):
3039         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3040         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3041         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3042         (WebTestInterfaces::Internal):
3043         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3044         (WebTestRunner::WebTestInterfaces::testRunner):
3045         (WebTestRunner):
3046         (WebTestRunner::WebTestInterfaces::setTestRunner):
3047         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3048         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3049         (WebTestRunner):
3050         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3051         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3052         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3053         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3054         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3055         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3056         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3057         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3058         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3059         (WebTestRunner::WebTestProxyBase::didChangeContents):
3060         (WebTestRunner::WebTestProxyBase::didEndEditing):
3061         * DumpRenderTree/chromium/TestShell.cpp:
3062         (TestShell::initialize):
3063         (TestShell::createNewWindow):
3064         * DumpRenderTree/chromium/WebViewHost.cpp:
3065         (WebViewHost::shouldBeginEditing):
3066         (WebViewHost::shouldEndEditing):
3067         (WebViewHost::shouldInsertNode):
3068         (WebViewHost::shouldInsertText):
3069         (WebViewHost::shouldChangeSelectedRange):
3070         (WebViewHost::shouldDeleteRange):
3071         (WebViewHost::shouldApplyStyle):
3072         * DumpRenderTree/chromium/WebViewHost.h:
3073         (WebViewHost):
3074
3075 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3076
3077         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3078         https://bugs.webkit.org/show_bug.cgi?id=105154
3079
3080         Reviewed by Tony Chang.
3081
3082         If the settings are modified directly, the embedder can't keep track of
3083         them and might accidentially override the changed settings.
3084
3085         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3086         (WebPreferences):
3087         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3088         (WebTestRunner::TestRunner::TestRunner):
3089         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3090         (WebTestRunner):
3091         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3092         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3093         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3094         (TestRunner):
3095         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3096         (WebTestRunner::WebPreferences::reset):
3097         (WebTestRunner::WebPreferences::applyTo):
3098
3099 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3100
3101         Unreviewed unit test skipping.
3102
3103         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3104
3105         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3106         (TestWebKitAPI):
3107         (TestWebKitAPI::TEST):
3108
3109 2012-12-17  Dean Jackson  <dino@apple.com>
3110
3111         Unreviewed. Add Silvia Pfeiffer to contributor list.
3112
3113         * Scripts/webkitpy/common/config/committers.py:
3114
3115 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3116
3117         build.webkit.org - add more google windows bots
3118         https://bugs.webkit.org/show_bug.cgi?id=105225
3119
3120         Reviewed by Eric Seidel.
3121
3122         Adds two more windows bots (google-windows-3, a builder, and
3123         google-windows-4, a tester) for the Chromium configs.
3124
3125         * BuildSlaveSupport/build.webkit.org-config/config.json:
3126
3127 2012-12-17  Eric Seidel  <eric@webkit.org>
3128
3129         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3130         https://bugs.webkit.org/show_bug.cgi?id=105217
3131
3132         Reviewed by Dirk Pranke.
3133
3134         Previously --profile would fail strangely if find_unused_filename returned None
3135         (which would happen as soon as we had 100 report files).
3136         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3137         I also made some minor cleanups to the output of perf, and tried to make the
3138         commands more self-documenting by using long-names for args.
3139
3140         * Scripts/webkitpy/common/system/profiler.py:
3141         (SingleFileOutputProfiler.__init__):
3142         (Perf.attach_to_pid):
3143         (Perf.profile_after_exit):
3144
3145 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3146
3147         Unreviewed, rolling out r137198.
3148         http://trac.webkit.org/changeset/137198
3149         https://bugs.webkit.org/show_bug.cgi?id=105212
3150
3151         This patch is causing API behavior compatibility problems
3152         (Requested by zdobersek on #webkit).
3153
3154         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3155         (willSendRequestCallback):
3156
3157 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3158
3159         Unreviewed. Adding myself to committers list.
3160
3161         * Scripts/webkitpy/common/config/committers.py:
3162
3163 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3164
3165         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3166         https://bugs.webkit.org/show_bug.cgi?id=105078
3167
3168         Reviewed by Ojan Vafai.
3169
3170         This patch reorders functions so that run_webkit_tests can be
3171         understood in a top-down matter better, and to make things slightly
3172         more sensible when I merge manager.py into it.
3173
3174         Also, this adds tests for the actual main() routine, which had several
3175         bugs get through testing a week or two ago.
3176
3177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3178         (main):
3179         (parse_args):
3180         (_set_up_derived_options):
3181         (run):
3182         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3183         (RunTest):
3184         (RunTest.test_no_http_tests):
3185         (PortTest.disabled_test_mac_lion):
3186         (MainTest):
3187         (MainTest.test_exception_handling):
3188         (MainTest.test_exception_handling.interrupting_run):
3189         (MainTest.test_exception_handling.successful_run):
3190         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3191         (MainTest.test_exception_handling.exception_raising_run):
3192
3193 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3194
3195         webkitpy: move --lint-test-files code into its own module
3196         https://bugs.webkit.org/show_bug.cgi?id=105077
3197
3198         Reviewed by Eric Seidel.
3199
3200         It really didn't need to be in run_webkit_tests.py anymore.
3201         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3202         rwt --lint-test-files is still supported for backwards compatibility
3203         for now.
3204
3205         * Scripts/lint-test-expectations: Added.
3206         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3207         (lint):
3208         (main):
3209         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3210         (FakePort):
3211         (FakePort.__init__):
3212         (FakePort.test_configuration):
3213         (FakePort.expectations_dict):
3214         (FakePort.skipped_layout_tests):
3215         (FakePort.all_test_configurations):
3216         (FakePort.configuration_specifier_macros):
3217         (FakePort.get_option):
3218         (FakeFactory):
3219         (FakeFactory.__init__):
3220         (FakeFactory.get):
3221         (FakeFactory.all_port_names):
3222         (LintTest):
3223         (LintTest.test_all_configurations):
3224         (LintTest.test_lint_test_files):
3225         (LintTest.test_lint_test_files__errors):
3226         (MainTest):
3227         (MainTest.test_success):
3228         (MainTest.test_success.interrupting_lint):
3229         (MainTest.test_success.successful_lint):
3230         (MainTest.test_success.exception_raising_lint):
3231         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3232         (main):
3233         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3234         (StreamTestingMixin.assertNotEmpty):
3235
3236 2012-12-17  Adam Klein  <adamk@chromium.org>
3237
3238         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3239         https://bugs.webkit.org/show_bug.cgi?id=105072
3240
3241         Reviewed by Laszlo Gombos.
3242
3243         * Scripts/webkitperl/FeatureList.pm:
3244
3245 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3246
3247         Add some unit testing for WTF::clampTo* functions
3248         https://bugs.webkit.org/show_bug.cgi?id=105060
3249
3250         Reviewed by Emil A Eklund.
3251
3252         The new tests are targeted at clamping to int / unsigned and float as those are
3253         the one explicitely exposed through more dedicated functions (like clampToInteger,
3254         clampToPositiveInteger and clampToFloat).
3255
3256         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3257
3258 2012-12-17  Eric Seidel  <eric@webkit.org>
3259
3260         rpt --profile --chromium-android throws exception
3261         https://bugs.webkit.org/show_bug.cgi?id=105061
3262
3263         Reviewed by Daniel Bates.
3264
3265         Somehow popen(args) got turned into popen(*args) at some point,
3266         which caused my new stringify code to fail when args was passed by name.
3267         Fixed and tested.
3268
3269         * Scripts/webkitpy/common/system/executive.py:
3270         (Executive._stringify_args):
3271         (Executive):
3272         (Executive.popen):
3273         * Scripts/webkitpy/common/system/executive_unittest.py:
3274         (ExecutiveTest.test_popen_args):
3275
3276 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3277
3278         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3279         https://bugs.webkit.org/show_bug.cgi?id=105054
3280
3281         Reviewed by Jochen Eisinger.
3282
3283         Part of a refactoring series; see tracking bug 82948.
3284
3285         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3286         (NotificationPresenter::show):
3287         * DumpRenderTree/chromium/Task.cpp:
3288         (postTask):
3289         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3290
3291 2012-12-17  Emil A Eklund  <eae@chromium.org>
3292
3293         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3294         https://bugs.webkit.org/show_bug.cgi?id=104955
3295
3296         Reviewed by Julien Chaffraix.
3297
3298         Add tests for LayoutUnit.
3299
3300         * TestWebKitAPI/CMakeLists.txt:
3301         * TestWebKitAPI/ForwardingHeaders: Added.
3302         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3303         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3304         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3305         * TestWebKitAPI/TestWebKitAPI.gypi:
3306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3307         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3308         (TestWebKitAPI):
3309         (TestWebKitAPI::TEST):
3310         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3311
3312 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3313
3314         [chromium] removed unused preferences from testRunner.overridePreference
3315         https://bugs.webkit.org/show_bug.cgi?id=105169
3316
3317         Reviewed by Tony Chang.
3318
3319         Most notably this removes the code related to font family maps which is
3320         now handled via window.internals.settings
3321
3322         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3323         (WebPreferences):
3324         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3325         (WebTestRunner::TestRunner::overridePreference):
3326         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3327         (TestRunner):
3328         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3329         (WebTestRunner::WebPreferences::applyTo):
3330
3331 2012-12-17  James Robinson  <jamesr@chromium.org>
3332
3333         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3334         https://bugs.webkit.org/show_bug.cgi?id=105071
3335
3336         Reviewed by Adrienne Walker.
3337
3338         Update WebViewHost for the new WebWidgetClient interface.
3339
3340         * DumpRenderTree/chromium/WebViewHost.cpp:
3341         (WebViewHost::initializeLayerTreeView):
3342         (WebViewHost::layerTreeView):
3343         (WebViewHost::~WebViewHost):
3344         * DumpRenderTree/chromium/WebViewHost.h:
3345         (WebViewHost):
3346
3347 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3348
3349         [EFL][WK2] window_create doesn't receive the url
3350         https://bugs.webkit.org/show_bug.cgi?id=105184
3351
3352         Reviewed by Alexis Menard.
3353
3354         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3355         (on_window_create):
3356
3357 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3358
3359         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3360         https://bugs.webkit.org/show_bug.cgi?id=105026
3361
3362         Reviewed by Yury Semikhatsky.
3363
3364         Old SFINAE test was replaced with new one based on this article:
3365         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3366
3367         New test which covers this problem was added.
3368
3369         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3370
3371 2012-12-17  Anthony Scian  <ascian@rim.com>
3372
3373         [Blackberry] Static code analysis warning fixes
3374         https://bugs.webkit.org/show_bug.cgi?id=105129
3375
3376         Reviewed by Rob Buis.
3377
3378         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3379
3380         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3381         (BlackBerry::WebKit::createFile):
3382         (BlackBerry::WebKit::DumpRenderTree::runTest):
3383
3384 2012-12-17  John Mellor  <johnme@chromium.org>
3385
3386         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3387         https://bugs.webkit.org/show_bug.cgi?id=105025
3388
3389         Unreviewed. Adds two contributors to committers.py.
3390         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3391
3392         * Scripts/webkitpy/common/config/committers.py:
3393
3394 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3395
3396         Unreviewed, add myself to committers.py.
3397
3398         * Scripts/webkitpy/common/config/committers.py:
3399
3400 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3401
3402         [Qt] remove some unnecessary CONFIG additions
3403
3404         Reviewed by Simon Hausmann.
3405
3406         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3407         default_pre.prf.
3408
3409         * qmake/mkspecs/features/default_post.prf:
3410
3411 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3412
3413         Unreviewed, rolling out r137892.
3414         http://trac.webkit.org/changeset/137892
3415         https://bugs.webkit.org/show_bug.cgi?id=105026
3416
3417         it broke compilation on windows
3418
3419         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3420
3421 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
3422
3423         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3424         https://bugs.webkit.org/show_bug.cgi?id=105026
3425
3426         Reviewed by Yury Semikhatsky.
3427
3428         Old SFINAE test was replaced with new one based on this article:
3429         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3430
3431         New test which covers this problem was added.
3432
3433         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3434
3435 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3436
3437         [Qt] rely on automatic output directory setup
3438
3439         Reviewed by Simon Hausmann.
3440
3441         Now being a proper qt module (by virtue of having load(qt_build_config)
3442         in .qmake.conf), webkit gets the path setup goodies for free.
3443
3444         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
3445         at the same time, instead of the debug and release version ending up in different
3446         directories as they should.
3447
3448         * qmake/mkspecs/features/default_pre.prf:
3449
3450 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3451
3452         [BlackBerry] Need to re-enable video track
3453         https://bugs.webkit.org/show_bug.cgi?id=105155
3454
3455         Reviewed by George Staikos.
3456
3457         Just enable Video Track for BlackBerry.
3458
3459         * Scripts/webkitperl/FeatureList.pm:
3460
3461 2012-12-17  János Badics  <jbadics@inf.u-szeged.hu>
3462
3463         Unreviewed. Added myself to committers.py
3464
3465         * Scripts/webkitpy/common/config/committers.py:
3466
3467 2012-12-17  Jonathan Liu  <net147@gmail.com>
3468
3469         Fix linking of libraries with -Wl,-whole-archive
3470         https://bugs.webkit.org/show_bug.cgi?id=104436
3471
3472         Reviewed by Simon Hausmann.
3473
3474         If there is more than one library in LIBS linked with
3475         -Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
3476         merge the duplicate flags in LIBS which causes linking to fail.
3477
3478         Add no_smart_library_merge to CONFIG to prevent the duplicate
3479         flags from being removed when using -Wl,-whole-archive.
3480
3481         * qmake/mkspecs/features/functions.prf:
3482
3483 2012-12-16  Arvid Nilsson  <anilsson@rim.com>
3484
3485         [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
3486         https://bugs.webkit.org/show_bug.cgi?id=105143
3487         RIM PR 171941
3488
3489         Reviewed by Rob Buis.
3490         Internally reviewed by George Staikos.
3491
3492         Adapt to new method names and encapsulation of TouchPoint data members.
3493
3494         * DumpRenderTree/blackberry/EventSender.cpp:
3495         (addTouchPointCallback):
3496         (updateTouchPointCallback):
3497         (touchEndCallback):
3498         (releaseTouchPointCallback):
3499         (sendTouchEvent):
3500
3501 2012-12-16  Maciej Stachowiak  <mjs@apple.com>
3502
3503         Add a script to compute the mean and 95% confidence interval (using two-sided t-test) of a sample set
3504         https://bugs.webkit.org/show_bug.cgi?id=105148
3505
3506         Reviewed by Filip Pizlo.
3507
3508         Usage examples:
3509         
3510         $ sampstat --help
3511         Usage: sampstat [options] [FILES]
3512           Compute the mean and 95% confidence interval of a sample set.
3513           Standard input or files must contain two or more decimal numbers, one per line.
3514         
3515         Options:
3516           -h, --help            show this help message and exit
3517           -u UNIT, --unit=UNIT  assume values are in units of UNIT
3518           -v, --verbose         print all values (with units)
3519         
3520         $ sampstat -u MB memresults.txt
3521         2356.90 MB +/- 101.34 MB (4.3%)
3522         
3523         $ sampstat -v -u MB memresults.txt
3524               2318.21 MB
3525               2399.56 MB
3526               2352.93 MB
3527         ----------------
3528         Mean: 2356.90 MB +/- 101.34 MB (4.3%)
3529         
3530
3531         * Scripts/sampstat: Added.
3532         (sum): Helper function to compute the sum of a list.
3533         (arithmeticMean): Compute the meam of a list.
3534         (standardDeviation): Compute the sample standard deviation (unbiased estimator).
3535         (standardError): Compute the sample standard error.
3536         (tDist): Compute t(.025, n-1), the t-value for atwo-sided 95% confidence interval. 
3537         (twoSidedConfidenceInterval): Compute the two-sided confidence interval range about the mean.
3538
3539 2012-12-15  Nima Ghanavatian  <nghanavatian@rim.com>
3540
3541         [BlackBerry] Pass key modifiers with touch and mouse events
3542         https://bugs.webkit.org/show_bug.cgi?id=105108
3543
3544         Reviewed by Rob Buis.
3545
3546         Update DRT to new api.
3547
3548         Internally reviewed by Gen Mak.
3549
3550         * DumpRenderTree/blackberry/EventSender.cpp:
3551         (mouseDownCallback):
3552         (mouseUpCallback):
3553         (mouseMoveToCallback):
3554
3555 2012-12-15  Zan Dobersek  <zandobersek@gmail.com>
3556
3557         Stop the XvfbDriver before proceeding with its starting setup
3558         https://bugs.webkit.org/show_bug.cgi?id=105006
3559
3560         Reviewed by Philippe Normand.
3561
3562         Just as with the base Driver implementation, stop the XvfbDriver
3563         before proceeding with setting up lock files and a new Xvfb instance.
3564         This forces any driver or Xvfb instances that are currently under
3565         the driver's control to be closed/killed and cleaned up after.
3566
3567         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3568         (XvfbDriver._start):
3569
3570 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3571
3572         webkitpy: make port_name a required parameter to the non-test ports
3573         https://bugs.webkit.org/show_bug.cgi?id=105057
3574
3575         Reviewed by Eric Seidel.
3576
3577         This is just minor code cleanup along the path to making Port
3578         constructors simpler and pushing more logic into the port factory.
3579
3580         * Scripts/webkitpy/layout_tests/port/base.py:
3581         (Port.__init__):
3582         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3583         (PortTest.make_port):
3584         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3585         (TestWebKitPort.__init__):
3586         * Scripts/webkitpy/layout_tests/port/test.py:
3587         (TestPort):
3588         (TestPort.determine_full_port_name):
3589         (TestPort.__init__):
3590         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3591         (XvfbDriverTest.make_driver):
3592         (XvfbDriverTest.test_stop):
3593
3594 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3595
3596         garden-o-matic doesn't know about reftests
3597         https://bugs.webkit.org/show_bug.cgi?id=101976
3598
3599         Reviewed by Eric Seidel.
3600
3601         Attempt to make garden-o-matic properly aware of reftests again.
3602
3603         This is re-landing r137407 with a change to
3604         rebaselineWithStatusUpdates() to actually pass the filtered
3605         failureInofLost to checkout.rebaseline().
3606
3607         Unfortunately, the testing coverage for this whole module is almost
3608         non-existent, and it's not obvious that there's a good way to
3609         stub out checkout.rebaseline() to test that the right thing
3610         happens. I verified the change manually.
3611
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3613         (.):
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3615         (.):
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3617
3618 2012-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3619
3620         "Running 1 DumpRenderTree over X shards" is not a helpful output
3621         https://bugs.webkit.org/show_bug.cgi?id=104858
3622
3623         Reviewed by Dirk Pranke.
3624
3625         The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
3626         contributors who typically don't have much experience on distributed computations and databases.
3627         So only print this message out in the debug mode.
3628
3629         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: