4ab910c73e66d1f23a70316d5cb0f2adb43e08e9
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-01  Tony Tseung  <tseung@apple.com>
2
3         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
4         composite fonts from existing physical fonts.
5         <rdar://problem/10717370>
6         https://bugs.webkit.org/show_bug.cgi?id=82810
7             
8         A new test font of this kind as been added to the test tools for running the webkit-tests
9
10         Reviewed by Dan Bernstein.
11
12         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
13         Added new dependency SampleFont.sfont
14         
15         * DumpRenderTree/fonts/SampleFont.sfont: Added.
16         
17         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
18         * DumpRenderTree/mac/DumpRenderTree.mm:
19         (allowedFontFamilySet):
20         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
21         
22         (activateTestingFonts):
23         Added the registration of the Composite Font Referene sample font
24         
25         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
26         (WTR::allowedFontFamilySet):
27         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
28
29         (WTR::activateFonts):
30         Added the registration of the Composite Font Referene sample font
31
32         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
33         Added new dependency SampleFont.sfont
34
35         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
36
37 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
38
39         Support the Network Information API
40         https://bugs.webkit.org/show_bug.cgi?id=73528
41
42         Reviewed by Adam Barth.
43
44         Add network information API feature to build script.
45
46         * Scripts/build-webkit:
47
48 2012-03-31  Ojan Vafai  <ojan@chromium.org>
49
50         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
51         https://bugs.webkit.org/show_bug.cgi?id=82839
52
53         Reviewed by Adam Barth.
54
55         Also, update various hard-coded lists for WIN7 and Lion ports.
56         This is necessary since the new list of builders grabbed off the
57         buildbot includes Lion.
58
59         * TestResultServer/static-dashboards/builders.js:
60         (generateWebkitBuildersFromBuilderList):
61         (xhr.onreadystatechange):
62         Don't use dashboard_base's request method to avoid layering violation.
63
64         * TestResultServer/static-dashboards/dashboard_base.js:
65         (parseParameters):
66         (initBuilders):
67         (haveJsonFilesLoaded):
68         (g_handleBuildersListLoaded):
69         Block loading the JSON files for each builder until we actually have a list of builders.
70
71         * TestResultServer/static-dashboards/flakiness_dashboard.html:
72         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
73         (testPlatformAndBuildType):
74         (testGenerateWebkitBuildersFromBuilderList):
75         * TestResultServer/static-dashboards/timeline_explorer.html:
76         * TestResultServer/static-dashboards/treemap.html:
77         Delay generating the page until the builder list has loaded.
78
79 2012-03-31  Ojan Vafai  <ojan@chromium.org>
80
81         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
82         https://bugs.webkit.org/show_bug.cgi?id=82799
83
84         Reviewed by Eric Seidel.
85
86         If we don't run a test, mark it as skipped.
87
88         * Scripts/webkitpy/layout_tests/controllers/manager.py:
89         (Manager._mark_interrupted_tests_as_skipped):
90         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
91         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
92         (ManagerTest.test_interrupt_if_at_failure_limits):
93
94 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
95
96         One more build fix after r112781 for Chromium Windows.
97         Don't copy zip .idb files.
98
99         * BuildSlaveSupport/built-product-archive:
100         (copyBuildFiles):
101
102 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
103
104         Yet another build fix after r112781 for Chromium Windows.
105         Run webkit-build-directory by perl explicitly.
106
107         * BuildSlaveSupport/built-product-archive:
108         (determineWebKitBuildDirectory):
109
110 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
111
112         Fix the syntax error in master.cfg after r112734.
113
114         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
115         (unitTestsSupported):
116
117 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
118
119         Another build fix after r112781.
120
121         * BuildSlaveSupport/built-product-archive:
122         (createZip):
123
124 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
125
126         Build fix after r112781.
127
128         * BuildSlaveSupport/built-product-archive:
129         (createZipManually):
130         (createZip):
131
132 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
133
134         Chromium bots should upload archived built files
135         https://bugs.webkit.org/show_bug.cgi?id=82666
136
137         Reviewed by Tony Chang.
138
139         * BuildSlaveSupport/build.webkit.org-config/config.json:
140         * BuildSlaveSupport/built-product-archive:
141         (main):
142         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
143         call out to webkit-build-directory.
144         (removeDirectoryIfExists): Extracted.
145         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
146         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
147         (createZipManually.addToArchive):
148         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
149         (archiveBuiltProduct): Add support for Chromium port.
150         * Scripts/webkit-build-directory: Add support for --platform options.
151
152 2012-03-30  Dan Bernstein  <mitz@apple.com>
153
154         Reverted r112767, because it caused many vertical text tests to fail.
155
156         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
157         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
158         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
159         * DumpRenderTree/mac/DumpRenderTree.mm:
160         (allowedFontFamilySet):
161         (activateTestingFonts):
162         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
163         (WTR::allowedFontFamilySet):
164         (WTR::activateFonts):
165         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
166         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
167
168 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
169
170         [wx] Move wxWebKit API into WebKit namespace.
171         https://bugs.webkit.org/show_bug.cgi?id=82740
172
173         Reviewed by Kevin Ollivier.
174
175         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
176         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
177         (LayoutWebViewEventHandler::bindEvents):
178         (LayoutWebViewEventHandler::OnLoadEvent):
179         (LayoutWebViewEventHandler::OnAlertEvent):
180         (LayoutWebViewEventHandler::OnConfirmEvent):
181         (LayoutWebViewEventHandler::OnPromptEvent):
182         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
183         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
184         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
185         (LayoutWebViewEventHandler):
186         (dumpFramesAsText):
187         (dump):
188         (MyApp::OnInit):
189         * wx/browser/browser.cpp:
190         (MyApp::OnInit):
191
192 2012-03-30  Eli Fidler  <efidler@rim.com>
193
194         Enable OpenType Sanitizer for BlackBerry port.
195         https://bugs.webkit.org/show_bug.cgi?id=82782
196
197         Reviewed by Eric Seidel.
198
199         * Scripts/webkitdirs.pm:
200         (blackberryCMakeArguments): add OTS to include path
201
202 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
203
204         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
205         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
206         is found.
207
208         <rdar://problem/11158581>
209         
210         Reviewed by Mark Rowe.
211
212         * Scripts/webkitpy/layout_tests/port/webkit.py:
213         (WebKitDriver._start):
214
215 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
216
217         Disable run-api-tests on release mac builds
218         https://bugs.webkit.org/show_bug.cgi?id=82788
219
220         Reviewed by Ryosuke Niwa.
221         
222         TestWebKitAPI crashes every time in release builds currently
223         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
224         run-api-tests on mac release builders.
225
226         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
227         (unitTestsSupported):
228
229 2012-03-30  Chang Shu  <cshu@webkit.org>
230
231         Unreviewed. Update my email.
232
233         * Scripts/webkitpy/common/config/committers.py:
234
235 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
236
237         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
238         https://bugs.webkit.org/show_bug.cgi?id=82745
239
240         Reviewed by Simon Fraser.
241
242         * DumpRenderTree/AccessibilityUIElement.cpp:
243         (rangeForPositionCallback):
244         (AccessibilityUIElement::rangeForPosition):
245         (AccessibilityUIElement::getJSClass):
246         * DumpRenderTree/AccessibilityUIElement.h:
247         (AccessibilityUIElement):
248         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
249         (AccessibilityUIElement::rangeForPosition):
250         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
251         (WTR::AccessibilityUIElement::rangeForPosition):
252         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
253         (AccessibilityUIElement):
254         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
255         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
256         (WTR::AccessibilityUIElement::rangeForPosition):
257         (WTR):
258
259 2012-03-30  David Barr  <davidbarr@chromium.org>
260
261         Split up top-level .gitignore and .gitattributes
262         https://bugs.webkit.org/show_bug.cgi?id=82687
263
264         Reviewed by Tor Arne Vestbø.
265
266         * .gitattributes: Added.
267         * .gitignore: Added.
268         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
269         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
270
271 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
272
273         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
274
275         * TestResultServer/static-dashboards/builders.js:
276
277 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
278
279         Update ChromiumOS bot names in builders.js to reflect changes made by
280         http://crrev.com/129835
281         
282         Also removes the ChromiumOS GTK builder, which was removed by
283         http://crrev.com/129835
284
285         * TestResultServer/static-dashboards/builders.js:
286
287 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
288
289         [GTK] Disable introspection build in the at-spi2-core module.
290         https://bugs.webkit.org/show_bug.cgi?id=82729
291
292         Reviewed by Philippe Normand.
293
294         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
295
296         * gtk/jhbuild.modules: Disable introspection.
297
298 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
299
300         Add a "preview" state to Page Visibility API implementation
301         https://bugs.webkit.org/show_bug.cgi?id=81355
302
303         Reviewed by Adam Barth.
304
305         Updating the Page Visibility API implementation to the current spec version.
306
307         * DumpRenderTree/chromium/LayoutTestController.cpp:
308         (LayoutTestController::setPageVisibility):
309
310 2012-03-30  Keishi Hattori  <keishi@webkit.org>
311
312         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
313         https://bugs.webkit.org/show_bug.cgi?id=80972
314
315         Reviewed by Kent Tamura.
316
317         * Scripts/build-webkit:
318         * qmake/mkspecs/features/features.prf:
319
320 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
321
322         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
323         https://bugs.webkit.org/show_bug.cgi?id=82195
324
325         Reviewed by Simon Hausmann.
326
327         * MiniBrowser/qt/BrowserWindow.cpp:
328         (BrowserWindow::updateVisualMockTouchPoints):
329         * MiniBrowser/qt/main.cpp:
330         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
331         (WTR::WrapperWindow::handleStatusChanged):
332         * qmake/mkspecs/features/unix/default_post.prf:
333
334 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
335
336         [EFL] Implement LayoutTestController::setMinimumTimerInterval
337         https://bugs.webkit.org/show_bug.cgi?id=81220
338
339         Add missing implementation setMinimumTimerInterval to EFL's
340         LayoutTestController so that we can unskip related tests from the skip list.
341
342         Reviewed by Philippe Normand.
343
344         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
345         (LayoutTestController::setMinimumTimerInterval):
346
347 2012-03-29  Dan Bernstein  <mitz@apple.com>
348
349         Removed “Intel” from the Lion builders’ names.
350
351         Rubber-stamped by Mark Rowe.
352
353         * BuildSlaveSupport/build.webkit.org-config/config.json:
354         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
355         (LeaksViewer._displayURLPrompt):
356
357 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
358
359         [Chromium] Add sharded ChromiumOS debug bots to builders.js
360         https://bugs.webkit.org/show_bug.cgi?id=82639
361
362         Reviewed by Eric Seidel.
363
364         The bots were sharded by http://crrev.com/129613, update builders.js
365         to reflect this.
366
367         * TestResultServer/static-dashboards/builders.js:
368
369 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
370
371         remove support for junit-style xml output from test-webkitpy
372         https://bugs.webkit.org/show_bug.cgi?id=82279
373
374         Reviewed by Eric Seidel.
375
376         This was added when we were looking into integrating w/ Jenkins
377         rather than buildbot, but I believe that project got shelved, so
378         this is unused. We can always add it back in later as necessary.
379
380         * Scripts/webkitpy/test/main.py:
381         (Tester._parse_args):
382         (Tester._run_tests):
383         * Scritps/webkitpy/thirdparty/__init__.py:
384
385 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
386
387         new-run-webkit-tests: crashes when it fails to decode a stack trace
388         https://bugs.webkit.org/show_bug.cgi?id=82673
389
390         Unreviewed, build fix.
391
392         We are assuming the stdout/stderr output from the driver is utf-8
393         encoded when we get stack traces; this may not be a valid
394         assumption generally, but if we do get strings that aren't valid
395         utf-8, we would crash. Now we will ignore any decoding errors.
396
397         * Scripts/webkitpy/layout_tests/port/base.py:
398         (Port._get_crash_log):
399         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
400         (PortTestCase.test_get_crash_log):
401
402 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
403
404         Scripts fail to detect when a tool crashes
405         https://bugs.webkit.org/show_bug.cgi?id=82659
406
407         Reviewed by Mark Rowe.
408         
409         Have exitStatus() detect when the process fail to exit cleanly
410         (possibly because of a crash), and return a non-zero exit code
411         in that case.
412
413         * Scripts/VCSUtils.pm:
414         (exitStatus):
415
416 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
417
418         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
419         https://bugs.webkit.org/show_bug.cgi?id=82581
420
421         Reviewed by Martin Robinson.
422
423         Running Javascriptcore tests through jhbuild
424         for consistency with run-webkit-tests and in order to
425         avoid confusing libraries when facing regressions.
426
427         * Scripts/run-javascriptcore-tests:
428
429 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
430
431         test-webkitpy: add --timing
432         https://bugs.webkit.org/show_bug.cgi?id=82550
433
434         Reviewed by Eric Seidel.
435
436         This patch adds a --timing option that will display the time
437         each test takes. It also removes the --silent option, since
438         probably no one ever used it, and cleans up the logging
439         option parsing code to be easier to follow.
440
441         * Scripts/webkitpy/test/main.py:
442         (Tester._parse_args):
443         (Tester._configure):
444         * Scripts/webkitpy/test/runner.py:
445         (TestRunner.write_result):
446         * Scripts/webkitpy/test/runner_unittest.py:
447         (RunnerTest.test_regular):
448         (RunnerTest.test_verbose):
449         (RunnerTest):
450         (RunnerTest.test_timing):
451
452 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
453
454         HashMap<>::add should return a more descriptive object
455         https://bugs.webkit.org/show_bug.cgi?id=71063
456
457         Reviewed by Ryosuke Niwa.
458
459         Update code to use AddResult instead of a pair.
460
461         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
462         (LayoutTestController::evaluateScriptInIsolatedWorld):
463         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
464         (LayoutTestController::evaluateScriptInIsolatedWorld):
465         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
466         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
467
468 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
469
470         Web Inspector: chromium: DRT --no-timeout option doesn't work.
471         https://bugs.webkit.org/show_bug.cgi?id=82608
472
473         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
474         This was broken by r112354 and the sequence became opposite.
475
476         Reviewed by Yury Semikhatsky.
477
478         * DumpRenderTree/chromium/TestShell.cpp:
479         (TestShell::TestShell):
480         (TestShell::initialize):
481
482 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
483
484         Remove custom bindings form Internals.idl of attribute type Array.
485         https://bugs.webkit.org/show_bug.cgi?id=82319
486
487         Reviewed by Kentaro Hara.
488
489         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
490
491         * GNUmakefile.am:
492
493 2012-03-28  Mark Rowe  <mrowe@apple.com>
494
495         Fix --no-saved-state.
496
497         Ignore the flag before Lion, rather than making it specific to Lion.
498
499         Rubber-stamped by Dan Bernstein.
500
501         * Scripts/webkitdirs.pm:
502         (argumentsForRunAndDebugMacWebKitApp):
503
504 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
505
506         Add dtharp to contributors list
507         https://bugs.webkit.org/show_bug.cgi?id=82545
508
509         Reviewed by Adam Barth.
510
511         Adding dtharp as Contributor.
512
513         * Scripts/webkitpy/common/config/committers.py:
514
515 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
516
517         build-webkit : the word "pass" is spelled incorrectly as "passs"
518         https://bugs.webkit.org/show_bug.cgi?id=82532
519
520         Reviewed by Julien Chaffraix.
521
522         Corrected spelling of the word "pass" in build-webkit.
523
524         * Scripts/build-webkit:
525
526 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
527
528         new-run-webkit-tests doesn't log correctly after retrying failures
529         https://bugs.webkit.org/show_bug.cgi?id=82541
530
531         Unreviewed, build fix.
532
533         r112189 introduced a regression where we would accidentally
534         delete the log handler after we retried any failing tests - that
535         meant that any log messages around uploading the results got
536         dropped.
537
538         * Scripts/webkitpy/layout_tests/controllers/manager.py:
539         (Manager._run_tests):
540
541 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
542
543         [wx] Unreviewed. Build fix, move WTF back into JSCore target
544         until issues with JSCore not linking in all WTF symbols are resolved.
545
546         * waf/build/settings.py:
547
548 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
549
550         download-built-product build step should detect 404 errors
551         https://bugs.webkit.org/show_bug.cgi?id=82491
552
553         Reviewed by Ryosuke Niwa.
554         
555         Pass --fail to curl so that it reports 404 errors.
556
557         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
558         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
559         * BuildSlaveSupport/built-product-archive:
560         (extractBuiltProduct): Remove trailing whitespace.
561
562 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
563
564         flakiness dashboard should only keep the last 500 runs
565         https://bugs.webkit.org/show_bug.cgi?id=82530
566
567         Reviewed by Ojan Vafai.
568
569         If a bot has an overly large amount of failing tests, then
570         storing 750 runs' worth takes a lot of memory and CPU time to
571         process and we end up getting killed by AppEngine; this cases
572         data corruption and confusion down the road when we have to
573         retry the upload of the data and the tests show up as multiple
574         runs.
575
576         * TestResultServer/model/jsonresults.py:
577         (JsonResults.update_file):
578
579 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
580
581         extract-built-product build step should fail if unzipping fails
582         https://bugs.webkit.org/show_bug.cgi?id=82493
583
584         Reviewed by Simon Fraser.
585
586         Forward non-zero exit code from subprocesses so that the master can detect any failures
587         and bail out early.
588
589         * BuildSlaveSupport/built-product-archive:
590         (main):
591
592 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
593
594         test-webkitpy should support files, directories, and packages as command line args
595         https://bugs.webkit.org/show_bug.cgi?id=76765
596
597         Reviewed by Adam Barth.
598
599         This patch adds support for specifying files, directories, and
600         packages to test-webkitpy along with the already existing
601         support for modules, test classes, and individual test names.
602
603         Also, fix a bug in filesystem_mock where we wouldn't normalize a
604         path containing a reference to the current directory properly,
605         for example, '/foo/./bar.py'.
606
607         * Scripts/webkitpy/common/system/filesystem_mock.py:
608         (MockFileSystem.normpath):
609         * Scripts/webkitpy/test/main.py:
610         (Tester._configure_logging):
611         (Tester._run_tests):
612         * Scripts/webkitpy/test/test_finder.py:
613         (TestDirectoryTree.find_modules):
614         (TestDirectoryTree.subpath):
615         (TestFinder.is_dotted_name):
616         (TestFinder.find_names):
617         (TestFinder):
618         (TestFinder._find_names_for_arg):
619         (TestFinder._find_in_trees):
620         (TestFinder._default_names):
621         * Scripts/webkitpy/test/test_finder_unittest.py:
622         (TestFinderTest.setUp):
623         (TestFinderTest.tearDown):
624         (TestFinderTest.check_names):
625         (TestFinderTest.test_default_names):
626         (TestFinderTest):
627         (TestFinderTest.test_paths):
628
629 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
630
631         Fix inspector tests when running in internal builds.
632
633         <rdar://problem/11050694>
634
635         Reviewed by Tim Hatcher.
636
637         * DumpRenderTree/mac/DumpRenderTree.mm:
638         (resetDefaultsToConsistentValues):
639         * WebKitTestRunner/TestController.cpp:
640         (WTR::TestController::resetStateToConsistentValues):
641
642 2012-03-28  David Kilzer  <ddkilzer@apple.com>
643
644         Use xcrun to find nm and ranlib on OS X builds
645         <http://webkit.org/b/82466>
646
647         Reviewed by Dan Bernstein.
648
649         * Scripts/build-webkit: Use xcrun to find ranlib.
650         * Scripts/webkitdirs.pm:
651         (determineNmPath): Added.  Use xcrun to find nm on OS X.
652         (nmPath): Added.
653         * Scripts/webkitperl/features.pm:
654         (libraryContainsSymbol): Use nmPath().
655
656 2012-03-28  Ojan Vafai  <ojan@chromium.org>
657
658         Add history navigation to garden-o-matic
659         https://bugs.webkit.org/show_bug.cgi?id=82495
660
661         Reviewed by Dimitri Glazkov.
662
663         Also, maintain scroll offsets when returning to a tab. This makes addressing
664         expected failures considerably easier when dealing with below-the-fold tests.
665
666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
667         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
668         switching.
669         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
670         from a file URL and Chrome puts each different file URL in it's own origin.
671
672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
673         Remove the href so that clicking on the accordion item does not modify window.location.hash.
674
675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
677
678 2012-03-28  Philippe Normand  <pnormand@igalia.com>
679
680         [GTK] generate-gtk-doc doesn't cope with custom build directory
681         https://bugs.webkit.org/show_bug.cgi?id=82448
682
683         Reviewed by Martin Robinson.
684
685         Pass the product directory in generate-gtkdoc arguments from
686         build-webkit.
687
688         * Scripts/webkitdirs.pm:
689         (buildAutotoolsProject):
690         * gtk/common.py:
691         (get_build_path):
692
693 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
694
695         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
696         https://bugs.webkit.org/show_bug.cgi?id=82341
697
698         Reviewed by Martin Robinson.
699
700         Add --skipped=skip|ignore|only command line option.
701
702         * Scripts/run-gtk-tests:
703         (TestRunner._test_cases_to_skip): Return the list of test cases
704         to skip for the given test depending on the skipped action.
705         (TestRunner._should_run_test): Decide whether to run the test or
706         not depending on the skipped action.
707         (TestRunner.run_tests): Only show the list of skipped tests when
708         skipped action is 'skip'.
709
710 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
711
712         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
713         https://bugs.webkit.org/show_bug.cgi?id=82333
714
715         Reviewed by Martin Robinson.
716
717         * Scripts/run-gtk-tests:
718         (TestRunner.SkippedTest): Add SkippedTest class to store more
719         information about skipped tests.
720         (TestRunner._setup_testing_environment): Use SkippedTest to add
721         TestWebKitAccessibility to the skipped list.
722         (TestRunner._find_skipped_test): Return the SkippedTest object for
723         a given test path.
724         (TestRunner._test_cases_to_skip): Returns the list of test cases
725         that should be skipped for a given test path.
726         (TestRunner._should_run_test): Helper funtion to decide whether
727         the given test path should be run or not. Tests in the skipped
728         list that don't have a list of failing test cases are not run at
729         all. Tests in the skipped list that contain a list of test cases
730         are run with gtester -s to skip the individual test cases.
731         (TestRunner._run_test): Helper funtion to run a given test.
732         (TestRunner.run_tests): Build the list of tests to run based on
733         _should_run_test() and use helper function _run_test() to run
734         every test.
735
736 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
737
738         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
739         https://bugs.webkit.org/show_bug.cgi?id=52810
740
741         Reviewed by Simon Hausmann.
742
743         Use SSE2 floating point math on 32 bit instead of the default
744         387 to make layout test result same on 32 and on 64 bit builds.
745
746         * qmake/mkspecs/features/unix/default_post.prf:
747
748 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
749
750         [Soup] DNS prefetching spams resolver, shoots self in the foot
751         https://bugs.webkit.org/show_bug.cgi?id=41630
752
753         Reviewed by Martin Robinson.
754
755         Bump libsoup and glib dependencies.
756
757         * efl/jhbuild.modules:
758         * gtk/jhbuild.modules:
759
760 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
761
762         [GTK] Disable introspection for jhbuild modules
763         https://bugs.webkit.org/show_bug.cgi?id=82395
764
765         Reviewed by Philippe Normand.
766
767         * efl/jhbuild.modules: add --disable-introspection to all modules
768         that support it
769         * gtk/jhbuild.modules: ditto.
770
771 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
772
773         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
774
775         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
776         (BuildAndTestFactory.__init__):
777
778 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
779
780         [Qt] Unreviewed typo fix after r112383.
781
782         * Scripts/run-qtwebkit-tests:
783         (Main.check_crash_occurences):
784
785 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
786
787         [Qt] run-qtwebkit-tests should report crashes
788         https://bugs.webkit.org/show_bug.cgi?id=76905
789
790         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
791         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
792
793         Reviewed by Csaba Osztrogonác.
794
795         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
796         (RunQtAPITests.commandComplete):
797         (RunQtAPITests.evaluateCommand):
798         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
799         (RunQtAPITestsTest):
800         (test_failure):
801         (test_crash):
802         * Scripts/run-qtwebkit-tests:
803         (Main.announce_results_html):
804         (Main):
805         (Main.check_crash_occurences):
806         (Main.convert_to_stdout):
807         (Main.convert_to_html):
808
809 2012-03-28  Kwonjin Jeong  <gram@company100.net>
810
811         Add support for Intel compiler on Linux QT port.
812         https://bugs.webkit.org/show_bug.cgi?id=81077
813
814         Reviewed by Tor Arne Vestbø.
815
816         * qmake/mkspecs/features/default_post.prf:
817         Don't hide symbols when building with Intel compiler.
818         The symbols are needed when building QtWebKit tests.
819
820         * qmake/mkspecs/features/unix/icc.prf:
821         Added to ignore icc-specific warnings.
822         This feature is used with command-line arguments for build-webkit script.
823
824 2012-03-28  Philippe Normand  <pnormand@igalia.com>
825
826         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
827
828         * Scripts/update-webkitgtk-libs: This script is written in
829         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
830
831 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
832
833         kill-old-processes doesn't do anything on linux
834         https://bugs.webkit.org/show_bug.cgi?id=82388
835
836         Reviewed by Tony Chang.
837
838         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
839         This should help stabilizing Chromium linux bots.
840
841         * BuildSlaveSupport/kill-old-processes:
842
843 2012-03-28  Philippe Normand  <pnormand@igalia.com>
844
845         [GTK] jhbuild wrongly tricked into clean-up
846         https://bugs.webkit.org/show_bug.cgi?id=82216
847
848         Reviewed by Gustavo Noronha Silva.
849
850         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
851         build tree. Also when checking if the jhbuild configuration
852         changed use absolute md5sum paths.
853
854         * Scripts/webkitdirs.pm:
855         (runAutogenForAutotoolsProjectIfNecessary):
856         (jhbuildConfigurationChanged):
857         (buildAutotoolsProject):
858
859 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
860
861         kill-old-processes doesn't do anything on linux
862         https://bugs.webkit.org/show_bug.cgi?id=82388
863
864         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
865
866         The platform in Factory comes from config.json, accordingly platform is fullplatform,
867         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
868
869         Reviewed by Ryosuke Niwa.
870
871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
872         (Factory.__init__):
873
874 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
875
876         Make Chromium port for Android use hardware gpu path default.
877         https://bugs.webkit.org/show_bug.cgi?id=82033
878
879         Reviewed by Dirk Pranke.
880
881         Skip canvas tests, which are run in virtual gpu test suites.
882
883         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
884         (ChromiumAndroidPort.__init__):
885         (ChromiumAndroidPort.skipped_tests):
886
887 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
888
889         kill-old-processes doesn't do anything on linux
890         https://bugs.webkit.org/show_bug.cgi?id=82388
891
892         Disable kill-old-processes on the Qt bots not to kill each others.
893
894         Reviewed by Ryosuke Niwa.
895
896         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
897         (Factory.__init__):
898
899 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
900
901         Handle DRT crash caused by Android OOM.
902         https://bugs.webkit.org/show_bug.cgi?id=82310
903
904         Reviewed by Tony Chang.
905
906         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
907         is stopped silently and regarded as crashed. Re-run the test for
908         such crash.
909
910         Add some debug log to NRWT.
911
912         * Scripts/webkitpy/layout_tests/port/chromium.py:
913         (ChromiumDriver.run_test):
914         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
915         (ChromiumAndroidPort.__init__):
916         (ChromiumAndroidPort.get_last_stacktrace):
917         (ChromiumAndroidDriver.__init__):
918         (ChromiumAndroidDriver._start):
919         (ChromiumAndroidDriver.run_test):
920         (ChromiumAndroidDriver._get_drt_return_value):
921
922 2012-03-27  Ojan Vafai  <ojan@chromium.org>
923
924         Fix expected results for some unittest failures.
925
926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
927
928 2012-03-27  Adrienne Walker  <enne@google.com>
929
930         [chromium] Fix --enabled-threaded-compositing flag in DRT
931         https://bugs.webkit.org/show_bug.cgi?id=82405
932
933         Reviewed by James Robinson.
934
935         --enable-threaded-compositing wasn't working because there was no way
936         to set the value before it was used in the TestShell constructor.
937
938         To avoid adding yet another boolean parameter to TestShell's
939         constructor, add an explicit initialize function that can operate on
940         any boolean settings that are set post-constructor.
941
942         * DumpRenderTree/chromium/DumpRenderTree.cpp:
943         (main):
944         * DumpRenderTree/chromium/TestShell.cpp:
945         (TestShell::TestShell):
946         (TestShell::initialize):
947         * DumpRenderTree/chromium/TestShell.h:
948         (TestShell):
949         (TestShell::setTestShellMode):
950
951 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
952
953         new-run-webkit-tests: suppress debug output from run-safari on results file
954         https://bugs.webkit.org/show_bug.cgi?id=82400
955
956         Reviewed by Ryosuke Niwa.
957
958         Send the run-safari output to /dev/null rather than the console.
959
960         * Scripts/webkitpy/layout_tests/port/mac.py:
961         (MacPort.show_results_html_file):
962
963 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
964
965         Improve error reporting in run-javascriptcore-tests
966         https://bugs.webkit.org/show_bug.cgi?id=82379
967
968         Reviewed by Jessie Berlin.
969         
970         When the script dies, have it print out the reason for dying.
971
972         * Scripts/run-javascriptcore-tests:
973
974 2012-03-27  Eric Seidel  <eric@webkit.org>
975
976         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
977         https://bugs.webkit.org/show_bug.cgi?id=82373
978
979         Reviewed by Ryosuke Niwa.
980
981         Dave's committer-status in in-progress, so until then
982         list him as a Contributor so at least I can more easily CC him on bugs.
983
984         * Scripts/webkitpy/common/config/committers.py:
985
986 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
987
988         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
989         https://bugs.webkit.org/show_bug.cgi?id=82252
990
991         Reviewed by Gustavo Noronha Silva.
992
993         Appending the directory containing common.py may be problematic if
994         another path in sys.path also contains either a common.py or a
995         common/ module, so prepend to select our version instead. This is
996         the case with fail2ban, which has a common/ directory which may
997         end up being in Python's default path.
998
999         * efl/jhbuildrc:
1000         * gtk/jhbuildrc:
1001
1002 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
1003
1004         test-webkitpy: prepare for better test run output
1005         https://bugs.webkit.org/show_bug.cgi?id=82290
1006
1007         Reviewed by Adam Barth.
1008
1009         This code basically re-implements the output of the TextTestRunner default
1010         runner code from unittest, although the implementation is quite
1011         different, in preparation for changing the test output to be
1012         metered and possibly running in parallel.
1013
1014         The output is almost identical to before, except that instead of
1015         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
1016         "webkitpy.main.RunnerTest.test_regular passed". It has always
1017         annoyed me that they invert the names to be harder to read and
1018         so that you can't copy & paste back to the input for
1019         test-webkitpy.
1020
1021         This patch is provided to add a skeleton for unit tests and for
1022         comparison to an upcoming patch that will actually add new
1023         functionality.
1024
1025         * Scripts/webkitpy/test/main.py:
1026         (Tester.__init__):
1027         (Tester._configure_logging):
1028         (Tester._run_tests):
1029         * Scripts/webkitpy/test/runner.py: Added.
1030         (TestRunner):
1031         (TestRunner.__init__):
1032         (TestRunner.test_name):
1033         (TestRunner.all_test_names):
1034         (TestRunner.run):
1035         (TestRunner.write_result):
1036         (TestRunner.write_summary):
1037         * Scripts/webkitpy/test/runner_unittest.py: Added.
1038         (FakeModuleSuite):
1039         (FakeModuleSuite.__init__):
1040         (FakeModuleSuite.__str__):
1041         (FakeModuleSuite.run):
1042         (FakeTopSuite):
1043         (FakeTopSuite.__init__):
1044         (FakeLoader):
1045         (FakeLoader.__init__):
1046         (FakeLoader.top_suite):
1047         (FakeLoader.loadTestsFromName):
1048         (RunnerTest):
1049         (RunnerTest.test_regular):
1050         (RunnerTest.test_verbose):
1051
1052 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1053
1054         [GTK] Build gnutls without p11-kit support
1055         https://bugs.webkit.org/show_bug.cgi?id=82212
1056
1057         Reviewed by Martin Robinson.
1058
1059         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
1060         configure, to avoid requiring that dependency, which is not used
1061         by libsoup and WebKit anyway
1062
1063 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1064
1065         [Qt] Make debug build work on 32 bit
1066         https://bugs.webkit.org/show_bug.cgi?id=82331
1067
1068         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
1069         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
1070
1071         Reviewed by Tor Arne Vestbø.
1072
1073         * qmake/mkspecs/features/unix/default_post.prf:
1074         * qmake/mkspecs/features/unix/default_pre.prf:
1075
1076 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
1077
1078         Add png checking to check-webkit-style
1079         https://bugs.webkit.org/show_bug.cgi?id=75824
1080
1081         Reviewed by NOBODY Tony Chang.
1082
1083         * Scripts/webkitpy/style/checker.py:
1084         (_all_categories):
1085         (FileType):
1086         (CheckerDispatcher._should_skip_file_path):
1087         (CheckerDispatcher._file_type):
1088         (CheckerDispatcher._create_checker):
1089         * Scripts/webkitpy/style/checker_unittest.py:
1090         (CheckerDispatcherDispatchTest.test_none_paths):
1091         * Scripts/webkitpy/style/checkers/png.py: Added.
1092         (PNGChecker):
1093         (PNGChecker.__init__):
1094         (PNGChecker.check):
1095         (PNGChecker._config_file_path):
1096         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
1097         (MockSCMDetector):
1098         (MockSCMDetector.__init__):
1099         (MockSCMDetector.display_name):
1100         (MockSCMDetector.propget):
1101         (PNGCheckerTest):
1102         (PNGCheckerTest.test_init):
1103         (PNGCheckerTest.test_init.mock_handle_style_error):
1104         (PNGCheckerTest.test_check):
1105         (PNGCheckerTest.test_check.mock_handle_style_error):
1106         * Scripts/webkitpy/style/patchreader.py:
1107         (PatchReader.check):
1108
1109 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1110
1111         Unreviewed. Skip GTK+ unit tests that fail in the bots
1112
1113         * Scripts/run-gtk-tests:
1114         (TestRunner): Add failing tests to the skipped list.
1115
1116 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1117
1118         Unreviewed. Unskip all GTK+ unit test.
1119
1120         Currently, skipped tests contains the list of unit tests that have
1121         failed in one or more bots. In this moment it's not possible to
1122         skip just the test cases that fail, so the complete unit test is
1123         skipped when a single test case fails. For that reason, we don't
1124         know which test cases are actually failing for every skipped
1125         test. We are planning to land a patch to allow skipping individual
1126         test cases, but first we need to know which test cases are
1127         currently failing in the bots to skip them. So, this patch simply
1128         unskips all unit tests in order to watch the bots and get the list
1129         of test cases failing. Failing tests will be skipped again as soon
1130         as we have the new list of failing test cases.
1131
1132         * Scripts/run-gtk-tests:
1133         (TestRunner): Reset the list of skipped tests.
1134
1135 2012-03-26  Scott Byer  <scottbyer@chromium.org>
1136
1137         Enable layout testing of the scroll animator.
1138         https://bugs.webkit.org/show_bug.cgi?id=81858
1139         Add a call to the InternalSettings that layout tests can use to
1140         turn on scroll animation. Enable animation updates for the
1141         Chromium platform DRT when scroll animation has been turned on in
1142         a test. This should be a no-op for all current layout tests.
1143
1144         Reviewed by James Robinson.
1145
1146         * DumpRenderTree/chromium/WebViewHost.cpp:
1147         (WebViewHost::serviceAnimation):
1148         (WebViewHost::scheduleAnimation):
1149         * DumpRenderTree/chromium/WebViewHost.h:
1150         (WebViewHost):
1151
1152 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
1153
1154         [Qt][WK2] Support multi-file upload
1155         https://bugs.webkit.org/show_bug.cgi?id=81589
1156
1157         Reviewed by Simon Hausmann.
1158
1159         Modified filePicker to support multi-file upload.
1160
1161         * MiniBrowser/qt/MiniBrowser.qrc:
1162         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
1163         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
1164         * MiniBrowser/qt/js/MultiSelect.js: Added.
1165         (values):
1166         (isSelected):
1167         (removeValue):
1168         * MiniBrowser/qt/qml/CheckBox.qml: Added.
1169         * MiniBrowser/qt/qml/FilePicker.qml:
1170
1171 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1172
1173         Retry crashing tests serially at the end of NRWT on Apple Mac
1174         https://bugs.webkit.org/show_bug.cgi?id=82233
1175
1176         Reviewed by Dirk Pranke.
1177
1178         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1179         (Manager.run):
1180         * Scripts/webkitpy/layout_tests/port/base.py:
1181         (Port.should_retry_crashes):
1182         * Scripts/webkitpy/layout_tests/port/mac.py:
1183         (MacPort.should_retry_crashes):
1184
1185 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1186
1187         NRWT should retry failures serially
1188         https://bugs.webkit.org/show_bug.cgi?id=82241
1189
1190         Reviewed by Dirk Pranke.
1191
1192         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1193         (Manager._run_tests): Add another parameter to specify the number of workers to use.
1194         (Manager.run): Run the failures serially.
1195
1196 2012-03-26  Adrienne Walker  <enne@google.com>
1197
1198         Allow expectations on directories in virtual test suites
1199         https://bugs.webkit.org/show_bug.cgi?id=82250
1200
1201         Reviewed by Dirk Pranke.
1202
1203         lookup_virtual_test_base was only returning valid results for files
1204         and not directories. Fix by falling back to the virtual test suite
1205         mapping if possible.
1206
1207         * Scripts/webkitpy/layout_tests/port/base.py:
1208         (Port.lookup_virtual_test_base):
1209         * Scripts/webkitpy/layout_tests/port/test.py:
1210         (TestPort.skipped_tests):
1211         (TestPort.virtual_test_suites):
1212
1213 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1214
1215         Fix duplicated ChangeLog entry from r112171.
1216
1217         Unreviewed, build fix.
1218
1219 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1220
1221         nrwt: remove --worker-model flag
1222         https://bugs.webkit.org/show_bug.cgi?id=82112
1223
1224         Reviewed by Adam Barth.
1225
1226         The --worker-model=inline flag is basically redundant with the
1227         --child-processes=1 flag (technically, you could one run child
1228         process, but this is only useful for testing); this patch
1229         removes this flag, which simplifies things and enables more
1230         cleanup down the road.
1231
1232         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1233         (Manager._run_tests):
1234         (Manager.print_config):
1235         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1236         (get):
1237         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1238         (make_broker):
1239         (FunctionTests.test_get__inline):
1240         (FunctionTests.test_get__processes):
1241         (_TestsMixin.setUp):
1242         (_TestsMixin.make_broker):
1243         (InlineBrokerTests.setUp):
1244         (MultiProcessBrokerTests.setUp):
1245         * Scripts/webkitpy/layout_tests/port/base.py:
1246         (Port.default_child_processes):
1247         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1248         (ChromiumAndroidPort.check_sys_deps):
1249         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1250         (ChromiumAndroidPortTest):
1251         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1252         (MockDRTPortTest.make_port):
1253         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1254         (PortTestCase):
1255         (PortTestCase.make_port):
1256         * Scripts/webkitpy/layout_tests/port/test.py:
1257         (TestPort.default_child_processes):
1258         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1259         (_set_up_derived_options):
1260         (parse_args):
1261         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1262         (parse_args):
1263         (MainTest.test_batch_size):
1264         (MainTest.test_child_processes_2):
1265         (MainTest.test_child_processes_min):
1266         (MainTest.test_exception_raised):
1267         (MainTest.test_keyboard_interrupt):
1268         (MainTest.test_exit_after_n_crashes):
1269         (MainTest.assert_run_order):
1270         (MainTest.test_run_order__inline):
1271         (MainTest.test_virtual):
1272
1273 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1274
1275         test-webkitpy: split test-finding code into a different module
1276         https://bugs.webkit.org/show_bug.cgi?id=82253
1277
1278         Reviewed by Adam Barth.
1279
1280         Per suggestion from abarth, this change splits all the
1281         filesystem-crawling, test-finding code in test-webkitpy out into
1282         a separate module and switches to using a FileSystem object.
1283         This makes things much more testable, so we also add tests :).
1284
1285         We also add a realpath() method to the Filesystem object, since
1286         test-webkitpy needs that in order to be able to resolve symlinks
1287         properly to determine whether a file is under a particular tree
1288         or not.
1289
1290         * Scripts/webkitpy/common/system/filesystem.py:
1291         (FileSystem.realpath):
1292         * Scripts/webkitpy/common/system/filesystem_mock.py:
1293         (MockFileSystem.realpath):
1294         * Scripts/webkitpy/test/main.py:
1295         (Tester.__init__):
1296         (Tester.add_tree):
1297         (Tester.run):
1298         (Tester._run_tests):
1299         (Tester._log_exception):
1300         * Scripts/webkitpy/test/test_finder.py: Added.
1301         (TestDirectoryTree):
1302         (TestDirectoryTree.__init__):
1303         (TestDirectoryTree.find_modules):
1304         (TestDirectoryTree.find_modules.file_filter):
1305         (TestDirectoryTree.to_module):
1306         (TestDirectoryTree.clean):
1307         (TestFinder):
1308         (TestFinder.__init__):
1309         (TestFinder.add_tree):
1310         (TestFinder.additional_paths):
1311         (TestFinder.clean_trees):
1312         (TestFinder.is_module):
1313         (TestFinder.to_module):
1314         (TestFinder.find_names):
1315         (TestFinder._exclude):
1316         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
1317         (TestFinderTest):
1318         (TestFinderTest.setUp):
1319         (TestFinderTest.tearDown):
1320         (TestFinderTest.test_additional_system_paths):
1321         (TestFinderTest.test_is_module):
1322         (TestFinderTest.test_to_module):
1323         (TestFinderTest.test_clean):
1324         (TestFinderTest.test_find_names):
1325
1326 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1327
1328         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
1329         https://bugs.webkit.org/show_bug.cgi?id=82209
1330
1331         Reviewed by Martin Robinson.
1332
1333         Respecting the $MAKE environment variable when it is defined makes
1334         building jhbuild more portable, as some platforms may have GNU
1335         make as gmake, for example.
1336
1337         * jhbuild/jhbuild-wrapper:
1338         (install_jhbuild):
1339
1340 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1341
1342         add a Tree abstraction to test-webkitpy to better encapsulate things
1343         https://bugs.webkit.org/show_bug.cgi?id=82158
1344
1345         Reviewed by Adam Barth.
1346
1347         There are no functional changes in this patch, but adding a
1348         basic abstraction for the trees we are looking in for python
1349         tests will allow me to add some features later on more easily
1350         (like ignoring certain directories like webkitpy/thirdparty),
1351         and it makes things slightly less hard-coded.
1352
1353         * Scripts/test-webkitpy:
1354         * Scripts/webkitpy/test/main.py:
1355         (Tester.__init__):
1356         (Tester):
1357         (Tester.add_tree):
1358         (Tester._parse_args):
1359         (Tester._configure):
1360         (Tester.run):
1361         (Tester._find_modules):
1362         (Tester._run_tests):
1363         (Tester._is_module):
1364         (Tester._log_exception):
1365         (TestDirectoryTree):
1366         (TestDirectoryTree.__init__):
1367         (TestDirectoryTree.find_modules):
1368         (TestDirectoryTree.clean):
1369
1370 2012-03-26  Ojan Vafai  <ojan@chromium.org>
1371
1372         garden-o-matic should special case reftests
1373         https://bugs.webkit.org/show_bug.cgi?id=81812
1374
1375         Reviewed by Adam Barth.
1376
1377         On the examine page, don't show a rebaseline button for reftests.
1378         We still show it on the failure summary page because tests are grouped
1379         together. Long-term, we should make sure webkit-patch rebaseline-test
1380         never tries to rebaseline reftests.
1381
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1385
1386 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1387
1388         clean up NRWT logging/metering, be less verbose
1389         https://bugs.webkit.org/show_bug.cgi?id=73846
1390
1391         Reviewed by Ojan Vafai.
1392
1393         Re-land r112014 with a build fix for Python 2.6 compatibility.
1394
1395         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1396         (ManagerTest.test_http_locking):
1397         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1398         (AbstractWorker.run):
1399         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1400         (Worker.__init__):
1401         (Worker._set_up_logging):
1402         (Worker):
1403         (Worker._set_up_host_and_port):
1404         (Worker.run):
1405         (Worker.cleanup):
1406         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1407         (WorkerTest.test_default_platform_in_worker):
1408         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1409         (run):
1410         (main):
1411         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1412         (MeteredStream):
1413         (MeteredStream.implements):
1414         (MeteredStream._erasure):
1415         (MeteredStream._ensure_newline):
1416         (MeteredStream.__init__):
1417         (MeteredStream.__del__):
1418         (MeteredStream.cleanup):
1419         (MeteredStream.write_throttled_update):
1420         (MeteredStream.write_update):
1421         (MeteredStream.write):
1422         (MeteredStream.writeln):
1423         (MeteredStream._erase_last_partial_line):
1424         (_LogHandler):
1425         (_LogHandler.__init__):
1426         (_LogHandler.emit):
1427         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1428         (RegularTest):
1429         (RegularTest.setUp):
1430         (RegularTest.tearDown):
1431         (RegularTest.time_fn):
1432         (RegularTest.test_logging_not_included):
1433         (RegularTest._basic):
1434         (RegularTest.test_basic):
1435         (RegularTest._log_after_update):
1436         (RegularTest.test_log_after_update):
1437         (TtyTest):
1438         (TtyTest.test_basic):
1439         (TtyTest.test_log_after_update):
1440         (VerboseTest):
1441         (VerboseTest.test_basic):
1442         (VerboseTest.test_log_after_update):
1443         * Scripts/webkitpy/layout_tests/views/printing.py:
1444         (parse_print_options):
1445         (Printer.__init__):
1446         (Printer.cleanup):
1447         (Printer.print_progress):
1448         (Printer.print_update):
1449         (Printer._write):
1450         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1451         (Testprinter.get_printer):
1452         (Testprinter.test_print_progress):
1453         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1454         (PerfTestsRunner.__init__):
1455         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1456         (test_run_test_pause_before_testing):
1457
1458 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1459
1460         [jhbuild] Revert $MAKE environment hack introduced in r101929.
1461         https://bugs.webkit.org/show_bug.cgi?id=82234
1462
1463         Reviewed by Martin Robinson.
1464
1465         The problem it was supposedly fixing was fixed in jhbuild itself
1466         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
1467         can remove the workaround added to the script.
1468
1469         * jhbuild/jhbuild-wrapper:
1470         (install_jhbuild):
1471
1472 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
1473
1474         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
1475         https://bugs.webkit.org/show_bug.cgi?id=82157
1476
1477         Reviewed by Rob Buis.
1478
1479         * Scripts/build-webkit:
1480         Make ENABLE_FILE_SYSTEM default on for blackberry.
1481
1482 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1483
1484         [jhbuild] Explicitly disable DTrace when building glib.
1485         https://bugs.webkit.org/show_bug.cgi?id=82145
1486
1487         Reviewed by Gustavo Noronha Silva.
1488
1489         DTrace support is not really needed by WebKit, so disabling it
1490         helps avoid some build errors on more exotic platforms (such as
1491         FreeBSD).
1492
1493         * efl/jhbuild.modules:
1494         * gtk/jhbuild.modules:
1495
1496 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1497
1498         Unreviewed, rolling out r111993.
1499         http://trac.webkit.org/changeset/111993
1500         https://bugs.webkit.org/show_bug.cgi?id=82184
1501
1502         It broke layout and API tests and made WTR crash (Requested by
1503         Ossy on #webkit).
1504
1505         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1506         (WTR::PlatformWebView::PlatformWebView):
1507
1508 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
1509
1510         [wx] Unreviewed build fix. Move WTF to its own static lib build.
1511
1512         * waf/build/settings.py:
1513         (common_configure):
1514
1515 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
1516
1517         AX: Support solution to handle invalid ax text marker
1518         https://bugs.webkit.org/show_bug.cgi?id=82023
1519
1520         Reviewed by Oliver Hunt.
1521
1522         * DumpRenderTree/AccessibilityUIElement.cpp:
1523         (indexForTextMarkerCallback):
1524         (isTextMarkerValidCallback):
1525         (textMarkerForIndexCallback):
1526         (AccessibilityUIElement::indexForTextMarker):
1527         (AccessibilityUIElement::isTextMarkerValid):
1528         (AccessibilityUIElement::textMarkerForIndex):
1529         (AccessibilityUIElement::getJSClass):
1530         * DumpRenderTree/AccessibilityUIElement.h:
1531         (AccessibilityUIElement):
1532         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1533         (AccessibilityUIElement::indexForTextMarker):
1534         (AccessibilityUIElement::textMarkerForIndex):
1535         (AccessibilityUIElement::isTextMarkerValid):
1536         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1537         (WTR::AccessibilityUIElement::indexForTextMarker):
1538         (WTR::AccessibilityUIElement::isTextMarkerValid):
1539         (WTR::AccessibilityUIElement::textMarkerForIndex):
1540         (WTR):
1541         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1542         (AccessibilityUIElement):
1543         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1544         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1545         (WTR):
1546         (WTR::AccessibilityUIElement::indexForTextMarker):
1547         (WTR::AccessibilityUIElement::isTextMarkerValid):
1548         (WTR::AccessibilityUIElement::textMarkerForIndex):
1549
1550 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1551
1552         Unreviewed, rolling out r112014.
1553         http://trac.webkit.org/changeset/112014
1554         https://bugs.webkit.org/show_bug.cgi?id=82138
1555
1556         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
1557         #webkit).
1558
1559         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1560         (ManagerTest.test_http_locking):
1561         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1562         (AbstractWorker.run):
1563         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1564         (Worker.__init__):
1565         (Worker.safe_init):
1566         (Worker.run):
1567         (Worker.cleanup):
1568         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1569         (WorkerTest.test_default_platform_in_worker):
1570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1571         (run):
1572         (main):
1573         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1574         (MeteredStream):
1575         (MeteredStream.is):
1576         (MeteredStream.__init__):
1577         (MeteredStream.write):
1578         (MeteredStream.update):
1579         (MeteredStream._overwrite):
1580         (MeteredStream._reset):
1581         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1582         (TestMeteredStream):
1583         (TestMeteredStream.test_regular):
1584         * Scripts/webkitpy/layout_tests/views/printing.py:
1585         (_configure_logging):
1586         (_restore_logging):
1587         (Printer.__init__):
1588         (Printer.cleanup):
1589         (Printer.print_progress):
1590         (Printer.print_update):
1591         (Printer._write):
1592         (Printer):
1593         (Printer._update):
1594         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1595         (TestUtilityFunctions.assertEmpty):
1596         (TestUtilityFunctions):
1597         (TestUtilityFunctions.assertNotEmpty):
1598         (TestUtilityFunctions.assertWritten):
1599         (TestUtilityFunctions.test_configure_logging):
1600         (Testprinter.get_printer):
1601         (Testprinter.test_print_progress):
1602         (Testprinter.test_print_progress.mock_time):
1603         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1604         (PerfTestsRunner.__init__):
1605         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1606         (test_run_test_pause_before_testing):
1607
1608 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1609
1610         [wx] Unreviewed. Fix the build after WTF move.
1611
1612         * waf/build/build_utils.py:
1613         (get_excludes):
1614         (get_excludes_in_dirs):
1615         * waf/build/settings.py:
1616         (get_port_excludes):
1617         (common_configure):
1618
1619 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
1620
1621         clean up NRWT logging/metering, be less verbose
1622         https://bugs.webkit.org/show_bug.cgi?id=73846
1623
1624         Reviewed by Ojan Vafai.
1625
1626         This patch totally rewrites the metered_stream module and
1627         changes the way it and the printing module now interact with the
1628         logging subsystem.
1629
1630         The printing module becomes a dumb layout_tests-specific wrapper around
1631         the metered stream. All of the intelligence of how and when to
1632         actually write (or erase) lines and how things interact with
1633         logging moves into the metered stream.
1634
1635         As of now, anything written to the metered stream *bypasses the
1636         logging system*. If a logger is passed to the meter constructor,
1637         the metered stream will also attach a log handler so that all
1638         messages fed to the logger will also be written to the metered
1639         stream. This detangles the logic that used to exist where
1640         sometimes the meter would write to the logger and sometimes the
1641         logger would write to the meter.
1642
1643         All of this makes the logic generic and reusable for
1644         test-webkitpy (coming in another patch). It also helps clarify
1645         what the mysterious "configure_logging" parameter to the printer
1646         constructor used to do (that parameter itself is gone now, and
1647         by default the printer and metered_stream will not ever touch
1648         the logging system; this makes a bunch of tests less fragile).
1649
1650         All of the above should produce no user-visible changes.
1651
1652         However, to also fix the bug in question, we change the message
1653         format in --verbose mode to %H:%M:%S.%frac %pid %message,
1654         eliminating the date, file:lineno, and level parameters. I am
1655         making this change at the same time because it would be
1656         difficult to write things consistently between the logs and the
1657         metered stream if we were still logging the file:lineno.
1658
1659         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1660           Remove the configure_logging parameter
1661         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1662           Use metered stream to configure the logging (we don't need a printer)
1663           and be careful about when and how we manipulate the log level
1664           and handlers on the root logger.
1665         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1666           Pass in the root logger so that log messages are formatted
1667           properly, and set the log level outside of any routines called
1668           by unit tests so as to not interfere.
1669         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
1670           remove a duplicate log message.
1671         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1672           complete rewrite :).
1673         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1674           complete rewrite :).
1675         * Scripts/webkitpy/layout_tests/views/printing.py:
1676           move the logging configuration into metered_stream, and also
1677           move the "when should I log progress messages" into metered stream.
1678         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1679           remove tests that are no longer necessary.
1680         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1681           remove the configure_logging parameter.
1682         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1683           update the test; since the printer no longer writes to the log,
1684           we need to check what is written to the regular_output instead.
1685           (test_run_test_pause_before_testing):
1686
1687 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
1688
1689         Add myself and Martin Robinson to:
1690           * GStreamerGraphics
1691           * GtkWebKit2PublicAPI
1692           * SoupNetwork
1693         and to the newly created WebKitGTKTranslations.
1694
1695         Rubber-stamped by Martin Robinson.
1696
1697         * Scripts/webkitpy/common/config/watchlist:
1698
1699 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1700
1701         [Qt][WK2] Implement PageClient::isViewWindowActive()
1702         https://bugs.webkit.org/show_bug.cgi?id=81143
1703
1704         Reviewed by Kenneth Rohde Christiansen.
1705
1706         Fix the WrapperWindow from our PlatformWebView
1707         so it correctly creates the platform related
1708         stuff for QWindow, which is not created unless
1709         QWindow::setVisible() or QWindow::show() are called.
1710
1711         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1712         (WTR::PlatformWebView::PlatformWebView):
1713
1714 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
1715
1716         nrwt: don't wait for safari to exit before exiting after showing the results file
1717         https://bugs.webkit.org/show_bug.cgi?id=81845
1718
1719         Reviewed by Ryosuke Niwa.
1720
1721         Prior to this change, if you ran new-run-webkit-tests and
1722         displayed the HTML results file at the end, we would block
1723         waiting for the user to quit the browser. There doesn't seem to
1724         be a need for that, and the Chromium ports don't do this.
1725
1726         Also, update the mac tests to capture the output and be quiet :).
1727
1728         * Scripts/webkitpy/common/system/executive_mock.py:
1729           Make popen() testable, implement should_log for it.
1730         * Scripts/webkitpy/layout_tests/port/mac.py:
1731         (MacPort.show_results_html_file):
1732         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1733           Silence some of the tests via outputcapture.
1734
1735 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
1736
1737         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
1738         https://bugs.webkit.org/show_bug.cgi?id=82073
1739
1740         Reviewed by Martin Robinson.
1741
1742         * Scripts/webkitdirs.pm:
1743         (jhbuildConfigurationChanged): new function that isolates the
1744         jhbuild configuration change checking from the autogen logic.
1745         (mustReRunAutogen): code for the new function lived here.
1746         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
1747         itself, and cleans up the jhbuild root if configuration has
1748         changed; it also forces autogen to be run in that case, to
1749         make sure the new libraries are used.
1750         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
1751         * jhbuild/jhbuild-wrapper:
1752         (ensure_jhbuild): this might be run inside a jhbuild environment,
1753         in which case aclocal fails when trying to use the now deleted
1754         aclocal directory in the jhbuild prefix, so work around that.
1755
1756 2012-03-23  Ojan Vafai  <ojan@chromium.org>
1757
1758         garden-o-matic scrolls to the top of the page when you click an accordion item
1759         https://bugs.webkit.org/show_bug.cgi?id=82088
1760
1761         Reviewed by Adam Barth.
1762
1763         Check the scroll position and make sure that the clicked accordion item is visible.
1764
1765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1766
1767 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
1768
1769         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
1770         https://bugs.webkit.org/show_bug.cgi?id=80567
1771
1772         Reviewed by Ryosuke Niwa.
1773
1774         Move clean_up_run to occur right after we finish testing and
1775         before we start processing the results. Also makes set_up_run()
1776         and clean_up_run() private since there's no real need for
1777         callers to be aware of them.
1778
1779         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1780         (Manager._set_up_run):
1781         (Manager.run):
1782         (Manager._clean_up_run):
1783         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1784         (ManagerTest.test_http_locking):
1785         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1786         (run):
1787
1788 2012-03-23  Dean Jackson  <dino@apple.com>
1789
1790         Disable CSS_SHADERS in Apple builds
1791         https://bugs.webkit.org/show_bug.cgi?id=81996
1792
1793         Reviewed by Simon Fraser.
1794
1795         Default enableCSSShaders to be 0 on all builds that use
1796         this script. Use the flag to turn it back on.
1797
1798         * Scripts/build-webkit:
1799
1800 2012-03-23  Tony Chang  <tony@chromium.org>
1801
1802         [chromium] rename newwtf target back to wtf
1803         https://bugs.webkit.org/show_bug.cgi?id=82064
1804
1805         Reviewed by Adam Barth.
1806
1807         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1808
1809 2012-03-23  Jessie Berlin  <jberlin@apple.com>
1810
1811         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
1812         the Lion Intel WebKit2 Debug bots.
1813         https://bugs.webkit.org/show_bug.cgi?id=81012.
1814
1815         Rubber-stamped by Dan Bernstein.
1816
1817         Add a step to kill the pasteboard server while we investigate what is causing these
1818         assertion failures (to get the bots green).
1819
1820         * BuildSlaveSupport/kill-old-processes:
1821
1822 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
1823
1824         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
1825         https://bugs.webkit.org/show_bug.cgi?id=81986
1826
1827         Reviewed by David Levin.
1828
1829         Track whether or not errors are filtered in error handlers. If an
1830         alphabetical sorting error is reported for a header and filtered, try
1831         reporting it for the other potential source of the error. This ensures
1832         that the style bot can still find new sorting errors in both potential
1833         situations:
1834
1835             #include <foo.h> <-- 1. edited line
1836             #include <baz.h> <-- 2. edited line
1837
1838         * Scripts/webkitpy/style/checkers/cpp.py:
1839         (check_include_line): Potentially report the error for both lines,
1840         if the first error is filtered.
1841         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
1842         test that allows only reporting errors for certain lines. This verifies that
1843         when one line of an ordering error is filtered, the error is reported on the
1844         other line.
1845         (ErrorCollector.__init__):
1846         (ErrorCollector.__call__):
1847         (CppStyleTestBase.perform_lint):
1848         (CppStyleTestBase.perform_language_rules_check):
1849         (CppStyleTestBase.assert_language_rules_check):
1850         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
1851         Added a new test that verifies that when one line of the two lines of an ordering
1852         error occur, the error is reported on the other line.
1853         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1854         (MockErrorHandler.__call__): Report True because the error is handled.
1855         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1856         (ErrorCollector.__call__): Ditto.
1857         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1858         (MockErrorHandler.__call__): Ditto.
1859         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1860         (TestErrorHandler.__call__): Ditto.
1861         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1862         (MockErrorHandler.__call__): Ditto.
1863         * Scripts/webkitpy/style/error_handlers.py:
1864         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
1865         and False if it is filtered.
1866
1867 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
1868
1869         Build fix for WinCE after r111778.
1870
1871         * WinCELauncher/CMakeLists.txt:
1872
1873 2012-03-23  Peter Beverloo  <peter@chromium.org>
1874
1875         Unreviewed buildfix for the Chromium Android builder.
1876
1877         Disable the ImageDiff target for now. Android needs to build this for
1878         host rather than for target (as other configurations do), but since the
1879         WTF move the dependency chain got significantly more complicated.
1880
1881         I'll work out a proper fix in the following bug, but since several
1882         things are broken due to this, this buildfix should be landed first.
1883         https://bugs.webkit.org/show_bug.cgi?id=82039
1884
1885         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1886
1887 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1888
1889         [EFL][DRT] Implement LayoutTestController's methods related with editing.
1890         https://bugs.webkit.org/show_bug.cgi?id=80136
1891
1892         Reviewed by Ryosuke Niwa.
1893
1894         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
1895         setSelectTrailingWhitespaceEnabled.
1896
1897         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1898         (LayoutTestController::setSmartInsertDeleteEnabled):
1899         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1900
1901 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1902
1903         Convert hasGrammarMarker to use Internals interface
1904         https://bugs.webkit.org/show_bug.cgi?id=82004
1905
1906         Reviewed by Ryosuke Niwa.
1907
1908         Remove hasGrammarMarker functions, because it is able to work in the
1909         cross-port way through the Internals interface.
1910
1911         * DumpRenderTree/LayoutTestController.cpp:
1912         (LayoutTestController::staticFunctions):
1913         * DumpRenderTree/LayoutTestController.h:
1914         (LayoutTestController):
1915         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1916         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1917         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1918         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1919         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1920         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1921
1922 2012-03-22  Adam Barth  <abarth@webkit.org>
1923
1924         sync-master-with-upstream creates non-linear git history
1925         https://bugs.webkit.org/show_bug.cgi?id=82006
1926
1927         Reviewed by Julien Chaffraix.
1928
1929         Previously this script would create a merge commit at the HEAD of
1930         origin/master, causing your fork of WebKit to diverge from upstream.
1931         The new version of this script pushes directly from upstream to origin
1932         (without round-tripping through any local branches), avoiding this
1933         problem.
1934
1935         * Scripts/sync-master-with-upstream:
1936
1937 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
1938
1939         Unreviewed build fix. Add knowledge of the WTF project to
1940         the autotools build system scripts so that build-jsc works
1941         correctly for GTK+.
1942
1943         * Scripts/webkitdirs.pm:
1944         (buildAutotoolsProject): handle the WTF project, build the
1945         libWTF.la target.
1946         (buildGtkProject): add WTF to the list of supported projects.
1947
1948 2012-03-22  Eric Seidel  <eric@webkit.org>
1949
1950         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
1951         https://bugs.webkit.org/show_bug.cgi?id=81984
1952
1953         Reviewed by Adam Barth.
1954
1955         * Scripts/VCSUtils.pm:
1956         (adjustPathForRecentRenamings):
1957
1958 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1959
1960         [CMake] Fix build-jsc after r111778 and r111797.
1961         https://bugs.webkit.org/show_bug.cgi?id=82001
1962
1963         Reviewed by Filip Pizlo.
1964
1965         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
1966         does return if no error occurred, and build-jsc failed with
1967         "building not defined for this platform".
1968
1969         * Scripts/build-jsc: Always exit after caling
1970         buildCMakeProjectOrExit().
1971         * Scripts/webkitdirs.pm:
1972         (buildCMakeProjectOrExit): Return 0 if no error occurred.
1973
1974 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1975
1976         [CMake] Unreviewed build fix after r111778.
1977
1978         * DumpRenderTree/efl/CMakeLists.txt: Replace
1979         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
1980         paths.
1981         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
1982         wtf include.
1983         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
1984         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
1985         with ${WTF_DIR}/wtf in the include paths.
1986
1987 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
1988
1989         Tools/Scripts/build-jsc doesn't work after WTF move
1990         https://bugs.webkit.org/show_bug.cgi?id=81999
1991
1992         Reviewed by Eric Seidel.
1993         
1994         For ports that require WTF and JSC to be built as two projects and where
1995         the machinery to build both does not already exist, teach the tool to do
1996         so for us.
1997
1998         * Scripts/build-jsc:
1999         (buildMyProject):
2000
2001 2012-03-22  Ojan Vafai  <ojan@chromium.org>
2002
2003         Fix accidental missing line in r111793.
2004
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2007         Remove base.values. It was unused and duplicates the builtin Object.values.
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2009         Accidentally deleted this line before committing r111793.
2010
2011 2012-03-22  Ojan Vafai  <ojan@chromium.org>
2012
2013         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
2014         https://bugs.webkit.org/show_bug.cgi?id=81983
2015
2016         Reviewed by Adam Barth.
2017
2018         The dialogs get in the way if you are doing multiple rebaselines. Also,
2019         a number of people didn't realize that you could do multiple rebaselines
2020         in parallel. A non-modal dialog is just confusing.
2021
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2024         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
2025         show the number of tests being rebaselined.
2026
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2028         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
2029         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
2030         into a single area.
2031
2032         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
2033         also serves to clear all teh content in the StatusArea. 
2034
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2037
2038 2012-03-22  Tony Chang  <tony@chromium.org>
2039
2040         Unreviewed, fix chromium build after wtf move.
2041
2042         Only use newwtf, remove references to wtf.
2043
2044         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2045
2046 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2047
2048         Actually move WTF files to their new home
2049         https://bugs.webkit.org/show_bug.cgi?id=81844
2050
2051         [Qt] Unreviewed buildfix after r111778.
2052
2053         * DumpRenderTree/qt/DumpRenderTree.pro:
2054
2055 2012-03-22  Dan Bernstein  <mitz@apple.com>
2056
2057         Font fallback in WebKitTestRunner depends on user settings
2058         https://bugs.webkit.org/show_bug.cgi?id=81978
2059
2060         Reviewed by Jessie Berlin.
2061
2062         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2063         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
2064         with a value consisting of the array ("en") to the override defaults
2065         dictionary. This is the same value used in DumpRenderTree, and it
2066         ensures that font fallback follows a consistent path that is not
2067         affected by the language preferences of the user running the test.
2068
2069 2012-03-22  Andy Estes  <aestes@apple.com>
2070
2071         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
2072         https://bugs.webkit.org/show_bug.cgi?id=81971
2073
2074         Reviewed by Dan Bernstein.
2075
2076         Xcode will automatically link ObjC binaries against libarclite in some
2077         cases, which defines a class called __ARCLite__.
2078         check-for-inappropriate-objc-class-names shouldn't complain about this
2079         class name.
2080
2081         * Scripts/check-for-inappropriate-objc-class-names:
2082
2083 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2084
2085         new-run-webkit-tests blames the wrong test for crashing
2086         https://bugs.webkit.org/show_bug.cgi?id=81951
2087
2088         Reviewed by Adam Barth.
2089
2090         NRWT wasn't extracting the WebProcess pid correct; should've
2091         used re.search instead of re.match :(. Add more tests!
2092
2093         * Scripts/webkitpy/layout_tests/port/mac.py:
2094         (MacPort._get_crash_log):
2095         * Scripts/webkitpy/layout_tests/port/webkit.py:
2096         (WebKitDriver.has_crashed):
2097         (WebKitDriver._check_for_driver_crash):
2098         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2099         (WebKitDriverTest.test_no_timeout):
2100         (WebKitDriverTest):
2101         (WebKitDriverTest.test_check_for_driver_crash):
2102         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
2103         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
2104         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
2105         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
2106         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
2107         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2108
2109 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2110
2111         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
2112         https://bugs.webkit.org/show_bug.cgi?id=81512
2113
2114         Adding missing implementation markerTextForListItem to EFL's
2115         LayoutTestController so that we can unskip related tests from
2116         the skip list.
2117
2118         Reviewed by Antonio Gomes.
2119
2120         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2121         (LayoutTestController::markerTextForListItem): Implemented.
2122
2123 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2124
2125         [EFL] Enable view mode media feature layout tests
2126         https://bugs.webkit.org/show_bug.cgi?id=81205
2127
2128         Adding missing implementation setViewModeMediaFeature to EFL's 
2129         LayoutTestController so that we can unskip view mode 
2130         media feature layout tests.
2131
2132         Reviewed by Antonio Gomes.
2133
2134         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2135         (LayoutTestController::setViewModeMediaFeature): Implemented.
2136
2137 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2138
2139         nrwt: crash while stopping layout test helper on apple mac lion
2140         https://bugs.webkit.org/show_bug.cgi?id=81949
2141
2142         Reviewed by Eric Seidel.
2143
2144         stop_helper() didn't work right if the helper process wasn't
2145         still running or didn't respond properly to being shut down. Fix
2146         this and add some tests. Also add code to MockExecutive() to be
2147         able to mock executive.popen() properly.
2148
2149         * Scripts/webkitpy/common/system/executive_mock.py:
2150         (MockProcess.__init__):
2151         (MockProcess.wait):
2152         (MockExecutive.__init__):
2153         (MockExecutive.popen):
2154         * Scripts/webkitpy/common/system/systemhost_mock.py:
2155         (MockSystemHost.__init__):
2156         * Scripts/webkitpy/layout_tests/port/mac.py:
2157         (MacPort.start_helper):
2158         (MacPort.stop_helper):
2159         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2160         (test_get_crash_log):
2161         (test_helper_starts):
2162         (test_helper_fails_to_start):
2163         (test_helper_fails_to_stop):
2164         (test_helper_fails_to_stop.bad_waiter):
2165
2166 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
2167
2168         [GTK] Add make to the jhbuild moduleset
2169         https://bugs.webkit.org/show_bug.cgi?id=81769
2170
2171         Reviewed by Martin Robinson.
2172
2173         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
2174         Add GNU make with custom patches to fix several issues:
2175
2176         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
2177           fix the argument list limit of GNU make when running make
2178           distcheck.
2179         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
2180           and Jeremy Devenport to fix parallel build issues present in
2181           GNU make 3.82
2182
2183         * gtk/jhbuild.modules: Added make with patches.
2184         * gtk/patches/make-3.82-arg-list-length.patch: Added.
2185         * gtk/patches/make-3.82-parallel-build.patch: Added.
2186
2187 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
2188
2189         [wx] Unreviewed. Adding Source/WTF to the build and updating
2190         waf port list.
2191
2192         * DumpRenderTree/wscript:
2193         * waf/build/settings.py:
2194
2195 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2196
2197         Re-land fix for r81603 yet again (!) with latest build fix.
2198         https://bugs.webkit.org/show_bug.cgi?id=81603
2199
2200         Unreviewed, build fix.
2201
2202         The latest problem was a bad sprintf() in
2203         BasePort._get_crash_log(). I've reworked that routine and added
2204         unit tests for coverage.
2205
2206         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2207         (SingleTestRunner._handle_error):
2208         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2209         (write_test_result):
2210         (TestResultWriter.write_crash_log):
2211         * Scripts/webkitpy/layout_tests/port/base.py:
2212         (Port.diff_text):
2213         (Port._get_crash_log):
2214         * Scripts/webkitpy/layout_tests/port/chromium.py:
2215         (ChromiumDriver.run_test):
2216         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2217         (ChromiumDriverTest.test_crash_log):
2218         * Scripts/webkitpy/layout_tests/port/driver.py:
2219         (DriverOutput.__init__):
2220         * Scripts/webkitpy/layout_tests/port/mac.py:
2221         (MacPort.is_lion):
2222         (MacPort._get_crash_log):
2223         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2224         (test_default_child_processes):
2225         (test_get_crash_log):
2226         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2227         (MockDRTPortTest.test_get_crash_log):
2228         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2229         (PortTestCase.test_get_crash_log):
2230         * Scripts/webkitpy/layout_tests/port/test.py:
2231         (TestDriver.run_test):
2232         * Scripts/webkitpy/layout_tests/port/webkit.py:
2233         (WebKitDriver.__init__):
2234         (WebKitDriver._start):
2235         (WebKitDriver.has_crashed):
2236         (WebKitDriver._check_for_driver_crash):
2237         (WebKitDriver.run_test):
2238
2239 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
2240
2241         [Qt] Enable support for handling database quota's in the MiniBrowser
2242         https://bugs.webkit.org/show_bug.cgi?id=81928
2243
2244         Reviewed by Simon Hausmann.
2245
2246         * MiniBrowser/qt/qml/BrowserWindow.qml:
2247
2248 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2249
2250         [EFL] Implement LayoutTestController::setEditingBehavior
2251         https://bugs.webkit.org/show_bug.cgi?id=81124
2252
2253         Adding missing implementation setEditingBehavior to EFL's
2254         LayoutTestController. This implementation allows us to
2255         unskip some tests from the skip list.
2256
2257         Reviewed by Martin Robinson.
2258
2259         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2260         (LayoutTestController::setEditingBehavior): Implemented.
2261
2262 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
2263
2264         [GTK] Use the angle-bracket form to include wtf headers
2265         https://bugs.webkit.org/show_bug.cgi?id=81884
2266
2267         Reviewed by Eric Seidel.
2268
2269         Use #include <wtf/foo> instead of #include "foo".
2270
2271         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2272         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2274         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2275         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2276         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2277
2278 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
2279
2280         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
2281
2282         * Scripts/webkitpy/common/config/committers.py:
2283
2284 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2285
2286         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
2287         https://bugs.webkit.org/show_bug.cgi?id=81889
2288
2289         Reviewed by Kenneth Rohde Christiansen.
2290
2291         Enable FAST_MOBILE_SCROLLING feature.
2292
2293         * qmake/mkspecs/features/features.prf:
2294
2295 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2296
2297         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
2298         https://bugs.webkit.org/show_bug.cgi?id=81900
2299
2300         Reviewed by Gustavo Noronha Silva.
2301
2302         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
2303         path which assumed a certain directory structure for the build
2304         directory which may noy be true.
2305
2306         Instead, hardcode the path to the downloaded fonts starting from the
2307         top-level source directory. While this solution is also far from
2308         perfect, it makes it more consistent and reliable, and easier to
2309         tackle at once with the rest of bug 81475.
2310
2311         * DumpRenderTree/efl/CMakeLists.txt:
2312
2313 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
2316         https://bugs.webkit.org/show_bug.cgi?id=81888
2317
2318         Reviewed by Philippe Normand.
2319
2320         * Scripts/update-webkit-libs-jhbuild:
2321         (runJhbuild): Helper function to run jhbuild with a given command.
2322         Instead of running jhbuild directly, use the jhbuild-wrapper, so
2323         that we don't need to run it first to check whether jhbuild is
2324         installed or not.
2325         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
2326         * gtk/run-with-jhbuild: Ditto.
2327         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
2328         not only run.
2329
2330 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2331
2332         Unreviewed, test-webkitpy fix after r111661.
2333
2334         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2335         (MainTest.test_crash_log):
2336         (MainTest.test_web_process_crash_log):
2337
2338 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2339
2340         Unreviewed, test-webkitpy fix after r111642.
2341
2342         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2343         (ChromiumDriverTest.setUp):
2344         (ChromiumDriverTest.test_two_drivers):
2345
2346 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2347
2348         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2349         https://bugs.webkit.org/show_bug.cgi?id=81603
2350
2351         Unreviewed rolling out r111609 and part of r111615,
2352         because it broke NRWT on Qt-WK2 platform.
2353
2354         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2355         (SingleTestRunner._handle_error):
2356         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2357         (write_test_result):
2358         (TestResultWriter.write_crash_report):
2359         * Scripts/webkitpy/layout_tests/port/base.py:
2360         (Port.is_crash_reporter):
2361         (Port._driver_class):
2362         * Scripts/webkitpy/layout_tests/port/chromium.py:
2363         (ChromiumDriver.run_test):
2364         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2365         (ChromiumDriverTest.test_crashed_process_name):
2366         * Scripts/webkitpy/layout_tests/port/driver.py:
2367         (DriverOutput.__init__):
2368         * Scripts/webkitpy/layout_tests/port/mac.py:
2369         (MacPort):
2370         (MacPort.is_crash_reporter):
2371         (MacPort.release_http_lock):
2372         * Scripts/webkitpy/layout_tests/port/test.py:
2373         (TestDriver.run_test):
2374         * Scripts/webkitpy/layout_tests/port/webkit.py:
2375         (WebKitDriver.__init__):
2376         (WebKitDriver._start):
2377         (WebKitDriver.has_crashed):
2378         (WebKitDriver._check_for_driver_crash):
2379         (WebKitDriver.run_test):
2380
2381 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2382
2383         [Qt] Add full platforms to Qt buildslaves
2384         https://bugs.webkit.org/show_bug.cgi?id=81877
2385
2386         Reviewed by Ryosuke Niwa.
2387
2388         * BuildSlaveSupport/build.webkit.org-config/config.json:
2389
2390 2012-03-21  Johnny Ding  <jnd@chromium.org>
2391
2392         Customize layout test timeout value for different ports.
2393         https://bugs.webkit.org/show_bug.cgi?id=79859
2394
2395         Reviewed by Ojan Vafai.
2396
2397         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2398         (Manager):
2399         * Scripts/webkitpy/layout_tests/port/base.py:
2400         (Port.default_test_timeout_ms):
2401         * Scripts/webkitpy/layout_tests/port/chromium.py:
2402         (ChromiumDriver.stop):
2403         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2404         (ChromiumAndroidPort.default_test_timeout_ms):
2405         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2406         (_set_up_derived_options):
2407
2408 2012-03-21  Mark Rowe  <mrowe@apple.com>
2409
2410         Fix the build.
2411
2412         Ensure that our test tools don't try and use RTTI unnecessarily.
2413
2414         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2415         * TestWebKitAPI/Configurations/Base.xcconfig:
2416         * WebKitTestRunner/Configurations/Base.xcconfig:
2417
2418 2012-03-21  Adam Barth  <abarth@webkit.org>
2419
2420         WebKit should have some scripts to smooth interactions with GitHub
2421         https://bugs.webkit.org/show_bug.cgi?id=81842
2422
2423         Reviewed by Eric Seidel.
2424
2425         These scripts support the workflow in
2426         https://trac.webkit.org/wiki/UsingGitHub by automating the
2427         configuration and syncing operations needed for a GitHub fork of WebKit
2428         to track the main WebKit repository.
2429
2430         * Scripts/configure-github-as-upstream: Added.
2431         * Scripts/sync-master-with-upstream: Added.
2432
2433 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2434
2435         WTR - log the pid of a crashing WebProcess
2436         https://bugs.webkit.org/show_bug.cgi?id=81575
2437
2438         Reviewed by Alexey Proskuryakov.
2439
2440         This allows run-webkit-tests to find the right crash log for a
2441         given crashed WebProcess in WebKit2.
2442
2443         * WebKitTestRunner/TestController.cpp:
2444         (WTR::exceededDatabaseQuota):
2445         (WTR::TestController::createOtherPage):
2446         (WTR::TestController::initialize):
2447         (WTR::TestController::resetStateToConsistentValues):
2448         (WTR::TestController::runTest):
2449         (WTR::TestController::processDidCrash):
2450
2451 2012-03-21  Enrica Casucci  <enrica@apple.com>
2452
2453         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
2454         https://bugs.webkit.org/show_bug.cgi?id=81835
2455         <rdar://problem/11082749>
2456
2457         Reviewed by Brady Eidson.
2458
2459         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2460         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2461         (TestWebKitAPI::contextMenuCopyLink):
2462
2463 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
2464
2465         [CSS Shaders] Make CSS Shaders compile on Chromium
2466         https://bugs.webkit.org/show_bug.cgi?id=81435
2467
2468         Reviewed by Stephen White.
2469         
2470         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
2471
2472         * DumpRenderTree/chromium/LayoutTestController.cpp:
2473         (LayoutTestController::overridePreference):
2474         * DumpRenderTree/chromium/WebPreferences.cpp:
2475         (WebPreferences::reset):
2476         (WebPreferences::applyTo):
2477         * DumpRenderTree/chromium/WebPreferences.h:
2478         (WebPreferences):
2479
2480 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2481
2482         fix regression on gtk port introduced by r111609
2483         https://bugs.webkit.org/show_bug.cgi?id=81839
2484
2485         Reviewed by Philippe Normand.
2486
2487         r111609 should've initialized a couple of missing fields in
2488         WebKitDriver, and also should've checked for method overrides
2489         in the other ports :(.
2490
2491         * Scripts/webkitpy/layout_tests/port/gtk.py:
2492         (GtkDriver._start):
2493         * Scripts/webkitpy/layout_tests/port/webkit.py:
2494         (WebKitDriver.__init__):
2495         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2496         (MainTest.test_crash_log):
2497         (MainTest.test_web_process_crash_log):
2498
2499 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2500
2501         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2502         https://bugs.webkit.org/show_bug.cgi?id=81603
2503
2504         Reviewed by Adam Barth.
2505
2506         Add a new _get_crash_log() overridable method on the Port
2507         object to customize how we fetch crash logs per port.
2508         Mac will now slow-spin with a timeout waiting for the crash log, rather
2509         than waiting for the ReportCrash process to exit (it appears
2510         that the mac will manage multiple crashes with a single
2511         ReportCrash process, the process waits around longer than
2512         necessary, presumably to avoid thrashing if processes are
2513         repeatedly crashing).
2514
2515         Also, add the DriverOutput should contain the crash log and other info,
2516         which is created in a port-specific manner but can then be
2517         treated generically. Previously single_test_runner would get
2518         told that something crashed and attempt to do something to get
2519         the crash log, but it didn't have the information it needed to
2520         od the right thing; better to make the driver hand back the
2521         right info.
2522
2523         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2524         (SingleTestRunner._handle_error):
2525         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2526         (write_test_result):
2527         (TestResultWriter.write_crash_log):
2528         * Scripts/webkitpy/layout_tests/port/base.py:
2529         (Port.diff_text):
2530         (Port._get_crash_log):
2531         * Scripts/webkitpy/layout_tests/port/chromium.py:
2532         (ChromiumDriver.run_test):
2533         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2534         (ChromiumDriverTest.test_crash_log):
2535         * Scripts/webkitpy/layout_tests/port/driver.py:
2536         (DriverOutput.__init__):
2537         * Scripts/webkitpy/layout_tests/port/mac.py:
2538         (MacPort.is_lion):
2539         (MacPort._get_crash_log):
2540         * Scripts/webkitpy/layout_tests/port/test.py:
2541         (TestDriver.run_test):
2542         * Scripts/webkitpy/layout_tests/port/webkit.py:
2543         (WebKitDriver.__init__):
2544         (WebKitDriver._start):
2545         (WebKitDriver.has_crashed):
2546         (WebKitDriver._check_for_driver_crash):
2547         (WebKitDriver.run_test):
2548
2549 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2550
2551         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
2552         https://bugs.webkit.org/show_bug.cgi?id=81507
2553
2554         Now that we're only loading from one directory, no need to
2555         iterate over a list of directories anymore.
2556
2557         Reviewed by Martin Robinson.
2558
2559         * DumpRenderTree/efl/CMakeLists.txt:
2560         * DumpRenderTree/efl/FontManagement.cpp:
2561         (addFontDirectory):
2562         (addFontsToEnvironment):
2563
2564 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2565
2566         webkitpy: get ServerProcess out of the reportcrash business
2567         https://bugs.webkit.org/show_bug.cgi?id=81600
2568
2569         Unreviewed, build fix.
2570
2571         Re-land r111307 and r111293 with another fix for a crash in NRWT;
2572         we need to check if the driver has crashed before attempting to
2573         read from it.
2574
2575
2576         * Scripts/webkitpy/layout_tests/port/server_process.py:
2577         (ServerProcess._reset):
2578         (ServerProcess._handle_possible_interrupt):
2579         (ServerProcess.write):
2580         (ServerProcess.read_stdout):
2581         (ServerProcess.has_crashed):
2582         (ServerProcess._read):
2583         (ServerProcess.stop):
2584         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2585         (TrivialMockPort.check_for_leaks):
2586         (TestServerProcess.test_broken_pipe):
2587         * Scripts/webkitpy/layout_tests/port/webkit.py:
2588         (WebKitPort._read_image_diff):
2589         (WebKitDriver.has_crashed):
2590         (WebKitDriver._check_for_driver_crash):
2591         (WebKitDriver.run_test):
2592         (WebKitDriver._read_block):
2593         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2594         (MockServerProcess.__init__):
2595         (MockServerProcess):
2596         (MockServerProcess.has_crashed):
2597
2598 2012-03-21  Zeno Albisser  <zeno@webkit.org>
2599
2600         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
2601         https://bugs.webkit.org/show_bug.cgi?id=81750
2602
2603         Building WebCore on mac currently creates an archive that is bigger than
2604         4GB. But ranlib fails to create a symbol table for such a big archive,
2605         even on 64bit machines.
2606         Therefore we start using SVGAllInOne.cpp when building debug
2607         on mac. This reduces the size of the archive by about 300MB.
2608
2609         Reviewed by Tor Arne Vestbø.
2610
2611         * qmake/mkspecs/features/mac/default_pre.prf:
2612
2613 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
2614
2615         Updated the address list of committers.py.
2616
2617         Reviewed by Csaba Osztrogonác.
2618
2619         * Scripts/webkitpy/common/config/committers.py:
2620
2621 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
2622
2623         Updating my nick in committers file.
2624
2625         Unreviewed.
2626
2627         * Scripts/webkitpy/common/config/committers.py:
2628
2629 2012-03-21  Peter Beverloo  <peter@chromium.org>
2630
2631         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
2632         https://bugs.webkit.org/show_bug.cgi?id=80861
2633
2634         Reviewed by Tony Chang.
2635
2636         Remove most Android-specific logic from webkitdirs.pm in favor of
2637         handling this during project generation time.
2638
2639         * Scripts/webkitdirs.pm:
2640         (buildChromiumMakefile):
2641
2642 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2643
2644         [GTK] Allow running javascript from location bar in MiniBrowser
2645         https://bugs.webkit.org/show_bug.cgi?id=81331
2646
2647         Reviewed by Martin Robinson.
2648
2649         * MiniBrowser/gtk/BrowserWindow.c:
2650         (activateUriEntryCallback): Use browser_window_load_uri().
2651         (browser_window_load_uri): Check whether uri starts with
2652         javascript: and run the given script, or just call
2653         webkit_web_view_load_uri() to load the given uri.
2654         * MiniBrowser/gtk/BrowserWindow.h:
2655         * MiniBrowser/gtk/main.c:
2656         (createBrowserWindow): Use browser_window_load_uri().
2657
2658 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2659
2660         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
2661         https://bugs.webkit.org/show_bug.cgi?id=75543
2662
2663         Reviewed by Martin Robinson.
2664
2665         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
2666         MiniBrowser CPP flags.
2667
2668 2012-03-20  Eric Seidel  <eric@webkit.org>
2669
2670         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
2671         https://bugs.webkit.org/show_bug.cgi?id=80911
2672
2673         Reviewed by Adam Barth.
2674
2675         Update include paths for Source/WTF.
2676
2677         * DumpRenderTree/efl/CMakeLists.txt:
2678         * DumpRenderTree/qt/DumpRenderTree.pro:
2679         * QtTestBrowser/QtTestBrowser.pro:
2680         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
2681
2682 2012-03-20  Adam Barth  <abarth@webkit.org>
2683
2684         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
2685         https://bugs.webkit.org/show_bug.cgi?id=81567
2686
2687         Reviewed by Eric Seidel.
2688
2689         This temporary measure should help us avoid disrupting the folks
2690         working on WebAudio when we move the webaudio directory to Modules.
2691
2692         * Scripts/VCSUtils.pm:
2693         (adjustPathForRecentRenamings):
2694         (parseGitDiffHeader):
2695         (parseSvnDiffHeader):
2696
2697 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
2698
2699         Unreviewed, rolling out r111453.
2700         http://trac.webkit.org/changeset/111453
2701         https://bugs.webkit.org/show_bug.cgi?id=81600
2702
2703         still broken
2704
2705         * Scripts/webkitpy/layout_tests/port/server_process.py:
2706         (ServerProcess._reset):
2707         (ServerProcess.handle_interrupt):
2708         (ServerProcess.write):
2709         (ServerProcess._check_for_crash):
2710         (ServerProcess._handle_timeout):
2711         (ServerProcess._check_for_abort):
2712         (ServerProcess._read):
2713         (ServerProcess.stop):
2714         (ServerProcess):
2715         (ServerProcess.set_crashed):
2716         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2717         (TrivialMockPort.is_crash_reporter):
2718         (TestServerProcess.test_broken_pipe):
2719         * Scripts/webkitpy/layout_tests/port/webkit.py:
2720         (WebKitPort._read_image_diff):
2721         (WebKitDriver.has_crashed):
2722         (WebKitDriver._check_for_driver_crash):
2723         (WebKitDriver):
2724         (WebKitDriver._detected_crash):
2725         (WebKitDriver._subprocess_crashed):
2726         (WebKitDriver._crashed_process_name):
2727         (WebKitDriver.run_test):
2728         (WebKitDriver._read_block):
2729         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2730         (MockServerProcess.__init__):
2731
2732 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
2733
2734         webkitpy: get ServerProcess out of the reportcrash business
2735         https://bugs.webkit.org/show_bug.cgi?id=81600
2736
2737         Unreviewed, build fix.
2738
2739         Re-land r111307 and r111293 with fix for crash in NRWT; I
2740         was failing to set the crashing process name.
2741
2742         * Scripts/webkitpy/layout_tests/port/server_process.py:
2743         (ServerProcess._reset):
2744         (ServerProcess._handle_possible_interrupt):
2745         (ServerProcess.write):
2746         (ServerProcess.read_stdout):
2747         (ServerProcess.has_crashed):
2748         (ServerProcess._read):
2749         (ServerProcess.stop):
2750         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2751         (TrivialMockPort.check_for_leaks):
2752         (TestServerProcess.test_broken_pipe):
2753         * Scripts/webkitpy/layout_tests/port/webkit.py:
2754         (WebKitPort._read_image_diff):
2755         (WebKitDriver.has_crashed):
2756         (WebKitDriver._check_for_driver_crash):
2757         (WebKitDriver.run_test):
2758         (WebKitDriver._read_block):
2759         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2760         (MockServerProcess.__init__):
2761         (MockServerProcess):
2762         (MockServerProcess.has_crashed):
2763
2764 2012-03-20  Tim Horton  <timothy_horton@apple.com>
2765
2766         [mac] Restore color space switching code to run-webkit-tests
2767         https://bugs.webkit.org/show_bug.cgi?id=80571
2768         <rdar://problem/11008529>
2769
2770         Reviewed by Simon Fraser.
2771
2772         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
2773         
2774         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
2775         didn't exist until Lion.
2776
2777         * DumpRenderTree/mac/LayoutTestHelper.m:
2778         (installLayoutTestColorProfile):
2779         (restoreUserColorProfile):
2780
2781 2012-03-20  Adele Peterson  <adele@apple.com>
2782
2783         Update the last test to use EXPECT_WK_STREQ.
2784
2785         Reviewed by Dan Bernstein.
2786
2787         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
2788
2789 2012-03-20  Adele Peterson  <adele@apple.com>
2790
2791         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
2792         https://bugs.webkit.org/show_bug.cgi?id=81630
2793         <rdar://problem/10650660>
2794
2795         Reviewed by Alexey Proskuryakov.
2796
2797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2798         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
2799         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
2800         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
2801         (TestWebKitAPI):
2802         (TestWebKitAPI::didFinishLoadForFrame):
2803         (TestWebKitAPI::TEST):
2804         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
2805
2806 2012-03-20  Eric Seidel  <eric@webkit.org>
2807
2808         Add link on queues.webkit.org to kov's fancy queue-depth graph
2809         https://bugs.webkit.org/show_bug.cgi?id=81690
2810
2811         Reviewed by Adam Barth.
2812
2813         * QueueStatusServer/templates/recentstatus.html:
2814
2815 2012-03-20  Tim Horton  <timothy_horton@apple.com>
2816
2817         [mac] Restore color space switching code to run-webkit-tests
2818         https://bugs.webkit.org/show_bug.cgi?id=80571
2819         <rdar://problem/11008529>
2820
2821         Reviewed by Simon Fraser.
2822
2823         Make use of the layout test helper hooks to restore the Mac system-wide
2824         color profile switching code. This makes WkTR and DRT results match, and
2825         causes the main display's color profile to not affect results on Lion.
2826
2827         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2828         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
2829         (installLayoutTestColorProfile):
2830         (restoreUserColorProfile):
2831         (simpleSignalHandler):
2832         (main):
2833         * Scripts/webkitpy/layout_tests/port/mac.py:
2834         (MacPort.release_http_lock):
2835         (MacPort):
2836         (MacPort._path_to_helper):
2837         (MacPort.start_helper):
2838         (MacPort.stop_helper):
2839         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2840         (WTR::PlatformWebView::PlatformWebView):
2841         (WTR::PlatformWebView::windowSnapshotImage):
2842
2843 2012-02-24  Darin Fisher  <darin@chromium.org>
2844
2845         Add more Chromium WebKit API reviewers
2846         https://bugs.webkit.org/show_bug.cgi?id=81576
2847
2848         Reviewed by Adam Barth and David Levin.
2849
2850         Simplify watchlist to lump all WebKit API into one.
2851
2852         * Scripts/webkitpy/common/config/watchlist:
2853
2854 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2855
2856         Convert hasSpellingMarker to use Internals interface.
2857         https://bugs.webkit.org/show_bug.cgi?id=81300
2858
2859         Reviewed by Ryosuke Niwa.
2860
2861         Remove hasSpellingMarker functions, because it is able to work in the
2862         cross-port way through the Internals interface.
2863
2864         * DumpRenderTree/LayoutTestController.cpp:
2865         (LayoutTestController::staticFunctions):
2866         * DumpRenderTree/LayoutTestController.h:
2867         (LayoutTestController):
2868         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2869         * DumpRenderTree/chromium/LayoutTestController.cpp:
2870         (LayoutTestController::LayoutTestController):
2871         * DumpRenderTree/chromium/LayoutTestController.h:
2872         (LayoutTestController):
2873         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2874         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2875         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2876         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2877         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2878         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2879         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2880
2881 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2882
2883         Add new Qt-WK2 performance tester bot to build.webkit.org
2884         https://bugs.webkit.org/show_bug.cgi?id=80842
2885
2886         Reviewed by Ryosuke Niwa.
2887
2888         * BuildSlaveSupport/build.webkit.org-config/config.json:
2889         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2890         (RunAndUploadPerfTestsWebKit2):
2891         (RunAndUploadPerfTestsWebKit2.start):
2892         (BuildAndPerfTestWebKit2Factory):
2893         (BuildAndPerfTestWebKit2Factory.__init__):
2894         (DownloadAndPerfTestWebKit2Factory):
2895         (DownloadAndPerfTestWebKit2Factory.__init__):
2896
2897 2012-03-20  Peter Beverloo  <peter@chromium.org>
2898
2899         [Chromium] Update to Android NDK r7b
2900         https://bugs.webkit.org/show_bug.cgi?id=81005
2901
2902         Reviewed by Adam Barth.
2903
2904         Update to version r7b of the Android NDK, release notes of which are
2905         available on the following page:
2906         http://developer.android.com/sdk/ndk/index.html
2907
2908         * Scripts/update-webkit-chromium:
2909
2910 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
2911
2912         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
2913         https://bugs.webkit.org/show_bug.cgi?id=81502
2914
2915         Unreviewed.
2916
2917         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
2918
2919 2012-03-19  Jessie Berlin  <jberlin@apple.com>
2920
2921         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
2922         because they broke running the layout tests on mac.
2923
2924         * Scripts/webkitpy/layout_tests/port/webkit.py:
2925         (WebKitDriver._check_for_driver_crash):
2926
2927 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
2928
2929         [GTK] Allow running run-gtk-tests during 'make distcheck'
2930         https://bugs.webkit.org/show_bug.cgi?id=81415
2931
2932         Reviewed by Philippe Normand.
2933
2934         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
2935
2936         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
2937         main command run during 'make check.'
2938         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
2939         a requirement to run it. If jhbuild isn't around it will simply not start the
2940         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
2941         main loop and simply use the main loop in a synchronous method to start SPI
2942         daemons. Did a bunch of general cleanup around these tasks.
2943
2944 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2945
2946         jhbuild: Use the multiprocessing module to get the number of CPUs.
2947         https://bugs.webkit.org/show_bug.cgi?id=81585
2948
2949         Reviewed by Martin Robinson.
2950
2951         Now that support for Python 2.5 has been dropped, we can safely
2952         use multiprocessing.cpu_count() to obtain the current number of
2953         CPUs in the system instead of running a webkitperl script for
2954         that.
2955
2956         * efl/common.py:
2957         (top_level_path):
2958         * efl/jhbuildrc:
2959         * gtk/common.py:
2960         (build_path):
2961         * gtk/jhbuildrc:
2962
2963 2012-03-19  Ojan Vafai  <ojan@chromium.org>
2964
2965         We should only add a live event listener once, not once per TestSelector.
2966         Adding one per TestSelector would cause accordion('option', 'active') to
2967         incorrectly be "false" if you examine multiple sets of tests.
2968
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2970
2971 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2972
2973         Fix typo introduced in r111293.
2974
2975         Unreviewed, build fix.
2976
2977         * Scripts/webkitpy/layout_tests/port/webkit.py:
2978         (WebKitDriver._check_for_driver_crash):
2979
2980 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
2981
2982         webkitpy: get ServerProcess out of the reportcrash business
2983         https://bugs.webkit.org/show_bug.cgi?id=81600
2984
2985         Reviewed by Adam Barth.
2986
2987         ServerProcess was half-aware that ReportCrash might run
2988         sometimes, and that the process ServerProcess was talking to
2989         might have its own crashing subprocesses; neither of these
2990         things really worked right and it made the logic convoluted, so
2991         this change makes handling crashes completely separate from the
2992         server_process code, so that it can focus on just I/O to the
2993         subprocess.
2994
2995         There should be no functional changes resulting from this patch.
2996
2997         * Scripts/webkitpy/layout_tests/port/server_process.py:
2998         (ServerProcess._reset):
2999         (ServerProcess._handle_possible_interrupt):
3000         (ServerProcess.write):
3001         (ServerProcess.read_stdout):
3002         (ServerProcess.has_crashed):
3003         (ServerProcess._read):
3004         (ServerProcess.stop):
3005         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3006         (TrivialMockPort.check_for_leaks):
3007         (TestServerProcess.test_broken_pipe):
3008         * Scripts/webkitpy/layout_tests/port/webkit.py:
3009         (WebKitPort._read_image_diff):
3010         (WebKitDriver.has_crashed):
3011         (WebKitDriver._check_for_driver_crash):
3012         (WebKitDriver.run_test):
3013         (WebKitDriver._read_block):
3014         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3015         (MockServerProcess.__init__):
3016         (MockServerProcess):
3017         (MockServerProcess.has_crashed):
3018
3019 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3020
3021         webkitpy: crashlog parsing is broken
3022         https://bugs.webkit.org/show_bug.cgi?id=81586
3023
3024         Reviewed by Adam Barth.
3025
3026         Seeking on a file opened through codecs() appears to not work
3027         correctly (at least on SL).
3028         
3029         The code was more complicated than it needed to be, so I have
3030         revamped it to just read a full crashlog at once and then look
3031         for matches. 
3032         
3033         I have also added the ability to optionally propagate
3034         errors back (which can be helpful to debug races when ReportCrash is
3035         still running and you need to see that you couldn't open some
3036         files, rather than just ignoring them).
3037
3038         * Scripts/webkitpy/common/system/crashlogs.py:
3039         (CrashLogs.find_newest_log):
3040         (CrashLogs._find_newest_log_darwin):
3041         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3042         (CrashLogsTest.test_find_log_darwin):
3043
3044 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3045
3046         webkitpy: clean up some port._filesystem references to not reference private members
3047         https://bugs.webkit.org/show_bug.cgi?id=81595
3048
3049         Reviewed by Eric Seidel.
3050
3051         There should be no functional changes in this patch, just some
3052         refactoring. Also, fixes a minor nit in write_image_diff_files(()
3053
3054         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3055         (SingleTestRunner.__init__):
3056         (SingleTestRunner._run_compare_test):
3057         (SingleTestRunner._run_rebaseline):
3058         (SingleTestRunner._save_baseline_data):
3059         (SingleTestRunner._handle_error):
3060         (SingleTestRunner._run_reftest):
3061         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3062         (write_test_result):
3063         (TestResultWriter.__init__):
3064         (TestResultWriter._make_output_directory):
3065         (TestResultWriter.output_filename):
3066         (TestResultWriter._output_testname):
3067         (TestResultWriter.write_output_files):
3068         (TestResultWriter.write_stderr):
3069         (TestResultWriter.write_crash_report):
3070         (TestResultWriter.create_text_diff_and_write_result):
3071         (TestResultWriter.write_image_diff_files):
3072         (copy_file):
3073         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3074         (TestResultWriterTest.test_reftest_diff_image):
3075
3076 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3077
3078         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
3079         https://bugs.webkit.org/show_bug.cgi?id=81598
3080
3081         Reviewed by Eric Seidel.
3082
3083         "DumpRenderTree" shouldn't be hard-coded here, since some other
3084         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
3085         
3086         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3087         (TestExpectations):
3088
3089 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3090
3091         webkitpy: allow instance data in TestFailure objects
3092         https://bugs.webkit.org/show_bug.cgi?id=81580
3093
3094         Reviewed by Tony Chang.
3095
3096         Current TestFailures are basically enums, but it would be nice,
3097         especially for crashes, if they contained the name and pid of
3098         the process that crashed.
3099
3100         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3101         (TestFailure.message):
3102         (FailureTimeout.message):
3103         (FailureCrash):
3104         (FailureCrash.__init__):
3105         (FailureCrash.message):
3106         (FailureMissingResult.message):
3107         (FailureTextMismatch.message):
3108         (FailureMissingImageHash.message):
3109         (FailureMissingImage.message):
3110         (FailureImageHashMismatch.message):
3111         (FailureImageHashIncorrect.message):
3112         (FailureReftestMismatch.message):
3113         (FailureReftestMismatchDidNotOccur.message):
3114         (FailureReftestNoImagesGenerated.message):
3115         (FailureMissingAudio.message):
3116         (FailureAudioMismatch.message):
3117         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3118         (TestFailuresTest.test_equals):
3119         (TestFailuresTest):
3120         (TestFailuresTest.test_crashes):
3121
3122 2012-03-19  Brady Eidson  <beidson@apple.com>
3123
3124         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
3125         Crash in 3rd party WebKit apps under XHR/Cache code
3126
3127         Reviewed by Antti Koivisto.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
3131         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
3132         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3133         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3134         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3135         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3136         (TestWebKitAPI):
3137         (TestWebKitAPI::TEST):
3138
3139 2012-03-19  Brady Eidson  <beidson@apple.com>
3140
3141         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
3142         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
3143
3144         Reviewed by Enrica Casucci.
3145
3146         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
3147         are in the correct format.
3148
3149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3150         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
3151         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
3152         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
3153         (TestWebKitAPI::contextMenuCopyLink):
3154         (TestWebKitAPI::TEST):
3155
3156 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3157
3158         Make the selected item in the accordion a link to the flakiness dashboard
3159         https://bugs.webkit.org/show_bug.cgi?id=81571
3160
3161         Reviewed by Dimitri Glazkov.
3162
3163         Also, make it so that you can select the text of the link, instead of the current behavior
3164         of acting as if you had clicked on the accordion header.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3168
3169 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3170
3171         NRWT runs some tests that are skipped with -i command line option
3172         https://bugs.webkit.org/show_bug.cgi?id=81535
3173
3174         Reviewed by Ojan Vafai.
3175
3176         This change modifies the interaction of Skipped files and
3177         test_expectations files so that entries in Skipped files (and
3178         the -i command line) override *everything* in the expectations
3179         file.
3180
3181         Specifically, a directory in a Skipped file will cause all of
3182         the tests in the dir to be skipped even if individual tests in
3183         the dir are listed in the test_expectations.txt.
3184
3185         Skipped files also override anything in an overrides files.
3186
3187         This seems to make more intuitive sense, since if you list
3188         something in the Skips file (and even more specify it on the
3189         command line) you probably want it to be universally applied.
3190
3191         Theoretically we could add more precedence levels and have full
3192         paths in an expectations file override dirs in a Skipped file
3193         (but not the command line), but I don't know yet that that level
3194         of complexity is justified.
3195         
3196         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3197         (TestExpectations.__init__):
3198         (TestExpectations._add_skipped_tests):
3199         (TestExpectations._add_test):
3200         (TestExpectations._add_expectations):
3201         (TestExpectations._add_expectation_line):
3202         (TestExpectations._already_seen_better_match):
3203         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3204         (test_more_specific_override_resets_skip):
3205         (SkippedTests):
3206         (SkippedTests.get_exp):
3207         (SkippedTests.assert_exp):
3208         (SkippedTests.test_skipped_tests_work):
3209         (SkippedTests.test_duplicate_skipped_test_fails_lint):
3210         (SkippedTests.test_skipped_file_overrides_expectations):
3211         (SkippedTests.test_skipped_dir_overrides_expectations):
3212         (SkippedTests.test_skipped_file_overrides_overrides):
3213         (SkippedTests.test_skipped_dir_overrides_overrides):
3214
3215 2012-03-19  Eric Seidel  <eric@webkit.org>
3216
3217         Fix WTF header include discipline in Chromium WebKit
3218         https://bugs.webkit.org/show_bug.cgi?id=81281
3219
3220         Reviewed by James Robinson.
3221
3222         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3223         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
3224
3225 2012-03-19  Andy Chen  <andchen@rim.com>
3226
3227         [BlackBerry] Add new layout test for text match marker
3228         https://bugs.webkit.org/show_bug.cgi?id=81531
3229
3230         Make the LayoutTestControllerBlackBerry::findString to test the
3231         BlackBerry port implementation.
3232
3233         Reviewed by Rob Buis.
3234
3235         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3236         (LayoutTestController::findString):
3237
3238 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3239
3240         Don't show WONTFIX tests in garden-o-matic
3241         https://bugs.webkit.org/show_bug.cgi?id=81554
3242
3243         Reviewed by Dimitri Glazkov.
3244
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3247
3248 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
3249
3250         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
3251         https://bugs.webkit.org/show_bug.cgi?id=81530
3252
3253         Reviewed by Jessie Berlin.
3254
3255         Add rowAtIndex to WebKitTestRunner.
3256
3257         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3258         (WTR::AccessibilityUIElement::rowAtIndex):
3259         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3260         (AccessibilityUIElement):
3261         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3262         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3263         (WTR):
3264         (WTR::AccessibilityUIElement::rowAtIndex):
3265
3266 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3267
3268         Change garden-o-matic All Failures tab to Expected Failures
3269         https://bugs.webkit.org/show_bug.cgi?id=81540
3270
3271         Reviewed by Dimitri Glazkov.
3272
3273         Also, fix some broken unittests that had just gotten stale.
3274
3275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3285
3286 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
3287
3288         [chromium] DRT crashes at shutdown.
3289         https://bugs.webkit.org/show_bug.cgi?id=81504
3290
3291         Reviewed by James Robinson.
3292
3293         WebCompositor must be destroyed after WebView is properly destroyed,
3294         or some compositor objects like CCLayerTreeHost may not be destroyed.
3295         However, it is really hard to make the destruction order correct
3296         explicitly in ~TestShell. So move it out to DumpRenderTree.
3297
3298         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3299         (main):
3300         * DumpRenderTree/chromium/TestShell.cpp:
3301         (TestShell::~TestShell):
3302
3303 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3304
3305         add dpranke to webkitpy watchlist
3306         https://bugs.webkit.org/show_bug.cgi?id=81433
3307
3308         Reviewed by Benjamin Poulain.
3309
3310         * Scripts/webkitpy/common/config/watchlist:
3311
3312 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3313
3314         test-webkitpy is failing on SL/Python 2.6.1
3315         https://bugs.webkit.org/show_bug.cgi?id=81533
3316
3317         Reviewed by Ojan Vafai.
3318
3319         It appears that itertools.combinations() is buggy in 2.6.1; this
3320         backports the implementation from 2.7.
3321
3322         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3323         (TestConfigurationConverter.collapse_macros):
3324         (TestConfigurationConverter):
3325         (TestConfigurationConverter.combinations):
3326
3327 2012-03-19  David Michael Barr  <davidbarr@google.com>
3328
3329         Optimize the cleanup sequence in the start-queue.sh script
3330         https://github.com/abarth/webkit/pull/1
3331
3332         Reviewed by Adam Barth.
3333
3334         Updating the working copy is an expensive operation
3335         for a repository the size of WebKit.
3336         Attempt to reset only to the target revision.
3337
3338         * EWSTools/start-queue.sh:
3339
3340 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
3341
3342         Adjust architecture type of the EFL build bot.
3343         https://bugs.webkit.org/show_bug.cgi?id=81452
3344
3345         Reviewed by Tony Chang.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/config.json: The
3348         buildslave is a 64-bit machine, therefore describe it as being
3349         x86_64, not i386.
3350
3351 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3352
3353         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
3354         https://bugs.webkit.org/show_bug.cgi?id=81514
3355
3356         Reviewed by Simon Hausmann.
3357
3358         * MiniBrowser/qt/qml/BrowserWindow.qml:
3359
3360 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3361
3362         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
3363         https://bugs.webkit.org/show_bug.cgi?id=81491
3364
3365         Reviewed by Philippe Normand.
3366
3367         For the find_path(), find_library() etc CMake calls to find the
3368         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
3369         set, otherwise CMake cannot know the dependencies exist and will only
3370         look in the standard directories.
3371
3372         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
3373         the jhbuild Root directory.
3374
3375 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3376
3377         [EFL] Add XDG env vars to jhbuildrc
3378         https://bugs.webkit.org/show_bug.cgi?id=81510
3379
3380         Needed to ensure correct glib behaviour in jhbuild environment.
3381
3382         Reviewed by Philippe Normand.
3383
3384         * efl/jhbuildrc:
3385
3386 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3387
3388         Select best target for tap gesture.
3389         https://bugs.webkit.org/show_bug.cgi?id=78801
3390
3391         Reviewed by Kenneth Rohde Christiansen.
3392
3393         Add TOUCH_ADJUSTMENT to enabled features.
3394
3395         * qmake/mkspecs/features/features.prf:
3396
3397 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
3398
3399         [chromium] synthesize wheel events for fling on main thread
3400         https://bugs.webkit.org/show_bug.cgi?id=81458
3401
3402         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
3403
3404         Reviewed by James Robinson.
3405
3406         * DumpRenderTree/chromium/EventSender.cpp:
3407         (EventSender::EventSender):
3408         (EventSender::gestureFlingCancel):
3409         (EventSender::gestureFlingStart):
3410         * DumpRenderTree/chromium/EventSender.h:
3411         (EventSender):
3412
3413 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3414
3415         [Qt] Add command line option to set the user agent in the MiniBrowser
3416         https://bugs.webkit.org/show_bug.cgi?id=81508
3417
3418         Reviewed by Simon Hausmann.
3419
3420         * MiniBrowser/qt/BrowserWindow.cpp:
3421         (BrowserWindow::BrowserWindow):
3422         (BrowserWindow::webViewExperimental):
3423         * MiniBrowser/qt/BrowserWindow.h:
3424         (BrowserWindow):
3425         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3426         (printHelp):
3427         (MiniBrowserApplication::handleUserOptions):
3428         * MiniBrowser/qt/MiniBrowserApplication.h:
3429         (WindowOptions::WindowOptions):
3430         (WindowOptions::setUserAgent):
3431         (WindowOptions::userAgent):
3432         (WindowOptions):
3433
3434 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
3435
3436         [Qt] Remove dead user agent code from the MiniBrowser.
3437
3438         Reviewed by Simon Hausmann.
3439
3440         * MiniBrowser/qt/BrowserWindow.cpp:
3441         * MiniBrowser/qt/BrowserWindow.h:
3442         (BrowserWindow):
3443         * MiniBrowser/qt/MiniBrowser.qrc:
3444         * MiniBrowser/qt/useragentlist.txt: Removed.
3445
3446 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3447
3448         jhbuild: Call jhbuild's autogen.sh via bash.
3449         https://bugs.webkit.org/show_bug.cgi?id=81485
3450
3451         Reviewed by Philippe Normand.
3452
3453         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
3454         this is usually true only on Linux systems, and even then bash for
3455         some reason might not be available in that location. It is safer to
3456         call bash directly and pass autogen.sh to it instead.
3457
3458         * jhbuild/jhbuild-wrapper:
3459         (install_jhbuild):
3460
3461 2012-03-19  Philippe Normand  <pnormand@igalia.com>
3462
3463         [GTK] Prefix run-launcher with run-with-jhbuild
3464         https://bugs.webkit.org/show_bug.cgi?id=81503
3465
3466         Reviewed by Hajime Morita.
3467
3468         * Scripts/run-launcher:
3469
3470 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3471
3472         [EFL] Prefix run-launcher with run-with-jhbuild
3473         https://bugs.webkit.org/show_bug.cgi?id=80026
3474
3475         Reviewed by Hajime Morita.
3476
3477         * Scripts/run-launcher:
3478
3479 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3480
3481         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
3482         https://bugs.webkit.org/show_bug.cgi?id=81498
3483
3484         * qmake/mkspecs/features/unix/default_post.prf:
3485
3486 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3487
3488         Unreviewed; switch to using my FreeBSD.org email address, the
3489         other one is going to disappear soon.
3490
3491         * Scripts/webkitpy/common/config/committers.py:
3492         * Scripts/webkitpy/common/config/watchlist:
3493
3494 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
3495
3496         Unreviewed; fix webkitpy unit test failures after r111116.
3497
3498         It turns out that cmd_line in the patch in bug 80025 had the right
3499         signature when it was submitted, but r109242 added a few more
3500         required parameters, and since the method (and EflDriver) did not
3501         exist at the time we ended up committing a broken method.
3502
3503         * Scripts/webkitpy/layout_tests/port/efl.py:
3504         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
3505         arguments.
3506
3507 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3508
3509         [BlackBerry] Enable Web Timing for performance profiling and improvement.
3510         https://bugs.webkit.org/show_bug.cgi?id=81085
3511
3512         Reviewed by Rob Buis.
3513
3514         * Scripts/build-webkit:
3515
3516 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3517
3518         Add a dependencies installation step for EFL to buildbot master.cfg
3519         https://bugs.webkit.org/show_bug.cgi?id=81337
3520
3521         Reviewed by Gustavo Noronha Silva.
3522
3523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3524         (InstallEflDependencies):
3525         (Factory.__init__):
3526
3527 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3528
3529         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
3530         https://bugs.webkit.org/show_bug.cgi?id=80025
3531
3532         Reviewed by Gustavo Noronha Silva.
3533
3534         * Scripts/webkitpy/layout_tests/port/efl.py:
3535         (EflDriver):
3536         (EflDriver.cmd_line):
3537         (EflPort._driver_class):
3538
3539 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3540
3541         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
3542         https://bugs.webkit.org/show_bug.cgi?id=79904
3543
3544         build-webkit --efl will use jhbuild for fetching and building dependencies.
3545
3546         Reviewed by Gustavo Noronha Silva.
3547
3548         * Scripts/update-webkitefl-libs: Added.
3549         * Scripts/webkitdirs.pm:
3550         (jhbuildWrapperPrefixIfNeeded):
3551         (generateBuildSystemFromCMakeProject):
3552         (buildCMakeGeneratedProject):
3553         * efl/common.py: Added.
3554         (script_path):
3555         (top_level_path):
3556         (number_of_cpus):
3557         * efl/jhbuild.modules: Added.
3558         * efl/jhbuildrc: Added.
3559         * efl/run-with-jhbuild: Added.
3560
3561 2012-03-16  Stephanie Lewis  <slewis@apple.com>
3562
3563         https://bugs.webkit.org/show_bug.cgi?id=81065
3564         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
3565         Fix crash preventing WebKitTestRunner from working in Release.  
3566         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
3567         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
3568         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
3569
3570         I removed ostringstream in favor of StringBuilder.  
3571
3572         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
3573
3574         Reviewed by Geoff Garen.
3575
3576         Add DEBUG_DEFINES to set NDEBUG on release builds.
3577         * WebKitTestRunner/Configurations/Base.xcconfig:
3578         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3579
3580         Remove ostringstream member in favor of StringBuilder.
3581         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3582         (WTR::InjectedBundle::initialize):
3583         (WTR::InjectedBundle::beginTesting):
3584         (WTR::InjectedBundle::done):
3585         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3586         (WTF):
3587         (WTR::InjectedBundle::stringBuilder):
3588         (InjectedBundle):
3589
3590         Append output to StringBuilder.
3591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3592         (WTR::hasPrefix):
3593         (WTR::dumpPath):
3594         (WTR::rangeToStr):
3595         (WTR::styleDecToStr):
3596         (WTR::frameToStr):
3597         (WTR::dumpFrameScrollPosition):
3598         (WTR::dumpFrameText):
3599         (WTR::dumpDescendantFramesText):
3600         (WTR::InjectedBundlePage::dump):
3601         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3602         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3603         (WTR::InjectedBundlePage::willSendRequestForFrame):
3604         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3605         (WTR::lastFileURLPathComponent):
3606         (WTR::InjectedBundlePage::willAddMessageToConsole):
3607         (WTR::InjectedBundlePage::willSetStatusbarText):
3608         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
3609         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
3610         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
3611         (WTR::InjectedBundlePage::shouldBeginEditing):
3612         (WTR::InjectedBundlePage::shouldEndEditing):
3613         (WTR::InjectedBundlePage::shouldInsertNode):
3614         (WTR::InjectedBundlePage::shouldInsertText):
3615         (WTR::InjectedBundlePage::shouldDeleteRange):
3616         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3617         (WTR::InjectedBundlePage::shouldApplyStyle):
3618         (WTR::InjectedBundlePage::didBeginEditing):
3619         (WTR::InjectedBundlePage::didEndEditing):
3620         (WTR::InjectedBundlePage::didChange):
3621         (WTR::InjectedBundlePage::didChangeSelection):
3622         (WTR::InjectedBundlePage::supportsFullScreen):
3623         (WTR::InjectedBundlePage::enterFullScreenForElement):
3624         (WTR::InjectedBundlePage::exitFullScreenForElement):
3625         (WTR::InjectedBundlePage::beganEnterFullScreen):
3626         (WTR::InjectedBundlePage::beganExitFullScreen):
3627         (WTR::dumpBackForwardListItem):
3628         (WTR::InjectedBundlePage::dumpBackForwardList):
3629         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3630         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
3631         (WTR::LayoutTestController::dumpConfigurationForViewport):
3632         
3633         Convert between WTF::String and WKStringRef.
3634         * WebKitTestRunner/StringFunctions.h:
3635         (WTR::toWTFString):
3636         (WTR):
3637         * WebKitTestRunner/TestInvocation.cpp:
3638         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3639
3640 2012-03-16  Eric Seidel  <eric@webkit.org>
3641
3642         Add a land-from-url command
3643         https://bugs.webkit.org/show_bug.cgi?id=81411
3644
3645         Reviewed by Adam Barth.
3646
3647         Very basic so far.  The goal is to make it landing smarter
3648         so that users don't have to bother to parse out the ids out of the urls.
3649
3650         * Scripts/webkitpy/common/config/urls.py:
3651         (parse_bug_id):
3652         (parse_attachment_id):
3653         * Scripts/webkitpy/common/config/urls_unittest.py:
3654         (URLsTest.test_parse_bug_id):
3655         (URLsTest):
3656         (URLsTest.test_parse_attachment_id):
3657         * Scripts/webkitpy/tool/commands/download.py:
3658         (ProcessURLsMixin):
3659         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3660         (LandFromURL):
3661         * Scripts/webkitpy/tool/commands/download_unittest.py:
3662         (test_land_from_bug):
3663         (test_land_from_url):
3664
3665 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
3666
3667         build-webkit launcher instructions use wrong relative path for Qt
3668         https://bugs.webkit.org/show_bug.cgi?id=81357
3669
3670         Reviewed by Eric Seidel.
3671
3672         Ensure we are at the proper directory before generating run-launcher
3673         instructions.
3674
3675         * Scripts/build-webkit:
3676
3677 2012-03-16  Brady Eidson  <beidson@apple.com>
3678
3679         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
3680         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
3681
3682         Reviewed by Geoff Garen.
3683
3684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3685         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
3686
3687 2012-03-16  Ojan Vafai  <ojan@chromium.org>
3688
3689         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
3690         https://bugs.webkit.org/show_bug.cgi?id=81407
3691
3692         Reviewed by Adam Barth.
3693
3694         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3695         (summarize_results):
3696         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3697         (ResultSummaryTest.summarized_results):
3698         (ResultSummaryTest.test_no_svn_revision):
3699         (ResultSummaryTest.test_svn_revision):
3700         (ResultSummaryTest):
3701         (ResultSummaryTest.test_summarized_results_wontfix):
3702
3703 2012-03-16  Ojan Vafai  <ojan@chromium.org>
3704
3705         Have webkit-patch rebaseline-test update test_expectations.txt
3706         https://bugs.webkit.org/show_bug.cgi?id=81054
3707
3708         Recommit http://trac.webkit.org/changeset/110783 now that
3709         http://trac.webkit.org/changeset/111034 has landed.
3710
3711         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3712         (TestExpectations.remove_configuration_from_test):
3713         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3714         (RemoveConfigurationsTest):
3715         (RemoveConfigurationsTest.test_remove):
3716         (test_remove_line):
3717         * Scripts/webkitpy/tool/commands/rebaseline.py:
3718         (RebaselineTest._update_expectations_file):
3719         (RebaselineTest._rebaseline_test_and_update_expectations):
3720         (RebaselineTest):
3721         (RebaselineTest.execute):
3722         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3723         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
3724         (test_rebaseline_updates_expectations_file):
3725
3726 2012-03-15  Ojan Vafai  <ojan@chromium.org>
3727
3728         Specifier collapsing when writing test expectations lines gets a number of cases wrong
3729         https://bugs.webkit.org/show_bug.cgi?id=81309
3730
3731         Reviewed by Dimitri Glazkov.
3732
3733         I've run this over all the lines in the current Chromium test_expectations.txt file,
3734         so I'm relatively confident we now cover all the cases.
3735
3736         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3737         (TestConfigurationConverter.__init__):
3738         (TestConfigurationConverter.collapse_macros):
3739         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
3740         (TestConfigurationConverter):
3741         (TestConfigurationConverter.intersect_combination):
3742         (TestConfigurationConverter.symmetric_difference):
3743         (TestConfigurationConverter.to_specifiers_list):
3744         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3745         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3746         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3747         (make_mock_all_test_configurations_set):
3748         (TestConfigurationConverterTest.test_symmetric_difference):
3749         (TestConfigurationConverterTest.test_to_config_set):
3750         (TestConfigurationConverterTest.test_macro_expansion):
3751         (TestConfigurationConverterTest.test_to_specifier_lists):
3752         (TestConfigurationConverterTest.test_converter_macro_collapsing):
3753         * Scripts/webkitpy/layout_tests/port/chromium.py:
3754         (ChromiumPort):
3755         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3756         (ChromiumAndroidPort.__init__):
3757         The android port uses "arm" as it's architecture, which is technically correct,
3758         but considerably complicates making collapsing work. We probably should kill
3759         the concept of architecture entirely. The benefits are not worth the code
3760         complexity.
3761
3762         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3763         (ChromiumPortTest.test_all_test_configurations):
3764         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3765         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
3766         (test_rebaseline_updates_expectations_file):
3767
3768 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
3769
3770         [Qt][Wk2] Assertion Failure and crash on file upload
3771         https://bugs.webkit.org/show_bug.cgi?id=80854
3772
3773         Reviewed by Simon Hausmann.
3774
3775         Added filePicker to WebView using experimental API.
3776
3777         * MiniBrowser/qt/MiniBrowser.qrc:
3778         * MiniBrowser/qt/icons/folder.png: Added.
3779         * MiniBrowser/qt/icons/titlebar.png: Added.
3780         * MiniBrowser/qt/icons/up.png: Added.
3781         * MiniBrowser/qt/qml/BrowserWindow.qml:
3782         * MiniBrowser/qt/qml/FilePicker.qml: Added.
3783
3784 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3785
3786         Updating email for committer.py script.
3787
3788         * Scripts/webkitpy/common/config/committers.py:
3789
3790 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
3791
3792         [chromium] DRT: Add support for sending gesture scrolls without a begin
3793         https://bugs.webkit.org/show_bug.cgi?id=81292
3794
3795         Reviewed by Kent Tamura.
3796
3797         * DumpRenderTree/chromium/EventSender.cpp:
3798         (EventSender::EventSender):
3799         (EventSender::gestureScrollFirstPoint):
3800         * DumpRenderTree/chromium/EventSender.h:
3801         (EventSender):
3802
3803 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
3804
3805         [GTK] WebKitIconDatabase doesn't keep icons cached
3806         https://bugs.webkit.org/show_bug.cgi?id=56200
3807
3808         Reviewed by Martin Robinson.
3809
3810         Add support for favicons in GtkLauncher.
3811
3812         * GtkLauncher/main.c:
3813         (activateUriEntryCb):
3814         (iconLoadedCb):
3815         (createBrowser):
3816
3817 2012-03-16  Adam Barth  <abarth@webkit.org>
3818
3819         Remove sheriff-bot's last-green-revision command
3820         https://bugs.webkit.org/show_bug.cgi?id=81314
3821
3822         Reviewed by Eric Seidel.
3823
3824         This command is a cruel joke.  WebKit doesn't really ever have a
3825         last-green-revision.
3826
3827         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3828         (BuildBot._find_green_revision):
3829         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3830         (MockBuildBot.builder_statuses):
3831         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3832         (test_find_green_revision):
3833         * Scripts/webkitpy/tool/bot/irc_command.py:
3834         (IRCCommand.execute):
3835         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3836         (SheriffIRCBotTest.test_help):
3837         * Scripts/webkitpy/tool/commands/queries.py:
3838         (PatchesToReview.execute):
3839
3840 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3841
3842         [Qt] Make gccdepends test aware of broken icecream deps generation
3843
3844         Icecream seems to build the files without passing -o to gcc with
3845         the original destination path, which means the target name in the
3846         dependency file is wrong.
3847
3848         Also, echo something to the final file instead of just touching it,
3849         so it's not deleted on every build.
3850
3851         Reviewed by Simon Hausmann.
3852
3853         * qmake/config.tests/gccdepends/gccdepends.pro:
3854
3855 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
3856
3857         Support for Battery Status API
3858         https://bugs.webkit.org/show_bug.cgi?id=62698
3859
3860         Add include directory and file.
3861         http://www.w3.org/TR/battery-status/
3862
3863         Reviewed by Adam Barth.
3864
3865         * Scripts/build-webkit:
3866
3867 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
3868
3869         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
3870         https://bugs.webkit.org/show_bug.cgi?id=81007
3871
3872         Reviewed by Adam Barth.
3873
3874         A dedidcated build slave is available for efl on build.webkit.org. 
3875         This change add's an entry for the elf port in list of available port builders.
3876         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
3877
3878         * Scripts/webkitpy/layout_tests/port/builders.py:
3879
3880 2012-03-16  Adam Barth  <abarth@webkit.org>
3881
3882         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
3883         https://bugs.webkit.org/show_bug.cgi?id=81302
3884
3885         Reviewed by Eric Seidel.
3886
3887         This is a trivial patch, but the variable name turned up in a grep of
3888         webkitpy and looks like copy pasta.
3889
3890         * Scripts/webkitpy/common/net/statusserver.py:
3891         (StatusServer.next_work_item):
3892
3893 2012-03-16  Andrew Lo  <anlo@rim.com>
3894
3895         [BlackBerry] Enable PAGE_VISIBILITY_API
3896         https://bugs.webkit.org/show_bug.cgi?id=81257
3897
3898         Enable Page Visibility API for BlackBerry.
3899
3900         Reviewed by Rob Buis.
3901
3902         * Scripts/build-webkit:
3903
3904 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
3905
3906         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
3907         https://bugs.webkit.org/show_bug.cgi?id=81232
3908
3909         Reviewed by Philippe Normand.
3910
3911         Use the newly-added helper method in DumpRenderTreeSupportGtk.
3912
3913         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3914         (LayoutTestController::computedStyleIncludingVisitedInfo):
3915
3916 2012-03-15  Eric Seidel  <eric@webkit.org>
3917
3918         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
3919         https://bugs.webkit.org/show_bug.cgi?id=81313
3920
3921         Reviewed by Adam Barth.
3922
3923         * Scripts/webkitpy/common/checkout/changelog.py:
3924         (parse_bug_id_from_changelog):
3925         * Scripts/webkitpy/common/config/urls.py:
3926         (parse_bug_id):
3927         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
3928         (URLsTest):
3929         (URLsTest.test_parse_bug_id):
3930         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3931         (test_parse_bug_id):
3932         * Scripts/webkitpy/tool/bot/irc_command.py:
3933         (_post_error_and_check_for_bug_url):
3934         * Scripts/webkitpy/tool/bot/sheriff.py:
3935         (Sheriff.post_rollout_patch):
3936         (Sheriff.post_chromium_deps_roll):
3937
3938 2012-03-15  Adam Barth  <abarth@webkit.org>
3939
3940         The commit-queue should fast-track patches that have already passed the testing EWS bots
3941         https://bugs.webkit.org/show_bug.cgi?id=81305
3942
3943         Reviewed by Eric Seidel.
3944
3945         If a patch has already passed the testing EWS bots (currently only the
3946         chromium-ews bot), we should be able to land the patch without running
3947         the tests again.  This patch is somewhat risky in that the tests might
3948         have been broken between when the EWS bots ran and when the
3949         commit-queue is processing the patch.  If that turns out to be a
3950         problem in practice, we'll tighten up this fast-track in some way,
3951         likely by making sure that the pass status is recent.
3952
3953         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3954         (CommitQueueTaskDelegate.did_pass_testing_ews):
3955         (CommitQueueTask._did_pass_tests_recently):
3956         (CommitQueueTask.run):
3957         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3958         (MockCommitQueue.did_pass_testing_ews):
3959         (test_fast_success_case):
3960         * Scripts/webkitpy/tool/commands/queues.py:
3961         (CommitQueue.did_pass_testing_ews):
3962         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3963         (test_did_pass_testing_ews):
3964
3965 2012-03-15  Kentaro Hara  <haraken@chromium.org>
3966
3967         [PerformanceTests] run-perf-tests should output correct units
3968         https://bugs.webkit.org/show_bug.cgi?id=78303
3969
3970         Reviewed by Ryosuke Niwa.
3971
3972         Previously run-perf-tests just supported "ms" for units.
3973         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
3974         This patch fixes run-perf-tests so that they can support custom units.
3975         The default unit is "ms".
3976
3977         The test result looks like this:
3978
3979         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
3980         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
3981         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
3982
3983         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3984         (PerfTestsRunner._process_parser_test_result):
3985
3986 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
3987
3988         [WinCairo] Unreviewed build change after wtf path changes.
3989
3990         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
3991         directories to look at the private header directory to find 'wtf'.
3992
3993 2012-03-15  Kent Tamura  <tkent@chromium.org>
3994
3995         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
3996         https://bugs.webkit.org/show_bug.cgi?id=81293
3997
3998         Reviewed by Adam Barth.
3999
4000         r110595 introduced new format of the author field of ChangeLog entry:
4001         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
4002         Updte chanelog.py to support it.
4003
4004         * Scripts/webkitpy/common/checkout/changelog.py:
4005         (ChangeLogEntry._split_contributor_names):
4006         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4007         (test_parse_authors):
4008
4009 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
4010
4011         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
4012
4013         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
4014
4015         Reviewed by Jessie Berlin.
4016
4017         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4018         (LayoutTestController::setValueForUser):
4019         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4020         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4021         (WTR::LayoutTestController::setValueForUser):
4022         (WTR):
4023         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4024         (LayoutTestController):
4025
4026 2012-03-15  Adam Barth  <abarth@webkit.org>
4027
4028         Update the start-queue.sh script to match what we're using on the bots
4029         https://bugs.webkit.org/show_bug.cgi?id=81277
4030
4031         Reviewed by Eric Seidel.
4032
4033         Over time we've added more magic git commands to clean up the local repo after
4034         it has been borked in various ways. The idea behind this sequence is to clear
4035         out any changes in the working copy and then to rebuild the master branch from
4036         origin/master.
4037
4038         This patch also removes the watchdog timer that we've stopped using on the
4039         bots.
4040
4041         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
4042         Note: Eric and I are experimenting with GitHub to see if it might be
4043         useful for WebKit.  If you have thoughts on this topic, please feel
4044         free to grab Eric or me on #webkit to chat.  I assume that he and I are
4045         the only ones who care about this file so using this alternative
4046         process for this patch shouldn't cause any trouble.
4047
4048         * EWSTools/start-queue.sh:
4049
4050 2012-03-15  Adam Barth  <abarth@webkit.org>
4051
4052         The commit-queue can hang when the test_expectations.txt style check fails during commit
4053         https://bugs.webkit.org/show_bug.cgi?id=81251
4054
4055         Reviewed by Eric Seidel.
4056
4057         We forgot to check the --non-interactive flag, so we end up prompting
4058         the "user" who doesn't exist on the bot.  We might consider teaching
4059         the User class about non-interactive if we have this sort of bug again.
4060
4061         * Scripts/webkitpy/tool/steps/commit.py:
4062         (Commit.options):
4063         (Commit._check_test_expectations):
4064         (Commit.run):
4065         * Scripts/webkitpy/tool/steps/commit_unittest.py:
4066         (CommitTest.test_check_test_expectations):
4067
4068 2012-03-15  Jessie Berlin  <jberlin@apple.com>
4069
4070         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
4071         Mac WK2 because WebAudio is not enabled
4072         https://bugs.webkit.org/show_bug.cgi?id=81259
4073
4074         Reviewed by Dan Bernstein.
4075
4076         Enable WebAudio so that it appears in the window object in the tests.
4077         The webaudio tests are all still skipped in the Mac Skipped list.
4078
4079         * WebKitTestRunner/TestController.cpp:
4080         (WTR::TestController::resetStateToConsistentValues):
4081
4082 2012-03-15  David Levin  <levin@chromium.org>
4083
4084         Various autoresize fixes.
4085         https://bugs.webkit.org/show_bug.cgi?id=81199
4086
4087         Reviewed by Darin Fisher.
4088
4089         * DumpRenderTree/chromium/LayoutTestController.cpp:
4090         (LayoutTestController::reset): Stop using the deprecated api that was removed.
4091
4092 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4093
4094         [GTK] Actually use --release and --debug command line options in run-gtk-test
4095         https://bugs.webkit.org/show_bug.cgi?id=81234
4096
4097         Reviewed by Philippe Normand.
4098
4099         Actually handle --release and --debug command line options to
4100         create the build directory, falling back to current hack to detect
4101         whether it's a Release or Debug build when both options are missed.
4102
4103         * Scripts/run-gtk-tests:
4104         (TestRunner.__init__): Receive options too.
4105         (TestRunner._get_top_level_directory): Helper function to get the
4106         top level directory.
4107         (TestRunner._get_build_directory): Helper function to get the
4108         build directory depending on --release/--debug command line
4109         options or gessing it if both options are missing.
4110         (TestRunner._ensure_accessibility_daemon_is_running): Use
4111         self-options now.
4112         (TestRunner.run): Ditto.
4113         (TestRunner.run.run_tests): Pass options to the constructor
4114         instead of run().
4115
4116 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4117
4118         [GTK] Run unit tests with --verbose in the bots
4119         https://bugs.webkit.org/show_bug.cgi?id=81230
4120
4121         Reviewed by Martin Robinson.
4122
4123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4124         (RunGtkAPITests): Add --verbose to run-gtk-test command.
4125
4126 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
4127
4128         Move wx port to using export macros
4129         https://bugs.webkit.org/show_bug.cgi?id=77279
4130
4131         Reviewed by Hajime Morita.
4132
4133         * waf/build/settings.py:
4134         (common_configure):
4135
4136 2012-03-15  Philippe Normand  <pnormand@igalia.com>
4137
4138         Unreviewed, GTK build fix attempt after r110845.
4139
4140         * Scripts/run-gtk-tests: Added --release and --debug options.
4141
4142 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
4143
4144         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
4145         https://bugs.webkit.org/show_bug.cgi?id=79673
4146
4147         Preparatory work for bringing jhbuild enabled build to EFL port.
4148
4149         Reviewed by Philippe Normand.
4150
4151         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
4152         * Scripts/update-webkitgtk-libs:
4153         * gtk/run-with-jhbuild:
4154         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
4155         (top_level_path):
4156         (jhbuild_installed):
4157         (jhbuild_cloned):
4158         (jhbuild_at_expected_revision):
4159         (update_jhbuild):
4160         (clone_jhbuild):
4161         (install_jhbuild):
4162         (update_webkit_libs_jhbuild):
4163         (determine_platform):
4164         (ensure_jhbuild):
4165
4166 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4167
4168         [GTK] Add command line options to run-gtk-tests script
4169         https://bugs.webkit.org/show_bug.cgi?id=81218
4170
4171         Reviewed by Philippe Normand.
4172
4173         Following command line options have been added:
4174
4175         -v, --verbose: to run gtester with --verbose. That would be used
4176         by the bots to make it easier to know which test case it failing.
4177
4178         --display: to use a different display for Xvfb
4179
4180         It's also possible to pass one or more tests as arguments.
4181
4182         * Scripts/run-gtk-tests:
4183         (TestRunner.__init__): Receive command line arguments.
4184         (TestRunner._get_tests): Get all the tests or the ones passed by
4185         command line arguments.
4186         (TestRunner._ensure_accessibility_daemon_is_running): Use display
4187         command line argument.
4188         (TestRunner.run): Pas command line options.
4189         (TestRunner.run.run_tests): Pass command line arguments.
4190
4191 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
4192
4193         [GTK] WebKit2APITests/TestPrinting timeout in the bots
4194         https://bugs.webkit.org/show_bug.cgi?id=81211
4195
4196         Reviewed by Philippe Normand.
4197
4198         Add gtk+ patch to fix timeout in the bots. A similar patch has
4199         already landed in updatream gtk+, see
4200         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
4201
4202         * gtk/jhbuild.modules:
4203         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
4204
4205 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
4206
4207         sheriffbot should also be addressable with a comma in addition to colon
4208         https://bugs.webkit.org/show_bug.cgi?id=81101
4209
4210         Reviewed by Adam Barth.
4211
4212         * Scripts/webkitpy/common/net/irc/ircbot.py:
4213         (IRCBot.on_pubmsg):
4214
4215 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
4216
4217         [Qt] MiniBrowser scroll indicators should not scroll out of view
4218         https://bugs.webkit.org/show_bug.cgi?id=81131
4219
4220         Reviewed by Kenneth Rohde Christiansen.
4221
4222         * MiniBrowser/qt/qml/ScrollIndicator.qml:
4223
4224 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
4225
4226         AX: ARIA tables need to support selected rows attribute/select rows changed notification
4227         https://bugs.webkit.org/show_bug.cgi?id=79821
4228
4229         Reviewed by Beth Dakin.
4230
4231         * DumpRenderTree/AccessibilityUIElement.cpp:
4232         (rowAtIndexCallback):
4233         (AccessibilityUIElement::getJSClass):
4234         * DumpRenderTree/AccessibilityUIElement.h:
4235         (AccessibilityUIElement):
4236         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
4237         (AccessibilityUIElement::rowAtIndex):
4238         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4239         (AccessibilityUIElement::rowAtIndex):
4240         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4241         (AccessibilityUIElement::rowAtIndex):
4242         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4243         (AccessibilityUIElement::rowAtIndex):
4244
4245 2012-03-14  Tim Horton  <timothy_horton@apple.com>
4246
4247         NRWT should respect --additional-platform-directory's Skipped list
4248         https://bugs.webkit.org/show_bug.cgi?id=81172
4249
4250         Reviewed by Timothy Hatcher.
4251
4252         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
4253         from said path are already used, but the Skipped file is ignored.
4254
4255         * Scripts/webkitpy/layout_tests/port/webkit.py:
4256         (WebKitPort._skipped_file_search_paths):
4257         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4258         (test_skipped_file_search_paths):
4259
4260 2012-03-14  Ojan Vafai  <ojan@chromium.org>
4261
4262         Unreviewed, rolling out r110783.
4263         http://trac.webkit.org/changeset/110783
4264         https://bugs.webkit.org/show_bug.cgi?id=81054
4265
4266         Caused existing test expectation lines to expand to one for
4267         each test configuration.
4268
4269         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4270         (TestExpectations.has_warnings):
4271         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4272         (test_macro_overrides):
4273         * Scripts/webkitpy/tool/commands/rebaseline.py:
4274         (RebaselineTest._save_baseline):
4275         (RebaselineTest._rebaseline_test):
4276         (RebaselineTest.execute):
4277         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4278         (TestRebaseline.test_tests_to_update):
4279
4280 2012-03-13  Jon Lee  <jonlee@apple.com>
4281
4282         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
4283         https://bugs.webkit.org/show_bug.cgi?id=80922
4284         <rdar://problem/11035082>
4285
4286         Reviewed by Jian Li.
4287
4288         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
4289         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
4290         new API. Therefore, APIs that are common between the two will have:
4291         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
4292
4293         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
4294         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
4295
4296         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
4297         * DumpRenderTree/chromium/LayoutTestController.cpp:
4298         (LayoutTestController::grantDesktopNotificationPermission):
4299         (LayoutTestController::simulateDesktopNotificationClick):
4300         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4301         * DumpRenderTree/chromium/TestShell.cpp:
4302         (TestShell::TestShell):
4303         (TestShell::resetTestController):
4304         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
4305         (DRTDesktopNotificationPresenter::checkNotificationPermission):
4306
4307 2012-03-13  Ojan Vafai  <ojan@chromium.org>
4308
4309         Have webkit-patch rebaseline-test update test_expectations.txt
4310         https://bugs.webkit.org/show_bug.cgi?id=81054
4311
4312         Reviewed by Dirk Pranke.
4313
4314         This will allow us to use the All Failures tab in garden-o-matic
4315         to rebaseline tests without making test_expectations.txt stale.
4316
4317         It's conservative and only removes lines if the test is
4318         not flaky and fails in a way the rebaseline would fix (e.g.
4319         CRASH/TIMEOUT will not be touched).
4320
4321         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4322         (TestExpectations.remove_configuration_from_test):
4323         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4324         (RemoveConfigurationsTest):
4325         (RemoveConfigurationsTest.test_remove):
4326         (test_remove_line):
4327         * Scripts/webkitpy/tool/commands/rebaseline.py:
4328         (RebaselineTest._is_supported_port):
4329         (RebaselineTest):
4330         (RebaselineTest._update_expectations_file):
4331         (RebaselineTest._rebaseline_test_and_update_expectations):
4332         (RebaselineTest.execute):
4333         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4334         (TestRebaseline.test_rebaseline_updates_expectations_file):
4335
4336 2012-03-14  Jessie Berlin  <jberlin@apple.com>
4337
4338         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
4339         https://bugs.webkit.org/show_bug.cgi?id=81167
4340
4341         Reviewed by Sam Weinig.
4342
4343         Do not use 0 as a key in a HashMap.
4344
4345         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4346         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
4347
4348 2012-03-14  Ojan Vafai  <ojan@chromium.org>
4349
4350         Add the chromium lion bot to garden-o-matic and remove
4351         the platform_move_to in builders.py since the Chromium Lion
4352         port is now a normal port.
4353
4354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4355         * Scripts/webkitpy/layout_tests/port/builders.py:
4356