Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2
3         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
4         https://bugs.webkit.org/show_bug.cgi?id=199972
5
6         Reviewed by Jer Noble.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
9         (TEST):
10
11 2019-07-23  Alicia Boya García  <aboya@igalia.com>
12
13         [WTF] Add DataMutex and MainThreadData wrappers
14         https://bugs.webkit.org/show_bug.cgi?id=199831
15
16         Reviewed by Alex Christensen.
17
18         Added a very simple test that checks that DataMutex<T> indeed takes
19         the lock and indeed holds data.
20
21         * TestWebKitAPI/CMakeLists.txt:
22         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
23         (TestWebKitAPI::TEST):
24
25 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
26
27         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
28         https://bugs.webkit.org/show_bug.cgi?id=200021
29         <rdar://problem/53301325>
30
31         Reviewed by Ryosuke Niwa.
32
33         Add support for grabbing the child menu items of a context menu item.
34
35         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
36         (WTR::getMenuItemChildrenCallback):
37
38 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
39
40         WebKit should strip away system font names from the pasted content
41         https://bugs.webkit.org/show_bug.cgi?id=199975
42         <rdar://problem/53336353>
43
44         Reviewed by Darin Adler.
45
46         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
47
48         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
49         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
50         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
51
52 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
53
54         [ews-build] EWS fails to parse multi-line full_results.json
55         https://bugs.webkit.org/show_bug.cgi?id=199992
56
57         Reviewed by Alexey Proskuryakov.
58
59         * BuildSlaveSupport/ews-build/layout_test_failures.py:
60         (LayoutTestFailures.results_from_string): Concatenate content into single line.
61         * BuildSlaveSupport/ews-build/steps_unittest.py:
62         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
63
64 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
65
66         resultsdbpy: Handle case where the previous commit doesn't have the changelog
67         https://bugs.webkit.org/show_bug.cgi?id=200015
68
69         Reviewed by Aakash Jain.
70
71         * resultsdbpy/resultsdbpy/model/repository.py:
72         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
73
74 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
75
76         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
77         https://bugs.webkit.org/show_bug.cgi?id=200013
78         <rdar://problem/52526901>
79
80         Reviewed by Simon Fraser.
81
82         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
83
84         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
85         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
86         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
87         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
88         * TestWebKitAPI/ios/UIKitSPI.h:
89
90 2019-07-22  Jer Noble  <jer.noble@apple.com>
91
92         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
93         https://bugs.webkit.org/show_bug.cgi?id=199971
94         <rdar://problem/51951218>
95
96         Reviewed by Alex Christensen.
97
98         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
99         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
100         (TestWebKitAPI::TEST):
101
102 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
103
104         [ews-build] Add an EWS to run services tests
105         https://bugs.webkit.org/show_bug.cgi?id=199994
106
107         Reviewed by Jonathan Bedard.
108
109         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
110         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
111         * BuildSlaveSupport/ews-build/steps.py:
112         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
113         (RunEWSUnitTests): Build step to run EWS unit-tests.
114         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
115         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
116         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
117
118 2019-07-22  Youenn Fablet  <youenn@apple.com>
119
120         Disable MediaRecorder for legacy WebKit
121         https://bugs.webkit.org/show_bug.cgi?id=200001
122         <rdar://problem/53400030>
123
124         Reviewed by Eric Carlson.
125
126         Enable MediaRecorder for testing purposes.
127
128         * DumpRenderTree/mac/DumpRenderTree.mm:
129         (createWebViewAndOffscreenWindow):
130
131 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
132
133         results.webkit.org: Timeline header is too small
134         https://bugs.webkit.org/show_bug.cgi?id=199955
135
136         Reviewed by Aakash Jain.
137
138         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
139         (.timeline>.header): Make timeline header larder to fit configuration names.
140
141 2019-07-22  Alex Christensen  <achristensen@webkit.org>
142
143         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
144         https://bugs.webkit.org/show_bug.cgi?id=199954
145
146         Reviewed by Geoff Garen.
147
148         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
149         (TEST):
150
151 2019-07-22  Alex Christensen  <achristensen@webkit.org>
152
153         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
154         https://bugs.webkit.org/show_bug.cgi?id=199917
155
156         Reviewed by Sam Weinig.
157
158         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
159         (TEST):
160
161 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
162
163         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
164         https://bugs.webkit.org/show_bug.cgi?id=199980
165
166         Reviewed by Jonathan Bedard.
167
168         * BuildSlaveSupport/ews-build/steps.py:
169         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
170         * BuildSlaveSupport/ews-build/steps_unittest.py:
171         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
172         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
173
174 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
175
176         [webkitpy] Add an unit test for setting up the driver environment without starting it.
177         https://bugs.webkit.org/show_bug.cgi?id=199945
178
179         Reviewed by Michael Catanzaro.
180
181         This adds an unit test for the change implemented in r247663.
182
183         * Scripts/webkitpy/port/driver_unittest.py:
184         (DriverTest.test_setup_environ_base_vars):
185         (DriverTest):
186         (DriverTest.test_setup_environ_without_starting_driver):
187
188 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
189
190         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
191         https://bugs.webkit.org/show_bug.cgi?id=199993
192         <rdar://problem/49523528>
193
194         Reviewed by Beth Dakin.
195
196         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
197
198         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
199         (TestWebKitAPI::TEST):
200         * TestWebKitAPI/cocoa/TestWKWebView.h:
201
202 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
203
204         Add accessibilityInsertText for text insertion in edit fields.
205         https://bugs.webkit.org/show_bug.cgi?id=199973
206
207         Reviewed by Chris Fleizach.
208
209         Renamed accessibilityInsertText to _accessibilityInsertText.
210
211         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
212         (AccessibilityUIElement::insertText):
213         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
214         (AccessibilityUIElement::insertText):
215         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
216         (WTR::AccessibilityUIElement::insertText):
217         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
218         (WTR::AccessibilityUIElement::insertText):
219
220 2019-07-20  Chris Dumez  <cdumez@apple.com>
221
222         Speed up HashTable decoding by reserving capacity and avoiding rehashing
223         https://bugs.webkit.org/show_bug.cgi?id=199982
224
225         Reviewed by Saam Barati.
226
227         Add API test coverage.
228
229         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
230         (TestWebKitAPI::TEST):
231
232 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
233
234         Add accessibilityInsertText for text insertion in edit fields.
235         https://bugs.webkit.org/show_bug.cgi?id=199973
236
237         Reviewed by Chris Fleizach.
238
239         Glue code to run new LayoutTests.
240         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
241         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
242         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
243         (WTR::AccessibilityUIElement::insertText):
244         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
245         (WTR::AccessibilityUIElement::insertText):
246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
247         (WTR::AccessibilityUIElement::insertText):
248         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
249         (WTR::AccessibilityUIElement::insertText):
250
251 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
252
253         Move webkit.css to opensource to support resultsdbpy's frontend
254         https://bugs.webkit.org/show_bug.cgi?id=199957
255
256         Reviewed by Jonathan Bedard.
257
258         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
259         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
260         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
261         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
262
263 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
264
265         Move Ref.js to WebKit to support resultsdbpy's frontend
266         https://bugs.webkit.org/show_bug.cgi?id=199956
267
268         Reviewed by Jonathan Bedard.
269
270         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
271         * resultsdbpy/resultsdbpy/view/static/js/search.js:
272         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
273         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
274         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
275         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
276         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
277         * resultsdbpy/resultsdbpy/view/templates/base.html:
278         * resultsdbpy/resultsdbpy/view/templates/commits.html:
279         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
280         * resultsdbpy/resultsdbpy/view/templates/search.html:
281         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
282         * resultsdbpy/resultsdbpy/view/view_routes.py:
283
284 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
285
286         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
287         https://bugs.webkit.org/show_bug.cgi?id=199945
288
289         Reviewed by Michael Catanzaro.
290
291         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
292         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
293         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
294
295         * Scripts/webkitpy/port/driver.py:
296         (Driver._setup_environ_for_driver):
297         (Driver._create_temporal_directories):
298         (Driver):
299         (Driver._start):
300         (Driver._delete_temporal_directories):
301         (Driver.stop):
302         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
303         (main):
304         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
305         (WebDriverTestRunner.__init__):
306         * glib/api_test_runner.py:
307         (TestRunner._setup_testing_environment): Ditto.
308
309 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
310
311         [ews-build] Display pre-existing Layout test failure names in the build summary
312         https://bugs.webkit.org/show_bug.cgi?id=199941
313
314         Reviewed by Jonathan Bedard.
315
316         * BuildSlaveSupport/ews-build/steps.py:
317         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
318
319 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
320
321         [GTK][WPE] run-webkit-tests should run with a temporal homedir
322         https://bugs.webkit.org/show_bug.cgi?id=199738
323
324         Reviewed by Michael Catanzaro.
325
326         Run the tests with an empty homedir that is created inside the driver tmpdir.
327         The driver tmpdir is a random directory created for each test runner that is purged after the run.
328
329         This is done to ensure that the test results are not affected by the user settings of any library.
330
331         * Scripts/webkitpy/port/driver.py:
332         (Driver._setup_environ_for_driver):
333         * Scripts/webkitpy/port/driver_unittest.py:
334         (DriverTest.test_setup_environ_base_vars):
335         (DriverTest):
336         (DriverTest.test_create_temporal_home_dir):
337
338 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
339
340         Remove pywebsockets from thirdparty
341         https://bugs.webkit.org/show_bug.cgi?id=199710
342
343         Reviewed by Jonathan Bedard.
344
345         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
346         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
347
348         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
349         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
350         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
351         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
352         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
353         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
354         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
355         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
356         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
357         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
358         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
359         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
360         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
361         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
362         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
363         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
364         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
365         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
366         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
367         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
368         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
369         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
370
371 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
372
373         results.webkit.org: Move resultsdbpy to WebKit
374         https://bugs.webkit.org/show_bug.cgi?id=199837
375         <rdar://problem/53172130>
376
377         Rubber-stamped by Aakash Jain.
378
379         Moving the entirety of the resultsdbpy library, which provides utilities to build
380         a database designed to store, visualize and organize test results, into WebKit.
381
382         * Scripts/webkitpy/style/checker.py:
383         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
384         * resultsdbpy: Added.
385         * resultsdbpy/MANIFEST.in: Added.
386         * resultsdbpy/README.md: Added.
387         * resultsdbpy/resultsdbpy: Added.
388         * resultsdbpy/resultsdbpy/__init__.py: Added.
389         * resultsdbpy/resultsdbpy/controller: Added.
390         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
391         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
392         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
393         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
394         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
395         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
396         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
397         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
398         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
399         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
400         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
401         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
402         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
403         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
404         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
405         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
406         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
407         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
408         * resultsdbpy/resultsdbpy/flask_support: Added.
409         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
410         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
411         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
412         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
413         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
414         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
415         * resultsdbpy/resultsdbpy/model: Added.
416         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
417         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
418         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
419         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
420         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
421         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
422         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
423         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
424         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
425         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
426         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
427         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
428         * resultsdbpy/resultsdbpy/model/docker.py: Added.
429         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
430         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
431         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
432         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
433         * resultsdbpy/resultsdbpy/model/model.py: Added.
434         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
435         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
436         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
437         * resultsdbpy/resultsdbpy/model/repository.py: Added.
438         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
439         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
440         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
441         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
442         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
443         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
444         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
445         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
446         * resultsdbpy/resultsdbpy/run-tests: Added.
447         * resultsdbpy/resultsdbpy/view: Added.
448         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
449         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
450         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
451         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
452         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
453         * resultsdbpy/resultsdbpy/view/static: Added.
454         * resultsdbpy/resultsdbpy/view/static/css: Added.
455         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
456         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
457         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
458         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
459         * resultsdbpy/resultsdbpy/view/static/js: Added.
460         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
461         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
462         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
463         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
464         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
465         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
466         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
467         * resultsdbpy/resultsdbpy/view/templates: Added.
468         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
469         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
470         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
471         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
472         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
473         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
474         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
475         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
476         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
477         * resultsdbpy/setup.py: Added.
478
479 2019-07-18  Alex Christensen  <achristensen@webkit.org>
480
481         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
482         https://bugs.webkit.org/show_bug.cgi?id=199923
483
484         Reviewed by Youenn Fablet.
485
486         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
487         (TestWebKitAPI::TEST):
488
489 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
490
491         [ews-build] Enable iOS WK2 tester queue on new EWS
492         https://bugs.webkit.org/show_bug.cgi?id=199867
493
494         Reviewed by Jonathan Bedard.
495
496         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
497         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
499         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
500
501 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
502
503         [ews-build] Add build step to AnalyzeLayoutTestsResults
504         https://bugs.webkit.org/show_bug.cgi?id=199877
505
506         Reviewed by Jonathan Bedard.
507
508         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
509
510         * BuildSlaveSupport/ews-build/steps.py:
511         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
512         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
513         (AnalyzeLayoutTestsResults.report_failure):
514         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
515         (AnalyzeLayoutTestsResults.retry_build):
516         (AnalyzeLayoutTestsResults._results_failed_different_tests):
517         (AnalyzeLayoutTestsResults._report_flaky_tests):
518         (AnalyzeLayoutTestsResults.start):
519         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
520
521 2019-07-18  Alex Christensen  <achristensen@webkit.org>
522
523         Move NetworkCache ownership from NetworkProcess to NetworkSession
524         https://bugs.webkit.org/show_bug.cgi?id=199817
525
526         Reviewed by Geoff Garen.
527
528         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
529         (TEST):
530         * TestWebKitAPI/cocoa/TestWKWebView.h:
531         * TestWebKitAPI/cocoa/TestWKWebView.mm:
532         (-[WKWebView synchronouslyLoadRequest:]):
533
534 2019-07-18  Youenn Fablet  <youenn@apple.com>
535
536         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
537         https://bugs.webkit.org/show_bug.cgi?id=199769
538         <rdar://problem/49390297>
539
540         Reviewed by Myles C. Maxfield.
541
542         Add a font containing one extended character not found in system fonts.
543
544         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
545         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
546
547 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
548
549         Unreviewed, Add Olivier Blin as contributor
550
551         * Scripts/webkitpy/common/config/contributors.json:
552
553 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
554
555         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
556         https://bugs.webkit.org/show_bug.cgi?id=199855
557
558         Reviewed by Michael Catanzaro.
559
560         The webkitpy drivers for GTK and WPE use their own versions for setting
561         up the environment and starting/stopping the drivers.
562         This refactors those drivers to use the base class driver functions.
563         As a benefit we get some fixes like support for setting the profiler
564         environment variables, and a simpler code.
565
566         * Scripts/webkitpy/port/driver.py:
567         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
568         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
569         * Scripts/webkitpy/port/headlessdriver.py:
570         (HeadlessDriver._setup_environ_for_test):
571         * Scripts/webkitpy/port/waylanddriver.py:
572         (WaylandDriver._setup_environ_for_test):
573         * Scripts/webkitpy/port/westondriver.py:
574         (WestonDriver._setup_environ_for_test):
575         (WestonDriver.stop):
576         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
577         (WestonDriverTest.make_driver):
578         * Scripts/webkitpy/port/xorgdriver.py:
579         (XorgDriver._setup_environ_for_test):
580         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
581         (XvfbDriver._setup_environ_for_test):
582         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
583         (XvfbDriverTest.make_driver):
584         (XvfbDriverTest.test_start):
585         (XvfbDriverTest.test_start_arbitrary_worker_number):
586         * Scripts/webkitpy/w3c/wpt_runner.py:
587         (main): Start the driver before trying to get its environment to define all the environment variables.
588         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
589         (WebDriverTestRunner.__init__): Ditto.
590         * glib/api_test_runner.py:
591         (TestRunner._setup_testing_environment): Ditto.
592
593 2019-07-17  Antoine Quint  <graouts@apple.com>
594
595         Disable Pointer Events prior to watchOS 6
596         https://bugs.webkit.org/show_bug.cgi?id=199890
597         <rdar://problem/53206113>
598
599         Reviewed by Dean Jackson.
600
601         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
602
603 2019-07-17  Christopher Reid  <chris.reid@sony.com>
604
605         Bytecode cache should use FileSystem
606         https://bugs.webkit.org/show_bug.cgi?id=199759
607
608         Reviewed by Yusuke Suzuki.
609
610         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
611
612 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
613
614         check-webkit-style: Add limited Python3 support
615         https://bugs.webkit.org/show_bug.cgi?id=199870
616
617         Rubber-stamped by Aakash Jain.
618
619         Since new services will be added in the near future which are Python 3, we
620         need to support Python 3 style checks. For now, assume all Python files are
621         Python 2 unless otherwise specified.
622
623         * Scripts/webkitpy/style/checker.py:
624         (_all_categories): Add pycodestyle to valid categories for testing.
625         (CheckerDispatcher._create_checker): Check that the provided Python file is in
626         one of the declared Python 3 directories.
627         * Scripts/webkitpy/style/checkers/python.py:
628         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
629         instead of pep8.
630         (Python3Checker.__init__):
631         (Python3Checker.check):
632         * Scripts/webkitpy/thirdparty/__init__.py:
633         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
634         (AutoinstallImportHook._install_pycodestyle):
635
636 2019-07-17  Sam Weinig  <weinig@apple.com>
637
638         Add StringBuilder member function which allows makeString() style variadic argument construction
639         https://bugs.webkit.org/show_bug.cgi?id=198997
640
641         Reviewed by Darin Adler.
642
643         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
644         Add basic test showing that StringBuilder::flexibleAppend can be used to 
645         append one or more string adaptable types. 
646
647         * TestWebKitAPI/CMakeLists.txt:
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         Add WTFStringUtilities.cpp
650
651         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
652         Add basic test showing that StringBuilder::flexibleAppend can be used to 
653         append one or more string adaptable types. 
654
655         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
656         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
657         * TestWebKitAPI/WTFStringUtilities.h:
658         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
659         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
660
661 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
662
663         Remove the file superfluously added in r247535.
664
665         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
666         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
667
668 2019-07-17  Alex Christensen  <achristensen@webkit.org>
669
670         Add a runtime-disabled dialog element skeleton
671         https://bugs.webkit.org/show_bug.cgi?id=199839
672
673         Reviewed by Ryosuke Niwa.
674
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         (resetWebPreferencesToConsistentValues):
677         * WebKitTestRunner/TestController.cpp:
678         (WTR::TestController::resetPreferencesToConsistentValues):
679         Enable the dialog element for layout tests.
680
681 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
682
683         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
684         https://bugs.webkit.org/show_bug.cgi?id=199851
685
686         Reviewed by Wenson Hsieh.
687
688         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
689         this code is getting directly triggered from UIKeyboard's code.
690
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
693         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
694         * TestWebKitAPI/ios/UIKitSPI.h:
695
696 2019-07-17  Commit Queue  <commit-queue@webkit.org>
697
698         Unreviewed, rolling out r247505.
699         https://bugs.webkit.org/show_bug.cgi?id=199871
700
701         "Caused failed ASSERT in stress test" (Requested by creid on
702         #webkit).
703
704         Reverted changeset:
705
706         "Bytecode cache should use FileSystem"
707         https://bugs.webkit.org/show_bug.cgi?id=199759
708         https://trac.webkit.org/changeset/247505
709
710 2019-07-17  Russell Epstein  <russell_e@apple.com>
711
712         Adding self to contributors.json
713
714         Unreviewed.
715
716         * Scripts/webkitpy/common/config/contributors.json:
717
718 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
719
720         [ews-build] Parse full_results.json for layout-tests
721         https://bugs.webkit.org/show_bug.cgi?id=199804
722
723         Reviewed by Jonathan Bedard.
724
725         * BuildSlaveSupport/ews-build/steps.py:
726         (RunWebKitTests.start): Monitor json output.
727         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
728         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
729         by the patch or are pre-existing.
730         (ReRunWebKitTests.commandComplete): Ditto.
731         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
732         * BuildSlaveSupport/ews-build/steps_unittest.py:
733         (BuildStepMixinAdditions.getProperty): Added.
734         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
735         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
736
737 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
738
739         Unreviewed, rolling out r247512.
740
741         Broke API test runners
742
743         Reverted changeset:
744
745         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
746         for setting up the environment and start the drivers."
747         https://bugs.webkit.org/show_bug.cgi?id=199855
748         https://trac.webkit.org/changeset/247512
749
750 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
751
752         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
753         https://bugs.webkit.org/show_bug.cgi?id=199855
754
755         Reviewed by Carlos Garcia Campos.
756
757         The webkitpy drivers for GTK and WPE use their own versions for setting
758         up the environment and starting/stopping the drivers.
759         This refactors those drivers to use the base class driver functions.
760         As a benefit we get some fixes like support for setting the profiler
761         environment variables, and a simpler code.
762
763         * Scripts/webkitpy/port/driver.py:
764         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
765         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
766         * Scripts/webkitpy/port/headlessdriver.py:
767         (HeadlessDriver._setup_environ_for_test):
768         * Scripts/webkitpy/port/waylanddriver.py:
769         (WaylandDriver._setup_environ_for_test):
770         * Scripts/webkitpy/port/westondriver.py:
771         (WestonDriver._setup_environ_for_test):
772         (WestonDriver.stop):
773         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
774         (WestonDriverTest.make_driver):
775         * Scripts/webkitpy/port/xorgdriver.py:
776         (XorgDriver._setup_environ_for_test):
777         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
778         (XvfbDriver._setup_environ_for_test):
779         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
780         (XvfbDriverTest.make_driver):
781         (XvfbDriverTest.test_start):
782         (XvfbDriverTest.test_start_arbitrary_worker_number):
783
784 2019-07-16  Christopher Reid  <chris.reid@sony.com>
785
786         Bytecode cache should use FileSystem
787         https://bugs.webkit.org/show_bug.cgi?id=199759
788
789         Reviewed by Yusuke Suzuki.
790
791         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
792
793 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
794
795         svn-create-patch duplicates diffs when adding directories
796         https://bugs.webkit.org/show_bug.cgi?id=199842
797
798         Reviewed by Dewei Zhu.
799
800         * Scripts/svn-create-patch:
801         (findKind): Add function which returns what 'kind' of file the provided path is.
802         (generateFileList): If the path is a directory and being added, don't add it.
803         Instead, rely on the fact that its children will be added.
804
805 2019-07-16  Tim Horton  <timothy_horton@apple.com>
806
807         NSTextFinder holes don't scroll with the page
808         https://bugs.webkit.org/show_bug.cgi?id=199815
809         <rdar://problem/52280514>
810
811         Reviewed by Simon Fraser.
812
813         * MiniBrowser/mac/WK2BrowserWindowController.m:
814         (-[MiniBrowserNSTextFinder performAction:]):
815         (-[WK2BrowserWindowController awakeFromNib]):
816         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
817         -performAction: so that we can intercept the close action and
818         hide our own find UI, since there is no delegate for that action yet.
819
820         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
821         (TEST):
822
823 2019-07-15  Keith Miller  <keith_miller@apple.com>
824
825         JSGlobalObject type macros should support feature flags and WeakRef should have one
826         https://bugs.webkit.org/show_bug.cgi?id=199601
827
828         Reviewed by Mark Lam.
829
830         JSC options need to be set before the window is created for the test.
831
832         * DumpRenderTree/mac/DumpRenderTree.mm:
833         (resetWebViewToConsistentStateBeforeTesting):
834         * DumpRenderTree/win/DumpRenderTree.cpp:
835         (setJSCOptions):
836         (resetWebViewToConsistentStateBeforeTesting):
837
838 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
839
840         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
841         https://bugs.webkit.org/show_bug.cgi?id=193108
842
843         Reviewed by Simon Fraser.
844
845         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
846         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
847         at the wrong scale.
848
849         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
850         (takeWindowSnapshot):
851         (createBitmapContextFromWebView):
852
853 2019-07-15  Brady Eidson  <beidson@apple.com>
854
855         Make WKURLSchemeTask thread safe.
856         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
857
858         Reviewed by Alex Christensen.
859
860         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
861
862 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
863
864         Unreviewed, a build fix after r247437
865
866         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
867         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
868
869 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
870
871         [macOS 10.15] Cannot unbold selected text when the system font is used
872         https://bugs.webkit.org/show_bug.cgi?id=199788
873         <rdar://problem/52142570>
874
875         Reviewed by Tim Horton.
876
877         Add a new API test to verify that bolding and unbolding updates the
878         shared font manager's selected font.
879
880         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
881         (TestWebKitAPI::TEST):
882
883 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
884
885         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
886         https://bugs.webkit.org/show_bug.cgi?id=199790
887         <rdar://problem/52790112>
888
889         Reviewed by Brent Fulgham.
890
891         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
892
893         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
894         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
895         (configureSOAuthorizationWebView):
896         (TestWebKitAPI::TEST):
897         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
898         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
899         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
900         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
901         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
902
903 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
904
905         window.openDatabase is not writable
906         https://bugs.webkit.org/show_bug.cgi?id=199737
907         <rdar://problem/52551332>
908
909         Reviewed by Chris Dumez.
910
911         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
912         (TEST):
913         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
914
915 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
916
917         [ews-build] Parse and display layout test failures
918         https://bugs.webkit.org/show_bug.cgi?id=199709
919
920         Rubber-stamped by Jonathan Bedard.
921
922         * BuildSlaveSupport/ews-build/steps.py:
923         (RunWebKitTests.start): Initialize log_observer.
924         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
925         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
926         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
927         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
928         (RunWebKitTests.getResultSummary): Update build and step summary.
929         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
930
931 2019-07-15  Commit Queue  <commit-queue@webkit.org>
932
933         Unreviewed, rolling out r247393.
934         https://bugs.webkit.org/show_bug.cgi?id=199797
935
936         broke mips and arm EWS (Requested by guijemont on #webkit).
937
938         Reverted changeset:
939
940         "run-javascriptcore-tests won't report test results for
941         testmasm, testair, testb3, testdfg and test api"
942         https://bugs.webkit.org/show_bug.cgi?id=199489
943         https://trac.webkit.org/changeset/247393
944
945 2019-07-12  Andy Estes  <aestes@apple.com>
946
947         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
948         https://bugs.webkit.org/show_bug.cgi?id=199768
949         <rdar://problem/52002206>
950
951         Reviewed by Geoffrey Garen.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
954         (TEST):
955
956 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-build] Remove wincairo queue from old EWS and dashboard
959         https://bugs.webkit.org/show_bug.cgi?id=199776
960
961         Reviewed by Don Olmstead.
962
963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
964         * QueueStatusServer/config/queues.py:
965
966 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
967
968         [ews-build] Enable wincairo queue on new EWS
969         https://bugs.webkit.org/show_bug.cgi?id=199593
970
971         Reviewed by Don Olmstead.
972
973         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
974         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
975         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
976         (StatusBubble): Enable wincairo status-bubble.
977
978 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
979
980         [ews-app] Enable logging for clicking SubmitToEWS button
981         https://bugs.webkit.org/show_bug.cgi?id=199757
982
983         Unreviewed minor infrastructure fix.
984
985         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
986         (SubmitToEWS.post): Change logging level from debug to info.
987
988 2019-07-12  Alex Christensen  <achristensen@webkit.org>
989
990         Enable client certificate authentication unit test
991         https://bugs.webkit.org/show_bug.cgi?id=199735
992
993         Reviewed by Chris Dumez.
994
995         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
996         (TEST):
997         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
998         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
999
1000 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1001
1002         Begin unifying TestWebKitAPI build
1003         https://bugs.webkit.org/show_bug.cgi?id=199728
1004
1005         Reviewed by Keith Miller.
1006
1007         * TestWebKitAPI/Configurations/Base.xcconfig:
1008         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
1009         * TestWebKitAPI/Sources.txt: Added.
1010         * TestWebKitAPI/SourcesCocoa.txt: Added.
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012
1013 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
1014
1015         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1016         https://bugs.webkit.org/show_bug.cgi?id=199489
1017         <rdar://problem/47891081>
1018
1019         Reviewed by Aakash Jain.
1020
1021         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1022         (RunJavaScriptCoreTests.countFailures):
1023         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1024         * Scripts/run-javascriptcore-tests:
1025         (runTest):
1026         (reportTestFailures):
1027         (runJSCStressTests):
1028
1029 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1030
1031         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
1032         https://bugs.webkit.org/show_bug.cgi?id=199743
1033
1034         Reviewed by Jonathan Bedard.
1035
1036         * BuildSlaveSupport/ews-build/steps.py:
1037         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1038
1039 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1040
1041         Unreviewed follow-up fix to r247364.
1042         [ews-build] Add build step to clean up .git/index.lock file
1043         https://bugs.webkit.org/show_bug.cgi?id=199722
1044
1045         * BuildSlaveSupport/ews-build/steps.py:
1046         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
1047         to be run after this step.
1048
1049 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
1050
1051         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
1052         https://bugs.webkit.org/show_bug.cgi?id=199524
1053         <rdar://problem/52783816>
1054
1055         Reviewed by Saam Barati.
1056
1057         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
1058         But this test has several problems.
1059
1060         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
1061            number is calculated by pageSize / sizeof(T), and this does not account the header
1062            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
1063            is very small, we can have many objects in one IsoPage. As a result, we need a large
1064            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
1065            less than numObjects.
1066
1067         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
1068            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
1069            page. This also makes the intention of this test wrong.
1070
1071         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
1072
1073         We make this test robust while we still keep this test white-box one to test the critical feature
1074         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
1075         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
1076         tier live, and check whether the deallocated memory is reused.
1077
1078         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1079         (TEST):
1080
1081 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
1082
1083         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
1084         https://bugs.webkit.org/show_bug.cgi?id=199625
1085
1086         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
1087         with ENABLE(ACCESSIBILITY) in the code.
1088
1089         Additionally, the TestRunner code generator now honors the
1090         Conditional IDL format.
1091
1092         Reviewed by Konstantin Tokarev.
1093
1094         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1095         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1096         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1097         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1098         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1099         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1100         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1101         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1102         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1103         (_generateImplementationFile):
1104
1105 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1106
1107         [ews-build] Add build step to clean up .git/index.lock file
1108         https://bugs.webkit.org/show_bug.cgi?id=199722
1109
1110         Reviewed by Jonathan Bedard.
1111
1112         * BuildSlaveSupport/ews-build/steps.py:
1113         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
1114         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
1115         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
1116         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1117
1118 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
1119
1120         [iOS 13] Enable WebKit build
1121         https://bugs.webkit.org/show_bug.cgi?id=199481
1122         <rdar://problem/52619048>
1123
1124         Reviewed by Tim Horton.
1125
1126         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
1127
1128 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
1129
1130         Add test expectations and baselines for iOS 13
1131         https://bugs.webkit.org/show_bug.cgi?id=199329
1132
1133         Reviewed by Jonathan Bedard.
1134
1135         * Scripts/webkitpy/port/ios.py:
1136         (IOSPort): Increment current version to 13.
1137         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
1138         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
1139         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
1140         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
1141         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
1142         (IOSSimulatorTest.make_port):
1143         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
1144         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
1145         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
1146         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
1147         (IOSTest.make_port):
1148
1149 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
1150
1151         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
1152         https://bugs.webkit.org/show_bug.cgi?id=199692
1153
1154         Reviewed by Chris Fleizach.
1155
1156         Add support for output of AXDeletion and AXInsertion roles for tests.
1157         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
1158         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
1159
1160         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1161         * gtk/jhbuild.modules:
1162         * wpe/jhbuild.modules:
1163
1164 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
1165
1166         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
1167         https://bugs.webkit.org/show_bug.cgi?id=199707
1168
1169         Reviewed by Aakash Jain.
1170
1171         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
1172
1173 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
1174
1175         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
1176         https://bugs.webkit.org/show_bug.cgi?id=199693
1177         rdar://problem/51930364
1178
1179         Reviewed by Tim Horton.
1180         
1181         New API tests that test scrollability with various combinations of content, insets,
1182         input accessory bars etc.
1183
1184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1185         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
1186         (TestWebKitAPI::webViewWithAutofocusedInput):
1187         (TestWebKitAPI::TEST):
1188
1189 2019-07-10  Tim Horton  <timothy_horton@apple.com>
1190
1191         Long pressing on attachments will crash the WebContent process
1192         https://bugs.webkit.org/show_bug.cgi?id=199696
1193         <rdar://problem/52920241>
1194
1195         Reviewed by Dean Jackson.
1196
1197         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1198         (TestWebKitAPI::TEST):
1199         Add a test that previously crashed.
1200
1201 2019-07-10  Dean Jackson  <dino@apple.com>
1202
1203         Support MacCatalyst in run-webkit-app
1204         https://bugs.webkit.org/show_bug.cgi?id=199690
1205
1206         Reviewed by Tim Horton.
1207
1208         Add a --maccatalyst option to run-webkit-app that
1209         can launch MacCatalyst applications with a built WebKit.
1210
1211         * Scripts/webkitdirs.pm:
1212         (argumentsForConfiguration):
1213         (determineXcodeSDK):
1214         (xcodeSDKPlatformName):
1215         (determineConfigurationProductDir):
1216         (determinePortName):
1217         (isCatalystWebKit):
1218         (isAppleCocoaWebKit):
1219         (willUseCatalystSDK):
1220
1221 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
1222
1223         [MacOS] Filter VPA info logged to stdout
1224         https://bugs.webkit.org/show_bug.cgi?id=199673
1225
1226         Reviewed by Eric Carlson.
1227
1228         * Scripts/webkitpy/port/mac.py:
1229         (MacPort.logging_patterns_to_strip):
1230
1231 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
1232
1233         Unreviewed, rolling out r247286.
1234
1235         Caused TestWTF.WTF.StringOperators to fail on debug bots
1236
1237         Reverted changeset:
1238
1239         "Add StringBuilder member function which allows makeString()
1240         style variadic argument construction"
1241         https://bugs.webkit.org/show_bug.cgi?id=198997
1242         https://trac.webkit.org/changeset/247286
1243
1244 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
1245
1246         [ews-build] Explicitly use perl or python while invoking scripts
1247         https://bugs.webkit.org/show_bug.cgi?id=199669
1248
1249         Reviewed by Jonathan Bedard.
1250
1251         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
1252         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1253
1254 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
1255
1256         Run tests on mips EWS
1257         https://bugs.webkit.org/show_bug.cgi?id=196854
1258
1259         Reviewed by Carlos Garcia Campos.
1260
1261         * Scripts/webkitpy/common/config/ews.json:
1262
1263 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1264
1265         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
1266         https://bugs.webkit.org/show_bug.cgi?id=199579
1267
1268         Reviewed by Carlos Garcia Campos.
1269
1270         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
1271         (TestWebKitAPI::TEST):
1272
1273 2019-07-09  Chris Dumez  <cdumez@apple.com>
1274
1275         Fix integer type encoding / decoding in WKRemoteObjectCoder
1276         https://bugs.webkit.org/show_bug.cgi?id=199643
1277         <rdar://problem/52732342>
1278
1279         Reviewed by Anders Carlsson.
1280
1281         Update API test coverage.
1282
1283         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1284         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1285         (TEST):
1286         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1287         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
1288         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
1289         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
1290         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
1291
1292 2019-07-09  Sam Weinig  <weinig@apple.com>
1293
1294         Add StringBuilder member function which allows makeString() style variadic argument construction
1295         https://bugs.webkit.org/show_bug.cgi?id=198997
1296
1297         Reviewed by Darin Adler.
1298
1299         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1300         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1301         append one or more string adaptable types. 
1302
1303 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
1304
1305         Only allow fetching and removing session credentials from WebsiteDataStore
1306         https://bugs.webkit.org/show_bug.cgi?id=199385
1307         <rdar://problem/52622080>
1308
1309         Reviewed by Alex Christensen.
1310
1311         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
1312         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
1313         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
1314
1315         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1316         (TEST):
1317         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1318         (TestWebKitAPI::TEST):
1319
1320 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1321
1322         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
1323         https://bugs.webkit.org/show_bug.cgi?id=199628
1324
1325         Reviewed by Brady Eidson.
1326
1327         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1328         (TestWebKitAPI::TEST_F):
1329
1330 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1331
1332         Remove invalid assertion in URLParser::domainToASCII
1333         https://bugs.webkit.org/show_bug.cgi?id=199624
1334
1335         Reviewed by Brady Eidson.
1336
1337         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1338         (TestWebKitAPI::TEST_F):
1339
1340 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1341
1342         URLParser should reserialize IPv6 addresses that end with a colon
1343         https://bugs.webkit.org/show_bug.cgi?id=199627
1344
1345         Reviewed by Brady Eidson.
1346
1347         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1348         (TestWebKitAPI::TEST_F):
1349
1350 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
1351
1352         [ews-build] Do not run unix commands for windows in PrintConfiguration
1353         https://bugs.webkit.org/show_bug.cgi?id=199605
1354
1355         Reviewed by Jonathan Bedard.
1356
1357         * BuildSlaveSupport/ews-build/steps.py:
1358
1359 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1360
1361         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
1362         https://bugs.webkit.org/show_bug.cgi?id=199487
1363
1364         Reviewed by Ross Kirsling.
1365
1366         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
1367         failing to open testglobalscope_constructors_file which was
1368         created by using tempfile.mkstemp() because it keeps the file
1369         open. Use tempfile.mkdtemp() to create temporary files in the
1370         temporary directory instead of tempfile.mkstemp().
1371
1372         * Scripts/webkitpy/bindings/main.py:
1373         (BindingsTests.run_tests):
1374         (BindingsTests.main):
1375         (BindingsTests.close_and_remove): Deleted.
1376
1377 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
1378
1379         [ews-build] Add KillOldProcesses step before running API or Layout tests
1380         https://bugs.webkit.org/show_bug.cgi?id=199592
1381
1382         Reviewed by Jonathan Bedard.
1383
1384         * BuildSlaveSupport/ews-build/factories.py:
1385
1386 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
1387
1388         test-webkitpy: Explicitly use Python 2.7 lldb library
1389         https://bugs.webkit.org/show_bug.cgi?id=199578
1390         <rdar://problem/51853557>
1391
1392         Reviewed by Aakash Jain.
1393
1394         * Scripts/webkitpy/common/system/systemhost.py:
1395         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
1396         * Scripts/webkitpy/test/main.py:
1397         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
1398
1399 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
1400
1401         Add test expectations and baselines for Catalina
1402         https://bugs.webkit.org/show_bug.cgi?id=199328
1403
1404         Reviewed by Jonathan Bedard.
1405
1406         * Scripts/webkitpy/port/mac.py:
1407         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
1408
1409 2019-07-08  Christopher Reid  <chris.reid@sony.com>
1410
1411         Implement MappedFileData for Windows
1412         https://bugs.webkit.org/show_bug.cgi?id=198269
1413
1414         Reviewed by Darin Adler.
1415
1416         * TestWebKitAPI/PlatformWin.cmake:
1417
1418 2019-07-08  Charlie Turner  <cturner@igalia.com>
1419
1420         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
1421         https://bugs.webkit.org/show_bug.cgi?id=197558
1422
1423         Reviewed by Xabier Rodriguez-Calvar.
1424
1425         On shutdown we can easily deadlock the web process if we don't
1426         ensure all network operations are completed before comitting state
1427         changes. In HLS, make sure the network operations are cancelled,
1428         and also prevent hlsdemux's retry logic from scuppering our
1429         efforts.
1430
1431         * gstreamer/jhbuild.modules: Include the patch.
1432         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
1433
1434 2019-07-08  Antoine Quint  <graouts@apple.com>
1435
1436         [Pointer Events] Enable only on the most recent version of the supported iOS family
1437         https://bugs.webkit.org/show_bug.cgi?id=199562
1438         <rdar://problem/52766511>
1439
1440         Reviewed by Dean Jackson.
1441
1442         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1443
1444 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
1445
1446         Long hang when loading a cnn.com page on iOS
1447         https://bugs.webkit.org/show_bug.cgi?id=199556
1448
1449         Reviewed by Zalan Bujtas.
1450
1451         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
1452         to load a test page of your choice.
1453
1454         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
1455         (-[WebViewController viewDidLoad]):
1456
1457 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
1458
1459         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
1460         https://bugs.webkit.org/show_bug.cgi?id=199503
1461
1462         Reviewed by Wenson Hsieh.
1463
1464         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
1465         _requestActivatedElementAtPosition
1466
1467         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1468         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1469         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1470         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1471         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1472         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1473         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1474         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1475         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1476         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1477         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
1478         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1479
1480 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
1481
1482         Unreviewed, rolling out r247115.
1483
1484         Breaks lldbWebKitTester (and by extension, test-webkitpy)
1485
1486         Reverted changeset:
1487
1488         "[WHLSL] Standard library is too big to directly include in
1489         WebCore"
1490         https://bugs.webkit.org/show_bug.cgi?id=198186
1491         https://trac.webkit.org/changeset/247115
1492
1493 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
1494
1495         Unreviewed, rolling out r247123.
1496
1497         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
1498         fail.
1499
1500         Reverted changeset:
1501
1502         "Only allow fetching and removing session credentials from
1503         WebsiteDataStore"
1504         https://bugs.webkit.org/show_bug.cgi?id=199385
1505         https://trac.webkit.org/changeset/247123
1506
1507 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1508
1509         Touching media controls sometimes shows software keyboard
1510         https://bugs.webkit.org/show_bug.cgi?id=199490
1511         <rdar://problem/52076270>
1512
1513         Reviewed by Eric Carlson.
1514
1515         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
1516         ChangeLog entries for more detail.
1517
1518         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1519         (WTR::UIScriptController::hasInputSession const):
1520         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1521         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1522         (WTR::UIScriptController::hasInputSession const):
1523         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1524         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1525         (WTR::UIScriptController::hasInputSession const):
1526
1527 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
1528
1529         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
1530         https://bugs.webkit.org/show_bug.cgi?id=199458
1531
1532         Reviewed by Michael Catanzaro.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1535         * QueueStatusServer/config/queues.py:
1536
1537 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1538
1539         [GTK] Fix browserperfdash script after r239522
1540         https://bugs.webkit.org/show_bug.cgi?id=199496
1541
1542         Reviewed by Michael Catanzaro.
1543
1544         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
1545         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
1546
1547 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1548
1549         [webkitpy] test-webkitpy is broken on Linux since r246662
1550         https://bugs.webkit.org/show_bug.cgi?id=199493
1551
1552         Reviewed by Michael Catanzaro.
1553
1554         * Scripts/webkitpy/test/main.py:
1555         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
1556
1557 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1558
1559         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
1560         https://bugs.webkit.org/show_bug.cgi?id=199406
1561
1562         Reviewed by Michael Catanzaro.
1563
1564         Install the Woff2 libraries and headers from the system package
1565         and stop building them on the JHBuild.
1566
1567         * gtk/install-dependencies:
1568         * gtk/jhbuild.modules:
1569         * wpe/install-dependencies:
1570         * wpe/jhbuild.modules:
1571
1572 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1573
1574         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
1575         https://bugs.webkit.org/show_bug.cgi?id=199449
1576
1577         Reviewed by Michael Catanzaro.
1578
1579         * Scripts/webkitdirs.pm:
1580         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
1581
1582 2019-07-01  Philippe Normand  <pnormand@igalia.com>
1583
1584         Unreviewed, GTK a11y tests fix after r247071
1585
1586         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1587         (WTR::AccessibilityUIElement::popupValue const):
1588
1589 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
1590
1591         [ews-build] Enable WPE and GTK queues on new EWS
1592         https://bugs.webkit.org/show_bug.cgi?id=199234
1593
1594         Reviewed by Jonathan Bedard.
1595
1596         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
1597         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
1598         * BuildSlaveSupport/ews-build/steps.py:
1599         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
1600         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1601         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1602         (StatusBubble): Enable gtk and wpe status-bubbles.
1603
1604 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
1605
1606         Only allow fetching and removing session credentials from WebsiteDataStore
1607         https://bugs.webkit.org/show_bug.cgi?id=199385
1608
1609         Reviewed by Alex Christensen.
1610
1611         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1612         (TestWebKitAPI::TEST):
1613
1614 2019-07-03  Tim Horton  <timothy_horton@apple.com>
1615
1616         UI process exception when dragging an <attachment> with no content type
1617         https://bugs.webkit.org/show_bug.cgi?id=199480
1618         <rdar://problem/44351353>
1619
1620         Reviewed by Wenson Hsieh.
1621
1622         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1623         (TestWebKitAPI::TEST):
1624         Add a test; before the change, it crashes.
1625
1626 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
1627
1628         [Catalina] Enable WebKit build
1629         https://bugs.webkit.org/show_bug.cgi?id=199209
1630
1631         Reviewed by Darin Adler.
1632
1633         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
1634
1635 2019-07-03  Sam Weinig  <weinig@apple.com>
1636
1637         Adopt simple structured bindings in more places
1638         https://bugs.webkit.org/show_bug.cgi?id=199247
1639
1640         Reviewed by Alex Christensen.
1641
1642         Replaces simple uses of std::tie() with structured bindings. Does not touch
1643         uses of std::tie() that are not initial declarations, use std::ignore or in
1644         case where the binding is captured by a lambda, as structured bindings don't
1645         work for those cases yet.
1646
1647         * TestWebKitAPI/ios/PreferredContentMode.mm:
1648         (TestWebKitAPI::TEST):
1649
1650 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
1651
1652         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
1653
1654         * BuildSlaveSupport/ews-build/steps.py:
1655         (PrintConfiguration.run):
1656
1657 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1658
1659         [ews-build] Add build steps to Install Wpe and Gtk dependencies
1660         https://bugs.webkit.org/show_bug.cgi?id=199408
1661
1662         Reviewed by Michael Catanzaro.
1663
1664         * BuildSlaveSupport/ews-build/steps.py:
1665         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
1666         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
1667         (InstallWpeDependencies): Ditto for WPE.
1668         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1669
1670 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1671
1672         [ews-build] Allow skipping uploading built product for few builders
1673         https://bugs.webkit.org/show_bug.cgi?id=199422
1674
1675         Reviewed by Michael Catanzaro.
1676
1677         * BuildSlaveSupport/ews-build/steps.py:
1678         (CompileWebKit.__init__): Added optional skipUpload parameter.
1679         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
1680
1681 2019-07-02  Tim Horton  <timothy_horton@apple.com>
1682
1683         REGRESSION (r243240): Unable to swipe back in Safari
1684         https://bugs.webkit.org/show_bug.cgi?id=199394
1685         <rdar://problem/51137447>
1686
1687         Reviewed by Wenson Hsieh.
1688
1689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1690         Make sure that we actually end up with swipe gesture recognizers installed
1691         after process swap and crash.
1692
1693 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
1694
1695         Enhance support of aria-haspopup per ARIA 1.1 specification.
1696         https://bugs.webkit.org/show_bug.cgi?id=199216
1697         <rdar://problem/46221342>
1698
1699         Reviewed by Chris Fleizach.
1700
1701         * DumpRenderTree/AccessibilityUIElement.cpp:
1702         (getPopupValueCallback):
1703         (AccessibilityUIElement::getJSClass):
1704         * DumpRenderTree/AccessibilityUIElement.h:
1705         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1706         (AccessibilityUIElement::popupValue const):
1707         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1708         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1709         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1710         (WTR::AccessibilityUIElement::popupValue const):
1711         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1712         (WTR::AccessibilityUIElement::popupValue const):
1713
1714 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-build] Do not print worker environment variables in each build step [part 2]
1717         https://bugs.webkit.org/show_bug.cgi?id=199405
1718
1719         Reviewed by Jonathan Bedard.
1720
1721         * BuildSlaveSupport/ews-build/steps.py:
1722         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
1723         (CleanWorkingDirectory.__init__): Ditto.
1724         (RunBindingsTests.__init__): Ditto.
1725         (RunWebKitPerlTests.__init__): Ditto.
1726         (RunWebKitPyTests.__init__): Ditto.
1727         (CompileWebKit.__init__): Ditto.
1728         (ArchiveTestResults.__init__): Ditto.
1729         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1730
1731 2019-07-02  Jer Noble  <jer.noble@apple.com>
1732
1733         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
1734         https://bugs.webkit.org/show_bug.cgi?id=199381
1735         <rdar://problem/52483103>
1736
1737         Reviewed by Eric Carlson.
1738
1739         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1740
1741 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1742
1743         [ews-build] Update bot configuration for WPE and GTK
1744         https://bugs.webkit.org/show_bug.cgi?id=199238
1745
1746         Reviewed by Michael Catanzaro.
1747
1748         * BuildSlaveSupport/ews-build/config.json:
1749
1750 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1751
1752         [ews-build] Make PrintConfiguration platform aware
1753         https://bugs.webkit.org/show_bug.cgi?id=196657
1754
1755         Reviewed by Lucas Forschler.
1756
1757         * BuildSlaveSupport/ews-build/steps.py:
1758         (PrintConfiguration): Specified platform-specific command lists.
1759         (PrintConfiguration.run): Override run method and specify platform specific commands.
1760         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1761
1762 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
1763
1764         [Wasm-References] Disable references by default
1765         https://bugs.webkit.org/show_bug.cgi?id=199390
1766
1767         Reviewed by Saam Barati.
1768
1769         * Scripts/run-jsc-stress-tests:
1770
1771 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
1772
1773         Unreviewed. Revert r246965 to fix build break
1774         since r247019 reverted its related changes.
1775
1776         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1777         (WTR::AccessibilityUIElement::popupValue const): Deleted.
1778
1779 2019-07-01  Alex Christensen  <achristensen@webkit.org>
1780
1781         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
1782         https://bugs.webkit.org/show_bug.cgi?id=199371
1783         <rdar://problem/52352905>
1784
1785         Reviewed by Tim Horton.
1786
1787         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1788         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
1789         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
1790         (-[NavigationActionSPIDelegate spiCalled]):
1791         (TEST):
1792
1793 2019-07-01  Alex Christensen  <achristensen@webkit.org>
1794
1795         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
1796         https://bugs.webkit.org/show_bug.cgi?id=199296
1797         <rdar://problem/51041960>
1798
1799         Reviewed by Darin Adler.
1800
1801         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1802         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
1803
1804 2019-07-01  Truitt Savell  <tsavell@apple.com>
1805
1806         Unreviewed, rolling out r246958.
1807
1808         Broke inspector/dom/getAccessibilityPropertiesForNode.html
1809
1810         Reverted changeset:
1811
1812         "Enhance support of aria-haspopup per ARIA 1.1 specification."
1813         https://bugs.webkit.org/show_bug.cgi?id=199216
1814         https://trac.webkit.org/changeset/246958
1815
1816 2019-07-01  Philippe Normand  <pnormand@igalia.com>
1817
1818         Unreviewed, GTK a11y tests fix after r246958
1819
1820         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1821         (WTR::AccessibilityUIElement::popupValue const):
1822
1823 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
1824
1825         Enhance support of aria-haspopup per ARIA 1.1 specification.
1826         https://bugs.webkit.org/show_bug.cgi?id=199216
1827         <rdar://problem/46221342>
1828
1829         Reviewed by Chris Fleizach.
1830
1831         * DumpRenderTree/AccessibilityUIElement.cpp:
1832         (getPopupValueCallback):
1833         (AccessibilityUIElement::getJSClass):
1834         * DumpRenderTree/AccessibilityUIElement.h:
1835         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1836         (AccessibilityUIElement::popupValue const):
1837         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1838         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1839         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1840         (WTR::AccessibilityUIElement::popupValue const):
1841         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1842         (WTR::AccessibilityUIElement::popupValue const):
1843
1844 2019-06-28  Robin Morisset  <rmorisset@apple.com>
1845
1846         Adding myself as a reviewer to contributors.json.
1847
1848         Unreviewed.
1849
1850         * Scripts/webkitpy/common/config/contributors.json:
1851
1852 2019-06-28  Jer Noble  <jer.noble@apple.com>
1853
1854         Add new -[WKWebView _closeAllMediaPresentations] SPI
1855         https://bugs.webkit.org/show_bug.cgi?id=199294
1856         <rdar://problem/51965958>
1857
1858         Reviewed by Alex Christensen.
1859
1860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1861         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
1862         (TEST):
1863
1864 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
1865
1866         Add a regression test for change r246901
1867         https://bugs.webkit.org/show_bug.cgi?id=199290
1868
1869         Reviewed by Geoffrey Garen.
1870
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1873         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1874         (TEST):
1875         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
1876
1877 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
1878
1879         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
1880         https://bugs.webkit.org/show_bug.cgi?id=199317
1881
1882         Reviewed by Michael Catanzaro.
1883
1884         While IconDatabase and all code using it was removed,
1885         ENABLE_ICONDATABASE still exists as build option and C++ macro.
1886
1887         * Scripts/webkitperl/FeatureList.pm:
1888         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1889         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
1890         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
1891
1892 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1893
1894         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
1895         https://bugs.webkit.org/show_bug.cgi?id=199310
1896         <rdar://problem/52292137>
1897
1898         Reviewed by Megan Gardner.
1899
1900         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
1901         _elementDidFocus.
1902
1903         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1906         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1907         (-[TestInputDelegate setDidStartInputSessionHandler:]):
1908         (-[TestInputDelegate didStartInputSessionHandler]):
1909
1910         Add plumbing for a handler block in TestInputDelegate.
1911
1912         (-[TestInputDelegate setWillStartInputSessionHandler:]):
1913
1914         Drive-by style fixes to add a space between id and < for Objective-C protocols.
1915
1916         (-[TestInputDelegate willStartInputSessionHandler]):
1917         (-[TestInputDelegate _webView:willStartInputSession:]):
1918         (-[TestInputDelegate _webView:didStartInputSession:]):
1919         * TestWebKitAPI/cocoa/TestWKWebView.h:
1920         * TestWebKitAPI/ios/UIKitSPI.h:
1921
1922         Add a declaration for _selectionClipRects.
1923
1924 2019-06-27  Zalan Bujtas  <zalan@apple.com>
1925
1926         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
1927         https://bugs.webkit.org/show_bug.cgi?id=199303
1928         <rdar://problem/51340927>
1929
1930         Reviewed by Tim Horton.
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1933         (TEST):
1934
1935 2019-06-27  Beth Dakin  <bdakin@apple.com>
1936
1937         Upstream use of MACCATALYST
1938         https://bugs.webkit.org/show_bug.cgi?id=199245
1939         rdar://problem/51687723
1940
1941         Reviewed by Tim Horton.
1942
1943         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
1944         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
1945         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
1946         * MiniBrowser/Configurations/SDKVariant.xcconfig:
1947         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
1948         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1949         (JavaScriptCoreGenerator):
1950         (WebCoreGenerator):
1951         (WebKitGenerator):
1952         * TestWebKitAPI/Configurations/Base.xcconfig:
1953         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1954         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
1955         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1956         * WebEditingTester/Configurations/SDKVariant.xcconfig:
1957         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
1958         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
1959         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
1960
1961 2019-06-27  Saam Barati  <sbarati@apple.com>
1962
1963         Make WEBGPU enabled only on Mojave and later.
1964
1965         Rubber-stamped by Myles C. Maxfield.
1966
1967         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1968
1969 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
1970
1971         [ews-build] Do not print worker environment variables in each build step
1972         https://bugs.webkit.org/show_bug.cgi?id=197319
1973
1974         Reviewed by Lucas Forschler.
1975
1976         * BuildSlaveSupport/ews-build/steps.py:
1977         (CheckOutSource.__init__): Disabled logging of environment variables.
1978         (ApplyPatch.__init__): Ditto.
1979         (KillOldProcesses.__init__): Ditto.
1980         (ArchiveBuiltProduct.__init__): Ditto.
1981         (DownloadBuiltProduct.__init__): Ditto.
1982         (ExtractBuiltProduct.__init__): Ditto.
1983         (RunAPITests.__init__): Ditto.
1984         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1985
1986 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
1987
1988         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
1989         https://bugs.webkit.org/show_bug.cgi?id=199232
1990         <rdar://problem/51718328>
1991
1992         Reviewed by Youenn Fablet.
1993
1994         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1995         (TestWebKitAPI::TEST):
1996         Add a test that utilizes TCPServer as local files always omit referrer.
1997
1998 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-build] Add configuration and architecture for WPE and GTK builders
2001         https://bugs.webkit.org/show_bug.cgi?id=199249
2002
2003         Reviewed by Jonathan Bedard.
2004
2005         * BuildSlaveSupport/ews-build/config.json:
2006
2007 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2008
2009         [ews-build] Add check for duplicate workers in config.json
2010         https://bugs.webkit.org/show_bug.cgi?id=199240
2011
2012         Reviewed by Jonathan Bedard.
2013
2014         * BuildSlaveSupport/ews-build/loadConfig.py:
2015         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
2016         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2017         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
2018
2019 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2020
2021         [Win] MiniBrowser should make better font choices
2022         https://bugs.webkit.org/show_bug.cgi?id=199244
2023
2024         Reviewed by Brent Fulgham.
2025
2026         * MiniBrowser/win/MainWindow.cpp:
2027         (MainWindow::updateDeviceScaleFactor):
2028         * MiniBrowser/win/MiniBrowserLib.rc:
2029
2030 2019-06-26  Alex Christensen  <achristensen@webkit.org>
2031
2032         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
2033         https://bugs.webkit.org/show_bug.cgi?id=199230
2034         <rdar://51757107>
2035
2036         Reviewed by Andy Estes.
2037
2038         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2039         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2040         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2041         * WebKitTestRunner/TestController.cpp:
2042         (WTR::TestController::generatePageConfiguration):
2043         (WTR::TestController::createWebViewWithOptions):
2044         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
2045         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
2046         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2047         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
2048         * WebKitTestRunner/TestController.h:
2049         * WebKitTestRunner/TestInvocation.cpp:
2050         (WTR::TestInvocation::invoke):
2051         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2052
2053 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2054
2055         [Win][MiniBrowser] Remove obsolete code after r246814.
2056         https://bugs.webkit.org/show_bug.cgi?id=199233
2057
2058         Reviewed by Fujii Hironori.
2059
2060         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2061         (MiniBrowserWebHost::didFinishLoadForFrame):
2062         (SimpleEventListener::SimpleEventListener): Deleted.
2063         (SimpleEventListener::handleEvent): Deleted.
2064
2065 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
2066
2067         Implement a new SPI to inform clients about AppSSO
2068         https://bugs.webkit.org/show_bug.cgi?id=199085
2069         <rdar://problem/50028246>
2070
2071         Reviewed by Geoffrey Garen.
2072
2073         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2074         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
2075         (-[TestSOAuthorizationNavigationDelegate init]):
2076         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
2077         (TestWebKitAPI::TEST):
2078
2079 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2080
2081         [ews-build] Retry Layout test in case of failures
2082         https://bugs.webkit.org/show_bug.cgi?id=199194
2083
2084         Reviewed by Jonathan Bedard.
2085
2086         * BuildSlaveSupport/ews-build/steps.py:
2087         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
2088         (ReRunWebKitTests): Build step to re-run layout tests.
2089         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
2090         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
2091         (RunWebKitTestsWithoutPatch.evaluateCommand):
2092
2093 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2094
2095         [ews-build] Combine various patchFailed*Tests properties
2096         https://bugs.webkit.org/show_bug.cgi?id=199193
2097
2098         Reviewed by Jonathan Bedard.
2099
2100         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
2101         can also be used for layout-tests later on.
2102         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2103
2104 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
2105
2106         [Win] MiniBrowser should default to webkit.org
2107         https://bugs.webkit.org/show_bug.cgi?id=199201
2108
2109         Reviewed by Don Olmstead.
2110
2111         * MiniBrowser/win/BrowserWindow.h:
2112         * MiniBrowser/win/MiniBrowserReplace.h:
2113         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2114         (WebKitBrowserWindow::loadHTMLString): Deleted.
2115         * MiniBrowser/win/WebKitBrowserWindow.h:
2116         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2117         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
2118         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2119         * MiniBrowser/win/WinMain.cpp:
2120         (wWinMain):
2121
2122 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2123
2124         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
2125         https://bugs.webkit.org/show_bug.cgi?id=199192
2126         <rdar://problem/51554509>
2127
2128         Reviewed by Tim Horton.
2129
2130         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
2131         verify that we gracefully handle web process termination and web view unparenting mid-drag.
2132
2133         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2134         (TestWebKitAPI::TEST):
2135         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2136         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2137         (-[DragAndDropSimulator _resetSimulatedState]):
2138         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2139         (-[DragAndDropSimulator _advanceProgress]):
2140         (-[DragAndDropSimulator liftPreviews]):
2141         (-[DragAndDropSimulator cancellationPreviews]):
2142         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
2143         (-[DragAndDropSimulator sessionWillBeginBlock]):
2144         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
2145
2146 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2147
2148         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
2149         https://bugs.webkit.org/show_bug.cgi?id=199178
2150
2151         Reviewed by Jonathan Bedard.
2152
2153         * BuildSlaveSupport/ews-build/steps.py:
2154         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
2155         (ExtractTestResults.__init__): Ditto.
2156         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
2157
2158 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2159
2160         Add user agent quirk for bankofamerica.com
2161         https://bugs.webkit.org/show_bug.cgi?id=199154
2162
2163         Reviewed by Carlos Garcia Campos.
2164
2165         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2166         (TestWebKitAPI::TEST):
2167
2168 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2169
2170         Fully rename WebKitGTK+ -> WebKitGTK everywhere
2171         https://bugs.webkit.org/show_bug.cgi?id=199159
2172
2173         Reviewed by Carlos Garcia Campos.
2174
2175         * BuildSlaveSupport/gtk/README:
2176         * MiniBrowser/gtk/BrowserWindow.c:
2177         * MiniBrowser/gtk/main.c:
2178         (aboutURISchemeRequestCallback):
2179         * Scripts/webkitpy/common/config/contributionareas.py:
2180         * Scripts/webkitpy/common/config/contributors.json:
2181         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2182         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2183         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2184         (testWebViewResources):
2185         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2186         (testWebViewMouseTarget):
2187         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2188         (testWebExtensionGetTitle):
2189         (testDocumentLoadedSignal):
2190         (testWebExtensionFormControlsAssociated):
2191         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2192         (testWebKitSettingsUserAgent):
2193         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2194         (testWebViewRunJavaScript):
2195         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
2196         (main):
2197         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2198         (prepareContextMenuTestView):
2199         (testContextMenuPopulateMenu):
2200         (testContextMenuCustomMenu):
2201         (testContextMenuDisableMenu):
2202         (testContextMenuSubMenu):
2203         (testContextMenuDismissed):
2204         (testContextMenuWebExtensionMenu):
2205         (testContextMenuWebExtensionNode):
2206         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2207         (testInspectorDefault):
2208         (testInspectorManualAttachDetach):
2209         (testInspectorCustomContainerDestroyed):
2210         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2211         (testWebViewPrint):
2212         (testPrintOperationPrint):
2213         (testPrintOperationErrors):
2214         * gtk/install-dependencies:
2215         * gtk/jhbuild.modules:
2216         * gtkdoc/generate-gtkdoc:
2217         * wpe/install-dependencies:
2218
2219 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2220
2221         contributors.json not canonicalized since r243297
2222         https://bugs.webkit.org/show_bug.cgi?id=199161
2223
2224         Reviewed by Alexey Proskuryakov.
2225
2226         Canonicalize it using 'validate-committer-lists --canonicalize'
2227
2228         * Scripts/webkitpy/common/config/contributors.json:
2229
2230 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
2231
2232         webkitpy: Build style should be lower-case
2233         https://bugs.webkit.org/show_bug.cgi?id=199158
2234
2235         Reviewed by Aakash Jain.
2236
2237         * Scripts/webkitpy/test/main.py:
2238         (Tester._run_tests): Make all styles lower-case.
2239
2240 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2241
2242         [ews-build] Remove iOS queue from old EWS and dashboard
2243         https://bugs.webkit.org/show_bug.cgi?id=199150
2244
2245         Reviewed by Jonathan Bedard.
2246
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2248         * QueueStatusServer/config/queues.py:
2249
2250 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
2251
2252         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
2253         https://bugs.webkit.org/show_bug.cgi?id=198795
2254
2255         Unreviewed test gardening.
2256
2257         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2258         (TestWebKitAPI::TEST): Disable flaky test.
2259
2260 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2261
2262         [ews-build] Enable iOS-12-Build queue on new EWS
2263         https://bugs.webkit.org/show_bug.cgi?id=199149
2264
2265         Reviewed by Jonathan Bedard.
2266
2267         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
2268         this queue.
2269         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2270         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
2271         will keep the builders to the left and testers to the right.
2272
2273 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2274
2275         [ews-build] Upload test results after running layout-tests
2276         https://bugs.webkit.org/show_bug.cgi?id=199120
2277
2278         Reviewed by Jonathan Bedard.
2279
2280         * BuildSlaveSupport/ews-build/steps.py:
2281         (RunWebKitTests.evaluateCommand):
2282         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2283
2284 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2285
2286         [ews-build] EWS should provide option to download layout test results zip file
2287         https://bugs.webkit.org/show_bug.cgi?id=199121
2288
2289         Reviewed by Jonathan Bedard.
2290
2291         * BuildSlaveSupport/ews-build/steps.py:
2292         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
2293         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
2294
2295 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2296
2297         Add user agent quirk for Google Drive
2298         https://bugs.webkit.org/show_bug.cgi?id=199153
2299
2300         Reviewed by Carlos Garcia Campos.
2301
2302         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2303         (TestWebKitAPI::TEST):
2304
2305 2019-06-22  Zalan Bujtas  <zalan@apple.com>
2306
2307         [LFC] Expand tests coverage (328 new tests -> 2652).
2308
2309         * LayoutReloaded/misc/LFC-passing-tests.txt:
2310
2311 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
2312
2313         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
2314         https://bugs.webkit.org/show_bug.cgi?id=199107
2315         <rdar://problem/43663611>
2316
2317         Reviewed by Chris Fleizach.
2318
2319         iOS implementation for AccessibilityUIElement::hasPopup.
2320         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2321         (WTR::AccessibilityUIElement::hasPopup const):
2322
2323 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
2324
2325         Unreviewed, add myself to CMake watchlist
2326
2327         * Scripts/webkitpy/common/config/watchlist:
2328
2329 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
2330
2331         openDatabase should return an empty object when WebSQL is disabled
2332         https://bugs.webkit.org/show_bug.cgi?id=198805
2333
2334         Reviewed by Geoffrey Garen.
2335
2336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2337         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
2338         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
2339         (TEST):
2340         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
2341
2342 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
2343
2344         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
2345         https://bugs.webkit.org/show_bug.cgi?id=199114
2346         <rdar://problem/51671674>
2347
2348         Reviewed by Youenn Fablet.
2349
2350         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2351         (-[TestSOAuthorizationNavigationDelegate init]):
2352         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2353         (configureSOAuthorizationWebView):
2354         (TestWebKitAPI::TEST):
2355
2356 2019-06-21  Youenn Fablet  <youenn@apple.com>
2357
2358         WebPageProxy should use the right path for sandbox extension
2359         https://bugs.webkit.org/show_bug.cgi?id=198902
2360         <rdar://problem/50772810>
2361
2362         Reviewed by Geoffrey Garen.
2363
2364         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2365         (TEST):
2366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2367
2368 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2369
2370         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
2371         https://bugs.webkit.org/show_bug.cgi?id=199094
2372
2373         Reviewed by Carlos Garcia Campos.
2374
2375         * MiniBrowser/gtk/BrowserTab.c:
2376         (runColorChooserCallback):
2377         (browserTabConstructed):
2378         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2379         (testWebViewSyncRequestOnMaxConns):
2380         (beforeAll):
2381         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2382         (testWebSocketTLSErrors):
2383         (beforeAll):
2384         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2385         (WebKitTestServer::~WebKitTestServer):
2386         (WebKitTestServer::getWebSocketURIForPath const):
2387         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2388         (WTR::AccessibilityUIElement::rowHeaders const):
2389         (WTR::AccessibilityUIElement::columnHeaders const):
2390         (WTR::AccessibilityUIElement::isAttributeSettable):
2391         (WTR::AccessibilityUIElement::x):
2392         (WTR::AccessibilityUIElement::y):
2393         (WTR::AccessibilityUIElement::width):
2394         (WTR::AccessibilityUIElement::height):
2395         (WTR::AccessibilityUIElement::clickPointX):
2396         (WTR::AccessibilityUIElement::clickPointY):
2397         (WTR::AccessibilityUIElement::intValue const):
2398         (WTR::AccessibilityUIElement::minValue):
2399         (WTR::AccessibilityUIElement::maxValue):
2400         (WTR::stringAtOffset):
2401
2402 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
2403
2404         test-webkitpy is broken on macOS Catalina
2405         https://bugs.webkit.org/show_bug.cgi?id=199078
2406
2407         Reviewed by Jonathan Bedard.
2408
2409         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
2410         to the runner.
2411         (main): 
2412         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
2413
2414 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
2415
2416         Change status to "committer" in contributors.json
2417
2418         Unreviewed.
2419
2420         * Scripts/webkitpy/common/config/contributors.json:
2421
2422 2019-06-20  Alex Christensen  <achristensen@webkit.org>
2423
2424         Add unit test for UIContextMenuConfiguration API
2425         https://bugs.webkit.org/show_bug.cgi?id=199043
2426
2427         Reviewed by Wenson Hsieh.
2428
2429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2430         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
2431         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
2432         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
2433         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
2434         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
2435         (TEST):
2436         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
2437         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
2438         (-[TestContextMenuDriver delegate]):
2439         (-[TestContextMenuDriver setDelegate:]):
2440         (-[TestContextMenuDriver view]):
2441         (-[TestContextMenuDriver setView:]):
2442         (-[TestContextMenuDriver allowableMovement]):
2443         (-[TestContextMenuDriver setAllowableMovement:]):
2444         (-[TestContextMenuDriver primaryGestureRecognizer]):
2445         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
2446         (-[TestContextMenuDriver touchDuration]):
2447         (-[TestContextMenuDriver setTouchDuration:]):
2448         (-[TestContextMenuDriver locationInCoordinateSpace:]):
2449         (-[TestContextMenuDriver cancelInteraction]):
2450         (-[TestContextMenuDriver begin:]):
2451         (-[TestContextMenuDriver clickDown]):
2452         (-[TestContextMenuDriver clickUp]):
2453         (-[TestContextMenuDriver end]):
2454         * TestWebKitAPI/ios/UIKitSPI.h:
2455
2456 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2457
2458         [ews-app] Status bubble should not turn orange when any build step is skipped
2459         https://bugs.webkit.org/show_bug.cgi?id=199079
2460
2461         Reviewed by Jonathan Bedard.
2462
2463         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2464
2465 2019-06-20  Alex Christensen  <achristensen@webkit.org>
2466
2467         Fix an internal engineering build after r246605
2468        ​https://bugs.webkit.org/show_bug.cgi?id=197800
2469
2470         * TestWebKitAPI/TCPServer.cpp:
2471
2472 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2473
2474         [ews-build] Triggered builds should use same revision as parent build
2475         https://bugs.webkit.org/show_bug.cgi?id=198289
2476
2477         Reviewed by Jonathan Bedard.
2478
2479         * BuildSlaveSupport/ews-build/steps.py:
2480         (CheckOutSpecificRevision): Build step to checkout specific revision.
2481         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
2482         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
2483         (CheckOutSpecificRevision.start): Run appropriate git command.
2484         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
2485         builds use same revision as parent build.
2486         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2487         * BuildSlaveSupport/ews-build/factories.py:
2488         (Factory.__init__): Added CheckOutSpecificRevision step.
2489
2490 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2491
2492         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
2493         https://bugs.webkit.org/show_bug.cgi?id=199073
2494
2495         Reviewed by Jonathan Bedard.
2496
2497         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
2498
2499 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
2500
2501         [GTK] Enable navigation swipe layout tests
2502         https://bugs.webkit.org/show_bug.cgi?id=198995
2503
2504         Reviewed by Michael Catanzaro.
2505
2506         Add a way for tests to enable and then control swipe gesture on GTK.
2507
2508         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
2509         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
2510         * WebKitTestRunner/PlatformGTK.cmake:
2511         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2512         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
2513         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
2514         (WTR::UIScriptController::beginBackSwipe):
2515         (WTR::UIScriptController::completeBackSwipe):
2516
2517 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
2518
2519         [GTK] HTTP layout tests don't run in flatpak
2520         https://bugs.webkit.org/show_bug.cgi?id=199067
2521
2522         Reviewed by Michael Catanzaro.
2523
2524         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
2525         check that path. Instead, add /app/lib/perl to Apache config directly.
2526
2527         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
2528         /.flatpak-info instead.
2529
2530         * Scripts/webkitpy/port/base.py:
2531         (Port._is_flatpak):
2532         (Port._in_flatpak_sandbox):
2533         * flatpak/flatpakutils.py:
2534         (WebkitFlatpak.run_in_sandbox):
2535         (is_sandboxed):
2536
2537 2019-06-18  Darin Adler  <darin@apple.com>
2538
2539         Tidy up the remaining bits of the AtomicString to AtomString rename
2540         https://bugs.webkit.org/show_bug.cgi?id=198990
2541
2542         Reviewed by Michael Catanzaro.
2543
2544         * Scripts/do-webcore-rename: Removed already-done renames.
2545         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
2546
2547 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2548
2549         [GTK] Remove support for GTK2 plugins
2550         https://bugs.webkit.org/show_bug.cgi?id=199065
2551
2552         Reviewed by Sergio Villar Senin.
2553
2554         * EWSTools/ubuntu-ews-packages:
2555         * TestWebKitAPI/PlatformGTK.cmake:
2556         * WebKitTestRunner/PlatformGTK.cmake:
2557         * flatpak/org.webkit.GTK.yaml:
2558         * gtk/install-dependencies:
2559
2560 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
2561
2562         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
2563         https://bugs.webkit.org/show_bug.cgi?id=199053
2564
2565         Reviewed by Saam Barati.
2566
2567         Added a test stressing IsoHeap with multiple threads.
2568
2569         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2570         (assertHasObjects):
2571         (assertHasOnlyObjects):
2572         (assertClean):
2573         (TEST):
2574
2575 2019-06-19  Zalan Bujtas  <zalan@apple.com>
2576
2577         [LFC] Expand tests coverage (1126 new tests -> 2324).
2578
2579         * LayoutReloaded/misc/LFC-passing-tests.txt:
2580
2581 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2582
2583         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
2584         https://bugs.webkit.org/show_bug.cgi?id=198957
2585
2586         Reviewed by Alex Christensen.
2587
2588         * TestWebKitAPI/CMakeLists.txt:
2589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2590         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
2591
2592 2019-06-19  Keith Rollin  <krollin@apple.com>
2593
2594         Relocate some test tools in non-mac builds
2595         https://bugs.webkit.org/show_bug.cgi?id=198984
2596         <rdar://problem/51873261>
2597
2598         Reviewed by Andy Estes.
2599
2600         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
2601         TestNetscapePlugin get created in
2602         WebKit.framework/Versions/A/Resources on non-mac builds. This is
2603         incorrect, as those bundles are shallow bundles that don't use the
2604         Versions hierarchy. Instead, store these files directly in
2605         WebKit.framework.
2606
2607         Note that getting rid of just the "Versions/A" path components and
2608         putting the files in WebKit.framework/Resources doesn't work as
2609         `codesign` treats the result as an invalid layout.
2610
2611         The work in this patch involves changing the definition of the custom
2612         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
2613         variable INSTALL_PATH is defined in terms of this variable. In order
2614         to increase visiblity into this relationship, move both of these
2615         variables into .xcconfig files if they weren't already. This
2616         refactoring was done in a way to be the least disruptive and most
2617         compatible with the previous definitions, even at the cost of being
2618         repetitive.
2619
2620         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2621         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2622         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2623         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2624         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2625         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2626
2627 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2628
2629         [ews-build] Patch link should open the pretty patch
2630         https://bugs.webkit.org/show_bug.cgi?id=199031
2631
2632         Reviewed by Jonathan Bedard.
2633
2634         * BuildSlaveSupport/ews-build/steps.py:
2635         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
2636
2637 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2638
2639         [ews-build] Add step to analyze Compile WebKit failures
2640         https://bugs.webkit.org/show_bug.cgi?id=199025
2641
2642         Reviewed by Jonathan Bedard.
2643
2644         * BuildSlaveSupport/ews-build/steps.py:
2645         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
2646         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
2647         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
2648         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
2649         this step is run only when compile-webkit failed.
2650
2651 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2652
2653         [ews-build] Send email notifications for failures
2654         https://bugs.webkit.org/show_bug.cgi?id=198919
2655
2656         Reviewed by Jonathan Bedard.
2657
2658         * BuildSlaveSupport/ews-build/master.cfg:
2659
2660 2019-06-19  Alex Christensen  <achristensen@webkit.org>
2661
2662         Add a unit test for client certificate authentication
2663         https://bugs.webkit.org/show_bug.cgi?id=197800
2664
2665         Reviewed by Youenn Fablet.
2666
2667         Make better abstractions for reading and writing from/to TCPServer.
2668         Add a unit test that causes a client certificate authentication challenge to happen.
2669
2670         * TestWebKitAPI/TCPServer.cpp:
2671         (TestWebKitAPI::TCPServer::TCPServer):
2672         (TestWebKitAPI::TCPServer::read):
2673         (TestWebKitAPI::TCPServer::write):
2674         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
2675         (TestWebKitAPI::TCPServer::respondWithOK):
2676         * TestWebKitAPI/TCPServer.h:
2677         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2678         (credentialWithIdentity):
2679         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2680         (TEST):
2681         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
2682         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2683         (-[ClientCertificateDelegate challengeCount]):
2684         (TestWebKitAPI::TEST):
2685         (respondWithChallengeThenOK): Deleted.
2686         (credentialWithIdentityAndKeychainPath): Deleted.
2687         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2688         (TEST):
2689         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2690         (TestWebKitAPI::TEST):
2691         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2692         (TEST):
2693         (readRequest): Deleted.
2694         (writeResponse): Deleted.
2695         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2696         (TestWebKitAPI::TEST):
2697         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
2698
2699 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2700
2701         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
2702
2703         System headers are being included without SYSTEM again here.
2704
2705         * TestWebKitAPI/PlatformGTK.cmake:
2706
2707 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
2708
2709         [JSC] JSLock should be WebThread aware
2710         https://bugs.webkit.org/show_bug.cgi?id=198911
2711
2712         Reviewed by Geoffrey Garen.
2713
2714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2715         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
2716         (TestWebKitAPI::TEST):
2717
2718 2019-06-18  Keith Miller  <keith_miller@apple.com>
2719
2720         webkit-patch should allow for a bugzilla url not just bugzilla id
2721         https://bugs.webkit.org/show_bug.cgi?id=198972
2722
2723         Reviewed by Dewei Zhu.
2724
2725         When prompting for a bugzilla id or a new title we should also
2726         allow for a bugzilla url.
2727
2728         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
2729         (PromptForBugOrTitle.run):
2730
2731 2019-06-18  David Quesada  <david_quesada@apple.com>
2732
2733         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
2734         https://bugs.webkit.org/show_bug.cgi?id=198954
2735         rdar://problem/51711556
2736
2737         Reviewed by Alex Christensen.
2738
2739         For these tests, kill the web process after the download starts. This makes the deallocation
2740         of the download-originating web views, which these tests depend on, more reliable.
2741
2742         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2743         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2744         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2745
2746 2019-06-18  Dan Bernstein  <mitz@apple.com>
2747
2748         Revert workaround for bug 198904 from run-webkit-archive
2749         https://bugs.webkit.org/show_bug.cgi?id=198931
2750
2751         Reviewed by Alexey Proskuryakov.
2752
2753         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
2754         pick up the built frameworks.
2755
2756         * WebKitArchiveSupport/run-webkit-archive:
2757         (set_dyld_framework_path):
2758
2759 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
2760
2761         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2762         https://bugs.webkit.org/show_bug.cgi?id=198854
2763         <rdar://problem/51386058>
2764
2765         Reviewed by Geoffrey Garen.
2766
2767         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2768         (TestWebKitAPI::TEST):
2769
2770 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
2771
2772         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
2773         https://bugs.webkit.org/show_bug.cgi?id=198831
2774
2775         Reviewed by Žan Doberšek.
2776
2777         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
2778         * wpe/jhbuild.modules: Ditto.
2779         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
2780         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
2781
2782 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
2783
2784         Move SOAuthorization from WebKitAdditions to WebKit
2785         https://bugs.webkit.org/show_bug.cgi?id=198874
2786         <rdar://problem/47573431>
2787
2788         Reviewed by Brent Fulgham.
2789
2790         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
2791
2792         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2794         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
2795         (-[TestSOAuthorizationNavigationDelegate init]):
2796         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
2797         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2798         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2799         (-[TestSOAuthorizationViewController viewDidAppear]):
2800         (-[TestSOAuthorizationViewController viewDidDisappear]):
2801         (overrideCanPerformAuthorizationWithURL):
2802         (overrideSetDelegate):
2803         (overrideBeginAuthorizationWithURL):
2804         (overrideCancelAuthorization):
2805         (overrideAddObserverForName):
2806         (overrideIsURLFromAppleOwnedDomain):
2807         (resetState):
2808         (configureSOAuthorizationWebView):
2809         (generateHtml):
2810         (checkAuthorizationOptions):
2811         (TestWebKitAPI::TEST):
2812
2813 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
2814
2815         Ensure ITP state is relayed to Network Process on restart
2816         https://bugs.webkit.org/show_bug.cgi?id=198797
2817         <rdar://problem/51646944>
2818
2819         Reviewed by Youenn Fablet.
2820
2821         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2822         (cleanupITPDatabase): Added.
2823         (TEST:EnableDisableITP): Update to use cleanup method.
2824         (TEST:NetworkProcessRestart): Added.
2825
2826 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
2827
2828         New EWS can't process patches larger than 640kb
2829         https://bugs.webkit.org/show_bug.cgi?id=198851
2830
2831         Reviewed by Jonathan Bedard.
2832
2833         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
2834
2835 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
2836
2837         webkitpy: Add macOS Catalina, iOS 13
2838         https://bugs.webkit.org/show_bug.cgi?id=198492
2839
2840         Reviewed by Alexey Proskuryakov.
2841
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2850         * BuildSlaveSupport/ews-build/steps.py:
2851         * Scripts/webkitpy/common/version_name_map.py:
2852         * Scripts/webkitpy/common/version_name_map_unittest.py:
2853         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2854         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2855
2856 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2857
2858         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
2859
2860         * gtk/jhbuild.modules:
2861         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
2862         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
2863
2864 2019-06-16  Zalan Bujtas  <zalan@apple.com>
2865
2866         [LFC] Expand tests coverage (325 new tests -> 1198).
2867
2868         * LayoutReloaded/misc/LFC-passing-tests.txt:
2869
2870 2019-06-16  Darin Adler  <darin@apple.com>
2871
2872         Rename AtomicString to AtomString
2873         https://bugs.webkit.org/show_bug.cgi?id=195276
2874
2875         Reviewed by Michael Catanzaro.
2876
2877         * many files: Let do-webcore-rename do the renaming.
2878
2879         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
2880         that mention "atomic string" and changed them to instead say "atom string".
2881
2882 2019-06-16  Zalan Bujtas  <zalan@apple.com>
2883
2884         [LFC] Unreviewed test gardening.
2885
2886         Unsupported alignments.
2887
2888         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
2889         fast/borders/empty-outline-border-assert.html -vertical-align: super
2890         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
2891
2892         * LayoutReloaded/misc/LFC-passing-tests.txt:
2893
2894 2019-06-15  Youenn Fablet  <youenn@apple.com>
2895
2896         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
2897         https://bugs.webkit.org/show_bug.cgi?id=198780
2898
2899         Reviewed by Jonathan Bedard.
2900
2901         * Scripts/webkitpy/w3c/test_importer.py:
2902         (TestImporter._webkit_test_runner_options):
2903         In case the test file cannot be read as text, consider that there is no WTR option.
2904
2905 2019-06-14  Youenn Fablet  <youenn@apple.com>
2906
2907         WebResourceLoadStatisticsStore should not use its network session if invalidated
2908         https://bugs.webkit.org/show_bug.cgi?id=198814
2909
2910         Reviewed by Geoffrey Garen.
2911
2912         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2913         (TEST):
2914
2915 2019-06-14  Youenn Fablet  <youenn@apple.com>
2916
2917         import-w3c-tests should respect WEBKIT_OUTPUTDIR
2918         https://bugs.webkit.org/show_bug.cgi?id=198682
2919         <rdar://problem/51536931>
2920
2921         Reviewed by Jonathan Bedard.
2922
2923         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
2924         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
2925
2926         * Scripts/webkitpy/common/webkit_finder.py:
2927         (WebKitFinder.path_from_webkit_outputdir):
2928         * Scripts/webkitpy/w3c/common.py:
2929         (WPTPaths):
2930         (WPTPaths.checkout_directory):
2931         (WPTPaths.wpt_checkout_path):
2932         * Scripts/webkitpy/w3c/test_importer.py:
2933         (TestImporter.__init__):
2934         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2935         (test_checkout_directory):
2936
2937 2019-06-13  Antoine Quint  <graouts@apple.com>
2938
2939         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
2940         https://bugs.webkit.org/show_bug.cgi?id=198800
2941         <rdar://problem/51679634>
2942
2943         Reviewed by Tim Horton.
2944
2945         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
2946         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
2947
2948         * DumpRenderTree/mac/EventSendingController.mm:
2949         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
2950         (-[EventSendingController mouseDown:withModifiers:]):
2951         (-[EventSendingController mouseUp:withModifiers:]):
2952         (-[EventSendingController mouseMoveToX:Y:]):
2953
2954 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2955
2956         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
2957         https://bugs.webkit.org/show_bug.cgi?id=198820
2958
2959         Reviewed by Ross Kirsling.
2960
2961         WebView window paints nothing because it is moved out of the
2962         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
2963         as DumpRenderTree does.
2964
2965         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2966         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
2967
2968 2019-06-13  Tim Horton  <timothy_horton@apple.com>
2969
2970         Make it possible for validate-committer-lists to dump a mailmap file
2971         https://bugs.webkit.org/show_bug.cgi?id=198517
2972
2973         Reviewed by Simon Fraser.
2974
2975         Mailmaps wildly improve the output of various Git tools, including
2976         `git shortlog -sne`, mapping committers to our canonical name/email pair.
2977
2978         * Scripts/validate-committer-lists:
2979         (CommitterListFromGit):
2980         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
2981         Add some missing legacy username mappings.
2982
2983         (dump_mailmap):
2984         (dump_mailmap.format_email):
2985         (dump_mailmap.format_email_with_gitsvn_uuid):
2986         (dump_mailmap.map_emails_to_legacy_username):
2987         (main):
2988         Add `validate-committer-lists --dump-mailmap`, which generates
2989         one given committers.json and the existing mapping of legacy username
2990         to email addresses that exists in validate-committer-lists.
2991
2992 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
2993
2994         Replace double-quotes with single quotes in loadConfig.py
2995         https://bugs.webkit.org/show_bug.cgi?id=198792
2996
2997         Reviewed by Jonathan Bedard.
2998
2999         * BuildSlaveSupport/ews-build/loadConfig.py:
3000         * BuildSlaveSupport/ews-build/steps_unittest.py:
3001
3002 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
3003
3004         Add mechanism and test case to check if ITP is active
3005         https://bugs.webkit.org/show_bug.cgi?id=198694
3006         <rdar://problem/51557704>
3007
3008         Reviewed by Youenn Fablet.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3011         (TEST):
3012
3013 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3014
3015         [WPE][GTK] Deprecate WebSQL APIs
3016         https://bugs.webkit.org/show_bug.cgi?id=195011
3017
3018         Reviewed by Carlos Garcia Campos.
3019
3020         * MiniBrowser/gtk/main.c:
3021         (gotWebsiteDataCallback):
3022         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3023         (testWebsiteDataConfiguration):
3024         (testWebsiteDataEphemeral):
3025         (testWebsiteDataDatabases):
3026
3027 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3028
3029         [WPE][GTK] Enable hyperlink auditing
3030         https://bugs.webkit.org/show_bug.cgi?id=197845
3031
3032         Reviewed by Carlos Garcia Campos.
3033
3034         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3035         (testWebKitSettings):
3036
3037 2019-06-11  Keith Rollin  <krollin@apple.com>
3038
3039         Open up xcfilelist processing to more platforms
3040         https://bugs.webkit.org/show_bug.cgi?id=198675
3041         <rdar://problem/51533238>
3042
3043         Reviewed by Jonathan Bedard.
3044
3045         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
3046         platforms on which to perform xcfilelist generation/updating.
3047
3048         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3049         (JavaScriptCoreGenerator):
3050         (WebCoreGenerator):
3051         (WebKitGenerator):
3052
3053 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
3054
3055         webkitpy: Fix device ASan reporting, add testing for report configurations
3056         https://bugs.webkit.org/show_bug.cgi?id=198756
3057
3058         Reviewed by Aakash Jain.
3059
3060         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
3061         configuration thoroughly in webkitpy.
3062
3063         * Scripts/webkitpy/port/config.py:
3064         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
3065         * Scripts/webkitpy/port/device_port.py:
3066         (DevicePort.configuration_for_upload): Add ASan as style.
3067         * Scripts/webkitpy/port/ios_device_unittest.py:
3068         (IOSDeviceTest):
3069         (IOSDeviceTest.test_default_upload_configuration):
3070         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3071         (IOSSimulatorTest.test_default_upload_configuration):
3072         * Scripts/webkitpy/port/mock_drt_unittest.py:
3073         (MockDRTPortTest.test_asan_upload_configuration):
3074         * Scripts/webkitpy/port/port_testcase.py:
3075         (test_default_upload_configuration):
3076         (test_debug_upload_configuration):
3077         (test_asan_upload_configuration):
3078         (test_guard_malloc_configuration):
3079         * Scripts/webkitpy/port/watch_simulator_unittest.py:
3080         (WatchSimulatorTest):
3081         (WatchSimulatorTest.test_default_upload_configuration):
3082
3083 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3084
3085         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
3086         https://bugs.webkit.org/show_bug.cgi?id=198749
3087
3088         Reviewed by Carlos Garcia Campos.
3089
3090         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3091         (TestWebKitAPI::TEST):
3092
3093 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3094
3095         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
3096         https://bugs.webkit.org/show_bug.cgi?id=198735
3097         <rdar://problem/51557159>
3098
3099         Reviewed by Megan Gardner.
3100
3101         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
3102         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
3103
3104         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3105         (TestWebKitAPI::TEST):
3106
3107 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
3108
3109         Unreviewed, add myself to the JavaScriptCore watchlist.
3110
3111         * Scripts/webkitpy/common/config/watchlist:
3112
3113 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
3114
3115         Unreviewed, change my status to be a WebKit reviewer
3116
3117         * Scripts/webkitpy/common/config/contributors.json:
3118
3119 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3120
3121         [WPE] Use new exported image API from fdo backend
3122         https://bugs.webkit.org/show_bug.cgi?id=198558
3123
3124         Reviewed by Philippe Normand.
3125
3126         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
3127         WPEToolingBackends that already depends on fdo backend and libxkb
3128         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
3129         * wpe/backends/HeadlessViewBackend.cpp:
3130         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
3131         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
3132         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
3133         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
3134         * wpe/backends/HeadlessViewBackend.h:
3135         * wpe/backends/ViewBackend.cpp:
3136         (WPEToolingBackends::ViewBackend::initialize):
3137         * wpe/backends/ViewBackend.h:
3138         * wpe/backends/WindowViewBackend.cpp:
3139         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3140         * wpe/backends/WindowViewBackend.h:
3141
3142 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
3143
3144         Extend run-benchmark to allow diagnosing before closing browser on test failure.
3145         https://bugs.webkit.org/show_bug.cgi?id=198729
3146
3147         Reviewed by Ryosuke Niwa.
3148
3149         Add '--diagnose-directory' option to store diagnose information when test failed.
3150
3151         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3152         (BenchmarkRunner.__init__):
3153         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3154         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
3155         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
3156         (parse_args):
3157         (run_benchmark_plan):
3158         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
3159         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
3160         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3161         (WebServerBenchmarkRunner.__init__):
3162         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
3163
3164 2019-06-10  Sam Weinig  <weinig@apple.com>
3165
3166         Remove Dashboard support
3167         https://bugs.webkit.org/show_bug.cgi?id=198615
3168
3169         Reviewed by Ryosuke Niwa.
3170
3171         * DumpRenderTree/TestRunner.cpp:
3172         (TestRunner::staticFunctions):
3173         (setUseDashboardCompatibilityModeCallback): Deleted.
3174         * DumpRenderTree/TestRunner.h:
3175         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3176         * DumpRenderTree/mac/DumpRenderTree.mm:
3177         (resetWebViewToConsistentStateBeforeTesting):
3178         * DumpRenderTree/mac/TestRunnerMac.mm:
3179         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
3180         * ImageDiff/cg/Configurations/Base.xcconfig:
3181         * Scripts/webkitperl/FeatureList.pm:
3182         * TestWebKitAPI/Configurations/Base.xcconfig:
3183         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3185         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
3186         * WebKitTestRunner/Configurations/Base.xcconfig:
3187         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3188         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3189         (WTR::InjectedBundle::beginTesting):
3190         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3191         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
3192         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3193
3194 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
3195
3196         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
3197         https://bugs.webkit.org/show_bug.cgi?id=198616
3198         rdar://problem/36386573
3199
3200         Reviewed by David Kilzer.
3201
3202         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
3203
3204         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3205         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3206         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
3207         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
3208         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
3209         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
3210         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
3211         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3212         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3213         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3214
3215 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3216
3217         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
3218         https://bugs.webkit.org/show_bug.cgi?id=198699
3219         <rdar://problem/50501718>
3220
3221         Reviewed by Simon Fraser.
3222
3223         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
3224         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
3225         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
3226         viewport parameters are used.
3227
3228         * WebKitTestRunner/ios/TestControllerIOS.mm:
3229         (WTR::TestController::platformResetPreferencesToConsistentValues):
3230         (WTR::TestController::platformConfigureViewForTest):
3231
3232 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
3233
3234         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
3235         https://bugs.webkit.org/show_bug.cgi?id=198023
3236
3237         Reviewed by Saam Barati.
3238
3239         * Scripts/run-jsc-stress-tests:
3240
3241 2019-06-10  Timothy Hatcher  <timothy@apple.com>
3242
3243         Integrate dark mode support for iOS.
3244         https://bugs.webkit.org/show_bug.cgi?id=198687
3245         rdar://problem/51545643
3246
3247         Reviewed by Tim Horton.
3248
3249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3250
3251 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
3252
3253         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
3254         https://bugs.webkit.org/show_bug.cgi?id=198723
3255
3256         Reviewed by Aakash Jain.
3257
3258         * Scripts/webkitpy/xcode/simulated_device.py:
3259         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
3260
3261 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
3262
3263         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
3264         https://bugs.webkit.org/show_bug.cgi?id=198635
3265         <rdar://problem/46010232>
3266
3267         Reviewed by Ryosuke Niwa.
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3270         (areCookiesEqual):
3271         (TEST):
3272
3273 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
3274
3275         [JHBuild] Bump shared-mime-info to version ≥ 1.6
3276         https://bugs.webkit.org/show_bug.cgi?id=198714
3277
3278         Reviewed by Carlos Garcia Campos.
3279
3280         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
3281         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
3282         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
3283
3284 2019-06-10  Philippe Normand  <pnormand@igalia.com>
3285
3286         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
3287         https://bugs.webkit.org/show_bug.cgi?id=198713
3288
3289         Reviewed by Carlos Garcia Campos.
3290
3291         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
3292         patches currently used in JHBuild.
3293
3294 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
3295
3296         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
3297         https://bugs.webkit.org/show_bug.cgi?id=198711
3298
3299         Reviewed by Philippe Normand.
3300
3301         * flatpak/org.webkit.GTK.yaml: Also include modules from
3302         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
3303
3304 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
3305
3306         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
3307         avoids double-free condition that's causing bots to exit early.
3308
3309         * gtk/jhbuild.modules:
3310         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
3311         * wpe/jhbuild.modules:
3312         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
3313
3314 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3315
3316         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
3317         https://bugs.webkit.org/show_bug.cgi?id=198655
3318
3319         Reviewed by Ross Kirsling.
3320
3321         MediaCapabilities is enabled by default for WK2, but WinCairo
3322         doesn't implemented yet. Disable it in MiniBrowser.
3323
3324         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3325         (WebKitBrowserWindow::create):
3326
3327 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3328
3329         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
3330         https://bugs.webkit.org/show_bug.cgi?id=198693
3331         <rdar://problem/51555371>
3332
3333         Reviewed by Tim Horton.
3334
3335         Augment an existing API test to exercise three additional scenarios:
3336             -   The web view configuration's application name is never set; the default should not include
3337                 "Mobile/15E148" in desktop mode.
3338             -   The application name is explicitly set to nil; the default application name should still not include
3339                 "Mobile/15E148".
3340             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
3341                 this when generating the user agent, even in desktop mode.
3342
3343         * TestWebKitAPI/ios/PreferredContentMode.mm:
3344         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
3345         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
3346         (TestWebKitAPI::TEST):
3347
3348 2019-06-08  Zalan Bujtas  <zalan@apple.com>
3349
3350         [LFC] Unreviewed test gardening.
3351
3352         Remove rtl tests. They were mistakenly marked as pass.
3353
3354         * LayoutReloaded/misc/LFC-passing-tests.txt:
3355
3356 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3357
3358         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
3359         https://bugs.webkit.org/show_bug.cgi?id=198664
3360
3361         Reviewed by Simon Fraser.
3362
3363         Delete repeated entries which were submitted by mistake.
3364
3365         * Tracing/SystemTracePoints.plist:
3366
3367 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3368
3369         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
3370         https://bugs.webkit.org/show_bug.cgi?id=198631
3371         <rdar://problem/51505431>
3372
3373         Reviewed by Tim Horton.
3374
3375         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
3376
3377         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3378         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
3379         (-[CustomInputWebView inputView]):
3380         (-[CustomInputWebView inputAccessoryView]):
3381         (TestWebKitAPI::TEST):
3382
3383 2019-06-07  Daniel Bates  <dabates@apple.com>
3384
3385         [lldb-webkit] Pretty-print all kinds of Documents
3386         https://bugs.webkit.org/show_bug.cgi?id=198620
3387
3388         Reviewed by Simon Fraser.
3389
3390         Register formatters for all classes derived from WebCore::Document so we get nice summaries
3391         without having to drill down in Xcode- or casting- to the base class, Document.
3392
3393         Older LLDB versions use to do this automatically, but this functionality was removed in newer
3394         versions:
3395             [[
3396                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
3397                 chains, but also through inheritance chains. This feature has been removed since it
3398                 significantly degrades performance. You need to set up your formatters for every type in
3399                 inheritance chains to which you want the formatter to apply.
3400             ]]
3401             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
3402
3403         * lldb/lldb_webkit.py:
3404         (__lldb_init_module):
3405
3406 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
3407
3408         webkitpy: Support reporting results for uncommon test configurations
3409         https://bugs.webkit.org/show_bug.cgi?id=198662
3410         <rdar://problem/51524128>
3411
3412         Reviewed by Aakash Jain.
3413
3414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3415         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
3416         * Scripts/webkitpy/port/base.py:
3417         (Port.configuration_for_upload): Set flavor based on options.
3418         * Scripts/webkitpy/results/options.py:
3419         (upload_options): Add result-report-flavor option.
3420         * Scripts/webkitpy/test/main.py:
3421         (Tester._run_tests): Set flavor based on options.
3422
3423 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3424
3425         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
3426         https://bugs.webkit.org/show_bug.cgi?id=198641
3427         <rdar://problem/51266310>
3428
3429         Reviewed by Tim Horton.
3430
3431         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
3432         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
3433         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
3434         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
3435         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
3436         reproduces on iOS simulator.
3437
3438         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
3439         representation is actually ignored by most clients anyways (including WebKit), in favor of using
3440         "com.apple.flat-rtfd".
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3443         (TestWebKitAPI::TEST):
3444         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3445         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
3446         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3447
3448 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3449
3450         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
3451         https://bugs.webkit.org/show_bug.cgi?id=198607
3452
3453         Reviewed by Michael Catanzaro.
3454
3455         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
3456         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
3457         determine the type of the tests.
3458
3459         * Scripts/run-gtk-tests:
3460         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
3461         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
3462         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
3463         (GtkTestRunner.is_google_test): Ditto.
3464         * Scripts/run-wpe-tests:
3465         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
3466         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
3467         (WPETestRunner.is_google_test): Ditto.
3468         * glib/api_test_runner.py:
3469         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
3470         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
3471
3472 2019-06-06  Keith Rollin  <krollin@apple.com>
3473
3474         Remove SSL-based tests from TestWebKitAPI on some configurations
3475         https://bugs.webkit.org/show_bug.cgi?id=198551
3476         <rdar://problem/51424996>
3477
3478         Reviewed by Jonathan Bedard.
3479
3480         Not all platforms have SSL handy, so don't include SSL-based tests on
3481         those platforms.
3482
3483         * TestWebKitAPI/TCPServer.cpp:
3484         * TestWebKitAPI/TCPServer.h:
3485         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3486         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
3487         * TestWebKitAPI/config.h:
3488
3489 2019-06-06  Daniel Bates  <dabates@apple.com>
3490
3491         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
3492         non-default port number
3493         https://bugs.webkit.org/show_bug.cgi?id=198618
3494
3495         Reviewed by Brent Fulgham.
3496
3497         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
3498         a string before we concatenate it with another string when building the string representation
3499         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
3500         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
3501
3502         * lldb/lldb_webkit.py:
3503         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
3504
3505 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
3506
3507         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
3508         https://bugs.webkit.org/show_bug.cgi?id=198613
3509
3510         Reviewed by Alexey Proskuryakov.
3511
3512         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
3513
3514 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
3515
3516         webkitpluginhost: Support ASan as a style
3517         https://bugs.webkit.org/show_bug.cgi?id=198586
3518         <rdar://problem/51459088>
3519
3520         Reviewed by Alexey Proskuryakov.
3521
3522         * Scripts/webkitpy/port/base.py:
3523         (Port.configuration_for_upload): Add ASan as a style.
3524         * Scripts/webkitpy/port/config.py:
3525         (Config._read_configuration):
3526         (Config):
3527         (Config.asan): Add property to check if the ASan configuration is active.
3528         * Scripts/webkitpy/port/config_unittest.py:
3529         (ConfigTest.test_default_configuration__scripterror):
3530         (ConfigTest):
3531         (ConfigTest.test_asan):
3532         * Scripts/webkitpy/test/main.py:
3533         (Tester._run_tests): Add Asan as a style.
3534
3535 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
3536
3537         block-spammers tool doesn't block e-mail
3538         https://bugs.webkit.org/show_bug.cgi?id=198570
3539
3540         Reviewed by Jonathan Bedard.
3541
3542         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
3543         recognize "false" here. Also, request body is unnecessary.
3544
3545 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3546
3547         [GTK][WPE] Enable PSON
3548         https://bugs.webkit.org/show_bug.cgi?id=194979
3549
3550         Reviewed by Žan Doberšek.
3551
3552         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
3553
3554         * gtk/jhbuild.modules:
3555         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
3556         * wpe/jhbuild.modules:
3557         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
3558
3559 2019-06-05  Andy Estes  <aestes@apple.com>
3560
3561         [macOS] Stop calling -[NSDraggingItem setItem:]
3562         https://bugs.webkit.org/show_bug.cgi?id=198588
3563         <rdar://problem/48297453>
3564
3565         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
3566
3567         Reviewed by Wenson Hsieh.
3568
3569         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
3570         TestRunnerShared group.
3571
3572         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3573         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3574         Changed to call -[NSDraggingItem _initWithItem:] when available.
3575
3576         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
3577         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
3578         declarations here from DumpRenderTree.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         Added TestRunnerShared/spi/AppKitTestSPI.h.
3582
3583         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3584         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3585         Changed to call -[NSDraggingItem _initWithItem:] when available.
3586
3587 2019-06-05  Jer Noble  <jer.noble@apple.com>
3588
3589         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
3590         https://bugs.webkit.org/show_bug.cgi?id=198585
3591
3592         Reviewed by Chris Dumez.
3593
3594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3596         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
3597         (TEST):
3598         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
3599
3600 2019-06-05  Alex Christensen  <achristensen@webkit.org>
3601
3602         Re-enable safe browsing in WKWebView
3603         https://bugs.webkit.org/show_bug.cgi?id=196161
3604         <rdar://problem/49171413>
3605
3606         Reviewed by Ryosuke Niwa.
3607
3608         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3609         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3610         (TEST):
3611         (safeBrowsingView):
3612
3613 == Rolled over to ChangeLog-2019-06-05 ==