[JHBuild] Doesn't check sha256 sums
[WebKit-https.git] / Tools / ChangeLog
1 2018-09-17  Philippe Normand  <pnormand@igalia.com>
2
3         [JHBuild] Doesn't check sha256 sums
4         https://bugs.webkit.org/show_bug.cgi?id=189646
5
6         Reviewed by Michael Catanzaro.
7
8         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
9
10 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
11
12         Move IndexedDB to Network Process
13         https://bugs.webkit.org/show_bug.cgi?id=189415
14         <rdar://problem/44396973>
15
16         Reviewed by Chris Dumez.
17
18         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
19         (TEST):
20         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
21         (TEST):
22         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
23         (TEST):
24         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
25         (TEST):
26         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
27         (TEST):
28
29 2018-09-08  Darin Adler  <darin@apple.com>
30
31         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
32         https://bugs.webkit.org/show_bug.cgi?id=189455
33
34         Reviewed by Keith Miller.
35
36         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
37         testing and even for macOS vs. iOS vs. Windows platform-specific code.
38         For now, this patch just makes corresponding changes to the copied code.
39         Later we might get better results by merging more code instead of having
40         all these separate copies.
41
42         * DumpRenderTree/AccessibilityController.cpp:
43         (AccessibilityController::makeWindowObject): Use the adopt function
44         instead of the special Adopt constructor of JSRetainPtr.
45
46         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
47
48         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
49         (allAttributesCallback): Don't adopt at this level; changed the
50         underlying function to return a JSRetainPtr so the adopt is right next
51         to the call to the create or copy function.
52         (attributesOfLinkedUIElementsCallback): Ditto.
53         (attributesOfDocumentLinksCallback): Ditto.
54         (attributesOfChildrenCallback): Ditto.
55         (parameterizedAttributeNamesCallback): Ditto.
56         (attributesOfColumnHeadersCallback): Ditto.
57         (attributesOfRowHeadersCallback): Ditto.
58         (attributesOfColumnsCallback): Ditto.
59         (attributesOfRowsCallback): Ditto.
60         (attributesOfVisibleCellsCallback): Ditto.
61         (attributesOfHeaderCallback): Ditto.
62         (rowIndexRangeCallback): Ditto.
63         (columnIndexRangeCallback): Ditto.
64         (rangeForLineCallback): Ditto.
65         (boundsForRangeCallback): Ditto.
66         (rangeForPositionCallback): Ditto.
67         (stringForRangeCallback): Ditto.
68         (attributedStringForRangeCallback): Ditto.
69         (uiElementCountForSearchPredicateCallback): Use the free adopt
70         function instead of the adopt member function.
71         (uiElementForSearchPredicateCallback): Ditto.
72         (selectTextWithCriteriaCallback): Don't adopt at this level.
73         (attributedStringForElementCallback): Ditto.
74         (setValueCallback): Use free adopt.
75         (stringAttributeValueCallback): Don't adopt at this level.
76         (uiElementArrayAttributeValueCallback): Ditto.
77         (uiElementAttributeValueCallback): Ditto.
78         (stringForTextMarkerRangeCallback): Ditto.
79         (attributedStringForTextMarkerRangeCallback): Ditto.
80         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
81         (getARIADropEffectsCallback): Ditto.
82         (getClassListCallback): Ditto.
83         (getRoleCallback): Ditto.
84         (getSubroleCallback): Ditto.
85         (getRoleDescriptionCallback): Ditto.
86         (getComputedRoleStringCallback): Ditto.
87         (getTitleCallback): Ditto.
88         (getDescriptionCallback): Ditto.
89         (getStringValueCallback): Ditto.
90         (getLanguageCallback): Ditto.
91         (getHelpTextCallback): Ditto.
92         (getOrientationCallback): Ditto.
93         (getPathDescriptionCallback): Ditto.
94         (getSelectedTextRangeCallback): Ditto.
95         (speakAsCallback): Ditto.
96         (getValueDescriptionCallback): Ditto.
97         (getAccessibilityValueCallback): Ditto.
98         (getDocumentEncodingCallback): Ditto.
99         (getDocumentURICallback): Ditto.
100         (getURLCallback): Ditto.
101         (characterAtOffsetCallback): Ditto.
102         (wordAtOffsetCallback): Ditto.
103         (lineAtOffsetCallback): Ditto.
104         (sentenceAtOffsetCallback): Ditto.
105         (stringForSelectionCallback): Ditto.
106         (getIdentifierCallback): Ditto.
107         (getTraitsCallback): Ditto.
108         (supportedActionsCallback): Ditto.
109         (mathPostscriptsDescriptionCallback): Ditto.
110         (mathPrescriptsDescriptionCallback): Ditto.
111         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
112         (AccessibilityUIElement::rangeForPosition): Ditto.
113         (AccessibilityUIElement::speakAs): Ditto.
114         (AccessibilityUIElement::pathDescription const): Ditto.
115         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
116         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
117         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
118
119         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
120         raw pointers for the results of the functions that create strings.
121         The old way was difficult to get right; the functions didn't even follow
122         the create/copy naming rule.
123
124         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
125         (_platformTypeConstructor): Use the adopt function instead of the
126         JSRetainPtr adopt constructor. Also nullptr instead of 0.
127
128         * DumpRenderTree/GCController.cpp:
129         (GCController::makeWindowObject): Use adopt function instead of constructor.
130
131         * DumpRenderTree/TestRunner.cpp:
132         (pathToLocalResourceCallback): Use adopt function instead of constructor.
133         (addDisallowedURLCallback): Ditto.
134         (addURLToRedirectCallback): Ditto.
135         (clearApplicationCacheForOriginCallback): Ditto.
136         (applicationCacheDiskUsageForOriginCallback): Ditto.
137         (decodeHostNameCallback): Don't adopt at this level.
138         (encodeHostNameCallback): Ditto.
139         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
140         (findStringCallback): Use adopt function instead of constructor.
141         (isCommandEnabledCallback): Ditto.
142         (overridePreferenceCallback): Ditto.
143         (queueLoadCallback): Ditto.
144         (queueLoadHTMLStringCallback): Ditto.
145         (queueLoadingScriptCallback): Ditto.
146         (queueNonLoadingScriptCallback): Ditto.
147         (setAuthenticationPasswordCallback): Ditto.
148         (setAuthenticationUsernameCallback): Ditto.
149         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
150         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
151         (setPOSIXLocaleCallback): Ditto.
152         (setPersistentUserStyleSheetLocationCallback): Ditto.
153         (setUserStyleSheetLocationCallback): Ditto.
154         (setValueForUserCallback): Ditto.
155         (setWillSendRequestClearHeaderCallback): Ditto.
156         (setPageVisibilityCallback): Ditto.
157         (evaluateInWebInspectorCallback): Ditto.
158         (evaluateScriptInIsolatedWorldCallback): Ditto.
159         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
160         (addOriginAccessWhitelistEntryCallback): Ditto.
161         (removeOriginAccessWhitelistEntryCallback): Ditto.
162         (setScrollbarPolicyCallback): Ditto.
163         (addUserScriptCallback): Ditto.
164         (addUserStyleSheetCallback): Ditto.
165         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
166         (authenticateSessionCallback): Ditto.
167         (getTitleTextDirectionCallback): Ditto.
168         (getInspectorTestStubURLCallback): Ditto.
169         (simulateLegacyWebNotificationClickCallback): Ditto.
170         (setTextDirectionCallback): Ditto.
171         (grantWebNotificationPermissionCallback): Ditto.
172         (denyWebNotificationPermissionCallback): Ditto.
173         (accummulateLogsForChannel): Ditto.
174         (runUIScriptCallback): Ditto.
175         (TestRunner::makeWindowObject): Ditto.
176         (TestRunner::uiScriptDidComplete): Ditto.
177         (TestRunner::setOpenPanelFiles): Ditto.
178
179         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
180         raw pointers for the results of the functions that create strings.
181
182         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
183         (AccessibilityController::platformName const): Use the adopt
184         function instead of the adopt constructor.
185
186         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
187         (createEmptyJSString): Added. This helper function makes reduces the
188         repetitive code to create empty strings.
189         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
190         (AccessibilityUIElement::identifier): Ditto.
191         (AccessibilityUIElement::traits): Ditto.
192         (AccessibilityUIElement::url): Ditto.
193         (AccessibilityUIElement::speakAs): Ditto.
194         (AccessibilityUIElement::stringForSelection): Ditto.
195         (AccessibilityUIElement::stringForRange): Ditto.
196         (AccessibilityUIElement::attributedStringForRange): Ditto.
197         (AccessibilityUIElement::attributedStringForElement): Ditto.
198         (AccessibilityUIElement::pathDescription const): Ditto.
199         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
200         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
201         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
202         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
203         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
204         (AccessibilityUIElement::attributesOfChildren): Ditto.
205         (AccessibilityUIElement::allAttributes): Ditto.
206         (AccessibilityUIElement::stringAttributeValue): Ditto.
207         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
208         (AccessibilityUIElement::role): Ditto.
209         (AccessibilityUIElement::subrole): Ditto.
210         (AccessibilityUIElement::roleDescription): Ditto.
211         (AccessibilityUIElement::computedRoleString): Ditto.
212         (AccessibilityUIElement::title): Ditto.
213         (AccessibilityUIElement::description): Ditto.
214         (AccessibilityUIElement::orientation const): Ditto.
215         (AccessibilityUIElement::stringValue): Ditto.
216         (AccessibilityUIElement::language): Ditto.
217         (AccessibilityUIElement::helpText const): Ditto.
218         (AccessibilityUIElement::valueDescription): Ditto.
219         (AccessibilityUIElement::ariaDropEffects const): Ditto.
220         (AccessibilityUIElement::boundsForRange): Ditto.
221         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
222         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
223         (AccessibilityUIElement::attributesOfColumns): Ditto.
224         (AccessibilityUIElement::attributesOfRows): Ditto.
225         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
226         (AccessibilityUIElement::attributesOfHeader): Ditto.
227         (AccessibilityUIElement::rowIndexRange): Ditto.
228         (AccessibilityUIElement::columnIndexRange): Ditto.
229         (AccessibilityUIElement::selectedTextRange): Ditto.
230         (AccessibilityUIElement::accessibilityValue const): Ditto.
231         (AccessibilityUIElement::documentEncoding): Ditto.
232         (AccessibilityUIElement::documentURI): Ditto.
233         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
234         (AccessibilityUIElement::classList const): Ditto.
235
236         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
237         createJSStringRef method to return a JSRetainPtr.
238         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
239         (-[NSString createJSStringRef]): Ditto.
240         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
241         adopt function instead of the adopt constructor.
242         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
243         (AccessibilityController::platformName const): Ditto.
244
245         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
246         (-[NSString createJSStringRef]): Return a JSRetainPtr.
247         (makeValueRefForValue): Updated for the above, no adopt needed here now.
248         (makeObjectRefForDictionary): Ditto.
249         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
250
251         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
252         (createEmptyJSString): Added. This helper function makes reduces the
253         repetitive code to create empty strings.
254         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
255         (descriptionOfElements): Ditto.
256         (selectTextParameterizedAttributeForCriteria): Ditto.
257         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
258         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
259         (AccessibilityUIElement::attributesOfChildren): Ditto.
260         (AccessibilityUIElement::allAttributes): Ditto.
261         (AccessibilityUIElement::stringAttributeValue): Ditto.
262         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
263         (AccessibilityUIElement::role): Ditto.
264         (AccessibilityUIElement::subrole): Ditto.
265         (AccessibilityUIElement::roleDescription): Ditto.
266         (AccessibilityUIElement::computedRoleString): Ditto.
267         (AccessibilityUIElement::title): Ditto.
268         (AccessibilityUIElement::description): Ditto.
269         (AccessibilityUIElement::orientation const): Ditto.
270         (AccessibilityUIElement::stringValue): Ditto.
271         (AccessibilityUIElement::language): Ditto.
272         (AccessibilityUIElement::helpText const): Ditto.
273         (AccessibilityUIElement::valueDescription): Ditto.
274         (AccessibilityUIElement::speakAs): Ditto.
275         (AccessibilityUIElement::classList const): Ditto.
276         (AccessibilityUIElement::ariaDropEffects const): Ditto.
277         (AccessibilityUIElement::rangeForLine): Ditto.
278         (AccessibilityUIElement::rangeForPosition): Ditto.
279         (AccessibilityUIElement::boundsForRange): Ditto.
280         (AccessibilityUIElement::stringForRange): Ditto.
281         (AccessibilityUIElement::attributedStringForRange): Ditto.
282         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
283         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
284         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
285         (AccessibilityUIElement::attributesOfColumns): Ditto.
286         (AccessibilityUIElement::attributesOfRows): Ditto.
287         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
288         (AccessibilityUIElement::attributesOfHeader): Ditto.
289         (AccessibilityUIElement::rowIndexRange): Ditto.
290         (AccessibilityUIElement::columnIndexRange): Ditto.
291         (AccessibilityUIElement::pathDescription const): Ditto.
292         (AccessibilityUIElement::selectedTextRange): Ditto.
293         (AccessibilityUIElement::accessibilityValue const): Ditto.
294         (AccessibilityUIElement::documentEncoding): Ditto.
295         (AccessibilityUIElement::documentURI): Ditto.
296         (AccessibilityUIElement::url): Ditto.
297         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
298         (createJSStringRef): Ditto.
299         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
300         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
301         (AccessibilityUIElement::supportedActions): Ditto.
302         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
303         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
304
305         * DumpRenderTree/mac/FrameLoadDelegate.mm:
306         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
307         Use the adopt function instead of the adopt constructor.
308         * DumpRenderTree/mac/TestRunnerMac.mm:
309         (originsArrayToJS): Ditto.
310         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
311         (TestRunner::copyEncodedHostName): Ditto.
312         (TestRunner::pathToLocalResource): Ditto.
313         (TestRunner::queueLoad): Use adopt function instead of constructor.
314         (TestRunner::findString): Ditto.
315         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
316
317         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
318         (AccessibilityController::winNotificationReceived): Use adopt function
319         instead of adopt constructor.
320         (AccessibilityController::platformName const): Ditto.
321
322         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
323         (createEmptyJSString): Added. This helper function makes reduces the
324         repetitive code to create empty strings.
325         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
326         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
327         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
328         (AccessibilityUIElement::attributesOfChildren): Ditto.
329         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
330         (AccessibilityUIElement::role): Ditto.
331         (AccessibilityUIElement::subrole): Ditto.
332         (AccessibilityUIElement::roleDescription): Ditto.
333         (AccessibilityUIElement::computedRoleString): Ditto.
334         (AccessibilityUIElement::title): Ditto.
335         (AccessibilityUIElement::description): Ditto.
336         (AccessibilityUIElement::stringValue): Ditto.
337         (AccessibilityUIElement::language): Ditto.
338         (AccessibilityUIElement::helpText const): Ditto.
339         (AccessibilityUIElement::valueDescription): Ditto.
340         (AccessibilityUIElement::ariaDropEffects const): Ditto.
341         (AccessibilityUIElement::orientation const): Ditto.
342         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
343         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
344         (AccessibilityUIElement::attributesOfColumns): Ditto.
345         (AccessibilityUIElement::attributesOfRows): Ditto.
346         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
347         (AccessibilityUIElement::attributesOfHeader): Ditto.
348         (AccessibilityUIElement::rowIndexRange): Ditto.
349         (AccessibilityUIElement::columnIndexRange): Ditto.
350         (AccessibilityUIElement::boundsForRange): Ditto.
351         (AccessibilityUIElement::stringForRange): Ditto.
352         (AccessibilityUIElement::attributedStringForRange): Ditto.
353         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
354         (AccessibilityUIElement::selectedTextRange): Ditto.
355         (AccessibilityUIElement::stringAttributeValue): Ditto.
356         (AccessibilityUIElement::accessibilityValue const): Ditto.
357         (AccessibilityUIElement::documentEncoding): Ditto.
358         (AccessibilityUIElement::documentURI): Ditto.
359         (AccessibilityUIElement::url): Ditto.
360         (AccessibilityUIElement::classList const): Ditto.
361
362         * DumpRenderTree/win/TestRunnerWin.cpp:
363         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
364         (TestRunner::copyEncodedHostName): Ditto.
365         (TestRunner::pathToLocalResource): Ditto.
366         (TestRunner::queueLoad): Ditto.
367         (TestRunner::findString): Ditto.
368         (TestRunner::inspectorTestStubURL): Ditto.
369
370         * TestRunnerShared/Bindings/JSWrapper.h:
371         (WTR::setProperty): Use adopt function instead of constructor.
372         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
373         (UIScriptContext::UIScriptContext): Ditto.
374         (UIScriptContext::runUIScript): Ditto.
375         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
376         (WTR::toDeviceOrientation): Ditto.
377
378         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
379         (nsTextCheckingType): Changed this function to not take an rvalue
380         reference to a JSRetainPtr since it doesn't take ownership.
381         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
382         for the above change.
383
384         * TestWebKitAPI/JavaScriptTest.cpp:
385         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
386         adopt member function.
387
388         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
389         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
390         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
391         adopt constructor.
392         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
393
394         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
395         Removed unneeded includes.
396         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
397         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
398         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
399
400         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
401         (_platformTypeConstructor): Use the adopt function instead of the
402         JSRetainPtr adopt constructor. Also nullptr instead of 0.
403
404         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
405         (WTR::arrayLength): Use adopt function instead of constructor.
406         (WTR::parseModifierArray): Ditto.
407         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
408         (WTR::propertyValue): Ditto.
409         (WTR::dumpPath): Ditto.
410         (WTR::toJS): Ditto.
411         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
412         (WTR::TestRunner::findString): Ditto.
413         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
414         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
415         (WTR::TestRunner::setOpenPanelFiles): Ditto.
416         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
417         (WTR::AccessibilityController::platformName): Ditto.
418
419         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
420         (-[NSString createJSStringRef]): Return a JSRetainPtr.
421         This fixes storage leaks in many functions below, which were using
422         the create function and putting the value right into a JSRetainPtr
423         without adoption.
424         (WTR::createEmptyJSString): Added. This helper function reduces the
425         repetitive code to create empty strings.
426         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
427         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
428         Use createEmptyJSString, fixing a storage leak due to missing adoption.
429         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
430         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
431         (WTR::AccessibilityUIElement::allAttributes): Ditto.
432         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
433         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
434         (WTR::AccessibilityUIElement::role): Ditto.
435         (WTR::AccessibilityUIElement::subrole): Ditto.
436         (WTR::AccessibilityUIElement::roleDescription): Ditto.
437         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
438         (WTR::AccessibilityUIElement::title): Ditto.
439         (WTR::AccessibilityUIElement::orientation const): Ditto.
440         (WTR::AccessibilityUIElement::language): Ditto.
441         (WTR::AccessibilityUIElement::valueDescription): Ditto.
442         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
443         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
444         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
445         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
446         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
447         Use createEmptyJSString, fixing a storage leak due to missing adoption.
448         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
449         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
450         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
451         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
452         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
453         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
454         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
455         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
456         (WTR::AccessibilityUIElement::documentURI): Ditto.
457         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
458         null check.
459         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
460         Use createEmptyJSString, fixing a storage leak due to missing adoption.
461
462         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
463         Use JSRetainPtr for the return value of createJSStringRef.
464         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
465         (-[NSString createJSStringRef]): Ditto.
466         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
467         adopt function instead of the adopt constructor.
468         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
469         (WTR::AccessibilityController::platformName): Ditto
470
471         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
472         (-[NSString createJSStringRef]): Return a JSRetainPtr.
473         (makeValueRefForValue): Updated for above by removing adopt.
474         (makeObjectRefForDictionary): Ditto.
475         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
476
477         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
478         (WTR::createEmptyJSString): Added. This helper function makes reduces the
479         repetitive code to create empty strings.
480         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
481         (WTR::descriptionOfElements): Ditto.
482         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
483         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
484         fixing a storage leak due to missing adoption.
485         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
486         (WTR::AccessibilityUIElement::documentURI): Ditto.
487         (WTR::createJSStringRef): Return a JSRetainPtr.
488
489         * WebKitTestRunner/StringFunctions.h:
490         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
491         (WTR::toJS): Use the adopt function instead of the constructor.
492
493 2018-09-14  Dean Jackson  <dino@grorg.org>
494
495         Add Justin Michaud.
496
497         * Scripts/webkitpy/common/config/contributors.json:
498
499 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
500
501         bots should pass --clobber-old-results to run-webkit-tests
502         https://bugs.webkit.org/show_bug.cgi?id=189623
503
504         Reviewed by Aakash Jain.
505
506         In order to ensure that bots to not produce confusing results due to transient execptions,
507         or run out of space if they continually hit an exception, old layout test results should be clobbered.
508
509         * BuildSlaveSupport/build.webkit.org-config/steps.py:
510         (RunWebKitTests):
511
512 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
513
514         Unreviewed, rolling out r235954.
515
516         Breaks the watchOS build.
517
518         Reverted changeset:
519
520         "Move IndexedDB to Network Process"
521         https://bugs.webkit.org/show_bug.cgi?id=189415
522         https://trac.webkit.org/changeset/235954
523
524 2018-09-13  Daniel Bates  <dabates@apple.com>
525
526         Add Copy WebKit Permalink plugin for Sublime Text
527         https://bugs.webkit.org/show_bug.cgi?id=189589
528
529         Rubber-stamped by Joseph Pecoraro.
530
531         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
532         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
533         active document with or without blame annotations.
534
535         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
536         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
537         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
538         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
539         and Command + Shift + Control + Option + C, respectively.
540
541         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
542         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
543         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
544         * CopyPermalink/Sublime Text/INSTALL: Added.
545         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
546         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
547         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
548
549 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
550
551         Unreviewed. Fix WebDriver tests after r235225.
552
553         Use wpt serve command to run the http server.
554
555         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
556         (WebDriverW3CWebServer.__init__):
557         (WebDriverW3CWebServer.start):
558         (WebDriverW3CWebServer.stop):
559
560 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
561
562         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
563         https://bugs.webkit.org/show_bug.cgi?id=189544
564
565         Reviewed by Michael Catanzaro.
566
567         Add test cases for the new API.
568
569         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
570         (testWebViewJavaScriptDialogs):
571
572 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
573
574         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
575         https://bugs.webkit.org/show_bug.cgi?id=189496
576         <rdar://problem/44370981>
577
578         Unreviewed warning fix.
579
580         r235929 has introduced a new compilation warning:
581         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
582
583         * ImageDiff/cairo/PlatformImageCairo.cpp:
584         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
585
586 2018-09-12  Dan Bernstein  <mitz@apple.com>
587
588         [Cocoa] Complete support for Paste as Quotation
589         https://bugs.webkit.org/show_bug.cgi?id=189504
590
591         Reviewed by Wenson Hsieh.
592
593         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
594
595 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
596
597         Move IndexedDB to Network Process
598         https://bugs.webkit.org/show_bug.cgi?id=189415
599
600         Reviewed by Geoffrey Garen.
601
602         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
603         (TEST):
604         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
605         (TEST):
606         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
607         (TEST):
608         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
609         (TEST):
610         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
611         (TEST):
612
613 2018-09-12  Chris Dumez  <cdumez@apple.com>
614
615         PSON: No process swap on back navigation after URL bar navigation
616         https://bugs.webkit.org/show_bug.cgi?id=189557
617         <rdar://problem/44353108>
618
619         Reviewed by Alex Christensen.
620
621         Add API test coverage.
622
623         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
624
625 2018-09-11  Dean Jackson  <dino@apple.com>
626
627         Header parsing for experimental and internal debug features
628         https://bugs.webkit.org/show_bug.cgi?id=189486
629         <rdar://problem/44320618>
630
631         Reviewed by Tim Horton.
632
633         Keep track of experimental and internal debug features in TestOptions, and
634         allow webkit-test-runner headers to toggle them by name.
635
636         * DumpRenderTree/TestOptions.cpp:
637         (TestOptions::TestOptions):
638         * WebKitTestRunner/TestController.cpp:
639         (WTR::TestController::resetPreferencesToConsistentValues):
640         (WTR::updateTestOptionsFromTestHeader):
641         * WebKitTestRunner/TestOptions.h:
642         (WTR::TestOptions::hasSameInitializationOptions const):
643
644 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
645
646         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
647         https://bugs.webkit.org/show_bug.cgi?id=189492
648
649         Reviewed by Alex Christensen.
650
651         0 and nullptr can't be implicitly converted to
652         AccessibilityUIElement because only Windows port typedefs
653         PlatformUIElement as COMPtr<IAccessible> not a pointer.
654
655         Replaced "return 0" and "return nullptr" with "return { nullptr }".
656
657         * DumpRenderTree/AccessibilityUIElement.cpp:
658         (AccessibilityUIElement::horizontalScrollbar const):
659         (AccessibilityUIElement::verticalScrollbar const):
660         (AccessibilityUIElement::uiElementAttributeValue const):
661         (AccessibilityUIElement::accessibilityElementForTextMarker):
662         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
663         (AccessibilityController::elementAtPoint):
664         (AccessibilityController::accessibleElementById):
665         (AccessibilityController::focusedElement):
666         (AccessibilityController::rootElement):
667         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
668         (AccessibilityUIElement::elementAtPoint):
669         (AccessibilityUIElement::linkedUIElementAtIndex):
670         (AccessibilityUIElement::getChildAtIndex):
671         (AccessibilityUIElement::titleUIElement):
672         (AccessibilityUIElement::parentElement):
673         (AccessibilityUIElement::uiElementForSearchPredicate):
674         (AccessibilityUIElement::cellForColumnAndRow):
675         (AccessibilityUIElement::disclosedRowAtIndex):
676         (AccessibilityUIElement::ariaOwnsElementAtIndex):
677         (AccessibilityUIElement::ariaFlowToElementAtIndex):
678         (AccessibilityUIElement::ariaControlsElementAtIndex):
679         (AccessibilityUIElement::selectedRowAtIndex):
680         (AccessibilityUIElement::rowAtIndex):
681         (AccessibilityUIElement::disclosedByRow):
682         (AccessibilityUIElement::selectedChildAtIndex const):
683
684 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
685
686         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
687         https://bugs.webkit.org/show_bug.cgi?id=189382
688
689         Reviewed by Ryosuke Niwa.
690
691         Fix the test by specifying colors in RGB colorspace.
692
693         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
694         (TestWebKitAPI::TEST):
695
696 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
697
698         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
699         https://bugs.webkit.org/show_bug.cgi?id=189496
700
701         Reviewed by Alex Christensen.
702
703         * ImageDiff/cairo/PlatformImageCairo.cpp:
704         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
705         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
706
707 2018-09-07  Dean Jackson  <dino@apple.com>
708
709         Add and expose Internal features from WebKit
710         https://bugs.webkit.org/show_bug.cgi?id=189442
711         <rdar://problem/44243404>
712
713         Reviewed by Simon Fraser.
714
715         Update MiniBrowser to expose an Internal feature menu.
716
717         * MiniBrowser/mac/AppDelegate.m:
718         (defaultConfiguration):
719         * MiniBrowser/mac/SettingsController.m:
720         (-[SettingsController _populateMenu]):
721         (-[SettingsController validateMenuItem:]):
722         (-[SettingsController toggleExperimentalFeature:]):
723         (-[SettingsController toggleInternalDebugFeature:]):
724
725 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
726
727         [macOS] [WK2] Support changing foreground colors via color panel
728         https://bugs.webkit.org/show_bug.cgi?id=189382
729         <rdar://problem/44227311>
730
731         Reviewed by Ryosuke Niwa.
732
733         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
734         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
735         colors, as well as making different parts of a word different colors.
736
737         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
738         (-[TestWKWebView collapseToEnd]):
739         (webViewForFontManagerTesting):
740         (TestWebKitAPI::TEST):
741         * TestWebKitAPI/cocoa/TestWKWebView.h:
742
743 == Rolled over to ChangeLog-2018-09-11 ==