49b14413fb543269703b0bb760c60f693963ffb3
[WebKit-https.git] / Tools / ChangeLog
1 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
2
3         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
4         https://bugs.webkit.org/show_bug.cgi?id=102510
5
6         Reviewed by Pavel Feldman.
7
8         Added missing includes.
9
10         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
11
12 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
13
14         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
15         https://bugs.webkit.org/show_bug.cgi?id=103123
16
17         Reviewed by Kenneth Rohde Christiansen.
18
19         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
20         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
21
22         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
23         test.
24         * TestWebKitAPI/efl/PlatformUtilities.cpp:
25         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
26         test case is passing 0.5 seconds to sleep.
27         * TestWebKitAPI/efl/PlatformWebView.cpp:
28         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
29         (TestWebKitAPI):
30
31 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
32
33         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
34         https://bugs.webkit.org/show_bug.cgi?id=86881
35
36         Reviewed by Kenneth Rohde Christiansen.
37
38         eventSender object extended with contextClick() method in WebKitTestRunner.
39         contextClick() method returns an array of menu items objects with field 'title' containing title of single
40         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
41         delivered in this patch.
42
43         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
44         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
45         (WTR::EventSendingController::contextClick):
46         (WTR):
47         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
48         (EventSendingController):
49
50 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
51
52         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
53         https://bugs.webkit.org/show_bug.cgi?id=102942
54
55         Reviewed by Tor Arne Vestbø.
56
57         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
58         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
59         to follow the same rules as other Qt 5 modules, with the exception that instead of
60         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
61         in other cross-platform header files to determine the correct meaning of export
62         macros.
63
64         * qmake/mkspecs/features/default_post.prf:
65         * qmake/mkspecs/features/win32/default_post.prf:
66
67 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
68
69         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
70         https://bugs.webkit.org/show_bug.cgi?id=103111
71
72         Reviewed by Kenneth Rohde Christiansen.
73
74         This function was added as a slot during Qt 4.x times because adding
75         virtual functions breaks binary compatibility. This constraint is gone
76         with the initial release of WebKit with Qt 5, and therefore we can
77         make it virtual now.
78
79         The change is fully source compatible as existing "re-implementations"
80         as slots will now be called through it being a virtual function. They
81         become unused slots.
82
83         * DumpRenderTree/qt/DumpRenderTreeQt.h:
84         (WebCore::WebPage::shouldInterruptJavaScript):
85         (WebPage):
86         * QtTestBrowser/webpage.h:
87         (WebPage):
88
89 2012-11-22  Peter Beverloo  <peter@chromium.org>
90
91         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
92         https://bugs.webkit.org/show_bug.cgi?id=103065
93
94         Reviewed by Dirk Pranke.
95
96         This addresses two further reliability issues in the Android test running
97         scripts. Firstly, the run_tests.py script needs to have the --exit_code
98         argument passed in order to return non-zero codes, which we need for the
99         build master to distinguish failures from successful runs.
100
101         Secondly, it modifies the layout test runner to briefly wait (through
102         the wait-for-device command) after requesting a device to switch to root
103         mode. Without this waiting period, commands might get lost and thereby
104         unexpectedly fail.
105
106         * Scripts/run-api-tests:
107         * Scripts/run-chromium-webkit-unit-tests:
108         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
109         (ChromiumAndroidDriver._setup_test):
110         (ChromiumAndroidDriver._restart_adb_as_root):
111
112 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
113
114         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
115         https://bugs.webkit.org/show_bug.cgi?id=102800
116
117         Reviewed by Tor Arne Vestbø.
118
119         This patch separates code that needs to use QWidget related APIs in
120         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
121         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
122         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
123         static library. WebKit1 is compiled without QT += widgets and therefore
124         any widget related dependency has been moved "up" and out of WebKit1 into
125         the WebKitWidgets library.
126
127         Between the code in WebKit.a and WebKitWidgets.a new adapters and
128         interfaces have been introduced, such as QWebPageAdapter and
129         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
130         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
131         The other way around if QWebPage wants to access WebCore or
132         WebCoreSupport related functionality, it will go through
133         QWebPageAdapater (as base class). The separation in the direction up
134         into the API layer is complete with this patch, no code in WebKit1
135         depends on QtWidgets. The separation the other way around, code in the
136         API layer not using any WebCore types, is not complete yet.
137
138         Some classes such as QWebSettings, QWebElement or
139         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
140         they do not depend on widget related Qt APIs and they make much more
141         use of WebCore internal APIs and therefore are easier to keep in
142         WebKit1.
143
144         In the future we plan to place a real shared library boundary between
145         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
146         part of the QtWebKit shared library and by turning the WebKitWidgets
147         static library into a shared one.
148
149         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
150         (WebCore::WebPage::resetSettings):
151         (WebCore::WebPage::createWindow):
152         (WebCore::DumpRenderTree::DumpRenderTree):
153         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
154         (WebCore::DumpRenderTree::initJSObjects):
155         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
156         (WebCore::DumpRenderTree::dumpFramesAsText):
157         (WebCore::DumpRenderTree::dump):
158         (WebCore::DumpRenderTree::createWindow):
159         (WebCore::DumpRenderTree::pageAdapter):
160         (WebCore):
161         (WebCore::DumpRenderTree::mainFrameAdapter):
162         * DumpRenderTree/qt/DumpRenderTreeQt.h:
163         (DumpRenderTree):
164         * DumpRenderTree/qt/EventSenderQt.cpp:
165         (EventSender::contextClick):
166         (EventSender::scalePageBy):
167         * DumpRenderTree/qt/TestRunnerQt.cpp:
168         (TestRunner::reset):
169         (TestRunner::display):
170         (TestRunner::closeWebInspector):
171         (TestRunner::showWebInspector):
172         (TestRunner::evaluateInWebInspector):
173         (TestRunner::setFrameFlatteningEnabled):
174         (TestRunner::goBack):
175         (TestRunner::setDefersLoading):
176         (TestRunner::pauseAnimationAtTimeOnElementWithId):
177         (TestRunner::pauseTransitionAtTimeOnElementWithId):
178         (TestRunner::numberOfActiveAnimations):
179         (TestRunner::setCaretBrowsingEnabled):
180         (TestRunner::setAuthorAndUserStylesEnabled):
181         (TestRunner::callShouldCloseOnWebView):
182         (TestRunner::setSmartInsertDeleteEnabled):
183         (TestRunner::setSelectTrailingWhitespaceEnabled):
184         (TestRunner::execCommand):
185         (TestRunner::isCommandEnabled):
186         (TestRunner::findString):
187         (TestRunner::elementDoesAutoCompleteForElementWithId):
188         (TestRunner::setMockDeviceOrientation):
189         (TestRunner::setGeolocationPermission):
190         (TestRunner::numberOfPendingGeolocationPermissionRequests):
191         (TestRunner::setMockGeolocationPositionUnavailableError):
192         (TestRunner::setMockGeolocationPosition):
193         (TestRunner::evaluateScriptInIsolatedWorld):
194         (TestRunner::addUserStyleSheet):
195         (TestRunner::setMinimumTimerInterval):
196         * DumpRenderTree/qt/TextInputControllerQt.cpp:
197         (TextInputController::selectedRange):
198         (TextInputController::firstRectForCharacterRange):
199         (TextInputController::unmarkText):
200         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
201         (LoadAlternateHTMLStringItem::invoke):
202         * qmake/mkspecs/features/default_post.prf:
203         * qmake/mkspecs/features/production_build.prf:
204         * qmake/mkspecs/features/webkit_modules.prf:
205         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
206
207 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
208
209         WebKitTestRunner needs layoutTestController.setCacheModel
210         https://bugs.webkit.org/show_bug.cgi?id=42684
211
212         Reviewed by Kenneth Rohde Christiansen.
213
214         Add support for testRunner.setCacheModel to WebKitTestRunner.
215
216         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
217         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
218         (WTR::InjectedBundle::beginTesting):
219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
220         (WTR::TestRunner::setCacheModel):
221         (WTR):
222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
223         (TestRunner):
224
225 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
226
227         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
228         https://bugs.webkit.org/show_bug.cgi?id=101327
229
230         Reviewed by Simon Hausmann.
231
232         Avoid busy waiting for events in platformRunUntil while making
233         sure we don't change the behavior of modal event loops.
234
235         * WebKitTestRunner/TestController.cpp:
236         (WTR::TestController::~TestController):
237         * WebKitTestRunner/TestController.h:
238         (TestController):
239         * WebKitTestRunner/efl/TestControllerEfl.cpp:
240         (WTR::TestController::platformDestroy):
241         (WTR):
242         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
243         (WTR::TestController::platformDestroy):
244         (WTR):
245         * WebKitTestRunner/mac/TestControllerMac.mm:
246         (WTR::TestController::platformDestroy):
247         (WTR):
248         * WebKitTestRunner/qt/TestControllerQt.cpp:
249         (TestController::RunLoop): Helper class to handle
250         the event loop logic
251         (WTR):
252         (WTR::TestController::RunLoop::RunLoop):
253         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
254         the run loop. This is the appropriate API to push the WaitForMoreEvents
255         flag to QCoreApplication::processEvents and also being able to exit the
256         loop if we have timed out.
257         (WTR::TestController::RunLoop::notifyDone):
258         (WTR::TestController::RunLoop::timerFired):
259         (WTR::TestController::RunLoop::runModal):
260         (WTR::TestController::notifyDone):
261         (WTR::TestController::platformInitialize):
262         (WTR::TestController::platformDestroy):
263         (WTR::TestController::platformRunUntil):
264         (WTR::TestController::runModal):
265         * WebKitTestRunner/win/TestControllerWin.cpp:
266         (WTR::TestController::platformDestroy):
267         (WTR):
268
269 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
270
271         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
272         https://bugs.webkit.org/show_bug.cgi?id=102926
273
274         Reviewed by Kenneth Rohde Christiansen.
275
276         Add missing bits needed by WKPreferences and AboutBlankLoad API
277         tests in the test harness and enable these tests on EFL port.
278
279         * TestWebKitAPI/PlatformEfl.cmake:
280         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/efl/PlatformUtilities.cpp:
283         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
284         (Util):
285
286 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
287
288         [GTK][WTR] Implement AccessibilityUIElement::stringValue
289         https://bugs.webkit.org/show_bug.cgi?id=102951
290
291         Reviewed by Martin Robinson.
292
293         Implement AccessibilityUIElement::stringValue in the ATK backend
294         in the same manner it is implemented in DumpRenderTree.
295
296         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
297         (WTR::replaceCharactersForResults):
298         (WTR):
299         (WTR::AccessibilityUIElement::stringValue):
300
301 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
302
303         Unreviewed. Adding myself to committers.py.
304
305         * Scripts/webkitpy/common/config/committers.py:
306
307 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
308
309         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
310         https://bugs.webkit.org/show_bug.cgi?id=100061
311
312         Reviewed by Adam Barth.
313
314         On Android we're using a different pixel scaling implementation
315         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
316         platforms. In this mode, we don't make use of device-independent pixels. Device
317         scale factor is provided to WebKit and get merged into page scale factor. Other
318         than that device scale factor should have no effects on rendering.
319
320         * DumpRenderTree/chromium/WebPreferences.cpp:
321         (WebPreferences::applyTo):
322
323 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
324
325         Clear MousePressed state on context menu to avoid initiating a drag
326         https://bugs.webkit.org/show_bug.cgi?id=101786
327
328         Reviewed by Ojan Vafai.
329
330         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
331         (WebTestRunner):
332         (WebTestRunner::EventSender::EventSender):
333         (WebTestRunner::EventSender::contextClick):
334         Only send a MouseUp on Windows. Keep the current mouse pressed state when
335         calling up a context menu.
336
337 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
338
339         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
340         https://bugs.webkit.org/show_bug.cgi?id=102895
341
342         Reviewed by Gyuyoung Kim.
343
344         Change the link order so it wont override the new operator on gtest.
345         Looks like it was crashing because an allocator mismatch (using libc's
346         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
347         the fastMalloc issue.
348
349         * TestWebKitAPI/CMakeLists.txt:
350
351 2012-11-21  Kentaro Hara  <haraken@chromium.org>
352
353         Unreviewed, rolling out r135340.
354         http://trac.webkit.org/changeset/135340
355         https://bugs.webkit.org/show_bug.cgi?id=102492
356
357         It broke Safari's internal build
358
359         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
360         (new):
361         (GenerateModule):
362         (GenerateInterface):
363         (finish):
364
365 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
366
367         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
368         https://bugs.webkit.org/show_bug.cgi?id=101526
369
370         Reviewed by Kenneth Rohde Christiansen.
371
372         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
373
374         * Scripts/webkitperl/FeatureList.pm:
375         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
376
377 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
378
379         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
380         https://bugs.webkit.org/show_bug.cgi?id=102867
381
382         Reviewed by Gyuyoung Kim.
383
384         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
385
386         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
387         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
388         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
389
390         * MiniBrowser/efl/main.c:
391         (on_key_down):
392
393 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
394
395         Unreviewed, rolling out r133859.
396         http://trac.webkit.org/changeset/133859
397         https://bugs.webkit.org/show_bug.cgi?id=102875
398
399         This patch makes API test broken (Requested by gyuyoung on
400         #webkit).
401
402         * Scripts/webkitperl/FeatureList.pm:
403
404 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
405
406         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
407         https://bugs.webkit.org/show_bug.cgi?id=99114
408
409         Reviewed by Gyuyoung Kim.
410
411         Implemented window_create and window_close smartcallback functions.
412
413         * MiniBrowser/efl/main.c:
414         (on_window_create):
415         (on_window_close):
416         (window_create):
417
418 2012-11-20  Ojan Vafai  <ojan@chromium.org>
419
420         Simplify builder filters now that we have lists of which builders run which tests
421         https://bugs.webkit.org/show_bug.cgi?id=102849
422
423         Reviewed by Dirk Pranke.
424
425         We only need filters when we load the same master for multiple groups in the
426         same test type, i.e. when we need to only include some of the builders that run
427         a given test suite on a given master.
428
429         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
430         Now just make it a method on BuilderGroup.
431
432         * TestResultServer/static-dashboards/builders.js:
433         (BuilderGroup.prototype.append):
434         (BuilderGroup.prototype.setup):
435         (BuilderGroup.prototype._defaultBuilder):
436         (BuilderGroup.prototype.master):
437         (requestBuilderList):
438         (isChromiumWebkitTipOfTreeTestRunner):
439         (isChromiumWebkitDepsTestRunner):
440         (loadBuildersList):
441         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
442         (test):
443
444 2012-11-20  Ojan Vafai  <ojan@chromium.org>
445
446         Remove perfav master for webkit_unit_tests and test_shell_tests.
447         There are no bots on this master that run these tests.
448         * TestResultServer/static-dashboards/builders.js:
449
450 2012-11-20  Ojan Vafai  <ojan@chromium.org>
451
452         Remove special case for layout tests when builders fail to load
453         https://bugs.webkit.org/show_bug.cgi?id=102842
454
455         Reviewed by Tony Chang.
456
457         Now that we load only builders that actually run the given test
458         type, we can reliably show errors to the users because it
459         represents a broken bot.
460         * TestResultServer/static-dashboards/loader.js:
461
462 2012-11-15  Ojan Vafai  <ojan@chromium.org>
463
464         Generate a list of builders/test suites from the buildbot json
465         https://bugs.webkit.org/show_bug.cgi?id=102443
466
467         Reviewed by Dirk Pranke.
468
469         Instead of the cludgy things we do now to track which bots run which tests,
470         we generate all that data from the buildbots' json files.
471         This is the minimal amount to keep everything working. Once this lands,
472         we can also do a bunch of followup cleanup.
473
474         For now we commit the generated data. In theory, in the future, we could
475         have the test results server generate the data on the fly.
476
477         For the sake of easily understanding what changes when we run the generate script,
478         also checkin a pretty printed version of the output. The pretty printed version
479         is too large to serve as part of the flakiness dashboard though.
480
481         This also has the benefit of making the dashboard load much faster since
482         we no longer ever need to block on requests to buildbot.
483
484         * TestResultServer/generate_builders_json.py: Added.
485         (master_json_url):
486         (builder_json_url):
487         (cached_build_json_url):
488         (fetch_json):
489         (insert_builder_and_test_data):
490         (main):
491         * TestResultServer/generate_builders_json_unittest.py: Added.
492         (GenerateBuildersJsonTest):
493         (GenerateBuildersJsonTest.test_master_json_url):
494         (GenerateBuildersJsonTest.test_builder_json_url):
495         (GenerateBuildersJsonTest.test_cached_build_json_url):
496         (GenerateBuildersJsonTest.test_generate_json_data):
497         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
498         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
499         * TestResultServer/static-dashboards/builders.js:
500         (LOAD_BUILDBOT_DATA):
501         (BuilderGroup):
502         (BuilderGroup.prototype.append):
503         (BuilderGroup.prototype.master):
504         (requestBuilderList):
505         * TestResultServer/static-dashboards/builders.jsonp: Added.
506         * TestResultServer/static-dashboards/builders_unittests.js: Added.
507         * TestResultServer/static-dashboards/dashboard_base.js:
508         * TestResultServer/static-dashboards/flakiness_dashboard.js:
509         (showPopupForBuild):
510         (htmlForTestResults):
511         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
512         (loadExpectationsLayoutTests):
513         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
514         (resetGlobals):
515         (test):
516         * TestResultServer/static-dashboards/loader.js:
517         * TestResultServer/static-dashboards/loader_unittests.js:
518         * TestResultServer/static-dashboards/run-embedded-unittests.html:
519         * TestResultServer/static-dashboards/run-unittests.html:
520         * TestResultServer/static-dashboards/timeline_explorer.html:
521
522 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
523
524         [WTR][Qt] Enable fixedLayout when needed by the test
525         https://bugs.webkit.org/show_bug.cgi?id=102811
526
527         Reviewed by Kenneth Rohde Christiansen.
528
529         Create a flickable view for CSS Device Adaptation tests. This is
530         crucial for testing them since they will change the size of the
531         viewport.
532
533         * WebKitTestRunner/PlatformWebView.h:
534         (PlatformWebView):
535         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
536         (WTR::PlatformWebView::PlatformWebView):
537         (WTR::PlatformWebView::viewSupportsOptions):
538         (WTR):
539         * WebKitTestRunner/qt/main.cpp:
540         (main):
541
542 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
543
544         [WTR] WebKitTestRunner should be able to run tests using fixed layout
545         https://bugs.webkit.org/show_bug.cgi?id=102517
546
547         Reviewed by Kenneth Rohde Christiansen.
548
549         WTR will now request the creation of a view that has a page using
550         fixed layout for CSS Device Adaptation tests, but this feature might
551         be used in the future by any other test that requires a mobile-like type
552         of viewport (i.e. Viewport META tests should be ported).
553
554         The viewport type of the other tests remains unchanged and is restored
555         when the runner leaves the device-adapt/ folder.
556
557         * WebKitTestRunner/PlatformWebView.h:
558         (PlatformWebView):
559         * WebKitTestRunner/TestInvocation.cpp:
560         (WTR):
561         (WTR::shouldUseFixedLayout):
562         (WTR::updateLayoutType):
563         (WTR::TestInvocation::invoke):
564         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
565         (WTR::PlatformWebView::PlatformWebView):
566         (WTR::PlatformWebView::viewSupportsOptions):
567         (WTR):
568
569 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
570
571         [Qt] REGRESSION(r128174): Fast build path doesn't work now
572         https://bugs.webkit.org/show_bug.cgi?id=100360
573
574         Reviewed by Tor Arne Vestbø.
575
576         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
577
578         * Scripts/webkitdirs.pm:
579         (buildQMakeProjects):
580
581 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
582
583         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
584         https://bugs.webkit.org/show_bug.cgi?id=99011
585
586         Reviewed by Martin Robinson.
587
588         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
589
590         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
591         (WTR::AccessibilityController::logAccessibilityEvents):
592         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
593
594 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
595
596         webkitpy unit tests should run serially when checking code coverage
597         https://bugs.webkit.org/show_bug.cgi?id=102693
598
599         Reviewed by Dirk Pranke.
600
601         When checking code coverage, the unit tests should not be run in parallel
602         as this causes the tracing functions (set via sys.settrace in the coverage
603         module) being overriden, resulting in incorrect coverage reports.
604
605         * Scripts/webkitpy/test/main.py:
606         (Tester._run_tests):
607
608 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
609
610         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
611         https://bugs.webkit.org/show_bug.cgi?id=102704
612
613         Reviewed by Laszlo Gombos.
614
615         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
616
617         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
618         (WTR::initEcoreEvas):
619
620 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
621
622         [garden-o-matic] Switch frontend to use the gardeningserver.
623         https://bugs.webkit.org/show_bug.cgi?id=102712
624
625         Reviewed by Dirk Pranke.
626
627         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
628         using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.
629
630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
634         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
636         * Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
637
638 2012-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>
639
640         Unreviewed, rolling out r135172.
641         http://trac.webkit.org/changeset/135172
642         https://bugs.webkit.org/show_bug.cgi?id=102710
643
644         Broke some WebKit2 api tests :( (Requested by japhet on
645         #webkit).
646
647         * DumpRenderTree/chromium/WebViewHost.cpp:
648         (WebViewHost::updateForCommittedLoad):
649
650 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
651
652         [garden-o-matic] Enable serving garden-o-matic with gardeningserver.
653         https://bugs.webkit.org/show_bug.cgi?id=102703
654
655         Reviewed by Ojan Vafai.
656
657         To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
658         from the same origin as the gardening server. This change gently massages the current
659         logic to adapt an extension-sniffing-based approach of identifying static files,
660         rather than requiring an explicit list.
661
662         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
663         (ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
664         (ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.
665         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
666
667 2012-11-19  Ojan Vafai  <ojan@chromium.org>
668
669         Add DOM and HTML watchlists and add myself to a bunch of lists
670         https://bugs.webkit.org/show_bug.cgi?id=102707
671
672         Reviewed by Eric Seidel.
673
674         * Scripts/webkitpy/common/config/watchlist:
675
676 2012-11-19  Jochen Eisinger  <jochen@chromium.org>
677
678         [chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
679         https://bugs.webkit.org/show_bug.cgi?id=102676
680
681         Reviewed by Tony Chang.
682
683         In addition, I've replaced parsePageNumber with the more commonly used
684         cppVariantToInt32, moved abortModal to the list of stubbed out methods,
685         and removed setAutomaticLinkDetectionEnabled which wasn't used
686         anywhere.
687
688         * DumpRenderTree/chromium/DRTTestRunner.cpp:
689         (DRTTestRunner::DRTTestRunner):
690         (DRTTestRunner::reset):
691         (DRTTestRunner::overridePreference):
692         * DumpRenderTree/chromium/DRTTestRunner.h:
693         (DRTTestRunner):
694         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
695         (WebTestRunner::TestRunner::TestRunner):
696         (WebTestRunner::TestRunner::reset):
697         (WebTestRunner):
698         (WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
699         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
700         (WebTestRunner::TestRunner::execCommand):
701         (WebTestRunner::TestRunner::isCommandEnabled):
702         (WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
703         (WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
704         (WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
705         (WebTestRunner::TestRunner::numberOfActiveAnimations):
706         (WebTestRunner::TestRunner::callShouldCloseOnWebView):
707         (WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
708         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
709         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
710         (WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
711         (WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
712         (WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
713         (WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
714         (WebTestRunner::TestRunner::hasCustomPageSizeStyle):
715         (WebTestRunner::TestRunner::forceRedSelectionColors):
716         (WebTestRunner::TestRunner::addUserScript):
717         (WebTestRunner::TestRunner::addUserStyleSheet):
718         (WebTestRunner::TestRunner::startSpeechInput):
719         (WebTestRunner::TestRunner::loseCompositorContext):
720         (WebTestRunner::TestRunner::markerTextForListItem):
721         (WebTestRunner::TestRunner::findString):
722         (WebTestRunner::TestRunner::setMinimumTimerInterval):
723         (WebTestRunner::TestRunner::setAutofilled):
724         (WebTestRunner::TestRunner::setValueForUser):
725         (WebTestRunner::TestRunner::enableFixedLayoutMode):
726         (WebTestRunner::TestRunner::setFixedLayoutSize):
727         (WebTestRunner::TestRunner::selectionAsMarkup):
728         (WebTestRunner::TestRunner::setTextSubpixelPositioning):
729         (WebTestRunner::TestRunner::resetPageVisibility):
730         (WebTestRunner::TestRunner::setPageVisibility):
731         (WebTestRunner::TestRunner::setTextDirection):
732         (WebTestRunner::TestRunner::textSurroundingNode):
733         (WebTestRunner::TestRunner::workerThreadCount):
734         (WebTestRunner::TestRunner::cppVariantToBool):
735         (WebTestRunner::TestRunner::cppVariantToInt32):
736         (WebTestRunner::TestRunner::cppVariantToWebString):
737         (WebTestRunner::TestRunner::cppVariantToWebStringArray):
738         (WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
739         (WebTestRunner::TestRunner::fallbackMethod):
740         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
741         (WebKit):
742         (WebTestRunner::TestRunner::setWebView):
743         (TestRunner):
744         * DumpRenderTree/chromium/TestShell.cpp:
745         (TestShell::createMainWindow):
746         (TestShell::~TestShell):
747
748 2012-11-19  Yusuke Sato  <yusukes@chromium.org>
749
750         [Chromium] Flash cannot receive scroll events when threaded compositing is in use
751         https://bugs.webkit.org/show_bug.cgi?id=101423
752
753         Reviewed by James Robinson.
754
755         Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
756         LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
757         in the future.
758
759         * DumpRenderTree/chromium/TestWebPlugin.cpp:
760         (TestWebPlugin::initialize):
761
762 2012-11-19  Nate Chapin  <japhet@chromium.org>
763
764         Move empty loading to DocumentLoader, simplify FrameLoader::init()
765         https://bugs.webkit.org/show_bug.cgi?id=101512
766
767         Reviewed by Adam Barth.
768
769         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
770         interprets them as a non-empty load. This ensures
771         http/tests/navigation/new-window-redirect-history.html continues to pass
772         in chromium.
773
774         * DumpRenderTree/chromium/WebViewHost.cpp:
775         (WebViewHost::updateForCommittedLoad):
776
777 2012-11-19  Vincent Scheib  <scheib@chromium.org>
778
779         [Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
780         https://bugs.webkit.org/show_bug.cgi?id=96946
781
782         Reviewed by Adam Barth.
783
784         The runtime flag functionality has already been removed.
785         Now that Chromium no longer has a compile dependency on this
786         API, it can be removed as well.
787
788         * DumpRenderTree/chromium/TestShell.cpp:
789         (TestShell::TestShell):
790
791 2012-11-19  Kihong Kwon  <kihong.kwon@samsung.com>
792
793         Add PROXIMITY_EVENTS feature
794         https://bugs.webkit.org/show_bug.cgi?id=102658
795
796         Reviewed by Kentaro Hara.
797
798         Add PROXIMITY_EVENTS feature to FeatureList and qmake.
799
800         * Scripts/webkitperl/FeatureList.pm:
801         * qmake/mkspecs/features/features.pri:
802
803 2012-11-19  Christophe Dumez  <christophe.dumez@intel.com>
804
805         [WK2][WTR] Memory leak in TestController::initialize()
806         https://bugs.webkit.org/show_bug.cgi?id=102616
807
808         Reviewed by Kenneth Rohde Christiansen.
809
810         Remove call to WKStringCreateWithUTF8CString() to construct
811         the icon database path which was leaking memory since the
812         returned WKStringRef was not adopted. The code now uses
813         WTF::String instead of std::string and converts it to a
814         WKStringRef using toWK().
815
816         * WebKitTestRunner/StringFunctions.h:
817         (WTR::toWK): Overload toWK() to take a WTF::String in
818         argument.
819         (WTR):
820         * WebKitTestRunner/TestController.cpp:
821         (WTR::TestController::initialize):
822
823 2012-11-19  Kentaro Hara  <haraken@chromium.org>
824
825         Remove IDLStructure.pm
826         https://bugs.webkit.org/show_bug.cgi?id=102642
827
828         Reviewed by Adam Barth.
829
830         Previously IDLStructure.pm was full of regular expressions to
831         parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
832         just contains several data structures for the IDL parser. We can
833         move them to IDLParser.pm and thus remove IDLStructure.pm.
834
835         No tests. No change in generated code.
836
837         * WebKitTestRunner/DerivedSources.make:
838         * WebKitTestRunner/GNUmakefile.am:
839         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
840
841 2012-11-18  KyungTae Kim  <ktf.kim@samsung.com>
842
843         [EFL] Not to include "ewk_view_private.h" in Tools
844         https://bugs.webkit.org/show_bug.cgi?id=102644
845
846         Reviewed by Gyuyoung Kim.
847
848         Include ewk_view.h instead of ewk_view_private.h in Tools
849
850         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
851
852 2012-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
853
854         Unreviewed, rolling out r135104.
855         http://trac.webkit.org/changeset/135104
856         https://bugs.webkit.org/show_bug.cgi?id=102638
857
858         Should not use commit queue to add people to committer list.
859         (Requested by ap_ on #webkit).
860
861         * Scripts/webkitpy/common/config/committers.py:
862
863 2012-11-18  Vivek Galatage  <vivek.vg@samsung.com>
864
865         Add myself to committers.py
866         https://bugs.webkit.org/show_bug.cgi?id=102636
867
868         Reviewed by Laszlo Gombos.
869
870         Add myself to committers.py
871
872         * Scripts/webkitpy/common/config/committers.py:
873
874 2012-11-18  Genevieve Mak  <gmak@rim.com>
875
876         [BlackBerry] Enable Touch Sliders
877         https://bugs.webkit.org/show_bug.cgi?id=102516
878
879         Reviewed by Rob Buis.
880
881         Enabled for BlackBerry only
882         PR #242781
883         PR #176014
884
885         * Scripts/webkitperl/FeatureList.pm:
886
887 2012-11-17  Dimitri Glazkov  <dglazkov@chromium.org>
888
889         Remove unused code I wrote a long time ago from gardeningserver.py
890         https://bugs.webkit.org/show_bug.cgi?id=102605
891
892         Reviewed by Adam Barth.
893
894         * Scripts/webkitpy/tool/servers/gardeningserver.py: Removed.
895         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Removed.
896
897 2012-11-16  Tony Chang  <tony@chromium.org>
898
899         Remove ENABLE_CSS_HIERARCHIES since it's no longer in use
900         https://bugs.webkit.org/show_bug.cgi?id=102554
901
902         Reviewed by Andreas Kling.
903
904         As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 ,
905         we're going to revist this feature once additional vendor support is
906         achieved.
907
908         * Scripts/webkitperl/FeatureList.pm:
909
910 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
911
912         [chromium] move stubs from DRTTestRunner to TestRunner
913         https://bugs.webkit.org/show_bug.cgi?id=102489
914
915         Reviewed by Adam Barth.
916
917         This is part of moving all methods from DRTTestRunner to TestRunner.
918         Instead of keeping one stub per method, I'm using a shared stub to
919         clean up the code.
920
921         * DumpRenderTree/chromium/DRTTestRunner.cpp:
922         (DRTTestRunner::DRTTestRunner):
923         * DumpRenderTree/chromium/DRTTestRunner.h:
924         (DRTTestRunner):
925         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
926         (WebTestRunner::TestRunner::TestRunner):
927         (WebTestRunner):
928         (WebTestRunner::TestRunner::fallbackMethod):
929         (WebTestRunner::TestRunner::notImplemented):
930         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
931         (WebTestRunner):
932         (TestRunner):
933         (WebTestRunner::TestRunner::setDelegate):
934         * DumpRenderTree/chromium/TestShell.cpp:
935         (TestShell::createMainWindow):
936         (TestShell::~TestShell):
937
938 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
939
940         [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost
941         https://bugs.webkit.org/show_bug.cgi?id=102495
942
943         Reviewed by Adam Barth.
944
945         When a drag operation is initiated in a layout test, we need to
946         simulate a corresponding drop event, otherwise the WebViewImpl will sit
947         there waiting for it. Instead of having the embedder taking care of
948         this, move this into the TestRunner library.
949
950         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
951         (WebKit):
952         (WebTestProxyBase):
953         (WebTestRunner::WebTestProxy::startDragging):
954         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
955         (WebTestRunner::WebTestProxyBase::startDragging):
956         (WebTestRunner):
957         * DumpRenderTree/chromium/WebViewHost.cpp:
958         * DumpRenderTree/chromium/WebViewHost.h:
959         (WebViewHost):
960
961 2012-11-16  Tien-Ren Chen  <trchen@chromium.org>
962
963         Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor
964         https://bugs.webkit.org/show_bug.cgi?id=102462
965
966         Reviewed by James Robinson.
967
968         As we no longer have this "default" device scale factor.
969
970         * DumpRenderTree/chromium/WebPreferences.cpp:
971         (WebPreferences::applyTo):
972
973 2012-11-15  Takashi Sakamoto  <tasak@google.com>
974
975         [Win] key event's location does not work on Windows platform.
976         https://bugs.webkit.org/show_bug.cgi?id=89742
977
978         Reviewed by Brent Fulgham.
979
980         Modified keyDownCallback to use lparam to specify left-hand keys or
981         right-hand keys.
982
983         * DumpRenderTree/win/EventSender.cpp:
984         (makeKeyDataForScanCode):
985         Given a virtual keycode, generate scancode and extended key bit of
986         lparam.
987         (keyDownCallback):
988         Use lparam for left-hand and right-hand keys, because Windows doesn't
989         directly provide a virtual keycode which distinguishes between
990         left-hand and right-hand. For example, when control key is pressed,
991         wparam has VK_CONTROL, neither VK_RCONTROL nor VK_LCONTROL.
992
993 2012-11-16  Tommy Widenflycht  <tommyw@google.com>
994
995         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
996         https://bugs.webkit.org/show_bug.cgi?id=102386
997
998         Reviewed by Adam Barth.
999
1000         Adding mock data channel functionality.
1001
1002         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1003         (MockWebRTCPeerConnectionHandler::openDataChannel):
1004
1005 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
1006
1007         [chromium] delete unused testRunner methods
1008         https://bugs.webkit.org/show_bug.cgi?id=102479
1009
1010         Reviewed by Adam Barth.
1011
1012         These methods aren't used by any layout test. Remove them to avoid bit rot
1013
1014         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1015         (DRTTestRunner::DRTTestRunner):
1016         (DRTTestRunner::reset):
1017         * DumpRenderTree/chromium/DRTTestRunner.h:
1018         (DRTTestRunner):
1019         * DumpRenderTree/chromium/WebViewHost.cpp:
1020         (WebViewHost::shouldBeginEditing):
1021         (WebViewHost::shouldEndEditing):
1022         (WebViewHost::shouldInsertNode):
1023         (WebViewHost::shouldInsertText):
1024         (WebViewHost::shouldChangeSelectedRange):
1025         (WebViewHost::shouldDeleteRange):
1026         (WebViewHost::shouldApplyStyle):
1027         (WebViewHost::startDragging):
1028         (WebViewHost::enterFullScreenNow):
1029         (WebViewHost::exitFullScreenNow):
1030
1031 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
1032
1033         Private Browsing is a per-page setting that sets a global value
1034         https://bugs.webkit.org/show_bug.cgi?id=67870
1035
1036         Reviewed by Sam Weinig.
1037
1038         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1039         Call _switchNetworkLoaderToNewTestingSession before making other settings, so that
1040         they would actually apply to the testing session.
1041
1042         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1043         (WTR::InjectedBundle::initialize):
1044         (WTR::InjectedBundle::beginTesting):
1045         Only call WKBundleSwitchNetworkLoaderToNewTestingSession once per process, matching
1046         WebKit1. I'm not fully sure what is going wrong, but apparently creating mutiple
1047         sessions with the same identifier doesn't quite work.
1048
1049 2012-11-16  Yael Aharon  <yael.aharon@intel.com>
1050
1051         Unreviewed. Help bugzilla find me.
1052
1053         * Scripts/webkitpy/common/config/committers.py:
1054
1055 2012-11-16  Peter Beverloo  <peter@chromium.org>
1056
1057         Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
1058         https://bugs.webkit.org/show_bug.cgi?id=102245
1059
1060         Reviewed by Tony Chang.
1061
1062         When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
1063         the actual running part to the test runner which lives on the Chromium side.
1064         Re-implementing or even generalizing the device-interaction part in WebKit
1065         is error prone and not worth the effort.
1066
1067         * Scripts/run-api-tests:
1068         * Scripts/run-chromium-webkit-unit-tests:
1069
1070 2012-11-15  Yury Semikhatsky  <yurys@chromium.org>
1071
1072         Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
1073         https://bugs.webkit.org/show_bug.cgi?id=102384
1074
1075         Reviewed by Pavel Feldman.
1076
1077         Updated return type in accord with the changes in MemoryInstrumentationClient.
1078
1079         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1080
1081 2012-11-15  Gustavo Noronha Silva  <gns@gnome.org>
1082
1083         [GTK] Split WebCore/platform into a separate library
1084         https://bugs.webkit.org/show_bug.cgi?id=94435
1085
1086         Reviewed by Martin Robinson.
1087
1088         More people have been reporting problems when linking WebCore because
1089         the command line limit is being exceeded. Splitting WebCore a bit more
1090         is in order.
1091
1092         * GNUmakefile.am: link libWebCorePlatform into DRT
1093
1094 2012-11-15  Dana Jansens  <danakj@chromium.org>
1095
1096         [chromium] Stop using the WebCompositorSupport methods for changing settings
1097         https://bugs.webkit.org/show_bug.cgi?id=101968
1098
1099         Reviewed by James Robinson.
1100
1101         * DumpRenderTree/chromium/TestShell.cpp:
1102         * DumpRenderTree/chromium/TestShell.h:
1103         (TestShell::setPerTilePaintingEnabled):
1104         (TestShell::setAcceleratedAnimationEnabled):
1105
1106 2012-11-15  Tony Chang  <tony@chromium.org>
1107
1108         Generate Settings from a .in file
1109         https://bugs.webkit.org/show_bug.cgi?id=100393
1110
1111         Reviewed by Adam Barth.
1112
1113         Add the generated WebCore files to the include dir.
1114
1115         * TestWebKitAPI/CMakeLists.txt:
1116         * WebKitTestRunner/CMakeLists.txt:
1117
1118 2012-11-15  Roger Fong  <roger_fong@apple.com>
1119
1120         Make old-run-webkit-tests handle setting the results directory properly.
1121         https://bugs.webkit.org/show_bug.cgi?id=102273
1122         <rdar://problem/11571607>
1123
1124         Reviewed by Timothy Horton.
1125
1126         A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder.
1127         Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder.
1128         This caused many other problems including failure to upload test results and failed future test runs.
1129         The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory 
1130         using the saved directory when setting $testResultsDirectory.
1131
1132         * Scripts/old-run-webkit-tests:
1133
1134 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1135
1136         Unreviewed, rolling out r134800 and r134805.
1137         http://trac.webkit.org/changeset/134800
1138         http://trac.webkit.org/changeset/134805
1139         https://bugs.webkit.org/show_bug.cgi?id=102417
1140
1141         This patch broke chromium port (Requested by jianli on
1142         #webkit).
1143
1144         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1145         (MockWebRTCPeerConnectionHandler::openDataChannel):
1146
1147 2012-11-15  Tommy Widenflycht  <tommyw@google.com>
1148
1149         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
1150         https://bugs.webkit.org/show_bug.cgi?id=102386
1151
1152         Reviewed by Adam Barth.
1153
1154         Adding mock data channel functionality.
1155
1156         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1157         (MockWebRTCPeerConnectionHandler::openDataChannel):
1158
1159 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1160
1161         Unreviewed, rolling out r134649 and r134665.
1162         http://trac.webkit.org/changeset/134649
1163         http://trac.webkit.org/changeset/134665
1164         https://bugs.webkit.org/show_bug.cgi?id=102413
1165
1166         Broke a ton of downstream chromium tests (Requested by japhet
1167         on #webkit).
1168
1169         * DumpRenderTree/chromium/WebViewHost.cpp:
1170         (WebViewHost::updateForCommittedLoad):
1171
1172 2012-11-15  Andreas Kling  <akling@apple.com>
1173
1174         Update my e-mail address.
1175
1176         Rubber-stamped by Anders Koivisto.
1177
1178         * Scripts/webkitpy/common/config/committers.py:
1179
1180 2012-11-15  Dominik Röttsches  <dominik.rottsches@intel.com>
1181
1182         [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
1183         https://bugs.webkit.org/show_bug.cgi?id=101323
1184
1185         Reviewed by Martin Robinson.
1186
1187         Bumping Harfbuzz to newer version so that we can remove the
1188         ifdef round the fix for bug 101009 for EFL, too.
1189         We're using the zip snapshot since jhbuild can fallback to the previously
1190         downloaded blob in case of network failures which leads to better
1191         buildbot robustness. This zip snapshot currently needs to be locally
1192         patched to fix ICU detection on systems that don't have icu pkg-config files.
1193         The patch is suggested for merging into HarfBuzz. We can remove it locally
1194         once it's accepted into HarfBuzz upstream.
1195
1196         * efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
1197         * efl/jhbuild.modules: Bumping harfbuzz version.
1198
1199 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
1200
1201         [Mac] Implement WTR --no-timeout-at-all option
1202         https://bugs.webkit.org/show_bug.cgi?id=102251
1203
1204         Reviewed by Eric Carlson.
1205
1206         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
1207         Just do it, and convert to Objective C on the way for simplicity.
1208
1209 2012-11-14  Ryuan Choi  <ryuan.choi@gmail.com>
1210
1211         [EFL] Port tiled backing store
1212         https://bugs.webkit.org/show_bug.cgi?id=71352
1213
1214         Reviewed by Gyuyoung Kim.
1215
1216         * EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
1217         (_User_Arguments):
1218         (windowCreate):
1219         (parseUserArguments):
1220
1221 2012-11-14  Andy Estes  <aestes@apple.com>
1222
1223         Fix the build.
1224
1225         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1226
1227 2012-11-14  Dirk Pranke  <dpranke@chromium.org>
1228
1229         webkitpy: consolidate webkit-base-finding code
1230         https://bugs.webkit.org/show_bug.cgi?id=102007
1231
1232         Reviewed by Eric Seidel.
1233
1234         This patch creates a new "WebKitFinder" class that other
1235         modules can use to find the top of the WebKit tree and
1236         commonly used subdirectories. This logic was in the
1237         webkitpy.layout_test.port classes but wasn't specific to those
1238         classes and now can be used by other modules without needing a port
1239         (e.g., by the check-webkit-style python linter).
1240
1241         This code is somewhat redundant with the code for find_checkout_root()
1242         in the scm modules, but it does not rely on the presence of a version
1243         control system to work. This is a requirement for some uses of the
1244         tree (e.g., Chromium tester checkouts).
1245
1246         This patch removes most of the logic from the layout_tests.port.config
1247         module and makes that as private as possible. Now we just need to move
1248         the default_configuration and flag_from_configuration logic into
1249         DeprecatedPort (or someplace else appropriate) and we can finish
1250         getting rid of the Config class (but that is a separate patch).
1251
1252         * Scripts/webkitpy/common/webkit_finder.py: Added.
1253         (WebKitFinder):
1254         (WebKitFinder.__init__):
1255         (WebKitFinder.webkit_base):
1256         (WebKitFinder.path_from_webkit_base):
1257         (WebKitFinder.path_to_script):
1258         (WebKitFinder.layout_tests_dir):
1259         (WebKitFinder.perf_tests_dir):
1260         * Scripts/webkitpy/layout_tests/port/base.py:
1261         (Port.__init__):
1262         (Port):
1263         (Port.webkit_base):
1264         (Port.path_from_webkit_base):
1265         (Port.path_to_script):
1266         (Port.layout_tests_dir):
1267         (Port.perf_tests_dir):
1268         (Port.set_option_default):
1269         (Port._run_script):
1270         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1271         (PortTest.test_diff_text):
1272         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1273         (ChromiumLinuxPort._determine_driver_path_statically):
1274         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1275         * Scripts/webkitpy/layout_tests/port/config.py:
1276         (Config.__init__):
1277         (Config.build_directory):
1278         (Config.default_configuration):
1279         (Config._read_configuration):
1280         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
1281         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1282         (ConfigTest.test_default_configuration__standalone):
1283         (ConfigTest.test_default_configuration__scripterror):
1284         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1285         (DriverTest.make_port):
1286         (DriverTest.test_no_timeout):
1287         * Scripts/webkitpy/layout_tests/port/gtk.py:
1288         (GtkPort.setup_environ_for_server):
1289         * Scripts/webkitpy/layout_tests/port/mac.py:
1290         (MacPort.show_results_html_file):
1291         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1292         (TestWebKitPort.__init__):
1293         (PortTestCase.make_port):
1294         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1295         (WinPortTest.test_expectations_files):
1296         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1297         (XvfbDriverTest.make_driver):
1298         (XvfbDriverTest.test_stop):
1299         * Scripts/webkitpy/style/checkers/python.py:
1300         (Pylinter.__init__):
1301
1302 2012-11-14  Dana Jansens  <danakj@chromium.org>
1303
1304         [chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
1305         https://bugs.webkit.org/show_bug.cgi?id=102296
1306
1307         Reviewed by James Robinson.
1308
1309         These settings are always set by TestShell anyhow, but we should be
1310         setting them to false here along with everything else.
1311
1312         * DumpRenderTree/chromium/WebPreferences.cpp:
1313         (WebPreferences::reset):
1314
1315 2012-11-08  Andy Estes  <aestes@apple.com>
1316
1317         [WebKit2] Need API in UIProcess to enable loading of custom protocols
1318         https://bugs.webkit.org/show_bug.cgi?id=101674
1319
1320         Reviewed by Brady Eidson.
1321
1322         Add an API test that implements a custom protocol and attempts to load
1323         a resource requiring that protocol in a WKView. The test passes only if
1324         didFinishLoadForFrame: fires.
1325
1326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1327         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Added.
1328         (+[TestProtocol canInitWithRequest:]):
1329         (+[TestProtocol canonicalRequestForRequest:]):
1330         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1331         (-[TestProtocol startLoading]):
1332         (-[TestProtocol stopLoading]):
1333         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1334         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
1335         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
1336         (-[TestBrowsingContextLoadDelegate initWithBlockToRunOnLoad:]):
1337         (-[TestBrowsingContextLoadDelegate browsingContextControllerDidFinishLoad:]):
1338
1339 2012-11-14  Ojan Vafai  <ojan@chromium.org>
1340
1341         Fix some defuct flakiness dashboard unittests.
1342         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1343
1344 2012-11-14  Glenn Adams  <glenn@skynav.com>
1345
1346         webkitpy: print-expectations - add --paths option to print only paths of test expectation files
1347         https://bugs.webkit.org/show_bug.cgi?id=102269
1348
1349         Reviewed by Dirk Pranke.
1350
1351         Add --paths option to print-expectations command in order to obtain list of applicable
1352         test expectation file paths.
1353
1354         * Scripts/webkitpy/tool/commands/queries.py:
1355         (PrintExpectations.__init__):
1356         (PrintExpectations.execute):
1357         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1358         (PrintExpectationsTest.run_test):
1359         (PrintExpectationsTest.test_paths):
1360
1361 2012-11-14  James Robinson  <jamesr@chromium.org>
1362
1363         webgl-background-color.html started failing
1364         https://bugs.webkit.org/show_bug.cgi?id=102247
1365
1366         Reviewed by Adrienne Walker.
1367
1368         The compositor thread should outlive the WebView.
1369
1370         * DumpRenderTree/chromium/TestShell.h:
1371         (TestShell):
1372
1373 2012-11-14  Nate Chapin  <japhet@chromium.org>
1374
1375         Move empty loading to DocumentLoader, simplify FrameLoader::init()
1376         https://bugs.webkit.org/show_bug.cgi?id=101512
1377
1378         Reviewed by Adam Barth.
1379
1380         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
1381         interprets them as a non-empty load. This ensures
1382         http/tests/navigation/new-window-redirect-history.html continues to pass
1383         in chromium.
1384
1385         * DumpRenderTree/chromium/WebViewHost.cpp:
1386         (WebViewHost::updateForCommittedLoad):
1387
1388 2012-11-14  Zan Dobersek  <zandobersek@gmail.com>
1389
1390         Remove uses of deprecated unittest.TestCase aliases
1391         https://bugs.webkit.org/show_bug.cgi?id=102253
1392
1393         Reviewed by Dirk Pranke.
1394
1395         Replace the deprecated unittest.TestCase methods with the corresponding methods
1396         everywhere inside the Tools directory. The following replacements are done:
1397         - assertEquals -> assertEqual
1398         - assert_ -> assertTrue
1399         - failUnlessRaises -> assertRaises
1400
1401         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1402         (SVNMirrorTest.test_CheckOutSource):
1403         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1404         (QueuePropertyMixinTest.test_queue_property):
1405         * QueueStatusServer/model/queues_unittest.py:
1406         (QueueTest._assert_short_name):
1407         (QueueTest._assert_display_name):
1408         (QueueTest._assert_name_with_underscores):
1409         * QueueStatusServer/model/workitems_unittest.py:
1410         (WorkItemsTest.test_display_position_for_attachment):
1411         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1412         (test_parse_log_entries_from_changelog):
1413         (test_parse_log_entries_from_annotated_file):
1414         (_assert_parse_reviewer_text_and_list):
1415         (_assert_parse_reviewer_text_list):
1416         (_assert_fuzzy_reviewer_match):
1417         (_assert_parse_authors):
1418         (test_latest_entry_parse):
1419         (test_latest_entry_parse_single_entry):
1420         (test_set_reviewer):
1421         (test_set_short_description_and_bug_url):
1422         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1423         (DiffParserTest.test_diff_parser):
1424         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1425         (GitSVNTest.test_revisions_changing_files_with_local_commit):
1426         (GitSVNTest.test_upstream_branch):
1427         (GitSVNTest.test_create_patch_with_rm_and_changed_files):
1428         (GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
1429         * Scripts/webkitpy/common/config/ports_unittest.py:
1430         (DeprecatedPortTest.test_mac_port):
1431         (DeprecatedPortTest.test_gtk_port):
1432         (DeprecatedPortTest.test_efl_port):
1433         (DeprecatedPortTest.test_qt_port):
1434         (DeprecatedPortTest.test_chromium_port):
1435         (DeprecatedPortTest.test_chromium_android_port):
1436         (DeprecatedPortTest.test_chromium_xvfb_port):
1437         * Scripts/webkitpy/common/config/urls_unittest.py:
1438         (URLsTest.test_parse_bug_id):
1439         (URLsTest.test_parse_attachment_id):
1440         * Scripts/webkitpy/common/find_files_unittest.py:
1441         (TestWinNormalize.assert_filesystem_normalizes):
1442         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1443         (test_url_creation):
1444         (test_parse_bug_id):
1445         (_assert_dictionaries_equal):
1446         (test_parse_bugs_from_xml):
1447         (test_attachment_detail_bug_parsing):
1448         (_assert_result_count):
1449         (test_request_page_parsing):
1450         (test_quip_page_parsing):
1451         (EditUsersParserTest._assert_login_userid_pairs):
1452         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1453         (test_status_parsing):
1454         (test_latest_cached_build):
1455         (test_results_zip_url):
1456         * Scripts/webkitpy/common/net/credentials_unittest.py:
1457         (test_credentials_from_environment):
1458         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1459         (FailureMapTest.test_failing_revisions):
1460         (FailureMapTest.test_new_failures):
1461         (FailureMapTest.test_new_failures_with_old_revisions):
1462         (FailureMapTest.test_new_failures_with_more_old_revisions):
1463         (FailureMapTest.test_tests_failing_for):
1464         (FailureMapTest.test_failing_tests):
1465         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1466         (LayoutTestResultsTest.test_set_failure_limit_count):
1467         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1468         (UnitTestResultsTest.test_nostring):
1469         (UnitTestResultsTest.test_emptystring):
1470         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1471         (ReadChecksumFromPngTest.test_read_checksum):
1472         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
1473         (LoggingTest.assert_log_equals):
1474         * Scripts/webkitpy/common/system/executive_unittest.py:
1475         (ScriptErrorTest.test_string_from_args):
1476         (ScriptErrorTest.test_message_with_output):
1477         (ExecutiveTest.test_run_command_with_bad_command):
1478         (ExecutiveTest.test_run_command_with_unicode):
1479         (ExecutiveTest.serial_test_run_in_parallel):
1480         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1481         (MockFileSystemTest.quick_check):
1482         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1483         (GenericFileSystemTests.test_glob__trailing_asterisk):
1484         (GenericFileSystemTests.test_glob__leading_asterisk):
1485         (GenericFileSystemTests.test_glob__middle_asterisk):
1486         (GenericFileSystemTests.test_glob__period_is_escaped):
1487         (RealFileSystemTest.test_chdir):
1488         (RealFileSystemTest.test_remove_file_with_retry):
1489         (RealFileSystemTest.test_sep):
1490         * Scripts/webkitpy/common/system/logtesting.py:
1491         (TestLogStream.assertMessages):
1492         * Scripts/webkitpy/common/system/logutils_unittest.py:
1493         (GetLoggerTest.test_get_logger_in_webkitpy):
1494         (GetLoggerTest.test_get_logger_not_in_webkitpy):
1495         * Scripts/webkitpy/common/system/outputcapture.py:
1496         (OutputCaptureTestCaseBase.assertStdout):
1497         (OutputCaptureTestCaseBase.assertStderr):
1498         * Scripts/webkitpy/common/system/path_unittest.py:
1499         (AbspathTest.test_abspath_to_uri_cygwin):
1500         (AbspathTest.test_abspath_to_uri_unixy):
1501         (AbspathTest.test_abspath_to_uri_win):
1502         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1503         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1504         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1505         (TestPlatformInfo.test_real_code):
1506         (TestPlatformInfo.test_os_name_and_wrappers):
1507         (TestPlatformInfo.test_os_version):
1508         (TestPlatformInfo.test_total_bytes_memory):
1509         * Scripts/webkitpy/common/system/user_unittest.py:
1510         (UserTest.test_confirm.mock_raw_input):
1511         (UserTest.test_confirm):
1512         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1513         (ZipFileSetTest.test_open):
1514         (ZipFileSetTest.test_read):
1515         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1516         (WatchListTest.test_filename_definition_no_matches):
1517         (WatchListTest.test_filename_definition):
1518         (WatchListTest.test_cc_rules_simple):
1519         (WatchListTest.test_cc_rules_complex):
1520         (WatchListTest.test_cc_and_message_rules_complex):
1521         (WatchListTest.test_cc_and_message_rules_no_matches):
1522         (WatchListTest.test_added_match):
1523         (WatchListTest.test_deleted_match):
1524         (WatchListTest.test_more_and_less_match):
1525         (WatchListTest.test_complex_match):
1526         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1527         (LockCheckingRunner.handle_finished_list):
1528         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1529         (LayoutTestRunnerTests.test_update_summary_with_result):
1530         (LayoutTestRunnerTests.test_servers_started):
1531         (SharderTests.assert_shards):
1532         (SharderTests.test_shard_in_two_has_no_locked_shards):
1533         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
1534         (NaturalCompareTest.assert_cmp):
1535         (KeyCompareTest.assert_cmp):
1536         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1537         (TestConfigurationTest.test_items):
1538         (TestConfigurationTest.test_keys):
1539         (TestConfigurationTest.test_str):
1540         (TestConfigurationTest.test_repr):
1541         (TestConfigurationTest.test_hash):
1542         (TestConfigurationTest.test_eq):
1543         (TestConfigurationTest.test_values):
1544         (SpecifierSorterTest.test_init):
1545         (SpecifierSorterTest.test_add_specifier):
1546         (SpecifierSorterTest.test_add_macros):
1547         (SpecifierSorterTest.test_category_priority):
1548         (SpecifierSorterTest.test_specifier_priority):
1549         (SpecifierSorterTest.test_sort_specifiers):
1550         (TestConfigurationConverterTest.test_symmetric_difference):
1551         (TestConfigurationConverterTest.test_to_config_set):
1552         (TestConfigurationConverterTest.test_macro_expansion):
1553         (TestConfigurationConverterTest.test_to_specifier_lists):
1554         (TestConfigurationConverterTest.test_macro_collapsing):
1555         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1556         (TestConfigurationConverterTest.test_specifier_converter_access):
1557         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1558         (assert_exp):
1559         (MiscTests.test_result_was_expected):
1560         (MiscTests.test_remove_pixel_failures):
1561         (MiscTests.test_suffixes_for_expectations):
1562         (MiscTests.test_get_expectations_string):
1563         (SkippedTests.check):
1564         (ExpectationSyntaxTests.assert_tokenize_exp):
1565         (SemanticTests.test_bad_bugid):
1566         (SemanticTests.test_missing_bugid):
1567         (TestExpectationSerializationTests.test_reconstitute_only_these):
1568         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1569         (TestFailuresTest.test_crashes):
1570         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1571         (PortTest.test_nonexistant_expectations):
1572         (PortTest.test_additional_expectations):
1573         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1574         (BuildersTest.test_path_from_name):
1575         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1576         (ChromiumAndroidPortTest.test_attributes):
1577         (ChromiumAndroidPortTest.test_default_timeout_ms):
1578         (ChromiumAndroidPortTest.test_get_devices_one_device):
1579         (ChromiumAndroidPortTest.test_get_devices_two_devices):
1580         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
1581         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
1582         (ChromiumAndroidPortTest.test_must_require_http_server):
1583         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
1584         (ChromiumAndroidDriverTest.test_get_crash_log):
1585         (ChromiumAndroidDriverTest.test_cmd_line):
1586         (ChromiumAndroidDriverTest.test_read_prompt):
1587         (ChromiumAndroidDriverTest.test_command_from_driver_input):
1588         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
1589         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1590         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1591         (ChromiumLinuxPortTest.assert_architecture):
1592         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1593         (ChromiumLinuxPortTest.test_path_to_image_diff):
1594         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1595         (ChromiumMacPortTest.assert_name):
1596         (ChromiumMacPortTest.test_baseline_path):
1597         (ChromiumMacPortTest.test_path_to_image_diff):
1598         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1599         (ChromiumPortTestCase.test_default_max_locked_shards):
1600         (ChromiumPortTestCase.test_default_timeout_ms):
1601         (ChromiumPortTestCase.test_default_pixel_tests):
1602         (ChromiumPortTestCase.test_all_test_configurations):
1603         (ChromiumPortTestCase.test_default_configuration):
1604         (ChromiumPortTestCase.test_diff_image):
1605         (ChromiumPortTestCase.test_diff_image_crashed):
1606         (ChromiumPortTestCase.test_expectations_files):
1607         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1608         (ChromiumWinTest.test_setup_environ_for_server_cygpath):
1609         (ChromiumWinTest.assert_name):
1610         (ChromiumWinTest.test_baseline_path):
1611         (ChromiumWinTest.test_path_to_image_diff):
1612         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1613         (DriverTest.test_read_block):
1614         (DriverTest.test_read_binary_block):
1615         (DriverTest.test_read_base64_block):
1616         (DriverTest.test_no_timeout):
1617         (DriverTest.test_check_for_driver_crash.assert_crash):
1618         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1619         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1620         (FactoryTest.test_get_from_builder_name):
1621         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1622         (GtkPortTest.test_default_timeout_ms):
1623         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1624         (HttpLockTest.test_current_lock_pid):
1625         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1626         (TestImageDiffer.test_diff_image_failed):
1627         (TestImageDiffer.test_diff_image_passed):
1628         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1629         (LeakDetectorTest.test_leaks_args):
1630         (test_parse_leaks_output):
1631         (test_leaks_files_in_directory):
1632         (test_count_total_leaks):
1633         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1634         (MacTest.test_default_timeout_ms):
1635         (assert_name):
1636         (test_setup_environ_for_server):
1637         (_assert_search_path):
1638         (test_32bit):
1639         (test_64bit):
1640         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1641         (MockTestShellTest.test_pixeltest__fails):
1642         (MockTestShellTest.test_test_shell_parse_options):
1643         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1644         (PortTestCase.test_default_max_locked_shards):
1645         (PortTestCase.test_default_timeout_ms):
1646         (PortTestCase.test_default_pixel_tests):
1647         (PortTestCase.test_diff_image):
1648         (PortTestCase.test_diff_image_crashed):
1649         (PortTestCase.test_get_crash_log):
1650         (PortTestCase.assert_build_path):
1651         (PortTestCase.test_expectations_ordering):
1652         (_assert_config_file_for_platform):
1653         (test_path_to_apache_config_file):
1654         (test_additional_platform_directory):
1655         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1656         (QtPortTest._assert_search_path):
1657         (QtPortTest._assert_expectations_files):
1658         (QtPortTest.test_setup_environ_for_server):
1659         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1660         (TestServerProcess.test_basic):
1661         (TestServerProcess.test_broken_pipe):
1662         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1663         (WinPortTest._assert_search_path):
1664         (WinPortTest._assert_version):
1665         (WinPortTest.test_runtime_feature_list):
1666         (WinPortTest.test_expectations_files):
1667         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1668         (LintTest.test_all_configurations):
1669         (MainTest.test_all):
1670         (MainTest.test_repeat_each):
1671         (MainTest.test_skipped_flag):
1672         (MainTest.test_iterations):
1673         (MainTest.test_run_chunk):
1674         (MainTest.test_run_part):
1675         (MainTest.test_run_singly):
1676         (MainTest.test_run_singly_actually_runs_tests):
1677         (MainTest.test_single_file):
1678         (MainTest.test_single_file_with_prefix):
1679         (MainTest.test_single_skipped_file):
1680         (MainTest.test_stderr_is_saved):
1681         (MainTest.test_test_list):
1682         (MainTest.test_test_list_with_prefix):
1683         (MainTest.test_missing_and_unexpected_results):
1684         (MainTest.test_pixel_test_directories):
1685         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1686         (MainTest.test_crash_log):
1687         (MainTest.test_web_process_crash_log):
1688         (MainTest.test_exit_after_n_failures_upload):
1689         (MainTest.test_exit_after_n_failures):
1690         (MainTest.test_exit_after_n_crashes):
1691         (MainTest.test_retrying_and_flaky_tests):
1692         (MainTest.test_run_order__inline):
1693         (MainTest.test_reftest_run):
1694         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
1695         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
1696         (MainTest.test_reftest_expected_html_should_be_ignored):
1697         (MainTest.test_reftest_driver_should_run_expected_html):
1698         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
1699         (MainTest.test_output_diffs):
1700         (MainTest.test_unsupported_platform):
1701         (EndToEndTest.test_end_to_end):
1702         (RebaselineTest.test_reset_results):
1703         (RebaselineTest.test_missing_results):
1704         (RebaselineTest.test_new_baseline):
1705         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1706         (BaseTest.integration_test_server__normal):
1707         (BaseTest.integration_test_server__fails):
1708         (BaseTest.integration_test_port_and_root):
1709         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1710         (TestHttpServer.test_start_cmd):
1711         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1712         (RegularTest.test_logging_not_included):
1713         (RegularTest._basic):
1714         (RegularTest.test_basic):
1715         (RegularTest.test_log_after_update):
1716         (RegularTest.test_log_args):
1717         (TtyTest.test_basic):
1718         (TtyTest.test_log_after_update):
1719         (VerboseTest.test_basic):
1720         (VerboseTest.test_log_after_update):
1721         (VerboseTest.test_log_args):
1722         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1723         (Testprinter.assertWritten):
1724         (test_test_status_line):
1725         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1726         (MainTest.assertWritten):
1727         * Scripts/webkitpy/style/checker_unittest.py:
1728         (GlobalVariablesTest.test_webkit_base_filter_rules):
1729         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1730         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1731         (CheckerDispatcherDispatchTest.assert_checker):
1732         (CheckerDispatcherDispatchTest.test_changelog_paths):
1733         (CheckerDispatcherDispatchTest.test_cpp_paths):
1734         (CheckerDispatcherDispatchTest.test_json_paths):
1735         (CheckerDispatcherDispatchTest.test_python_paths):
1736         (CheckerDispatcherDispatchTest.test_text_paths):
1737         (CheckerDispatcherDispatchTest.test_xml_paths):
1738         (StyleProcessorConfigurationTest.test_init):
1739         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
1740         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
1741         (StyleProcessor_EndToEndTest.test_init):
1742         (StyleProcessor_EndToEndTest.test_process):
1743         (StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
1744         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1745         (ChangeLogCheckerTest.assert_error.handle_style_error):
1746         (ChangeLogCheckerTest.test_init):
1747         * Scripts/webkitpy/style/checkers/common_unittest.py:
1748         (CarriageReturnCheckerTest.assert_carriage_return):
1749         (TabCheckerTest.assert_tab):
1750         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1751         (CppFunctionsTest.test_convert_to_lower_with_underscores):
1752         (CppFunctionsTest.test_create_acronym):
1753         (CppFunctionsTest.test_parameter):
1754         (CppFunctionsTest.test_single_line_view):
1755         (CppFunctionsTest.test_create_skeleton_parameters):
1756         (CppFunctionsTest.test_find_parameter_name_index):
1757         (CppFunctionsTest.test_parameter_list):
1758         (CppFunctionsTest.test_check_parameter_against_text):
1759         (CppStyleTestBase.perform_lint):
1760         (CppStyleTestBase.assert_lint):
1761         (CppStyleTestBase.assert_lint_one_of_many_errors_re):
1762         (CppStyleTestBase.assert_multi_line_lint):
1763         (CppStyleTestBase.assert_language_rules_check):
1764         (CppStyleTestBase.assert_include_what_you_use):
1765         (CppStyleTestBase.assert_blank_lines_check):
1766         (CppStyleTestBase.assert_positions_equal):
1767         (FunctionDetectionTest.perform_function_detection):
1768         (CppStyleTest.test_get_line_width):
1769         (CppStyleTest.test_find_next_multi_line_comment_start):
1770         (CppStyleTest.test_find_next_multi_line_comment_end):
1771         (CppStyleTest.test_remove_multi_line_comments_from_range):
1772         (CppStyleTest.test_position):
1773         (CppStyleTest.test_rfind_in_lines):
1774         (CppStyleTest.test_close_expression):
1775         (CppStyleTest.test_include_what_you_use_no_implementation_files):
1776         (CppStyleTest.test_include_what_you_use):
1777         (CppStyleTest.test_files_belong_to_same_module):
1778         (CppStyleTest.test_cleanse_line):
1779         (CppStyleTest.test_multiline_strings):
1780         (CppStyleTest.test_newline_at_eof.do_test):
1781         (CppStyleTest.test_invalid_utf8.do_test):
1782         (CppStyleTest.test_is_blank_line):
1783         (CppStyleTest.test_allow_blank_line_before_closing_namespace):
1784         (CppStyleTest.test_allow_blank_line_before_if_else_chain):
1785         (CppStyleTest.test_else_on_same_line_as_closing_braces):
1786         (CppStyleTest.test_build_header_guard):
1787         (CppStyleTest.test_legal_copyright):
1788         (CleansedLinesTest.test_init):
1789         (CleansedLinesTest.test_init_empty):
1790         (CleansedLinesTest.test_collapse_strings):
1791         (CheckForFunctionLengthsTest.assert_function_lengths_check):
1792         (PassPtrTest.assert_pass_ptr_check):
1793         (LeakyPatternTest.assert_leaky_pattern_check):
1794         (WebKitStyleTest.test_parameter_names):
1795         (WebKitStyleTest.test_webkit_export_check):
1796         (CppCheckerTest.test_init):
1797         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1798         (JSONCheckerTest.assert_error.handle_style_error):
1799         (JSONCheckerTest.test_init):
1800         * Scripts/webkitpy/style/checkers/png_unittest.py:
1801         (PNGCheckerTest.test_init):
1802         (PNGCheckerTest.test_check):
1803         * Scripts/webkitpy/style/checkers/python_unittest.py:
1804         (PythonCheckerTest.test_init):
1805         (PythonCheckerTest.test_check):
1806         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1807         (TestExpectationsTestCase._expect_port_for_expectations_path):
1808         (TestExpectationsTestCase.assert_lines_lint):
1809         * Scripts/webkitpy/style/checkers/text_unittest.py:
1810         (TextStyleTestCase.assertNoError):
1811         (TextStyleTestCase.assertError.error_for_test):
1812         (TextStyleTestCase.assertError):
1813         (TextCheckerTest.test_init):
1814         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1815         (WatchListTest.test_basic_error_message.handle_style_error):
1816         (WatchListTest):
1817         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1818         (XcodeProjectFileCheckerTest.assert_error):
1819         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1820         (XMLCheckerTest.assert_error.handle_style_error):
1821         (XMLCheckerTest.test_init):
1822         * Scripts/webkitpy/style/error_handlers_unittest.py:
1823         (DefaultStyleErrorHandlerTest._check_initialized):
1824         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
1825         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
1826         (DefaultStyleErrorHandlerTest.test_line_numbers):
1827         * Scripts/webkitpy/style/filereader_unittest.py:
1828         (TextFileReaderTest._assert_file_reader):
1829         (TextFileReaderTest.test_process_file__does_not_exist):
1830         (TextFileReaderTest.test_count_delete_only_file):
1831         * Scripts/webkitpy/style/filter_unittest.py:
1832         (CategoryFilterTest.test_init):
1833         (CategoryFilterTest.test_init_default_arguments):
1834         (CategoryFilterTest.test_str):
1835         (FilterConfigurationTest.test_init):
1836         (FilterConfigurationTest.test_default_arguments):
1837         * Scripts/webkitpy/style/main_unittest.py:
1838         (ChangeDirectoryTest._assert_result):
1839         * Scripts/webkitpy/style/optparser_unittest.py:
1840         (ArgumentPrinterTest.test_to_flag_string):
1841         (ArgumentParserTest.test_parse_default_arguments):
1842         (ArgumentParserTest.test_parse_explicit_arguments):
1843         (ArgumentParserTest.test_parse_files):
1844         (CommandOptionValuesTest.test_init):
1845         * Scripts/webkitpy/style/patchreader_unittest.py:
1846         (PatchReaderTest._assert_checked):
1847         * Scripts/webkitpy/test/finder_unittest.py:
1848         (FinderTest.test_additional_system_paths):
1849         (FinderTest.test_to_module):
1850         (FinderTest.check_names):
1851         * Scripts/webkitpy/test/main_unittest.py:
1852         (TesterTest.test_individual_names_are_not_run_twice):
1853         (TesterTest.test_integration_tests_are_not_found_by_default):
1854         (TesterTest.test_integration_tests_are_found):
1855         (TesterTest.integration_test_coverage_works):
1856         * Scripts/webkitpy/test/runner_unittest.py:
1857         (RunnerTest.test_run):
1858         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1859         (_expect_validate):
1860         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1861         (ExpectedFailuresTest._assert_can_trust):
1862         (ExpectedFailuresTest.test_unexpected_failures_observed):
1863         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
1864         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1865         (test_patches_with_acceptable_review_flag):
1866         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1867         (IRCCommandTest.test_whois):
1868         (IRCCommandTest.test_create_bug):
1869         (IRCCommandTest.test_roll_chromium_deps):
1870         (IRCCommandTest.test_rollout):
1871         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1872         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1873         (test_missing_unit_test_results_path):
1874         (test_layout_test_results):
1875         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1876         (LoggingDelegate.process_work_item):
1877         (LoggingDelegate.handle_unexpected_error):
1878         (QueueEngineTest.test_trivial):
1879         (QueueEngineTest.test_unexpected_error):
1880         (QueueEngineTest.test_handled_error):
1881         (QueueEngineTest._test_terminating_queue):
1882         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1883         (OpenBugsTest.test_find_bugs_in_string):
1884         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1885         (FailureReasonTest.test_blame_line_for_revision):
1886         (PrintExpectationsTest.run_test):
1887         (PrintBaselinesTest.test_basic):
1888         (PrintBaselinesTest.test_multiple):
1889         (PrintBaselinesTest.test_csv):
1890         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1891         (AbstractQueueTest.test_log_directory):
1892         (AbstractPatchQueueTest.test_next_patch):
1893         (test_auto_retry):
1894         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1895         (test_rebaseline_updates_expectations_file):
1896         (test_rebaseline_does_not_include_overrides):
1897         (test_rebaseline_test):
1898         (test_rebaseline_test_with_results_directory):
1899         (test_rebaseline_test_and_print_scm_changes):
1900         (test_rebaseline_and_copy_test):
1901         (test_rebaseline_and_copy_test_no_existing_result):
1902         (test_rebaseline_and_copy_test_with_lion_result):
1903         (test_rebaseline_and_copy_no_overwrite_test):
1904         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1905         (TestRebaselineJson.test_rebaseline_all):
1906         (TestRebaselineJson.test_rebaseline_debug):
1907         (TestRebaselineJson.test_move_overwritten):
1908         (TestRebaselineJson.test_no_optimize):
1909         (TestRebaselineJson.test_results_directory):
1910         (TestRebaseline.test_rebaseline):
1911         (TestRebaselineExpectations.test_rebaseline_expectations_noop):
1912         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
1913         (TestAnalyzeBaselines.test_default):
1914         (TestAnalyzeBaselines.test_missing_baselines):
1915         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1916         (PostRollCommandsTest.test_prepare_state):
1917         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1918         (BuildCoverageExtrapolatorTest.test_extrapolate):
1919         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
1920         (AddSvnMimetypeForPngTest.test_run):
1921         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1922         (PrepareChangeLogTest.test_ensure_bug_url):
1923         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1924         (_assert_message_for_revert_output):
1925         * TestResultServer/model/jsonresults_unittest.py:
1926         (JsonResultsTest._test_merge):
1927         (JsonResultsTest._test_get_test_list):
1928
1929 2012-11-14  János Badics  <jbadics@inf.u-szeged.hu>
1930
1931         [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
1932         https://bugs.webkit.org/show_bug.cgi?id=102083
1933
1934         Reviewed by Csaba Osztrogonác.
1935
1936         Modified compiler name regex in condition that tests if -std=c++0x, c++11,
1937         gnu++0x or gnu++11 are enabled in order to match linux-arm-gnueabi-g++ too,
1938         thus enabling -Wno-c++0x-compat also on ARM compiler.
1939
1940         * qmake/mkspecs/features/unix/default_post.prf:
1941
1942 2012-11-14  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1943
1944         REGRESSION(r133757): Causing webkitpy unit tests to fail
1945         https://bugs.webkit.org/show_bug.cgi?id=101444
1946
1947         Reviewed by Csaba Osztrogonác.
1948
1949         Updated the bot name on the unit tests.
1950
1951         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1952         (TestRebaselineTest.test_baseline_directory):
1953
1954 2012-11-14  Byungwoo Lee  <bw80.lee@samsung.com>
1955
1956         [EFL][WK2] Rename variables, structures and functions of the MiniBrowser.
1957         https://bugs.webkit.org/show_bug.cgi?id=101517
1958
1959         Reviewed by Gyuyoung Kim.
1960
1961         Rename variables, structures and functions of the MiniBrowser
1962         for the naming consistency.
1963
1964         1) Browser_Window* {app_data|browser_window|window} -> window
1965
1966         2) Browser_Window::webview -> Browser_Window::ewk_view
1967              The webkit API functions are ewk_view_xxx not webview_xxx.
1968              So using ewk_view will be better than webview.
1969
1970         3) Browser_Window::window -> Browser_Window::elm_window
1971              The name is changed to be distinguished with 'Browser_Window *window'
1972
1973         4) browser_{window|view}_find() -> window_find_with_{elm_window|ewk_view}()
1974              This is changed because the name of the function can be confused.
1975              Currently, browser_window_find() returns Browser_Window*. And
1976              browser_view_find() also returns Browser_Window*.
1977
1978         5) FileSelectorData -> File_Selector_Data / AuthData -> Auth_Data
1979              The type definition is moved to the top of the source file
1980              and the name is changed to follow EFL style.
1981
1982         * MiniBrowser/efl/main.c:
1983         (miniBrowserViewSmartClass):
1984         (_Browser_Window):
1985         (_File_Selector_Data):
1986         (_Auth_Data):
1987         (window_find_with_ewk_view):
1988         (window_free):
1989         (on_key_down):
1990         (view_focus_set):
1991         (on_mouse_down):
1992         (title_set):
1993         (on_title_changed):
1994         (on_url_changed):
1995         (on_back_forward_list_changed):
1996         (on_new_window):
1997         (on_close_window):
1998         (on_progress):
1999         (on_error):
2000         (on_download_request):
2001         (close_file_picker):
2002         (on_filepicker_parent_deletion):
2003         (on_filepicker_deletion):
2004         (on_fileselector_done):
2005         (on_file_chooser_request):
2006         (on_download_finished):
2007         (on_download_failed):
2008         (on_favicon_received):
2009         (on_view_icon_changed):
2010         (on_url_bar_activated):
2011         (on_url_bar_clicked):
2012         (on_back_button_clicked):
2013         (on_forward_button_clicked):
2014         (on_refresh_button_clicked):
2015         (on_javascript_alert):
2016         (on_javascript_confirm):
2017         (on_javascript_prompt):
2018         (on_window_geometry_get):
2019         (on_window_geometry_set):
2020         (on_fullscreen_deny):
2021         (on_fullscreen_enter):
2022         (on_fullscreen_exit):
2023         (auth_popup_close):
2024         (on_auth_cancel):
2025         (on_auth_ok):
2026         (on_authentication_request):
2027         (on_tooltip_text_set):
2028         (on_tooltip_text_unset):
2029         (on_home_button_clicked):
2030         (on_window_deletion):
2031         (window_create):
2032
2033 2012-11-14  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2034
2035         webkitpy: Update the EFL list of bots
2036         https://bugs.webkit.org/show_bug.cgi?id=102121
2037
2038         Reviewed by Kenneth Rohde Christiansen.
2039
2040         Update the EFL bots so we can use garden-o-matic.
2041
2042         * Scripts/webkitpy/layout_tests/port/builders.py:
2043
2044 2012-11-13  Yael Aharon  <yael.aharon@intel.com>
2045
2046         [EFL][WK2] New window size should consult the window attributes
2047         https://bugs.webkit.org/show_bug.cgi?id=102122
2048
2049         Reviewed by Kenneth Rohde Christiansen.
2050
2051         Take into account the size that was specified in window.open
2052         when creating a new window. This avoids ugly flashing on the screen.
2053
2054         * MiniBrowser/efl/main.c:
2055         (on_key_down):
2056         (on_new_window):
2057         (window_create):
2058         (elm_main):
2059
2060 2012-11-13  Dana Jansens  <danakj@chromium.org>
2061
2062         [chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport
2063         https://bugs.webkit.org/show_bug.cgi?id=102146
2064
2065         Reviewed by James Robinson.
2066
2067         Pass settings that go through WebCompositorSupport also through
2068         WebLayerTreeSettings. When the compositor starts using those instead,
2069         we can remove the callers to the WebCompositorSupport setters.
2070
2071         * DumpRenderTree/chromium/TestShell.cpp:
2072         (TestShell::TestShell):
2073         (TestShell::resetWebSettings):
2074         (TestShell::setPerTilePaintingEnabled):
2075         (TestShell::setAcceleratedAnimationEnabled):
2076         * DumpRenderTree/chromium/TestShell.h:
2077         (TestShell):
2078         * DumpRenderTree/chromium/WebPreferences.cpp:
2079         (WebPreferences::applyTo):
2080         * DumpRenderTree/chromium/WebPreferences.h:
2081         (WebPreferences):
2082
2083 2012-11-13  Kentaro Hara  <haraken@chromium.org>
2084
2085         Unreviewed, rolling out r134503.
2086         http://trac.webkit.org/changeset/134503
2087
2088         Roll out a patch that was landed just to investigate svn
2089         trouble
2090
2091         * Scripts/webkitpy/common/config/committers.py:
2092
2093 2012-11-13  Kentaro Hara  <haraken@chromium.org>
2094
2095         Unreviewed. Investigating svn trouble. Test commit.
2096
2097         * Scripts/webkitpy/common/config/committers.py:
2098
2099 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2100
2101         Unreviewed, rolling out r134446.
2102         http://trac.webkit.org/changeset/134446
2103         https://bugs.webkit.org/show_bug.cgi?id=101968
2104
2105         Need to try a different strategy for landing a two-sided patch
2106         (3/3).
2107
2108         * DumpRenderTree/chromium/TestShell.cpp:
2109         (TestShell::TestShell):
2110         (TestShell::resetWebSettings):
2111         (TestShell::setPerTilePaintingEnabled):
2112         (TestShell::setAcceleratedAnimationEnabled):
2113         * DumpRenderTree/chromium/TestShell.h:
2114         (TestShell):
2115         * DumpRenderTree/chromium/WebPreferences.cpp:
2116         (WebPreferences::applyTo):
2117         * DumpRenderTree/chromium/WebPreferences.h:
2118         (WebPreferences):
2119
2120 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2121
2122         Unreviewed, rolling out r134449.
2123         http://trac.webkit.org/changeset/134449
2124         https://bugs.webkit.org/show_bug.cgi?id=102076
2125
2126         Re-rolling in the patch, it was innocent.
2127
2128         * TestWebKitAPI/PlatformEfl.cmake:
2129
2130 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2131
2132         Unreviewed, rolling out r134424.
2133         http://trac.webkit.org/changeset/134424
2134         https://bugs.webkit.org/show_bug.cgi?id=102076
2135
2136         Made fast/dom/Window/open-window-min-size.html crash.
2137
2138         * TestWebKitAPI/PlatformEfl.cmake:
2139
2140 2012-11-12  Dana Jansens  <danakj@chromium.org>
2141
2142         [chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
2143         https://bugs.webkit.org/show_bug.cgi?id=101968
2144
2145         Reviewed by James Robinson.
2146
2147         * DumpRenderTree/chromium/TestShell.cpp:
2148         (TestShell::TestShell):
2149         (TestShell::resetWebSettings):
2150         * DumpRenderTree/chromium/TestShell.h:
2151         (TestShell::setPerTilePaintingEnabled):
2152         (TestShell::setAcceleratedAnimationEnabled):
2153         (TestShell):
2154         * DumpRenderTree/chromium/WebPreferences.cpp:
2155         (WebPreferences::applyTo):
2156         * DumpRenderTree/chromium/WebPreferences.h:
2157         (WebPreferences):
2158
2159 2012-11-13  Dirk Pranke  <dpranke@chromium.org>
2160
2161         Fix webkitpy issues arising from a partially-installed pylint.
2162         Unreviewed, build fix.
2163
2164         This patch ensures that we will re-install the pylint and logilab
2165         packages if any of them are missing, not just the pylint package.
2166
2167         * Scripts/webkitpy/thirdparty/__init__.py:
2168         (AutoinstallImportHook._install_pylint):
2169
2170 2012-11-13  No'am Rosenthal  <noam.rosenthal@nokia.com>
2171
2172         Unreviewed, adding my new email address to committers.py and watchlist.
2173
2174         * Scripts/webkitpy/common/config/committers.py:
2175         * Scripts/webkitpy/common/config/watchlist:
2176
2177 2012-11-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2178
2179         [CMake] Incorrect dependency calculation when generating forwarding headers
2180         https://bugs.webkit.org/show_bug.cgi?id=102076
2181
2182         Reviewed by Kenneth Rohde Christiansen.
2183
2184         Explicitly call generate-forwarding-headers.pl on ${WEBKIT2_DIR} as
2185         well, since some dependencies pulled in via the WebKit2/WebKit2_C.h
2186         include in config.h are only generated from there.
2187
2188         This is a bit redundant since this is also done in WebKit2's
2189         PlatformEfl.cmake, however the WTF and WebCore API tests do not depend
2190         on WebKit2 so the script may not have been called when these tests are
2191         being built.
2192
2193         * TestWebKitAPI/PlatformEfl.cmake:
2194
2195 2012-11-13  Zeno Albisser  <zeno@webkit.org>
2196
2197         Unreviewed: Adding watchlist definition for CoordinatedGraphics.
2198
2199         * Scripts/webkitpy/common/config/watchlist:
2200
2201 2012-11-13  Hugo Parente Lima  <hugo.lima@openbossa.org>
2202
2203         [cmake] Do not use GLOB to add WTR IDL files to buildsystem.
2204         https://bugs.webkit.org/show_bug.cgi?id=101785
2205
2206         Reviewed by Caio Marcelo de Oliveira Filho.
2207
2208         Using *.idl makes impossible to add IDL files depending on compiler flags,
2209         like a possible GamepadController.idl file found on Chromium.
2210
2211         * WebKitTestRunner/CMakeLists.txt:
2212
2213 2012-11-13  Jochen Eisinger  <jochen@chromium.org>
2214
2215         [chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself
2216         https://bugs.webkit.org/show_bug.cgi?id=102075
2217
2218         Reviewed by Pavel Feldman.
2219
2220         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2221
2222 2012-11-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2223
2224         [EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventSender.
2225         https://bugs.webkit.org/show_bug.cgi?id=102074
2226
2227         Reviewed by Kenneth Rohde Christiansen.
2228
2229         * DumpRenderTree/efl/EventSender.cpp:
2230         (feedMouseEvent): Do not call DumpRenderTreeSupportEfl::layoutFrame()
2231         when sending an event, as it causes additional repaints that create
2232         wrong pixel results for tests such as
2233         fast/repaint/overflow-auto-in-overflow-auto-scrolled.html.
2234
2235 2012-11-13  Csaba Osztrogonác  <ossy@webkit.org>
2236
2237         [Qt] Enable Mutation observer
2238         https://bugs.webkit.org/show_bug.cgi?id=102066
2239
2240         Reviewed by Pavel Feldman.
2241
2242         * qmake/mkspecs/features/features.pri:
2243
2244 2012-11-13  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2245
2246         [BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html failed
2247         https://bugs.webkit.org/show_bug.cgi?id=102056
2248
2249         Reviewed by Rob Buis.
2250
2251         RIM PR 235836
2252
2253         TestRunner::findString() was changed to call Page::findString() instead
2254         of WebPage::findNextString(). Page::findString() doesn't update
2255         TextMatch markers.
2256         Work-around by calling both Page::findString() and WebPage::findNextString().
2257
2258         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2259         (TestRunner::findString):
2260
2261 2012-11-12  Jochen Eisinger  <jochen@chromium.org>
2262
2263         Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
2264         https://bugs.webkit.org/show_bug.cgi?id=101957
2265
2266         Reviewed by Adam Barth.
2267
2268         Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply.
2269
2270         * Scripts/webkitpy/common/config/watchlist:
2271
2272 2012-11-13  Jochen Eisinger  <jochen@chromium.org>
2273
2274         [chromium] move tracking of damaged regions from WebViewHost to WebTestProxy
2275         https://bugs.webkit.org/show_bug.cgi?id=101927
2276
2277         Reviewed by Adam Barth.
2278
2279         This will allow for sharing the code with content_shell
2280
2281         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2282         (DRTTestRunner::display):
2283         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2284         (WebKit):
2285         (WebTestProxyBase):
2286         (WebTestRunner::WebTestProxy::didInvalidateRect):
2287         (WebTestRunner::WebTestProxy::didScrollRect):
2288         (WebTestRunner::WebTestProxy::scheduleComposite):
2289         (WebTestRunner::WebTestProxy::scheduleAnimation):
2290         (WebTestRunner::WebTestProxy::setWindowRect):
2291         (WebTestRunner::WebTestProxy::show):
2292         (WebTestRunner::WebTestProxy::didAutoResize):
2293         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2294         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2295         (WebTestRunner::WebTestProxyBase::setPaintRect):
2296         (WebTestRunner):
2297         (WebTestRunner::WebTestProxyBase::paintRect):
2298         (WebTestRunner::WebTestProxyBase::didInvalidateRect):
2299         (WebTestRunner::WebTestProxyBase::didScrollRect):
2300         (WebTestRunner::WebTestProxyBase::scheduleComposite):
2301         (WebTestRunner::WebTestProxyBase::scheduleAnimation):
2302         (WebTestRunner::WebTestProxyBase::show):
2303         (WebTestRunner::WebTestProxyBase::setWindowRect):
2304         (WebTestRunner::WebTestProxyBase::didAutoResize):
2305         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2306         * DumpRenderTree/chromium/TestShell.cpp:
2307         (TestShell::createNewWindow):
2308         * DumpRenderTree/chromium/WebViewHost.cpp:
2309         (WebViewHost::scheduleAnimation):
2310         (WebViewHost::show):
2311         (WebViewHost::setWindowRect):
2312         (WebViewHost::WebViewHost):
2313         (WebViewHost::proxy):
2314         (WebViewHost::setProxy):
2315         (WebViewHost::reset):
2316         (WebViewHost::paintInvalidatedRegion):
2317         * DumpRenderTree/chromium/WebViewHost.h:
2318         (WebViewHost):
2319
2320 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2321
2322         webkitpy: clean up lint errors, part 1
2323         https://bugs.webkit.org/show_bug.cgi?id=102024
2324
2325         Reviewed by Adam Barth.
2326
2327         This patch cleans up a lot of miscellaneous minor lint errors that
2328         apparently aren't caught by unit tests, and suppresses a few
2329         false positives.
2330
2331         Also, this patch removes the garden-o-matic "rollout" entry point
2332         since it's no longer being used by the frontend (rather than
2333         fix it to not generate lint errors).
2334
2335         * Scripts/webkitpy/common/system/executive_mock.py:
2336         (MockExecutive2.run_command):
2337         * Scripts/webkitpy/common/system/filesystem_mock.py:
2338         (MockFileSystem.copyfile):
2339         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2340         (Manager._http_tests):
2341         * Scripts/webkitpy/layout_tests/port/apple.py:
2342         (ApplePort):
2343         * Scripts/webkitpy/layout_tests/port/base.py:
2344         (Port.reference_files):
2345         * Scripts/webkitpy/layout_tests/port/chromium.py:
2346         (ChromiumPort):
2347         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2348         (ChromiumAndroidDriver._teardown_performance):
2349         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2350         (ChromiumPortTestCase.TestAndroidPort.__init__):
2351         (ChromiumPortTestCase.test_default_configuration):
2352         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2353         (PortTestCase):
2354         (PortTestCase.test_driver_cmd_line):
2355         (PortTestCase.test_expectations_ordering):
2356         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2357         (HttpServerBase._check_that_all_ports_are_available):
2358         * Scripts/webkitpy/style/checkers/python.py:
2359         (Pylinter):
2360         * Scripts/webkitpy/tool/commands/gardenomatic.py:
2361         (GardenOMatic.__init__):
2362         * Scripts/webkitpy/tool/commands/queues.py:
2363         (CommitQueue):
2364         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2365         (GardeningHTTPRequestHandler):
2366         (GardeningHTTPRequestHandler.localresult):
2367
2368 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2369
2370         webkitpy: clean up lint errors, part 2
2371         https://bugs.webkit.org/show_bug.cgi?id=102029
2372
2373         Reviewed by Adam Barth.
2374
2375         This cleans up the remaining lint errors in webkitpy with four exceptions:
2376         1) we don't lint thirdparty/ autoinstalled code, obviously
2377         2) there's an intentional error in the unit tests for pylint itself
2378         3) the implementation of webkit-patch optimize-expectations has
2379         an error but I think we can and should just remove that command as well.
2380         4) I have not yet linted the test code
2381
2382         * Scripts/webkitpy/common/newstringio.py:
2383         * Scripts/webkitpy/common/checkout/scm/scm.py:
2384         (SCM.find_checkout_root):
2385         (SCM.will.remote_merge_base):
2386         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2387         * Scripts/webkitpy/common/checkout/scm/svn.py:
2388         (SVNRepository.has_authorization_for_realm):
2389         (SVN.__init__):
2390         * Scripts/webkitpy/common/config/contributionareas.py:
2391         (ContributionAreas.names):
2392         * Scripts/webkitpy/common/config/ports.py:
2393         (DeprecatedPort):
2394         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2395         (Builder.force_build):
2396         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2397         * Scripts/webkitpy/style/checkers/cpp.py:
2398         (check_posix_threading):
2399         (check_spacing):
2400         * Scripts/webkitpy/style/optparser.py:
2401         (ArgumentParser._create_option_parser):
2402         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2403         (AbstractLocalServerCommand.execute):
2404         * Scripts/webkitpy/tool/commands/download.py:
2405         (AbstractPatchProcessingCommand):
2406         (AbstractPatchProcessingCommand._process_patch):
2407         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2408         (AbstractEarlyWarningSystem):
2409
2410 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2411
2412         remove 'webkit-patch optimize-expectations'
2413         https://bugs.webkit.org/show_bug.cgi?id=102032
2414
2415         Reviewed by Adam Barth.
2416
2417         Removing this command because it is totally broken (probably
2418         broke when I added support for multiple files in a cascade)
2419         and doesn't seem to do anything much useful. It certainly
2420         didn't actually optimize things.
2421
2422         * Scripts/webkitpy/tool/commands/expectations.py: Removed.
2423
2424 2012-11-12  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2425
2426         [BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
2427         https://bugs.webkit.org/show_bug.cgi?id=101894
2428
2429         Reviewed by Rob Buis.
2430
2431         RIM PR 241686
2432         Also remove an un-needed pixel lock, and fix a klocwork error in SKIA
2433         code path.
2434
2435         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2436         (readPixelsUserInterfaceThread):
2437         (createBitmapContextFromWebView):
2438
2439 2012-11-12  Daniel Bates  <dbates@webkit.org>
2440
2441         Perl errors from Tools/Scripts/copy-webkitlibraries-to-product-directory
2442         https://bugs.webkit.org/show_bug.cgi?id=101980
2443
2444         Reviewed by Mark Rowe.
2445
2446         Remove library libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceSnowLeopard.a
2447         from the list of libraries to copy to the specified built products directory
2448         as these libraries were removed from the repository in <http://trac.webkit.org/changeset/133670>.
2449
2450         * Scripts/copy-webkitlibraries-to-product-directory:
2451
2452 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2453
2454         webkitpy: integrate pylint into check-webkit-style, part I
2455         https://bugs.webkit.org/show_bug.cgi?id=101285
2456
2457         Reviewed by Ojan Vafai.
2458
2459         This patch re-works lint-webkitpy so that the logic is pushed
2460         into check-webkit-style (mostly); we don't yet control which
2461         messages are displayed using the rules in webkitpy/style/checker.py
2462         (we're still using the pylintrc to suppress messages instead),
2463         but otherwise things work. For now we will only report pylint
2464         "errors", not warnings.
2465
2466         * Scripts/lint-webkitpy:
2467         * Scripts/webkitpy/style/checker.py:
2468         * Scripts/webkitpy/style/checkers/python.py:
2469         (PythonChecker):
2470         (PythonChecker.check):
2471         (PythonChecker._check_pep8):
2472         (PythonChecker._check_pylint):
2473         (Pylinter):
2474         (Pylinter.__init__):
2475         (Pylinter.run):
2476         (_FilteredStringIO):
2477         (_FilteredStringIO.__init__):
2478         (_FilteredStringIO.write):
2479         (_FilteredStringIO._filter):
2480         * Scripts/webkitpy/style/checkers/python_unittest.py:
2481         (PythonCheckerTest.test_check):
2482         * Scripts/webkitpy/style/checkers/python_unittest_input.py:
2483
2484 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2485
2486         nrwt: remove a bunch of broken chromium-specific flags
2487         https://bugs.webkit.org/show_bug.cgi?id=101979
2488
2489         Reviewed by Tony Chang.
2490
2491         There were a bunch of chromium-specific flags that used to be
2492         supported by NRWT (and handled and passed on to DRT) but have
2493         probably been broken for a long time and are currently ignored.
2494
2495         This patch removes all of those flags; the rule of thumb going forward
2496         is that we should only add flags that affect how the python code functions.
2497         If a flag is just passed verbatim to DRT, the user can use --additional-drt-flag
2498         for that.
2499
2500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2501         (parse_args):
2502         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2503         (MainTest.setUp):
2504
2505 2012-11-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2506
2507         [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
2508         https://bugs.webkit.org/show_bug.cgi?id=101930
2509
2510         Reviewed by Kenneth Rohde Christiansen.
2511
2512         Added --device-pixel-ratio command line option to EFL MiniBrowser which sets
2513         the ratio between the CSS units and device pixels when the content is unscaled.
2514         Option is applied for all the views created by mini browser.
2515
2516         * MiniBrowser/efl/main.c:
2517         (window_create):
2518         (elm_main):
2519
2520 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2521
2522         remove the chromium-mac-mountainlion TestExpectations file
2523         https://bugs.webkit.org/show_bug.cgi?id=101789
2524
2525         Reviewed by Ojan Vafai.
2526
2527         Nearly all of the tests have been updated for 10.8 and the remaining
2528         failures have been merged into the main TestExpectations file. We
2529         don't need this hook any more.
2530
2531         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2532         (ChromiumMacPort.operating_system):
2533         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2534         (ChromiumMacPortTest.test_path_to_image_diff):
2535
2536 2012-11-12  Peter Beverloo  <peter@chromium.org>
2537
2538         [Chromium-Android] Restart the device's shell in root before pushing data
2539         https://bugs.webkit.org/show_bug.cgi?id=101944
2540
2541         Reviewed by Adam Barth.
2542
2543         Setting up md5sum and pushing the executable, fonts and test resources was
2544         unintentionally being done prior to executing the "adb root" command,
2545         which restarts the device's shell to be root. Since test data is still
2546         being pushed to /data/local/tmp, writing to which requires root access,
2547         devices not running as root would throw a ScriptError.
2548
2549         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2550         (ChromiumAndroidDriver._setup_test):
2551
2552 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2553
2554         [Qt] Support ResourceRequest's setTimeoutInterval
2555         https://bugs.webkit.org/show_bug.cgi?id=101731
2556
2557         Reviewed by Simon Hausmann.
2558
2559         Enable XHR_TIMEOUT now that we support the necessary feature.
2560
2561         * qmake/mkspecs/features/features.pri:
2562
2563 2012-11-12  Gustavo Noronha Silva  <gns@gnome.org>
2564
2565         Unreviewed. Removing myself from the list of address to CC on EWS
2566         build failure; the CC turned out to just be too noisy so I'm
2567         tracking those in a different way.
2568
2569         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2570         (GtkEWS):
2571
2572 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2573
2574         [Qt] Can not load MHTML documents
2575         https://bugs.webkit.org/show_bug.cgi?id=101765
2576
2577         Reviewed by Simon Hausmann.
2578
2579         Enable MHTML feature.
2580
2581         * qmake/mkspecs/features/features.pri:
2582
2583 2012-11-12  Tommy Widenflycht  <tommyw@google.com>
2584
2585         MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
2586         https://bugs.webkit.org/show_bug.cgi?id=101751
2587
2588         Reviewed by Adam Barth.
2589
2590         Makes the data channel mocks to be synchronous instead of asynchronous to be able to
2591         properly test RTCDataChannel event handling.
2592
2593         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2594         (MockWebRTCPeerConnectionHandler::sendStringData):
2595         (MockWebRTCPeerConnectionHandler::sendRawData):
2596
2597 2012-11-12  Jochen Eisinger  <jochen@chromium.org>
2598
2599         [chromium] move TestRunner implementation into WebTestRunner namespace
2600         https://bugs.webkit.org/show_bug.cgi?id=101837
2601
2602         Reviewed by Adam Barth.
2603
2604         That way, we don't get collisions when linking e.g. against chromium's
2605         net test support library.
2606
2607         * DumpRenderTree/chromium/DRTTestRunner.h:
2608         (DRTTestRunner):
2609         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
2610         (WebTestRunner):
2611         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2612         (WebTestRunner):
2613         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2614         (WebTestRunner):
2615         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
2616         (WebTestRunner):
2617         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
2618         (WebTestRunner):
2619         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
2620         (WebTestRunner):
2621         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2622         (WebTestRunner):
2623         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2624         (WebTestRunner):
2625         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
2626         (WebTestRunner):
2627         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
2628         (WebTestRunner):
2629         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2630         (WebTestRunner):
2631         (TestDelegate):
2632         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2633         (WebTestRunner):
2634         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2635         (WebTestRunner):
2636         (TestInterfaces):
2637         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2638         (WebTestRunner):
2639         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2640         (WebTestRunner):
2641         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
2642         (WebTestRunner):
2643         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h:
2644         (WebTestRunner):
2645
2646 2012-11-12  Zeno Albisser  <zeno@webkit.org>
2647
2648         [Qt] MiniBrowser should not strongly depend on QtTestSupport.
2649         https://bugs.webkit.org/show_bug.cgi?id=101775
2650
2651         Introducing HAVE(QTTESTSUPPORT) to allow building
2652         MiniBrowser without QtTestSupport.
2653         This is necessary when using a production build.
2654
2655         Reviewed by Tor Arne Vestbø.
2656
2657         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2658         (MiniBrowserApplication::handleUserOptions):
2659         * qmake/mkspecs/features/configure.prf:
2660         * qmake/mkspecs/features/features.prf:
2661
2662 2012-11-11  Kangil Han  <kangil.han@samsung.com>
2663
2664         Change build congratulation message in EFL
2665         https://bugs.webkit.org/show_bug.cgi?id=101833
2666
2667         Reviewed by Gyuyoung Kim.
2668
2669         EFL port is currently supporting both WK1 and WK2.
2670         But, build congratulation message still shows WK1(EWebLauncher) only.
2671         Therefore, this patch adopts WK2 reference execution(MiniBrowser) in its message.
2672
2673         From 'To run EWebLauncher with this newly-built code, use the'
2674         to 'To run EWebLauncher/MiniBrowser with this newly-built code, use the'.
2675
2676         * Scripts/build-webkit:
2677         (writeCongrats):
2678         * Scripts/webkitdirs.pm:
2679         (launcherName):
2680
2681 2012-11-09  Ryosuke Niwa  <rniwa@webkit.org>
2682
2683         People with dichromacy can't tell crashes and passes on flakiness dashboard
2684         https://bugs.webkit.org/show_bug.cgi?id=101711
2685
2686         Reviewed by Ojan Vafai.
2687
2688         Lower the brightness of orange, and raise the brightness of green so that
2689         people with color blindnes can still distinguish passes and crashes easily.
2690
2691         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
2692         (.P):
2693         (.C):
2694
2695 2012-11-09  Tommy Widenflycht  <tommyw@google.com>
2696
2697         MediaStream API: Deleting all files relating to the deprecated PeerConnection00
2698         https://bugs.webkit.org/show_bug.cgi?id=101730
2699
2700         Reviewed by Adam Barth.
2701
2702         Since RTCPeerConenction has superseeded PeerConnection00 this patch removes all
2703         files relating to the old API.
2704
2705         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2706         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2707         (MockWebMediaStreamCenter):
2708         * DumpRenderTree/chromium/TestShell.cpp:
2709         (TestShell::TestShell):
2710
2711 2012-11-09  Yael Aharon  <yael.aharon@intel.com>
2712
2713         [EFL] Give the view a size in TestWebKitAPI
2714         https://bugs.webkit.org/show_bug.cgi?id=101770
2715
2716         Reviewed by Laszlo Gombos.
2717
2718         2 tests are currently failing, because they expect us to paint, but we don't paint if the view size is empty.
2719
2720         * TestWebKitAPI/efl/PlatformWebView.cpp:
2721         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2722         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2723         (TestWebKitAPI):
2724         (TestWebKitAPI::PlatformWebView::resizeTo):
2725
2726 2012-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2727
2728         Unreviewed, rolling out r134068.
2729         http://trac.webkit.org/changeset/134068
2730         https://bugs.webkit.org/show_bug.cgi?id=101766
2731
2732         Caused crashes on the bots. (Requested by rakuco on #webkit).
2733
2734         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2735         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2736
2737 2012-11-09  Zan Dobersek  <zandobersek@gmail.com>
2738
2739         [GTK] Bump the jhbuild Cairo version to 1.12.8
2740         https://bugs.webkit.org/show_bug.cgi?id=101721
2741
2742         Bump the Cairo version in Jhbuild moduleset to 1.12.8. This version
2743         should fix multiple failures in canvas tests and also contains
2744         fixes for X-related crashes that occurred from the 1.12.4 version onwards.
2745
2746         * gtk/jhbuild.modules:
2747
2748 2012-11-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2749
2750         [WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
2751         https://bugs.webkit.org/show_bug.cgi?id=101759
2752
2753         Reviewed by Kenneth Rohde Christiansen.
2754
2755         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2756         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
2757         the check for an empty repaintRect -- we need to check if the
2758         WKArrayRef has any items. `if (repaintRect)' will return true
2759         regardless of whether the array is empty or not.
2760
2761
2762 2012-11-09  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2763
2764         [Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources
2765
2766         Having DerivedSources.pri in the watchlist regexp was creating too much
2767         noise.
2768
2769         Reviewed by Ossy.
2770
2771         * Scripts/webkitpy/common/config/watchlist:
2772
2773 2012-11-09  Dominik Röttsches  <dominik.rottsches@intel.com>
2774
2775         webkitpy/layouttests integration test fails if high shards/processes environment variables are used
2776         https://bugs.webkit.org/show_bug.cgi?id=101455
2777
2778         Reviewed by Dirk Pranke.
2779
2780         Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.
2781
2782         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2783         (MainTest.test_max_locked_shards):
2784
2785 2012-11-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2786
2787         [EFL][DRT] Force a repaint before tracking repaint rects.
2788         https://bugs.webkit.org/show_bug.cgi?id=101743
2789
2790         Reviewed by Kenneth Rohde Christiansen.
2791
2792         Do like other ports and force a repaint before we start tracking
2793         repaints so that the pixel results generated look more in line
2794         with what's expected.
2795
2796         * DumpRenderTree/efl/DumpRenderTree.cpp:
2797         (displayWebView): Call DRTSupport::forceLayout() before start
2798         tracking repaints.
2799
2800 2012-11-09  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2801
2802         [BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key
2803         https://bugs.webkit.org/show_bug.cgi?id=100937
2804
2805         Reviewed by Rob Buis.
2806
2807         1. Translate these keys to their corresponding BlackBerry key code.
2808         2. Break down a KeyChar event to a KeyDown/KeyUp pair. This is required
2809         because we only handle scrolling on a KeyDown event in WebPage::keyEvent()
2810         , and internally a KeyChar event is interpreted as a KeyDown event + a
2811         KeyUp event in InputHandler::handleKeyboardInput().
2812
2813         Tests fixed:
2814         1. editing/input/scroll-viewport-page-up-down.html
2815         2. editing/selection/move-begin-end.html
2816         3. fast/forms/select-popup-pagekeys.html
2817
2818         * DumpRenderTree/blackberry/EventSender.cpp:
2819         (keyDownCallback):
2820
2821 2012-11-09  Simon Hausmann  <simon.hausmann@digia.com>
2822
2823         Unreviewed prospective Qt/Windows build bot fix:
2824
2825         Make determination of qmake mkspec work with older versions of Qt that
2826         still create a "mkspecs/default" directory.
2827
2828         * Scripts/webkitdirs.pm:
2829         (qtMakeCommand):
2830
2831 2012-11-09  Jochen Eisinger  <jochen@chromium.org>
2832
2833         [chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests
2834         https://bugs.webkit.org/show_bug.cgi?id=101452
2835
2836         Reviewed by Adam Barth.
2837
2838         The WebTestProxy is template, so it can derive from an implementation
2839         of the WebViewClient interface. That way, WebTestProxy can hook into
2840         individual methods of the WebViewClient and forward all the rest to the
2841         actual implementation.
2842
2843         To demonstrate how I want to use this, I moved the
2844         postAccessibilityNotification method from WebViewHost to WebTestProxy.
2845
2846         * DumpRenderTree/DumpRenderTree.gypi:
2847         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added.
2848         (WebKit):
2849         (WebTestRunner):
2850         (WebTestProxyBase):
2851         (WebTestProxy):
2852         (WebTestRunner::WebTestProxy::WebTestProxy):
2853         (WebTestRunner::WebTestProxy::~WebTestProxy):
2854         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2855         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added.
2856         (WebTestRunner):
2857         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
2858         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2859         (WebTestRunner::WebTestProxyBase::setInterfaces):
2860         (WebTestRunner::WebTestProxyBase::setDelegate):
2861         (WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification):
2862         * DumpRenderTree/chromium/TestShell.cpp:
2863         (TestShell::createNewWindow):
2864         * DumpRenderTree/chromium/WebViewHost.cpp:
2865         * DumpRenderTree/chromium/WebViewHost.h:
2866         (WebViewHost):
2867
2868 2012-11-09  Simon Hausmann  <simon.hausmann@digia.com>
2869
2870         [Qt] Build with MSVC fails to use nmake instead of make
2871         https://bugs.webkit.org/show_bug.cgi?id=98645
2872
2873         Reviewed by Tor Arne Vestbø.
2874
2875         Don't rely on the "default" mkspec but instead query the target
2876         mkspec variable from qmake to find the right qmake.conf.
2877
2878         * Scripts/webkitdirs.pm:
2879         (qtMakeCommand):
2880
2881 2012-11-08  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2882
2883         [EFL] about:blank should display the blank page
2884         https://bugs.webkit.org/show_bug.cgi?id=101566
2885
2886         Reviewed by Laszlo Gombos.
2887
2888         Add a check to return early without prepending http:// scheme, if the
2889         URL is 'about:blank'.
2890
2891         * EWebLauncher/url_utils.c:
2892         (url_from_user_input):
2893
2894 2012-11-08  Christophe Dumez  <christophe.dumez@intel.com>
2895
2896         [EFL][WK2] Add proper support for fullscreen API to MiniBrowser
2897         https://bugs.webkit.org/show_bug.cgi?id=101615
2898
2899         Reviewed by Kenneth Rohde Christiansen.
2900
2901         Implement fullscreen API support in MiniBrowser. When entering
2902         fullscreen a popup is shown to notify the user that something
2903         is displayed in fullscreen and to advertise that the Escape
2904         key can be used to exit fullscreen. This behavior is according
2905         to specification.
2906
2907         * MiniBrowser/efl/main.c:
2908         (on_key_down):
2909         (on_fullscreen_accept):
2910         (on_fullscreen_deny):
2911         (on_fullscreen_enter):
2912         (on_fullscreen_exit):
2913         (window_create):
2914
2915 2012-11-08  Slavomir Kaslev  <skaslev@google.com>
2916
2917         [Chromium] DumpRenderTree fix for canvas in software compositing
2918         https://bugs.webkit.org/show_bug.cgi?id=101509
2919
2920         Reviewed by Adrienne Walker.
2921
2922         Don't use accelerated canvas 2d when in software compositing mode.
2923
2924         * DumpRenderTree/chromium/TestShell.cpp:
2925         (TestShell::runFileTest):
2926
2927 2012-11-08  Jakob Petsovits  <jpetsovits@rim.com>
2928
2929         [BlackBerry] Rework the API to use document coordinates
2930         https://bugs.webkit.org/show_bug.cgi?id=101608
2931         RIM PR 173292
2932
2933         Reviewed by Adam Treat.
2934
2935         Adapt to changed WebPage API.
2936         See Source/WebKit/blackberry/ChangeLog for details.
2937
2938         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2939         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
2940         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2941
2942 2012-11-08  Yael Aharon  <yael.aharon@intel.com>
2943
2944         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
2945         https://bugs.webkit.org/show_bug.cgi?id=101526
2946
2947         Reviewed by Kenneth Rohde Christiansen.
2948
2949         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
2950
2951         * Scripts/webkitperl/FeatureList.pm:
2952
2953 2012-11-08  Simon Hausmann  <simon.hausmann@digia.com>
2954
2955         [Qt] Fix build with MSVC 2012 and Angle
2956         https://bugs.webkit.org/show_bug.cgi?id=101588
2957
2958         Reviewed by Tor Arne Vestbø.
2959
2960         Angle includes STL's <memory> header file, which with MSVC 2012 includes stdint.h. MSVC 2012
2961         does ship stdint.h, but it's lacking other headers such as inttypes.h.
2962
2963         So for the rest of WebKit we have to continue to use our own versions of these files from
2964         JavaScriptCore/os-win32. But for Angle we are just including a shipped STL header file (memory)
2965         and so it's up to the compiler to make that work, i.e. using the stdint.h it ships.
2966
2967         This patch moves the addition of JavaScriptCore/os-win32 out of default_post.prf, so that it
2968         doesn't apply to each and every target anymore. In particular it won't apply to Angle anymore,
2969         because its presence causes a build issue where due to the addition of os-win32/ we end up
2970         including our own stdint.h but are lacking WTF/ to be in the include search path (which our own
2971         stdint.h requires). So out of default_post.prf and into WTF.pri, our own wrappers are now only
2972         used where WTF is also needed, and since os-win32/stdint.h depends on wtf/Platform.h, it seems
2973         like a logical location.
2974
2975         * qmake/mkspecs/features/default_post.prf:
2976
2977 2012-11-08  Dominik Röttsches  <dominik.rottsches@intel.com>
2978
2979         Unreviewed, rolling out r133859.
2980         http://trac.webkit.org/changeset/133859
2981         https://bugs.webkit.org/show_bug.cgi?id=101526
2982
2983         Breaks EFL bots test execution.
2984
2985         * Scripts/webkitperl/FeatureList.pm:
2986
2987 2012-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2988
2989         [Qt] Reduce the number of clean builds
2990         https://bugs.webkit.org/show_bug.cgi?id=100844
2991
2992         Reviewed by Tor Arne Vestbø.
2993
2994         A change in any Qt project file shouldn't trigger clean
2995         build always, but only if the incremental build failed.
2996
2997         * Scripts/webkitdirs.pm:
2998         (buildQMakeProjects):
2999
3000 2012-11-08  Kangil Han  <kangil.han@samsung.com>
3001
3002         [EFL][MiniBrowser] Add encoding detector option.
3003         https://bugs.webkit.org/show_bug.cgi?id=100931
3004
3005         Reviewed by Gyuyoung Kim.
3006
3007         Add a runtime option to enable/disable encoding detector.
3008
3009         * MiniBrowser/efl/main.c:
3010         (window_create):
3011         (elm_main):
3012
3013 2012-11-08  Balazs Kelemen  <kbalazs@webkit.org>
3014
3015         [Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
3016         https://bugs.webkit.org/show_bug.cgi?id=101485
3017
3018         Reviewed by Csaba Osztrogonác.
3019
3020         [Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
3021
3022         Support dumpAsText(true) which means we should not dump a render tree
3023         but should dump pixels. All other platforms already support it.
3024
3025         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3026         (WebCore::DumpRenderTree::dump):
3027         * DumpRenderTree/qt/TestRunnerQt.cpp:
3028         (TestRunner::reset):
3029         (TestRunner::dumpAsText):
3030         * DumpRenderTree/qt/TestRunnerQt.h:
3031         (TestRunner::shouldDumpPixels):
3032         (TestRunner):
3033
3034 2012-11-08  Yael Aharon  <yael.aharon@intel.com>
3035
3036         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
3037         https://bugs.webkit.org/show_bug.cgi?id=101526
3038
3039         Reviewed by Kenneth Rohde Christiansen.
3040
3041         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
3042
3043         * Scripts/webkitperl/FeatureList.pm:
3044
3045 2012-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3046
3047         Make wait-for-SVN-server.py accept empty string as revision
3048         https://bugs.webkit.org/show_bug.cgi?id=98014
3049
3050         Reviewed by Dirk Pranke.
3051
3052         * BuildSlaveSupport/wait-for-SVN-server.py:
3053         (waitForSVNRevision):
3054
3055 2012-11-07  Dirk Pranke  <dpranke@chromium.org>
3056
3057         garden-o-matic should handle concurrent requests
3058         https://bugs.webkit.org/show_bug.cgi?id=101407
3059
3060         Reviewed by Ojan Vafai.
3061
3062         Garden-o-Matic is implemented on top of the BaseHttpServer
3063         python library, which implements a single-threaded (one request at
3064         a time) server. This means that we can only rebaseline one test at
3065         a time, and when using a local results file, even fetching the results
3066         for diffs is single-threaded.
3067
3068         Mixing in the ThreadingMixin enables concurrent requests (subject
3069         to the global python interpreter lock). Given that we're doing all
3070         of the work in webkit-patch subprocesses, I think this is safe.
3071
3072         Of course, it may not be safe to do some of the subprocesses in
3073         parallel (e.g., rollout), but I think as long as we don't issue
3074         commands that touch overlapping sets of files things should be fine.
3075         The file locking over modifying testexpectations should keep that
3076         from being corrupted.
3077
3078         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3079         (GardeningHTTPServer):
3080         (GardeningHTTPRequestHandler):
3081
3082 2012-11-07  Andreas Kling  <akling@apple.com>
3083
3084         Remove build-webkit dependency on Java SDK for Apple Mac WebKit.
3085         <http://webkit.org/b/101492>
3086
3087         Reviewed by Anders Carlsson.
3088
3089         Don't check for a Java SDK before building the Apple Mac port. It's no longer needed for
3090         the build after the Java bridge was removed.
3091
3092         * Scripts/build-webkit:
3093         (cMakeArgsFromFeatures):
3094
3095 2012-11-07  Christophe Dumez  <christophe.dumez@intel.com>
3096
3097         [EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
3098         https://bugs.webkit.org/show_bug.cgi?id=101496
3099
3100         Reviewed by Kenneth Rohde Christiansen.
3101
3102         Provide implementation for on_window_geometry_get() / on_window_geometry_set()
3103         smart functions that interact with the elm_win widget.
3104
3105         * MiniBrowser/efl/main.c:
3106         (on_window_geometry_get):
3107         (on_window_geometry_set):
3108         (window_create):
3109
3110 2012-11-07  Yael Aharon  <yael.aharon@intel.com>
3111
3112         [EFL][WK2][AC] API tests crash
3113         https://bugs.webkit.org/show_bug.cgi?id=101480
3114
3115         Reviewed by Kenneth Rohde Christiansen.
3116
3117         When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests.
3118
3119         * TestWebKitAPI/efl/PlatformWebView.cpp:
3120         (TestWebKitAPI::initEcoreEvas):
3121
3122 2012-11-07  Peter Beverloo  <peter@chromium.org>
3123
3124         Don't show the Android tester in garden-o-matic yet
3125         https://bugs.webkit.org/show_bug.cgi?id=101476
3126
3127         Reviewed by Adam Barth.
3128
3129         The Android tester just started running layout tests, and doesn't upload its
3130         results yet. Don't show it for now. This exception will be removed once it
3131         has a baseline of greenness.
3132
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3134         (.):
3135
3136 2012-11-07  Balazs Kelemen  <kbalazs@webkit.org>
3137
3138         WebKitTestRunner flakily hangs when running pixel tests on Qt
3139         https://bugs.webkit.org/show_bug.cgi?id=100686
3140
3141         Reviewed by Csaba Osztrogonác.
3142
3143         Make WebKitTestRunner harden against the situation when the coordinated
3144         graphics rendering synchronisation fails. If we time out when waiting
3145         for the forced repaint to finish it usually a symptom of the synchronisation
3146         has been broken. In this case all other tests will fail with the same error.
3147         The underlying problem is not yet known. Ths patch make us report this situation
3148         as web process unresponsiveness, so the test harness will kill us and launch
3149         a new instance. This will make our pixel test bot usable while it should not limit
3150         us debugging the underlying bug.
3151
3152         * WebKitTestRunner/TestController.cpp:
3153         (WTR::TestController::run):
3154         * WebKitTestRunner/TestInvocation.cpp:
3155         (WTR::TestInvocation::TestInvocation):
3156         (WTR::TestInvocation::invoke):
3157         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
3158         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3159         * WebKitTestRunner/TestInvocation.h:
3160         (TestInvocation): Introduce new members to hold our state
3161         that was local to invoke() so far.
3162         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3163         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3164
3165 2012-11-07  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3166
3167         [Qt] Open link in this window action
3168         https://bugs.webkit.org/show_bug.cgi?id=101226
3169
3170         Reviewed by Simon Hausmann.
3171
3172         Populates the context-menu with the new action when the default action is to open in a new window.
3173
3174         * QtTestBrowser/webview.cpp:
3175         (createContextMenu):
3176
3177 2012-11-07  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3178
3179         [EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
3180         https://bugs.webkit.org/show_bug.cgi?id=101467
3181
3182         Reviewed by Kenneth Rohde Christiansen.
3183
3184         Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
3185         of default minimum contents width for non viewport meta element sites.
3186         Set default minimum contents width to '0' for MiniBrowser as it should behave like desktop browser.
3187
3188         * MiniBrowser/efl/main.c:
3189         (window_create):
3190
3191 2012-11-07  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3192
3193         [EFL] Add EFL to garden-o-matic
3194         https://bugs.webkit.org/show_bug.cgi?id=101444
3195
3196         Reviewed by Kenneth Rohde Christiansen.
3197
3198         Added the EFL bots running layout tests to the garden-o-matic report
3199         page. We are skipping here the bot that just builds WebKit EFL to make
3200         the data fetching faster.
3201
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3203         (.):
3204
3205 2012-11-07  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3206
3207         [EFL][WK2] Make EWK classes Ewk_Objects
3208         https://bugs.webkit.org/show_bug.cgi?id=101057
3209
3210         Reviewed by Kenneth Rohde Christiansen.
3211
3212         Now all the existing EWK classes share common Ewk_Object ref/unref API.
3213
3214         * MiniBrowser/efl/main.c:
3215         (close_file_picker):
3216         (on_file_chooser_request):
3217
3218 2012-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3219
3220         [Qt] Unreviewed. Add Qt EWS bots to the watchers list.
3221
3222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3223         (QtEWS):
3224         (QtWK2EWS):
3225
3226 2012-11-07  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3227
3228         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
3229         https://bugs.webkit.org/show_bug.cgi?id=93611
3230
3231         Reviewed by Gyuyoung Kim.
3232
3233         WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
3234
3235         * WebKitTestRunner/TestController.cpp:
3236         (WTR::TestController::resetStateToConsistentValues):
3237         Enables spelling by WebKit2 C API.
3238
3239 2012-11-07  Dominik Röttsches  <dominik.rottsches@intel.com>
3240
3241         [EFL] Switch the efl-linux-slave-2 to Wk2 Release
3242         https://bugs.webkit.org/show_bug.cgi?id=101345
3243
3244         Reviewed by Gyuyoung Kim.
3245
3246         Switching efl-linux-slave-2 to Wk2 Release.
3247
3248         * BuildSlaveSupport/build.webkit.org-config/config.json:
3249
3250 2012-11-07  Christophe Dumez  <christophe.dumez@intel.com>
3251
3252         Add replaceWithLiteral() method to WTF::String
3253         https://bugs.webkit.org/show_bug.cgi?id=101257
3254
3255         Reviewed by Benjamin Poulain.
3256
3257         Add API tests for String::replaceWithLiteral() and corresponding
3258         StringImpl methods.
3259
3260         * TestWebKitAPI/CMakeLists.txt: Add WTFString API tests to CMake.
3261         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3262         (TestWebKitAPI::TEST):
3263         (TestWebKitAPI):
3264         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3265         (TestWebKitAPI::TEST):
3266
3267 2012-11-07  Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
3268
3269         [Qt] Fix build of modules depending on QtWebKit when using prefix
3270         https://bugs.webkit.org/show_bug.cgi?id=101437
3271
3272         Reviewed by Simon Hausmann.
3273
3274         Remove setting of MODULE_QMAKE_OUTDIR from here, it's been moved to .qmake.conf.
3275
3276         * qmake/mkspecs/features/default_pre.prf:
3277
3278 2012-11-06  Dan Beam  <dbeam@chromium.org>
3279
3280         Enable REQUEST_AUTOCOMPLETE for chromium port
3281         https://bugs.webkit.org/show_bug.cgi?id=101376
3282
3283         Reviewed by Adam Barth.
3284
3285         This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
3286         HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
3287
3288         * DumpRenderTree/chromium/TestShell.cpp:
3289         (TestShell::TestShell):
3290
3291         Enables the requestAutocomplete runtime feature flag during tests.
3292
3293 2012-11-06  KyungTae Kim  <ktf.kim@samsung.com>
3294
3295         [WK2][EFL] Add shortcut for setting a pagination mode on Minibrowser
3296         https://bugs.webkit.org/show_bug.cgi?id=100301
3297
3298         Reviewed by Gyuyoung Kim.
3299
3300         Setting pagination modes is for a paginated view - left to right / right to left / top to bottom / bottom to top.
3301         Assign a shortcut "F7" to set pagination modes for tests.
3302
3303         * MiniBrowser/efl/main.c:
3304         (on_key_down):
3305
3306 2012-11-06  KyungTae Kim  <ktf.kim@samsung.com>
3307
3308         [EFL][EWebLauncher] Use Ctrl +/-  to zoom in EWebLauncher
3309         https://bugs.webkit.org/show_bug.cgi?id=100207
3310
3311         Reviewed by Gyuyoung Kim.
3312
3313         Use "Ctrl -" instead of "F7" to zoom out, and use "Ctrl +" instead of "F8" to zoom in, 
3314         and use "Ctrl 0" to set to default zoom level.
3315         They are more common shortcuts on usual browsers.
3316
3317         * EWebLauncher/main.c:
3318         (on_key_down):
3319
3320 2012-11-06  Oliver Hunt  <oliver@apple.com>
3321
3322         Don't warn about RefPtr* parameters
3323         https://bugs.webkit.org/show_bug.cgi?id=101403
3324
3325         Reviewed by Gavin Barraclough.
3326
3327         RefPtr<>* is a valid parameter type.
3328
3329         * Scripts/webkitpy/style/checkers/cpp.py:
3330         (check_function_definition_and_pass_ptr):
3331         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3332         (PassPtrTest.test_ref_ptr_parameter_value):
3333
3334 2012-11-06  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3335
3336         [WTR] Reset EventSender before running each test.
3337         https://bugs.webkit.org/show_bug.cgi?id=101353
3338
3339         Reviewed by Simon Fraser.
3340
3341         Contrary to what was done to at least some ports in DumpRenderTree,
3342         EventSender did not currently reset its values in WTR. This caused
3343         flakiness if a test such as editing/selection/fake-doubleclick.html was
3344         run twice in a row, since the click count was not reset across each
3345         run.
3346
3347         * WebKitTestRunner/TestController.cpp:
3348         (WTR::TestController::TestController): Do not create m_eventSenderProxy
3349         in the constructor anymore, it is created in
3350         resetStateToConsistentValues now.
3351         (WTR::TestController::resetStateToConsistentValues): Recreate
3352         m_eventSenderProxy every time this method is run.
3353         * WebKitTestRunner/TestController.h: Make m_eventSenderProxy an OwnPtr
3354         and guard it with a platform #ifdef.
3355         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3356         (WTR::EventSenderProxy::~EventSenderProxy): Add an empty
3357         implementation.
3358         * WebKitTestRunner/mac/EventSenderProxy.mm:
3359         (WTR::EventSenderProxy::~EventSenderProxy): Ditto.
3360         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3361         (WTR::EventSenderProxy::~EventSenderProxy): Ditto.
3362
3363 2012-11-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3364
3365         [EFL][WK2] Refactor Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job to be Ewk_Objects
3366         https://bugs.webkit.org/show_bug.cgi?id=101383
3367
3368         Reviewed by Kenneth Rohde Christiansen.
3369
3370         Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job are Ewk_Objects now.
3371
3372         * MiniBrowser/efl/main.c:
3373         (auth_popup_close):
3374         (on_authentication_request):
3375
3376 2012-11-06  Tommy Widenflycht  <tommyw@google.com>
3377
3378         [chromium] MediaStream API: Remove the valgrind issue with MockWebRTCPeerConnectionHandler
3379         https://bugs.webkit.org/show_bug.cgi?id=101336
3380
3381         Reviewed by Andreas Kling.
3382
3383         This patch changes the delete to delete [] to match the new[].
3384
3385         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3386
3387 2012-11-06  Mihai Balan  <mibalan@adobe.com>
3388
3389         Add Adobe's bug tracker to committers.py
3390         https://bugs.webkit.org/show_bug.cgi?id=101338
3391
3392         Reviewed by Kentaro Hara.
3393
3394         Adding Adobe's bug tracker mailing list to committers.py
3395         to enable its inclusion in the autocomplete list.
3396
3397         * Scripts/webkitpy/common/config/committers.py:
3398
3399 2012-11-06  Sami Kyostila  <skyostil@chromium.org>
3400
3401         [chromium] Enable fixed position compositing on Android DRT
3402         https://bugs.webkit.org/show_bug.cgi?id=100263
3403
3404         Reviewed by James Robinson.
3405
3406         Chrome on Android forces composited mode for every page and creates
3407         stacking contexts and graphics layers for fixed positioned elements.
3408         Change the DumpRenderTree settings to match this.
3409
3410         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3411         (main):
3412         * DumpRenderTree/chromium/TestShell.cpp:
3413         (TestShell::TestShell):
3414         (TestShell::resetWebSettings):
3415         * DumpRenderTree/chromium/TestShell.h:
3416         (TestShell::setAcceleratedCompositingForFixedPositionEnabled):
3417         (TestShell):
3418         * DumpRenderTree/chromium/WebPreferences.cpp:
3419         (WebPreferences::reset):
3420         (WebPreferences::applyTo):
3421         * DumpRenderTree/chromium/WebPreferences.h:
3422         (WebPreferences):
3423         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3424         (ChromiumAndroidPort.additional_drt_flag):
3425
3426 2012-11-06  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3427
3428         [EFL][WTR] EventSender: Get rid of the WTRMouseButton enum.
3429         https://bugs.webkit.org/show_bug.cgi?id=101340
3430
3431         Reviewed by Kenneth Rohde Christiansen.
3432
3433         Get rid of an enum which was basically a duplicate of the
3434         WKEventMouseButton one in the shared API.
3435
3436         The only difference is that it also had a case for a 4th mouse
3437         button that we treat in a special way in evasMouseButton() now.
3438
3439         * WebKitTestRunner/EventSenderProxy.h:
3440         (EventSenderProxy):
3441         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3442         (WTR::evasMouseButton):
3443         (WTR::EventSenderProxy::EventSenderProxy):
3444         (WTR::EventSenderProxy::mouseUp):
3445         (WTR::EventSenderProxy::mouseMoveTo):
3446         (WTR::EventSenderProxy::mouseScrollBy):
3447         (WTR::EventSenderProxy::leapForward):
3448
3449 2012-11-06  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3450
3451         [EFL][WK2] Minibrowser forgets http variables when url includes ampersand
3452         https://bugs.webkit.org/show_bug.cgi?id=101061
3453
3454         Reviewed by Kenneth Rohde Christiansen.
3455
3456         Elementary entry only returns 'markup' text, meaning ampersands
3457         in a url will become "&amp;". Use elm_entry_markup_to_utf8() and
3458         elm_entry_utf8_to_markup() when interacting with the entry.
3459
3460         * MiniBrowser/efl/main.c:
3461         (on_url_changed):
3462         (on_url_bar_activated):
3463
3464 2012-11-06  Balazs Kelemen  <kbalazs@webkit.org>
3465
3466         DumpRenderTree should have --pixel-tests option again
3467         https://bugs.webkit.org/show_bug.cgi?id=98648
3468
3469         Reviewed by Dirk Pranke.
3470
3471         Add back the --pixel-tests command line option to DumpRenderTree.
3472         It was removed r124581 because tools don't use it after that patch.
3473         However, it turned out that it is useful for debugging and working
3474         with pixel tests.
3475
3476         * DumpRenderTree/efl/DumpRenderTree.cpp:
3477         (parseCommandLineOptions):
3478         (runTest):
3479         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3480         (initializeGlobalsFromCommandLineOptions):
3481         (runTest):
3482         * DumpRenderTree/mac/DumpRenderTree.mm:
3483         (initializeGlobalsFromCommandLineOptions):
3484         (runTest):
3485         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3486         (isOption):
3487         (printUsage):
3488         (main):
3489         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3490         (WebCore::DumpRenderTree::processLine):
3491         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3492         (WebCore::DumpRenderTree::setShouldDumpPixelsForAllTests):
3493         (DumpRenderTree):
3494         * DumpRenderTree/win/DumpRenderTree.cpp:
3495         (runTest):
3496         (dllLauncherEntryPoint):
3497         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3498         (runTest):
3499         (MyApp::OnInit):
3500         * WebKitTestRunner/TestController.cpp:
3501         (WTR::TestController::TestController):
3502         (WTR::TestController::initialize):
3503         (WTR::TestController::runTest):
3504         * WebKitTestRunner/TestController.h:
3505         (TestController):
3506
3507 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3508
3509         webkit-patch rebaseline*: fix typo for --results-directory
3510         https://bugs.webkit.org/show_bug.cgi?id=101295
3511
3512         Reviewed by Ojan Vafai.
3513
3514         Had --results_directory instead of --results-directory in both the
3515         code and the unit test.
3516
3517         * Scripts/webkitpy/tool/commands/rebaseline.py:
3518         (AbstractParallelRebaselineCommand._rebaseline_commands):
3519         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3520         (TestRebaselineJson.test_results_directory):
3521
3522 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3523
3524         webkit-patch rebaseline*: fix handling of local file urls
3525         https://bugs.webkit.org/show_bug.cgi?id=101296
3526
3527         Reviewed by Ojan Vafai.
3528
3529         When using --results-directory, we need to make sure we're converting
3530         paths to file:/// urls for urllib to work correctly. Also, this
3531         patch reworks the unit tests to get better coverage (of the execute()
3532         command) and reduce copy/pasting of mock options.
3533
3534         * Scripts/webkitpy/tool/commands/rebaseline.py:
3535         (RebaselineTest._rebaseline_test_and_update_expectations):
3536         (RebaselineTest.execute):
3537         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3538         (TestRebaselineTest.setUp):
3539         (test_rebaseline_updates_expectations_file):
3540         (test_rebaseline_does_not_include_overrides):
3541         (test_rebaseline_test_with_results_directory):
3542         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
3543
3544 2012-11-05  Kenneth Russell  <kbr@google.com>
3545
3546         Added secondary email address and IRC nick.
3547         https://bugs.webkit.org/show_bug.cgi?id=101290
3548
3549         Unreviewed change to committers.py.
3550
3551         * Scripts/webkitpy/common/config/committers.py:
3552
3553 2012-11-05  Glenn Adams  <glenn@skynav.com>
3554
3555         Add IRC alias for Glenn Adams
3556         https://bugs.webkit.org/show_bug.cgi?id=101262
3557
3558         Reviewed by Eric Seidel.
3559
3560         Add IRC alias for Glenn Adams.
3561
3562         * Scripts/webkitpy/common/config/committers.py:
3563
3564 2012-11-05  Dima Gorbik  <dgorbik@apple.com>
3565
3566         Back out controversial changes from Bug 98665.
3567         https://bugs.webkit.org/show_bug.cgi?id=101244
3568
3569         Reviewed by David Kilzer.
3570
3571         Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
3572
3573         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3574
3575 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3576
3577         webkitpy: lint, clean up rebaseline.py
3578         https://bugs.webkit.org/show_bug.cgi?id=101240
3579
3580         Reviewed by Ojan Vafai.
3581
3582         Miscellaneous cleanup of lint errors and warnings.
3583
3584         * Scripts/webkitpy/tool/commands/rebaseline.py:
3585         (AbstractRebaseliningCommand):
3586         (RebaselineTest._test_root):
3587         (OptimizeBaselines._optimize_baseline):
3588         (OptimizeBaselines.execute):
3589         (AnalyzeBaselines.__init__):
3590         (AbstractParallelRebaselineCommand):
3591         (AbstractParallelRebaselineCommand._builders_to_fetch_from):
3592         (AbstractParallelRebaselineCommand._files_to_add):
3593         (AbstractParallelRebaselineCommand._rebaseline):
3594         (RebaselineExpectations.__init__):
3595         (Rebaseline.execute):
3596         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3597         (_BaseTestCase.setUp):
3598         (TestAnalyzeBaselines.setUp):
3599
3600 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3601
3602         webkit-patch optimize-baselines should take a --platform arg
3603         https://bugs.webkit.org/show_bug.cgi?id=97623
3604
3605         Reviewed by Ojan Vafai.
3606
3607         So that we can optionally limit/control which platforms' results
3608         are affected.
3609
3610         This patch adds --platform to analyze-baselines as well.
3611
3612         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3613         (_baseline_search_hypergraph):
3614         (BaselineOptimizer.__init__):
3615         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3616         (TestBaselineOptimizer.__init__):
3617         (BaselineOptimizerTest.test_move_baselines):
3618         * Scripts/webkitpy/tool/commands/rebaseline.py:
3619         (OptimizeBaselines.__init__):
3620         (OptimizeBaselines.execute):
3621         (AnalyzeBaselines.__init__):
3622         (AnalyzeBaselines.execute):
3623         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3624         (TestAnalyzeBaselines.test_default):
3625         (TestAnalyzeBaselines.test_missing_baselines):
3626
3627 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3628
3629         webkit-patch rebaseline-expectations should take a --platform arg
3630         https://bugs.webkit.org/show_bug.cgi?id=97621
3631
3632         Reviewed by Ojan Vafai.
3633
3634         So that we can limit which platforms we attempt to rebaseline;
3635         this can reduce the noise the command produces if some ports
3636         have errors or warnings in their TestExpectations files and/or
3637         help produce more predictable results.
3638
3639         In testing this patch, I realized that the rebaseline-in-parallel
3640         commands (rebaseline-json, rebaseline-expectations, etc.) can
3641         cause multiple rebaseline-test-internal commands to attempt to
3642         modify the TestExpectations files concurrently, and that we needed
3643         to lock the files to prevent corruption; it would be nice if
3644         we can split the updating-the-expectations-files out separately
3645         from updating the filesystem (much like we do with the scm updates)
3646         to avoid this concurrency.
3647
3648         * Scripts/webkitpy/common/system/file_lock_mock.py: Added.
3649         (MockFileLock):
3650         (MockFileLock.__init__):
3651         (MockFileLock.acquire_lock):
3652         (MockFileLock.release_lock):
3653         * Scripts/webkitpy/common/system/systemhost.py:
3654         (SystemHost.copy_current_environment):
3655         (SystemHost):
3656         (SystemHost.make_file_lock):
3657         * Scripts/webkitpy/common/system/systemhost_mock.py:
3658         (MockSystemHost.copy_current_environment):
3659         (MockSystemHost):
3660         (MockSystemHost.make_file_lock):
3661         * Scripts/webkitpy/tool/commands/rebaseline.py:
3662         (RebaselineTest._update_expectations_file):
3663         (RebaselineExpectations.__init__):
3664         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
3665         (RebaselineExpectations.execute):
3666
3667 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3668
3669         webkitpy: clean up options for specifying multiple platforms at once
3670         https://bugs.webkit.org/show_bug.cgi?id=101140
3671
3672         Reviewed by Ojan Vafai.
3673
3674         This patch reworks how we display the help strings for --platform
3675         options and how we filter out platforms matching a glob. This will
3676         be useful as I add patches to ensure that all the webkit-patch
3677         commands are using --platform consistently to filter ports.
3678
3679         There should be no functional changes resulting from this patch.
3680
3681         * Scripts/webkitpy/layout_tests/port/factory.py:
3682         (platform_options):
3683         (PortFactory.all_port_names):
3684         (PortFactory.get_from_builder_name):
3685         * Scripts/webkitpy/tool/commands/queries.py:
3686         (PrintExpectations.__init__):
3687         (PrintBaselines.__init__):
3688         * Scripts/webkitpy/tool/commands/rebaseline.py:
3689         (AbstractRebaseliningCommand):
3690         (RebaselineJson.__init__):
3691         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3692         (TestRebaselineExpectations.setUp):
3693         (TestRebaselineExpectations.test_rebaseline_expectations):
3694
3695 2012-11-05  Peter Beverloo  <peter@chromium.org>
3696
3697         The layout test runner shouldn't wait for data if stdout/stderr have been closed
3698         https://bugs.webkit.org/show_bug.cgi?id=101233
3699
3700         Reviewed by Dirk Pranke.
3701
3702         Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
3703         has crashed during a Chromium Android layout test-run, which uses FIFOs for
3704         communication, causes the File.fileno() method to raise a ValueError. Return early
3705         if either of the pipes has already been closed.
3706
3707         * Scripts/webkitpy/layout_tests/port/server_process.py:
3708         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3709
3710 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3711
3712         webkit-patch rebaseline is broken
3713         https://bugs.webkit.org/show_bug.cgi?id=101235
3714
3715         Reviewed by Ojan Vafai.
3716
3717         It didn't get updated to handle the change in parsing --suffixes
3718         properly, and the unit test didn't get updated either, masking the
3719         problem.
3720
3721         * Scripts/webkitpy/tool/commands/rebaseline.py:
3722         (Rebaseline._tests_to_update):
3723         (Rebaseline.execute):
3724         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3725         (TestRebaseline.test_rebaseline):
3726
3727 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3728
3729         lint-webkitpy doesn't autoinstall pylint properly.
3730         https://bugs.webkit.org/show_bug.cgi?id=101106
3731
3732         Reviewed by Ojan Vafai.
3733
3734         Re-land r133381 with fix; ironically, lint-webkitpy would've
3735         complained about the problem. Also modify pylintrc and clean up
3736         any other lint errors in the modified files.
3737
3738         * Scripts/webkitpy/common/system/autoinstall.py:
3739         (AutoInstaller._set_up_target_dir):
3740         (AutoInstaller):
3741         (AutoInstaller._make_package):
3742         (AutoInstaller._create_scratch_directory):
3743         (AutoInstaller._install):
3744         (AutoInstaller.install):
3745         * Scripts/webkitpy/pylintrc:
3746         * Scripts/webkitpy/thirdparty/__init__.py:
3747         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
3748         (AutoinstallImportHook):
3749         (AutoinstallImportHook.find_module):
3750         (AutoinstallImportHook._install_pylint):
3751         (AutoinstallImportHook._install_coverage):
3752         (AutoinstallImportHook._install_eliza):
3753         (AutoinstallImportHook._install_webpagereplay):
3754         (AutoinstallImportHook._install):
3755         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3756         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
3757         (ThirdpartyTest.test_import_hook):
3758         (ThirdpartyTest.test_imports):
3759
3760 2012-11-05  KyungTae Kim  <ktf.kim@samsung.com>
3761
3762         [EFL] Fix build warning in EWebLauncher/main.c
3763         https://bugs.webkit.org/show_bug.cgi?id=101197
3764
3765         Reviewed by Kentaro Hara.
3766
3767         Because the strp of _Ecore_Getopt_Value is char** (Ecore_Getopt.h),
3768         The parameter of ECORE_GETOPT_VALUE_STR should be char*
3769
3770         * EWebLauncher/main.c:
3771         (_User_Arguments):
3772
3773 2012-11-05  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3774
3775         [EFL][WK2] Add --window-size command line option to EFL MiniBrowser
3776         https://bugs.webkit.org/show_bug.cgi?id=100942
3777
3778         Reviewed by Kenneth Rohde Christiansen.
3779
3780         Added window-size (-s) command line option to EFL MiniBrowser.
3781
3782         * MiniBrowser/efl/main.c:
3783         (window_create):
3784         (parse_window_size):
3785         (elm_main):
3786
3787 2012-11-05  Christophe Dumez  <christophe.dumez@intel.com>
3788
3789         [EFL][WK2] The icon database path should be set by the client
3790         https://bugs.webkit.org/show_bug.cgi?id=101182
3791
3792         Reviewed by Kenneth Rohde Christiansen.
3793
3794         Enable favicon database functionality in MiniBrowser since
3795         it is used and it is no longer enabled by default.
3796
3797         * MiniBrowser/efl/main.c:
3798         (elm_main):
3799
3800 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
3801
3802         [Qt][WK2] setPlatformStrategies always asserts after r132744
3803         https://bugs.webkit.org/show_bug.cgi?id=100838
3804
3805         Reviewed by Simon Hausmann.
3806
3807         Reland with build fixes.
3808
3809         Turned test runners to use the new QtTestSupport.
3810
3811         * DumpRenderTree/qt/DumpRenderTree.pro:
3812         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3813         (main):
3814         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3815         (WebCore::DumpRenderTree::open):
3816         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
3817         * MiniBrowser/qt/MiniBrowser.pro:
3818         * QtTestBrowser/QtTestBrowser.pro:
3819         * QtTestBrowser/qttestbrowser.cpp:
3820         (LauncherApplication::handleUserOptions):
3821         * WebKitTestRunner/InjectedBundle/Target.pri:
3822         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3823         (WTR::activateFonts):
3824         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
3825         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
3826         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3827         (WTR::TestRunner::platformInitialize):  Removed the comment from here
3828         because it was just lying, apparently two times. First, it is not incorrect
3829         to reinitialize our font set and clear font caches, it is what the tests
3830         expect. Second, the use of QRawFont has nothing to do with the font cache.
3831         * WebKitTestRunner/Target.pri:
3832         * WebKitTestRunner/qt/main.cpp:
3833         (main):
3834
3835 2012-11-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3836
3837         Unreviewed, rolling out r133381.
3838         http://trac.webkit.org/changeset/133381
3839         https://bugs.webkit.org/show_bug.cgi?id=101161
3840
3841         It made webkit-patch useless (Requested by Ossy_weekend on
3842         #webkit).
3843
3844         * Scripts/webkitpy/common/system/autoinstall.py:
3845         (AutoInstaller._create_scratch_directory):
3846         (AutoInstaller._install):
3847         (AutoInstaller.install):
3848         * Scripts/webkitpy/thirdparty/__init__.py:
3849         (AutoinstallImportHook.__init__):
3850         (AutoinstallImportHook._install_pylint):
3851         (AutoinstallImportHook._install_coverage):
3852         (AutoinstallImportHook._install_eliza):
3853         (AutoinstallImportHook._install):
3854         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3855         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
3856         (ThirdpartyTest.test_import_hook):
3857
3858 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3859
3860         Unreviewed, rolling out r133403, r133404, and r133409.
3861         http://trac.webkit.org/changeset/133403
3862         http://trac.webkit.org/changeset/133404
3863         http://trac.webkit.org/changeset/133409
3864         https://bugs.webkit.org/show_bug.cgi?id=101158
3865
3866         "Broke tests" (Requested by kbalazs on #webkit).
3867
3868         * DumpRenderTree/qt/DumpRenderTree.pro:
3869         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3870         (main):
3871         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3872         (WebCore::DumpRenderTree::open):
3873         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
3874         (WebKit):
3875         (WebKit::initializeTestFonts):
3876         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3877         (WebKit):
3878         * MiniBrowser/qt/MiniBrowser.pro:
3879         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3880         (MiniBrowserApplication::handleUserOptions):
3881         * QtTestBrowser/QtTestBrowser.pro:
3882         * QtTestBrowser/qttestbrowser.cpp:
3883         (LauncherApplication::handleUserOptions):
3884         * WebKitTestRunner/InjectedBundle/Target.pri:
3885         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3886         (WTR::activateFonts):
3887         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3888         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3889         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3890         (WTR::TestRunner::platformInitialize):
3891         * WebKitTestRunner/Target.pri:
3892         * WebKitTestRunner/qt/main.cpp:
3893         (main):
3894
3895 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
3896
3897         [Qt][WK2] setPlatformStrategies always asserts after r132744
3898         https://bugs.webkit.org/show_bug.cgi?id=100838
3899
3900         2nd unreviewed buildfix.
3901
3902         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3903
3904 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
3905
3906         [Qt][WK2] setPlatformStrategies always asserts after r132744
3907         https://bugs.webkit.org/show_bug.cgi?id=100838
3908
3909         Unreviewed buildfix.
3910
3911         * WebKitTestRunner/Target.pri:
3912
3913 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
3914
3915         [Qt][WK2] setPlatformStrategies always asserts after r132744
3916         https://bugs.webkit.org/show_bug.cgi?id=100838
3917
3918         Reviewed by Simon Hausmann.
3919
3920         Reland with build fix.
3921
3922         Turned test runners to use the new QtTestSupport.
3923
3924         * DumpRenderTree/qt/DumpRenderTree.pro:
3925         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3926         (main):
3927         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3928         (WebCore::DumpRenderTree::open):
3929         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
3930         * MiniBrowser/qt/MiniBrowser.pro:
3931         * QtTestBrowser/QtTestBrowser.pro:
3932         * QtTestBrowser/qttestbrowser.cpp:
3933         (LauncherApplication::handleUserOptions):
3934         * WebKitTestRunner/InjectedBundle/Target.pri:
3935         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3936         (WTR::activateFonts):
3937         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
3938         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
3939         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3940         (WTR::TestRunner::platformInitialize):  Removed the comment from here
3941         because it was just lying, apparently two times. First, it is not incorrect
3942         to reinitialize our font set and clear font caches, it is what the tests
3943         expect. Second, the use of QRawFont has nothing to do with the font cache.
3944         * WebKitTestRunner/Target.pri:
3945         * WebKitTestRunner/qt/main.cpp:
3946         (main):
3947
3948 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3949
3950         Unreviewed, rolling out r133397.
3951         http://trac.webkit.org/changeset/133397
3952         https://bugs.webkit.org/show_bug.cgi?id=101155
3953
3954         "Broke Qt. No way to force the damn bots to do a clean build.
3955         I'm giving up." (Requested by kbalazs on #webkit).
3956
3957         * DumpRenderTree/qt/DumpRenderTree.pro:
3958         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3959         (main):
3960         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3961         (WebCore::DumpRenderTree::open):
3962         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
3963         (WebKit):
3964         (WebKit::initializeTestFonts):
3965         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3966         (WebKit):
3967         * QtTestBrowser/QtTestBrowser.pro:
3968         * QtTestBrowser/qttestbrowser.cpp:
3969         (LauncherApplication::handleUserOptions):
3970         * WebKitTestRunner/InjectedBundle/Target.pri:
3971         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3972         (WTR::activateFonts):
3973         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3974         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
3975         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3976         (WTR::TestRunner::platformInitialize):
3977         * WebKitTestRunner/Target.pri:
3978         * WebKitTestRunner/qt/main.cpp:
3979         (main):
3980
3981 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
3982
3983         [Qt][WK2] setPlatformStrategies always asserts after r132744
3984         https://bugs.webkit.org/show_bug.cgi?id=100838
3985
3986         Reviewed by Simon Hausmann.
3987
3988         Turned test runners to use the new QtTestSupport.
3989
3990         * DumpRenderTree/qt/DumpRenderTree.pro:
3991         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3992         (main):
3993         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3994         (WebCore::DumpRenderTree::open):
3995         * QtTestBrowser/QtTestBrowser.pro:
3996         * QtTestBrowser/qttestbrowser.cpp:
3997         (LauncherApplication::handleUserOptions):
3998         * WebKitTestRunner/InjectedBundle/Target.pri:
3999         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4000         (WTR::activateFonts):
4001         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
4002         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
4003         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
4004         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
4005         (WTR::TestRunner::platformInitialize): Removed the comment from here
4006         because it was just lying, apparently two times. First, it is not incorrect
4007         to reinitialize our font set and clear font caches, it is what the tests
4008         expect. Second, the use of QRawFont has nothing to do with the font cache.
4009         * WebKitTestRunner/Target.pri:
4010         * WebKitTestRunner/qt/main.cpp:
4011         (main):
4012
4013 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
4014
4015         webkit-patch rebaseline is broken
4016         https://bugs.webkit.org/show_bug.cgi?id=101081
4017
4018         Reviewed by Ojan Vafai.
4019
4020         I broke this in r133061 and the unit tests weren't covering this
4021         code path. Fixed the issue and the tests. --results-directory
4022         doesn't make sense for either 'webkit-patch rebaseline' or
4023         'webkit-patch rebaseline-expectations', so we don't want to expose
4024         that as a command line option, but they all call a common
4025         _rebaseline() routine that references options.results_directory,
4026         so we need to set a default value.
4027
4028         * Scripts/webkitpy/tool/commands/rebaseline.py:
4029         (RebaselineExpectations.execute):
4030         (Rebaseline.execute):
4031         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4032         (TestRebaseline):
4033         (TestRebaseline.test_rebaseline):
4034
4035 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
4036
4037         lint-webkitpy doesn't autoinstall pylint properly
4038         https://bugs.webkit.org/show_bug.cgi?id=101106
4039
4040         Reviewed by Ojan Vafai.
4041
4042         Turns out the autoinstalling code for pylint didn't install
4043         pylint's dependencies, and the autoinstaller code didn't work
4044         using nested directories (e.g., "logilab/astng"). Fix those issues,
4045         clean up the autoinstaller code, and add tests to make sure everything
4046         imports successfully.
4047
4048         * Scripts/webkitpy/common/system/autoinstall.py:
4049         (AutoInstaller._create_scratch_directory):
4050         (AutoInstaller._install):
4051         (AutoInstaller.install):
4052         * Scripts/webkitpy/thirdparty/__init__.py:
4053         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
4054         (AutoinstallImportHook._install_pylint):
4055         (AutoinstallImportHook._install_coverage):
4056         (AutoinstallImportHook._install_eliza):
4057         (AutoinstallImportHook._install):
4058         * Scripts/webkitpy/thirdparty/__init___unittest.py:
4059         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
4060         (ThirdpartyTest.test_import_hook):
4061         (ThirdpartyTest.test_imports):
4062
4063 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
4064
4065         nrwt prints an awkward result message for missing results
4066         https://bugs.webkit.org/show_bug.cgi?id=100915
4067
4068         Reviewed by Ojan Vafai.
4069
4070         Completely rework how we print out the description of
4071         each tests's result - we now will print either "passed" or "failed",
4072         followed by " unexpectedly" if we weren't expecting the result,
4073         followed by a short description of each type of failure that happened
4074         (in parentheses). Also reworked the description of each type of
4075         failure slightly to be clearer.
4076
4077         Also rework the tests to make sure we have coverage of all of the
4078         messages. Examples of the new output are posted as an attachment to
4079         the bug.
4080
4081         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4082         (TestExpectations):
4083         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4084         (FailureTimeout.message):
4085         (FailureMissingResult.message):
4086         (FailureTextMismatch.message):
4087         (FailureMissingImageHash.message):
4088         (FailureMissingImage.message):
4089         (FailureImageHashMismatch.message):
4090         (FailureImageHashIncorrect.message):
4091         (FailureReftestMismatch.message):
4092         (FailureReftestMismatchDidNotOccur.message):
4093         (FailureReftestNoImagesGenerated.message):
4094         (FailureMissingAudio.message):
4095         (FailureAudioMismatch.message):
4096         (FailureEarlyExit.message):
4097         * Scripts/webkitpy/layout_tests/port/test.py:
4098         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4099         (MainTest.test_run_singly_actually_runs_tests):
4100         (MainTest.test_missing_and_unexpected_results):
4101         * Scripts/webkitpy/layout_tests/views/printing.py:
4102         (Printer._print_result_summary_entry):
4103         (Printer.print_finished_test):
4104         (Printer._result_message):
4105         (Printer._print_unexpected_results):
4106         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4107         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4108
4109 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
4110
4111         webkitpy: clean up logging in common.system.autoinstall
4112         https://bugs.webkit.org/show_bug.cgi?id=101090
4113
4114         Reviewed by Ojan Vafai.
4115
4116         This module logged way too much, much of which was logging that
4117         was either really redundant or useful only during initial development.
4118         This patch deletes a lot of code and tweaks the remaining log messages
4119         to be more useful now.
4120
4121         Also, clean up a bunch of lint errors and warnings.
4122
4123         * Scripts/webkitpy/common/system/autoinstall.py:
4124         (AutoInstaller.__init__):
4125         (AutoInstaller._write_file):
4126         (AutoInstaller._set_up_target_dir):
4127         (AutoInstaller._create_scratch_directory):
4128         (AutoInstaller._url_downloaded_path):
4129         (AutoInstaller._is_downloaded):
4130         (AutoInstaller._record_url_downloaded):
4131         (AutoInstaller._extract_targz):
4132         (AutoInstaller._extract_all):
4133         (AutoInstaller._unzip):
4134         (AutoInstaller._download_to_stream):
4135         (AutoInstaller._download):
4136         (AutoInstaller._install):
4137         (AutoInstaller.install):
4138
4139 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
4140
4141         webkit-patch analyze-baselines output is weak
4142         https://bugs.webkit.org/show_bug.cgi?id=100998
4143
4144         Reviewed by Ojan Vafai.
4145
4146         Currently analyze-baselines prints a list of baselines that have
4147         the same checksum per line, but the format is hard to read;
4148         this patch cleans up the output to print by directory instead
4149         and use the same format I recently added for debugging optimize-baselines,
4150         then refactors the code so that we share and adds tests for
4151         analyze-baselines (which was untested).
4152
4153         Also, I got rid of a couple of unnecessarily-hardcoded port names,
4154         and modified the baseline optimizer to log the current world when
4155         optimize fails.
4156
4157         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4158         (BaselineOptimizer.read_results_by_directory):
4159         (BaselineOptimizer.write_by_directory):
4160         (BaselineOptimizer.optimize):
4161         * Scripts/webkitpy/tool/commands/rebaseline.py:
4162         (OptimizeBaselines.execute):
4163         (AnalyzeBaselines.__init__):
4164         (AnalyzeBaselines._write):
4165         (AnalyzeBaselines._analyze_baseline):
4166         (AnalyzeBaselines.execute):
4167         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4168         (_FakeOptimizer):
4169         (_FakeOptimizer.read_results_by_directory):
4170         (TestAnalyzeBaselines):
4171         (TestAnalyzeBaselines.setUp):
4172         (TestAnalyzeBaselines.test_default):
4173         (TestAnalyzeBaselines.test_missing_baselines):
4174
4175 2012-11-02  Adam Barth  <abarth@webkit.org>
4176
4177         ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
4178         https://bugs.webkit.org/show_bug.cgi?id=100711
4179
4180         Reviewed by Eric Seidel.
4181
4182         * Scripts/webkitperl/FeatureList.pm:
4183         * qmake/mkspecs/features/features.pri:
4184
4185 2012-11-02  Sheriff Bot  <webkit.review.bot@gmail.com>
4186
4187         Unreviewed, rolling out r133303.
4188         http://trac.webkit.org/changeset/133303
4189         https://bugs.webkit.org/show_bug.cgi?id=101068
4190
4191         "Broke qt wk2 build (seems like bots fails to rerun qmake if
4192         needed)" (Requested by kbalazs on #webkit).
4193
4194         * DumpRenderTree/qt/DumpRenderTree.pro:
4195         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4196         (main):
4197         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4198         (WebCore::DumpRenderTree::open):
4199         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
4200         (WebKit):
4201         (WebKit::initializeTestFonts):
4202         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
4203         (WebKit):
4204         * QtTestBrowser/QtTestBrowser.pro:
4205         * QtTestBrowser/qttestbrowser.cpp:
4206         (LauncherApplication::handleUserOptions):
4207         * WebKitTestRunner/InjectedBundle/Target.pri:
4208         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4209         (WTR::activateFonts):
4210         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
4211         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
4212         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
4213         (WTR::TestRunner::platformInitialize):
4214         * WebKitTestRunner/Target.pri:
4215         * WebKitTestRunner/qt/main.cpp:
4216         (main):
4217
4218 2012-11-02  Balazs Kelemen  <kbalazs@webkit.org>
4219
4220         [Qt][WK2] setPlatformStrategies always asserts after r132744
4221         https://bugs.webkit.org/show_bug.cgi?id=100838
4222
4223         Reviewed by Simon Hausmann.
4224
4225         Turned test runners to use the new QtTestSupport.
4226
4227         * DumpRenderTree/qt/DumpRenderTree.pro:
4228         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4229         (main):
4230         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4231         (WebCore::DumpRenderTree::open):
4232         * QtTestBrowser/QtTestBrowser.pro:
4233         * QtTestBrowser/qttestbrowser.cpp:
4234         (LauncherApplication::handleUserOptions):
4235         * WebKitTestRunner/InjectedBundle/Target.pri:
4236         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4237         (WTR::activateFonts):
4238         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
4239         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
4240         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
4241         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
4242         (WTR::TestRunner::platformInitialize): Removed the comment from here
4243         because it was just lying, apparently two times. First, it is not incorrect
4244         to reinitialize our font set and clear font caches, it is what the tests
4245         expect. Second, the use of QRawFont has nothing to do with the font cache.
4246         * WebKitTestRunner/Target.pri:
4247         * WebKitTestRunner/qt/main.cpp:
4248         (main):
4249
4250 2012-11-02  Peter Beverloo  <peter@chromium.org>
4251
4252         Output Android's device status before running tests on the bots
4253         https://bugs.webkit.org/show_bug.cgi?id=100944
4254
4255         Reviewed by Dirk Pranke.
4256
4257         This adds a new step to the build master which will be run prior to the
4258         actual tests-suites on the Chromium Android tester, and soon the Chromium
4259         Android Perf bot. For each attached device, it outputs the build
4260         information, battery level, battery temperature and username.
4261
4262         The Android tester currently is very flaky, and this will help tremendously
4263         in being able to figure out what's wrong with the bot.
4264
4265         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4266         (OutputAndroidDeviceStatus):
4267         (TestFactory.__init__):
4268         * BuildSlaveSupport/chromium/output-android-device-status: Added.
4269         (GetAttachedDevices):
4270         (AndroidDeviceStatus):
4271         (AndroidDeviceStatus.__init__):
4272         (AndroidDeviceStatus._run_adb_command):
4273         (AndroidDeviceStatus.device_type):
4274         (AndroidDeviceStatus.device_build):
4275         (AndroidDeviceStatus.device_fingerprint):
4276         (AndroidDeviceStatus.battery_level):
4277         (AndroidDeviceStatus.battery_temperature):
4278         (AndroidDeviceStatus.username):
4279         (main):
4280
4281 2012-11-02  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
4282
4283         [Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
4284         https://bugs.webkit.org/show_bug.cgi?id=101033
4285
4286         Reviewed by Simon Hausmann.
4287
4288         eventSender.mouseDown doesn't work properly since r133153 where
4289         MouseButtonDblClick events aren't interpreted as Press events anymore.
4290         The problem is that mouseDown sends a DblClick event instead of a Press,