[GTK][WPE] WTR: fix handling of WebsiteDataStore
[WebKit-https.git] / Tools / ChangeLog
1 2020-04-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK][WPE] WTR: fix handling of WebsiteDataStore
4         https://bugs.webkit.org/show_bug.cgi?id=210106
5
6         Reviewed by Adrian Perez de Castro.
7
8         The TestController::defaultWebsiteDataStore() is created and used but never really assigned to the
9         context. Since we are not assigning a WebsiteDataStore to the context, and we don't use the default
10         WebsiteDataStore, when a new page is created, we end up creating the default one (with the default config,
11         instead of the one created by WTR).
12
13         * WebKitTestRunner/TestController.cpp:
14         (WTR::TestController::platformAdjustContext): Set defaultWebsiteDataStore() as the primary data store of the
15         context like the GLib API does.
16
17 2020-04-07  Fujii Hironori  <Hironori.Fujii@sony.com>
18
19         [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in TestWebKitAPI
20         https://bugs.webkit.org/show_bug.cgi?id=210067
21
22         Reviewed by Darin Adler.
23
24         There are test cases for overflow, non-overflow, underflow and
25         non-underflow edge cases in WTF.clampToIntegerFloat test.
26         maxPlusOne<int> can be used for overflow edge case, INT_MIN for
27         non-underflow. This change added code to calculate values for
28         non-overflow and underflow cases.
29
30         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
31         (TestWebKitAPI::TEST(WTF.clampToIntegerFloat)):
32         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
33         (TestWebKitAPI::TEST(FloatRect.EnclosingIntRect)): Replaced
34         shiftMaxXEdgeTo(INT_MAX) with shiftMaxXEdgeTo(0) because it also
35         causes overflow for enclosingIntRect.
36
37 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
38
39         [ews] Add unit tests for layout tests factories
40         https://bugs.webkit.org/show_bug.cgi?id=210150
41
42         Reviewed by Jonathan Bedard.
43
44         * BuildSlaveSupport/ews-build/factories_unittest.py:
45         (TestLayoutTestsFactory):
46         (TestLayoutTestsFactory.test_macos_wk1_release_factory): Added unit-test.
47         (TestLayoutTestsFactory.test_macos_wk1_debug_factory): Ditto.
48         (TestLayoutTestsFactory.test_macos_wk2_factory): Ditto.
49         (TestLayoutTestsFactory.test_ios_wk2_factory): Ditto.
50         (TestGTKFactory): Renamed.
51
52 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
53
54         [ews] Improve summary for CheckPatchRelevance build step
55         https://bugs.webkit.org/show_bug.cgi?id=210146
56
57         Reviewed by Jonathan Bedard.
58
59         * BuildSlaveSupport/ews-build/steps.py:
60         (CheckPatchRelevance): Improved success message.
61         (CheckPatchRelevance.start):
62         (CheckPatchRelevance.getResultSummary): Improved failure message.
63         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
64         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Updated accordingly.
65
66 2020-04-07  Jiewen Tan  <jiewen_tan@apple.com>
67
68         [WebAuthn] Cancel WebAuthn requests when users cancel LocalAuthentication prompts
69         https://bugs.webkit.org/show_bug.cgi?id=209923
70         <rdar://problem/61223713>
71
72         Reviewed by Brent Fulgham.
73
74         Modifies existing tests to accommodate changes in MockWebAuthenticationConfiguration.idl.
75
76         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html:
77         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html:
78         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html:
79         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html:
80
81 2020-04-07  Ryan Haddad  <ryanhaddad@apple.com>
82
83         Unreviewed, reverting r259655.
84
85         Caused assertion failures and timeouts on iOS bots
86
87         Reverted changeset:
88
89         "Return app-bound sessions for instances where
90         WKAppBoundDomains is"
91         https://bugs.webkit.org/show_bug.cgi?id=210124
92         https://trac.webkit.org/changeset/259655
93
94 2020-04-07  Joanmarie Diggs  <jdiggs@igalia.com>
95
96         AX: Change ATK mapping of the ARIA alert and alertdialog roles
97         https://bugs.webkit.org/show_bug.cgi?id=210121
98
99         Reviewed by Chris Fleizach.
100
101         Add support for ATK_ROLE_NOTIFICATION.
102
103         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
104
105 2020-04-07  Wenson Hsieh  <wenson_hsieh@apple.com>
106
107         Preventing touch events should not prevent gestures installed above WKWebView from recognizing
108         https://bugs.webkit.org/show_bug.cgi?id=210080
109         <rdar://problem/61365814>
110
111         Reviewed by Tim Horton.
112
113         Add a UIScriptController helper method that allows a test to install a tap gesture recognizer on the UIWindow
114         containing the web view. This method additionally takes a JavaScript callback, which is invoked when the tap
115         gesture is recognized.
116
117         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
118         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
119         * TestRunnerShared/UIScriptContext/UIScriptController.h:
120         (WTR::UIScriptController::installTapGestureOnWindow):
121         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
122         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
123         (-[TestRunnerWKWebView resetInteractionCallbacks]):
124         (-[TestRunnerWKWebView didRecognizeTapOnWindow]):
125         (-[TestRunnerWKWebView windowTapRecognizedCallback]):
126         (-[TestRunnerWKWebView setWindowTapRecognizedCallback:]):
127         (-[TestRunnerWKWebView willMoveToWindow:]):
128         (-[TestRunnerWKWebView didMoveToWindow]):
129         (-[TestRunnerWKWebView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
130         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
132         (WTR::UIScriptControllerIOS::installTapGestureOnWindow):
133
134 2020-04-07  Alexey Shvayka  <shvaikalesh@gmail.com>
135
136         test262/Runner.pm ignores "async" flag
137         https://bugs.webkit.org/show_bug.cgi?id=210127
138
139         Reviewed by Ross Kirsling.
140
141         This change adds dereferencing for `$data->{flags}` array, making `grep` work as
142         expected. Other flags are correctly handled by `getScenarios` function, which
143         gets a dereferenced array as an argument.
144
145         * Scripts/test262/Runner.pm:
146         (runTest):
147
148 2020-04-07  Truitt Savell  <tsavell@apple.com>
149
150         Unreviewed, reverting r259446.
151
152         Broke Windows testing
153
154         Reverted changeset:
155
156         "[Windows] Ignore render tree dump based results on Windows"
157         https://bugs.webkit.org/show_bug.cgi?id=209897
158         https://trac.webkit.org/changeset/259446
159
160 2020-04-07  Aakash Jain  <aakash_jain@apple.com>
161
162         [ews] Add unit-test for CheckPatchRelevance build step
163         https://bugs.webkit.org/show_bug.cgi?id=210140
164
165         Reviewed by Jonathan Bedard.
166
167         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
168         (TestCheckPatchRelevance):
169         (TestCheckPatchRelevance.test_relevant_patch):
170         (TestCheckPatchRelevance.test_non_relevant_patch):
171
172 2020-04-07  Kate Cheney  <katherine_cheney@apple.com>
173
174         Return app-bound sessions for instances where WKAppBoundDomains is
175         empty
176         https://bugs.webkit.org/show_bug.cgi?id=210124
177         <rdar://problem/61276630>
178
179         Reviewed by Brent Fulgham.
180
181         Cleaned up tests to turn the flag on at the start of each In-App
182         Browser Privacy test.
183
184         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
185         (cleanUpInAppBrowserPrivacyTestSettings):
186         (initializeInAppBrowserPrivacyTestSettings):
187         (TEST):
188
189 2020-04-07  Timothy Hatcher  <timothy@apple.com>
190
191         WKUserScripts deferred from injection are not injected if -[WKWebView _notifyUserScripts] is called early.
192         https://bugs.webkit.org/show_bug.cgi?id=210131
193         rdar://problem/61368446
194
195         Reviewed by Brady Eidson.
196
197         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
198         (TEST):
199
200 2020-04-07  Ryosuke Niwa  <rniwa@webkit.org>
201
202         TextManipulationController fails to replace a paragraph that ends with a br
203         https://bugs.webkit.org/show_bug.cgi?id=210099
204
205         Reviewed by Wenson Hsieh.
206
207         Added regression tests.
208
209         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
210         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsSeparatedByBR):
211         (TextManipulation.CompleteTextManipulationReplaceParagraphsSeparatedByWrappedBR):
212         (TextManipulation.CompleteTextManipulationFailWhenBRIsInserted):
213
214 2020-04-07  Adrian Perez de Castro  <aperez@igalia.com>
215
216         [GTK] CMake find module for GTK4
217         https://bugs.webkit.org/show_bug.cgi?id=210110
218
219         Reviewed by Don Olmstead.
220
221         * MiniBrowser/gtk/CMakeLists.txt: Use the GTK::GTK imported target.
222         * TestWebKitAPI/PlatformGTK.cmake: Ditto.
223         * TestWebKitAPI/glib/PlatformGTK.cmake: Ditto.
224         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
225
226 2020-04-07  Youenn Fablet  <youenn@apple.com>
227
228         Reset mock capture devices between layout tests
229         https://bugs.webkit.org/show_bug.cgi?id=210098
230
231         Reviewed by Eric Carlson.
232
233         This fixes fast/mediastream/anonymize-device-name.html
234         failure since https://trac.webkit.org/changeset/259477/webkit.
235
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::resetStateToConsistentValues):
238
239 2020-04-06  Peng Liu  <peng.liu6@apple.com>
240
241         REGRESSION (r259531?): [iOS] TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia is timing out
242         https://bugs.webkit.org/show_bug.cgi?id=210013
243
244         Reviewed by Daniel Bates.
245
246         Fix mistakes in the test and make it more reliable.
247
248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
249         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
250         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
251         (TestWebKitAPI::TEST):
252         * TestWebKitAPI/Tests/WebKitLegacy/ios/one-video.html: Added.
253
254 2020-04-06  Don Olmstead  <don.olmstead@sony.com>
255
256         [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
257         https://bugs.webkit.org/show_bug.cgi?id=210059
258
259         Reviewed by Fujii Hironori.
260
261         Modify CMake code to use WEBKIT_EXECUTABLE when creating DumpRenderTree.
262
263         * DumpRenderTree/CMakeLists.txt:
264         * DumpRenderTree/PlatformWin.cmake:
265
266 2020-04-06  Jonathan Bedard  <jbedard@apple.com>
267
268         ImageDiff: Don't build with ASan in automation
269         https://bugs.webkit.org/show_bug.cgi?id=210057
270         <rdar://problem/61234753>
271
272         Reviewed by David Kilzer.
273
274         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Disable ASan.
275
276 2020-04-06  Kenneth Russell  <kbr@chromium.org>
277
278         Update my committer status
279         https://bugs.webkit.org/show_bug.cgi?id=210072
280
281         Reviewed by Dean Jackson.
282
283         Update contributors.json to reflect that my lapsed committer
284         status was recently reinstated.
285
286         * Scripts/webkitpy/common/config/contributors.json:
287
288 2020-04-06  Ross Kirsling  <ross.kirsling@sony.com>
289
290         Update minimum ICU version to 60.2
291         https://bugs.webkit.org/show_bug.cgi?id=209694
292
293         Reviewed by Darin Adler.
294
295         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
296         Remove obsoleted compile-time version checks.
297
298         * DumpRenderTree/TestRunner.cpp:
299         (TestRunner::runUIScript):
300         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
301         (breakingLocationsFromICU):
302         Manually convert between UChar and UniChar/unichar where needed.
303
304 2020-04-06  Rick Waldron  <waldron.rick@gmail.com> and Alexey Shvayka  <shvaikalesh@gmail.com>
305
306         Remove unnecessary Test262 harness file and implement $262.IsHTMLDDA
307         https://bugs.webkit.org/show_bug.cgi?id=187526
308
309         Reviewed by Darin Adler.
310
311         Removed file duplicates functionality of jsc.cpp's GlobalObject::finishCreation.
312
313         * Scripts/test262/Runner.pm:
314         * Scripts/test262/agent.js: Removed.
315
316 2020-04-06  Saam Barati  <sbarati@apple.com>
317
318         Implement 1GB of executable memory on arm64
319         https://bugs.webkit.org/show_bug.cgi?id=208490
320         <rdar://problem/60797127>
321
322         Reviewed by Keith Miller.
323
324         * Scripts/run-jsc-stress-tests:
325         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
326         (TestWebKitAPI::TEST_F):
327         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
328         (TestWebKitAPI::TEST_F):
329
330 2020-04-04  Darin Adler  <darin@apple.com>
331
332         Stop using live ranges in DocumentMarkerController
333         https://bugs.webkit.org/show_bug.cgi?id=209985
334
335         Reviewed by Antti Koivisto.
336
337         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
338         (TestWebKitAPI::TEST): Update for change to DocumentMarker constructor.
339
340 2020-04-06  Jonathan Bedard  <jbedard@apple.com>
341
342         run-api-tests spew "setup_environ_for_server" in verbose mode
343         https://bugs.webkit.org/show_bug.cgi?id=210012
344         <rdar://problem/61306056>
345
346         Reviewed by Aakash Jain.
347
348         * Scripts/webkitpy/port/ios_simulator.py:
349         (IOSSimulatorPort.setup_environ_for_server): Do not log this function when called.
350
351 2020-04-06  Antoine Quint  <graouts@apple.com>
352
353         [macOS] TestWebKitAPI.WKUserContentController.UserStyleSheetAffectingOnlySpecificWebViewSharedConfiguration is a flaky timeout
354         https://bugs.webkit.org/show_bug.cgi?id=209934
355         <rdar://problem/61229832>
356
357         Reviewed by Antti Koivisto.
358
359         Fix a couple of tests which would use `-[WKWebView _test_waitForDidFinishNavigation]` in a way where the navigation may have finished before the method was called.
360
361         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
362         (TEST):
363
364 2020-04-05  Gus Caplan  <me@gus.host> and Ross Kirsling  <ross.kirsling@sony.com>
365
366         DLLLauncherMain print to console instead of opening window on fatal error
367         https://bugs.webkit.org/show_bug.cgi?id=206537
368
369         Reviewed by Fujii Hironori.
370
371         * win/DLLLauncher/DLLLauncherMain.cpp:
372         (fatalError):
373
374 2020-04-05  Don Olmstead  <don.olmstead@sony.com>
375
376         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
377         https://bugs.webkit.org/show_bug.cgi?id=206894
378
379         Reviewed by Adrian Perez de Castro.
380
381         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
382         MiniBrowsers.
383
384         * MiniBrowser/gtk/CMakeLists.txt:
385         * MiniBrowser/win/CMakeLists.txt:
386         * MiniBrowser/wpe/CMakeLists.txt:
387
388 2020-04-05  Don Olmstead  <don.olmstead@sony.com>
389
390         [CMake] Add WebKit::WebKit target
391         https://bugs.webkit.org/show_bug.cgi?id=210033
392
393         Reviewed by Fujii Hironori.
394
395         Use the WebKit::WebKit target for MiniBrowser and TestWebKit. This removes
396         the need to have WebProcess and NetworkProcess as dependencies since they are
397         attached to the WebKit::WebKit target.
398
399         Remove references to WebKitFrameworkHeaders as it is now WebKit_CopyHeaders.
400         It is also a dependency of WebKit::WebKit so it does not need to be listed
401         as a dependency.
402
403         * MiniBrowser/win/CMakeLists.txt:
404         * TestWebKitAPI/CMakeLists.txt:
405         * TestWebKitAPI/PlatformPlayStation.cmake:
406         * TestWebKitAPI/PlatformWin.cmake:
407         * WebKitTestRunner/CMakeLists.txt:
408
409 2020-04-05  Daniel Bates  <dabates@apple.com>
410
411         RequestTextInputContext.Simple iframe sub-tests may sometimes fail
412         https://bugs.webkit.org/show_bug.cgi?id=210010
413         <rdar://problem/61303697>
414
415         Reviewed by Simon Fraser and Darin Adler.
416
417         Make the iframe sub tests wait until the DOM Load event has fired in the main frame.
418         When it fires this means that all immediate child frames (like the one added by these
419         sub tests) have fired their DOM Load event. This ensures deterministic results.
420
421         Also while I am here, extract out the iframe sub-tests into their own TEST() method
422         for testing and debugging convenience. I also fixed up -performAfterLoading so that
423         it wouldn't leak the user script string and made it work if called more than once in the
424         same TEST() by caching this script and only adding it to the user content controller
425         once. Moreover, removed duplication by writing it in terms of -performAfterReceivingMessage.
426
427         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
428         (TEST):
429         (webViewLoadHTMLStringAndWaitForDOMLoadEvent): Helper function to load an HTML string
430         into a web view and wait until a DOM Load event is fired at the main frame.
431         * TestWebKitAPI/cocoa/TestWKWebView.h:
432         * TestWebKitAPI/cocoa/TestWKWebView.mm:
433         (-[TestWKWebView performAfterLoading:]): Modernized and simplified. Modified user script
434         to use addEventListener() instead of onload as the latter overrides any existing load handler.
435         This user script is also added only to the main frame since all existing callers just
436         want to know that all main frame and immediate child frames loaded. Also listen for the load
437         event during the capture phase, which is a tiny bit faster to receive, instead of the bubbling
438         phase. See second paragraph above for more details on the changes I made to this function.
439
440
441 2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
442
443         Add a fourth round of logging to help diagnose <webkit.org/b/209685>
444         https://bugs.webkit.org/show_bug.cgi?id=210011
445
446         Reviewed by Darin Adler.
447
448         Remove all logging previously added to DragAndDropSimulator.
449
450         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
451         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
452
453 2020-04-04  Chris Dumez  <cdumez@apple.com>
454
455         [iOS] Simplify ProcessAssertion class in preparation for switch to RunningBoard
456         https://bugs.webkit.org/show_bug.cgi?id=209984
457         <rdar://problem/61273941>
458
459         Reviewed by Darin Adler.
460
461         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
462
463 2020-04-04  Wenson Hsieh  <wenson_hsieh@apple.com>
464
465         Add even more logging to try and diagnose <webkit.org/b/209685>
466         https://bugs.webkit.org/show_bug.cgi?id=210008
467
468         Reviewed by Tim Horton.
469
470         Replace old logging with new logging (in different places).
471
472         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
473         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
474         (-[DragAndDropSimulator _advanceProgress]):
475         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
476
477         Rule out the possibility that the WebKit client (in this case, the drag and drop simulator) is overriding the
478         list of drag items by logging the given NSItemProvider that will be used to start the drag.
479
480 2020-04-04  Peng Liu  <peng.liu6@apple.com>
481
482         REGRESSION (r259095): ASSERTION FAILED: m_videoFullscreenMode != VideoFullscreenModeNone seen with TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
483         https://bugs.webkit.org/show_bug.cgi?id=209680
484
485         Reviewed by Jer Noble.
486
487         Add an API test for the video fullscreen support of WebKitLegacy on iOS.
488
489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
490         * TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm: Added.
491         (-[VideoFullscreenStressUIWebViewDelegate webViewDidFinishLoad:]):
492         (-[VideoFullscreenStressUIWebViewDelegate uiWebView:didCommitLoadForFrame:]):
493         (-[VideoFullscreenStressUIWebViewDelegate handleEvent:]):
494         (TestWebKitAPI::TEST):
495         * TestWebKitAPI/Tests/WebKitLegacy/ios/two-videos.html: Added.
496
497 2020-04-03  Alex Christensen  <achristensen@webkit.org>
498
499         Add SPI to make WKUserScripts wait for a notification
500         https://bugs.webkit.org/show_bug.cgi?id=209845
501         <rdar://problem/60342299>
502
503         Reviewed by Chris Dumez.
504
505         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
506         (TEST):
507
508 2020-04-03  Kate Cheney  <katherine_cheney@apple.com>
509
510         Prevent non app-bound domain cookies from being read or set using API calls
511         https://bugs.webkit.org/show_bug.cgi?id=209926
512         <rdar://problem/61071428>
513
514         Reviewed by Brady Eidson.
515
516         Added 3 new API tests to test that non app-bound cookies are not being
517         set or returned via API calls. Also added a function to reset state
518         between tests for internal debugging.
519
520         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
521         (setUpCookieTest):
522         (TEST):
523
524 2020-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
525
526         Add more logging to help diagnose <webkit.org/b/209685>
527         https://bugs.webkit.org/show_bug.cgi?id=209988
528
529         Reviewed by Timothy Hatcher.
530
531         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
532
533         Fix a few stray style mistakes (unnecessary `.get()`s).
534
535         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
536         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
537         (-[DragAndDropSimulator _advanceProgress]):
538
539 2020-04-03  Truitt Savell  <tsavell@apple.com>
540
541         Unreviewed, reverting r259440.
542
543         Introduced 2 failing tests on Mac and iOS
544
545         Reverted changeset:
546
547         "Add SPI to configure WebsiteDataStores with a URL for
548         standalone web applications and use it to disable first-party
549         website data removal in ITP"
550         https://bugs.webkit.org/show_bug.cgi?id=209634
551         https://trac.webkit.org/changeset/259440
552
553 2020-04-03  Kate Cheney  <katherine_cheney@apple.com>
554
555         Remove _setIsNavigatingToAppBoundDomain testing SPI
556         https://bugs.webkit.org/show_bug.cgi?id=209973
557         <rdar://problem/61264350>
558
559         Reviewed by David Kilzer.
560
561         This SPI is no longer needed to set a webView as navigating to an
562         app-bound domain. We can now load a local file instead.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
565         (TEST):
566         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
567
568 2020-04-03  David Kilzer  <ddkilzer@apple.com>
569
570         [Xcode] Replace ASAN_OTHER_CFLAGS and ASAN_OTHER_CPLUSPLUSFLAGS with $(inherited)
571         <https://webkit.org/b/209963>
572         <rdar://problem/61257504>
573
574         Reviewed by Alexey Proskuryakov.
575
576         * asan/asan.xcconfig:
577         - Use $(inherited) to get rid of custom ASAN_OTHER_CFLAGS and
578           ASAN_OTHER_CPLUSPLUSFLAGS.  Note that ASAN_OTHER_LDFLAGS had
579           been previously removed in r179312, but not in the other
580           *.xcconfig files.
581
582         * ContentExtensionTester/Configurations/Base.xcconfig:
583         * DumpRenderTree/mac/Configurations/Base.xcconfig:
584         * ImageDiff/cg/Configurations/Base.xcconfig:
585         * MiniBrowser/Configurations/Base.xcconfig:
586         * MobileMiniBrowser/Configurations/Base.xcconfig:
587         * TestWebKitAPI/Configurations/Base.xcconfig:
588         * WebEditingTester/Configurations/Base.xcconfig:
589         * WebKitLauncher/Configurations/Base.xcconfig:
590         * WebKitTestRunner/Configurations/Base.xcconfig:
591         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
592         - Remove ASAN_OTHER_CFLAGS, ASAN_OTHER_CPLUSPLUSFLAGS and
593           ASAN_OTHER_LDFLAGS.
594
595 2020-04-03  Aakash Jain  <aakash_jain@apple.com>
596
597         [ews] Improve error message when patch fails to apply to trunk
598         https://bugs.webkit.org/show_bug.cgi?id=209965
599
600         Reviewed by Jonathan Bedard.
601
602         * BuildSlaveSupport/ews-build/steps.py:
603         (ApplyPatch.getResultSummary): Improved error message.
604         (ApplyPatch.evaluateCommand): Ditto.
605         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
606
607 2020-04-03  Sihui Liu  <sihui_liu@apple.com>
608
609         ASSERTION FAILED: m_delegate in IDBConnectionToClient::identifier()
610         https://bugs.webkit.org/show_bug.cgi?id=209891
611         <rdar://problem/59293891>
612
613         Reviewed by Geoffrey Garen.
614
615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
616         * TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html: Added.
617         * TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-2.html: Added.
618         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
619         (TEST):
620
621 2020-04-03  Aakash Jain  <aakash_jain@apple.com>
622
623         [ews] Display list of test failures along-with the layout-test build step
624         https://bugs.webkit.org/show_bug.cgi?id=209912
625
626         Reviewed by Jonathan Bedard.
627
628         * BuildSlaveSupport/ews-build/steps.py:
629         (RunWebKitTests._addToLog):
630         (RunWebKitTests.commandComplete): Add list of test failures to 'test-failures' log which is displayed in UI.
631         (ReRunWebKitTests.commandComplete): Ditto.
632         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
633
634 2020-04-03  Philippe Normand  <pnormand@igalia.com>
635
636         REGRESSION(r259453): [Flatpak SDK] Build directory no longer bind-mounted when running tests
637         https://bugs.webkit.org/show_bug.cgi?id=209960
638
639         Reviewed by Carlos Alberto Lopez Perez.
640
641         The bind-mount is always needed, not only when running build-webkit.
642
643         * flatpak/flatpakutils.py:
644         (WebkitFlatpak.run_in_sandbox):
645
646 2020-04-03  Diego Pino Garcia  <dpino@igalia.com>
647
648         [Flatpak SDK] Create platform/Release directory only when build-webkit is called
649         https://bugs.webkit.org/show_bug.cgi?id=209954
650
651         Reviewed by Philippe Normand.
652
653         * flatpak/flatpakutils.py:
654         (WebkitFlatpak.clean_args): Remove creation of self.build_path.
655         (WebkitFlatpak.run_in_sandbox): Create self.build_path if command is
656         build-webkit.
657
658 2020-04-03  Philippe Normand  <pnormand@igalia.com>
659
660         [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored
661         https://bugs.webkit.org/show_bug.cgi?id=209648
662
663         Reviewed by Žan Doberšek.
664
665         This patch removes redundant options from webkit-flatpak,
666         correctly handles the cmakeargs option and reduces the amount of
667         `flatpak list` calls performed.
668
669         * flatpak/flatpakutils.py:
670         (check_flatpak):
671         (FlatpakPackages.__init__):
672         (FlatpakPackage.is_installed):
673         (WebkitFlatpak.load_from_args):
674         (WebkitFlatpak.__init__):
675         (WebkitFlatpak.clean_args):
676         (WebkitFlatpak.run_in_sandbox):
677         (WebkitFlatpak.main):
678         (WebkitFlatpak.setup_dev_env):
679         (WebkitFlatpak.run_gdb):
680
681 2020-04-03  Diego Pino Garcia  <dpino@igalia.com>
682
683         [Flatpak SDK] Call setup_icecc only if use_icecream is defined
684         https://bugs.webkit.org/show_bug.cgi?id=209956
685
686         Reviewed by Philippe Normand.
687
688         * flatpak/flatpakutils.py:
689         (WebkitFlatpak.setup_dev_env):
690
691 2020-04-03  Antti Koivisto  <antti@apple.com>
692
693         [Windows] Ignore render tree dump based results on Windows
694         https://bugs.webkit.org/show_bug.cgi?id=209897
695
696         Reviewed by Darin Adler.
697
698         Render tree dumps are port specific and so difficult to maintain. They are mostly very old and
699         have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
700
701         This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by
702         default on Apple Windows port.
703
704         With the option set the render tree dump tests are still run (so crashes are detected) but their
705         output is treated as if it always passed. Missing results are not written to disk.
706
707         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
708         (SingleTestRunner._compare_text):
709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
710         (parse_args):
711         (_set_up_derived_options):
712
713 2020-04-02  James Savage  <james.savage@apple.com>
714
715         Add myself, as a committer, to contributors.json.
716         https://bugs.webkit.org/show_bug.cgi?id=209952.
717
718         * Scripts/webkitpy/common/config/contributors.json:
719
720 2020-04-02  James Savage  <james.savage@apple.com>
721
722         Add myself to contributors.json.
723         https://bugs.webkit.org/show_bug.cgi?id=209952.
724
725         * Scripts/webkitpy/common/config/contributors.json:
726
727 2020-04-02  John Wilander  <wilander@apple.com>
728
729         Add SPI to configure WebsiteDataStores with a URL for standalone web applications and use it to disable first-party website data removal in ITP
730         https://bugs.webkit.org/show_bug.cgi?id=209634
731         <rdar://problem/60943970>
732
733         Reviewed by Alex Christensen.
734
735         Added a new test option called standaloneWebApplicationURL so that layout tests can
736         configure the website data store accordingly. Picking it up and using it requires
737         creating a new website data store with a configuration that has the standalone web
738         application URL.
739
740         * WebKitTestRunner/TestController.cpp:
741         (WTR::parseStringTestHeaderValueAsURL):
742         (WTR::updateTestOptionsFromTestHeader):
743         * WebKitTestRunner/TestOptions.h:
744         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
745         (WTR::TestController::platformCreateWebView):
746
747 2020-04-02  David Kilzer  <ddkilzer@apple.com>
748
749         REGRESSION (r234685): Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm
750         <https://webkit.org/b/209915>
751
752         Reviewed by Darin Adler.
753
754         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
755         (createCoreAnimationLayer): Use RetainPtr<> to fix leak.
756
757 2020-04-02  David Kilzer  <ddkilzer@apple.com>
758
759         API::PageConfiguration may have conflicting preference values between WebPreferences and WebPreferencesStore::ValueMap instance variables
760         <https://webkit.org/b/209678>
761         <rdar://problem/60981271>
762
763         Reviewed by Brent Fulgham.
764
765         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
766         (TestWebKitAPI::TEST):
767         - Fix WKView constructor to pass a valid WKPageGroupRef.
768
769         * WebKitTestRunner/TestController.cpp:
770         (WTR::updateTestOptionsFromTestHeader):
771         * WebKitTestRunner/TestOptions.h:
772         (WTR::TestOptions::hasSameInitializationOptions const):
773         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
774         (WTR::TestController::platformCreateWebView):
775         - Remove support for custom "enableUndoManagerAPI" setting since
776           layout tests should use "internal:UndoManagerAPIEnabled"
777           instead.
778
779 2020-04-02  Alex Christensen  <achristensen@webkit.org>
780
781         Add SPI to restrict loading to main resources or non-network loads
782         https://bugs.webkit.org/show_bug.cgi?id=209893
783
784         Reviewed by Tim Horton.
785
786         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
787         * TestWebKitAPI/cocoa/HTTPServer.h:
788         (TestWebKitAPI::HTTPServer::totalRequests const):
789         * TestWebKitAPI/cocoa/HTTPServer.mm:
790         (TestWebKitAPI::HTTPServer::respondToRequests):
791
792 2020-04-02  Kate Cheney  <katherine_cheney@apple.com>
793
794         Add additional WKAppBoundDomains to TestWebKitAPI's expectations after initializing eTLD+1 by default
795         https://bugs.webkit.org/show_bug.cgi?id=209889
796         <rdar://problem/61184539>
797
798         Reviewed by Brent Fulgham.
799
800         Additional domains will now be included in TestWebKitAPI's
801         WKAppBoundDomains list after
802         https://bugs.webkit.org/show_bug.cgi?id=209839 (Allow WKAppBoundDomains
803         to be initialized with eTLD+1 only (no protocol)).
804
805         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
806         (TEST):
807
808 2020-04-01  Per Arne Vollan  <pvollan@apple.com>
809
810         [Cocoa] UTI from MIME type cache can be removed after r258915
811         https://bugs.webkit.org/show_bug.cgi?id=209787
812
813         Unreviewed rollout of r257828.
814
815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
816         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Removed.
817
818 2020-04-01  Jonathan Bedard  <jbedard@apple.com>
819
820         run-javascriptcore-tests: runJSCStressTests shouldn't exit the program
821         https://bugs.webkit.org/show_bug.cgi?id=209887
822
823         Reviewed by Darin Adler.
824
825         * Scripts/run-javascriptcore-tests:
826         (runJSCStressTests): Exit the function, not the program.
827
828 2020-04-01  Chris Dumez  <cdumez@apple.com>
829
830         Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
831         https://bugs.webkit.org/show_bug.cgi?id=209873
832         <rdar://problem/61132068>
833
834         Reviewed by Alex Christensen.
835
836         Add API test coverage.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
839
840 2020-04-01  Don Olmstead  <don.olmstead@sony.com>
841
842         [PlayStation] Use OBJECT libraries for WebCore and PAL
843         https://bugs.webkit.org/show_bug.cgi?id=209835
844
845         Reviewed by Ross Kirsling.
846
847         Use the object libraries when compiling TestWebCore.
848
849         * TestWebKitAPI/PlatformPlayStation.cmake:
850
851 2020-04-01  Jack Lee  <shihchieh_lee@apple.com>
852
853         Unreviewed, add new committer to contributors.json
854
855         * Scripts/webkitpy/common/config/contributors.json:
856
857 2020-04-01  Philippe Normand  <pnormand@igalia.com>
858
859         [Flatpak SDK] Migration to version 0.2
860         https://bugs.webkit.org/show_bug.cgi?id=209850
861
862         Reviewed by Carlos Alberto Lopez Perez.
863
864         Version 0.2 of the SDK is now built with Buildstream instead of
865         flatpak-builder. With this new version it will be easier to add
866         new dependencies and hack on dependencies shipped by the SDK.
867
868         Sadly I haven't found a nice way to upgrade smoothly without
869         removing the UserFlatpak directory. In theory this shouldn't be
870         needed but then old SDK branches would accumulate there, wasting
871         disk-space.
872
873         * flatpak/flatpakutils.py:
874         (Console):
875         (Console.colored_message):
876         (Console.error_message):
877         (Console.warning_message):
878         (check_flatpak):
879         (FlatpakObject.flatpak):
880         (FlatpakRepo.__init__):
881         (FlatpakRepo):
882         (FlatpakRepo.is_app_installed):
883         (FlatpakPackage.__init__):
884         (FlatpakPackage.install):
885         (FlatpakPackage.update):
886         (WebkitFlatpak.__init__):
887         (WebkitFlatpak.clean_args):
888         (WebkitFlatpak._reset_repository):
889         (WebkitFlatpak.setup_gstbuild):
890         (WebkitFlatpak.main):
891         (WebkitFlatpak.run):
892         (WebkitFlatpak.setup_dev_env):
893         (WebkitFlatpak._get_packages):
894
895 2020-04-01  Carlos Garcia Campos  <cgarcia@igalia.com>
896
897         [GTK] MiniBrowser: valgrind claims 'Invalid write of size 8' on close
898         https://bugs.webkit.org/show_bug.cgi?id=209471
899
900         Reviewed by Adrian Perez de Castro.
901
902         This is because we need to remove the weak pointer added in child windows to their parent.
903
904         * MiniBrowser/gtk/BrowserWindow.c:
905         (browserWindowDispose): Remove the parentWindow weak ref.
906         (browser_window_class_init): Add dispose.
907
908 2020-03-31  Kate Cheney  <katherine_cheney@apple.com>
909
910         Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
911         https://bugs.webkit.org/show_bug.cgi?id=209836
912         <rdar://problem/61071607>
913
914         Reviewed by Brent Fulgham.
915
916         Most of this patch is changes to the tests, which formerly relied
917         on message handlers to test script injection protections. I rewrote
918         three tests to remove the use of message handlers which were used to
919         confirm normal script injection behavior before enabling In-App
920         Browser Privacy. Since normal script injection behavior is tested in
921         WKUserContentController.mm already it is unecessary to test here.
922
923         I removed one test, IgnoreAppBoundDomainsAcceptsUserScripts, which
924         fully relied on message handler use and could not be tested without
925         somehow disabling this feature.
926
927         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
928         (TEST):
929         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
930         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html:
931         Add a message handler to this page to demonstrate that message
932         handlers work for app-bound navigations (file:// protocol is always
933         app-bound).
934
935 2020-03-31  Alex Christensen  <achristensen@webkit.org>
936
937         Send correct UserContentControllerIdentifier after using SPI WKWebpagePreferences._userContentController
938         https://bugs.webkit.org/show_bug.cgi?id=209833
939
940         Reviewed by Tim Hatcher.
941
942         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
943
944 2020-03-31  Brent Fulgham  <bfulgham@apple.com>
945
946         Allow WKAppBoundDomains to be initialized with eTLD+1 only (no protocol)
947         https://bugs.webkit.org/show_bug.cgi?id=209839
948         <rdar://problem/61129400>
949
950         Reviewed by Darin Adler.
951
952         * TestWebKitAPI/Info.plist:
953
954 2020-03-31  Alex Christensen  <achristensen@webkit.org>
955
956         Add SPI WKWebpagePreferences._userContentController
957         https://bugs.webkit.org/show_bug.cgi?id=209795
958
959         Reviewed by Tim Hatcher.
960
961         * TestWebKitAPI/SourcesCocoa.txt:
962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
963         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
964         (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
965         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
966         * TestWebKitAPI/cocoa/TestUIDelegate.h: Added.
967         * TestWebKitAPI/cocoa/TestUIDelegate.mm: Added.
968         (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
969         (-[TestUIDelegate waitForAlert]):
970
971 2020-03-31  Aakash Jain  <aakash_jain@apple.com>
972
973         Delete code for security EWS from old EWS (follow-up fix)
974         https://bugs.webkit.org/show_bug.cgi?id=209683
975
976         Revert 233220.
977
978         Unreviewed follow-up fix.
979
980         * Scripts/webkitpy/common/net/statusserver_mock.py:
981         * Scripts/webkitpy/tool/commands/queues.py:
982
983 2020-03-30  Peng Liu  <peng.liu6@apple.com>
984
985         PiP support of MiniBrowser is broken
986         https://bugs.webkit.org/show_bug.cgi?id=209749
987
988         Reviewed by Jer Noble.
989
990         Add com.apple.PIPAgent to the mach-lookup.global.name temporary exception entitlement.
991         * MiniBrowser/MiniBrowser.entitlements:
992         Fix an issue that the intended preferences are overwritten by default values
993         and enable the PiP support.
994         * MiniBrowser/mac/AppDelegate.m:
995         (-[BrowserAppDelegate defaultConfiguration]):
996
997 2020-03-30  Zhifei Fang  <zhifei_fang@apple.com>
998
999         [results.webkit.org: Timeline]: Left side of the timeline scale is usually bigger than the right        
1000
1001         https://bugs.webkit.org/show_bug.cgi?id=209569
1002
1003         Reviewed by Jonathan Bedard.
1004
1005         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1006
1007 2020-03-30  Frank Yang  <guowei_yang@apple.com>
1008
1009         Update my name in contributors.json
1010         https://bugs.webkit.org/show_bug.cgi?id=209751
1011         
1012         Added myself to contributors.json. Also some changes to other
1013         people's information are made after running the canonicalize script.
1014         
1015         Reviewed by Myles C. Maxfield.
1016
1017         * Scripts/webkitpy/common/config/contributors.json:
1018
1019 2020-03-30  Aakash Jain  <aakash_jain@apple.com>
1020
1021         Delete code for security EWS from old EWS
1022         https://bugs.webkit.org/show_bug.cgi?id=209683
1023
1024         Reverted r232979, r233061, r233190, r233219, r233276 and r233288.
1025
1026         Rubber-stamped by Jonathan Bedard.
1027
1028         * QueueStatusServer/handlers/releasepatch.py: Reverted changes for security EWS in old EWS.
1029         * QueueStatusServer/main.py:
1030         * QueueStatusServer/config/authorization.py: Removed.
1031         * QueueStatusServer/handlers/fetchattachment.py: Removed.
1032         * QueueStatusServer/handlers/uploadattachment.py: Removed.
1033         * QueueStatusServer/model/attachmentdata.py: Removed.
1034         * QueueStatusServer/templates/uploadattachment.html: Removed.
1035         * Scripts/webkitpy/common/net/bugzilla/constants.py: Removed.
1036         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1037         * Scripts/webkitpy/common/net/bugzilla/attachment_unittest.py:
1038         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1039         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1040         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1041         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1042         * Scripts/webkitpy/common/net/statusserver.py:
1043         * Scripts/webkitpy/common/net/statusserver_mock.py:
1044         * Scripts/webkitpy/tool/bot/feeders.py:
1045         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1046         * Scripts/webkitpy/tool/commands/download.py:
1047         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1048         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1049         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1050         * Scripts/webkitpy/tool/commands/queues.py:
1051         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1052         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1053         * Scripts/webkitpy/tool/main.py:
1054         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1055
1056 2020-03-30  Michael Catanzaro  <mcatanzaro@gnome.org>
1057
1058         Add user agent quirk for Red Hat Bugzilla
1059         https://bugs.webkit.org/show_bug.cgi?id=209484
1060
1061         Reviewed by Adrian Perez de Castro.
1062
1063         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1064         (TestWebKitAPI::TEST):
1065
1066 2020-03-30  Per Arne Vollan  <pvollan@apple.com>
1067
1068         [Cocoa] Sleep disabling should be performed in the UI process
1069         https://bugs.webkit.org/show_bug.cgi?id=209676
1070
1071         Reviewed by Darin Adler.
1072
1073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1074         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm: Added.
1075         (TEST):
1076
1077 2020-03-30  Per Arne Vollan  <pvollan@apple.com>
1078
1079         [macOS] REGRESSION(r258949) API test failures
1080         https://bugs.webkit.org/show_bug.cgi?id=209702
1081
1082         Reviewed by Darin Adler.
1083
1084         After r258949, the preference observer is started when the app is activated, but since the app running
1085         API tests is not being activated, the preference observer needs to be manually instantiated in each test.
1086
1087         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1088         (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
1089         (TEST):
1090
1091 2020-03-28  Alex Christensen  <achristensen@webkit.org>
1092
1093         REGRESSION(r257963) UI process crashes when setting navigation delegate inside navigation delegate callbacks
1094         https://bugs.webkit.org/show_bug.cgi?id=209705
1095         <rdar://problem/60814765>
1096
1097         Reviewed by Darin Adler.
1098
1099         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm:
1100         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
1101         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1102
1103 2020-03-28  Alex Christensen  <achristensen@webkit.org>
1104
1105         Deprecate injected bundle page group SPI
1106         https://bugs.webkit.org/show_bug.cgi?id=209687
1107
1108         Reviewed by Timothy Hatcher.
1109
1110         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1111         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1112         (TestWebKitAPI::DOMWindowExtensionBasic::initialize): Deleted.
1113         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1114         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1115         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize): Deleted.
1116         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1117         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::didCreatePage):
1118         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize): Deleted.
1119         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1120         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize): Deleted.
1121         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize): Deleted.
1122         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1123         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::didCreatePage):
1124         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Deleted.
1125
1126 2020-03-28  ChangSeok Oh  <changseok@webkit.org>
1127
1128         [GTK] No libsystemd-devel for DNF
1129         https://bugs.webkit.org/show_bug.cgi?id=209697
1130
1131         Reviewed by Philippe Normand.
1132
1133         Replace libsystemd-devel to systemd-devel for DNF.
1134
1135         * gtk/install-dependencies:
1136         * wpe/install-dependencies:
1137
1138 2020-03-27  Philippe Normand  <pnormand@igalia.com>
1139
1140         [Flatpak SDK] Allow passing gst-build Meson options
1141         https://bugs.webkit.org/show_bug.cgi?id=209608
1142
1143         Reviewed by Žan Doberšek.
1144
1145         Add support for the GST_BUILD_ARGS env var storing gst-build Meson options.
1146
1147         * flatpak/flatpakutils.py:
1148         (WebkitFlatpak.setup_gstbuild):
1149
1150 2020-03-27  Philippe Normand  <pnormand@igalia.com>
1151
1152         [Flatpak SDK] Warn when gst-build support was requested but GST_BUILD_PATH is not set
1153         https://bugs.webkit.org/show_bug.cgi?id=209599
1154
1155         Reviewed by Žan Doberšek.
1156
1157         * flatpak/flatpakutils.py:
1158         (WebkitFlatpak.setup_gstbuild):
1159         (WebkitFlatpak.setup_dev_env):
1160
1161 2020-03-26  Chris Dumez  <cdumez@apple.com>
1162
1163         REGRESSION: Unable to show Web Inspector on empty tabs in Safari
1164         https://bugs.webkit.org/show_bug.cgi?id=209639
1165         <rdar://problem/60937524>
1166
1167         Reviewed by Darin Adler.
1168
1169         Add API test coverage.
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1172
1173 2020-03-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1174
1175         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
1176         https://bugs.webkit.org/show_bug.cgi?id=204831
1177
1178         Reviewed by Ross Kirsling.
1179
1180         * TestWebKitAPI/win/main.cpp:
1181         * win/DLLLauncher/DLLLauncherMain.cpp:
1182
1183 2020-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1184
1185         Unreviewed test gardening for iOS API tests.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1188         (TEST):
1189         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1190         (TestWebKitAPI::TEST):
1191
1192 2020-03-26  Daniel Bates  <dabates@apple.com>
1193
1194         WebPage::selectPositionAtPoint() does not focus an element in a non-focused frame
1195         https://bugs.webkit.org/show_bug.cgi?id=209559
1196         <rdar://problem/60887055>
1197
1198         Reviewed by Wenson Hsieh.
1199
1200         Add a test.
1201
1202         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1203         (TEST):
1204
1205 2020-03-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1206
1207         WebKitTestRunner should enable ResourceLoadStatistics also for non-Cocoa ports
1208         https://bugs.webkit.org/show_bug.cgi?id=209410
1209
1210         Reviewed by Youenn Fablet.
1211
1212         Cocoa WebKitTestRunner always enables ResourceLoadStatistics.
1213         Other ports should do so.
1214
1215         * WebKitTestRunner/TestController.cpp:
1216         (WTR::TestController::platformAdjustContext): Enable ResourceLoadStatistics
1217         by using WKWebsiteDataStoreSetResourceLoadStatisticsEnabled.
1218
1219 2020-03-26  Kate Cheney  <katherine_cheney@apple.com>
1220
1221         Guard AppBound domain protections with PLATFORM(iOS_FAMILY)
1222         https://bugs.webkit.org/show_bug.cgi?id=209615
1223         <rdar://problem/60931014>
1224
1225         Reviewed by Darin Adler.
1226
1227         Tests should only be run on iOS.
1228
1229         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1230
1231 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
1232
1233         [ews] status-bubble for tester queues should point to tester queue while waiting in queue (Follow-up fix)
1234         https://bugs.webkit.org/show_bug.cgi?id=209598
1235
1236         Unreviewed follow-up fix.
1237
1238         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1239         (StatusBubble._build_bubble): Display the tester name in tester's status-bubble hover-over message.
1240
1241 2020-03-26  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews] status-bubble for tester queues should point to tester queue while waiting in queue
1244         https://bugs.webkit.org/show_bug.cgi?id=209598
1245
1246         Reviewed by Jonathan Bedard.
1247
1248         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1249         (StatusBubble._build_bubble):
1250
1251 2020-03-26  Chris Fleizach  <cfleizach@apple.com>
1252
1253         AX: WKTR: Don't update isolated tree mode behavior if not required
1254         https://bugs.webkit.org/show_bug.cgi?id=209555
1255         <rdar://problem/60885094>
1256
1257         Reviewed by Darin Adler.
1258
1259         If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
1260         This might have the side effect of turning on accessibility unexpectedly.
1261
1262         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1263         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1264
1265 2020-03-26  Philippe Normand  <pnormand@igalia.com>
1266
1267         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
1268         https://bugs.webkit.org/show_bug.cgi?id=209558
1269
1270         Reviewed by Žan Doberšek.
1271
1272         When using flatpak some of the arguments we pass to build-webkit
1273         are not meant to be used by that script but by webkit-flatpak. However we are
1274         not passing all of them to webkit-flatpak but just the configuration ones
1275         (port, release/debug...). This means that all the arguments that configure the
1276         behaviour of webkit-flatpak are lost.
1277
1278         * Scripts/webkitdirs.pm:
1279         (runInFlatpak): Filter-out Flatpak SDK-specific arguments to a
1280         separate array, passed to webkit-flatpak.
1281
1282 2020-03-26  Commit Queue  <commit-queue@webkit.org>
1283
1284         Unreviewed, reverting r259035.
1285         https://bugs.webkit.org/show_bug.cgi?id=209597
1286
1287         broke windows layout-tests (Requested by aakashjain on
1288         #webkit).
1289
1290         Reverted changeset:
1291
1292         "[Win] lld-link: error: /manifestdependency: is not allowed in
1293         .drectve"
1294         https://bugs.webkit.org/show_bug.cgi?id=204831
1295         https://trac.webkit.org/changeset/259035
1296
1297 2020-03-26  Philippe Normand  <pnormand@igalia.com>
1298
1299         [Flatpak SDK] update-webkitgtk-libs fails
1300         https://bugs.webkit.org/show_bug.cgi?id=209546
1301
1302         Reviewed by Žan Doberšek.
1303
1304         Simplify the code a bit, add a `--assumeyes` argument to the
1305         `flatpak update` command to make it non-interactive and improve
1306         error handling/reporting a bit as well.
1307
1308         * flatpak/flatpakutils.py:
1309         (FlatpakObject.flatpak):
1310         (WebkitFlatpak.main):
1311         (WebkitFlatpak.run):
1312         (WebkitFlatpak.install_all):
1313         (WebkitFlatpak.update_all): Deleted.
1314
1315 2020-03-26  Philippe Normand  <pnormand@igalia.com>
1316
1317         [Flatpak SDK] Crash post-mortem debugging is broken
1318         https://bugs.webkit.org/show_bug.cgi?id=209537
1319
1320         Reviewed by Žan Doberšek.
1321
1322         webkit-flatpak --gdb now properly launches gdb to inspect the last
1323         crash reported to coredumpctl. The -m argument can be used to
1324         select another crash dump.
1325
1326         * flatpak/flatpakutils.py:
1327         (WebkitFlatpak.clean_args):
1328         (WebkitFlatpak.run_in_sandbox):
1329         (WebkitFlatpak.run_gdb):
1330
1331 2020-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1332
1333         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
1334         https://bugs.webkit.org/show_bug.cgi?id=204831
1335
1336         Reviewed by Ross Kirsling.
1337
1338         * TestWebKitAPI/win/main.cpp:
1339         * win/DLLLauncher/DLLLauncherMain.cpp:
1340
1341 2020-03-25  Alexey Shvayka  <shvaikalesh@gmail.com>
1342
1343         Invalid numeric and named references should be early syntax errors
1344         https://bugs.webkit.org/show_bug.cgi?id=178175
1345
1346         Reviewed by Ross Kirsling.
1347
1348         Removes FIXME as YarrParser is correct not to throw errors as it is
1349         parsing in non-Unicode mode. Also adds a few named groups tests.
1350
1351         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1352
1353 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
1354
1355         [Timeline] A better default get label function, which fit the assumpation the label is always a string
1356         https://bugs.webkit.org/show_bug.cgi?id=209567
1357
1358         Reviewed by Jonathan Bedard.
1359
1360         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1361
1362 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
1363
1364         [Timeline] Fix the out of bound dot index
1365         https://bugs.webkit.org/show_bug.cgi?id=209492
1366
1367         Reviewed by Jonathan Bedard.
1368
1369         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1370         (Timeline.CanvasSeriesComponent):
1371
1372 2020-03-25  Daniel Bates  <dabates@apple.com>
1373
1374         Element context character rects may be in wrong coordinate system
1375         https://bugs.webkit.org/show_bug.cgi?id=209493
1376         <rdar://problem/60840261>
1377
1378         Reviewed by Wenson Hsieh.
1379
1380         Add some tests.
1381
1382         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1383         (TEST):
1384
1385 2020-03-25  Doug Kelly  <dougk@apple.com>
1386
1387         Unreviewed, add new committer to contributors.json
1388
1389         * Scripts/webkitpy/common/config/contributors.json:
1390
1391 2020-03-25  Frank Yang  <guowei_yang@apple.com>
1392
1393         Unprefix -webkit-text-orientation
1394         https://bugs.webkit.org/show_bug.cgi?id=196139
1395
1396         Reviewed by Myles C. Maxfield.
1397
1398         This change is made to add the extra flag "related-property" in CSSProperty.json
1399         in the jsonchecker so that the jsonchecker would not complain about unrecognized key
1400
1401         * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property
1402         (JSONCSSPropertiesChecker.check_codegen_properties): 
1403
1404 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
1405
1406         [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
1407         https://bugs.webkit.org/show_bug.cgi?id=209550
1408
1409         Reviewed by Jonathan Bedard.
1410
1411         * BuildSlaveSupport/ews-build/steps.py:
1412         (FindModifiedChangeLogs): Set haltOnFailure to false.
1413         (FindModifiedChangeLogs.getResultSummary):
1414         (FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
1415         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1416
1417 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
1418
1419         [ews] status-bubble should link to buildbot queue while waiting in queue
1420         https://bugs.webkit.org/show_bug.cgi?id=209543
1421
1422         Reviewed by Jonathan Bedard.
1423
1424         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1425         (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
1426         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1427         (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
1428
1429 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
1430
1431         [GTK] Add user agent quirk for auth.mayohr.com
1432         https://bugs.webkit.org/show_bug.cgi?id=209378
1433
1434         Reviewed by Michael Catanzaro.
1435
1436         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1437         (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
1438         (TestWebKitAPI::TEST):
1439
1440 2020-03-24  Daniel Bates  <dabates@apple.com>
1441
1442         Unreviewed, reverting r258945.
1443
1444         Revert change that broke API tests while I investigate
1445         offline.
1446
1447         Reverted changeset:
1448
1449         "Element context character rects may be in wrong coordinate
1450         system"
1451         https://bugs.webkit.org/show_bug.cgi?id=209493
1452         https://trac.webkit.org/changeset/258945
1453
1454 2020-03-24  Jiewen Tan  <jiewen_tan@apple.com>
1455
1456         Unreviewed, skips a test for iOS
1457
1458         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1459
1460 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
1461
1462         results.webkit.org: Documentation for uncollapsed failure endpoints is wrong
1463         https://bugs.webkit.org/show_bug.cgi?id=209496
1464
1465         Rubber-stamped by Aakash Jain.
1466
1467         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1468
1469 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
1470
1471         results.webkit.org: Filter suite results by expectation by default
1472         https://bugs.webkit.org/show_bug.cgi?id=209500
1473
1474         Rubber-stamped by Aakash Jain.
1475
1476         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Allow the Legend constructor
1477         to set a willFilterExpected default.
1478         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1479
1480 2020-03-24  Per Arne Vollan  <pvollan@apple.com>
1481
1482         [Cocoa] Fix launch time regression with CF prefs direct mode enabled
1483         https://bugs.webkit.org/show_bug.cgi?id=209244
1484
1485         Reviewed by Darin Adler.
1486
1487         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1488         (TEST):
1489         (sharedInstanceMethodOverride):
1490
1491 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
1492
1493         results.webkit.org: Correct UUID capitalization in documentation
1494         https://bugs.webkit.org/show_bug.cgi?id=209497
1495
1496         Reviewed by Aakash Jain.
1497
1498         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1499
1500 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
1501
1502         [ews] commit-queue should comment on bug if it fails to create git commit
1503         https://bugs.webkit.org/show_bug.cgi?id=209487
1504
1505         Reviewed by Jonathan Bedard.
1506
1507         * BuildSlaveSupport/ews-build/steps.py:
1508         (CreateLocalGITCommit):
1509         (CreateLocalGITCommit.start):
1510         (CreateLocalGITCommit.evaluateCommand):
1511         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1512
1513 2020-03-24  Daniel Bates  <dabates@apple.com>
1514
1515         Element context character rects may be in wrong coordinate system
1516         https://bugs.webkit.org/show_bug.cgi?id=209493
1517         <rdar://problem/60840261>
1518
1519         Reviewed by Wenson Hsieh.
1520
1521         Add some tests.
1522
1523         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1524         (TEST):
1525
1526 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
1527
1528         [ews] position in queue shown in status-bubble is larger than actual position
1529         https://bugs.webkit.org/show_bug.cgi?id=209481
1530
1531         Reviewed by Jonathan Bedard.
1532
1533         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1534         (StatusBubble._queue_position): Use created timestamp instead of modified.
1535
1536 2020-03-24  Daniel Bates  <dabates@apple.com>
1537
1538         [iOS][WK2] Set text trait isSingleLineDocument
1539         https://bugs.webkit.org/show_bug.cgi?id=209391
1540         <rdar://problem/60705870>
1541
1542         Reviewed by Darin Adler.
1543
1544         Add a test.
1545
1546         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1547         (TestWebKitAPI::TEST):
1548         * TestWebKitAPI/ios/UIKitSPI.h: Expose more SPI.
1549
1550 2020-03-24  Alex Christensen  <achristensen@webkit.org>
1551
1552         Unreviewed, reverting r258862.
1553
1554         SPI was not what was needed
1555
1556         Reverted changeset:
1557
1558         "Add SPI to move localStorage to a different domain"
1559         https://bugs.webkit.org/show_bug.cgi?id=209260
1560         https://trac.webkit.org/changeset/258862
1561
1562 2020-03-24  Chris Lord  <clord@igalia.com>
1563
1564         [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
1565         https://bugs.webkit.org/show_bug.cgi?id=209478
1566
1567         Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.
1568
1569         Reviewed by Philippe Normand.
1570
1571         * flatpak/flatpakutils.py:
1572         (WebkitFlatpak.run_in_sandbox):
1573
1574 2020-03-23  Simon Fraser  <simon.fraser@apple.com>
1575
1576         [mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
1577         https://bugs.webkit.org/show_bug.cgi?id=209427
1578
1579         Reviewed by Wenson Hsieh.
1580         
1581         0 => NULL
1582
1583         * DumpRenderTree/mac/DumpRenderTree.mm:
1584         (invalidateAnyPreviousWaitToDumpWatchdog):
1585
1586 2020-03-23  Dean Jackson  <dino@apple.com>
1587
1588         webkitpy Git class must expose the repository URL
1589         https://bugs.webkit.org/show_bug.cgi?id=209439
1590         <rdar://problem/60792668>
1591
1592         Reviewed by Simon Fraser.
1593
1594         Some internal tools were relying on the svn_url() method
1595         that was changed/removed in r258164. Add a replacement.
1596
1597         * Scripts/webkitpy/common/checkout/scm/git.py:
1598         (Git.svn_repository_url):
1599
1600 2020-03-23  Alex Christensen  <achristensen@webkit.org>
1601
1602         Fix memory leak introduced in r257726
1603         https://bugs.webkit.org/show_bug.cgi?id=208399
1604
1605         Reviewed by John Wilander.
1606
1607         * WebKitTestRunner/TestController.cpp:
1608         (WTR::TestController::websiteDataStore):
1609         We were leaking page configurations.
1610
1611 2020-03-23  John Wilander  <wilander@apple.com>
1612
1613         Add the capability to change all of a website's cookies to SameSite=Strict
1614         https://bugs.webkit.org/show_bug.cgi?id=209369
1615         <rdar://problem/60710690>
1616
1617         Reviewed by Alex Christensen and David Kilzer.
1618
1619         These changes add TestRunner function statisticsSetToSameSiteStrictCookies().
1620
1621         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1622         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1623         (WTR::InjectedBundle::didReceiveMessageToPage):
1624         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1625         (WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
1626         (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):
1627         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1628         * WebKitTestRunner/TestController.cpp:
1629         (WTR::TestController::setStatisticsToSameSiteStrictCookies):
1630         * WebKitTestRunner/TestController.h:
1631         * WebKitTestRunner/TestInvocation.cpp:
1632         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1633         (WTR::TestInvocation::didSetToSameSiteStrictCookies):
1634         * WebKitTestRunner/TestInvocation.h:
1635
1636 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
1637
1638         Uneviewed, added myself to contributors.json.
1639
1640         * Scripts/webkitpy/common/config/contributors.json:
1641
1642 2020-03-23  Daniel Bates  <dabates@apple.com>
1643
1644         Support inserting text or dictation alternative by simulating keyboard input
1645         https://bugs.webkit.org/show_bug.cgi?id=209380
1646         <rdar://problem/59445102>
1647
1648         Reviewed by Darin Adler.
1649
1650         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
1651         is enabled.
1652
1653         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
1654         compare NSObjects so long as they implement -isEqual and -description. I
1655         make use of this to compare the actual array of fired DOM events types to
1656         an expected array.
1657
1658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1659         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1660         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
1661         (TestWebKitAPI::TEST):
1662         * TestWebKitAPI/cocoa/TestCocoa.h:
1663         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
1664         (EXPECT_NS_EQUAL): Added.
1665         * TestWebKitAPI/ios/insert-text.html: Added.
1666
1667 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
1668
1669         Add checks for app-bound navigations when evaluating user style sheets
1670         https://bugs.webkit.org/show_bug.cgi?id=209368
1671         <rdar://problem/60204230>
1672
1673         Reviewed by Brent Fulgham.
1674
1675         Tested cases based on those in UserContentController.mm.
1676
1677         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1678         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
1679         (expectScriptEvaluatesToColor):
1680         (TEST):
1681
1682
1683 2020-03-23  Alex Christensen  <achristensen@webkit.org>
1684
1685         Add SPI to move localStorage to a different domain
1686         https://bugs.webkit.org/show_bug.cgi?id=209260
1687         <rdar://problem/60285683>
1688
1689         Reviewed by Brady Eidson.
1690
1691         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1692         (TEST):
1693
1694 2020-03-23  youenn fablet  <youenn@apple.com>
1695
1696         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
1697         https://bugs.webkit.org/show_bug.cgi?id=209428
1698
1699         Reviewed by Jonathan Bedard.
1700
1701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1702
1703 2020-03-23  Chris Lord  <clord@igalia.com>
1704
1705         Add missing committer status to Chris Lord in contributors.json
1706
1707         Unreviewed
1708
1709         * Scripts/webkitpy/common/config/contributors.json:
1710
1711 2020-03-23  youenn fablet  <youenn@apple.com>
1712
1713         StringView::startsWith and String::startsWith do not treat null strings the same
1714         https://bugs.webkit.org/show_bug.cgi?id=209273
1715
1716         Reviewed by Darin Adler.
1717
1718         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1719         (TestWebKitAPI::TEST):
1720         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1721         (TestWebKitAPI::TEST):
1722
1723 2020-03-22  Antoine Quint  <graouts@apple.com>
1724
1725         DocumentTimeline / CSSTransition objects are leaking on CNN.com
1726         https://bugs.webkit.org/show_bug.cgi?id=208069
1727         <rdar://problem/59680143>
1728
1729         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
1730
1731         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
1732
1733         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1734         (TestWebKitAPI::ListHashSetReferencedItem::create):
1735         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
1736         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
1737         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
1738         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
1739         (TestWebKitAPI::FakeElementAnimationRareData::collection):
1740         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
1741         (TestWebKitAPI::TEST):
1742
1743 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
1744
1745         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
1746         https://bugs.webkit.org/show_bug.cgi?id=208970
1747
1748         Reviewed by Konstantin Tokarev.
1749
1750         We are allowed to use /usr/bin/env in this script because it's not installed (so not
1751         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
1752         case.
1753
1754         * gtkdoc/generate-gtkdoc:
1755
1756 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
1757
1758         run-webkit-tests: Report MacCatalyst as a unique platform
1759         https://bugs.webkit.org/show_bug.cgi?id=209361
1760
1761         Rubber-stamped by Aakash Jain.
1762
1763         * Scripts/webkitpy/port/mac.py:
1764         (MacCatalystPort):
1765         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
1766
1767 2020-03-20  Alex Christensen  <achristensen@webkit.org>
1768
1769         CORS-disabling SPI introduced in r253978 should make responses non-opaque
1770         https://bugs.webkit.org/show_bug.cgi?id=209351
1771         <rdar://problem/60024850>
1772
1773         Reviewed by Chris Dumez.
1774
1775         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1776
1777 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1778
1779         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
1780         https://bugs.webkit.org/show_bug.cgi?id=208938
1781
1782         Reviewed by Jonathan Bedard.
1783
1784         * BuildSlaveSupport/ews-build/steps.py:
1785         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
1786         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
1787         (CheckPatchStatusOnEWSQueues.get_patch_status):
1788         (CheckPatchStatusOnEWSQueues.start):
1789         * BuildSlaveSupport/ews-build/steps_unittest.py:
1790         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
1791         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
1792         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1793         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
1794
1795 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1796
1797         [ews] Better organize patch status api data
1798         https://bugs.webkit.org/show_bug.cgi?id=209342
1799
1800         Reviewed by Jonathan Bedard.
1801
1802         * BuildSlaveSupport/ews-app/ews/views/status.py:
1803         (Status._build_status):
1804         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
1805         (Status.get): Remove safe=false now that we are returning a dictionary.
1806
1807 2020-03-20  Tim Horton  <timothy_horton@apple.com>
1808
1809         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
1810         https://bugs.webkit.org/show_bug.cgi?id=209307
1811
1812         Reviewed by Andy Estes.
1813
1814         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1815
1816 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
1817
1818         Unreviewed, reverting r258748.
1819
1820         This commit broke the Catalina build
1821
1822         Reverted changeset:
1823
1824         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
1825         https://bugs.webkit.org/show_bug.cgi?id=209307
1826         https://trac.webkit.org/changeset/258748
1827
1828 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1829
1830         [ews] commit-queue should comment on bug if patch fails to apply
1831         https://bugs.webkit.org/show_bug.cgi?id=209334
1832
1833         Reviewed by Jonathan Bedard.
1834
1835         * BuildSlaveSupport/ews-build/steps.py:
1836         (ApplyPatch):
1837         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
1838         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1839         (TestApplyPatch):
1840         (TestApplyPatch.setUp):
1841         (TestApplyPatch.setUp.mock_start):
1842         (TestApplyPatch.tearDown):
1843         (TestApplyPatch.test_success):
1844         (TestApplyPatch.test_failure):
1845         (TestApplyPatch.test_failure_on_commit_queue):
1846
1847 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
1848
1849         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
1850         https://bugs.webkit.org/show_bug.cgi?id=209122
1851
1852         Reviewed by Jonathan Bedard.
1853
1854         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1855         (StatusBubble._build_bubble):
1856
1857 2020-03-19  Tim Horton  <timothy_horton@apple.com>
1858
1859         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
1860         https://bugs.webkit.org/show_bug.cgi?id=209307
1861
1862         Reviewed by Andy Estes.
1863
1864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1865
1866 2020-03-19  Alex Christensen  <achristensen@webkit.org>
1867
1868         Remove test failing after r258734
1869         https://bugs.webkit.org/show_bug.cgi?id=209303
1870
1871         We removed the functionality it was testing because it did nothing useful except call the callback.
1872         I'm about to remove the only user of WKContextGetStatistics.
1873
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
1876
1877 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
1878
1879         commit-queue status-bubble shows incorrect position in queue
1880         https://bugs.webkit.org/show_bug.cgi?id=209313
1881
1882         Reviewed by Jonathan Bedard.
1883
1884         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1885         (StatusBubble._queue_position):
1886
1887 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
1888
1889         [Curl] Add an API returns description of verification errors.
1890         https://bugs.webkit.org/show_bug.cgi?id=208913
1891
1892         Reviewed by Fujii Hironori.
1893
1894         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
1895         Browser can display more precise error information with this API.
1896
1897         API Test: Curl.CertificateAPI
1898
1899         * MiniBrowser/win/Common.cpp:
1900         (askServerTrustEvaluation):
1901         * MiniBrowser/win/Common.h:
1902         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1903         (createPEMString):
1904         (WebKitBrowserWindow::canTrustServerCertificate):
1905         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
1906         (TestWebKitAPI::Curl::TEST):
1907
1908 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
1909
1910         Update build.webkit.org link for EWS
1911         https://bugs.webkit.org/show_bug.cgi?id=209280
1912
1913         Reviewed by Alexey Proskuryakov.
1914
1915         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1916
1917 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
1918
1919         [WinCairo] extract-built-product fails after r258612
1920         https://bugs.webkit.org/show_bug.cgi?id=209285
1921
1922         extractBuiltProduct also references the old name for the
1923         requirements on wincairo.
1924
1925         Reviewed by Ross Kirsling.
1926
1927         * BuildSlaveSupport/built-product-archive:
1928
1929 2020-03-19  Philippe Normand  <pnormand@igalia.com>
1930
1931         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
1932         https://bugs.webkit.org/show_bug.cgi?id=209223
1933
1934         Reviewed by Carlos Alberto Lopez Perez.
1935
1936         flatpak build doesn't expose a --socket option for white-listing
1937         the systemd journal socket. So white-list everything in /run. 🤷
1938
1939         * flatpak/flatpakutils.py:
1940         (WebkitFlatpak.run_in_sandbox):
1941
1942 2020-03-19  Charlie Turner  <cturner@igalia.com>
1943
1944         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
1945         https://bugs.webkit.org/show_bug.cgi?id=209146
1946
1947         Reviewed by Darin Adler.
1948
1949         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1950         (TestWebKitAPI::TEST):
1951         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1952         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1953         (testDownloadMIMEType):
1954         (testContextMenuDownloadActions):
1955         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1956
1957 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1958
1959         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
1960         https://bugs.webkit.org/show_bug.cgi?id=209278
1961
1962         Reviewed by Philippe Normand.
1963
1964         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
1965         means flatpak.
1966
1967         * Scripts/webkitdirs.pm:
1968         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
1969
1970 2020-03-19  Philippe Normand  <pnormand@igalia.com>
1971
1972         [CMake] cache not cleared when build-webkit options change
1973         https://bugs.webkit.org/show_bug.cgi?id=209277
1974
1975         Reviewed by Adrian Perez de Castro.
1976
1977         * Scripts/webkitdirs.pm:
1978         (shouldRemoveCMakeCache): The expected function signature never
1979         included the cache file path. Remove it.
1980
1981 2020-03-18  Philippe Normand  <pnormand@igalia.com>
1982
1983         REGRESSION(r258626): webkit-dirs warning
1984         https://bugs.webkit.org/show_bug.cgi?id=209221
1985
1986         Reviewed by Adrian Perez de Castro.
1987
1988         * Scripts/webkitdirs.pm:
1989         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
1990
1991 2020-03-19  Chris Lord  <clord@igalia.com>
1992
1993         Add Chris Lord (clord@igalia.com) to the list of contributors
1994         https://bugs.webkit.org/show_bug.cgi?id=209274
1995
1996         Unreviewed
1997
1998         * Scripts/webkitpy/common/config/contributors.json:
1999
2000 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
2001
2002         Remove commit queue bubble from bot watchers dashboard
2003         https://bugs.webkit.org/show_bug.cgi?id=209271
2004
2005         Reviewed by Alexey Proskuryakov.
2006
2007         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
2008
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2010         (BubbleQueueServer): 
2011
2012 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
2013
2014         eventSender.monitorWheelEvents() is very fragile
2015         https://bugs.webkit.org/show_bug.cgi?id=197819
2016         <rdar://problem/51319456>
2017
2018         Reviewed by Tim Horton.
2019
2020         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
2021         adding back changes from r257844 that were reverted in r258558.
2022         
2023         First, have EventSendingController keep track of whether it's seen then "end" event
2024         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
2025         now waits until it sees these, which prevents premature triggering which was a common cause of
2026         failure before.
2027         
2028         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
2029         for completion in a callout from the end of Page::updateRendering(), which makes it test
2030         and fire at a more consistent time.
2031         
2032         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
2033         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
2034         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
2035         also resulting in a premature trigger.
2036
2037         * DumpRenderTree/mac/EventSendingController.h:
2038         * DumpRenderTree/mac/EventSendingController.mm:
2039         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2040         (-[EventSendingController monitorWheelEvents]):
2041         (-[EventSendingController callAfterScrollingCompletes:]):
2042         * DumpRenderTree/win/EventSender.cpp:
2043         (mouseScrollBy):
2044         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2045         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2046         (WTR::EventSendingController::monitorWheelEvents):
2047         (WTR::EventSendingController::callAfterScrollingCompletes):
2048         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2049
2050 2020-03-18  John Wilander  <wilander@apple.com>
2051
2052         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
2053         https://bugs.webkit.org/show_bug.cgi?id=209245
2054         <rdar://problem/60511121>
2055
2056         Reviewed by Chris Dumez.
2057
2058         These changes to the TestRunner makes sure that
2059         - statisticsClearInMemoryAndPersistentStore()
2060         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
2061         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
2062         and adds the infrastructure for that.
2063
2064         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2065         (WTR::InjectedBundle::didReceiveMessageToPage):
2066         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2067         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2068         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2069         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
2070         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2073         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2074         * WebKitTestRunner/TestInvocation.cpp:
2075         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
2076         * WebKitTestRunner/TestInvocation.h:
2077
2078 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2079
2080         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
2081         https://bugs.webkit.org/show_bug.cgi?id=209218
2082         <rdar://problem/60560831>
2083
2084         Reviewed by Tim Horton.
2085
2086         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
2087         those views must be parented (i.e. they must be connected to a UIWindow).
2088
2089         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2090         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2091         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
2092         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
2093
2094 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [ews] commit-queue should comment on bug in case of test failures
2097         https://bugs.webkit.org/show_bug.cgi?id=209226
2098
2099         Reviewed by Jonathan Bedard.
2100
2101         * BuildSlaveSupport/ews-build/steps.py:
2102         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
2103         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
2104         (SetBuildSummary): Ditto.
2105         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2106
2107 2020-03-18  Philippe Normand  <pnormand@igalia.com>
2108
2109         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
2110         https://bugs.webkit.org/show_bug.cgi?id=209238
2111
2112         Reviewed by Jonathan Bedard.
2113
2114         * Scripts/test262-runner: Perform the flatpak check on Linux only.
2115
2116 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
2117
2118         [WinCairo] archive-built-product fails after r258612
2119         https://bugs.webkit.org/show_bug.cgi?id=209237
2120
2121         Reviewed by Alex Christensen.
2122
2123         * BuildSlaveSupport/built-product-archive:
2124         Update name of version file for requirements version
2125         file for wincairo.
2126
2127 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
2128
2129         commit-queue should allow patches which are reviewed by patch author
2130         https://bugs.webkit.org/show_bug.cgi?id=209231
2131
2132         Reviewed by Jonathan Bedard.
2133
2134         * BuildSlaveSupport/ews-build/steps.py:
2135         (BugzillaMixin._does_patch_have_acceptable_review_flag):
2136
2137 2020-03-18  Philippe Normand  <pnormand@igalia.com>
2138
2139         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
2140         https://bugs.webkit.org/show_bug.cgi?id=209222
2141
2142         Reviewed by Carlos Alberto Lopez Perez.
2143
2144         * Scripts/webkitdirs.pm:
2145         (runInFlatpakIfAvailable): If a command wrapper is required it
2146         means Flatpak shouldn't be used.
2147
2148 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
2149
2150         [ews] commit-queue should comment on bug in case patch fails to build
2151         https://bugs.webkit.org/show_bug.cgi?id=209227
2152
2153         Reviewed by Jonathan Bedard.
2154
2155         * BuildSlaveSupport/ews-build/steps.py:
2156         (AnalyzeCompileWebKitResults.start):
2157         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2158
2159 2020-03-18  Philippe Normand  <pnormand@igalia.com>
2160
2161         [GTK][WPE] Migrate to Flatpak-based dev SDK
2162         https://bugs.webkit.org/show_bug.cgi?id=205658
2163
2164         Reviewed by Carlos Alberto Lopez Perez.
2165
2166         JHBuild will now be used only if the WEBKIT_JHBUILD environment
2167         variable is set to 1, which is the case for the time being on the
2168         GTK and WPE EWS/build bots.
2169
2170         By default the build dependencies are now locally installed from a
2171         Flatpak repository hosted at https://software.igalia.com. The
2172         repository can be regenerated with the scripts from the
2173         webkit-flatpak-sdk Github project
2174         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
2175         transparently with the update-webkit{gtk,wpe}-libs scripts. As
2176         there is no need to rebuild the dependencies from scratch, the
2177         developer user-experience should now be much more friendly and
2178         overall build times reduced.
2179
2180         As an additional commodity, the new environment supports the
2181         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
2182         environment variable to your gst-build path. This feature was
2183         contributed by Thibault Saunier.
2184
2185         The JHBuild infrastructure will be removed once all the bots have
2186         been switched over to Flatpak.
2187
2188         * BuildSlaveSupport/ews-build/steps.py:
2189         (InstallGtkDependencies):
2190         (InstallWpeDependencies):
2191         (CompileWebKit.start):
2192         * BuildSlaveSupport/gtk/buildbot/run:
2193         * Scripts/build-webkit:
2194         * Scripts/run-bindings-tests:
2195         * Scripts/run-builtins-generator-tests:
2196         * Scripts/run-gtk-tests:
2197         * Scripts/run-javascriptcore-tests:
2198         * Scripts/run-minibrowser:
2199         * Scripts/run-qt-wpe-minibrowser:
2200         * Scripts/run-webdriver-tests:
2201         * Scripts/run-wpe-tests:
2202         * Scripts/test-webkitperl:
2203         * Scripts/test-webkitpy:
2204         * Scripts/test262-runner:
2205         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
2206         * Scripts/update-webkitgtk-libs:
2207         * Scripts/update-webkitwpe-flatpak: Removed.
2208         * Scripts/update-webkitwpe-libs:
2209         * Scripts/webkitdirs.pm:
2210         (getUserFlatpakPath):
2211         (inFlatpakSandbox):
2212         (runInFlatpakIfAvailable):
2213         (wrapperPrefixIfNeeded):
2214         (shouldUseJhbuild):
2215         (shouldUseFlatpak):
2216         (shouldRemoveCMakeCache):
2217         * Scripts/webkitpy/common/system/executive.py:
2218         (Executive.kill_all):
2219         * Scripts/webkitpy/port/base.py:
2220         (Port._path_to_apache):
2221         (Port._should_run_as_pixel_test):
2222         (Port._in_flatpak_sandbox):
2223         * Scripts/webkitpy/port/gtk.py:
2224         (GtkPort.setup_environ_for_server):
2225         (GtkPort._get_crash_log):
2226         * Scripts/webkitpy/port/linux_get_crash_log.py:
2227         (GDBCrashLogGenerator):
2228         (GDBCrashLogGenerator.__init__):
2229         (GDBCrashLogGenerator.generate_crash_log):
2230         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2231         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2232         * Scripts/webkitpy/port/wpe.py:
2233         (WPEPort.setup_environ_for_server):
2234         (WPEPort._get_crash_log):
2235         * Scripts/webkitpy/port/xvfbdriver.py:
2236         (XvfbDriver._setup_environ_for_test):
2237         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2238         (WTR::getFontsPath):
2239         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2240         (WTR::getFontsPath):
2241         * flatpak/files/default.xkm: Removed.
2242         * flatpak/files/httpd-autogen.sh: Removed.
2243         * flatpak/flatpakutils.py:
2244         (check_flatpak):
2245         (FlatpakRepos.update):
2246         (FlatpakPackage.__repr__):
2247         (FlatpakPackage.__str__):
2248         (WebkitFlatpak.load_from_args):
2249         (WebkitFlatpak.__init__):
2250         (WebkitFlatpak.clean_args):
2251         (WebkitFlatpak.setup_builddir):
2252         (WebkitFlatpak):
2253         (WebkitFlatpak.setup_gstbuild):
2254         (WebkitFlatpak.run_in_sandbox):
2255         (WebkitFlatpak.run):
2256         (WebkitFlatpak.has_environment):
2257         (WebkitFlatpak.save_config):
2258         (WebkitFlatpak.setup_dev_env):
2259         (WebkitFlatpak.install_all):
2260         (WebkitFlatpak.run_gdb):
2261         * flatpak/org.webkit.CommonModules.yaml: Removed.
2262         * flatpak/org.webkit.GTK.yaml: Removed.
2263         * flatpak/org.webkit.WPE.yaml: Removed.
2264         * flatpak/org.webkit.WPEModules.yaml: Removed.
2265         * flatpak/org.webkit.WPEQT.yaml: Removed.
2266         * flatpak/org.webkit.WebKit.yaml: Removed.
2267         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
2268         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
2269         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
2270
2271 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
2272
2273         Expand In-App-Browser-Privacy testing
2274         https://bugs.webkit.org/show_bug.cgi?id=209142
2275         <rdar://problem/60496618>
2276
2277         Reviewed by Darin Adler.
2278
2279         Expanded test coverage by adding new tests and creating a custom url
2280         scheme handler to get around the fact that local file loads are
2281         always classified as app-bound.
2282
2283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2284         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2285         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
2286         If the path indicates testing user scripts on load, notify the script message
2287         handler that the navigation has finished. If the path indicates
2288         testing user-agent scripts, set the window.wkUserScriptInjected
2289         variable to true. A user agent script will attempt to read this
2290         variable and should fail.
2291
2292         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
2293         (initializeInAppBrowserPrivacyTestSettings):
2294         Basic test setup. Initialize the main run loop and make sure we are
2295         starting with a clean state.
2296
2297         (TEST):
2298         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
2299         except for blob files which must be generated within the web content.
2300
2301         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
2302         Basic html document to test local file loads are classified as
2303         app-bound.
2304
2305         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
2306         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
2307         These files are no longer needed as their content is directly copied
2308         into the URL scheme handler.
2309
2310 2020-03-17  Chris Dumez  <cdumez@apple.com>
2311
2312         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
2313         https://bugs.webkit.org/show_bug.cgi?id=207307
2314         <rdar://problem/59206964>
2315
2316         Reviewed by Alex Christensen.
2317
2318         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
2319         notifications from the map but not tell WebCore that the notification were discarded. As a result,
2320         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
2321         notification would no longer be in the map, causing us to hit an assertion in debug.
2322
2323         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
2324         to let WebCore know the notification was discarded. This is similar to what is already done for
2325         WebKit2 in WebNotificationManager::clearNotifications().
2326
2327         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2328         (-[MockWebNotificationProvider reset]):
2329
2330 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
2331
2332         [WinCairo][FTW] Update path to requirements download
2333         https://bugs.webkit.org/show_bug.cgi?id=209202
2334
2335         Reviewed by Ross Kirsling.
2336
2337         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
2338         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
2339         WebKitRequirementsWin64.zip.
2340
2341         * Scripts/update-webkit-wincairo-libs.py:
2342
2343 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
2346         https://bugs.webkit.org/show_bug.cgi?id=208920
2347
2348         Reviewed by Jonathan Bedard.
2349
2350         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2351         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
2352         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
2353         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
2354         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
2355         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
2356         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2357         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
2358         for commit-queue which isn't expected to change.
2359         (BugzillaPatchFetcher.fetch_commit_queue_patches):
2360         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
2361         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
2362         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
2363         setting cq+ flag on bugzilla.
2364
2365 2020-03-17  Chris Dumez  <cdumez@apple.com>
2366
2367         [WKTR] testRunner API that takes in a completion handler should use async IPC
2368         https://bugs.webkit.org/show_bug.cgi?id=209187
2369
2370         Reviewed by John Wilander.
2371
2372         testRunner API that takes in a completion handler should use async IPC. This hangs
2373         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
2374         to IPC the WebProcess as a result of this testRunner call.
2375
2376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2377         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2378         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2379         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2380         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2381         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2382         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
2383         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
2384         (WTR::TestRunner::statisticsResetToConsistentState):
2385         (WTR::TestRunner::getAllStorageAccessEntries):
2386         (WTR::TestRunner::removeAllSessionCredentials):
2387         (WTR::TestRunner::getApplicationManifestThen):
2388         * WebKitTestRunner/TestInvocation.cpp:
2389         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2390         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2391
2392 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [ews-app] Timestamp shown in status-bubble hover-over message is in future
2395         https://bugs.webkit.org/show_bug.cgi?id=196628
2396
2397         Reviewed by Jonathan Bedard.
2398
2399         * BuildSlaveSupport/ews-build/events.py:
2400         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
2401         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2402         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
2403         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
2404
2405 2020-03-17  Alex Christensen  <achristensen@webkit.org>
2406
2407         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
2408         https://bugs.webkit.org/show_bug.cgi?id=209192
2409         <rdar://problem/51313336>
2410
2411         Reviewed by Geoff Garen.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2414         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
2415         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
2416         (TEST):
2417
2418 2020-03-17  Chris Dumez  <cdumez@apple.com>
2419
2420         Use less sync IPC for ITP testRunner methods
2421         https://bugs.webkit.org/show_bug.cgi?id=209184
2422
2423         Reviewed by Alex Christensen.
2424
2425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2426         (WTR::TestRunner::setStatisticsDebugMode):
2427         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2428         (WTR::TestRunner::setStatisticsLastSeen):
2429         (WTR::TestRunner::setStatisticsMergeStatistic):
2430         (WTR::TestRunner::setStatisticsPrevalentResource):
2431         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2432         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2433         * WebKitTestRunner/TestInvocation.cpp:
2434         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2435         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2436
2437 2020-03-17  Chris Dumez  <cdumez@apple.com>
2438
2439         [WKTR] Crash when trying to open a new window in an ephemeral session test
2440         https://bugs.webkit.org/show_bug.cgi?id=209181
2441
2442         Reviewed by Geoffrey Garen.
2443
2444         Make sure that the new WKWebView is using the same data store as its related WKWebView.
2445
2446         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2447         (WTR::TestController::platformCreateOtherPage):
2448
2449 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
2450
2451         Unreviewed, reverting r257844.
2452
2453         this revision caused a test to start timing out
2454
2455         Reverted changeset:
2456
2457         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
2458         zero.html is a flaky failure"
2459         https://bugs.webkit.org/show_bug.cgi?id=207948
2460         https://trac.webkit.org/changeset/257844
2461
2462 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
2463
2464         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
2465         https://bugs.webkit.org/show_bug.cgi?id=209151
2466
2467         Reviewed by Yusuke Suzuki.
2468
2469         * Scripts/webkitpy/common/config/contributors.json:
2470
2471 2020-03-16  Chris Dumez  <cdumez@apple.com>
2472
2473         Crash under WebCookieCache::clearForHost()
2474         https://bugs.webkit.org/show_bug.cgi?id=209149
2475         <rdar://problem/60453086>
2476
2477         Reviewed by Alex Christensen.
2478
2479         Add API test coverage.
2480
2481         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
2482         (TEST):
2483
2484 2020-03-16  Keith Rollin  <krollin@apple.com>
2485
2486         Remove support for WebKitSystemInterface
2487         https://bugs.webkit.org/show_bug.cgi?id=208894
2488         <rdar://problem/60297590>
2489
2490         Reviewed by Brent Fulgham.
2491
2492         This project provided support for facilities that are now handled
2493         elsewhere and is no longer needed.
2494
2495         * Scripts/copy-webkitlibraries-to-product-directory:
2496
2497 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
2498
2499         [macOS] Accessibility sandbox regressions
2500         https://bugs.webkit.org/show_bug.cgi?id=209065
2501
2502         Reviewed by Brent Fulgham.
2503
2504         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
2505         (TEST):
2506         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
2507         (TEST):
2508
2509 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
2510
2511         Unreviewed infrastructure fix.
2512
2513         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
2514         while the hardware is out for repair.
2515
2516 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
2517
2518         [WebXR] IDLs, stubs and build configuration for WPE
2519         https://bugs.webkit.org/show_bug.cgi?id=208702
2520
2521         Reviewed by Dean Jackson.
2522
2523         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
2524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
2525
2526 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
2527
2528         [Cocoa] Limit set of classes that can be decoded when a preference has changed
2529         https://bugs.webkit.org/show_bug.cgi?id=208012
2530
2531         Reviewed by Brent Fulgham.
2532
2533         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
2534         (TEST):
2535
2536 2020-03-16  youenn fablet  <youenn@apple.com>
2537
2538         Unique origins should not be Potentially Trustworthy
2539         https://bugs.webkit.org/show_bug.cgi?id=209049
2540
2541         Reviewed by Darin Adler.
2542
2543         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2544         (TestWebKitAPI::TEST_F):
2545
2546 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2547
2548         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
2549         https://bugs.webkit.org/show_bug.cgi?id=207324
2550
2551         Reviewed by Darin Adler.
2552
2553         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
2554         (TestWebKitAPI::generateRandomData): Added.
2555         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
2556
2557 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
2558
2559         Should not use variable-length-array (VLA)
2560         https://bugs.webkit.org/show_bug.cgi?id=209043
2561
2562         Reviewed by Mark Lam.
2563
2564         * ContentExtensionTester/Configurations/Base.xcconfig:
2565         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2566
2567 2020-03-13  Alex Christensen  <achristensen@webkit.org>
2568
2569         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
2570         https://bugs.webkit.org/show_bug.cgi?id=209011
2571         <rdar://problem/59370588>
2572
2573         Reviewed by Youenn Fablet.
2574
2575         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2576         (TestWebKitAPI::TEST):
2577
2578 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2579
2580         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
2581         https://bugs.webkit.org/show_bug.cgi?id=209089
2582
2583         Reviewed by Tim Horton.
2584
2585         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
2586         marketing name for the feature.
2587
2588         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2589         (runUntilReceivesAutoplayEvent):
2590
2591         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
2592         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
2593         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
2594         be any compelling reason to compare against different types here (especially since we only set
2595         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
2596         these all to be `_WKAutoplayEvent`.
2597
2598         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2599         (-[AutoFillTestView _autofillInputView]):
2600         (-[AutoFillTestView textInputHasAutoFillContext]):
2601         (TestWebKitAPI::TEST):
2602         (-[AutofillTestView initWithFrame:]): Deleted.
2603         (-[AutofillTestView _autofillInputView]): Deleted.
2604         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
2605         * TestWebKitAPI/ios/UIKitSPI.h:
2606
2607 2020-03-13  Chris Dumez  <cdumez@apple.com>
2608
2609         Unreviewed, reverting r256232.
2610
2611         Caused ResizeObserver tests to become flaky
2612
2613         Reverted changeset:
2614
2615         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
2616         override TestOptions"
2617         https://bugs.webkit.org/show_bug.cgi?id=207481
2618         https://trac.webkit.org/changeset/256232
2619
2620 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
2621
2622         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
2623         https://bugs.webkit.org/show_bug.cgi?id=209016
2624         <rdar://problem/60329530> 
2625
2626         Reviewed by Chris Dumez.
2627
2628         Re-initialize the app-bound domains when the correct
2629         TestOptions parameter is set.
2630
2631         * WebKitTestRunner/TestController.cpp:
2632         (WTR::TestController::createWebViewWithOptions):
2633         (WTR::TestController::reinitializeAppBoundDomains):
2634         * WebKitTestRunner/TestController.h:
2635
2636 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
2637
2638         Report all third party loads on a per-page basis
2639         https://bugs.webkit.org/show_bug.cgi?id=209032
2640         <rdar://problem/60397323>
2641
2642         Reviewed by Chris Dumez.
2643
2644         Mostly naming updates to reflect the change in use for this SPI call.
2645         It now returns all loaded third party domains, not just prevalent ones.
2646
2647         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2648         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2649         (WTR::InjectedBundle::didReceiveMessageToPage):
2650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2651         (WTR::TestRunner::getLoadedThirdPartyDomains):
2652         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
2653         (WTR::TestRunner::getPrevalentDomains): Deleted.
2654         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
2655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2656         * WebKitTestRunner/TestController.cpp:
2657         (WTR::TestController::resetStateToConsistentValues):
2658         (WTR::TestController::getLoadedThirdPartyDomains):
2659         (WTR::TestController::clearLoadedThirdPartyDomains):
2660         (WTR::TestController::getPrevalentDomains): Deleted.
2661         (WTR::TestController::clearPrevalentDomains): Deleted.
2662         * WebKitTestRunner/TestController.h:
2663         * WebKitTestRunner/TestInvocation.cpp:
2664         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2665         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
2666         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
2667         * WebKitTestRunner/TestInvocation.h:
2668         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2669         (WTR::TestController::getLoadedThirdPartyDomains):
2670         (WTR::TestController::clearLoadedThirdPartyDomains):
2671         (WTR::TestController::getPrevalentDomains): Deleted.
2672         (WTR::TestController::clearPrevalentDomains): Deleted.
2673
2674 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews] run FindModifiedChangeLogs early in the build
2677         https://bugs.webkit.org/show_bug.cgi?id=209060
2678
2679         Reviewed by Jonathan Bedard.
2680
2681         * BuildSlaveSupport/ews-build/factories.py:
2682         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
2683
2684 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
2685
2686         [GTK] Add EWS testers to run GTK layout tests
2687         https://bugs.webkit.org/show_bug.cgi?id=207648
2688
2689         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
2690
2691         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
2692         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
2693         tests (layout tests).
2694
2695         * BuildSlaveSupport/ews-build/config.json: Added new queue for
2696         WK2 tests.
2697         * BuildSlaveSupport/ews-build/factories.py:
2698         (GTKTestsFactory):
2699         * BuildSlaveSupport/ews-build/factories_unittest.py:
2700         (TestCommitQueueFactory.test_commit_queue_factory):
2701         (TestGTKFactory): Added unit-test.
2702         (TestGTKFactory.test_gtk_factory):
2703         * BuildSlaveSupport/ews-build/loadConfig.py:
2704         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2705         (TagsForBuilderTest.test_getTagsForBuilder):
2706
2707 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
2708
2709         Add API endpoint in EWS django app to provide patch status in json format
2710         https://bugs.webkit.org/show_bug.cgi?id=208940
2711
2712         Reviewed by Jonathan Bedard.
2713
2714         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
2715         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
2716
2717 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
2718
2719         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
2720         https://bugs.webkit.org/show_bug.cgi?id=209055
2721         <rdar://problem/60272692>
2722
2723         Reviewed by Simon Fraser.
2724
2725         Now that WebKitTestRunner has a bundleID, its' user default values
2726         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
2727         to NO before running tests. It will be set to YES in PlatformWebView
2728         if specified by the test.
2729
2730         * WebKitTestRunner/mac/main.mm:
2731         (setDefaultsToConsistentValuesForTesting):
2732
2733 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
2734
2735         [CMake] Eleminate mismatches between Find* module names and variables they set
2736         https://bugs.webkit.org/show_bug.cgi?id=208948
2737
2738         Reviewed by Michael Catanzaro.
2739
2740         * wpe/backends/CMakeLists.txt:
2741
2742 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [ews-app] reduce logging
2745         https://bugs.webkit.org/show_bug.cgi?id=209062
2746
2747         Reviewed by Jonathan Bedard.
2748
2749         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
2750         (BugzillaBeautifulSoup.authenticate):
2751         (BugzillaBeautifulSoup._load_query):
2752
2753 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2754
2755         Crash in TextIterator::node via TextManipulationController::replace
2756         https://bugs.webkit.org/show_bug.cgi?id=209048
2757
2758         Reviewed by Wenson Hsieh.
2759
2760         Added a regression test.
2761
2762         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2763         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
2764
2765 2020-03-13  Saam Barati  <sbarati@apple.com>
2766
2767         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
2768         https://bugs.webkit.org/show_bug.cgi?id=209038
2769
2770         Reviewed by Keith Miller.
2771
2772         This allows us to automatically pull in some tests that are in non open sourced Apple
2773         checkouts.
2774
2775         * Scripts/run-javascriptcore-tests:
2776         (runJSCStressTests):
2777
2778 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
2779
2780         Crash in TextManipulationController::replace
2781         https://bugs.webkit.org/show_bug.cgi?id=209021
2782
2783         Reviewed by Wenson Hsieh.
2784
2785         Added a regression test.
2786
2787         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2788         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
2789
2790 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
2791
2792         [macOS] _AXSApplicationAccessibilityEnabled should not be called
2793         https://bugs.webkit.org/show_bug.cgi?id=208953
2794
2795         Reviewed by Brent Fulgham.
2796
2797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2798
2799 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
2800
2801         Resource load statistics data summary should return all third party data
2802         https://bugs.webkit.org/show_bug.cgi?id=209000
2803         <rdar://problem/60348306>
2804
2805         Reviewed by John Wilander.
2806
2807         Marked only 2 of 3 domains prevalent in data summary tests to ensure
2808         the call returns all third parties, not just prevalent ones.
2809         Added a more aggressive check for the size of the array at the
2810         beginning of the test to ensure the array is still returning 3 values. 
2811         Also removed the ASSERT statements as they seem to cause timeouts (not
2812         clear crashes) when they are not true, which is hard to debug.
2813         If these values are nil, the test will fail in the EXPECT_WK_STREQ
2814         checks, we don't need ASSERT statements.
2815
2816         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2817         (TEST):
2818
2819 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
2820
2821         resultsdpy: Add script to run local instance
2822         https://bugs.webkit.org/show_bug.cgi?id=208746
2823
2824         Rubber-stamped by Aakash Jain.
2825
2826         * resultsdbpy/resultsdbpy/example: Added.
2827         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
2828         * resultsdbpy/resultsdbpy/example/environment.py: Added.
2829         (Environment): Organize environment variables used by results database.
2830         (ModelFromEnvironment): Construct the database model from the environment.
2831         (main): Create and drop tables, if required.
2832         * resultsdbpy/resultsdbpy/example/main.py: Added.
2833         (health): Web-server health check.
2834         (handle_errors):
2835         (main): Run results database web-server.
2836         * resultsdbpy/resultsdbpy/example/worker.py: Added.
2837         (main): Asynchronously process uploaded results.
2838         * resultsdbpy/resultsdbpy/run: Added.
2839
2840 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2841
2842         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
2843         https://bugs.webkit.org/show_bug.cgi?id=209004
2844
2845         Reviewed by Tim Horton.
2846
2847         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
2848         `use_gpu_process` is specified.
2849
2850         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2851         (parse_args):
2852
2853 2020-03-12  Matt Lewis  <jlewis3@apple.com>
2854
2855         Make flatpack import for run-webkit-tests only happen on linux systems
2856         https://bugs.webkit.org/show_bug.cgi?id=208954
2857
2858         Reviewed by Philippe Normand.
2859
2860         * Scripts/run-webkit-tests: Added an if statement to find the system platform
2861         to determine if we need the flatpackutils import. 
2862
2863 2020-03-12  Alex Christensen  <achristensen@webkit.org>
2864
2865         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
2866         https://bugs.webkit.org/show_bug.cgi?id=207609
2867
2868         Reviewed by Ryosuke Niwa.
2869
2870         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2871         (TestWebKitAPI::TEST):
2872
2873 2020-03-12  Daniel Bates  <dabates@apple.com>
2874
2875         FocusController::setFocusedElement() should tell client of refocused element
2876         https://bugs.webkit.org/show_bug.cgi?id=208880
2877
2878         Reviewed by Wenson Hsieh.
2879
2880         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
2881         to start an input session. Currently, it does not even try.
2882
2883         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2884         (TEST):
2885
2886 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
2887
2888         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
2889         https://bugs.webkit.org/show_bug.cgi?id=208970
2890
2891         Reviewed by Daniel Bates.
2892
2893         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
2894         #!/usr/bin/env python.
2895
2896         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
2897         probably has similar rules.
2898
2899         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
2900         Everything else that does so is probably only used by webkit-build.
2901
2902         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
2903
2904         * gtkdoc/generate-gtkdoc:
2905
2906 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
2907
2908         [WebAuthn] Formalize the Keychain schema
2909         https://bugs.webkit.org/show_bug.cgi?id=183533
2910         <rdar://problem/43347926>
2911
2912         Reviewed by Brent Fulgham.
2913
2914         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
2915         the original combination of RP ID and user handle.
2916
2917         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2919         (WTR::TestRunner::cleanUpKeychain):
2920         (WTR::TestRunner::keyExistsInKeychain):
2921         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2922         * WebKitTestRunner/TestController.h:
2923         * WebKitTestRunner/TestInvocation.cpp:
2924         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2925         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2926         (WTR::TestController::cleanUpKeychain):
2927         (WTR::TestController::keyExistsInKeychain):
2928
2929 2020-03-11  Keith Miller  <keith_miller@apple.com>
2930
2931         Test262-runner should always consider crashes as new failures
2932         https://bugs.webkit.org/show_bug.cgi?id=208943
2933
2934         Reviewed by Yusuke Suzuki.
2935
2936         Right now the runner will consider crashes with no output as passes, which is obviously bad.
2937         Since we should never crash on a conformance test we should consider a crash as a new failure
2938         100% of the time.
2939
2940         * Scripts/test262/Runner.pm:
2941         (processFile):
2942         (runTest):
2943         (processResult):
2944
2945 2020-03-11  Chris Dumez  <cdumez@apple.com>
2946
2947         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
2948         https://bugs.webkit.org/show_bug.cgi?id=208927
2949         <rdar://problem/55448331>
2950
2951         Reviewed by Alex Christensen.
2952
2953         Add API test coverage.
2954
2955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2956
2957 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
2958
2959         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
2960         https://bugs.webkit.org/show_bug.cgi?id=208860
2961
2962         Reviewed by Carlos Alberto Lopez Perez.
2963
2964         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2965         (StatusBubble): Added 'api-gtk'.
2966         * BuildSlaveSupport/ews-build/config.json:
2967         * BuildSlaveSupport/ews-build/factories.py:
2968         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
2969         GTK.
2970         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
2971         GTK.
2972         (GTKBuildFactory):
2973         (GTKBuildFactory.__init__): Deleted.
2974         (GTKBuildAndTestFactory): Deleted.
2975         (GTKBuildAndTestFactory.__init__): Deleted.
2976         (GTKAPIBuildAndTestFactory): Deleted.
2977         * BuildSlaveSupport/ews-build/loadConfig.py:
2978
2979 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
2980
2981         [ews] Add unit test to prevent multiple schedulers for a builder.
2982         https://bugs.webkit.org/show_bug.cgi?id=208917
2983
2984         Reviewed by Carlos Alberto Lopez Perez.
2985
2986         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2987         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
2988         (TagsForBuilderTest): Fixed a typo.
2989
2990 2020-03-11 Philippe Normand  <pnormand@igalia.com>
2991
2992         [GTK] Failing API tests under the Flatpak SDK environment
2993         https://bugs.webkit.org/show_bug.cgi?id=208871
2994
2995         Reviewed by Michael Catanzaro.
2996
2997         The load-failed signal callback should return a boolean result,
2998         otherwise we enter in unknown territory depending on how the
2999         toolchain compiles this, possibly triggering bad behavior (with
3000         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
3001         GCC toolchain on buildbots).
3002
3003         Patch suggested by Michael Catanzaro.
3004
3005         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3006         (loadFailedCallback):
3007
3008 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
3009
3010         Sync FeatureList.pm with CMake definitions
3011         https://bugs.webkit.org/show_bug.cgi?id=208866
3012
3013         Reviewed by Michael Catanzaro.
3014
3015         * Scripts/webkitperl/FeatureList.pm:
3016
3017 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3018
3019         [ews] Add unit tests for commit queue factory
3020         https://bugs.webkit.org/show_bug.cgi?id=208862
3021
3022         Reviewed by Jonathan Bedard.
3023
3024         * BuildSlaveSupport/ews-build/factories_unittest.py:
3025         (TestCommitQueueFactory):
3026         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
3027
3028 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-app] Status bubble should only display important messages in pop-over - part 3
3031         https://bugs.webkit.org/show_bug.cgi?id=208865
3032
3033         Reviewed by Jonathan Bedard.
3034
3035         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3036         (StatusBubble): Added more strings to STEPS_TO_HIDE.
3037
3038 2020-03-10  Lauro Moura  <lmoura@igalia.com>
3039
3040         [WPE] MiniBrowser: Close child WebViews when exiting
3041         https://bugs.webkit.org/show_bug.cgi?id=208689
3042
3043         Reviewed by Carlos Garcia Campos.
3044
3045         Store created views so we can release them before exiting.
3046
3047         * MiniBrowser/wpe/main.cpp:
3048         (webViewClose):
3049         (createWebView):
3050         (main):
3051
3052 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3053
3054         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
3055         https://bugs.webkit.org/show_bug.cgi?id=208861
3056
3057         Reviewed by Jonathan Bedard.
3058
3059         * BuildSlaveSupport/ews-build/factories.py:
3060         (Factory.__init__): Remove verifycqplus parameter.
3061         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
3062         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
3063         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
3064
3065 2020-03-10  Philippe Normand  <pnormand@igalia.com>
3066
3067         [GTK] API favicon test flaky timeouts
3068         https://bugs.webkit.org/show_bug.cgi?id=208189
3069
3070         Reviewed by Carlos Garcia Campos.
3071
3072         Sometimes the favicon changes already during the load. Keeping
3073         track of it in the WebView favicon property notification handler
3074         gets us rid of the race.
3075
3076         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3077         (testFaviconDatabaseGetFavicon):
3078
3079 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
3080
3081         Generate commit-queue status bubble from new EWS
3082         https://bugs.webkit.org/show_bug.cgi?id=208811
3083
3084         Reviewed by Jonathan Bedard.
3085
3086         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3087         (StatusBubble._build_bubbles_for_patch):
3088
3089 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
3090
3091         Remove obsolete feature flags
3092         https://bugs.webkit.org/show_bug.cgi?id=208830
3093
3094         Reviewed by Alex Christensen.
3095
3096         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
3097         are no longer used.
3098
3099         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
3100         when the compilation flag was removed in r258148.
3101
3102         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
3103         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
3104
3105         * Scripts/webkitperl/FeatureList.pm:
3106         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3107
3108 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
3109
3110         WebKitTestRunner bundleID should not be cleared before every test
3111         https://bugs.webkit.org/show_bug.cgi?id=208823
3112         <rdar://problem/60204539>
3113
3114         Reviewed by Per Arne Vollan.
3115
3116         This is causing test failures for layout tests which rely on the Info.plist 
3117         bundle identifier (not the one set via the override method).
3118
3119         * WebKitTestRunner/TestController.cpp:
3120         (WTR::TestController::createWebViewWithOptions):
3121         (WTR::TestController::ensureViewSupportsOptionsForTest):
3122         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3123
3124 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
3125
3126         [macOS] Notification observer is not removed
3127         https://bugs.webkit.org/show_bug.cgi?id=208834
3128
3129         Reviewed by Tim Horton.
3130
3131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3132         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
3133         (TEST):
3134
3135 2020-03-06  Brian Burg  <bburg@apple.com>
3136
3137         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
3138         https://bugs.webkit.org/show_bug.cgi?id=208729
3139         <rdar://problem/60105447>
3140
3141         Reviewed by Jonathan Bedard.
3142
3143         Improve upload.py to look for the svn branch and revision for the 'webkit'
3144         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
3145
3146         * Scripts/webkitpy/common/checkout/scm/git.py:
3147         (Git):
3148         (Git.git_svn_id_regexp):
3149         (Git._field_from_git_svn_id):
3150         (Git.svn_revision):
3151         (Git.svn_branch):
3152         (Git.svn_url):
3153         (Git.native_branch):
3154         Refactor svn revision, branch, url to use the same regexp and helper code.
3155
3156         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3157         (StubRepository.svn_branch):
3158         Expose a stub since this is used unconditionally by Port.commits_for_upload.
3159
3160         * Scripts/webkitpy/common/checkout/scm/svn.py:
3161         (SVN.svn_branch):
3162         (SVN.native_revision):
3163         (SVN):
3164         (SVN.native_branch):
3165         Refactor so the actual implementation is contained in svn_revision / svn_branch.
3166         The native_* methods call out to the SVN equivalents since this is an SVN repository.
3167
3168         * Scripts/webkitpy/port/base.py:
3169         (Port.commits_for_upload):
3170         Add special git-svn handling for the WebKit repository so that SVN branch and revision
3171         is preferred over the git equivalents.
3172
3173 2020-03-09  Antoine Quint  <graouts@apple.com>
3174
3175         TestWebKitAPI fails to build on watchOS
3176         https://bugs.webkit.org/show_bug.cgi?id=208820
3177
3178         Reviewed by Tim Horton.
3179
3180         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3181
3182 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
3183
3184         resultsdbpy: Add tool to manage resultsdbpy container
3185         https://bugs.webkit.org/show_bug.cgi?id=208743
3186
3187         Rubber-stamped by Aakash Jain.
3188
3189         Add tool to start, stop and restart the resultsdbpy Docker container.
3190
3191         * resultsdbpy/resultsdbpy/container: Added.
3192
3193 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3194
3195         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
3196         https://bugs.webkit.org/show_bug.cgi?id=208706
3197
3198         Reviewed by Žan Doberšek.
3199
3200         Add test case to check surrounding text in multiline context.
3201
3202         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
3203         (testWebKitInputMethodContextSurrounding):
3204
3205 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
3206
3207         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
3208         https://bugs.webkit.org/show_bug.cgi?id=208783
3209
3210         Reviewed by Brent Fulgham.
3211
3212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3213
3214 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
3215
3216         Replace the use of term "rollout" to "revert" in various tools
3217         https://bugs.webkit.org/show_bug.cgi?id=208775
3218
3219         Reviewed by Ryosuke Niwa.
3220
3221         See this webkit-dev thread for the originating discussion:
3222         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
3223
3224         'rollout' is a confusing term to anyone unacquainted with WebKit;
3225         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
3226
3227         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
3228         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3238         * BuildSlaveSupport/ews-build/steps.py:
3239         * BuildSlaveSupport/ews-build/steps_unittest.py:
3240         * Scripts/webkit-tools-completion.sh:
3241         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3242         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3243         * Scripts/webkitpy/common/checkout/scm/svn.py:
3244         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
3245         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3246         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3247         * Scripts/webkitpy/tool/bot/feeders.py:
3248         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3249         * Scripts/webkitpy/tool/bot/irc_command.py:
3250         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3251         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3252         * Scripts/webkitpy/tool/bot/sheriff.py:
3253         * Scripts/webkitpy/tool/commands/download.py:
3254         * Scripts/webkitpy/tool/commands/download_unittest.py:
3255         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3256         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3257         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3258         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3259         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3260         * Scripts/webkitpy/tool/steps/__init__.py:
3261         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3262         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3263         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3264         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
3265
3266 2020-03-07  David Quesada  <david_quesada@apple.com>
3267
3268         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
3269         https://bugs.webkit.org/show_bug.cgi?id=208781
3270         rdar://problem/60061016
3271
3272         Reviewed by Alex Christensen.
3273
3274         Add a test that recreates the conditions of this crash:
3275         - Send a message from the injected bundle to the UI process that contains a reply block.
3276         - Hold a reference to the reply block.
3277         - Let the web view deallocate.
3278         - Call the block, and expect not to crash.
3279
3280         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3281         (localObjectInterface):
3282         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3283         (-[LocalObject doSomethingWithCompletionHandler:]):
3284         (TEST):
3285         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3286         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
3287
3288 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
3289
3290         TextManipulationController should work with ARIA labels
3291         https://bugs.webkit.org/show_bug.cgi?id=208759
3292
3293         Reviewed by Wenson Hsieh.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3296         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
3297         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
3298         the expected number of tokens for the first item as the very first image is correctly
3299         detected per the code change. 
3300         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
3301
3302 2020-03-07  Alex Christensen  <achristensen@webkit.org>
3303
3304         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
3305         https://bugs.webkit.org/show_bug.cgi?id=208767
3306
3307         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3308         The frameID of the main frame before loading is only 0 on Mac right now.
3309         The test is still good because it validates that execution works in the main frame before loading.
3310
3311 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
3312
3313         [ews] commit queue is not skipping layout tests for rollout patches
3314         https://bugs.webkit.org/show_bug.cgi?id=208716
3315
3316         Unreviewed minor fix.
3317
3318         * BuildSlaveSupport/ews-build/steps.py:
3319         (RunWebKitTests.doStepIf):
3320         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
3321         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
3322
3323 2020-03-05  Sam Weinig  <weinig@apple.com>
3324
3325         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3326         https://bugs.webkit.org/show_bug.cgi?id=207436
3327         <rdar://problem/59296762>
3328
3329         Reviewed by Darin Adler.
3330
3331         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3332         Remove JSC related defines.
3333
3334 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
3335
3336         AX: Provide a way to run tests in isolated tree mode
3337         https://bugs.webkit.org/show_bug.cgi?id=208629
3338         <rdar://problem/60075583>
3339
3340         Reviewed by Ryosuke Niwa.
3341
3342         Provide the ability to run tests for accessibility in the isolated tree mode.
3343         This sends a flag over to the injected bundle which calls the right HIServices override so that
3344         the system thinks it is in isolated mode.
3345
3346         * Scripts/compare-webkit-configurations:
3347         (flag_for_comparison):
3348         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3349         (parse_args):
3350         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3351         (parse_args):
3352         * Scripts/webkitpy/port/driver.py:
3353         (Driver.cmd_line):
3354         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3355         (WTR::AccessibilityController::AccessibilityController):
3356         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
3357         (WTR::AccessibilityController::updateIsolatedTreeMode):
3358         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
3359         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3360         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3361         (WTR::InjectedBundle::didReceiveMessageToPage):
3362         (WTR::InjectedBundle::beginTesting):
3363         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3364         * WebKitTestRunner/Options.cpp:
3365         (WTR::handleOptionAccessibilityIsolatedTreeMode):
3366         (WTR::OptionsHandler::OptionsHandler):
3367         * WebKitTestRunner/Options.h:
3368         * WebKitTestRunner/TestController.cpp:
3369         (WTR::TestController::initialize):
3370         (WTR::TestController::resetPreferencesToConsistentValues):
3371         (WTR::TestController::resetStateToConsistentValues):
3372         * WebKitTestRunner/TestController.h:
3373         (WTR::TestController::accessibilityIsolatedTreeMode const):
3374
3375 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
3376
3377         [Cocoa] Re-enable CFPrefs direct mode
3378         https://bugs.webkit.org/show_bug.cgi?id=208690
3379
3380         Reviewed by Brent Fulgham.
3381
3382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3383         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
3384         (TEST):
3385         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3386         (TestWebKitAPI::TEST):
3387
3388 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
3389
3390         UIProcess needs mechanism to specify AppBound domains
3391         https://bugs.webkit.org/show_bug.cgi?id=208528
3392         <rdar://problem/59980340>
3393
3394         Reviewed by Brent Fulgham.
3395
3396         Added test app-bound domains to the plist and tested that the domains
3397         are properly stored in the website data store after a navigation.
3398
3399         * TestWebKitAPI/Info.plist:
3400         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
3401         (TEST):
3402
3403 2020-03-06  Alex Christensen  <achristensen@webkit.org>
3404
3405         Add SPI to disable cross origin access control checks
3406         https://bugs.webkit.org/show_bug.cgi?id=208748
3407
3408         Reviewed by Tim Hatcher.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3411         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
3412
3413 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
3414
3415         [webkitpy] Fix executive on Windows to run wpt server correctly
3416         https://bugs.webkit.org/show_bug.cgi?id=208693
3417
3418         Reviewed by Jonathan Bedard.
3419
3420         Bug fix for Windows environment a) fixing a typo. b) fixing path
3421         c) fix how to kill subprocesses.
3422
3423         * Scripts/webkitpy/common/system/executive.py:
3424         (Executive._windows_kill_command):
3425         (Executive.interrupt):
3426         (Executive.kill_all):
3427         * Scripts/webkitpy/port/base.py:
3428         (Port.web_platform_test_server_doc_root):
3429
3430 2020-03-06  Alex Christensen  <achristensen@webkit.org>
3431
3432         Evaluating JavaScript in main frame before loading should succeed
3433         https://bugs.webkit.org/show_bug.cgi?id=208733
3434
3435         Reviewed by Tim Horton.
3436
3437         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3438
3439 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
3440
3441         TextManipulationController should preserve images
3442         https://bugs.webkit.org/show_bug.cgi?id=208692
3443
3444         Reviewed by Wenson Hsieh.
3445
3446         Added tests for preserving images and their ordering.
3447
3448         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3449         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
3450         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
3451         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
3452
3453 2020-03-06  David Quesada  <david_quesada@apple.com>
3454
3455         Add _WKResourceLoadInfo.resourceType SPI
3456         https://bugs.webkit.org/show_bug.cgi?id=208723
3457
3458         Reviewed by Alex Christensen.
3459
3460         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3461         (TEST):
3462
3463 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
3464
3465         Stop reporting to webkit-test-results.webkit.org
3466         https://bugs.webkit.org/show_bug.cgi?id=207218
3467
3468         Reviewed by Alexey Proskuryakov.
3469
3470         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3471         (RunWebKitTests):
3472
3473 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
3474
3475         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
3476         https://bugs.webkit.org/show_bug.cgi?id=208365
3477         <rdar://problem/59877296>
3478
3479         Reviewed by Geoffrey Garen.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3482         (TEST):
3483
3484 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
3485
3486         EWS should be able to fetch patch status for security bugs while processing them
3487         https://bugs.webkit.org/show_bug.cgi?id=206511
3488
3489         Reviewed by Alexey Proskuryakov.
3490
3491         * BuildSlaveSupport/ews-build/steps.py:
3492         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
3493         (BugzillaMixin.get_patch_json): 
3494         (BugzillaMixin.get_bug_json):
3495         (BugzillaMixin._is_bug_closed):
3496         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
3497         (TransferToS3.hideStepIf): Ditto.
3498
3499 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
3500
3501         [ews] commit-queue should show the trac url for the commit on the build page
3502         https://bugs.webkit.org/show_bug.cgi?id=208715
3503
3504         Reviewed by Jonathan Bedard.
3505
3506         * BuildSlaveSupport/ews-build/steps.py:
3507         (PushCommitToWebKitRepo.evaluateCommand):
3508
3509 2020-03-06  Alex Christensen  <achristensen@webkit.org>
3510
3511         Fix ResourceLoadDelegate.LoadInfo API test after r257816
3512         https://bugs.webkit.org/show_bug.cgi?id=208550
3513
3514         * TestWebKitAPI/cocoa/HTTPServer.mm:
3515         (TestWebKitAPI::HTTPServer::respondToRequests):
3516         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
3517         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
3518
3519 2020-03-06  Lauro Moura <lmoura@igalia.com>
3520
3521         [WPE][WebDriver] MiniBrowser should react to close session commands
3522         https://bugs.webkit.org/show_bug.cgi?id=207529
3523
3524         Reviewed by Carlos Garcia Campos.
3525
3526         Do not call g_object_unref on the first created view if it has already
3527         been disposed in the "close" signal handler.
3528
3529         Based on original patch by Yury Semikhatsky.
3530
3531         * MiniBrowser/wpe/main.cpp:
3532         (main):
3533
3534 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
3535
3536         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
3537         https://bugs.webkit.org/show_bug.cgi?id=208647
3538
3539         Reviewed by Carlos Garcia Campos.
3540
3541         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3542         (TestWebKitAPI::TEST):
3543
3544 2020-03-05  Alex Christensen  <achristensen@webkit.org>
3545
3546         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
3547         https://bugs.webkit.org/show_bug.cgi?id=208670
3548
3549         Reviewed by Brady Eidson.
3550
3551         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3552         (-[FrameNavigationDelegate waitForNavigations:]):
3553         (-[FrameNavigationDelegate requests]):
3554         (-[FrameNavigationDelegate frames]):
3555         (-[FrameNavigationDelegate callbacks]):
3556         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
3557         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
3558         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
3559         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
3560         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
3561         (TEST):
3562
3563 2020-03-05  Alex Christensen  <achristensen@webkit.org>
3564
3565         Add WKFrameInfo._parentFrameHandle SPI
3566         https://bugs.webkit.org/show_bug.cgi?id=208674
3567
3568         Reviewed by Brady Eidson.
3569
3570         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3571
3572 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
3573
3574         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
3575         https://bugs.webkit.org/show_bug.cgi?id=208626
3576         <rdar://problem/60074148>
3577
3578         Reviewed by Brent Fulgham.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3582         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
3583         (TestWebKitAPI::TEST):
3584         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
3585         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
3586         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
3587
3588 2020-03-05  Antoine Quint  <graouts@apple.com>
3589
3590         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
3591         https://bugs.webkit.org/show_bug.cgi?id=208644
3592         <rdar://problem/60042429>
3593
3594         Reviewed by Brady Eidson.
3595
3596         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
3597         
3598         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
3599            empty document has been removed in favor of the document for the requested URL,
3600         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
3601            correctly does not injected the style sheet.
3602
3603         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3604
3605 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3606
3607         [ews] Add build step to push commit to WebKit repository
3608         https://bugs.webkit.org/show_bug.cgi?id=208589
3609
3610         Reviewed by Jonathan Bedard.
3611
3612         * BuildSlaveSupport/ews-build/steps.py:
3613         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
3614         (PushCommitToWebKitRepo.start): Initialize log observer.
3615         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
3616         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
3617         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
3618         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
3619         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3620         * BuildSlaveSupport/ews-build/factories.py:
3621
3622 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3623
3624         [ews] Add unit tests for ValidateCommiterAndReviewer build step
3625         https://bugs.webkit.org/show_bug.cgi?id=208262
3626
3627         Reviewed by Jonathan Bedard.
3628
3629         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
3630
3631 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3632
3633         commit-queue should run WK2 tests instead of WK1 tests
3634         https://bugs.webkit.org/show_bug.cgi?id=208544
3635
3636         Reviewed by Jonathan Bedard.
3637
3638         * BuildSlaveSupport/ews-build/factories.py:
3639
3640 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
3641
3642         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
3643         https://bugs.webkit.org/show_bug.cgi?id=208645
3644
3645         Reviewed by Alexey Proskuryakov.
3646
3647         * BuildSlaveSupport/ews-build/steps.py:
3648         (ValidateCommiterAndReviewer.load_contributors):
3649         (ValidateCommiterAndReviewer.start):
3650
3651 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3652
3653         style-checker: Add UAF to the list of security words to warn about.
3654         https://bugs.webkit.org/show_bug.cgi?id=208643
3655
3656         Reviewed by Jonathan Bedard.
3657
3658         UAF is a common acronym used for use after free.
3659
3660         * Scripts/webkitpy/style/checkers/changelog.py:
3661         (ChangeLogChecker.check_for_unwanted_security_phrases):
3662
3663 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
3664
3665         [MSVC] Add .natvis support of WebKit types
3666         https://bugs.webkit.org/show_bug.cgi?id=193119
3667
3668         Reviewed by Don Olmstead.
3669
3670         To help the WebKit developer while debugging, this file defines how
3671         WebKit types are displayed in debugger of Visual Studio.
3672         Very limited set of WebKit types, but it changes the world.
3673
3674         * VisualStudio/WebKit.natvis: Added.
3675
3676 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3677
3678         Add system trace points around display list replay
3679         https://bugs.webkit.org/show_bug.cgi?id=208616
3680
3681         Reviewed by Simon Fraser.
3682
3683         Add a new "Display list replay" trace point.
3684
3685         * Tracing/SystemTracePoints.plist:
3686
3687 2020-03-04  Alex Christensen  <achristensen@webkit.org>
3688
3689         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
3690         https://bugs.webkit.org/show_bug.cgi?id=208615
3691         <rdar://problem/59406743>
3692
3693         Reviewed by Alex Christensen.