Tools/ChangeLog

   1 2015-11-03  Jason Marcell  <jmarcell@apple.com>
   2
   3         run-webkit-test should look in --root directory for LayoutTestRelay
   4         https://bugs.webkit.org/show_bug.cgi?id=150859
   5
   6         Reviewed by Daniel Bates.
   7
   8         For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
   9         LayoutTestRelay in the Mac build directory when --root is unspecified.
  10
  11         * Scripts/webkitpy/port/ios.py:
  12         (IOSSimulatorPort.relay_path):
  13
  14 2015-11-03  Alexey Proskuryakov  <ap@apple.com>
  15
  16         build.webkit.org/dashboard should use ISO dates in Trac URLs
  17         https://bugs.webkit.org/show_bug.cgi?id=150855
  18
  19         Reviewed by Darin Adler.
  20
  21         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
  22         (Trac.prototype._xmlTimelineURL):
  23
  24 2015-11-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
  25
  26         Unreviewed, add myself to the SVG watchlist.
  27
  28         * Scripts/webkitpy/common/config/watchlist:
  29
  30 2015-11-03  Wenson Hsieh  <wenson_hsieh@apple.com>
  31
  32         Fix touch event sending crash in WebKitTestRunner
  33         https://bugs.webkit.org/show_bug.cgi?id=150848
  34         <rdar://problem/23360841>
  35
  36         Reviewed by Simon Fraser.
  37
  38         Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
  39
  40         * WebKitTestRunner/ios/HIDEventGenerator.mm:
  41         (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
  42
  43 2015-11-03  Brent Fulgham  <bfulgham@apple.com>
  44
  45         [Win] Unreviewed build fix after r191958.
  46
  47         * MiniBrowser/win/MiniBrowser.h: Add missing include.
  48         * MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
  49
  50 2015-11-02  Jiewen Tan  <jiewen_tan@apple.com>
  51
  52         Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
  53
  54         * Scripts/webkitpy/common/config/contributors.json:
  55
  56 2015-11-03  Csaba Osztrogonác  <ossy@webkit.org>
  57
  58         Unreviewed, add unittest after r191827.
  59
  60         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  61
  62 2015-11-02  Andy Estes  <aestes@apple.com>
  63
  64         [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
  65         https://bugs.webkit.org/show_bug.cgi?id=150819
  66
  67         Reviewed by Dan Bernstein.
  68
  69         This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
  70
  71         * DumpRenderTree/mac/Configurations/Base.xcconfig:
  72         * MiniBrowser/Configurations/Base.xcconfig:
  73         * TestWebKitAPI/Configurations/Base.xcconfig:
  74         * WebKitTestRunner/Configurations/Base.xcconfig:
  75
  76 2015-11-02  Anders Carlsson  <andersca@apple.com>
  77
  78         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
  79         https://bugs.webkit.org/show_bug.cgi?id=150739
  80
  81         Reviewed by Tim Horton.
  82
  83         Add a test. We only test the encoding right now.
  84
  85         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
  86         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
  87         (TEST):
  88         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
  89         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
  90
  91 2015-11-02  Tim Horton  <timothy_horton@apple.com>
  92
  93         Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
  94         https://bugs.webkit.org/show_bug.cgi?id=150174
  95
  96         Reviewed by Anders Carlsson.
  97
  98         * WebKitTestRunner/mac/EventSenderProxy.mm:
  99         (WTR::EventSenderProxy::mouseUp):
 100         (WTR::EventSenderProxy::mouseMoveTo):
 101         Revert some parts of r188828 which no longer apply.
 102
 103 2015-10-30  Dana Burkart  <dburkart@apple.com>
 104
 105         svn-apply should handle unified diffs
 106         https://bugs.webkit.org/show_bug.cgi?id=150650
 107
 108         Reviewed by Darin Adler.
 109
 110         * Scripts/VCSUtils.pm:
 111         (parseUnifiedDiffHeader):
 112         This method parses a unified diff header, and returns a information in the
 113         style of parseGitDiffHeader and parseSvnDiffHeader.
 114
 115         (parseDiffHeader):
 116         Teach parseDiffHeader to recognize unified diff headers.
 117
 118         (parseDiff):
 119         Teach parseDiff to recognize unified diffs.
 120
 121         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
 122         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
 123
 124 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 125
 126         Fix the FTL JIT build with system LLVM on Linux
 127         https://bugs.webkit.org/show_bug.cgi?id=150795
 128
 129         Reviewed by Filip Pizlo.
 130
 131         * efl/install-dependencies:
 132         * gtk/install-dependencies:
 133
 134 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 135
 136         [EFL] Bump harfbuzz versions to 0.9.35
 137         https://bugs.webkit.org/show_bug.cgi?id=150448
 138
 139         Reviewed by Gyuyoung Kim.
 140
 141         * efl/jhbuild.modules:
 142
 143 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 144
 145         [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
 146         https://bugs.webkit.org/show_bug.cgi?id=150622
 147
 148         Reviewed by Gyuyoung Kim.
 149
 150         * efl/install-dependencies:
 151         * efl/jhbuild.modules:
 152
 153 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 154
 155         Fix EFL jhbuild module build on Ubuntu 15.10
 156         https://bugs.webkit.org/show_bug.cgi?id=150621
 157
 158         Reviewed by Gyuyoung Kim.
 159
 160         * efl/jhbuild.modules:
 161         * efl/patches/efl-remove-XPrint.patch: Added.
 162
 163 2015-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 164
 165         [GLIB] Remove delete on destroy GMainLoopSources
 166         https://bugs.webkit.org/show_bug.cgi?id=150771
 167
 168         Reviewed by Žan Doberšek.
 169
 170         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
 171         (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
 172         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
 173         (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
 174
 175 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
 176
 177         [ES6] Support Generator Syntax
 178         https://bugs.webkit.org/show_bug.cgi?id=150769
 179
 180         Reviewed by Geoffrey Garen.
 181
 182         Added ENABLE_ES6_GENERATORS flag.
 183
 184         * Scripts/webkitperl/FeatureList.pm:
 185
 186 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
 187
 188         Sort EWS bots in popovers
 189         https://bugs.webkit.org/show_bug.cgi?id=150782
 190
 191         Reviewed by Darin Adler.
 192
 193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
 194         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
 195
 196 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
 197
 198         B3::reduceStrength's DCE should be more agro and less wrong
 199         https://bugs.webkit.org/show_bug.cgi?id=150748
 200
 201         Reviewed by Geoffrey Garen.
 202
 203         Add an LLVM version of testb3's "testComplex".
 204
 205         * ReducedFTL/ComplexTest.cpp: Added.
 206
 207 2015-11-01  Commit Queue  <commit-queue@webkit.org>
 208
 209         Unreviewed, rolling out r191831.
 210         https://bugs.webkit.org/show_bug.cgi?id=150774
 211
 212         The new test fails (Requested by ap on #webkit).
 213
 214         Reverted changeset:
 215
 216         "Begin work on supporting reply blocks in
 217         _WKRemoteObjectRegistry"
 218         https://bugs.webkit.org/show_bug.cgi?id=150739
 219         http://trac.webkit.org/changeset/191831
 220
 221 2015-10-31  Andreas Kling  <akling@apple.com>
 222
 223         Add a debug overlay with information about web process resource usage.
 224         <https://webkit.org/b/150599>
 225
 226         Reviewed by Darin Adler.
 227
 228         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
 229
 230         * MiniBrowser/mac/SettingsController.h:
 231         * MiniBrowser/mac/SettingsController.m:
 232         (-[SettingsController _populateMenu]):
 233         (-[SettingsController validateMenuItem:]):
 234         (-[SettingsController toggleShowResourceUsageOverlay:]):
 235         (-[SettingsController resourceUsageOverlayVisible]):
 236         * MiniBrowser/mac/WK2BrowserWindowController.m:
 237         (-[WK2BrowserWindowController didChangeSettings]):
 238
 239 2015-10-31  Lucas Forschler  <lforschler@apple.com>
 240
 241         Teach the CompileWebKit step to look for additional arguments.
 242
 243         Unreviewed config change.
 244
 245         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 246         (CompileWebKit.start):
 247
 248 2015-10-30  Anders Carlsson  <andersca@apple.com>
 249
 250         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
 251         https://bugs.webkit.org/show_bug.cgi?id=150739
 252
 253         Reviewed by Tim Horton.
 254
 255         Add a test. We only test the encoding right now.
 256
 257         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
 258         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
 259         (TEST):
 260         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
 261         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
 262
 263 2015-10-30  Lucas Forschler  <lforschler@apple.com>
 264
 265         Add CMAke builder to build.webkit.org
 266         https://bugs.webkit.org/show_bug.cgi?id=150738
 267
 268         Reviewed by Alex Christensen.
 269
 270         * BuildSlaveSupport/build.webkit.org-config/config.json:
 271
 272 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
 273
 274         [Win] build-jsc and run-javascriptcore-tests do not work
 275         https://bugs.webkit.org/show_bug.cgi?id=150700
 276
 277         Reviewed by Mark Lam.
 278
 279         Correct our build system so that it expects Windows to be using CMake,
 280         and to build the correct sub-projects for our JSC helper scripts.
 281
 282         * Scripts/build-jsc: Make sure to build the testapi harness when
 283           building for Windows.
 284         * Scripts/build-webkit:
 285           (1) Use the existing 'cmakeBasedPortName()'
 286           (2) Use File::Spec rather than hard-coding path delimeters.
 287           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
 288         method rather than hard-coding the name based on conditional.
 289         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
 290           LLVM libraries on Apple Windows build.
 291         * Scripts/run-javascriptcore-tests:
 292         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
 293         * Scripts/run-jsc: Ditto.
 294         * Scripts/webkitdirs.pm:
 295         (cmakeBasedPortName): Update to return the right value for the Apple
 296         Windows port and the WinCairo port.
 297         (isCMakeBuild): Expect CMake build for all Windows ports.
 298
 299 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
 300
 301         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
 302         https://bugs.webkit.org/show_bug.cgi?id=150665
 303
 304         Reviewed by Csaba Osztrogonác.
 305
 306         We check it only to wipe the directory or not, but we are still
 307         tryihng to update every module even when the configuration hasn't
 308         changed. This is problematic because it makes the whole build fail
 309         when any repository fails to checkout an already checked out
 310         revision, because the server is down for example. This is even
 311         more problematic for the bots that skip perfectly valid revisions.
 312         It's still possible to force an update passing --force command
 313         line argument.
 314
 315         * Scripts/update-webkit-libs-jhbuild:
 316         (deleteJhbuildMd5): Delete the md5sum files if exist.
 317         (runJhbuild): Return early if the md5sum files haven't
 318         changed. Only write them after a successful build and delete them
 319         if the build fails to ensure we don't skip next run.
 320
 321 2015-10-30  Philippe Normand  <pnormand@igalia.com>
 322
 323         [GTK] Fix MacCLang build errors in Tools
 324         https://bugs.webkit.org/show_bug.cgi?id=150031
 325
 326         Reviewed by Carlos Garcia Campos.
 327
 328         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
 329         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
 330         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
 331         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
 332
 333 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
 334
 335         [EFL] MiniBrowser didn't work after r191749.
 336         https://bugs.webkit.org/show_bug.cgi?id=150706
 337
 338         Reviewed by Alex Christensen.
 339
 340         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
 341
 342         * Scripts/run-minibrowser:
 343
 344 2015-10-29  Commit Queue  <commit-queue@webkit.org>
 345
 346         Unreviewed, rolling out r191766.
 347         https://bugs.webkit.org/show_bug.cgi?id=150707
 348
 349         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
 350
 351         Reverted changeset:
 352
 353         "[Win] build-jsc and run-javascriptcore-tests do not work"
 354         https://bugs.webkit.org/show_bug.cgi?id=150700
 355         http://trac.webkit.org/changeset/191766
 356
 357 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
 358
 359         [Win] build-jsc and run-javascriptcore-tests do not work
 360         https://bugs.webkit.org/show_bug.cgi?id=150700
 361
 362         Reviewed by Mark Lam.
 363
 364         Correct our build system so that it expects Windows to be using CMake,
 365         and to build the correct sub-projects for our JSC helper scripts.
 366
 367         * Scripts/build-jsc: Make sure to build the testapi harness when
 368           building for Windows.
 369         * Scripts/build-webkit:
 370           (1) Use the existing 'cmakeBasedPortName()'
 371           (2) Use File::Spec rather than hard-coding path delimeters.
 372           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
 373         method rather than hard-coding the name based on conditional.
 374         * Scripts/run-javascriptcore-tests:
 375         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
 376         * Scripts/run-jsc: Ditto.
 377         * Scripts/webkitdirs.pm:
 378         (cmakeBasedPortName): Update to return the right value for the Apple
 379         Windows port and the WinCairo port.
 380         (isCMakeBuild): Expect CMake build for all Windows ports.
 381
 382 2015-10-29  Alex Christensen  <achristensen@webkit.org>
 383
 384         Fix build-jsc on Mac after r191749.
 385
 386         * Scripts/build-jsc:
 387         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
 388
 389 2015-10-29  Alex Christensen  <achristensen@webkit.org>
 390
 391         Fix Mac CMake build
 392         https://bugs.webkit.org/show_bug.cgi?id=150686
 393
 394         Reviewed by Filip Pizlo.
 395
 396         * Scripts/build-webkit:
 397         * Scripts/webkitdirs.pm:
 398         (isCachedArgumentfileOutOfDate):
 399         (wrapperPrefixIfNeeded):
 400         (generateBuildSystemFromCMakeProject):
 401         (buildCMakeGeneratedProject):
 402         (cmakeBasedPortName):
 403         (determineIsCMakeBuild):
 404         (isCMakeBuild):
 405         (promptUser):
 406         (jhbuildWrapperPrefixIfNeeded): Deleted.
 407
 408 2015-10-29  Lucas Forschler  <lforschler@apple.com>
 409
 410         Teach JSC bots to build 32bit instead of x86_64
 411
 412         Reviewed by Mark Lam.
 413
 414         * BuildSlaveSupport/build.webkit.org-config/config.json:
 415
 416 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
 417
 418         [WinCairo] Fall back to AppleWin results in layout tests.
 419         https://bugs.webkit.org/show_bug.cgi?id=150672
 420
 421         Reviewed by Alex Christensen.
 422
 423         * Scripts/webkitpy/port/win.py:
 424         (WinCairoPort):
 425         (WinCairoPort.default_baseline_search_path):
 426
 427 2015-10-28  Keith Rollin  <krollin@apple.com>
 428
 429         Do not sanitize user input for input[type=url]
 430         https://bugs.webkit.org/show_bug.cgi?id=150346
 431         <rdar://problem/23243240>
 432
 433         Reviewed by Brent Fulgham.
 434
 435         The Windows version of DumpRenderTree's eventSender.keyDown handler
 436         simulates user-entry by decomposing the given character into a virtual
 437         key code and a set of modifier keys. The code that determines if the
 438         shift key should be simulated only worked if the character was an
 439         upper case character. Extend this support to also include symbols that
 440         (on the U.S. keyboard) require holding down the shift key.
 441
 442         This change allows fast/forms/input-user-input-sanitization.html
 443         to succeed, which requires us to simulate the entering of '@' and ':'.
 444
 445         * DumpRenderTree/win/EventSender.cpp:
 446         (keyDownCallback):
 447
 448 2015-10-28  Alex Christensen  <achristensen@webkit.org>
 449
 450         Compile and link with CMake on Mac
 451         https://bugs.webkit.org/show_bug.cgi?id=150632
 452
 453         Reviewed by Tim Horton.
 454
 455         * TestWebKitAPI/PlatformMac.cmake:
 456
 457 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 458
 459         Unreviewed.
 460
 461         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
 462
 463 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
 464
 465         Add WinCairo to list of ports in run-webkit-tests.
 466         https://bugs.webkit.org/show_bug.cgi?id=150625
 467
 468         Reviewed by Brent Fulgham.
 469
 470         * Scripts/webkitpy/common/config/ports.py:
 471         (DeprecatedPort.port):
 472         (WinPort.run_webkit_tests_command):
 473         (WinCairoPort):
 474         (GtkWK2Port):
 475         * Scripts/webkitpy/port/factory.py:
 476         (PortFactory):
 477         * Scripts/webkitpy/port/win.py:
 478         (WinPort.find_system_pid):
 479         (WinCairoPort):
 480
 481 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
 482
 483         WebKitTestRunner leaks in generateWhitelist()
 484         https://bugs.webkit.org/show_bug.cgi?id=150563
 485
 486         Reviewed by Andreas Kling.
 487
 488         * WebKitTestRunner/mac/TestControllerMac.mm:
 489         (WTR::generateWhitelist):
 490
 491 2015-10-27  Anders Carlsson  <andersca@apple.com>
 492
 493         Add an API test for _WKRemoteObjectRegistry
 494         https://bugs.webkit.org/show_bug.cgi?id=150597
 495
 496         Reviewed by Andreas Kling.
 497
 498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 499         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
 500         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
 501         (TEST):
 502         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
 503         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
 504         (-[RemoteObjectRegistryPlugIn sayHello:]):
 505
 506 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 507
 508         Add myself to the reviewers list
 509         https://bugs.webkit.org/show_bug.cgi?id=150581
 510
 511         Unreviewed.
 512
 513         * Scripts/webkitpy/common/config/contributors.json:
 514
 515 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
 516
 517         Adding myself to contributors.json
 518
 519         * Scripts/webkitpy/common/config/contributors.json:
 520
 521 2015-10-26  Tim Horton  <timothy_horton@apple.com>
 522
 523         Don't expose the whitelist/blacklist in _WKUserStyleSheet
 524         https://bugs.webkit.org/show_bug.cgi?id=150566
 525
 526         Reviewed by Anders Carlsson.
 527
 528         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
 529         (TEST):
 530
 531 2015-10-26  Philippe Normand  <pnormand@igalia.com>
 532
 533         Unreviewed, rolling out r191576.
 534
 535         broke
 536
 537         Reverted changeset:
 538
 539         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
 540         https://bugs.webkit.org/show_bug.cgi?id=149594
 541         http://trac.webkit.org/changeset/191576
 542
 543 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
 544
 545         [GStreamer] Bump internal jhbuild versions to 1.6.0
 546         https://bugs.webkit.org/show_bug.cgi?id=149594
 547
 548         Reviewed by Philippe Normand.
 549
 550         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
 551         useful so they are removed accordingly.
 552
 553         * gtk/jhbuild.modules:
 554         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
 555         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
 556         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
 557
 558 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
 559
 560         API tests fail on El Capitan after r191543
 561         https://bugs.webkit.org/show_bug.cgi?id=150547
 562
 563         Reviewed by Dan Bernstein.
 564
 565         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
 566
 567 2015-10-24  Tim Horton  <timothy_horton@apple.com>
 568
 569         Add a way to add user style sheets to WKUserContentController
 570         https://bugs.webkit.org/show_bug.cgi?id=150531
 571         <rdar://problem/23191691>
 572
 573         Reviewed by Darin Adler.
 574
 575         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
 576         (TEST):
 577
 578 2015-10-24  Tim Horton  <timothy_horton@apple.com>
 579
 580         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
 581         https://bugs.webkit.org/show_bug.cgi?id=150525
 582
 583         Reviewed by Darin Adler.
 584
 585         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
 586         (TEST):
 587         Test the various new keys.
 588
 589 2015-10-24  Frederic Wang  <fred.wang@free.fr>
 590
 591         check-webkit-style complains about missing operator whitespace inside character literal
 592         https://bugs.webkit.org/show_bug.cgi?id=150396
 593
 594         Reviewed by Darin Adler.
 595
 596         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
 597         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 598         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
 599
 600 2015-10-23  Michael Saboff  <msaboff@apple.com>
 601
 602         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
 603         https://bugs.webkit.org/show_bug.cgi?id=150513
 604
 605         Reviewed by Saam Barati.
 606
 607         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
 608
 609         * DumpRenderTree/TestRunner.cpp:
 610         (simulateWebNotificationClickCallback):
 611         (failNextCodeBlock):
 612         (numberOfDFGCompiles):
 613         (TestRunner::staticFunctions):
 614         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 615         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 616         (WTR::TestRunner::setBlockAllPlugins):
 617         (WTR::TestRunner::failNextCodeBlock):
 618         (WTR::TestRunner::numberOfDFGCompiles):
 619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 620
 621 2015-10-23  Anders Carlsson  <andersca@apple.com>
 622
 623         Simplify the WebKitLegacy menu conversion code
 624         https://bugs.webkit.org/show_bug.cgi?id=150509
 625
 626         Reviewed by Andreas Kling.
 627
 628         Implement the context menu delegate method so we'll test that code path.
 629
 630         * MiniBrowser/mac/WK1BrowserWindowController.m:
 631         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
 632
 633 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
 634
 635         [WinCairo] Improve test results for fast layouttests.
 636         https://bugs.webkit.org/show_bug.cgi?id=150464
 637
 638         Reviewed by Alex Christensen.
 639
 640         Set custom device scale factor to 1.0.
 641
 642         * DumpRenderTree/win/DumpRenderTree.cpp:
 643         (createWebViewAndOffscreenWindow):
 644
 645 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
 646
 647         [GTK] update-webkitgtk-libs should use mesa tarball
 648
 649         https://bugs.webkit.org/show_bug.cgi?id=150470
 650
 651         update-webkitgtk-libs downloads all build dependencies; in fixing
 652         bug 148941 mesa was switched from ftp to git access.  Now an http
 653         tarball is available, which is preferred over accessing via git.
 654
 655         Reviewed by Philippe Normand
 656
 657         * gtk/jhbuild.modules:
 658         Mesa access changed to http tarball.
 659
 660 2015-10-22  Sam Weinig  <sam@webkit.org>
 661
 662         Navigations on the same host (but with different schemes and ports) should not trigger universal links
 663         <rdar://problem/22811325>
 664         https://bugs.webkit.org/show_bug.cgi?id=150481
 665
 666         Reviewed by Dan Bernstein.
 667
 668         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
 669         Update test to test that navigations on the same host but with different schemes does not
 670         trigger universal links, but that changes in the host do.
 671
 672 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
 673
 674         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
 675         https://bugs.webkit.org/show_bug.cgi?id=150428
 676
 677         Reviewed by Antti Koivisto.
 678
 679         Added a regression test using WebKit API test.
 680
 681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 682         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
 683         (TestWebKitAPI::didFinishLoadForFrame):
 684         (TestWebKitAPI::TEST):
 685
 686 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 687
 688         Unreviewed. Fix GTK+ build after r191423.
 689
 690         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
 691
 692         * gtk/webkitdom.py:
 693         (WebKitDOMDocGenerator):
 694
 695 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
 696
 697         [Win][EFL][GTK] webkitpy test failed after r191374.
 698         https://bugs.webkit.org/show_bug.cgi?id=150433
 699
 700         Reviewed by Alexey Proskuryakov.
 701
 702         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 703         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
 704         (CrashLogsTest.test_find_log_darwin): Same.
 705
 706 2015-10-21  Brian Burg  <bburg@apple.com>
 707
 708         Unreviewed, update watchlist for JS builtins.
 709
 710         Add a category for JS builtins code generator, similar to other generators.
 711
 712         Add a nag message to rebaseline builtins generator tests when touching
 713         code generator files in Source/JavaScriptCore/Scripts/builtins/.
 714
 715         * Scripts/webkitpy/common/config/watchlist:
 716
 717 2015-10-21  Brian Burg  <bburg@apple.com>
 718
 719         Restructure generate-js-bindings script to be modular and testable
 720         https://bugs.webkit.org/show_bug.cgi?id=149929
 721
 722         Reviewed by Alex Christensen.
 723
 724         Add a stub shell script and basic webkitpy support for running builtins
 725         generator tests.
 726
 727         * Scripts/run-builtins-generator-tests: Added.
 728         (main):
 729         * Scripts/webkitpy/codegen/__init__.py: Added.
 730         * Scripts/webkitpy/codegen/main.py: Added.
 731
 732             The only interesting difference here from the inspector protocol
 733             generator equivalent is that this implementation decodes the target
 734             framework and output mode (combined or separate) from the test's file name.
 735
 736         (BuiltinsGeneratorTests):
 737         (BuiltinsGeneratorTests.__init__):
 738         (BuiltinsGeneratorTests.generate_from_js_builtins):
 739         (BuiltinsGeneratorTests.write_error_file):
 740         (BuiltinsGeneratorTests.detect_changes):
 741         (BuiltinsGeneratorTests.run_tests):
 742         (BuiltinsGeneratorTests.main):
 743
 744 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
 745
 746         run-webkit-tests does not copy all crash logs for layout test failures on Mac
 747         https://bugs.webkit.org/show_bug.cgi?id=150407
 748         <rdar://problem/22239750>
 749
 750         Reviewed by Alexey Proskuryakov.
 751
 752         * Scripts/webkitpy/port/mac.py:
 753         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
 754         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
 755         the log directory.
 756         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
 757         from log directory and merge them with the list of already crashed tests.
 758
 759 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
 760
 761         Failures in PutStackSinkingPhase should be less severe
 762         https://bugs.webkit.org/show_bug.cgi?id=150400
 763
 764         Reviewed by Geoffrey Garen.
 765
 766         Add a test mode for no PutStackSinkingPhase.
 767
 768         * Scripts/run-jsc-stress-tests:
 769
 770 2015-10-21  Nan Wang  <n_wang@apple.com>
 771
 772         AX: Expose table size and cell indexes on iOS
 773         https://bugs.webkit.org/show_bug.cgi?id=150366
 774
 775         Reviewed by Chris Fleizach.
 776
 777         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 778         (AccessibilityUIElement::rowCount):
 779         (AccessibilityUIElement::columnCount):
 780         (AccessibilityUIElement::indexInTable):
 781         (AccessibilityUIElement::numberAttributeValue):
 782         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 783         (WTR::AccessibilityUIElement::numberAttributeValue):
 784         (WTR::AccessibilityUIElement::rowCount):
 785         (WTR::AccessibilityUIElement::columnCount):
 786         (WTR::AccessibilityUIElement::indexInTable):
 787
 788 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 789
 790         W3C test importer should not import reference files as regular tests
 791         https://bugs.webkit.org/show_bug.cgi?id=150331
 792
 793         Reviewed by Darin Adler.
 794
 795         Updated test_parser to return information that a file can be a referencefile or a manual test.
 796         Updated test importer to skip those files.
 797         Updated/Added test parser unit tests accordingly.
 798
 799         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
 800         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
 801         to mark these files as Skip, since they are not direct tests.
 802
 803         * Scripts/webkitpy/w3c/test_importer.py:
 804         (TestImporter.__init__):
 805         (TestImporter.find_importable_tests):
 806         (TestImporter.import_tests):
 807         * Scripts/webkitpy/w3c/test_parser.py:
 808         (TestParser.analyze_test):
 809         * Scripts/webkitpy/w3c/test_parser_unittest.py:
 810         (test_analyze_non_html_file):
 811         (test_reference_test):
 812
 813 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
 814
 815         run-webkit-tests does not copy all crash logs for layout test failures on iOS
 816         https://bugs.webkit.org/show_bug.cgi?id=150056
 817         <rdar://problem/9280656>
 818
 819         Reviewed by Alexey Proskuryakov.
 820
 821         * Scripts/webkitpy/common/system/crashlogs.py:
 822         (CrashLogs.find_all_logs): Generic method to find all crash logs.
 823         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
 824         It iterates through log directory and returns all the logs based on timestamp.
 825         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 826         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
 827         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
 828         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
 829         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 830         (Manager.run): Modified start_time to start counting before simulator launch
 831         so that we can capture crashes during simualator launch.
 832         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
 833         any test which is not already marked as CRASH to the run_results.
 834         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 835         (TestExpectationsModel.get_expectations_string): return PASS in case there
 836         are no expectations defined for this test.
 837         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 838         (summarize_results): Add other_crashes in a separte category in full_results.json.
 839         * Scripts/webkitpy/port/ios.py:
 840         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
 841         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
 842         from the log directory.
 843         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
 844         logs from log directory and merge them with the list of already crashed tests.
 845
 846 2015-10-20  Dana Burkart  <dburkart@apple.com>
 847
 848         Fix the build
 849
 850         Unreviewed.
 851
 852         My previous patch was missing a necessary space character.
 853
 854         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
 855
 856 2015-10-20  Dana Burkart  <dburkart@apple.com>
 857
 858         svn-apply fails to apply binary diffs in some cases
 859         https://bugs.webkit.org/show_bug.cgi?id=64647
 860
 861         Reviewed by Daniel Bates.
 862
 863         * Scripts/VCSUtils.pm:
 864         (decodeGitBinaryPatchDeltaSize): Modified.
 865         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
 866         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
 867
 868 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
 869
 870         Mac Debug EWS never finishes when there are failures
 871         https://bugs.webkit.org/show_bug.cgi?id=150334
 872
 873         Reviewed by Daniel Bates.
 874
 875         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 876         * Scripts/webkitpy/tool/commands/queues.py:
 877
 878 2015-10-20  Philippe Normand  <pnormand@igalia.com>
 879
 880         [GTK] Enable OpenWebRTC test video/audio sources in tests
 881
 882         This is needed because we can't expect the buildbots to have
 883         webcam/mic devices plugged in.
 884
 885         Rubber-stamped by Carlos Garcia Campos.
 886
 887         * Scripts/run-gtk-tests:
 888         (TestRunner._setup_testing_environment):
 889         * Scripts/webkitpy/port/gtk.py:
 890         (GtkPort.setup_environ_for_server):
 891
 892 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
 893
 894         Rename the PICTURE_SIZES flag to CURRENTSRC
 895         https://bugs.webkit.org/show_bug.cgi?id=150275
 896
 897         Reviewed by Dean Jackson.
 898
 899         * Scripts/webkitperl/FeatureList.pm:
 900
 901 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
 902
 903         Unreviewed, add myself to the committers list.
 904
 905         * Scripts/webkitpy/common/config/contributors.json:
 906
 907 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
 908
 909         Add new EWS queues to bot watcher's dashboard
 910         https://bugs.webkit.org/show_bug.cgi?id=150297
 911
 912         Reviewed by Darin Adler.
 913
 914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 915         (BubbleQueueServer):
 916
 917 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
 918
 919         REGRESSION(r190262): User media unit test failures after r190262
 920         https://bugs.webkit.org/show_bug.cgi?id=149580
 921
 922         Reviewed by Carlos Garcia Campos.
 923
 924         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
 925         So we do not need to skip them anymore.
 926
 927         * Scripts/run-gtk-tests:
 928         (TestRunner): Deleted.
 929
 930 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
 931
 932         Add historical addresses to contributors.json
 933         https://bugs.webkit.org/show_bug.cgi?id=150227
 934
 935         Reviewed by Darin Adler.
 936
 937         * Scripts/webkitpy/common/config/contributors.json:
 938
 939 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
 940
 941         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
 942         https://bugs.webkit.org/show_bug.cgi?id=150307
 943
 944         Reviewed by Brent Fulgham.
 945
 946         The DLL build rules have been changed to generate "{Name}Lib.DLL",
 947         but these changes have not yet been applied to the Visual Studio builds.
 948
 949         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
 950
 951 2015-10-16  Andreas Kling  <akling@apple.com>
 952
 953         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
 954         <https://webkit.org/b/150153>
 955
 956         Unreviewed.
 957
 958         Just use simple arrays of LChar and UChar for this test instead of creating String
 959         objects and then getting the characters8()/characters16() from them, since that
 960         doesn't guarantee null-termination (the bug.)
 961
 962         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
 963         (TestWebKitAPI::TEST):
 964         (TestWebKitAPI::build): Deleted.
 965
 966 2015-10-16  Tim Horton  <timothy_horton@apple.com>
 967
 968         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
 969         https://bugs.webkit.org/show_bug.cgi?id=150255
 970
 971         Reviewed by Simon Fraser.
 972
 973         * Scripts/run-api-tests:
 974         (runTest):
 975         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
 976         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
 977         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
 978         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
 979         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
 980         Don't set the layout size until after the load finishes and we're waiting
 981         for the reply, so that there is no race between the new size coming in
 982         and us waiting for it.
 983
 984 2015-10-16  Anders Carlsson  <andersca@apple.com>
 985
 986         WebEditingDelegate should be a formal protocol
 987         https://bugs.webkit.org/show_bug.cgi?id=150254
 988         <rdar://problem/23149847>
 989
 990         Reviewed by Dan Bernstein.
 991
 992         * DumpRenderTree/mac/EditingDelegate.h:
 993         Conform to the WebEditingDelegate protocol.
 994
 995 2015-10-16  Tim Horton  <timothy_horton@apple.com>
 996
 997         Hook up autolayout intrinsic sizing for WKWebView
 998         https://bugs.webkit.org/show_bug.cgi?id=150219
 999         <rdar://problem/20016905>
1000
1001         Reviewed by Simon Fraser.
1002
1003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1004         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
1005         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
1006         (-[AutoLayoutWKWebView load:expectingContentSize:]):
1007         (-[AutoLayoutWKWebView expectContentSizeChange:]):
1008         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
1009         (TEST):
1010         Add a variety of tests, including one which catches the bug that
1011         the WebCore part of this patch fixes.
1012
1013 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
1014
1015         Update the help message of --system-malloc
1016         https://bugs.webkit.org/show_bug.cgi?id=150169
1017
1018         Reviewed by Geoffrey Garen.
1019
1020         * Scripts/webkitperl/FeatureList.pm:
1021
1022 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1023
1024         Update ImportExpectations according currently imported wpt tests
1025         https://bugs.webkit.org/show_bug.cgi?id=150158
1026
1027         Reviewed by Chris Dumez.
1028
1029         * Scripts/webkitpy/w3c/test_downloader.py:
1030         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
1031
1032 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
1033
1034         Unreviewed, Update my email address.
1035
1036         * Scripts/webkitpy/common/config/contributors.json:
1037
1038 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1039
1040         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
1041         https://bugs.webkit.org/show_bug.cgi?id=84960
1042
1043         Reviewed by Žan Doberšek.
1044
1045         * Scripts/run-gtk-tests:
1046         (TestRunner): Unskip tests using SessionState.
1047         * TestWebKitAPI/PlatformGTK.cmake: Add
1048         WKPageCopySessionStateWithFiltering test.
1049
1050 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1051
1052         [GTK] Missing return value on TestWebExtensions.cpp:193
1053         https://bugs.webkit.org/show_bug.cgi?id=149755
1054
1055         Unreviewed. Add missing return value.
1056
1057         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1058         (permissionRequestCallback):
1059
1060 2015-10-14  Andy Estes  <aestes@apple.com>
1061
1062         [iOS] build-dumprendertree does not build ImageDiff
1063         https://bugs.webkit.org/show_bug.cgi?id=150152
1064
1065         Reviewed by Tim Horton.
1066
1067         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
1068         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
1069         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
1070         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
1071
1072         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
1073         fine on that platform, and results in ImageDiff being built.
1074
1075         * Scripts/build-dumprendertree:
1076
1077 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
1078
1079         [Win] Enforce launcher/library naming scheme
1080         https://bugs.webkit.org/show_bug.cgi?id=150124
1081
1082         Reviewed by Alex Christensen.
1083
1084         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
1085         * MiniBrowser/win/CMakeLists.txt: Ditto.
1086         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1087         * win/DLLLauncher/DLLLauncherMain.cpp:
1088         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
1089         original {name}.dll.
1090
1091 2015-10-14  Andreas Kling  <akling@apple.com>
1092
1093         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
1094         <https://webkit.org/b/150135>
1095
1096         Reviewed by Geoffrey Garen.
1097
1098         Add a new WTF API test that covers this issue.
1099
1100         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1101         (TestWebKitAPI::build):
1102         (TestWebKitAPI::TEST):
1103
1104 2015-10-14  Alex Christensen  <achristensen@webkit.org>
1105
1106         Add SPI for reloading without content blockers
1107         https://bugs.webkit.org/show_bug.cgi?id=150058
1108         rdar://problem/22742222
1109
1110         Reviewed by Sam Weinig.
1111
1112         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1113         (WTR::TestController::cocoaResetStateToConsistentValues):
1114         * WebKitTestRunner/mac/TestControllerMac.mm:
1115         (WTR::TestController::platformConfigureViewForTest):
1116
1117 2015-10-14  Mark Lam  <mark.lam@apple.com>
1118
1119         Rename some JSC option names to be more uniform.
1120         https://bugs.webkit.org/show_bug.cgi?id=150127
1121
1122         Reviewed by Geoffrey Garen.
1123
1124         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1125         * Scripts/run-jsc-stress-tests:
1126
1127 2015-10-14  Anders Carlsson  <andersca@apple.com>
1128
1129         Change the bundle app cache APIs to take a page
1130         https://bugs.webkit.org/show_bug.cgi?id=150123
1131
1132         Reviewed by Sam Weinig.
1133
1134         Update APIs.
1135
1136         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1137         (WTR::InjectedBundle::beginTesting):
1138         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1139         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1141         (WTR::TestRunner::clearAllApplicationCaches):
1142         (WTR::TestRunner::clearApplicationCacheForOrigin):
1143         (WTR::TestRunner::setAppCacheMaximumSize):
1144         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1145         (WTR::TestRunner::originsWithApplicationCache):
1146
1147 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1148
1149         Update web-platform-tests tools to the latest revision
1150         https://bugs.webkit.org/show_bug.cgi?id=149645
1151
1152         Reviewed by Darin Adler.
1153
1154         Disabling git submodules information conversion to json install file for web-platform-tests.
1155         Disabling related python unit tests.
1156         The tools submodules contain submodules and the conversion tool does not support that yet.
1157
1158         Updating wpt launcher script to aling it with web-platform-test main script.
1159
1160         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1161         (main):
1162         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1163         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
1164         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1165         (TestImporterTest.test_submodules_generation):
1166
1167 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1168
1169         More debug queue build fixing.
1170
1171         Preserve the build style in one more place. Changed mock build_style from "both"
1172         to "release", as we don't support testing both debug and release.
1173
1174         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1175         (MockCommitQueue.archive_last_test_results):
1176         (MockCommitQueue):
1177         (MockCommitQueue.build_style):
1178         (MockCommitQueue.did_pass_testing_ews):
1179         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1180         (PatchAnalysisTask._test):
1181         (PatchAnalysisTask._build_and_test_without_patch):
1182         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1183         (EarlyWarningSystemTest._default_expected_logs):
1184         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1185
1186 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1187
1188         More debug queue build fixing.
1189
1190         Add build_style argument to derived classes as well.
1191
1192         * Scripts/webkitpy/common/config/ports.py:
1193         (MacPort):
1194         (MacPort.run_webkit_tests_command):
1195         (WinPort.run_bindings_tests_command):
1196         (WinPort):
1197         (WinPort.run_webkit_tests_command):
1198         (GtkWK2Port.build_webkit_command):
1199         (GtkWK2Port):
1200         (GtkWK2Port.run_webkit_tests_command):
1201
1202 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
1203
1204         [iOS] Build fix
1205
1206         Unreviewed.
1207
1208         Mach-O section names are limited to 16 characters.
1209
1210         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1211         * DumpRenderTree/mac/DumpRenderTree.mm:
1212         (activateFontsIOS):
1213
1214 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1215
1216         Build fix for mac-debug EWS queue.
1217
1218         Unreviewed.
1219
1220         Pass --debug to run-webkit-tests.
1221
1222         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1223         will need to be substantially modified to work in EWS, so the dummy implementation
1224         was not helpful.
1225
1226         * Scripts/webkitpy/common/config/ports.py:
1227         (DeprecatedPort.run_javascriptcore_tests_command):
1228         (DeprecatedPort):
1229         (DeprecatedPort.run_webkit_tests_command):
1230         (DeprecatedPort.run_python_unittests_command):
1231         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1232         * Scripts/webkitpy/common/config/ports_mock.py:
1233         (MockPort.run_javascriptcore_tests_command):
1234         (MockPort):
1235         (MockPort.run_webkit_tests_command):
1236         (MockPort.run_bindings_tests_command):
1237         (MockPort.run_webkit_unit_tests_command): Deleted.
1238         * Scripts/webkitpy/tool/commands/download_unittest.py:
1239         * Scripts/webkitpy/tool/steps/runtests.py:
1240         (RunTests.run):
1241         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1242         (RunTestsTest.test_webkit_run_unit_tests):
1243         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1244         (StepsTest.test_runtests_args):
1245
1246 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
1247
1248         [Win] Generate Crash Traces
1249         https://bugs.webkit.org/show_bug.cgi?id=150103
1250
1251         Reviewed by Daniel Bates.
1252
1253         We were using an exception filter to try to emit "#CRASHED" to stderr
1254         when a test program crashed. However, the modern Python implementation
1255         seems capable of recognizing crashes on its own. Furthermore, registering
1256         the exception handler was preventing the JIT debugger (NTSD) from
1257         automatically attaching to the crashing program, so we were not getting
1258         crash traces.
1259
1260         * DumpRenderTree/win/DumpRenderTree.cpp:
1261         (main): Don't register an exception filter.
1262         (exceptionFilter): Deleted.
1263         * Scripts/webkitpy/common/system/crashlogs.py:
1264         (CrashLogs): Add another regular expression to handle a second crash trace
1265         syntax I encountered during testing.
1266         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1267         try the new one. The PID found by the new expression is in hexadecimal, so
1268         convert it to an integer before returning it.
1269         * Scripts/webkitpy/port/driver.py:
1270         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1271         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1272         check for "#CRASHED" after stripping off the EOL characters.
1273         * Scripts/webkitpy/port/win.py:
1274         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1275         invocation. This is apparently used to signal an event when the debugger is finished.
1276
1277 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1278
1279         Mac Debug and 32-bit queues should be separate
1280         https://bugs.webkit.org/show_bug.cgi?id=150092
1281
1282         Reviewed by Lucas Forschler.
1283
1284         * QueueStatusServer/config/queues.py:
1285         * QueueStatusServer/model/queues.py:
1286         (Queue._capitalize_after_dash):
1287         (Queue._caplitalize_after_dash): Deleted.
1288         * Scripts/webkitpy/common/config/ews.json:
1289
1290 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1291
1292         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1293         https://bugs.webkit.org/show_bug.cgi?id=150085
1294
1295         Reviewed by Carlos Garcia Campos.
1296
1297         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1298
1299 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1300
1301         Unreviewed, add myself to the committers list.
1302
1303         * Scripts/webkitpy/common/config/contributors.json:
1304
1305 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1306
1307         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1308         https://bugs.webkit.org/show_bug.cgi?id=149983
1309
1310         Reviewed by Dan Bates.
1311
1312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1313         (BubbleQueueServer):
1314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1315
1316 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1317
1318         Fix webkitpy tests after r190922.
1319
1320         * Scripts/webkitpy/common/config/ews.json:
1321         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1322         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1323
1324 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1325
1326         Add a Mac debug EWS queue
1327         https://bugs.webkit.org/show_bug.cgi?id=150069
1328
1329         Reviewed by Geoffrey Garen.
1330
1331         * QueueStatusServer/config/queues.py:
1332         * Scripts/webkitpy/common/config/ews.json:
1333         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1334         (AbstractEarlyWarningSystem):
1335         (AbstractEarlyWarningSystem.archive_last_test_results):
1336         (AbstractEarlyWarningSystem.build_style):
1337         (AbstractEarlyWarningSystem.refetch_patch):
1338         (AbstractEarlyWarningSystem.load_ews_classes):
1339
1340 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1341
1342         [GTK] Update jhbuild's version of harfbuzz
1343         https://bugs.webkit.org/show_bug.cgi?id=149749
1344
1345         Reviewed by Martin Robinson.
1346
1347         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1348
1349         * gtk/jhbuild.modules: Updated details for harfbuzz.
1350
1351 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1352
1353         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1354         https://bugs.webkit.org/show_bug.cgi?id=150026
1355
1356         Reviewed by Philippe Normand.
1357
1358         Backport upstream patch from gst-plugins-bad so that the right version
1359         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1360         gets compiled properly, avoiding crashes on runtime while running tests.
1361
1362         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1363         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1364
1365 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1366
1367         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1368         https://bugs.webkit.org/show_bug.cgi?id=149777
1369
1370         Reviewed by Simon Fraser.
1371
1372         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1373         to the list of tests to preinstall at startup time.
1374
1375         Also, update the generation of the 'name' table in the FontWithFeatures font.
1376
1377         * DumpRenderTree/mac/DumpRenderTree.mm:
1378         (allowedFontFamilySet):
1379         (activateTestingFonts):
1380         (activateFontsIOS):
1381         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1382         (Generator::generate):
1383         (Generator::appendCFFTable):
1384         (Generator::appendNameSubtable):
1385         (Generator::appendNAMETable):
1386         * FontWithFeatures/FontWithFeatures/main.cpp:
1387         (main):
1388         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1389         (WTR::allowedFontFamilySet):
1390         (WTR::activateFonts):
1391         * WebKitTestRunner/mac/TestControllerMac.mm:
1392         (WTR::allowedFontFamilySet):
1393
1394 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1395
1396         Unreviewed. Add Jinyoung Hur as a committer.
1397
1398         * Scripts/webkitpy/common/config/contributors.json:
1399
1400 2015-10-10  Dan Bernstein  <mitz@apple.com>
1401
1402         [iOS] Remove unnecessary iOS version checks
1403         https://bugs.webkit.org/show_bug.cgi?id=150002
1404
1405         Reviewed by Alexey Proskuryakov.
1406
1407         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1408         (-[HIDEventGenerator _createIOHIDEventType:]):
1409         (-[HIDEventGenerator _sendHIDEvent:]):
1410         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1411         * WebKitTestRunner/ios/UIKitSPI.h:
1412
1413 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1414
1415         Unreviewed, rolling out r190689
1416         https://bugs.webkit.org/show_bug.cgi?id=149992
1417
1418         Fixed in other repository.
1419
1420         Reverted changesets:
1421
1422         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1423         https://bugs.webkit.org/show_bug.cgi?id=149897
1424
1425 2015-10-09  Brian Burg  <bburg@apple.com>
1426
1427         Teach webkitperl how to figure out IOS versions from the SDK
1428         https://bugs.webkit.org/show_bug.cgi?id=149963
1429
1430         Reviewed by Daniel Bates.
1431
1432         It should be easier to check the major and minor version of IOS SDKs.
1433
1434         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1435         * Scripts/webkitdirs.pm:
1436         (splitVersionString): Added.
1437         (determineOSXVersion): Use splitVersionString.
1438         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1439         (iosVersion): Added.
1440
1441 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1442
1443         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1444         https://bugs.webkit.org/show_bug.cgi?id=149960
1445
1446         Reviewed by Tim Horton.
1447
1448         Use adoptWK(), and null out some members (file is not using ARC).
1449
1450         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1451         (UIScriptContext::uiScriptComplete):
1452         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1453         (-[TestRunnerWKWebView dealloc]):
1454
1455 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1456
1457         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1458         https://bugs.webkit.org/show_bug.cgi?id=149954
1459
1460         Reviewed by Darin Adler.
1461
1462         * Scripts/webkitperl/FeatureList.pm:
1463
1464 2015-10-09  Daniel Bates  <dabates@apple.com>
1465
1466         Make iOS builders generate debug information in a separate dSYM file
1467         https://bugs.webkit.org/show_bug.cgi?id=149696
1468
1469         Reviewed by Darin Adler.
1470
1471         Similar to the Mac builders, the iOS builders should write debug information
1472         into a separate dSYM file instead of including such information in the binary
1473         itself (default Xcode behavior)
1474
1475         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1476         (CompileWebKit.start):
1477
1478 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1479
1480         Fix webkitpy tests after r190779
1481         https://bugs.webkit.org/show_bug.cgi?id=149949
1482
1483         Reviewed by Ryosuke Niwa.
1484
1485         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1486         (BenchmarkResults.format):
1487         (BenchmarkResults._format_values):
1488
1489 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1490
1491         Extend run-benchmark script to support human-readable results conversion.
1492         https://bugs.webkit.org/show_bug.cgi?id=149944
1493
1494         Reviewed by Ryosuke Niwa.
1495
1496         Add '--read-results-json' and '--no-adjust-unit' options.
1497         '--read-results-json' option converts result file to human readable format.
1498         '--no-adjust-unit' option skips scientific notation convertion.
1499         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1500
1501         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1502         (BenchmarkResults.format):
1503         (BenchmarkResults._format_tests):
1504         (BenchmarkResults._format_values):
1505         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1506         (BenchmarkRunner.__init__):
1507         (BenchmarkRunner._run_benchmark):
1508         (BenchmarkRunner._dump):
1509         (BenchmarkRunner.show_results):
1510         (BenchmarkRunner._show_results): Deleted.
1511         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1512         (parse_args):
1513         (start):
1514
1515 2015-10-08  Daniel Bates  <dabates@apple.com>
1516
1517         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1518         https://bugs.webkit.org/show_bug.cgi?id=149945
1519
1520         Reviewed by Dan Bernstein.
1521
1522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1524         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1526         (WebKitBuildbot):
1527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1528         (table.queue-grid tr.platform.ios-9 img.logo):
1529
1530 2015-10-08  Daniel Bates  <dabates@apple.com>
1531
1532         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1533         https://bugs.webkit.org/show_bug.cgi?id=149943
1534
1535         Reviewed by Dan Bernstein.
1536
1537         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1538         teach build-webkit to install them when building for iOS device using the public iOS SDK.
1539
1540         * Scripts/build-webkit:
1541
1542 2015-10-08  Daniel Bates  <dabates@apple.com>
1543
1544         Add LLVM binaries for iOS 9 device
1545         https://bugs.webkit.org/show_bug.cgi?id=149913
1546
1547         Reviewed by Filip Pizlo.
1548
1549         Implement support for building LLVM for ARM64-based iOS devices.
1550
1551         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1552         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1553         an existing build earlier in the file such that remove previously built
1554         libraries before building/copying new ones (if applicable).
1555         (fileContains): Moved function outside of if-block.
1556         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1557         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1558         added logic to build LLVM for ARM64-based iOS devices.
1559         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1560         LLVM into the WebKitBuild directory.
1561
1562 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1563
1564         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1565         https://bugs.webkit.org/show_bug.cgi?id=149848
1566
1567         Reviewed by Darin Adler.
1568
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1570
1571 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1572
1573         [Win] Support 64-bit Build and Testing
1574         https://bugs.webkit.org/show_bug.cgi?id=149904
1575
1576         Reviewed by Daniel Bates.
1577
1578         Extend our existing scripts to support 64-bit build and test operations on
1579         Windows.
1580
1581         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1582         Windows always builds the whole stack.
1583         * Scripts/webkit-build-directory: Add an option to return the location of
1584         the executable files produced by a specific configuration. This change is
1585         actually useful for Gtk and EFL, too.
1586         * Scripts/webkitdirs.pm:
1587         (executableProductDir): Added. This function appends the proper binary
1588         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1589         (jscProductDir): Use the new 'executableProductDir' method.
1590         (setPathForRunningWebKitApp): Ditto.
1591         (runSafari): Ditto.
1592         (runMiniBrowser): Ditto.
1593         * Scripts/webkitpy/port/factory.py:
1594         (configuration_options): Add a 64-bit option, used on Windows to specify
1595         which binary target should be used for testing.
1596         * Scripts/webkitpy/port/win.py:
1597         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1598         processes when needed.
1599         (WinPort._build_path): Add the correct binary target path to _build_path.
1600         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1601         64-bit paths for 64-bit tests.
1602         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1603         NTSD debugger does not understand this argument.
1604
1605 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1606
1607         Test font-variant-* and font-feature-settings with TrueType fonts
1608         https://bugs.webkit.org/show_bug.cgi?id=149776
1609
1610         Reviewed by Simon Fraser.
1611
1612         This test extends our existing FontWithFeatures project to be able to generate a
1613         TrueType font. This font is conceptually similar as the existing OpenType font,
1614         except the feature -> character mapping is different.
1615
1616         The font itself only supports the following characters:
1617         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1618         However, the shape of these letters are either an X or a check mark.
1619         The letter "A" always is a check mark.
1620         The letter "B" always is an X.
1621         Each font feature has an letter associated with it. When the font feature is enabled,
1622         that letter is shown as a check mark. For example, when
1623         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1624         mark.
1625
1626         Here are the mappings of font features to letters:
1627         kLigaturesType / kCommonLigaturesOnSelector: C
1628         kLigaturesType / kContextualLigaturesOnSelector: D
1629         kLigaturesType / kRareLigaturesOnSelector: G
1630         kLigaturesType / kHistoricalLigaturesOnSelector: I
1631         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1632         kVerticalPositionType / kInferiorsSelector: O
1633         kVerticalPositionType / kSuperiorsSelector: P
1634         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1635         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1636         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1637         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1638         kLetterCaseType / 14: Y
1639         kStyleOptionsType / kTitlingCapsSelector: a
1640         kNumberCaseType / kUpperCaseNumbersSelector: c
1641         kNumberCaseType / kLowerCaseNumbersSelector: d
1642         kNumberSpacingType / kProportionalNumbersSelector: f
1643         kNumberSpacingType / kMonospacedNumbersSelector: g
1644         kFractionsType / kDiagonalFractionsSelector: i
1645         kFractionsType / kVerticalFractionsSelector: j
1646         kVerticalPositionType / kOrdinalsSelector: Q
1647         kTypographicExtrasType / kSlashedZeroOnSelector: k
1648         kLigaturesType / kHistoricalLigaturesOnSelector: K
1649         kCharacterShapeType / kJIS1978CharactersSelector: m
1650         kCharacterShapeType / kJIS1983CharactersSelector: n
1651         kCharacterShapeType / kJIS1990CharactersSelector: o
1652         kCharacterShapeType / kJIS2004CharactersSelector: p
1653         kCharacterShapeType / kSimplifiedCharactersSelector: q
1654         kCharacterShapeType / kTraditionalCharactersSelector: r
1655         kTextSpacingType / kMonospacedTextSelector: t
1656         kTextSpacingType / kProportionalTextSelector: u
1657         kRubyKanaType / kRubyKanaOnSelector: v
1658
1659         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1660         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1661         (CFFBuilder::moveTo):
1662         (CFFBuilder::lineTo):
1663         (GLYFBuilder::GLYFBuilder):
1664         (GLYFBuilder::takeResult):
1665         (GLYFBuilder::moveTo):
1666         (GLYFBuilder::lineTo):
1667         (GLYFBuilder::closePath):
1668         (GLYFBuilder::writePoint):
1669         (GLYFBuilder::append16):
1670         (generateBoxCharString):
1671         (generateCheckCharString):
1672         (generateXCharString):
1673         (itemForGlyph):
1674         (Generator::generate):
1675         (Generator::insertSelector):
1676         (Generator::insertFeature):
1677         (Generator::generateFeatureDescription):
1678         (Generator::appendCFFTable):
1679         (Generator::appendGLYFTable):
1680         (Generator::appendLOCATable):
1681         (Generator::appendFEATTable):
1682         (Generator::appendMetamorphosisChain):
1683         (Generator::appendMORXTable):
1684         (Generator::appendHEADTable):
1685         (Generator::appendHMTXTable):
1686         (Generator::appendNameSubtable):
1687         (Generator::append2ByteASCIIString):
1688         (Generator::appendNAMETable):
1689         (generateFont):
1690         (CFFBuilder::curveToCubic): Deleted.
1691         (charStringForGlyph): Deleted.
1692         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1693         * FontWithFeatures/FontWithFeatures/main.cpp:
1694         (constructFontWithTrueTypeFeature):
1695         (constructFontWithOpenTypeFeature):
1696         (drawText):
1697         (main):
1698         (drawTextWithFeature): Deleted.
1699
1700 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1701
1702         Unreviewed, rolling out r190572, r190593, r190594, and
1703         r190639.
1704         https://bugs.webkit.org/show_bug.cgi?id=149897
1705
1706         Breaks Mavericks build (Requested by litherum on #webkit).
1707
1708         Reverted changesets:
1709
1710         "Allow WKRetainPtrs to be used as keys in hashing data
1711         structures"
1712         https://bugs.webkit.org/show_bug.cgi?id=149762
1713         http://trac.webkit.org/changeset/190572
1714
1715         "REGRESSION(189668?): http/tests/notifications/events.html
1716         flakily asserts or times out"
1717         https://bugs.webkit.org/show_bug.cgi?id=149218
1718         http://trac.webkit.org/changeset/190593
1719
1720         "Prospective Mavericks build fix."
1721         http://trac.webkit.org/changeset/190594
1722
1723         "Post-review cleanup after r190572."
1724         http://trac.webkit.org/changeset/190639
1725
1726 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1727
1728         [GTK] Add autocleanups
1729         https://bugs.webkit.org/show_bug.cgi?id=149588
1730
1731         Reviewed by Darin Adler.
1732
1733         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1734         (AutocleanupsTest::create):
1735         (AutocleanupsTest::testWebProcessAutocleanups):
1736         (registerTests):
1737         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1738         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1739         (testUIProcessAutocleanups):
1740         (testWebProcessAutocleanups):
1741         (beforeAll):
1742         (afterAll):
1743
1744 2015-10-06  Brian Burg  <bburg@apple.com>
1745
1746         Unreviewed, try to fix the iOS 8 build after r190368.
1747
1748         On older versions, IOHIDEventCreateForceEvent is not available.
1749
1750         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1751         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1752
1753 2015-10-06  Keith Miller  <keith_miller@apple.com>
1754
1755         Add gmalloc option to run-javascriptcore-tests.
1756         https://bugs.webkit.org/show_bug.cgi?id=149858
1757
1758         Reviewed by Geoffrey Garen.
1759
1760         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1761         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1762
1763         * Scripts/run-javascriptcore-tests:
1764
1765 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1766
1767         Post-review cleanup after r190572.
1768
1769         Unreviewed.
1770
1771         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1772
1773 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1774
1775         [Win] Unreviewed build correction.
1776
1777         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1778         are soft-linked at runtime.
1779
1780 2015-10-06  Keith Miller  <keith_miller@apple.com>
1781
1782         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1783         https://bugs.webkit.org/show_bug.cgi?id=149815
1784
1785         Reviewed by Filip Pizlo.
1786
1787         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1788         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1789         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1790         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1791         so should just use one test runner.
1792
1793         * Scripts/run-javascriptcore-tests:
1794         (runJSCStressTests):
1795         (runMozillaTests): Deleted.
1796         (defaultJsDriverArgsForMozillaTests): Deleted.
1797         * Scripts/run-jsc-stress-tests:
1798
1799 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1800
1801         [GTK] Make update-webkitgtk-libs work behind firewall
1802
1803         update-webkitgtk-libs can work behind a firewall with changes to
1804         a few packages.  Where outbound git and active FTP connections
1805         fail, using http protocol succeeds.  Most packages are
1806         already accessed using http.
1807
1808         https://bugs.webkit.org/show_bug.cgi?id=148941
1809
1810         Reviewed by Martin Robinson.
1811
1812         Tools
1813         * gtk/jhbuild.modules:
1814             Replace git URLs with http.  Remove no longer used ftp repositories.
1815             Update argument for libxml2's autogen.sh script (--without-python
1816             is ignored; --with-python=no is correct).
1817         * jhbuild/jhbuild-wrapper:
1818             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1819             http://git.gnome.org/browse/jhbuild.
1820
1821 2015-10-06  Daniel Bates  <dbates@webkit.org>
1822
1823         Enable XSLT when building WebKit for iOS using the public iOS SDK
1824         https://bugs.webkit.org/show_bug.cgi?id=149827
1825
1826         Reviewed by Alexey Proskuryakov.
1827
1828         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1829         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1830         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1831         headers cannot be found.
1832
1833         * Scripts/configure-xcode-for-ios-development:
1834         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1835
1836 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1837
1838         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1839         https://bugs.webkit.org/show_bug.cgi?id=149218
1840
1841         Reviewed by Alexey Proskuryakov.
1842
1843         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1844         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1845         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1846         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1847         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1848         WebNotificationProvider must be updated to appropriately handle multiple
1849         WKNotificationManagerRefs in flight at the same time.
1850
1851         * WebKitTestRunner/WebNotificationProvider.cpp:
1852         (WTR::WebNotificationProvider::~WebNotificationProvider):
1853         (WTR::WebNotificationProvider::showWebNotification):
1854         (WTR::WebNotificationProvider::closeWebNotification):
1855         (WTR::WebNotificationProvider::addNotificationManager):
1856         (WTR::WebNotificationProvider::removeNotificationManager):
1857         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1858         (WTR::WebNotificationProvider::reset):
1859         * WebKitTestRunner/WebNotificationProvider.h:
1860
1861 2015-10-05  Daniel Bates  <dabates@apple.com>
1862
1863         Disable Bitcode when building for iOS device
1864         https://bugs.webkit.org/show_bug.cgi?id=149818
1865
1866         Reviewed by Alexey Proskuryakov.
1867
1868         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1869         when building for iOS device.
1870
1871         * Scripts/webkitdirs.pm:
1872         (XcodeOptions):
1873
1874 2015-10-05  Daniel Bates  <dabates@apple.com>
1875
1876         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1877         https://bugs.webkit.org/show_bug.cgi?id=140828
1878         <rdar://problem/19520599>
1879
1880         Reviewed by Alexey Proskuryakov.
1881
1882         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1883         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1884         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1885         to build-webkit.
1886
1887         * Scripts/webkitdirs.pm:
1888         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1889         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1890         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1891         (hasIOSDevelopmentCertificate): Added.
1892
1893 2015-10-05  Daniel Bates  <dabates@apple.com>
1894
1895         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1896         https://bugs.webkit.org/show_bug.cgi?id=149766
1897
1898         Reviewed by Alexey Proskuryakov.
1899
1900         Create network storage testing session on iOS.
1901
1902         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1903         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1904         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1905         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1906         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1907         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1908         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1909         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1910         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1911
1912         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1913         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1914         returns a non-null pointer to a cookie store.
1915
1916         * DumpRenderTree/mac/DumpRenderTree.mm:
1917         (prepareConsistentTestingEnvironment):
1918
1919 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1920
1921         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1922         available.
1923
1924         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1925         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1926
1927 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1928
1929         Allow WKRetainPtrs to be used as keys in hashing data structures
1930         https://bugs.webkit.org/show_bug.cgi?id=149762
1931
1932         Reviewed by Anders Carlsson.
1933
1934         * TestWebKitAPI/PlatformGTK.cmake:
1935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1936         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1937         (TestWebKitAPI::TEST):
1938
1939 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1940
1941         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1942         available, and tidy up the #ifdefs in the UIKitSPI header.
1943
1944         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1945         (-[HIDEventGenerator _sendHIDEvent:]):
1946         * WebKitTestRunner/ios/UIKitSPI.h:
1947
1948 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1949
1950         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1951         https://bugs.webkit.org/show_bug.cgi?id=149792
1952
1953         Reviewed by Martin Robinson.
1954
1955         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1956         for WebKitTestRunner multiple times.
1957
1958 2015-10-04  Daniel Bates  <dabates@apple.com>
1959
1960         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1961         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1962
1963         For now, support calling build-layouttestrelay without --ios-simulator so long
1964         as we are building on a Mac.
1965
1966         * Scripts/build-layouttestrelay:
1967
1968 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1969
1970         Support Trac 1.0.x XML timeline link format
1971         https://bugs.webkit.org/show_bug.cgi?id=149786
1972
1973         Reviewed by Lucas Forschler.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1976         (Trac.prototype._convertCommitInfoElementToObject):
1977
1978 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1979
1980         Fix some errors on bot watcher's dashboard
1981         https://bugs.webkit.org/show_bug.cgi?id=149789
1982
1983         Reviewed by Lucas Forschler.
1984
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1986         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1987         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1988
1989 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1990
1991         Bot watcher's dashboard builders should turn yellow when svn fails
1992         https://bugs.webkit.org/show_bug.cgi?id=149791
1993
1994         Reviewed by Lucas Forschler.
1995
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1997         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1998         (BuildbotBuilderQueueView.prototype.update):
1999
2000 2015-10-02  Daniel Bates  <dabates@apple.com>
2001
2002         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
2003         https://bugs.webkit.org/show_bug.cgi?id=149769
2004
2005         Reviewed by Alexey Proskuryakov.
2006
2007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2011         (WebKitBuildbot):
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2013         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
2014
2015 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
2016
2017         REGRESSION(r190370): Speedometer spits out an extra console message
2018         https://bugs.webkit.org/show_bug.cgi?id=149720
2019
2020         Unreviewed. Temporarily ignore the console error message.
2021
2022         * Scripts/webkitpy/performance_tests/perftest.py:
2023         (PerfTest._filter_output):
2024
2025 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
2026
2027         Provide "--no-ninja" option to avoid using Ninja
2028         https://bugs.webkit.org/show_bug.cgi?id=149757
2029
2030         Reviewed by Alex Christensen.
2031
2032         Add a new command line argument understood by webkitdirs.pm so
2033         that we can conditionally avoid using Ninja. This is an
2034         'opt-out' argument, so no existing Ninja users should be affected.
2035
2036         * Scripts/webkitdirs.pm:
2037         (canUseNinja): Check for option and block ninja if present.
2038
2039 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
2040
2041         Flakiness dashboard should support OS X El Capitan
2042         https://bugs.webkit.org/show_bug.cgi?id=149648
2043
2044         Reviewed by Alexey Proskuryakov.
2045
2046         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
2047
2048 2015-10-02  Daniel Bates  <dabates@apple.com>
2049
2050         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
2051         (https://bugs.webkit.org/show_bug.cgi?id=149753)
2052
2053         For now, pass --ios-simulator.
2054
2055         * Scripts/webkitpy/port/ios.py:
2056         (IOSSimulatorPort._build_relay):
2057
2058 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
2059
2060         Remove a "nullable" that breaks the iOS 8 build.
2061
2062         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2063         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
2064
2065 2015-10-02  Daniel Bates  <dabates@apple.com>
2066
2067         LayoutTestRelay is not built and archived when building for iOS Simulator
2068         https://bugs.webkit.org/show_bug.cgi?id=149753
2069
2070         Reviewed by Alexey Proskuryakov and Andy Estes.
2071
2072         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
2073         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
2074         product archive when building for iOS Simulator, respectively.
2075
2076         * BuildSlaveSupport/built-product-archive:
2077         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
2078         differentiate between iOS device and iOS Simulator platforms.
2079         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
2080         from determineWebKitBuildDirectories() into this function so that it can be used by both
2081         determineWebKitBuildDirectories() and archiveBuiltProduct().
2082         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
2083         webkitBuildDirectoryForConfigurationAndPlatform().
2084         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
2085         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
2086         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
2087         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
2088         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
2089         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
2090         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
2091         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
2092         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
2093         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
2094         * Scripts/build-layouttestrelay:
2095             - Remove unnecessary include of Perl module POSIX.
2096             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
2097         * Scripts/build-webkit:
2098             - Invoke script build-layouttestrelay when building for iOS Simulator.
2099
2100 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
2101
2102         [Win] Unreviewed test fix.
2103
2104         You cannot run 'run-webkit-tests' from the command line because it does not know
2105         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
2106         because they explicitly set use the 'root' argument to provide the full path to
2107         the test binaries.
2108
2109         * Scripts/webkitpy/port/win.py:
2110         (WinPort._build_path): Added.
2111
2112 2015-10-02  Alex Christensen  <achristensen@webkit.org>
2113
2114         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
2115         https://bugs.webkit.org/show_bug.cgi?id=149430
2116         rdar://problem/22742222
2117
2118         Reviewed by Geoffrey Garen.
2119
2120         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2121         (WTR::TestController::cocoaResetStateToConsistentValues):
2122         * WebKitTestRunner/mac/TestControllerMac.mm:
2123         (WTR::TestController::platformConfigureViewForTest):
2124         Test what happens when you disable content blockers from the SPI.
2125
2126 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2127
2128         [Win] Unreviewed build fix for run-api-tests
2129
2130         * Scripts/run-api-tests:
2131         (testToolPaths): Windows run needs to specify the binary path.
2132
2133 2015-10-01  Daniel Bates  <dabates@apple.com>
2134
2135         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
2136         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2137
2138         Following r190424 we can now rely on webkit-build-directory to return the path to
2139         the correct configuration-specific build directory on Windows.
2140
2141         * BuildSlaveSupport/built-product-archive:
2142         (archiveBuiltProduct):
2143
2144 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2145
2146         [Win] Unreviewed build fix.
2147
2148         * Scripts/webkitdirs.pm:
2149         (setupAppleWinEnv): Use 64-bit build tools if available
2150
2151 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2152
2153         [Win] Fix TestWebKitAPI build under CMake.
2154
2155         Reviewed by Alex Christensen.
2156
2157         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
2158         for Psapi.lib.
2159
2160 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2161
2162         [Win] Fix behavior of webkit-build-directory script
2163         https://bugs.webkit.org/show_bug.cgi?id=149718
2164
2165         Reviewed by Alex Christensen.
2166
2167         * Scripts/webkitdirs.pm:
2168         (determineConfigurationProductDir): Do not include the binary
2169         sub-directory in the configuration product directory output.
2170         (jscProductDir): Append correct binary path for Windows build.
2171         (setPathForRunningWebKitApp): Include properly binary subdirectories.
2172         (runSafari): Update for revised productDir behavior.
2173         (runMiniBrowser): Ditto.
2174
2175 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2176
2177         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2178         use iOS SDK, like with all the others.
2179
2180         * Scripts/build-webkit:
2181
2182 2015-10-01  Daniel Bates  <dabates@apple.com>
2183
2184         Attempt to fix the iOS 9 Simulator testers
2185
2186         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2187         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2188         LayoutTestRelay when building for iOS Simulator.
2189
2190         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2191         * Scripts/build-webkit:
2192
2193 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2194
2195         [GTK] Websites with invalid auth header keep loading forever
2196         https://bugs.webkit.org/show_bug.cgi?id=149710
2197
2198         Reviewed by Martin Robinson.
2199
2200         Add test case to check that we can authenticate sites with an
2201         empty realm.
2202
2203         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2204         (testWebViewAuthenticationEmptyRealm):
2205         (serverCallback):
2206         (beforeAll):
2207
2208 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2209
2210         [Mac] Make run-api-tests work with System Integrity Protection
2211         https://bugs.webkit.org/show_bug.cgi?id=149711
2212         rdar://problem/22928202
2213
2214         Reviewed by Dan Bernstein.
2215
2216         * Scripts/run-api-tests:
2217         (runTest):
2218         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2219
2220 2015-10-01  Daniel Bates  <dabates@apple.com>
2221
2222         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2223         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2224
2225         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2226         For now, use the path to the top-level WebKit build directory instead of using the configuration-
2227         specific build directory.
2228
2229         * BuildSlaveSupport/built-product-archive:
2230         (archiveBuiltProduct):
2231
2232 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2233
2234         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2235         https://bugs.webkit.org/show_bug.cgi?id=145837
2236
2237         Reviewed by Philippe Normand.
2238
2239         * efl/jhbuild.modules:
2240         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2241         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2242
2243 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2244
2245         Unreviewed. Fix the iOS build after r190407.
2246
2247         * WebKitTestRunner/ios/IOKitSPI.h:
2248
2249 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2250
2251         Implement keyboard event sending for iOS in WebKitTestRunner
2252         https://bugs.webkit.org/show_bug.cgi?id=149676
2253
2254         Reviewed by Simon Fraser.
2255
2256         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2257         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2258         allows us to run code when the keyboard is shown or hidden.
2259
2260         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2261         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2262         (WTR::UIScriptController::setDidShowKeyboardCallback):
2263         (WTR::UIScriptController::didShowKeyboardCallback):
2264         (WTR::UIScriptController::setDidHideKeyboardCallback):
2265         (WTR::UIScriptController::didHideKeyboardCallback):
2266         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2267         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2268         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2269         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2270         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2271         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2272         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2273                 the notifications that the keyboard has been raised or lowered.
2274         (-[TestRunnerWKWebView _keyboardDidShow:]):
2275         (-[TestRunnerWKWebView _keyboardDidHide:]):
2276         * WebKitTestRunner/ios/HIDEventGenerator.h:
2277         * WebKitTestRunner/ios/HIDEventGenerator.m:
2278         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2279         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2280         (hidUsageCodeForCharacter): Ditto.
2281         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2282                 a keyDown event in WebKit.
2283         * WebKitTestRunner/ios/IOKitSPI.h:
2284         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2285
2286 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2287
2288         Unreviewed, rolling out r190399.
2289
2290         Tests are still failing even after r190362
2291
2292         Reverted changeset:
2293
2294         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2295         http://trac.webkit.org/changeset/190399
2296
2297 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2298
2299         [jhbuild] switch to new upstream usrsctp library
2300         https://bugs.webkit.org/show_bug.cgi?id=149494
2301
2302         Reviewed by Philippe Normand.
2303
2304         * efl/jhbuild.modules:
2305         * gtk/jhbuild.modules:
2306
2307 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2308
2309         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2310
2311         They should pass now.
2312
2313         * Scripts/run-gtk-tests:
2314         (TestRunner):
2315
2316 2015-09-30  Daniel Bates  <dabates@apple.com>
2317
2318         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2319         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2320
2321         * BuildSlaveSupport/built-product-archive:
2322         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2323         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2324
2325 2015-09-30  Daniel Bates  <dabates@apple.com>
2326
2327         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2328         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2329
2330         Actually, we need to pass --configuration to script webkit-build-directory to have
2331         it return the path to the configuration-specific build directory.
2332
2333         * BuildSlaveSupport/built-product-archive:
2334         (determineWebKitBuildDirectories):
2335
2336 2015-09-30  Daniel Bates  <dabates@apple.com>
2337
2338         built-product-archive archives incorrect build directory for iOS port
2339         https://bugs.webkit.org/show_bug.cgi?id=149695
2340
2341         Reviewed by Darin Adler.
2342
2343         Fixes an issue where the script built-product-archive archives a non-existent
2344         build directory for the iOS port. Without loss of generality, the script assumes
2345         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2346         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2347
2348         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2349         to determine the top-level build directory and computes the configuration-specific
2350         build directory to be the concatenation of the the top-level build directory and
2351         the configuration (e.g. Release). This is incorrect. Instead we should call
2352         webkit-build-directory omitting the flag --top-level to compute the path to the
2353         configuration-specific build directory.
2354
2355         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2356         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2357         its purpose and added global variable _configurationBuildDirectory to store the path
2358         to the configuration-specific build directory. Ensure that we have a non-empty string
2359         for both the top-level and configuration-specific build directories.
2360         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2361         Compute the configuration-specific build directory and store it in the global variable
2362         _configurationBuildDirectory.
2363         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2364         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2365         as needed.
2366         (determineWebKitBuildDirectory): Deleted.
2367
2368 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2369
2370         [EFL] css3/device-adapt/* tests failed after r190335.
2371         https://bugs.webkit.org/show_bug.cgi?id=149655
2372
2373         Reviewed by Simon Fraser.
2374
2375         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2376         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2377
2378         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2379         (WTR::shouldUseFixedLayout):
2380
2381 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2382
2383         Extend JetStream timeout for slow devices.
2384
2385         Reviewed by Chris Dumez.
2386
2387         Extend JetStream timeout to 20 minutes.
2388
2389         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2390
2391 2015-09-30  Daniel Bates  <dabates@apple.com>
2392
2393         Rename iOS builders/testers to include version
2394         https://bugs.webkit.org/show_bug.cgi?id=149685
2395
2396         Reviewed by Simon Fraser.
2397
2398         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2399         make it clear to a reader the version of iOS these builders/testers are using.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/config.json:
2402         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2403
2404 2015-09-30  Daniel Bates  <dabates@apple.com>
2405
2406         Add iOS criterion for triggering a build
2407         https://bugs.webkit.org/show_bug.cgi?id=149679
2408
2409         Rubber-stamped by Alexey Proskuryakov.
2410
2411         First pass at defining criterion for triggering an iOS build.
2412
2413         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2414         (_should_file_trigger_build):
2415         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2416         (ShouldBuildTest):
2417         (ShouldBuildTest.test_should_build):
2418
2419 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2420
2421         [iOS] Allow tests to generate user gestures for UI testing
2422         https://bugs.webkit.org/show_bug.cgi?id=149653
2423
2424         Reviewed by Tim Horton.
2425
2426         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2427         and to listen for completion of scrolling and zooming in the WKWebView.
2428
2429         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2430         which hides the complexity of creating these events. Event dispatch is asynchronous.
2431         We detect when the last event has been handled by dispatching a vendor-specific event,
2432         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2433
2434         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2435         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2436         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2437         single and double taps.
2438         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2439         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2440         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2441         (UIScriptContext::unregisterCallback):
2442         (UIScriptContext::callbackWithID):
2443         (UIScriptContext::fireCallback):
2444         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2445         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2446         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2447         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2448         (WTR::UIScriptController::setDidEndZoomingCallback):
2449         (WTR::UIScriptController::didEndZoomingCallback):
2450         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2451         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2452         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2453         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2454         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2455         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2456         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2457         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2458         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2459         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2460         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2461         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2462         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2463         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2464         (simpleDragCurve):
2465         (calculateNextLocation):
2466         (delayBetweenMove):
2467         (+[HIDEventGenerator sharedHIDEventGenerator]):
2468         (+[HIDEventGenerator nextEventCallbackID]):
2469         (-[HIDEventGenerator init]):
2470         (-[HIDEventGenerator _createIOHIDEventType:]):
2471         (-[HIDEventGenerator _sendHIDEvent:]):
2472         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2473         (-[HIDEventGenerator _updateTouchPoints:count:]):
2474         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2475         (-[HIDEventGenerator touchDown:touchCount:]):
2476         (-[HIDEventGenerator touchDown:]):
2477         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2478         (-[HIDEventGenerator liftUp:touchCount:]):
2479         (-[HIDEventGenerator liftUp:]):
2480         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2481         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2482         (-[HIDEventGenerator tap:completionBlock:]):
2483         (-[HIDEventGenerator doubleTap:completionBlock:]):
2484         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2485         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2486         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2487         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2488         (-[HIDEventGenerator markerEventReceived:]):
2489         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2490         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2491         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2492         (WTR::globalToContentCoordinates):
2493         (WTR::UIScriptController::singleTapAtPoint):
2494         (WTR::UIScriptController::doubleTapAtPoint):
2495         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2496         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2497         * WebKitTestRunner/ios/mainIOS.mm:
2498         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2499
2500 2015-09-30  Dana Burkart  <dburkart@apple.com>
2501
2502         git-add-reviewer should trim trailing spaces/newlines
2503         https://bugs.webkit.org/show_bug.cgi?id=149513
2504
2505         Reviewed by Darin Adler.
2506
2507         * Scripts/git-add-reviewer:
2508         (nonInteractive):
2509
2510 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2511
2512         REGRESSION(r190262): User media unit test failures after r190262
2513         https://bugs.webkit.org/show_bug.cgi?id=149580
2514
2515         Reviewed by Darin Adler.
2516
2517         * WebKitTestRunner/TestController.cpp:
2518         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2519           order to WKUserMediaPermissionRequestAllow.
2520
2521 2015-09-30  Daniel Bates  <dabates@apple.com>
2522
2523         Add iOS builders and testers
2524         https://bugs.webkit.org/show_bug.cgi?id=149549
2525
2526         Reviewed by Alexey Proskuryakov.
2527
2528         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2529         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2530
2531         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2532         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2533
2534 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2535
2536         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2537         https://bugs.webkit.org/show_bug.cgi?id=149674
2538
2539         Reviewed by Lucas Forschler.
2540
2541         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2542         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2543
2544 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2545
2546         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2547         have an associated trac instance.
2548         https://bugs.webkit.org/show_bug.cgi?id=149673
2549
2550         Reviewed by Alexey Proskuryakov.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2553         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2554         have an associated trac instance.
2555
2556 2015-09-30  Daniel Bates  <dabates@apple.com>
2557
2558         Prioritize testing latest build request on iOS test bots
2559         https://bugs.webkit.org/show_bug.cgi?id=149669
2560
2561         Reviewed by Darin Adler.
2562
2563         We should prioritize testing of the latest build request on the iOS test bots
2564         as we do for Mac and Windows test bots.
2565
2566         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2567         (loadBuilderConfig):
2568
2569 2015-09-30  Daniel Bates  <dabates@apple.com>
2570
2571         Add buildbot category for iOS builders and testers
2572         https://bugs.webkit.org/show_bug.cgi?id=149667
2573
2574         Reviewed by Darin Adler.
2575
2576         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2577         for iOS to the build.webkit.org home page.
2578
2579         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2580         (loadBuilderConfig):
2581         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2582
2583 2015-09-30  Daniel Bates  <dabates@apple.com>
2584
2585         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2586         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2587
2588         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2589         in <http://trac.webkit.org/changeset/190351>.
2590
2591         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2592         (CompileWebKit.start):
2593
2594 2015-09-30  Daniel Bates  <dabates@apple.com>
2595
2596         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2597         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2598
2599         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2600         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2601
2602         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2603         (CompileWebKit.start):
2604
2605 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2606
2607         bot210 was configured for a queue instead of bot126.
2608
2609         Unreviewed config.json fix.
2610
2611         * BuildSlaveSupport/build.webkit.org-config/config.json:
2612
2613 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2614
2615         Bring El Capitan buildbot infrastructure online.
2616         https://bugs.webkit.org/show_bug.cgi?id=149605
2617
2618         Reviewed by Darin Adler.
2619
2620         * BuildSlaveSupport/build.webkit.org-config/config.json:
2621
2622 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2623
2624         [GTK] Deprecation warnings in DOMNodeTest
2625         https://bugs.webkit.org/show_bug.cgi?id=149663
2626
2627         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2628         need to update the tests to use webkit_dom_document_query_selector_all
2629         to avoid compilation warnings.
2630
2631         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2632         (the suggested replacement for the deprecated function).
2633
2634         Reviewed by Carlos Garcia Campos.
2635
2636         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2637         (WebKitDOMNodeTest::testTagNamesNodeList):
2638         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2639         (registerTests):
2640         (WebKitDOMNodeTest::testTagNames): Deleted.
2641         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2642         (prepareDOMForTagNamesTests):
2643         (testWebKitDOMNodeTagNamesNodeList):
2644         (testWebKitDOMNodeTagNamesHTMLCollection):
2645         (beforeAll):
2646         (testWebKitDOMNodeTagNames): Deleted.
2647
2648 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2649
2650         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2651         https://bugs.webkit.org/show_bug.cgi?id=149650
2652
2653         Reviewed by Tim Horton.
2654
2655         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2656         looks at the file path, and not the custom options that come from file comments.
2657
2658         Fix by computing TestOptions before making the TestInvocation, and setting them
2659         as const TestInvocation data. This meant changing various call sites to take
2660         the std::string pathOrURL, rather than the TestInvocation itself.
2661
2662         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2663
2664         * WebKitTestRunner/CMakeLists.txt:
2665         * WebKitTestRunner/TestController.cpp:
2666         (WTR::TestController::ensureViewSupportsOptionsForTest):
2667         (WTR::testPath):
2668         (WTR::createTestURL):
2669         (WTR::updateTestOptionsFromTestHeader):
2670         (WTR::TestController::testOptionsForTest):
2671         (WTR::TestController::updateWebViewSizeForTest):
2672         (WTR::TestController::updateWindowScaleForTest):
2673         (WTR::TestController::runTest):
2674         * WebKitTestRunner/TestController.h:
2675         * WebKitTestRunner/TestInvocation.cpp:
2676         (WTR::TestInvocation::TestInvocation):
2677         (WTR::TestInvocation::invoke):
2678         (WTR::createWKURL): Deleted.
2679         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2680         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2681         * WebKitTestRunner/TestInvocation.h:
2682         (WTR::TestInvocation::options):
2683         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2684         (WTR::pathContains):
2685         (WTR::shouldMakeViewportFlexible):
2686         (WTR::shouldUseFixedLayout):
2687         (WTR::isSVGTestPath):
2688         (WTR::isHiDPITestPath):
2689         (WTR::TestOptions::TestOptions):
2690         * WebKitTestRunner/TestOptions.h:
2691         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2692         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2693         (WTR::pathContains):
2694         (WTR::shouldUseFixedLayout):
2695         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2696         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2697         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2698         * WebKitTestRunner/ios/TestControllerIOS.mm:
2699         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2700         * WebKitTestRunner/mac/TestControllerMac.mm:
2701         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2702
2703 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2704
2705         Flakiness dashboard should support OS X El Capitan
2706         https://bugs.webkit.org/show_bug.cgi?id=149648
2707
2708         Reviewed by Alexey Proskuryakov.
2709
2710         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
2711         difference between new appscale and old Google App Engine implementation.
2712         * TestResultServer/app.yaml: Same.
2713         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2714
2715 2015-09-29  Daniel Bates  <dabates@apple.com>
2716
2717         configure-xcode-for-ios-development does not work with Xcode 7
2718         https://bugs.webkit.org/show_bug.cgi?id=149640
2719
2720         Reviewed by Alexey Proskuryakov.
2721
2722         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2723         because it cannot find the Xcode specification files for iOS simulator and device. These
2724         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2725         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2726         new specification files with the added definitions (as we did in older versions of Xcode)
2727         in order for Xcode 7 to honor these definitions.
2728
2729         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2730         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2731         (updateXcode7SpecificationFile): Added.
2732         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2733         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2734         appropriate success message.
2735         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2736         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2737         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2738
2739 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2740
2741         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2742         https://bugs.webkit.org/show_bug.cgi?id=149639
2743
2744         Reviewed by Alex Christensen.
2745
2746         * Scripts/VCSUtils.pm:
2747         (exitStatus): Use 'isWindows()' method.
2748         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2749         an error. This method could probably just go away.
2750         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2751         always changing to Unix style.
2752         (unixPath): Added. Needed so Windows can always show a Unix path in the
2753         ChangeLog file.
2754         (changeLogName): Work around the fact that 'getpwuid' is not available on
2755         a pure Windows build of Perl.
2756         * Scripts/prepare-ChangeLog:
2757         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2758         path on Windows.
2759         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2760         support using arrays for 'open' arguments.
2761         (resolveChangeLogsPath): Ditto.
2762         (resolveConflictedChangeLogs): Use new helper functions.
2763         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2764         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2765         quotes. Unix systems are happy either way.
2766         (statusCommand): Ditto.
2767         * Scripts/webkitdirs.pm:
2768         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2769
2770 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2771
2772         [Win] Unreviewed 64-bit build fix after switch to CMake.
2773
2774         * Scripts/webkitdirs.pm:
2775         (determineIsWin64FromArchitecture): Added.
2776
2777 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2778
2779         printing does not use minimum page zoom factor
2780         https://bugs.webkit.org/show_bug.cgi?id=108507
2781
2782         Reviewed by Darin Adler.
2783
2784         WebKitTestRunner always takes the snapshots from the UI process
2785         (expect for IOS), so in the case of printing, the layout in the
2786         web view is not the expected one. When printing, we need to take
2787         the snapshot in the web process and ensure it's rendered with a
2788         PrintContext.
2789
2790         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2791         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2792         kWKSnapshotOptionsPrinting option to
2793         WKBundlePageCreateSnapshotWithOptions() when printing.
2794
2795 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2796
2797         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2798         https://bugs.webkit.org/show_bug.cgi?id=149595
2799
2800         Reviewed by Tim Horton.
2801
2802         All ports except IOS implement
2803         PlatformWebView::windowSnapshotImage() to generate the snapshot
2804         for the pixel tests in the UI process. But we are still generating
2805         a snapshot for pixel tests in the Web process too, that is passed
2806         to the UI process but ignored.
2807         Whether a pixel result is needed or not, is only known by the web
2808         process depending on whether the test called dumpAsText with
2809         dumpPixels == true or not. Since the pixels are now dump in the UI
2810         process, we need to pass that information to the UI process when
2811         the test is done. For that we set a PixelResultIsPending bool
2812         parameter to the Done message, and we only add the PixelResult
2813         when UI process doesn't need to generate the pixels dump.
2814
2815         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2816         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2817         m_pixelResultIsPending to false on reset.
2818         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2819         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2820         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2821         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2822         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2823         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2824         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2825         port.
2826         * WebKitTestRunner/TestInvocation.cpp:
2827         (WTR::TestInvocation::dumpResults): Use either the pixel result
2828         from the web process or generate a pixel result from the web view
2829         if need it.
2830         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2831         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2832         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2833         is created by the caller now, but the CG implementation needs to
2834         know if it's a Web or UI process snapshot.
2835         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2836         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2837         cairo surface for the given image.
2838         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2839         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2840         CGContext for the given image.
2841
2842 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2843
2844         Fix JS errors on dashboard metrics page
2845         https://bugs.webkit.org/show_bug.cgi?id=149608
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2850         (initPlatformsByFamily):
2851         (updateHiddenPlatforms):
2852         (parsePlatformFamily): Deleted.
2853         (updateToggleButtons): Deleted.
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2855         (updateHiddenPlatforms): Added to remove errors.
2856         (initPlatformsByFamily): Added to remove errors.
2857         (unhiddenQueues): Updated to use Settings.
2858         (documentReady): Added logic to add toggle buttons to the settings menu.
2859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2860         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2861         MetricsMain.js to Settings.
2862         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2863         MetricsMain.js to Settings.
2864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2865         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2866
2867 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2868
2869         Appscale query fails because of missing index
2870         https://bugs.webkit.org/show_bug.cgi?id=149609
2871
2872         Reviewed by Darin Adler.
2873
2874         * QueueStatusServer/index.yaml: Added the required index.
2875
2876 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2877
2878         [Win] Fix the 64-bit build after switch to cmake.
2879
2880         Reviewed by Alex Christensen.
2881
2882         * Scripts/webkitdirs.pm:
2883         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2884         run a 64-bit build.
2885
2886 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2887
2888         [Win] Allow Windows to run test-webkitpy without Cygwin
2889         https://bugs.webkit.org/show_bug.cgi?id=149602
2890
2891         Reviewed by Alex Christensen.
2892
2893         These changes mostly shift from hard-coded paths using UNIX-style
2894         separators to Python's "os.path.join" syntax that uses the correct
2895         path separator for each platform.
2896
2897         * Scripts/webkitpy/common/system/path.py:
2898         (cygpath): Don't pass paths through Cygpath on native Windows.
2899         * Scripts/webkitpy/port/win.py:
2900         (WinPort._path_to_apache): Use os.path.join.
2901         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2902         in 64-bit environments).
2903         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2904         * Scripts/webkitpy/style/checker_unittest.py:
2905         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2906         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2907         (GlobalVariablesTest): Ditto.
2908         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2909         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2910         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2911         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2912         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2913         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2914         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2915         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2916         (StyleProcessor_CodeCoverageTest): Ditto.
2917         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2918         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2919         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2920         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2921         manual string concatenation of paths.
2922
2923 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2924
2925         Add bugzilla addresses of committers to contributors.json
2926         https://bugs.webkit.org/show_bug.cgi?id=149520
2927
2928         Reviewed by Darin Adler.
2929
2930         * Scripts/webkitpy/common/config/contributors.json:
2931
2932 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2933
2934         validate-committer-lists -b shouldn't need edituser privileges
2935         https://bugs.webkit.org/show_bug.cgi?id=149519
2936
2937         Reviewed by Darin Adler.
2938
2939         * Scripts/validate-committer-lists:
2940         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2941         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2942         (BugzillaQueries.is_invalid_bugzilla_email):
2943         (BugzillaQueries): Deleted.
2944         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2945
2946 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2947
2948         Unreviewed. Gardening: skip media stream tests failing after r190262.
2949
2950         * Scripts/run-gtk-tests:
2951         (TestRunner):
2952
2953 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2954
2955         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2956         https://bugs.webkit.org/show_bug.cgi?id=149571
2957
2958         Reviewed by Dan Bernstein.
2959
2960         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
2961
2962         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2963         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2964         * LayoutTestRelay/Configurations/Base.xcconfig:
2965         * MiniBrowser/Configurations/Base.xcconfig:
2966         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2967         * TestWebKitAPI/Configurations/Base.xcconfig:
2968         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2969         * WebEditingTester/Configurations/Base.xcconfig:
2970         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2971         * WebKitTestRunner/Configurations/Base.xcconfig:
2972         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2973         * WebKitTestRunner/iOS.xcconfig: Removed.
2974
2975 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2976
2977         Clean up user media request internal API
2978         https://bugs.webkit.org/show_bug.cgi?id=149527
2979
2980         Reviewed by Tim Horton.
2981
2982         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2983         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2984
2985         * WebKitTestRunner/TestController.cpp:
2986         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2987
2988 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2989
2990         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2991         https://bugs.webkit.org/show_bug.cgi?id=149577
2992
2993         Reviewed by Tim Horton.
2994
2995         When calling testRunner.runUIScript() from a page load event, the script could run
2996         in the UI process before the current remote layer tree transaction had been handled
2997         there. This meant that runUIScript() could query state which was about to change.
2998
2999         Fix by delaying the execution of the UI script until a layer tree transaction has
3000         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
3001
3002         * WebKitTestRunner/TestInvocation.cpp:
3003         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3004         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
3005         * WebKitTestRunner/TestInvocation.h:
3006
3007 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
3008
3009         [Mac] Media tests start to time out after a few days of bot uptime
3010         https://bugs.webkit.org/show_bug.cgi?id=149468
3011
3012         Reviewed by Darin Adler.
3013
3014         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
3015         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
3016         all temporary and cache files go to a custom location.
3017
3018         * Scripts/webkitpy/port/base.py:
3019         * Scripts/webkitpy/port/driver.py:
3020         * Scripts/webkitpy/port/mac.py:
3021         * Scripts/webkitpy/port/win.py:
3022         (WinPort._driver_tempdir_for_environment): Deleted unused function.
3023
3024 2015-09-25  Dan Bernstein  <mitz@apple.com>
3025
3026         Removed MiniBrowser.entitlements.
3027
3028         Rubber-stamped by Anders Carlsson.
3029
3030         The entitlements weren’t used anyway.
3031
3032         * MiniBrowser/MiniBrowser.entitlements: Removed.
3033         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3034
3035 2015-09-24  Daniel Bates  <dabates@apple.com>
3036
3037         Add WebKitSystemInterface for iOS 9.0
3038         https://bugs.webkit.org/show_bug.cgi?id=149550
3039
3040         Rubber-stamped by Alexey Proskuryakov.
3041
3042         * Scripts/copy-webkitlibraries-to-product-directory:
3043
3044 2015-09-24  Daniel Bates  <dabates@apple.com>
3045
3046         Support building for arbitrary architectures
3047         https://bugs.webkit.org/show_bug.cgi?id=149539
3048
3049         Reviewed by Alexey Proskuryakov.
3050
3051         Teach buildbot to pass the architectures associated with the builder to build-webkit
3052         when building on OS X and iOS. As a side effect of this change we now support building
3053         universal binaries when multiples architectures are specified.
3054
3055         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3056         (CompileWebKit.start):
3057
3058 2015-09-24  Daniel Bates  <dabates@apple.com>
3059
3060         Fix the build after <http://trac.webkit.org/changeset/190212>
3061         (http://trac.webkit.org/changeset/190212)
3062
3063         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
3064
3065         * BuildSlaveSupport/built-product-archive:
3066         (main):
3067
3068 2015-09-24  Daniel Bates  <dabates@apple.com>
3069
3070         Support running unit tests on iOS Simulator test bot
3071         https://bugs.webkit.org/show_bug.cgi?id=149536
3072
3073         Reviewed by Alexey Proskuryakov.
3074
3075         Implements support for running unit tests on a iOS test bot. At the time of writing,
3076         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
3077
3078         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3079         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
3080         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
3081
3082 2015-09-24  Daniel Bates  <dabates@apple.com>
3083
3084         Add support infrastructure for OpenSource iOS builders and testers
3085         https://bugs.webkit.org/show_bug.cgi?id=149534
3086
3087         Reviewed by Darin Adler.
3088
3089         Towards setting up OpenSource iOS build bots, teach buildbot and its support
3090         scripts about iOS.
3091
3092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3093         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
3094         --ios-simulator or --device for a builder/tester whose full platform name begins with
3095         "ios-simulator" or "ios", respectively.
3096         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
3097         * BuildSlaveSupport/built-product-archive:
3098         (main): Pass the full platform name to determineWebKitBuildDirectory().
3099         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
3100         command line flag when building for iOS.
3101         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
3102         parameter fullPlatform. This parameter was originally added in r125066 to support the
3103         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
3104         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
3105         * BuildSlaveSupport/clean-build:
3106         (main): Call script webkit-build-directory with the appropriate command line flag when
3107         building for iOS.
3108         * BuildSlaveSupport/delete-stale-build-files:
3109         (main): Use the same logic for iOS as we do for Mac.
3110         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
3111         flag when building for iOS.
3112         * BuildSlaveSupport/test-result-archive:
3113         (archiveTestResults): Use the same logic for iOS as we do for Mac.
3114
3115 2015-09-24  Daniel Bates  <dabates@apple.com>
3116
3117         Remove Chromium-specific changes to script built-product-archive
3118         https://bugs.webkit.org/show_bug.cgi?id=149530
3119
3120         Rubber-stamped by Csaba Osztrogonác.
3121
3122         Reverts changes made in r113074 and r113067 to support Chromium testers. The
3123         Chromium code has long since been removed from the OpenSource WebKit Project.
3124
3125         * BuildSlaveSupport/built-product-archive:
3126         (createZipManually):
3127         (createZip):
3128         (archiveBuiltProduct):
3129
3130 2015-09-24  Dan Bernstein  <mitz@apple.com>
3131
3132         Build fix.
3133
3134         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3135
3136 2015-09-24  Mark Lam  <mark.lam@apple.com>
3137
3138         Unreviewed. Make Lucas Forschler a WebKit reviewer.
3139
3140         * Scripts/webkitpy/common/config/contributors.json:
3141
3142 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3143
3144         Unreviewed. Fix GObject DOM API breaks after r190120.
3145
3146         Bring back code removed in r169931 to handle documentation of
3147         deleted classes.
3148
3149         * gtk/webkitdom.py:
3150         (WebKitDOMDocGenerator):
3151         (WebKitDOMDocGenerator.write_deleted_classes):
3152         (WebKitDOMDocGenerator.generate):
3153         (write_deleted_classes):
3154         (WebKitDOMDocGeneratorSections._deleted_class):
3155         (WebKitDOMDocGeneratorSections._deleted_class.in):
3156         (WebKitDOMDocGeneratorSections.write_deleted_classes):
3157         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
3158
3159 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
3160
3161         [Cocoa] [Font Features] Implement font-variant-*
3162         https://bugs.webkit.org/show_bug.cgi?id=148413
3163
3164         Reviewed by Darin Adler.
3165
3166         Update test font to use "lnum" feature.
3167
3168         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3169         (Generator::appendGSUBTable):
3170
3171 2015-09-22  Andy Estes  <aestes@apple.com>
3172
3173         ContentFiltering.AllowDownloadAfterAddData is very flaky
3174         https://bugs.webkit.org/show_bug.cgi?id=148885
3175         <rdar://problem/22729563>
3176
3177         Reviewed by Alexey Proskuryakov.
3178
3179         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3180         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3181         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3182
3183         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3184         (downloadTest):
3185
3186 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
3187
3188         Mavericks: Media tests start to time out after a few days of bot uptime
3189         https://bugs.webkit.org/show_bug.cgi?id=149468
3190
3191         Reviewed by Chris Dumez.
3192
3193         * Scripts/webkitpy/port/base.py:
3194         * Scripts/webkitpy/port/driver.py:
3195         * Scripts/webkitpy/port/mac.py:
3196
3197 2015-09-22  Nan Wang  <n_wang@apple.com>
3198
3199         Unreviewed, add myself to the committers list.
3200
3201         * Scripts/webkitpy/common/config/contributors.json:
3202
3203 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3204
3205         Remove 'nullable' to fix older iOS builds.
3206
3207         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3208         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3209
3210 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3211
3212         [Win] Show tiled drawing debug overlay on Windows
3213         https://bugs.webkit.org/show_bug.cgi?id=149426
3214
3215         Reviewed by Dean Jackson.
3216
3217         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3218         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3219         * MiniBrowser/win/Common.cpp:
3220         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3221         flag if needed.
3222         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3223
3224 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3225
3226         [Win] Use command-line argument to launch in regular or High DPI mode.
3227         https://bugs.webkit.org/show_bug.cgi?id=149417
3228
3229         Reviewed by Dean Jackson.
3230
3231         * MiniBrowser/win/Common.cpp:
3232         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3233         very start of execution, before the MiniBrowser.dll is loaded.
3234         * win/DLLLauncher/DLLLauncherMain.cpp:
3235         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3236         present. On WinCairo, always use High DPI.
3237
3238 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3239
3240         32-bit Mac build fix attempt after r190065.
3241
3242         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3243
3244 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
3245
3246         [OS X] Update for Xcode 7.0 on Yosemite
3247         https://bugs.webkit.org/show_bug.cgi?id=149389
3248
3249         Reviewed by Dan Bernstein.
3250
3251         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3252         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3253         Removed unneeded declarations - conforming to a protocol is sufficient.
3254
3255         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3256         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3257         Changed the definitions to be compiled whenever the SDK requires it (so we will have
3258         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3259
3260 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3261
3262         Add the ability for tests to run script in the UI process in WebKitTestRunner
3263         https://bugs.webkit.org/show_bug.cgi?id=149356
3264
3265         Reviewed by Tim Horton.
3266
3267         This change adds testRunner.runUIScript(script, callback), which allows a test
3268         to execute script in a JSContext which runs in the UI process. That context
3269         has bindings exposed through the UIScriptController interface; currently one test
3270         function, and some iOS-specific functions are included. UIScriptController can be
3271         async with a callback, and runUIScript() itself is asynchronous. When the UI
3272         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3273         is a string passed back to the web process, and given to the runUIScript()
3274         callback function.
3275
3276         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3277
3278         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3279         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3280         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3281         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3282         complete, call back into TestRunner.
3283         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3284         (WTR::nextUIScriptCallbackID):
3285         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3286         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3287         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3288         * WebKitTestRunner/PlatformWebView.h:
3289         * WebKitTestRunner/TestController.cpp:
3290         (WTR::updateTestOptionsFromTestHeader):
3291         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3292         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3293         * WebKitTestRunner/TestInvocation.cpp:
3294         (WTR::TestInvocation::shouldUseFixedLayout):
3295         (WTR::TestInvocation::shouldUseThreadedScrolling):
3296         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3297         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3298         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3299         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3300         * WebKitTestRunner/TestInvocation.h:
3301         * WebKitTestRunner/TestOptions.h:
3302         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3303         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3304         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3305         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3306         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3307         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3308         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3309         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3310         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3311         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3312         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3313         (WTR::UIScriptController::doAsyncTask):
3314         (WTR::UIScriptController::zoomToScale):
3315         (WTR::UIScriptController::zoomScale):
3316         (WTR::UIScriptController::minimumZoomScale):
3317         (WTR::UIScriptController::maximumZoomScale):
3318         (WTR::UIScriptController::contentVisibleRect):
3319         * WebKitTestRunner/mac/EventSenderProxy.mm:
3320         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3321         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3322         * WebKitTestRunner/mac/TestControllerMac.mm:
3323         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3324         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3325         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3326         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3327         (UIScriptContext::UIScriptContext):
3328         (UIScriptContext::~UIScriptContext):
3329         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3330         asynchronous, call the callback.
3331         (UIScriptContext::nextTaskCallbackID):
3332         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3333         that has a callback). Has to store the callbackID of the script, so code called from the completion
3334         callback knows which UI script invoked it.
3335         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3336         (UIScriptContext::uiScriptComplete):
3337         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3338         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3339         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3340         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3341         (WTR::UIScriptController::UIScriptController):
3342         (WTR::UIScriptController::makeWindowObject):
3343         (WTR::UIScriptController::wrapperClass):
3344         (WTR::UIScriptController::doAsyncTask):
3345         (WTR::UIScriptController::zoomToScale):
3346         (WTR::UIScriptController::zoomScale):
3347         (WTR::UIScriptController::minimumZoomScale):
3348         (WTR::UIScriptController::maximumZoomScale):
3349         (WTR::UIScriptController::contentVisibleRect):
3350         (WTR::UIScriptController::uiScriptComplete):
3351         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3352         (WTR::UIScriptController::create):
3353         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3354
3355 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3356
3357         Turn on threaded scrolling by default in the tests
3358         https://bugs.webkit.org/show_bug.cgi?id=149377
3359
3360         Reviewed by Simon Fraser.
3361
3362         * WebKitTestRunner/mac/TestControllerMac.mm:
3363         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3364         (WTR::shouldUseThreadedScrolling): Deleted.
3365         Turn on threaded scrolling by default.
3366
3367 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3368
3369         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3370         https://bugs.webkit.org/show_bug.cgi?id=149252
3371
3372         Reviewed by Darin Adler.
3373
3374         In case of glib tests the test runner notifies about tests
3375         crashing, but for google tests we don't get any feedback, which
3376         means that in case of a test crashing we get a list of **PASS**
3377         messages and at the summary we are notified that the test suite
3378         has failed, but it's impossible to know which test cases have failed.
3379
3380         * Scripts/run-gtk-tests:
3381         (TestRunner._run_google_test): Add a **CRASH** message if test
3382         case crashed.
3383
3384 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3385
3386         WebKitTestRunner can leak user content script results between tests
3387         https://bugs.webkit.org/show_bug.cgi?id=149391
3388
3389         Reviewed by Sam Weinig.
3390
3391         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3392         about:blank, and thus about:blank doesn't have unintended side effects.
3393
3394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3395         (WTR::InjectedBundle::beginTesting):
3396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3397         (WTR::InjectedBundlePage::resetAfterTest):
3398
3399 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3400
3401         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3402         https://bugs.webkit.org/show_bug.cgi?id=149384
3403
3404         Reviewed by Chris Fleizach.
3405
3406         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3407         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3408         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3409         regardless of whether someone else holds a reference (we also call -stopListening in
3410         -dealloc).
3411
3412         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3413         (AccessibilityController::platformResetToConsistentState):
3414         (AccessibilityController::addNotificationListener):
3415         Ditto.
3416
3417 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3418
3419         Remove XHR_TIMEOUT compilation guard
3420         https://bugs.webkit.org/show_bug.cgi?id=149260
3421
3422         Reviewed by Benjamin Poulain.
3423
3424         * Scripts/webkitperl/FeatureList.pm:
3425
3426 2015-09-19  Dan Bernstein  <mitz@apple.com>
3427
3428         Attempted build fix.
3429
3430         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3431
3432 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3433
3434         Unreviewed, rolling out r189908.
3435         https://bugs.webkit.org/show_bug.cgi?id=149368
3436
3437         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3438
3439         Reverted changeset:
3440
3441         "printing does not use minimum page zoom factor"
3442         https://bugs.webkit.org/show_bug.cgi?id=108507
3443         http://trac.webkit.org/changeset/189908
3444
3445 2015-09-18  Andy Estes  <aestes@apple.com>
3446
3447         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3448         https://bugs.webkit.org/show_bug.cgi?id=149360
3449
3450         Reviewed by Tim Horton.
3451
3452         Added an API test.
3453
3454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3455         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3456         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3457         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3458         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3459         (TEST):
3460         * TestWebKitAPI/ios/pages.pages: Added.
3461
3462 2015-09-18  Nan Wang  <n_wang@apple.com>
3463
3464         AX: Implement ARIA 1.1 @aria-current on iOS
3465         https://bugs.webkit.org/show_bug.cgi?id=149297
3466
3467         Reviewed by Chris Fleizach.
3468
3469         Added support to test aria-current on iOS.
3470
3471         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3472         (AccessibilityUIElement::stringAttributeValue):
3473         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3474         (WTR::AccessibilityUIElement::stringAttributeValue):
3475
3476 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3477
3478         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3479         https://bugs.webkit.org/show_bug.cgi?id=149352
3480
3481         Reviewed by Simon Fraser.
3482
3483         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3484         m_context can be null. This may indicate a bug in webkitpy too, but
3485         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3486         wrong with opening and immediately closing it.
3487
3488 2015-09-18  Daniel Bates  <dabates@apple.com>
3489
3490         isGitSVNDirectory() returns true when Git is not installed
3491         https://bugs.webkit.org/show_bug.cgi?id=149351
3492
3493         Reviewed by Alexey Proskuryakov.
3494
3495         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3496         Git is not installed on the machine.
3497
3498         * Scripts/VCSUtils.pm:
3499         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3500         status code 0 (success).
3501
3502 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3503
3504         Prevent build-webkit from building four times on Windows
3505         https://bugs.webkit.org/show_bug.cgi?id=149336
3506
3507         Reviewed by Brent Fulgham.
3508
3509         * Scripts/build-webkit:
3510         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3511         They're built all at once.
3512         * Scripts/webkitdirs.pm:
3513         (buildVisualStudioProject):
3514         (cmakeGeneratedBuildfile):
3515         Don't generate the Visual Studio solution if it already exists.
3516         It will run CMake again if necessary.
3517
3518 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3519
3520         [iOS WK2] WTR fails to set the key window in the UIKit sense
3521         https://bugs.webkit.org/show_bug.cgi?id=149325
3522
3523         Reviewed by Tim Horton.
3524
3525         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3526         This causes UIKit to bypass code that actually sets the key window, resulting in
3527         [UIAppliation sharedApplication].keyWindow always being nil.
3528
3529         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3530         -[WebKitTestRunnerWindow isKeyWindow] call super.
3531
3532         * WebKitTestRunner/PlatformWebView.h:
3533         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3534         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3535         (WTR::PlatformWebView::setWindowIsKey):
3536         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3537         (WTR::PlatformWebView::setWindowIsKey):
3538         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3539         (-[WebKitTestRunnerWindow isKeyWindow]):
3540         (WTR::PlatformWebView::PlatformWebView):
3541         (WTR::PlatformWebView::~PlatformWebView):
3542         (WTR::PlatformWebView::setWindowIsKey):
3543         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3544         (WTR::PlatformWebView::setWindowIsKey):
3545
3546 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3547
3548         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3549         https://bugs.webkit.org/show_bug.cgi?id=149321
3550
3551         Reviewed by Tim Horton.
3552
3553         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
3554         enabled the "testing" viewport configuration, which disables page scaling.
3555
3556         If we're running viewport tests, we want the normal web page configuration.
3557         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3558         based on whether the test is in a "viewport" directory.
3559
3560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3561         (WTR::InjectedBundle::beginTesting):
3562         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3563         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3564         * WebKitTestRunner/TestInvocation.cpp:
3565         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3566         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3567         (WTR::TestInvocation::shouldMakeViewportFlexible):
3568         (WTR::TestInvocation::invoke):
3569         * WebKitTestRunner/TestInvocation.h:
3570         * WebKitTestRunner/ios/TestControllerIOS.mm:
3571         (WTR::TestController::platformConfigureViewForTest):
3572         (WTR::shouldMakeViewportFlexible): Deleted.
3573
3574 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3575
3576         Give iOS WebKitTestRunner a launch storyboard
3577         https://bugs.webkit.org/show_bug.cgi?id=149314
3578
3579         Reviewed by Dan Bates.
3580
3581         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3582         that it's been built for specific device configurations, and puts the window
3583         at the top of the screen. This simplifies coordinate conversions in a future patch.
3584
3585         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3586         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3587         * WebKitTestRunner/ios/Launch.storyboard: Added.
3588
3589 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3590
3591         Update licence in r189890
3592         https://bugs.webkit.org/show_bug.cgi?id=149306
3593
3594         Reviewed by Dean Jackson.
3595
3596         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3597         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3598         * FontWithFeatures/FontWithFeatures/main.cpp:
3599
3600 2015-09-17  Mark Lam  <mark.lam@apple.com>
3601
3602         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3603         https://bugs.webkit.org/show_bug.cgi?id=149285
3604
3605         Reviewed by Saam Barati.
3606
3607         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3608
3609         * Scripts/run-javascriptcore-tests:
3610         (runJSCStressTests):
3611
3612 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3613
3614         Switch AppleWin build to use CMake
3615         https://bugs.webkit.org/show_bug.cgi?id=149163
3616
3617         Reviewed by Brent Fulgham.
3618
3619         * Scripts/build-webkit:
3620         * Scripts/run-api-tests:
3621         (runTest):
3622         (listAllTests):
3623         (prepareEnvironmentForRunningTestTool):
3624         (testToolPaths):
3625         (testToolPath): Deleted.
3626         Run the API tests as separate executables on Windows.
3627         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3628    &nbs