Re-enable generate-xcfilelists
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-17  Keith Rollin  <krollin@apple.com>
2
3         Re-enable generate-xcfilelists
4         https://bugs.webkit.org/show_bug.cgi?id=197933
5         <rdar://problem/50831677>
6
7         Reviewed by Jonathan Bedard.
8
9         The following two tasks have been completed, and we can re-enable
10         generate-xcfilelists:
11
12         Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
13         Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
14
15         * DumpRenderTree/Scripts/check-xcfilelists.sh:
16         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
17
18 2019-05-17  Commit Queue  <commit-queue@webkit.org>
19
20         Unreviewed, rolling out r245401.
21         https://bugs.webkit.org/show_bug.cgi?id=197990
22
23         Causing internal build failures (Requested by ShawnRoberts on
24         #webkit).
25
26         Reverted changeset:
27
28         "Add SPI to set a list of hosts to which to send custom header
29         fields cross-origin"
30         https://bugs.webkit.org/show_bug.cgi?id=197397
31         https://trac.webkit.org/changeset/245401
32
33 2019-05-17  Commit Queue  <commit-queue@webkit.org>
34
35         Unreviewed, rolling out r245418.
36         https://bugs.webkit.org/show_bug.cgi?id=197989
37
38         New API test causing crashes on Mojave testers (Requested by
39         ShawnRoberts on #webkit).
40
41         Reverted changeset:
42
43         "Add a unit test for client certificate authentication"
44         https://bugs.webkit.org/show_bug.cgi?id=197800
45         https://trac.webkit.org/changeset/245418
46
47 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
48
49         [ews-build] Add build step to Transfer archive to S3
50         https://bugs.webkit.org/show_bug.cgi?id=197922
51
52         Reviewed by Jonathan Bedard.
53
54         * BuildSlaveSupport/ews-build/steps.py:
55         (TransferToS3):
56         (TransferToS3.finished): Invoke triggers after transfer is successful.
57         (TransferToS3.getResultSummary): Create more readable failure string.
58         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
59         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
60
61 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
62
63         [GTK] Need WebKitContextMenuItemType to open emoji picker
64         https://bugs.webkit.org/show_bug.cgi?id=176760
65
66         Reviewed by Michael Catanzaro.
67
68         Update context menu test to check insert emoji action is included in default context menu for editable content.
69
70         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
71
72 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
73
74         [ews-build] Download archives from S3
75         https://bugs.webkit.org/show_bug.cgi?id=197949
76
77         Reviewed by Jonathan Bedard.
78
79         * BuildSlaveSupport/ews-build/steps.py:
80         (DownloadBuiltProduct): Updated to use S3 URL.
81         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
82         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
83
84 2019-05-16  David Kilzer  <ddkilzer@apple.com>
85
86         REGRESSION (r15133): Fix leak of JSStringRef in minidom
87         <https://webkit.org/b/197968>
88         <rdar://problem/50872430>
89
90         Reviewed by Joseph Pecoraro.
91
92         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
93         (expectScriptValueIsString): Drive-by fix to use adopt() instead
94         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
95
96 2019-05-16  David Kilzer  <ddkilzer@apple.com>
97
98         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
99         <https://webkit.org/b/197965>
100
101         Reviewed by Joseph Pecoraro.
102
103         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
104         (WTR::TestRunner::pathToLocalResource): Don't call
105         JSStringRetain() here because the JSRetainPtr<JSStringRef>
106         return type will increment the retain count for us.
107
108 2019-05-16  Alex Christensen  <achristensen@webkit.org>
109
110         Add a unit test for client certificate authentication
111         https://bugs.webkit.org/show_bug.cgi?id=197800
112
113         Reviewed by Youenn Fablet.
114
115         Make better abstractions for reading and writing from/to TCPServer.
116         Add a unit test that causes a client certificate authentication challenge to happen.
117
118         * TestWebKitAPI/TCPServer.cpp:
119         (TestWebKitAPI::TCPServer::TCPServer):
120         (TestWebKitAPI::TCPServer::read):
121         (TestWebKitAPI::TCPServer::write):
122         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
123         (TestWebKitAPI::TCPServer::respondWithOK):
124         * TestWebKitAPI/TCPServer.h:
125         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
126         (credentialWithIdentity):
127         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
128         (TEST):
129         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
130         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
131         (-[ClientCertificateDelegate challengeCount]):
132         (TestWebKitAPI::TEST):
133         (respondWithChallengeThenOK): Deleted.
134         (credentialWithIdentityAndKeychainPath): Deleted.
135         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
136         (TEST):
137         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
138         (TestWebKitAPI::TEST):
139         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
140         (TEST):
141         (readRequest): Deleted.
142         (writeResponse): Deleted.
143         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
144         (TestWebKitAPI::TEST):
145         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
146
147 2019-05-16  Alex Christensen  <achristensen@webkit.org>
148
149         Add SPI to set a list of hosts to which to send custom header fields cross-origin
150         https://bugs.webkit.org/show_bug.cgi?id=197397
151
152         Reviewed by Geoff Garen.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
155         (TEST):
156         (expectLegacyHeaders):
157         (expectHeaders):
158         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
159         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
160         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
161
162 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
163
164         Replace double-quotes with single quotes in steps.py
165         https://bugs.webkit.org/show_bug.cgi?id=197921
166
167         Reviewed by Jonathan Bedard.
168
169         * BuildSlaveSupport/ews-build/steps.py:
170
171 2019-05-15  Keith Rollin  <krollin@apple.com>
172
173         Rewrite generate-xcfilelists in Python
174         https://bugs.webkit.org/show_bug.cgi?id=197622
175         <rdar://problem/50508222>
176
177         Reviewed by Jonathan Bedard, Alex Christensen.
178
179         For a number of reasons, rewrite generate-xcfilelists in Python:
180
181         - The previous bash script was large and unmaintainable.
182         - We have more internal expertise with Python than with bash.
183         - The bash script used temporary files in /tmp that got stranded and
184           were owned by root, making them awkward to clear out.
185           <rdar://problem/49490262>
186         - We needed to complete support for engineers that built with Xcode
187           rather than the command line.
188         - There are some bugs leading to mildly corrupted .xcfilelist files.
189           It's not apparent the source of the bugs, but one general reason
190           might be due to approaches born of using bash. Rewriting in Python
191           may clear these up.
192
193         * Scripts/generate-xcfilelists:
194         * Scripts/webkitpy/common/attribute_saver.py: Added.
195         (AttributeSaver):
196         (AttributeSaver.__init__):
197         (AttributeSaver.__enter__):
198         (AttributeSaver.__exit__):
199         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
200         (AttributeSaverTest):
201         (AttributeSaverTest.SimpleTestClass):
202         (AttributeSaverTest.SimpleTestClass.__init__):
203         (AttributeSaverTest.test_class):
204         (AttributeSaverTest.test_normal_default):
205         (AttributeSaverTest.test_normal_value):
206         (AttributeSaverTest.test_normal_value_on_exception):
207         (AttributeSaverTest.test_normal_value_on_normal_exit):
208         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
209         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
210         (AttributeSaverTest.test_normal_value_with_else_on_exception):
211         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
212         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
213         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
214         (Application):
215         (Application.__init__):
216         (Application.run):
217         (Application._initialize):
218         (Application._initialize.collect_attributes):
219         (Application._create_parser):
220         (_validate_args):
221         (_cmd_generate):
222         (_cmd_check):
223         (_cmd_subgenerate):
224         (_cmd_help):
225         (_do_generate):
226         (_do_merge):
227         (_report_results):
228         (_report_merge_results):
229         (_report_remediation_steps):
230         (_report_remediation_steps.add_to_message):
231         (_any_have_errors):
232         (_any_have_actions):
233         (_log_progress):
234         (_log_results):
235         (get_generate_xcfilelists_script_path):
236         (_get_root_dir):
237         (get_opensource_dir):
238         (get_build_scripts_dir):
239         (get_extract_dependencies_from_makefile_script):
240         (get_xcode_built_products_dir):
241         (_getenv):
242         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
243         (BaseGenerator):
244         (BaseGenerator.__init__):
245         (BaseGenerator.__str__):
246         (BaseGenerator.generate):
247         (BaseGenerator._sublaunch_under_xcode):
248         (BaseGenerator.subgenerate):
249         (BaseGenerator.merge):
250         (BaseGenerator.pickle_to_file):
251         (BaseGenerator.has_action):
252         (BaseGenerator.has_error):
253         (BaseGenerator.is_valid):
254         (BaseGenerator.report_error):
255         (BaseGenerator._generate_derived):
256         (BaseGenerator._merge_derived):
257         (BaseGenerator._generate_unified):
258         (BaseGenerator._merge_unified):
259         (BaseGenerator._replace):
260         (BaseGenerator._unexpand):
261         (BaseGenerator._find_added_lines):
262         (BaseGenerator._merge_added_lines):
263         (BaseGenerator._get_file_lines):
264         (BaseGenerator._getenv):
265         (BaseGenerator._get_project_file_path):
266         (BaseGenerator._get_project_dir):
267         (BaseGenerator._get_project_file_name):
268         (BaseGenerator._get_project_name):
269         (BaseGenerator._get_sym_root):
270         (BaseGenerator._get_obj_root):
271         (BaseGenerator._get_shared_precomps_dir):
272         (BaseGenerator._get_build_dirs):
273         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
274         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
275         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
276         (BaseGenerator._get_derived_sources_dir):
277         (BaseGenerator._get_xcfilelist_dir):
278         (BaseGenerator._get_input_derived_xcfilelist_project_path):
279         (BaseGenerator._get_output_derived_xcfilelist_project_path):
280         (BaseGenerator._get_input_unified_xcfilelist_project_path):
281         (BaseGenerator._get_output_unified_xcfilelist_project_path):
282         (BaseGenerator._get_generate_derived_sources_script):
283         (BaseGenerator._get_generate_unified_sources_script):
284         (JavaScriptCoreGenerator):
285         (JavaScriptCoreGenerator._get_project_file_path):
286         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
287         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
288         (WebCoreGenerator):
289         (WebCoreGenerator._get_project_file_path):
290         (WebCoreGenerator._get_generate_derived_sources_script):
291         (WebCoreGenerator._get_generate_unified_sources_script):
292         (WebKitGenerator):
293         (WebKitGenerator._get_project_file_path):
294         (WebKitGenerator._get_derived_sources_dir):
295         (WebKitGenerator._get_generate_derived_sources_script):
296         (WebKitGenerator._get_generate_unified_sources_script):
297         (DumpRenderTreeGenerator):
298         (DumpRenderTreeGenerator._get_project_file_path):
299         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
300         (WebKitTestRunnerGenerator):
301         (WebKitTestRunnerGenerator._get_project_file_path):
302         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
303         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
304         (debug_log):
305         (LogEntryHelper):
306         (LogEntryHelper.__init__):
307         (LogEntryHelper.log_entry):
308         (LogEntryHelper.log_result):
309         (LogEntryHelper.log_exception):
310         (LogEntryHelper._print):
311         (LogEntryExit):
312         (LogEntryExit._show_debug_logging):
313         (LogEntryExitClass):
314         (LogEntryExitClass._show_debug_logging):
315         (LogEntryExitGlobal):
316         (LogEntryExitGlobal._show_debug_logging):
317         (subprocess_run):
318         (is_running_under_xcode):
319         (CheckValidItemAction):
320         (CheckValidItemAction.__init__):
321         (CheckValidItemAction.__call__):
322         (CheckValidItemAction.validate_item):
323         (CheckCommandAction):
324         (CheckCommandAction.__call__):
325         (InvalidCommandError):
326         (InvalidArgumentError):
327         (InvalidConfigurationError):
328         (CalledProcessError):
329         (CalledProcessError.__str__):
330         * Scripts/webkitpy/xcode/__init__.py:
331         (xcode_hash_for_path):
332         (xcode_hash_for_path.convert_to_string):
333         * Scripts/webkitpy/xcode/sdk.py: Added.
334         (SDK):
335         (SDK.__init__):
336         (SDK.__repr__):
337         (SDK.as_xcode_specification):
338         (SDK.get_preferred_sdk_for_platform):
339         (SDK._parse_sdk):
340         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
341         (SDKTest):
342
343 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
344
345         [ews-build] Enabling uploading EWS archives to S3
346         https://bugs.webkit.org/show_bug.cgi?id=197914
347
348         Reviewed by Jonathan Bedard.
349
350         * BuildSlaveSupport/Shared: Added.
351         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
352         (archiveExists): Replace tab with space.
353         (main): Added main method.
354         * BuildSlaveSupport/build.webkit.org-config/steps.py:
355         (TransferToS3): Updated path to the script.
356         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
357
358 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
359
360         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
361         https://bugs.webkit.org/show_bug.cgi?id=197916
362         <rdar://problem/50815427>
363
364         Reviewed by Timothy Hatcher.
365
366         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
367         inputmode="numeric".
368
369         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
370         (TestWebKitAPI::TEST):
371
372 2019-05-15  Youenn Fablet  <youenn@apple.com>
373
374         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
375         https://bugs.webkit.org/show_bug.cgi?id=197463
376         <rdar://problem/47403621>
377
378         Reviewed by Alex Christensen.
379
380         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
381         (-[QuotaDelegate init]):
382         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
383         (-[QuotaDelegate quotaDelegateCalled]):
384         (-[QuotaDelegate grantQuota]):
385         (-[StorageSchemes webView:startURLSchemeTask:]):
386         (-[StorageSchemes webView:stopURLSchemeTask:]):
387         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
388         (doTest):
389
390 2019-05-15  Youenn Fablet  <youenn@apple.com>
391
392         Constant crashes under WebPage::isThrottleable() after r245299
393         https://bugs.webkit.org/show_bug.cgi?id=197902
394         <rdar://problem/50793796>
395
396         Reviewed by Alex Christensen.
397
398         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
399
400 2019-05-15  Philippe Normand  <pnormand@igalia.com>
401
402         [GTK][jhbuild] misc cleanups and bumps
403         https://bugs.webkit.org/show_bug.cgi?id=197913
404
405         Reviewed by Xabier Rodriguez-Calvar.
406
407         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
408         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
409
410 2019-05-15  Chris Dumez  <cdumez@apple.com>
411
412         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
413         https://bugs.webkit.org/show_bug.cgi?id=195102
414         <rdar://problem/48456786>
415
416         Reviewed by Alex Christensen.
417
418         Try to wait longer for the number of processes to reach the expected number
419         and before failing.
420
421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
422
423 2019-05-15  Alex Christensen  <achristensen@webkit.org>
424
425         Allow NSFileCoordinator to be called from WebContent process
426         https://bugs.webkit.org/show_bug.cgi?id=197895
427         <rdar://problem/50107679>
428
429         Reviewed by Brent Fulgham.
430
431         Add a unit test that verifies calling the block succeeds.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
434         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
435
436 2019-05-14  Andy Estes  <aestes@apple.com>
437
438         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
439         https://bugs.webkit.org/show_bug.cgi?id=197751
440         <rdar://problem/50631563>
441
442         Reviewed by Alex Christensen.
443
444         Added new API tests.
445
446         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
447         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
448         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
449         (TestWebKitAPI::TEST):
450         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
451         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
452
453 2019-05-14  Youenn Fablet  <youenn@apple.com>
454
455         A service worker process should app nap when all its clients app nap
456         https://bugs.webkit.org/show_bug.cgi?id=185626
457         <rdar://problem/46785908>
458
459         Reviewed by Alex Christensen.
460
461         Allow to enable app nap through test header.
462
463         * WebKitTestRunner/TestController.cpp:
464         (WTR::TestController::resetPreferencesToConsistentValues):
465         (WTR::updateTestOptionsFromTestHeader):
466         * WebKitTestRunner/TestOptions.h:
467         (WTR::TestOptions::hasSameInitializationOptions const):
468
469 2019-05-14  Commit Queue  <commit-queue@webkit.org>
470
471         Unreviewed, rolling out r245281.
472         https://bugs.webkit.org/show_bug.cgi?id=197887
473
474         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
475         (Requested by aakashjain on #webkit).
476
477         Reverted changeset:
478
479         "Add a unit test for client certificate authentication"
480         https://bugs.webkit.org/show_bug.cgi?id=197800
481         https://trac.webkit.org/changeset/245281
482
483 2019-05-14  Youenn Fablet  <youenn@apple.com>
484
485         Add support for webkit-test-runner options to WPT importer
486         https://bugs.webkit.org/show_bug.cgi?id=197826
487
488         Reviewed by Alex Christensen.
489
490         In case of overwriting an existing test, check if the existing test
491         contains a <!-- webkit-test-runner --> comment and insert it back if
492         needed in the new test.
493
494         For exporter, forbid creating a WPT PR if there are changes containing
495         the webkit-test-runner string.
496
497         * Scripts/webkitpy/w3c/test_converter.py:
498         (convert_for_webkit):
499         (_W3CTestConverter.__init__):
500         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
501         (_W3CTestConverter.handle_starttag):
502         (_W3CTestConverter.handle_comment):
503         (_W3CTestConverter.handle_decl):
504         (_W3CTestConverter.handle_pi):
505         * Scripts/webkitpy/w3c/test_exporter.py:
506         (WebPlatformTestExporter.write_git_patch_file):
507         (WebPlatformTestExporter.make_pull_request):
508         * Scripts/webkitpy/w3c/test_importer.py:
509         (TestImporter.webkit_test_runner_options):
510         (TestImporter):
511         (TestImporter.add_webkit_test_runner_options_to_content):
512         (TestImporter.copy_html_file):
513         (TestImporter.write_html_template):
514         (TestImporter.write_html_files_for_templated_js_tests):
515         (TestImporter.import_tests):
516         * Scripts/webkitpy/w3c/test_importer_unittest.py:
517         (test_manual_slow_test):
518         (test_webkit_test_runner_options):
519
520 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
521
522         [ews-app] Status bubble should turn orange when any build step fails
523         https://bugs.webkit.org/show_bug.cgi?id=197812
524
525         Reviewed by Jonathan Bedard.
526
527         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
528         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
529         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
530
531 2019-05-14  Alex Christensen  <achristensen@webkit.org>
532
533         Add a unit test for client certificate authentication
534         https://bugs.webkit.org/show_bug.cgi?id=197800
535
536         Reviewed by Youenn Fablet.
537
538         Make better abstractions for reading and writing from/to TCPServer.
539         Add a unit test that causes a client certificate authentication challenge to happen.
540
541         * TestWebKitAPI/TCPServer.cpp:
542         (TestWebKitAPI::TCPServer::TCPServer):
543         (TestWebKitAPI::TCPServer::read):
544         (TestWebKitAPI::TCPServer::write):
545         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
546         (TestWebKitAPI::TCPServer::respondWithOK):
547         * TestWebKitAPI/TCPServer.h:
548         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
549         (credentialWithIdentity):
550         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
551         (TEST):
552         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
553         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
554         (-[ClientCertificateDelegate challengeCount]):
555         (TestWebKitAPI::TEST):
556         (respondWithChallengeThenOK): Deleted.
557         (credentialWithIdentityAndKeychainPath): Deleted.
558         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
559         (TEST):
560         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
561         (TestWebKitAPI::TEST):
562         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
563         (TEST):
564         (readRequest): Deleted.
565         (writeResponse): Deleted.
566         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
567         (TestWebKitAPI::TEST):
568         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
569
570 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
571
572         [CG] Adding support for HEIF-sequence ('public.heics') images
573         https://bugs.webkit.org/show_bug.cgi?id=197384
574
575         Reviewed by Simon Fraser.
576
577         * DumpRenderTree/TestOptions.cpp:
578         (TestOptions::TestOptions):
579         * DumpRenderTree/TestOptions.h:
580         * DumpRenderTree/mac/DumpRenderTree.mm:
581         (resetWebViewToConsistentStateBeforeTesting):
582         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
583         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
584         the test.
585
586         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
587         (WTR::InjectedBundle::stringForKey):
588         (WTR::InjectedBundle::beginTesting):
589         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::TestController::resetStateToConsistentValues):
592         (WTR::updateTestOptionsFromTestHeader):
593         * WebKitTestRunner/TestInvocation.cpp:
594         (WTR::TestInvocation::createTestSettingsDictionary):
595         * WebKitTestRunner/TestOptions.h:
596         (WTR::TestOptions::hasSameInitializationOptions const):
597         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
598         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
599         the test.
600
601 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
602
603         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
604         https://bugs.webkit.org/show_bug.cgi?id=197730
605
606         Reviewed by Filip Pizlo.
607
608         * TestWebKitAPI/CMakeLists.txt:
609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
610         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
611         (TestWebKitAPI::TEST):
612         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
613         (TestWebKitAPI::TEST):
614
615 2019-05-10  Chris Dumez  <cdumez@apple.com>
616
617         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
618
619         It became flaky after r245198.
620
621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
622
623 2019-05-10  Youenn Fablet  <youenn@apple.com>
624
625         A service worker instance should be terminated when its SWServer is destroyed
626         https://bugs.webkit.org/show_bug.cgi?id=197801
627         <rdar://problem/50587270>
628
629         Reviewed by Chris Dumez.
630
631         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
632
633 2019-05-10  Chris Dumez  <cdumez@apple.com>
634
635         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
636         https://bugs.webkit.org/show_bug.cgi?id=197750
637
638         Reviewed by Geoffrey Garen.
639
640         Add API test coverage.
641
642         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
643         (TEST):
644
645 2019-05-10  Keith Miller  <keith_miller@apple.com>
646
647         Remove legacy test262 import script
648         https://bugs.webkit.org/show_bug.cgi?id=197788
649
650         Reviewed by Yusuke Suzuki.
651
652         import-test262-tests doesn't work anymore. We should be using test262-import instead.
653
654         * Scripts/import-test262-tests: Removed.
655
656 2019-05-10  Charlie Turner  <cturner@igalia.com>
657
658         [WPE] Forward libepoxy cflags
659         https://bugs.webkit.org/show_bug.cgi?id=197784
660
661         Reviewed by Žan Doberšek.
662
663         Patch by Zan Dobersek.
664
665         * wpe/backends/CMakeLists.txt: This is required to keep
666         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
667         up trying to include X11 headers even when they're not present in the
668         environment.
669
670 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
671
672         Fix a bunch of compiler warnings
673         https://bugs.webkit.org/show_bug.cgi?id=197785
674
675         Reviewed by Don Olmstead.
676
677         Add preprocessor guards to avoid -Wunused-function warnings.
678
679         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
680         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
681         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
682
683 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
684
685         [WPE][GTK] Add webkit_frame_get_id() API
686         https://bugs.webkit.org/show_bug.cgi?id=197270
687
688         Reviewed by Carlos Garcia Campos.
689
690         This was hard, but I added a test to verify that two different WebKitFrames of the same
691         WebKitWebPage return two different frame IDs.
692
693         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
694         (WebKitFrameTest::willSubmitFormCallback):
695         (WebKitFrameTest::testSubframe):
696         (registerTests):
697         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
698         (testWebKitFrameSubframe):
699         (beforeAll):
700         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
701         (willSubmitFormCallback):
702         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
703         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
704
705 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
706
707         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
708         https://bugs.webkit.org/show_bug.cgi?id=197271
709
710         Reviewed by Youenn Fablet.
711
712         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
713         (formControlsAssociatedForFrameCallback):
714         (pageCreatedCallback):
715         (formControlsAssociatedCallback): Deleted.
716
717 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
718
719         [Flatpak] Use the safe PyYAML loader if available
720         https://bugs.webkit.org/show_bug.cgi?id=197771
721
722         Reviewed by Philippe Normand.
723
724         * flatpak/flatpakutils.py:
725         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
726         still used as fallback when the former is not provided by the module.
727
728 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
729
730         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
731         https://bugs.webkit.org/show_bug.cgi?id=197734
732
733         Reviewed by Don Olmstead.
734
735         * Scripts/webkitpy/port/win.py:
736         (WinCairoPort._search_paths): Add 'wk2' and
737         additional_platform_directory to paths as well as other ports do.
738
739 2019-05-09  Daniel Bates  <dabates@apple.com>
740
741         [iOS] Numpad comma key has incorrect keyIdentifier property
742         https://bugs.webkit.org/show_bug.cgi?id=197753
743         <rdar://problem/50636274>
744
745         Reviewed by Brent Fulgham.
746
747         Recognize "numpadComma" and return the appropriate HID usage code.
748
749         * WebKitTestRunner/ios/HIDEventGenerator.mm:
750         (hidUsageCodeForCharacter):
751
752 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
753
754         Refine AudioSession route sharing policy
755         https://bugs.webkit.org/show_bug.cgi?id=197742
756         <rdar://problem/50590818>
757
758         Reviewed by Darin Adler.
759
760         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
761         (TestWebKitAPI::TEST):
762
763 2019-05-09  Alex Christensen  <achristensen@webkit.org>
764
765         Remove unnecessary test SPI after r244883
766         https://bugs.webkit.org/show_bug.cgi?id=197575
767
768         Reviewed by Tim Horton.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
771         (TEST):
772         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
773         (TestWebKitAPI::TEST):
774
775 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
776
777         [ews-app] Add migrations file to repository
778         https://bugs.webkit.org/show_bug.cgi?id=197729
779
780         Reviewed by Jonathan Bedard.
781
782         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
783
784 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
785
786         [ews-build] Fix formatting issues and typos
787         https://bugs.webkit.org/show_bug.cgi?id=197737
788
789         Reviewed by Jonathan Bedard.
790
791         * BuildSlaveSupport/ews-build/steps.py:
792         (CompileWebKit.evaluateCommand): Removed extra empty line.
793         * BuildSlaveSupport/ews-build/steps_unittest.py:
794         (TestRunWebKitPerlTests): Fixed typo.
795         * BuildSlaveSupport/ews-app/ews/models/step.py:
796         (Step.save_step): Changed log level to info so that it is logged in production.
797
798 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
799
800         [ews-app] Production and Development env should configure DEBUG appropriately
801         https://bugs.webkit.org/show_bug.cgi?id=197700
802
803         Reviewed by Jonathan Bedard.
804
805         * BuildSlaveSupport/ews-app/ews-app/settings.py:
806
807 2019-05-09  Xan López  <xan@igalia.com>
808
809         [CMake] Detect SSE2 at compile time
810         https://bugs.webkit.org/show_bug.cgi?id=196488
811
812         Reviewed by Carlos Garcia Campos.
813
814         * Scripts/webkitdirs.pm:
815         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
816         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
817
818 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
819
820         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
821         https://bugs.webkit.org/show_bug.cgi?id=197697
822
823         Reviewed by Žan Doberšek.
824
825         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
826         * wpe/jhbuild.modules: Ditto.
827
828 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
829
830         Update ANGLE
831         https://bugs.webkit.org/show_bug.cgi?id=197676
832
833         Reviewed by Alex Christensen.
834
835         * TestWebKitAPI/PlatformWin.cmake:
836         Remove unnecessary library linkage.
837
838 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
839
840         [Win] build-webkit should be ready for Visual Studio 2019
841         https://bugs.webkit.org/show_bug.cgi?id=196622
842
843         Reviewed by Ross Kirsling.
844
845         1. Accommodated to the new msbuild.exe location of VS 2019.
846         2. Removed the hard coded "Visual Studio 15" generator.
847
848         build-webkit is going to choose a Visual Studio generator version
849         matching with the latest installed VS. If you invoke vcvars.bat
850         before build-webkit, it chooses the corresponding Visual Studio
851         generator version by cheking 'VisualStudioVersion' env var which
852         is set by vcvars.bat.
853
854         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
855         (msBuildPath): When looking for MSBuild, look in
856         "MSBuild\Current\bin" (the new expected location) and fallback
857         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
858         first location.
859         (msBuildInstallDir): Renamed to msBuildPath.
860         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
861         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
862
863 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
864
865         [PlayStation] Update port options
866         https://bugs.webkit.org/show_bug.cgi?id=197723
867
868         Reviewed by Ross Kirsling.
869
870         ICU headers were missing from TestWTF.
871
872         * TestWebKitAPI/PlatformPlayStation.cmake:
873
874 2019-05-08  Alex Christensen  <achristensen@webkit.org>
875
876         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
877         https://bugs.webkit.org/show_bug.cgi?id=197712
878         <rdar://problem/50429770>
879
880         Reviewed by Tim Horton.
881
882         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
883         (TestWebKitAPI::TEST):
884
885 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
886
887         Change my status to be a WebKit reviewer.
888
889         * Scripts/webkitpy/common/config/contributors.json:
890
891 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
892
893         Unreviewed, rolling out r244952.
894
895         Caused inspector to appear blank.
896
897         Reverted changeset:
898
899         "Web Inspector: Provide UIString descriptions to improve
900         localizations"
901         https://bugs.webkit.org/show_bug.cgi?id=195132
902         https://trac.webkit.org/changeset/244952
903
904 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
905
906         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
907         https://bugs.webkit.org/show_bug.cgi?id=197685
908
909         Reviewed by Alex Christensen.
910
911         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
912         completion. See LayoutTests/ChangeLog for more details.
913
914         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
915         (WTR::UIScriptController::platformClearAllCallbacks):
916
917 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
918
919         Unreviewed. Add myself as a committer.
920
921         * Scripts/webkitpy/common/config/contributors.json:
922
923 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
924
925         Unreviewed, rolling out r245038.
926
927         Breaks internal builds.
928
929         Reverted changeset:
930
931         "Add SPI to set a list of hosts to which to send custom header
932         fields cross-origin"
933         https://bugs.webkit.org/show_bug.cgi?id=197397
934         https://trac.webkit.org/changeset/245038
935
936 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
937
938         Unreviewed. Add myself as a committer.
939
940         * Scripts/webkitpy/common/config/contributors.json:
941
942 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
943
944         Define media buffering policy
945         https://bugs.webkit.org/show_bug.cgi?id=196979
946         <rdar://problem/28383861>
947
948         Reviewed by Jer Noble.
949
950         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
951         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
952         (waitUntilBufferingPolicyIsEqualTo):
953         (TEST):
954
955 2019-05-07  Alex Christensen  <achristensen@webkit.org>
956
957         Add SPI to set a list of hosts to which to send custom header fields cross-origin
958         https://bugs.webkit.org/show_bug.cgi?id=197397
959
960         Reviewed by Geoff Garen.
961
962         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
963         (TEST):
964         (expectLegacyHeaders):
965         (expectHeaders):
966         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
967         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
968         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
969
970 2019-05-07  Keith Rollin  <krollin@apple.com>
971
972         Add option to build-webkit to control whether or not XCBuild is used
973         https://bugs.webkit.org/show_bug.cgi?id=197668
974         <rdar://problem/50549728>
975
976         Reviewed by Tim Horton.
977
978         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
979         Also update build-webkit and the makefiles with the foundation for
980         automatically using XCBuild when the conditions allow it. This latter
981         facility is currently turned off until Xcode fully supports building
982         WebKit with XCBuild.
983
984         * Scripts/build-webkit:
985         * Scripts/webkitdirs.pm:
986         (XcodeOptions):
987         (canUseXCBuild):
988
989 2019-05-07  Andy Estes  <aestes@apple.com>
990
991         run-bindings-tests should test global scope constructor generation
992         https://bugs.webkit.org/show_bug.cgi?id=197669
993
994         Reviewed by Alex Christensen.
995
996         * Scripts/webkitpy/bindings/main.py:
997         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
998         invoking preprocess-idls.pl.
999
1000 2019-05-07  Youenn Fablet  <youenn@apple.com>
1001
1002         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
1003         https://bugs.webkit.org/show_bug.cgi?id=195997
1004         <rdar://problem/50509884>
1005
1006         Reviewed by Chris Dumez.
1007
1008         Spin test until successful.
1009
1010         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1011
1012 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
1013
1014         [Flatpak] webkit-build fails due to missing GTK2 in build environment
1015         https://bugs.webkit.org/show_bug.cgi?id=197352
1016
1017         Reviewed by Philippe Normand.
1018
1019         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
1020         to build it ourselves on top in order to be able to build the GTK 2.x plugin
1021         process.
1022
1023         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
1024
1025 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1026
1027         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
1028         https://bugs.webkit.org/show_bug.cgi?id=197644
1029         <rdar://problem/50526364>
1030
1031         Reviewed by Tim Horton.
1032
1033         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
1034
1035         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1036         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1037         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1038         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1039
1040 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1041
1042         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
1043         https://bugs.webkit.org/show_bug.cgi?id=197651
1044
1045         Reviewed by Žan Doberšek.
1046
1047         This is required since the process creation was delayed until something is loaded in the view.
1048
1049         * MiniBrowser/gtk/BrowserWindow.c:
1050         (browser_window_get_or_create_web_view_for_automation):
1051         * MiniBrowser/wpe/main.cpp:
1052         (main):
1053
1054 2019-05-06  Tim Horton  <timothy_horton@apple.com>
1055
1056         _overrideViewportWithArguments does not work when called before loading
1057         https://bugs.webkit.org/show_bug.cgi?id=197638
1058         <rdar://problem/50505111>
1059
1060         Reviewed by Wenson Hsieh.
1061
1062         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1063         (TEST):
1064
1065 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
1066
1067         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1068         https://bugs.webkit.org/show_bug.cgi?id=197510
1069
1070         Reviewed by Alex Christensen.
1071
1072         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1073         (TestWebKitAPI::TEST):
1074
1075 2019-05-06  Keith Rollin  <krollin@apple.com>
1076
1077         Temporarily disable generate-xcfilelists
1078         https://bugs.webkit.org/show_bug.cgi?id=197619
1079         <rdar://problem/50507392>
1080
1081         Reviewed by Alex Christensen.
1082
1083         We need to perform a significant update to the generate-xcfilelist
1084         scripts. This work involves coordinated work with another facility. If
1085         the work does not occur in tandem, the build will be broken. To avoid
1086         this, disable the invoking of the scripts during the transition. The
1087         checking will be restored once the new scripts are in place.
1088
1089         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1090         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1091
1092 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1093
1094         Revert r244953 and r244954 because they broke internal builds.
1095         https://bugs.webkit.org/show_bug.cgi?id=197534
1096
1097         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1098         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1099         * DumpRenderTree/mac/DumpRenderTree.mm:
1100         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1101         * DumpRenderTree/mac/TestRunnerMac.mm:
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1103         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1104         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1105         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1106         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1107         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1108         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1109         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1110         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1111         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1112         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1113         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1114         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1115         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1116         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1117         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1118         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1119         * TestWebKitAPI/ios/UIKitSPI.h: Added.
1120         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1121         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1122         * WebKitTestRunner/ios/HIDEventGenerator.h:
1123         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1124         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1125         * WebKitTestRunner/ios/TestControllerIOS.mm:
1126         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1127         * WebKitTestRunner/ios/mainIOS.mm:
1128
1129 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1130
1131         Merge the three UIKitSPI.h files into a single one in PAL
1132         https://bugs.webkit.org/show_bug.cgi?id=197534
1133
1134         Reviewed by Darin Adler.
1135
1136         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1137         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1138         * DumpRenderTree/mac/DumpRenderTree.mm:
1139         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1140         * DumpRenderTree/mac/TestRunnerMac.mm:
1141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1142         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1143         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1144         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1145         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1146         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1147         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1148         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1149         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1150         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1151         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1152         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1153         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1154         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1155         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1156         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1157         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1158         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
1159         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1160         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1161         * WebKitTestRunner/ios/HIDEventGenerator.h:
1162         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1163         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1164         * WebKitTestRunner/ios/TestControllerIOS.mm:
1165         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1166         * WebKitTestRunner/ios/mainIOS.mm:
1167
1168 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
1169
1170         Web Inspector: Provide UIString descriptions to improve localizations
1171         https://bugs.webkit.org/show_bug.cgi?id=195132
1172         <rdar://problem/48457817>
1173
1174         Reviewed by Devin Rousso.
1175
1176         Allow WI.UIString to take:
1177         - WI.UIString(string, key, comment)
1178         - WI.UIString(string, comment)
1179         - WI.UIString(string)
1180
1181         * Scripts/extract-localizable-js-strings:
1182
1183 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1184
1185         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
1186         https://bugs.webkit.org/show_bug.cgi?id=197579
1187
1188         Reviewed by Tim Horton.
1189
1190         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
1191         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
1192         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
1193         ensure that the the focused element has been blurred.
1194
1195         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1196
1197 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
1198
1199         Add a tool to block spammer accounts
1200         https://bugs.webkit.org/show_bug.cgi?id=197537
1201
1202         Reviewed by Darin Adler.
1203
1204         Usage: block-spammers email1 email2 ...
1205
1206         The tool finds and hides all bugs and comments from this account. Before any work
1207         is done, these bugs and comments are displayed for confirmation.
1208
1209         * Scripts/block-spammers: Added.
1210         (get_bugzilla_token):
1211         (invalidate_bugzilla_token):
1212         (get_user_info):
1213         (get_user_info_self):
1214         (can_use_this_tool):
1215         (disable_user):
1216         (get_bugs_created_by_user):
1217         (get_bugs_commented_on_by_user):
1218         (get_comments):
1219         (hide_bug):
1220         (hide_comments):
1221         (ask_yes_no):
1222         (sanitized_string):
1223         (main):
1224
1225 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
1226
1227         run-apit-tests: Add --iterations and --repeat-each
1228         https://bugs.webkit.org/show_bug.cgi?id=197563
1229
1230         Reviewed by Aakash Jain.
1231
1232         * Scripts/webkitpy/api_tests/manager.py:
1233         (Manager.run): Add --iterations and --repeat-each/
1234         * Scripts/webkitpy/api_tests/run_api_tests.py:
1235         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
1236
1237 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1238
1239         New EWS: Clicking on white bubble navigates to page with only bubbles
1240         https://bugs.webkit.org/show_bug.cgi?id=197520
1241
1242         Reviewed by Lucas Forschler.
1243
1244         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
1245
1246 2019-05-03  Daniel Bates  <dabates@apple.com>
1247
1248         [lldb-webkit] Support adding pretty-printing for qualified types
1249         https://bugs.webkit.org/show_bug.cgi?id=197518
1250
1251         Reviewed by Darin Adler.
1252
1253         Remove all "::"s from the name of the specified type when computing the name for the Python classes
1254         that will provide summary and synthetic details as LLDB is not happy about registering such classes
1255         when they contain :: in their name.
1256
1257         * lldb/lldb_webkit.py:
1258         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1259
1260 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1261
1262         New EWS: patches on recently added queues listed as #1 for older bugs
1263         https://bugs.webkit.org/show_bug.cgi?id=197496
1264
1265         Reviewed by Lucas Forschler.
1266
1267         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1268         (StatusBubble._build_bubble):
1269         (StatusBubble._queue_position):
1270
1271 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1272
1273         webkit-patch --no-review upload does not submit patch to New EWS
1274         https://bugs.webkit.org/show_bug.cgi?id=197519
1275         <rdar://problem/50424887>
1276
1277         Reviewed by Lucas Forschler.
1278
1279         * Scripts/webkitpy/tool/steps/submittoews.py:
1280         (SubmitToEWS.run): Submit to both old and new EWS.
1281         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
1282         * Scripts/webkitpy/common/net/ewsserver.py: Added.
1283         (EWSServer._server_url): Method to return server url.
1284         (EWSServer._post_patch_to_ews): Method to post patch to ews.
1285         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
1286         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
1287         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
1288         * Scripts/webkitpy/common/net/statusserver_mock.py:
1289         (MockStatusServer.submit_to_ews): Updated the log text.
1290         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
1291         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
1292         * Scripts/webkitpy/tool/main.py:
1293         (WebKitPatch.__init__): Initialize ews_server. 
1294         * Scripts/webkitpy/tool/mocktool.py:
1295         (MockTool.__init__): Ditto.
1296
1297 2019-05-03  Chris Dumez  <cdumez@apple.com>
1298
1299         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
1300         https://bugs.webkit.org/show_bug.cgi?id=197574
1301         <rdar://problem/50453181>
1302
1303         Reviewed by Tim Horton.
1304
1305         Add API test coverage.
1306
1307         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1308         (TEST):
1309
1310 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
1311
1312         [JSC] Generator CodeBlock generation should be idempotent
1313         https://bugs.webkit.org/show_bug.cgi?id=197552
1314
1315         Reviewed by Keith Miller.
1316
1317         * Scripts/run-javascriptcore-tests:
1318         (runJSCStressTests):
1319         * Scripts/run-jsc-stress-tests:
1320
1321 2019-05-03  Commit Queue  <commit-queue@webkit.org>
1322
1323         Unreviewed, rolling out r244881.
1324         https://bugs.webkit.org/show_bug.cgi?id=197559
1325
1326         Breaks compilation of jsconly on linux, breaking compilation
1327         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
1328         guijemont on #webkit).
1329
1330         Reverted changeset:
1331
1332         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
1333         WEBKIT_COPY_FILES"
1334         https://bugs.webkit.org/show_bug.cgi?id=197174
1335         https://trac.webkit.org/changeset/244881
1336
1337 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
1338
1339         Unreviewed WPE build fix after r244898.
1340
1341         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
1342         (WTR::TestController::abortModal): Add the missing (no-op) definition.
1343
1344 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1345
1346         Mark U+01C0 as a homograph of U+006C
1347         https://bugs.webkit.org/show_bug.cgi?id=197526
1348         <rdar://problem/50301904>
1349
1350         Reviewed by Tim Horton.
1351
1352         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1353         (TestWebKitAPI::TEST):
1354
1355 2019-05-02  Chris Dumez  <cdumez@apple.com>
1356
1357         Add test coverage for <rdar://problem/49731231>
1358         https://bugs.webkit.org/show_bug.cgi?id=196730
1359         <rdar://problem/49731231>
1360
1361         Reviewed by Ryosuke Niwa.
1362
1363         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
1364         to match DumpRenderTree.
1365
1366         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1368         (WTR::TestRunner::abortModal):
1369         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1370         * WebKitTestRunner/TestController.cpp:
1371         (WTR::TestController::runModal):
1372         * WebKitTestRunner/TestController.h:
1373         * WebKitTestRunner/TestInvocation.cpp:
1374         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1375         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1376         (WTR::TestController::abortModal):
1377         * WebKitTestRunner/ios/TestControllerIOS.mm:
1378         (WTR::TestController::abortModal):
1379         * WebKitTestRunner/mac/TestControllerMac.mm:
1380         (WTR::TestController::abortModal):
1381         * WebKitTestRunner/win/TestControllerWin.cpp:
1382         (WTR::TestController::abortModal):
1383
1384 2019-05-02  Christopher Reid  <chris.reid@sony.com>
1385
1386         [CMake] Add support for LTO builds
1387         https://bugs.webkit.org/show_bug.cgi?id=188986
1388
1389         Reviewed by Don Olmstead.
1390
1391         Add support to configure --lto-mode with cmake builds.
1392
1393         * Scripts/build-webkit:
1394         * Scripts/webkitdirs.pm:
1395         (generateBuildSystemFromCMakeProject):
1396
1397 2019-05-02  John Wilander  <wilander@apple.com>
1398
1399         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
1400         https://bugs.webkit.org/show_bug.cgi?id=197521
1401         <rdar://problem/49651503>
1402
1403         Reviewed by Brent Fulgham.
1404
1405         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1406         (TestWebKitAPI::TEST):
1407            Added a test for host strings with leading dots since they are
1408            often used for the domain attribute in cookies.
1409
1410 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
1411
1412         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1413         https://bugs.webkit.org/show_bug.cgi?id=197510
1414
1415         Reviewed by Alex Christensen.
1416
1417         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1418         (TestWebKitAPI::TEST):
1419
1420 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
1421
1422         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1423         https://bugs.webkit.org/show_bug.cgi?id=197174
1424
1425         Reviewed by Alex Christensen.
1426
1427         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1428
1429         * TestWebKitAPI/PlatformGTK.cmake:
1430         * TestWebKitAPI/PlatformWPE.cmake:
1431
1432 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1433
1434         Build fix for internal branch.
1435
1436         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1437         RetainPtr.h was not explicitly included.
1438
1439 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1440
1441         webkitpy: Ignore errors when shutting down an already shutdown simulator
1442         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1443         <rdar://problem/50390247>
1444
1445         Reviewed by Lucas Forschler.
1446
1447         * Scripts/webkitpy/xcode/simulated_device.py:
1448         (SimulatedDevice._shut_down):
1449
1450 2019-05-02  Frederic Wang  <fwang@igalia.com>
1451
1452         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1453         https://bugs.webkit.org/show_bug.cgi?id=196142
1454
1455         This patch introduces some experimental runtime flag to let users
1456         disable MathML features that are removed from MathML Core [1]. For now,
1457         these features are only disabled on GTK and WPE ports.
1458
1459         [1] https://mathml-refresh.github.io/mathml-core/
1460
1461         Reviewed by Rob Buis.
1462
1463         * DumpRenderTree/TestOptions.cpp:
1464         (TestOptions::TestOptions):
1465         * DumpRenderTree/TestOptions.h:
1466         * DumpRenderTree/mac/DumpRenderTree.mm:
1467         (setWebPreferencesForTestOptions):
1468
1469 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1470
1471         TestWebKitAPI config.h should be aware of what suite is being built
1472         https://bugs.webkit.org/show_bug.cgi?id=196583
1473
1474         Reviewed by Konstantin Tokarev.
1475
1476         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1477         benefit the macro defines BUILDING_* for the executable which allows the includes
1478         of the config.h to be tailored to the test suite being built. Because of that the
1479         dependencies of the Test* executable are specific to the test suite which may
1480         speed up the build.
1481
1482         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1483         when "Utilities.h" is what was needed.
1484
1485         * TestWebKitAPI/CMakeLists.txt:
1486         * TestWebKitAPI/PlatformGTK.cmake:
1487         * TestWebKitAPI/PlatformJSCOnly.cmake:
1488         * TestWebKitAPI/PlatformMac.cmake:
1489         * TestWebKitAPI/PlatformPlayStation.cmake:
1490         * TestWebKitAPI/PlatformUtilities.h:
1491         * TestWebKitAPI/PlatformWPE.cmake:
1492         * TestWebKitAPI/PlatformWin.cmake:
1493         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1494         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1495         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1496         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1497         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1498         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1499         * TestWebKitAPI/config.h:
1500
1501 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1502
1503         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1504         https://bugs.webkit.org/show_bug.cgi?id=181950
1505         <rdar://problem/43357371>
1506
1507         Reviewed by Brent Fulgham.
1508
1509         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1510         (TestWebKitAPI::TEST_F):
1511
1512 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1513
1514         Remove webkitpy and bindings EWS queues from dashboard
1515         https://bugs.webkit.org/show_bug.cgi?id=197475
1516
1517         Reviewed by Alexey Proskuryakov.
1518
1519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1520
1521 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1522
1523         Remove webkitpy and bindings test queues from old EWS
1524         https://bugs.webkit.org/show_bug.cgi?id=197468
1525
1526         Reviewed by Alexey Proskuryakov.
1527
1528         * QueueStatusServer/config/queues.py:
1529
1530 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1531
1532         Fix the WebKitTestRunner build
1533         https://bugs.webkit.org/show_bug.cgi?id=197449
1534         <rdar://problem/50334169>
1535
1536         Reviewed by Alexey Proskuryakov.
1537
1538         * WebKitTestRunner/mac/EventSenderProxy.mm:
1539         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1540         (WTR::EventSenderProxy::mouseForceChanged):
1541         Use some SPI instead of IPI.
1542
1543 2019-04-30  Chris Dumez  <cdumez@apple.com>
1544
1545         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1546         https://bugs.webkit.org/show_bug.cgi?id=197426
1547         <rdar://problem/50256169>
1548
1549         Reviewed by Brady Eidson.
1550
1551         Add API test coverage.
1552
1553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1554         (-[PSONScheme setShouldRespondAsynchronously:]):
1555         (-[PSONScheme webView:startURLSchemeTask:]):
1556         (-[PSONScheme webView:stopURLSchemeTask:]):
1557
1558 2019-04-30  Chris Dumez  <cdumez@apple.com>
1559
1560         Unreviewed, rolling out r244802.
1561
1562         Caused an API test failure
1563
1564         Reverted changeset:
1565
1566         "Regression(PSON) URL scheme handlers can no longer respond
1567         asynchronously"
1568         https://bugs.webkit.org/show_bug.cgi?id=197426
1569         https://trac.webkit.org/changeset/244802
1570
1571 2019-04-30  Chris Dumez  <cdumez@apple.com>
1572
1573         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1574         https://bugs.webkit.org/show_bug.cgi?id=197426
1575         <rdar://problem/50256169>
1576
1577         Reviewed by Brady Eidson.
1578
1579         Add API test coverage.
1580
1581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1582         (-[PSONScheme setShouldRespondAsynchronously:]):
1583         (-[PSONScheme webView:startURLSchemeTask:]):
1584         (-[PSONScheme webView:stopURLSchemeTask:]):
1585
1586 2019-04-30  Chris Dumez  <cdumez@apple.com>
1587
1588         Only use a related page's process if that page has not been closed yet
1589         https://bugs.webkit.org/show_bug.cgi?id=197393
1590         <rdar://problem/50302423>
1591
1592         Reviewed by Tim Horton.
1593
1594         Add API test coverage.
1595
1596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1597
1598 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1599
1600         [ews-build] Enable Bindings tests queue on new EWS
1601         https://bugs.webkit.org/show_bug.cgi?id=197424
1602
1603         Reviewed by Lucas Forschler.
1604
1605         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1606         (StatusBubble):
1607         * BuildSlaveSupport/ews-build/config.json:
1608
1609 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1610
1611         [ews-build] Configure ews151 for running various tests
1612         https://bugs.webkit.org/show_bug.cgi?id=197419
1613
1614         Reviewed by Lucas Forschler.
1615
1616         * BuildSlaveSupport/ews-build/config.json:
1617
1618 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1619
1620         [ews-build] Parse and display bindings test failures
1621         https://bugs.webkit.org/show_bug.cgi?id=197423
1622
1623         Reviewed by Lucas Forschler.
1624
1625         * BuildSlaveSupport/ews-build/steps.py:
1626         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1627         (RunBindingsTests.start): Initialize log_observer for json output.
1628         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1629         (RunBindingsTests._addToLog): Method to add message to log.
1630         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1631
1632 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1633
1634         Unreviewed. Add myself as a committer.
1635
1636         * Scripts/webkitpy/common/config/contributors.json:
1637
1638 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1639
1640         [ews-build] Enable webkitpy queue on new EWS
1641         https://bugs.webkit.org/show_bug.cgi?id=197396
1642
1643         Reviewed by Lucas Forschler.
1644
1645         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1646         (StatusBubble):
1647         * BuildSlaveSupport/ews-build/config.json:
1648
1649 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1650
1651         [ews-build] Parse and display webkitpy failures
1652         https://bugs.webkit.org/show_bug.cgi?id=197395
1653
1654         Reviewed by Lucas Forschler.
1655
1656         * BuildSlaveSupport/ews-build/steps.py:
1657         (RunWebKitPyTests.start): Initialize log_observer for json output.
1658         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1659         (RunWebKitPyTests._addToLog): Method to add message to log.
1660         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1661
1662 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1663
1664         <rdar://problem/50299396> Fix internal High Sierra build
1665         https://bugs.webkit.org/show_bug.cgi?id=197388
1666
1667         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1668         * MiniBrowser/Configurations/Base.xcconfig:
1669         * MobileMiniBrowser/Configurations/Base.xcconfig:
1670         * TestWebKitAPI/Configurations/Base.xcconfig:
1671         * WebKitTestRunner/Configurations/Base.xcconfig:
1672
1673 2019-04-29  Youenn Fablet  <youenn@apple.com>
1674
1675         Remove spurious GVA printf logging
1676         https://bugs.webkit.org/show_bug.cgi?id=197368
1677         <rdar://problem/35975256>
1678
1679         Reviewed by Alexey Proskuryakov.
1680
1681         * Scripts/webkitpy/port/mac.py:
1682         (MacPort.logging_patterns_to_strip):
1683
1684 2019-04-29  Youenn Fablet  <youenn@apple.com>
1685
1686         getDisplayMedia should be called on user gesture
1687         https://bugs.webkit.org/show_bug.cgi?id=197356
1688         <rdar://problem/50296074>
1689
1690         Reviewed by Eric Carlson.
1691
1692         Update test configuration to inject internals
1693         so that we can use it to simulate a user click to call getDisplayMedia.
1694
1695         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1696         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1697         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1698
1699 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1700
1701         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1702         https://bugs.webkit.org/show_bug.cgi?id=197339
1703
1704         Reviewed by Dewei Zhu.
1705
1706         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1707         test run for setup steps that are too expensive to do every iteration.
1708
1709         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1710         (BenchmarkRunner._run_benchmark):
1711         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1712         (BrowserDriver):
1713         (BrowserDriver.prepare_initial_env):
1714         (BrowserDriver.restore_env_after_all_testing):
1715         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1716         (LinuxBrowserDriver.prepare_initial_env):
1717         (LinuxBrowserDriver.restore_env_after_all_testing):
1718         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1719         (OSXBrowserDriver.prepare_initial_env):
1720         (OSXBrowserDriver.restore_env_after_all_testing):
1721
1722 2019-04-28  Andy Estes  <aestes@apple.com>
1723
1724         Fix the watchOS engineering build.
1725
1726         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1727         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1728
1729 2019-04-27  Chris Dumez  <cdumez@apple.com>
1730
1731         [WKTR] Move test timeout handling to the UIProcess
1732         https://bugs.webkit.org/show_bug.cgi?id=197333
1733
1734         Reviewed by Darin Adler.
1735
1736         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1737         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1738         every WebContent process in the case of swapping.
1739
1740         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1741         would lead to crashes when firing the timer.
1742
1743         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1744         (WTR::InjectedBundle::didReceiveMessageToPage):
1745         (WTR::InjectedBundle::done):
1746         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1747         (WTR::InjectedBundle::shouldDumpPixels const):
1748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1749         (WTR::TestRunner::TestRunner):
1750         (WTR::TestRunner::waitUntilDone):
1751         (WTR::TestRunner::setWaitUntilDone):
1752         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1753         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1754         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1755         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1756         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1757         * WebKitTestRunner/TestInvocation.cpp:
1758         (WTR::TestInvocation::TestInvocation):
1759         (WTR::TestInvocation::createTestSettingsDictionary):
1760         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1761         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1762         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1763         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1764         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1765         (WTR::TestInvocation::setWaitUntilDone):
1766         (WTR::TestInvocation::done):
1767         * WebKitTestRunner/TestInvocation.h:
1768
1769 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1770
1771         [JSC] linkPolymorphicCall now does GC
1772         https://bugs.webkit.org/show_bug.cgi?id=197306
1773
1774         Reviewed by Saam Barati.
1775
1776         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1777         To add this test, we add `runWithoutBaseOption`.
1778
1779         * Scripts/run-jsc-stress-tests:
1780
1781 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1782
1783         Update inactive reviewers' status to 'contributor'.
1784
1785         Accidentally skipped one at first.
1786
1787         * Scripts/webkitpy/common/config/contributors.json:
1788
1789 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1790
1791         Update inactive reviewers' status to 'contributor'.
1792
1793         * Scripts/webkitpy/common/config/contributors.json: The change.
1794
1795         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1796         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1797         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1798         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1799         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1800         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1801         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1802         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1803         Sadly, regression tests operate on a crazy mix of mock and live data for
1804         contributors.json. It would be a substantial project to mock all code paths,
1805         so changing the tests instead.
1806
1807 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1808
1809         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1810         https://bugs.webkit.org/show_bug.cgi?id=197171
1811         <rdar://problem/47454979>
1812
1813         Reviewed by Youenn Fablet.
1814
1815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1816         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1817         (TestWebKitAPI::TEST):
1818
1819 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1820
1821         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1822         <https://webkit.org/b/197314>
1823         <rdar://problem/50245252>
1824
1825         Reviewed by Simon Fraser.
1826
1827         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1828         (WTR::UIScriptController::lastUndoLabel const):
1829         (WTR::UIScriptController::firstRedoLabel const):
1830         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1831
1832         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1833         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1834         - Call -autorelease to fix leak of NSDictionary.
1835
1836         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1837         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1838         (WTR::UIScriptController::selectFormPopoverTitle const):
1839         (WTR::UIScriptController::textContentType const):
1840         (WTR::UIScriptController::formInputLabel const):
1841         (WTR::UIScriptController::scrollingTreeAsText const):
1842         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1843
1844 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1845
1846         webkitpy: Running a single test will always use the default device
1847         https://bugs.webkit.org/show_bug.cgi?id=195472
1848         <rdar://problem/48724825>
1849
1850         Reviewed by Lucas Forschler.
1851
1852         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1853         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1854         requested will be run regardless of what shard they are in.
1855
1856         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1857         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1858         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1859         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1860         on the default device type.
1861         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1862         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1863         (RunTest.test_run_part): Ditto.
1864
1865 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1866
1867         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1868         https://bugs.webkit.org/show_bug.cgi?id=197165
1869
1870         Reviewed by Youenn Fablet.
1871
1872         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1873
1874 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1875
1876         Replace iOS build queue hardware
1877         https://bugs.webkit.org/show_bug.cgi?id=197312
1878
1879         Reviewed by Aakash Jain.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/config.json:
1882         Use newer hardware that supports macOS Mojave.
1883
1884 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1885
1886         check-webkit-style complains the first block in while loop.
1887         https://bugs.webkit.org/show_bug.cgi?id=197307
1888
1889         The style checker shouldn't complain about an open brace on
1890         its own line if the last non-whitespace character on the previous
1891         non-blank line is another open brace, because it's likely to
1892         indicate the begining of a nested code block.
1893
1894         Reviewed by Alex Christensen.
1895
1896         * Scripts/webkitpy/style/checkers/cpp.py:
1897         (check_braces):
1898         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1899         (WebKitStyleTest.test_braces):
1900
1901 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1902
1903         Stop IDB transactions to release locked database files when network process is ready to suspend
1904         https://bugs.webkit.org/show_bug.cgi?id=196372
1905         <rdar://problem/48930116>
1906
1907         Reviewed by Brady Eidson.
1908
1909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1910         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1911         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1912         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1913         (runTestAndCheckResult):
1914         (keepNetworkProcessActive):
1915         (TEST):
1916
1917 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1918
1919         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1920         https://bugs.webkit.org/show_bug.cgi?id=188357
1921         <rdar://problem/42986633>
1922
1923         Reviewed by Dean Jackson.
1924
1925         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1926         tests would fall into low memory mode and have different behavior.
1927         
1928         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1929         to Internals, so it's shared by DRT and WTR.
1930         
1931         We no longer need the WK2 C SPI glue.
1932
1933         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1934         (WTR::InjectedBundlePage::prepare):
1935
1936 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1937
1938         webkitpy: Including skipped tests in the final count
1939         https://bugs.webkit.org/show_bug.cgi?id=197298
1940         <rdar://problem/49705424>
1941
1942         Reviewed by Lucas Forschler.
1943
1944         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1945         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1946
1947 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1948
1949         Disable date and time inputs on iOSMac.
1950         https://bugs.webkit.org/show_bug.cgi?id=197287
1951         rdar://problem/46794376
1952
1953         Reviewed by Wenson Hsieh.
1954
1955         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1956
1957 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1958
1959         Fix test-webkitpy after r244653
1960         https://bugs.webkit.org/show_bug.cgi?id=197131
1961
1962         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1963         Also use C++17.
1964
1965 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1966
1967         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1968         https://bugs.webkit.org/show_bug.cgi?id=196991
1969         <rdar://problem/45507423>
1970
1971         Reviewed by Alex Christensen.
1972
1973         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1974         (-[NavigationTestDelegate init]):
1975         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1976         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1977         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1978         (TestWebKitAPI::TEST):
1979         (TEST): Deleted.
1980
1981 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1982
1983         Revert some code accidentally committed with r244653
1984         https://bugs.webkit.org/show_bug.cgi?id=197131
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1987         (TestWebKitAPI::TEST):
1988
1989 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1990
1991         Start using C++17
1992         https://bugs.webkit.org/show_bug.cgi?id=197131
1993
1994         Reviewed by Darin Adler.
1995
1996         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1997         * MiniBrowser/Configurations/Base.xcconfig:
1998         * MobileMiniBrowser/Configurations/Base.xcconfig:
1999         * TestWebKitAPI/Configurations/Base.xcconfig:
2000         * WebKitTestRunner/Configurations/Base.xcconfig:
2001
2002 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2003
2004         Unreviewed, rolling out r244627.
2005         https://bugs.webkit.org/show_bug.cgi?id=197282
2006
2007         Causing internal build failures (Requested by ShawnRoberts on
2008         #webkit).
2009
2010         Reverted changeset:
2011
2012         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2013         https://bugs.webkit.org/show_bug.cgi?id=197171
2014         https://trac.webkit.org/changeset/244627
2015
2016 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2017
2018         [GTK] Hardcoded text color in input fields
2019         https://bugs.webkit.org/show_bug.cgi?id=126907
2020
2021         Reviewed by Michael Catanzaro.
2022
2023         Add dark-mode command line option to MiniBrowser.
2024
2025         * MiniBrowser/gtk/main.c:
2026         (main):
2027
2028 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2029
2030         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2031         https://bugs.webkit.org/show_bug.cgi?id=196948
2032         <rdar://problem/49927131>
2033
2034         Reviewed by Tim Horton.
2035
2036         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2037         (TEST):
2038         The expected order of incoming events is
2039         1. didInvalidateIntrinsicContentSize
2040         2. didFirstLayout
2041         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2042         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2043         (and remember, all we care about is ordering).
2044
2045 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2046
2047         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2048         https://bugs.webkit.org/show_bug.cgi?id=197171
2049         <rdar://problem/47454979>
2050
2051         Reviewed by Youenn Fablet.
2052
2053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2054         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2055         (TestWebKitAPI::TEST):
2056
2057 2019-04-24  Brady Eidson  <beidson@apple.com>
2058
2059         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
2060         https://bugs.webkit.org/show_bug.cgi?id=191362
2061
2062         Reviewed by Alex Christensen.
2063
2064         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
2065           from an XHR to a custom protocol.
2066
2067 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2068
2069         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
2070         https://bugs.webkit.org/show_bug.cgi?id=197273
2071
2072         Reviewed by Dean Jackson.
2073
2074         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
2075         so that WebCoreTestSupport::resetInternalsObject() is always run.
2076
2077         * DumpRenderTree/mac/DumpRenderTree.mm:
2078         (resetWebViewToConsistentStateBeforeTesting):
2079         (runTest):
2080
2081 2019-04-24  John Wilander  <wilander@apple.com>
2082
2083         Age out unconverted Ad Click Attributions after one week.
2084         https://bugs.webkit.org/show_bug.cgi?id=197238
2085         <rdar://problem/50177349>
2086
2087         Reviewed by Chris Dumez.
2088
2089         This patch adds infrastructure to allow tests to expire all unconverted
2090         attributions early.
2091
2092         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2093         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2094         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
2095         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2096         * WebKitTestRunner/TestController.cpp:
2097         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
2098         * WebKitTestRunner/TestController.h:
2099         * WebKitTestRunner/TestInvocation.cpp:
2100         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2101
2102 2019-04-24  Chris Dumez  <cdumez@apple.com>
2103
2104         Fix flaky crashes in a couple of PSON API tests
2105         https://bugs.webkit.org/show_bug.cgi?id=197239
2106
2107         Reviewed by Tim Horton.
2108
2109         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
2110
2111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2112
2113 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
2114
2115         Make it possible to control the renderTreeAsText output by setting options on testRunner
2116         https://bugs.webkit.org/show_bug.cgi?id=197133
2117
2118         Reviewed by Sam Weinig.
2119
2120         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
2121         that make sense in testing (those that don't dump unstable data like addresses), and plumb
2122         these flags through the various framework layers.
2123
2124         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
2125
2126         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
2127         and hand-code DumpRenderTree bindings.
2128
2129         Some cleanup of the TestRunners, using member initializers.
2130
2131         * DumpRenderTree/TestRunner.cpp:
2132         (TestRunner::TestRunner):
2133         (setRenderTreeDumpOptionsCallback):
2134         (TestRunner::staticFunctions):
2135         (TestRunner::setRenderTreeDumpOptions):
2136         * DumpRenderTree/TestRunner.h:
2137         (TestRunner::renderTreeDumpOptions const):
2138         * DumpRenderTree/mac/DumpRenderTree.mm:
2139         (dump):
2140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2142         (WTR::InjectedBundlePage::dump):
2143         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2144         (WTR::TestRunner::TestRunner):
2145         (WTR::TestRunner::setRenderTreeDumpOptions):
2146         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2147         (WTR::TestRunner::renderTreeDumpOptions const):
2148
2149 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2150
2151         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
2152         https://bugs.webkit.org/show_bug.cgi?id=197078
2153         <rdar://problem/49564348>
2154
2155         Reviewed by Geoff Garen.
2156
2157         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2158         (TEST_F):
2159         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
2160         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
2161         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
2162
2163 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2164
2165         Add unit test for r239322
2166         https://bugs.webkit.org/show_bug.cgi?id=197236
2167
2168         Reviewed by Chris Dumez.
2169
2170         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
2171         May as well add the test infrastructure which was needed before and will be needed in the future.
2172
2173         * TestWebKitAPI/TCPServer.cpp:
2174         (TestWebKitAPI::TCPServer::TCPServer):
2175         * TestWebKitAPI/TCPServer.h:
2176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2177         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2178         (TestWebKitAPI::TEST):
2179         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2180         (TestWebKitAPI::downloadAtRate):
2181         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2182         (TEST):
2183         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
2184         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2185         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2186         (TestWebKitAPI::TEST):
2187         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2188         (TEST):
2189
2190 2019-04-24  Chris Dumez  <cdumez@apple.com>
2191
2192         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
2193         https://bugs.webkit.org/show_bug.cgi?id=197214
2194         <rdar://problem/49237544>
2195
2196         Reviewed by Alex Christensen.
2197
2198         Extend API test coverage.
2199
2200         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2201         (TEST):
2202
2203 2019-04-24  Philippe Normand  <pnormand@igalia.com>
2204
2205         [Build][GStreamer] Update to 1.16.0
2206         https://bugs.webkit.org/show_bug.cgi?id=197157
2207
2208         Reviewed by Xabier Rodriguez-Calvar.
2209
2210         The upstreamed patches were removed and a new one was added for a
2211         regression detected in the scaletempo GStreamer element. The GNOME
2212         Flatpak was migrated to 3.32 and I switched a few modules to Meson
2213         on the way, as it is the preferred build system now in GStreamer
2214         1.16.
2215
2216         * flatpak/files/httpd-autogen.sh:
2217         * flatpak/flatpakutils.py:
2218         (FlatpakPackage.install):
2219         (WebkitFlatpak.run_in_sandbox):
2220         * flatpak/org.webkit.CommonModules.yaml:
2221         * flatpak/org.webkit.WebKit.yaml:
2222         * gstreamer/jhbuild.modules:
2223         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
2224         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
2225         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
2226         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
2227         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
2228         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
2229         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
2230         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
2231         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
2232         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
2233         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
2234         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
2235         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
2236         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
2237         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
2238         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
2239         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
2240         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
2241         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
2242         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
2243         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
2244         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
2245
2246 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
2249         https://bugs.webkit.org/show_bug.cgi?id=197156
2250
2251         Reviewed by Michael Catanzaro.
2252
2253         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
2254         support was added.
2255
2256         * MiniBrowser/gtk/BrowserTab.c:
2257         (browser_tab_set_background_color): Set the passed in color as web view background color.
2258         * MiniBrowser/gtk/BrowserTab.h:
2259         * MiniBrowser/gtk/BrowserWindow.c:
2260         (browser_window_init): Initialize backgroundColor.
2261         (browser_window_append_view): Call browser_tab_set_background_color().
2262         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
2263         are added.
2264         * MiniBrowser/gtk/main.c:
2265         (main): Call browser_window_set_background_color() before creating the tabs.
2266
2267 2019-04-23  John Wilander  <wilander@apple.com>
2268
2269         Move Ad Click Attribution from internal feature to experimental feature
2270         https://bugs.webkit.org/show_bug.cgi?id=197218
2271         <rdar://problem/47651691>
2272
2273         Reviewed by Brent Fulgham.
2274
2275         * DumpRenderTree/TestOptions.cpp:
2276         (TestOptions::TestOptions):
2277
2278 2019-04-23  Andy Estes  <aestes@apple.com>
2279
2280         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
2281         https://bugs.webkit.org/show_bug.cgi?id=196749
2282         <rdar://problem/35773454>
2283
2284         Reviewed by Daniel Bates.
2285
2286         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
2287
2288         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2289         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
2290         (-[QuickLookDelegate webView:didFinishNavigation:]):
2291         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
2292         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2293         (runTest):
2294         (runTestDecideBeforeLoading):
2295         (runTestDecideAfterLoading):
2296         (TEST):
2297
2298 2019-04-23  John Wilander  <wilander@apple.com>
2299
2300         Remove Ad Click Attribution data when removing website data
2301         https://bugs.webkit.org/show_bug.cgi?id=197215
2302         <rdar://problem/47668988>
2303
2304         Reviewed by Chris Dumez.
2305
2306         This patch adds test infrastructure to delete Ad Click Attribution data
2307         through WebsiteDataStore::removeData().
2308
2309         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2310         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2311         (WTR::TestRunner::clearAdClickAttribution):
2312         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
2313         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2314         * WebKitTestRunner/TestController.cpp:
2315         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2316         * WebKitTestRunner/TestController.h:
2317         * WebKitTestRunner/TestInvocation.cpp:
2318         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2319
2320 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
2321
2322         webkitpy: Kill unresponsive worker processes
2323         https://bugs.webkit.org/show_bug.cgi?id=197205
2324         <rdar://problem/50104388>
2325
2326         Reviewed by Lucas Forschler.
2327
2328         * Scripts/webkitpy/common/message_pool.py:
2329         (_MessagePool.__init__): Add close timeout.
2330         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
2331
2332 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2333
2334         Add unit tests for WKWebView.serverTrust
2335         https://bugs.webkit.org/show_bug.cgi?id=197202
2336
2337         Reviewed by Youenn Fablet
2338
2339         * TestWebKitAPI/TCPServer.cpp:
2340         (TestWebKitAPI::deleter<BIO>::operator()):
2341         (TestWebKitAPI::deleter<SSL>::operator()):
2342         (TestWebKitAPI::deleter<X509>::operator()):
2343         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
2344         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
2345         (TestWebKitAPI::TCPServer::TCPServer):
2346         (TestWebKitAPI::TCPServer::listenForConnections):
2347         * TestWebKitAPI/TCPServer.h:
2348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2349         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2350         (TestWebKitAPI::TEST):
2351         (verifyCertificateAndPublicKey):
2352         (-[ServerTrustDelegate webView:didFinishNavigation:]):
2353         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2354         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2355         (TestWebKitAPI::downloadAtRate):
2356         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2357         (TEST):
2358         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2359         (TEST):
2360
2361 2019-04-23  Commit Queue  <commit-queue@webkit.org>
2362
2363         Unreviewed, rolling out r244556.
2364         https://bugs.webkit.org/show_bug.cgi?id=197212
2365
2366         Causing build failures on multiple builders (Requested by
2367         ShawnRoberts on #webkit).
2368
2369         Reverted changeset:
2370
2371         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2372         https://bugs.webkit.org/show_bug.cgi?id=197171
2373         https://trac.webkit.org/changeset/244556
2374
2375 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2376
2377         Fix iOS build.
2378         https://bugs.webkit.org/show_bug.cgi?id=195537
2379
2380         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2381         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2382         AdoptWK constructor is private now.  Use adoptWK instead.
2383
2384 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
2385
2386         Accessibility text search and selection API enhancements.
2387         https://bugs.webkit.org/show_bug.cgi?id=197095
2388         <rdar://problem/48181791>
2389
2390         Reviewed by Chris Fleizach.
2391
2392         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
2393
2394         * DumpRenderTree/AccessibilityTextMarker.h:
2395         * DumpRenderTree/AccessibilityUIElement.cpp:
2396         (searchTextWithCriteriaCallback):
2397         (AccessibilityUIElement::getJSClass):
2398         * DumpRenderTree/AccessibilityUIElement.h:
2399         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2400         (convertVectorToObjectArray):
2401         (convertNSArrayToVector):
2402         (searchTextParameterizedAttributeForCriteria):
2403         (AccessibilityUIElement::getLinkedUIElements):
2404         (AccessibilityUIElement::getDocumentLinks):
2405         (AccessibilityUIElement::getChildren):
2406         (AccessibilityUIElement::getChildrenWithRange):
2407         (AccessibilityUIElement::rowHeaders const):
2408         (AccessibilityUIElement::columnHeaders const):
2409         (AccessibilityUIElement::uiElementArrayAttributeValue const):
2410         (AccessibilityUIElement::searchTextWithCriteria):
2411         (AccessibilityUIElement::attributesOfColumnHeaders):
2412         (AccessibilityUIElement::attributesOfRowHeaders):
2413         (AccessibilityUIElement::attributesOfColumns):
2414         (AccessibilityUIElement::attributesOfRows):
2415         (AccessibilityUIElement::attributesOfVisibleCells):
2416         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2417         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2418         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2419         (WTR::convertVectorToObjectArray):
2420         (WTR::convertNSArrayToVector):
2421         (WTR::searchTextParameterizedAttributeForCriteria):
2422         (WTR::AccessibilityUIElement::getLinkedUIElements):
2423         (WTR::AccessibilityUIElement::getDocumentLinks):
2424         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2425         (WTR::AccessibilityUIElement::getChildren):
2426         (WTR::AccessibilityUIElement::getChildrenWithRange):
2427         (WTR::AccessibilityUIElement::rowHeaders const):
2428         (WTR::AccessibilityUIElement::columnHeaders const):
2429         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2430         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2431         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2432         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2433         (WTR::AccessibilityUIElement::attributesOfColumns):
2434         (WTR::AccessibilityUIElement::attributesOfRows):
2435         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2436         (WTR::convertElementsToObjectArray): Deleted.
2437
2438 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2439
2440         Multiple File Input Icon Set Regardless of File List
2441         https://bugs.webkit.org/show_bug.cgi?id=195537
2442
2443         Reviewed by Alexey Proskuryakov.
2444
2445         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2446         display string in iOS file inputs
2447
2448         * DumpRenderTree/TestRunner.cpp:
2449         (SetOpenPanelFilesMediaIconCallback):
2450         (TestRunner::staticFunctions):
2451         (TestRunner::setOpenPanelFilesMediaIcon):
2452         * DumpRenderTree/TestRunner.h:
2453         (TestRunner::openPanelFilesMediaIcon const):
2454         * DumpRenderTree/mac/UIDelegate.mm:
2455         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2458         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2459         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2460         * WebKitTestRunner/TestController.cpp:
2461         (WTR::runOpenPanel):
2462         (WTR::TestController::resetStateToConsistentValues):
2463         * WebKitTestRunner/TestController.h:
2464         (WTR::TestController::openPanelFileURLsMediaIcon const):
2465         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2466         * WebKitTestRunner/TestInvocation.cpp:
2467         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2468
2469 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2470
2471         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2472         https://bugs.webkit.org/show_bug.cgi?id=197171
2473         <rdar://problem/47454979>
2474
2475         Reviewed by Youenn Fablet.
2476
2477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2478         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2479         (TestWebKitAPI::TEST):
2480
2481 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2482
2483         [ews-build] Add unit tests for UnApplyPatchIfRequired
2484         https://bugs.webkit.org/show_bug.cgi?id=197197
2485
2486         Reviewed by Lucas Forschler.
2487
2488         * BuildSlaveSupport/ews-build/steps_unittest.py:
2489         (TestUnApplyPatchIfRequired):
2490         (TestUnApplyPatchIfRequired.test_success):
2491         (TestUnApplyPatchIfRequired.test_failure):
2492         (TestUnApplyPatchIfRequired.test_skip):
2493
2494 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2495
2496         [ews-build] Add unit tests for CleanWorkingDirectory
2497         https://bugs.webkit.org/show_bug.cgi?id=197195
2498
2499         Reviewed by Lucas Forschler.
2500
2501         * BuildSlaveSupport/ews-build/steps_unittest.py:
2502         (TestCleanWorkingDirectory):
2503         (TestCleanWorkingDirectory.test_success):
2504         (TestCleanWorkingDirectory.test_failure):
2505
2506 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-build] Use explicit imports instead of wildcard imports
2509         https://bugs.webkit.org/show_bug.cgi?id=197194
2510
2511         Reviewed by Lucas Forschler.
2512
2513         * BuildSlaveSupport/ews-build/factories.py:
2514         * BuildSlaveSupport/ews-build/loadConfig.py:
2515         * BuildSlaveSupport/ews-build/steps_unittest.py:
2516
2517 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2518
2519         [ews-build] Add unit tests for DownloadBuiltProduct
2520         https://bugs.webkit.org/show_bug.cgi?id=197193
2521
2522         Reviewed by Lucas Forschler.
2523
2524         * BuildSlaveSupport/ews-build/steps_unittest.py:
2525         (TestDownloadBuiltProduct):
2526         (TestDownloadBuiltProduct.setUp):
2527         (TestDownloadBuiltProduct.tearDown):
2528         (TestDownloadBuiltProduct.test_success):
2529         (TestDownloadBuiltProduct.test_failure):
2530
2531 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2532
2533         [ews-app] Exception while loading status-bubble when no build step has started
2534         https://bugs.webkit.org/show_bug.cgi?id=196676
2535
2536         Reviewed by Lucas Forschler.
2537
2538         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2539         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2540
2541 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2542
2543         [PlayStation] Support running of JSC tests on remote playstation devices
2544         https://bugs.webkit.org/show_bug.cgi?id=197170
2545
2546         Reviewed by Ross Kirsling.
2547
2548         Script changes
2549
2550         * Scripts/run-javascriptcore-tests:
2551         (runJSCStressTests): Pass arguments for playstation to
2552         run-jsc-stress-tests
2553         * Scripts/run-jsc-stress-tests:
2554         Handle $hostOS=="playstation" for determineArchitecture, turning
2555         off $isFTLPlatform and runProfiler and defaulting test writer.
2556         * Scripts/webkitdirs.pm:
2557         (jscPath): PlayStation WebKit executables have .elf extension
2558         (executableProductDir): PlayStation builds on Windows hosts but
2559         uses bin directory rather than bin64/bin32 for executable output
2560         location.
2561         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2562
2563 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2564
2565         [CMake][Win] Use target oriented design for WebKit
2566         https://bugs.webkit.org/show_bug.cgi?id=197173
2567
2568         Reviewed by Alex Christensen.
2569
2570         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2571         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2572
2573 2019-04-23  Chris Dumez  <cdumez@apple.com>
2574
2575         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2576         https://bugs.webkit.org/show_bug.cgi?id=197097
2577         <rdar://problem/50048318>
2578
2579         Reviewed by Alex Christensen.
2580
2581         Add API test coverage.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2584         (-[PSONScheme webView:startURLSchemeTask:]):
2585
2586 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2587
2588         [ATK] Implement AtkComponentIface scroll_to methods
2589         https://bugs.webkit.org/show_bug.cgi?id=196856
2590
2591         Reviewed by Michael Catanzaro.
2592
2593         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2594         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2595         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2596         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2597
2598 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2599
2600         [ews-build] Improve summary for UploadBuiltProduct step
2601         https://bugs.webkit.org/show_bug.cgi?id=197182
2602
2603         Reviewed by Lucas Forschler.
2604
2605         * BuildSlaveSupport/ews-build/steps.py:
2606         (UploadBuiltProduct): Added descriptionDone.
2607         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2608         * BuildSlaveSupport/ews-build/steps_unittest.py:
2609         (TestUploadBuiltProduct.test_success): Updated unit-test.
2610         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2611
2612 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2613
2614         [ews-build] Trigger queues only after uploading the archive
2615         https://bugs.webkit.org/show_bug.cgi?id=197180
2616
2617         Reviewed by Lucas Forschler.
2618
2619         * BuildSlaveSupport/ews-build/factories.py:
2620         (Factory.__init__):
2621         (BuildFactory.__init__): Remove trigger step from factories.
2622         (BuildFactory.propertiesToPassToTriggers): Deleted.
2623         * BuildSlaveSupport/ews-build/steps.py:
2624         (ConfigureBuild.__init__): Confiure triggers property.
2625         (Trigger): Step to trigger other queues.
2626         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2627         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2628
2629 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2630
2631         Deprecate WKContextCreateWithInjectedBundlePath
2632         https://bugs.webkit.org/show_bug.cgi?id=197169
2633
2634         Reviewed by Youenn Fablet.
2635
2636         * TestWebKitAPI/PlatformUtilities.cpp:
2637         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2638         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2639
2640 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2641
2642         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2643         https://bugs.webkit.org/show_bug.cgi?id=197093
2644         <rdar://problem/49708268>
2645
2646         Reviewed by Chris Dumez.
2647
2648         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2649         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2650         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2651         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2652         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2653
2654         * TestWebKitAPI/TCPServer.cpp:
2655         (TestWebKitAPI::TCPServer::TCPServer):
2656         (TestWebKitAPI::TCPServer::~TCPServer):
2657         (TestWebKitAPI::TCPServer::socketBindListen):
2658         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2659         * TestWebKitAPI/TCPServer.h:
2660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2661         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2662         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2663         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2664         (respondWithChallengeThenOK):
2665         (TestWebKitAPI::TEST):
2666         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2667         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2668         (TEST):
2669
2670 2019-04-22  Chris Dumez  <cdumez@apple.com>
2671
2672         Delayed WebProcessLaunch may break the _relatedWebView SPI
2673         https://bugs.webkit.org/show_bug.cgi?id=197160
2674
2675         Reviewed by Alex Christensen.
2676
2677         Add API test coverage.
2678
2679         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2680
2681 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2682
2683         Use curl to download packages for webkitpy autoinstaller
2684         https://bugs.webkit.org/show_bug.cgi?id=197164
2685
2686         Reviewed by Darin Adler.
2687
2688         * Scripts/webkitpy/common/system/autoinstall.py:
2689         (AutoInstaller._download): Use curl(1) to download packages necessary for
2690         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2691         errors which are not present when using curl(1).
2692
2693 2019-04-22  Chris Dumez  <cdumez@apple.com>
2694
2695         Unreviewed, rolling out r244502.
2696
2697         Caused crashes on the bots
2698
2699         Reverted changeset:
2700
2701         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2702         https://bugs.webkit.org/show_bug.cgi?id=197160
2703         https://trac.webkit.org/changeset/244502
2704
2705 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2706
2707         Unreviewed, rolling out r244437.
2708
2709         Still breaks internal tests.
2710
2711         Reverted changeset:
2712
2713         "InjectedBundle parameters often need initialization function
2714         called before unarchiving"
2715         https://bugs.webkit.org/show_bug.cgi?id=189709
2716         https://trac.webkit.org/changeset/244437
2717
2718 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2719
2720         [ews-build] Use singular verb in failure description in case of single api test failure
2721         https://bugs.webkit.org/show_bug.cgi?id=197013
2722
2723         Reviewed by Lucas Forschler.
2724
2725         * BuildSlaveSupport/ews-build/steps.py:
2726         (AnalyzeAPITestsResults.analyzeResults):
2727
2728 2019-04-22  Chris Dumez  <cdumez@apple.com>
2729
2730         Delayed WebProcessLaunch may break the _relatedWebView SPI
2731         https://bugs.webkit.org/show_bug.cgi?id=197160
2732
2733         Reviewed by Alex Christensen.
2734
2735         Add API test coverage.
2736
2737         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2738
2739 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2740
2741         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2742         https://bugs.webkit.org/show_bug.cgi?id=194630
2743
2744         Reviewed by Michael Catanzaro.
2745
2746         Return early from getAttributeSet() is passed in accessible is nullptr.
2747
2748         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2749
2750 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2751
2752         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2753         https://bugs.webkit.org/show_bug.cgi?id=197145
2754         <rdar://problem/50078170>
2755
2756         Reviewed by Darin Adler.
2757
2758         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2759         focus, or showing the font manager.
2760
2761         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2762         (TestWebKitAPI::TEST):
2763         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2764         (TEST):
2765         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2766         (TestWebKitAPI::TEST):
2767
2768 2019-04-21  Brian Burg  <bburg@apple.com>
2769
2770         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2771         https://bugs.webkit.org/show_bug.cgi?id=197125
2772         <rdar://problem/50061468>
2773
2774         Reviewed by Darin Adler.
2775
2776         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2777         using this class rather than making our own ./wpt serve invocation.
2778
2779         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2780         (WebDriverW3CWebServer):
2781         (WebDriverW3CWebServer.document_root): Expose this to clients.
2782         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2783
2784         (WebDriverW3CWebServer.__enter__):
2785         (WebDriverW3CWebServer.__exit__):
2786         Make it possible to use the web server with a 'with' statement.
2787
2788 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2789
2790         [CMake][Win] Use target oriented design for WebKitLegacy
2791         https://bugs.webkit.org/show_bug.cgi?id=197112
2792
2793         Reviewed by Konstantin Tokarev.
2794
2795         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2796
2797         * DumpRenderTree/CMakeLists.txt:
2798         * DumpRenderTree/PlatformWin.cmake:
2799         * DumpRenderTree/win/EventSender.cpp:
2800
2801 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2802
2803         Update text for old EWS submit button
2804         https://bugs.webkit.org/show_bug.cgi?id=197140
2805
2806         Reviewed by Alexey Proskuryakov.
2807
2808         * QueueStatusServer/templates/statusbubble.html:
2809
2810 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-app] New EWS should poll bugzilla more frequently
2813         https://bugs.webkit.org/show_bug.cgi?id=197138
2814
2815         Reviewed by Alexey Proskuryakov.
2816
2817         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2818         (FetchLoop.__init__):
2819
2820 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2821
2822         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2823         https://bugs.webkit.org/show_bug.cgi?id=197139
2824
2825         Reviewed by Alexey Proskuryakov.
2826
2827         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2828         * QueueStatusServer/templates/statusbubble.html:
2829
2830 2019-04-20  Chris Dumez  <cdumez@apple.com>
2831
2832         Unreviewed, fix iOS build with recent SDKs.
2833
2834         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2835
2836 2019-04-19  Keith Miller  <keith_miller@apple.com>
2837
2838         Add script to merge run_benchmark jsons
2839         https://bugs.webkit.org/show_bug.cgi?id=197107
2840
2841         Reviewed by Michael Saboff.
2842
2843         The script basically recursively decends through all json objects until it gets
2844         to an array or JSON primitive and concats or takes the first value, respectively.
2845
2846         This patch also adds +x bits to the compare-results script so it
2847         can be run directly from the command line. I had to add a new line so that svn
2848         will accept the change... yay svn!
2849
2850         * Scripts/compare-results:
2851         * Scripts/merge-result-jsons: Added.
2852         (readJSONFile):
2853         (deepAppend):
2854         (mergeJSONs):
2855         (main):
2856
2857 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2858
2859         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2860         https://bugs.webkit.org/show_bug.cgi?id=197079
2861
2862         Reviewed by Darin Adler.
2863
2864         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2865
2866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2868
2869 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2870
2871         Unreviewed, rolling out r244434.
2872         https://bugs.webkit.org/show_bug.cgi?id=197089
2873
2874         caused 1 API test failure (Requested by zalan on #webkit).
2875
2876         Reverted changeset:
2877
2878         "Regression (r244291): Broken API Test
2879         AutoLayoutRenderingProgressRelativeOrdering"
2880         https://bugs.webkit.org/show_bug.cgi?id=196948
2881         https://trac.webkit.org/changeset/244434
2882
2883 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2884
2885         Add new compatibility mode API on WKNavigation
2886         https://bugs.webkit.org/show_bug.cgi?id=197069
2887         <rdar://problem/50025800>
2888
2889         Reviewed by Tim Horton.
2890
2891         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2892
2893         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2894         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2895         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2896
2897 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2898
2899         [CMake] Make WebCore headers copies
2900         https://bugs.webkit.org/show_bug.cgi?id=182512
2901         <rdar://problem/37510435>
2902
2903         Reviewed by Alex Christensen.
2904
2905         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2906         ports.
2907
2908         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2909         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2910
2911         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2912         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2913         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2914         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2915         * TestWebKitAPI/CMakeLists.txt:
2916         * TestWebKitAPI/PlatformWin.cmake:
2917         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2918         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2919         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2920
2921 2019-04-18  Jer Noble  <jer.noble@apple.com>
2922
2923         Add support for parsing FairPlayStreaming PSSH boxes.
2924         https://bugs.webkit.org/show_bug.cgi?id=197064
2925
2926         Reviewed by Eric Carlson.
2927
2928         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2929         (TestWebKitAPI::TEST):
2930
2931 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2932
2933         InjectedBundle parameters often need initialization function called before unarchiving
2934         https://bugs.webkit.org/show_bug.cgi?id=189709
2935         <rdar://problem/44573653>
2936
2937         Reviewed by Ryosuke Niwa.
2938
2939         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2940         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2941
2942 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2943
2944         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2945         https://bugs.webkit.org/show_bug.cgi?id=196948
2946         <rdar://problem/49927131>
2947
2948         Reviewed by Tim Horton.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2951         (TEST): 
2952         The expected order of incoming events is
2953         1. didInvalidateIntrinsicContentSize
2954         2. didFirstLayout
2955         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2956         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2957         (and remember, all we care about is ordering).
2958
2959 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2960
2961         Unreviewed, rolling out r244299.
2962
2963         Breaks internal tests.
2964
2965         Reverted changeset:
2966
2967         "InjectedBundle parameters often need initialization function
2968         called before unarchiving"
2969         https://bugs.webkit.org/show_bug.cgi?id=189709
2970         https://trac.webkit.org/changeset/244299
2971
2972 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2973
2974         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2975         https://bugs.webkit.org/show_bug.cgi?id=197053
2976
2977         Reviewed by Saam Barati.
2978
2979         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2980         (TestWebKitAPI::TEST):
2981
2982 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2983
2984         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2985         https://bugs.webkit.org/show_bug.cgi?id=197028
2986         <rdar://problem/49985290>
2987
2988         Reviewed by Wenson Hsieh.
2989
2990         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2991         (TEST):
2992         Liberal application of waitForNextPresentationUpdate works around a race
2993         where if the page rapidly changes its viewport arguments (or an API client
2994         rapidly changes its viewport arguments), we'd get stuck thinking that the
2995         user had intentionally zoomed the page, and stop resetting the initial scale.
2996         This deserves a separate bug, but no need to keep the test failing while
2997         we think about it.
2998
2999 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3000
3001         REGRESSION (r241988): Switching tabs is slow
3002         https://bugs.webkit.org/show_bug.cgi?id=197037
3003         <rdar://problem/49951473>
3004
3005         Reviewed by Simon Fraser.
3006
3007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3008         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
3009         (TEST):
3010         * TestWebKitAPI/cocoa/TestWKWebView.h:
3011         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3012         (-[TestWKWebView addToTestWindow]):
3013         Add a test that hangs without this fix.
3014
3015 2019-04-17  Truitt Savell  <tsavell@apple.com>
3016
3017         Unreviewed, rolling out r244400.
3018
3019         Caused testing to exit early with assertionon Debug WK2
3020
3021         Reverted changeset:
3022
3023         "UI↔Web deadlock when printing with a JavaScript alert
3024         visible"
3025         https://bugs.webkit.org/show_bug.cgi?id=196839
3026         https://trac.webkit.org/changeset/244400
3027
3028 2019-04-17  Brady Eidson  <beidson@apple.com>
3029
3030         Link clicks in PDFs shouldn't send referrer headers.
3031         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
3032
3033         Reviewed by Tim Horton.
3034
3035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3036         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
3037         (putPDFBytesCallback):
3038         (emptyReleaseInfoCallback):
3039         (createPDFWithLinkToURL):
3040         (TEST):
3041
3042 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3043
3044         UI↔Web deadlock when printing with a JavaScript alert visible
3045         https://bugs.webkit.org/show_bug.cgi?id=196839
3046         <rdar://problem/49157642>
3047
3048         Reviewed by Andy Estes.
3049
3050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3051         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
3052         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3053         (TEST):
3054
3055 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3056
3057         WKRetainPtr's adoption constructor should be private
3058         https://bugs.webkit.org/show_bug.cgi?id=197019
3059
3060         Reviewed by Tim Horton.
3061
3062         * DumpRenderTree/mac/DumpRenderTree.mm:
3063         (dumpFramesAsText):
3064         * TestWebKitAPI/InjectedBundleController.cpp:
3065         (TestWebKitAPI::InjectedBundleController::initialize):
3066         * TestWebKitAPI/PlatformUtilities.cpp:
3067         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3068         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
3069         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3070         (TestWebKitAPI::Util::toWK):
3071         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3072         (TestWebKitAPI::TEST):
3073         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3074         (TestWebKitAPI::TEST):
3075         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3076         (TestWebKitAPI::TEST):
3077         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3078         (TestWebKitAPI::TEST):
3079         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3080         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
3081         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
3082         (TestWebKitAPI::TEST):
3083         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
3084         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
3085         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
3086         (TestWebKitAPI::TEST):
3087         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
3088         (TestWebKitAPI::TEST):
3089         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3090         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3091         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
3092         (TestWebKitAPI::TEST):
3093         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3094         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3095         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3096         (TestWebKitAPI::TEST):
3097         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3098         (TestWebKitAPI::TEST):
3099         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3100         (TestWebKitAPI::TEST):
3101         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3102         (TestWebKitAPI::TEST):
3103         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3104         (TestWebKitAPI::TEST):
3105         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3106         (TestWebKitAPI::TEST):
3107         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3108         (TestWebKitAPI::TEST):
3109         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
3110         (TestWebKitAPI::TEST):
3111         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3114         (TestWebKitAPI::TEST):
3115         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3116         (TestWebKitAPI::TEST):
3117         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3118         (TestWebKitAPI::TEST):
3119         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3120         (TestWebKitAPI::TEST):
3121         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
3122         (TestWebKitAPI::TEST):
3123         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
3126         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3127         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
3128         (TestWebKitAPI::TEST):
3129         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
3130         (TestWebKitAPI::TEST):
3131         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
3132         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
3133         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
3134         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
3135         (TestWebKitAPI::TEST):
3136         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
3137         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3138         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
3139         (TestWebKitAPI::TEST):
3140         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
3141         (TestWebKitAPI::TEST):
3142         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
3143         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
3144         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3145         (TestWebKitAPI::TEST):
3146         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3147         (TestWebKitAPI::loadAlternateHTMLString):
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
3150         (TestWebKitAPI::TEST):
3151         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3152         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3153         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3154         (TestWebKitAPI::buildAndPerformTest):
3155         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3156         (TestWebKitAPI::TEST):
3157         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
3158         (TestWebKitAPI::TEST):
3159         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
3160         (TestWebKitAPI::TEST):
3161         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3162         (TestWebKitAPI::TEST):
3163         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3164         (TestWebKitAPI::TEST):
3165         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3166         (TestWebKitAPI::TEST):
3167         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3168         (TestWebKitAPI::TEST):
3169         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3170         (TestWebKitAPI::TEST):
3171         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
3172         (TestWebKitAPI::TEST):
3173         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3174         (TestWebKitAPI::TEST):
3175         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3176         (TestWebKitAPI::TEST):
3177         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3178         (TestWebKitAPI::TEST):
3179         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3180         (TestWebKitAPI::TEST):
3181         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3182         (TestWebKitAPI::TEST):
3183         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3184         (TestWebKitAPI::TEST):
3185         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3186         (TestWebKitAPI::TEST):
3187         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3188         (TestWebKitAPI::TEST):
3189         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3190         (TestWebKitAPI::TEST):
3191         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3192         (TestWebKitAPI::TEST):
3193         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3194         (TestWebKitAPI::TEST):
3195         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
3196         (TestWebKitAPI::TEST):
3197         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
3198         (TestWebKitAPI::TEST):
3199         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3200         (TestWebKitAPI::TEST):
3201         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3202         (TestWebKitAPI::TEST):
3203         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3204         (TestWebKitAPI::TEST):
3205         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3206         (TestWebKitAPI::TEST):
3207         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3208         (TestWebKitAPI::TEST):
3209         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3210         (TestWebKitAPI::TEST):
3211         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3212         (TestWebKitAPI::TEST):
3213         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
3214         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3215         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
3216         (TestWebKitAPI::TEST):
3217         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
3218         (TestWebKitAPI::TEST):
3219         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
3220         (TestWebKitAPI::TEST):
3221         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
3222         (TestWebKitAPI::TEST):
3223         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3224         (TestWebKitAPI::TEST):
3225         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3226         (TestWebKitAPI::TEST):
3227         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
3228         (TestWebKitAPI::TEST):
3229         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3230         (TestWebKitAPI::TEST):
3231         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3232         (TestWebKitAPI::TEST):
3233         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3234         (TestWebKitAPI::TEST):
3235         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
3236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
3237         (TEST):
3238         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3239         (TEST):
3240         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3241         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3242         (TEST):
3243         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
3244         (TestWebKitAPI::TEST):
3245         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3246         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3247         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3248         (WTR::getMenuItemTitleCallback):
3249         (WTR::createMouseMessageBody):
3250         (WTR::EventSendingController::mouseDown):
3251         (WTR::EventSendingController::mouseUp):
3252         (WTR::EventSendingController::mouseMoveTo):
3253         (WTR::EventSendingController::mouseForceClick):
3254         (WTR::EventSendingController::startAndCancelMouseForceClick):
3255         (WTR::EventSendingController::mouseForceDown):
3256         (WTR::EventSendingController::mouseForceUp):
3257         (WTR::EventSendingController::mouseForceChanged):
3258         (WTR::EventSendingController::leapForward):
3259         (WTR::EventSendingController::scheduleAsynchronousClick):
3260         (WTR::createKeyDownMessageBody):
3261         (WTR::EventSendingController::keyDown):
3262         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3263         (WTR::EventSendingController::mouseScrollBy):
3264         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3265         (WTR::EventSendingController::continuousMouseScrollBy):
3266         (WTR::EventSendingController::addTouchPoint):
3267         (WTR::EventSendingController::updateTouchPoint):
3268         (WTR::EventSendingController::setTouchModifier):
3269         (WTR::EventSendingController::setTouchPointRadius):
3270         (WTR::EventSendingController::touchStart):
3271         (WTR::EventSendingController::touchMove):
3272         (WTR::EventSendingController::touchEnd):
3273         (WTR::EventSendingController::touchCancel):
3274         (WTR::EventSendingController::clearTouchPoints):
3275         (WTR::EventSendingController::releaseTouchPoint):
3276         (WTR::EventSendingController::cancelTouchPoint):
3277         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3278         (WTR::InjectedBundle::didCreatePage):
3279         (WTR::InjectedBundle::didReceiveMessage):
3280         (WTR::InjectedBundle::didReceiveMessageToPage):
3281         (WTR::InjectedBundle::booleanForKey):
3282         (WTR::InjectedBundle::done):
3283         (WTR::InjectedBundle::dumpToStdErr):
3284         (WTR::InjectedBundle::outputText):
3285         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3286         (WTR::InjectedBundle::postAddChromeInputField):
3287         (WTR::InjectedBundle::postRemoveChromeInputField):
3288         (WTR::InjectedBundle::postFocusWebView):
3289         (WTR::InjectedBundle::postSetBackingScaleFactor):
3290         (WTR::InjectedBundle::postSetWindowIsKey):
3291         (WTR::InjectedBundle::postSetViewSize):
3292         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3293         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3294         (WTR::InjectedBundle::setGeolocationPermission):
3295         (WTR::InjectedBundle::setMockGeolocationPosition):
3296         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3297         (WTR::InjectedBundle::isGeolocationProviderActive const):
3298         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
3299         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3300         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
3301         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3302         (WTR::InjectedBundle::setCustomPolicyDelegate):
3303         (WTR::InjectedBundle::setHidden):
3304         (WTR::InjectedBundle::setCacheModel):
3305         (WTR::InjectedBundle::shouldProcessWorkQueue const):
3306         (WTR::InjectedBundle::processWorkQueue):
3307         (WTR::InjectedBundle::queueBackNavigation):
3308         (WTR::InjectedBundle::queueForwardNavigation):
3309         (WTR::InjectedBundle::queueLoad):
3310         (WTR::InjectedBundle::queueLoadHTMLString):
3311         (WTR::InjectedBundle::queueReload):
3312         (WTR::InjectedBundle::queueLoadingScript):
3313         (WTR::InjectedBundle::queueNonLoadingScript):
3314         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3315         (WTR::frameToStr):
3316         (WTR::InjectedBundlePage::InjectedBundlePage):
3317         (WTR::dumpFrameDescriptionSuitableForTestResult):
3318         (WTR::dumpFrameScrollPosition):
3319         (WTR::dumpDescendantFrameScrollPositions):
3320         (WTR::dumpFrameText):
3321         (WTR::dumpDescendantFramesText):
3322         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3323         (WTR::TestRunner::shouldDumpPixels const):
3324         (WTR::TestRunner::setDumpPixels):
3325         (WTR::TestRunner::whatToDump const):
3326         (WTR::TestRunner::setWhatToDump):
3327         (WTR::TestRunner::setWaitUntilDone):
3328         (WTR::TestRunner::shouldWaitUntilDone const):
3329         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
3330         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3331         (WTR::TestRunner::clearAllDatabases):
3332         (WTR::TestRunner::setIDBPerOriginQuota):
3333         (WTR::TestRunner::originsWithApplicationCache):
3334         (WTR::TestRunner::setCanOpenWindows):
3335         (WTR::TestRunner::setXSSAuditorEnabled):
3336         (WTR::TestRunner::setMediaDevicesEnabled):
3337         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
3338         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
3339         (WTR::TestRunner::setCustomUserAgent):
3340         (WTR::TestRunner::setWebAPIStatisticsEnabled):
3341         (WTR::TestRunner::setModernMediaControlsEnabled):
3342         (WTR::TestRunner::setWebGL2Enabled):
3343         (WTR::TestRunner::setWritableStreamAPIEnabled):
3344         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
3345         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
3346         (WTR::TestRunner::setAllowsAnySSLCertificate):
3347         (WTR::TestRunner::setPluginsEnabled):
3348         (WTR::TestRunner::setValueForUser):
3349         (WTR::TestRunner::setAudioResult):
3350         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3351         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3352         (WTR::TestRunner::setAlwaysAcceptCookies):
3353         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3354         (WTR::TestRunner::isDoingMediaCapture const):
3355         (WTR::TestRunner::queueLoad):
3356         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3357         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3358         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3359         (WTR::TestRunner::setShouldLogDownloadCallbacks):
3360         (WTR::TestRunner::setAuthenticationUsername):
3361         (WTR::TestRunner::setAuthenticationPassword):
3362         (WTR::TestRunner::secureEventInputIsEnabled const):
3363         (WTR::TestRunner::setBlockAllPlugins):
3364         (WTR::TestRunner::setPluginSupportedMode):
3365         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3366         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
3367         (WTR::TestRunner::setNavigationGesturesEnabled):
3368         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3369         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
3370         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3371         (WTR::TestRunner::terminateNetworkProcess):
3372         (WTR::TestRunner::terminateServiceWorkerProcess):
3373         (WTR::TestRunner::runUIScript):
3374         (WTR::TestRunner::setStatisticsDebugMode):
3375         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3376         (WTR::TestRunner::setStatisticsLastSeen):
3377         (WTR::TestRunner::setStatisticsPrevalentResource):
3378         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
3379         (WTR::TestRunner::dumpResourceLoadStatistics):
3380         (WTR::TestRunner::isStatisticsPrevalentResource):
3381         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3382         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3383         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3384         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3385         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
3386         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3387         (WTR::TestRunner::setStatisticsGrandfathered):
3388         (WTR::TestRunner::isStatisticsGrandfathered):
3389         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
3390         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
3391         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
3392         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
3393         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
3394         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
3395         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3396         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
3397         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3398         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3399         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3400         (WTR::TestRunner::statisticsSubmitTelemetry):
3401         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3402         (WTR::TestRunner::setStatisticsIsRunningTest):
3403         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3404         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3405         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3406         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3407         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3408         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3409         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3410         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3411         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3412         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3413         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3414         (WTR::TestRunner::statisticsResetToConsistentState):
3415         (WTR::TestRunner::setStorageAccessAPIEnabled):
3416         (WTR::TestRunner::getAllStorageAccessEntries):
3417         (WTR::TestRunner::addMockMediaDevice):
3418         (WTR::TestRunner::clearMockMediaDevices):
3419         (WTR::TestRunner::removeMockMediaDevice):
3420         (WTR::TestRunner::resetMockMediaDevices):
3421         (WTR::TestRunner::connectMockGamepad):
3422         (WTR::TestRunner::disconnectMockGamepad):
3423         (WTR::TestRunner::setMockGamepadDetails):
3424         (WTR::TestRunner::setMockGamepadAxisValue):
3425         (WTR::TestRunner::setMockGamepadButtonValue):
3426         (WTR::TestRunner::removeAllSessionCredentials):
3427         (WTR::TestRunner::clearDOMCache):
3428         (WTR::TestRunner::clearDOMCaches):
3429         (WTR::TestRunner::hasDOMCache):
3430         (WTR::TestRunner::domCacheSize):
3431         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3432         (WTR::TestRunner::getApplicationManifestThen):
3433         (WTR::TestRunner::injectUserScript):
3434         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3435         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3436         (WTR::TestRunner::addTestKeyToKeychain):
3437         (WTR::TestRunner::cleanUpKeychain):
3438         (WTR::TestRunner::keyExistsInKeychain):
3439         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3440         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3441         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3442         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3443         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3444         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3445         * WebKitTestRunner/TestController.cpp:
3446         (WTR::TestController::initialize):
3447         (WTR::parseStringTestHeaderValueAsRelativePath):
3448         (WTR::updateTestOptionsFromTestHeader):
3449         (WTR::TestController::runTest):
3450         (WTR::TestController::didReceiveLiveDocumentsList):
3451         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3452         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3453         (WTR::TestController::didFinishNavigation):
3454         (WTR::TestController::didReceiveAuthenticationChallenge):
3455         * WebKitTestRunner/TestInvocation.cpp:
3456         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3457         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3458         (WTR::TestInvocation::uiScriptDidComplete):
3459         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3460         * WebKitTestRunner/WebNotificationProvider.cpp:
3461         (WTR::WebNotificationProvider::closeWebNotification):
3462         * WebKitTestRunner/WorkQueueManager.cpp:
3463         (WTR::ScriptItem::ScriptItem):
3464         (WTR::WorkQueueManager::queueLoad):
3465         (WTR::WorkQueueManager::queueLoadHTMLString):
3466
3467 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3468
3469         Add a comment to make my test from r244139 less mysterious.
3470         https://bugs.webkit.org/show_bug.cgi?id=196744
3471
3472         As suggested by Darin Adler.
3473
3474         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3475         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3476
3477 2019-04-17  Chris Dumez  <cdumez@apple.com>
3478
3479         Remember device orientation permission for the duration of the browsing session
3480         https://bugs.webkit.org/show_bug.cgi?id=196992
3481         <rdar://problem/49946067>
3482
3483         Reviewed by Alex Christensen.
3484
3485         Add API test coverage.
3486
3487         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3488         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3489         (TEST):
3490
3491 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3492
3493         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3494         https://bugs.webkit.org/show_bug.cgi?id=196675
3495
3496         Reviewed by Lucas Forschler.
3497
3498         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3499         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3500
3501 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3502
3503         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3504         https://bugs.webkit.org/show_bug.cgi?id=196919
3505         <rdar://problem/41630459>
3506
3507         Reviewed by Tim Horton.
3508
3509         Add iOS support for several new testing hooks. See below for more detail.
3510
3511         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3512         (WTR::UIScriptController::isDismissingMenu const):
3513
3514         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3515         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3516         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3517
3518         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3519         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3520         (WTR::UIScriptController::isDismissingMenu const):
3521         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3522         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3523         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3524         (WTR::InjectedBundle::didReceiveMessageToPage):
3525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3526         (WTR::TestRunner::setAllowedMenuActions):
3527
3528         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3529         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3530         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3531         against the name of the custom action.
3532
3533         (WTR::TestRunner::installCustomMenuAction):
3534
3535         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3536         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3537         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3538         triggered.
3539
3540         (WTR::TestRunner::performCustomMenuAction):
3541
3542         Invoked when the custom menu action is triggered.
3543
3544         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3545         * WebKitTestRunner/TestController.cpp:
3546         (WTR::TestController::installCustomMenuAction):
3547         (WTR::TestController::setAllowedMenuActions):
3548         * WebKitTestRunner/TestController.h:
3549         * WebKitTestRunner/TestInvocation.cpp:
3550         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3551         (WTR::TestInvocation::performCustomMenuAction):
3552
3553         Add plumbing to call back into the injected bundle when performing the custom action.
3554
3555         * WebKitTestRunner/TestInvocation.h:
3556         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3557         (WTR::TestController::installCustomMenuAction):
3558         (WTR::TestController::setAllowedMenuActions):
3559         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3560         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3561         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3562         (-[TestRunnerWKWebView becomeFirstResponder]):
3563         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3564
3565         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3566         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3567         in the Mail app on iOS.
3568
3569         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3570         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3571         (-[TestRunnerWKWebView resetCustomMenuAction]):
3572         (-[TestRunnerWKWebView performCustomAction:]):
3573         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3574         (-[TestRunnerWKWebView _willHideMenu]):
3575         (-[TestRunnerWKWebView _didHideMenu]):
3576         * WebKitTestRunner/ios/TestControllerIOS.mm:
3577         (WTR::TestController::platformResetStateToConsistentValues):
3578
3579         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3580         if specified.
3581
3582         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3583         (WTR::UIScriptController::isDismissingMenu const):
3584
3585 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3586
3587         Allow sharing from imageSheet on an image document
3588         https://bugs.webkit.org/show_bug.cgi?id=196891
3589         <rdar://problem/25377386>
3590
3591         Reviewed by Tim Horton.
3592
3593         Test to make sure that the correct imageURL is extracted from an image element.
3594
3595         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3596         (TestWebKitAPI::TEST):
3597
3598 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3599
3600         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3601         https://bugs.webkit.org/show_bug.cgi?id=196995
3602
3603         Reviewed by Brady Eidson.
3604
3605         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3606         (TEST):
3607
3608 2019-04-16  Chris Dumez  <cdumez@apple.com>
3609
3610         URL set by document.open() is not communicated to the UIProcess
3611         https://bugs.webkit.org/show_bug.cgi?id=196941
3612         <rdar://problem/49237544>
3613
3614         Reviewed by Geoff Garen.
3615
3616         Add API test coverage.
3617
3618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3619         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3620         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3621         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3622         (TEST):
3623
3624 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3625
3626         Unreviewed, rolling out r244321.
3627         https://bugs.webkit.org/show_bug.cgi?id=196968
3628
3629         Causing all WK2 Debug builds to exit early after Assertion
3630         failures. (Requested by ShawnRoberts on #webkit).
3631
3632         Reverted changeset:
3633
3634         "URL set by document.open() is not communicated to the
3635         UIProcess"
3636         https://bugs.webkit.org/show_bug.cgi?id=196941
3637         https://trac.webkit.org/changeset/244321
3638
3639 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3640
3641         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3642         https://bugs.webkit.org/show_bug.cgi?id=196948
3643
3644         Reviewed by Zalan Bujtas.
3645
3646         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3647         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3648
3649 2019-04-15  Chris Dumez  <cdumez@apple.com>
3650
3651         URL set by document.open() is not communicated to the UIProcess
3652         https://bugs.webkit.org/show_bug.cgi?id=196941
3653         <rdar://problem/49237544>
3654
3655         Reviewed by Geoffrey Garen.
3656
3657         Add API test coverage.
3658
3659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: