[GTK] [CMake] Add support for building WebKit2
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK] [CMake] Add support for building WebKit2
4         https://bugs.webkit.org/show_bug.cgi?id=116372
5
6         Reviewed by Gustavo Noronha Silva.
7
8         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
9         * MiniBrowser/gtk/CMakeLists.txt: Added.
10
11 2013-05-21  Jessie Berlin  <jberlin@apple.com>
12
13         Revert r149635, it was too optimistic.
14
15         Rubber-stamped by Andreas Kling.
16
17         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
18         #ifdefs in WebCore code outside of WebCore/platform.
19
20         * Scripts/webkitpy/style/checkers/cpp.py:
21         (check_invalid_increment):
22         (process_line):
23         (CppChecker):
24         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
25         (CppStyleTest.test_plain_integral_bitfields):
26
27 2013-05-21  Jer Noble  <jer.noble@apple.com>
28
29         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
30
31         * lldb/lldb_webkit.py:
32         (WTFVectorProvider.num_children):
33         (WTFVectorProvider.get_child_index):
34         (WTFVectorProvider.get_child_at_index):
35         (WTFVectorProvider.update):
36
37 2013-05-21  Jessie Berlin  <jberlin@apple.com>
38
39         Expose a way to know when forms are added to a page or when form controls are added to a form
40         in the injected bundle
41         https://bugs.webkit.org/show_bug.cgi?id=116334
42
43         Reviewed by Alexey Proskuryakov.
44
45         Add tests for the new callbacks.
46
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
49
50         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
51         (TestWebKitAPI::nullJavaScriptCallback):
52         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
53         being passed in for the callback.
54         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
55         After receiving the message that didAssociateFormControls callback was invoked from adding
56         the form in the onload handler, tell the page to add a password field to the form, which
57         should also invoke didAssociateFormControls callback.
58         (TestWebKitAPI::setInjectedBundleClient):
59         Register to receive messages.
60         (TestWebKitAPI::TEST):
61         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
62         been invoked for both adding the form and for adding a password field to the form.
63
64         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
65         (TestWebKitAPI::shouldNotifyOnFormChanges):
66         Return true so the didAssociateFormControls callback is invoked.
67         (TestWebKitAPI::didAssociateFormControls):
68         Tell the UI process.
69         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
70         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
71         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
72
73         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
74         Add a form in response to the onload event. Add a button that will add the password field
75         for manual testing.
76
77 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
78
79         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
80         https://bugs.webkit.org/show_bug.cgi?id=106341
81
82         Reviewed by Martin Robinson.
83
84         Adds support for retrieving accessibility element at exact point.
85
86         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
87         (WTR::AccessibilityUIElement::elementAtPoint):
88
89 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
90
91         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
92         https://bugs.webkit.org/show_bug.cgi?id=112913
93
94         Reviewed by Martin Robinson.
95
96         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
97         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
98         so the leak appears.
99
100         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
101         (WTR):
102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
103         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
104         (WTR::AccessibilityController::rootElement):
105         (WTR):
106         (WTR::AccessibilityController::focusedElement):
107         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
108         (WTR::checkElementState):
109         (WTR::indexRangeInTable):
110         (WTR::alterCurrentValue):
111         (WTR::AccessibilityUIElement::getChildren):
112         (WTR::AccessibilityUIElement::getChildrenWithRange):
113         (WTR::AccessibilityUIElement::childrenCount):
114         (WTR::AccessibilityUIElement::indexOfChild):
115         (WTR::AccessibilityUIElement::titleUIElement):
116         (WTR::AccessibilityUIElement::parentElement):
117         (WTR::AccessibilityUIElement::allAttributes):
118         (WTR::AccessibilityUIElement::role):
119         (WTR::AccessibilityUIElement::title):
120         (WTR::AccessibilityUIElement::description):
121         (WTR::AccessibilityUIElement::orientation):
122         (WTR::AccessibilityUIElement::stringValue):
123         (WTR::AccessibilityUIElement::language):
124         (WTR::AccessibilityUIElement::x):
125         (WTR::AccessibilityUIElement::y):
126         (WTR::AccessibilityUIElement::width):
127         (WTR::AccessibilityUIElement::height):
128         (WTR::AccessibilityUIElement::intValue):
129         (WTR::AccessibilityUIElement::minValue):
130         (WTR::AccessibilityUIElement::maxValue):
131         (WTR::AccessibilityUIElement::isEnabled):
132         (WTR::AccessibilityUIElement::isFocused):
133         (WTR::AccessibilityUIElement::isSelected):
134         (WTR::AccessibilityUIElement::isExpanded):
135         (WTR::AccessibilityUIElement::isChecked):
136         (WTR::AccessibilityUIElement::rowCount):
137         (WTR::AccessibilityUIElement::columnCount):
138         (WTR::AccessibilityUIElement::rowIndexRange):
139         (WTR::AccessibilityUIElement::columnIndexRange):
140         (WTR::AccessibilityUIElement::cellForColumnAndRow):
141         (WTR::AccessibilityUIElement::increment):
142         (WTR::AccessibilityUIElement::decrement):
143         (WTR::AccessibilityUIElement::press):
144         (WTR::AccessibilityUIElement::documentEncoding):
145         (WTR::AccessibilityUIElement::documentURI):
146         (WTR::AccessibilityUIElement::isFocusable):
147         (WTR::AccessibilityUIElement::isSelectable):
148         (WTR::AccessibilityUIElement::isMultiSelectable):
149         (WTR::AccessibilityUIElement::isVisible):
150
151 2013-05-20  Lucas Forschler  <lforschler@apple.com>
152
153     Rollout 150398.
154     
155 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
156
157         [GTK] Fix concatenations of string literals that are not C++11-compliant
158         https://bugs.webkit.org/show_bug.cgi?id=116449
159
160         Reviewed by Martin Robinson.
161
162         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
163         is simply a matter of separating the string and the string literal that are being concatenated with a space.
164
165         * ImageDiff/gtk/ImageDiff.cpp:
166         (printImage):
167
168 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
169
170         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
171         https://bugs.webkit.org/show_bug.cgi?id=116450
172
173         Reviewed by Martin Robinson.
174
175         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
176         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
177         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
178         TestWebKitAPI programs when compiling them.
179
180         * TestWebKitAPI/GNUmakefile.am:
181
182 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
183
184         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
185         https://bugs.webkit.org/show_bug.cgi?id=116492
186
187         Reviewed by Dirk Pranke.
188
189         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
190
191         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
192         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
193         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
194         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
195         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
196         to memory pressure on the machine.
197
198         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
199         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
200         for a subsequent patch just to make things easier to follow.
201
202         * Scripts/webkitpy/port/driver.py:
203         (DriverProxy.__init__):
204         (DriverProxy.run_test):
205         (DriverProxy.has_crashed):
206         (DriverProxy.stop):
207
208 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
209
210         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
211         https://bugs.webkit.org/show_bug.cgi?id=116423
212
213         Reviewed by Ryosuke Niwa.
214
215         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
216
217         * BuildSlaveSupport/build.webkit.org-config/config.json:
218
219 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
220
221         Remove remaining link-prerender code
222         https://bugs.webkit.org/show_bug.cgi?id=116429
223
224         Reviewed by Darin Adler.
225
226         Link prerendering code was removed in r150356.
227
228         * Scripts/webkitperl/FeatureList.pm:
229         * qmake/mkspecs/features/features.pri:
230
231 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
232
233         commit-queue should check for oops in changelog entries
234         https://bugs.webkit.org/show_bug.cgi?id=116395
235
236         Reviewed by Martin Robinson.
237
238         Make changelog validation fail when it contains oops!.
239
240         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
241         (CommitQueueTask._validate_changelog):
242         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
243         (CommitQueueTaskTest._run_through_task):
244         * Scripts/webkitpy/tool/commands/queues_unittest.py:
245         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
246         (ValidateChangeLogs.options):
247         (ValidateChangeLogs._check_changelog_diff):
248         (ValidateChangeLogs._changelog_contains_oops):
249         (ValidateChangeLogs.run):
250         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
251         (ValidateChangeLogsTest._assert_start_line_produces_output):
252         (ValidateChangeLogsTest.test_check_changelog_diff):
253         (ValidateChangeLogsTest):
254         (ValidateChangeLogsTest.test_changelog_contains_oops):
255
256 2013-05-20  Jessie Berlin  <jberlin@apple.com>
257
258         Expose a way to know when forms are added to a page or when form controls are added to a form
259         in the injected bundle
260         https://bugs.webkit.org/show_bug.cgi?id=116334
261
262         Reviewed by Alexey Proskuryakov.
263
264         Add tests for the new callbacks.
265
266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
267         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
268
269         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
270         (TestWebKitAPI::nullJavaScriptCallback):
271         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
272         being passed in for the callback.
273         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
274         After receiving the message that didAssociateFormControls callback was invoked from adding
275         the form in the onload handler, tell the page to add a password field to the form, which
276         should also invoke didAssociateFormControls callback.
277         (TestWebKitAPI::setInjectedBundleClient):
278         Register to receive messages.
279         (TestWebKitAPI::TEST):
280         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
281         been invoked for both adding the form and for adding a password field to the form.
282
283         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
284         (TestWebKitAPI::shouldNotifyOnFormChanges):
285         Return true so the didAssociateFormControls callback is invoked.
286         (TestWebKitAPI::didAssociateFormControls):
287         Tell the UI process.
288         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
289         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
290         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
291
292         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
293         Add a form in response to the onload event. Add a button that will add the password field
294         for manual testing.
295
296 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
297
298         [EFL][JHBUILD] Make sure eet is built before evas
299         https://bugs.webkit.org/show_bug.cgi?id=116440
300
301         Reviewed by Gyuyoung Kim.
302
303         Mark eet as a dependency of evas since evas requires eet to enable some of its
304         functionality.
305
306         * efl/jhbuild.modules:
307
308 2013-05-20  Alex Christensen  <achristensen@apple.com>
309
310         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
311         https://bugs.webkit.org/show_bug.cgi?id=116125
312
313         Reviewed by Tim Horton.
314
315         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
316         (WTR::pathSuitableForTestResult):
317         Changed string operations to match _drt_descriptionSuitableForTestResult.
318         (WTR::dumpRequestDescriptionSuitableForTestResult):
319         (WTR::dumpResponseDescriptionSuitableForTestResult):
320         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
321         (WTR::InjectedBundlePage::didInitiateLoadForResource):
322         (WTR::InjectedBundlePage::willSendRequestForFrame):
323         (WTR::InjectedBundlePage::didReceiveResponseForResource):
324         Pass the main frame's URL to pathSuitableForTestResult.
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
326         Added WKBundlePageRef to willPerformClientRedirectForFrame.
327
328 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
329
330         fix w3c test importer unit tests after r150324
331         https://bugs.webkit.org/show_bug.cgi?id=116459
332
333         Reviewed by Ryosuke Niwa.
334
335         This patch fixes the unit tests to not actually call out to
336         'hg' (by using a mock executive) and also changes the real
337         directory we crawl from Source/WebCore/css to
338         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
339         still change this to a mock filesystem, but that's a separate change.
340
341         * Scripts/webkitpy/w3c/test_importer.py:
342         (main):
343         (TestImporter.__init__):
344         (TestImporter.load_changeset):
345         * Scripts/webkitpy/w3c/test_importer_unittest.py:
346         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
347         (TestImporterTest.test_import_dir_with_no_tests):
348
349 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
350
351         Unreviewed EFL build fix.
352
353         Fix linking errors due to undefined symbols on Ubuntu 13.04.
354
355         * DumpRenderTree/efl/CMakeLists.txt:
356         * EWebLauncher/CMakeLists.txt:
357         * MiniBrowser/efl/CMakeLists.txt:
358
359 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
360
361         [EFL] Reenabled INDEXED_DATABASE after r150344
362         https://bugs.webkit.org/show_bug.cgi?id=116430
363
364         Reviewed by Gyuyoung Kim.
365
366         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
367         build was fixed in r150344.
368
369         * Scripts/webkitperl/FeatureList.pm:
370
371 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
372
373         [EFL] init/shutdown should be paired in EWebLauncher
374         https://bugs.webkit.org/show_bug.cgi?id=116427
375
376         Reviewed by Christophe Dumez.
377
378         Added ecore_file_shutdown() for cleanup of ecore_file.
379         Removed edje_init and ecore_evas_init because it was in ewk_init().
380
381         * EWebLauncher/main.c:
382         (main):
383
384 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
385
386         [EFL] Add command line option to MiniBrowser to set user agent
387         https://bugs.webkit.org/show_bug.cgi?id=116387
388
389         Reviewed by Christophe Dumez.
390
391         We need this option to compare the rendering differences according to different user agents.
392
393         * MiniBrowser/efl/main.c:
394         (window_create):
395         (elm_main):
396
397 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
398
399         Unreviewed, addressing test-webkitpy failures after r150317.
400
401         * Scripts/webkitpy/w3c/test_converter.py:
402         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
403
404 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
405
406         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
407         https://bugs.webkit.org/show_bug.cgi?id=114554
408
409         Reviewed by Gyuyoung Kim.
410
411         Using variables as target names is very uncommon in CMake.
412         The usual way to specify the name of the resulting binary
413         is to set the OUTPUT_NAME target property.
414
415         * DumpRenderTree/efl/CMakeLists.txt:
416         * EWebLauncher/CMakeLists.txt:
417         * ImageDiff/CMakeLists.txt:
418         * MiniBrowser/efl/CMakeLists.txt:
419         * TestWebKitAPI/CMakeLists.txt:
420         * WebKitTestRunner/CMakeLists.txt:
421         * WebKitTestRunner/PlatformEfl.cmake:
422         * WinCELauncher/CMakeLists.txt:
423
424 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
425
426         Unreviewed EFL build fix.
427
428         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
429         WK2 build after r150305.
430
431         * Scripts/webkitperl/FeatureList.pm:
432
433 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
434
435         [GTK] Parallel build fails if gtk-doc is enabled
436         https://bugs.webkit.org/show_bug.cgi?id=116227
437
438         Reviewed by Martin Robinson.
439
440         * GNUmakefile.am:
441         Don't use the 'all' target to generate the documentation.
442         The prerequisites of this target must be files that need to be
443         built _before_ the actual compilation of WebKit starts. Since the
444         documentation depends on WebKit being built first, this means in
445         practice that the code will be built in parallel with the
446         generation of its dependencies, potentially making the build fail.
447
448 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
449
450         Don't run hg.
451
452         * Scripts/webkitpy/w3c/test_importer_unittest.py:
453         (TestImporterTest):
454
455 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
456
457         Create a script to import W3C tests
458         https://bugs.webkit.org/show_bug.cgi?id=111513
459
460         Reviewed by Ryosuke Niwa.
461
462         This patch attempts to re-land the 'import-w3c-tests'
463         script and accompanying modules.  The tests and code have
464         been cleaned up so that we do not log anything to stdout/stderr
465         while running the tests (thanks to outputcapture) and do not
466         write into the source tree while running the tests, and much
467         but not all of the code has been converted over to using the webkitpy
468
469         * Scripts/import-w3c-tests: Added.
470         * Scripts/webkitpy/w3c/__init__.py: Added.
471         * Scripts/webkitpy/w3c/test_converter.py: Added.
472         (W3CTestConverter):
473         (W3CTestConverter.__init__):
474         (W3CTestConverter.path_from_webkit_root):
475         (W3CTestConverter.read_webkit_prefixed_css_property_list):
476         (W3CTestConverter.convert_for_webkit):
477         (W3CTestConverter.convert_css):
478         (W3CTestConverter.convert_html):
479         (W3CTestConverter.convert_testharness_paths):
480         (W3CTestConverter.convert_prefixed_properties):
481         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
482         (W3CTestConverter.replace_tag):
483         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
484         (W3CTestConverterTest):
485         (W3CTestConverterTest.fake_dir_path):
486         (W3CTestConverterTest.test_read_prefixed_property_list):
487         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
488         (test_convert_for_webkit_harness_only):
489         (test_convert_for_webkit_properties_only):
490         (test_convert_for_webkit_harness_and_properties):
491         (test_convert_test_harness_paths):
492         (test_convert_prefixed_properties):
493         (verify_conversion_happened):
494         (verify_no_conversion_happened):
495         (verify_test_harness_paths):
496         (verify_prefixed_properties):
497         (generate_test_content):
498         * Scripts/webkitpy/w3c/test_importer.py: Added.
499         (main):
500         (parse_args):
501         (validate_import_directory):
502         (TestImporter):
503         (TestImporter.__init__):
504         (TestImporter.path_from_webkit_root):
505         (TestImporter.do_import):
506         (TestImporter.load_changeset):
507         (TestImporter.find_importable_tests):
508         (TestImporter.import_tests):
509         (TestImporter.setup_destination_directory):
510         (TestImporter.update_test_status):
511         (TestImporter.remove_deleted_files):
512         (TestImporter.write_import_log):
513         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
514         (TestImporterTest):
515         (TestImporterTest.test_import_dir_with_no_tests):
516         * Scripts/webkitpy/w3c/test_parser.py: Added.
517         (TestParser):
518         (TestParser.__init__):
519         (TestParser.load_file):
520         (TestParser.analyze_test):
521         (TestParser.reference_links_of_type):
522         (TestParser.is_jstest):
523         (TestParser.support_files):
524         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
525         (TestParserTest):
526         (TestParserTest.test_analyze_test_reftest_one_match):
527         (test_analyze_test_reftest_multiple_matches):
528         (test_analyze_test_reftest_match_and_mismatch):
529         (test_analyze_test_reftest_with_ref_support_Files):
530         (test_analyze_jstest):
531         (test_analyze_pixel_test_all_true):
532         (test_analyze_pixel_test_all_false):
533         (test_analyze_non_html_file):
534
535 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
536
537         Leaks builders exit early frequently
538         https://bugs.webkit.org/show_bug.cgi?id=116355
539
540         Reviewed by Stephanie Lewis.
541
542         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
543         we tolerate from 20 to 50.
544
545         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
546         (RunWebKitTests.start):
547         * Scripts/webkitpy/port/mac.py:
548         (MacPort.default_child_processes):
549
550 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
551
552         Remove chrome-channels command from the webkit-patch
553         https://bugs.webkit.org/show_bug.cgi?id=116303
554
555         Reviewed by Ryosuke Niwa.
556
557         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
558         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
559         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
560         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
561         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
562         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
563
564 2013-05-17  David Kilzer  <ddkilzer@apple.com>
565
566         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
567         Part 3 of 3: <http://webkit.org/b/116247>
568
569         Reviewed by Benjamin Poulain.
570
571         * Scripts/filter-build-webkit: Change while() loop to for() loop
572         to track $previousLine, then pass $previousLine into
573         shouldIgnoreLine().
574         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
575         line that begins with four spaces if the previous line is a
576         linker error message.
577         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
578         - Add "Ignored: " to test descriptions to document expected
579           behavior.
580         - Add comment blocks for various groups of tests.
581         - Expand "Build settings" tests since we're changing the code in
582           shouldIgnoreLine() that ignores those lines.
583         - Add tests for undefined symbols error message.
584         (description): Add.  Extract from global code.
585
586 2013-05-17  David Kilzer  <ddkilzer@apple.com>
587
588         Add tests for shouldIgnoreLine() in filter-build-webkit
589         Part 2 of 3: <http://webkit.org/b/116247>
590
591         Reviewed by Benjamin Poulain.
592
593         * Scripts/filter-build-webkit:
594         (shouldIgnoreLine): Add.  Extract code from global scope into
595         subroutine to make it testable.
596         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
597         Tests shouldIgnoreLine() using output from a real build
598         transcript.
599
600 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
601
602         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
603         https://bugs.webkit.org/show_bug.cgi?id=116341
604
605         Reviewed by Brady Eidson.
606
607         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
608
609 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
610
611         [Windows] Don't use pdevenv when building with VS2010.
612         https://bugs.webkit.org/show_bug.cgi?id=116338.
613
614         Reviewed by Adam Roben.
615
616         * Scripts/webkitdirs.pm:
617         (setupCygwinEnv): Check if we are using VS2005, and only use
618         the 'pdevenv' hack if we are. Otherwise, just build with
619         our standard project since it uses VS2010+'s native
620         parallel building features.
621
622 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
623
624         Unreviewed. Disable accelerated compositing until we figure out why it does not work
625         properly in the 64 bits release bot.
626
627         * DumpRenderTree/gtk/DumpRenderTree.cpp:
628         (resetDefaultsToConsistentValues):
629
630 2013-05-17  David Kilzer  <ddkilzer@apple.com>
631
632         Make filter-build-webkit testable using LoadAsModule
633         Part 1 of 3: <http://webkit.org/b/116247>
634
635         Reviewed by Benjamin Poulain.
636
637         * Scripts/filter-build-webkit: Change global variables that are
638         used in subroutines from 'my' to 'our' to make it possible to
639         evaluate the script in a package context in LoadAsModule.pm.
640
641 2013-05-14  Sam Weinig  <sam@webkit.org>
642
643         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
644         https://bugs.webkit.org/show_bug.cgi?id=116132
645
646         Reviewed by Anders Carlsson.
647
648         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
649         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
650
651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
652         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
653         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
654         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
655
656 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
657
658         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
659         https://bugs.webkit.org/show_bug.cgi?id=114781
660
661         Reviewed by Christophe Dumez.
662
663         Add run_before_unload_confirm and
664         Print the log message with "CONFIRM NAVIGATION: " in console.
665
666         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
667         (onBeforeUnloadConfirm):
668         (drtViewAdd):
669
670 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
671
672         Fix Analyze ChangeLog's entry processing
673         https://bugs.webkit.org/show_bug.cgi?id=116219
674
675         Reviewed by Ryosuke Niwa.
676
677         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
678         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
679
680 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
681
682         [Qt] UrlLoader::loadNext is broken in MiniBrowser
683         https://bugs.webkit.org/show_bug.cgi?id=116099
684
685         Reviewed by Jocelyn Turcotte.
686
687         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
688         are not available any more. So, UrlLoader::loadNext was broken
689         because it failed to connect to those signals.
690
691         * MiniBrowser/qt/UrlLoader.cpp:
692         (UrlLoader::UrlLoader):
693         (UrlLoader::loadingChanged):
694         * MiniBrowser/qt/UrlLoader.h:
695         (UrlLoader):
696
697 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
698
699         [WebSocket] Update pywebsocket to r760
700         https://bugs.webkit.org/show_bug.cgi?id=115863
701
702         Reviewed by Alexey Proskuryakov.
703
704         Version r760 supports a newer draft of message compression.
705         We need this update to finish the permessage compression patch in
706         bug 98840. This patch also fixes failing unit tests after the update.
707
708         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
709         (StreamBase._read):
710         (StreamBase._read.of):
711         (StreamBase._write):
712         (StreamBase.receive_bytes):
713         (StreamBase._read_until):
714         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
715         (parse_frame):
716         (StreamOptions.__init__):
717         (Stream.__init__):
718         (Stream._receive_frame_as_frame_object):
719         (Stream._get_message_from_frame):
720         (Stream._process_close_message):
721         (Stream.close_connection):
722         (Stream.get_last_received_opcode):
723         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
724         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
725         (Dispatcher.do_extra_handshake):
726         (Dispatcher.transfer_data):
727         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
728         (ExtensionProcessorInterface.__init__):
729         (ExtensionProcessorInterface.request):
730         (ExtensionProcessorInterface):
731         (ExtensionProcessorInterface.name):
732         (ExtensionProcessorInterface.check_consistency_with_other_processors):
733         (ExtensionProcessorInterface.set_active):
734         (ExtensionProcessorInterface.is_active):
735         (ExtensionProcessorInterface._get_extension_response_internal):
736         (ExtensionProcessorInterface.get_extension_response):
737         (ExtensionProcessorInterface._setup_stream_options_internal):
738         (ExtensionProcessorInterface.setup_stream_options):
739         (_log_outgoing_compression_ratio):
740         (_log_incoming_compression_ratio):
741         (_parse_window_bits):
742         (_AverageRatioCalculator):
743         (_AverageRatioCalculator.__init__):
744         (_AverageRatioCalculator.add_original_bytes):
745         (_AverageRatioCalculator.add_result_bytes):
746         (_AverageRatioCalculator.get_average_ratio):
747         (DeflateFrameExtensionProcessor):
748         (DeflateFrameExtensionProcessor.__init__):
749         (DeflateFrameExtensionProcessor._get_extension_response_internal):
750         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
751         (DeflateFrameExtensionProcessor._outgoing_filter):
752         (DeflateFrameExtensionProcessor._incoming_filter):
753         (CompressionExtensionProcessorBase.for):
754         (CompressionExtensionProcessorBase.__init__):
755         (CompressionExtensionProcessorBase._get_extension_response_internal):
756         (CompressionExtensionProcessorBase._setup_stream_options_internal):
757         (PerFrameCompressExtensionProcessor):
758         (PerMessageDeflateExtensionProcessor):
759         (PerMessageDeflateExtensionProcessor.__init__):
760         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
761         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
762         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
763         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
764         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
765         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
766         (PerMessageDeflateExtensionProcessor.set_bfinal):
767         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
768         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
769         (_PerMessageDeflateFramer):
770         (_PerMessageDeflateFramer.__init__):
771         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
772         (_PerMessageDeflateFramer._process_incoming_message):
773         (_PerMessageDeflateFramer._process_outgoing_message):
774         (_PerMessageDeflateFramer.setup_stream_options):
775         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
776         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
777         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
778         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
779         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
780         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
781         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
782         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
783         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
784         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
785         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
786         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
787         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
788         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
789         (PerMessageCompressExtensionProcessor):
790         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
791         (MuxExtensionProcessor.__init__):
792         (MuxExtensionProcessor.check_consistency_with_other_processors):
793         (MuxExtensionProcessor):
794         (MuxExtensionProcessor._get_extension_response_internal):
795         (MuxExtensionProcessor._setup_stream_options_internal):
796         (MuxExtensionProcessor.set_quota):
797         (MuxExtensionProcessor.quota):
798         (MuxExtensionProcessor.set_extensions):
799         (MuxExtensionProcessor.extensions):
800         (is_compression_extension):
801         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
802         (validate_subprotocol):
803         (parse_host_header):
804         (format_header):
805         (check_request_line):
806         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
807         (Handshaker.do_handshake):
808         (Handshaker._create_handshake_response):
809         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
810         (_validate_subprotocol):
811         (_check_header_lines):
812         (_build_location):
813         (Handshaker.do_handshake):
814         (Handshaker._set_subprotocol):
815         (Handshaker._set_location):
816         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
817         (_create_dispatcher):
818         (headerparserhandler):
819         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
820         (_create_add_channel_response):
821         (_create_drop_channel):
822         (_create_flow_control):
823         (_create_new_channel_slot):
824         (_create_fallback_new_channel_slot):
825         (_MuxFramePayloadParser._read_number):
826         (_MuxFramePayloadParser._read_size_and_contents):
827         (_MuxFramePayloadParser._read_flow_control):
828         (_MuxFramePayloadParser._read_new_channel_slot):
829         (_LogicalConnection.__init__):
830         (_LogicalConnection.write):
831         (_LogicalConnection.on_write_data_done):
832         (_LogicalConnection):
833         (_LogicalConnection.on_writer_done):
834         (_InnerMessage):
835         (_InnerMessage.__init__):
836         (_InnerMessageBuilder):
837         (_InnerMessageBuilder.that):
838         (_InnerMessageBuilder.__init__):
839         (_InnerMessageBuilder._handle_first):
840         (_InnerMessageBuilder._process_first_fragmented_control):
841         (_InnerMessageBuilder._process_first_fragmented_message):
842         (_InnerMessageBuilder._handle_fragmented_control):
843         (_InnerMessageBuilder._reassemble_fragmented_control):
844         (_InnerMessageBuilder._handle_fragmented_message):
845         (_InnerMessageBuilder._reassemble_fragmented_message):
846         (_InnerMessageBuilder.build):
847         (_LogicalStream.__init__):
848         (_LogicalStream._create_inner_frame):
849         (_LogicalStream._write_inner_frame):
850         (_LogicalStream.replenish_send_quota):
851         (_LogicalStream.send_message):
852         (_LogicalStream._receive_frame):
853         (_LogicalStream._get_message_from_frame):
854         (_LogicalStream.stop_sending):
855         (_PhysicalConnectionWriter.__init__):
856         (_PhysicalConnectionWriter._write_data):
857         (_PhysicalConnectionWriter.run):
858         (_PhysicalConnectionWriter.stop):
859         (_Worker.run):
860         (_MuxHandshaker.__init__):
861         (_MuxHandshaker._create_stream):
862         (_MuxHandshaker._create_handshake_response):
863         (_HandshakeDeltaBase.create_headers):
864         (_MuxHandler.start):
865         (_MuxHandler.wait_until_done):
866         (_MuxHandler.notify_write_data_done):
867         (_MuxHandler._process_drop_channel):
868         (_MuxHandler._process_logical_frame):
869         (_MuxHandler.notify_reader_done):
870         (_MuxHandler):
871         (_MuxHandler.notify_writer_done):
872         (_MuxHandler.fail_physical_connection):
873         (_MuxHandler.fail_logical_channel):
874         (use_mux):
875         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
876         (_StandaloneRequest.get_uri):
877         (_StandaloneRequest.get_unparsed_uri):
878         (_StandaloneRequest):
879         (_StandaloneRequest.is_https):
880         (_import_ssl):
881         (_import_pyopenssl):
882         (_StandaloneSSLConnection.for):
883         (_StandaloneSSLConnection):
884         (_StandaloneSSLConnection.__getattribute__):
885         (_StandaloneSSLConnection.__setattr__):
886         (_StandaloneSSLConnection.makefile):
887         (_StandaloneSSLConnection.shutdown):
888         (_StandaloneSSLConnection.recv):
889         (WebSocketServer.__init__):
890         (WebSocketServer._create_sockets):
891         (WebSocketServer.handle_error):
892         (WebSocketServer.get_request):
893         (WebSocketServer.get_request.default_callback):
894         (WebSocketRequestHandler.parse_request):
895         (_build_option_parser):
896         (_main):
897         (_main.if):
898         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
899         (RepeatedXorMasker.__init__):
900         (RepeatedXorMasker._mask_using_swig):
901         (RepeatedXorMasker):
902         (RepeatedXorMasker._mask_using_array):
903         (_Deflater.compress_and_finish):
904         (_RFC1979Deflater.filter):
905         (DeflateSocket.send):
906
907 2013-05-16  Jonathan Liu  <net147@gmail.com>
908
909         Fix testing if program exists in PATH
910         https://bugs.webkit.org/show_bug.cgi?id=116216
911
912         Reviewed by Jocelyn Turcotte.
913
914         functions.prf incorrectly uses win_cmd_shell to test whether to
915         add .exe to the executable name when checking if it exists in
916         the PATH environment variable. This works correctly when
917         building using Windows Command Prompt but not under MSYS shell.
918
919         To resolve this, check the win32 platform scope instead of
920         win_cmd_shell so that it correctly adds .exe to the executable
921         name on Windows regardless of the shell used when testing if
922         it exists in PATH.
923
924         * qmake/mkspecs/features/functions.prf:
925
926 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
927
928         Fix the hard-coded names of EWS bots that run tests.
929
930         * Scripts/webkitpy/tool/commands/queues.py:
931         (CommitQueue.did_pass_testing_ews):
932
933 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
934
935         [GTK] Build Xvfb with jhbuild
936         https://bugs.webkit.org/show_bug.cgi?id=115907
937
938         Reviewed by Martin Robinson.
939
940         Build our own Xvfb so that we can avoid problems with the system Xvfb
941         relying on symbols not present in our jhbuilt libraries such as pixman,
942         and also to ensure we have the fix for a GLX module crasher.
943
944         * DumpRenderTree/gtk/DumpRenderTree.cpp:
945         (resetDefaultsToConsistentValues): enable accelerated compositing.
946         * gtk/install-dependencies: list packages required for building Xvfb.
947         * gtk/jhbuild.modules: add xserver as a jhbuild module.
948         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
949         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
950         initializing the GLX module for Xvfb.
951
952 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
953
954         [jhbuild] Should remove the sources directory as well when cleaning
955         https://bugs.webkit.org/show_bug.cgi?id=116229
956
957         Reviewed by Martin Robinson.
958
959         * Scripts/update-webkit-libs-jhbuild:
960         (cleanJhbuild): remove the Source directory as well when cleaning.
961
962 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
963
964         [EFL] Remove Intel Wk2 Buildbots from Master
965         https://bugs.webkit.org/show_bug.cgi?id=116149
966
967         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
968         since Gyuyoung Kim from Samsung plans to take over and maintain it.
969
970         Reviewed by Benjamin Poulain.
971
972         * BuildSlaveSupport/build.webkit.org-config/config.json:
973
974 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
975
976         [Windows] Update various build tools to understand VS2010 environment.
977         https://bugs.webkit.org/show_bug.cgi?id=116169.
978
979         Reviewed by Anders Carlsson.
980
981         * Scripts/build-api-tests: Identify VS2010 environment.
982         * Scripts/build-dumprendertree: Ditto.
983         * Scripts/build-webkit: Ditto.
984         * Scripts/webkitdirs.pm:
985         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
986         range of acceptable SDK's.
987
988 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
989
990         Allow http tests on Arch Linux
991         https://bugs.webkit.org/show_bug.cgi?id=116155
992
993         Reviewed by Ryosuke Niwa.
994
995         * Scripts/webkitpy/port/base.py:
996         (Port._is_arch_based): Added check for /etc/arch-release file.
997         (Port._apache_config_file_name_for_platform): Call the check.
998         * Scripts/webkitpy/port/port_testcase.py:
999         (test_linux_distro_detection): Testcase added.
1000
1001 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1002
1003         Remove a leftover v8 file from the watchlist
1004         https://bugs.webkit.org/show_bug.cgi?id=116158
1005
1006         Reviewed by Csaba Osztrogonác.
1007
1008         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1009
1010 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1011
1012         [GTK] Fails to build while generating gtkdoc
1013         https://bugs.webkit.org/show_bug.cgi?id=115612
1014
1015         Reviewed by Philippe Normand.
1016
1017         Fix typo in the prerequisites of docs-build.stamp.
1018
1019         * GNUmakefile.am:
1020
1021 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1022
1023         Unreviewed, fixing the current test-webkitpy failure.
1024
1025         * Scripts/webkitpy/port/mac_unittest.py:
1026         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1027         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1028
1029 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1030
1031         Fix build after r150090.
1032         https://bugs.webkit.org/show_bug.cgi?id=116129
1033
1034         Unreviewed build fix after r150090.
1035
1036         * WebKitTestRunner/TestInvocation.cpp:
1037         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1038
1039 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1040
1041         [Windows, others] Unreviewed build fix after r150090.
1042
1043         * DumpRenderTree/TestRunner.cpp:
1044         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1045         doesn't exist on other platforms.
1046
1047 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1048
1049         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1050         https://bugs.webkit.org/show_bug.cgi?id=115889
1051
1052         Reviewed by Benjamin Poulain.
1053
1054         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1055         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1056
1057 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1058
1059         [Windows] Identify proper run environment for scripts.
1060         https://bugs.webkit.org/show_bug.cgi?id=116114
1061
1062         Reviewed by David Kilzer.
1063
1064         Determine (based on Visual Studio version) which path to use for
1065         executables (bin versus bin32).
1066
1067         * Scripts/webkitdirs.pm:
1068         (determineVisualStudioInstallDir): Added.
1069         (determineVisualStudioVersion): Added.
1070         (determineConfigurationProductDir): Modified to choose proper bin
1071         or bin32 directory.
1072         (visualStudioVersion): Added
1073         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1074
1075 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1076
1077         [Mac] Add tests for secure event input
1078         https://bugs.webkit.org/show_bug.cgi?id=116121
1079
1080         Reviewed by Mark Rowe.
1081
1082         * DumpRenderTree/TestRunner.cpp:
1083         (getSecureEventInputIsEnabledCallback):
1084         (TestRunner::staticValues):
1085         Expose an accessor for current secure event input state.
1086
1087         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1088         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1089         (WTR::TestRunner::secureEventInputIsEnabled):
1090         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1091         * WebKitTestRunner/TestInvocation.cpp:
1092         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1093         Expose an accessor for current secure event input state. This has to be done in
1094         UI process, as this is where it's changed by WebKit.
1095
1096 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1097
1098         [Mac] Add a testing shim for secure event input functions
1099         https://bugs.webkit.org/show_bug.cgi?id=116122
1100
1101         Reviewed by Mark Rowe.
1102
1103         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1104         Inject WebCore testing shim library to override system framework functions.
1105
1106 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1107
1108         [Windows] Switch to embedded manifest commands for launcher executables.
1109         https://bugs.webkit.org/show_bug.cgi?id=116109
1110
1111         Reviewed by Darin Adler.
1112
1113         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1114         now-unused WinLauncher.exe.manifest file.
1115         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1116         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1117         when building with VS2010 or newer.
1118
1119 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1120
1121         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1122         https://bugs.webkit.org/show_bug.cgi?id=116079
1123
1124         Reviewed by David Kilzer.
1125
1126         * Scripts/old-run-webkit-tests:
1127         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1128
1129 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1130
1131         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1132         https://bugs.webkit.org/show_bug.cgi?id=115921
1133
1134         Reviewed by Gustavo Noronha Silva.
1135
1136         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1137         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1138
1139 2013-05-13  Alex Christensen  <achristensen@apple.com>
1140
1141         Added testRunner.setPrinting.
1142         https://bugs.webkit.org/show_bug.cgi?id=42693
1143         rdar://problem/8213845
1144
1145         Reviewed by Darin Adler.
1146
1147         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1148         Added setPrinting JavaScript function.
1149         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1150         (WTR::InjectedBundlePage::dump):
1151         Dump the external representation for printing if setPrinting has been called.
1152         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1153         (WTR::TestRunner::isPrinting): Added.
1154         (WTR::TestRunner::setPrinting): Added.
1155         Added and initialized m_isPrinting member boolean.
1156
1157 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1158
1159         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1160         https://bugs.webkit.org/show_bug.cgi?id=116016
1161
1162         Reviewed by Dirk Pranke.
1163
1164         Same fix as in the upstream style checker, but without hg support.
1165         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1166
1167         * Scripts/webkitpy/style/checkers/cpp.py:
1168         (FileInfo.repository_name):
1169
1170 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1171
1172         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1173         https://bugs.webkit.org/show_bug.cgi?id=115918
1174
1175         Reviewed by Gustavo Noronha Silva.
1176
1177         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1178         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1179         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1180         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1181         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1182         problems.
1183
1184         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1185         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1186         file paths are constructed and then used to dump the member files from these archives. The member files are
1187         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1188         successfully link.
1189
1190         * TestWebKitAPI/GNUmakefile.am:
1191
1192 2013-05-13  Anders Carlsson  <andersca@apple.com>
1193
1194         Remove UnusedParam.h
1195         https://bugs.webkit.org/show_bug.cgi?id=116029
1196
1197         Reviewed by Andreas Kling.
1198
1199         Stop including UnusedParam.h.
1200
1201         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1202         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1203
1204 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1205
1206         Unreviewed, rolling out r149955.
1207         http://trac.webkit.org/changeset/149955
1208         https://bugs.webkit.org/show_bug.cgi?id=115990
1209
1210         Broke lots of tests (Requested by smfr on #webkit).
1211
1212         * Scripts/webkitpy/port/mac.py:
1213
1214 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1215
1216         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1217         https://bugs.webkit.org/show_bug.cgi?id=115914
1218
1219         Reviewed by Martin Robinson.
1220
1221         * GtkLauncher/main.c:
1222         (createToolbar):
1223         * MiniBrowser/gtk/BrowserWindow.c:
1224         (_BrowserWindow):
1225         (browserWindowSetStatusText):
1226         (fullScreenMessageTimeoutCallback):
1227         (webViewEnterFullScreen):
1228         (webViewLeaveFullScreen):
1229         (browserWindowFinalize):
1230         (browserWindowConstructed):
1231         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1232         (WTR::EventSenderProxy::mouseScrollBy):
1233         (WTR::EventSenderProxy::continuousMouseScrollBy):
1234
1235 2013-05-11  Anders Carlsson  <andersca@apple.com>
1236
1237         Crash when terminating a process that has not been fully launched
1238         https://bugs.webkit.org/show_bug.cgi?id=115962
1239         <rdar://problem/13660916>
1240
1241         Reviewed by Andreas Kling.
1242
1243         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1244         before the process has had a chance to be fully launched.
1245
1246         * TestWebKitAPI/GNUmakefile.am:
1247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1248         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1249         (TestWebKitAPI):
1250         (TestWebKitAPI::didFinishLoadForFrame):
1251         (TestWebKitAPI::TEST):
1252         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1253
1254 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1255
1256         Remove Mac OS X Leopard (10.5) support
1257         https://bugs.webkit.org/show_bug.cgi?id=107964
1258
1259         Reviewed by Ryosuke Niwa.
1260
1261         Removed the code for 10.5 and removed if-def for 10.6.
1262
1263         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1264         (convertMIMEType):
1265         (createXMLStringFromWebArchiveData):
1266         * DumpRenderTree/mac/TestRunnerMac.mm:
1267         (TestRunner::authenticateSession):
1268         (TestRunner::setTextDirection):
1269         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1270         (convertMIMEType):
1271         (createXMLStringFromWebArchiveData):
1272
1273 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1274
1275         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1276         https://bugs.webkit.org/show_bug.cgi?id=115935
1277
1278         Reviewed by Jer Noble.
1279
1280         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1281         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1282         to the new manifest file.
1283         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1284
1285 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1286
1287         Fix some compiler warnings (miscellaneous)
1288         https://bugs.webkit.org/show_bug.cgi?id=80790
1289
1290         Reviewed by Rob Buis.
1291
1292         Fix the following warnings for BlackBerry:
1293         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1294         used as truth value [-Wparentheses].
1295
1296         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1297         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1298
1299 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1300
1301         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1302         https://bugs.webkit.org/show_bug.cgi?id=115928
1303
1304         Reviewed by Kenneth Rohde Christiansen.
1305
1306         WKViewSetThemePath was moved to WKViewEfl.h.
1307
1308         * TestWebKitAPI/efl/PlatformWebView.cpp:
1309
1310 2013-05-10  Andreas Kling  <akling@apple.com>
1311
1312         I accidentally the Java testing.
1313
1314         * Scripts/webkitpy/port/mac.py:
1315
1316 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1317
1318         [GTK] Module Cairo fails to build under jhbuild
1319         https://bugs.webkit.org/show_bug.cgi?id=115854
1320
1321         Reviewed by Martin Robinson.
1322
1323         Make cairo depend on glib in jhbuild.modules.
1324
1325         * gtk/jhbuild.modules:
1326
1327 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1328
1329         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1330         https://bugs.webkit.org/show_bug.cgi?id=115904
1331
1332         Reviewed by Martin Robinson.
1333
1334         * ImageDiff/gtk/ImageDiff.cpp:
1335         (main):
1336
1337 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1338
1339         Add my new address to contributors.json. (Unreviewed)
1340
1341         * Scripts/webkitpy/common/config/contributors.json:
1342
1343 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1344
1345         Unreviewed. Move myself to the reviewers list.
1346
1347         * Scripts/webkitpy/common/config/contributors.json:
1348
1349 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1350
1351         Unreviewed. Add my email to a few watchlists.
1352
1353         * Scripts/webkitpy/common/config/watchlist:
1354
1355 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1356
1357         Unicode support missing from string representation of Contributors in committers.py
1358         https://bugs.webkit.org/show_bug.cgi?id=115859
1359
1360         Reviewed by Darin Adler.
1361
1362         Contributors, in committers.py, provided a string representation in __str__ which
1363         didn't support unicode characters, so printing a contributor would fail in that case.
1364         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1365         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1366
1367         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1368         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1369         representation.
1370         (Contributor.__str__):
1371         (Contributor):
1372         (Contributor.__unicode__):
1373         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1374         a contributor with unicode characters can be represented as a string.
1375         (CommittersTest):
1376         (CommittersTest.test_contributor_encoding):
1377
1378 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1379
1380         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1381         https://bugs.webkit.org/show_bug.cgi?id=92371
1382
1383         Reviewed by Brent Fulgham.
1384
1385         Use JavaScriptThreading.cpp where the same functionality is
1386         implemented too. This reduces the dependency on the pthread
1387         library. Also replace assert() with WebKit ASSERT().
1388
1389         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1390         * DumpRenderTree/win/DumpRenderTree.cpp:
1391         (dumpHistoryItem):
1392         (dumpBackForwardList):
1393         * DumpRenderTree/win/DumpRenderTree.vcproj:
1394
1395 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1396
1397         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1398         https://bugs.webkit.org/show_bug.cgi?id=92505
1399
1400         Reviewed by Brent Fulgham.
1401
1402         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1403         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1404         (javaScriptThreadsMutex):
1405         (javaScriptThreads):
1406         (runJavaScriptThread):
1407         (startJavaScriptThreads):
1408         (stopJavaScriptThreads):
1409         * DumpRenderTree/pthreads: Removed.
1410         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1411
1412 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1413
1414         Unreviewed. Update Simon Pena email on his behalf.
1415
1416         * Scripts/webkitpy/common/config/contributors.json:
1417
1418 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1419
1420         Add support for [NoInterfaceObject] Web IDL extended attribute
1421         https://bugs.webkit.org/show_bug.cgi?id=115714
1422
1423         Reviewed by Kentaro Hara.
1424
1425         Update BindingsTests.generate_supplemental_dependency() to pass an
1426         additional windowConstructorsFile argument to preprocess-idls.pl.
1427
1428         * Scripts/webkitpy/bindings/main.py:
1429         (BindingsTests.generate_supplemental_dependency):
1430         (BindingsTests.main):
1431
1432 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1433
1434         [GTK][AC] Buildfix after r149694
1435         https://bugs.webkit.org/show_bug.cgi?id=115797
1436
1437         Reviewed by Gustavo Noronha Silva.
1438
1439         Add CLUTTER_LIBS for linking TestWebCore.
1440
1441         * TestWebKitAPI/GNUmakefile.am:
1442
1443 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1444
1445         [EFL] Remove unnecessary pkgs in EFL jhbuild
1446         https://bugs.webkit.org/show_bug.cgi?id=114908
1447
1448         Reviewed by Laszlo Gombos.
1449
1450         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1451         handle them using jhbuild. We can reduce build time when using --update-efl.
1452
1453         * efl/jhbuild.modules:
1454
1455 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1456
1457         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1458         https://bugs.webkit.org/show_bug.cgi?id=115834
1459
1460         Reviewed by Gyuyoung Kim.
1461
1462         * Scripts/webkitperl/FeatureList.pm:
1463
1464 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1465
1466         Add Scheduler for Mac MtnLion 32bit Release builder.
1467         
1468         Unreviewed.
1469         
1470         * BuildSlaveSupport/build.webkit.org-config/config.json:
1471
1472 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1473
1474         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1475         https://bugs.webkit.org/show_bug.cgi?id=115808
1476
1477         Reviewed by Darin Adler.
1478
1479         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1480         was left outdated after r127191, when the m_string member was changed
1481         from UString to String. This patch calls the right pretty printer for it.
1482
1483         * gdb/webkit.py:
1484         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1485         WTFImplPrettyPrinter.
1486
1487 2013-05-08  Andy Estes  <aestes@apple.com>
1488
1489         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1490         https://bugs.webkit.org/show_bug.cgi?id=115790
1491
1492         Reviewed by Alexey Proskuryakov.
1493
1494         Added two API tests:
1495
1496         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1497         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1498
1499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1500         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1501         (TestWebKitAPI):
1502         (TestWebKitAPI::TEST):
1503         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1504         (TestWebKitAPI):
1505         (TestWebKitAPI::decidePolicyForNavigationAction):
1506         (CustomProtocolInvalidSchemeTest):
1507         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1508
1509 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1510
1511         Teach buildbot how to compile 32-bit on Mac.
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1516         (CompileWebKit.start):
1517         (ExtractTestResultsAndLeaks):
1518
1519 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1520
1521         [BlackBerry] Fix usage of BlackBerry::Platform::String
1522         https://bugs.webkit.org/show_bug.cgi?id=115781
1523
1524         Reviewed by Rob Buis.
1525
1526         BlackBerry PRs 304193 and 327181
1527         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1528
1529         We currently have a problem where we're passing UTF-8 encoded data into
1530         the char* constructors of BlackBerry::Platform::String. This means the string
1531         thinks its data is not UTF-8.
1532
1533         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1534         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1535         (BlackBerry::WebKit::dumpHistoryItem):
1536         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1537         (TestRunner::setUserStyleSheetLocation):
1538         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1539         (LoadHTMLStringItem::invoke):
1540
1541 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1542
1543         Tools: add new BlackBerry include dirs.
1544         https://bugs.webkit.org/show_bug.cgi?id=115514
1545
1546         Reviewed by Rob Buis.
1547
1548         iType include dirs are missing, and HarfBuzz needs to be fixed.
1549
1550         * Scripts/webkitdirs.pm:
1551         (blackberryCMakeArguments):
1552
1553 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1554
1555         [GTK] Plumb the Automake build system for the Battery Status API feature
1556         https://bugs.webkit.org/show_bug.cgi?id=115718
1557
1558         Reviewed by Martin Robinson.
1559
1560         * Scripts/webkitdirs.pm:
1561         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1562         through the --(enable|disable)-battery-status flag passed to configure.
1563
1564 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1565
1566         new-run-webkit-websocketserver doesn't work after Chromium removal
1567         https://bugs.webkit.org/show_bug.cgi?id=115816
1568
1569         Reviewed by Joseph Pecoraro.
1570
1571         Fix the bug by instantiating the correct port object.
1572
1573         * Scripts/new-run-webkit-websocketserver:
1574         (main):
1575
1576 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1577
1578         Configure buildbot for 32bit builder.
1579         https://bugs.webkit.org/show_bug.cgi?id=115769
1580         
1581         Reviewed by Ryosuke Niwa.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/config.json:
1584
1585 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1586
1587         Unreviewed. Update to show my apple.com address.
1588
1589         * Scripts/webkitpy/common/config/contributors.json: Added
1590         my apple.com e-mail address.
1591
1592 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1593
1594         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1595
1596         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1597         (concatenateAttributeAndValue): Switch to appendVector().
1598
1599 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1600
1601         [Qt][WTR] Fix the build on Mac after r149692
1602
1603         Unreviewed build fix.
1604
1605         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1606         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1607
1608 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1609
1610         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1611         to the watchlist for Accessibility.
1612
1613         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1614         * Scripts/webkitpy/common/config/watchlist: Added myself.
1615
1616 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1617
1618         [Qt] Build fails with clang
1619         https://bugs.webkit.org/show_bug.cgi?id=115741
1620
1621         Reviewed by Benjamin Poulain.
1622
1623         Since r149112 std::move is used in AtomicString for compilers that
1624         support rvalue references and this requires a standard library
1625         implementing c++11 move semantics.
1626         We only explicitely require c++11 for WebKit2, but since clang supports
1627         rvalue references the build of subtargets using AtomicString fails because
1628         of missing std::move.
1629         It is safe to add CONFIG += c++11 for the whole project when using clang
1630         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1631
1632         * qmake/mkspecs/features/unix/default_pre.prf:
1633
1634 2013-05-08  Darin Adler  <darin@apple.com>
1635
1636         Fix one more place that needed to use adoptCF/NS
1637         https://bugs.webkit.org/show_bug.cgi?id=115778
1638
1639         Reviewed by Benjamin Poulain.
1640
1641         Not sure why I missed this code last time, but found a bit more code that needs
1642         to switch to the newer style adoptCF/NS.
1643
1644         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1645         (convertWebResourceDataToString): Use adoptCF.
1646         (convertWebResourceResponseToDictionary): Ditto.
1647         (createXMLStringFromWebArchiveData): Ditto.
1648         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1649         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1650
1651 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1652
1653         Unreviewed, rolling out r149271.
1654         http://trac.webkit.org/changeset/149271
1655         https://bugs.webkit.org/show_bug.cgi?id=115780
1656
1657         The mangled symbols are now enforced through LDFLAGS
1658         (Requested by zdobersek on #webkit).
1659
1660         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1661
1662 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
1663
1664         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
1665         https://bugs.webkit.org/show_bug.cgi?id=115636
1666
1667         Reviewed by Ryosuke Niwa.
1668
1669         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1670         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
1671         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
1672         while Chromium-specific, can't be removed just yet as there's more code that uses it.
1673
1674 2013-05-06  Darin Adler  <darin@apple.com>
1675
1676         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
1677         https://bugs.webkit.org/show_bug.cgi?id=115657
1678
1679         Reviewed by Sam Weinig.
1680
1681         This is similar to my last set of changes, but covers code that I missed with
1682         global replace using the Safari Xcode workspace.
1683
1684         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1685         (convertWebResourceDataToString):
1686         (convertWebResourceResponseToDictionary):
1687         (createXMLStringFromWebArchiveData):
1688         * DumpRenderTree/cg/ImageDiffCG.cpp:
1689         (createImageFromStdin):
1690         (createDifferenceImage):
1691         (main):
1692         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1693         (printPNG):
1694         (dumpBitmap):
1695         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1696         (BitmapContext::BitmapContext):
1697         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1698         (-[MockWebNotificationProvider init]):
1699         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1700         (createBitmapContext):
1701         * DumpRenderTree/mac/TestRunnerMac.mm:
1702         (TestRunner::addDisallowedURL):
1703         (TestRunner::applicationCacheDiskUsageForOrigin):
1704         (TestRunner::localStorageDiskUsageForOrigin):
1705         (TestRunner::clearApplicationCacheForOrigin):
1706         (TestRunner::deleteLocalStorageForOrigin):
1707         (TestRunner::copyDecodedHostName):
1708         (TestRunner::copyEncodedHostName):
1709         (TestRunner::queueLoad):
1710         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1711         (TestRunner::setMockGeolocationPositionUnavailableError):
1712         (TestRunner::setUserStyleSheetLocation):
1713         (TestRunner::setValueForUser):
1714         (TestRunner::overridePreference):
1715         (TestRunner::setPersistentUserStyleSheetLocation):
1716         (TestRunner::execCommand):
1717         (TestRunner::findString):
1718         (TestRunner::isCommandEnabled):
1719         (TestRunner::addOriginAccessWhitelistEntry):
1720         (TestRunner::removeOriginAccessWhitelistEntry):
1721         (TestRunner::addUserScript):
1722         (TestRunner::addUserStyleSheet):
1723         (TestRunner::evaluateInWebInspector):
1724         (TestRunner::evaluateScriptInIsolatedWorld):
1725         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1726         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1727         (TestRunner::authenticateSession):
1728         (TestRunner::grantWebNotificationPermission):
1729         (TestRunner::denyWebNotificationPermission):
1730         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1731         (createCFURLResponseFromResponseData):
1732         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1733         (LoadItem::invoke):
1734         (LoadHTMLStringItem::invoke):
1735         (ScriptItem::invoke):
1736         * DumpRenderTree/win/DumpRenderTree.cpp:
1737         (substringFromIndex):
1738         (urlSuitableForTestResult):
1739         (lastPathComponent):
1740         (sharedCFURLCache):
1741         * DumpRenderTree/win/ImageDiffCairo.cpp:
1742         (createImageFromStdin):
1743         (main):
1744         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1745         (createBitmapContextFromWebView):
1746         * DumpRenderTree/win/TestRunnerWin.cpp:
1747         (TestRunner::setUserStyleSheetLocation):
1748         (TestRunner::setPersistentUserStyleSheetLocation):
1749         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1750         (TestWebKitAPI::TEST):
1751         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1752         (TestWebKitAPI::TEST):
1753         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1754         (TestWebKitAPI::TEST):
1755         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1756         (TestWebKitAPI::TEST):
1757         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1758         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1759         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1760         (TestWebKitAPI::createWindow):
1761         (TestWebKitAPI::TEST):
1762         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1765         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1766         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1767         (TestWebKitAPI::TEST):
1768         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
1771         (TestWebKitAPI::TEST):
1772         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1773         (TestWebKitAPI::TEST):
1774         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1777         (TestWebKitAPI::TEST):
1778         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
1779         (TestWebKitAPI::TEST):
1780         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1781         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1782         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1783         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
1784         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1793         (TestWebKitAPI::TEST):
1794         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1795         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1796         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
1797         (TestWebKitAPI::TEST):
1798         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1799         (TestWebKitAPI::TEST):
1800         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1801         (TestWebKitAPI::TEST):
1802         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1803         (TestWebKitAPI::TEST):
1804         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1805         (TestWebKitAPI::TEST):
1806         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
1809         (TestWebKitAPI::TEST):
1810         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1811         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1812         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1813         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1814         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1815         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1816         (WTR::testPathFromURL):
1817         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1818         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1819         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1820         (WTR::createCGContextFromImage):
1821         (WTR::dumpBitmap):
1822         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1823         * WebKitTestRunner/mac/EventSenderProxy.mm:
1824         (WTR::EventSenderProxy::mouseScrollBy):
1825         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1826         (WTR::PlatformWebView::windowSnapshotImage):
1827         * WebKitTestRunner/win/TestControllerWin.cpp:
1828         (WTR::TestController::initializeTestPluginDirectory):
1829         Use adoptCF and adoptNS.
1830
1831 2013-05-07  Alex Christensen  <achristensen@apple.com>
1832
1833         Fix a memory leak introduced in r149692
1834         https://bugs.webkit.org/show_bug.cgi?id=115766
1835
1836         Reviewed by Mark Rowe.
1837
1838         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
1839         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
1840
1841         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1842         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1843         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
1844
1845 2013-05-07  Darin Adler  <darin@apple.com>
1846
1847         [Win] Fix storage leak in Windows DumpRenderTree
1848         https://bugs.webkit.org/show_bug.cgi?id=115651
1849
1850         Reviewed by Sam Weinig.
1851
1852         * DumpRenderTree/win/DumpRenderTree.cpp:
1853         (lastPathComponent): Added a missing call to adoptCF.
1854
1855 2013-05-07  Alex Christensen  <achristensen@apple.com>
1856
1857         fixed a memory leak introduced by bug 42324 by using a RetainPtr
1858         https://bugs.webkit.org/show_bug.cgi?id=115760
1859
1860         Reviewed by Tim Horton.
1861
1862         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1863         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1864         fixed memory leak, added UNUSED_PARAM macros
1865
1866 2013-05-07  Alex Christensen  <achristensen@apple.com>
1867
1868         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
1869         https://bugs.webkit.org/show_bug.cgi?id=42324
1870         <rdar://problem/8193633>
1871
1872         Reviewed by Tim Horton.
1873
1874         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1875         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
1876         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1877         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1878         Added dumpDOMAsWebArchive code that is called when dumping.        
1879         (WTR::InjectedBundlePage::dump):
1880         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
1881         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1882         (InjectedBundlePage):
1883         Added dumpDOMAsWebArchive declaration.
1884         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
1885         (WTR::TestRunner::dumpDOMAsWebArchive):
1886         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
1887         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1888         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
1889         * Tools/WebKitTestRunner/cf: Added.
1890         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
1891         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
1892         (convertMIMEType):
1893         (convertWebResourceDataToString):
1894         (normalizeHTTPResponseHeaderFields):
1895         (normalizeWebResourceURL):
1896         (convertWebResourceResponseToDictionary):
1897         (compareResourceURLs):
1898         (createXMLStringFromWebArchiveData):
1899         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
1900         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
1901         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
1902         Copied from Tools/DumpRenderTree/mac for used functions.
1903         (createCFURLResponseFromResponseData):
1904         (supportedNonImageMIMETypes):
1905
1906 2013-05-07  Alex Christensen  <achristensen@apple.com>
1907
1908         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
1909         https://bugs.webkit.org/show_bug.cgi?id=115745
1910
1911         Reviewed by Tim Horton.
1912
1913         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1914         (compareResourceURLs):
1915         Updated style.
1916
1917 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
1918
1919         Add an 'isReadOnly' member to IDL parse tree structure
1920         https://bugs.webkit.org/show_bug.cgi?id=115704
1921
1922         Reviewed by Kentaro Hara.
1923
1924         Use newly added isReadOnly attribute.
1925
1926         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1927         (_generateHeaderFile):
1928         (_generateImplementationFile):
1929         (_staticValuesGetterImplementation):
1930
1931 2013-05-07  Anders Carlsson  <andersca@apple.com>
1932
1933         Remove AlwaysInline.h from WTF
1934         https://bugs.webkit.org/show_bug.cgi?id=115727
1935
1936         Reviewed by Brent Fulgham.
1937
1938         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
1939         to keep AlwaysInline.h around anymore.
1940
1941         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1942         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1943
1944 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
1945
1946         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
1947         https://bugs.webkit.org/show_bug.cgi?id=114808
1948
1949         Reviewed by Jocelyn Turcotte.
1950
1951         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
1952         (https://codereview.qt-project.org/#change,54234)
1953
1954         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1955         (WTR::WrapperWindow::handleStatusChanged):
1956
1957 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1958
1959         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
1960
1961         * Scripts/webkitpy/common/config/watchlist:
1962
1963 2013-05-06  Kangil Han  <kangil.han@samsung.com>
1964
1965         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
1966         https://bugs.webkit.org/show_bug.cgi?id=115645
1967
1968         Reviewed by Gyuyoung Kim.
1969
1970         To run performance tests in wk1, we need --no-timeout option implementation.
1971         So adopt it from gtk+ port.
1972
1973         * DumpRenderTree/efl/DumpRenderTree.cpp:
1974         (shouldSetWaitToDumpWatchdog):
1975         (parseCommandLineOptions):
1976         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1977         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1978         (TestRunner::setWaitToDump):
1979
1980 2013-05-06  Commit Queue  <commit-queue@webkit.org>
1981
1982         Unreviewed, rolling out r149547.
1983         http://trac.webkit.org/changeset/149547
1984         https://bugs.webkit.org/show_bug.cgi?id=115682
1985
1986         Added unittests that fail on bots and spits out text into
1987         stdout (Requested by rniwa on #webkit).
1988
1989         * Scripts/import-w3c-tests: Removed.
1990         * Scripts/webkitpy/w3c/__init__.py: Removed.
1991         * Scripts/webkitpy/w3c/test_converter.py: Removed.
1992         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
1993         * Scripts/webkitpy/w3c/test_importer.py: Removed.
1994         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
1995         * Scripts/webkitpy/w3c/test_parser.py: Removed.
1996         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
1997
1998 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
1999
2000         [jhbuild] bump jhbuild version to take advantage of new improvements
2001         https://bugs.webkit.org/show_bug.cgi?id=115558
2002
2003         Reviewed by Martin Robinson.
2004
2005         One of the important improvements is jhbuild no longer fetches git
2006         repositories if they are already at the expected revision, which should
2007         make the EWS bots more robust to git servers unavailability.
2008
2009         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2010
2011 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2012
2013         [GTK] Add webkit_uri_scheme_request_finish_error
2014         https://bugs.webkit.org/show_bug.cgi?id=94316
2015
2016         Reviewed by Anders Carlsson.
2017
2018         * MiniBrowser/gtk/main.c:
2019         (miniBrowserErrorQuark): Add function to create a global quark for
2020         MiniBrowser.
2021         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2022         function webkit_uri_scheme_request_finish_error().
2023
2024 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2025
2026         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2027         https://bugs.webkit.org/show_bug.cgi?id=113808
2028
2029         Reviewed by Rob Buis.
2030
2031         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2032         to true for BlackBerry.
2033
2034         * Scripts/webkitperl/FeatureList.pm:
2035
2036 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2037
2038         check-webkit-style should complain about a layering violation if platform-specific guards are
2039         used in WebCore outside of the platform directory
2040         https://bugs.webkit.org/show_bug.cgi?id=115567
2041
2042         Reviewed by Benjamin Poulain.
2043
2044         * Scripts/webkitpy/style/checkers/cpp.py:
2045         (check_for_webcore_platform_layering_violation):
2046         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2047         (process_line):
2048         Add the check_for_webcore_platform_layering_violation.
2049         (CppChecker):
2050         List the new check.
2051
2052         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2053         (CppStyleTest.test_webcore_platform_layering_violation):
2054         Add tests.
2055
2056 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2057
2058         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2059         <http://webkit.org/b/115667>
2060
2061         Reviewed by Dirk Pranke.
2062
2063         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2064         (Bugzilla._check_create_bug_response): Update regex to work with
2065         Bugzilla 3.2.3 and 4.2.5.
2066         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2067         (test__check_create_bug_response): Add new test that covers both
2068         old and new <title> variations.
2069
2070 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2071
2072         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2073         https://bugs.webkit.org/show_bug.cgi?id=115661
2074
2075         Reviewed by Ryosuke Niwa.
2076
2077         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2078         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2079         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2080
2081         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2082         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2083
2084 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2085
2086         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2087         https://bugs.webkit.org/show_bug.cgi?id=114603
2088
2089         Reviewed by Ryosuke Niwa.
2090
2091         * TestResultServer/generate_builders_json.py:
2092         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2093         to represent these to be 'layout-test', for backwards compatibility.
2094         (main): Remove all the build.chromium.org masters.
2095         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2096         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2097         (GenerateBuildersJsonTest):
2098         (GenerateBuildersJsonTest.test_generate_json_data):
2099         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2100         test-running builders from the webkit.org master.
2101
2102 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2103
2104         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2105         https://bugs.webkit.org/show_bug.cgi?id=114988
2106
2107         Reviewed by Ryosuke Niwa.
2108
2109         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2110         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2111         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2112         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2113         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2114
2115 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2116
2117         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2118         https://bugs.webkit.org/show_bug.cgi?id=114954
2119
2120         Reviewed by Ryosuke Niwa.
2121
2122         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2123         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2124         modifier unions in the list of modifiers.
2125         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2126         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2127
2128 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2129
2130         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2131         https://bugs.webkit.org/show_bug.cgi?id=114957
2132
2133         Reviewed by Ryosuke Niwa.
2134
2135         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2136         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2137         (chromiumPlatform): Removed, unnecessary.
2138         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2139         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2140         the builder operates with debug builds, no webkit.org builders are named this way.
2141         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2142         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2143
2144 2013-05-06  Andy Estes  <aestes@apple.com>
2145
2146         Added two files I neglected to commit in r149589.
2147
2148         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2149         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2150
2151 2013-05-04  Andy Estes  <aestes@apple.com>
2152
2153         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2154         https://bugs.webkit.org/show_bug.cgi?id=115609
2155
2156         Reviewed by Oliver Hunt.
2157
2158         Added an API test.
2159
2160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2161         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2162         (+[TestDelegate shared]):
2163         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2164         (-[TestDelegate webView:createWebViewWithRequest:]):
2165         (TestWebKitAPI):
2166         (TestWebKitAPI::TEST):
2167         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2168
2169 2013-05-06  Antoine Quint  <graouts@apple.com>
2170
2171         Manage the presentation of the snapshotted plug-in using JavaScript
2172         https://bugs.webkit.org/show_bug.cgi?id=115548
2173
2174         Reviewed by Dean Jackson.
2175
2176         Take into account the new plugInExtraScript method added to support
2177         the injection of a JS file from the chrome client to customize the
2178         rendering of a snapshotted plug-in's shadow tree.
2179
2180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2181         (WTR::InjectedBundlePage::InjectedBundlePage):
2182
2183 2013-05-05  Anders Carlsson  <andersca@apple.com>
2184
2185         Remove the Vector::append overload that takes a Vector
2186         https://bugs.webkit.org/show_bug.cgi?id=115535
2187
2188         Reviewed by Andreas Kling.
2189
2190         Use Vector::appendVector instead.
2191
2192         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2193         (concatenateAttributeAndValue):
2194         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2195         (WTR::concatenateAttributeAndValue):
2196
2197 2013-05-04  Sam Weinig  <sam@webkit.org>
2198
2199         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2200         <rdar://problem/13702008>
2201         https://bugs.webkit.org/show_bug.cgi?id=115607
2202
2203         Reviewed by Benjamin Poulain.
2204
2205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2206         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2207         (TestWebKitAPI::didFinishLoadForFrame):
2208         (TestWebKitAPI::TEST):
2209         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2210
2211 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2212
2213         Unreviewed.
2214
2215         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2216
2217 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2218
2219         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2220
2221         * Scripts/webkitpy/common/config/contributors.json:
2222
2223 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2224
2225         [GTK] Catch select.error exceptions in parse_output_lines
2226         https://bugs.webkit.org/show_bug.cgi?id=115253
2227
2228         Reviewed by Gustavo Noronha Silva.
2229
2230         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2231         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2232         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2233         error code and the error message) and the loop is re-entered.
2234
2235         * gtk/common.py:
2236         (parse_output_lines):
2237
2238 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2239
2240         [GTK] Set up the TestWebCore in TestWebKitAPI
2241         https://bugs.webkit.org/show_bug.cgi?id=115237
2242
2243         Reviewed by Gustavo Noronha Silva.
2244
2245         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2246         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2247         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2248         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2249         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2250
2251         * TestWebKitAPI/GNUmakefile.am:
2252
2253 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2254
2255         Create a script to import W3C tests
2256         https://bugs.webkit.org/show_bug.cgi?id=111513
2257
2258         Reviewed by Dirk Pranke.
2259
2260         Script to automate the import of W3C tests into WebKit. 
2261         For the full description of how it works, see the comments
2262         at the top of test_importer.py.
2263
2264         * Scripts/import-w3c-tests: Added.
2265         * Scripts/webkitpy/w3c/__init__.py: Added.
2266         * Scripts/webkitpy/w3c/test_converter.py: Added.
2267         (TestConverter):
2268         (TestConverter.__init__):
2269         (TestConverter.load_prefixed_prop_list):
2270         (TestConverter.load_file):
2271         (TestConverter.convert_for_webkit):
2272         (TestConverter.convert_testharness_paths):
2273         (TestConverter.convert_prefixed_properties):
2274         (TestConverter.scrub_unprefixed_props):
2275         (TestConverter.replace_tag):
2276         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2277         (TestConverterTest):
2278         (TestConverterTest.testLoadPrefixedPropList):
2279         (TestConverterTest.test_convertForWebkitNothingToConvert):
2280         (test_convertForWebkitHarnessOnly):
2281         (test_convertForWebkitPropsOnly):
2282         (test_convertForWebkitHarnessAndProps):
2283         (test_convertTestHarnessPaths):
2284         (test_convertPrefixedProperties):
2285         (verifyTestHarnessPaths):
2286         (verifyPrefixedProperties):
2287         (generateTestContent):
2288         * Scripts/webkitpy/w3c/test_importer.py: Added.
2289         (main):
2290         (parse_args):
2291         (validate_import_directory):
2292         (TestImporter):
2293         (TestImporter.__init__):
2294         (TestImporter.do_import):
2295         (TestImporter.get_changeset):
2296         (TestImporter.scan_source_directory):
2297         (TestImporter.import_tests):
2298         (TestImporter.setup_destination_directory):
2299         (TestImporter.get_test_status):
2300         (TestImporter.remove_deleted_files):
2301         (TestImporter.write_import_log):
2302         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2303         (TestImporterTest):
2304         (TestImporterTest.test_ImportDirWithNoTests):
2305         * Scripts/webkitpy/w3c/test_parser.py: Added.
2306         (TestParser):
2307         (TestParser.__init__):
2308         (TestParser.load_file):
2309         (TestParser.analyze_test):
2310         (TestParser.get_reftests):
2311         (TestParser.is_jstest):
2312         (TestParser.get_support_files):
2313         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2314         (TestParserTest):
2315         (TestParserTest.test_analyzeTestReftestOneMatch):
2316         (test_analyzeTestReftestMultipleMatches):
2317         (test_analyzeTestReftestMatchAndMismatch):
2318         (test_analyzeTestReftestWithRefSupportFiles):
2319         (test_analyzeJSTest):
2320         (test_analyzePixelTestAllTrue):
2321         (test_analyzePixelTestAllFalse):
2322         (test_analyzeNonHTMLFile):
2323
2324 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2325
2326         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2013-05-02  Nico Weber  <thakis@chromium.org>
2331
2332         Remove a stale script file.
2333         https://bugs.webkit.org/show_bug.cgi?id=115521
2334
2335         Reviewed by Anders Carlsson.
2336
2337         This script was added in
2338         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2339         Bakefile system that was removed in
2340         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2341         script just asserts when it's run and is useless.
2342
2343         * Scripts/update-sources-list.py: Removed.
2344
2345 2013-05-01  Glenn Adams  <glenn@skynav.com>
2346
2347         [webkitpy] Need abstract base class for commands that analyze commit logs
2348         https://bugs.webkit.org/show_bug.cgi?id=115391
2349
2350         Reviewed by Benjamin Poulain.
2351
2352         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2353         in preparation for adding two new commands that will reuse this functionality along with
2354         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2355         https://bugs.webkit.org/show_bug.cgi?id=115388.
2356
2357         No new tests as this patch does not change existing functionality or behavior.
2358
2359         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2360         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2361         (AbstractCommitLogCommand.__init__):
2362         (AbstractCommitLogCommand._init_options):
2363         (AbstractCommitLogCommand._parse_commit_message):
2364         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2365         (SuggestNominations.__init__): 
2366         (SuggestNominations._init_options):
2367
2368 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2369
2370         Web Inspector: Fix check-inspector-strings script and fix localized strings
2371         https://bugs.webkit.org/show_bug.cgi?id=115495
2372
2373         Reviewed by Joseph Pecoraro.
2374
2375         * Scripts/check-inspector-strings:
2376
2377 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2378
2379         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2380         https://bugs.webkit.org/show_bug.cgi?id=115470
2381
2382         Reviewed by Martin Robinson.
2383
2384         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2385         not building either of the IOS, Windows or GTK-WK1 platforms.
2386
2387         Up until now the header was included for everything but the IOS and Windows platforms due to
2388         an incorrectly stated condition regarding the GTK platform.
2389
2390         * TestWebKitAPI/config.h:
2391
2392 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2393
2394         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2395         https://bugs.webkit.org/show_bug.cgi?id=115469
2396
2397         Reviewed by Martin Robinson.
2398
2399         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2400         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2401         for the WebKit2 tests and the injected bundle required by them.
2402
2403         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2404         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2405         under the WebKit2 code).
2406
2407         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2408         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2409         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2410
2411         * TestWebKitAPI/GNUmakefile.am:
2412
2413 2013-04-30  Glenn Adams  <glenn@skynav.com>
2414
2415         Unreviewed. Add myself to watchlist entries.
2416
2417         * Scripts/webkitpy/common/config/watchlist:
2418
2419 2013-04-30  Glenn Adams  <glenn@skynav.com>
2420
2421         [webkitpy] suggest-nominations doesn't count all qualified patches
2422         https://bugs.webkit.org/show_bug.cgi?id=115285
2423
2424         Reviewed by Benjamin Poulain.
2425
2426         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2427         nomination. Improve commit log parsing.
2428
2429         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2430         (CommitLogError):
2431         (CommitLogError.__init__):
2432         (CommitLogMissingReviewer):
2433         (CommitLogMissingReviewer.__init__):
2434         (SuggestNominations):
2435         (SuggestNominations.__init__):
2436         (SuggestNominations._recent_commit_messages):
2437         (SuggestNominations._author_name_from_email):
2438         (SuggestNominations._contributor_from_email):
2439         (SuggestNominations._parse_commit_message):
2440         (SuggestNominations._count_commit):
2441         (SuggestNominations._count_recent_patches):
2442         (SuggestNominations._collect_nominations):
2443         (SuggestNominations._print_nominations):
2444         (SuggestNominations.execute):
2445         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2446         (_make_options):
2447         (test_recent_commit_messages):
2448         (test_basic):
2449
2450 2013-04-30  Commit Queue  <rniwa@webkit.org>
2451
2452         Unreviewed, rolling out r149309.
2453         http://trac.webkit.org/changeset/149309
2454         https://bugs.webkit.org/show_bug.cgi?id=115430
2455
2456         The patch does not build on WK1-only builds of the GTK port
2457         (Requested by zdobersek on #webkit).
2458
2459         * TestWebKitAPI/GNUmakefile.am:
2460
2461 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2462
2463         Stop using "in" keyword in IDL files
2464         https://bugs.webkit.org/show_bug.cgi?id=115418
2465
2466         Reviewed by Kentaro Hara.
2467
2468         Remove "in" keyword from IDL files as this is no longer part of the Web
2469         IDL specification.
2470
2471         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2472         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2473         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2474         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2475         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2476         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2477         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2478         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2479
2480 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2481
2482         [EFL] Enable scaled cursors
2483         https://bugs.webkit.org/show_bug.cgi?id=106242
2484
2485         Reviewed by Gyuyoung Kim.
2486
2487         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2488
2489         * Scripts/webkitperl/FeatureList.pm:
2490
2491 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2492
2493         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2494         https://bugs.webkit.org/show_bug.cgi?id=115380
2495
2496         Reviewed by Kentaro Hara.
2497
2498         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2499         keyword.
2500
2501         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2502         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2503
2504 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2505
2506         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2507         https://bugs.webkit.org/show_bug.cgi?id=114684
2508
2509         Reviewed by Simon Hausmann.
2510
2511         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2512         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2513
2514         * qmake/mkspecs/features/features.prf:
2515
2516 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2517
2518         [GTK] Disable Shadow DOM feature
2519         https://bugs.webkit.org/show_bug.cgi?id=115374
2520
2521         Reviewed by Martin Robinson.
2522
2523         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2524
2525         * Scripts/webkitperl/FeatureList.pm:
2526
2527 2013-04-29  Glenn Adams  <glenn@skynav.com>
2528
2529         [webkitpy] Add missing contributor email addresses
2530         https://bugs.webkit.org/show_bug.cgi?id=115394
2531
2532         Reviewed by Ryosuke Niwa.
2533
2534         * Scripts/webkitpy/common/config/contributors.json:
2535
2536 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2537
2538         Remove all remaining Skia code
2539         https://bugs.webkit.org/show_bug.cgi?id=115263
2540
2541         Reviewed by Benjamin Poulain.
2542
2543         Remove all remaining references to Skia.
2544
2545         * Scripts/webkitdirs.pm:
2546         (blackberryCMakeArguments):
2547         * Scripts/webkitpy/common/config/contributionareas.py:
2548         * Scripts/webkitpy/common/config/watchlist:
2549
2550 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2551
2552         Get rid of unused options in Tools/Scripts/webkit-build-directory
2553         https://bugs.webkit.org/show_bug.cgi?id=115383
2554
2555         Reviewed by Darin Adler.
2556
2557         * Scripts/webkit-build-directory:
2558
2559 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2560
2561         [WK2][Mac] Test with NetworkProcess enabled.
2562
2563         Fix the build for non-Mac.
2564
2565         * WebKitTestRunner/TestController.cpp:
2566         (WTR::TestController::initialize):
2567
2568 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2569
2570         [WK2][Mac] Test with NetworkProcess enabled.
2571
2572         Reviewed by Sam Weinig.
2573
2574         * WebKitTestRunner/TestController.cpp:
2575         (WTR::TestController::initialize):
2576
2577 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2578
2579         [GTK] Set up the TestWebCore in TestWebKitAPI
2580         https://bugs.webkit.org/show_bug.cgi?id=115237
2581
2582         Reviewed by Gustavo Noronha Silva.
2583
2584         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2585         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2586         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2587         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2588         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2589
2590         * TestWebKitAPI/GNUmakefile.am:
2591
2592 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2593
2594         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2595         https://bugs.webkit.org/show_bug.cgi?id=115236
2596
2597         Reviewed by Gustavo Noronha Silva.
2598
2599         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2600         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2601
2602         * TestWebKitAPI/GNUmakefile.am:
2603
2604 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2605
2606         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2607         https://bugs.webkit.org/show_bug.cgi?id=115323
2608
2609         Reviewed by Philippe Normand.
2610
2611         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2612         Its presence enforces linkers to output mangled symbols when reporting linking failures
2613         due to unresolved references. People trying to fix the build can then simply copy
2614         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2615         or connecting to the builders to discover the mangled version of the missing symbol.
2616
2617         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2618
2619 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2620
2621         Remove Chromium code from Tools/BuildSlaveSupport
2622         https://bugs.webkit.org/show_bug.cgi?id=115325
2623
2624         Reviewed by Benjamin Poulain.
2625
2626         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2627         covering archiving test results and built products.
2628
2629         * BuildSlaveSupport/built-product-archive:
2630         (archiveBuiltProduct):
2631         (extractBuiltProduct):
2632         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2633         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2634         * BuildSlaveSupport/test-result-archive:
2635         (archiveTestResults):
2636
2637 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2638
2639         Remove support for Chromium from webkitdirs.pm
2640         https://bugs.webkit.org/show_bug.cgi?id=115338
2641
2642         Reviewed by Darin Adler.
2643
2644         * Scripts/webkitdirs.pm:
2645         (determineBaseProductDir):
2646         (argumentsForConfiguration):
2647         (builtDylibPathForName):
2648         (determineIsQt):
2649         (isAppleWebKit):
2650
2651 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2652
2653         Rename TestRunner's setAudioData to setAudioResult
2654         https://bugs.webkit.org/show_bug.cgi?id=115326
2655
2656         Reviewed by Darin Adler.
2657
2658         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2659         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2660         affected tests are adjusted accordingly.
2661
2662         * DumpRenderTree/qt/TestRunnerQt.cpp:
2663         (TestRunnerQt::setAudioResult):
2664         * DumpRenderTree/qt/TestRunnerQt.h:
2665         (TestRunnerQt):
2666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2668         (WTR::TestRunner::setAudioResult):
2669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2670         (TestRunner):
2671
2672 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2673
2674         [WKTR] Tests dumping audio data shouldn't dump pixels
2675         https://bugs.webkit.org/show_bug.cgi?id=115270
2676
2677         Reviewed by Benjamin Poulain.
2678
2679         Prevent dumping the pixel output when Web Audio tests are dumping output data
2680         as the testing output. Pixel output in these tests has no real meaning and is
2681         as such unnecessary.
2682
2683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2684         (WTR::TestRunner::setAudioData):
2685
2686 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2687
2688         [EFL] Unreviewed Intel bots fix after r149231.
2689
2690         * efl/jhbuild.modules: Disable the libxml Python bindings since the
2691         bots don't have Python's development files installed. libxml should
2692         detect this kind of thing better.
2693
2694 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
2695
2696         [EFL] Build break using jhbuild on ubuntu 13.04
2697         https://bugs.webkit.org/show_bug.cgi?id=115225
2698
2699         Reviewed by Gyuyoung Kim.
2700
2701         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
2702         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
2703         So this patch bumped libxml version to 2.9.1.
2704
2705         * efl/jhbuild.modules:
2706
2707 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
2708
2709         delete-stale-build-files does not clear .d files
2710         http://bugs.webkit.org/show_bug.cgi?id=115293
2711
2712         Reviewed by Ryosuke Niwa.
2713
2714         * BuildSlaveSupport/delete-stale-build-files:
2715         (main): Add .d to the file type list
2716
2717 2013-04-26  Roger Fong  <roger_fong@apple.com>
2718
2719         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
2720         Make the DebugSuffix configuration use _debug dependencies.
2721
2722         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2723         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
2724         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2725         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
2726         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2727         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2728         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
2729         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
2730         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
2731         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2732         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2733         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
2734         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2735         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2736         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2737         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
2738         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
2739         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
2740         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2741         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
2742         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
2743         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
2744         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2745         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
2746         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2747         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
2748         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
2749         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2750         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2751         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2752         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
2753         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
2754         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2755         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
2756         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2757         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2758         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2759         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
2760         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2761         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
2762         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2763         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2764         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2765         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
2766         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
2767         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2768         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
2769         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
2770         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
2771         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2772         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
2773         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2774         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2775         * win/AssembleBuildLogs/AssembleLogs.cmd:
2776         * win/record-memory/record-memory.vcxproj:
2777         * win/record-memory/record-memoryDebug.props:
2778         * win/record-memory/record-memoryDebugWinCairo.props:
2779         * win/record-memory/record-memoryProduction.props:
2780         * win/record-memory/record-memoryRelease.props:
2781         * win/record-memory/record-memoryReleaseWinCairo.props:
2782
2783 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2784
2785         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
2786         https://bugs.webkit.org/show_bug.cgi?id=115233
2787
2788         Reviewed by Martin Robinson.
2789
2790         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
2791         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
2792         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
2793         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
2794         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
2795
2796         * TestWebKitAPI/GNUmakefile.am:
2797
2798 2013-04-25  Andy Estes  <aestes@apple.com>
2799
2800         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
2801         https://bugs.webkit.org/show_bug.cgi?id=115223
2802
2803         Reviewed by Darin Adler.
2804
2805         Added an API test.
2806
2807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2808         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
2809         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
2810         when it loads a request with a custom protocol.
2811         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
2812         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
2813         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
2814         miscellaneous cleanup.
2815         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
2816         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
2817         (+[TestProtocol canInitWithRequest:]):
2818         (+[TestProtocol canonicalRequestForRequest:]):
2819         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
2820         (+[TestProtocol scheme]):
2821         (-[TestProtocol startLoading]):
2822         (-[TestProtocol stopLoading]):
2823
2824 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
2825
2826         Remove the remaining Skia #ifdefs
2827         https://bugs.webkit.org/show_bug.cgi?id=114886
2828
2829         Reviewed by Benjamin Poulain.
2830
2831         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2832         (createBitmapContextFromWebView): Remove Skia #ifdef references.
2833
2834 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
2835
2836         [BlackBerry] Clean up load interface in WebPage
2837         https://bugs.webkit.org/show_bug.cgi?id=113267
2838
2839         Reviewed by Rob Buis.
2840
2841         Update DumpRenderTree with change of load() interface in WebPage.
2842         RIM Bug# 315535, internally reviewed by Joe Mason.
2843
2844         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2845         (BlackBerry::WebKit::DumpRenderTree::runTest):
2846
2847 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2848
2849         Remove the HeapGraphSerializer unit test
2850         https://bugs.webkit.org/show_bug.cgi?id=115231
2851
2852         Reviewed by Andreas Kling.
2853
2854         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
2855         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
2856
2857         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
2858
2859 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2860
2861         Remove support for Chromium from build/update scripts
2862         https://bugs.webkit.org/show_bug.cgi?id=115218
2863
2864         Reviewed by Darin Adler.
2865
2866         * Scripts/build-webkit:
2867         (writeCongrats):
2868         * Scripts/update-webkit:
2869
2870 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2871
2872         Remove support for Chromium from api-test
2873         https://bugs.webkit.org/show_bug.cgi?id=115211
2874
2875         Reviewed by Dirk Pranke.
2876
2877         * Scripts/build-api-tests:
2878         * Scripts/run-api-tests:
2879         (isSupportedPlatform):
2880
2881 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2882
2883         Get rid of Chromium in build-dumprendertree
2884         https://bugs.webkit.org/show_bug.cgi?id=115212
2885
2886         Reviewed by Dirk Pranke.
2887
2888         * Scripts/build-dumprendertree:
2889
2890 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
2891
2892         Pass relatedPage when creating a page in WebKitTestRunner
2893         https://bugs.webkit.org/show_bug.cgi?id=115206
2894
2895         Reviewed by Geoffrey Garen.
2896
2897         To make sure that window.open() opens in the same process even when using multiple processes.
2898
2899         * WebKitTestRunner/PlatformWebView.h:
2900         * WebKitTestRunner/TestController.cpp:
2901         (WTR::TestController::createOtherPage):
2902         (WTR::TestController::createWebViewWithOptions):
2903         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2904         (WTR::PlatformWebView::PlatformWebView):
2905         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2906         (WTR::PlatformWebView::PlatformWebView):
2907         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2908         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2909         (WTR::PlatformWebView::PlatformWebView):
2910         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2911         (WTR::PlatformWebView::PlatformWebView):
2912         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2913         (WTR::PlatformWebView::PlatformWebView):
2914
2915 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2916
2917         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
2918
2919         * Scripts/webkitpy/common/config/contributors.json:
2920
2921 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2922
2923         Build fix. Forgot to merge args.
2924
2925         * Scripts/webkitpy/tool/bot/irc_command.py:
2926         (Hi.execute):
2927
2928 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2929
2930         webkitbot should recognize its own nickname in greetings.
2931         https://bugs.webkit.org/show_bug.cgi?id=115196
2932
2933         Reviewed by Andreas Kling.
2934
2935         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
2936
2937         * Scripts/webkitpy/tool/bot/irc_command.py:
2938         (Hi.execute):
2939
2940 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
2941
2942         [GTK] Tools/gtk/install-dependencies added ragel dependency
2943         https://bugs.webkit.org/show_bug.cgi?id=115163
2944
2945         Reviewed by Xan Lopez.
2946
2947         The install-dependencies script was missing a dependency on ragel
2948         which is expected when building HarfBuzz.
2949
2950         * gtk/install-dependencies: Added a dependency on ragel for both
2951         apt and yum.
2952
2953 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
2954
2955         [GTK] Remove pango from optional jhbuild dependencies
2956         https://bugs.webkit.org/show_bug.cgi?id=115162
2957
2958         Reviewed by Martin Robinson.
2959
2960         Pango is not needed since revision r148293 that lowers the pango
2961         dependency to 1.30, which is available in most distributions.
2962
2963         * gtk/jhbuild-optional.modules: Removes description of pango module.
2964
2965 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2966
2967         Remove Chromium-specific cases from FeatureList.pm
2968         https://bugs.webkit.org/show_bug.cgi?id=115169
2969
2970         Reviewed by Andreas Kling.
2971
2972         * Scripts/webkitperl/FeatureList.pm:
2973
2974 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
2975
2976         Remove checking chromium from run-webkit-tests
2977         https://bugs.webkit.org/show_bug.cgi?id=115139
2978
2979         Reviewed by Benjamin Poulain.
2980
2981         * Scripts/run-webkit-tests:
2982         (useNewRunWebKitTests):
2983
2984 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
2985
2986         Pixel tests in SVG are all broken in WK2
2987         https://bugs.webkit.org/show_bug.cgi?id=114218
2988
2989         Reviewed by Darin Adler.
2990         
2991         Window snapshots in WebKitTestRunner on Mac are window-sized
2992         (800x600), which is wrong for the W3C SVG tests that require a
2993         480x360 snapshot.
2994         
2995         Fix by resizing the window, as well as the web view in
2996         PlatformWebView::resizeTo() so that window snapshots are correctly
2997         sized.
2998         
2999         Also do some drive-by cleanup of the window size constants in both
3000         DRT and WTR to remove magic numbers, and make the code more similar.
3001         
3002         * DumpRenderTree/TestRunner.cpp:
3003         (TestRunner::setShouldPaintBrokenImage):
3004         * DumpRenderTree/TestRunner.h:
3005         * DumpRenderTree/efl/DumpRenderTree.cpp:
3006         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3007         (webInspectorShowWindow):
3008         * DumpRenderTree/mac/DumpRenderTree.mm:
3009         (createWebViewAndOffscreenWindow):
3010         (sizeWebViewForCurrentTest):
3011         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3012         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3013         (createPagedBitmapContext):
3014         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3015         (DumpRenderTree::DumpRenderTree):
3016         (DumpRenderTree::open):
3017         * DumpRenderTree/qt/TestRunnerQt.cpp:
3018         * DumpRenderTree/qt/TestRunnerQt.h:
3019         * DumpRenderTree/win/DumpRenderTree.cpp:
3020         (sizeWebViewForCurrentTest):
3021         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3022         * WebKitTestRunner/TestController.cpp:
3023         (WTR::TestController::resetStateToConsistentValues):
3024         * WebKitTestRunner/TestController.h:
3025         * WebKitTestRunner/TestInvocation.cpp:
3026         (WTR::sizeWebViewForCurrentTest):
3027         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3028         (WTR::PlatformWebView::PlatformWebView):
3029         (WTR::PlatformWebView::resizeTo):
3030
3031 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3032
3033         [EFL] Fix build error after r148963.
3034         https://bugs.webkit.org/show_bug.cgi?id=115126
3035
3036         Reviewed by Laszlo Gombos.
3037
3038         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3039
3040         * TestWebKitAPI/PlatformEfl.cmake:
3041
3042 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3043
3044         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3045         https://bugs.webkit.org/show_bug.cgi?id=115118
3046
3047         Reviewed by Martin Robinson.
3048
3049         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3050         forwarding generator rules and don't call it for soup since there
3051         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3052
3053         * TestWebKitAPI/GNUmakefile.am:
3054         * WebKitTestRunner/GNUmakefile.am:
3055
3056 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3057
3058         [GTK] Update build dependencies
3059         https://bugs.webkit.org/show_bug.cgi?id=115111
3060
3061         Reviewed by Martin Robinson.
3062
3063         The install-dependencies script was missing a dependency on EGL,
3064         which is expected when building Cairo.
3065
3066         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3067         for both apt and yum.
3068
3069 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3070
3071         Remove the Chromium-specific helper from run_webkit_tests.py
3072         https://bugs.webkit.org/show_bug.cgi?id=114996
3073
3074         Reviewed by Dirk Pranke.
3075
3076         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3077         (parse_args):
3078
3079 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3080
3081         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3082         https://bugs.webkit.org/show_bug.cgi?id=114850
3083
3084         Reviewed by Andreas Kling.
3085
3086         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3087         termination semantics when requested by the user so that a client is not
3088         notified of a crash anymore, since there was no crash anyway.
3089
3090         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3091         relied on being notified of a crash after calling WKPageTerminate(). As
3092         a result of not being notified of such non-existent crash, the test would
3093         timeout right after making the terminate call.
3094
3095         This patch adds an InjectedBundle to be used for simulating a crash, by
3096         calling abort() upon receiving a "Crash" message, and thus we are able to
3097         keep testing the crash callback.
3098
3099         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3100         had been disabled in revisions r148858 and r148855, since it was failing.
3101
3102         * TestWebKitAPI/PlatformEfl.cmake:
3103         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3104         (TestWebKitAPI::TEST):
3105         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3106         (TestWebKitAPI):
3107         (WKViewClientWebProcessCallbacksTest):
3108         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3109         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3110
3111 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3112
3113         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3114         https://bugs.webkit.org/show_bug.cgi?id=115095
3115
3116         Reviewed by Antonio Gomes.
3117
3118         Use different subfolders under DumpRenderTree Temp folder for every
3119         functionality (icon database, cache, localstorage, ...). This makes
3120         sure there is no conflict between the functionalities.
3121
3122         In EFL's case, libsoup cache was causing problems for the icon
3123         database if sharing the same folder.
3124
3125         * WebKitTestRunner/TestController.cpp:
3126         (WTR::TestController::initialize):
3127
3128 == Rolled over to ChangeLog-2013-04-24 ==