47e506fe3e98883bb6c967dd05bdec0b6d9749b5
[WebKit-https.git] / Tools / ChangeLog
1 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
2
3         results.webkit.org: Increase default limit for LimitSlider
4         https://bugs.webkit.org/show_bug.cgi?id=201424
5
6         Reviewed by Aakash Jain.
7
8         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
9         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
10
11 2019-09-03  Antoine Quint  <graouts@apple.com>
12
13         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
14         https://bugs.webkit.org/show_bug.cgi?id=201420
15         <rdar://problem/53207786>
16
17         Reviewed by Simon Fraser.
18
19         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
20         -[HIDEventGenerator twoFingerTap:completionBlock:].
21
22         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
23         * TestRunnerShared/UIScriptContext/UIScriptController.h:
24         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
25         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
26         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
27         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
28
29 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
30
31         [WPE] MiniBrowser should handle the WebKitWebView::create signal
32         https://bugs.webkit.org/show_bug.cgi?id=201417
33
34         Reviewed by Carlos Garcia Campos.
35
36         WPE's MiniBrowser should connect to and handle the
37         WebKitWebView::create signal, constructing a new bit related
38         WebKitWebView object upon invocation.
39
40         * MiniBrowser/wpe/main.cpp:
41         (webViewClose):
42         (createWebView):
43         (main):
44
45 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
46
47         [WPE] Make view backends multi-view-friendly
48         https://bugs.webkit.org/show_bug.cgi?id=201415
49
50         Reviewed by Carlos Garcia Campos.
51
52         Have the Wayland EGL connection for WindowViewBackend instances managed
53         through a per-process singleton, allowing multiple backend objects
54         use it for different views. HeadlessViewBackend already does this, but
55         the code there is refurbished into a singleton structure.
56
57         The ViewBackend classes are adjusted to work with the backend-specific
58         EGLDisplay objects (as constructed through the backend-specific EGL
59         connection approach).
60
61         * wpe/backends/HeadlessViewBackend.cpp:
62         (WPEToolingBackends::HeadlessEGLConnection::singleton):
63         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
64         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
65         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
66         (WPEToolingBackends::getEGLDisplay): Deleted.
67         * wpe/backends/ViewBackend.cpp:
68         (WPEToolingBackends::ViewBackend::initialize):
69         (WPEToolingBackends::ViewBackend::deinitialize):
70         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
71         * wpe/backends/ViewBackend.h:
72         * wpe/backends/WindowViewBackend.cpp:
73         (WPEToolingBackends::WaylandEGLConnection::singleton):
74         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
75         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
76         (WPEToolingBackends::WindowViewBackend::displayBuffer):
77
78 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
79
80         [WPE][GTK] Deprecate nonfunctional process limit APIs
81         https://bugs.webkit.org/show_bug.cgi?id=193749
82
83         Reviewed by Žan Doberšek.
84
85         * MiniBrowser/gtk/main.c:
86         (main):
87         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
88         (beforeAll):
89         (testWebProcessLimit): Deleted.
90
91 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
92
93         [WPE] WindowBackend should do resizing properly
94         https://bugs.webkit.org/show_bug.cgi?id=201386
95
96         Reviewed by Carlos Garcia Campos.
97
98         The WindowBackend implementation is resized via the XDG protocol. The
99         initial size is stored for the object's lifetime and fallen back to when
100         the XDG protocol reports (0,0) configuration size.
101
102         Upon each resize, we have to recreate the texture. We also have to size
103         the GL viewport accordingly.
104
105         * wpe/backends/WindowViewBackend.cpp:
106         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
107         (WPEToolingBackends::WindowViewBackend::createViewTexture):
108         (WPEToolingBackends::WindowViewBackend::resize):
109         (WPEToolingBackends::WindowViewBackend::displayBuffer):
110         * wpe/backends/WindowViewBackend.h:
111
112 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
113
114         Unreviewed, rolling out r249366.
115
116         WinCairo WebKit2 crashes in some websites and the device scale
117         factor is not correct in high DPI.
118
119         Reverted changeset:
120
121         "[WinCairo, FTW] Properly handle device scale factor"
122         https://bugs.webkit.org/show_bug.cgi?id=201361
123         https://trac.webkit.org/changeset/249366
124
125 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
126
127         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
128         https://bugs.webkit.org/show_bug.cgi?id=201346
129         <rdar://problem/54885784>
130
131         Reviewed by Dean Jackson.
132
133         Add a new test option to allow tests to disable link previews.
134
135         * WebKitTestRunner/TestController.cpp:
136         (WTR::updateTestOptionsFromTestHeader):
137         * WebKitTestRunner/TestOptions.h:
138
139         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
140
141         (WTR::TestOptions::hasSameInitializationOptions const):
142         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
143         (WTR::TestController::platformCreateWebView):
144
145 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
146
147         [WinCairo, FTW] Properly handle device scale factor
148         https://bugs.webkit.org/show_bug.cgi?id=201361
149
150         Reviewed by Don Olmstead.
151
152         Reset zoom to 1.0; device scale is handled elsewhere.
153
154         * MiniBrowser/win/WebKitBrowserWindow.cpp:
155         (WebKitBrowserWindow::resetZoom):
156
157 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
158
159         [results.webkit.org Timeline] Add notify rerender API for timeline
160         https://bugs.webkit.org/show_bug.cgi?id=201363
161
162         Reviewed by Jonathan Bedard.
163
164         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
165         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
166         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
167         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
168         (prototype.Timeline.CanvasContainer):
169
170 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
171
172         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
173         https://bugs.webkit.org/show_bug.cgi?id=201350
174
175         Reviewed by Jonathan Bedard.
176
177         * BuildSlaveSupport/ews-build/steps.py:
178         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
179         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
180
181 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
182
183         results.webkit.org: Add endpoints to upload and download archives
184         https://bugs.webkit.org/show_bug.cgi?id=201100
185
186         Reviewed by Aakash Jain.
187
188         Add the endpoint to upload and download a zip archive associated with a test run.
189
190         * resultsdbpy/resultsdbpy/controller/api_routes.py:
191         (APIRoutes.__init__): Add archive endpoint.
192         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
193         (ArchiveController):
194         (ArchiveController.__init__):
195         (ArchiveController.endpoint):
196         (ArchiveController.download):
197         (ArchiveController.upload):
198         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
199         (ArchiveControllerUnittest):
200         * resultsdbpy/resultsdbpy/model/configuration_context.py:
201         (ClusteredByConfiguration.register_configuration): Make error message more clear.
202
203 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
204
205         Add system tracing points for compositing updates, and touch-event dispatching
206         https://bugs.webkit.org/show_bug.cgi?id=201327
207
208         Reviewed by Alex Christensen.
209
210         * Tracing/SystemTracePoints.plist:
211
212 2019-08-30  Keith Rollin  <krollin@apple.com>
213
214         Simplify PLATFORM expression
215         https://bugs.webkit.org/show_bug.cgi?id=201286
216         <rdar://problem/54822347>
217
218         Reviewed by Alexey Proskuryakov.
219
220         The preprocessor expression conditionalizing the inclusion of the body
221         of ExitFullscreenOnEnterPiP.mm evolved into:
222
223             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
224
225         Simplify this to just:
226
227             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
228
229         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
230
231 2019-08-30  Keith Rollin  <krollin@apple.com>
232
233         Remove AppKitCompatibilityDeclarations.h
234         https://bugs.webkit.org/show_bug.cgi?id=201283
235         <rdar://problem/54822042>
236
237         Reviewed by Alexey Proskuryakov.
238
239         The two copies of these files -- on in WTF, one in MiniBrowser -- are
240         empty and can be removed.
241
242         * DumpRenderTree/mac/EventSendingController.mm:
243         * DumpRenderTree/mac/TextInputControllerMac.m:
244         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
245         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
246         * MiniBrowser/mac/SettingsController.m:
247         * MiniBrowser/mac/WK1BrowserWindowController.m:
248         * MiniBrowser/mac/WK2BrowserWindowController.m:
249         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
250         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
251         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
252         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
253         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
254         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
255         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
256         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
257         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
258         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
259         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
260         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
261         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
262         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
263         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
264         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
265         * TestWebKitAPI/cocoa/TestWKWebView.mm:
266         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
267         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
268         * WebKitTestRunner/mac/EventSenderProxy.mm:
269         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
270         * WebKitTestRunner/mac/TestControllerMac.mm:
271
272 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
273
274         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
275         https://bugs.webkit.org/show_bug.cgi?id=200479
276
277         Reviewed by Carlos Garcia Campos.
278
279         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
280         (testUserContentManagerContentFilter): Test also the new
281         webkit_user_content_manager_remove_filter_by_id() public API function.
282
283 2019-08-30  Philippe Normand  <pnormand@igalia.com>
284
285         [WPE][Qt] loadingChanged signal parameter is unusable
286         https://bugs.webkit.org/show_bug.cgi?id=201301
287
288         Reviewed by Carlos Garcia Campos.
289
290         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
291         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
292         readablity/parameter_name code styl checker rule.
293
294 2019-08-29  Keith Rollin  <krollin@apple.com>
295
296         Update .xcconfig symbols to reflect the current set of past and future product versions.
297         https://bugs.webkit.org/show_bug.cgi?id=200720
298         <rdar://problem/54305032>
299
300         Reviewed by Alex Christensen.
301
302         Remove version symbols related to old OS's we no longer support,
303         ensure that version symbols are defined for OS's we do support.
304
305         * ContentExtensionTester/Configurations/Base.xcconfig:
306         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
307         * DumpRenderTree/mac/Configurations/Base.xcconfig:
308         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
309         * ImageDiff/cg/Configurations/Base.xcconfig:
310         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
311         * MiniBrowser/Configurations/Base.xcconfig:
312         * MiniBrowser/Configurations/DebugRelease.xcconfig:
313         * TestWebKitAPI/Configurations/Base.xcconfig:
314         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
315         * WebEditingTester/Configurations/Base.xcconfig:
316         * WebEditingTester/Configurations/DebugRelease.xcconfig:
317         * WebKitTestRunner/Configurations/Base.xcconfig:
318         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
319         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
320         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
321
322 2019-08-29  Keith Rollin  <krollin@apple.com>
323
324         Remove empty FontCache.cpp file in TestWebKitAPI
325         https://bugs.webkit.org/show_bug.cgi?id=201277
326         <rdar://problem/54820726>
327
328         Reviewed by Alex Christensen.
329
330         Bug 200694 emptied out the contents of FontCache.cpp. This patch
331         removes the file from the project.
332
333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
334         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
335
336 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
337
338         [ews-app] Status bubble should only display important messages in pop-over
339         https://bugs.webkit.org/show_bug.cgi?id=201308
340
341         Reviewed by Jonathan Bedard.
342
343         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
344         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
345
346 2019-08-29  Keith Rollin  <krollin@apple.com>
347
348         Remove support for macOS < 10.13 (part 3)
349         https://bugs.webkit.org/show_bug.cgi?id=201224
350         <rdar://problem/54795934>
351
352         Reviewed by Darin Adler.
353
354         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
355         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
356         like _MACOS_SINCE_1013.
357
358         Also added some macOS target numbers.
359
360         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
361
362 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
363
364         results.webkit.org: Remove border from tooltip
365         https://bugs.webkit.org/show_bug.cgi?id=201239
366
367         Reviewed by Alex Christensen.
368
369         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
370         (.tooltip-content): Remove border.
371
372 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
373
374         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
375         https://bugs.webkit.org/show_bug.cgi?id=201215
376
377         Reviewed by Don Olmstead.
378
379         MiniBrowser crashed if it was going to go to a unreachable page
380         because WKPageCopyActiveURL returned a nullptr.
381
382         * MiniBrowser/win/WebKitBrowserWindow.cpp:
383         (createString): Added null checking of the argument.
384
385 2019-08-28  Tim Horton  <timothy_horton@apple.com>
386
387         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
388         https://bugs.webkit.org/show_bug.cgi?id=201256
389         <rdar://problem/54809509>
390
391         Reviewed by Simon Fraser.
392
393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
394         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
395         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
396         (TestWebKitAPI::TEST):
397         Add a test. I left many comments because I had a great deal of trouble
398         writing this test and wanted to document my findings.
399
400 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
401
402         results.webkit.org: Do not display branch selector if only one branches available
403         https://bugs.webkit.org/show_bug.cgi?id=201244
404
405         Rubber-stamped by Aakash Jain.
406
407         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
408         container if there aren't multiple branches to choose from.
409
410 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
411
412         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
413         https://bugs.webkit.org/show_bug.cgi?id=201241
414         <rdar://problem/54317588>
415
416         Reviewed by Tim Horton.
417
418         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
419         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
420         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
421         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
422         it believes that the web view has rejected the drop from being handled.
423
424         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
425         to make sure that the web process has had time to send a response after each update.
426
427         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
428         (-[DragAndDropSimulator _advanceProgress]):
429
430 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
431
432         Null check webFrame when creating a print preview to prevent a crash.
433         https://bugs.webkit.org/show_bug.cgi?id=201237
434         <rdar://problem/51618863>
435
436         Reviewed by Tim Horton.
437
438         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
439
440         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
441         (TEST):
442
443 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
444
445         results.webkit.org: Move drawer to the right, open by default
446         https://bugs.webkit.org/show_bug.cgi?id=200977
447
448         Rubber-stamped by Aakash Jain.
449
450         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
451         moving the drawer to the right side of the screen, opening it by default and have it displace
452         instead of hide the main content.
453
454         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
455         (CommitViewUnittest.test_drawer): Support new drawer style.
456         (CommitViewUnittest.test_range_slider): Ditto.
457         (CommitViewUnittest.test_one_line_switch): Ditto.
458         (CommitViewUnittest.test_branch_selection): Ditto.
459         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
460         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
461         (setEnableRecursive): Disable all elements underneath this one 
462         (Drawer): Make drawer a sidebar.
463         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
464         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
465         (:root): Move boldInverseColor into webkit.css.
466         (@media (prefers-color-scheme: dark)):
467         (.sidebar): Sidebars on mobile should behave like drawers.
468         (.sidebar.hidden): Add concept of hidden sidebar.
469         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
470         (.mobile-sidebar-control.display):
471         (.main.under-topbar-with-actions):
472         (@media screen and (min-width: 600px) and (orientation: landscape)):
473         (.sidebar.left.hidden):
474         (.sidebar.right.hidden):
475         (.main.right.hidden):
476         (.main.left.hidden):
477         (@media screen and (min-width: 768px) and (orientation: landscape)):
478         (.sidebar.right):
479         (a.disabled): Add ability to disable a link.
480         (.desktop-control): Add a control which only exists on desktop.
481         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
482         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
483         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
484         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
485         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
486         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
487         (WebSiteTestCase.toggle_drawer): Support new drawer style.
488         (WebSiteTestCase.find_input_with_name): Ditto.
489
490 2019-08-28  Keith Rollin  <krollin@apple.com>
491
492         Remove support for macOS < 10.13 (part 2)
493         https://bugs.webkit.org/show_bug.cgi?id=201197
494         <rdar://problem/54759985>
495
496         Reviewed by Darin Adler.
497
498         Update conditionals that reference WK_MACOS_1013 and suffixes like
499         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
500         later and that these conditionals are always True or False.
501
502         See Bug 200694 for earlier changes in this area.
503
504         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
505
506 2019-08-28  Alicia Boya García  <aboya@igalia.com>
507
508         [MSE][GStreamer] WebKitMediaSrc rework
509         https://bugs.webkit.org/show_bug.cgi?id=199719
510
511         Reviewed by Xabier Rodriguez-Calvar.
512
513         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
514         whitelist.
515
516         * Scripts/webkitpy/style/checker.py:
517
518 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
519
520         Updating inactive contributors in contributors.json.
521
522         * Scripts/webkitpy/common/config/contributors.json:
523
524 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
525
526         results.webkit.org: Auto-expand single configurations
527         https://bugs.webkit.org/show_bug.cgi?id=201218
528
529         Rubber-stamped by Aakash Jain.
530
531         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
532         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
533         configuration has been specified.
534         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
535         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
536         is expanded or collapsed by default.
537
538 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
539
540         results.webkit.org: Sanitize all commit arguments on upload
541         https://bugs.webkit.org/show_bug.cgi?id=201189
542         <rdar://problem/54564837>
543
544         Reviewed by Aakash Jain.
545
546         * resultsdbpy/resultsdbpy/controller/commit.py:
547         (Commit.__init__): Only allow commits to be constructed with valid values.
548         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
549         (CommitController.register): Strip potential API key.
550         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
551         (CommitUnittest.test_invalid): Test that commits which contain html inside the
552         repository_id, branch or commit id are rejected.
553
554 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
555
556         [GTK][WPE] Implement HSTS for the soup network backend
557         https://bugs.webkit.org/show_bug.cgi?id=192074
558
559         Reviewed by Carlos Garcia Campos.
560
561         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
562         Add support to the soup network backend by adding the feature to
563         SoupNetworkSession and handling HSTS protocol upgrades, by
564         propagating the scheme change further to clients. This patch adds
565         the HSTS feature unconditionally, but it still possible to add
566         a boolean property to the web context class if desired.
567
568         Additionally, add API to the WebKitWebsiteDataManager to specify
569         the directory where the HSTS database is saved. If the directory
570         is not set or if the data manager is ephemeral, use a
571         non-persistent, memory only HSTS enforcer.
572
573         Implement as well the methods needed to clean-up and delete HSTS
574         policies from the storage and expose the feature in GTK+
575         MiniBrowser's about:data.
576
577         * MiniBrowser/gtk/main.c:
578         (gotWebsiteDataCallback):
579         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
580         (serverCallback):
581         (testWebsiteDataConfiguration):
582         (testWebsiteDataEphemeral):
583         (prepopulateHstsData):
584         (testWebsiteDataHsts):
585         (beforeAll):
586         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
587         (Test::Test):
588         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
589         * wpe/jhbuild.modules: Ditto
590         * MiniBrowser/gtk/main.c:
591         (gotWebsiteDataCallback):
592
593 2019-08-27  James Darpinian  <jdarpinian@google.com>
594
595         Fix applying diffs that only change file mode
596         https://bugs.webkit.org/show_bug.cgi?id=201191
597
598         Reviewed by Daniel Bates.
599
600         * Scripts/svn-apply:
601         (patch): Handle case of file mode change without content change
602
603 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
604
605         [ews] Status bubble should be red for CANCELLED builds
606         https://bugs.webkit.org/show_bug.cgi?id=201204
607
608         Reviewed by Jonathan Bedard.
609
610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
611         (StatusBubble._build_bubble):
612
613 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
614
615         [results.webkit.org Webkit.css] Center the legend symbols
616         https://bugs.webkit.org/show_bug.cgi?id=201187
617
618         Reviewed by Jonathan Bedard.
619
620         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
621         (.lengend>.item .dot .text): center the dot symbol vertically
622
623 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
624
625         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
626         https://bugs.webkit.org/show_bug.cgi?id=201000
627         <rdar://problem/53778938>
628
629         Unreviewed follow-up fix.
630
631         * Scripts/webkitpy/port/darwin.py:
632         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
633         spindump call failed.
634         * Scripts/webkitpy/port/darwin_testcase.py:
635         * Scripts/webkitpy/port/ios_device_unittest.py:
636
637 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
638
639         [ews-build] Use update-webkit script in Apply-WatchList EWS
640         https://bugs.webkit.org/show_bug.cgi?id=201179
641
642         Reviewed by Jonathan Bedard.
643
644         * BuildSlaveSupport/ews-build/factories.py:
645         (WatchListFactory): Updated to use CheckOutSource step as well.
646
647 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
648
649         W3C test importer should be able to handle expected references with an absolute path.
650         https://bugs.webkit.org/show_bug.cgi?id=200717
651
652         Reviewed by Youenn Fablet.
653
654         This patch implements the logic to resolve test references with absolute paths
655         when importing w3c tests (like web-platform-tests).
656         When an absolute path is found for a test reference, the parser now
657         tries to find the right file by looking for a relative path inside
658         the root directory of the source test repository.
659         It works when the tool is run in download-mode as well as when the
660         tool is run to import the tests from a local directory.
661
662         This fixes the import of test references for tests like
663         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
664
665         * Scripts/webkitpy/w3c/test_importer.py:
666         (TestImporter._source_root_directory_for_path):
667         (TestImporter.find_importable_tests):
668         * Scripts/webkitpy/w3c/test_importer_unittest.py:
669         (TestImporterTest.import_directory):
670         (test_webkit_test_runner_options):
671         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
672         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
673         * Scripts/webkitpy/w3c/test_parser.py:
674         (TestParser.__init__):
675         (TestParser.analyze_test):
676
677 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
678
679         Remove UIHelper.activateElementAtHumanSpeed
680         https://bugs.webkit.org/show_bug.cgi?id=201147
681
682         Reviewed by Tim Horton.
683
684         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
685         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
686         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
687
688         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
689         * TestRunnerShared/UIScriptContext/UIScriptController.h:
690         (WTR::UIScriptController::doAfterDoubleTapDelay):
691         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
692         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
693         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
694
695 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
696
697         [results.webkit.org Timline] Add symbols to the timeline dot
698         https://bugs.webkit.org/show_bug.cgi?id=201105
699
700         Reviewed by Jonathan Bedard.
701
702         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
703         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
704         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
705         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
706
707 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
708
709         Unreviewed, remove useMaximalFlushInsertionPhase use
710         https://bugs.webkit.org/show_bug.cgi?id=201036
711
712         * Scripts/run-jsc-stress-tests:
713
714 2019-08-26  David Kilzer  <ddkilzer@apple.com>
715
716         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
717         <https://webkit.org/b/201144>
718         <rdar://problem/54689399>
719
720         Reviewed by Brent Fulgham.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
723         DataDetectorsTestIOS.mm to the project.
724         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
725         test for Data Detectors for phone numbers.
726
727 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
728
729         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
730         https://bugs.webkit.org/show_bug.cgi?id=201129
731         <rdar://problem/51857277>
732
733         Reviewed by Tim Horton.
734
735         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
736         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
737         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
738         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
739         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
740         capable of recognizing further touches yet.
741
742         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
743         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
744         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
745         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
746         allows both of them to be reset.
747
748         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
749         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
750         immediately after sending the first tap. This change in dependencies is caused by the introduction of
751         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
752         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
753         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
754         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
755
756         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
757         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
758         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
759         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
760         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
761         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
762         requiring arbitrary 120 ms "human speed" delays.
763
764         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
765
766         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
767         * TestRunnerShared/UIScriptContext/UIScriptController.h:
768         (WTR::UIScriptController::doubleTapAtPoint):
769
770         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
771         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
772         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
773         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
774         recognized only as a single tap instead of a double tap.
775
776         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
777         gestures use instead to wait after simulating the first tap.
778
779         * WebKitTestRunner/ios/HIDEventGenerator.h:
780         * WebKitTestRunner/ios/HIDEventGenerator.mm:
781         (-[HIDEventGenerator _waitFor:]):
782         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
783
784         Plumb the tap gesture delay through to this helper method.
785
786         (-[HIDEventGenerator tap:completionBlock:]):
787         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
788         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
789         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
790         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
791         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
792         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
793         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
794
795         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
796         attempting to simulate single taps (either using a stylus, or with a regular touch).
797
798         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
799         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
800         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
801
802 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
803
804         results.webkit.org: Allow clicking on the tooltip arrow
805         https://bugs.webkit.org/show_bug.cgi?id=201103
806
807         Rubber-stamped by Aakash Jain.
808
809         By design, the arrow sits above the canvas and intercepts mouse events from it.
810         This will often make an element that has a tooltip unclickable.
811
812         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
813         (xAxisFromScale):
814         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
815         (TimelineFromEndpoint.prototype.render):
816         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
817         (_ToolTip):
818         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
819         (_ToolTip.prototype.set): Set the onClick callback.
820
821 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
822
823         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
824         https://bugs.webkit.org/show_bug.cgi?id=201140
825
826         Reviewed by Jonathan Bedard.
827
828         * BuildSlaveSupport/ews-build/steps.py:
829         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
830         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
831
832 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
833
834         run-webkit-tests: Cap the number of automatically booted simulators at 12
835         https://bugs.webkit.org/show_bug.cgi?id=201139
836
837         Reviewed by Aakash Jain.
838
839         To make local development with simulators more pleasant, machines should
840         never automatically boot more than 12 simulators.
841
842         * Scripts/webkitpy/xcode/simulated_device.py:
843         (SimulatedDeviceManager.max_supported_simulators):
844
845 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
846
847         [ews] Add EWS queue for applying watchlist
848         https://bugs.webkit.org/show_bug.cgi?id=201072
849
850         Reviewed by Jonathan Bedard.
851
852         * BuildSlaveSupport/ews-build/steps.py:
853         (ApplyWatchList): Build step to apply watchlist.
854         (ApplyWatchList.__init__): Set logEnviron to False.
855         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
856         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
857         * BuildSlaveSupport/ews-build/factories.py:
858         (WatchListFactory): Build factory for WatchList.
859         * BuildSlaveSupport/ews-build/loadConfig.py:
860         * BuildSlaveSupport/ews-build/config.json:
861
862 2019-08-26  Youenn Fablet  <youenn@apple.com>
863
864         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
865         https://bugs.webkit.org/show_bug.cgi?id=196870
866
867         Reviewed by Alex Christensen.
868
869         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
870         Accept any server certificate by default.
871
872         * WebKitTestRunner/TestController.cpp:
873         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
874         (WTR::TestController::cocoaResetStateToConsistentValues):
875         (WTR::TestController::setAllowsAnySSLCertificate):
876         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
877         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
878         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
879         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
880
881 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
882
883         Increase log level for watchlist result
884         https://bugs.webkit.org/show_bug.cgi?id=201081
885
886         Reviewed by Jonathan Bedard.
887
888         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
889         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
890         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
891
892 2019-08-23  Chris Dumez  <cdumez@apple.com>
893
894         [geolocation] Rename interfaces and remove [NoInterfaceObject]
895         https://bugs.webkit.org/show_bug.cgi?id=200885
896
897         Reviewed by Alex Christensen.
898
899         * DumpRenderTree/mac/TestRunnerMac.mm:
900         (TestRunner::setMockGeolocationPosition):
901
902 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
903
904         Unreviewed, rolling out r249001.
905
906         Caused one layout test to fail on all configurations and
907         another to time out on Catalina / iOS 13.
908
909         Reverted changeset:
910
911         "Add a WebsiteDataStore delegate to handle
912         AuthenticationChallenge that do not come from pages"
913         https://bugs.webkit.org/show_bug.cgi?id=196870
914         https://trac.webkit.org/changeset/249001
915
916 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
917
918         results.webkit.org: Escape html in changelog
919         https://bugs.webkit.org/show_bug.cgi?id=201025
920         <rdar://problem/54564837>
921
922         Reviewed by Darin Adler.
923
924         * resultsdbpy/resultsdbpy/view/commit_view.py:
925         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
926         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
927         directly into a JavaScript dictionary.
928
929 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
930
931         [WebAuthn] Support NFC authenticators for iOS
932         https://bugs.webkit.org/show_bug.cgi?id=188624
933         <rdar://problem/43354214>
934
935         Reviewed by Chris Dumez.
936
937         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
938         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
939         Setup NFC mock testing configuration.
940
941 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
942
943         [ews] Enable Style queue on new EWS
944         https://bugs.webkit.org/show_bug.cgi?id=201071
945
946         Reviewed by Jonathan Bedard.
947
948         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
949         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
950         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
952         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
953
954 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
955
956         [Win][MiniBrowser] URL bar should be updated for in-page navigations
957         https://bugs.webkit.org/show_bug.cgi?id=201032
958
959         Reviewed by Darin Adler.
960
961         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
962         * MiniBrowser/win/MainWindow.cpp:
963         (MainWindow::init):
964         (MainWindow::activeURLChanged): Added.
965         * MiniBrowser/win/MainWindow.h:
966         * MiniBrowser/win/MiniBrowserWebHost.cpp:
967         (MiniBrowserWebHost::didCommitLoadForFrame):
968         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
969         (MiniBrowserWebHost::updateAddressBar): Deleted.
970         (MiniBrowserWebHost::loadURL): Deleted.
971         * MiniBrowser/win/MiniBrowserWebHost.h:
972         (MiniBrowserWebHost::MiniBrowserWebHost):
973         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
974         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
975         * MiniBrowser/win/PrintWebUIDelegate.cpp:
976         * MiniBrowser/win/WebKitBrowserWindow.cpp:
977         (WebKitBrowserWindow::create):
978         (WebKitBrowserWindow::WebKitBrowserWindow):
979         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
980         (WebKitBrowserWindow::didChangeActiveURL): Added.
981         (WebKitBrowserWindow::createNewPage):
982         (WebKitBrowserWindow::didCommitNavigation): Deleted.
983         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
984         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
985         (WebKitLegacyBrowserWindow::create):
986         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
987         (WebKitLegacyBrowserWindow::init):
988         (WebKitLegacyBrowserWindow::navigateToHistory):
989         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
990
991 2019-08-22  Andy Estes  <aestes@apple.com>
992
993         [watchOS] Disable Content Filtering in the simulator build
994         https://bugs.webkit.org/show_bug.cgi?id=201047
995
996         Reviewed by Tim Horton.
997
998         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
999
1000 2019-08-22  Chris Dumez  <cdumez@apple.com>
1001
1002         Try to recover nicely when getting an unexpected schema in the service workers database
1003         https://bugs.webkit.org/show_bug.cgi?id=201002
1004         <rdar://problem/54574991>
1005
1006         Reviewed by Youenn Fablet.
1007
1008         Add API test coverage.
1009
1010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1011         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1012
1013 2019-08-22  Keith Rollin  <krollin@apple.com>
1014
1015         Remove support for tvOS < 13.0
1016         https://bugs.webkit.org/show_bug.cgi?id=200963
1017         <rdar://problem/54541355>
1018
1019         Reviewed by Tim Horton.
1020
1021         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
1022         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
1023         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
1024         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
1025         130000" are always True.
1026
1027         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1028         (TestWebKitAPI::TEST):
1029
1030 2019-08-22  Daniel Bates  <dabates@apple.com>
1031
1032         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
1033         https://bugs.webkit.org/show_bug.cgi?id=200742
1034
1035         Reviewed by Simon Fraser.
1036
1037         The OptionSet synthetic provider must respond to requests for the value of m_storage
1038         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
1039         of the type summary.
1040
1041         Synthetic providers substitute alternative debug information (children) for the default
1042         information for a variable. The OptionSet type summary is implemented in terms of the
1043         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
1044         before invoking the type summary handler then evaluating GetChildMemberWithName() on
1045         the SBValue passed to the type summary handler will access the substitute information
1046         instead of the original debug information. As a result OptionSet's synthetic provider's
1047         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
1048         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
1049         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
1050         should return a valid value.
1051
1052         * lldb/lldb_webkit.py:
1053         (FlagEnumerationProvider.__init__):
1054         (FlagEnumerationProvider):
1055         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
1056         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
1057         (FlagEnumerationProvider.size): Added.
1058         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
1059         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
1060         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
1061         and removed self.size. For the latter we can just expose a getter that returns the size of
1062         the list self._elements.
1063         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
1064         value of m_storage.
1065         (WTFOptionSetProvider):
1066         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
1067         matches the specified index.
1068         * lldb/lldb_webkit_unittest.py:
1069         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
1070         that we return the value of m_storage as the last synthetic child.
1071
1072 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
1073
1074         results.webkit.org: Remove branch and repository information from commit tooltip
1075         https://bugs.webkit.org/show_bug.cgi?id=201035
1076
1077         Reviewed by Aakash Jain.
1078
1079         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1080         (xAxisFromScale): Remove branch and repository information from tooltip.
1081
1082 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
1083
1084         run-webkit-tests: Use -noBulkSymbolication when calling spindump
1085         https://bugs.webkit.org/show_bug.cgi?id=201000
1086         <rdar://problem/53778938>
1087
1088         Reviewed by Alexey Proskuryakov.
1089
1090         * Scripts/webkitpy/port/darwin.py:
1091         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
1092         * Scripts/webkitpy/port/darwin_testcase.py:
1093         (DarwinTest.test_tailspin):
1094         (DarwinTest.test_get_crash_log): Deleted.
1095         * Scripts/webkitpy/port/ios_device_unittest.py:
1096         (IOSDeviceTest.test_tailspin):
1097
1098 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
1099
1100         [results.webkit.org Webkit.css] Change input's disable style
1101         The disable input style will always show the label like it has a value 
1102         https://bugs.webkit.org/show_bug.cgi?id=200998
1103
1104         Reviewed by Jonathan Bedard.
1105
1106         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
1107         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
1108         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1109         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1110         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
1111         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
1112         (@media (prefers-color-scheme: dark)):
1113
1114 2019-08-17  Darin Adler  <darin@apple.com>
1115
1116         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
1117         https://bugs.webkit.org/show_bug.cgi?id=200862
1118
1119         Reviewed by Ryosuke Niwa.
1120
1121         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1122         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
1123         * WebKitTestRunner/TestController.cpp:
1124         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
1125         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
1126         (WTR::TestController::downloadDidFail): Ditto.
1127
1128 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
1129
1130         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
1131         https://bugs.webkit.org/show_bug.cgi?id=200978
1132
1133         Unreviewed follow-up fix.
1134
1135         Update the string format specifier for unsigned it.
1136
1137         * MiniBrowser/gtk/main.c:
1138         (main):
1139         * MiniBrowser/wpe/main.cpp:
1140         (main):
1141
1142 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1143
1144         [GTK][WPE] Support for command "--version" on the MiniBrowser
1145         https://bugs.webkit.org/show_bug.cgi?id=200978
1146
1147         Reviewed by Žan Doberšek.
1148
1149         Printing the engine version used from the MiniBrowser is useful.
1150         For example, the test scripts on WPT can use this info to better
1151         tag the generated results.
1152
1153         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
1154         (main):
1155         * MiniBrowser/wpe/main.cpp: Ditto.
1156         (main):
1157
1158 2019-08-22  Youenn Fablet  <youenn@apple.com>
1159
1160         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
1161         https://bugs.webkit.org/show_bug.cgi?id=196870
1162
1163         Reviewed by Alex Christensen.
1164
1165         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
1166         Accept any server certificate by default.
1167
1168         * WebKitTestRunner/TestController.cpp:
1169         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1170         (WTR::TestController::cocoaResetStateToConsistentValues):
1171         (WTR::TestController::setAllowsAnySSLCertificate):
1172         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
1173         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1174         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
1175         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
1176
1177 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
1178
1179         results.webkit.org: Fix drawer style
1180         https://bugs.webkit.org/show_bug.cgi?id=200988
1181
1182         Rubber-stamped by Aakash Jain.
1183
1184         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1185         (Drawer): Nothing in the drawer should be selectable.
1186         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
1187         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1188         (.action:hover): Disable underline on 'links' which are actually actions
1189         (.unselectable): Make a div unselectable.
1190         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1191         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
1192
1193 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1194
1195         [Win][MiniBrowser] Add a progress indicator to the main window
1196         https://bugs.webkit.org/show_bug.cgi?id=200970
1197
1198         Reviewed by Alex Christensen.
1199
1200         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
1201         * MiniBrowser/win/MainWindow.cpp:
1202         (MainWindow::init):
1203         (MainWindow::resizeSubViews):
1204         (MainWindow::progressChanged):
1205         (MainWindow::progressFinished):
1206         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
1207         Added m_hProgressIndicator.
1208         (MainWindow::hwnd const): Deleted.
1209         (MainWindow::browserWindow const): Deleted.
1210         (): Deleted.
1211         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1212         (MiniBrowserWebHost::onNotify):
1213         * MiniBrowser/win/MiniBrowserWebHost.h:
1214         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1215         (WebKitBrowserWindow::create):
1216         (WebKitBrowserWindow::WebKitBrowserWindow):
1217         (WebKitBrowserWindow::didChangeIsLoading):
1218         (WebKitBrowserWindow::didChangeEstimatedProgress):
1219         (WebKitBrowserWindow::createNewPage):
1220         * MiniBrowser/win/WebKitBrowserWindow.h:
1221         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1222         (WebKitLegacyBrowserWindow::create):
1223         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1224         (WebKitLegacyBrowserWindow::init):
1225         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1226
1227 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
1228
1229         Unreviewed, rolling out r248970.
1230
1231         Caused
1232         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
1233         to fail.
1234
1235         Reverted changeset:
1236
1237         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
1238         non-empty set"
1239         https://bugs.webkit.org/show_bug.cgi?id=200742
1240         https://trac.webkit.org/changeset/248970
1241
1242 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
1243
1244         results.webkit.org: Add database table to save zip archives to
1245         https://bugs.webkit.org/show_bug.cgi?id=200718
1246
1247         Rubber-stamped by Aakash Jain.
1248
1249         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
1250         (ArchiveContext):
1251         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
1252         (ArchiveContext.ArchivesByCommit.unpack):
1253         (ArchiveContext.assert_zipfile):
1254         (ArchiveContext.open_zipfile):
1255         (ArchiveContext.__init__):
1256         (ArchiveContext.__enter__):
1257         (ArchiveContext.__exit__):
1258         (ArchiveContext.register): Save the provided archive to Cassandra.
1259         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
1260         (ArchiveContext._files_for_archive):
1261         (ArchiveContext.ls): List all files in the matching archives.
1262         (ArchiveContext.file): Extract a file from the matching archives.
1263         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
1264         (ArchiveContextTest):
1265         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
1266         (MockModelFactory):
1267         (MockModelFactory.process_results):
1268         (MockModelFactory.add_mock_archives):
1269         * resultsdbpy/resultsdbpy/model/model.py:
1270         (Model.__init__): Add an ArchiveContext to the model.
1271
1272 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1273
1274         [ews-build] view layout test results option should be displayed next to layout-test build step
1275         https://bugs.webkit.org/show_bug.cgi?id=200048
1276
1277         Reviewed by Jonathan Bedard.
1278
1279         * BuildSlaveSupport/ews-build/steps.py:
1280         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
1281         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
1282
1283 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1284
1285         [ews] Fix capitalization in Found x new Test failure message
1286         https://bugs.webkit.org/show_bug.cgi?id=201004
1287
1288         Reviewed by Alexey Proskuryakov.
1289
1290         * BuildSlaveSupport/ews-build/steps.py:
1291         (AnalyzeLayoutTestsResults.report_failure):
1292         (AnalyzeAPITestsResults.analyzeResults):
1293         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1294
1295 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1296
1297         Assign ews117 to EWS High-Sierra Debug queues
1298         https://bugs.webkit.org/show_bug.cgi?id=200993
1299
1300         Reviewed by Jonathan Bedard.
1301
1302         * BuildSlaveSupport/ews-build/config.json:
1303
1304 2019-08-21  Daniel Bates  <dabates@apple.com>
1305
1306         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
1307         https://bugs.webkit.org/show_bug.cgi?id=200742
1308
1309         Reviewed by Simon Fraser.
1310
1311         The OptionSet synthetic provider must respond to requests for the value of m_storage
1312         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
1313         of the type summary.
1314
1315         Synthetic providers substitute alternative debug information (children) for the default
1316         information for a variable. The OptionSet type summary is implemented in terms of the
1317         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
1318         before invoking the type summary handler then evaluating GetChildMemberWithName() on
1319         the SBValue passed to the type summary handler will access the substitute information
1320         instead of the original debug information. As a result OptionSet's synthetic provider's
1321         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
1322         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
1323         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
1324         should return a valid value.
1325
1326         * lldb/lldb_webkit.py:
1327         (FlagEnumerationProvider.__init__):
1328         (FlagEnumerationProvider):
1329         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
1330         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
1331         (FlagEnumerationProvider.size): Added.
1332         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
1333         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
1334         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
1335         and removed self.size. For the latter we can just expose a getter that returns the size of
1336         the list self._elements.
1337         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
1338         value of m_storage.
1339         (WTFOptionSetProvider):
1340         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
1341         matches the specified index.
1342
1343 2019-08-21  Alex Christensen  <achristensen@webkit.org>
1344
1345         Disabling text autosizing should prevent text autosizing
1346         https://bugs.webkit.org/show_bug.cgi?id=200955
1347         <rdar://problem/48095374>
1348
1349         Reviewed by Simon Fraser.
1350
1351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1352         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
1353         (TEST):
1354
1355 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
1356
1357         [GTK][WPE] Make debug-test-runner work
1358         https://bugs.webkit.org/show_bug.cgi?id=193576
1359
1360         Reviewed by Michael Catanzaro.
1361
1362         * Scripts/webkitdirs.pm:
1363         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
1364         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
1365         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
1366         (execUnixAppForDebugging): Added.
1367         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
1368
1369 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
1370
1371         Put keygen element behind a runtime flag and disable it by default
1372         https://bugs.webkit.org/show_bug.cgi?id=200850
1373
1374         Reviewed by Antti Koivisto.
1375
1376         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
1377
1378         * DumpRenderTree/TestOptions.cpp:
1379         (TestOptions::TestOptions):
1380         * DumpRenderTree/TestOptions.h:
1381         * DumpRenderTree/mac/DumpRenderTree.mm:
1382         (setWebPreferencesForTestOptions):
1383         * DumpRenderTree/win/DumpRenderTree.cpp:
1384         (setWebPreferencesForTestOptions):
1385         * WebKitTestRunner/TestController.cpp:
1386         (WTR::TestController::resetPreferencesToConsistentValues):
1387         (WTR::updateTestOptionsFromTestHeader):
1388         * WebKitTestRunner/TestOptions.h:
1389         (WTR::TestOptions::hasSameInitializationOptions const):
1390
1391 2019-08-21  Chris Dumez  <cdumez@apple.com>
1392
1393         Add internal setting to disable SecureContext checks
1394         https://bugs.webkit.org/show_bug.cgi?id=200980
1395         <rdar://problem/54438512>
1396
1397         Reviewed by Alex Christensen.
1398
1399         Add API test coverage.
1400
1401         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1402         (log):
1403         (requestPermission):
1404
1405 2019-08-21  Keith Rollin  <krollin@apple.com>
1406
1407         Remove support for watchOS < 6.0
1408         https://bugs.webkit.org/show_bug.cgi?id=200937
1409         <rdar://problem/54524009>
1410
1411         Reviewed by Darin Adler.
1412
1413         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
1414         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
1415         60000. This means that expressions like
1416         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
1417         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
1418
1419         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1420         (TestWebKitAPI::TEST):
1421
1422 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
1423
1424         [results.webkit.org Webkit.css] Add right sidebar
1425         https://bugs.webkit.org/show_bug.cgi?id=200946
1426
1427         Reviewed by Jonathan Bedard.
1428
1429         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1430         (@media screen and (min-width: 600px) and (orientation: landscape)):
1431         (.main.left):
1432         (@media screen and (min-width: 768px) and (orientation: landscape)):
1433         (.sidebar.right):
1434
1435 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
1436
1437         results.webkit.org: Add ToolTips
1438         https://bugs.webkit.org/show_bug.cgi?id=200801
1439
1440         Rubber-stamped by Aakash Jain.
1441
1442         When dots or scale labels are hovered over, we should display a tool tip with additional information about
1443         The specific element.
1444
1445         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
1446         (.tooltip): Add class for ToolTip text box.
1447         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
1448         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
1449         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
1450         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
1451         repositories at a given time.
1452         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1453         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
1454         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
1455         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
1456         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
1457         (_ToolTip):
1458         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
1459         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
1460         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
1461         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
1462         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1463         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
1464         dot and scale elements.
1465         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
1466         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1467
1468 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
1469
1470         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
1471         https://bugs.webkit.org/show_bug.cgi?id=200782
1472
1473         Reviewed by Saam Barati.
1474
1475         * Scripts/run-jsc-stress-tests:
1476
1477 2019-08-20  Darin Adler  <darin@apple.com>
1478
1479         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
1480         https://bugs.webkit.org/show_bug.cgi?id=200921
1481
1482         Reviewed by Saam Barati.
1483
1484         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1485         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
1486         need to abort after the first failure. Added three new tests to the VariadicAppend
1487         test to cover various cases of upconverting from 8-bit to 16-bit strings.
1488
1489 2019-08-20  Dean Jackson  <dino@apple.com>
1490
1491         REGRESSION: Open in New Tab is missing from context menu
1492         https://bugs.webkit.org/show_bug.cgi?id=200909
1493         <rdar://problem/54476169>
1494
1495         Reviewed by Simon Fraser.
1496
1497         Add a new test that runs through the legacy context menu
1498         flow, and verifies that it will be called if there aren't
1499         appropriate delegates for the new API.
1500
1501         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1502         (contextMenuWebViewDriver):
1503         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1504         (TEST):
1505         (-[LegacyPreviewViewController previewActionItems]):
1506         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
1507         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
1508         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1509         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
1510         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
1511
1512 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1513
1514         [JSC] OSR entry to Wasm OMG
1515         https://bugs.webkit.org/show_bug.cgi?id=200362
1516
1517         Reviewed by Michael Saboff.
1518
1519         * Scripts/run-jsc-stress-tests:
1520
1521 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
1522
1523         [results.webkit.org Timeline] Disable back gesture
1524         https://bugs.webkit.org/show_bug.cgi?id=200839
1525
1526         Reviewed by Jonathan Bedard.
1527
1528         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1529         * resultsdbpy/resultsdbpy/view/templates/base.html:
1530
1531 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
1532
1533         results-webkit.org: Add timeout to Redis locks
1534         https://bugs.webkit.org/show_bug.cgi?id=200890
1535
1536         Reviewed by Aakash Jain.
1537
1538         * resultsdbpy/resultsdbpy/model/upload_context.py:
1539         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
1540
1541 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
1542
1543         Remove IDB-specific quota
1544         https://bugs.webkit.org/show_bug.cgi?id=196545
1545         <rdar://problem/54201783>
1546
1547         Reviewed by Youenn Fablet.
1548
1549         * DumpRenderTree/TestRunner.cpp:
1550         (TestRunner::staticFunctions):
1551         (setIDBPerOriginQuotaCallback): Deleted.
1552         * DumpRenderTree/TestRunner.h:
1553         * DumpRenderTree/mac/DumpRenderTree.mm:
1554         (runTest):
1555         * DumpRenderTree/mac/TestRunnerMac.mm:
1556         (TestRunner::setIDBPerOriginQuota): Deleted.
1557         * DumpRenderTree/win/TestRunnerWin.cpp:
1558         (TestRunner::setIDBPerOriginQuota): Deleted.
1559         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1560         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1561         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1563         * WebKitTestRunner/TestController.cpp:
1564         (WTR::TestController::resetStateToConsistentValues):
1565         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1566         * WebKitTestRunner/TestController.h:
1567         * WebKitTestRunner/TestInvocation.cpp:
1568         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1569
1570 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1571
1572         [WTF] Style checker should tell errors when it finds std::make_unique
1573         https://bugs.webkit.org/show_bug.cgi?id=200878
1574
1575         Reviewed by Ross Kirsling.
1576
1577         * Scripts/webkitpy/style/checkers/cpp.py:
1578         (check_wtf_make_unique):
1579         (check_style):
1580         (CppChecker):
1581
1582 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
1583
1584         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
1585         https://bugs.webkit.org/show_bug.cgi?id=200620
1586
1587         Reviewed by Geoffrey Garen.
1588
1589         * DumpRenderTree/TestRunner.cpp:
1590         (addURLToRedirectCallback):
1591         (setWillSendRequestClearHeaderCallback):
1592         (TestRunner::setAccummulateLogsForChannel):
1593         (TestRunner::runUIScript):
1594         (TestRunner::setOpenPanelFiles):
1595         * DumpRenderTree/mac/DumpRenderTree.mm:
1596         (dumpFramesAsText):
1597         * DumpRenderTree/mac/EventSendingController.mm:
1598         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1599         * DumpRenderTree/win/DRTDataObject.cpp:
1600         (DRTDataObject::SetData):
1601         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1602         (FrameLoadDelegate::FrameLoadDelegate):
1603         * DumpRenderTree/win/UIDelegate.cpp:
1604         (DRTUndoManager::DRTUndoManager):
1605         (UIDelegate::UIDelegate):
1606         (UIDelegate::resetUndoManager):
1607         * TestWebKitAPI/JavaScriptTest.cpp:
1608         (TestWebKitAPI::runJSTest):
1609         * TestWebKitAPI/PlatformUtilities.cpp:
1610         (TestWebKitAPI::Util::toSTD):
1611         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1612         (TestWebKitAPI::TEST):
1613         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1616         (TestWebKitAPI::TEST):
1617         (TestWebKitAPI::testMovingUsingEnsure):
1618         (TestWebKitAPI::testMovingUsingAdd):
1619         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1620         (TestWebKitAPI::TEST):
1621         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1622         (TestWebKitAPI::TEST):
1623         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1624         (TestWebKitAPI::runLockTest):
1625         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1626         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1627         (TestWebKitAPI::TEST):
1628         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1629         (TestWebKitAPI::TEST):
1630         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1633         (TestWebKitAPI::TEST):
1634         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
1635         (TestWebKitAPI::CARingBufferTest::SetUp):
1636         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1637         (TestWebKitAPI::createTestValue):
1638         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1641         (TestWebKitAPI::TEST_F):
1642         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1643         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1644         (TestWebKitAPI::createNewPage):
1645         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1646         (TestWebKitAPI::createNewPage):
1647         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
1648         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
1649         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
1650         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
1651         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
1652         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1653         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1654         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1655         (serverCallback):
1656         (testWebViewAuthenticationProxyHTTPS):
1657         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1658         (WebKitDOMDOMWindowTest::create):
1659         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
1660         (TestWebKitAPI::Util::toSTD):
1661         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1662         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1663         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1664         * TestWebKitAPI/mac/TestFontOptions.mm:
1665         (-[TestFontOptions initWithFontOptions:]):
1666         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1667         (WTR::EventSendingController::callAfterScrollingCompletes):
1668         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1669         (WTR::InjectedBundle::didCreatePage):
1670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1671         (WTR::TestRunner::setOpenPanelFiles):
1672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1673         * WebKitTestRunner/StringFunctions.h:
1674         (WTR::toSTD):
1675         (WTR::toWTFString):
1676         * WebKitTestRunner/TestController.cpp:
1677         (WTR::TestController::initialize):
1678         (WTR::TestController::generatePageConfiguration):
1679         (WTR::TestController::resetStateToConsistentValues):
1680         (WTR::createTestURL):
1681         (WTR::TestController::runTest):
1682         (WTR::TestController::platformCreateWebView):
1683         * WebKitTestRunner/TestInvocation.cpp:
1684         (WTR::TestInvocation::runUISideScript):
1685         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1686         (WTR::TestController::platformCreateWebView):
1687         (WTR::TestController::setDefaultCalendarType):
1688         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1689         (WTR::getGDKKeySymForKeyRef):
1690         * WebKitTestRunner/ios/TestControllerIOS.mm:
1691         (WTR::TestController::platformResetStateToConsistentValues):
1692         (WTR::TestController::setKeyboardInputModeIdentifier):
1693         * WebKitTestRunner/mac/EventSenderProxy.mm:
1694         (WTR::EventSenderProxy::mouseDown):
1695         (WTR::EventSenderProxy::mouseUp):
1696         (WTR::EventSenderProxy::mouseMoveTo):
1697         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1698         (WTR::wpeKeySymForKeyRef):
1699
1700 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
1701
1702         [ESNext] Implement optional chaining
1703         https://bugs.webkit.org/show_bug.cgi?id=200199
1704
1705         Reviewed by Yusuke Suzuki.
1706
1707         * Scripts/run-jsc-stress-tests:
1708
1709 2019-08-17  Tim Horton  <timothy_horton@apple.com>
1710
1711         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
1712         https://bugs.webkit.org/show_bug.cgi?id=200866
1713         <rdar://problem/50254021>
1714
1715         Reviewed by Simon Fraser.
1716
1717         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1718         (WTR::PlatformWebView::windowSnapshotImage):
1719         Replace some logging with release assertions that we are snapshotting a reasonable
1720         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
1721         "silently" failing with just a log that will be ignored is not helpful.
1722
1723 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
1724
1725         [WTF] ThreadGroupRemove test is flaky
1726         https://bugs.webkit.org/show_bug.cgi?id=200763
1727
1728         Reviewed by Mark Lam.
1729
1730         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
1731         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
1732         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
1733         and releasing the lock after that.
1734
1735         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1736         (TestWebKitAPI::TEST):
1737
1738 2019-08-17  Eric Liang  <ericliang@apple.com>
1739
1740         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
1741         https://bugs.webkit.org/show_bug.cgi?id=200367
1742
1743         Reviewed by Darin Adler.
1744
1745         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
1746
1747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1748         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
1749         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
1750         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
1751         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
1752         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1753         (TestWebKitAPI::TEST):
1754
1755 2019-08-17  Sam Weinig  <weinig@apple.com>
1756
1757         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
1758         https://bugs.webkit.org/show_bug.cgi?id=200756
1759
1760         Reviewed by Darin Adler.
1761
1762         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
1763         StringBuilder::append(...).
1764
1765         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1766         (TestWebKitAPI::TEST):
1767
1768 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
1769
1770         [iOS WK2] Scroll indicators disappear sometimes
1771         https://bugs.webkit.org/show_bug.cgi?id=200791
1772
1773         Reviewed by Tim Horton.
1774
1775         Tests that test that scroll indicators survive subview replacement, and that
1776         a custom view also survives subview replacement.
1777
1778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1779         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
1780         (TestWebKitAPI::TEST):
1781         * TestWebKitAPI/cocoa/TestWKWebView.h:
1782         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1783         (-[TestWKWebView performAfterLoading:]):
1784         (-[UIView wkFirstSubviewWithClass:]):
1785         (-[UIView wkFirstSubviewWithBoundsSize:]):
1786         * TestWebKitAPI/ios/composited.html: Added.
1787         * TestWebKitAPI/ios/overflow-scroll.html: Added.
1788
1789 2019-08-16  John Wilander  <wilander@apple.com>
1790
1791         Add John Wilander as WebKit Reviewer
1792         https://bugs.webkit.org/show_bug.cgi?id=200837
1793
1794         Unreviewed update to contributors.json to change my status to reviewer.
1795         See email on reviewers mailing list for proof of granted privileges.
1796
1797         * Scripts/webkitpy/common/config/contributors.json:
1798
1799 2019-08-16  Timothy Hatcher  <timothy@apple.com>
1800
1801         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
1802         https://bugs.webkit.org/show_bug.cgi?id=200802
1803         rdar://problem/54357818
1804
1805         Reviewed by Tim Horton.
1806
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
1808         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
1809         (-[OpaqueTestWKWebView isOpaque]): Added.
1810         (-[NonOpaqueTestWKWebView isOpaque]): Added.
1811         (isOpaque): Added.
1812         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
1813         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
1814         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
1815
1816 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1817
1818         [ews] Add build steps for Windows Factory
1819         https://bugs.webkit.org/show_bug.cgi?id=200813
1820
1821         Reviewed by Jonathan Bedard.
1822
1823         * BuildSlaveSupport/ews-build/factories.py:
1824         (WindowsFactory.__init__):
1825
1826 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews] Report machine uptime in PrintConfiguration
1829         https://bugs.webkit.org/show_bug.cgi?id=200812
1830
1831         Reviewed by Jonathan Bedard.
1832
1833         * BuildSlaveSupport/ews-build/steps.py:
1834         (PrintConfiguration): Added uptime command.
1835         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1836
1837 2019-08-16  Chris Lord  <clord@igalia.com>
1838
1839         Add shared-mime-info to WPE WebKit jhbuild
1840         https://bugs.webkit.org/show_bug.cgi?id=200768
1841
1842         Reviewed by Carlos Alberto Lopez Perez.
1843
1844         * wpe/jhbuild.modules:
1845
1846 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
1847
1848         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
1849         https://bugs.webkit.org/show_bug.cgi?id=200620
1850
1851         Reviewed by Geoffrey Garen.
1852
1853         * DumpRenderTree/AccessibilityController.h:
1854         * DumpRenderTree/GCController.h:
1855         * DumpRenderTree/win/DRTDataObject.cpp:
1856         * DumpRenderTree/win/DRTDataObject.h:
1857         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1858         * DumpRenderTree/win/DRTDropSource.h:
1859         * DumpRenderTree/win/DraggingInfo.h:
1860         * DumpRenderTree/win/EditingDelegate.h:
1861         * DumpRenderTree/win/EventSender.cpp:
1862         * DumpRenderTree/win/FrameLoadDelegate.h:
1863         * DumpRenderTree/win/HistoryDelegate.h:
1864         * DumpRenderTree/win/MD5.h:
1865         * DumpRenderTree/win/PolicyDelegate.h:
1866         * DumpRenderTree/win/ResourceLoadDelegate.h:
1867         * DumpRenderTree/win/TextInputController.h:
1868         * DumpRenderTree/win/UIDelegate.cpp:
1869         * DumpRenderTree/win/UIDelegate.h:
1870         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1871         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
1872         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
1873         * TestWebKitAPI/Counters.h:
1874         * TestWebKitAPI/PlatformWebView.h:
1875         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1876         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1877         (TestWebKitAPI::DerefObserver::ref):
1878         (TestWebKitAPI::DerefObserver::deref):
1879         (TestWebKitAPI::TEST):
1880         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1881         (TestWebKitAPI::DerefObserver::ref):
1882         (TestWebKitAPI::DerefObserver::deref):
1883         (TestWebKitAPI::TEST):
1884         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
1885         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1886         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1887         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1888         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1889         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1890         * WebKitTestRunner/EventSenderProxy.h:
1891         * WebKitTestRunner/GeolocationProviderMock.h:
1892         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1893         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1894         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1895         * WebKitTestRunner/PlatformWebView.h:
1896         * WebKitTestRunner/TestInvocation.h:
1897
1898 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
1899
1900         Some improvements on web storage
1901         https://bugs.webkit.org/show_bug.cgi?id=200373
1902
1903         Reviewed by Geoffrey Garen.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1906         (TEST): update expectation for behavior change.
1907
1908         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
1909         database file.
1910         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1911         (WTR::TestRunner::syncLocalStorage):
1912         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1913
1914         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
1915         (WTR::TestController::resetStateToConsistentValues):
1916         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
1917         (WTR::StorageVoidCallback):
1918         (WTR::TestController::clearIndexedDatabases):
1919         (WTR::TestController::clearLocalStorage):
1920         (WTR::TestController::syncLocalStorage):
1921         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
1922         with StorageVoidCallbackContext for general usage.
1923         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
1924         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
1925         * WebKitTestRunner/TestController.h:
1926
1927         * WebKitTestRunner/TestInvocation.cpp:
1928         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
1929         SyncLocalStorage.
1930
1931 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
1932
1933         results.webkit.org: Add content hook to FlaskRequestsResponse
1934         https://bugs.webkit.org/show_bug.cgi?id=200721
1935
1936         Rubber-stamped by Aakash Jain.
1937
1938         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
1939         (FlaskRequestsResponse):
1940         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
1941         Response, conforming to request's API.
1942
1943 2019-08-15  Alex Christensen  <achristensen@webkit.org>
1944
1945         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
1946         https://bugs.webkit.org/show_bug.cgi?id=200750
1947         <rdar://problem/54232261> and <rdar://problem/52355829>
1948
1949         Reviewed by Tim Horton.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1952         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1953         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1954         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1955         (contextMenuWebViewDriver):
1956         (TEST):
1957
1958 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1959
1960         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
1961         https://bugs.webkit.org/show_bug.cgi?id=200726
1962
1963         Reviewed by Simon Fraser.
1964
1965         To get the pixels as an array of colors, draw the image into a memory
1966         context. The backing memory buffer can then be accessed to get the image
1967         pixels' colors.
1968
1969         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1970         (TestWebKitAPI::TEST):
1971
1972 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
1973
1974         Unreviewed, rolling out r248526.
1975
1976         Caused two IndexedDB perf tests to fail
1977
1978         Reverted changeset:
1979
1980         "Remove IDB-specific quota"
1981         https://bugs.webkit.org/show_bug.cgi?id=196545
1982         https://trac.webkit.org/changeset/248526
1983
1984 2019-08-14  Keith Rollin  <krollin@apple.com>
1985
1986         Remove support for macOS < 10.13
1987         https://bugs.webkit.org/show_bug.cgi?id=200694
1988         <rdar://problem/54278851>
1989
1990         Reviewed by Youenn Fablet.
1991
1992         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
1993         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
1994         101300. This means that expressions like
1995         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
1996         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
1997
1998         * MiniBrowser/AppKitCompatibilityDeclarations.h:
1999         * MiniBrowser/mac/SettingsController.m:
2000         (-[SettingsController init]):
2001         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
2002         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
2003         (TestWebKitAPI::createPlatformFont): Deleted.
2004         (TestWebKitAPI::compareFonts): Deleted.
2005         (TestWebKitAPI::TEST_F): Deleted.
2006         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2007         (TestWebKitAPI::TEST):
2008         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2009         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2010         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2011         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2012         (runWebsiteDataStoreCustomPaths):
2013         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
2014
2015 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
2016
2017         [JSC] Less contended MetaAllocator
2018         https://bugs.webkit.org/show_bug.cgi?id=200278
2019
2020         Reviewed by Mark Lam.
2021
2022         Update the interface.
2023
2024         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2025
2026 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
2027
2028         results.webkit.org: 500 errors on API endpoints don't return JSON
2029         https://bugs.webkit.org/show_bug.cgi?id=200722
2030
2031         Reviewed by Aakash Jain.
2032
2033         * resultsdbpy/resultsdbpy/controller/api_routes.py:
2034         (APIRoutes.response_500): We should return the response, instead of abort.
2035
2036 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
2037
2038         results.webkit.org: Don't save configuration multiple times in upload
2039         https://bugs.webkit.org/show_bug.cgi?id=200719
2040
2041         Reviewed by Aakash Jain.
2042
2043         * resultsdbpy/resultsdbpy/model/upload_context.py:
2044         (UploadContext.upload_test_results): Move registering of the configuration out
2045         of the branch loop.
2046
2047 2019-08-14  Youenn Fablet  <youenn@apple.com>
2048
2049         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
2050         https://bugs.webkit.org/show_bug.cgi?id=200706
2051
2052         Reviewed by Alex Christensen.
2053
2054         Libwebrtc is now soft-linked so we can reenable this test.
2055
2056         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
2057         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
2058
2059 2019-08-13  Sam Weinig  <weinig@apple.com>
2060
2061         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
2062         https://bugs.webkit.org/show_bug.cgi?id=200675
2063
2064         Reviewed by Darin Adler.
2065
2066         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2067         (TestWebKitAPI::TEST):
2068         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
2069
2070 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
2071
2072         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
2073         https://bugs.webkit.org/show_bug.cgi?id=200456
2074
2075         Reviewed by Jonathan Bedard.
2076
2077         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
2078
2079         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
2080
2081         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
2082         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2083         (pointPolygonCollisionDetect): Detact
2084         (pointRightRayLineSegmentCollisionDetect):
2085         (ColorBatchRender):
2086         (ColorBatchRender.prototype.lazyCreateColorSeqs):
2087         (ColorBatchRender.prototype.addSeq):
2088         (ColorBatchRender.prototype.batchRender):
2089         (ColorBatchRender.prototype.clear):
2090         (xScrollStreamRenderFactory):
2091         (Timeline.CanvasSeriesComponent):
2092         (offscreenCachedRenderFactory): Deleted.
2093
2094 2019-08-13  John Wilander  <wilander@apple.com>
2095
2096         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
2097         https://bugs.webkit.org/show_bug.cgi?id=200642
2098         <rdar://problem/53962073>
2099
2100         Reviewed by Alex Christensen.
2101
2102         This patch adds test infrastructure to query whether an origin has an
2103         isolated NSURLSession or not.
2104
2105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2107         (WTR::TestRunner::hasStatisticsIsolatedSession):
2108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2109         * WebKitTestRunner/TestController.cpp:
2110         (WTR::TestController::hasStatisticsIsolatedSession):
2111         * WebKitTestRunner/TestController.h:
2112         * WebKitTestRunner/TestInvocation.cpp:
2113         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2114
2115 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
2116
2117         Update my status in contributors.json to committer.
2118
2119         Reviewed by Unreviewed
2120
2121         * Scripts/webkitpy/common/config/contributors.json:
2122
2123 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
2124
2125         Adds WebAuthn and AppSSO into watchlist
2126         https://bugs.webkit.org/show_bug.cgi?id=200647
2127
2128         Reviewed by Dewei Zhu.
2129
2130         * Scripts/webkitpy/common/config/watchlist:
2131
2132 2019-08-13  Chris Dumez  <cdumez@apple.com>
2133
2134         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
2135         https://bugs.webkit.org/show_bug.cgi?id=200674
2136         <rdar://problem/50692748>
2137
2138         Reviewed by Geoff Garen.
2139
2140         Add API test coverage.
2141
2142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2143
2144 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
2145
2146         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
2147         https://bugs.webkit.org/show_bug.cgi?id=199857
2148
2149         Reviewed by Yusuke Suzuki.
2150
2151         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2152         (TestWebKitAPI::countThreadGroups):
2153         (TestWebKitAPI::TEST):
2154
2155 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
2156
2157         AX: Homebrew is not allowed to run any script under sudo.
2158         https://bugs.webkit.org/show_bug.cgi?id=173801
2159
2160         Reviewed by Carlos Alberto Lopez Perez.
2161
2162         Latest versions of Homebrew throw an error when run as root.
2163         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
2164
2165         * gtk/install-dependencies:
2166
2167 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
2168
2169         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
2170         https://bugs.webkit.org/show_bug.cgi?id=200644
2171
2172         Reviewed by Aakash Jain.
2173
2174         * Scripts/webkitpy/port/simulator_process.py:
2175         (SimulatorProcess._start): Define system PID after launching app.
2176
2177 2019-08-12  Sam Weinig  <weinig@apple.com>
2178
2179         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
2180         https://bugs.webkit.org/show_bug.cgi?id=200614
2181
2182         Reviewed by Darin Adler.
2183
2184         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
2185         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
2186         
2187         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
2188         StringBuilder::appendSubstring(...).
2189
2190         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2191         (TestWebKitAPI::TEST):
2192         Update for renames.
2193
2194 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
2195
2196         Fix Crash in Mail Search
2197         https://bugs.webkit.org/show_bug.cgi?id=200589
2198
2199         Reviewed by Tim Horton.
2200
2201         If you search backwards first in mail, we would crash,
2202         this tests that codepath.
2203
2204         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2205         (TEST):
2206
2207 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2208
2209         [iPadOS] Web pages sometimes load at half width in Safari
2210         https://bugs.webkit.org/show_bug.cgi?id=200624
2211         <rdar://problem/52694257>
2212
2213         Reviewed by Simon Fraser.
2214
2215         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
2216         web page is created using the post-animated-resize web view dimensions, rather than the original layout
2217         dimensions.
2218
2219         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2220
2221 2019-08-12  Daniel Bates  <dabates@apple.com>
2222
2223         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
2224         https://bugs.webkit.org/show_bug.cgi?id=200548
2225
2226         Reviewed by Darin Adler.
2227
2228         Expose infrastructure to simulate a literal raw key down and a literal key up event.
2229
2230         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2231         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2232         (WTR::UIScriptController::rawKeyDown):
2233         (WTR::UIScriptController::rawKeyUp):
2234         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2235         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2236         (WTR::UIScriptControllerIOS::rawKeyDown):
2237         (WTR::UIScriptControllerIOS::rawKeyUp):
2238
2239 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
2240
2241         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
2242         https://bugs.webkit.org/show_bug.cgi?id=200584
2243
2244         Reviewed by Philippe Normand.
2245
2246         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
2247         Ignore style libwebrtc optionnal 'style issue'
2248
2249         * Scripts/webkitpy/style/checker.py:
2250         * gstreamer/jhbuild.modules:
2251         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
2252
2253 2019-08-12  Youenn Fablet  <youenn@apple.com>
2254
2255         Remove IDB-specific quota
2256         https://bugs.webkit.org/show_bug.cgi?id=196545
2257
2258         Reviewed by Alex Christensen.
2259
2260         * DumpRenderTree/TestRunner.cpp:
2261         (TestRunner::staticFunctions):
2262         (setIDBPerOriginQuotaCallback): Deleted.
2263         * DumpRenderTree/TestRunner.h:
2264         * DumpRenderTree/mac/DumpRenderTree.mm:
2265         (runTest):
2266         * DumpRenderTree/mac/TestRunnerMac.mm:
2267         (TestRunner::setIDBPerOriginQuota): Deleted.
2268         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2270         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
2271         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2272         * WebKitTestRunner/TestController.cpp:
2273         (WTR::TestController::resetStateToConsistentValues):
2274         (WTR::TestController::setIDBPerOriginQuota): Deleted.
2275         * WebKitTestRunner/TestController.h:
2276         * WebKitTestRunner/TestInvocation.cpp:
2277         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2278
2279 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
2280
2281         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
2282         https://bugs.webkit.org/show_bug.cgi?id=200621
2283
2284         Reviewed by Dan Bernstein.
2285
2286         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2287
2288 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2289
2290         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
2291         https://bugs.webkit.org/show_bug.cgi?id=200604
2292         <rdar://problem/51273130>
2293
2294         Reviewed by Megan Gardner.
2295
2296         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
2297         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
2298         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
2299         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
2300         remains the same.
2301
2302         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
2303         the caret rect at initial scale 1.
2304
2305         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2306
2307 2019-08-09  Ali Juma  <ajuma@chromium.org>
2308
2309         Don't allow cross-origin iframes to autofocus
2310         https://bugs.webkit.org/show_bug.cgi?id=200515
2311         <rdar://problem/54092988>
2312
2313         Reviewed by Ryosuke Niwa.
2314
2315         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
2316         of cross-origin iframes, since it depends on focusing one of the
2317         frames.
2318
2319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2320         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2321         (TestWebKitAPI::TEST):
2322         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
2323
2324 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2325
2326         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
2327         https://bugs.webkit.org/show_bug.cgi?id=200591
2328         <rdar://problem/54102238>
2329
2330         Reviewed by Ryosuke Niwa and Tim Horton.
2331
2332         Add a new API test to exercise -supportsImagePaste.
2333
2334         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2335         (TestWebKitAPI::TEST):
2336         * TestWebKitAPI/ios/UIKitSPI.h:
2337
2338 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2339
2340         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
2341         [ews-build] Set svn:ignore to various EWS Buildbot files
2342         https://bugs.webkit.org/show_bug.cgi?id=200581
2343
2344         Reviewed by Jonathan Bedard.
2345
2346         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2347
2348 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2349
2350         [ews-build] Set svn:ignore to various EWS Buildbot files
2351         https://bugs.webkit.org/show_bug.cgi?id=200581
2352
2353         Reviewed by Jonathan Bedard.
2354
2355         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2356
2357 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2358
2359         [ews] Add buildbot.tac to repository
2360         https://bugs.webkit.org/show_bug.cgi?id=200580
2361
2362         Reviewed by Jonathan Bedard.
2363
2364         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
2365
2366 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
2367
2368         [GTK] Add missing spellchecking packages to dependencies script
2369         https://bugs.webkit.org/show_bug.cgi?id=200574
2370
2371         Reviewed by Philippe Normand.
2372
2373         These are needed for the spellchecking test in WebContext API tests.
2374
2375         * gtk/install-dependencies:
2376
2377 2019-08-08  Jon Lee  <jonlee@apple.com>
2378
2379         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
2380
2381 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2382
2383         webkitpy: Disable shared clipboard between Simulators
2384         https://bugs.webkit.org/show_bug.cgi?id=200546
2385
2386         Reviewed by Aakash Jain.
2387
2388         * Scripts/webkitpy/xcode/simulated_device.py:
2389         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
2390         managed by run-webkit-tests.
2391
2392 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
2393
2394         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
2395         https://bugs.webkit.org/show_bug.cgi?id=200539
2396         <rdar://problem/54082550>
2397
2398         Reviewed by Dean Jackson.
2399
2400         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2401         * PlatformFTW.cmake: Added.
2402
2403 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2404
2405         [iOS] Position image information should respect the image orientation
2406         https://bugs.webkit.org/show_bug.cgi?id=200487
2407
2408         Reviewed by Simon Fraser.
2409
2410         Add an API test to verify the position image information is drawn rotated
2411         because of respecting its image orientation.
2412
2413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2414         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2415         (TestWebKitAPI::TEST):
2416         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
2417         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
2418
2419 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2420
2421         [GTK] Fix WebContext languages test
2422         https://bugs.webkit.org/show_bug.cgi?id=200538
2423
2424         Reviewed by Alex Christensen.
2425
2426         This test broke after the format of Accepted-Languages
2427         was changed in r238236, update.
2428
2429         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2430         (testWebContextLanguages):
2431
2432 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2433
2434         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
2435         https://bugs.webkit.org/show_bug.cgi?id=200536
2436
2437         Reviewed by Carlos Alberto Lopez Perez.
2438
2439         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2440         (testWebsiteDataDatabases): Databases take a moment to be written,
2441         wait before fetching the data as it's done in other tests.
2442
2443 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2444
2445         results.webkit.org: Use canvas for timeline
2446         https://bugs.webkit.org/show_bug.cgi?id=200172
2447
2448         Rubber-stamped by Aakash Jain.
2449
2450         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2451         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
2452         (Commit.compare): Ditto.
2453         (_CommitBank.commitByUuid): Ditto.
2454         (_CommitBank._loadSiblings): Ditto.
2455         (_CommitBank._load): Ditto.
2456         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2457         (tickForCommit): Deleted.
2458         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
2459         which encompasses all results. Crucially, this function must exclude an UUIDs which may
2460         refer to results excluded because of the limit argument.
2461         (renderTimeline): Deleted.
2462         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
2463         with those results.
2464         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
2465         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
2466         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
2467         (inPlaceCombine): Combine result objects together.
2468         (statsForSingleResult): Turn a single result into a stat object.
2469         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
2470         (Dot): Deleted.
2471         (TimelineFromEndpoint): Renamed from Timeline.
2472         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
2473         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
2474         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
2475         cache contents.
2476         (TimelineFromEndpoint.reload): Remove management of nested timelines.
2477         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
2478         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
2479         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2480
2481 2019-08-08  Brady Eidson  <beidson@apple.com>
2482
2483         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
2484         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
2485
2486         Reviewed by Geoff Garen.
2487
2488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2489         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
2490
2491 2019-08-08  Rob Buis  <rbuis@igalia.com>
2492
2493         Add runtime flag for lazy image loading
2494         https://bugs.webkit.org/show_bug.cgi?id=199794
2495
2496         Reviewed by Darin Adler.
2497
2498         Set lazyImageLoading preference as part of experimental features. Add
2499         TestOption for lazy image loading.
2500
2501         * DumpRenderTree/TestOptions.cpp:
2502         (TestOptions::TestOptions):
2503         * DumpRenderTree/TestOptions.h:
2504         * DumpRenderTree/mac/DumpRenderTree.mm:
2505         (enableExperimentalFeatures):
2506         (setWebPreferencesForTestOptions):
2507         * DumpRenderTree/win/DumpRenderTree.cpp:
2508         (enableExperimentalFeatures):
2509
2510 2019-08-08  Rob Buis  <rbuis@igalia.com>
2511
2512         Import lazy loading WPT tests
2513         https://bugs.webkit.org/show_bug.cgi?id=199795
2514
2515         Reviewed by Darin Adler.
2516
2517         Only do loading/ exception for WebKit specific, non WPT tests.
2518
2519         * DumpRenderTree/mac/DumpRenderTree.mm:
2520         (shouldLogFrameLoadDelegates):
2521         * WebKitTestRunner/TestInvocation.cpp:
2522         (WTR::TestInvocation::TestInvocation):
2523
2524 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2525
2526         [Win][MiniBrowser] Add key accelerators for reload and close window
2527         https://bugs.webkit.org/show_bug.cgi?id=200497
2528
2529         Reviewed by Brent Fulgham.
2530
2531         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
2532
2533         * MiniBrowser/win/MainWindow.cpp:
2534         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
2535         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
2536         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
2537
2538 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
2539
2540         Add WHLSL and WebGPU to the watchlist file
2541         https://bugs.webkit.org/show_bug.cgi?id=200509
2542
2543         Reviewed by Robin Morisset.
2544
2545         * Scripts/webkitpy/common/config/watchlist:
2546
2547 2019-08-07  Keith Rollin  <krollin@apple.com>
2548
2549         Unreviewed build fix after r248317 -- disable XCBuild because it
2550         breaks incremental builds.
2551
2552         * Scripts/webkitdirs.pm:
2553         (canUseXCBuild):
2554
2555 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2556
2557         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
2558         https://bugs.webkit.org/show_bug.cgi?id=200465
2559
2560         Reviewed by Alex Christensen.
2561
2562         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
2563         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
2564         finishing the test.
2565         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2566         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
2567
2568 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2569
2570         Unreviewed, a build fix after r248308
2571
2572         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
2573
2574         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2575
2576 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2577
2578         Unreviewed, a build fix after r248319
2579
2580         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
2581
2582         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2583         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2584         (WTR::TestController::addTestKeyToKeychain):
2585         (WTR::TestController::cleanUpKeychain):
2586         (WTR::TestController::keyExistsInKeychain):
2587
2588 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2589
2590         Unreviewed, a build fix after r248308
2591
2592         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
2593
2594         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2595         (WTR::TestController::addTestKeyToKeychain):
2596         (WTR::TestController::cleanUpKeychain):
2597         (WTR::TestController::keyExistsInKeychain):
2598
2599 2019-08-06  Keith Rollin  <krollin@apple.com>
2600
2601         Enable XCBuild for `make` and `build-webkit` builds
2602         https://bugs.webkit.org/show_bug.cgi?id=200476
2603         <rdar://problem/50771065>
2604
2605         Reviewed by Jonathan Bedard.
2606
2607         All projects have now been tested under XCBuild and successfully
2608         build. Enable the use of XCBuild when performing builds with `make` or
2609         `build-webkit` and when using a sufficient version of Xcode. We set
2610         this version to Xcode 11 since Xcode 10 -- even though it supports
2611         XCBuild -- does not support a build facility needed to build WebKit
2612         (Bug 197072, Bug 197116, Bug 197340).
2613
2614         Do not enable XCBuild in the Xcode projects themselves since these
2615         projects may need to be used under older versions of Xcode and there's
2616         no way to make those project changes sensitive to the version of Xcode
2617         being used. This means that builds performed in the Xcode IDE will not
2618         use XCBuild.
2619
2620         * Scripts/webkitdirs.pm:
2621         (canUseXCBuild):
2622
2623 2019-08-06  Chris Dumez  <cdumez@apple.com>
2624
2625         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
2626         https://bugs.webkit.org/show_bug.cgi?id=200475
2627
2628         Reviewed by Darin Adler.
2629
2630         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2631         (TestWebKitAPI::stringViewFromLiteral):
2632         (TestWebKitAPI::stringViewFromUTF8):
2633
2634 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2635
2636         Update my status in contributors.json to reviewer.
2637
2638         Regained the status after following the procedure for inactive contributors.
2639         See r247136 for further explanation.
2640
2641         * Scripts/webkitpy/common/config/contributors.json:
2642
2643 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2644
2645         [WebAuthN] Enable LocalAuthenticator for macOS
2646         https://bugs.webkit.org/show_bug.cgi?id=182772
2647         <rdar://problem/43347920>
2648
2649         Reviewed by Brent Fulgham.
2650
2651         Add an entitlement file to WebKitTestRunner such that it can access
2652         the modern macOS keychain.
2653
2654         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
2655         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2656         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2657         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2658         (WTR::TestController::addTestKeyToKeychain):
2659         (WTR::TestController::cleanUpKeychain):
2660         (WTR::TestController::keyExistsInKeychain):
2661
2662 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
2663
2664         [results.webkit.org Timeline] Performance improvements
2665         https://bugs.webkit.org/show_bug.cgi?id=200406
2666
2667         Reviewed by Jonathan Bedard.
2668
2669         1. Unhook the scroll event when a series/axis have been removed from the container
2670         2. Fix the axis's cache data structure out of sync.
2671         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
2672         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
2673
2674
2675         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2676         (Signal.prototype.removeListener):
2677         (prototype.stopAction): Unregsiter an action handler
2678         (Ref):
2679         (Ref.prototype.apply):
2680         (Ref.prototype.destory):
2681         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
2682         (ApplyNewChildren):
2683         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2684         (Timeline.CanvasSeriesComponent):
2685
2686 2019-08-06  Jer Noble  <jer.noble@apple.com>
2687
2688         Add test for behavior introduced in r248174
2689         https://bugs.webkit.org/show_bug.cgi?id=200446
2690
2691         Reviewed by Eric Carlson.
2692
2693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2694         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
2695         (WebKit::configureSecheuristic):
2696         (WebKit::TEST):
2697
2698 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2699
2700         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
2701         https://bugs.webkit.org/show_bug.cgi?id=200464
2702
2703         Reviewed by Ross Kirsling.
2704
2705         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
2706         menu, Alt-F4 to close window, and etc) don't work.
2707
2708         WK1 WebView doesn't have this issue because it processes key events
2709         properly.
2710
2711         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2712         (WebKitBrowserWindow::WebKitBrowserWindow):
2713         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
2714         unhandled key events to the main window.
2715         * MiniBrowser/win/WebKitBrowserWindow.h:
2716
2717 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
2718
2719         iOS 13: Overflow:hidden on body prevents PDF scroll
2720         https://bugs.webkit.org/show_bug.cgi?id=200435
2721         rdar://problem/53942888
2722
2723         Reviewed by Tim Horton.
2724
2725         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
2726         to make sure that the scroll view is scrollable.
2727
2728         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
2729         (TestWebKitAPI::TEST):
2730
2731 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
2732
2733         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
2734         https://bugs.webkit.org/show_bug.cgi?id=200400
2735
2736         Reviewed by Jonathan Bedard.
2737
2738         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2739         (StatusBubble._build_bubble):
2740         (StatusBubble._queue_position):
2741
2742 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
2743
2744         run-webkit-tests asserts when the iPhone XR simulator is running
2745         https://bugs.webkit.org/show_bug.cgi?id=200404
2746         <rdar://problem/53878739>
2747
2748         Reviewed by Dean Jackson.
2749
2750         Support unicode in all logging statements tied to device model.
2751
2752         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2753         (Manager.run):
2754         * Scripts/webkitpy/layout_tests/views/printing.py:
2755         (Printer.print_baseline_search_path):
2756         * Scripts/webkitpy/port/device.py:
2757         (Device.__repr__):
2758         * Scripts/webkitpy/port/device_port.py:
2759         (DevicePort._install):
2760         (DevicePort.setup_test_run):
2761         (DevicePort.clean_up_test_run):
2762         (DevicePort.configuration_for_upload):
2763         * Scripts/webkitpy/port/ios.py:
2764         (IOSPort.default_baseline_search_path):
2765         * Scripts/webkitpy/xcode/device_type.py:
2766         (DeviceType.__str__):
2767         * Scripts/webkitpy/xcode/simulated_device.py:
2768         (SimulatedDeviceManager.populate_available_devices):
2769         (SimulatedDeviceManager._find_available_name):
2770         (SimulatedDeviceManager._get_device_identifier_for_type):
2771         (SimulatedDeviceManager._create_or_find_device_for_request):
2772         (SimulatedDeviceManager._does_fulfill_request):
2773         (SimulatedDeviceManager._wait_until_device_in_state):
2774         (SimulatedDeviceManager._wait_until_device_is_usable):
2775         (SimulatedDeviceManager._boot_device):
2776         (SimulatedDeviceManager.initialize_devices):
2777         (SimulatedDeviceManager.max_supported_simulators):
2778         (SimulatedDeviceManager.swap):
2779         (SimulatedDevice.is_usable):
2780         (SimulatedDevice._shut_down):
2781         (SimulatedDevice._delete):
2782         (SimulatedDevice.launch_app):
2783         (SimulatedDevice.__repr__):
2784
2785 2019-08-04  Chris Dumez  <cdumez@apple.com>
2786
2787         Ping loads should not prevent page caching
2788         https://bugs.webkit.org/show_bug.cgi?id=200418
2789         <rdar://problem/53901632>
2790
2791         Reviewed by Darin Adler.
2792
2793         Add TestOption to enable PageCache at UIProcess-level so that we can test
2794         page caching when navigating cross-origin with PSON enabled.
2795
2796         * WebKitTestRunner/TestController.cpp:
2797         (WTR::TestController::resetPreferencesToConsistentValues):
2798         (WTR::updateTestOptionsFromTestHeader):
2799         * WebKitTestRunner/TestOptions.h:
2800         (WTR::TestOptions::hasSameInitializationOptions const):
2801
2802 2019-08-02  Keith Rollin  <krollin@apple.com>
2803
2804         Consistently use Obj-C boolean literals
2805         https://bugs.webkit.org/show_bug.cgi?id=200405
2806         <rdar://problem/53880043>
2807
2808         Reviewed by Simon Fraser, Joseph Pecoraro.
2809
2810         There are places where we use equivalent but different expressions for
2811         Obj-C boolean objects. For example, we use both [NSNumber
2812         numberWithBool:YES] and @YES. There are places where both are used in
2813         the same function, such as -[WebPreferences initialize]. The boolean
2814         literal is in greater use and is more succinct, so standardize on
2815         that. Also, change @(YES/NO) to @YES/NO.
2816
2817         * DumpRenderTree/mac/ObjCController.m:
2818         (-[ObjCController objectOfClass:]):
2819         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2820         (TEST):
2821         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2822         (overrideAddObserverForName):
2823         * TestWebKitAPI/ios/mainIOS.mm:
2824         (main):
2825         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2826         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2827         * TestWebKitAPI/mac/mainMac.mm:
2828         (main):
2829         * WebKitLauncher/WebKitNightlyEnabler.m:
2830         (enableWebKitNightlyBehaviour):
2831
2832 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2833
2834         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
2835         https://bugs.webkit.org/show_bug.cgi?id=200402
2836         <rdar://problem/53823368>
2837
2838         Reviewed by Tim Horton.
2839
2840         Make it possible to run this test using the iPad simulator.
2841
2842         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2843
2844         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
2845         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
2846         since this would result in differently sized text.
2847
2848         (mainScreenReferenceBoundsOverride):
2849         * TestWebKitAPI/ios/UIKitSPI.h:
2850
2851 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
2852
2853         API tests using permanent credentials should clear credentials left by previous tests
2854         https://bugs.webkit.org/show_bug.cgi?id=199729
2855
2856         Reviewed by Alex Christensen.
2857
2858         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
2859         credentials will not affect tests running after. There is a case where permanent credentials were left on the
2860         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
2861         failure. To prevent this from happening again, add cleanup at the begining of the tests.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2864         (TEST):
2865         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2866         (TestWebKitAPI::TEST):
2867
2868 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
2869
2870         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
2871         https://bugs.webkit.org/show_bug.cgi?id=200394
2872         <rdar://problem/52914964>
2873
2874         Reviewed by Chris Fleizach.
2875
2876         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
2877
2878         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2879         (WTR::AccessibilityUIElement::isInTableCell const):
2880         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2881         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2882         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2883         (WTR::AccessibilityUIElement::isInTableCell const):
2884
2885 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
2886
2887         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
2888         https://bugs.webkit.org/show_bug.cgi?id=200397
2889
2890         Reviewed by Jonathan Bedard.
2891
2892         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2893
2894 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2895
2896         [macOS 10.15] Image dragged from Safari does not appear in Notes
2897         https://bugs.webkit.org/show_bug.cgi?id=188490
2898         <rdar://problem/39462717>
2899
2900         Reviewed by Andy Estes.
2901
2902         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
2903
2904         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2905
2906 2019-08-02  Alex Christensen  <achristensen@webkit.org>
2907
2908         Fix API test after r248139
2909         https://bugs.webkit.org/show_bug.cgi?id=200102
2910
2911         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
2912         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2913         This was supposed to be removed as part of reverting r245322.
2914
2915 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2916
2917         results.webkit.org: Force update cache when timeline updated
2918         https://bugs.webkit.org/show_bug.cgi?id=200363
2919
2920         Reviewed by Jonathan Bedard.
2921
2922         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2923         (offscreenCachedRenderFactory): Add ability to force the redraw.
2924         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
2925         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
2926
2927 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2928
2929         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
2930         https://bugs.webkit.org/show_bug.cgi?id=200360
2931
2932         Reviewed by Tim Horton.
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2935         (cleanupITPDatabase):
2936         (TEST):
2937
2938 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2939
2940         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
2941         https://bugs.webkit.org/show_bug.cgi?id=200102
2942         <rdar://problem/53275114>
2943
2944         Reviewed by Darin Adler.
2945
2946         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
2947         and because clicking on a TestWKWebView only works on Mac.
2948
2949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2950         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
2951         (-[UploadDelegate initWithDirectory:]):
2952         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2953         (-[UploadDelegate sentDirectory]):
2954         (TEST):
2955         * TestWebKitAPI/cocoa/TestWKWebView.h:
2956         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2957         (-[TestWKWebView sendClickAtPoint:]):
2958
2959 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2960
2961         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
2962         https://bugs.webkit.org/show_bug.cgi?id=200321
2963
2964         Reviewed by Jonathan Bedard.
2965
2966         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2967         Let the axis' height be defined in the option. Timeine component will use this value as
2968         padding-top for headers which allows headers start in the right position, even with multiple
2969         top axises.
2970         (Timeline.CanvasSeriesComponent):
2971         (prototype.Timeline.CanvasContainer):
2972
2973 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2974
2975         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
2976         https://bugs.webkit.org/show_bug.cgi?id=200347
2977
2978         Reviewed by Jonathan Bedard.
2979
2980         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2981         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
2982
2983 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
2984
2985         Improve flakiness of SOAuthorizationRedirect tests
2986         https://bugs.webkit.org/show_bug.cgi?id=200320
2987         <rdar://problem/53767057>
2988
2989         Reviewed by Alex Christensen.
2990
2991         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
2992         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
2993         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
2994         is executed.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2997         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2998         (resetState):
2999         (TestWebKitAPI::TEST):
3000
3001 2019-08-01  Keith Rollin  <krollin@apple.com>
3002
3003         Update TestWebKitAPI for XCBuild
3004         https://bugs.webkit.org/show_bug.cgi?id=200311
3005         <rdar://problem/53773804>
3006
3007         Reviewed by Alex Christensen.
3008
3009         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
3010         technique. Now update WebKitLegacy to build under XCBuild after those
3011         changes. This work involves adding an "Apply Configuration to
3012         XCFileLists" build target, adding a check-xcfilelists.sh script,
3013         adding a "Check xcfilelists" build phase that calls that script,
3014         adding knowledge of the project to the generate-xcfilelists script,
3015         creating new .xcfilelist files, and adding those to the project.
3016
3017         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
3018         (Application.__init__):
3019         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3020         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
3021         (TestWebKitAPIGenerator):
3022         (TestWebKitAPIGenerator._get_project_file_path):
3023         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
3024         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
3025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3026         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
3027
3028 2019-08-01  Youenn Fablet  <youenn@apple.com>
3029
3030         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
3031         https://bugs.webkit.org/show_bug.cgi?id=200317
3032
3033         Reviewed by Eric Carlson.
3034
3035         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3037         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3038         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
3039         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3040         (TestWebKitAPI::TEST):
3041
3042 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
3043
3044         New EWS: Cannot see build status page when patch is waiting for tester
3045         https://bugs.webkit.org/show_bug.cgi?id=200333
3046
3047         Reviewed by Jonathan Bedard.
3048
3049         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3050         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
3051
3052 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3053
3054         [SOUP] Switch to use libsoup WebSockets API
3055         https://bugs.webkit.org/show_bug.cgi?id=200162
3056
3057         Reviewed by Michael Catanzaro.
3058
3059         Update libsoup version to 2.67.90.
3060
3061         * gtk/jhbuild.modules:
3062         * wpe/jhbuild.modules:
3063
3064 2019-07-31  Andy Estes  <aestes@apple.com>
3065
3066         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
3067         https://bugs.webkit.org/show_bug.cgi?id=200293
3068         <rdar://problem/52937749>
3069
3070         Reviewed by Alex Christensen.
3071
3072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3073         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
3074         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3075         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3076         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
3077         (TEST):
3078
3079 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
3080
3081         [ews-build] Enable all macOS queues on new EWS
3082         https://bugs.webkit.org/show_bug.cgi?id=199944
3083
3084         Reviewed by Jonathan Bedard.
3085
3086         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
3087         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3088         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
3089         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
3091         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
3092
3093 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
3094
3095         Unreviewed test gardening, disable failing test for rdar://51752593.
3096
3097         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3098
3099 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
3100
3101         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
3102         https://bugs.webkit.org/show_bug.cgi?id=200318
3103
3104         Reviewed by Aakash Jain.
3105
3106         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3107         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
3108         (Timeline.CanvasXAxisComponent): Use getLabel function.
3109
3110 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
3111
3112         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
3113         https://bugs.webkit.org/show_bug.cgi?id=200306
3114
3115         Reviewed by Michael Catanzaro.
3116
3117         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
3118         jsc-glib-4.0-scan for example).
3119
3120         * Scripts/webkitdirs.pm:
3121         (generateBuildSystemFromCMakeProject):
3122
3123 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
3124
3125         Unreviewed test gardening, disable failing test for rdar://52355829.
3126
3127         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3128         (TEST):
3129
3130 2019-07-31  Keith Rollin  <krollin@apple.com>
3131
3132         Update WebKitLegacy for XCBuild
3133         https://bugs.webkit.org/show_bug.cgi?id=200310
3134         <rdar://problem/53773708>
3135
3136         Reviewed by Alex Christensen.
3137
3138         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
3139         technique. Now update WebKitLegacy to build under XCBuild after those
3140         changes. This work involves adding an "Apply Configuration to
3141         XCFileLists" build target, adding a check-xcfilelists.sh script,
3142         adding a "Check xcfilelists" build phase that calls that script,
3143         adding knowledge of the project to the generate-xcfilelists script,
3144         creating new .xcfilelist files, and adding those to the project.
3145
3146         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
3147         (Application.__init__):
3148         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3149         (JavaScriptCoreGenerator):
3150         (WebCoreGenerator):
3151         (WebKitGenerator):
3152         (WebKitGenerator._get_generate_unified_sources_script):
3153         (WebKitLegacyGenerator):
3154         (WebKitLegacyGenerator._get_project_file_path):
3155         (WebKitLegacyGenerator._get_generate_unified_sources_script):
3156
3157 2019-07-31  Chris Dumez  <cdumez@apple.com>
3158
3159         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
3160         https://bugs.webkit.org/show_bug.cgi?id=200086
3161         <rdar://problem/53501721>
3162
3163         Reviewed by Alex Christensen.
3164
3165         re-enable the API test.
3166
3167         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3168         (TEST):
3169
3170 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3171
3172         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
3173         https://bugs.webkit.org/show_bug.cgi?id=200291
3174         <rdar://problem/53717946>
3175
3176         Reviewed by Megan Gardner.
3177
3178         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
3179         after closing the web view, while the web view's content view isn't the first responder.
3180
3181         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
3182         * TestWebKitAPI/ios/UIKitSPI.h:
3183
3184 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3185
3186         [GTK] Datalist element support for TextFieldInputType
3187         https://bugs.webkit.org/show_bug.cgi?id=98934
3188
3189         Reviewed by Michael Catanzaro.
3190
3191         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
3192
3193         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3194         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
3195         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
3196
3197 2019-07-30  Tim Horton  <timothy_horton@apple.com>
3198
3199         Remove some needless comments that snuck into the tree
3200
3201         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3202         (WTR::UIScriptController::setHardwareKeyboardAttached):
3203         (WTR::UIScriptController::playBackEventStream):
3204
3205 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3206
3207         [WebKit] Add PageLoadState::Observer C API
3208         https://bugs.webkit.org/show_bug.cgi?id=199848
3209
3210         Reviewed by Alex Christensen.
3211
3212         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3213         (WebKitBrowserWindow::WebKitBrowserWindow):
3214         (WebKitBrowserWindow::didChangeTitle):
3215         (WebKitBrowserWindow::didFinishNavigation): Deleted.
3216         * MiniBrowser/win/WebKitBrowserWindow.h:
3217         * TestWebKitAPI/CMakeLists.txt:
3218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3219         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
3220         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
3221         (TestWebKitAPI::didChangeActiveURL):
3222         (TestWebKitAPI::didChangeCanGoBack):
3223         (TestWebKitAPI::didChangeCanGoForward):
3224         (TestWebKitAPI::didChangeCertificateInfo):
3225         (TestWebKitAPI::didChangeEstimatedProgress):
3226         (TestWebKitAPI::didChangeHasOnlySecureContent):
3227         (TestWebKitAPI::didChangeIsLoading):
3228         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
3229         (TestWebKitAPI::didChangeTitle):
3230         (TestWebKitAPI::didChangeWebProcessIsResponsive):
3231         (TestWebKitAPI::didSwapWebProcesses):
3232         (TestWebKitAPI::willChangeActiveURL):
3233         (TestWebKitAPI::willChangeCanGoBack):
3234         (TestWebKitAPI::willChangeCanGoForward):
3235         (TestWebKitAPI::willChangeCertificateInfo):
3236         (TestWebKitAPI::willChangeEstimatedProgress):
3237         (TestWebKitAPI::willChangeHasOnlySecureContent):
3238         (TestWebKitAPI::willChangeIsLoading):
3239         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
3240         (TestWebKitAPI::willChangeTitle):
3241         (TestWebKitAPI::willChangeWebProcessIsResponsive):
3242         (TestWebKitAPI::didFinishNavigation):
3243         (TestWebKitAPI::TEST):
3244
3245 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
3246
3247         DumpRenderTree.app: Add CFBundleShortVersionString
3248         https://bugs.webkit.org/show_bug.cgi?id=200269
3249         <rdar://problem/53412596>
3250
3251         Rubber-stamped by Aakash Jain.
3252
3253         * DumpRenderTree/ios/Info.plist:
3254
3255 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3256
3257         Add layout test coverage for <https://webkit.org/b/200215>
3258         https://bugs.webkit.org/show_bug.cgi?id=200245
3259         <rdar://problem/52976965>
3260
3261         Reviewed by Tim Horton.
3262
3263         Add new testing infrastructure. See below for more details.
3264
3265         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3266         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3267         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3268         (WTR::UIScriptController::setWillCreateNewPageCallback):
3269         (WTR::UIScriptController::willCreateNewPageCallback const):
3270
3271         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
3272         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
3273
3274         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3275         (WTR::UIScriptController::becomeFirstResponder):
3276
3277         Add and implement a Cocoa platform hook to make the web view first responder.
3278
3279         * WebKitTestRunner/TestController.cpp:
3280         (WTR::TestController::createOtherPage):
3281         * WebKitTestRunner/TestInvocation.cpp:
3282         (WTR::TestInvocation::willCreateNewPage):
3283         * WebKitTestRunner/TestInvocation.h:
3284         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3285         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3286         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
3287
3288 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3289
3290         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
3291         https://bugs.webkit.org/show_bug.cgi?id=200217
3292
3293         Reviewed by Alex Christensen.
3294
3295         * MiniBrowser/win/BrowserWindow.h:
3296         * MiniBrowser/win/MainWindow.cpp:
3297         (MainWindow::init):
3298         (MainWindow::resizeSubViews):
3299         (MainWindow::WndProc):
3300         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
3301         * MiniBrowser/win/MiniBrowserLib.rc:
3302         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
3303         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3304         (WebKitBrowserWindow::reload):
3305         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
3306         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3307         (WebKitLegacyBrowserWindow::reload):
3308         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3309
3310 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3311
3312         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
3313         https://bugs.webkit.org/show_bug.cgi?id=200218
3314
3315         Reviewed by Alex Christensen.
3316
3317         Moved the scheme supplementing logic from
3318         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
3319
3320         * MiniBrowser/win/MainWindow.cpp:
3321         (MainWindow::loadURL):
3322         (MainWindow::onURLBarEnter):
3323         * MiniBrowser/win/MainWindow.h:
3324         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3325         (WebKitLegacyBrowserWindow::loadURL):
3326
3327 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
3328
3329         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
3330         https://bugs.webkit.org/show_bug.cgi?id=200254
3331
3332         Unreviewed infrastructure fix.
3333
3334         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
3335
3336 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
3337
3338         [Canvas Timeline] Compact canvas timeline
3339         https://bugs.webkit.org/show_bug.cgi?id=200177
3340
3341         Reviewed by Jonathan Bedard.
3342
3343         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
3344         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3345         (Timeline.CanvasSeriesComponent):
3346
3347 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         Multiple context menu actions broken for YouTube videos
3350         https://bugs.webkit.org/show_bug.cgi?id=199999
3351
3352         Reviewed by Eric Carlson.
3353
3354         Add a test case to check copy link address, open in new window and download options are not included in the
3355         context menu for non-downloadable media.
3356
3357         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3358         (writeNextChunk):
3359         (serverCallback):
3360         (testContextMenuLiveStream):
3361         (beforeAll):
3362         (afterAll):
3363
3364 2019-07-28  Tim Horton  <timothy_horton@apple.com>
3365
3366         Reorganize UIScriptController into platform-specific subclasses
3367         https://bugs.webkit.org/show_bug.cgi?id=200027
3368
3369         Reviewed by Simon Fraser.
3370
3371         Instead of a mishmash of #ifdefs and extraneous empty functions,
3372         reorganize UIScriptController so that we have a base class
3373         with functions that assert if called (to make it harder to
3374         accidentally write a test that depends on unimplemented
3375         functionality), and override them in platform specific subclasses
3376         as functionality is added.
3377
3378         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3379         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
3380         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3381         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
3382         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3383         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3384         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3385         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3386         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
3387         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
3388         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3389         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
3390         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
3391         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3392         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
3393         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3394
3395 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3396
3397         [Win][MiniBrowser] Remove PageLoadTestClient
3398         https://bugs.webkit.org/show_bug.cgi?id=200155
3399
3400         Reviewed by Brent Fulgham.
3401
3402         It is not used nowadays.
3403
3404         * MiniBrowser/win/CMakeLists.txt:
3405         * MiniBrowser/win/Common.cpp:
3406         (parseCommandLine):
3407         * MiniBrowser/win/Common.h:
3408         * MiniBrowser/win/MainWindow.cpp:
3409         (MainWindow::init):
3410         * MiniBrowser/win/MainWindow.h:
3411         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3412         (MiniBrowserWebHost::updateAddressBar):
3413         (MiniBrowserWebHost::didFinishLoadForFrame):
3414         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
3415         (MiniBrowserWebHost::didFailLoadWithError):
3416         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
3417         (MiniBrowserWebHost::didFirstLayoutInFrame):
3418         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
3419         * MiniBrowser/win/PageLoadTestClient.h: Removed.
3420         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3421         (ResourceLoadDelegate::identifierForInitialRequest):
3422         (ResourceLoadDelegate::willSendRequest):
3423         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3424         (ResourceLoadDelegate::didFailLoadingWithError):
3425         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3426         (WebKitBrowserWindow::create):
3427         (WebKitBrowserWindow::createNewPage):
3428         * MiniBrowser/win/WebKitBrowserWindow.h:
3429         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3430         (WebKitLegacyBrowserWindow::create):
3431         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
3432         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
3433         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3434         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
3435         * MiniBrowser/win/WinMain.cpp:
3436         (wWinMain):
3437
3438 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
3439
3440         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
3441         https://bugs.webkit.org/show_bug.cgi?id=200150
3442         <rdar://problem/53280170>
3443
3444         Reviewed by Brent Fulgham.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3447         (TestWebKitAPI::TEST):
3448
3449 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3450
3451         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
3452         https://bugs.webkit.org/show_bug.cgi?id=200090
3453
3454         Unreviewed follow-up fix.
3455
3456         * resultsdbpy/resultsdbpy/view/view_routes.py:
3457         (ViewRoutes.__init__): Keep /search endpoint for existing links
3458
3459 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3460
3461         results.webkit.org: Add switch to filter results by expectation
3462         https://bugs.webkit.org/show_bug.cgi?id=200134
3463
3464         Rubber-stamped by Aakash Jain.
3465
3466         Users of the results database should be able to easily differentiate tests which are expected
3467         to fail verse tests which are unexpectedly failing.
3468
3469         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3470         (Timeline.render): Respect the willFilterExpected variable.
3471         (LegendLabel): Generates html for label in the legend.
3472         (Legend): Add switch for filter results.
3473         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
3474         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3475
3476 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
3477
3478         [ews-build] Use update-webkit script in Style EWS
3479         https://bugs.webkit.org/show_bug.cgi?id=193196
3480
3481         Reviewed by Jonathan Bedard.
3482
3483         * BuildSlaveSupport/ews-build/factories.py:
3484         (StyleFactory): Updated to use CheckOutSource step as well.
3485         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
3486         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3487
3488 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3489
3490         results.webkit.org: Support buildbot 0.8 CI links
3491         https://bugs.webkit.org/show_bug.cgi?id=200146
3492
3493         Reviewed by Aakash Jain.
3494
3495         * resultsdbpy/resultsdbpy/model/ci_context.py:
3496         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
3497         (BuildbotEightURLFactory.__init__):
3498         (BuildbotEightURLFactory.url):
3499         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
3500         (URLFactoryTest.test_old_builder_url):
3501         (URLFactoryTest):
3502         (URLFactoryTest.test_old_worker_url):
3503
3504 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3505
3506         results.webkit.org: Suite results shouldn't be the landing page
3507         https://bugs.webkit.org/show_bug.cgi?id=200090
3508
3509         Reviewed by Aakash Jain.
3510
3511         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
3512         * resultsdbpy/resultsdbpy/view/view_routes.py:
3513         (ViewRoutes.__init__): Make search the landing page instead of suite results.
3514         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
3515         (WebSiteUnittest.test_main):
3516
3517 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3518
3519         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
3520         https://bugs.webkit.org/show_bug.cgi?id=200127
3521
3522         Unreviewed follow-up fix.
3523
3524         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3525         (Dot.toString): Use self instead of this in render callback.
3526
3527 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
3528
3529         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
3530         https://bugs.webkit.org/show_bug.cgi?id=200108
3531         <rdar://problem/53521238>
3532
3533         Reviewed by Chris Dumez.
3534
3535         Added an API test.
3536
3537         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3538         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3539         (TEST):
3540
3541 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
3542
3543         results.webkit.org: Color should be the worst result, count should include all results
3544         https://bugs.webkit.org/show_bug.cgi?id=200127
3545
3546         Rubber-stamped by Aakash Jain.
3547
3548         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3549         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
3550
3551 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
3552
3553         [Timeline]: Make timeline header width automatic, instead of fixed width
3554         https://bugs.webkit.org/show_bug.cgi?id=200059
3555
3556         Reviewed by Jonathan Bedard.
3557
3558         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3559         (.dot.crash):
3560         (.timeline>.header): Deleted.
3561         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3562         (.timeline>.content):
3563         (.timeline>.header):
3564
3565 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
3566
3567         [ESNext] Implement nullish coalescing
3568         https://bugs.webkit.org/show_bug.cgi?id=200072
3569
3570         Reviewed by Darin Adler.
3571
3572         * Scripts/run-jsc-stress-tests:
3573
3574 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3575
3576         Add Takashi Komori and Tomoki Imai as contributors
3577
3578         Unreviewed.
3579
3580         * Scripts/webkitpy/common/config/contributors.json:
3581
3582 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
3583
3584         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
3585         https://bugs.webkit.org/show_bug.cgi?id=200103
3586
3587         Reviewed by Mark Lam.
3588
3589         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
3590         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
3591
3592         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
3593         to the future implementation changes while it catches the severe issues we had.
3594
3595         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3596         (assertEmptyPointerSet):
3597         (assertHasOnlyObjects):
3598         (assertClean):
3599         (TEST):
3600         (allocateAndDeallocate):
3601
3602 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
3603
3604         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
3605         https://bugs.webkit.org/show_bug.cgi?id=200074
3606
3607         Reviewed by Michael Catanzaro.
3608
3609         There was a latent issue. PluginTest::indicateTestFailure was
3610         using WTF::sleep without linking WTF.
3611
3612         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3613         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
3614
3615 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
3616
3617         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
3618         https://bugs.webkit.org/show_bug.cgi?id=200073
3619
3620         Reviewed by Michael Catanzaro.
3621
3622         * TestWebKitAPI/PlatformGTK.cmake:
3623         * TestWebKitAPI/PlatformWPE.cmake:
3624         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
3625
3626 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3627
3628         [webkitperl] runCommand doesn't work in Windows Perl
3629         https://bugs.webkit.org/show_bug.cgi?id=199900
3630
3631         Reviewed by Don Olmstead.
3632
3633         runCommand was always failing implicit fork by using 'open' with
3634         '-|' in Windows Perl. Explicitly specify the command to 'open' not
3635         to do the implicit fork.
3636
3637         There is one more difference between Windows and Unix. 'open'
3638         successes on Windows even for non existent command while it fails
3639         on Unix. So, return the same error code on Unix as well as
3640         Windows.
3641
3642         * Scripts/VCSUtils.pm: Specified the command to 'open'.
3643         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
3644         command is not available on Windows. Use Perl ($^X) instead.
3645
3646 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
3647
3648         Allow Clients to Add Fields to the AutoFillContext Dictionary.
3649         https://bugs.webkit.org/show_bug.cgi?id=199326
3650         rdar://problem/42816957
3651
3652         Reviewed by Wenson Hsieh.
3653
3654         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3655         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
3656         is being properly populated with additional context dictionary.
3657
3658         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3659         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3660         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
3661         which will populate the additional autofill context dictionary.
3662
3663         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
3664         populates the additional autofill context dictionary.
3665
3666         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
3667         context dictionary.
3668
3669         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
3670         input field requires strong password work.
3671
3672         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
3673         input field requires strong password work.
3674
3675         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
3676         password work.
3677
3678 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
3679
3680         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
3681         https://bugs.webkit.org/show_bug.cgi?id=199489
3682
3683         Reviewed by Aakash Jain.
3684
3685         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3686         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
3687         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
3688         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3689         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
3690         (runTest): Record test binary failure
3691         (reportTestFailures): Report test binary failure
3692         (runJSCStressTests):
3693         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
3694         (JscOnlyPort.build_jsc_command):
3695         (JscOnlyPort):
3696         (JscOnlyPort.run_javascriptcore_tests_command):
3697         * Scripts/webkitpy/common/config/ports_unittest.py:
3698         (DeprecatedPortTest.test_jsconly_port):
3699
3700 2019-07-24  Zalan Bujtas  <zalan@apple.com>
3701
3702         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
3703         https://bugs.webkit.org/show_bug.cgi?id=200079
3704         <rdar://problem/53474325>
3705
3706         Reviewed by Wenson Hsieh.
3707
3708         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
3709
3710         * WebKitTestRunner/ios/TestControllerIOS.mm:
3711         (WTR::TestController::platformResetPreferencesToConsistentValues):
3712
3713 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
3714
3715         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
3716         https://bugs.webkit.org/show_bug.cgi?id=199927
3717
3718         Reviewed by Alex Christensen.
3719
3720         convertAbsolutepathToWebKitPath was failing to convert paths on
3721         Windows Perl due to path separators mismatch.
3722
3723         Renamed convertAbsolutepathToWebKitPath to
3724         convertAbsolutePathToRelativeUnixPath, and changed it to replace
3725         paths to relative Unix paths.
3726
3727         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3728         (convertAbsolutePathToRelativeUnixPath): Added.
3729         (convertAbsolutepathToWebKitPath): Deleted.
3730
3731 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3732
3733         Fix iOS API test after r247759
3734         https://bugs.webkit.org/show_bug.cgi?id=200045
3735
3736         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3737         (TEST):
3738         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
3739         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
3740
3741 2019-07-23  Keith Rollin  <krollin@apple.com>
3742
3743         Remove rest of NavigatorContentUtils support
3744         https://bugs.webkit.org/show_bug.cgi?id=200052
3745         <rdar://problem/53467357>
3746
3747         Reviewed by Alex Christensen.
3748
3749         Bug 196070 removes most of the support for the never-used
3750         NavigatorContentUtils facility. However, there were still a couple of
3751         left-over references after that change. This patch sweeps those up.
3752
3753         * Scripts/webkitperl/FeatureList.pm:
3754
3755 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3756
3757         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3758         https://bugs.webkit.org/show_bug.cgi?id=200045
3759
3760         Reviewed by Mark Lam.
3761
3762         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3763         (TEST):
3764
3765 2019-07-23  Russell Epstein  <repstein@apple.com>
3766
3767         Unreviewed, rolling out r247745.
3768
3769         This broke API test
3770         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
3771         indicated by EWS
3772
3773         Reverted changeset:
3774
3775         "Move javaScriptConfigurationDirectory SPI from
3776         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
3777         runtime switchable"
3778         https://bugs.webkit.org/show_bug.cgi?id=200045
3779         https://trac.webkit.org/changeset/247745
3780
3781 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3782
3783         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3784         https://bugs.webkit.org/show_bug.cgi?id=200045
3785
3786         Reviewed by Mark Lam.
3787
3788         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3789         (TEST):
3790
3791 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3792
3793         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
3794         https://bugs.webkit.org/show_bug.cgi?id=199972
3795
3796         Reviewed by Jer Noble.
3797
3798         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3799         (TEST):
3800
3801 2019-07-23  Alicia Boya García  <aboya@igalia.com>
3802
3803         [WTF] Add DataMutex and MainThreadData wrappers
3804         https://bugs.webkit.org/show_bug.cgi?id=199831
3805
3806         Reviewed by Alex Christensen.
3807
3808         Added a very simple test that checks that DataMutex<T> indeed takes
3809         the lock and indeed holds data.
3810
3811         * TestWebKitAPI/CMakeLists.txt:
3812         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
3813         (TestWebKitAPI::TEST):
3814
3815 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3816
3817         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
3818         https://bugs.webkit.org/show_bug.cgi?id=200021
3819         <rdar://problem/53301325>
3820
3821         Reviewed by Ryosuke Niwa.
3822
3823         Add support for grabbing the child menu items of a context menu item.
3824
3825         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3826         (WTR::getMenuItemChildrenCallback):
3827
3828 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
3829
3830         WebKit should strip away system font names from the pasted content
3831         https://bugs.webkit.org/show_bug.cgi?id=199975
3832         <rdar://problem/53336353>
3833
3834         Reviewed by Darin Adler.
3835
3836         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
3837
3838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3839         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3840         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
3841
3842 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3843
3844         [ews-build] EWS fails to parse multi-line full_results.json
3845         https://bugs.webkit.org/show_bug.cgi?id=199992
3846
3847         Reviewed by Alexey Proskuryakov.
3848
3849         * BuildSlaveSupport/ews-build/layout_test_failures.py:
3850         (LayoutTestFailures.results_from_string): Concatenate content into single line.
3851         * BuildSlaveSupport/ews-build/steps_unittest.py:
3852         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
3853
3854 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3855
3856         resultsdbpy: Handle case where the previous commit doesn't have the changelog
3857         https://bugs.webkit.org/show_bug.cgi?id=200015
3858
3859         Reviewed by Aakash Jain.
3860
3861         * resultsdbpy/resultsdbpy/model/repository.py:
3862         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
3863
3864 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3865
3866         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
3867         https://bugs.webkit.org/show_bug.cgi?id=200013
3868         <rdar://problem/52526901>
3869
3870         Reviewed by Simon Fraser.
3871
3872         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
3873
3874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3875         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
3876         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
3877         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
3878         * TestWebKitAPI/ios/UIKitSPI.h:
3879
3880 2019-07-22  Jer Noble  <jer.noble@apple.com>
3881
3882         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
3883         https://bugs.webkit.org/show_bug.cgi?id=199971
3884         <rdar://problem/51951218>
3885
3886         Reviewed by Alex Christensen.
3887
3888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3889         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
3890         (TestWebKitAPI::TEST):
3891
3892 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3893
3894         [ews-build] Add an EWS to run services tests
3895         https://bugs.webkit.org/show_bug.cgi?id=199994
3896
3897         Reviewed by Jonathan Bedard.
3898
3899         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
3900         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
3901         * BuildSlaveSupport/ews-build/steps.py:
3902         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
3903         (RunEWSUnitTests): Build step to run EWS unit-tests.
3904         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
3905         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3906         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
3907
3908 2019-07-22  Youenn Fablet  <youenn@apple.com>
3909
3910         Disable MediaRecorder for legacy WebKit
3911         https://bugs.webkit.org/show_bug.cgi?id=200001
3912         <rdar://problem/53400030>
3913
3914         Reviewed by Eric Carlson.
3915
3916         Enable MediaRecorder for testing purposes.
3917
3918         * DumpRenderTree/mac/DumpRenderTree.mm:
3919         (createWebViewAndOffscreenWindow):
3920
3921 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3922
3923         results.webkit.org: Timeline header is too small
3924         https://bugs.webkit.org/show_bug.cgi?id=199955
3925
3926         Reviewed by Aakash Jain.
3927
3928         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3929         (.timeline>.header): Make timeline header larder to fit configuration names.
3930
3931 2019-07-22  Alex Christensen  <achristensen@webkit.org>
3932
3933         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
3934         https://bugs.webkit.org/show_bug.cgi?id=199954
3935
3936         Reviewed by Geoff Garen.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3939         (TEST):
3940
3941 2019-07-22  Alex Christensen  <achristensen@webkit.org>
3942
3943         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
3944         https://bugs.webkit.org/show_bug.cgi?id=199917
3945
3946         Reviewed by Sam Weinig.
3947
3948         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3949         (TEST):
3950
3951 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3952
3953         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
3954         https://bugs.webkit.org/show_bug.cgi?id=199980
3955
3956         Reviewed by Jonathan Bedard.
3957
3958         * BuildSlaveSupport/ews-build/steps.py:
3959         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
3960         * BuildSlaveSupport/ews-build/steps_unittest.py:
3961         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
3962         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
3963
3964 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3965
3966         [webkitpy] Add an unit test for setting up the driver environment without starting it.
3967         https://bugs.webkit.org/show_bug.cgi?id=199945
3968
3969         Reviewed by Michael Catanzaro.
3970
3971         This adds an unit test for the change implemented in r247663.
3972
3973         * Scripts/webkitpy/port/driver_unittest.py:
3974         (DriverTest.test_setup_environ_base_vars):
3975         (DriverTest):
3976         (DriverTest.test_setup_environ_without_starting_driver):
3977
3978 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3979
3980         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
3981         https://bugs.webkit.org/show_bug.cgi?id=199993
3982         <rdar://problem/49523528>
3983
3984         Reviewed by Beth Dakin.
3985
3986         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
3987
3988         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3989         (TestWebKitAPI::TEST):
3990         * TestWebKitAPI/cocoa/TestWKWebView.h:
3991
3992 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
3993
3994         Add accessibilityInsertText for text insertion in edit fields.
3995         https://bugs.webkit.org/show_bug.cgi?id=199973
3996
3997         Reviewed by Chris Fleizach.
3998
3999         Renamed accessibilityInsertText to _accessibilityInsertText.
4000
4001         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4002         (AccessibilityUIElement::insertText):
4003         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4004         (AccessibilityUIElement::insertText):
4005         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4006         (WTR::AccessibilityUIElement::insertText):
4007         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4008         (WTR::AccessibilityUIElement::insertText):
4009
4010 2019-07-20  Chris Dumez  <cdumez@apple.com>
4011
4012         Speed up HashTable decoding by reserving capacity and avoiding rehashing
4013         https://bugs.webkit.org/show_bug.cgi?id=199982
4014
4015         Reviewed by Saam Barati.
4016
4017         Add API test coverage.
4018
4019         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4020         (TestWebKitAPI::TEST):
4021
4022 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
4023
4024         Add accessibilityInsertText for text insertion in edit fields.
4025         https://bugs.webkit.org/show_bug.cgi?id=199973
4026
4027         Reviewed by Chris Fleizach.
4028
4029         Glue code to run new LayoutTests.
4030         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4031         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4032         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4033         (WTR::AccessibilityUIElement::insertText):
4034         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4035         (WTR::AccessibilityUIElement::insertText):
4036         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4037         (WTR::AccessibilityUIElement::insertText):
4038         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
4039         (WTR::AccessibilityUIElement::insertText):
4040
4041 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
4042
4043         Move webkit.css to opensource to support resultsdbpy's frontend
4044         https://bugs.webkit.org/show_bug.cgi?id=199957
4045
4046         Reviewed by Jonathan Bedard.
4047
4048         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
4049         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
4050         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
4051         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
4052
4053 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
4054
4055         Move Ref.js to WebKit to support resultsdbpy's frontend
4056         https://bugs.webkit.org/show_bug.cgi?id=199956
4057
4058         Reviewed by Jonathan Bedard.
4059
4060         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
4061         * resultsdbpy/resultsdbpy/view/static/js/search.js:
4062         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
4063         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
4064         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
4065         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
4066         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
4067         * resultsdbpy/resultsdbpy/view/templates/base.html:
4068         * resultsdbpy/resultsdbpy/view/templates/commits.html:
4069         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
4070         * resultsdbpy/resultsdbpy/view/templates/search.html:
4071         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
4072         * resultsdbpy/resultsdbpy/view/view_routes.py:
4073
4074 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4075
4076         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
4077         https://bugs.webkit.org/show_bug.cgi?id=199945
4078
4079         Reviewed by Michael Catanzaro.
4080
4081         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
4082         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
4083         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
4084
4085         * Scripts/webkitpy/port/driver.py:
4086         (Driver._setup_environ_for_driver):
4087         (Driver._create_temporal_directories):
4088         (Driver):
4089         (Driver._start):
4090         (Driver._delete_temporal_directories):
4091         (Driver.stop):
4092         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
4093         (main):
4094         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
4095         (WebDriverTestRunner.__init__):
4096         * glib/api_test_runner.py:
4097         (TestRunner._setup_testing_environment): Ditto.
4098
4099 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
4100
4101         [ews-build] Display pre-existing Layout test failure names in the build summary
4102         https://bugs.webkit.org/show_bug.cgi?id=199941
4103
4104         Reviewed by Jonathan Bedard.
4105
4106         * BuildSlaveSupport/ews-build/steps.py:
4107         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
4108
4109 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4110
4111         [GTK][WPE] run-webkit-tests should run with a temporal homedir
4112         https://bugs.webkit.org/show_bug.cgi?id=199738
4113
4114         Reviewed by Michael Catanzaro.
4115
4116         Run the tests with an empty homedir that is created inside the driver tmpdir.
4117         The driver tmpdir is a random directory created for each test runner that is purged after the run.
4118
4119         This is done to ensure that the test results are not affected by the user settings of any library.
4120
4121         * Scripts/webkitpy/port/driver.py:
4122         (Driver._setup_environ_for_driver):
4123         * Scripts/webkitpy/port/driver_unittest.py:
4124         (DriverTest.test_setup_environ_base_vars):
4125         (DriverTest):
4126         (DriverTest.test_create_temporal_home_dir):
4127
4128 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
4129
4130         Remove pywebsockets from thirdparty
4131         https://bugs.webkit.org/show_bug.cgi?id=199710
4132
4133         Reviewed by Jonathan Bedard.
4134
4135         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
4136         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
4137
4138         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
4139         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
4140         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
4141         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
4142         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
4143         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
4144         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
4145         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
4146         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
4147         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
4148         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
4149         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
4150         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
4151         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
4152         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
4153         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
4154         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
4155         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
4156         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
4157         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
4158         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
4159         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
4160
4161 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
4162
4163         results.webkit.org: Move resultsdbpy to WebKit
4164         https://bugs.webkit.org/show_bug.cgi?id=199837
4165         <rdar://problem/53172130>
4166
4167         Rubber-stamped by Aakash Jain.
4168
4169         Moving the entirety of the resultsdbpy library, which provides utilities to build
4170         a database designed to store, visualize and organize test results, into WebKit.
4171
4172         * Scripts/webkitpy/style/checker.py:
4173         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
4174         * resultsdbpy: Added.
4175         * resultsdbpy/MANIFEST.in: Added.
4176         * resultsdbpy/README.md: Added.
4177         * resultsdbpy/resultsdbpy: Added.
4178         * resultsdbpy/resultsdbpy/__init__.py: Added.
4179         * resultsdbpy/resultsdbpy/controller: Added.
4180         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
4181         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
4182         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
4183         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
4184         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
4185         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
4186         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
4187         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
4188         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
4189         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
4190         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
4191         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
4192         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
4193         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
4194         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
4195         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
4196         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
4197         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
4198         * resultsdbpy/resultsdbpy/flask_support: Added.
4199         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
4200         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
4201         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
4202         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
4203         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
4204         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
4205         * resultsdbpy/resultsdbpy/model: Added.
4206         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
4207         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
4208         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
4209         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
4210         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
4211         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
4212         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
4213         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
4214         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
4215         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
4216         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
4217         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
4218         * resultsdbpy/resultsdbpy/model/docker.py: Added.
4219         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
4220         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
4221         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
4222         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
4223         * resultsdbpy/resultsdbpy/model/model.py: Added.
4224         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
4225         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
4226         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
4227         * resultsdbpy/resultsdbpy/model/repository.py: Added.
4228         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
4229         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
4230         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
4231         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
4232         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
4233         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
4234         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
4235         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
4236         * resultsdbpy/resultsdbpy/run-tests: Added.
4237         * resultsdbpy/resultsdbpy/view: Added.
4238         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
4239         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
4240         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
4241         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
4242         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
4243         * resultsdbpy/resultsdbpy/view/static: Added.
4244         * resultsdbpy/resultsdbpy/view/static/css: Added.
4245         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
4246         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
4247         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
4248         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
4249         * resultsdbpy/resultsdbpy/view/static/js: Added.
4250         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
4251         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
4252         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
4253         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
4254         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
4255         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
4256         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
4257         * resultsdbpy/resultsdbpy/view/templates: Added.
4258         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
4259         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
4260         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
4261         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.