47cf2307d8ae9fa4d6a491e9ee9410ee3bc4c0b0
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-12  Justin Fan  <justin_fan@apple.com>
2
3         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4         https://bugs.webkit.org/show_bug.cgi?id=195518
5         <rdar://problem/46322356>
6
7         Reviewed by Myles C. Maxfield.
8
9         * DumpRenderTree/DerivedSources-input.xcfilelist:
10         * DumpRenderTree/DerivedSources-output.xcfilelist:
11
12 2019-03-12  Commit Queue  <commit-queue@webkit.org>
13
14         Unreviewed, rolling out r242825.
15         https://bugs.webkit.org/show_bug.cgi?id=195648
16
17         "Broke webkitpy tests with my change to
18         lldb_dump_class_layout.py" (Requested by rmorisset on
19         #webkit).
20
21         Reverted changeset:
22
23         "Alter Tools/Scripts/dump-class-layout to be able to dump all
24         classes with suspicious padding"
25         https://bugs.webkit.org/show_bug.cgi?id=195573
26         https://trac.webkit.org/changeset/242825
27
28 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
29
30         [ews-build] Show status bubbles while the patch is waiting in queue
31         https://bugs.webkit.org/show_bug.cgi?id=195618
32
33         Reviewed by Lucas Forschler.
34
35         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
36         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
37         enabled in initial deployment.
38         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
39         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
40         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
41         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
42         (StatusBubble._build_bubbles_for_patch):
43
44 2019-03-12  Robin Morisset  <rmorisset@apple.com>
45
46         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
47         https://bugs.webkit.org/show_bug.cgi?id=195573
48
49         Reviewed by Simon Fraser.
50
51         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
52
53         * Scripts/dump-class-layout:
54         (main):
55         * lldb/lldb_dump_class_layout.py:
56         (ClassLayout.__init__):
57         (ClassLayout._compute_padding_recursive):
58         (LLDBDebuggerInstance.dump_layout_for_classname):
59         (LLDBDebuggerInstance):
60         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
61         (LLDBDebuggerInstance.layout_for_classname): Deleted.
62
63 2019-03-12  Chris Dumez  <cdumez@apple.com>
64
65         Device Orientation access permission should be denied unless explicitly granted by the client
66         https://bugs.webkit.org/show_bug.cgi?id=195625
67
68         Reviewed by Youenn Fablet.
69
70         add API test coverage.
71
72         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
73         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
74         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
75         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
76         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
77         (runDeviceOrientationTest):
78         (TEST):
79         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
80         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
81
82 2019-03-12  Jer Noble  <jer.noble@apple.com>
83
84         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
85         https://bugs.webkit.org/show_bug.cgi?id=195137
86         <rdar://problem/48810307>
87
88         Reviewed by Eric Carlson.
89
90         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
91         (TestWebKitAPI::TEST):
92
93 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
94
95         [ews-build] Change urls from uat to production
96         https://bugs.webkit.org/show_bug.cgi?id=195566
97
98         Reviewed by Lucas Forschler.
99
100         * BuildSlaveSupport/ews-app/ews/config.py:
101         * BuildSlaveSupport/ews-build/events.py:
102         * BuildSlaveSupport/ews-build/steps.py:
103
104 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
105
106         [ews-build] change max_builds for local-worker to 1
107         https://bugs.webkit.org/show_bug.cgi?id=195568
108
109         Reviewed by Lucas Forschler.
110
111         * BuildSlaveSupport/ews-build/loadConfig.py:
112
113 2019-03-12  Tim Horton  <timothy_horton@apple.com>
114
115         Fix the build
116
117         * TestRunnerShared/spi/PencilKitTestSPI.h:
118         * TestWebKitAPI/ios/PencilKitTestSPI.h:
119
120 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
121
122         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
123         https://bugs.webkit.org/show_bug.cgi?id=194131
124
125         Reviewed by Michael Catanzaro.
126
127         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
128         (uriChanged):
129         (testUnfinishedSubresourceLoad):
130         (serverCallback):
131         (beforeAll):
132
133 2019-03-11  Alex Christensen  <achristensen@webkit.org>
134
135         WTF::Expected should use std::addressof instead of operator&
136         https://bugs.webkit.org/show_bug.cgi?id=195604
137
138         Reviewed by Myles Maxfield.
139
140         * TestWebKitAPI/Tests/WTF/Expected.cpp:
141         (TestWebKitAPI::Unique::Unique):
142         (TestWebKitAPI::Unique::operator&):
143         (TestWebKitAPI::TEST):
144
145 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
146
147         Add Optional to Forward.h.
148         https://bugs.webkit.org/show_bug.cgi?id=195586
149
150         Reviewed by Darin Adler.
151
152         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
153         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
154         Remove unnecessary includes from headers.
155
156 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
157
158         Add testing API to hit-test and scroll overflow scrollers
159         https://bugs.webkit.org/show_bug.cgi?id=195278
160
161         Reviewed by Antti Koivisto.
162         
163         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
164         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
165         
166         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
167
168         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
169         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
170         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
171         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
172         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
173         * TestRunnerShared/UIScriptContext/UIScriptController.h:
174         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
175         (WTR::enclosingScrollViewIncludingSelf):
176         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
177
178 2019-03-11  Tim Horton  <timothy_horton@apple.com>
179
180         API test WebKit.RequestTextInputContext fails on iOS
181         https://bugs.webkit.org/show_bug.cgi?id=195585
182
183         Reviewed by Wenson Hsieh and Simon Fraser.
184
185         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
186         (applyStyle):
187         (TEST):
188         Add a viewport, so that the coordinates match up on iOS.
189         Scroll by moving the UIScrollView's contentOffset.
190
191 2019-03-11  Chris Dumez  <cdumez@apple.com>
192
193         Assert in WebPageProxy::suspendCurrentPageIfPossible()
194         https://bugs.webkit.org/show_bug.cgi?id=195506
195         <rdar://problem/48733477>
196
197         Reviewed by Alex Christensen.
198
199         Add API test coverage.
200
201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
202
203 2019-03-11  Shawn Roberts  <sroberts@apple.com>
204
205         Adding myself to contributors.json
206
207         Unreviewed, addming myself to contributors.json .
208
209         * Scripts/webkitpy/common/config/contributors.json:
210
211 2019-03-11  Alex Christensen  <achristensen@webkit.org>
212
213         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
214         https://bugs.webkit.org/show_bug.cgi?id=195511
215         <rdar://problem/44873269>
216
217         Reviewed by Darin Adler.
218
219         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
220         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
221         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
222         (TEST_F):
223
224 2019-03-11  Chris Dumez  <cdumez@apple.com>
225
226         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
227         https://bugs.webkit.org/show_bug.cgi?id=195561
228
229         Reviewed by Youenn Fablet.
230
231         Make sure the JS in the test requests for permission to receive device orientation events.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
234
235 2019-03-11  Youenn Fablet  <youenn@apple.com>
236
237         Allow storage quota increase by default in WTR
238         https://bugs.webkit.org/show_bug.cgi?id=195541
239
240         Reviewed by Geoffrey Garen.
241
242         Allow storage quota increase by default in WTR.
243         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
244         Use this for tests that explicitly need cache increase.
245
246         Instead of increasing quota by 2, make sure the next request is
247         granted by adding all given parameters.
248
249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
251         (WTR::TestRunner::setAllowStorageQuotaIncrease):
252         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
254         * WebKitTestRunner/TestController.cpp:
255         (WTR::TestController::setAllowStorageQuotaIncrease):
256         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
257         * WebKitTestRunner/TestController.h:
258         * WebKitTestRunner/TestInvocation.cpp:
259         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
260         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
261         (WTR::TestController::cocoaResetStateToConsistentValues):
262         (WTR::TestController::setAllowStorageQuotaIncrease):
263         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
264         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
265         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
266
267 2019-03-11  Xan Lopez  <xan@igalia.com>
268
269         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
270         https://bugs.webkit.org/show_bug.cgi?id=194147
271
272         Reviewed by Michael Saboff.
273
274         To make --32-bit work correctly on Linux/64bit we need to:
275
276         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
277         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
278         unfortunately CMake only allows us to do this during
279         crosscompilation, which is overkill here.
280         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
281         pkg-config detection module uses the x86 .pc files instead of the
282         x86_64 ones.
283         - Set the -m32 flags for the compiler.
284
285         * Scripts/webkitdirs.pm:
286         (generateBuildSystemFromCMakeProject):
287
288 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
289
290         Add MotionMark-1.1 plan file for run-benchmark script.
291         https://bugs.webkit.org/show_bug.cgi?id=195481
292
293         Rubber-stamped by Darin Adler.
294
295         Run-benchmark script should support MontionMark-1.1.
296
297         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
298
299 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
300
301         [ews-app] Add support for submit-to-ews url
302         https://bugs.webkit.org/show_bug.cgi?id=195477
303
304         Reviewed by Lucas Forschler.
305
306         * BuildSlaveSupport/ews-app/ews/fetcher.py:
307         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
308         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
309         * BuildSlaveSupport/ews-app/ews/urls.py:
310         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
311
312 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
313
314         Unreviewed, rolling out r242688, r242643, r242624.
315
316         Caused multiple layout test failures and crashes on iOS and macOS.
317
318         Reverted changeset:
319
320         "requestAnimationFrame should execute before the next frame"
321         https://bugs.webkit.org/show_bug.cgi?id=177484
322         https://trac.webkit.org/changeset/242624/webkit
323
324         * Tracing/SystemTracePoints.plist:
325
326 2019-03-11  John Wilander  <wilander@apple.com>
327
328         Resource Load Statistics: Make it possible exclude localhost from classification
329         https://bugs.webkit.org/show_bug.cgi?id=195474
330         <rdar://problem/47520577>
331
332         Reviewed by Brent Fulgham.
333
334         This patch allows for localhost to be excluded from classification and
335         treatment as a prevalent resource.
336
337         The WebKit Tools change adds a new function called
338         testRunner.setStatisticsIsRunningTest() which can be used to control this
339         behavior.
340
341         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
342         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
343         (WTR::TestRunner::setStatisticsIsRunningTest):
344         * WebKitTestRunner/InjectedBundle/TestRunner.h:
345         * WebKitTestRunner/TestController.cpp:
346         (WTR::TestController::setStatisticsIsRunningTest):
347         * WebKitTestRunner/TestController.h:
348         * WebKitTestRunner/TestInvocation.cpp:
349         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
350
351 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-build] Disable waterfall and console view for ews-build.webkit.org
354         https://bugs.webkit.org/show_bug.cgi?id=195560
355
356         Reviewed by Lucas Forschler.
357
358         * BuildSlaveSupport/ews-build/master.cfg:
359
360 2019-03-11  Alex Christensen  <achristensen@webkit.org>
361
362         Unreviewed, rolling out r242698.
363
364         API test crashes on bots.
365
366         Reverted changeset:
367
368         "Add a WKContentRuleList variant that uses copied memory
369         instead of mmap'd shared memory for class A containerized
370         apps"
371         https://bugs.webkit.org/show_bug.cgi?id=195511
372         https://trac.webkit.org/changeset/242698
373
374 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
375
376         [WPE] Enable web process sandbox
377         https://bugs.webkit.org/show_bug.cgi?id=195169
378
379         Reviewed by Daniel Bates.
380
381         * wpe/install-dependencies:
382         * wpe/jhbuild.modules:
383
384 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
385
386         [ews-app] Use port 17000 for worker communication
387         https://bugs.webkit.org/show_bug.cgi?id=195558
388
389         Reviewed by Lucas Forschler.
390
391         * BuildSlaveSupport/ews-build/master.cfg:
392
393 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
394
395         [ews-build] unit-tests fail when passwords.json is missing
396         https://bugs.webkit.org/show_bug.cgi?id=195557
397
398         Reviewed by Lucas Forschler.
399
400         * BuildSlaveSupport/ews-build/loadConfig.py:
401         (loadBuilderConfig):
402         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
403         (ConfigDotJSONTest.test_configuration):
404         * BuildSlaveSupport/ews-build/master.cfg:
405
406 2019-03-11  Truitt Savell  <tsavell@apple.com>
407
408         Unreviewed, rolling out r242702.
409
410         Broke High Sierra builders.
411
412         Reverted changeset:
413
414         "Add utility function to allow easy reverse range-based
415         iteration of a container"
416         https://bugs.webkit.org/show_bug.cgi?id=195542
417         https://trac.webkit.org/changeset/242702
418
419 2019-03-11  Sam Weinig  <sam@webkit.org>
420
421         Add utility function to allow easy reverse range-based iteration of a container
422         https://bugs.webkit.org/show_bug.cgi?id=195542
423
424         Reviewed by Antti Koivisto.
425
426         * TestWebKitAPI/CMakeLists.txt:
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
429         (TestWebKitAPI::TEST):
430         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
431
432 2019-03-10  Alex Christensen  <achristensen@webkit.org>
433
434         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
435         https://bugs.webkit.org/show_bug.cgi?id=195511
436         <rdar://problem/44873269>
437
438         Reviewed by Darin Adler.
439
440         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
441         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
442         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
443         (TEST_F):
444
445 2019-03-10  Tim Horton  <timothy_horton@apple.com>
446
447         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
448         https://bugs.webkit.org/show_bug.cgi?id=195499
449
450         Reviewed by Darin Adler.
451
452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
453         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
454         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
455         (-[WKWebView synchronouslyFocusTextInputContext:]):
456         (applyStyle):
457         (applyIframe):
458         (TEST):
459         Add some tests for this SPI.
460
461 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
462
463         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
464         https://bugs.webkit.org/show_bug.cgi?id=181151
465
466         Reviewed by Don Olmstead.
467
468         * TestWebKitAPI/CMakeLists.txt:
469         * TestWebKitAPI/PlatformWin.cmake:
470         Enable TestWTF RunLoop tests in all platforms.
471
472         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
473         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
474         (TestWebKitAPI::DerivedOneShotTimer::fired):
475         (TestWebKitAPI::TEST):
476         Only a few platforms support nested RunLoop.
477
478         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
479         (TestWebKitAPI::DerivedRepeatingTimer::fired):
480
481 2019-03-10  David Quesada  <david_quesada@apple.com>
482
483         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
484         https://bugs.webkit.org/show_bug.cgi?id=152480
485
486         Reviewed by Chris Dumez.
487
488         Add a unit test based on Daniel Bates's test case that starts a download, ensures
489         there are no additional references to the process pool besides the one held by
490         the download, waits for the download to finish (in the sense that the
491         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
492         measure, also check that the process pool has been deallocated at the end of the
493         test. The test wouldn't be meaningful if the process pool were still alive.
494
495         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
496         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
497         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
498             The download will be canceled because the delegate does not implement the
499             method to decide the download's destination, so this is where we know the
500             DownloadProxyMap is done with the DownloadProxy.
501         (TEST):
502
503 2019-03-08  Chris Dumez  <cdumez@apple.com>
504
505         Add support for Device Orientation / Motion permission API
506         https://bugs.webkit.org/show_bug.cgi?id=195329
507         <rdar://problem/47645367>
508
509         Reviewed by Geoffrey Garen.
510
511         Add test infrastructure to help test the Device Orientation / Motion permission API.
512
513         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
514         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
515         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
517         * WebKitTestRunner/TestController.cpp:
518         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
519         (WTR::TestController::createWebViewWithOptions):
520         (WTR::TestController::resetStateToConsistentValues):
521         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
522         * WebKitTestRunner/TestController.h:
523         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
524         * WebKitTestRunner/TestInvocation.cpp:
525         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
526
527 2019-03-08  Saam barati  <sbarati@apple.com>
528
529         Add a compare-results script to compare benchmark results
530         https://bugs.webkit.org/show_bug.cgi?id=195486
531         <rdar://problem/48723397>
532
533         Reviewed by Geoffrey Garen.
534
535         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
536         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
537         to extend it to learn about our other benchmarks.
538
539         * Scripts/compare-results: Added.
540         (readJSONFile):
541         (detectJetStream2):
542         (JetStream2Results):
543         (detectSpeedometer2):
544         (Speedometer2Results):
545         (detectPLT5):
546         (PLT5Results):
547         (detectBenchmark):
548         (biggerIsBetter):
549         (ttest):
550         (getOptions):
551         (main):
552
553 2019-03-08  Stephanie Lewis  <slewis@apple.com>
554
555         Ensure old tab state is cleared between iterations of run-benchmark
556         https://bugs.webkit.org/show_bug.cgi?id=195393
557         <rdar://problem/46885583>
558
559         Reviewed by Dewei Zhu.
560
561         a) ensure the default to restore state is not set
562         b) terminate Safari correctly
563         c) Set the system default to ignore Persistent State in Safari
564
565         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
566         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
567         (OSXBrowserDriver.prepare_env): 
568         (OSXBrowserDriver.restore_env):
569         (OSXBrowserDriver.close_browsers):
570         (OSXBrowserDriver._terminate_processes):
571         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
572         (OSXChromeDriver):
573         (OSXChromeCanaryDriver):
574         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
575         (OSXFirefoxDriver):
576         (OSXFirefoxNightlyDriver):
577         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
578         (OSXSafariDriver):
579         (OSXSafariDriver.prepare_env):
580
581 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
582
583         [GTK] Several InputMethodFilter tests are failing
584         https://bugs.webkit.org/show_bug.cgi?id=195408
585
586         Reviewed by Carlos Garcia Campos.
587
588         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
589         Regressed in r241751.
590         Hexadecimal values of keycodes are expressed now in upper letters.
591         Composited characters should be cast to UTF8 strings.
592
593         (TestWebKitAPI::TEST):
594
595 2019-03-07  Tomas Popela  <tpopela@redhat.com>
596
597         [GTK] Make Tools/gtkdoc python3 compatible
598         https://bugs.webkit.org/show_bug.cgi?id=195359
599
600         Reviewed by Carlos Garcia Campos.
601
602         * gtkdoc/generate-gtkdoc:
603         ConfigParser was reworked in Python 3.2 so we have adapt the code to
604         work with Python 2 and 3.
605         (get_gtkdoc_module_paths):
606         The iteritems() was removed in Python 3, so let's use items() that's
607         available in Python 2 and 3.
608         (get_generator_for_config):
609         * gtkdoc/gtkdoc.py:
610         (GTKDoc._run_command):
611         The sys.stdout.write() is expecting str in Python 3 and not bytes
612         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
613         for passing the bytes there.
614
615 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
616
617         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
618         https://bugs.webkit.org/show_bug.cgi?id=195346
619         <rdar://problem/48667048>
620
621         Unreviewed build fix for clang-cl.
622
623         * DumpRenderTree/win/DumpRenderTree.cpp:
624         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
625
626 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
627
628         requestAnimationFrame should execute before the next frame
629         https://bugs.webkit.org/show_bug.cgi?id=177484
630
631         Reviewed by Simon Fraser.
632
633         Add trace points for the page RenderingUpdate.
634
635         * Tracing/SystemTracePoints.plist:
636
637 2019-03-07  Zalan Bujtas  <zalan@apple.com>
638
639         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
640         https://bugs.webkit.org/show_bug.cgi?id=195353
641         <rdar://problem/48626394>
642
643         Reviewed by Simon Fraser.
644
645         * WebKitTestRunner/ios/TestControllerIOS.mm:
646         (WTR::TestController::platformResetPreferencesToConsistentValues):
647
648 2019-03-07  John Wilander  <wilander@apple.com>
649
650         Resource Load Statistics: Make it possible to purge only script-accessible cookies
651         https://bugs.webkit.org/show_bug.cgi?id=195383
652         <rdar://problem/48570136>
653
654         Reviewed by Brent Fulgham.
655
656         This patch adds test infrastructure to purge only script-accessible cookies,
657         including a new testRunner function called statisticsDeleteCookiesForHost().git a
658
659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
661         (WTR::TestRunner::statisticsDeleteCookiesForHost):
662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
663         * WebKitTestRunner/TestController.cpp:
664         (WTR::TestController::statisticsDeleteCookiesForHost):
665         * WebKitTestRunner/TestController.h:
666         * WebKitTestRunner/TestInvocation.cpp:
667         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
668
669 2019-03-07  Commit Queue  <commit-queue@webkit.org>
670
671         Unreviewed, rolling out r242354.
672         https://bugs.webkit.org/show_bug.cgi?id=195402
673
674         breaks layout tests in all configurations (Requested by
675         zdobersek on #webkit).
676
677         Reverted changeset:
678
679         "[WPE] Enable web process sandbox"
680         https://bugs.webkit.org/show_bug.cgi?id=195169
681         https://trac.webkit.org/changeset/242354
682
683 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
684
685         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
686         https://bugs.webkit.org/show_bug.cgi?id=195346
687
688         Reviewed by Fujii Hironori.
689
690         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
691         (TestWebKitAPI::TEST):
692         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
693
694         * DumpRenderTree/win/DumpRenderTree.cpp:
695         (findFontFallback):
696         (addFontFallbackIfPresent):
697         (removeFontFallbackIfPresent):
698         (main):
699         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
700         (TestWebKitAPI::Util::moduleDirectory):
701         (TestWebKitAPI::Util::createInjectedBundlePath):
702         Use wchar helpers as needed.
703
704 2019-03-06  Rob Buis  <rbuis@igalia.com>
705
706         Consider supporting the `referrerpolicy` attribute.
707         https://bugs.webkit.org/show_bug.cgi?id=179053
708
709         Reviewed by Darin Adler.
710
711         Add a runtime flag for referrerpolicy attribute.
712
713         * DumpRenderTree/mac/DumpRenderTree.mm:
714         (enableExperimentalFeatures):
715
716 2019-03-05  Daniel Bates  <dabates@apple.com>
717
718         Update expected API test result following r242379
719         (https://bugs.webkit.org/show_bug.cgi?id=195125)
720
721         Update expected x-coordinate of selection rect now that the left padding of
722         a textarea is sized in ems (so dependent on the font size) just like the left
723         padding of a text field.
724
725         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
726         (TestWebKitAPI::TEST):
727
728 2019-03-05  David Quesada  <david_quesada@apple.com>
729
730         [WK2] It should be possible to follow links with 'download' attributes
731         https://bugs.webkit.org/show_bug.cgi?id=195145
732         rdar://problem/48462642
733
734         Reviewed by Alex Christensen.
735
736         Add a unit test to verify that activating links with 'download' attributes now
737         navigates to the linked resource, rather than starts downloading it. Add another
738         to verify that it is still possible to explicitly download the link via the
739         'Download' navigation action policy.
740
741         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
742         (-[DownloadAttributeTestDelegate init]):
743         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
744         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
745         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
746         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
747         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
748         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
749         (TEST):
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::TestController::decidePolicyForNavigationAction):
752         * WebKitTestRunner/TestController.h:
753
754 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
755
756         [Curl] Implement Cookie Accept Policy.
757         https://bugs.webkit.org/show_bug.cgi?id=191645
758
759         Reviewed by Fujii Hironori.
760
761         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
762         (TestWebKitAPI::Curl::TEST_F):
763
764 2019-03-05  Youenn Fablet  <youenn@apple.com>
765
766         Rename requestCacheStorageSpace to requestStorageSpace
767         https://bugs.webkit.org/show_bug.cgi?id=195282
768
769         Reviewed by Chris Dumez.
770
771         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
772         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
773         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
774
775 2019-03-05  Brady Eidson  <beidson@apple.com>
776
777         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
778         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
779
780         Reviewed by Tim Horton.
781
782         Loading a file: URL into a WKWebView and then loading another file: url from a completely
783         different directory into that same WKWebView should work.
784
785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
786         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
787
788 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
789
790         Add WeakHashSet
791         https://bugs.webkit.org/show_bug.cgi?id=195152
792
793         Reviewed by Antti Koivisto.
794
795         Added tests for WeakHashSet.
796
797         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
798         (TestWebKitAPI::Base::Base): Moved.
799         (TestWebKitAPI::Derived::foo): Moved.
800         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
801         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
802         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
803         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
804
805 2019-03-04  Chris Dumez  <cdumez@apple.com>
806
807         Do not share WebProcesses between private and regular sessions
808         https://bugs.webkit.org/show_bug.cgi?id=195189
809         <rdar://problem/48421064>
810
811         Reviewed by Alex Christensen.
812
813         Add API test coverage.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
816         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
817
818 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
819
820         [WPE] Enable web process sandbox
821         https://bugs.webkit.org/show_bug.cgi?id=195169
822
823         Reviewed by Daniel Bates.
824
825         * wpe/install-dependencies:
826         * wpe/jhbuild.modules:
827
828 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
829
830         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
831         https://bugs.webkit.org/show_bug.cgi?id=195206
832
833         Reviewed by Žan Doberšek.
834
835         Add a new test case.
836
837         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
838         (testJSCClass):
839
840 2019-03-04  Charlie Turner  <cturner@igalia.com>
841
842         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
843         https://bugs.webkit.org/show_bug.cgi?id=194898
844
845         Reviewed by Žan Doberšek.
846
847         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
848         a GCC extension that permits arithmetic on void* pointer. Inline
849         the macro until this issue is fixed upstream.
850
851 2019-03-03  Tim Horton  <timothy_horton@apple.com>
852
853         Rid the world of WK_API_ENABLED
854         https://bugs.webkit.org/show_bug.cgi?id=195263
855
856         Reviewed by Dan Bernstein.
857
858         List of changed files elided because it's useless.
859
860 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
861
862         Unreviewed follow-up to r242292.
863
864         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
865
866         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
867         (TestWebKitAPI::testStrip): Renamed from strip.
868         (TestWebKitAPI::TEST):
869
870 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
871
872         Unreviewed, remove accidentally-committed URLHelpers.cpp test
873
874         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
875         and bug #194272 for details.
876
877         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
878
879 2019-03-03  Tim Horton  <timothy_horton@apple.com>
880
881         Remove some more unused 32-bit code
882         https://bugs.webkit.org/show_bug.cgi?id=195255
883
884         Reviewed by Darin Adler.
885
886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
887         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
888         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
889         (NPP_New):
890         (NPP_HandleEvent):
891         (handleEventCarbon): Deleted.
892
893 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
894
895         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
896
897         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
898         (TestWebKitAPI::TEST):
899
900 2019-03-01  Darin Adler  <darin@apple.com>
901
902         Finish removing String::format
903         https://bugs.webkit.org/show_bug.cgi?id=194893
904
905         Reviewed by Daniel Bates.
906 '
907         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
908
909 2019-03-01  Alex Christensen  <achristensen@webkit.org>
910
911         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
912         https://bugs.webkit.org/show_bug.cgi?id=195229
913         <rdar://problem/48520362>
914
915         Reviewed by Chris Dumez.
916
917         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
918         (TEST):
919
920 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
921
922         Add a system trace scope for event region building
923         https://bugs.webkit.org/show_bug.cgi?id=195226
924
925         Reviewed by Jon Lee.
926
927         This trace scope measures the time spend converting element rects into Region objects,
928         which can be large on some pages.
929
930         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
931
932         * Tracing/SystemTracePoints.plist:
933
934 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
935
936         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
937         https://bugs.webkit.org/show_bug.cgi?id=194612
938
939         Reviewed by Alex Christensen.
940
941         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
942         Just test the new string-processing function and don't touch the actual environment.
943         (Test cases are all as before, but based on operator== instead of strcmp.)
944
945 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
946
947         [ews-app] Update primary keys for handling multiple Buildbot instances
948         https://bugs.webkit.org/show_bug.cgi?id=195120
949
950         Reviewed by Stephanie Lewis.
951
952         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
953         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
954         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
955
956         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
957         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
958         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
959         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
960         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
961         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
962
963 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
964
965         [WinCairo] Enable service worker
966         https://bugs.webkit.org/show_bug.cgi?id=188318
967
968         Reviewed by Youenn Fablet.
969
970         * DumpRenderTree/DumpRenderTreePrefix.h:
971         * TestWebKitAPI/PlatformWin.cmake:
972         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
973         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
974         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
975
976 2019-03-01  Justin Fan  <justin_fan@apple.com>
977
978         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
979         https://bugs.webkit.org/show_bug.cgi?id=195191
980
981         Rubber-stamped by Dean Jackson.
982
983         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
984
985         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
986
987 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
988
989         Unreviewed, fix lldb webkitpy tests
990         https://bugs.webkit.org/show_bug.cgi?id=194375
991
992         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
993
994         * lldb/lldb_webkit.py:
995         (WTFStringImplProvider.is_8bit):
996
997 2019-02-28  David Quesada  <david_quesada@apple.com>
998
999         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1000         https://bugs.webkit.org/show_bug.cgi?id=195121
1001         rdar://problem/48450302
1002
1003         Reviewed by Alex Christensen.
1004
1005         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1006         configurations where the 'download' attribute is absent, blank, or populated
1007         with a filename, and where the anchor element is same-origin or cross-origin
1008         (meaning the 'download' attribute shouldn't be honored).
1009
1010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1011         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1012         (-[NavigationActionTestDelegate init]):
1013         (-[NavigationActionTestDelegate navigationAction]):
1014         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1015         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1016         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1017         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1018         (TEST):
1019
1020 2019-02-28  Antoine Quint  <graouts@apple.com>
1021
1022         Enable the Pointer Events runtime flag by default
1023         https://bugs.webkit.org/show_bug.cgi?id=195156
1024
1025         Reviewed by Dean Jackson.
1026
1027         * DumpRenderTree/mac/DumpRenderTree.mm:
1028         (enableExperimentalFeatures):
1029
1030 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1031
1032         Several PasteImage API tests are flaky
1033         https://bugs.webkit.org/show_bug.cgi?id=195160
1034
1035         Reviewed by Tim Horton.
1036
1037         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1038         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1039         listening for a "load" event after image load is already complete.
1040
1041         To address this, make these tests first register a "load" event handler, then run script to insert an image
1042         element into the document, and finally wait until the load event is observed before checking image size.
1043
1044         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1045
1046 2019-02-28  Chris Dumez  <cdumez@apple.com>
1047
1048         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1049         https://bugs.webkit.org/show_bug.cgi?id=195107
1050
1051         Reviewed by Alex Christensen.
1052
1053         Give some time for the zoom level to get restored.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1056
1057 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1058
1059         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1060         https://bugs.webkit.org/show_bug.cgi?id=194958
1061
1062         Reviewed by Geoffrey Garen.
1063
1064         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1065         (TEST):
1066
1067 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1068
1069         [ews-app] Update method to save build to handle builder_display_name
1070         https://bugs.webkit.org/show_bug.cgi?id=195047
1071
1072         Reviewed by Dewei Zhu.
1073
1074         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1075         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1076
1077 2019-02-28  Justin Fan  <justin_fan@apple.com>
1078
1079         [Web GPU] Enable Web GPU only on 64-bit
1080         https://bugs.webkit.org/show_bug.cgi?id=195139
1081
1082         Because Metal is only supported on 64 bit apps.
1083
1084         Unreviewed build fix.
1085
1086         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1087
1088 2019-02-27  Youenn Fablet  <youenn@apple.com>
1089
1090         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1091         https://bugs.webkit.org/show_bug.cgi?id=194959
1092
1093         Reviewed by Chris Dumez.
1094
1095         Spin loop until getting the condition to remove flakiness.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1098
1099 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1100
1101         [ews-build] Buildbot should include builder_display_name in the build events
1102         https://bugs.webkit.org/show_bug.cgi?id=195045
1103
1104         Reviewed by Dewei Zhu.
1105
1106         * BuildSlaveSupport/ews-build/events.py:
1107         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1108         buildername to builder_name to be consistent in naming style.
1109         (Events.buildFinished): Ditto.
1110
1111 2019-02-27  Chris Dumez  <cdumez@apple.com>
1112
1113         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1114         https://bugs.webkit.org/show_bug.cgi?id=194480
1115
1116         Reviewed by Brady Eidson.
1117
1118         Update existing API test to make it more likely to reproduce the issue.
1119
1120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1121
1122 2019-02-27  Brady Eidson  <beidson@apple.com>
1123
1124         Universal links from Google search results pages don't open the app.
1125         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1126
1127         Reviewed by Geoffrey Garen.
1128
1129         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1130         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1131         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1132         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1133
1134 2019-02-27  Chris Dumez  <cdumez@apple.com>
1135
1136         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1137         https://bugs.webkit.org/show_bug.cgi?id=195102
1138
1139         Reviewed by Geoffrey Garen.
1140
1141         If the number of processes is not yet what we expect, wait a bit and check again to give
1142         processes some time to exit.
1143
1144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1145
1146 2019-02-27  Chris Dumez  <cdumez@apple.com>
1147
1148         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1149         https://bugs.webkit.org/show_bug.cgi?id=194545
1150
1151         Reviewed by Brady Eidson.
1152
1153         Make sure the test navigates forward and then back only once. Previously, navigating
1154         back would trigger a navigation again in a timer.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1157
1158 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1159
1160         High Sierra Debug JSC test queue should use faster hardware
1161         https://bugs.webkit.org/show_bug.cgi?id=194603
1162
1163         Rubber-stamped by Alexey Proskuryakov.
1164
1165         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1166
1167         * BuildSlaveSupport/build.webkit.org-config/config.json:
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1169         (BubbleQueueServer):
1170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1171         (WebKitBuildbot):
1172         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1173         * QueueStatusServer/config/queues.py:
1174         * Scripts/webkitpy/common/config/ews.json:
1175         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1176         (test_ews_name):
1177
1178 2019-02-27  John Wilander  <wilander@apple.com>
1179
1180         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1181         https://bugs.webkit.org/show_bug.cgi?id=195071
1182         <rdar://problem/48417690>
1183
1184         Reviewed by Alex Christensen and Brent Fulgham.
1185
1186         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1187         (TestWebKitAPI::createURL):
1188             Convenience function.
1189         (TestWebKitAPI::TEST):
1190             WebCore::AdClickAttribution now takes a URL when creating Source and
1191             Destination.
1192         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1193         (TestWebKitAPI::TEST):
1194             WebCore::AdClickAttribution now takes a URL when creating Source and
1195             Destination.
1196
1197 2019-02-27  Antoine Quint  <graouts@apple.com>
1198
1199         Support Pointer Events on macOS
1200         https://bugs.webkit.org/show_bug.cgi?id=195008
1201         <rdar://problem/47454419>
1202
1203         Reviewed by Dean Jackson.
1204
1205         * DumpRenderTree/mac/DumpRenderTree.mm:
1206         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1208
1209 2019-02-26  Mark Lam  <mark.lam@apple.com>
1210
1211         Remove remaining poisoning code.
1212         https://bugs.webkit.org/show_bug.cgi?id=194138
1213
1214         Reviewed by Saam Barati.
1215
1216         * TestWebKitAPI/CMakeLists.txt:
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1219         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1220         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1221         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1222         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1223         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1224
1225 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1226
1227         Move ephemeral local storage from WebProcess to UIProcess
1228         https://bugs.webkit.org/show_bug.cgi?id=195074
1229         <rdar://problem/47937975>
1230
1231         Reviewed by Geoff Garen.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1234
1235 2019-02-20  Jer Noble  <jer.noble@apple.com>
1236
1237         [Cocoa] Media elements will restart network buffering just before suspending
1238         https://bugs.webkit.org/show_bug.cgi?id=193691
1239
1240         Reviewed by Eric Carlson.
1241
1242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1244         (TEST):
1245
1246 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1247
1248         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1249         https://bugs.webkit.org/show_bug.cgi?id=191652
1250
1251         Reviewed by Alex Christensen.
1252
1253         Fix WinCairo MiniBrowser behavior of authentication dialog.
1254
1255         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1256         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1257
1258 2019-02-26  Youenn Fablet  <youenn@apple.com>
1259
1260         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1261         https://bugs.webkit.org/show_bug.cgi?id=195028
1262         <rdar://problem/48243733>
1263
1264         Reviewed by Eric Carlson.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1267
1268 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1269
1270         [WPE] Add API for webview background color configuration
1271         https://bugs.webkit.org/show_bug.cgi?id=192305
1272
1273         Reviewed by Michael Catanzaro.
1274
1275         * MiniBrowser/wpe/main.cpp:
1276         (main): Add a new option to configure the webview background
1277         color. Example: --bg-color=transparent.
1278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1279         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1280         (beforeAll): Ditto.
1281
1282 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1283
1284         scalableNativeWebpageParameters() is not preserved on new page navigation.
1285         https://bugs.webkit.org/show_bug.cgi?id=194892
1286         <rdar://problem/47538280>
1287
1288         Reviewed by Wenson Hsieh.
1289         
1290         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1291
1292         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1293         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1294         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1295         (WTR::UIScriptController::allowsViewportShrinkToFit):
1296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1298         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1299         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1300         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1301         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1302
1303 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1304
1305         [ews-app] Add model for handling multiple Buildbot instances
1306         https://bugs.webkit.org/show_bug.cgi?id=194863
1307
1308         Reviewed by Stephanie Lewis.
1309
1310         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1311
1312 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1313
1314         [ews-app] Remove BuilderMapping table
1315         https://bugs.webkit.org/show_bug.cgi?id=194961
1316
1317         Reviewed by Stephanie Lewis.
1318
1319         Store builder name directly in build table, instead of having a separate
1320         table for it.
1321
1322         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1323         * BuildSlaveSupport/ews-app/ews/models/build.py:
1324         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1325         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1326
1327 2019-02-25  John Wilander  <wilander@apple.com>
1328
1329         Introduce and adopt new class RegistrableDomain for eTLD+1
1330         https://bugs.webkit.org/show_bug.cgi?id=194791
1331         <rdar://problem/48179240>
1332
1333         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1334
1335         This patch adds an API test and replaces two instances of
1336         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1337
1338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1339         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1340         (TestWebKitAPI::TEST):
1341             Changed two strings to make sure the registrable domains are still considered
1342             invalid and pass the test.
1343         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1344         (TestWebKitAPI::TEST):
1345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1346         (WTR::InjectedBundle::didReceiveMessageToPage):
1347
1348 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1349
1350         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1351         https://bugs.webkit.org/show_bug.cgi?id=195001
1352
1353         Reviewed by Carlos Garcia Campos.
1354
1355         API version 1.0 always includes the functionality previously guarded with
1356         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1357         unconditionally.
1358
1359         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1360         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1361         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1362         (WebViewTest::showInWindow): Ditto.
1363         (WebViewTest::hideView): Ditto.
1364         * wpe/backends/HeadlessViewBackend.cpp:
1365         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1366         * wpe/backends/ViewBackend.cpp:
1367         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1368         * wpe/backends/WindowViewBackend.cpp:
1369         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1370         WPE_BACKEND_CHECK_VERSION().
1371         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1372
1373 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1374
1375         [Flatpak] Add support for flatpak > 1.1.2
1376         https://bugs.webkit.org/show_bug.cgi?id=194088
1377
1378         Flatpak 1.2 is now out so we need to support that
1379         version now.
1380
1381         Reviewed by Michael Catanzaro.
1382
1383         * flatpak/flatpakutils.py:
1384         (check_flatpak):
1385         (FlatpakPackages.__init__):
1386         (FlatpakPackages.__detect_packages):
1387         (FlatpakPackages.__detect_packages.in):
1388         (FlatpakRepos.update):
1389
1390 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1391
1392         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1393         https://bugs.webkit.org/show_bug.cgi?id=194998
1394
1395         Reviewed by Carlos Garcia Campos.
1396
1397         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1398         to a Git checkout and using the latest commit containing various fixes
1399         and improvements.
1400
1401 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1402
1403         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1404         https://bugs.webkit.org/show_bug.cgi?id=194981
1405
1406         Reviewed by Žan Doberšek.
1407
1408         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1409         (TestWebKitAPI::TEST):
1410
1411 2019-02-23  Keith Miller  <keith_miller@apple.com>
1412
1413         Add new mac target numbers
1414         https://bugs.webkit.org/show_bug.cgi?id=194955
1415
1416         Reviewed by Tim Horton.
1417
1418         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1419         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1420         * MiniBrowser/Configurations/Base.xcconfig:
1421         * TestWebKitAPI/Configurations/Base.xcconfig:
1422         * WebKitTestRunner/Configurations/Base.xcconfig:
1423
1424 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1425
1426         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1427         https://bugs.webkit.org/show_bug.cgi?id=194846
1428
1429         Reviewed by Don Olmstead.
1430
1431         Added _search_paths() and _port_specific_expectations_files() for
1432         WinCairoPort.
1433
1434         * Scripts/webkitpy/port/win.py:
1435         (WinCairoPort.default_baseline_search_path):
1436         (WinCairoPort):
1437         (WinCairoPort._port_specific_expectations_files):
1438         (WinCairoPort._search_paths):
1439
1440 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1441
1442         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1443         https://bugs.webkit.org/show_bug.cgi?id=194963
1444
1445         Reviewed by Dean Jackson.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1448         Do a `contains` check instead of `equals`, because in debug builds we
1449         put the GraphicsLayer pointer in a prefix.
1450
1451 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1452
1453         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1454         https://bugs.webkit.org/show_bug.cgi?id=194873
1455         <rdar://problem/46701974>
1456
1457         Reviewed by Tim Horton.
1458
1459         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1460
1461         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1462         (WTR::UIScriptController::menuRect const):
1463         (WTR::UIScriptController::isShowingMenu const):
1464         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1465         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1466         (WTR::UIScriptController::menuRect const):
1467
1468         Add a function to query the bounds of the callout menu in content coordinates.
1469
1470         (WTR::UIScriptController::isShowingMenu const):
1471
1472         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1473
1474         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1475         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1476         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1477         (WTR::UIScriptController::rectForMenuAction const):
1478         (WTR::UIScriptController::menuRect const):
1479         (WTR::UIScriptController::isShowingMenu const):
1480         (WTR::findViewInHierarchyOfType): Deleted.
1481
1482 2019-02-22  Chris Dumez  <cdumez@apple.com>
1483
1484         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1485         https://bugs.webkit.org/show_bug.cgi?id=194954
1486         <rdar://problem/48127957>
1487
1488         Reviewed by Alex Christensen.
1489
1490         Add API test coverage.
1491
1492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1493         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1494         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1495         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1496
1497 2019-02-22  Chris Dumez  <cdumez@apple.com>
1498
1499         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1500         https://bugs.webkit.org/show_bug.cgi?id=194924
1501         <rdar://problem/48216125>
1502
1503         Reviewed by Geoffrey Garen.
1504
1505         Add API test coverage.
1506
1507         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1508
1509 2019-02-22  Chris Dumez  <cdumez@apple.com>
1510
1511         Unreviewed, disable API test added in r241928 on iOS.
1512
1513         The cache is not enabled on devices with less than 3GB of RAM.
1514
1515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1516
1517 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1518
1519         Hardcode Visual Viewports on everywhere except iOS WK1
1520         https://bugs.webkit.org/show_bug.cgi?id=194928
1521
1522         Reviewed by Zalan Bujtas.
1523
1524         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1525         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1526         set it to false. The setting has shipped for several years and there's no need to turn
1527         it off now.
1528
1529         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1530         Visual Viewports are not enabled.
1531         
1532         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1533         that only runs in WK2
1534
1535         * MiniBrowser/mac/SettingsController.h:
1536         * MiniBrowser/mac/SettingsController.m:
1537         (-[SettingsController init]):
1538         (-[SettingsController _populateMenu]):
1539         (-[SettingsController validateMenuItem:]):
1540         (-[SettingsController visualViewportEnabled]): Deleted.
1541         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1542         * MiniBrowser/mac/WK1BrowserWindowController.m:
1543         (-[WK1BrowserWindowController didChangeSettings]):
1544         * MiniBrowser/mac/WK2BrowserWindowController.m:
1545         (-[WK2BrowserWindowController didChangeSettings]):
1546
1547 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1548
1549         Discard cached processes when clearing website data store
1550         https://bugs.webkit.org/show_bug.cgi?id=194894
1551
1552         Reviewed by Chris Dumez.
1553
1554         Added a test case.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1557         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1558
1559 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1560
1561         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1562         https://bugs.webkit.org/show_bug.cgi?id=194914
1563         <rdar://problem/47586889>
1564
1565         Reviewed by Geoffrey Garen.
1566
1567         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1568         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1569         (TEST):
1570         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1571
1572 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1573
1574         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1575         <https://webkit.org/b/194761>
1576
1577         Reviewed by Myles Maxfield.
1578
1579         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1580         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1581         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1582         to use ARC-compliant cast.
1583         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1584         ARC-compliant cast.
1585         (WTR::installFakeHelvetica): Log `error` to console if
1586         CTFontManagerRegisterFontsForURL() fails, but only on supported
1587         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1588         Call CFRelease() on `error` to fix the leak.  Update to use
1589         ARC-compliant cast.
1590         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1591         cast.
1592
1593 2019-02-21  Chris Dumez  <cdumez@apple.com>
1594
1595         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1596         https://bugs.webkit.org/show_bug.cgi?id=194481
1597
1598         Reviewed by Alex Christensen.
1599
1600         Give the processes a chance to shutdown and wait until we reached the expected number
1601         of processes.
1602
1603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1604
1605 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1606
1607         Fix the macOS build
1608
1609         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1610
1611 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1612
1613         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1614
1615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1616         I am a backwards.
1617
1618 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1619
1620         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1621
1622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1623         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1624         We could force on UI-side compositing, but I feel like the test might be more
1625         valuable exercising the normal path on each platform (though the original
1626         bug was also UI-side specific). Though we can't validate that the overlay
1627         layer was installed successfully, there are layout tests that do that.
1628
1629 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1630
1631         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1632         https://bugs.webkit.org/show_bug.cgi?id=194845
1633         <rdar://problem/47944579>
1634
1635         Reviewed by Antti Koivisto.
1636
1637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1638         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1639
1640 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1641
1642         [LFC][Floats] Add support for placing formatting roots in-between floats.
1643         https://bugs.webkit.org/show_bug.cgi?id=194902
1644
1645         Reviewed by Antti Koivisto.
1646
1647         * LayoutReloaded/misc/LFC-passing-tests.txt:
1648
1649 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1650
1651         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1652         https://bugs.webkit.org/show_bug.cgi?id=194901
1653
1654         Unreviewed build fix.
1655
1656         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1657         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1658         WPEBackend-fdo-0.1 as library name.
1659
1660 2019-02-21  Rob Buis  <rbuis@igalia.com>
1661
1662         Update MIME type parser
1663         https://bugs.webkit.org/show_bug.cgi?id=180526
1664
1665         Reviewed by Darin Adler.
1666
1667         Add tests involving leading and trailing whitespace, non-token
1668         characters and quoted strings.
1669
1670         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1671         (TestWebKitAPI::TEST):
1672
1673 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1674
1675         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1676         https://bugs.webkit.org/show_bug.cgi?id=194884
1677
1678         Reviewed by Michael Catanzaro.
1679
1680         * PlatformWin.cmake:
1681
1682 2019-02-20  Chris Dumez  <cdumez@apple.com>
1683
1684         Add API test for <rdar://problem/47471222>
1685         https://bugs.webkit.org/show_bug.cgi?id=194847
1686
1687         Reviewed by Alex Christensen.
1688
1689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1690
1691 2019-02-20  Chris Dumez  <cdumez@apple.com>
1692
1693         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1694         https://bugs.webkit.org/show_bug.cgi?id=194872
1695         <rdar://problem/47924500>
1696
1697         Reviewed by Alex Christensen.
1698
1699         Add API test coverage.
1700
1701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1702
1703 2019-02-20  Jer Noble  <jer.noble@apple.com>
1704
1705         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1706         https://bugs.webkit.org/show_bug.cgi?id=191332
1707
1708         Reviewed by Dean Jackson.
1709
1710         * Scripts/git-is-in-range: Added.
1711
1712 2019-02-20  Andy Estes  <aestes@apple.com>
1713
1714         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1715         https://bugs.webkit.org/show_bug.cgi?id=194869
1716
1717         Rubber-stamped by Jer Noble.
1718
1719         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1720         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1721         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1722         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1725
1726 2019-02-20  Chris Dumez  <cdumez@apple.com>
1727
1728         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1729         https://bugs.webkit.org/show_bug.cgi?id=194857
1730         <rdar://problem/47759323>
1731
1732         Reviewed by Alex Christensen.
1733
1734         Add API test coverage.
1735
1736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1737
1738 2019-02-20  Chris Dumez  <cdumez@apple.com>
1739
1740         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1741         https://bugs.webkit.org/show_bug.cgi?id=194829
1742         <rdar://problem/47889906>
1743
1744         Reviewed by Alexey Proskuryakov.
1745
1746         Every time the TestOptions were changing we were creating both a new Web view and
1747         a new WKContext, which would start a new Network process. In most cases, we only
1748         need to contruct a new Web view and we do can keep reusing the same WKContext.
1749         This patch implements this optimization and thus avoids spinning a lot of new
1750         Network processes while running the layout tests.
1751
1752         * WebKitTestRunner/TestController.cpp:
1753         (WTR::TestController::generateContextConfiguration const):
1754         (WTR::TestController::generatePageConfiguration):
1755         (WTR::TestController::createWebViewWithOptions):
1756         (WTR::TestController::resetPreferencesToConsistentValues):
1757         (WTR::updateTestOptionsFromTestHeader):
1758         * WebKitTestRunner/TestController.h:
1759         * WebKitTestRunner/TestOptions.h:
1760         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1761         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1762         (WTR::TestOptions::hasSameInitializationOptions const):
1763         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1764         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1765         (WTR::TestController::platformAddTestOptions const):
1766
1767 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1768
1769         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1770         https://bugs.webkit.org/show_bug.cgi?id=167941
1771
1772         Reviewed by Carlos Garcia Campos.
1773
1774         * MiniBrowser/gtk/main.c:
1775         (filterSavedCallback): Added.
1776         (main): Support loading a JSON rule set file for content filtering.
1777         * MiniBrowser/wpe/main.cpp:
1778         (filterSavedCallback): Added.
1779         (main): Support loading a JSON rule set file for content filtering.
1780         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1781         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1782         (WTF::derefGPtr): Ditto.
1783         (testEmptyStore):
1784         (testSaveInvalidFilter):
1785         (testSaveLoadFilter):
1786         (testSavedFilterIdentifierMatch):
1787         (testRemoveFilter):
1788         (testSaveMultipleFilters):
1789         (testSaveFilterFromFile):
1790         (testFilterPersistence):
1791         (beforeAll):
1792         (afterAll):
1793         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1794         (removeOldInjectedContentAndResetLists): Also reset content filters.
1795         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1796         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1797         the element affected by the style sheet.
1798         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1799         and returns it to be used by tests.
1800         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1801         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1802         (serverCallback): Add support for serving a CSS style sheet for testing.
1803         (beforeAll): Add call to testUserContentManagerContentFilter().
1804         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1805
1806 2019-02-19  Keith Rollin  <krollin@apple.com>
1807
1808         Add timing information to build output
1809         https://bugs.webkit.org/show_bug.cgi?id=194839
1810         <rdar://problem/48219609>
1811
1812         Reviewed by Alexey Proskuryakov.
1813
1814         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1815         emit each project's build time to its output. E.g.,
1816
1817             ** BUILD SUCCEEDED ** [0.132 sec]
1818
1819         * Scripts/webkitdirs.pm:
1820         (XcodeOptions):
1821
1822 2019-02-19  Truitt Savell  <tsavell@apple.com>
1823
1824         Unreviewed, rolling out r241784.
1825
1826         Broke all OpenSource builds.
1827
1828         Reverted changeset:
1829
1830         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1831         instances view"
1832         https://bugs.webkit.org/show_bug.cgi?id=172848
1833         https://trac.webkit.org/changeset/241784
1834
1835 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1836
1837         [LFC][Floats] Remove redundant intersecting logic
1838         https://bugs.webkit.org/show_bug.cgi?id=194804
1839
1840         Reviewed by Antti Koivisto.
1841
1842         * LayoutReloaded/misc/LFC-passing-tests.txt:
1843
1844 2019-02-19  Dean Jackson  <dino@apple.com>
1845
1846         Clean-up output from generate-xcfilelists so it can be filtered
1847         https://bugs.webkit.org/show_bug.cgi?id=194795
1848
1849         Reviewed by Joseph Pecoraro (and Keith Rollin).
1850
1851         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1852         make a slight tweak to filter-build-webkit so such lines are marked
1853         as plain.
1854
1855         * Scripts/filter-build-webkit:
1856         * Scripts/generate-xcfilelists:
1857
1858 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1859
1860         pytest is not correctly auto-installed
1861         https://bugs.webkit.org/show_bug.cgi?id=194707
1862
1863         Reviewed by Carlos Garcia Campos.
1864
1865         * Scripts/webkitpy/thirdparty/__init__.py:
1866         (AutoinstallImportHook._install_pytest):
1867
1868 2019-02-18  Chris Dumez  <cdumez@apple.com>
1869
1870         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1871         https://bugs.webkit.org/show_bug.cgi?id=194797
1872         <rdar://problem/48055151>
1873
1874         Reviewed by Geoffrey Garen.
1875
1876         Add API test coverage.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1879
1880 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1881
1882         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1883         https://bugs.webkit.org/show_bug.cgi?id=194670
1884         <rdar://problem/39066529>
1885
1886         Reviewed by Tim Horton.
1887
1888         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1889         pasted in an editable area as attachment elements.
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1892         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1893         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1894         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1895         (TestWebKitAPI::TEST):
1896         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1897         (WTR::InjectedBundlePage::InjectedBundlePage):
1898
1899 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1900
1901         Fix API test after r241728
1902        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1903
1904         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1905         (TEST):
1906         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1907
1908 2019-02-18  Daniel Bates  <dabates@apple.com>
1909
1910         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1911         https://bugs.webkit.org/show_bug.cgi?id=192824
1912         <rdar://problem/47100332>
1913
1914         Reviewed by Wenson Hsieh.
1915
1916         Fix a bug where the wrong usage code was used for F13 thru F24.
1917
1918         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1919         (keyCodeForDOMFunctionKey):
1920
1921 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1922
1923         Bytecode cache should a have a boot-specific validation
1924         https://bugs.webkit.org/show_bug.cgi?id=194769
1925         <rdar://problem/48149509>
1926
1927         Reviewed by Keith Miller.
1928
1929         Add test for WTF::bootSessionUUIDString()
1930
1931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1932         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1933         (TEST):
1934
1935 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1936
1937         Disable safe browsing in WKWebView and remove its WKPreferences API
1938         https://bugs.webkit.org/show_bug.cgi?id=194723
1939         <rdar://problem/48122993>
1940
1941         Reviewed by Geoffrey Garen.
1942
1943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1944         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1945         (TEST):
1946         (safeBrowsingView):
1947         Make tests use SPI instead of API.
1948
1949 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1950
1951         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1952         https://bugs.webkit.org/show_bug.cgi?id=194586
1953
1954         Reviewed by Ross Kirsling.
1955
1956         * DumpRenderTree/win/DumpRenderTree.cpp:
1957         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1958         * Scripts/webkitpy/port/driver.py:
1959         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1960
1961 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1962
1963         Unreviewed, rolling out r241620.
1964
1965         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1966         (Requested by ddkilzer on #webkit.)
1967
1968         Reverted changeset:
1969
1970         "[WTF] Add environment variable helpers"
1971         https://bugs.webkit.org/show_bug.cgi?id=192405
1972         https://trac.webkit.org/changeset/241620
1973
1974 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1975
1976         [LFC] RenderImage's default intrinsic size is 0.
1977         https://bugs.webkit.org/show_bug.cgi?id=194745
1978
1979         Reviewed by Antti Koivisto.
1980
1981         * LayoutReloaded/misc/LFC-passing-tests.txt:
1982
1983 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1984
1985         [LFC][BFC] Add support for block replaced intrinsic width.
1986         https://bugs.webkit.org/show_bug.cgi?id=194705
1987
1988         Reviewed by Simon Fraser.
1989
1990         * LayoutReloaded/misc/LFC-passing-tests.txt:
1991
1992 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1993
1994         [LFC] Apply min/max width constraints to preferred width computation
1995         https://bugs.webkit.org/show_bug.cgi?id=194739
1996
1997         Reviewed by Simon Fraser.
1998
1999         * LayoutReloaded/misc/LFC-passing-tests.txt:
2000
2001 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2002
2003         [WTF] Add environment variable helpers
2004         https://bugs.webkit.org/show_bug.cgi?id=192405
2005
2006         Reviewed by Michael Catanzaro.
2007
2008         * DumpRenderTree/mac/DumpRenderTree.mm:
2009         (libraryPathForDumpRenderTree):
2010         * DumpRenderTree/win/DumpRenderTree.cpp:
2011         (libraryPathForDumpRenderTree):
2012         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2013         (setUpIOSLayoutTestCommunication):
2014         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2015         (beforeAll):
2016         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2017         (main):
2018         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2019         (WebKitTestBus::run):
2020         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2021         (WTR::getOutputDir):
2022         (WTR::initializeFontConfigSetting):
2023         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2024         (WTR::InjectedBundle::platformInitialize):
2025         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2026         (WTR::topLevelPath):
2027         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2028         (WTR::topLevelPath):
2029         (WTR::getOutputDir):
2030         (WTR::activateFonts):
2031         * WebKitTestRunner/TestController.cpp:
2032         (WTR::TestController::libraryPathForTesting):
2033         (WTR::TestController::generateContextConfiguration const):
2034         (WTR::TestController::generatePageConfiguration):
2035         (WTR::TestController::decideDestinationWithSuggestedFilename):
2036         (WTR::TestController::platformAdjustContext):
2037         * WebKitTestRunner/TestController.h:
2038         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2039         (WTR::TestController::cocoaPlatformInitialize):
2040         (WTR::TestController::platformAdjustContext):
2041         * WebKitTestRunner/gtk/main.cpp:
2042         (main):
2043         * WebKitTestRunner/mac/TestControllerMac.mm:
2044         (WTR::TestController::configureContentExtensionForTest):
2045         * WebKitTestRunner/wpe/main.cpp:
2046         (main):
2047         Utilize WTF::Environment where possible.
2048
2049 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2050
2051         [iOS] WKWebView callout bar is missing Change Writing Direction item
2052         https://bugs.webkit.org/show_bug.cgi?id=190015
2053         <rdar://problem/44810366>
2054
2055         Reviewed by Tim Horton.
2056
2057         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2058         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2059
2060         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2061         (TestWebKitAPI::TEST):
2062
2063 2019-02-15  Chris Dumez  <cdumez@apple.com>
2064
2065         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2066         https://bugs.webkit.org/show_bug.cgi?id=194717
2067         <rdar://problem/47884404>
2068
2069         Reviewed by Brady Eidson.
2070
2071         Add API test coverage.
2072
2073         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2074
2075 2019-02-15  Youenn Fablet  <youenn@apple.com>
2076
2077         Make navigator.mediaDevices SecureContext
2078         https://bugs.webkit.org/show_bug.cgi?id=194666
2079
2080         Reviewed by Eric Carlson.
2081
2082         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2083         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2084         (TEST_F):
2085
2086 2019-02-15  Brian Burg  <bburg@apple.com>
2087
2088         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2089         https://bugs.webkit.org/show_bug.cgi?id=194411
2090         <rdar://problem/47787614>
2091
2092         Reviewed by Joseph Pecoraro.
2093
2094         Remove unnecessary soft linking macro usage.
2095
2096         * DumpRenderTree/mac/TestRunnerMac.mm:
2097         (TestRunner::inspectorTestStubURL):
2098         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2099         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2100         (WTR::TestRunner::inspectorTestStubURL):
2101
2102 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2103
2104         Unreviewed, rolling out r241559 and r241566.
2105         https://bugs.webkit.org/show_bug.cgi?id=194710
2106
2107         Causes layout test crashes under GuardMalloc (Requested by
2108         ryanhaddad on #webkit).
2109
2110         Reverted changesets:
2111
2112         "[WTF] Add environment variable helpers"
2113         https://bugs.webkit.org/show_bug.cgi?id=192405
2114         https://trac.webkit.org/changeset/241559
2115
2116         "Unreviewed build fix for WinCairo Debug after r241559."
2117         https://trac.webkit.org/changeset/241566
2118
2119 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2120
2121         [LFC] Out-of-flow box is never a float box
2122         https://bugs.webkit.org/show_bug.cgi?id=194704
2123
2124         Reviewed by Antti Koivisto.
2125
2126         * LayoutReloaded/misc/LFC-passing-tests.txt:
2127
2128 2019-02-10  Darin Adler  <darin@apple.com>
2129
2130         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2131         https://bugs.webkit.org/show_bug.cgi?id=194487
2132
2133         Reviewed by Daniel Bates.
2134
2135         * DumpRenderTree/win/DumpRenderTree.cpp:
2136         (applicationId): Use makeString instead of String::format.
2137         (main): Ditto.
2138         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2139         (TestWebKitAPI::Util::createURLForResource): Ditto.
2140         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2141         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2142
2143         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2144         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2145         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2146         (WTR::createStringWithAttributes): Use appendLiteral.
2147         (WTR::AccessibilityUIElement::helpText const): Ditto.
2148         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2149         directly instead of using String::format.
2150         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2151         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2152
2153 2019-02-15  Truitt Savell  <tsavell@apple.com>
2154
2155         Unreviewed, rolling out r241564.
2156
2157         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2158
2159         Reverted changeset:
2160
2161         "[Mac] WebInspectorUI.framework does not need to be soft-
2162         linked anymore"
2163         https://bugs.webkit.org/show_bug.cgi?id=194411
2164         https://trac.webkit.org/changeset/241564
2165
2166 2019-02-15  Saam barati  <sbarati@apple.com>
2167
2168         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2169         https://bugs.webkit.org/show_bug.cgi?id=194036
2170
2171         Reviewed by Yusuke Suzuki.
2172
2173         * Scripts/run-jsc-stress-tests:
2174
2175 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2176
2177         Fix the build.
2178
2179         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2180         (WTR::UIScriptController::drawSquareInEditableImage):
2181         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2182         (TestWebKitAPI::drawSquareInEditableImage):
2183
2184 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2185
2186         Fix the build.
2187
2188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2189         (WTR::UIScriptController::drawSquareInEditableImage):
2190         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2191         (TestWebKitAPI::drawSquareInEditableImage):
2192
2193 2019-02-14  Brian Burg  <bburg@apple.com>
2194
2195         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2196         https://bugs.webkit.org/show_bug.cgi?id=194411
2197         <rdar://problem/47787614>
2198
2199         Reviewed by Joseph Pecoraro.
2200
2201         Remove unnecessary soft linking macro usage.
2202
2203         * DumpRenderTree/mac/TestRunnerMac.mm:
2204         (TestRunner::inspectorTestStubURL):
2205         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2206         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2207         (WTR::TestRunner::inspectorTestStubURL):
2208
2209 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2210
2211         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2212         https://bugs.webkit.org/show_bug.cgi?id=194599
2213
2214         Reviewed by Lucas Forschler.
2215
2216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2217         (StatusBubble._build_bubble):
2218
2219 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2220
2221         [ews-app] Set Foreign Key in Django build model
2222         https://bugs.webkit.org/show_bug.cgi?id=194667
2223
2224         Reviewed by Lucas Forschler.
2225
2226         * BuildSlaveSupport/ews-app/ews/models/build.py:
2227         (Build):
2228
2229 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2230
2231         [WTF] Add environment variable helpers
2232         https://bugs.webkit.org/show_bug.cgi?id=192405
2233
2234         Reviewed by Michael Catanzaro.
2235
2236         * DumpRenderTree/mac/DumpRenderTree.mm:
2237         (libraryPathForDumpRenderTree):
2238         * DumpRenderTree/win/DumpRenderTree.cpp:
2239         (libraryPathForDumpRenderTree):
2240         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2241         (setUpIOSLayoutTestCommunication):
2242         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2243         (TestWebKitAPI::strip):
2244         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2245         (beforeAll):
2246         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2247         (main):
2248         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2249         (WebKitTestBus::run):
2250         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2251         (WTR::getOutputDir):
2252         (WTR::initializeFontConfigSetting):
2253         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2254         (WTR::InjectedBundle::platformInitialize):
2255         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2256         (WTR::topLevelPath):
2257         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2258         (WTR::topLevelPath):
2259         (WTR::getOutputDir):
2260         (WTR::activateFonts):
2261         * WebKitTestRunner/TestController.cpp:
2262         (WTR::TestController::libraryPathForTesting):
2263         (WTR::TestController::generateContextConfiguration const):
2264         (WTR::TestController::generatePageConfiguration):
2265         (WTR::TestController::decideDestinationWithSuggestedFilename):
2266         (WTR::TestController::platformAdjustContext):
2267         * WebKitTestRunner/TestController.h:
2268         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2269         (WTR::TestController::cocoaPlatformInitialize):
2270         (WTR::TestController::platformAdjustContext):
2271         * WebKitTestRunner/gtk/main.cpp:
2272         (main):
2273         * WebKitTestRunner/mac/TestControllerMac.mm:
2274         (WTR::TestController::configureContentExtensionForTest):
2275         * WebKitTestRunner/wpe/main.cpp:
2276         (main):
2277         Utilize WTF::Environment where possible.
2278
2279 2019-02-14  Chris Dumez  <cdumez@apple.com>
2280
2281         [PSON] Introduce a WebContent Process cache
2282         https://bugs.webkit.org/show_bug.cgi?id=194594
2283         <rdar://problem/46793397>
2284
2285         Reviewed by Geoff Garen.
2286
2287         Update API tests to turn on the WebContent Process cache.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2290
2291 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2292
2293         Unreviewed, build fix after r241480
2294
2295         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2296         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2297         (-[DragAndDropSimulator initWithWebView:]):
2298
2299 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2300
2301         AX: ARIA Reflection was disabled in error
2302         https://bugs.webkit.org/show_bug.cgi?id=194647
2303         <rdar://problem/48068336>
2304
2305         Reviewed by Ryosuke Niwa.
2306
2307         Remove test override now that this feature should be enabled by default.
2308
2309         * WebKitTestRunner/TestController.cpp:
2310         (WTR::TestController::resetPreferencesToConsistentValues):
2311
2312 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2313
2314         Unreviewed, rolling out r241486.
2315         https://bugs.webkit.org/show_bug.cgi?id=194655
2316
2317         causing API failures in builds (Requested by ShawnRoberts on
2318         #webkit).
2319
2320         Reverted changeset:
2321
2322         "[Cocoa] Media elements will restart network buffering just
2323         before suspending"
2324         https://bugs.webkit.org/show_bug.cgi?id=193691
2325         https://trac.webkit.org/changeset/241486
2326
2327 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2328
2329         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2330         https://bugs.webkit.org/show_bug.cgi?id=194622
2331
2332         Reviewed by Antti Koivisto.
2333
2334         * LayoutReloaded/misc/LFC-passing-tests.txt:
2335
2336 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2337
2338         [LFC] Shrink-to-fit-width should be constrained by min/max width
2339         https://bugs.webkit.org/show_bug.cgi?id=194653
2340
2341         Reviewed by Antti Koivisto.
2342
2343         * LayoutReloaded/misc/LFC-passing-tests.txt:
2344
2345 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2346
2347         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2348         https://bugs.webkit.org/show_bug.cgi?id=194641
2349
2350         Reviewed by Geoffrey Garen.
2351
2352         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2353         so that the test would fail without this fix.
2354
2355         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2356         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2357
2358 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2359
2360         [ews-app] Change log level for a log statement
2361
2362         Unreviewed minor fix.
2363
2364         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2365         (Patch.save_patch):
2366
2367 2019-02-13  Jer Noble  <jer.noble@apple.com>
2368
2369         [Cocoa] Media elements will restart network buffering just before suspending
2370         https://bugs.webkit.org/show_bug.cgi?id=193691
2371
2372         Reviewed by Eric Carlson.
2373
2374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2376         (TEST):
2377
2378 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2379
2380         [ews-app] Fetch builder id to name mapping
2381         https://bugs.webkit.org/show_bug.cgi?id=194355
2382
2383         Reviewed by Lucas Forschler.
2384
2385         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2386         (Buildbot.get_builder_id_to_name_mapping):
2387         (Buildbot._get_display_name_from_builder_name):
2388
2389 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2390
2391         Further restricting webarchive loads
2392         https://bugs.webkit.org/show_bug.cgi?id=194567
2393         <rdar://problem/47610130>
2394
2395         Reviewed by Youenn Fablet.
2396
2397         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2398         navigations on drop.
2399
2400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2401         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2402         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2403         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2404         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2405         (TestWebKitAPI::TEST):
2406         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2407         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2408         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2409         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2410         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2411         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2412         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2413
2414 2019-02-13  John Wilander  <wilander@apple.com>
2415
2416         Store Ad Click Attribution requests in the network process
2417         https://bugs.webkit.org/show_bug.cgi?id=194510
2418         <rdar://problem/47650118>
2419
2420         Reviewed by Alex Christensen and Daniel Bates.
2421
2422         This patch adds two TestRunner functions:
2423         - dumpAdClickAttribution()
2424         - clearAdClickAttribution()
2425
2426         They call into the network process to dump and clear Ad Click
2427         Attribution state, respectively.
2428
2429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2431         (WTR::TestRunner::dumpAdClickAttribution):
2432         (WTR::TestRunner::clearAdClickAttribution):
2433         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2434         * WebKitTestRunner/TestController.cpp:
2435         (WTR::TestController::resetStateToConsistentValues):
2436         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2437         (WTR::adClickAttributionStringResultCallback):
2438         (WTR::TestController::dumpAdClickAttribution):
2439         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2440         (WTR::adClickAttributionVoidCallback):
2441         (WTR::TestController::clearAdClickAttribution):
2442         * WebKitTestRunner/TestController.h:
2443         * WebKitTestRunner/TestInvocation.cpp:
2444         (WTR::TestInvocation::dumpResults):
2445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2446         (WTR::TestInvocation::dumpAdClickAttribution):
2447         * WebKitTestRunner/TestInvocation.h:
2448
2449 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-app] Generate status-bubble
2452         https://bugs.webkit.org/show_bug.cgi?id=194572
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2457         (StatusBubble._build_bubble):
2458         (StatusBubble._should_show_bubble_for):
2459         (StatusBubble._build_bubbles_for_patch):
2460
2461 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2462
2463         [ews-app] Add status bubble html template
2464         https://bugs.webkit.org/show_bug.cgi?id=194571
2465
2466         Reviewed by Lucas Forschler.
2467
2468         * BuildSlaveSupport/ews-app/ews/templates: Added.
2469         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2470
2471 2019-02-12  Chris Dumez  <cdumez@apple.com>
2472
2473         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2474         https://bugs.webkit.org/show_bug.cgi?id=194568
2475         <rdar://problem/47944490>
2476
2477         Reviewed by Ryosuke Niwa.
2478
2479         Add API test coverage.
2480
2481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2482         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2483
2484 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2485
2486         webkitpy: Remove bug_dummy from parsed test expectations
2487         https://bugs.webkit.org/show_bug.cgi?id=194562
2488         <rdar://problem/47853999>
2489
2490         Reviewed by Lucas Forschler.
2491
2492         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2493         (TestExpectationParser):
2494         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2495         skipped tests.
2496         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2497
2498 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2499
2500         [ews-app] Add method to fetch patch
2501         https://bugs.webkit.org/show_bug.cgi?id=194518
2502
2503         Reviewed by Lucas Forschler.
2504
2505         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2506         (Patch.get_patch):
2507
2508 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2509
2510         [LFC] Expand tests coverage (60 new tests -> 860)
2511
2512         Unreviewed test gardening (run-singly, --child-processes=1).
2513
2514         * LayoutReloaded/misc/LFC-passing-tests.txt:
2515
2516 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2517
2518         Allow pages to trigger programmatic paste from script on iOS
2519         https://bugs.webkit.org/show_bug.cgi?id=194271
2520         <rdar://problem/47808810>
2521
2522         Reviewed by Tim Horton.
2523
2524         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2525
2526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2527         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2528         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2529         (WTR::UIScriptController::rectForMenuAction const):
2530
2531         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2532         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2533         for when the menu is shown or hidden.
2534
2535         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2536         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2537         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2538         (WTR::UIScriptController::setDidShowMenuCallback):
2539         (WTR::UIScriptController::didShowMenuCallback const):
2540         (WTR::UIScriptController::setDidHideMenuCallback):
2541         (WTR::UIScriptController::didHideMenuCallback const):
2542         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2543         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2544         (WTR::UIScriptController::rectForMenuAction const):
2545         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2546         * WebKitTestRunner/TestController.cpp:
2547         (WTR::TestController::resetPreferencesToConsistentValues):
2548         (WTR::updateTestOptionsFromTestHeader):
2549         * WebKitTestRunner/TestOptions.h:
2550
2551         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2552         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2553
2554         (WTR::TestOptions::hasSameInitializationOptions const):
2555         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2556         (WTR::UIScriptController::calendarType const):
2557         (WTR::UIScriptController::platformUndoManager const):
2558         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2559         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2560         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2561         (-[TestRunnerWKWebView dealloc]):
2562         (-[TestRunnerWKWebView _didShowMenu]):
2563         (-[TestRunnerWKWebView _didHideMenu]):
2564
2565         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2566
2567         * WebKitTestRunner/ios/TestControllerIOS.mm:
2568         (WTR::handleMenuWillHideNotification):
2569         (WTR::handleMenuDidHideNotification):
2570         (WTR::TestController::platformInitialize):
2571         (WTR::TestController::platformDestroy):
2572         (WTR::TestController::platformResetStateToConsistentValues):
2573
2574         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2575         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2576
2577         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2578         (WTR::forEachViewInHierarchy):
2579         (WTR::findViewInHierarchyOfType):
2580
2581         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2582         functions that dig through a given view's hierarchy in search of a view of a given class.
2583
2584         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2585         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2586         (WTR::UIScriptController::selectionCaretViewRect const):
2587         (WTR::UIScriptController::selectionRangeViewRects const):
2588         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2589         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2590
2591         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2592
2593         (WTR::UIScriptController::rectForMenuAction const):
2594
2595         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2596         callout bar) whose label matches the given string.
2597
2598         (WTR::UIScriptController::platformContentView const):
2599
2600         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2601         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2602         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2603
2604         (WTR::UIScriptController::platformUndoManager const): Deleted.
2605         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2606         (WTR::UIScriptController::platformContentView const):
2607         (WTR::UIScriptController::platformUndoManager const): Deleted.
2608
2609 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2610
2611         webkitpy: No option to only show unexpected failures in results.html for iPad
2612         https://bugs.webkit.org/show_bug.cgi?id=194554
2613         <rdar://problem/47922442>
2614
2615         Rubber-stamped by Aakash Jain.
2616
2617         Just because a TestExpecations file does not exist for a specific platform does not mean that
2618         TestExpecations are not being used, given that platforms inherit test expectations.
2619
2620         * Scripts/webkitpy/port/base.py:
2621         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2622         * Scripts/webkitpy/port/base_unittest.py:
2623         (PortTest.test_uses_test_expectations_file):
2624
2625 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2626
2627         Remove setDefersLoading infrastructure from WebKit2
2628         https://bugs.webkit.org/show_bug.cgi?id=194506
2629
2630         Reviewed by Brady Eidson.
2631
2632         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2634         (WTR::TestRunner::setDefersLoading): Deleted.
2635         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2636
2637 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2638
2639         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2640         https://bugs.webkit.org/show_bug.cgi?id=194522
2641         <rdar://problem/47789393>
2642
2643         Reviewed by Chris Dumez.
2644
2645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2646         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2647         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2649
2650 2019-02-12  Andy Estes  <aestes@apple.com>
2651
2652         [iOSMac] Enable Parental Controls Content Filtering
2653         https://bugs.webkit.org/show_bug.cgi?id=194521
2654         <rdar://39732376>
2655
2656         Reviewed by Tim Horton.
2657
2658         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2659
2660 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2661
2662         [LFC][IFC] Add intrinsic width support for float boxes.
2663         https://bugs.webkit.org/show_bug.cgi?id=194528
2664
2665         Reviewed by Antti Koivisto.
2666
2667         Expand tests coverage (2 new tests -> 800).
2668         (This is the correct test ordering --runs-singly --child-processes=1)
2669
2670         * LayoutReloaded/misc/LFC-passing-tests.txt:
2671
2672 2019-02-12  Rob Buis  <rbuis@igalia.com>
2673
2674         Implement serializing in MIME type parser
2675         https://bugs.webkit.org/show_bug.cgi?id=193909
2676
2677         Reviewed by Darin Adler.
2678
2679         Add various tests involving upper case, non-ASCII, control/null characters,
2680         various HTTP whitespace, single quotes and an unpaired surrogate.
2681
2682         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2683         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2684         (TestWebKitAPI::serializeIfValid):
2685         (TestWebKitAPI::TEST):
2686
2687 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2688
2689         [Cocoa] Ask platform for generic font family mappings
2690         https://bugs.webkit.org/show_bug.cgi?id=187723
2691         <rdar://problem/41892438>
2692
2693         Reviewed by Brent Fulgham.
2694
2695         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2696
2697         * DumpRenderTree/mac/DumpRenderTree.mm:
2698         (allowedFontFamilySet):
2699         * WebKitTestRunner/mac/TestControllerMac.mm:
2700         (WTR::allowedFontFamilySet):
2701
2702 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2703
2704         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2705         https://bugs.webkit.org/show_bug.cgi?id=193622
2706
2707         Reviewed by Michael Catanzaro.
2708
2709         This adds support for loading content extension rule sets from the JSON files which
2710         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2711         of WKTR for this could be removed, but that is left for a follow-up patch with
2712         cleanups.
2713
2714         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2715         * WebKitTestRunner/TestController.cpp:
2716         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2717         avoid having the null-terminator copied into the result.
2718         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2719         part of the preparations to run a test.
2720         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2721         (WTR::contentExtensionStoreCallback): Added.
2722         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2723         used for content extensions test.
2724         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2725         extensions and compiling the JSON rule set for tests involving content extensions.
2726         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2727         testing and disables content extensions.
2728         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2729         resetContentExtensions().
2730         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2731         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2732         configureContentExtensionForTest(), and userContentController().
2733
2734 2019-02-11  Daniel Bates  <dabates@apple.com>
2735
2736         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2737         https://bugs.webkit.org/show_bug.cgi?id=191446
2738         <rdar://problem/45929460>
2739
2740         Reviewed by Tim Horton.
2741
2742         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2743
2744         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2745         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2746         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2747         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2748         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2749         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2750         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2751         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2752         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2753         (WTR::arrayLength):
2754         (WTR::parseModifierArray):
2755         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2756         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2757         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2758         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2759
2760 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2761
2762         Unreviewed, rolling out r241272 and r241276.
2763         https://bugs.webkit.org/show_bug.cgi?id=194514
2764
2765         Broke the Apple Internal build and the fix requires human
2766         intervention :( (Requested by dydz on #webkit).
2767
2768         Reverted changesets:
2769
2770         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2771         https://bugs.webkit.org/show_bug.cgi?id=191446
2772         https://trac.webkit.org/changeset/241272
2773
2774         "Fix internal iOS build after r241272"
2775         https://bugs.webkit.org/show_bug.cgi?id=191446
2776         https://trac.webkit.org/changeset/241276
2777
2778 2019-02-11  Truitt Savell  <tsavell@apple.com>
2779
2780         Unreviewed, rolling out r241269.
2781
2782         Caused 5 layout tests crashes on Mac WK1
2783
2784         Reverted changeset:
2785
2786         "DumpRenderTree should report unknown options"
2787         https://bugs.webkit.org/show_bug.cgi?id=191303
2788         https://trac.webkit.org/changeset/241269
2789
2790 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2791
2792         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2793         https://bugs.webkit.org/show_bug.cgi?id=194313
2794
2795         Reviewed by Tim Horton.
2796
2797         Add a helper to determine whether the web view is presenting modal UI.
2798
2799         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2800         (WTR::UIScriptController::isPresentingModally const):
2801         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2802         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2803         (WTR::UIScriptController::isPresentingModally const):
2804         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2805         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2806         (WTR::UIScriptController::calendarType const): Deleted.
2807         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2808         (WTR::UIScriptController::isPresentingModally const):
2809         (WTR::UIScriptController::calendarType const):
2810         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2811         (WTR::UIScriptController::calendarType const):
2812
2813 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2814
2815         GCHeapInspector: Show the retained sizes in more places
2816         https://bugs.webkit.org/show_bug.cgi?id=194464
2817
2818         Reviewed by Simon Fraser.
2819
2820         * GCHeapInspector/gc-heap-inspector.html:
2821         * GCHeapInspector/script/interface.js:
2822         (HeapInspectorUtils.humanReadableSize):
2823         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2824         (HeapInspectorUtils.spanForNode.span.span):
2825         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2826         (HeapSnapshotInspector.prototype.buildRoots):
2827
2828 2019-02-11  Daniel Bates  <dabates@apple.com>
2829
2830         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2831         https://bugs.webkit.org/show_bug.cgi?id=191446
2832         <rdar://problem/45929460>
2833
2834         Reviewed by Tim Horton.
2835
2836         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2837
2838         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2839         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2840         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2841         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2842         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2843         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2844         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2845         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2846         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2847         (WTR::arrayLength):
2848         (WTR::parseModifierArray):
2849         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2850         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2851         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2852         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2853
2854 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2855
2856         DumpRenderTree should report unknown options
2857         https://bugs.webkit.org/show_bug.cgi?id=191303
2858
2859         Reviewed by Frédéric Wang.
2860
2861         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2862         to report unknown options.
2863         Added and assigned test options which are currently used in tests.
2864
2865         * DumpRenderTree/TestOptions.cpp:
2866         (TestOptions::TestOptions):
2867
2868 2019-02-11  Truitt Savell  <tsavell@apple.com>
2869
2870         Unreviewed, rolling out r241229.
2871
2872         Revision broke internal builds for watchOS.
2873
2874         Reverted changeset:
2875
2876         "[Cocoa] Ask platform for generic font family mappings"
2877         https://bugs.webkit.org/show_bug.cgi?id=187723
2878         https://trac.webkit.org/changeset/241229
2879
2880 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2881
2882         [WinCairo][MiniBrowser] Basic authentication always fails.
2883         https://bugs.webkit.org/show_bug.cgi?id=194496
2884
2885         Reviewed by Don Olmstead.
2886
2887         * MiniBrowser/win/DialogHelper.h:
2888         (Dialog::getText):
2889
2890 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2891
2892         [GStreamer] GstMappedBuffer testsuite build fails
2893         https://bugs.webkit.org/show_bug.cgi?id=194495
2894
2895         Reviewed by Carlos Garcia Campos.
2896
2897         Fix the build by explicitely adding the gstreamer1.0-audio include
2898         directories to the include path.
2899
2900         * TestWebKitAPI/PlatformGTK.cmake:
2901         * TestWebKitAPI/PlatformWPE.cmake:
2902
2903 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2904
2905         [GTK][WPE] Add enable-javascript-markup setting
2906         https://bugs.webkit.org/show_bug.cgi?id=193439
2907
2908         Reviewed by Michael Catanzaro.
2909
2910         Add test cases to check the new setting.
2911
2912         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2913         (testWebKitSettings):
2914         (testWebKitSettingsJavaScriptMarkup):
2915         (beforeAll):
2916
2917 2019-02-10  Darin Adler  <darin@apple.com>
2918
2919         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2920         https://bugs.webkit.org/show_bug.cgi?id=194485
2921
2922         Reviewed by Daniel Bates.
2923
2924         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2925
2926 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2927
2928         Add more tests for clampTo<>()
2929         https://bugs.webkit.org/show_bug.cgi?id=194462
2930
2931         Reviewed by Geoffrey Garen.
2932
2933         Darin suggested to test the very last floating point number
2934         at the boundaries when truncating to integer.
2935         I added test for max/min and max-1/min-1.
2936
2937         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2938         (TestWebKitAPI::TEST):
2939
2940 2019-02-09  Darin Adler  <darin@apple.com>
2941
2942         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2943         https://bugs.webkit.org/show_bug.cgi?id=194021
2944
2945         Reviewed by Geoffrey Garen.
2946
2947         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2948         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2949         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2950
2951 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2952
2953         [LFC][IFC] Add intrinsic width support for basic inline containers
2954         https://bugs.webkit.org/show_bug.cgi?id=194473
2955
2956         Reviewed by Antti Koivisto.
2957
2958         Expand tests coverage (11 new tests -> 798)
2959
2960         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2961
2962 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2963
2964         Fix MiniBrowser's entitlements
2965         https://bugs.webkit.org/show_bug.cgi?id=192431
2966
2967         Reviewed by Joseph Pecoraro.
2968
2969         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2970         files, making it impossible to load any extension.
2971
2972         * MiniBrowser/MiniBrowser.entitlements:
2973
2974 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2975
2976         [Cocoa] Ask platform for generic font family mappings
2977         https://bugs.webkit.org/show_bug.cgi?id=187723
2978         <rdar://problem/41892438>
2979
2980         Reviewed by Brent Fulgham.
2981
2982         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2983
2984         * DumpRenderTree/mac/DumpRenderTree.mm:
2985         (allowedFontFamilySet):
2986         * WebKitTestRunner/mac/TestControllerMac.mm:
2987         (WTR::allowedFontFamilySet):
2988
2989 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2990
2991         [GTK] Implement back/forward touchpad gesture
2992         https://bugs.webkit.org/show_bug.cgi?id=193919
2993
2994         Reviewed by Michael Catanzaro.
2995
2996         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2997         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2998
2999 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3000
3001         Add SPI to use networking daemon instead of XPC service
3002         https://bugs.webkit.org/show_bug.cgi?id=194427
3003
3004         Reviewed by Geoffrey Garen
3005
3006         * MiniBrowser/MiniBrowser.entitlements:
3007
3008 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3009
3010         [ews-build] Ensure that every builder in config.json has short name
3011         https://bugs.webkit.org/show_bug.cgi?id=194461
3012
3013         Reviewed by Lucas Forschler.
3014
3015         * BuildSlaveSupport/ews-build/loadConfig.py:
3016         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3017
3018 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3019
3020         [ews-build] Add short name to config.json
3021         https://bugs.webkit.org/show_bug.cgi?id=194456
3022
3023         Reviewed by Lucas Forschler.
3024
3025         * BuildSlaveSupport/ews-build/config.json: Added short name.
3026         * BuildSlaveSupport/ews-build/loadConfig.py:
3027         (loadBuilderConfig): Set the short name as the builder description.
3028
3029 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3030
3031         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3032         https://bugs.webkit.org/show_bug.cgi?id=194418
3033
3034         Reviewed by Lucas Forschler.
3035
3036         Do not include errors trying when finding crashlogs at the end of
3037         a run-webkit-tests run since we don't process those errors.
3038
3039         * Scripts/webkitpy/port/darwin.py:
3040         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3041         * Scripts/webkitpy/port/ios_device.py:
3042         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3043         * Scripts/webkitpy/port/watch_device.py:
3044         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3045
3046 2019-02-08  Beth Dakin  <bdakin@apple.com>
3047
3048         Add afterScreenUpdates to WKSnapshotConfiguration
3049         https://bugs.webkit.org/show_bug.cgi?id=194362
3050         -and corresponding-
3051         <rdar://problem/40655528> Please add an "after screen updates" property to 
3052         WKSnapshotConfiguration (to solve blank snapshots)
3053
3054         Reviewed by Tim Horton.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3057         (TEST):
3058
3059 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3060
3061         clampTo(): do not convert the input to double when dealing with integers
3062         https://bugs.webkit.org/show_bug.cgi?id=194263
3063         <rdar://problem/47692312>
3064
3065         Reviewed by Darin Adler.
3066
3067         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3068         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3069         (TestWebKitAPI::testClampFloatingPointToInteger):
3070         (TestWebKitAPI::testClampSameSignIntegers):
3071         (TestWebKitAPI::testClampUnsignedToSigned):
3072         (TestWebKitAPI::testClampSignedToUnsigned):
3073
3074 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3075
3076         webkitpy: Respect --dedicated-simulators flag
3077         https://bugs.webkit.org/show_bug.cgi?id=194416
3078         <rdar://problem/47894722>
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * Scripts/webkitpy/port/device_port.py:
3083         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3084         available devices can be safely ignored.
3085
3086 2019-02-07  Keith Rollin  <krollin@apple.com>
3087
3088         Remove extra copy of 100x100-red.tga
3089         https://bugs.webkit.org/show_bug.cgi?id=194371
3090         <rdar://problem/47873465>
3091
3092         Reviewed by Said Abou-Hallawa.
3093
3094         In order to help it pass its tests, Bug 194190 added a second copy of
3095         the file 100x100-red.tga. However, it turns out that this additional
3096         file wasn't actually needed, and that that sole previous copy was
3097         sufficient. At the same time, this second copy -- which was copied to
3098         the same location in the build output as the first copy -- now caused
3099         XCBuild to complain because there were two production rules for the
3100         same output file. Address this by removing the newly-added extra copy.
3101
3102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3103         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3104
3105 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3106
3107         Deprecate WKBundlePageSetDefersLoading
3108         https://bugs.webkit.org/show_bug.cgi?id=191394
3109
3110         Reviewed by Dean Jackson.
3111
3112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3113         (WTR::TestRunner::setDefersLoading):
3114
3115 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3116
3117         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3118         https://bugs.webkit.org/show_bug.cgi?id=194391
3119
3120         Reviewed by Antti Koivisto.
3121
3122         * LayoutReloaded/misc/LFC-passing-tests.txt:
3123
3124 2019-02-06  Keith Rollin  <krollin@apple.com>
3125
3126         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3127         https://bugs.webkit.org/show_bug.cgi?id=193975
3128         <rdar://problem/47643306>
3129
3130         Reviewed by Tim Horton.
3131
3132         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3133         the Info.plist file into the bundle. This step is not necessary as the
3134         implicit "bundle up all the build products into a framework" build
3135         phase does this already. Having the Copy Bundle Resources phase do
3136         this causes a conflict under XCBuild, which objects to two build
3137         phases producing the same file (Info.plist). Address this by removing
3138         Info.plist from the Copy Bundle Resources phase.
3139
3140         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3141
3142 2019-02-06  Keith Rollin  <krollin@apple.com>
3143
3144         Really enable the automatic checking and regenerations of .xcfilelists during builds
3145         https://bugs.webkit.org/show_bug.cgi?id=194357
3146         <rdar://problem/47861231>
3147
3148         Reviewed by Chris Dumez.
3149
3150         Bug 194124 was supposed to enable the automatic checking and
3151         regenerating of .xcfilelist files during the build. While related
3152         changes were included in that patch, the change to actually enable the
3153         operation somehow was omitted. This patch actually enables the
3154         operation. The check-xcfilelist.sh scripts now check
3155         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3156         from the checking.
3157
3158         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3159         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3160
3161 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3162
3163         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3164         <https://webkit.org/b/194286>
3165         <rdar://problem/47815558>
3166
3167         Reviewed by Alexey Proskuryakov.
3168
3169         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3170         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3171         WKRetainPtr<> to avoid leaking the WKDataRef.
3172
3173 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3174
3175         Unreviewed, fix a typo
3176
3177         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3178
3179 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3180
3181         [GTK][WPE] force libpsl build to use ICU in jhbuild
3182         https://bugs.webkit.org/show_bug.cgi?id=194288
3183
3184         Reviewed by Carlos Garcia Campos.
3185
3186         * gtk/jhbuild.modules:
3187         Require ICU for libpsl build in jhbuild, like done in WPE.
3188
3189 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3190
3191         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3192         https://bugs.webkit.org/show_bug.cgi?id=194209
3193
3194         Reviewed by Carlos Garcia Campos.
3195
3196         Enhance TestCookieManager to ensure this doesn't happen again.
3197
3198         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3199         (testCookieManagerPersistentStorage):
3200         (beforeAll):
3201
3202 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3203
3204         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3205         https://bugs.webkit.org/show_bug.cgi?id=194324
3206
3207         Reviewed by Andy Estes.
3208
3209         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3210         part of the name is already implicit, since this is in testing code in TestOptions.
3211
3212         * WebKitTestRunner/TestController.cpp:
3213         (WTR::TestController::generateContextConfiguration const):
3214         (WTR::updateTestOptionsFromTestHeader):
3215         * WebKitTestRunner/TestOptions.h:
3216         (WTR::TestOptions::hasSameInitializationOptions const):
3217
3218 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3219
3220         [ews-build] Allow * as platform for builders and workers
3221         https://bugs.webkit.org/show_bug.cgi?id=188533
3222
3223         Reviewed by Lucas Forschler.
3224
3225         * BuildSlaveSupport/ews-build/loadConfig.py:
3226         (checkWorkersAndBuildersForConsistency):
3227
3228 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3229
3230         [ews-build] Add few bots to config.json
3231         https://bugs.webkit.org/show_bug.cgi?id=194304
3232
3233         Reviewed by Lucas Forschler.
3234
3235         * BuildSlaveSupport/ews-build/config.json:
3236
3237 2019-02-05  Keith Rollin  <krollin@apple.com>
3238
3239         Enable the automatic checking and regenerations of .xcfilelists during builds
3240         https://bugs.webkit.org/show_bug.cgi?id=194124
3241         <rdar://problem/47721277>
3242
3243         Reviewed by Tim Horton.
3244
3245         Bug 193790 add a facility for checking -- during build time -- that
3246         any needed .xcfilelist files are up-to-date and for updating them if
3247         they are not. This facility was initially opt-in by setting
3248         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3249         the process seemed robust. Its now time to enable this facility and
3250         make it opt-out. If there is a need to disable this facility, set and
3251         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3252         running `make` or `build-webkit`, or before running Xcode from the
3253         command line.
3254
3255         Additionally, remove the step that generates a list of source files
3256         going into the UnifiedSources build step. It's only necessarily to
3257         specify Sources.txt and SourcesCocoa.txt as inputs.
3258
3259         * Scripts/generate-xcfilelists:
3260
3261 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3262
3263         [GTK][WPE] force libpsl build to use ICU in jhbuild
3264         https://bugs.webkit.org/show_bug.cgi?id=194288
3265
3266         Reviewed by Philippe Normand.
3267
3268         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3269         This can cause build failures if libidn is detected but libunistring is not available.
3270
3271         Make sure that ICU is used for runtime and builtin PSL data.
3272
3273         * gtk/jhbuild.modules:
3274         * wpe/jhbuild.modules:
3275
3276 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-app] Modified timestamp should be updated on updating data
3279         https://bugs.webkit.org/show_bug.cgi?id=194295
3280
3281         Reviewed by Lucas Forschler.
3282
3283         * BuildSlaveSupport/ews-app/ews/models/build.py:
3284         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3285         * BuildSlaveSupport/ews-app/ews/models/step.py:
3286
3287 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3288
3289         Unreviewed, rolling out r240742.
3290
3291         Causes crashes on iOS simulator.
3292
3293         Reverted changeset:
3294
3295         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3296         not focused in a content-editable element"
3297         https://bugs.webkit.org/show_bug.cgi?id=192824
3298         https://trac.webkit.org/changeset/240742
3299
3300 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3301
3302         run-webkit-tests emits message "...running None" when running tests
3303         https://bugs.webkit.org/show_bug.cgi?id=194133
3304         <rdar://problem/47724738>
3305
3306         Reviewed by Lucas Forschler.
3307
3308         * Scripts/webkitpy/xcode/device_type.py:
3309         (DeviceType.__str__): Use both version mapping tables and use just the variant
3310         name if no version name is available.
3311         * Scripts/webkitpy/xcode/device_type_unittest.py:
3312         (DeviceTypeTest):
3313         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3314         an associated named.
3315
3316 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3317
3318         [WPE] require python3-setuptools for meson build in jhbuild
3319         https://bugs.webkit.org/show_bug.cgi?id=194287
3320
3321         Reviewed by Philippe Normand.
3322
3323         python3-setuptools is needed to build meson in jhbuild.
3324         It is already required by the GTK port.
3325
3326         * wpe/install-dependencies:
3327
3328 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3329
3330         [ews-app] Add method to save BuilderMapping to database
3331         https://bugs.webkit.org/show_bug.cgi?id=194264
3332
3333         Reviewed by Lucas Forschler.
3334
3335         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3336         (BuilderMapping.__str__):
3337         (BuilderMapping):
3338         (BuilderMapping.save_mapping):
3339         (BuilderMapping.update_mapping):
3340         (BuilderMapping.get_existing_mapping):
3341         (BuilderMapping.is_valid_mapping):
3342
3343 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3344
3345         [ews-app] Add timestamp fields for BuilderMappings
3346         https://bugs.webkit.org/show_bug.cgi?id=194266
3347
3348         Reviewed by Lucas Forschler.
3349
3350         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3351         (BuilderMapping):
3352
3353 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3354
3355         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3356         https://bugs.webkit.org/show_bug.cgi?id=174816
3357
3358         Reviewed by Michael Catanzaro.
3359
3360         Add tests for webkit_uri_for_display().
3361
3362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3363         (testURIForDisplayUnaffected):
3364         (testURIForDisplayAffected):
3365         (beforeAll):
3366         (afterAll):
3367         * TestWebKitAPI/glib/CMakeLists.txt:
3368
3369 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3370
3371         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3372         https://bugs.webkit.org/show_bug.cgi?id=194158
3373         <rdar://problem/47737268>
3374
3375         Rubber-stamped by Aakash Jain.
3376
3377         * Scripts/webkitpy/port/device_port.py:
3378         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3379
3380 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3381
3382         [CG] Enable setAdditionalSupportedImageTypes for WK1
3383         https://bugs.webkit.org/show_bug.cgi?id=194190
3384
3385         Reviewed by Tim Horton.
3386
3387         Add a test similar to the one under WebKit Cocoa but make it create a
3388         WebView instead of a WKWebView.
3389
3390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3391         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3392         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3393         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3394         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3395         (TestWebKitAPI::runTest):
3396         (TestWebKitAPI::TEST):
3397
3398 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3399
3400         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3401         https://bugs.webkit.org/show_bug.cgi?id=194168
3402
3403         Reviewed by Simon Fraser.
3404
3405         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3406
3407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3408         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3409         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3410         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3411         (TEST):
3412         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3413         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3414
3415 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3416
3417         REGRESSION (r237269): webkit-patch what-broke is broken 
3418         https://bugs.webkit.org/show_bug.cgi?id=193025
3419
3420         Reviewed by Aakash Jain.
3421
3422         * Scripts/webkitpy/common/host.py:
3423         (Host.buildbot):
3424         (Host.bugzilla): Renamed to 'buildbot'.
3425
3426 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3427
3428         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3429         https://bugs.webkit.org/show_bug.cgi?id=194207
3430
3431         Reviewed by Tim Horton.
3432
3433         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3434         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3435         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3436         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3437         start and delete forwards to remove the original attachment.
3438
3439         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3440         (TestWebKitAPI::TEST):
3441
3442 2019-02-04  Youenn Fablet  <youenn@apple.com>
3443
3444         Capture state should be managed consistently when doing process swapping
3445         https://bugs.webkit.org/show_bug.cgi?id=194122
3446         <rdar://problem/47609293>
3447
3448         Reviewed by Eric Carlson.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3451         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3452         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3453         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3454         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3455         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3456         (WTR::TestRunner::isDoingMediaCapture const):
3457         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3458         * WebKitTestRunner/TestController.cpp:
3459         (WTR::TestController::isDoingMediaCapture const):
3460         * WebKitTestRunner/TestController.h:
3461         * WebKitTestRunner/TestInvocation.cpp:
3462         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3463         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3464         (WTR::TestController::isDoingMediaCapture const):
3465
3466 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3467
3468         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3469         https://bugs.webkit.org/show_bug.cgi?id=194142
3470
3471         Reviewed by Ross Kirsling.
3472
3473         There three 'separator' variables in TestController.cpp. Renamed
3474         it 'pathSeparator', and unified them.
3475
3476         * WebKitTestRunner/TestController.cpp:
3477         (WTR::TestController::generateContextConfiguration const):
3478         (WTR::createTestURL):
3479         (WTR::TestController::platformAdjustContext):
3480
3481 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3482
3483         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3484         https://bugs.webkit.org/show_bug.cgi?id=194198
3485
3486         Reviewed by Antti Koivisto.
3487
3488         No need to set the banner heights on navigation now, since Page stores them.
3489
3490         * MiniBrowser/mac/WK2BrowserWindowController.m:
3491         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3492
3493 2019-02-03  John Wilander  <wilander@apple.com>
3494
3495         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3496         https://bugs.webkit.org/show_bug.cgi?id=194104
3497         <rdar://problem/47649991>
3498
3499         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3500
3501         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3502         (TestWebKitAPI::TEST):
3503             Changed numeric types from unsigned short to uint32_t.
3504
3505 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3506
3507         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3508         <https://webkit.org/b/194178>
3509         <rdar://problem/47753473>
3510
3511         Reviewed by Alexey Proskuryakov.
3512
3513         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3514         (WTR::uninstallFakeHelvetica): Pass nullptr into
3515         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3516
3517 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3518
3519         [LFC] Initialize ICB's style with fixed width/height.
3520         https://bugs.webkit.org/show_bug.cgi?id=194188
3521
3522         Reviewed by Antti Koivisto.
3523
3524         * LayoutReloaded/misc/LFC-passing-tests.txt:
3525
3526 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3527
3528         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3529         https://bugs.webkit.org/show_bug.cgi?id=194185
3530
3531         Reviewed by Antti Koivisto.
3532
3533         * LayoutReloaded/misc/LFC-passing-tests.txt:
3534
3535 2018-12-16  Darin Adler  <darin@apple.com>
3536
3537         Convert additional String::format clients to alternative approaches
3538         https://bugs.webkit.org/show_bug.cgi?id=192746
3539
3540         Reviewed by Alexey Proskuryakov.
3541
3542         * WebKitTestRunner/TestController.cpp:
3543         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3544         as an intermediate in code that ultimately constructs a WTF::String.
3545         (WTR::userMediaOriginHash): Use makeString.
3546         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3547         (WTR::TestController::didPerformClientRedirect): Ditto.
3548         (WTR::TestController::didPerformServerRedirect): Ditto.
3549         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3550
3551 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3552
3553         [ews-build] Add unit test to verify builder keys
3554         https://bugs.webkit.org/show_bug.cgi?id=194152
3555
3556         Reviewed by Lucas Forschler.
3557
3558         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3559         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3560
3561 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3562
3563         [LFC] Expand tests coverage (12 new tests -> 787)
3564
3565         Unreviewed test gardening.
3566
3567         * LayoutReloaded/misc/LFC-passing-tests.txt:
3568
3569 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3570
3571         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3572         https://bugs.webkit.org/show_bug.cgi?id=194163
3573
3574         Reviewed by Simon Fraser.
3575
3576         775
3577
3578         * LayoutReloaded/misc/LFC-passing-tests.txt:
3579
3580 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3581
3582         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3583         https://bugs.webkit.org/show_bug.cgi?id=194140
3584         <rdar://problem/47728098>
3585
3586         Reviewed by Tim Horton.
3587
3588         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3590         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3591
3592         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3593         test to induce an IPC deadlock when presenting a modal alert during touch start.
3594
3595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3596         * WebKitTestRunner/TestController.cpp:
3597         (WTR::runJavaScriptAlert):
3598
3599         Add a client callback function for running JavaScript alerts.
3600
3601         (WTR::TestController::createOtherPage):
3602         (WTR::TestController::generateContextConfiguration const):
3603
3604         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3605         the fix in this patch.
3606
3607         (WTR::TestController::createWebViewWithOptions):
3608
3609         Plumb TestOptions to generateContextConfiguration.
3610
3611         (WTR::TestController::resetPreferencesToConsistentValues):
3612         (WTR::TestController::resetStateToConsistentValues):
3613         (WTR::updateTestOptionsFromTestHeader):
3614         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3615         (WTR::TestController::handleJavaScriptAlert):
3616         * WebKitTestRunner/TestController.h:
3617         * WebKitTestRunner/TestInvocation.cpp:
3618         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3619         * WebKitTestRunner/TestOptions.h:
3620         (WTR::TestOptions::hasSameInitializationOptions const):
3621
3622 2019-02-01  Chris Dumez  <cdumez@apple.com>
3623
3624         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3625         https://bugs.webkit.org/show_bug.cgi?id=193740
3626         <rdar://problem/47527267>
3627
3628         Reviewed by Alex Christensen.
3629
3630         Add API test coverage.
3631
3632         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3633
3634 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3635
3636         [ews-app] Add display name field to BuilderMapping model
3637         https://bugs.webkit.org/show_bug.cgi?id=194153
3638
3639         Reviewed by Lucas Forschler.
3640
3641         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3642         (BuilderMapping):
3643
3644 2019-02-01  Youenn Fablet  <youenn@apple.com>
3645
3646         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3647         https://bugs.webkit.org/show_bug.cgi?id=194155
3648
3649         Reviewed by Eric Carlson.
3650
3651         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3652         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3653         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3654
3655 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3656
3657         [LFC] Adjust replaced element's intrinsic ratio
3658         https://bugs.webkit.org/show_bug.cgi?id=194154
3659
3660         Reviewed by Antti Koivisto.
3661
3662         761
3663
3664         * LayoutReloaded/misc/LFC-passing-tests.txt:
3665
3666 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3667
3668         [WPE] Show test results in minibrowser
3669         https://bugs.webkit.org/show_bug.cgi?id=194150
3670
3671         Reviewed by Žan Doberšek.
3672
3673         * Scripts/webkitpy/port/wpe.py:
3674         (WPEPort.show_results_html_file):
3675
3676 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3677
3678         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3679         https://bugs.webkit.org/show_bug.cgi?id=194151
3680
3681         Reviewed by Žan Doberšek.
3682
3683         ALT + <- go back
3684         ALT + -> go forward
3685
3686         * MiniBrowser/wpe/main.cpp:
3687         (main):
3688
3689 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3690
3691         [LFC] Set intrinsic size on Layout::Replaced
3692         https://bugs.webkit.org/show_bug.cgi?id=194139
3693
3694         Reviewed by Antti Koivisto.
3695
3696         744
3697
3698         * LayoutReloaded/misc/LFC-passing-tests.txt:
3699
3700 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3701
3702         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3703         https://bugs.webkit.org/show_bug.cgi?id=194146
3704
3705         Reviewed by Xabier Rodriguez-Calvar.
3706
3707         It allows to open relative paths.
3708
3709         * MiniBrowser/wpe/main.cpp:
3710         (main):
3711
3712 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3713
3714         Update flakiness dashboard configuration after recent queue changes