REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate methods called on...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Don't run subsequent rounds if interrupted
4         https://bugs.webkit.org/show_bug.cgi?id=196646
5
6         Reviewed by Aakash Jain.
7
8         * Scripts/webkitpy/layout_tests/controllers/manager.py:
9         (Manager.run): Bail out if interrupted.
10
11 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
12
13         Test sessionStorage in PSON private browsing mode
14         https://bugs.webkit.org/show_bug.cgi?id=196561
15
16         Reviewed by Alex Christensen.
17
18         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
19
20 2019-04-05  Commit Queue  <commit-queue@webkit.org>
21
22         Unreviewed, rolling out r243833.
23         https://bugs.webkit.org/show_bug.cgi?id=196645
24
25         This change breaks build of WPE and GTK ports (Requested by
26         annulen on #webkit).
27
28         Reverted changeset:
29
30         "[CMake][WTF] Mirror XCode header directories"
31         https://bugs.webkit.org/show_bug.cgi?id=191662
32         https://trac.webkit.org/changeset/243833
33
34 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
35
36         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
37         https://bugs.webkit.org/show_bug.cgi?id=196635
38
39         Reviewed by Antti Koivisto.
40         
41         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
42         for a test to enable async frame scrolling via:
43             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
44         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
45         
46         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
47
48         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
49         (WTR::InjectedBundle::beginTesting):
50         * WebKitTestRunner/TestController.cpp:
51         (WTR::TestController::resetPreferencesToConsistentValues):
52
53 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
54
55         Use a correct LC_RPATH when building with ASan
56         https://bugs.webkit.org/show_bug.cgi?id=196576
57
58         Reviewed by David Kilzer.
59
60         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
61         so that ../Frameworks is checked. This is simpler and more reliable than updating
62         each SPC service xcconfig.
63
64 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
65
66         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
67         https://bugs.webkit.org/show_bug.cgi?id=196629
68
69         Reviewed by Lucas Forschler.
70
71         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
72
73 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
76         https://bugs.webkit.org/show_bug.cgi?id=196618
77
78         Reviewed by Lucas Forschler.
79
80         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
81         (StatusBubble): Added QUEUE_TRIGGERS.
82         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
83         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
84         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
85         its parent(builder).
86
87 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
88
89         [ews-app] Status-bubble steps are sometimes displayed in reverse order
90         https://bugs.webkit.org/show_bug.cgi?id=196625
91
92         Reviewed by Lucas Forschler.
93
94         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
95         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
96
97 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
98
99         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
100         https://bugs.webkit.org/show_bug.cgi?id=196630
101
102         Reviewed by Wenson Hsieh.
103
104         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
105
106 2019-04-04  Youenn Fablet  <youenn@apple.com>
107
108         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
109         https://bugs.webkit.org/show_bug.cgi?id=196543
110
111         Reviewed by Alex Christensen.
112
113         * WebKitTestRunner/TestController.cpp:
114         (WTR::TestController::generatePageConfiguration):
115
116 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
117
118         [ews-app] Status bubble should not display skipped buildbot steps
119         https://bugs.webkit.org/show_bug.cgi?id=196584
120
121         Reviewed by Lucas Forschler.
122
123         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
124
125 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
126
127         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
128         https://bugs.webkit.org/show_bug.cgi?id=196620
129
130         Reviewed by Lucas Forschler.
131
132         * BuildSlaveSupport/ews-app/ews/config.py:
133
134 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
135
136         [Win] DumpRenderTreeWatchDog.py is not checked into source
137         https://bugs.webkit.org/show_bug.cgi?id=196567
138         <rdar://problem/49525901>
139
140         Reviewed by Lucas Forschler.
141
142         This script is used on Win EWS bots to terminate hanging DRT processes.
143
144         * EWSTools/dumprendertreewatchdog.py: Added.
145
146 2019-04-04  Chris Dumez  <cdumez@apple.com>
147
148         Unreviewed, roll out r243858 which made tests time out.
149
150         Disable new API tests on Windows instead.
151
152         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
153         (TestWebKitAPI::TEST):
154
155 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
156
157         [ATK] Cleanup WebPageAccessibilityObjectAtk
158         https://bugs.webkit.org/show_bug.cgi?id=196537
159
160         Reviewed by Michael Catanzaro.
161
162         Also consider files under atk directories as exceptions for GObject conventions.
163
164         * Scripts/webkitpy/style/checkers/cpp.py:
165         (check_identifier_name_in_declaration):
166
167 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
168
169         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
170         https://bugs.webkit.org/show_bug.cgi?id=196588
171         <rdar://problem/49365787>
172
173         Unreviewed build fix for Windows port.
174
175         error C3861: 'kill': identifier not found
176
177         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
178         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
179
180 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-build] Cancel build and similar operations should have authentication
183         https://bugs.webkit.org/show_bug.cgi?id=196520
184
185         Reviewed by Dewei Zhu.
186
187         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
188         environment variables.
189
190 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
191
192         [ews-build] Do not trigger queues which are not in production yet
193         https://bugs.webkit.org/show_bug.cgi?id=196581
194
195         Reviewed by Dewei Zhu.
196
197         * BuildSlaveSupport/ews-build/config.json:
198
199 2019-04-03  Chris Dumez  <cdumez@apple.com>
200
201         Unreviewed, fix typo in the name of API test added in r243848.
202
203         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
204         (TestWebKitAPI::TEST):
205
206 2019-04-03  Chris Dumez  <cdumez@apple.com>
207
208         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
209         https://bugs.webkit.org/show_bug.cgi?id=196588
210         <rdar://problem/49365787>
211
212         Reviewed by Ryosuke Niwa.
213
214         Add API test coverage.
215
216         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
217         (TestWebKitAPI::nullJavaScriptCallback):
218         (TestWebKitAPI::didCrashCheckFrames):
219         (TestWebKitAPI::TEST):
220
221 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
222
223         run-webkit-tests: Upload test results (new results database)
224         https://bugs.webkit.org/show_bug.cgi?id=196577
225         <rdar://problem/34841155>
226
227         Reviewed by Lucas Forschler.
228
229         * Scripts/webkitpy/layout_tests/controllers/manager.py:
230         (Manager.run): Upload results after each device shard, since the configuration will be
231         different for each device.
232         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
233         uploaded to a results database.
234         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
235         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
236
237 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
238
239         -apple-trailing-word is needed for browser detection
240         https://bugs.webkit.org/show_bug.cgi?id=196575
241
242         Unreviewed.
243
244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
245
246 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
247
248         [CMake][WTF] Mirror XCode header directories
249         https://bugs.webkit.org/show_bug.cgi?id=191662
250
251         Reviewed by Konstantin Tokarev.
252
253         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
254         builds.
255
256         * CMakeLists.txt:
257         * DumpRenderTree/CMakeLists.txt:
258         * DumpRenderTree/PlatformWin.cmake:
259         * MiniBrowser/win/CMakeLists.txt:
260         * TestWebKitAPI/CMakeLists.txt:
261         * TestWebKitAPI/PlatformWin.cmake:
262         * WebKitTestRunner/PlatformGTK.cmake:
263         * WebKitTestRunner/PlatformWin.cmake:
264
265 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
266
267         [ews-app] Status bubble should not display certain infrastructure status messages
268         https://bugs.webkit.org/show_bug.cgi?id=196550
269
270         Reviewed by Lucas Forschler.
271
272         Do not display the steps which are un-needed for end-user. This information is still avaiable
273         if the user click on the bubble and look at the Buildbot build.
274         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
275         (StatusBubble._steps_messages):
276         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
277
278 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
279
280         [ews-build] Use https for sending data to ews-app
281         https://bugs.webkit.org/show_bug.cgi?id=196492
282
283         Reviewed by Lucas Forschler.
284
285         * BuildSlaveSupport/ews-build/events.py:
286
287 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
288
289         Remove support for -apple-trailing-word
290         https://bugs.webkit.org/show_bug.cgi?id=196525
291
292         Reviewed by Zalan Bujtas.
293
294         This CSS property is nonstandard and not used.
295
296         * Scripts/webkitperl/FeatureList.pm:
297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
298
299 2019-04-03  Youenn Fablet  <youenn@apple.com>
300
301         Add a test for DOMCache on multiple browsing in case of private browsing
302         https://bugs.webkit.org/show_bug.cgi?id=196524
303
304         Reviewed by Alex Christensen.
305
306         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
307         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
308
309 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
310
311         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
312         https://bugs.webkit.org/show_bug.cgi?id=196540
313
314         Reviewed by Aakash Jain.
315
316         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
317
318 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
319
320         Add plumbing for a compatibility mode preference in WebKit
321         https://bugs.webkit.org/show_bug.cgi?id=196005
322
323         Reviewed by Tim Horton.
324
325         Add new API tests.
326
327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
328         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
329
330 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
331
332         [WPE][GTK] Update libsrtp dependency package for Debian
333         https://bugs.webkit.org/show_bug.cgi?id=196528
334
335         Reviewed by Frédéric Wang.
336
337         * gtk/install-dependencies:
338         * wpe/install-dependencies:
339
340 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
341
342         [WK2] Add support for Window's beforeprint / afterprint events
343         https://bugs.webkit.org/show_bug.cgi?id=196478
344         <rdar://problem/49535124>
345
346         Unreviewed build fix for MSVC.
347
348         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
349
350         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
351
352         * WebKitTestRunner/TestController.cpp:
353         (WTR::printFrame): Use int and float literals.
354
355 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
356
357         [ews-build] Reassign bots to queues
358
359         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
360
361 2019-04-02  Chris Dumez  <cdumez@apple.com>
362
363         [WK2] Add support for Window's beforeprint / afterprint events
364         https://bugs.webkit.org/show_bug.cgi?id=196478
365
366         Reviewed by Alex Christensen.
367
368         Add minimal implementation for printFrame in WebKitTestRunner.
369
370         * WebKitTestRunner/TestController.cpp:
371         (WTR::printFrame):
372         (WTR::TestController::createOtherPage):
373         (WTR::TestController::createWebViewWithOptions):
374
375 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
378         https://bugs.webkit.org/show_bug.cgi?id=196491
379
380         Reviewed by Lucas Forschler.
381
382         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
383
384 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
385
386         [ews-build] Configure buildbot try credentials in environment variables
387         https://bugs.webkit.org/show_bug.cgi?id=196501
388
389         Reviewed by Lucas Forschler.
390
391         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
392         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
393         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
394
395 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
396
397         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
398         https://bugs.webkit.org/show_bug.cgi?id=196496
399         <rdar://problem/49521634>
400
401         Reviewed by Chris Dumez.
402
403         Add new API tests (see WebKit ChangeLog for more detail).
404
405         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
406         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
407         (TEST):
408
409 2019-04-02  David Kilzer  <ddkilzer@apple.com>
410
411         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
412         <https://webkit.org/b/196499>
413
414         Reviewed by Alexey Proskuryakov.
415
416         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
417         ENABLE_ADDRESS_SANITIZER.
418
419 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
420
421         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
422         https://bugs.webkit.org/show_bug.cgi?id=182757
423
424         Reviewed by Don Olmstead.
425
426         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
427         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
428
429 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
430
431         run-api-tests: Upload test results
432         https://bugs.webkit.org/show_bug.cgi?id=196323
433         <rdar://problem/49356714>
434
435         Reviewed by Lucas Forschler.
436
437         * Scripts/webkitpy/api_tests/manager.py:
438         (Manager):
439         (Manager.run): Upload results to a results database.
440         * Scripts/webkitpy/api_tests/run_api_tests.py:
441         (parse_args): Add upload arguments.
442         * Scripts/webkitpy/port/base.py:
443         (Port):
444         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
445         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
446         with commits from any other associated repositories.
447         * Scripts/webkitpy/port/device.py:
448         (Device):
449         (Device.build_version): Access build_versoin of underlying platform device.
450         * Scripts/webkitpy/port/ios_simulator_unittest.py:
451         (IOSSimulatorTest):
452         (IOSSimulatorTest.test_configuration_for_upload):
453         * Scripts/webkitpy/port/device_port.py:
454         (DevicePort):
455         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
456         the same as the machine uploading results.
457         * Scripts/webkitpy/port/mac.py:
458         (MacPort):
459         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
460         * Scripts/webkitpy/port/mac_unittest.py:
461         (MacTest):
462         (MacTest.test_configuration_for_upload):
463         * Scripts/webkitpy/xcode/simulated_device.py:
464         (SimulatedDeviceManager._create_device_with_runtime):
465         (SimulatedDevice.__init__): Create simulated device with a build_version.
466         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
467         (test_existing_simulator):
468
469 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
470
471         Remove extra newline characters (Follow-up fix to r243707)
472
473         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
474
475 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-app] Use API_KEY to accept results data
478         https://bugs.webkit.org/show_bug.cgi?id=196461
479
480         Reviewed by Dewei Zhu.
481
482         * BuildSlaveSupport/ews-app/ews/views/results.py:
483         (Results.post): Validate EWS_API_KEY before accepting any data.
484         * BuildSlaveSupport/ews-build/events.py:
485         (Events.sendData): Send EWS_API_KEY if available along with event data.
486
487 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
488
489         Unable to copy and paste a PDF from Notes into Mail compose body
490         https://bugs.webkit.org/show_bug.cgi?id=196442
491         <rdar://problem/48573098>
492
493         Reviewed by Tim Horton.
494
495         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
496         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
497         to be specified on the item providers.
498
499         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
500         (TestWebKitAPI::mapItemForTesting):
501         (TestWebKitAPI::contactItemForTesting):
502
503 2019-04-01  Tim Horton  <timothy_horton@apple.com>
504
505         Make UIWKDocumentContext rects per-character instead of per-word
506         https://bugs.webkit.org/show_bug.cgi?id=196459
507
508         Reviewed by Wenson Hsieh.
509
510         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
511         (TEST):
512         Adjust test results due to switching to per-character rects.
513
514 2019-04-01  Chris Dumez  <cdumez@apple.com>
515
516         UIProcess crash when a prewarmed process is terminated
517         https://bugs.webkit.org/show_bug.cgi?id=196451
518         <rdar://problem/49245471>
519
520         Reviewed by Geoffrey Garen.
521
522         Add API test coverage.
523
524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
525         (TEST):
526
527 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
528
529         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
530         https://bugs.webkit.org/show_bug.cgi?id=196449
531
532         Reviewed by Lucas Forschler.
533
534         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
535         (StatusBubble.get_os_details): Method to get OS and Xcode details.
536         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
537         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
538
539 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
540
541         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
542         https://bugs.webkit.org/show_bug.cgi?id=196444
543
544         Reviewed by Lucas Forschler.
545
546         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
547
548 2019-04-01  Alex Christensen  <achristensen@webkit.org>
549
550         Add SPI to canonicalize NSURLs with WTF::URL
551         https://bugs.webkit.org/show_bug.cgi?id=196415
552         <rdar://problem/44980271>
553
554         Reviewed by Darin Adler.
555
556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
557         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
558         (TestWebKitAPI::TEST):
559
560 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
561
562         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
563         https://bugs.webkit.org/show_bug.cgi?id=196441
564
565         Reviewed by Carlos Garcia Campos.
566
567         Don't cache the wpe_view_backend object that might not exist yet at the
568         time of EventSenderProxy constructor invocation, but instead retrieve
569         that object whenever it's required for event dispatching. This should
570         avoid crashes in this constructor now that it's invoked before any
571         PlatformWindow has been set up (as changed in r243496).
572
573         * WebKitTestRunner/EventSenderProxy.h:
574         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
575         (WTR::viewBackend):
576         (WTR::EventSenderProxy::EventSenderProxy):
577         (WTR::EventSenderProxy::mouseDown):
578         (WTR::EventSenderProxy::mouseUp):
579         (WTR::EventSenderProxy::mouseMoveTo):
580         (WTR::EventSenderProxy::mouseScrollBy):
581         (WTR::EventSenderProxy::keyDown):
582         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
583
584 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
585
586         [Win][WebKit] MiniBrowser should support high DPI display
587         https://bugs.webkit.org/show_bug.cgi?id=196391
588
589         Reviewed by Alex Christensen.
590
591         * MiniBrowser/win/WebKitBrowserWindow.cpp:
592         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
593         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
594         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
595
596 2019-03-31  Sam Weinig  <weinig@apple.com>
597
598         Remove more i386 specific configurations
599         https://bugs.webkit.org/show_bug.cgi?id=196430
600
601         Reviewed by Alexey Proskuryakov.
602
603         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
604         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
605
606 2019-03-31  Andy Estes  <aestes@apple.com>
607
608         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
609         https://bugs.webkit.org/show_bug.cgi?id=196433
610         <rdar://problem/49293305>
611
612         Reviewed by Tim Horton.
613
614         Enhanced API test coverage to include all navigation response policy decisions in both
615         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
616
617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
618         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
619         (TestWebKitAPI::TEST):
620         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
621         (readFile):
622         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
623         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
624         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
625         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
626         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
627         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
628         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
629         (-[QuickLookDelegate _downloadDidStart:]):
630         (-[QuickLookDelegate _download:didReceiveResponse:]):
631         (-[QuickLookDelegate _download:didReceiveData:]):
632         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
633         (-[QuickLookDelegate _downloadDidFinish:]):
634         (-[QuickLookDelegate _download:didFailWithError:]):
635         (-[QuickLookDelegate _downloadDidCancel:]):
636         (-[QuickLookDelegate verifyDownload]):
637         (runTest):
638         (runTestDecideBeforeLoading):
639         (runTestDecideAfterLoading):
640         (TEST):
641         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
642         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
643         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
644         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
645         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
646         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
647         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
648         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
649         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
650         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
651         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
652         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
653         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
654         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
655
656 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
657
658         [CMake] add testdfg as target with build-jsc
659         https://bugs.webkit.org/show_bug.cgi?id=196393
660
661         Reviewed by Saam Barati.
662
663         Added testdfg as one of the targets to build when
664         using CMake.
665
666         * Scripts/build-jsc:
667
668 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
669
670         Delete WebMetal implementation in favor of WebGPU
671         https://bugs.webkit.org/show_bug.cgi?id=195418
672
673         Reviewed by Dean Jackson.
674
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         (enableExperimentalFeatures):
677         (resetWebPreferencesToConsistentValues):
678         * Scripts/webkitperl/FeatureList.pm:
679         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
681         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
682         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
683         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
684         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
685         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
686         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
687         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
688         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
689         (WTR::InjectedBundle::beginTesting):
690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
691         (WTR::TestRunner::setWebMetalEnabled): Deleted.
692         * WebKitTestRunner/InjectedBundle/TestRunner.h:
693
694 2019-03-29  Chris Dumez  <cdumez@apple.com>
695
696         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
697         https://bugs.webkit.org/show_bug.cgi?id=196405
698         <rdar://problem/49428130>
699
700         Reviewed by Wenson Hsieh.
701
702         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
703         the popover presentation methods to be no-ops. Use this in the new test added in
704         r243523 so that we do not swizzle those methods for all tests. This is needed because
705         those WatchOS tests rely on the popover getting presented and interactive.
706
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::updateTestOptionsFromTestHeader):
709         * WebKitTestRunner/TestController.h:
710         * WebKitTestRunner/TestOptions.h:
711         (WTR::TestOptions::hasSameInitializationOptions const):
712         * WebKitTestRunner/ios/TestControllerIOS.mm:
713         (WTR::TestController::platformInitialize):
714         (WTR::TestController::platformResetStateToConsistentValues):
715
716 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
717
718         [Curl] Add Server Trust Evaluation Support.
719         https://bugs.webkit.org/show_bug.cgi?id=191646
720
721         Reviewed by Fujii Hironori.
722
723         Implemented MiniBrowser UI for asking if user trusts the server.
724
725         * MiniBrowser/win/Common.cpp:
726         (askServerTrustEvaluation):
727         (replaceString):
728         * MiniBrowser/win/Common.h:
729         * MiniBrowser/win/MiniBrowserLib.rc:
730         * MiniBrowser/win/MiniBrowserLibResource.h:
731         * MiniBrowser/win/WebKitBrowserWindow.cpp:
732         (createPEMString):
733         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
734         (WebKitBrowserWindow::canTrustServerCertificate):
735         * MiniBrowser/win/WebKitBrowserWindow.h:
736
737 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
738
739         Implement ResizeObserver.
740         https://bugs.webkit.org/show_bug.cgi?id=157743
741
742         Reviewed by Simon Fraser.
743
744         Support resizeObserverEnabled webPreferences.
745
746         * DumpRenderTree/TestOptions.cpp:
747         (TestOptions::TestOptions):
748         * DumpRenderTree/TestOptions.h:
749         * DumpRenderTree/mac/DumpRenderTree.mm:
750         (setWebPreferencesForTestOptions):
751         * DumpRenderTree/win/DumpRenderTree.cpp:
752         (enableExperimentalFeatures):
753         * Scripts/webkitperl/FeatureList.pm:
754         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
755
756 2019-03-28  John Wilander  <wilander@apple.com>
757
758         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
759         https://bugs.webkit.org/show_bug.cgi?id=196281
760         <rdar://problem/48938748>
761
762         Reviewed by Alex Christensen.
763
764         This patch adds the function isStatisticsHasLocalStorage() to the
765         TestRunner. With it, the page can query the WebsiteDataStore in the
766         UI process to make sure that it sees LocalStorage.
767
768         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
769         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
770         (WTR::TestRunner::isStatisticsHasLocalStorage):
771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
772         * WebKitTestRunner/TestController.cpp:
773         (WTR::TestController::isStatisticsHasLocalStorage):
774         * WebKitTestRunner/TestController.h:
775         * WebKitTestRunner/TestInvocation.cpp:
776         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
777
778 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
779
780         API::Data::createWithoutCopying should do a null check before calling CFRelease
781         https://bugs.webkit.org/show_bug.cgi?id=196276
782         <rdar://problem/48059859>
783
784         Reviewed by Alex Christensen.
785
786         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
787
788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
789         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
790         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
791         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
792         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
793         (TestWebKitAPI::TEST):
794
795 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
796
797         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
798         https://bugs.webkit.org/show_bug.cgi?id=186276
799
800         Reviewed by Carlos Garcia Campos.
801
802         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
803         (webViewLoadChanged):
804         (testWebResourceGetDataError):
805         (testWebResourceGetDataEmpty):
806         (beforeAll):
807         (webViewloadChanged): Deleted.
808
809 2019-03-27  Andy Estes  <aestes@apple.com>
810
811         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
812         https://bugs.webkit.org/show_bug.cgi?id=196317
813
814         Reviewed by Dan Bernstein.
815
816         package-root copies built products into a staging directory using ditto(1), which does not
817         follow symbolic links as it traverses a directory. Now that the files in
818         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
819         itself, these become broken links when ditto'd into the staging directory.
820
821         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
822
823         * Scripts/package-root:
824
825 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
826
827         [ews-app] Update display text of Submit for ews analysis
828         https://bugs.webkit.org/show_bug.cgi?id=196309
829
830         Reviewed by Dewei Zhu.
831
832         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
833
834 2019-03-27  David Kilzer  <ddkilzer@apple.com>
835
836         run-webkit-tests should check for leaks in WebKit processes
837         <https://webkit.org/b/193772>
838         <rdar://problem/46526680>
839
840         Reviewed by Ryosuke Niwa.
841
842         This works by doing the following:
843         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
844           The list of child processes are returned one per line:
845           process.name: pid
846         - Run the "#LIST CHILD PROCESSES" command just before the
847           "#CHECK FOR WORLD LEAKS" command, and store the list of child
848           processes on the ServerProcess object.
849         - When the `--leaks` switch is handled, run check_for_leaks() on
850           each child process after the main test harness.
851
852         * DumpRenderTree/mac/DumpRenderTree.mm:
853         (handleControlCommand):
854         - Use strncmp() instead of strcmp().
855         - Add support for handling "#LIST CHILD PROCESSES" command.
856
857         * Scripts/webkitpy/port/base.py:
858         (Port.check_for_leaks):
859         * Scripts/webkitpy/port/darwin.py:
860         (DarwinPort.check_for_leaks):
861         - Rename redundant 'process_pid' argument to 'process_id'.
862
863         * Scripts/webkitpy/port/driver.py:
864         (Driver.do_post_tests_work):
865         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
866           longer the only command this sends to WebKitTestRunner.
867         - If the `--leaks` switch is present, send the
868           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
869           result using Port.set_webkit_processes().
870         (Driver._parse_child_processes_output):
871         - Add helper method to parse list of child process names and
872           process IDs returned from WebKitTestRunner.
873
874         * Scripts/webkitpy/port/ios_device.py:
875         (IOSDevicePort.check_for_leaks):
876         - Rename redundant 'process_pid' argument to 'process_id'.
877
878         * Scripts/webkitpy/port/leakdetector.py:
879         (LeakDetector._parse_leaks_output):
880         - Return early if there is no leaks_output.
881         (LeakDetector.check_for_leaks):
882         - Rename redundant 'process_pid' argument to 'process_id'.
883
884         * Scripts/webkitpy/port/server_process.py:
885         (ServerProcess.__init__):
886         (ServerProcess.child_processes):
887         (ServerProcess.set_child_processes):
888         - Add instance variable to Port to store list of child process
889           names and process IDs returned from WebKitTestRunner.
890         (ServerProcess._start):
891         - Clear self._child_processes.
892         (ServerProcess.stop):
893         - If self._child_processes is set, call
894           self._port.check_for_leaks() for each child process.
895
896         * Scripts/webkitpy/port/server_process_unittest.py:
897         (TrivialMockPort.check_for_leaks):
898         - Rename redundant 'process_pid' argument to 'process_id'.
899
900         * Scripts/webkitpy/port/simulator_process.py:
901         (SimulatorProcess.stop):
902         - If self._child_processes is set, call
903           self._port.check_for_leaks() for each child process.
904
905         * Scripts/webkitpy/port/watch_device.py:
906         (WatchDevicePort.check_for_leaks):
907         - Rename redundant 'process_pid' argument to 'process_id'.
908
909         * WebKitTestRunner/TestController.cpp:
910         (WTR::TestController::dumpResponse):
911         - Extract method from findAndDumpWorldLeaks() so that it may be
912           reused by findAndDumpWebKitProcessIdentifiers().
913         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
914         - Add method to output process name and process ID of both the
915           WebContent and Networking processes.
916         (WTR::TestController::findAndDumpWorldLeaks):
917         - Fix missing newline in output when there were no abandoned
918           documents.
919         - Call dumpResponse() for extracted code.
920         (WTR::TestController::handleControlCommand):
921         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
922         - Use strncmp() instead of strcmp().
923         - Call findAndDumpWebKitProcessIdentifiers() when
924           "#LIST CHILD PROCESSES" command is sent.
925         * WebKitTestRunner/TestController.h:
926         (WTR::TestController::dumpResponse):
927         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
928         - Declare methods.
929
930 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
931
932         Unreviewed. Add GLib API test cases after r243434.
933
934         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
935         (testWebViewActiveURI):
936         (serverCallback):
937         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
938         (sendRequestCallback):
939
940 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
941
942         Geolocation request not complete when watch request was started in a different web process
943         https://bugs.webkit.org/show_bug.cgi?id=195996
944
945         Reviewed by Alex Christensen.
946
947         Add a test case.
948
949         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
950         (TestWebKitAPI::runJavaScriptAlert):
951         (TestWebKitAPI::TEST):
952
953 2019-03-26  Keith Rollin  <krollin@apple.com>
954
955         Update the way generate-xcfilelists returns strings from functions
956         https://bugs.webkit.org/show_bug.cgi?id=195975
957         <rdar://problem/49040807>
958
959         Reviewed by Dean Jackson.
960
961         There are places where generate-xcfilelists executes assignments with
962         statements like:
963
964             FOO=$(some_function)
965
966         where "some_function" return a string by echoing it. E.g.
967
968             some_function()
969             {
970                 echo "Hello, World"
971             }
972
973         This is a common idiom, but it has a problem if "some_function" needs
974         to call "exit" in an attempt to halt the entire script right then and
975         there. Since "some_function" is called inside of $(), it's being
976         executed in a sub-shell. Calling exit in that sub-shell simply exits
977         that shell; it doesn't not exit the outer shell in which the main part
978         of the script is still running. As such, the main script keeps
979         executing when the intent was for the script to halt.
980
981         The solution to this is to use a different idiom for returning
982         strings. The one we now is to pass in the name of the variable to
983         receive the string result:
984
985             some_function()
986             {
987                 variable_name=$1
988                 eval $variable_name ="Hello, World"
989             }
990
991         The call site now looks like
992
993             some_function FOO
994
995         Because there's no invocation of a sub-shell, some_function can now
996         call "exit" if it wants to, and the entire script will exit at that
997         point.
998
999         * Scripts/generate-xcfilelists:
1000
1001 2019-03-26  Chris Dumez  <cdumez@apple.com>
1002
1003         Add basic layout test coverage for File Picker on iOS
1004         https://bugs.webkit.org/show_bug.cgi?id=196265
1005
1006         Reviewed by Wenson Hsieh.
1007
1008         Add layout test infrastructure to test the file picker on iOS.
1009
1010         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1011         (WTR::UIScriptController::dismissFilePicker):
1012         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1013         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1014         (WTR::UIScriptController::dismissFilePicker):
1015         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::TestController::createWebViewWithOptions):
1018         (WTR::updateTestOptionsFromTestHeader):
1019         * WebKitTestRunner/TestOptions.h:
1020         (WTR::TestOptions::hasSameInitializationOptions const):
1021         * WebKitTestRunner/ios/TestControllerIOS.mm:
1022         (overridePresentViewController):
1023         (WTR::TestController::platformInitialize):
1024         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1025         (WTR::UIScriptController::dismissFilePicker):
1026
1027 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1028
1029         Implement async paste method on UIWKInteractionViewProtocol
1030         https://bugs.webkit.org/show_bug.cgi?id=196267
1031         <rdar://problem/49236346>
1032
1033         Reviewed by Tim Horton.
1034
1035         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1036         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1037         are now a part of all iOS 12 internal SDKs.
1038
1039         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1040
1041         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1042         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1043
1044         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1045         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1046         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1047         * TestWebKitAPI/ios/UIKitSPI.h:
1048
1049 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1050
1051         [ews-build] Use PostgreSQL for ews.webkit.org database
1052         https://bugs.webkit.org/show_bug.cgi?id=196270
1053
1054         Reviewed by Lucas Forschler.
1055
1056         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1057
1058 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1059
1060         [ews] Reset simctl states on reboot
1061         https://bugs.webkit.org/show_bug.cgi?id=196260
1062
1063         Rubber-stamped by Aakash Jain.
1064
1065         * EWSTools/start-queue-mac.sh:
1066
1067 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1068
1069         [ews-build] Use PostgreSQL for ews-build database
1070         https://bugs.webkit.org/show_bug.cgi?id=196229
1071
1072         Reviewed by Lucas Forschler.
1073
1074         * BuildSlaveSupport/ews-build/master.cfg:
1075
1076 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1077
1078         [ews-build] Get master_hostname dynamically in master.cfg
1079         https://bugs.webkit.org/show_bug.cgi?id=196255
1080
1081         Reviewed by Lucas Forschler.
1082
1083         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1084         send events data in test mode.
1085
1086 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-app] Set db_constraint to False for Foreign Keys
1089         https://bugs.webkit.org/show_bug.cgi?id=196252
1090
1091         Reviewed by Lucas Forschler.
1092
1093         * BuildSlaveSupport/ews-app/ews/models/build.py:
1094         * BuildSlaveSupport/ews-app/ews/models/step.py:
1095
1096 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1097
1098         [ews-build] is_test_mode_enabled should default to True
1099         https://bugs.webkit.org/show_bug.cgi?id=196248
1100
1101         Reviewed by Lucas Forschler.
1102
1103         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1104
1105 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1106
1107         [ews-app] Add webkitperl to ENABLED_QUEUES
1108         https://bugs.webkit.org/show_bug.cgi?id=196253
1109
1110         Reviewed by Lucas Forschler.
1111
1112         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1113
1114 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1115
1116         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1117         https://bugs.webkit.org/show_bug.cgi?id=196211
1118         rdar://problem/49110552
1119
1120         Reviewed by Tim Horton.
1121
1122         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1123         Make sure that EventSenderProxy always exists when running tests. We used to create
1124         it when resetting before the first test, which is a bit too late.
1125
1126         * WebKitTestRunner/TestController.h:
1127         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1128         (WTR::TestController::platformCreateWebView):
1129         (WTR::TestController::platformCreateOtherPage):
1130         (WTR::TestController::finishCreatingPlatformWebView):
1131         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1132         (WTR::PlatformWebView::PlatformWebView):
1133         Moved some code that made NSWindow use NSEvent during web view creation. We may
1134         need to move more if some other case us found, but this is enough for now.
1135
1136 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1137
1138         Unreviewed. Fix typo in GLib geolocation API after r243285.
1139
1140         gelocation -> geolocation.
1141
1142         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1143         (testGeolocationManagerWatchPosition):
1144
1145 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1146
1147         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1148         https://bugs.webkit.org/show_bug.cgi?id=196213
1149
1150         Reviewed by Geoff Garen.
1151
1152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1153         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1154         (credentialWithIdentityAndKeychainPath):
1155         (-[ChallengeDelegate webView:didFinishNavigation:]):
1156         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1157         (TestWebKitAPI::TEST):
1158
1159 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1160
1161         Expected shouldn't assume its contained types are copyable
1162         https://bugs.webkit.org/show_bug.cgi?id=195986
1163
1164         Reviewed by JF Bastien.
1165
1166         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1167         (TestWebKitAPI::NonCopyable::operator== const):
1168         (TestWebKitAPI::NonCopyable::operator!= const):
1169         (TestWebKitAPI::TEST):
1170
1171 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1172
1173         Remove some now-unnecessary dynamic class lookup
1174         https://bugs.webkit.org/show_bug.cgi?id=196237
1175
1176         Reviewed by Simon Fraser.
1177
1178         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1179         (makeRequest):
1180         (TEST):
1181
1182 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1183
1184         Unreviewed, rolling out r243450.
1185
1186         AppleWin and WinCairo port builds get broken.
1187
1188         Reverted changeset:
1189
1190         "Add test for fix of #196095"
1191         https://bugs.webkit.org/show_bug.cgi?id=196097
1192         https://trac.webkit.org/changeset/243450
1193
1194 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1195
1196         Unreviewed, rolling out r243465.
1197         https://bugs.webkit.org/show_bug.cgi?id=196226
1198
1199         the test doesn't build (Requested by thorton on #webkit).
1200
1201         Reverted changeset:
1202
1203         "Do not terminate the NetworkProcess if a third party
1204         application sends a NSCredential with a SecIdentityRef"
1205         https://bugs.webkit.org/show_bug.cgi?id=196213
1206         https://trac.webkit.org/changeset/243465
1207
1208 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1209
1210         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1211         https://bugs.webkit.org/show_bug.cgi?id=196213
1212
1213         Reviewed by Geoff Garen.
1214
1215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1216         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1217         (credentialWithIdentityAndKeychainPath):
1218         (-[ChallengeDelegate webView:didFinishNavigation:]):
1219         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1220         (TestWebKitAPI::TEST):
1221
1222 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1223
1224         [ews-build] Gracefully handle missing patch_id in events
1225         https://bugs.webkit.org/show_bug.cgi?id=196216
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * BuildSlaveSupport/ews-build/events.py:
1230
1231 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1232
1233         [ews-build] use lz4 compression for improving buildbot performance
1234         https://bugs.webkit.org/show_bug.cgi?id=196155
1235
1236         Reviewed by Lucas Forschler.
1237
1238         * BuildSlaveSupport/ews-build/master.cfg:
1239
1240 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1241
1242         Pull some API testing helper methods out of TestWKWebView
1243         https://bugs.webkit.org/show_bug.cgi?id=196212
1244
1245         Reviewed by Tim Horton.
1246
1247         Refactor some more API testing utility methods, so that they can be used in
1248         tests that do not use TestWKWebView.
1249
1250         * TestWebKitAPI/cocoa/TestWKWebView.h:
1251         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1252         (-[WKWebView loadTestPageNamed:]):
1253         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1254         (-[WKWebView synchronouslyLoadHTMLString:]):
1255         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1256         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1257         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1258         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1259         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1260
1261 2019-03-25  Jer Noble  <jer.noble@apple.com>
1262
1263         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1264         https://bugs.webkit.org/show_bug.cgi?id=196097
1265
1266         Reviewed by Eric Carlson.
1267
1268         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1269
1270         * DumpRenderTree/mac/DumpRenderTree.mm:
1271         (resetWebPreferencesToConsistentValues):
1272         * WebKitTestRunner/TestController.cpp:
1273         (WTR::TestController::resetPreferencesToConsistentValues):
1274
1275 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1276
1277         Pull IPadUserInterfaceSwizzler out into a separate header file
1278         https://bugs.webkit.org/show_bug.cgi?id=196193
1279
1280         Reviewed by Anders Carlsson.
1281
1282         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1283         be used in other API tests.
1284
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1287         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1288         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1289         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1290         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1291         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1292
1293 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1294
1295         Remove NavigatorContentUtils in WebCore/Modules
1296         https://bugs.webkit.org/show_bug.cgi?id=196070
1297
1298         Reviewed by Alex Christensen.
1299
1300         NavigatorContentUtils was to support the custom scheme spec [1].
1301         However, in WebKit side, no port has supported the feature in
1302         WebKit layer after EFL port was removed. So there has been the
1303         only IDL implementation of the NavigatorContentUtils in WebCore.
1304         So we don't need to keep the implementation in WebCore anymore.
1305
1306         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1307
1308         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1309
1310 2019-03-24  Andy Estes  <aestes@apple.com>
1311
1312         [watchOS] Remove unused Proximity Networking code
1313         https://bugs.webkit.org/show_bug.cgi?id=196188
1314
1315         Reviewed by Tim Horton.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1318         (TEST):
1319
1320 2019-03-23  Keith Miller  <keith_miller@apple.com>
1321
1322         Refactor clz/ctz and fix getLSBSet.
1323         https://bugs.webkit.org/show_bug.cgi?id=196162
1324
1325         Reviewed by Saam Barati.
1326
1327         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1328
1329         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1330         (TestWebKitAPI::TEST):
1331
1332 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1335         https://bugs.webkit.org/show_bug.cgi?id=196143
1336
1337         Reviewed by Michael Catanzaro.
1338
1339         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1340         directories.
1341
1342         * Scripts/webkitpy/style/checkers/cpp.py:
1343         (check_identifier_name_in_declaration):
1344         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1345         (WebKitStyleTest.test_names):
1346
1347 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1348
1349         [Flatpak] Manifest expanding fails for qt WPE extension
1350         https://bugs.webkit.org/show_bug.cgi?id=196148
1351
1352         Reviewed by Alex Christensen.
1353
1354         * flatpak/flatpakutils.py:
1355         (expand_submodules_recurse): The last recurse manifest expand
1356         iteration might lead to a single module so take it into account
1357         and don't try to recurse further.
1358
1359 2019-03-22  Chris Dumez  <cdumez@apple.com>
1360
1361         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1362         https://bugs.webkit.org/show_bug.cgi?id=195348
1363         <rdar://problem/48622090>
1364
1365         Reviewed by Alex Christensen.
1366
1367         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1368         to NO when test.options().shouldIgnoreMetaViewport is false.
1369
1370         * WebKitTestRunner/ios/TestControllerIOS.mm:
1371         (WTR::TestController::platformConfigureViewForTest):
1372
1373 2019-03-22  Chris Dumez  <cdumez@apple.com>
1374
1375         Prewarmed processes should be usable with any website data store
1376         https://bugs.webkit.org/show_bug.cgi?id=196104
1377
1378         Reviewed by Alex Christensen.
1379
1380         Add API test coverage.
1381
1382         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1383         (runInitialWarmedProcessUsedTest):
1384         (TEST):
1385
1386 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1387
1388         Back out local changes to Alex's Subversion working directory
1389
1390         They were accidentally committed.
1391
1392         * Scripts/webkitpy/common/system/abstractexecutive.py:
1393         (AbstractExecutive.wait_newest):
1394         * Scripts/webkitpy/common/system/executive.py:
1395         (Executive.running_pids):
1396         * Scripts/webkitpy/common/system/executive_mock.py:
1397         (MockExecutive.running_pids):
1398         * Scripts/webkitpy/common/system/executive_unittest.py:
1399         (ExecutiveTest.serial_test_running_pids):
1400         * Scripts/webkitpy/port/darwin.py:
1401         (DarwinPort.check_for_leaks):
1402         * Scripts/webkitpy/port/leakdetector.py:
1403         (LeakDetector.check_for_leaks):
1404         - This was the hack attached to Bug 193772.
1405
1406         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1407         (+[WebKitTestRunnerEvent mouseLocation]):
1408         - This works around a crash on an internal build.
1409
1410 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1411
1412         Fix the build after r243354
1413         https://bugs.webkit.org/show_bug.cgi?id=196138
1414         <rdar://problem/49145951>
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1417         (TEST):
1418         * TestWebKitAPI/ios/UIKitSPI.h:
1419
1420 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1421
1422         Adopt UIWKDocumentContext
1423         https://bugs.webkit.org/show_bug.cgi?id=196040
1424         <rdar://problem/48642440>
1425
1426         Reviewed by Ryosuke Niwa.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1430         (makeRequest):
1431         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1432         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1433         (applyStyle):
1434         (TEST):
1435         Add tests for UIWKDocumentContext.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1438         (TEST):
1439         (recursiveFindWKContentView): Deleted.
1440         * TestWebKitAPI/cocoa/TestWKWebView.h:
1441         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1442         (recursiveFindWKContentView):
1443         (-[TestWKWebView wkContentView]):
1444         * TestWebKitAPI/ios/UIKitSPI.h:
1445         Share the WKContentView finding code between tests.
1446
1447 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1448
1449         [iOS WK2] Turn on async overflow scrolling by default
1450         https://bugs.webkit.org/show_bug.cgi?id=196011
1451         rdar://problem/48453859
1452
1453         Reviewed by Antti Koivisto.
1454         
1455         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1456         since so many basic layout tests have different results when compositing is triggered for
1457         overflow.
1458         
1459         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1460
1461         * WebKitTestRunner/TestController.cpp:
1462         (WTR::TestController::resetPreferencesToConsistentValues):
1463
1464 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1465
1466         [ews-build] Retry API test in case of failures
1467         https://bugs.webkit.org/show_bug.cgi?id=196004
1468
1469         Reviewed by Lucas Forschler.
1470
1471         * BuildSlaveSupport/ews-build/steps.py:
1472         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1473         (CompileWebKitToT.doStepIf): Ditto.
1474         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1475         (ReRunAPITests): Re-run API tests.
1476         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1477         (RunAPITestsWithoutPatch): Run API tests without patch.
1478         (RunAPITestsWithoutPatch.doStepIf):
1479         (RunAPITestsWithoutPatch.hideStepIf):
1480         (RunAPITestsWithoutPatch.evaluateCommand):
1481         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1482         (AnalyzeAPITestsResults.start):
1483         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1484         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1485         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1486         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1487
1488 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1489
1490         [ews-build] Update queues configurations
1491         https://bugs.webkit.org/show_bug.cgi?id=196074
1492
1493         Reviewed by Dewei Zhu.
1494
1495         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1496         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1497
1498 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1499
1500         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1501         https://bugs.webkit.org/show_bug.cgi?id=195680
1502         <rdar://problem/48903534>
1503
1504         Unreviewed infrastructure fix.
1505
1506         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1507         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1508
1509 2019-03-21  Andy Estes  <aestes@apple.com>
1510
1511         [iOS] Apple Pay should be available in documents with no user agent scripts
1512         https://bugs.webkit.org/show_bug.cgi?id=196061
1513         <rdar://problem/48649391>
1514
1515         Reviewed by Brady Eidson.
1516
1517         Added API tests and related infrastructure.
1518
1519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1520         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1521         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1522         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1523         (TestWebKitAPI::TEST):
1524         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1525         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1526         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1527         * TestWebKitAPI/cocoa/TestProtocol.mm:
1528         (-[TestProtocol startLoading]):
1529         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1530         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1531         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1532         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1533
1534 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1535
1536         REGRESSSION (r243297): webkitpy tests broken
1537         https://bugs.webkit.org/show_bug.cgi?id=196108
1538
1539         Reviewed by Aakash Jain.
1540
1541         r243297 updated contributors.json, which broke a few unit tests.
1542
1543         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1544         (IRCCommandTest.test_whois):
1545         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1546
1547 2019-03-21  Chris Dumez  <cdumez@apple.com>
1548
1549         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1550         https://bugs.webkit.org/show_bug.cgi?id=196041
1551         <rdar://problem/49083230>
1552
1553         Reviewed by Alex Christensen.
1554
1555         Add API test coverage.
1556
1557         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1558         (TEST):
1559
1560 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1561
1562         Add SPI to inform applications of WKContentRuleList actions
1563         https://bugs.webkit.org/show_bug.cgi?id=195965
1564         <rdar://problem/42664365>
1565
1566         Reviewed by Geoff Garen.
1567
1568         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1569         (TestWebKitAPI::allActionsForResourceLoad):
1570         (TestWebKitAPI::testRequest):
1571         (TestWebKitAPI::TEST_F):
1572         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1573         (Notification::description):
1574         (Notification::operator== const):
1575         (toVector):
1576         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1577         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1578         (makeContentRuleList):
1579         (TEST):
1580         (makeWarnContentRuleList): Deleted.
1581
1582 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1583
1584         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1585         https://bugs.webkit.org/show_bug.cgi?id=196088
1586
1587         Reviewed by Brian Burg.
1588
1589         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1590         Support checks when only one platform is specified. Also deprecate macosx() and
1591         force the use of macos() instead.
1592
1593         * Scripts/webkitpy/style/checkers/cpp.py:
1594         (check_min_versions_of_wk_api_available):
1595         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1596         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1597
1598 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1599
1600         Update status inactive committers' status to 'contributor'.
1601
1602         * Scripts/webkitpy/common/config/contributors.json:
1603
1604 2019-03-21  Xan Lopez  <xan@igalia.com>
1605
1606         [JSC][x86] Drop support for x87 floating point
1607         https://bugs.webkit.org/show_bug.cgi?id=194853
1608
1609         Reviewed by Don Olmstead.
1610
1611         Force SSE2 on x86/32bit builds.
1612
1613         * Scripts/webkitdirs.pm:
1614         (generateBuildSystemFromCMakeProject):
1615
1616 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1617
1618         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1619         https://bugs.webkit.org/show_bug.cgi?id=196073
1620
1621         Reviewed by Michael Catanzaro.
1622
1623         Add test cases to check functions and constructors with no arguments but receiving user data.
1624
1625         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1626         (checkUserData):
1627         (testJSCFunction):
1628         (fooCreateWithUserData):
1629         (testJSCClass):
1630
1631 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1632
1633         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1634
1635         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1636
1637         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1638
1639 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1640
1641         [GTK][WPE] Add API to provide geolocation information
1642         https://bugs.webkit.org/show_bug.cgi?id=195940
1643
1644         Reviewed by Michael Catanzaro.
1645
1646         Add a new test to check the new API.
1647
1648         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1649         (testGeolocationManagerCurrentPosition):
1650         (testGeolocationManagerWatchPosition):
1651         (beforeAll):
1652         (afterAll):
1653         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1654         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1655         (beforeAll): Ditto.
1656         * TestWebKitAPI/glib/CMakeLists.txt:
1657
1658 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1659
1660         [GLib] Returning G_TYPE_OBJECT from a method does not work
1661         https://bugs.webkit.org/show_bug.cgi?id=195574
1662
1663         Reviewed by Michael Catanzaro.
1664
1665         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1666
1667         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1668         (getGFile):
1669         (getParent):
1670         (createGString):
1671         (getGString):
1672         (getGStringCopyWillRaise):
1673         (getGStringCopy):
1674         (getGStringStr):
1675         (getGStringLen):
1676         (freeGString):
1677         (testJSCClass):
1678
1679 2019-03-20  Saam Barati  <sbarati@apple.com>
1680
1681         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1682         https://bugs.webkit.org/show_bug.cgi?id=195721
1683
1684         Reviewed by Filip Pizlo.
1685
1686         * Scripts/run-javascriptcore-tests:
1687
1688 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1689
1690         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1691         https://bugs.webkit.org/show_bug.cgi?id=196049
1692
1693         Reviewed by Tim Horton.
1694
1695         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1696         overflow scrolling in general, so rename it.
1697
1698         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1699
1700 2019-03-20  Daniel Bates  <dabates@apple.com>
1701
1702         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1703         https://bugs.webkit.org/show_bug.cgi?id=196031
1704         <rdar://problem/49078172>
1705
1706         Reviewed by Tim Horton.
1707
1708         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1709         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1710         same code path used when the Done button is pressed to dismiss the <select> picker.
1711
1712         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1713         (TestWebKitAPI::TEST):
1714
1715 2019-03-20  Chris Dumez  <cdumez@apple.com>
1716
1717         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1718         https://bugs.webkit.org/show_bug.cgi?id=196029
1719         <rdar://problem/48954651>
1720
1721         Reviewed by Tim Horton.
1722
1723         Add API test coverage.
1724
1725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1726
1727 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-build] Improve failure summary string for ApplyPatch step
1730         https://bugs.webkit.org/show_bug.cgi?id=195995
1731
1732         Reviewed by Alexey Proskuryakov.
1733
1734         * BuildSlaveSupport/ews-build/steps.py:
1735         (ApplyPatch.getResultSummary): Override getResultSummary.
1736
1737 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1738
1739         AX: Implement support for new meter ARIA role
1740         https://bugs.webkit.org/show_bug.cgi?id=195966
1741
1742         Reviewed by Chris Fleizach.
1743
1744         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1745         to AXLevelIndicator.
1746
1747         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1748
1749 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1750
1751         [WebAuthN] Implement FIDO AppID extension
1752         https://bugs.webkit.org/show_bug.cgi?id=143491
1753         <rdar://problem/48298273>
1754
1755         Reviewed by Brent Fulgham.
1756
1757         Add a test that covers the new flag of convertToU2fSignCommand.
1758
1759         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1760         (TestWebKitAPI::TEST):
1761         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1762         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1763         (TestWebKitAPI::TEST):
1764
1765 2019-03-19  Keith Rollin  <krollin@apple.com>
1766
1767         Add support for more platforms to generate-xcfilelists
1768         https://bugs.webkit.org/show_bug.cgi?id=195977
1769
1770         Reviewed by Alexey Proskuryakov.
1771
1772         generate-xcfilelists incorrectly complains when involved with building
1773         WebKit for iphonesimulator:
1774
1775             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1776             …
1777             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1778
1779         Address this by teaching generate-xcfilelists about more platforms.
1780
1781         * Scripts/generate-xcfilelists:
1782
1783 2019-03-19  John Wilander  <wilander@apple.com>
1784
1785         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1786         https://bugs.webkit.org/show_bug.cgi?id=195923
1787         <rdar://problem/49001272>
1788
1789         Reviewed by Alex Christensen.
1790
1791         This patch does the following to the TestRunner:
1792         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1793         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1794         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1795
1796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1798         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1799         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1800         * WebKitTestRunner/TestController.cpp:
1801         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1802         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1803         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1804         * WebKitTestRunner/TestController.h:
1805         * WebKitTestRunner/TestInvocation.cpp:
1806         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1807
1808 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1809
1810         [CMake] Support more clang and gcc sanitizers
1811         https://bugs.webkit.org/show_bug.cgi?id=195956
1812
1813         Reviewed by Michael Catanzaro.
1814
1815         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1816
1817 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1818
1819         [ews-build] Improve summary for PrintConfiguration step
1820         https://bugs.webkit.org/show_bug.cgi?id=195945
1821
1822         Reviewed by Lucas Forschler.
1823
1824         * BuildSlaveSupport/ews-build/steps.py:
1825         (PrintConfiguration.getResultSummary): Override getResultSummary.
1826
1827 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1828
1829         [ews-build] Improve summary for CheckOutSource step
1830         https://bugs.webkit.org/show_bug.cgi?id=195963
1831
1832         Reviewed by Lucas Forschler.
1833
1834         * BuildSlaveSupport/ews-build/steps.py:
1835         (CheckOutSource.getResultSummary):
1836
1837 2019-03-19  Daniel Bates  <dabates@apple.com>
1838
1839         [iOS] Focus not preserved when switching between tabs
1840         https://bugs.webkit.org/show_bug.cgi?id=195820
1841         <rdar://problem/43614450>
1842
1843         Reviewed by Brent Fulgham.
1844
1845         Add tests to ensure that we restore focus when resigning and becoming first responder.
1846
1847         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1848         (TestWebKitAPI::TEST):
1849
1850 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1851
1852         Make WTFLogChannelState and WTFLogLevel enum classes
1853         https://bugs.webkit.org/show_bug.cgi?id=195904
1854
1855         Reviewed by Eric Carlson.
1856
1857         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1858         (TestWebKitAPI::TEST_F):
1859
1860 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1861
1862         [GStreamer][EME] Backported mssdemux protection data crash fix
1863         https://bugs.webkit.org/show_bug.cgi?id=195918
1864
1865         Reviewed by Philippe Normand.
1866
1867         * gstreamer/jhbuild.modules:
1868         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1869
1870 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1871
1872         Unreviewed, rolling out r243132.
1873
1874         Broke GTK build
1875
1876         Reverted changeset:
1877
1878         "Make WTFLogChannelState and WTFLogLevel enum classes"
1879         https://bugs.webkit.org/show_bug.cgi?id=195904
1880         https://trac.webkit.org/changeset/243132
1881
1882 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1883
1884         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1885
1886         * Scripts/webkitdirs.pm:
1887         (builtDylibPathForName): Adjust the shared library name that's changed
1888         with the API version bump in r243073.
1889
1890 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1891
1892         Make WTFLogChannelState and WTFLogLevel enum classes
1893         https://bugs.webkit.org/show_bug.cgi?id=195904
1894
1895         Reviewed by Eric Carlson.
1896
1897         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1898         (TestWebKitAPI::TEST_F):
1899
1900 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1901
1902         Disable flaky test added in r2431100
1903         https://webkit.org/b/195785
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1906         (TestWebKitAPI::TEST):
1907         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1908
1909 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1910
1911         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1912         https://bugs.webkit.org/show_bug.cgi?id=195916
1913
1914         Reviewed by Tim Horton.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1917         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1918
1919 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1920
1921         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1922
1923         * Scripts/webkitpy/common/config/contributors.json:
1924
1925 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1926
1927         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1928         https://bugs.webkit.org/show_bug.cgi?id=195785
1929
1930         Reviewed by Geoffrey Garen.
1931
1932         * TestWebKitAPI/TCPServer.cpp: Added.
1933         (TestWebKitAPI::TCPServer::TCPServer):
1934         (TestWebKitAPI::TCPServer::~TCPServer):
1935         (TestWebKitAPI::TCPServer::socketBindListen):
1936         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1937         * TestWebKitAPI/TCPServer.h: Added.
1938         (TestWebKitAPI::TCPServer::port const):
1939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1940         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1941         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1942         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1943         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1944         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1945         (TestWebKitAPI::respondSlowly):
1946         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1947         (TestWebKitAPI::downloadAtRate):
1948         (TestWebKitAPI::TEST):
1949
1950 2019-03-18  Saam Barati  <sbarati@apple.com>
1951
1952         Add a plan file for JetStream 2
1953         https://bugs.webkit.org/show_bug.cgi?id=190734
1954
1955         Reviewed by Mark Lam.
1956
1957         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1958
1959 2019-03-18  Chris Dumez  <cdumez@apple.com>
1960
1961         Delay WebProcess launch until a load is triggered in a Web view
1962         https://bugs.webkit.org/show_bug.cgi?id=195758
1963         <rdar://problem/48126013>
1964
1965         Reviewed by Geoff Garen.
1966
1967         Add API test coverage. Also update some existing API tests to not expect
1968         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1969
1970         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1971         (TestWebKitAPI::TEST):
1972         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1973         (TestWebKitAPI::TEST):
1974         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1975         (TEST):
1976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1977         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1978         (TEST):
1979         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1980         (TEST):
1981         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1982
1983 2019-03-18  Xan Lopez  <xan@igalia.com>
1984
1985         [CMake] Prevent potential warning when determining $architecture
1986         https://bugs.webkit.org/show_bug.cgi?id=195891
1987
1988         Reviewed by Michael Catanzaro.
1989
1990         It's possible for generateBuildSystemForCMakeProject to be called
1991         before determineArchitecture() is ever called. This will make the
1992         first eq check with $architecture to be bogus (and print a
1993         warning). Change that to an eq check with architecture(), which
1994         implicitly calls determineArchitecture() if needed, and change all
1995         the other similar cases in the method in the same way to prevent
1996         future bugs like this one.
1997
1998         * Scripts/webkitdirs.pm:
1999         (generateBuildSystemFromCMakeProject):
2000
2001 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2002
2003         [WPE] Tarballs generated with “make dist” cannot build documentation
2004         https://bugs.webkit.org/show_bug.cgi?id=195885
2005
2006         Reviewed by Carlos Garcia Campos.
2007
2008         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2009
2010 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2011
2012         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2013         https://bugs.webkit.org/show_bug.cgi?id=195883
2014
2015         Reviewed by Carlos Garcia Campos.
2016
2017         * gtkdoc/gtkdoc.py:
2018         (GTKDoc._run_command): When commands fail to run, include the full command line for
2019         the program invocation and the output it has generated on the standard error stream.
2020
2021 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2022
2023         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2024         https://bugs.webkit.org/show_bug.cgi?id=195786
2025
2026         Reviewed by Philippe Normand.
2027
2028         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2029         * wpe/jhbuild.modules: Ditto.
2030
2031 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2032
2033         [ews-build] Don't run clean builds on EWS builders
2034         https://bugs.webkit.org/show_bug.cgi?id=195851
2035
2036         Reviewed by Geoffrey Garen.
2037
2038         * BuildSlaveSupport/ews-build/factories.py:
2039
2040 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2041
2042         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2043         https://bugs.webkit.org/show_bug.cgi?id=195849
2044
2045         Reviewed by Chris Dumez.
2046
2047         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2048
2049         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2050         (runWebsiteDataStoreCustomPaths):
2051
2052 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2053
2054         webkitpy: Upload test results
2055         https://bugs.webkit.org/show_bug.cgi?id=195755
2056         <rdar://problem/48896182>
2057
2058         Reviewed by Aakash Jain.
2059
2060         Establish a new format for uploading results that is not tied to layout tests, apply
2061         that format to webkitpy tests.
2062
2063         * Scripts/webkitpy/common/checkout/scm/git.py:
2064         (Git.native_branch): Return what branch the current checkout is on.
2065         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2066         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2067         * Scripts/webkitpy/common/checkout/scm/svn.py:
2068         (SVN.native_branch): Ditto.
2069         * Scripts/webkitpy/common/system/platforminfo.py:
2070         (PlatformInfo.build_version): Return a build version for Mac.
2071         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2072         (MockPlatformInfo.__init__):
2073         (MockPlatformInfo.build_version):
2074         * Scripts/webkitpy/results: Added.
2075         * Scripts/webkitpy/results/__init__.py: Added.
2076         * Scripts/webkitpy/results/options.py: Added.
2077         (upload_options): OptParse list for upload options.
2078         * Scripts/webkitpy/results/upload.py: Added.
2079         (Upload): Class which enforces the upload format expected by the results server.
2080         (Upload.Expectations):
2081         (Upload.create_configuration):
2082         (Upload.create_commit):
2083         (Upload.create_details):
2084         (Upload.create_run_stats):
2085         (Upload.create_test_result):
2086         (Upload.__init__):
2087         (Upload.Encoder): Encode Upload object as json.
2088         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2089         * Scripts/webkitpy/results/upload_unittest.py: Added.
2090         * Scripts/webkitpy/test/main.py:
2091         (Tester._parse_args): Add upload arguments.
2092         (Tester._run_tests): Allow results to be uploaded.
2093         * Scripts/webkitpy/test/runner.py:
2094         (Runner.__init__): Record which tests were run, rather than just counting them.
2095         (Runner.handle):
2096         * Scripts/webkitpy/test/runner_unittest.py:
2097         (RunnerTest.test_run):
2098         * Scripts/webkitpy/thirdparty/__init__.py:
2099         (AutoinstallImportHook.find_module): Add requests auto-install.
2100         (AutoinstallImportHook._install_requests):
2101         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2102         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2103
2104 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2105
2106         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2107         https://bugs.webkit.org/show_bug.cgi?id=195810
2108
2109         Reviewed by Tim Horton.
2110
2111         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2112         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2113         ending certain layout tests.
2114
2115         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2116         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2117         (-[TestRunnerWKWebView dealloc]):
2118         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2119
2120         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2121         helper method when destroying the web view, and when resetting state between tests.
2122
2123         * WebKitTestRunner/ios/TestControllerIOS.mm:
2124         (WTR::TestController::platformResetStateToConsistentValues):
2125
2126         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2127
2128 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2129
2130         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2131         https://bugs.webkit.org/show_bug.cgi?id=190350
2132         <rdar://problem/45089503>
2133
2134         Reviewed by Geoffrey Garen.
2135
2136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2137         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2138         (TEST):
2139         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2140         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2141         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2142         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2143         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2144         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2145         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2146         (runTest):
2147         (createDirectories):
2148         (TEST):
2149         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2150         (TEST):
2151         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2152         (TEST):
2153
2154 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2155
2156         Add support to WebPage for getting the contents as an attributed string.
2157         https://bugs.webkit.org/show_bug.cgi?id=195636
2158         rdar://problem/45055697
2159
2160         Reviewed by Tim Horton.
2161
2162         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2163         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2164
2165 2019-03-15  Chris Dumez  <cdumez@apple.com>
2166
2167         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2168         https://bugs.webkit.org/show_bug.cgi?id=195747
2169
2170         Reviewed by Geoff Garen.
2171
2172         Add API test coverage.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2175
2176 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2177
2178         Unreviewed, rolling out r242952.
2179
2180         Causing API failures on iOS Simulator
2181
2182         Reverted changeset:
2183
2184         "[PSON] Make sure the WebProcessCache is leverage when
2185         relaunching a process after termination"
2186         https://bugs.webkit.org/show_bug.cgi?id=195747
2187         https://trac.webkit.org/changeset/242952
2188
2189 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2190
2191         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2192         https://bugs.webkit.org/show_bug.cgi?id=195740
2193
2194         Reviewed by Ross Kirsling.
2195
2196         window.open doesn't work for WebKitBrowserWindow because it is not
2197         implemented yet.
2198
2199         1. Implemented createNewPage callback of WKPageUIClient.
2200         2. Changed MainWindow to take a BrowserWindow factory function
2201           instead of BrowserWindowType to be flexible to create
2202           BrowserWindow with extra settings.
2203         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2204           because it is not relevant with MainWindow anymore.
2205
2206         * MiniBrowser/win/Common.cpp:
2207         (parseCommandLine):
2208         * MiniBrowser/win/Common.h:
2209         (CommandLineOptions::CommandLineOptions):
2210         * MiniBrowser/win/MainWindow.cpp:
2211         (MainWindow::MainWindow):
2212         (MainWindow::create):
2213         (MainWindow::init):
2214         (MainWindow::WndProc):
2215         * MiniBrowser/win/MainWindow.h:
2216         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2217         (PrintWebUIDelegate::createWebViewWithRequest):
2218         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2219         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2220         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2221         (WebKitBrowserWindow::updateProxySettings):
2222         (WebKitBrowserWindow::createNewPage):
2223         * MiniBrowser/win/WebKitBrowserWindow.h:
2224         * MiniBrowser/win/WinMain.cpp:
2225         (wWinMain):
2226
2227 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2228
2229         Make it possible to test scrolling tree layer manipulation more easily
2230         https://bugs.webkit.org/show_bug.cgi?id=195780
2231
2232         Reviewed by Tim Horton.
2233         
2234         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2235         cuts off communication of scrolling tree scrolls back to the web process
2236         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2237         allows tests to trigger scrolls which run the scrolling tree layer positioning
2238         logic, but never get another commit from the web process that might mask
2239         scrolling tree bugs.
2240         
2241         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2242         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2243         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2244
2245         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2246         (WTR::UIScriptController::scrollUpdatesDisabled const):
2247         (WTR::UIScriptController::setScrollUpdatesDisabled):
2248         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2249         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2250         (WTR::UIScriptController::scrollUpdatesDisabled const):
2251         (WTR::UIScriptController::setScrollUpdatesDisabled):
2252         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2253         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2254         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2255         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2256         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2257         * WebKitTestRunner/ios/TestControllerIOS.mm:
2258         (WTR::TestController::platformResetStateToConsistentValues):
2259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2260         (WTR::UIScriptController::scrollUpdatesDisabled const):
2261         (WTR::UIScriptController::setScrollUpdatesDisabled):
2262
2263 2019-03-14  Youenn Fablet  <youenn@apple.com>
2264
2265         Move IDB storage in private browsing mode to NetworkProcess
2266         https://bugs.webkit.org/show_bug.cgi?id=195602
2267
2268         Reviewed by Brady Eidson.
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2271         (TEST):
2272
2273 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2274
2275         [ews-build] Make descriptionDone messages more readable
2276         https://bugs.webkit.org/show_bug.cgi?id=195760
2277
2278         Reviewed by Lucas Forschler.
2279
2280         * BuildSlaveSupport/ews-build/steps.py:
2281         * BuildSlaveSupport/ews-build/steps_unittest.py:
2282
2283 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2284
2285         [ews-build] Generate status-bubble hover-over messages
2286         https://bugs.webkit.org/show_bug.cgi?id=195680
2287
2288         Reviewed by Lucas Forschler.
2289
2290         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2291         (StatusBubble):
2292         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2293         on hover-over.
2294         (StatusBubble._iso_time):
2295         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2296         hover-over message.
2297         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2298
2299 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2300
2301         [ews-app] Gracefully handle the case when state_string is None
2302         https://bugs.webkit.org/show_bug.cgi?id=195753
2303
2304         Reviewed by Lucas Forschler.
2305
2306         * BuildSlaveSupport/ews-app/ews/models/build.py:
2307         * BuildSlaveSupport/ews-app/ews/models/step.py:
2308
2309 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2310
2311         [ews-app] Status bubble display pending for currently running build step
2312         https://bugs.webkit.org/show_bug.cgi?id=195744
2313
2314         Reviewed by Lucas Forschler.
2315
2316         * BuildSlaveSupport/ews-build/events.py:
2317         (Events.stepStarted): If state_string is pending, replace it with step name.
2318
2319 2019-03-14  Chris Dumez  <cdumez@apple.com>
2320
2321         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2322         https://bugs.webkit.org/show_bug.cgi?id=195750
2323
2324         Reviewed by Geoffrey Garen.
2325
2326         Add API test coverage.
2327
2328         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2329         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2330         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2331         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2332
2333 2019-03-14  Chris Dumez  <cdumez@apple.com>
2334
2335         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2336         https://bugs.webkit.org/show_bug.cgi?id=195747
2337
2338         Reviewed by Geoff Garen.
2339
2340         Add API test coverage.
2341
2342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2343
2344 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2345
2346         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2347         https://bugs.webkit.org/show_bug.cgi?id=195725
2348         <rdar://problem/48545062>
2349
2350         Reviewed by Tim Horton.
2351
2352         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2353         handler is nil.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2356         (TestWebKitAPI::TEST):
2357
2358 2019-03-13  Sam Weinig  <sam@webkit.org>
2359
2360         Add utility function to allow easy reverse range-based iteration of a container
2361         https://bugs.webkit.org/show_bug.cgi?id=195542
2362
2363         Reviewed by Antti Koivisto.
2364
2365         * TestWebKitAPI/CMakeLists.txt:
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2368         (TestWebKitAPI::TEST):
2369         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2370
2371 2019-03-13  Chris Dumez  <cdumez@apple.com>
2372
2373         Use a ServiceWorker process per registrable domain
2374         https://bugs.webkit.org/show_bug.cgi?id=195649
2375
2376         Reviewed by Youenn Fablet.
2377
2378         Update API test coverage.
2379
2380         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2381
2382 2019-03-13  Chris Dumez  <cdumez@apple.com>
2383
2384         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2385         https://bugs.webkit.org/show_bug.cgi?id=195684
2386         <rdar://problem/48294714>
2387
2388         Reviewed by Antti Koivisto.
2389
2390         Add API test coverage.
2391
2392         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2393
2394 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2395
2396         [ews-app] Remove unused patch view
2397         https://bugs.webkit.org/show_bug.cgi?id=195669
2398
2399         Reviewed by Lucas Forschler.
2400
2401         * BuildSlaveSupport/ews-app/ews/urls.py:
2402         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2403
2404 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2405
2406         [ews-app] Use Buildbot result code variables
2407         https://bugs.webkit.org/show_bug.cgi?id=195668
2408
2409         Reviewed by Alexey Proskuryakov.
2410
2411         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2412         (Buildbot): Added Buildbot result code variables.
2413         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2414         (StatusBubble._build_bubble): Used Buildbot result code variables.
2415
2416 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2417
2418         [Flatpak] Expand submodule recursively
2419         https://bugs.webkit.org/show_bug.cgi?id=195672
2420
2421         Building WPE with flatpak was impossible without that as it was raising an exception.
2422         Also update wpebackend-fdo to match what is built in jhbuild
2423
2424         Reviewed by Philippe Normand.
2425
2426         * flatpak/flatpakutils.py:
2427         (expand_submodules_recurse):
2428         (expand_manifest):
2429         * flatpak/org.webkit.WPEModules.yaml:
2430
2431 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2432
2433         [ews-app] status bubble should be hidden for certain builds
2434         https://bugs.webkit.org/show_bug.cgi?id=194597
2435
2436         Reviewed by Dewei Zhu.
2437
2438         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2439         (StatusBubble._build_bubble):
2440         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2441         because the patch didn't have relevant changes.
2442         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2443         in production yet.
2444
2445 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2446
2447         [Win] Fix a slew of simple clang-cl warnings.
2448         https://bugs.webkit.org/show_bug.cgi?id=195652
2449
2450         Reviewed by Don Olmstead.
2451
2452         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2453         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2454
2455 2019-03-12  Justin Fan  <justin_fan@apple.com>
2456
2457         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2458         https://bugs.webkit.org/show_bug.cgi?id=195518
2459         <rdar://problem/46322356>
2460
2461         Reviewed by Myles C. Maxfield.
2462
2463         * DumpRenderTree/DerivedSources-input.xcfilelist:
2464         * DumpRenderTree/DerivedSources-output.xcfilelist:
2465
2466 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2467
2468         Unreviewed, rolling out r242825.
2469         https://bugs.webkit.org/show_bug.cgi?id=195648
2470
2471         "Broke webkitpy tests with my change to
2472         lldb_dump_class_layout.py" (Requested by rmorisset on
2473         #webkit).
2474
2475         Reverted changeset:
2476
2477         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2478         classes with suspicious padding"
2479         https://bugs.webkit.org/show_bug.cgi?id=195573
2480         https://trac.webkit.org/changeset/242825
2481
2482 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2483
2484         [ews-build] Show status bubbles while the patch is waiting in queue
2485         https://bugs.webkit.org/show_bug.cgi?id=195618
2486
2487         Reviewed by Lucas Forschler.
2488
2489         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2490         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2491         enabled in initial deployment.
2492         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2493         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2494         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2495         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2496         (StatusBubble._build_bubbles_for_patch):
2497
2498 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2499
2500         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2501         https://bugs.webkit.org/show_bug.cgi?id=195573
2502
2503         Reviewed by Simon Fraser.
2504
2505         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2506
2507         * Scripts/dump-class-layout:
2508         (main):
2509         * lldb/lldb_dump_class_layout.py:
2510         (ClassLayout.__init__):
2511         (ClassLayout._compute_padding_recursive):
2512         (LLDBDebuggerInstance.dump_layout_for_classname):
2513         (LLDBDebuggerInstance):
2514         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2515         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2516
2517 2019-03-12  Chris Dumez  <cdumez@apple.com>
2518
2519         Device Orientation access permission should be denied unless explicitly granted by the client
2520         https://bugs.webkit.org/show_bug.cgi?id=195625
2521
2522         Reviewed by Youenn Fablet.
2523
2524         add API test coverage.
2525
2526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2527         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2528         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2529         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2530         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2531         (runDeviceOrientationTest):
2532         (TEST):
2533         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2534         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2535
2536 2019-03-12  Jer Noble  <jer.noble@apple.com>
2537
2538         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2539         https://bugs.webkit.org/show_bug.cgi?id=195137
2540         <rdar://problem/48810307>
2541
2542         Reviewed by Eric Carlson.
2543
2544         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2545         (TestWebKitAPI::TEST):
2546
2547 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2548
2549         [ews-build] Change urls from uat to production
2550         https://bugs.webkit.org/show_bug.cgi?id=195566
2551
2552         Reviewed by Lucas Forschler.
2553
2554         * BuildSlaveSupport/ews-app/ews/config.py:
2555         * BuildSlaveSupport/ews-build/events.py:
2556         * BuildSlaveSupport/ews-build/steps.py:
2557
2558 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-build] change max_builds for local-worker to 1
2561         https://bugs.webkit.org/show_bug.cgi?id=195568
2562
2563         Reviewed by Lucas Forschler.
2564
2565         * BuildSlaveSupport/ews-build/loadConfig.py:
2566
2567 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2568
2569         Fix the build
2570
2571         * TestRunnerShared/spi/PencilKitTestSPI.h:
2572         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2573
2574 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2575
2576         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2577         https://bugs.webkit.org/show_bug.cgi?id=194131
2578
2579         Reviewed by Michael Catanzaro.
2580
2581         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2582         (uriChanged):
2583         (testUnfinishedSubresourceLoad):
2584         (serverCallback):
2585         (beforeAll):
2586
2587 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2588
2589         WTF::Expected should use std::addressof instead of operator&
2590         https://bugs.webkit.org/show_bug.cgi?id=195604
2591
2592         Reviewed by Myles Maxfield.
2593
2594         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2595         (TestWebKitAPI::Unique::Unique):
2596         (TestWebKitAPI::Unique::operator&):
2597         (TestWebKitAPI::TEST):
2598
2599 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2600
2601         Add Optional to Forward.h.
2602         https://bugs.webkit.org/show_bug.cgi?id=195586
2603
2604         Reviewed by Darin Adler.
2605
2606         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2607         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2608         Remove unnecessary includes from headers.
2609
2610 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2611
2612         Add testing API to hit-test and scroll overflow scrollers
2613         https://bugs.webkit.org/show_bug.cgi?id=195278
2614
2615         Reviewed by Antti Koivisto.
2616         
2617         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2618         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2619         
2620         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2621
2622         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2623         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2624         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2625         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2626         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2627         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2628         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2629         (WTR::enclosingScrollViewIncludingSelf):
2630         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2631
2632 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2633
2634         API test WebKit.RequestTextInputContext fails on iOS
2635         https://bugs.webkit.org/show_bug.cgi?id=195585
2636
2637         Reviewed by Wenson Hsieh and Simon Fraser.
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2640         (applyStyle):
2641         (TEST):
2642         Add a viewport, so that the coordinates match up on iOS.
2643         Scroll by moving the UIScrollView's contentOffset.
2644
2645 2019-03-11  Chris Dumez  <cdumez@apple.com>
2646
2647         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2648         https://bugs.webkit.org/show_bug.cgi?id=195506
2649         <rdar://problem/48733477>
2650
2651         Reviewed by Alex Christensen.
2652
2653         Add API test coverage.
2654
2655         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2656
2657 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2658
2659         Adding myself to contributors.json
2660
2661         Unreviewed, addming myself to contributors.json .
2662
2663         * Scripts/webkitpy/common/config/contributors.json:
2664
2665 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2666
2667         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2668         https://bugs.webkit.org/show_bug.cgi?id=195511
2669         <rdar://problem/44873269>
2670
2671         Reviewed by Darin Adler.
2672
2673         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2674         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2675         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2676         (TEST_F):
2677
2678 2019-03-11  Chris Dumez  <cdumez@apple.com>
2679
2680         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2681         https://bugs.webkit.org/show_bug.cgi?id=195561
2682
2683         Reviewed by Youenn Fablet.
2684
2685         Make sure the JS in the test requests for permission to receive device orientation events.
2686
2687         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2688
2689 2019-03-11  Youenn Fablet  <youenn@apple.com>
2690
2691         Allow storage quota increase by default in WTR
2692         https://bugs.webkit.org/show_bug.cgi?id=195541
2693
2694         Reviewed by Geoffrey Garen.
2695
2696         Allow storage quota increase by default in WTR.
2697         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2698         Use this for tests that explicitly need cache increase.
2699
2700         Instead of increasing quota by 2, make sure the next request is
2701         granted by adding all given parameters.
2702
2703         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2704         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2705         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2706         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2707         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2708         * WebKitTestRunner/TestController.cpp:
2709         (WTR::TestController::setAllowStorageQuotaIncrease):
2710         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2711         * WebKitTestRunner/TestController.h:
2712         * WebKitTestRunner/TestInvocation.cpp:
2713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2714         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2715         (WTR::TestController::cocoaResetStateToConsistentValues):
2716         (WTR::TestController::setAllowStorageQuotaIncrease):
2717         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2718         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2719         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2720
2721 2019-03-11  Xan Lopez  <xan@igalia.com>
2722
2723         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2724         https://bugs.webkit.org/show_bug.cgi?id=194147
2725
2726         Reviewed by Michael Saboff.
2727
2728         To make --32-bit work correctly on Linux/64bit we need to:
2729
2730         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2731         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2732         unfortunately CMake only allows us to do this during
2733         crosscompilation, which is overkill here.
2734         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2735         pkg-config detection module uses the x86 .pc files instead of the
2736         x86_64 ones.
2737         - Set the -m32 flags for the compiler.
2738
2739         * Scripts/webkitdirs.pm:
2740         (generateBuildSystemFromCMakeProject):
2741
2742 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2743
2744         Add MotionMark-1.1 plan file for run-benchmark script.
2745         https://bugs.webkit.org/show_bug.cgi?id=195481
2746
2747         Rubber-stamped by Darin Adler.
2748
2749         Run-benchmark script should support MontionMark-1.1.
2750
2751         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2752
2753 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2754
2755         [ews-app] Add support for submit-to-ews url
2756         https://bugs.webkit.org/show_bug.cgi?id=195477
2757
2758         Reviewed by Lucas Forschler.
2759
2760         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2761         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2762         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2763         * BuildSlaveSupport/ews-app/ews/urls.py:
2764         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2765
2766 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2767
2768         Unreviewed, rolling out r242688, r242643, r242624.
2769
2770         Caused multiple layout test failures and crashes on iOS and macOS.
2771
2772         Reverted changeset:
2773
2774         "requestAnimationFrame should execute before the next frame"
2775         https://bugs.webkit.org/show_bug.cgi?id=177484
2776         https://trac.webkit.org/changeset/242624/webkit
2777
2778         * Tracing/SystemTracePoints.plist:
2779
2780 2019-03-11  John Wilander  <wilander@apple.com>
2781
2782         Resource Load Statistics: Make it possible exclude localhost from classification
2783         https://bugs.webkit.org/show_bug.cgi?id=195474
2784         <rdar://problem/47520577>
2785
2786         Reviewed by Brent Fulgham.
2787
2788         This patch allows for localhost to be excluded from classification and
2789         treatment as a prevalent resource.
2790
2791         The WebKit Tools change adds a new function called
2792         testRunner.setStatisticsIsRunningTest() which can be used to control this
2793         behavior.
2794
2795         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2796         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2797         (WTR::TestRunner::setStatisticsIsRunningTest):
2798         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2799         * WebKitTestRunner/TestController.cpp:
2800         (WTR::TestController::setStatisticsIsRunningTest):
2801         * WebKitTestRunner/TestController.h:
2802         * WebKitTestRunner/TestInvocation.cpp:
2803         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2804
2805 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2808         https://bugs.webkit.org/show_bug.cgi?id=195560
2809
2810         Reviewed by Lucas Forschler.
2811
2812         * BuildSlaveSupport/ews-build/master.cfg:
2813
2814 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2815
2816         Unreviewed, rolling out r242698.
2817
2818         API test crashes on bots.
2819
2820         Reverted changeset:
2821
2822         "Add a WKContentRuleList variant that uses copied memory
2823         instead of mmap'd shared memory for class A containerized
2824         apps"
2825         https://bugs.webkit.org/show_bug.cgi?id=195511
2826         https://trac.webkit.org/changeset/242698
2827
2828 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2829
2830         [WPE] Enable web process sandbox
2831         https://bugs.webkit.org/show_bug.cgi?id=195169
2832
2833         Reviewed by Daniel Bates.
2834
2835         * wpe/install-dependencies:
2836         * wpe/jhbuild.modules:
2837
2838 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2839
2840         [ews-app] Use port 17000 for worker communication
2841         https://bugs.webkit.org/show_bug.cgi?id=195558
2842
2843         Reviewed by Lucas Forschler.
2844
2845         * BuildSlaveSupport/ews-build/master.cfg:
2846
2847 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2848
2849         [ews-build] unit-tests fail when passwords.json is missing
2850         https://bugs.webkit.org/show_bug.cgi?id=195557
2851
2852         Reviewed by Lucas Forschler.
2853
2854         * BuildSlaveSupport/ews-build/loadConfig.py:
2855         (loadBuilderConfig):
2856         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2857         (ConfigDotJSONTest.test_configuration):
2858         * BuildSlaveSupport/ews-build/master.cfg:
2859
2860 2019-03-11  Truitt Savell  <tsavell@apple.com>
2861
2862         Unreviewed, rolling out r242702.
2863
2864         Broke High Sierra builders.
2865
2866         Reverted changeset:
2867
2868         "Add utility function to allow easy reverse range-based
2869         iteration of a container"
2870         https://bugs.webkit.org/show_bug.cgi?id=195542
2871         https://trac.webkit.org/changeset/242702
2872
2873 2019-03-11  Sam Weinig  <sam@webkit.org>
2874
2875         Add utility function to allow easy reverse range-based iteration of a container
2876         https://bugs.webkit.org/show_bug.cgi?id=195542
2877
2878         Reviewed by Antti Koivisto.
2879
2880         * TestWebKitAPI/CMakeLists.txt:
2881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2882         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2883         (TestWebKitAPI::TEST):
2884         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2885
2886 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2887
2888         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2889         https://bugs.webkit.org/show_bug.cgi?id=195511
2890         <rdar://problem/44873269>
2891
2892         Reviewed by Darin Adler.
2893
2894         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2895         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2896         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2897         (TEST_F):
2898
2899 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2900
2901         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2902         https://bugs.webkit.org/show_bug.cgi?id=195499
2903
2904         Reviewed by Darin Adler.
2905
2906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2907         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2908         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2909         (-[WKWebView synchronouslyFocusTextInputContext:]):
2910         (applyStyle):
2911         (applyIframe):
2912         (TEST):
2913         Add some tests for this SPI.
2914
2915 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2916
2917         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2918         https://bugs.webkit.org/show_bug.cgi?id=181151
2919
2920         Reviewed by Don Olmstead.
2921
2922         * TestWebKitAPI/CMakeLists.txt:
2923         * TestWebKitAPI/PlatformWin.cmake:
2924         Enable TestWTF RunLoop tests in all platforms.
2925
2926         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2927         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2928         (TestWebKitAPI::DerivedOneShotTimer::fired):
2929         (TestWebKitAPI::TEST):
2930         Only a few platforms support nested RunLoop.
2931
2932         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2933         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2934
2935 2019-03-10  David Quesada  <david_quesada@apple.com>
2936
2937         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2938         https://bugs.webkit.org/show_bug.cgi?id=152480
2939
2940         Reviewed by Chris Dumez.
2941
2942         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2943         there are no additional references to the process pool besides the one held by
2944         the download, waits for the download to finish (in the sense that the
2945         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2946         measure, also check that the process pool has been deallocated at the end of the
2947         test. The test wouldn't be meaningful if the process pool were still alive.
2948
2949         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2950         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2951         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2952             The download will be canceled because the delegate does not implement the
2953             method to decide the download's destination, so this is where we know the
2954             DownloadProxyMap is done with the DownloadProxy.
2955         (TEST):
2956
2957 2019-03-08  Chris Dumez  <cdumez@apple.com>
2958
2959         Add support for Device Orientation / Motion permission API
2960         https://bugs.webkit.org/show_bug.cgi?id=195329
2961         <rdar://problem/47645367>
2962
2963         Reviewed by Geoffrey Garen.
2964
2965         Add test infrastructure to help test the Device Orientation / Motion permission API.
2966
2967         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2969         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2970         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2971         * WebKitTestRunner/TestController.cpp:
2972         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2973         (WTR::TestController::createWebViewWithOptions):
2974         (WTR::TestController::resetStateToConsistentValues):
2975         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2976         * WebKitTestRunner/TestController.h:
2977         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2978         * WebKitTestRunner/TestInvocation.cpp:
2979         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2980
2981 2019-03-08  Saam barati  <sbarati@apple.com>
2982
2983         Add a compare-results script to compare benchmark results
2984         https://bugs.webkit.org/show_bug.cgi?id=195486
2985         <rdar://problem/48723397>
2986
2987         Reviewed by Geoffrey Garen.
2988
2989         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2990         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2991         to extend it to learn about our other benchmarks.
2992
2993         * Scripts/compare-results: Added.
2994         (readJSONFile):
2995         (detectJetStream2):
2996         (JetStream2Results):
2997         (detectSpeedometer2):
2998         (Speedometer2Results):
2999         (detectPLT5):
3000         (PLT5Results):
3001         (detectBenchmark):
3002         (biggerIsBetter):
3003         (ttest):
3004         (getOptions):
3005         (main):
3006
3007 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3008
3009         Ensure old tab state is cleared between iterations of run-benchmark
3010         https://bugs.webkit.org/show_bug.cgi?id=195393
3011         <rdar://problem/46885583>
3012
3013         Reviewed by Dewei Zhu.
3014
3015         a) ensure the default to restore state is not set
3016         b) terminate Safari correctly
3017         c) Set the system default to ignore Persistent State in Safari
3018
3019         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3020         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3021         (OSXBrowserDriver.prepare_env): 
3022         (OSXBrowserDriver.restore_env):
3023         (OSXBrowserDriver.close_browsers):
3024         (OSXBrowserDriver._terminate_processes):
3025         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3026         (OSXChromeDriver):
3027         (OSXChromeCanaryDriver):
3028         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3029         (OSXFirefoxDriver):
3030         (OSXFirefoxNightlyDriver):
3031         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3032         (OSXSafariDriver):
3033         (OSXSafariDriver.prepare_env):
3034
3035 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3036
3037         [GTK] Several InputMethodFilter tests are failing
3038         https://bugs.webkit.org/show_bug.cgi?id=195408
3039
3040         Reviewed by Carlos Garcia Campos.
3041
3042         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3043         Regressed in r241751.
3044         Hexadecimal values of keycodes are expressed now in upper letters.
3045         Composited characters should be cast to UTF8 strings.
3046
3047         (TestWebKitAPI::TEST):
3048
3049 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3050
3051         [GTK] Make Tools/gtkdoc python3 compatible
3052         https://bugs.webkit.org/show_bug.cgi?id=195359
3053
3054         Reviewed by Carlos Garcia Campos.
3055
3056         * gtkdoc/generate-gtkdoc:
3057         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3058         work with Python 2 and 3.
3059         (get_gtkdoc_module_paths):
3060         The iteritems() was removed in Python 3, so let's use items() that's
3061         available in Python 2 and 3.
3062         (get_generator_for_config):
3063         * gtkdoc/gtkdoc.py:
3064         (GTKDoc._run_command):
3065         The sys.stdout.write() is expecting str in Python 3 and not bytes
3066         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3067         for passing the bytes there.
3068
3069 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3070
3071         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3072         https://bugs.webkit.org/show_bug.cgi?id=195346
3073         <rdar://problem/48667048>
3074
3075         Unreviewed build fix for clang-cl.
3076
3077         * DumpRenderTree/win/DumpRenderTree.cpp:
3078         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3079
3080 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3081
3082         requestAnimationFrame should execute before the next frame
3083         https://bugs.webkit.org/show_bug.cgi?id=177484
3084
3085         Reviewed by Simon Fraser.
3086
3087         Add trace points for the page RenderingUpdate.
3088
3089         * Tracing/SystemTracePoints.plist:
3090
3091 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3092
3093         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3094         https://bugs.webkit.org/show_bug.cgi?id=195353
3095         <rdar://problem/48626394>
3096
3097         Reviewed by Simon Fraser.
3098
3099         * WebKitTestRunner/ios/TestControllerIOS.mm:
3100         (WTR::TestController::platformResetPreferencesToConsistentValues):
3101
3102 2019-03-07  John Wilander  <wilander@apple.com>
3103
3104         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3105         https://bugs.webkit.org/show_bug.cgi?id=195383
3106         <rdar://problem/48570136>
3107
3108         Reviewed by Brent Fulgham.
3109
3110         This patch adds test infrastructure to purge only script-accessible cookies,
3111         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3112
3113         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3114         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3115         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3116         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3117         * WebKitTestRunner/TestController.cpp:
3118         (WTR::TestController::statisticsDeleteCookiesForHost):
3119         * WebKitTestRunner/TestController.h:
3120         * WebKitTestRunner/TestInvocation.cpp:
3121         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3122
3123 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3124
3125         Unreviewed, rolling out r242354.
3126         https://bugs.webkit.org/show_bug.cgi?id=195402
3127
3128         breaks layout tests in all configurations (Requested by
3129         zdobersek on #webkit).
3130
3131         Reverted changeset:
3132
3133         "[WPE] Enable web process sandbox"
3134         https://bugs.webkit.org/show_bug.cgi?id=195169
3135         https://trac.webkit.org/changeset/242354
3136
3137 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3138
3139         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3140         https://bugs.webkit.org/show_bug.cgi?id=195346
3141
3142         Reviewed by Fujii Hironori.
3143
3144         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3145         (TestWebKitAPI::TEST):
3146         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3147
3148         * DumpRenderTree/win/DumpRenderTree.cpp:
3149         (findFontFallback):
3150         (addFontFallbackIfPresent):
3151         (removeFontFallbackIfPresent):
3152         (main):
3153         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3154         (TestWebKitAPI::Util::moduleDirectory):
3155         (TestWebKitAPI::Util::createInjectedBundlePath):
3156         Use wchar helpers as needed.
3157
3158 2019-03-06  Rob Buis  <rbuis@igalia.com>
3159
3160         Consider supporting the `referrerpolicy` attribute.
3161         https://bugs.webkit.org/show_bug.cgi?id=179053
3162
3163         Reviewed by Darin Adler.
3164
3165         Add a runtime flag for referrerpolicy attribute.
3166
3167         * DumpRenderTree/mac/DumpRenderTree.mm:
3168         (enableExperimentalFeatures):
3169
3170 2019-03-05  Daniel Bates  <dabates@apple.com>
3171
3172         Update expected API test result following r242379
3173         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3174
3175         Update expected x-coordinate of selection rect now that the left padding of
3176         a textarea is sized in ems (so dependent on the font size) just like the left
3177         padding of a text field.
3178
3179         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3180         (TestWebKitAPI::TEST):
3181
3182 2019-03-05  David Quesada  <david_quesada@apple.com>
3183
3184         [WK2] It should be possible to follow links with 'download' attributes
3185         https://bugs.webkit.org/show_bug.cgi?id=195145
3186         rdar://problem/48462642
3187
3188         Reviewed by Alex Christensen.
3189
3190         Add a unit test to verify that activating links with 'download' attributes now
3191         navigates to the linked resource, rather than starts downloading it. Add another
3192         to verify that it is still possible to explicitly download the link via the
3193         'Download' navigation action policy.
3194
3195         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3196         (-[DownloadAttributeTestDelegate init]):
3197         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3198         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3199         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3200         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3201         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3202         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3203         (TEST):
3204         * WebKitTestRunner/TestController.cpp:
3205         (WTR::TestController::decidePolicyForNavigationAction):
3206         * WebKitTestRunner/TestController.h:
3207
3208 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3209
3210         [Curl] Implement Cookie Accept Policy.
3211         https://bugs.webkit.org/show_bug.cgi?id=191645
3212
3213         Reviewed by Fujii Hironori.
3214
3215         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3216         (TestWebKitAPI::Curl::TEST_F):
3217
3218 2019-03-05  Youenn Fablet  <youenn@apple.com>
3219
3220         Rename requestCacheStorageSpace to requestStorageSpace
3221         https://bugs.webkit.org/show_bug.cgi?id=195282
3222
3223         Reviewed by Chris Dumez.
3224
3225         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3226         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3227         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3228
3229 2019-03-05  Brady Eidson  <beidson@apple.com>
3230
3231         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3232         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3233
3234         Reviewed by Tim Horton.
3235
3236         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3237         different directory into that same WKWebView should work.
3238
3239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3240         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3241
3242 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3243
3244         Add WeakHashSet
3245         https://bugs.webkit.org/show_bug.cgi?id=195152
3246
3247         Reviewed by Antti Koivisto.
3248
3249         Added tests for WeakHashSet.
3250
3251         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3252         (TestWebKitAPI::Base::Base): Moved.
3253         (TestWebKitAPI::Derived::foo): Moved.
3254         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3255         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3256         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3257         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3258
3259 2019-03-04  Chris Dumez  <cdumez@apple.com>
3260
3261         Do not share WebProcesses between private and regular sessions
3262         https://bugs.webkit.org/show_bug.cgi?id=195189
3263         <rdar://problem/48421064>
3264
3265         Reviewed by Alex Christensen.
3266
3267         Add API test coverage.
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3270         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3271
3272 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3273
3274         [WPE] Enable web process sandbox
3275         https://bugs.webkit.org/show_bug.cgi?id=195169
3276
3277         Reviewed by Daniel Bates.
3278
3279         * wpe/install-dependencies:
3280         * wpe/jhbuild.modules:
3281
3282 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3283
3284         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3285         https://bugs.webkit.org/show_bug.cgi?id=195206
3286
3287         Reviewed by Žan Doberšek.
3288
3289         Add a new test case.
3290
3291         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3292         (testJSCClass):
3293
3294 2019-03-04  Charlie Turner  <cturner@igalia.com>
3295
3296         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3297         https://bugs.webkit.org/show_bug.cgi?id=194898
3298
3299         Reviewed by Žan Doberšek.
3300
3301         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3302         a GCC extension that permits arithmetic on void* pointer. Inline
3303         the macro until this issue is fixed upstream.
3304
3305 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3306
3307         Rid the world of WK_API_ENABLED
3308         https://bugs.webkit.org/show_bug.cgi?id=195263
3309
3310         Reviewed by Dan Bernstein.
3311
3312         List of changed files elided because it's useless.
3313
3314 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3315
3316         Unreviewed follow-up to r242292.
3317
3318         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3319
3320         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3321         (TestWebKitAPI::testStrip): Renamed from strip.
3322         (TestWebKitAPI::TEST):
3323
3324 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3325
3326         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3327
3328         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3329         and bug #194272 for details.
3330
3331         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3332
3333 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3334
3335         Remove some more unused 32-bit code
3336         https://bugs.webkit.org/show_bug.cgi?id=195255
3337
3338         Reviewed by Darin Adler.
3339
3340         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3341         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3342         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3343         (NPP_New):
3344         (NPP_HandleEvent):
3345         (handleEventCarbon): Deleted.
3346
3347 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3348
3349         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3350
3351         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3352         (TestWebKitAPI::TEST):
3353
3354 2019-03-01  Darin Adler  <darin@apple.com>
3355
3356         Finish removing String::format
3357         https://bugs.webkit.org/show_bug.cgi?id=194893
3358
3359         Reviewed by Daniel Bates.
3360 '
3361         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3362
3363 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3364
3365         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3366         https://bugs.webkit.org/show_bug.cgi?id=195229
3367         <rdar://problem/48520362>
3368
3369         Reviewed by Chris Dumez.
3370
3371         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3372         (TEST):
3373
3374 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3375
3376         Add a system trace scope for event region building
3377         https://bugs.webkit.org/show_bug.cgi?id=195226
3378
3379         Reviewed by Jon Lee.
3380
3381         This trace scope measures the time spend converting element rects into Region objects,
3382         which can be large on some pages.
3383
3384         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3385
3386         * Tracing/SystemTracePoints.plist:
3387
3388 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3389
3390         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3391         https://bugs.webkit.org/show_bug.cgi?id=194612
3392
3393         Reviewed by Alex Christensen.
3394
3395         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3396         Just test the new string-processing function and don't touch the actual environment.
3397         (Test cases are all as before, but based on operator== instead of strcmp.)
3398
3399 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3400
3401         [ews-app] Update primary keys for handling multiple Buildbot instances
3402         https://bugs.webkit.org/show_bug.cgi?id=195120
3403
3404         Reviewed by Stephanie Lewis.
3405
3406         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3407         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3408         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3409
3410         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3411         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3412         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3413         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3414         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3415         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3416
3417 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3418
3419         [WinCairo] Enable service worker
3420         https://bugs.webkit.org/show_bug.cgi?id=188318
3421
3422         Reviewed by Youenn Fablet.
3423
3424         * DumpRenderTree/DumpRenderTreePrefix.h:
3425         * TestWebKitAPI/PlatformWin.cmake:
3426         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3427         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3428         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3429
3430 2019-03-01  Justin Fan  <justin_fan@apple.com>
3431
3432         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3433         https://bugs.webkit.org/show_bug.cgi?id=195191
3434
3435         Rubber-stamped by Dean Jackson.
3436
3437         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3438
3439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3440
3441 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3442
3443         Unreviewed, fix lldb webkitpy tests
3444         https://bugs.webkit.org/show_bug.cgi?id=194375
3445
3446         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3447
3448         * lldb/lldb_webkit.py:
3449         (WTFStringImplProvider.is_8bit):
3450
3451 2019-02-28  David Quesada  <david_quesada@apple.com>
3452
3453         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3454         https://bugs.webkit.org/show_bug.cgi?id=195121
3455         rdar://problem/48450302
3456
3457         Reviewed by Alex Christensen.
3458
3459         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3460         configurations where the 'download' attribute is absent, blank, or populated
3461         with a filename, and where the anchor element is same-origin or cross-origin
3462         (meaning the 'download' attribute shouldn't be honored).
3463
3464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3465         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3466         (-[NavigationActionTestDelegate init]):
3467         (-[NavigationActionTestDelegate navigationAction]):
3468         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3469         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3470         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3471         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3472         (TEST):
3473
3474 2019-02-28  Antoine Quint  <graouts@apple.com>
3475
3476         Enable the Pointer Events runtime flag by default
3477         https://bugs.webkit.org/show_bug.cgi?id=195156
3478
3479         Reviewed by Dean Jackson.
3480
3481         * DumpRenderTree/mac/DumpRenderTree.mm:
3482         (enableExperimentalFeatures):
3483
3484 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3485
3486         Several PasteImage API tests are flaky
3487         https://bugs.webkit.org/show_bug.cgi?id=195160
3488
3489         Reviewed by Tim Horton.
3490
3491         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3492         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3493         listening for a "load" event after image load is already complete.
3494
3495         To address this, make these tests first register a "load" event handler, then run script to insert an image
3496         element into the document, and finally wait until the load event is observed before checking image size.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3499
3500 2019-02-28  Chris Dumez  <cdumez@apple.com>
3501
3502         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3503         https://bugs.webkit.org/show_bug.cgi?id=195107
3504
3505         Reviewed by Alex Christensen.
3506
3507         Give some time for the zoom level to get restored.
3508
3509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3510
3511 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3512
3513         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3514         https://bugs.webkit.org/show_bug.cgi?id=194958
3515
3516         Reviewed by Geoffrey Garen.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3519         (TEST):
3520
3521 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3522
3523         [ews-app] Update method to save build to handle builder_display_name
3524         https://bugs.webkit.org/show_bug.cgi?id=195047
3525
3526         Reviewed by Dewei Zhu.
3527
3528         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3529         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3530
3531 2019-02-28  Justin Fan  <justin_fan@apple.com>
3532
3533         [Web GPU] Enable Web GPU only on 64-bit
3534         https://bugs.webkit.org/show_bug.cgi?id=195139
3535
3536         Because Metal is only supported on 64 bit apps.
3537
3538         Unreviewed build fix.
3539
3540         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3541
3542 2019-02-27  Youenn Fablet  <youenn@apple.com>
3543
3544         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3545         https://bugs.webkit.org/show_bug.cgi?id=194959
3546
3547         Reviewed by Chris Dumez.
3548
3549         Spin loop until getting the condition to remove flakiness.
3550
3551         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3552
3553 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3554
3555         [ews-build] Buildbot should include builder_display_name in the build events
3556         https://bugs.webkit.org/show_bug.cgi?id=195045
3557
3558         Reviewed by Dewei Zhu.
3559
3560         * BuildSlaveSupport/ews-build/events.py:
3561         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3562         buildername to builder_name to be consistent in naming style.
3563         (Events.buildFinished): Ditto.
3564
3565 2019-02-27  Chris Dumez  <cdumez@apple.com>
3566
3567         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3568         https://bugs.webkit.org/show_bug.cgi?id=194480
3569
3570         Reviewed by Brady Eidson.
3571
3572         Update existing API test to make it more likely to reproduce the issue.
3573
3574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3575
3576 2019-02-27  Brady Eidson  <beidson@apple.com>
3577
3578         Universal links from Google search results pages don't open the app.
3579         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3580
3581         Reviewed by Geoffrey Garen.
3582
3583         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3584         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3585         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3586         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3587
3588 2019-02-27  Chris Dumez  <cdumez@apple.com>
3589
3590         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3591         https://bugs.webkit.org/show_bug.cgi?id=195102
3592
3593         Reviewed by Geoffrey Garen.
3594
3595         If the number of processes is not yet what we expect, wait a bit and check again to give
3596         processes some time to exit.
3597
3598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3599
3600 2019-02-27  Chris Dumez  <cdumez@apple.com>
3601
3602         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3603         https://bugs.webkit.org/show_bug.cgi?id=194545
3604
3605         Reviewed by Brady Eidson.
3606
3607         Make sure the test navigates forward and then back only once. Previously, navigating
3608         back would trigger a navigation again in a timer.
3609
3610         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3611
3612 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3613
3614         High Sierra Debug JSC test queue should use faster hardware
3615         https://bugs.webkit.org/show_bug.cgi?id=194603
3616
3617         Rubber-stamped by Alexey Proskuryakov.
3618
3619         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3620
3621         * BuildSlaveSupport/build.webkit.org-config/config.json:
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3623         (BubbleQueueServer):
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3625         (WebKitBuildbot):
3626         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3627         * QueueStatusServer/config/queues.py:
3628         * Scripts/webkitpy/common/config/ews.json:
3629         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3630         (test_ews_name):
3631
3632 2019-02-27  John Wilander  <wilander@apple.com>
3633
3634         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3635         https://bugs.webkit.org/show_bug.cgi?id=195071
3636         <rdar://problem/48417690>
3637
3638         Reviewed by Alex Christensen and Brent Fulgham.
3639
3640         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3641         (TestWebKitAPI::createURL):
3642             Convenience function.
3643         (TestWebKitAPI::TEST):
3644             WebCore::AdClickAttribution now takes a URL when creating Source and
3645             Destination.
3646         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3647         (TestWebKitAPI::TEST):
3648             WebCore::AdClickAttribution now takes a URL when creating Source and
3649             Destination.
3650
3651 2019-02-27  Antoine Quint  <graouts@apple.com>
3652
3653         Support Pointer Events on macOS
3654         https://bugs.webkit.org/show_bug.cgi?id=195008
3655         <rdar://problem/47454419>
3656
3657         Reviewed by Dean Jackson.
3658
3659         * DumpRenderTree/mac/DumpRenderTree.mm:
3660         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3661         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3662
3663 2019-02-26  Mark Lam  <mark.lam@apple.com>
3664
3665         Remove remaining poisoning code.
3666         https://bugs.webkit.org/show_bug.cgi?id=194138
3667
3668         Reviewed by Saam Barati.
3669
3670         * TestWebKitAPI/CMakeLists.txt:
3671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3672         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3673         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3674         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3675         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3676         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3677         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3678
3679 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3680
3681         Move ephemeral local storage from WebProcess to UIProcess
3682         https://bugs.webkit.org/show_bug.cgi?id=195074
3683         <rdar://problem/47937975>
3684
3685         Reviewed by Geoff Garen.
3686
3687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3688
3689 2019-02-20  Jer Noble  <jer.noble@apple.com>
3690
3691         [Cocoa] Media elements will restart network buffering just before suspending
3692         https://bugs.webkit.org/show_bug.cgi?id=193691
3693
3694         Reviewed by Eric Carlson.
3695
3696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3698         (TEST):
3699
3700 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3701
3702         [Curl] Load HTTP body of 401 response when AuthenticationChange is&nb