[EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
[WebKit-https.git] / Tools / ChangeLog
1 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
2
3         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
4         https://bugs.webkit.org/show_bug.cgi?id=100757
5
6         Reviewed by Laszlo Gombos.
7
8         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
9         Updating CMake files due to changes from Bug 99011.
10
11         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
12         (WTR::AccessibilityController::AccessibilityController):
13         (WTR):
14         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
15         (AccessibilityController):
16         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
17         (WTR):
18         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
19         (AccessibilityUIElement):
20         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
21         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
22
23 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
24
25         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
26         https://bugs.webkit.org/show_bug.cgi?id=102510
27
28         Reviewed by Pavel Feldman.
29
30         Added missing includes.
31
32         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
33
34 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
35
36         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
37         https://bugs.webkit.org/show_bug.cgi?id=103123
38
39         Reviewed by Kenneth Rohde Christiansen.
40
41         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
42         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
43
44         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
45         test.
46         * TestWebKitAPI/efl/PlatformUtilities.cpp:
47         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
48         test case is passing 0.5 seconds to sleep.
49         * TestWebKitAPI/efl/PlatformWebView.cpp:
50         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
51         (TestWebKitAPI):
52
53 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
54
55         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
56         https://bugs.webkit.org/show_bug.cgi?id=86881
57
58         Reviewed by Kenneth Rohde Christiansen.
59
60         eventSender object extended with contextClick() method in WebKitTestRunner.
61         contextClick() method returns an array of menu items objects with field 'title' containing title of single
62         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
63         delivered in this patch.
64
65         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
66         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
67         (WTR::EventSendingController::contextClick):
68         (WTR):
69         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
70         (EventSendingController):
71
72 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
73
74         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
75         https://bugs.webkit.org/show_bug.cgi?id=102942
76
77         Reviewed by Tor Arne Vestbø.
78
79         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
80         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
81         to follow the same rules as other Qt 5 modules, with the exception that instead of
82         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
83         in other cross-platform header files to determine the correct meaning of export
84         macros.
85
86         * qmake/mkspecs/features/default_post.prf:
87         * qmake/mkspecs/features/win32/default_post.prf:
88
89 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
90
91         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
92         https://bugs.webkit.org/show_bug.cgi?id=103111
93
94         Reviewed by Kenneth Rohde Christiansen.
95
96         This function was added as a slot during Qt 4.x times because adding
97         virtual functions breaks binary compatibility. This constraint is gone
98         with the initial release of WebKit with Qt 5, and therefore we can
99         make it virtual now.
100
101         The change is fully source compatible as existing "re-implementations"
102         as slots will now be called through it being a virtual function. They
103         become unused slots.
104
105         * DumpRenderTree/qt/DumpRenderTreeQt.h:
106         (WebCore::WebPage::shouldInterruptJavaScript):
107         (WebPage):
108         * QtTestBrowser/webpage.h:
109         (WebPage):
110
111 2012-11-22  Peter Beverloo  <peter@chromium.org>
112
113         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
114         https://bugs.webkit.org/show_bug.cgi?id=103065
115
116         Reviewed by Dirk Pranke.
117
118         This addresses two further reliability issues in the Android test running
119         scripts. Firstly, the run_tests.py script needs to have the --exit_code
120         argument passed in order to return non-zero codes, which we need for the
121         build master to distinguish failures from successful runs.
122
123         Secondly, it modifies the layout test runner to briefly wait (through
124         the wait-for-device command) after requesting a device to switch to root
125         mode. Without this waiting period, commands might get lost and thereby
126         unexpectedly fail.
127
128         * Scripts/run-api-tests:
129         * Scripts/run-chromium-webkit-unit-tests:
130         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
131         (ChromiumAndroidDriver._setup_test):
132         (ChromiumAndroidDriver._restart_adb_as_root):
133
134 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
135
136         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
137         https://bugs.webkit.org/show_bug.cgi?id=102800
138
139         Reviewed by Tor Arne Vestbø.
140
141         This patch separates code that needs to use QWidget related APIs in
142         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
143         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
144         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
145         static library. WebKit1 is compiled without QT += widgets and therefore
146         any widget related dependency has been moved "up" and out of WebKit1 into
147         the WebKitWidgets library.
148
149         Between the code in WebKit.a and WebKitWidgets.a new adapters and
150         interfaces have been introduced, such as QWebPageAdapter and
151         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
152         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
153         The other way around if QWebPage wants to access WebCore or
154         WebCoreSupport related functionality, it will go through
155         QWebPageAdapater (as base class). The separation in the direction up
156         into the API layer is complete with this patch, no code in WebKit1
157         depends on QtWidgets. The separation the other way around, code in the
158         API layer not using any WebCore types, is not complete yet.
159
160         Some classes such as QWebSettings, QWebElement or
161         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
162         they do not depend on widget related Qt APIs and they make much more
163         use of WebCore internal APIs and therefore are easier to keep in
164         WebKit1.
165
166         In the future we plan to place a real shared library boundary between
167         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
168         part of the QtWebKit shared library and by turning the WebKitWidgets
169         static library into a shared one.
170
171         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
172         (WebCore::WebPage::resetSettings):
173         (WebCore::WebPage::createWindow):
174         (WebCore::DumpRenderTree::DumpRenderTree):
175         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
176         (WebCore::DumpRenderTree::initJSObjects):
177         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
178         (WebCore::DumpRenderTree::dumpFramesAsText):
179         (WebCore::DumpRenderTree::dump):
180         (WebCore::DumpRenderTree::createWindow):
181         (WebCore::DumpRenderTree::pageAdapter):
182         (WebCore):
183         (WebCore::DumpRenderTree::mainFrameAdapter):
184         * DumpRenderTree/qt/DumpRenderTreeQt.h:
185         (DumpRenderTree):
186         * DumpRenderTree/qt/EventSenderQt.cpp:
187         (EventSender::contextClick):
188         (EventSender::scalePageBy):
189         * DumpRenderTree/qt/TestRunnerQt.cpp:
190         (TestRunner::reset):
191         (TestRunner::display):
192         (TestRunner::closeWebInspector):
193         (TestRunner::showWebInspector):
194         (TestRunner::evaluateInWebInspector):
195         (TestRunner::setFrameFlatteningEnabled):
196         (TestRunner::goBack):
197         (TestRunner::setDefersLoading):
198         (TestRunner::pauseAnimationAtTimeOnElementWithId):
199         (TestRunner::pauseTransitionAtTimeOnElementWithId):
200         (TestRunner::numberOfActiveAnimations):
201         (TestRunner::setCaretBrowsingEnabled):
202         (TestRunner::setAuthorAndUserStylesEnabled):
203         (TestRunner::callShouldCloseOnWebView):
204         (TestRunner::setSmartInsertDeleteEnabled):
205         (TestRunner::setSelectTrailingWhitespaceEnabled):
206         (TestRunner::execCommand):
207         (TestRunner::isCommandEnabled):
208         (TestRunner::findString):
209         (TestRunner::elementDoesAutoCompleteForElementWithId):
210         (TestRunner::setMockDeviceOrientation):
211         (TestRunner::setGeolocationPermission):
212         (TestRunner::numberOfPendingGeolocationPermissionRequests):
213         (TestRunner::setMockGeolocationPositionUnavailableError):
214         (TestRunner::setMockGeolocationPosition):
215         (TestRunner::evaluateScriptInIsolatedWorld):
216         (TestRunner::addUserStyleSheet):
217         (TestRunner::setMinimumTimerInterval):
218         * DumpRenderTree/qt/TextInputControllerQt.cpp:
219         (TextInputController::selectedRange):
220         (TextInputController::firstRectForCharacterRange):
221         (TextInputController::unmarkText):
222         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
223         (LoadAlternateHTMLStringItem::invoke):
224         * qmake/mkspecs/features/default_post.prf:
225         * qmake/mkspecs/features/production_build.prf:
226         * qmake/mkspecs/features/webkit_modules.prf:
227         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
228
229 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
230
231         WebKitTestRunner needs layoutTestController.setCacheModel
232         https://bugs.webkit.org/show_bug.cgi?id=42684
233
234         Reviewed by Kenneth Rohde Christiansen.
235
236         Add support for testRunner.setCacheModel to WebKitTestRunner.
237
238         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
239         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
240         (WTR::InjectedBundle::beginTesting):
241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
242         (WTR::TestRunner::setCacheModel):
243         (WTR):
244         * WebKitTestRunner/InjectedBundle/TestRunner.h:
245         (TestRunner):
246
247 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
248
249         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
250         https://bugs.webkit.org/show_bug.cgi?id=101327
251
252         Reviewed by Simon Hausmann.
253
254         Avoid busy waiting for events in platformRunUntil while making
255         sure we don't change the behavior of modal event loops.
256
257         * WebKitTestRunner/TestController.cpp:
258         (WTR::TestController::~TestController):
259         * WebKitTestRunner/TestController.h:
260         (TestController):
261         * WebKitTestRunner/efl/TestControllerEfl.cpp:
262         (WTR::TestController::platformDestroy):
263         (WTR):
264         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
265         (WTR::TestController::platformDestroy):
266         (WTR):
267         * WebKitTestRunner/mac/TestControllerMac.mm:
268         (WTR::TestController::platformDestroy):
269         (WTR):
270         * WebKitTestRunner/qt/TestControllerQt.cpp:
271         (TestController::RunLoop): Helper class to handle
272         the event loop logic
273         (WTR):
274         (WTR::TestController::RunLoop::RunLoop):
275         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
276         the run loop. This is the appropriate API to push the WaitForMoreEvents
277         flag to QCoreApplication::processEvents and also being able to exit the
278         loop if we have timed out.
279         (WTR::TestController::RunLoop::notifyDone):
280         (WTR::TestController::RunLoop::timerFired):
281         (WTR::TestController::RunLoop::runModal):
282         (WTR::TestController::notifyDone):
283         (WTR::TestController::platformInitialize):
284         (WTR::TestController::platformDestroy):
285         (WTR::TestController::platformRunUntil):
286         (WTR::TestController::runModal):
287         * WebKitTestRunner/win/TestControllerWin.cpp:
288         (WTR::TestController::platformDestroy):
289         (WTR):
290
291 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
292
293         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
294         https://bugs.webkit.org/show_bug.cgi?id=102926
295
296         Reviewed by Kenneth Rohde Christiansen.
297
298         Add missing bits needed by WKPreferences and AboutBlankLoad API
299         tests in the test harness and enable these tests on EFL port.
300
301         * TestWebKitAPI/PlatformEfl.cmake:
302         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
303         (TestWebKitAPI::TEST):
304         * TestWebKitAPI/efl/PlatformUtilities.cpp:
305         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
306         (Util):
307
308 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
309
310         [GTK][WTR] Implement AccessibilityUIElement::stringValue
311         https://bugs.webkit.org/show_bug.cgi?id=102951
312
313         Reviewed by Martin Robinson.
314
315         Implement AccessibilityUIElement::stringValue in the ATK backend
316         in the same manner it is implemented in DumpRenderTree.
317
318         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
319         (WTR::replaceCharactersForResults):
320         (WTR):
321         (WTR::AccessibilityUIElement::stringValue):
322
323 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
324
325         Unreviewed. Adding myself to committers.py.
326
327         * Scripts/webkitpy/common/config/committers.py:
328
329 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
330
331         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
332         https://bugs.webkit.org/show_bug.cgi?id=100061
333
334         Reviewed by Adam Barth.
335
336         On Android we're using a different pixel scaling implementation
337         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
338         platforms. In this mode, we don't make use of device-independent pixels. Device
339         scale factor is provided to WebKit and get merged into page scale factor. Other
340         than that device scale factor should have no effects on rendering.
341
342         * DumpRenderTree/chromium/WebPreferences.cpp:
343         (WebPreferences::applyTo):
344
345 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
346
347         Clear MousePressed state on context menu to avoid initiating a drag
348         https://bugs.webkit.org/show_bug.cgi?id=101786
349
350         Reviewed by Ojan Vafai.
351
352         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
353         (WebTestRunner):
354         (WebTestRunner::EventSender::EventSender):
355         (WebTestRunner::EventSender::contextClick):
356         Only send a MouseUp on Windows. Keep the current mouse pressed state when
357         calling up a context menu.
358
359 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
360
361         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
362         https://bugs.webkit.org/show_bug.cgi?id=102895
363
364         Reviewed by Gyuyoung Kim.
365
366         Change the link order so it wont override the new operator on gtest.
367         Looks like it was crashing because an allocator mismatch (using libc's
368         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
369         the fastMalloc issue.
370
371         * TestWebKitAPI/CMakeLists.txt:
372
373 2012-11-21  Kentaro Hara  <haraken@chromium.org>
374
375         Unreviewed, rolling out r135340.
376         http://trac.webkit.org/changeset/135340
377         https://bugs.webkit.org/show_bug.cgi?id=102492
378
379         It broke Safari's internal build
380
381         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
382         (new):
383         (GenerateModule):
384         (GenerateInterface):
385         (finish):
386
387 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
388
389         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
390         https://bugs.webkit.org/show_bug.cgi?id=101526
391
392         Reviewed by Kenneth Rohde Christiansen.
393
394         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
395
396         * Scripts/webkitperl/FeatureList.pm:
397         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
398
399 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
400
401         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
402         https://bugs.webkit.org/show_bug.cgi?id=102867
403
404         Reviewed by Gyuyoung Kim.
405
406         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
407
408         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
409         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
410         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
411
412         * MiniBrowser/efl/main.c:
413         (on_key_down):
414
415 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
416
417         Unreviewed, rolling out r133859.
418         http://trac.webkit.org/changeset/133859
419         https://bugs.webkit.org/show_bug.cgi?id=102875
420
421         This patch makes API test broken (Requested by gyuyoung on
422         #webkit).
423
424         * Scripts/webkitperl/FeatureList.pm:
425
426 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
427
428         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
429         https://bugs.webkit.org/show_bug.cgi?id=99114
430
431         Reviewed by Gyuyoung Kim.
432
433         Implemented window_create and window_close smartcallback functions.
434
435         * MiniBrowser/efl/main.c:
436         (on_window_create):
437         (on_window_close):
438         (window_create):
439
440 2012-11-20  Ojan Vafai  <ojan@chromium.org>
441
442         Simplify builder filters now that we have lists of which builders run which tests
443         https://bugs.webkit.org/show_bug.cgi?id=102849
444
445         Reviewed by Dirk Pranke.
446
447         We only need filters when we load the same master for multiple groups in the
448         same test type, i.e. when we need to only include some of the builders that run
449         a given test suite on a given master.
450
451         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
452         Now just make it a method on BuilderGroup.
453
454         * TestResultServer/static-dashboards/builders.js:
455         (BuilderGroup.prototype.append):
456         (BuilderGroup.prototype.setup):
457         (BuilderGroup.prototype._defaultBuilder):
458         (BuilderGroup.prototype.master):
459         (requestBuilderList):
460         (isChromiumWebkitTipOfTreeTestRunner):
461         (isChromiumWebkitDepsTestRunner):
462         (loadBuildersList):
463         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
464         (test):
465
466 2012-11-20  Ojan Vafai  <ojan@chromium.org>
467
468         Remove perfav master for webkit_unit_tests and test_shell_tests.
469         There are no bots on this master that run these tests.
470         * TestResultServer/static-dashboards/builders.js:
471
472 2012-11-20  Ojan Vafai  <ojan@chromium.org>
473
474         Remove special case for layout tests when builders fail to load
475         https://bugs.webkit.org/show_bug.cgi?id=102842
476
477         Reviewed by Tony Chang.
478
479         Now that we load only builders that actually run the given test
480         type, we can reliably show errors to the users because it
481         represents a broken bot.
482         * TestResultServer/static-dashboards/loader.js:
483
484 2012-11-15  Ojan Vafai  <ojan@chromium.org>
485
486         Generate a list of builders/test suites from the buildbot json
487         https://bugs.webkit.org/show_bug.cgi?id=102443
488
489         Reviewed by Dirk Pranke.
490
491         Instead of the cludgy things we do now to track which bots run which tests,
492         we generate all that data from the buildbots' json files.
493         This is the minimal amount to keep everything working. Once this lands,
494         we can also do a bunch of followup cleanup.
495
496         For now we commit the generated data. In theory, in the future, we could
497         have the test results server generate the data on the fly.
498
499         For the sake of easily understanding what changes when we run the generate script,
500         also checkin a pretty printed version of the output. The pretty printed version
501         is too large to serve as part of the flakiness dashboard though.
502
503         This also has the benefit of making the dashboard load much faster since
504         we no longer ever need to block on requests to buildbot.
505
506         * TestResultServer/generate_builders_json.py: Added.
507         (master_json_url):
508         (builder_json_url):
509         (cached_build_json_url):
510         (fetch_json):
511         (insert_builder_and_test_data):
512         (main):
513         * TestResultServer/generate_builders_json_unittest.py: Added.
514         (GenerateBuildersJsonTest):
515         (GenerateBuildersJsonTest.test_master_json_url):
516         (GenerateBuildersJsonTest.test_builder_json_url):
517         (GenerateBuildersJsonTest.test_cached_build_json_url):
518         (GenerateBuildersJsonTest.test_generate_json_data):
519         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
520         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
521         * TestResultServer/static-dashboards/builders.js:
522         (LOAD_BUILDBOT_DATA):
523         (BuilderGroup):
524         (BuilderGroup.prototype.append):
525         (BuilderGroup.prototype.master):
526         (requestBuilderList):
527         * TestResultServer/static-dashboards/builders.jsonp: Added.
528         * TestResultServer/static-dashboards/builders_unittests.js: Added.
529         * TestResultServer/static-dashboards/dashboard_base.js:
530         * TestResultServer/static-dashboards/flakiness_dashboard.js:
531         (showPopupForBuild):
532         (htmlForTestResults):
533         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
534         (loadExpectationsLayoutTests):
535         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
536         (resetGlobals):
537         (test):
538         * TestResultServer/static-dashboards/loader.js:
539         * TestResultServer/static-dashboards/loader_unittests.js:
540         * TestResultServer/static-dashboards/run-embedded-unittests.html:
541         * TestResultServer/static-dashboards/run-unittests.html:
542         * TestResultServer/static-dashboards/timeline_explorer.html:
543
544 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
545
546         [WTR][Qt] Enable fixedLayout when needed by the test
547         https://bugs.webkit.org/show_bug.cgi?id=102811
548
549         Reviewed by Kenneth Rohde Christiansen.
550
551         Create a flickable view for CSS Device Adaptation tests. This is
552         crucial for testing them since they will change the size of the
553         viewport.
554
555         * WebKitTestRunner/PlatformWebView.h:
556         (PlatformWebView):
557         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
558         (WTR::PlatformWebView::PlatformWebView):
559         (WTR::PlatformWebView::viewSupportsOptions):
560         (WTR):
561         * WebKitTestRunner/qt/main.cpp:
562         (main):
563
564 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
565
566         [WTR] WebKitTestRunner should be able to run tests using fixed layout
567         https://bugs.webkit.org/show_bug.cgi?id=102517
568
569         Reviewed by Kenneth Rohde Christiansen.
570
571         WTR will now request the creation of a view that has a page using
572         fixed layout for CSS Device Adaptation tests, but this feature might
573         be used in the future by any other test that requires a mobile-like type
574         of viewport (i.e. Viewport META tests should be ported).
575
576         The viewport type of the other tests remains unchanged and is restored
577         when the runner leaves the device-adapt/ folder.
578
579         * WebKitTestRunner/PlatformWebView.h:
580         (PlatformWebView):
581         * WebKitTestRunner/TestInvocation.cpp:
582         (WTR):
583         (WTR::shouldUseFixedLayout):
584         (WTR::updateLayoutType):
585         (WTR::TestInvocation::invoke):
586         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
587         (WTR::PlatformWebView::PlatformWebView):
588         (WTR::PlatformWebView::viewSupportsOptions):
589         (WTR):
590
591 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
592
593         [Qt] REGRESSION(r128174): Fast build path doesn't work now
594         https://bugs.webkit.org/show_bug.cgi?id=100360
595
596         Reviewed by Tor Arne Vestbø.
597
598         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
599
600         * Scripts/webkitdirs.pm:
601         (buildQMakeProjects):
602
603 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
604
605         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
606         https://bugs.webkit.org/show_bug.cgi?id=99011
607
608         Reviewed by Martin Robinson.
609
610         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
611
612         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
613         (WTR::AccessibilityController::logAccessibilityEvents):
614         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
615
616 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
617
618         webkitpy unit tests should run serially when checking code coverage
619         https://bugs.webkit.org/show_bug.cgi?id=102693
620
621         Reviewed by Dirk Pranke.
622
623         When checking code coverage, the unit tests should not be run in parallel
624         as this causes the tracing functions (set via sys.settrace in the coverage
625         module) being overriden, resulting in incorrect coverage reports.
626
627         * Scripts/webkitpy/test/main.py:
628         (Tester._run_tests):
629
630 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
631
632         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
633         https://bugs.webkit.org/show_bug.cgi?id=102704
634
635         Reviewed by Laszlo Gombos.
636
637         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
638
639         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
640         (WTR::initEcoreEvas):
641
642 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
643
644         [garden-o-matic] Switch frontend to use the gardeningserver.
645         https://bugs.webkit.org/show_bug.cgi?id=102712
646
647         Reviewed by Dirk Pranke.
648
649         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
650         using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.
651
652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
658         * Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
659
660 2012-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>
661
662         Unreviewed, rolling out r135172.
663         http://trac.webkit.org/changeset/135172
664         https://bugs.webkit.org/show_bug.cgi?id=102710
665
666         Broke some WebKit2 api tests :( (Requested by japhet on
667         #webkit).
668
669         * DumpRenderTree/chromium/WebViewHost.cpp:
670         (WebViewHost::updateForCommittedLoad):
671
672 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
673
674         [garden-o-matic] Enable serving garden-o-matic with gardeningserver.
675         https://bugs.webkit.org/show_bug.cgi?id=102703
676
677         Reviewed by Ojan Vafai.
678
679         To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
680         from the same origin as the gardening server. This change gently massages the current
681         logic to adapt an extension-sniffing-based approach of identifying static files,
682         rather than requiring an explicit list.
683
684         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
685         (ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
686         (ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.
687         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
688
689 2012-11-19  Ojan Vafai  <ojan@chromium.org>
690
691         Add DOM and HTML watchlists and add myself to a bunch of lists
692         https://bugs.webkit.org/show_bug.cgi?id=102707
693
694         Reviewed by Eric Seidel.
695
696         * Scripts/webkitpy/common/config/watchlist:
697
698 2012-11-19  Jochen Eisinger  <jochen@chromium.org>
699
700         [chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
701         https://bugs.webkit.org/show_bug.cgi?id=102676
702
703         Reviewed by Tony Chang.
704
705         In addition, I've replaced parsePageNumber with the more commonly used
706         cppVariantToInt32, moved abortModal to the list of stubbed out methods,
707         and removed setAutomaticLinkDetectionEnabled which wasn't used
708         anywhere.
709
710         * DumpRenderTree/chromium/DRTTestRunner.cpp:
711         (DRTTestRunner::DRTTestRunner):
712         (DRTTestRunner::reset):
713         (DRTTestRunner::overridePreference):
714         * DumpRenderTree/chromium/DRTTestRunner.h:
715         (DRTTestRunner):
716         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
717         (WebTestRunner::TestRunner::TestRunner):
718         (WebTestRunner::TestRunner::reset):
719         (WebTestRunner):
720         (WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
721         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
722         (WebTestRunner::TestRunner::execCommand):
723         (WebTestRunner::TestRunner::isCommandEnabled):
724         (WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
725         (WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
726         (WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
727         (WebTestRunner::TestRunner::numberOfActiveAnimations):
728         (WebTestRunner::TestRunner::callShouldCloseOnWebView):
729         (WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
730         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
731         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
732         (WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
733         (WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
734         (WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
735         (WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
736         (WebTestRunner::TestRunner::hasCustomPageSizeStyle):
737         (WebTestRunner::TestRunner::forceRedSelectionColors):
738         (WebTestRunner::TestRunner::addUserScript):
739         (WebTestRunner::TestRunner::addUserStyleSheet):
740         (WebTestRunner::TestRunner::startSpeechInput):
741         (WebTestRunner::TestRunner::loseCompositorContext):
742         (WebTestRunner::TestRunner::markerTextForListItem):
743         (WebTestRunner::TestRunner::findString):
744         (WebTestRunner::TestRunner::setMinimumTimerInterval):
745         (WebTestRunner::TestRunner::setAutofilled):
746         (WebTestRunner::TestRunner::setValueForUser):
747         (WebTestRunner::TestRunner::enableFixedLayoutMode):
748         (WebTestRunner::TestRunner::setFixedLayoutSize):
749         (WebTestRunner::TestRunner::selectionAsMarkup):
750         (WebTestRunner::TestRunner::setTextSubpixelPositioning):
751         (WebTestRunner::TestRunner::resetPageVisibility):
752         (WebTestRunner::TestRunner::setPageVisibility):
753         (WebTestRunner::TestRunner::setTextDirection):
754         (WebTestRunner::TestRunner::textSurroundingNode):
755         (WebTestRunner::TestRunner::workerThreadCount):
756         (WebTestRunner::TestRunner::cppVariantToBool):
757         (WebTestRunner::TestRunner::cppVariantToInt32):
758         (WebTestRunner::TestRunner::cppVariantToWebString):
759         (WebTestRunner::TestRunner::cppVariantToWebStringArray):
760         (WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
761         (WebTestRunner::TestRunner::fallbackMethod):
762         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
763         (WebKit):
764         (WebTestRunner::TestRunner::setWebView):
765         (TestRunner):
766         * DumpRenderTree/chromium/TestShell.cpp:
767         (TestShell::createMainWindow):
768         (TestShell::~TestShell):
769
770 2012-11-19  Yusuke Sato  <yusukes@chromium.org>
771
772         [Chromium] Flash cannot receive scroll events when threaded compositing is in use
773         https://bugs.webkit.org/show_bug.cgi?id=101423
774
775         Reviewed by James Robinson.
776
777         Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
778         LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
779         in the future.
780
781         * DumpRenderTree/chromium/TestWebPlugin.cpp:
782         (TestWebPlugin::initialize):
783
784 2012-11-19  Nate Chapin  <japhet@chromium.org>
785
786         Move empty loading to DocumentLoader, simplify FrameLoader::init()
787         https://bugs.webkit.org/show_bug.cgi?id=101512
788
789         Reviewed by Adam Barth.
790
791         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
792         interprets them as a non-empty load. This ensures
793         http/tests/navigation/new-window-redirect-history.html continues to pass
794         in chromium.
795
796         * DumpRenderTree/chromium/WebViewHost.cpp:
797         (WebViewHost::updateForCommittedLoad):
798
799 2012-11-19  Vincent Scheib  <scheib@chromium.org>
800
801         [Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
802         https://bugs.webkit.org/show_bug.cgi?id=96946
803
804         Reviewed by Adam Barth.
805
806         The runtime flag functionality has already been removed.
807         Now that Chromium no longer has a compile dependency on this
808         API, it can be removed as well.
809
810         * DumpRenderTree/chromium/TestShell.cpp:
811         (TestShell::TestShell):
812
813 2012-11-19  Kihong Kwon  <kihong.kwon@samsung.com>
814
815         Add PROXIMITY_EVENTS feature
816         https://bugs.webkit.org/show_bug.cgi?id=102658
817
818         Reviewed by Kentaro Hara.
819
820         Add PROXIMITY_EVENTS feature to FeatureList and qmake.
821
822         * Scripts/webkitperl/FeatureList.pm:
823         * qmake/mkspecs/features/features.pri:
824
825 2012-11-19  Christophe Dumez  <christophe.dumez@intel.com>
826
827         [WK2][WTR] Memory leak in TestController::initialize()
828         https://bugs.webkit.org/show_bug.cgi?id=102616
829
830         Reviewed by Kenneth Rohde Christiansen.
831
832         Remove call to WKStringCreateWithUTF8CString() to construct
833         the icon database path which was leaking memory since the
834         returned WKStringRef was not adopted. The code now uses
835         WTF::String instead of std::string and converts it to a
836         WKStringRef using toWK().
837
838         * WebKitTestRunner/StringFunctions.h:
839         (WTR::toWK): Overload toWK() to take a WTF::String in
840         argument.
841         (WTR):
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::TestController::initialize):
844
845 2012-11-19  Kentaro Hara  <haraken@chromium.org>
846
847         Remove IDLStructure.pm
848         https://bugs.webkit.org/show_bug.cgi?id=102642
849
850         Reviewed by Adam Barth.
851
852         Previously IDLStructure.pm was full of regular expressions to
853         parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
854         just contains several data structures for the IDL parser. We can
855         move them to IDLParser.pm and thus remove IDLStructure.pm.
856
857         No tests. No change in generated code.
858
859         * WebKitTestRunner/DerivedSources.make:
860         * WebKitTestRunner/GNUmakefile.am:
861         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
862
863 2012-11-18  KyungTae Kim  <ktf.kim@samsung.com>
864
865         [EFL] Not to include "ewk_view_private.h" in Tools
866         https://bugs.webkit.org/show_bug.cgi?id=102644
867
868         Reviewed by Gyuyoung Kim.
869
870         Include ewk_view.h instead of ewk_view_private.h in Tools
871
872         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
873
874 2012-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
875
876         Unreviewed, rolling out r135104.
877         http://trac.webkit.org/changeset/135104
878         https://bugs.webkit.org/show_bug.cgi?id=102638
879
880         Should not use commit queue to add people to committer list.
881         (Requested by ap_ on #webkit).
882
883         * Scripts/webkitpy/common/config/committers.py:
884
885 2012-11-18  Vivek Galatage  <vivek.vg@samsung.com>
886
887         Add myself to committers.py
888         https://bugs.webkit.org/show_bug.cgi?id=102636
889
890         Reviewed by Laszlo Gombos.
891
892         Add myself to committers.py
893
894         * Scripts/webkitpy/common/config/committers.py:
895
896 2012-11-18  Genevieve Mak  <gmak@rim.com>
897
898         [BlackBerry] Enable Touch Sliders
899         https://bugs.webkit.org/show_bug.cgi?id=102516
900
901         Reviewed by Rob Buis.
902
903         Enabled for BlackBerry only
904         PR #242781
905         PR #176014
906
907         * Scripts/webkitperl/FeatureList.pm:
908
909 2012-11-17  Dimitri Glazkov  <dglazkov@chromium.org>
910
911         Remove unused code I wrote a long time ago from gardeningserver.py
912         https://bugs.webkit.org/show_bug.cgi?id=102605
913
914         Reviewed by Adam Barth.
915
916         * Scripts/webkitpy/tool/servers/gardeningserver.py: Removed.
917         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Removed.
918
919 2012-11-16  Tony Chang  <tony@chromium.org>
920
921         Remove ENABLE_CSS_HIERARCHIES since it's no longer in use
922         https://bugs.webkit.org/show_bug.cgi?id=102554
923
924         Reviewed by Andreas Kling.
925
926         As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 ,
927         we're going to revist this feature once additional vendor support is
928         achieved.
929
930         * Scripts/webkitperl/FeatureList.pm:
931
932 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
933
934         [chromium] move stubs from DRTTestRunner to TestRunner
935         https://bugs.webkit.org/show_bug.cgi?id=102489
936
937         Reviewed by Adam Barth.
938
939         This is part of moving all methods from DRTTestRunner to TestRunner.
940         Instead of keeping one stub per method, I'm using a shared stub to
941         clean up the code.
942
943         * DumpRenderTree/chromium/DRTTestRunner.cpp:
944         (DRTTestRunner::DRTTestRunner):
945         * DumpRenderTree/chromium/DRTTestRunner.h:
946         (DRTTestRunner):
947         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
948         (WebTestRunner::TestRunner::TestRunner):
949         (WebTestRunner):
950         (WebTestRunner::TestRunner::fallbackMethod):
951         (WebTestRunner::TestRunner::notImplemented):
952         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
953         (WebTestRunner):
954         (TestRunner):
955         (WebTestRunner::TestRunner::setDelegate):
956         * DumpRenderTree/chromium/TestShell.cpp:
957         (TestShell::createMainWindow):
958         (TestShell::~TestShell):
959
960 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
961
962         [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost
963         https://bugs.webkit.org/show_bug.cgi?id=102495
964
965         Reviewed by Adam Barth.
966
967         When a drag operation is initiated in a layout test, we need to
968         simulate a corresponding drop event, otherwise the WebViewImpl will sit
969         there waiting for it. Instead of having the embedder taking care of
970         this, move this into the TestRunner library.
971
972         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
973         (WebKit):
974         (WebTestProxyBase):
975         (WebTestRunner::WebTestProxy::startDragging):
976         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
977         (WebTestRunner::WebTestProxyBase::startDragging):
978         (WebTestRunner):
979         * DumpRenderTree/chromium/WebViewHost.cpp:
980         * DumpRenderTree/chromium/WebViewHost.h:
981         (WebViewHost):
982
983 2012-11-16  Tien-Ren Chen  <trchen@chromium.org>
984
985         Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor
986         https://bugs.webkit.org/show_bug.cgi?id=102462
987
988         Reviewed by James Robinson.
989
990         As we no longer have this "default" device scale factor.
991
992         * DumpRenderTree/chromium/WebPreferences.cpp:
993         (WebPreferences::applyTo):
994
995 2012-11-15  Takashi Sakamoto  <tasak@google.com>
996
997         [Win] key event's location does not work on Windows platform.
998         https://bugs.webkit.org/show_bug.cgi?id=89742
999
1000         Reviewed by Brent Fulgham.
1001
1002         Modified keyDownCallback to use lparam to specify left-hand keys or
1003         right-hand keys.
1004
1005         * DumpRenderTree/win/EventSender.cpp:
1006         (makeKeyDataForScanCode):
1007         Given a virtual keycode, generate scancode and extended key bit of
1008         lparam.
1009         (keyDownCallback):
1010         Use lparam for left-hand and right-hand keys, because Windows doesn't
1011         directly provide a virtual keycode which distinguishes between
1012         left-hand and right-hand. For example, when control key is pressed,
1013         wparam has VK_CONTROL, neither VK_RCONTROL nor VK_LCONTROL.
1014
1015 2012-11-16  Tommy Widenflycht  <tommyw@google.com>
1016
1017         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
1018         https://bugs.webkit.org/show_bug.cgi?id=102386
1019
1020         Reviewed by Adam Barth.
1021
1022         Adding mock data channel functionality.
1023
1024         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1025         (MockWebRTCPeerConnectionHandler::openDataChannel):
1026
1027 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
1028
1029         [chromium] delete unused testRunner methods
1030         https://bugs.webkit.org/show_bug.cgi?id=102479
1031
1032         Reviewed by Adam Barth.
1033
1034         These methods aren't used by any layout test. Remove them to avoid bit rot
1035
1036         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1037         (DRTTestRunner::DRTTestRunner):
1038         (DRTTestRunner::reset):
1039         * DumpRenderTree/chromium/DRTTestRunner.h:
1040         (DRTTestRunner):
1041         * DumpRenderTree/chromium/WebViewHost.cpp:
1042         (WebViewHost::shouldBeginEditing):
1043         (WebViewHost::shouldEndEditing):
1044         (WebViewHost::shouldInsertNode):
1045         (WebViewHost::shouldInsertText):
1046         (WebViewHost::shouldChangeSelectedRange):
1047         (WebViewHost::shouldDeleteRange):
1048         (WebViewHost::shouldApplyStyle):
1049         (WebViewHost::startDragging):
1050         (WebViewHost::enterFullScreenNow):
1051         (WebViewHost::exitFullScreenNow):
1052
1053 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
1054
1055         Private Browsing is a per-page setting that sets a global value
1056         https://bugs.webkit.org/show_bug.cgi?id=67870
1057
1058         Reviewed by Sam Weinig.
1059
1060         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1061         Call _switchNetworkLoaderToNewTestingSession before making other settings, so that
1062         they would actually apply to the testing session.
1063
1064         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1065         (WTR::InjectedBundle::initialize):
1066         (WTR::InjectedBundle::beginTesting):
1067         Only call WKBundleSwitchNetworkLoaderToNewTestingSession once per process, matching
1068         WebKit1. I'm not fully sure what is going wrong, but apparently creating mutiple
1069         sessions with the same identifier doesn't quite work.
1070
1071 2012-11-16  Yael Aharon  <yael.aharon@intel.com>
1072
1073         Unreviewed. Help bugzilla find me.
1074
1075         * Scripts/webkitpy/common/config/committers.py:
1076
1077 2012-11-16  Peter Beverloo  <peter@chromium.org>
1078
1079         Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
1080         https://bugs.webkit.org/show_bug.cgi?id=102245
1081
1082         Reviewed by Tony Chang.
1083
1084         When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
1085         the actual running part to the test runner which lives on the Chromium side.
1086         Re-implementing or even generalizing the device-interaction part in WebKit
1087         is error prone and not worth the effort.
1088
1089         * Scripts/run-api-tests:
1090         * Scripts/run-chromium-webkit-unit-tests:
1091
1092 2012-11-15  Yury Semikhatsky  <yurys@chromium.org>
1093
1094         Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
1095         https://bugs.webkit.org/show_bug.cgi?id=102384
1096
1097         Reviewed by Pavel Feldman.
1098
1099         Updated return type in accord with the changes in MemoryInstrumentationClient.
1100
1101         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1102
1103 2012-11-15  Gustavo Noronha Silva  <gns@gnome.org>
1104
1105         [GTK] Split WebCore/platform into a separate library
1106         https://bugs.webkit.org/show_bug.cgi?id=94435
1107
1108         Reviewed by Martin Robinson.
1109
1110         More people have been reporting problems when linking WebCore because
1111         the command line limit is being exceeded. Splitting WebCore a bit more
1112         is in order.
1113
1114         * GNUmakefile.am: link libWebCorePlatform into DRT
1115
1116 2012-11-15  Dana Jansens  <danakj@chromium.org>
1117
1118         [chromium] Stop using the WebCompositorSupport methods for changing settings
1119         https://bugs.webkit.org/show_bug.cgi?id=101968
1120
1121         Reviewed by James Robinson.
1122
1123         * DumpRenderTree/chromium/TestShell.cpp:
1124         * DumpRenderTree/chromium/TestShell.h:
1125         (TestShell::setPerTilePaintingEnabled):
1126         (TestShell::setAcceleratedAnimationEnabled):
1127
1128 2012-11-15  Tony Chang  <tony@chromium.org>
1129
1130         Generate Settings from a .in file
1131         https://bugs.webkit.org/show_bug.cgi?id=100393
1132
1133         Reviewed by Adam Barth.
1134
1135         Add the generated WebCore files to the include dir.
1136
1137         * TestWebKitAPI/CMakeLists.txt:
1138         * WebKitTestRunner/CMakeLists.txt:
1139
1140 2012-11-15  Roger Fong  <roger_fong@apple.com>
1141
1142         Make old-run-webkit-tests handle setting the results directory properly.
1143         https://bugs.webkit.org/show_bug.cgi?id=102273
1144         <rdar://problem/11571607>
1145
1146         Reviewed by Timothy Horton.
1147
1148         A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder.
1149         Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder.
1150         This caused many other problems including failure to upload test results and failed future test runs.
1151         The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory 
1152         using the saved directory when setting $testResultsDirectory.
1153
1154         * Scripts/old-run-webkit-tests:
1155
1156 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1157
1158         Unreviewed, rolling out r134800 and r134805.
1159         http://trac.webkit.org/changeset/134800
1160         http://trac.webkit.org/changeset/134805
1161         https://bugs.webkit.org/show_bug.cgi?id=102417
1162
1163         This patch broke chromium port (Requested by jianli on
1164         #webkit).
1165
1166         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1167         (MockWebRTCPeerConnectionHandler::openDataChannel):
1168
1169 2012-11-15  Tommy Widenflycht  <tommyw@google.com>
1170
1171         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
1172         https://bugs.webkit.org/show_bug.cgi?id=102386
1173
1174         Reviewed by Adam Barth.
1175
1176         Adding mock data channel functionality.
1177
1178         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1179         (MockWebRTCPeerConnectionHandler::openDataChannel):
1180
1181 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1182
1183         Unreviewed, rolling out r134649 and r134665.
1184         http://trac.webkit.org/changeset/134649
1185         http://trac.webkit.org/changeset/134665
1186         https://bugs.webkit.org/show_bug.cgi?id=102413
1187
1188         Broke a ton of downstream chromium tests (Requested by japhet
1189         on #webkit).
1190
1191         * DumpRenderTree/chromium/WebViewHost.cpp:
1192         (WebViewHost::updateForCommittedLoad):
1193
1194 2012-11-15  Andreas Kling  <akling@apple.com>
1195
1196         Update my e-mail address.
1197
1198         Rubber-stamped by Anders Koivisto.
1199
1200         * Scripts/webkitpy/common/config/committers.py:
1201
1202 2012-11-15  Dominik Röttsches  <dominik.rottsches@intel.com>
1203
1204         [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
1205         https://bugs.webkit.org/show_bug.cgi?id=101323
1206
1207         Reviewed by Martin Robinson.
1208
1209         Bumping Harfbuzz to newer version so that we can remove the
1210         ifdef round the fix for bug 101009 for EFL, too.
1211         We're using the zip snapshot since jhbuild can fallback to the previously
1212         downloaded blob in case of network failures which leads to better
1213         buildbot robustness. This zip snapshot currently needs to be locally
1214         patched to fix ICU detection on systems that don't have icu pkg-config files.
1215         The patch is suggested for merging into HarfBuzz. We can remove it locally
1216         once it's accepted into HarfBuzz upstream.
1217
1218         * efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
1219         * efl/jhbuild.modules: Bumping harfbuzz version.
1220
1221 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
1222
1223         [Mac] Implement WTR --no-timeout-at-all option
1224         https://bugs.webkit.org/show_bug.cgi?id=102251
1225
1226         Reviewed by Eric Carlson.
1227
1228         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
1229         Just do it, and convert to Objective C on the way for simplicity.
1230
1231 2012-11-14  Ryuan Choi  <ryuan.choi@gmail.com>
1232
1233         [EFL] Port tiled backing store
1234         https://bugs.webkit.org/show_bug.cgi?id=71352
1235
1236         Reviewed by Gyuyoung Kim.
1237
1238         * EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
1239         (_User_Arguments):
1240         (windowCreate):
1241         (parseUserArguments):
1242
1243 2012-11-14  Andy Estes  <aestes@apple.com>
1244
1245         Fix the build.
1246
1247         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1248
1249 2012-11-14  Dirk Pranke  <dpranke@chromium.org>
1250
1251         webkitpy: consolidate webkit-base-finding code
1252         https://bugs.webkit.org/show_bug.cgi?id=102007
1253
1254         Reviewed by Eric Seidel.
1255
1256         This patch creates a new "WebKitFinder" class that other
1257         modules can use to find the top of the WebKit tree and
1258         commonly used subdirectories. This logic was in the
1259         webkitpy.layout_test.port classes but wasn't specific to those
1260         classes and now can be used by other modules without needing a port
1261         (e.g., by the check-webkit-style python linter).
1262
1263         This code is somewhat redundant with the code for find_checkout_root()
1264         in the scm modules, but it does not rely on the presence of a version
1265         control system to work. This is a requirement for some uses of the
1266         tree (e.g., Chromium tester checkouts).
1267
1268         This patch removes most of the logic from the layout_tests.port.config
1269         module and makes that as private as possible. Now we just need to move
1270         the default_configuration and flag_from_configuration logic into
1271         DeprecatedPort (or someplace else appropriate) and we can finish
1272         getting rid of the Config class (but that is a separate patch).
1273
1274         * Scripts/webkitpy/common/webkit_finder.py: Added.
1275         (WebKitFinder):
1276         (WebKitFinder.__init__):
1277         (WebKitFinder.webkit_base):
1278         (WebKitFinder.path_from_webkit_base):
1279         (WebKitFinder.path_to_script):
1280         (WebKitFinder.layout_tests_dir):
1281         (WebKitFinder.perf_tests_dir):
1282         * Scripts/webkitpy/layout_tests/port/base.py:
1283         (Port.__init__):
1284         (Port):
1285         (Port.webkit_base):
1286         (Port.path_from_webkit_base):
1287         (Port.path_to_script):
1288         (Port.layout_tests_dir):
1289         (Port.perf_tests_dir):
1290         (Port.set_option_default):
1291         (Port._run_script):
1292         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1293         (PortTest.test_diff_text):
1294         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1295         (ChromiumLinuxPort._determine_driver_path_statically):
1296         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1297         * Scripts/webkitpy/layout_tests/port/config.py:
1298         (Config.__init__):
1299         (Config.build_directory):
1300         (Config.default_configuration):
1301         (Config._read_configuration):
1302         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
1303         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1304         (ConfigTest.test_default_configuration__standalone):
1305         (ConfigTest.test_default_configuration__scripterror):
1306         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1307         (DriverTest.make_port):
1308         (DriverTest.test_no_timeout):
1309         * Scripts/webkitpy/layout_tests/port/gtk.py:
1310         (GtkPort.setup_environ_for_server):
1311         * Scripts/webkitpy/layout_tests/port/mac.py:
1312         (MacPort.show_results_html_file):
1313         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1314         (TestWebKitPort.__init__):
1315         (PortTestCase.make_port):
1316         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1317         (WinPortTest.test_expectations_files):
1318         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1319         (XvfbDriverTest.make_driver):
1320         (XvfbDriverTest.test_stop):
1321         * Scripts/webkitpy/style/checkers/python.py:
1322         (Pylinter.__init__):
1323
1324 2012-11-14  Dana Jansens  <danakj@chromium.org>
1325
1326         [chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
1327         https://bugs.webkit.org/show_bug.cgi?id=102296
1328
1329         Reviewed by James Robinson.
1330
1331         These settings are always set by TestShell anyhow, but we should be
1332         setting them to false here along with everything else.
1333
1334         * DumpRenderTree/chromium/WebPreferences.cpp:
1335         (WebPreferences::reset):
1336
1337 2012-11-08  Andy Estes  <aestes@apple.com>
1338
1339         [WebKit2] Need API in UIProcess to enable loading of custom protocols
1340         https://bugs.webkit.org/show_bug.cgi?id=101674
1341
1342         Reviewed by Brady Eidson.
1343
1344         Add an API test that implements a custom protocol and attempts to load
1345         a resource requiring that protocol in a WKView. The test passes only if
1346         didFinishLoadForFrame: fires.
1347
1348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1349         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Added.
1350         (+[TestProtocol canInitWithRequest:]):
1351         (+[TestProtocol canonicalRequestForRequest:]):
1352         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1353         (-[TestProtocol startLoading]):
1354         (-[TestProtocol stopLoading]):
1355         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1356         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
1357         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
1358         (-[TestBrowsingContextLoadDelegate initWithBlockToRunOnLoad:]):
1359         (-[TestBrowsingContextLoadDelegate browsingContextControllerDidFinishLoad:]):
1360
1361 2012-11-14  Ojan Vafai  <ojan@chromium.org>
1362
1363         Fix some defuct flakiness dashboard unittests.
1364         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1365
1366 2012-11-14  Glenn Adams  <glenn@skynav.com>
1367
1368         webkitpy: print-expectations - add --paths option to print only paths of test expectation files
1369         https://bugs.webkit.org/show_bug.cgi?id=102269
1370
1371         Reviewed by Dirk Pranke.
1372
1373         Add --paths option to print-expectations command in order to obtain list of applicable
1374         test expectation file paths.
1375
1376         * Scripts/webkitpy/tool/commands/queries.py:
1377         (PrintExpectations.__init__):
1378         (PrintExpectations.execute):
1379         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1380         (PrintExpectationsTest.run_test):
1381         (PrintExpectationsTest.test_paths):
1382
1383 2012-11-14  James Robinson  <jamesr@chromium.org>
1384
1385         webgl-background-color.html started failing
1386         https://bugs.webkit.org/show_bug.cgi?id=102247
1387
1388         Reviewed by Adrienne Walker.
1389
1390         The compositor thread should outlive the WebView.
1391
1392         * DumpRenderTree/chromium/TestShell.h:
1393         (TestShell):
1394
1395 2012-11-14  Nate Chapin  <japhet@chromium.org>
1396
1397         Move empty loading to DocumentLoader, simplify FrameLoader::init()
1398         https://bugs.webkit.org/show_bug.cgi?id=101512
1399
1400         Reviewed by Adam Barth.
1401
1402         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
1403         interprets them as a non-empty load. This ensures
1404         http/tests/navigation/new-window-redirect-history.html continues to pass
1405         in chromium.
1406
1407         * DumpRenderTree/chromium/WebViewHost.cpp:
1408         (WebViewHost::updateForCommittedLoad):
1409
1410 2012-11-14  Zan Dobersek  <zandobersek@gmail.com>
1411
1412         Remove uses of deprecated unittest.TestCase aliases
1413         https://bugs.webkit.org/show_bug.cgi?id=102253
1414
1415         Reviewed by Dirk Pranke.
1416
1417         Replace the deprecated unittest.TestCase methods with the corresponding methods
1418         everywhere inside the Tools directory. The following replacements are done:
1419         - assertEquals -> assertEqual
1420         - assert_ -> assertTrue
1421         - failUnlessRaises -> assertRaises
1422
1423         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1424         (SVNMirrorTest.test_CheckOutSource):
1425         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1426         (QueuePropertyMixinTest.test_queue_property):
1427         * QueueStatusServer/model/queues_unittest.py:
1428         (QueueTest._assert_short_name):
1429         (QueueTest._assert_display_name):
1430         (QueueTest._assert_name_with_underscores):
1431         * QueueStatusServer/model/workitems_unittest.py:
1432         (WorkItemsTest.test_display_position_for_attachment):
1433         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1434         (test_parse_log_entries_from_changelog):
1435         (test_parse_log_entries_from_annotated_file):
1436         (_assert_parse_reviewer_text_and_list):
1437         (_assert_parse_reviewer_text_list):
1438         (_assert_fuzzy_reviewer_match):
1439         (_assert_parse_authors):
1440         (test_latest_entry_parse):
1441         (test_latest_entry_parse_single_entry):
1442         (test_set_reviewer):
1443         (test_set_short_description_and_bug_url):
1444         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1445         (DiffParserTest.test_diff_parser):
1446         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1447         (GitSVNTest.test_revisions_changing_files_with_local_commit):
1448         (GitSVNTest.test_upstream_branch):
1449         (GitSVNTest.test_create_patch_with_rm_and_changed_files):
1450         (GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
1451         * Scripts/webkitpy/common/config/ports_unittest.py:
1452         (DeprecatedPortTest.test_mac_port):
1453         (DeprecatedPortTest.test_gtk_port):
1454         (DeprecatedPortTest.test_efl_port):
1455         (DeprecatedPortTest.test_qt_port):
1456         (DeprecatedPortTest.test_chromium_port):
1457         (DeprecatedPortTest.test_chromium_android_port):
1458         (DeprecatedPortTest.test_chromium_xvfb_port):
1459         * Scripts/webkitpy/common/config/urls_unittest.py:
1460         (URLsTest.test_parse_bug_id):
1461         (URLsTest.test_parse_attachment_id):
1462         * Scripts/webkitpy/common/find_files_unittest.py:
1463         (TestWinNormalize.assert_filesystem_normalizes):
1464         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1465         (test_url_creation):
1466         (test_parse_bug_id):
1467         (_assert_dictionaries_equal):
1468         (test_parse_bugs_from_xml):
1469         (test_attachment_detail_bug_parsing):
1470         (_assert_result_count):
1471         (test_request_page_parsing):
1472         (test_quip_page_parsing):
1473         (EditUsersParserTest._assert_login_userid_pairs):
1474         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1475         (test_status_parsing):
1476         (test_latest_cached_build):
1477         (test_results_zip_url):
1478         * Scripts/webkitpy/common/net/credentials_unittest.py:
1479         (test_credentials_from_environment):
1480         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1481         (FailureMapTest.test_failing_revisions):
1482         (FailureMapTest.test_new_failures):
1483         (FailureMapTest.test_new_failures_with_old_revisions):
1484         (FailureMapTest.test_new_failures_with_more_old_revisions):
1485         (FailureMapTest.test_tests_failing_for):
1486         (FailureMapTest.test_failing_tests):
1487         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1488         (LayoutTestResultsTest.test_set_failure_limit_count):
1489         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1490         (UnitTestResultsTest.test_nostring):
1491         (UnitTestResultsTest.test_emptystring):
1492         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1493         (ReadChecksumFromPngTest.test_read_checksum):
1494         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
1495         (LoggingTest.assert_log_equals):
1496         * Scripts/webkitpy/common/system/executive_unittest.py:
1497         (ScriptErrorTest.test_string_from_args):
1498         (ScriptErrorTest.test_message_with_output):
1499         (ExecutiveTest.test_run_command_with_bad_command):
1500         (ExecutiveTest.test_run_command_with_unicode):
1501         (ExecutiveTest.serial_test_run_in_parallel):
1502         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1503         (MockFileSystemTest.quick_check):
1504         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1505         (GenericFileSystemTests.test_glob__trailing_asterisk):
1506         (GenericFileSystemTests.test_glob__leading_asterisk):
1507         (GenericFileSystemTests.test_glob__middle_asterisk):
1508         (GenericFileSystemTests.test_glob__period_is_escaped):
1509         (RealFileSystemTest.test_chdir):
1510         (RealFileSystemTest.test_remove_file_with_retry):
1511         (RealFileSystemTest.test_sep):
1512         * Scripts/webkitpy/common/system/logtesting.py:
1513         (TestLogStream.assertMessages):
1514         * Scripts/webkitpy/common/system/logutils_unittest.py:
1515         (GetLoggerTest.test_get_logger_in_webkitpy):
1516         (GetLoggerTest.test_get_logger_not_in_webkitpy):
1517         * Scripts/webkitpy/common/system/outputcapture.py:
1518         (OutputCaptureTestCaseBase.assertStdout):
1519         (OutputCaptureTestCaseBase.assertStderr):
1520         * Scripts/webkitpy/common/system/path_unittest.py:
1521         (AbspathTest.test_abspath_to_uri_cygwin):
1522         (AbspathTest.test_abspath_to_uri_unixy):
1523         (AbspathTest.test_abspath_to_uri_win):
1524         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1525         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1526         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1527         (TestPlatformInfo.test_real_code):
1528         (TestPlatformInfo.test_os_name_and_wrappers):
1529         (TestPlatformInfo.test_os_version):
1530         (TestPlatformInfo.test_total_bytes_memory):
1531         * Scripts/webkitpy/common/system/user_unittest.py:
1532         (UserTest.test_confirm.mock_raw_input):
1533         (UserTest.test_confirm):
1534         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1535         (ZipFileSetTest.test_open):
1536         (ZipFileSetTest.test_read):
1537         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1538         (WatchListTest.test_filename_definition_no_matches):
1539         (WatchListTest.test_filename_definition):
1540         (WatchListTest.test_cc_rules_simple):
1541         (WatchListTest.test_cc_rules_complex):
1542         (WatchListTest.test_cc_and_message_rules_complex):
1543         (WatchListTest.test_cc_and_message_rules_no_matches):
1544         (WatchListTest.test_added_match):
1545         (WatchListTest.test_deleted_match):
1546         (WatchListTest.test_more_and_less_match):
1547         (WatchListTest.test_complex_match):
1548         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1549         (LockCheckingRunner.handle_finished_list):
1550         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1551         (LayoutTestRunnerTests.test_update_summary_with_result):
1552         (LayoutTestRunnerTests.test_servers_started):
1553         (SharderTests.assert_shards):
1554         (SharderTests.test_shard_in_two_has_no_locked_shards):
1555         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
1556         (NaturalCompareTest.assert_cmp):
1557         (KeyCompareTest.assert_cmp):
1558         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1559         (TestConfigurationTest.test_items):
1560         (TestConfigurationTest.test_keys):
1561         (TestConfigurationTest.test_str):
1562         (TestConfigurationTest.test_repr):
1563         (TestConfigurationTest.test_hash):
1564         (TestConfigurationTest.test_eq):
1565         (TestConfigurationTest.test_values):
1566         (SpecifierSorterTest.test_init):
1567         (SpecifierSorterTest.test_add_specifier):
1568         (SpecifierSorterTest.test_add_macros):
1569         (SpecifierSorterTest.test_category_priority):
1570         (SpecifierSorterTest.test_specifier_priority):
1571         (SpecifierSorterTest.test_sort_specifiers):
1572         (TestConfigurationConverterTest.test_symmetric_difference):
1573         (TestConfigurationConverterTest.test_to_config_set):
1574         (TestConfigurationConverterTest.test_macro_expansion):
1575         (TestConfigurationConverterTest.test_to_specifier_lists):
1576         (TestConfigurationConverterTest.test_macro_collapsing):
1577         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1578         (TestConfigurationConverterTest.test_specifier_converter_access):
1579         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1580         (assert_exp):
1581         (MiscTests.test_result_was_expected):
1582         (MiscTests.test_remove_pixel_failures):
1583         (MiscTests.test_suffixes_for_expectations):
1584         (MiscTests.test_get_expectations_string):
1585         (SkippedTests.check):
1586         (ExpectationSyntaxTests.assert_tokenize_exp):
1587         (SemanticTests.test_bad_bugid):
1588         (SemanticTests.test_missing_bugid):
1589         (TestExpectationSerializationTests.test_reconstitute_only_these):
1590         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1591         (TestFailuresTest.test_crashes):
1592         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1593         (PortTest.test_nonexistant_expectations):
1594         (PortTest.test_additional_expectations):
1595         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1596         (BuildersTest.test_path_from_name):
1597         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1598         (ChromiumAndroidPortTest.test_attributes):
1599         (ChromiumAndroidPortTest.test_default_timeout_ms):
1600         (ChromiumAndroidPortTest.test_get_devices_one_device):
1601         (ChromiumAndroidPortTest.test_get_devices_two_devices):
1602         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
1603         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
1604         (ChromiumAndroidPortTest.test_must_require_http_server):
1605         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
1606         (ChromiumAndroidDriverTest.test_get_crash_log):
1607         (ChromiumAndroidDriverTest.test_cmd_line):
1608         (ChromiumAndroidDriverTest.test_read_prompt):
1609         (ChromiumAndroidDriverTest.test_command_from_driver_input):
1610         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
1611         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1612         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1613         (ChromiumLinuxPortTest.assert_architecture):
1614         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1615         (ChromiumLinuxPortTest.test_path_to_image_diff):
1616         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1617         (ChromiumMacPortTest.assert_name):
1618         (ChromiumMacPortTest.test_baseline_path):
1619         (ChromiumMacPortTest.test_path_to_image_diff):
1620         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1621         (ChromiumPortTestCase.test_default_max_locked_shards):
1622         (ChromiumPortTestCase.test_default_timeout_ms):
1623         (ChromiumPortTestCase.test_default_pixel_tests):
1624         (ChromiumPortTestCase.test_all_test_configurations):
1625         (ChromiumPortTestCase.test_default_configuration):
1626         (ChromiumPortTestCase.test_diff_image):
1627         (ChromiumPortTestCase.test_diff_image_crashed):
1628         (ChromiumPortTestCase.test_expectations_files):
1629         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1630         (ChromiumWinTest.test_setup_environ_for_server_cygpath):
1631         (ChromiumWinTest.assert_name):
1632         (ChromiumWinTest.test_baseline_path):
1633         (ChromiumWinTest.test_path_to_image_diff):
1634         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1635         (DriverTest.test_read_block):
1636         (DriverTest.test_read_binary_block):
1637         (DriverTest.test_read_base64_block):
1638         (DriverTest.test_no_timeout):
1639         (DriverTest.test_check_for_driver_crash.assert_crash):
1640         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1641         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1642         (FactoryTest.test_get_from_builder_name):
1643         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1644         (GtkPortTest.test_default_timeout_ms):
1645         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1646         (HttpLockTest.test_current_lock_pid):
1647         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1648         (TestImageDiffer.test_diff_image_failed):
1649         (TestImageDiffer.test_diff_image_passed):
1650         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1651         (LeakDetectorTest.test_leaks_args):
1652         (test_parse_leaks_output):
1653         (test_leaks_files_in_directory):
1654         (test_count_total_leaks):
1655         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1656         (MacTest.test_default_timeout_ms):
1657         (assert_name):
1658         (test_setup_environ_for_server):
1659         (_assert_search_path):
1660         (test_32bit):
1661         (test_64bit):
1662         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1663         (MockTestShellTest.test_pixeltest__fails):
1664         (MockTestShellTest.test_test_shell_parse_options):
1665         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1666         (PortTestCase.test_default_max_locked_shards):
1667         (PortTestCase.test_default_timeout_ms):
1668         (PortTestCase.test_default_pixel_tests):
1669         (PortTestCase.test_diff_image):
1670         (PortTestCase.test_diff_image_crashed):
1671         (PortTestCase.test_get_crash_log):
1672         (PortTestCase.assert_build_path):
1673         (PortTestCase.test_expectations_ordering):
1674         (_assert_config_file_for_platform):
1675         (test_path_to_apache_config_file):
1676         (test_additional_platform_directory):
1677         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1678         (QtPortTest._assert_search_path):
1679         (QtPortTest._assert_expectations_files):
1680         (QtPortTest.test_setup_environ_for_server):
1681         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1682         (TestServerProcess.test_basic):
1683         (TestServerProcess.test_broken_pipe):
1684         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1685         (WinPortTest._assert_search_path):
1686         (WinPortTest._assert_version):
1687         (WinPortTest.test_runtime_feature_list):
1688         (WinPortTest.test_expectations_files):
1689         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1690         (LintTest.test_all_configurations):
1691         (MainTest.test_all):
1692         (MainTest.test_repeat_each):
1693         (MainTest.test_skipped_flag):
1694         (MainTest.test_iterations):
1695         (MainTest.test_run_chunk):
1696         (MainTest.test_run_part):
1697         (MainTest.test_run_singly):
1698         (MainTest.test_run_singly_actually_runs_tests):
1699         (MainTest.test_single_file):
1700         (MainTest.test_single_file_with_prefix):
1701         (MainTest.test_single_skipped_file):
1702         (MainTest.test_stderr_is_saved):
1703         (MainTest.test_test_list):
1704         (MainTest.test_test_list_with_prefix):
1705         (MainTest.test_missing_and_unexpected_results):
1706         (MainTest.test_pixel_test_directories):
1707         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1708         (MainTest.test_crash_log):
1709         (MainTest.test_web_process_crash_log):
1710         (MainTest.test_exit_after_n_failures_upload):
1711         (MainTest.test_exit_after_n_failures):
1712         (MainTest.test_exit_after_n_crashes):
1713         (MainTest.test_retrying_and_flaky_tests):
1714         (MainTest.test_run_order__inline):
1715         (MainTest.test_reftest_run):
1716         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
1717         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
1718         (MainTest.test_reftest_expected_html_should_be_ignored):
1719         (MainTest.test_reftest_driver_should_run_expected_html):
1720         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
1721         (MainTest.test_output_diffs):
1722         (MainTest.test_unsupported_platform):
1723         (EndToEndTest.test_end_to_end):
1724         (RebaselineTest.test_reset_results):
1725         (RebaselineTest.test_missing_results):
1726         (RebaselineTest.test_new_baseline):
1727         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1728         (BaseTest.integration_test_server__normal):
1729         (BaseTest.integration_test_server__fails):
1730         (BaseTest.integration_test_port_and_root):
1731         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1732         (TestHttpServer.test_start_cmd):
1733         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1734         (RegularTest.test_logging_not_included):
1735         (RegularTest._basic):
1736         (RegularTest.test_basic):
1737         (RegularTest.test_log_after_update):
1738         (RegularTest.test_log_args):
1739         (TtyTest.test_basic):
1740         (TtyTest.test_log_after_update):
1741         (VerboseTest.test_basic):
1742         (VerboseTest.test_log_after_update):
1743         (VerboseTest.test_log_args):
1744         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1745         (Testprinter.assertWritten):
1746         (test_test_status_line):
1747         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1748         (MainTest.assertWritten):
1749         * Scripts/webkitpy/style/checker_unittest.py:
1750         (GlobalVariablesTest.test_webkit_base_filter_rules):
1751         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1752         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1753         (CheckerDispatcherDispatchTest.assert_checker):
1754         (CheckerDispatcherDispatchTest.test_changelog_paths):
1755         (CheckerDispatcherDispatchTest.test_cpp_paths):
1756         (CheckerDispatcherDispatchTest.test_json_paths):
1757         (CheckerDispatcherDispatchTest.test_python_paths):
1758         (CheckerDispatcherDispatchTest.test_text_paths):
1759         (CheckerDispatcherDispatchTest.test_xml_paths):
1760         (StyleProcessorConfigurationTest.test_init):
1761         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
1762         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
1763         (StyleProcessor_EndToEndTest.test_init):
1764         (StyleProcessor_EndToEndTest.test_process):
1765         (StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
1766         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1767         (ChangeLogCheckerTest.assert_error.handle_style_error):
1768         (ChangeLogCheckerTest.test_init):
1769         * Scripts/webkitpy/style/checkers/common_unittest.py:
1770         (CarriageReturnCheckerTest.assert_carriage_return):
1771         (TabCheckerTest.assert_tab):
1772         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1773         (CppFunctionsTest.test_convert_to_lower_with_underscores):
1774         (CppFunctionsTest.test_create_acronym):
1775         (CppFunctionsTest.test_parameter):
1776         (CppFunctionsTest.test_single_line_view):
1777         (CppFunctionsTest.test_create_skeleton_parameters):
1778         (CppFunctionsTest.test_find_parameter_name_index):
1779         (CppFunctionsTest.test_parameter_list):
1780         (CppFunctionsTest.test_check_parameter_against_text):
1781         (CppStyleTestBase.perform_lint):
1782         (CppStyleTestBase.assert_lint):
1783         (CppStyleTestBase.assert_lint_one_of_many_errors_re):
1784         (CppStyleTestBase.assert_multi_line_lint):
1785         (CppStyleTestBase.assert_language_rules_check):
1786         (CppStyleTestBase.assert_include_what_you_use):
1787         (CppStyleTestBase.assert_blank_lines_check):
1788         (CppStyleTestBase.assert_positions_equal):
1789         (FunctionDetectionTest.perform_function_detection):
1790         (CppStyleTest.test_get_line_width):
1791         (CppStyleTest.test_find_next_multi_line_comment_start):
1792         (CppStyleTest.test_find_next_multi_line_comment_end):
1793         (CppStyleTest.test_remove_multi_line_comments_from_range):
1794         (CppStyleTest.test_position):
1795         (CppStyleTest.test_rfind_in_lines):
1796         (CppStyleTest.test_close_expression):
1797         (CppStyleTest.test_include_what_you_use_no_implementation_files):
1798         (CppStyleTest.test_include_what_you_use):
1799         (CppStyleTest.test_files_belong_to_same_module):
1800         (CppStyleTest.test_cleanse_line):
1801         (CppStyleTest.test_multiline_strings):
1802         (CppStyleTest.test_newline_at_eof.do_test):
1803         (CppStyleTest.test_invalid_utf8.do_test):
1804         (CppStyleTest.test_is_blank_line):
1805         (CppStyleTest.test_allow_blank_line_before_closing_namespace):
1806         (CppStyleTest.test_allow_blank_line_before_if_else_chain):
1807         (CppStyleTest.test_else_on_same_line_as_closing_braces):
1808         (CppStyleTest.test_build_header_guard):
1809         (CppStyleTest.test_legal_copyright):
1810         (CleansedLinesTest.test_init):
1811         (CleansedLinesTest.test_init_empty):
1812         (CleansedLinesTest.test_collapse_strings):
1813         (CheckForFunctionLengthsTest.assert_function_lengths_check):
1814         (PassPtrTest.assert_pass_ptr_check):
1815         (LeakyPatternTest.assert_leaky_pattern_check):
1816         (WebKitStyleTest.test_parameter_names):
1817         (WebKitStyleTest.test_webkit_export_check):
1818         (CppCheckerTest.test_init):
1819         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1820         (JSONCheckerTest.assert_error.handle_style_error):
1821         (JSONCheckerTest.test_init):
1822         * Scripts/webkitpy/style/checkers/png_unittest.py:
1823         (PNGCheckerTest.test_init):
1824         (PNGCheckerTest.test_check):
1825         * Scripts/webkitpy/style/checkers/python_unittest.py:
1826         (PythonCheckerTest.test_init):
1827         (PythonCheckerTest.test_check):
1828         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1829         (TestExpectationsTestCase._expect_port_for_expectations_path):
1830         (TestExpectationsTestCase.assert_lines_lint):
1831         * Scripts/webkitpy/style/checkers/text_unittest.py:
1832         (TextStyleTestCase.assertNoError):
1833         (TextStyleTestCase.assertError.error_for_test):
1834         (TextStyleTestCase.assertError):
1835         (TextCheckerTest.test_init):
1836         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1837         (WatchListTest.test_basic_error_message.handle_style_error):
1838         (WatchListTest):
1839         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1840         (XcodeProjectFileCheckerTest.assert_error):
1841         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1842         (XMLCheckerTest.assert_error.handle_style_error):
1843         (XMLCheckerTest.test_init):
1844         * Scripts/webkitpy/style/error_handlers_unittest.py:
1845         (DefaultStyleErrorHandlerTest._check_initialized):
1846         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
1847         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
1848         (DefaultStyleErrorHandlerTest.test_line_numbers):
1849         * Scripts/webkitpy/style/filereader_unittest.py:
1850         (TextFileReaderTest._assert_file_reader):
1851         (TextFileReaderTest.test_process_file__does_not_exist):
1852         (TextFileReaderTest.test_count_delete_only_file):
1853         * Scripts/webkitpy/style/filter_unittest.py:
1854         (CategoryFilterTest.test_init):
1855         (CategoryFilterTest.test_init_default_arguments):
1856         (CategoryFilterTest.test_str):
1857         (FilterConfigurationTest.test_init):
1858         (FilterConfigurationTest.test_default_arguments):
1859         * Scripts/webkitpy/style/main_unittest.py:
1860         (ChangeDirectoryTest._assert_result):
1861         * Scripts/webkitpy/style/optparser_unittest.py:
1862         (ArgumentPrinterTest.test_to_flag_string):
1863         (ArgumentParserTest.test_parse_default_arguments):
1864         (ArgumentParserTest.test_parse_explicit_arguments):
1865         (ArgumentParserTest.test_parse_files):
1866         (CommandOptionValuesTest.test_init):
1867         * Scripts/webkitpy/style/patchreader_unittest.py:
1868         (PatchReaderTest._assert_checked):
1869         * Scripts/webkitpy/test/finder_unittest.py:
1870         (FinderTest.test_additional_system_paths):
1871         (FinderTest.test_to_module):
1872         (FinderTest.check_names):
1873         * Scripts/webkitpy/test/main_unittest.py:
1874         (TesterTest.test_individual_names_are_not_run_twice):
1875         (TesterTest.test_integration_tests_are_not_found_by_default):
1876         (TesterTest.test_integration_tests_are_found):
1877         (TesterTest.integration_test_coverage_works):
1878         * Scripts/webkitpy/test/runner_unittest.py:
1879         (RunnerTest.test_run):
1880         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1881         (_expect_validate):
1882         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1883         (ExpectedFailuresTest._assert_can_trust):
1884         (ExpectedFailuresTest.test_unexpected_failures_observed):
1885         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
1886         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1887         (test_patches_with_acceptable_review_flag):
1888         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1889         (IRCCommandTest.test_whois):
1890         (IRCCommandTest.test_create_bug):
1891         (IRCCommandTest.test_roll_chromium_deps):
1892         (IRCCommandTest.test_rollout):
1893         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1894         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1895         (test_missing_unit_test_results_path):
1896         (test_layout_test_results):
1897         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1898         (LoggingDelegate.process_work_item):
1899         (LoggingDelegate.handle_unexpected_error):
1900         (QueueEngineTest.test_trivial):
1901         (QueueEngineTest.test_unexpected_error):
1902         (QueueEngineTest.test_handled_error):
1903         (QueueEngineTest._test_terminating_queue):
1904         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1905         (OpenBugsTest.test_find_bugs_in_string):
1906         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1907         (FailureReasonTest.test_blame_line_for_revision):
1908         (PrintExpectationsTest.run_test):
1909         (PrintBaselinesTest.test_basic):
1910         (PrintBaselinesTest.test_multiple):
1911         (PrintBaselinesTest.test_csv):
1912         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1913         (AbstractQueueTest.test_log_directory):
1914         (AbstractPatchQueueTest.test_next_patch):
1915         (test_auto_retry):
1916         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1917         (test_rebaseline_updates_expectations_file):
1918         (test_rebaseline_does_not_include_overrides):
1919         (test_rebaseline_test):
1920         (test_rebaseline_test_with_results_directory):
1921         (test_rebaseline_test_and_print_scm_changes):
1922         (test_rebaseline_and_copy_test):
1923         (test_rebaseline_and_copy_test_no_existing_result):
1924         (test_rebaseline_and_copy_test_with_lion_result):
1925         (test_rebaseline_and_copy_no_overwrite_test):
1926         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1927         (TestRebaselineJson.test_rebaseline_all):
1928         (TestRebaselineJson.test_rebaseline_debug):
1929         (TestRebaselineJson.test_move_overwritten):
1930         (TestRebaselineJson.test_no_optimize):
1931         (TestRebaselineJson.test_results_directory):
1932         (TestRebaseline.test_rebaseline):
1933         (TestRebaselineExpectations.test_rebaseline_expectations_noop):
1934         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
1935         (TestAnalyzeBaselines.test_default):
1936         (TestAnalyzeBaselines.test_missing_baselines):
1937         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1938         (PostRollCommandsTest.test_prepare_state):
1939         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1940         (BuildCoverageExtrapolatorTest.test_extrapolate):
1941         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
1942         (AddSvnMimetypeForPngTest.test_run):
1943         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1944         (PrepareChangeLogTest.test_ensure_bug_url):
1945         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1946         (_assert_message_for_revert_output):
1947         * TestResultServer/model/jsonresults_unittest.py:
1948         (JsonResultsTest._test_merge):
1949         (JsonResultsTest._test_get_test_list):
1950
1951 2012-11-14  János Badics  <jbadics@inf.u-szeged.hu>
1952
1953         [Qt][ARM] Fix 'nullptr' is a keyword in C++11 [-Wc++0x-compat] warning
1954         https://bugs.webkit.org/show_bug.cgi?id=102083
1955
1956         Reviewed by Csaba Osztrogonác.
1957
1958         Modified compiler name regex in condition that tests if -std=c++0x, c++11,
1959         gnu++0x or gnu++11 are enabled in order to match linux-arm-gnueabi-g++ too,
1960         thus enabling -Wno-c++0x-compat also on ARM compiler.
1961
1962         * qmake/mkspecs/features/unix/default_post.prf:
1963
1964 2012-11-14  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1965
1966         REGRESSION(r133757): Causing webkitpy unit tests to fail
1967         https://bugs.webkit.org/show_bug.cgi?id=101444
1968
1969         Reviewed by Csaba Osztrogonác.
1970
1971         Updated the bot name on the unit tests.
1972
1973         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1974         (TestRebaselineTest.test_baseline_directory):
1975
1976 2012-11-14  Byungwoo Lee  <bw80.lee@samsung.com>
1977
1978         [EFL][WK2] Rename variables, structures and functions of the MiniBrowser.
1979         https://bugs.webkit.org/show_bug.cgi?id=101517
1980
1981         Reviewed by Gyuyoung Kim.
1982
1983         Rename variables, structures and functions of the MiniBrowser
1984         for the naming consistency.
1985
1986         1) Browser_Window* {app_data|browser_window|window} -> window
1987
1988         2) Browser_Window::webview -> Browser_Window::ewk_view
1989              The webkit API functions are ewk_view_xxx not webview_xxx.
1990              So using ewk_view will be better than webview.
1991
1992         3) Browser_Window::window -> Browser_Window::elm_window
1993              The name is changed to be distinguished with 'Browser_Window *window'
1994
1995         4) browser_{window|view}_find() -> window_find_with_{elm_window|ewk_view}()
1996              This is changed because the name of the function can be confused.
1997              Currently, browser_window_find() returns Browser_Window*. And
1998              browser_view_find() also returns Browser_Window*.
1999
2000         5) FileSelectorData -> File_Selector_Data / AuthData -> Auth_Data
2001              The type definition is moved to the top of the source file
2002              and the name is changed to follow EFL style.
2003
2004         * MiniBrowser/efl/main.c:
2005         (miniBrowserViewSmartClass):
2006         (_Browser_Window):
2007         (_File_Selector_Data):
2008         (_Auth_Data):
2009         (window_find_with_ewk_view):
2010         (window_free):
2011         (on_key_down):
2012         (view_focus_set):
2013         (on_mouse_down):
2014         (title_set):
2015         (on_title_changed):
2016         (on_url_changed):
2017         (on_back_forward_list_changed):
2018         (on_new_window):
2019         (on_close_window):
2020         (on_progress):
2021         (on_error):
2022         (on_download_request):
2023         (close_file_picker):
2024         (on_filepicker_parent_deletion):
2025         (on_filepicker_deletion):
2026         (on_fileselector_done):
2027         (on_file_chooser_request):
2028         (on_download_finished):
2029         (on_download_failed):
2030         (on_favicon_received):
2031         (on_view_icon_changed):
2032         (on_url_bar_activated):
2033         (on_url_bar_clicked):
2034         (on_back_button_clicked):
2035         (on_forward_button_clicked):
2036         (on_refresh_button_clicked):
2037         (on_javascript_alert):
2038         (on_javascript_confirm):
2039         (on_javascript_prompt):
2040         (on_window_geometry_get):
2041         (on_window_geometry_set):
2042         (on_fullscreen_deny):
2043         (on_fullscreen_enter):
2044         (on_fullscreen_exit):
2045         (auth_popup_close):
2046         (on_auth_cancel):
2047         (on_auth_ok):
2048         (on_authentication_request):
2049         (on_tooltip_text_set):
2050         (on_tooltip_text_unset):
2051         (on_home_button_clicked):
2052         (on_window_deletion):
2053         (window_create):
2054
2055 2012-11-14  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2056
2057         webkitpy: Update the EFL list of bots
2058         https://bugs.webkit.org/show_bug.cgi?id=102121
2059
2060         Reviewed by Kenneth Rohde Christiansen.
2061
2062         Update the EFL bots so we can use garden-o-matic.
2063
2064         * Scripts/webkitpy/layout_tests/port/builders.py:
2065
2066 2012-11-13  Yael Aharon  <yael.aharon@intel.com>
2067
2068         [EFL][WK2] New window size should consult the window attributes
2069         https://bugs.webkit.org/show_bug.cgi?id=102122
2070
2071         Reviewed by Kenneth Rohde Christiansen.
2072
2073         Take into account the size that was specified in window.open
2074         when creating a new window. This avoids ugly flashing on the screen.
2075
2076         * MiniBrowser/efl/main.c:
2077         (on_key_down):
2078         (on_new_window):
2079         (window_create):
2080         (elm_main):
2081
2082 2012-11-13  Dana Jansens  <danakj@chromium.org>
2083
2084         [chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport
2085         https://bugs.webkit.org/show_bug.cgi?id=102146
2086
2087         Reviewed by James Robinson.
2088
2089         Pass settings that go through WebCompositorSupport also through
2090         WebLayerTreeSettings. When the compositor starts using those instead,
2091         we can remove the callers to the WebCompositorSupport setters.
2092
2093         * DumpRenderTree/chromium/TestShell.cpp:
2094         (TestShell::TestShell):
2095         (TestShell::resetWebSettings):
2096         (TestShell::setPerTilePaintingEnabled):
2097         (TestShell::setAcceleratedAnimationEnabled):
2098         * DumpRenderTree/chromium/TestShell.h:
2099         (TestShell):
2100         * DumpRenderTree/chromium/WebPreferences.cpp:
2101         (WebPreferences::applyTo):
2102         * DumpRenderTree/chromium/WebPreferences.h:
2103         (WebPreferences):
2104
2105 2012-11-13  Kentaro Hara  <haraken@chromium.org>
2106
2107         Unreviewed, rolling out r134503.
2108         http://trac.webkit.org/changeset/134503
2109
2110         Roll out a patch that was landed just to investigate svn
2111         trouble
2112
2113         * Scripts/webkitpy/common/config/committers.py:
2114
2115 2012-11-13  Kentaro Hara  <haraken@chromium.org>
2116
2117         Unreviewed. Investigating svn trouble. Test commit.
2118
2119         * Scripts/webkitpy/common/config/committers.py:
2120
2121 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2122
2123         Unreviewed, rolling out r134446.
2124         http://trac.webkit.org/changeset/134446
2125         https://bugs.webkit.org/show_bug.cgi?id=101968
2126
2127         Need to try a different strategy for landing a two-sided patch
2128         (3/3).
2129
2130         * DumpRenderTree/chromium/TestShell.cpp:
2131         (TestShell::TestShell):
2132         (TestShell::resetWebSettings):
2133         (TestShell::setPerTilePaintingEnabled):
2134         (TestShell::setAcceleratedAnimationEnabled):
2135         * DumpRenderTree/chromium/TestShell.h:
2136         (TestShell):
2137         * DumpRenderTree/chromium/WebPreferences.cpp:
2138         (WebPreferences::applyTo):
2139         * DumpRenderTree/chromium/WebPreferences.h:
2140         (WebPreferences):
2141
2142 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2143
2144         Unreviewed, rolling out r134449.
2145         http://trac.webkit.org/changeset/134449
2146         https://bugs.webkit.org/show_bug.cgi?id=102076
2147
2148         Re-rolling in the patch, it was innocent.
2149
2150         * TestWebKitAPI/PlatformEfl.cmake:
2151
2152 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2153
2154         Unreviewed, rolling out r134424.
2155         http://trac.webkit.org/changeset/134424
2156         https://bugs.webkit.org/show_bug.cgi?id=102076
2157
2158         Made fast/dom/Window/open-window-min-size.html crash.
2159
2160         * TestWebKitAPI/PlatformEfl.cmake:
2161
2162 2012-11-12  Dana Jansens  <danakj@chromium.org>
2163
2164         [chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
2165         https://bugs.webkit.org/show_bug.cgi?id=101968
2166
2167         Reviewed by James Robinson.
2168
2169         * DumpRenderTree/chromium/TestShell.cpp:
2170         (TestShell::TestShell):
2171         (TestShell::resetWebSettings):
2172         * DumpRenderTree/chromium/TestShell.h:
2173         (TestShell::setPerTilePaintingEnabled):
2174         (TestShell::setAcceleratedAnimationEnabled):
2175         (TestShell):
2176         * DumpRenderTree/chromium/WebPreferences.cpp:
2177         (WebPreferences::applyTo):
2178         * DumpRenderTree/chromium/WebPreferences.h:
2179         (WebPreferences):
2180
2181 2012-11-13  Dirk Pranke  <dpranke@chromium.org>
2182
2183         Fix webkitpy issues arising from a partially-installed pylint.
2184         Unreviewed, build fix.
2185
2186         This patch ensures that we will re-install the pylint and logilab
2187         packages if any of them are missing, not just the pylint package.
2188
2189         * Scripts/webkitpy/thirdparty/__init__.py:
2190         (AutoinstallImportHook._install_pylint):
2191
2192 2012-11-13  No'am Rosenthal  <noam.rosenthal@nokia.com>
2193
2194         Unreviewed, adding my new email address to committers.py and watchlist.
2195
2196         * Scripts/webkitpy/common/config/committers.py:
2197         * Scripts/webkitpy/common/config/watchlist:
2198
2199 2012-11-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2200
2201         [CMake] Incorrect dependency calculation when generating forwarding headers
2202         https://bugs.webkit.org/show_bug.cgi?id=102076
2203
2204         Reviewed by Kenneth Rohde Christiansen.
2205
2206         Explicitly call generate-forwarding-headers.pl on ${WEBKIT2_DIR} as
2207         well, since some dependencies pulled in via the WebKit2/WebKit2_C.h
2208         include in config.h are only generated from there.
2209
2210         This is a bit redundant since this is also done in WebKit2's
2211         PlatformEfl.cmake, however the WTF and WebCore API tests do not depend
2212         on WebKit2 so the script may not have been called when these tests are
2213         being built.
2214
2215         * TestWebKitAPI/PlatformEfl.cmake:
2216
2217 2012-11-13  Zeno Albisser  <zeno@webkit.org>
2218
2219         Unreviewed: Adding watchlist definition for CoordinatedGraphics.
2220
2221         * Scripts/webkitpy/common/config/watchlist:
2222
2223 2012-11-13  Hugo Parente Lima  <hugo.lima@openbossa.org>
2224
2225         [cmake] Do not use GLOB to add WTR IDL files to buildsystem.
2226         https://bugs.webkit.org/show_bug.cgi?id=101785
2227
2228         Reviewed by Caio Marcelo de Oliveira Filho.
2229
2230         Using *.idl makes impossible to add IDL files depending on compiler flags,
2231         like a possible GamepadController.idl file found on Chromium.
2232
2233         * WebKitTestRunner/CMakeLists.txt:
2234
2235 2012-11-13  Jochen Eisinger  <jochen@chromium.org>
2236
2237         [chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself
2238         https://bugs.webkit.org/show_bug.cgi?id=102075
2239
2240         Reviewed by Pavel Feldman.
2241
2242         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2243
2244 2012-11-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2245
2246         [EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventSender.
2247         https://bugs.webkit.org/show_bug.cgi?id=102074
2248
2249         Reviewed by Kenneth Rohde Christiansen.
2250
2251         * DumpRenderTree/efl/EventSender.cpp:
2252         (feedMouseEvent): Do not call DumpRenderTreeSupportEfl::layoutFrame()
2253         when sending an event, as it causes additional repaints that create
2254         wrong pixel results for tests such as
2255         fast/repaint/overflow-auto-in-overflow-auto-scrolled.html.
2256
2257 2012-11-13  Csaba Osztrogonác  <ossy@webkit.org>
2258
2259         [Qt] Enable Mutation observer
2260         https://bugs.webkit.org/show_bug.cgi?id=102066
2261
2262         Reviewed by Pavel Feldman.
2263
2264         * qmake/mkspecs/features/features.pri:
2265
2266 2012-11-13  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2267
2268         [BlackBerry] DRT - platform/blackberry/editing/text-iterator/findString-markers.html failed
2269         https://bugs.webkit.org/show_bug.cgi?id=102056
2270
2271         Reviewed by Rob Buis.
2272
2273         RIM PR 235836
2274
2275         TestRunner::findString() was changed to call Page::findString() instead
2276         of WebPage::findNextString(). Page::findString() doesn't update
2277         TextMatch markers.
2278         Work-around by calling both Page::findString() and WebPage::findNextString().
2279
2280         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2281         (TestRunner::findString):
2282
2283 2012-11-12  Jochen Eisinger  <jochen@chromium.org>
2284
2285         Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
2286         https://bugs.webkit.org/show_bug.cgi?id=101957
2287
2288         Reviewed by Adam Barth.
2289
2290         Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply.
2291
2292         * Scripts/webkitpy/common/config/watchlist:
2293
2294 2012-11-13  Jochen Eisinger  <jochen@chromium.org>
2295
2296         [chromium] move tracking of damaged regions from WebViewHost to WebTestProxy
2297         https://bugs.webkit.org/show_bug.cgi?id=101927
2298
2299         Reviewed by Adam Barth.
2300
2301         This will allow for sharing the code with content_shell
2302
2303         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2304         (DRTTestRunner::display):
2305         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2306         (WebKit):
2307         (WebTestProxyBase):
2308         (WebTestRunner::WebTestProxy::didInvalidateRect):
2309         (WebTestRunner::WebTestProxy::didScrollRect):
2310         (WebTestRunner::WebTestProxy::scheduleComposite):
2311         (WebTestRunner::WebTestProxy::scheduleAnimation):
2312         (WebTestRunner::WebTestProxy::setWindowRect):
2313         (WebTestRunner::WebTestProxy::show):
2314         (WebTestRunner::WebTestProxy::didAutoResize):
2315         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2316         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2317         (WebTestRunner::WebTestProxyBase::setPaintRect):
2318         (WebTestRunner):
2319         (WebTestRunner::WebTestProxyBase::paintRect):
2320         (WebTestRunner::WebTestProxyBase::didInvalidateRect):
2321         (WebTestRunner::WebTestProxyBase::didScrollRect):
2322         (WebTestRunner::WebTestProxyBase::scheduleComposite):
2323         (WebTestRunner::WebTestProxyBase::scheduleAnimation):
2324         (WebTestRunner::WebTestProxyBase::show):
2325         (WebTestRunner::WebTestProxyBase::setWindowRect):
2326         (WebTestRunner::WebTestProxyBase::didAutoResize):
2327         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2328         * DumpRenderTree/chromium/TestShell.cpp:
2329         (TestShell::createNewWindow):
2330         * DumpRenderTree/chromium/WebViewHost.cpp:
2331         (WebViewHost::scheduleAnimation):
2332         (WebViewHost::show):
2333         (WebViewHost::setWindowRect):
2334         (WebViewHost::WebViewHost):
2335         (WebViewHost::proxy):
2336         (WebViewHost::setProxy):
2337         (WebViewHost::reset):
2338         (WebViewHost::paintInvalidatedRegion):
2339         * DumpRenderTree/chromium/WebViewHost.h:
2340         (WebViewHost):
2341
2342 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2343
2344         webkitpy: clean up lint errors, part 1
2345         https://bugs.webkit.org/show_bug.cgi?id=102024
2346
2347         Reviewed by Adam Barth.
2348
2349         This patch cleans up a lot of miscellaneous minor lint errors that
2350         apparently aren't caught by unit tests, and suppresses a few
2351         false positives.
2352
2353         Also, this patch removes the garden-o-matic "rollout" entry point
2354         since it's no longer being used by the frontend (rather than
2355         fix it to not generate lint errors).
2356
2357         * Scripts/webkitpy/common/system/executive_mock.py:
2358         (MockExecutive2.run_command):
2359         * Scripts/webkitpy/common/system/filesystem_mock.py:
2360         (MockFileSystem.copyfile):
2361         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2362         (Manager._http_tests):
2363         * Scripts/webkitpy/layout_tests/port/apple.py:
2364         (ApplePort):
2365         * Scripts/webkitpy/layout_tests/port/base.py:
2366         (Port.reference_files):
2367         * Scripts/webkitpy/layout_tests/port/chromium.py:
2368         (ChromiumPort):
2369         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2370         (ChromiumAndroidDriver._teardown_performance):
2371         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2372         (ChromiumPortTestCase.TestAndroidPort.__init__):
2373         (ChromiumPortTestCase.test_default_configuration):
2374         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2375         (PortTestCase):
2376         (PortTestCase.test_driver_cmd_line):
2377         (PortTestCase.test_expectations_ordering):
2378         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2379         (HttpServerBase._check_that_all_ports_are_available):
2380         * Scripts/webkitpy/style/checkers/python.py:
2381         (Pylinter):
2382         * Scripts/webkitpy/tool/commands/gardenomatic.py:
2383         (GardenOMatic.__init__):
2384         * Scripts/webkitpy/tool/commands/queues.py:
2385         (CommitQueue):
2386         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2387         (GardeningHTTPRequestHandler):
2388         (GardeningHTTPRequestHandler.localresult):
2389
2390 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2391
2392         webkitpy: clean up lint errors, part 2
2393         https://bugs.webkit.org/show_bug.cgi?id=102029
2394
2395         Reviewed by Adam Barth.
2396
2397         This cleans up the remaining lint errors in webkitpy with four exceptions:
2398         1) we don't lint thirdparty/ autoinstalled code, obviously
2399         2) there's an intentional error in the unit tests for pylint itself
2400         3) the implementation of webkit-patch optimize-expectations has
2401         an error but I think we can and should just remove that command as well.
2402         4) I have not yet linted the test code
2403
2404         * Scripts/webkitpy/common/newstringio.py:
2405         * Scripts/webkitpy/common/checkout/scm/scm.py:
2406         (SCM.find_checkout_root):
2407         (SCM.will.remote_merge_base):
2408         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2409         * Scripts/webkitpy/common/checkout/scm/svn.py:
2410         (SVNRepository.has_authorization_for_realm):
2411         (SVN.__init__):
2412         * Scripts/webkitpy/common/config/contributionareas.py:
2413         (ContributionAreas.names):
2414         * Scripts/webkitpy/common/config/ports.py:
2415         (DeprecatedPort):
2416         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2417         (Builder.force_build):
2418         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2419         * Scripts/webkitpy/style/checkers/cpp.py:
2420         (check_posix_threading):
2421         (check_spacing):
2422         * Scripts/webkitpy/style/optparser.py:
2423         (ArgumentParser._create_option_parser):
2424         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2425         (AbstractLocalServerCommand.execute):
2426         * Scripts/webkitpy/tool/commands/download.py:
2427         (AbstractPatchProcessingCommand):
2428         (AbstractPatchProcessingCommand._process_patch):
2429         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2430         (AbstractEarlyWarningSystem):
2431
2432 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2433
2434         remove 'webkit-patch optimize-expectations'
2435         https://bugs.webkit.org/show_bug.cgi?id=102032
2436
2437         Reviewed by Adam Barth.
2438
2439         Removing this command because it is totally broken (probably
2440         broke when I added support for multiple files in a cascade)
2441         and doesn't seem to do anything much useful. It certainly
2442         didn't actually optimize things.
2443
2444         * Scripts/webkitpy/tool/commands/expectations.py: Removed.
2445
2446 2012-11-12  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2447
2448         [BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
2449         https://bugs.webkit.org/show_bug.cgi?id=101894
2450
2451         Reviewed by Rob Buis.
2452
2453         RIM PR 241686
2454         Also remove an un-needed pixel lock, and fix a klocwork error in SKIA
2455         code path.
2456
2457         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2458         (readPixelsUserInterfaceThread):
2459         (createBitmapContextFromWebView):
2460
2461 2012-11-12  Daniel Bates  <dbates@webkit.org>
2462
2463         Perl errors from Tools/Scripts/copy-webkitlibraries-to-product-directory
2464         https://bugs.webkit.org/show_bug.cgi?id=101980
2465
2466         Reviewed by Mark Rowe.
2467
2468         Remove library libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceSnowLeopard.a
2469         from the list of libraries to copy to the specified built products directory
2470         as these libraries were removed from the repository in <http://trac.webkit.org/changeset/133670>.
2471
2472         * Scripts/copy-webkitlibraries-to-product-directory:
2473
2474 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2475
2476         webkitpy: integrate pylint into check-webkit-style, part I
2477         https://bugs.webkit.org/show_bug.cgi?id=101285
2478
2479         Reviewed by Ojan Vafai.
2480
2481         This patch re-works lint-webkitpy so that the logic is pushed
2482         into check-webkit-style (mostly); we don't yet control which
2483         messages are displayed using the rules in webkitpy/style/checker.py
2484         (we're still using the pylintrc to suppress messages instead),
2485         but otherwise things work. For now we will only report pylint
2486         "errors", not warnings.
2487
2488         * Scripts/lint-webkitpy:
2489         * Scripts/webkitpy/style/checker.py:
2490         * Scripts/webkitpy/style/checkers/python.py:
2491         (PythonChecker):
2492         (PythonChecker.check):
2493         (PythonChecker._check_pep8):
2494         (PythonChecker._check_pylint):
2495         (Pylinter):
2496         (Pylinter.__init__):
2497         (Pylinter.run):
2498         (_FilteredStringIO):
2499         (_FilteredStringIO.__init__):
2500         (_FilteredStringIO.write):
2501         (_FilteredStringIO._filter):
2502         * Scripts/webkitpy/style/checkers/python_unittest.py:
2503         (PythonCheckerTest.test_check):
2504         * Scripts/webkitpy/style/checkers/python_unittest_input.py:
2505
2506 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2507
2508         nrwt: remove a bunch of broken chromium-specific flags
2509         https://bugs.webkit.org/show_bug.cgi?id=101979
2510
2511         Reviewed by Tony Chang.
2512
2513         There were a bunch of chromium-specific flags that used to be
2514         supported by NRWT (and handled and passed on to DRT) but have
2515         probably been broken for a long time and are currently ignored.
2516
2517         This patch removes all of those flags; the rule of thumb going forward
2518         is that we should only add flags that affect how the python code functions.
2519         If a flag is just passed verbatim to DRT, the user can use --additional-drt-flag
2520         for that.
2521
2522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2523         (parse_args):
2524         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2525         (MainTest.setUp):
2526
2527 2012-11-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2528
2529         [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser
2530         https://bugs.webkit.org/show_bug.cgi?id=101930
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         Added --device-pixel-ratio command line option to EFL MiniBrowser which sets
2535         the ratio between the CSS units and device pixels when the content is unscaled.
2536         Option is applied for all the views created by mini browser.
2537
2538         * MiniBrowser/efl/main.c:
2539         (window_create):
2540         (elm_main):
2541
2542 2012-11-12  Dirk Pranke  <dpranke@chromium.org>
2543
2544         remove the chromium-mac-mountainlion TestExpectations file
2545         https://bugs.webkit.org/show_bug.cgi?id=101789
2546
2547         Reviewed by Ojan Vafai.
2548
2549         Nearly all of the tests have been updated for 10.8 and the remaining
2550         failures have been merged into the main TestExpectations file. We
2551         don't need this hook any more.
2552
2553         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2554         (ChromiumMacPort.operating_system):
2555         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2556         (ChromiumMacPortTest.test_path_to_image_diff):
2557
2558 2012-11-12  Peter Beverloo  <peter@chromium.org>
2559
2560         [Chromium-Android] Restart the device's shell in root before pushing data
2561         https://bugs.webkit.org/show_bug.cgi?id=101944
2562
2563         Reviewed by Adam Barth.
2564
2565         Setting up md5sum and pushing the executable, fonts and test resources was
2566         unintentionally being done prior to executing the "adb root" command,
2567         which restarts the device's shell to be root. Since test data is still
2568         being pushed to /data/local/tmp, writing to which requires root access,
2569         devices not running as root would throw a ScriptError.
2570
2571         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2572         (ChromiumAndroidDriver._setup_test):
2573
2574 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2575
2576         [Qt] Support ResourceRequest's setTimeoutInterval
2577         https://bugs.webkit.org/show_bug.cgi?id=101731
2578
2579         Reviewed by Simon Hausmann.
2580
2581         Enable XHR_TIMEOUT now that we support the necessary feature.
2582
2583         * qmake/mkspecs/features/features.pri:
2584
2585 2012-11-12  Gustavo Noronha Silva  <gns@gnome.org>
2586
2587         Unreviewed. Removing myself from the list of address to CC on EWS
2588         build failure; the CC turned out to just be too noisy so I'm
2589         tracking those in a different way.
2590
2591         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2592         (GtkEWS):
2593
2594 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2595
2596         [Qt] Can not load MHTML documents
2597         https://bugs.webkit.org/show_bug.cgi?id=101765
2598
2599         Reviewed by Simon Hausmann.
2600
2601         Enable MHTML feature.
2602
2603         * qmake/mkspecs/features/features.pri:
2604
2605 2012-11-12  Tommy Widenflycht  <tommyw@google.com>
2606
2607         MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
2608         https://bugs.webkit.org/show_bug.cgi?id=101751
2609
2610         Reviewed by Adam Barth.
2611
2612         Makes the data channel mocks to be synchronous instead of asynchronous to be able to
2613         properly test RTCDataChannel event handling.
2614
2615         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2616         (MockWebRTCPeerConnectionHandler::sendStringData):
2617         (MockWebRTCPeerConnectionHandler::sendRawData):
2618
2619 2012-11-12  Jochen Eisinger  <jochen@chromium.org>
2620
2621         [chromium] move TestRunner implementation into WebTestRunner namespace
2622         https://bugs.webkit.org/show_bug.cgi?id=101837
2623
2624         Reviewed by Adam Barth.
2625
2626         That way, we don't get collisions when linking e.g. against chromium's
2627         net test support library.
2628
2629         * DumpRenderTree/chromium/DRTTestRunner.h:
2630         (DRTTestRunner):
2631         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
2632         (WebTestRunner):
2633         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2634         (WebTestRunner):
2635         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2636         (WebTestRunner):
2637         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
2638         (WebTestRunner):
2639         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
2640         (WebTestRunner):
2641         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
2642         (WebTestRunner):
2643         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2644         (WebTestRunner):
2645         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2646         (WebTestRunner):
2647         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
2648         (WebTestRunner):
2649         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
2650         (WebTestRunner):
2651         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2652         (WebTestRunner):
2653         (TestDelegate):
2654         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2655         (WebTestRunner):
2656         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2657         (WebTestRunner):
2658         (TestInterfaces):
2659         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2660         (WebTestRunner):
2661         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2662         (WebTestRunner):
2663         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
2664         (WebTestRunner):
2665         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h:
2666         (WebTestRunner):
2667
2668 2012-11-12  Zeno Albisser  <zeno@webkit.org>
2669
2670         [Qt] MiniBrowser should not strongly depend on QtTestSupport.
2671         https://bugs.webkit.org/show_bug.cgi?id=101775
2672
2673         Introducing HAVE(QTTESTSUPPORT) to allow building
2674         MiniBrowser without QtTestSupport.
2675         This is necessary when using a production build.
2676
2677         Reviewed by Tor Arne Vestbø.
2678
2679         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2680         (MiniBrowserApplication::handleUserOptions):
2681         * qmake/mkspecs/features/configure.prf:
2682         * qmake/mkspecs/features/features.prf:
2683
2684 2012-11-11  Kangil Han  <kangil.han@samsung.com>
2685
2686         Change build congratulation message in EFL
2687         https://bugs.webkit.org/show_bug.cgi?id=101833
2688
2689         Reviewed by Gyuyoung Kim.
2690
2691         EFL port is currently supporting both WK1 and WK2.
2692         But, build congratulation message still shows WK1(EWebLauncher) only.
2693         Therefore, this patch adopts WK2 reference execution(MiniBrowser) in its message.
2694
2695         From 'To run EWebLauncher with this newly-built code, use the'
2696         to 'To run EWebLauncher/MiniBrowser with this newly-built code, use the'.
2697
2698         * Scripts/build-webkit:
2699         (writeCongrats):
2700         * Scripts/webkitdirs.pm:
2701         (launcherName):
2702
2703 2012-11-09  Ryosuke Niwa  <rniwa@webkit.org>
2704
2705         People with dichromacy can't tell crashes and passes on flakiness dashboard
2706         https://bugs.webkit.org/show_bug.cgi?id=101711
2707
2708         Reviewed by Ojan Vafai.
2709
2710         Lower the brightness of orange, and raise the brightness of green so that
2711         people with color blindnes can still distinguish passes and crashes easily.
2712
2713         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
2714         (.P):
2715         (.C):
2716
2717 2012-11-09  Tommy Widenflycht  <tommyw@google.com>
2718
2719         MediaStream API: Deleting all files relating to the deprecated PeerConnection00
2720         https://bugs.webkit.org/show_bug.cgi?id=101730
2721
2722         Reviewed by Adam Barth.
2723
2724         Since RTCPeerConenction has superseeded PeerConnection00 this patch removes all
2725         files relating to the old API.
2726
2727         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2728         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2729         (MockWebMediaStreamCenter):
2730         * DumpRenderTree/chromium/TestShell.cpp:
2731         (TestShell::TestShell):
2732
2733 2012-11-09  Yael Aharon  <yael.aharon@intel.com>
2734
2735         [EFL] Give the view a size in TestWebKitAPI
2736         https://bugs.webkit.org/show_bug.cgi?id=101770
2737
2738         Reviewed by Laszlo Gombos.
2739
2740         2 tests are currently failing, because they expect us to paint, but we don't paint if the view size is empty.
2741
2742         * TestWebKitAPI/efl/PlatformWebView.cpp:
2743         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2744         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2745         (TestWebKitAPI):
2746         (TestWebKitAPI::PlatformWebView::resizeTo):
2747
2748 2012-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2749
2750         Unreviewed, rolling out r134068.
2751         http://trac.webkit.org/changeset/134068
2752         https://bugs.webkit.org/show_bug.cgi?id=101766
2753
2754         Caused crashes on the bots. (Requested by rakuco on #webkit).
2755
2756         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2757         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2758
2759 2012-11-09  Zan Dobersek  <zandobersek@gmail.com>
2760
2761         [GTK] Bump the jhbuild Cairo version to 1.12.8
2762         https://bugs.webkit.org/show_bug.cgi?id=101721
2763
2764         Bump the Cairo version in Jhbuild moduleset to 1.12.8. This version
2765         should fix multiple failures in canvas tests and also contains
2766         fixes for X-related crashes that occurred from the 1.12.4 version onwards.
2767
2768         * gtk/jhbuild.modules:
2769
2770 2012-11-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2771
2772         [WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
2773         https://bugs.webkit.org/show_bug.cgi?id=101759
2774
2775         Reviewed by Kenneth Rohde Christiansen.
2776
2777         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2778         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
2779         the check for an empty repaintRect -- we need to check if the
2780         WKArrayRef has any items. `if (repaintRect)' will return true
2781         regardless of whether the array is empty or not.
2782
2783
2784 2012-11-09  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2785
2786         [Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources
2787
2788         Having DerivedSources.pri in the watchlist regexp was creating too much
2789         noise.
2790
2791         Reviewed by Ossy.
2792
2793         * Scripts/webkitpy/common/config/watchlist:
2794
2795 2012-11-09  Dominik Röttsches  <dominik.rottsches@intel.com>
2796
2797         webkitpy/layouttests integration test fails if high shards/processes environment variables are used
2798         https://bugs.webkit.org/show_bug.cgi?id=101455
2799
2800         Reviewed by Dirk Pranke.
2801
2802         Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.
2803
2804         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2805         (MainTest.test_max_locked_shards):
2806
2807 2012-11-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2808
2809         [EFL][DRT] Force a repaint before tracking repaint rects.
2810         https://bugs.webkit.org/show_bug.cgi?id=101743
2811
2812         Reviewed by Kenneth Rohde Christiansen.
2813
2814         Do like other ports and force a repaint before we start tracking
2815         repaints so that the pixel results generated look more in line
2816         with what's expected.
2817
2818         * DumpRenderTree/efl/DumpRenderTree.cpp:
2819         (displayWebView): Call DRTSupport::forceLayout() before start
2820         tracking repaints.
2821
2822 2012-11-09  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2823
2824         [BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key
2825         https://bugs.webkit.org/show_bug.cgi?id=100937
2826
2827         Reviewed by Rob Buis.
2828
2829         1. Translate these keys to their corresponding BlackBerry key code.
2830         2. Break down a KeyChar event to a KeyDown/KeyUp pair. This is required
2831         because we only handle scrolling on a KeyDown event in WebPage::keyEvent()
2832         , and internally a KeyChar event is interpreted as a KeyDown event + a
2833         KeyUp event in InputHandler::handleKeyboardInput().
2834
2835         Tests fixed:
2836         1. editing/input/scroll-viewport-page-up-down.html
2837         2. editing/selection/move-begin-end.html
2838         3. fast/forms/select-popup-pagekeys.html
2839
2840         * DumpRenderTree/blackberry/EventSender.cpp:
2841         (keyDownCallback):
2842
2843 2012-11-09  Simon Hausmann  <simon.hausmann@digia.com>
2844
2845         Unreviewed prospective Qt/Windows build bot fix:
2846
2847         Make determination of qmake mkspec work with older versions of Qt that
2848         still create a "mkspecs/default" directory.
2849
2850         * Scripts/webkitdirs.pm:
2851         (qtMakeCommand):
2852
2853 2012-11-09  Jochen Eisinger  <jochen@chromium.org>
2854
2855         [chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests
2856         https://bugs.webkit.org/show_bug.cgi?id=101452
2857
2858         Reviewed by Adam Barth.
2859
2860         The WebTestProxy is template, so it can derive from an implementation
2861         of the WebViewClient interface. That way, WebTestProxy can hook into
2862         individual methods of the WebViewClient and forward all the rest to the
2863         actual implementation.
2864
2865         To demonstrate how I want to use this, I moved the
2866         postAccessibilityNotification method from WebViewHost to WebTestProxy.
2867
2868         * DumpRenderTree/DumpRenderTree.gypi:
2869         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added.
2870         (WebKit):
2871         (WebTestRunner):
2872         (WebTestProxyBase):
2873         (WebTestProxy):
2874         (WebTestRunner::WebTestProxy::WebTestProxy):
2875         (WebTestRunner::WebTestProxy::~WebTestProxy):
2876         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2877         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added.
2878         (WebTestRunner):
2879         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
2880         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2881         (WebTestRunner::WebTestProxyBase::setInterfaces):
2882         (WebTestRunner::WebTestProxyBase::setDelegate):
2883         (WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification):
2884         * DumpRenderTree/chromium/TestShell.cpp:
2885         (TestShell::createNewWindow):
2886         * DumpRenderTree/chromium/WebViewHost.cpp:
2887         * DumpRenderTree/chromium/WebViewHost.h:
2888         (WebViewHost):
2889
2890 2012-11-09  Simon Hausmann  <simon.hausmann@digia.com>
2891
2892         [Qt] Build with MSVC fails to use nmake instead of make
2893         https://bugs.webkit.org/show_bug.cgi?id=98645
2894
2895         Reviewed by Tor Arne Vestbø.
2896
2897         Don't rely on the "default" mkspec but instead query the target
2898         mkspec variable from qmake to find the right qmake.conf.
2899
2900         * Scripts/webkitdirs.pm:
2901         (qtMakeCommand):
2902
2903 2012-11-08  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2904
2905         [EFL] about:blank should display the blank page
2906         https://bugs.webkit.org/show_bug.cgi?id=101566
2907
2908         Reviewed by Laszlo Gombos.
2909
2910         Add a check to return early without prepending http:// scheme, if the
2911         URL is 'about:blank'.
2912
2913         * EWebLauncher/url_utils.c:
2914         (url_from_user_input):
2915
2916 2012-11-08  Christophe Dumez  <christophe.dumez@intel.com>
2917
2918         [EFL][WK2] Add proper support for fullscreen API to MiniBrowser
2919         https://bugs.webkit.org/show_bug.cgi?id=101615
2920
2921         Reviewed by Kenneth Rohde Christiansen.
2922
2923         Implement fullscreen API support in MiniBrowser. When entering
2924         fullscreen a popup is shown to notify the user that something
2925         is displayed in fullscreen and to advertise that the Escape
2926         key can be used to exit fullscreen. This behavior is according
2927         to specification.
2928
2929         * MiniBrowser/efl/main.c:
2930         (on_key_down):
2931         (on_fullscreen_accept):
2932         (on_fullscreen_deny):
2933         (on_fullscreen_enter):
2934         (on_fullscreen_exit):
2935         (window_create):
2936
2937 2012-11-08  Slavomir Kaslev  <skaslev@google.com>
2938
2939         [Chromium] DumpRenderTree fix for canvas in software compositing
2940         https://bugs.webkit.org/show_bug.cgi?id=101509
2941
2942         Reviewed by Adrienne Walker.
2943
2944         Don't use accelerated canvas 2d when in software compositing mode.
2945
2946         * DumpRenderTree/chromium/TestShell.cpp:
2947         (TestShell::runFileTest):
2948
2949 2012-11-08  Jakob Petsovits  <jpetsovits@rim.com>
2950
2951         [BlackBerry] Rework the API to use document coordinates
2952         https://bugs.webkit.org/show_bug.cgi?id=101608
2953         RIM PR 173292
2954
2955         Reviewed by Adam Treat.
2956
2957         Adapt to changed WebPage API.
2958         See Source/WebKit/blackberry/ChangeLog for details.
2959
2960         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2961         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
2962         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2963
2964 2012-11-08  Yael Aharon  <yael.aharon@intel.com>
2965
2966         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
2967         https://bugs.webkit.org/show_bug.cgi?id=101526
2968
2969         Reviewed by Kenneth Rohde Christiansen.
2970
2971         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
2972
2973         * Scripts/webkitperl/FeatureList.pm:
2974
2975 2012-11-08  Simon Hausmann  <simon.hausmann@digia.com>
2976
2977         [Qt] Fix build with MSVC 2012 and Angle
2978         https://bugs.webkit.org/show_bug.cgi?id=101588
2979
2980         Reviewed by Tor Arne Vestbø.
2981
2982         Angle includes STL's <memory> header file, which with MSVC 2012 includes stdint.h. MSVC 2012
2983         does ship stdint.h, but it's lacking other headers such as inttypes.h.
2984
2985         So for the rest of WebKit we have to continue to use our own versions of these files from
2986         JavaScriptCore/os-win32. But for Angle we are just including a shipped STL header file (memory)
2987         and so it's up to the compiler to make that work, i.e. using the stdint.h it ships.
2988
2989         This patch moves the addition of JavaScriptCore/os-win32 out of default_post.prf, so that it
2990         doesn't apply to each and every target anymore. In particular it won't apply to Angle anymore,
2991         because its presence causes a build issue where due to the addition of os-win32/ we end up
2992         including our own stdint.h but are lacking WTF/ to be in the include search path (which our own
2993         stdint.h requires). So out of default_post.prf and into WTF.pri, our own wrappers are now only
2994         used where WTF is also needed, and since os-win32/stdint.h depends on wtf/Platform.h, it seems
2995         like a logical location.
2996
2997         * qmake/mkspecs/features/default_post.prf:
2998
2999 2012-11-08  Dominik Röttsches  <dominik.rottsches@intel.com>
3000
3001         Unreviewed, rolling out r133859.
3002         http://trac.webkit.org/changeset/133859
3003         https://bugs.webkit.org/show_bug.cgi?id=101526
3004
3005         Breaks EFL bots test execution.
3006
3007         * Scripts/webkitperl/FeatureList.pm:
3008
3009 2012-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3010
3011         [Qt] Reduce the number of clean builds
3012         https://bugs.webkit.org/show_bug.cgi?id=100844
3013
3014         Reviewed by Tor Arne Vestbø.
3015
3016         A change in any Qt project file shouldn't trigger clean
3017         build always, but only if the incremental build failed.
3018
3019         * Scripts/webkitdirs.pm:
3020         (buildQMakeProjects):
3021
3022 2012-11-08  Kangil Han  <kangil.han@samsung.com>
3023
3024         [EFL][MiniBrowser] Add encoding detector option.
3025         https://bugs.webkit.org/show_bug.cgi?id=100931
3026
3027         Reviewed by Gyuyoung Kim.
3028
3029         Add a runtime option to enable/disable encoding detector.
3030
3031         * MiniBrowser/efl/main.c:
3032         (window_create):
3033         (elm_main):
3034
3035 2012-11-08  Balazs Kelemen  <kbalazs@webkit.org>
3036
3037         [Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
3038         https://bugs.webkit.org/show_bug.cgi?id=101485
3039
3040         Reviewed by Csaba Osztrogonác.
3041
3042         [Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
3043
3044         Support dumpAsText(true) which means we should not dump a render tree
3045         but should dump pixels. All other platforms already support it.
3046
3047         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3048         (WebCore::DumpRenderTree::dump):
3049         * DumpRenderTree/qt/TestRunnerQt.cpp:
3050         (TestRunner::reset):
3051         (TestRunner::dumpAsText):
3052         * DumpRenderTree/qt/TestRunnerQt.h:
3053         (TestRunner::shouldDumpPixels):
3054         (TestRunner):
3055
3056 2012-11-08  Yael Aharon  <yael.aharon@intel.com>
3057
3058         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
3059         https://bugs.webkit.org/show_bug.cgi?id=101526
3060
3061         Reviewed by Kenneth Rohde Christiansen.
3062
3063         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
3064
3065         * Scripts/webkitperl/FeatureList.pm:
3066
3067 2012-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3068
3069         Make wait-for-SVN-server.py accept empty string as revision
3070         https://bugs.webkit.org/show_bug.cgi?id=98014
3071
3072         Reviewed by Dirk Pranke.
3073
3074         * BuildSlaveSupport/wait-for-SVN-server.py:
3075         (waitForSVNRevision):
3076
3077 2012-11-07  Dirk Pranke  <dpranke@chromium.org>
3078
3079         garden-o-matic should handle concurrent requests
3080         https://bugs.webkit.org/show_bug.cgi?id=101407
3081
3082         Reviewed by Ojan Vafai.
3083
3084         Garden-o-Matic is implemented on top of the BaseHttpServer
3085         python library, which implements a single-threaded (one request at
3086         a time) server. This means that we can only rebaseline one test at
3087         a time, and when using a local results file, even fetching the results
3088         for diffs is single-threaded.
3089
3090         Mixing in the ThreadingMixin enables concurrent requests (subject
3091         to the global python interpreter lock). Given that we're doing all
3092         of the work in webkit-patch subprocesses, I think this is safe.
3093
3094         Of course, it may not be safe to do some of the subprocesses in
3095         parallel (e.g., rollout), but I think as long as we don't issue
3096         commands that touch overlapping sets of files things should be fine.
3097         The file locking over modifying testexpectations should keep that
3098         from being corrupted.
3099
3100         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3101         (GardeningHTTPServer):
3102         (GardeningHTTPRequestHandler):
3103
3104 2012-11-07  Andreas Kling  <akling@apple.com>
3105
3106         Remove build-webkit dependency on Java SDK for Apple Mac WebKit.
3107         <http://webkit.org/b/101492>
3108
3109         Reviewed by Anders Carlsson.
3110
3111         Don't check for a Java SDK before building the Apple Mac port. It's no longer needed for
3112         the build after the Java bridge was removed.
3113
3114         * Scripts/build-webkit:
3115         (cMakeArgsFromFeatures):
3116
3117 2012-11-07  Christophe Dumez  <christophe.dumez@intel.com>
3118
3119         [EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
3120         https://bugs.webkit.org/show_bug.cgi?id=101496
3121
3122         Reviewed by Kenneth Rohde Christiansen.
3123
3124         Provide implementation for on_window_geometry_get() / on_window_geometry_set()
3125         smart functions that interact with the elm_win widget.
3126
3127         * MiniBrowser/efl/main.c:
3128         (on_window_geometry_get):
3129         (on_window_geometry_set):
3130         (window_create):
3131
3132 2012-11-07  Yael Aharon  <yael.aharon@intel.com>
3133
3134         [EFL][WK2][AC] API tests crash
3135         https://bugs.webkit.org/show_bug.cgi?id=101480
3136
3137         Reviewed by Kenneth Rohde Christiansen.
3138
3139         When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests.
3140
3141         * TestWebKitAPI/efl/PlatformWebView.cpp:
3142         (TestWebKitAPI::initEcoreEvas):
3143
3144 2012-11-07  Peter Beverloo  <peter@chromium.org>
3145
3146         Don't show the Android tester in garden-o-matic yet
3147         https://bugs.webkit.org/show_bug.cgi?id=101476
3148
3149         Reviewed by Adam Barth.
3150
3151         The Android tester just started running layout tests, and doesn't upload its
3152         results yet. Don't show it for now. This exception will be removed once it
3153         has a baseline of greenness.
3154
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3156         (.):
3157
3158 2012-11-07  Balazs Kelemen  <kbalazs@webkit.org>
3159
3160         WebKitTestRunner flakily hangs when running pixel tests on Qt
3161         https://bugs.webkit.org/show_bug.cgi?id=100686
3162
3163         Reviewed by Csaba Osztrogonác.
3164
3165         Make WebKitTestRunner harden against the situation when the coordinated
3166         graphics rendering synchronisation fails. If we time out when waiting
3167         for the forced repaint to finish it usually a symptom of the synchronisation
3168         has been broken. In this case all other tests will fail with the same error.
3169         The underlying problem is not yet known. Ths patch make us report this situation
3170         as web process unresponsiveness, so the test harness will kill us and launch
3171         a new instance. This will make our pixel test bot usable while it should not limit
3172         us debugging the underlying bug.
3173
3174         * WebKitTestRunner/TestController.cpp:
3175         (WTR::TestController::run):
3176         * WebKitTestRunner/TestInvocation.cpp:
3177         (WTR::TestInvocation::TestInvocation):
3178         (WTR::TestInvocation::invoke):
3179         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
3180         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3181         * WebKitTestRunner/TestInvocation.h:
3182         (TestInvocation): Introduce new members to hold our state
3183         that was local to invoke() so far.
3184         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3185         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3186
3187 2012-11-07  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3188
3189         [Qt] Open link in this window action
3190         https://bugs.webkit.org/show_bug.cgi?id=101226
3191
3192         Reviewed by Simon Hausmann.
3193
3194         Populates the context-menu with the new action when the default action is to open in a new window.
3195
3196         * QtTestBrowser/webview.cpp:
3197         (createContextMenu):
3198
3199 2012-11-07  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3200
3201         [EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
3202         https://bugs.webkit.org/show_bug.cgi?id=101467
3203
3204         Reviewed by Kenneth Rohde Christiansen.
3205
3206         Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
3207         of default minimum contents width for non viewport meta element sites.
3208         Set default minimum contents width to '0' for MiniBrowser as it should behave like desktop browser.
3209
3210         * MiniBrowser/efl/main.c:
3211         (window_create):
3212
3213 2012-11-07  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3214
3215         [EFL] Add EFL to garden-o-matic
3216         https://bugs.webkit.org/show_bug.cgi?id=101444
3217
3218         Reviewed by Kenneth Rohde Christiansen.
3219
3220         Added the EFL bots running layout tests to the garden-o-matic report
3221         page. We are skipping here the bot that just builds WebKit EFL to make
3222         the data fetching faster.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3225         (.):
3226
3227 2012-11-07  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3228
3229         [EFL][WK2] Make EWK classes Ewk_Objects
3230         https://bugs.webkit.org/show_bug.cgi?id=101057
3231
3232         Reviewed by Kenneth Rohde Christiansen.
3233
3234         Now all the existing EWK classes share common Ewk_Object ref/unref API.
3235
3236         * MiniBrowser/efl/main.c:
3237         (close_file_picker):
3238         (on_file_chooser_request):
3239
3240 2012-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3241
3242         [Qt] Unreviewed. Add Qt EWS bots to the watchers list.
3243
3244         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3245         (QtEWS):
3246         (QtWK2EWS):
3247
3248 2012-11-07  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3249
3250         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
3251         https://bugs.webkit.org/show_bug.cgi?id=93611
3252
3253         Reviewed by Gyuyoung Kim.
3254
3255         WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
3256
3257         * WebKitTestRunner/TestController.cpp:
3258         (WTR::TestController::resetStateToConsistentValues):
3259         Enables spelling by WebKit2 C API.
3260
3261 2012-11-07  Dominik Röttsches  <dominik.rottsches@intel.com>
3262
3263         [EFL] Switch the efl-linux-slave-2 to Wk2 Release
3264         https://bugs.webkit.org/show_bug.cgi?id=101345
3265
3266         Reviewed by Gyuyoung Kim.
3267
3268         Switching efl-linux-slave-2 to Wk2 Release.
3269
3270         * BuildSlaveSupport/build.webkit.org-config/config.json:
3271
3272 2012-11-07  Christophe Dumez  <christophe.dumez@intel.com>
3273
3274         Add replaceWithLiteral() method to WTF::String
3275         https://bugs.webkit.org/show_bug.cgi?id=101257
3276
3277         Reviewed by Benjamin Poulain.
3278
3279         Add API tests for String::replaceWithLiteral() and corresponding
3280         StringImpl methods.
3281
3282         * TestWebKitAPI/CMakeLists.txt: Add WTFString API tests to CMake.
3283         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3284         (TestWebKitAPI::TEST):
3285         (TestWebKitAPI):
3286         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3287         (TestWebKitAPI::TEST):
3288
3289 2012-11-07  Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
3290
3291         [Qt] Fix build of modules depending on QtWebKit when using prefix
3292         https://bugs.webkit.org/show_bug.cgi?id=101437
3293
3294         Reviewed by Simon Hausmann.
3295
3296         Remove setting of MODULE_QMAKE_OUTDIR from here, it's been moved to .qmake.conf.
3297
3298         * qmake/mkspecs/features/default_pre.prf:
3299
3300 2012-11-06  Dan Beam  <dbeam@chromium.org>
3301
3302         Enable REQUEST_AUTOCOMPLETE for chromium port
3303         https://bugs.webkit.org/show_bug.cgi?id=101376
3304
3305         Reviewed by Adam Barth.
3306
3307         This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
3308         HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
3309
3310         * DumpRenderTree/chromium/TestShell.cpp:
3311         (TestShell::TestShell):
3312
3313         Enables the requestAutocomplete runtime feature flag during tests.
3314
3315 2012-11-06  KyungTae Kim  <ktf.kim@samsung.com>
3316
3317         [WK2][EFL] Add shortcut for setting a pagination mode on Minibrowser
3318         https://bugs.webkit.org/show_bug.cgi?id=100301
3319
3320         Reviewed by Gyuyoung Kim.
3321
3322         Setting pagination modes is for a paginated view - left to right / right to left / top to bottom / bottom to top.
3323         Assign a shortcut "F7" to set pagination modes for tests.
3324
3325         * MiniBrowser/efl/main.c:
3326         (on_key_down):
3327
3328 2012-11-06  KyungTae Kim  <ktf.kim@samsung.com>
3329
3330         [EFL][EWebLauncher] Use Ctrl +/-  to zoom in EWebLauncher
3331         https://bugs.webkit.org/show_bug.cgi?id=100207
3332
3333         Reviewed by Gyuyoung Kim.
3334
3335         Use "Ctrl -" instead of "F7" to zoom out, and use "Ctrl +" instead of "F8" to zoom in, 
3336         and use "Ctrl 0" to set to default zoom level.
3337         They are more common shortcuts on usual browsers.
3338
3339         * EWebLauncher/main.c:
3340         (on_key_down):
3341
3342 2012-11-06  Oliver Hunt  <oliver@apple.com>
3343
3344         Don't warn about RefPtr* parameters
3345         https://bugs.webkit.org/show_bug.cgi?id=101403
3346
3347         Reviewed by Gavin Barraclough.
3348
3349         RefPtr<>* is a valid parameter type.
3350
3351         * Scripts/webkitpy/style/checkers/cpp.py:
3352         (check_function_definition_and_pass_ptr):
3353         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3354         (PassPtrTest.test_ref_ptr_parameter_value):
3355
3356 2012-11-06  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3357
3358         [WTR] Reset EventSender before running each test.
3359         https://bugs.webkit.org/show_bug.cgi?id=101353
3360
3361         Reviewed by Simon Fraser.
3362
3363         Contrary to what was done to at least some ports in DumpRenderTree,
3364         EventSender did not currently reset its values in WTR. This caused
3365         flakiness if a test such as editing/selection/fake-doubleclick.html was
3366         run twice in a row, since the click count was not reset across each
3367         run.
3368
3369         * WebKitTestRunner/TestController.cpp:
3370         (WTR::TestController::TestController): Do not create m_eventSenderProxy
3371         in the constructor anymore, it is created in
3372         resetStateToConsistentValues now.
3373         (WTR::TestController::resetStateToConsistentValues): Recreate
3374         m_eventSenderProxy every time this method is run.
3375         * WebKitTestRunner/TestController.h: Make m_eventSenderProxy an OwnPtr
3376         and guard it with a platform #ifdef.
3377         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3378         (WTR::EventSenderProxy::~EventSenderProxy): Add an empty
3379         implementation.
3380         * WebKitTestRunner/mac/EventSenderProxy.mm:
3381         (WTR::EventSenderProxy::~EventSenderProxy): Ditto.
3382         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3383         (WTR::EventSenderProxy::~EventSenderProxy): Ditto.
3384
3385 2012-11-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3386
3387         [EFL][WK2] Refactor Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job to be Ewk_Objects
3388         https://bugs.webkit.org/show_bug.cgi?id=101383
3389
3390         Reviewed by Kenneth Rohde Christiansen.
3391
3392         Ewk_Auth_Request, Ewk_Url_Scheme_Request and Ewk_Download_Job are Ewk_Objects now.
3393
3394         * MiniBrowser/efl/main.c:
3395         (auth_popup_close):
3396         (on_authentication_request):
3397
3398 2012-11-06  Tommy Widenflycht  <tommyw@google.com>
3399
3400         [chromium] MediaStream API: Remove the valgrind issue with MockWebRTCPeerConnectionHandler
3401         https://bugs.webkit.org/show_bug.cgi?id=101336
3402
3403         Reviewed by Andreas Kling.
3404
3405         This patch changes the delete to delete [] to match the new[].
3406
3407         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3408
3409 2012-11-06  Mihai Balan  <mibalan@adobe.com>
3410
3411         Add Adobe's bug tracker to committers.py
3412         https://bugs.webkit.org/show_bug.cgi?id=101338
3413
3414         Reviewed by Kentaro Hara.
3415
3416         Adding Adobe's bug tracker mailing list to committers.py
3417         to enable its inclusion in the autocomplete list.
3418
3419         * Scripts/webkitpy/common/config/committers.py:
3420
3421 2012-11-06  Sami Kyostila  <skyostil@chromium.org>
3422
3423         [chromium] Enable fixed position compositing on Android DRT
3424         https://bugs.webkit.org/show_bug.cgi?id=100263
3425
3426         Reviewed by James Robinson.
3427
3428         Chrome on Android forces composited mode for every page and creates
3429         stacking contexts and graphics layers for fixed positioned elements.
3430         Change the DumpRenderTree settings to match this.
3431
3432         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3433         (main):
3434         * DumpRenderTree/chromium/TestShell.cpp:
3435         (TestShell::TestShell):
3436         (TestShell::resetWebSettings):
3437         * DumpRenderTree/chromium/TestShell.h:
3438         (TestShell::setAcceleratedCompositingForFixedPositionEnabled):
3439         (TestShell):
3440         * DumpRenderTree/chromium/WebPreferences.cpp:
3441         (WebPreferences::reset):
3442         (WebPreferences::applyTo):
3443         * DumpRenderTree/chromium/WebPreferences.h:
3444         (WebPreferences):
3445         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3446         (ChromiumAndroidPort.additional_drt_flag):
3447
3448 2012-11-06  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3449
3450         [EFL][WTR] EventSender: Get rid of the WTRMouseButton enum.
3451         https://bugs.webkit.org/show_bug.cgi?id=101340
3452
3453         Reviewed by Kenneth Rohde Christiansen.
3454
3455         Get rid of an enum which was basically a duplicate of the
3456         WKEventMouseButton one in the shared API.
3457
3458         The only difference is that it also had a case for a 4th mouse
3459         button that we treat in a special way in evasMouseButton() now.
3460
3461         * WebKitTestRunner/EventSenderProxy.h:
3462         (EventSenderProxy):
3463         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3464         (WTR::evasMouseButton):
3465         (WTR::EventSenderProxy::EventSenderProxy):
3466         (WTR::EventSenderProxy::mouseUp):
3467         (WTR::EventSenderProxy::mouseMoveTo):
3468         (WTR::EventSenderProxy::mouseScrollBy):
3469         (WTR::EventSenderProxy::leapForward):
3470
3471 2012-11-06  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3472
3473         [EFL][WK2] Minibrowser forgets http variables when url includes ampersand
3474         https://bugs.webkit.org/show_bug.cgi?id=101061
3475
3476         Reviewed by Kenneth Rohde Christiansen.
3477
3478         Elementary entry only returns 'markup' text, meaning ampersands
3479         in a url will become "&amp;". Use elm_entry_markup_to_utf8() and
3480         elm_entry_utf8_to_markup() when interacting with the entry.
3481
3482         * MiniBrowser/efl/main.c:
3483         (on_url_changed):
3484         (on_url_bar_activated):
3485
3486 2012-11-06  Balazs Kelemen  <kbalazs@webkit.org>
3487
3488         DumpRenderTree should have --pixel-tests option again
3489         https://bugs.webkit.org/show_bug.cgi?id=98648
3490
3491         Reviewed by Dirk Pranke.
3492
3493         Add back the --pixel-tests command line option to DumpRenderTree.
3494         It was removed r124581 because tools don't use it after that patch.
3495         However, it turned out that it is useful for debugging and working
3496         with pixel tests.
3497
3498         * DumpRenderTree/efl/DumpRenderTree.cpp:
3499         (parseCommandLineOptions):
3500         (runTest):
3501         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3502         (initializeGlobalsFromCommandLineOptions):
3503         (runTest):
3504         * DumpRenderTree/mac/DumpRenderTree.mm:
3505         (initializeGlobalsFromCommandLineOptions):
3506         (runTest):
3507         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3508         (isOption):
3509         (printUsage):
3510         (main):
3511         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3512         (WebCore::DumpRenderTree::processLine):
3513         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3514         (WebCore::DumpRenderTree::setShouldDumpPixelsForAllTests):
3515         (DumpRenderTree):
3516         * DumpRenderTree/win/DumpRenderTree.cpp:
3517         (runTest):
3518         (dllLauncherEntryPoint):
3519         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3520         (runTest):
3521         (MyApp::OnInit):
3522         * WebKitTestRunner/TestController.cpp:
3523         (WTR::TestController::TestController):
3524         (WTR::TestController::initialize):
3525         (WTR::TestController::runTest):
3526         * WebKitTestRunner/TestController.h:
3527         (TestController):
3528
3529 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3530
3531         webkit-patch rebaseline*: fix typo for --results-directory
3532         https://bugs.webkit.org/show_bug.cgi?id=101295
3533
3534         Reviewed by Ojan Vafai.
3535
3536         Had --results_directory instead of --results-directory in both the
3537         code and the unit test.
3538
3539         * Scripts/webkitpy/tool/commands/rebaseline.py:
3540         (AbstractParallelRebaselineCommand._rebaseline_commands):
3541         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3542         (TestRebaselineJson.test_results_directory):
3543
3544 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3545
3546         webkit-patch rebaseline*: fix handling of local file urls
3547         https://bugs.webkit.org/show_bug.cgi?id=101296
3548
3549         Reviewed by Ojan Vafai.
3550
3551         When using --results-directory, we need to make sure we're converting
3552         paths to file:/// urls for urllib to work correctly. Also, this
3553         patch reworks the unit tests to get better coverage (of the execute()
3554         command) and reduce copy/pasting of mock options.
3555
3556         * Scripts/webkitpy/tool/commands/rebaseline.py:
3557         (RebaselineTest._rebaseline_test_and_update_expectations):
3558         (RebaselineTest.execute):
3559         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3560         (TestRebaselineTest.setUp):
3561         (test_rebaseline_updates_expectations_file):
3562         (test_rebaseline_does_not_include_overrides):
3563         (test_rebaseline_test_with_results_directory):
3564         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
3565
3566 2012-11-05  Kenneth Russell  <kbr@google.com>
3567
3568         Added secondary email address and IRC nick.
3569         https://bugs.webkit.org/show_bug.cgi?id=101290
3570
3571         Unreviewed change to committers.py.
3572
3573         * Scripts/webkitpy/common/config/committers.py:
3574
3575 2012-11-05  Glenn Adams  <glenn@skynav.com>
3576
3577         Add IRC alias for Glenn Adams
3578         https://bugs.webkit.org/show_bug.cgi?id=101262
3579
3580         Reviewed by Eric Seidel.
3581
3582         Add IRC alias for Glenn Adams.
3583
3584         * Scripts/webkitpy/common/config/committers.py:
3585
3586 2012-11-05  Dima Gorbik  <dgorbik@apple.com>
3587
3588         Back out controversial changes from Bug 98665.
3589         https://bugs.webkit.org/show_bug.cgi?id=101244
3590
3591         Reviewed by David Kilzer.
3592
3593         Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
3594
3595         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3596
3597 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3598
3599         webkitpy: lint, clean up rebaseline.py
3600         https://bugs.webkit.org/show_bug.cgi?id=101240
3601
3602         Reviewed by Ojan Vafai.
3603
3604         Miscellaneous cleanup of lint errors and warnings.
3605
3606         * Scripts/webkitpy/tool/commands/rebaseline.py:
3607         (AbstractRebaseliningCommand):
3608         (RebaselineTest._test_root):
3609         (OptimizeBaselines._optimize_baseline):
3610         (OptimizeBaselines.execute):
3611         (AnalyzeBaselines.__init__):
3612         (AbstractParallelRebaselineCommand):
3613         (AbstractParallelRebaselineCommand._builders_to_fetch_from):
3614         (AbstractParallelRebaselineCommand._files_to_add):
3615         (AbstractParallelRebaselineCommand._rebaseline):
3616         (RebaselineExpectations.__init__):
3617         (Rebaseline.execute):
3618         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3619         (_BaseTestCase.setUp):
3620         (TestAnalyzeBaselines.setUp):
3621
3622 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
3623
3624         webkit-patch optimize-baselines should take a --platform arg
3625         https://bugs.webkit.org/show_bug.cgi?id=97623
3626
3627         Reviewed by Ojan Vafai.
3628
3629         So that we can optionally limit/control which platforms' results
3630         are affected.
3631
3632         This patch adds --platform to analyze-baselines as well.
3633
3634         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3635         (_baseline_search_hypergraph):
3636         (BaselineOptimizer.__init__):
3637         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3638         (TestBaselineOptimizer.__init__):
3639         (BaselineOptimizerT