Add support for Device Orientation / Motion permission API
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-08  Chris Dumez  <cdumez@apple.com>
2
3         Add support for Device Orientation / Motion permission API
4         https://bugs.webkit.org/show_bug.cgi?id=195329
5         <rdar://problem/47645367>
6
7         Reviewed by Geoffrey Garen.
8
9         Add test infrastructure to help test the Device Orientation / Motion permission API.
10
11         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
13         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
14         * WebKitTestRunner/InjectedBundle/TestRunner.h:
15         * WebKitTestRunner/TestController.cpp:
16         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
17         (WTR::TestController::createWebViewWithOptions):
18         (WTR::TestController::resetStateToConsistentValues):
19         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
20         * WebKitTestRunner/TestController.h:
21         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
22         * WebKitTestRunner/TestInvocation.cpp:
23         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
24
25 2019-03-08  Saam barati  <sbarati@apple.com>
26
27         Add a compare-results script to compare benchmark results
28         https://bugs.webkit.org/show_bug.cgi?id=195486
29         <rdar://problem/48723397>
30
31         Reviewed by Geoffrey Garen.
32
33         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
34         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
35         to extend it to learn about our other benchmarks.
36
37         * Scripts/compare-results: Added.
38         (readJSONFile):
39         (detectJetStream2):
40         (JetStream2Results):
41         (detectSpeedometer2):
42         (Speedometer2Results):
43         (detectPLT5):
44         (PLT5Results):
45         (detectBenchmark):
46         (biggerIsBetter):
47         (ttest):
48         (getOptions):
49         (main):
50
51 2019-03-08  Stephanie Lewis  <slewis@apple.com>
52
53         Ensure old tab state is cleared between iterations of run-benchmark
54         https://bugs.webkit.org/show_bug.cgi?id=195393
55         <rdar://problem/46885583>
56
57         Reviewed by Dewei Zhu.
58
59         a) ensure the default to restore state is not set
60         b) terminate Safari correctly
61         c) Set the system default to ignore Persistent State in Safari
62
63         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
64         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
65         (OSXBrowserDriver.prepare_env): 
66         (OSXBrowserDriver.restore_env):
67         (OSXBrowserDriver.close_browsers):
68         (OSXBrowserDriver._terminate_processes):
69         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
70         (OSXChromeDriver):
71         (OSXChromeCanaryDriver):
72         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
73         (OSXFirefoxDriver):
74         (OSXFirefoxNightlyDriver):
75         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
76         (OSXSafariDriver):
77         (OSXSafariDriver.prepare_env):
78
79 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
80
81         [GTK] Several InputMethodFilter tests are failing
82         https://bugs.webkit.org/show_bug.cgi?id=195408
83
84         Reviewed by Carlos Garcia Campos.
85
86         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
87         Regressed in r241751.
88         Hexadecimal values of keycodes are expressed now in upper letters.
89         Composited characters should be cast to UTF8 strings.
90
91         (TestWebKitAPI::TEST):
92
93 2019-03-07  Tomas Popela  <tpopela@redhat.com>
94
95         [GTK] Make Tools/gtkdoc python3 compatible
96         https://bugs.webkit.org/show_bug.cgi?id=195359
97
98         Reviewed by Carlos Garcia Campos.
99
100         * gtkdoc/generate-gtkdoc:
101         ConfigParser was reworked in Python 3.2 so we have adapt the code to
102         work with Python 2 and 3.
103         (get_gtkdoc_module_paths):
104         The iteritems() was removed in Python 3, so let's use items() that's
105         available in Python 2 and 3.
106         (get_generator_for_config):
107         * gtkdoc/gtkdoc.py:
108         (GTKDoc._run_command):
109         The sys.stdout.write() is expecting str in Python 3 and not bytes
110         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
111         for passing the bytes there.
112
113 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
114
115         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
116         https://bugs.webkit.org/show_bug.cgi?id=195346
117         <rdar://problem/48667048>
118
119         Unreviewed build fix for clang-cl.
120
121         * DumpRenderTree/win/DumpRenderTree.cpp:
122         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
123
124 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
125
126         requestAnimationFrame should execute before the next frame
127         https://bugs.webkit.org/show_bug.cgi?id=177484
128
129         Reviewed by Simon Fraser.
130
131         Add trace points for the page RenderingUpdate.
132
133         * Tracing/SystemTracePoints.plist:
134
135 2019-03-07  Zalan Bujtas  <zalan@apple.com>
136
137         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
138         https://bugs.webkit.org/show_bug.cgi?id=195353
139         <rdar://problem/48626394>
140
141         Reviewed by Simon Fraser.
142
143         * WebKitTestRunner/ios/TestControllerIOS.mm:
144         (WTR::TestController::platformResetPreferencesToConsistentValues):
145
146 2019-03-07  John Wilander  <wilander@apple.com>
147
148         Resource Load Statistics: Make it possible to purge only script-accessible cookies
149         https://bugs.webkit.org/show_bug.cgi?id=195383
150         <rdar://problem/48570136>
151
152         Reviewed by Brent Fulgham.
153
154         This patch adds test infrastructure to purge only script-accessible cookies,
155         including a new testRunner function called statisticsDeleteCookiesForHost().git a
156
157         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
158         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
159         (WTR::TestRunner::statisticsDeleteCookiesForHost):
160         * WebKitTestRunner/InjectedBundle/TestRunner.h:
161         * WebKitTestRunner/TestController.cpp:
162         (WTR::TestController::statisticsDeleteCookiesForHost):
163         * WebKitTestRunner/TestController.h:
164         * WebKitTestRunner/TestInvocation.cpp:
165         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
166
167 2019-03-07  Commit Queue  <commit-queue@webkit.org>
168
169         Unreviewed, rolling out r242354.
170         https://bugs.webkit.org/show_bug.cgi?id=195402
171
172         breaks layout tests in all configurations (Requested by
173         zdobersek on #webkit).
174
175         Reverted changeset:
176
177         "[WPE] Enable web process sandbox"
178         https://bugs.webkit.org/show_bug.cgi?id=195169
179         https://trac.webkit.org/changeset/242354
180
181 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
182
183         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
184         https://bugs.webkit.org/show_bug.cgi?id=195346
185
186         Reviewed by Fujii Hironori.
187
188         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
189         (TestWebKitAPI::TEST):
190         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
191
192         * DumpRenderTree/win/DumpRenderTree.cpp:
193         (findFontFallback):
194         (addFontFallbackIfPresent):
195         (removeFontFallbackIfPresent):
196         (main):
197         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
198         (TestWebKitAPI::Util::moduleDirectory):
199         (TestWebKitAPI::Util::createInjectedBundlePath):
200         Use wchar helpers as needed.
201
202 2019-03-06  Rob Buis  <rbuis@igalia.com>
203
204         Consider supporting the `referrerpolicy` attribute.
205         https://bugs.webkit.org/show_bug.cgi?id=179053
206
207         Reviewed by Darin Adler.
208
209         Add a runtime flag for referrerpolicy attribute.
210
211         * DumpRenderTree/mac/DumpRenderTree.mm:
212         (enableExperimentalFeatures):
213
214 2019-03-05  Daniel Bates  <dabates@apple.com>
215
216         Update expected API test result following r242379
217         (https://bugs.webkit.org/show_bug.cgi?id=195125)
218
219         Update expected x-coordinate of selection rect now that the left padding of
220         a textarea is sized in ems (so dependent on the font size) just like the left
221         padding of a text field.
222
223         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
224         (TestWebKitAPI::TEST):
225
226 2019-03-05  David Quesada  <david_quesada@apple.com>
227
228         [WK2] It should be possible to follow links with 'download' attributes
229         https://bugs.webkit.org/show_bug.cgi?id=195145
230         rdar://problem/48462642
231
232         Reviewed by Alex Christensen.
233
234         Add a unit test to verify that activating links with 'download' attributes now
235         navigates to the linked resource, rather than starts downloading it. Add another
236         to verify that it is still possible to explicitly download the link via the
237         'Download' navigation action policy.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
240         (-[DownloadAttributeTestDelegate init]):
241         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
242         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
243         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
244         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
245         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
246         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
247         (TEST):
248         * WebKitTestRunner/TestController.cpp:
249         (WTR::TestController::decidePolicyForNavigationAction):
250         * WebKitTestRunner/TestController.h:
251
252 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
253
254         [Curl] Implement Cookie Accept Policy.
255         https://bugs.webkit.org/show_bug.cgi?id=191645
256
257         Reviewed by Fujii Hironori.
258
259         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
260         (TestWebKitAPI::Curl::TEST_F):
261
262 2019-03-05  Youenn Fablet  <youenn@apple.com>
263
264         Rename requestCacheStorageSpace to requestStorageSpace
265         https://bugs.webkit.org/show_bug.cgi?id=195282
266
267         Reviewed by Chris Dumez.
268
269         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
270         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
271         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
272
273 2019-03-05  Brady Eidson  <beidson@apple.com>
274
275         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
276         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
277
278         Reviewed by Tim Horton.
279
280         Loading a file: URL into a WKWebView and then loading another file: url from a completely
281         different directory into that same WKWebView should work.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
285
286 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
287
288         Add WeakHashSet
289         https://bugs.webkit.org/show_bug.cgi?id=195152
290
291         Reviewed by Antti Koivisto.
292
293         Added tests for WeakHashSet.
294
295         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
296         (TestWebKitAPI::Base::Base): Moved.
297         (TestWebKitAPI::Derived::foo): Moved.
298         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
299         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
300         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
301         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
302
303 2019-03-04  Chris Dumez  <cdumez@apple.com>
304
305         Do not share WebProcesses between private and regular sessions
306         https://bugs.webkit.org/show_bug.cgi?id=195189
307         <rdar://problem/48421064>
308
309         Reviewed by Alex Christensen.
310
311         Add API test coverage.
312
313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
314         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
315
316 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
317
318         [WPE] Enable web process sandbox
319         https://bugs.webkit.org/show_bug.cgi?id=195169
320
321         Reviewed by Daniel Bates.
322
323         * wpe/install-dependencies:
324         * wpe/jhbuild.modules:
325
326 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
327
328         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
329         https://bugs.webkit.org/show_bug.cgi?id=195206
330
331         Reviewed by Žan Doberšek.
332
333         Add a new test case.
334
335         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
336         (testJSCClass):
337
338 2019-03-04  Charlie Turner  <cturner@igalia.com>
339
340         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
341         https://bugs.webkit.org/show_bug.cgi?id=194898
342
343         Reviewed by Žan Doberšek.
344
345         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
346         a GCC extension that permits arithmetic on void* pointer. Inline
347         the macro until this issue is fixed upstream.
348
349 2019-03-03  Tim Horton  <timothy_horton@apple.com>
350
351         Rid the world of WK_API_ENABLED
352         https://bugs.webkit.org/show_bug.cgi?id=195263
353
354         Reviewed by Dan Bernstein.
355
356         List of changed files elided because it's useless.
357
358 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
359
360         Unreviewed follow-up to r242292.
361
362         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
363
364         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
365         (TestWebKitAPI::testStrip): Renamed from strip.
366         (TestWebKitAPI::TEST):
367
368 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
369
370         Unreviewed, remove accidentally-committed URLHelpers.cpp test
371
372         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
373         and bug #194272 for details.
374
375         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
376
377 2019-03-03  Tim Horton  <timothy_horton@apple.com>
378
379         Remove some more unused 32-bit code
380         https://bugs.webkit.org/show_bug.cgi?id=195255
381
382         Reviewed by Darin Adler.
383
384         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
385         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
386         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
387         (NPP_New):
388         (NPP_HandleEvent):
389         (handleEventCarbon): Deleted.
390
391 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
392
393         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
394
395         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
396         (TestWebKitAPI::TEST):
397
398 2019-03-01  Darin Adler  <darin@apple.com>
399
400         Finish removing String::format
401         https://bugs.webkit.org/show_bug.cgi?id=194893
402
403         Reviewed by Daniel Bates.
404 '
405         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
406
407 2019-03-01  Alex Christensen  <achristensen@webkit.org>
408
409         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
410         https://bugs.webkit.org/show_bug.cgi?id=195229
411         <rdar://problem/48520362>
412
413         Reviewed by Chris Dumez.
414
415         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
416         (TEST):
417
418 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
419
420         Add a system trace scope for event region building
421         https://bugs.webkit.org/show_bug.cgi?id=195226
422
423         Reviewed by Jon Lee.
424
425         This trace scope measures the time spend converting element rects into Region objects,
426         which can be large on some pages.
427
428         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
429
430         * Tracing/SystemTracePoints.plist:
431
432 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
433
434         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
435         https://bugs.webkit.org/show_bug.cgi?id=194612
436
437         Reviewed by Alex Christensen.
438
439         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
440         Just test the new string-processing function and don't touch the actual environment.
441         (Test cases are all as before, but based on operator== instead of strcmp.)
442
443 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
444
445         [ews-app] Update primary keys for handling multiple Buildbot instances
446         https://bugs.webkit.org/show_bug.cgi?id=195120
447
448         Reviewed by Stephanie Lewis.
449
450         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
451         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
452         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
453
454         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
455         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
456         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
457         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
458         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
459         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
460
461 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
462
463         [WinCairo] Enable service worker
464         https://bugs.webkit.org/show_bug.cgi?id=188318
465
466         Reviewed by Youenn Fablet.
467
468         * DumpRenderTree/DumpRenderTreePrefix.h:
469         * TestWebKitAPI/PlatformWin.cmake:
470         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
471         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
472         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
473
474 2019-03-01  Justin Fan  <justin_fan@apple.com>
475
476         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
477         https://bugs.webkit.org/show_bug.cgi?id=195191
478
479         Rubber-stamped by Dean Jackson.
480
481         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
482
483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
484
485 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
486
487         Unreviewed, fix lldb webkitpy tests
488         https://bugs.webkit.org/show_bug.cgi?id=194375
489
490         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
491
492         * lldb/lldb_webkit.py:
493         (WTFStringImplProvider.is_8bit):
494
495 2019-02-28  David Quesada  <david_quesada@apple.com>
496
497         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
498         https://bugs.webkit.org/show_bug.cgi?id=195121
499         rdar://problem/48450302
500
501         Reviewed by Alex Christensen.
502
503         Add API tests for -WKNavigationAction._shouldPerformDownload in various
504         configurations where the 'download' attribute is absent, blank, or populated
505         with a filename, and where the anchor element is same-origin or cross-origin
506         (meaning the 'download' attribute shouldn't be honored).
507
508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
509         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
510         (-[NavigationActionTestDelegate init]):
511         (-[NavigationActionTestDelegate navigationAction]):
512         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
513         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
514         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
515         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
516         (TEST):
517
518 2019-02-28  Antoine Quint  <graouts@apple.com>
519
520         Enable the Pointer Events runtime flag by default
521         https://bugs.webkit.org/show_bug.cgi?id=195156
522
523         Reviewed by Dean Jackson.
524
525         * DumpRenderTree/mac/DumpRenderTree.mm:
526         (enableExperimentalFeatures):
527
528 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         Several PasteImage API tests are flaky
531         https://bugs.webkit.org/show_bug.cgi?id=195160
532
533         Reviewed by Tim Horton.
534
535         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
536         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
537         listening for a "load" event after image load is already complete.
538
539         To address this, make these tests first register a "load" event handler, then run script to insert an image
540         element into the document, and finally wait until the load event is observed before checking image size.
541
542         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
543
544 2019-02-28  Chris Dumez  <cdumez@apple.com>
545
546         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
547         https://bugs.webkit.org/show_bug.cgi?id=195107
548
549         Reviewed by Alex Christensen.
550
551         Give some time for the zoom level to get restored.
552
553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
554
555 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
556
557         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
558         https://bugs.webkit.org/show_bug.cgi?id=194958
559
560         Reviewed by Geoffrey Garen.
561
562         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
563         (TEST):
564
565 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
566
567         [ews-app] Update method to save build to handle builder_display_name
568         https://bugs.webkit.org/show_bug.cgi?id=195047
569
570         Reviewed by Dewei Zhu.
571
572         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
573         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
574
575 2019-02-28  Justin Fan  <justin_fan@apple.com>
576
577         [Web GPU] Enable Web GPU only on 64-bit
578         https://bugs.webkit.org/show_bug.cgi?id=195139
579
580         Because Metal is only supported on 64 bit apps.
581
582         Unreviewed build fix.
583
584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
585
586 2019-02-27  Youenn Fablet  <youenn@apple.com>
587
588         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
589         https://bugs.webkit.org/show_bug.cgi?id=194959
590
591         Reviewed by Chris Dumez.
592
593         Spin loop until getting the condition to remove flakiness.
594
595         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
596
597 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-build] Buildbot should include builder_display_name in the build events
600         https://bugs.webkit.org/show_bug.cgi?id=195045
601
602         Reviewed by Dewei Zhu.
603
604         * BuildSlaveSupport/ews-build/events.py:
605         (Events.buildStarted): Included builder_display_name in event data. Also renamed
606         buildername to builder_name to be consistent in naming style.
607         (Events.buildFinished): Ditto.
608
609 2019-02-27  Chris Dumez  <cdumez@apple.com>
610
611         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
612         https://bugs.webkit.org/show_bug.cgi?id=194480
613
614         Reviewed by Brady Eidson.
615
616         Update existing API test to make it more likely to reproduce the issue.
617
618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
619
620 2019-02-27  Brady Eidson  <beidson@apple.com>
621
622         Universal links from Google search results pages don't open the app.
623         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
624
625         Reviewed by Geoffrey Garen.
626
627         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
628         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
629         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
630         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
631
632 2019-02-27  Chris Dumez  <cdumez@apple.com>
633
634         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
635         https://bugs.webkit.org/show_bug.cgi?id=195102
636
637         Reviewed by Geoffrey Garen.
638
639         If the number of processes is not yet what we expect, wait a bit and check again to give
640         processes some time to exit.
641
642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
643
644 2019-02-27  Chris Dumez  <cdumez@apple.com>
645
646         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
647         https://bugs.webkit.org/show_bug.cgi?id=194545
648
649         Reviewed by Brady Eidson.
650
651         Make sure the test navigates forward and then back only once. Previously, navigating
652         back would trigger a navigation again in a timer.
653
654         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
655
656 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
657
658         High Sierra Debug JSC test queue should use faster hardware
659         https://bugs.webkit.org/show_bug.cgi?id=194603
660
661         Rubber-stamped by Alexey Proskuryakov.
662
663         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
664
665         * BuildSlaveSupport/build.webkit.org-config/config.json:
666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
667         (BubbleQueueServer):
668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
669         (WebKitBuildbot):
670         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
671         * QueueStatusServer/config/queues.py:
672         * Scripts/webkitpy/common/config/ews.json:
673         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
674         (test_ews_name):
675
676 2019-02-27  John Wilander  <wilander@apple.com>
677
678         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
679         https://bugs.webkit.org/show_bug.cgi?id=195071
680         <rdar://problem/48417690>
681
682         Reviewed by Alex Christensen and Brent Fulgham.
683
684         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
685         (TestWebKitAPI::createURL):
686             Convenience function.
687         (TestWebKitAPI::TEST):
688             WebCore::AdClickAttribution now takes a URL when creating Source and
689             Destination.
690         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
691         (TestWebKitAPI::TEST):
692             WebCore::AdClickAttribution now takes a URL when creating Source and
693             Destination.
694
695 2019-02-27  Antoine Quint  <graouts@apple.com>
696
697         Support Pointer Events on macOS
698         https://bugs.webkit.org/show_bug.cgi?id=195008
699         <rdar://problem/47454419>
700
701         Reviewed by Dean Jackson.
702
703         * DumpRenderTree/mac/DumpRenderTree.mm:
704         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
705         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
706
707 2019-02-26  Mark Lam  <mark.lam@apple.com>
708
709         Remove remaining poisoning code.
710         https://bugs.webkit.org/show_bug.cgi?id=194138
711
712         Reviewed by Saam Barati.
713
714         * TestWebKitAPI/CMakeLists.txt:
715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
716         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
717         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
718         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
719         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
720         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
721         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
722
723 2019-02-26  Alex Christensen  <achristensen@webkit.org>
724
725         Move ephemeral local storage from WebProcess to UIProcess
726         https://bugs.webkit.org/show_bug.cgi?id=195074
727         <rdar://problem/47937975>
728
729         Reviewed by Geoff Garen.
730
731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
732
733 2019-02-20  Jer Noble  <jer.noble@apple.com>
734
735         [Cocoa] Media elements will restart network buffering just before suspending
736         https://bugs.webkit.org/show_bug.cgi?id=193691
737
738         Reviewed by Eric Carlson.
739
740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
742         (TEST):
743
744 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
745
746         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
747         https://bugs.webkit.org/show_bug.cgi?id=191652
748
749         Reviewed by Alex Christensen.
750
751         Fix WinCairo MiniBrowser behavior of authentication dialog.
752
753         * MiniBrowser/win/WebKitBrowserWindow.cpp:
754         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
755
756 2019-02-26  Youenn Fablet  <youenn@apple.com>
757
758         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
759         https://bugs.webkit.org/show_bug.cgi?id=195028
760         <rdar://problem/48243733>
761
762         Reviewed by Eric Carlson.
763
764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
765
766 2019-02-26  Philippe Normand  <pnormand@igalia.com>
767
768         [WPE] Add API for webview background color configuration
769         https://bugs.webkit.org/show_bug.cgi?id=192305
770
771         Reviewed by Michael Catanzaro.
772
773         * MiniBrowser/wpe/main.cpp:
774         (main): Add a new option to configure the webview background
775         color. Example: --bg-color=transparent.
776         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
777         (testWebViewBackgroundColor): Enable background color API tests for WPE.
778         (beforeAll): Ditto.
779
780 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
781
782         scalableNativeWebpageParameters() is not preserved on new page navigation.
783         https://bugs.webkit.org/show_bug.cgi?id=194892
784         <rdar://problem/47538280>
785
786         Reviewed by Wenson Hsieh.
787         
788         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
789
790         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
791         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
792         * DumpRenderTree/mac/UIScriptControllerMac.mm:
793         (WTR::UIScriptController::allowsViewportShrinkToFit):
794         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
795         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
796         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
797         * TestRunnerShared/UIScriptContext/UIScriptController.h:
798         * WebKitTestRunner/UIScriptControllerCocoa.mm:
799         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
800
801 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews-app] Add model for handling multiple Buildbot instances
804         https://bugs.webkit.org/show_bug.cgi?id=194863
805
806         Reviewed by Stephanie Lewis.
807
808         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
809
810 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-app] Remove BuilderMapping table
813         https://bugs.webkit.org/show_bug.cgi?id=194961
814
815         Reviewed by Stephanie Lewis.
816
817         Store builder name directly in build table, instead of having a separate
818         table for it.
819
820         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
821         * BuildSlaveSupport/ews-app/ews/models/build.py:
822         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
823         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
824
825 2019-02-25  John Wilander  <wilander@apple.com>
826
827         Introduce and adopt new class RegistrableDomain for eTLD+1
828         https://bugs.webkit.org/show_bug.cgi?id=194791
829         <rdar://problem/48179240>
830
831         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
832
833         This patch adds an API test and replaces two instances of
834         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
835
836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
837         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
838         (TestWebKitAPI::TEST):
839             Changed two strings to make sure the registrable domains are still considered
840             invalid and pass the test.
841         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
842         (TestWebKitAPI::TEST):
843         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
844         (WTR::InjectedBundle::didReceiveMessageToPage):
845
846 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
847
848         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
849         https://bugs.webkit.org/show_bug.cgi?id=195001
850
851         Reviewed by Carlos Garcia Campos.
852
853         API version 1.0 always includes the functionality previously guarded with
854         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
855         unconditionally.
856
857         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
858         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
859         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
860         (WebViewTest::showInWindow): Ditto.
861         (WebViewTest::hideView): Ditto.
862         * wpe/backends/HeadlessViewBackend.cpp:
863         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
864         * wpe/backends/ViewBackend.cpp:
865         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
866         * wpe/backends/WindowViewBackend.cpp:
867         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
868         WPE_BACKEND_CHECK_VERSION().
869         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
870
871 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
872
873         [Flatpak] Add support for flatpak > 1.1.2
874         https://bugs.webkit.org/show_bug.cgi?id=194088
875
876         Flatpak 1.2 is now out so we need to support that
877         version now.
878
879         Reviewed by Michael Catanzaro.
880
881         * flatpak/flatpakutils.py:
882         (check_flatpak):
883         (FlatpakPackages.__init__):
884         (FlatpakPackages.__detect_packages):
885         (FlatpakPackages.__detect_packages.in):
886         (FlatpakRepos.update):
887
888 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
889
890         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
891         https://bugs.webkit.org/show_bug.cgi?id=194998
892
893         Reviewed by Carlos Garcia Campos.
894
895         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
896         to a Git checkout and using the latest commit containing various fixes
897         and improvements.
898
899 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
900
901         [WPE][GTK] Remove user agent quirk for washingtonpost.com
902         https://bugs.webkit.org/show_bug.cgi?id=194981
903
904         Reviewed by Žan Doberšek.
905
906         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
907         (TestWebKitAPI::TEST):
908
909 2019-02-23  Keith Miller  <keith_miller@apple.com>
910
911         Add new mac target numbers
912         https://bugs.webkit.org/show_bug.cgi?id=194955
913
914         Reviewed by Tim Horton.
915
916         * DumpRenderTree/mac/Configurations/Base.xcconfig:
917         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
918         * MiniBrowser/Configurations/Base.xcconfig:
919         * TestWebKitAPI/Configurations/Base.xcconfig:
920         * WebKitTestRunner/Configurations/Base.xcconfig:
921
922 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
923
924         [WinCairo] Enable wk1/wk2 suffix for platform search path.
925         https://bugs.webkit.org/show_bug.cgi?id=194846
926
927         Reviewed by Don Olmstead.
928
929         Added _search_paths() and _port_specific_expectations_files() for
930         WinCairoPort.
931
932         * Scripts/webkitpy/port/win.py:
933         (WinCairoPort.default_baseline_search_path):
934         (WinCairoPort):
935         (WinCairoPort._port_specific_expectations_files):
936         (WinCairoPort._search_paths):
937
938 2019-02-22  Tim Horton  <timothy_horton@apple.com>
939
940         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
941         https://bugs.webkit.org/show_bug.cgi?id=194963
942
943         Reviewed by Dean Jackson.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
946         Do a `contains` check instead of `equals`, because in debug builds we
947         put the GraphicsLayer pointer in a prefix.
948
949 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
950
951         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
952         https://bugs.webkit.org/show_bug.cgi?id=194873
953         <rdar://problem/46701974>
954
955         Reviewed by Tim Horton.
956
957         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
958
959         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
960         (WTR::UIScriptController::menuRect const):
961         (WTR::UIScriptController::isShowingMenu const):
962         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
963         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
964         (WTR::UIScriptController::menuRect const):
965
966         Add a function to query the bounds of the callout menu in content coordinates.
967
968         (WTR::UIScriptController::isShowingMenu const):
969
970         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
971
972         * TestRunnerShared/UIScriptContext/UIScriptController.h:
973         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
974         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
975         (WTR::UIScriptController::rectForMenuAction const):
976         (WTR::UIScriptController::menuRect const):
977         (WTR::UIScriptController::isShowingMenu const):
978         (WTR::findViewInHierarchyOfType): Deleted.
979
980 2019-02-22  Chris Dumez  <cdumez@apple.com>
981
982         Regression(PSON) Unable to preview password-protected documents on iCloud.com
983         https://bugs.webkit.org/show_bug.cgi?id=194954
984         <rdar://problem/48127957>
985
986         Reviewed by Alex Christensen.
987
988         Add API test coverage.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
991         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
992         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
993         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
994
995 2019-02-22  Chris Dumez  <cdumez@apple.com>
996
997         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
998         https://bugs.webkit.org/show_bug.cgi?id=194924
999         <rdar://problem/48216125>
1000
1001         Reviewed by Geoffrey Garen.
1002
1003         Add API test coverage.
1004
1005         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1006
1007 2019-02-22  Chris Dumez  <cdumez@apple.com>
1008
1009         Unreviewed, disable API test added in r241928 on iOS.
1010
1011         The cache is not enabled on devices with less than 3GB of RAM.
1012
1013         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1014
1015 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1016
1017         Hardcode Visual Viewports on everywhere except iOS WK1
1018         https://bugs.webkit.org/show_bug.cgi?id=194928
1019
1020         Reviewed by Zalan Bujtas.
1021
1022         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1023         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1024         set it to false. The setting has shipped for several years and there's no need to turn
1025         it off now.
1026
1027         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1028         Visual Viewports are not enabled.
1029         
1030         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1031         that only runs in WK2
1032
1033         * MiniBrowser/mac/SettingsController.h:
1034         * MiniBrowser/mac/SettingsController.m:
1035         (-[SettingsController init]):
1036         (-[SettingsController _populateMenu]):
1037         (-[SettingsController validateMenuItem:]):
1038         (-[SettingsController visualViewportEnabled]): Deleted.
1039         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1040         * MiniBrowser/mac/WK1BrowserWindowController.m:
1041         (-[WK1BrowserWindowController didChangeSettings]):
1042         * MiniBrowser/mac/WK2BrowserWindowController.m:
1043         (-[WK2BrowserWindowController didChangeSettings]):
1044
1045 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1046
1047         Discard cached processes when clearing website data store
1048         https://bugs.webkit.org/show_bug.cgi?id=194894
1049
1050         Reviewed by Chris Dumez.
1051
1052         Added a test case.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1055         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1056
1057 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1058
1059         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1060         https://bugs.webkit.org/show_bug.cgi?id=194914
1061         <rdar://problem/47586889>
1062
1063         Reviewed by Geoffrey Garen.
1064
1065         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1066         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1067         (TEST):
1068         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1069
1070 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1071
1072         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1073         <https://webkit.org/b/194761>
1074
1075         Reviewed by Myles Maxfield.
1076
1077         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1078         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1079         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1080         to use ARC-compliant cast.
1081         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1082         ARC-compliant cast.
1083         (WTR::installFakeHelvetica): Log `error` to console if
1084         CTFontManagerRegisterFontsForURL() fails, but only on supported
1085         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1086         Call CFRelease() on `error` to fix the leak.  Update to use
1087         ARC-compliant cast.
1088         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1089         cast.
1090
1091 2019-02-21  Chris Dumez  <cdumez@apple.com>
1092
1093         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1094         https://bugs.webkit.org/show_bug.cgi?id=194481
1095
1096         Reviewed by Alex Christensen.
1097
1098         Give the processes a chance to shutdown and wait until we reached the expected number
1099         of processes.
1100
1101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1102
1103 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1104
1105         Fix the macOS build
1106
1107         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1108
1109 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1110
1111         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1112
1113         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1114         I am a backwards.
1115
1116 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1117
1118         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1119
1120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1121         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1122         We could force on UI-side compositing, but I feel like the test might be more
1123         valuable exercising the normal path on each platform (though the original
1124         bug was also UI-side specific). Though we can't validate that the overlay
1125         layer was installed successfully, there are layout tests that do that.
1126
1127 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1128
1129         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1130         https://bugs.webkit.org/show_bug.cgi?id=194845
1131         <rdar://problem/47944579>
1132
1133         Reviewed by Antti Koivisto.
1134
1135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1137
1138 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1139
1140         [LFC][Floats] Add support for placing formatting roots in-between floats.
1141         https://bugs.webkit.org/show_bug.cgi?id=194902
1142
1143         Reviewed by Antti Koivisto.
1144
1145         * LayoutReloaded/misc/LFC-passing-tests.txt:
1146
1147 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1148
1149         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1150         https://bugs.webkit.org/show_bug.cgi?id=194901
1151
1152         Unreviewed build fix.
1153
1154         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1155         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1156         WPEBackend-fdo-0.1 as library name.
1157
1158 2019-02-21  Rob Buis  <rbuis@igalia.com>
1159
1160         Update MIME type parser
1161         https://bugs.webkit.org/show_bug.cgi?id=180526
1162
1163         Reviewed by Darin Adler.
1164
1165         Add tests involving leading and trailing whitespace, non-token
1166         characters and quoted strings.
1167
1168         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1169         (TestWebKitAPI::TEST):
1170
1171 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1172
1173         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1174         https://bugs.webkit.org/show_bug.cgi?id=194884
1175
1176         Reviewed by Michael Catanzaro.
1177
1178         * PlatformWin.cmake:
1179
1180 2019-02-20  Chris Dumez  <cdumez@apple.com>
1181
1182         Add API test for <rdar://problem/47471222>
1183         https://bugs.webkit.org/show_bug.cgi?id=194847
1184
1185         Reviewed by Alex Christensen.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1188
1189 2019-02-20  Chris Dumez  <cdumez@apple.com>
1190
1191         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1192         https://bugs.webkit.org/show_bug.cgi?id=194872
1193         <rdar://problem/47924500>
1194
1195         Reviewed by Alex Christensen.
1196
1197         Add API test coverage.
1198
1199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1200
1201 2019-02-20  Jer Noble  <jer.noble@apple.com>
1202
1203         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1204         https://bugs.webkit.org/show_bug.cgi?id=191332
1205
1206         Reviewed by Dean Jackson.
1207
1208         * Scripts/git-is-in-range: Added.
1209
1210 2019-02-20  Andy Estes  <aestes@apple.com>
1211
1212         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1213         https://bugs.webkit.org/show_bug.cgi?id=194869
1214
1215         Rubber-stamped by Jer Noble.
1216
1217         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1218         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1219         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1220         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1222         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1223
1224 2019-02-20  Chris Dumez  <cdumez@apple.com>
1225
1226         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1227         https://bugs.webkit.org/show_bug.cgi?id=194857
1228         <rdar://problem/47759323>
1229
1230         Reviewed by Alex Christensen.
1231
1232         Add API test coverage.
1233
1234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1235
1236 2019-02-20  Chris Dumez  <cdumez@apple.com>
1237
1238         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1239         https://bugs.webkit.org/show_bug.cgi?id=194829
1240         <rdar://problem/47889906>
1241
1242         Reviewed by Alexey Proskuryakov.
1243
1244         Every time the TestOptions were changing we were creating both a new Web view and
1245         a new WKContext, which would start a new Network process. In most cases, we only
1246         need to contruct a new Web view and we do can keep reusing the same WKContext.
1247         This patch implements this optimization and thus avoids spinning a lot of new
1248         Network processes while running the layout tests.
1249
1250         * WebKitTestRunner/TestController.cpp:
1251         (WTR::TestController::generateContextConfiguration const):
1252         (WTR::TestController::generatePageConfiguration):
1253         (WTR::TestController::createWebViewWithOptions):
1254         (WTR::TestController::resetPreferencesToConsistentValues):
1255         (WTR::updateTestOptionsFromTestHeader):
1256         * WebKitTestRunner/TestController.h:
1257         * WebKitTestRunner/TestOptions.h:
1258         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1259         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1260         (WTR::TestOptions::hasSameInitializationOptions const):
1261         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1262         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1263         (WTR::TestController::platformAddTestOptions const):
1264
1265 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1266
1267         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1268         https://bugs.webkit.org/show_bug.cgi?id=167941
1269
1270         Reviewed by Carlos Garcia Campos.
1271
1272         * MiniBrowser/gtk/main.c:
1273         (filterSavedCallback): Added.
1274         (main): Support loading a JSON rule set file for content filtering.
1275         * MiniBrowser/wpe/main.cpp:
1276         (filterSavedCallback): Added.
1277         (main): Support loading a JSON rule set file for content filtering.
1278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1279         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1280         (WTF::derefGPtr): Ditto.
1281         (testEmptyStore):
1282         (testSaveInvalidFilter):
1283         (testSaveLoadFilter):
1284         (testSavedFilterIdentifierMatch):
1285         (testRemoveFilter):
1286         (testSaveMultipleFilters):
1287         (testSaveFilterFromFile):
1288         (testFilterPersistence):
1289         (beforeAll):
1290         (afterAll):
1291         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1292         (removeOldInjectedContentAndResetLists): Also reset content filters.
1293         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1294         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1295         the element affected by the style sheet.
1296         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1297         and returns it to be used by tests.
1298         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1299         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1300         (serverCallback): Add support for serving a CSS style sheet for testing.
1301         (beforeAll): Add call to testUserContentManagerContentFilter().
1302         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1303
1304 2019-02-19  Keith Rollin  <krollin@apple.com>
1305
1306         Add timing information to build output
1307         https://bugs.webkit.org/show_bug.cgi?id=194839
1308         <rdar://problem/48219609>
1309
1310         Reviewed by Alexey Proskuryakov.
1311
1312         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1313         emit each project's build time to its output. E.g.,
1314
1315             ** BUILD SUCCEEDED ** [0.132 sec]
1316
1317         * Scripts/webkitdirs.pm:
1318         (XcodeOptions):
1319
1320 2019-02-19  Truitt Savell  <tsavell@apple.com>
1321
1322         Unreviewed, rolling out r241784.
1323
1324         Broke all OpenSource builds.
1325
1326         Reverted changeset:
1327
1328         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1329         instances view"
1330         https://bugs.webkit.org/show_bug.cgi?id=172848
1331         https://trac.webkit.org/changeset/241784
1332
1333 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1334
1335         [LFC][Floats] Remove redundant intersecting logic
1336         https://bugs.webkit.org/show_bug.cgi?id=194804
1337
1338         Reviewed by Antti Koivisto.
1339
1340         * LayoutReloaded/misc/LFC-passing-tests.txt:
1341
1342 2019-02-19  Dean Jackson  <dino@apple.com>
1343
1344         Clean-up output from generate-xcfilelists so it can be filtered
1345         https://bugs.webkit.org/show_bug.cgi?id=194795
1346
1347         Reviewed by Joseph Pecoraro (and Keith Rollin).
1348
1349         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1350         make a slight tweak to filter-build-webkit so such lines are marked
1351         as plain.
1352
1353         * Scripts/filter-build-webkit:
1354         * Scripts/generate-xcfilelists:
1355
1356 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1357
1358         pytest is not correctly auto-installed
1359         https://bugs.webkit.org/show_bug.cgi?id=194707
1360
1361         Reviewed by Carlos Garcia Campos.
1362
1363         * Scripts/webkitpy/thirdparty/__init__.py:
1364         (AutoinstallImportHook._install_pytest):
1365
1366 2019-02-18  Chris Dumez  <cdumez@apple.com>
1367
1368         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1369         https://bugs.webkit.org/show_bug.cgi?id=194797
1370         <rdar://problem/48055151>
1371
1372         Reviewed by Geoffrey Garen.
1373
1374         Add API test coverage.
1375
1376         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1377
1378 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1379
1380         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1381         https://bugs.webkit.org/show_bug.cgi?id=194670
1382         <rdar://problem/39066529>
1383
1384         Reviewed by Tim Horton.
1385
1386         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1387         pasted in an editable area as attachment elements.
1388
1389         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1390         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1391         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1392         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1393         (TestWebKitAPI::TEST):
1394         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1395         (WTR::InjectedBundlePage::InjectedBundlePage):
1396
1397 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1398
1399         Fix API test after r241728
1400        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1401
1402         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1403         (TEST):
1404         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1405
1406 2019-02-18  Daniel Bates  <dabates@apple.com>
1407
1408         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1409         https://bugs.webkit.org/show_bug.cgi?id=192824
1410         <rdar://problem/47100332>
1411
1412         Reviewed by Wenson Hsieh.
1413
1414         Fix a bug where the wrong usage code was used for F13 thru F24.
1415
1416         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1417         (keyCodeForDOMFunctionKey):
1418
1419 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1420
1421         Bytecode cache should a have a boot-specific validation
1422         https://bugs.webkit.org/show_bug.cgi?id=194769
1423         <rdar://problem/48149509>
1424
1425         Reviewed by Keith Miller.
1426
1427         Add test for WTF::bootSessionUUIDString()
1428
1429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1430         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1431         (TEST):
1432
1433 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1434
1435         Disable safe browsing in WKWebView and remove its WKPreferences API
1436         https://bugs.webkit.org/show_bug.cgi?id=194723
1437         <rdar://problem/48122993>
1438
1439         Reviewed by Geoffrey Garen.
1440
1441         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1442         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1443         (TEST):
1444         (safeBrowsingView):
1445         Make tests use SPI instead of API.
1446
1447 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1448
1449         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1450         https://bugs.webkit.org/show_bug.cgi?id=194586
1451
1452         Reviewed by Ross Kirsling.
1453
1454         * DumpRenderTree/win/DumpRenderTree.cpp:
1455         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1456         * Scripts/webkitpy/port/driver.py:
1457         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1458
1459 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1460
1461         Unreviewed, rolling out r241620.
1462
1463         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1464         (Requested by ddkilzer on #webkit.)
1465
1466         Reverted changeset:
1467
1468         "[WTF] Add environment variable helpers"
1469         https://bugs.webkit.org/show_bug.cgi?id=192405
1470         https://trac.webkit.org/changeset/241620
1471
1472 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1473
1474         [LFC] RenderImage's default intrinsic size is 0.
1475         https://bugs.webkit.org/show_bug.cgi?id=194745
1476
1477         Reviewed by Antti Koivisto.
1478
1479         * LayoutReloaded/misc/LFC-passing-tests.txt:
1480
1481 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1482
1483         [LFC][BFC] Add support for block replaced intrinsic width.
1484         https://bugs.webkit.org/show_bug.cgi?id=194705
1485
1486         Reviewed by Simon Fraser.
1487
1488         * LayoutReloaded/misc/LFC-passing-tests.txt:
1489
1490 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1491
1492         [LFC] Apply min/max width constraints to preferred width computation
1493         https://bugs.webkit.org/show_bug.cgi?id=194739
1494
1495         Reviewed by Simon Fraser.
1496
1497         * LayoutReloaded/misc/LFC-passing-tests.txt:
1498
1499 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1500
1501         [WTF] Add environment variable helpers
1502         https://bugs.webkit.org/show_bug.cgi?id=192405
1503
1504         Reviewed by Michael Catanzaro.
1505
1506         * DumpRenderTree/mac/DumpRenderTree.mm:
1507         (libraryPathForDumpRenderTree):
1508         * DumpRenderTree/win/DumpRenderTree.cpp:
1509         (libraryPathForDumpRenderTree):
1510         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1511         (setUpIOSLayoutTestCommunication):
1512         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1513         (beforeAll):
1514         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1515         (main):
1516         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1517         (WebKitTestBus::run):
1518         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1519         (WTR::getOutputDir):
1520         (WTR::initializeFontConfigSetting):
1521         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1522         (WTR::InjectedBundle::platformInitialize):
1523         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1524         (WTR::topLevelPath):
1525         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1526         (WTR::topLevelPath):
1527         (WTR::getOutputDir):
1528         (WTR::activateFonts):
1529         * WebKitTestRunner/TestController.cpp:
1530         (WTR::TestController::libraryPathForTesting):
1531         (WTR::TestController::generateContextConfiguration const):
1532         (WTR::TestController::generatePageConfiguration):
1533         (WTR::TestController::decideDestinationWithSuggestedFilename):
1534         (WTR::TestController::platformAdjustContext):
1535         * WebKitTestRunner/TestController.h:
1536         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1537         (WTR::TestController::cocoaPlatformInitialize):
1538         (WTR::TestController::platformAdjustContext):
1539         * WebKitTestRunner/gtk/main.cpp:
1540         (main):
1541         * WebKitTestRunner/mac/TestControllerMac.mm:
1542         (WTR::TestController::configureContentExtensionForTest):
1543         * WebKitTestRunner/wpe/main.cpp:
1544         (main):
1545         Utilize WTF::Environment where possible.
1546
1547 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1548
1549         [iOS] WKWebView callout bar is missing Change Writing Direction item
1550         https://bugs.webkit.org/show_bug.cgi?id=190015
1551         <rdar://problem/44810366>
1552
1553         Reviewed by Tim Horton.
1554
1555         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1556         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1557
1558         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1559         (TestWebKitAPI::TEST):
1560
1561 2019-02-15  Chris Dumez  <cdumez@apple.com>
1562
1563         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1564         https://bugs.webkit.org/show_bug.cgi?id=194717
1565         <rdar://problem/47884404>
1566
1567         Reviewed by Brady Eidson.
1568
1569         Add API test coverage.
1570
1571         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1572
1573 2019-02-15  Youenn Fablet  <youenn@apple.com>
1574
1575         Make navigator.mediaDevices SecureContext
1576         https://bugs.webkit.org/show_bug.cgi?id=194666
1577
1578         Reviewed by Eric Carlson.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1581         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1582         (TEST_F):
1583
1584 2019-02-15  Brian Burg  <bburg@apple.com>
1585
1586         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1587         https://bugs.webkit.org/show_bug.cgi?id=194411
1588         <rdar://problem/47787614>
1589
1590         Reviewed by Joseph Pecoraro.
1591
1592         Remove unnecessary soft linking macro usage.
1593
1594         * DumpRenderTree/mac/TestRunnerMac.mm:
1595         (TestRunner::inspectorTestStubURL):
1596         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1597         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1598         (WTR::TestRunner::inspectorTestStubURL):
1599
1600 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1601
1602         Unreviewed, rolling out r241559 and r241566.
1603         https://bugs.webkit.org/show_bug.cgi?id=194710
1604
1605         Causes layout test crashes under GuardMalloc (Requested by
1606         ryanhaddad on #webkit).
1607
1608         Reverted changesets:
1609
1610         "[WTF] Add environment variable helpers"
1611         https://bugs.webkit.org/show_bug.cgi?id=192405
1612         https://trac.webkit.org/changeset/241559
1613
1614         "Unreviewed build fix for WinCairo Debug after r241559."
1615         https://trac.webkit.org/changeset/241566
1616
1617 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1618
1619         [LFC] Out-of-flow box is never a float box
1620         https://bugs.webkit.org/show_bug.cgi?id=194704
1621
1622         Reviewed by Antti Koivisto.
1623
1624         * LayoutReloaded/misc/LFC-passing-tests.txt:
1625
1626 2019-02-10  Darin Adler  <darin@apple.com>
1627
1628         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1629         https://bugs.webkit.org/show_bug.cgi?id=194487
1630
1631         Reviewed by Daniel Bates.
1632
1633         * DumpRenderTree/win/DumpRenderTree.cpp:
1634         (applicationId): Use makeString instead of String::format.
1635         (main): Ditto.
1636         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1637         (TestWebKitAPI::Util::createURLForResource): Ditto.
1638         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1639         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1640
1641         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1642         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1643         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1644         (WTR::createStringWithAttributes): Use appendLiteral.
1645         (WTR::AccessibilityUIElement::helpText const): Ditto.
1646         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1647         directly instead of using String::format.
1648         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1649         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1650
1651 2019-02-15  Truitt Savell  <tsavell@apple.com>
1652
1653         Unreviewed, rolling out r241564.
1654
1655         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1656
1657         Reverted changeset:
1658
1659         "[Mac] WebInspectorUI.framework does not need to be soft-
1660         linked anymore"
1661         https://bugs.webkit.org/show_bug.cgi?id=194411
1662         https://trac.webkit.org/changeset/241564
1663
1664 2019-02-15  Saam barati  <sbarati@apple.com>
1665
1666         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1667         https://bugs.webkit.org/show_bug.cgi?id=194036
1668
1669         Reviewed by Yusuke Suzuki.
1670
1671         * Scripts/run-jsc-stress-tests:
1672
1673 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1674
1675         Fix the build.
1676
1677         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1678         (WTR::UIScriptController::drawSquareInEditableImage):
1679         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1680         (TestWebKitAPI::drawSquareInEditableImage):
1681
1682 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1683
1684         Fix the build.
1685
1686         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1687         (WTR::UIScriptController::drawSquareInEditableImage):
1688         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1689         (TestWebKitAPI::drawSquareInEditableImage):
1690
1691 2019-02-14  Brian Burg  <bburg@apple.com>
1692
1693         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1694         https://bugs.webkit.org/show_bug.cgi?id=194411
1695         <rdar://problem/47787614>
1696
1697         Reviewed by Joseph Pecoraro.
1698
1699         Remove unnecessary soft linking macro usage.
1700
1701         * DumpRenderTree/mac/TestRunnerMac.mm:
1702         (TestRunner::inspectorTestStubURL):
1703         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1704         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1705         (WTR::TestRunner::inspectorTestStubURL):
1706
1707 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1708
1709         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1710         https://bugs.webkit.org/show_bug.cgi?id=194599
1711
1712         Reviewed by Lucas Forschler.
1713
1714         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1715         (StatusBubble._build_bubble):
1716
1717 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1718
1719         [ews-app] Set Foreign Key in Django build model
1720         https://bugs.webkit.org/show_bug.cgi?id=194667
1721
1722         Reviewed by Lucas Forschler.
1723
1724         * BuildSlaveSupport/ews-app/ews/models/build.py:
1725         (Build):
1726
1727 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1728
1729         [WTF] Add environment variable helpers
1730         https://bugs.webkit.org/show_bug.cgi?id=192405
1731
1732         Reviewed by Michael Catanzaro.
1733
1734         * DumpRenderTree/mac/DumpRenderTree.mm:
1735         (libraryPathForDumpRenderTree):
1736         * DumpRenderTree/win/DumpRenderTree.cpp:
1737         (libraryPathForDumpRenderTree):
1738         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1739         (setUpIOSLayoutTestCommunication):
1740         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1741         (TestWebKitAPI::strip):
1742         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1743         (beforeAll):
1744         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1745         (main):
1746         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1747         (WebKitTestBus::run):
1748         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1749         (WTR::getOutputDir):
1750         (WTR::initializeFontConfigSetting):
1751         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1752         (WTR::InjectedBundle::platformInitialize):
1753         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1754         (WTR::topLevelPath):
1755         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1756         (WTR::topLevelPath):
1757         (WTR::getOutputDir):
1758         (WTR::activateFonts):
1759         * WebKitTestRunner/TestController.cpp:
1760         (WTR::TestController::libraryPathForTesting):
1761         (WTR::TestController::generateContextConfiguration const):
1762         (WTR::TestController::generatePageConfiguration):
1763         (WTR::TestController::decideDestinationWithSuggestedFilename):
1764         (WTR::TestController::platformAdjustContext):
1765         * WebKitTestRunner/TestController.h:
1766         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1767         (WTR::TestController::cocoaPlatformInitialize):
1768         (WTR::TestController::platformAdjustContext):
1769         * WebKitTestRunner/gtk/main.cpp:
1770         (main):
1771         * WebKitTestRunner/mac/TestControllerMac.mm:
1772         (WTR::TestController::configureContentExtensionForTest):
1773         * WebKitTestRunner/wpe/main.cpp:
1774         (main):
1775         Utilize WTF::Environment where possible.
1776
1777 2019-02-14  Chris Dumez  <cdumez@apple.com>
1778
1779         [PSON] Introduce a WebContent Process cache
1780         https://bugs.webkit.org/show_bug.cgi?id=194594
1781         <rdar://problem/46793397>
1782
1783         Reviewed by Geoff Garen.
1784
1785         Update API tests to turn on the WebContent Process cache.
1786
1787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1788
1789 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1790
1791         Unreviewed, build fix after r241480
1792
1793         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1794         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1795         (-[DragAndDropSimulator initWithWebView:]):
1796
1797 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1798
1799         AX: ARIA Reflection was disabled in error
1800         https://bugs.webkit.org/show_bug.cgi?id=194647
1801         <rdar://problem/48068336>
1802
1803         Reviewed by Ryosuke Niwa.
1804
1805         Remove test override now that this feature should be enabled by default.
1806
1807         * WebKitTestRunner/TestController.cpp:
1808         (WTR::TestController::resetPreferencesToConsistentValues):
1809
1810 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1811
1812         Unreviewed, rolling out r241486.
1813         https://bugs.webkit.org/show_bug.cgi?id=194655
1814
1815         causing API failures in builds (Requested by ShawnRoberts on
1816         #webkit).
1817
1818         Reverted changeset:
1819
1820         "[Cocoa] Media elements will restart network buffering just
1821         before suspending"
1822         https://bugs.webkit.org/show_bug.cgi?id=193691
1823         https://trac.webkit.org/changeset/241486
1824
1825 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1826
1827         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1828         https://bugs.webkit.org/show_bug.cgi?id=194622
1829
1830         Reviewed by Antti Koivisto.
1831
1832         * LayoutReloaded/misc/LFC-passing-tests.txt:
1833
1834 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1835
1836         [LFC] Shrink-to-fit-width should be constrained by min/max width
1837         https://bugs.webkit.org/show_bug.cgi?id=194653
1838
1839         Reviewed by Antti Koivisto.
1840
1841         * LayoutReloaded/misc/LFC-passing-tests.txt:
1842
1843 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1844
1845         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1846         https://bugs.webkit.org/show_bug.cgi?id=194641
1847
1848         Reviewed by Geoffrey Garen.
1849
1850         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1851         so that the test would fail without this fix.
1852
1853         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1854         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1855
1856 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1857
1858         [ews-app] Change log level for a log statement
1859
1860         Unreviewed minor fix.
1861
1862         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1863         (Patch.save_patch):
1864
1865 2019-02-13  Jer Noble  <jer.noble@apple.com>
1866
1867         [Cocoa] Media elements will restart network buffering just before suspending
1868         https://bugs.webkit.org/show_bug.cgi?id=193691
1869
1870         Reviewed by Eric Carlson.
1871
1872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1874         (TEST):
1875
1876 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews-app] Fetch builder id to name mapping
1879         https://bugs.webkit.org/show_bug.cgi?id=194355
1880
1881         Reviewed by Lucas Forschler.
1882
1883         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1884         (Buildbot.get_builder_id_to_name_mapping):
1885         (Buildbot._get_display_name_from_builder_name):
1886
1887 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1888
1889         Further restricting webarchive loads
1890         https://bugs.webkit.org/show_bug.cgi?id=194567
1891         <rdar://problem/47610130>
1892
1893         Reviewed by Youenn Fablet.
1894
1895         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1896         navigations on drop.
1897
1898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1899         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1900         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1901         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1902         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1903         (TestWebKitAPI::TEST):
1904         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1905         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1906         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1907         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1908         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1909         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1910         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1911
1912 2019-02-13  John Wilander  <wilander@apple.com>
1913
1914         Store Ad Click Attribution requests in the network process
1915         https://bugs.webkit.org/show_bug.cgi?id=194510
1916         <rdar://problem/47650118>
1917
1918         Reviewed by Alex Christensen and Daniel Bates.
1919
1920         This patch adds two TestRunner functions:
1921         - dumpAdClickAttribution()
1922         - clearAdClickAttribution()
1923
1924         They call into the network process to dump and clear Ad Click
1925         Attribution state, respectively.
1926
1927         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1928         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1929         (WTR::TestRunner::dumpAdClickAttribution):
1930         (WTR::TestRunner::clearAdClickAttribution):
1931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1932         * WebKitTestRunner/TestController.cpp:
1933         (WTR::TestController::resetStateToConsistentValues):
1934         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1935         (WTR::adClickAttributionStringResultCallback):
1936         (WTR::TestController::dumpAdClickAttribution):
1937         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1938         (WTR::adClickAttributionVoidCallback):
1939         (WTR::TestController::clearAdClickAttribution):
1940         * WebKitTestRunner/TestController.h:
1941         * WebKitTestRunner/TestInvocation.cpp:
1942         (WTR::TestInvocation::dumpResults):
1943         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1944         (WTR::TestInvocation::dumpAdClickAttribution):
1945         * WebKitTestRunner/TestInvocation.h:
1946
1947 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1948
1949         [ews-app] Generate status-bubble
1950         https://bugs.webkit.org/show_bug.cgi?id=194572
1951
1952         Reviewed by Lucas Forschler.
1953
1954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1955         (StatusBubble._build_bubble):
1956         (StatusBubble._should_show_bubble_for):
1957         (StatusBubble._build_bubbles_for_patch):
1958
1959 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1960
1961         [ews-app] Add status bubble html template
1962         https://bugs.webkit.org/show_bug.cgi?id=194571
1963
1964         Reviewed by Lucas Forschler.
1965
1966         * BuildSlaveSupport/ews-app/ews/templates: Added.
1967         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1968
1969 2019-02-12  Chris Dumez  <cdumez@apple.com>
1970
1971         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1972         https://bugs.webkit.org/show_bug.cgi?id=194568
1973         <rdar://problem/47944490>
1974
1975         Reviewed by Ryosuke Niwa.
1976
1977         Add API test coverage.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1980         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1981
1982 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1983
1984         webkitpy: Remove bug_dummy from parsed test expectations
1985         https://bugs.webkit.org/show_bug.cgi?id=194562
1986         <rdar://problem/47853999>
1987
1988         Reviewed by Lucas Forschler.
1989
1990         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1991         (TestExpectationParser):
1992         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1993         skipped tests.
1994         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1995
1996 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-app] Add method to fetch patch
1999         https://bugs.webkit.org/show_bug.cgi?id=194518
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2004         (Patch.get_patch):
2005
2006 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2007
2008         [LFC] Expand tests coverage (60 new tests -> 860)
2009
2010         Unreviewed test gardening (run-singly, --child-processes=1).
2011
2012         * LayoutReloaded/misc/LFC-passing-tests.txt:
2013
2014 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2015
2016         Allow pages to trigger programmatic paste from script on iOS
2017         https://bugs.webkit.org/show_bug.cgi?id=194271
2018         <rdar://problem/47808810>
2019
2020         Reviewed by Tim Horton.
2021
2022         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2023
2024         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2025         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2026         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2027         (WTR::UIScriptController::rectForMenuAction const):
2028
2029         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2030         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2031         for when the menu is shown or hidden.
2032
2033         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2034         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2035         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2036         (WTR::UIScriptController::setDidShowMenuCallback):
2037         (WTR::UIScriptController::didShowMenuCallback const):
2038         (WTR::UIScriptController::setDidHideMenuCallback):
2039         (WTR::UIScriptController::didHideMenuCallback const):
2040         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2041         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2042         (WTR::UIScriptController::rectForMenuAction const):
2043         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2044         * WebKitTestRunner/TestController.cpp:
2045         (WTR::TestController::resetPreferencesToConsistentValues):
2046         (WTR::updateTestOptionsFromTestHeader):
2047         * WebKitTestRunner/TestOptions.h:
2048
2049         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2050         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2051
2052         (WTR::TestOptions::hasSameInitializationOptions const):
2053         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2054         (WTR::UIScriptController::calendarType const):
2055         (WTR::UIScriptController::platformUndoManager const):
2056         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2057         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2058         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2059         (-[TestRunnerWKWebView dealloc]):
2060         (-[TestRunnerWKWebView _didShowMenu]):
2061         (-[TestRunnerWKWebView _didHideMenu]):
2062
2063         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2064
2065         * WebKitTestRunner/ios/TestControllerIOS.mm:
2066         (WTR::handleMenuWillHideNotification):
2067         (WTR::handleMenuDidHideNotification):
2068         (WTR::TestController::platformInitialize):
2069         (WTR::TestController::platformDestroy):
2070         (WTR::TestController::platformResetStateToConsistentValues):
2071
2072         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2073         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2074
2075         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2076         (WTR::forEachViewInHierarchy):
2077         (WTR::findViewInHierarchyOfType):
2078
2079         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2080         functions that dig through a given view's hierarchy in search of a view of a given class.
2081
2082         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2083         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2084         (WTR::UIScriptController::selectionCaretViewRect const):
2085         (WTR::UIScriptController::selectionRangeViewRects const):
2086         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2087         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2088
2089         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2090
2091         (WTR::UIScriptController::rectForMenuAction const):
2092
2093         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2094         callout bar) whose label matches the given string.
2095
2096         (WTR::UIScriptController::platformContentView const):
2097
2098         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2099         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2100         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2101
2102         (WTR::UIScriptController::platformUndoManager const): Deleted.
2103         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2104         (WTR::UIScriptController::platformContentView const):
2105         (WTR::UIScriptController::platformUndoManager const): Deleted.
2106
2107 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2108
2109         webkitpy: No option to only show unexpected failures in results.html for iPad
2110         https://bugs.webkit.org/show_bug.cgi?id=194554
2111         <rdar://problem/47922442>
2112
2113         Rubber-stamped by Aakash Jain.
2114
2115         Just because a TestExpecations file does not exist for a specific platform does not mean that
2116         TestExpecations are not being used, given that platforms inherit test expectations.
2117
2118         * Scripts/webkitpy/port/base.py:
2119         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2120         * Scripts/webkitpy/port/base_unittest.py:
2121         (PortTest.test_uses_test_expectations_file):
2122
2123 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2124
2125         Remove setDefersLoading infrastructure from WebKit2
2126         https://bugs.webkit.org/show_bug.cgi?id=194506
2127
2128         Reviewed by Brady Eidson.
2129
2130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2132         (WTR::TestRunner::setDefersLoading): Deleted.
2133         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2134
2135 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2136
2137         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2138         https://bugs.webkit.org/show_bug.cgi?id=194522
2139         <rdar://problem/47789393>
2140
2141         Reviewed by Chris Dumez.
2142
2143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2144         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2145         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2147
2148 2019-02-12  Andy Estes  <aestes@apple.com>
2149
2150         [iOSMac] Enable Parental Controls Content Filtering
2151         https://bugs.webkit.org/show_bug.cgi?id=194521
2152         <rdar://39732376>
2153
2154         Reviewed by Tim Horton.
2155
2156         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2157
2158 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2159
2160         [LFC][IFC] Add intrinsic width support for float boxes.
2161         https://bugs.webkit.org/show_bug.cgi?id=194528
2162
2163         Reviewed by Antti Koivisto.
2164
2165         Expand tests coverage (2 new tests -> 800).
2166         (This is the correct test ordering --runs-singly --child-processes=1)
2167
2168         * LayoutReloaded/misc/LFC-passing-tests.txt:
2169
2170 2019-02-12  Rob Buis  <rbuis@igalia.com>
2171
2172         Implement serializing in MIME type parser
2173         https://bugs.webkit.org/show_bug.cgi?id=193909
2174
2175         Reviewed by Darin Adler.
2176
2177         Add various tests involving upper case, non-ASCII, control/null characters,
2178         various HTTP whitespace, single quotes and an unpaired surrogate.
2179
2180         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2181         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2182         (TestWebKitAPI::serializeIfValid):
2183         (TestWebKitAPI::TEST):
2184
2185 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2186
2187         [Cocoa] Ask platform for generic font family mappings
2188         https://bugs.webkit.org/show_bug.cgi?id=187723
2189         <rdar://problem/41892438>
2190
2191         Reviewed by Brent Fulgham.
2192
2193         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2194
2195         * DumpRenderTree/mac/DumpRenderTree.mm:
2196         (allowedFontFamilySet):
2197         * WebKitTestRunner/mac/TestControllerMac.mm:
2198         (WTR::allowedFontFamilySet):
2199
2200 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2201
2202         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2203         https://bugs.webkit.org/show_bug.cgi?id=193622
2204
2205         Reviewed by Michael Catanzaro.
2206
2207         This adds support for loading content extension rule sets from the JSON files which
2208         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2209         of WKTR for this could be removed, but that is left for a follow-up patch with
2210         cleanups.
2211
2212         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2213         * WebKitTestRunner/TestController.cpp:
2214         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2215         avoid having the null-terminator copied into the result.
2216         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2217         part of the preparations to run a test.
2218         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2219         (WTR::contentExtensionStoreCallback): Added.
2220         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2221         used for content extensions test.
2222         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2223         extensions and compiling the JSON rule set for tests involving content extensions.
2224         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2225         testing and disables content extensions.
2226         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2227         resetContentExtensions().
2228         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2229         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2230         configureContentExtensionForTest(), and userContentController().
2231
2232 2019-02-11  Daniel Bates  <dabates@apple.com>
2233
2234         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2235         https://bugs.webkit.org/show_bug.cgi?id=191446
2236         <rdar://problem/45929460>
2237
2238         Reviewed by Tim Horton.
2239
2240         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2241
2242         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2243         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2244         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2245         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2246         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2247         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2248         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2249         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2250         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2251         (WTR::arrayLength):
2252         (WTR::parseModifierArray):
2253         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2254         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2255         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2256         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2257
2258 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2259
2260         Unreviewed, rolling out r241272 and r241276.
2261         https://bugs.webkit.org/show_bug.cgi?id=194514
2262
2263         Broke the Apple Internal build and the fix requires human
2264         intervention :( (Requested by dydz on #webkit).
2265
2266         Reverted changesets:
2267
2268         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2269         https://bugs.webkit.org/show_bug.cgi?id=191446
2270         https://trac.webkit.org/changeset/241272
2271
2272         "Fix internal iOS build after r241272"
2273         https://bugs.webkit.org/show_bug.cgi?id=191446
2274         https://trac.webkit.org/changeset/241276
2275
2276 2019-02-11  Truitt Savell  <tsavell@apple.com>
2277
2278         Unreviewed, rolling out r241269.
2279
2280         Caused 5 layout tests crashes on Mac WK1
2281
2282         Reverted changeset:
2283
2284         "DumpRenderTree should report unknown options"
2285         https://bugs.webkit.org/show_bug.cgi?id=191303
2286         https://trac.webkit.org/changeset/241269
2287
2288 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2289
2290         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2291         https://bugs.webkit.org/show_bug.cgi?id=194313
2292
2293         Reviewed by Tim Horton.
2294
2295         Add a helper to determine whether the web view is presenting modal UI.
2296
2297         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2298         (WTR::UIScriptController::isPresentingModally const):
2299         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2300         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2301         (WTR::UIScriptController::isPresentingModally const):
2302         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2303         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2304         (WTR::UIScriptController::calendarType const): Deleted.
2305         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2306         (WTR::UIScriptController::isPresentingModally const):
2307         (WTR::UIScriptController::calendarType const):
2308         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2309         (WTR::UIScriptController::calendarType const):
2310
2311 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2312
2313         GCHeapInspector: Show the retained sizes in more places
2314         https://bugs.webkit.org/show_bug.cgi?id=194464
2315
2316         Reviewed by Simon Fraser.
2317
2318         * GCHeapInspector/gc-heap-inspector.html:
2319         * GCHeapInspector/script/interface.js:
2320         (HeapInspectorUtils.humanReadableSize):
2321         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2322         (HeapInspectorUtils.spanForNode.span.span):
2323         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2324         (HeapSnapshotInspector.prototype.buildRoots):
2325
2326 2019-02-11  Daniel Bates  <dabates@apple.com>
2327
2328         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2329         https://bugs.webkit.org/show_bug.cgi?id=191446
2330         <rdar://problem/45929460>
2331
2332         Reviewed by Tim Horton.
2333
2334         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2335
2336         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2337         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2338         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2339         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2340         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2341         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2342         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2343         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2344         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2345         (WTR::arrayLength):
2346         (WTR::parseModifierArray):
2347         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2348         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2349         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2350         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2351
2352 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2353
2354         DumpRenderTree should report unknown options
2355         https://bugs.webkit.org/show_bug.cgi?id=191303
2356
2357         Reviewed by Frédéric Wang.
2358
2359         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2360         to report unknown options.
2361         Added and assigned test options which are currently used in tests.
2362
2363         * DumpRenderTree/TestOptions.cpp:
2364         (TestOptions::TestOptions):
2365
2366 2019-02-11  Truitt Savell  <tsavell@apple.com>
2367
2368         Unreviewed, rolling out r241229.
2369
2370         Revision broke internal builds for watchOS.
2371
2372         Reverted changeset:
2373
2374         "[Cocoa] Ask platform for generic font family mappings"
2375         https://bugs.webkit.org/show_bug.cgi?id=187723
2376         https://trac.webkit.org/changeset/241229
2377
2378 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2379
2380         [WinCairo][MiniBrowser] Basic authentication always fails.
2381         https://bugs.webkit.org/show_bug.cgi?id=194496
2382
2383         Reviewed by Don Olmstead.
2384
2385         * MiniBrowser/win/DialogHelper.h:
2386         (Dialog::getText):
2387
2388 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2389
2390         [GStreamer] GstMappedBuffer testsuite build fails
2391         https://bugs.webkit.org/show_bug.cgi?id=194495
2392
2393         Reviewed by Carlos Garcia Campos.
2394
2395         Fix the build by explicitely adding the gstreamer1.0-audio include
2396         directories to the include path.
2397
2398         * TestWebKitAPI/PlatformGTK.cmake:
2399         * TestWebKitAPI/PlatformWPE.cmake:
2400
2401 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2402
2403         [GTK][WPE] Add enable-javascript-markup setting
2404         https://bugs.webkit.org/show_bug.cgi?id=193439
2405
2406         Reviewed by Michael Catanzaro.
2407
2408         Add test cases to check the new setting.
2409
2410         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2411         (testWebKitSettings):
2412         (testWebKitSettingsJavaScriptMarkup):
2413         (beforeAll):
2414
2415 2019-02-10  Darin Adler  <darin@apple.com>
2416
2417         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2418         https://bugs.webkit.org/show_bug.cgi?id=194485
2419
2420         Reviewed by Daniel Bates.
2421
2422         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2423
2424 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2425
2426         Add more tests for clampTo<>()
2427         https://bugs.webkit.org/show_bug.cgi?id=194462
2428
2429         Reviewed by Geoffrey Garen.
2430
2431         Darin suggested to test the very last floating point number
2432         at the boundaries when truncating to integer.
2433         I added test for max/min and max-1/min-1.
2434
2435         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2436         (TestWebKitAPI::TEST):
2437
2438 2019-02-09  Darin Adler  <darin@apple.com>
2439
2440         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2441         https://bugs.webkit.org/show_bug.cgi?id=194021
2442
2443         Reviewed by Geoffrey Garen.
2444
2445         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2446         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2447         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2448
2449 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2450
2451         [LFC][IFC] Add intrinsic width support for basic inline containers
2452         https://bugs.webkit.org/show_bug.cgi?id=194473
2453
2454         Reviewed by Antti Koivisto.
2455
2456         Expand tests coverage (11 new tests -> 798)
2457
2458         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2459
2460 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2461
2462         Fix MiniBrowser's entitlements
2463         https://bugs.webkit.org/show_bug.cgi?id=192431
2464
2465         Reviewed by Joseph Pecoraro.
2466
2467         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2468         files, making it impossible to load any extension.
2469
2470         * MiniBrowser/MiniBrowser.entitlements:
2471
2472 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2473
2474         [Cocoa] Ask platform for generic font family mappings
2475         https://bugs.webkit.org/show_bug.cgi?id=187723
2476         <rdar://problem/41892438>
2477
2478         Reviewed by Brent Fulgham.
2479
2480         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2481
2482         * DumpRenderTree/mac/DumpRenderTree.mm:
2483         (allowedFontFamilySet):
2484         * WebKitTestRunner/mac/TestControllerMac.mm:
2485         (WTR::allowedFontFamilySet):
2486
2487 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2488
2489         [GTK] Implement back/forward touchpad gesture
2490         https://bugs.webkit.org/show_bug.cgi?id=193919
2491
2492         Reviewed by Michael Catanzaro.
2493
2494         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2495         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2496
2497 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2498
2499         Add SPI to use networking daemon instead of XPC service
2500         https://bugs.webkit.org/show_bug.cgi?id=194427
2501
2502         Reviewed by Geoffrey Garen
2503
2504         * MiniBrowser/MiniBrowser.entitlements:
2505
2506 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-build] Ensure that every builder in config.json has short name
2509         https://bugs.webkit.org/show_bug.cgi?id=194461
2510
2511         Reviewed by Lucas Forschler.
2512
2513         * BuildSlaveSupport/ews-build/loadConfig.py:
2514         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2515
2516 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2517
2518         [ews-build] Add short name to config.json
2519         https://bugs.webkit.org/show_bug.cgi?id=194456
2520
2521         Reviewed by Lucas Forschler.
2522
2523         * BuildSlaveSupport/ews-build/config.json: Added short name.
2524         * BuildSlaveSupport/ews-build/loadConfig.py:
2525         (loadBuilderConfig): Set the short name as the builder description.
2526
2527 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2528
2529         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2530         https://bugs.webkit.org/show_bug.cgi?id=194418
2531
2532         Reviewed by Lucas Forschler.
2533
2534         Do not include errors trying when finding crashlogs at the end of
2535         a run-webkit-tests run since we don't process those errors.
2536
2537         * Scripts/webkitpy/port/darwin.py:
2538         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2539         * Scripts/webkitpy/port/ios_device.py:
2540         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2541         * Scripts/webkitpy/port/watch_device.py:
2542         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2543
2544 2019-02-08  Beth Dakin  <bdakin@apple.com>
2545
2546         Add afterScreenUpdates to WKSnapshotConfiguration
2547         https://bugs.webkit.org/show_bug.cgi?id=194362
2548         -and corresponding-
2549         <rdar://problem/40655528> Please add an "after screen updates" property to 
2550         WKSnapshotConfiguration (to solve blank snapshots)
2551
2552         Reviewed by Tim Horton.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2555         (TEST):
2556
2557 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2558
2559         clampTo(): do not convert the input to double when dealing with integers
2560         https://bugs.webkit.org/show_bug.cgi?id=194263
2561         <rdar://problem/47692312>
2562
2563         Reviewed by Darin Adler.
2564
2565         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2566         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2567         (TestWebKitAPI::testClampFloatingPointToInteger):
2568         (TestWebKitAPI::testClampSameSignIntegers):
2569         (TestWebKitAPI::testClampUnsignedToSigned):
2570         (TestWebKitAPI::testClampSignedToUnsigned):
2571
2572 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2573
2574         webkitpy: Respect --dedicated-simulators flag
2575         https://bugs.webkit.org/show_bug.cgi?id=194416
2576         <rdar://problem/47894722>
2577
2578         Reviewed by Lucas Forschler.
2579
2580         * Scripts/webkitpy/port/device_port.py:
2581         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2582         available devices can be safely ignored.
2583
2584 2019-02-07  Keith Rollin  <krollin@apple.com>
2585
2586         Remove extra copy of 100x100-red.tga
2587         https://bugs.webkit.org/show_bug.cgi?id=194371
2588         <rdar://problem/47873465>
2589
2590         Reviewed by Said Abou-Hallawa.
2591
2592         In order to help it pass its tests, Bug 194190 added a second copy of
2593         the file 100x100-red.tga. However, it turns out that this additional
2594         file wasn't actually needed, and that that sole previous copy was
2595         sufficient. At the same time, this second copy -- which was copied to
2596         the same location in the build output as the first copy -- now caused
2597         XCBuild to complain because there were two production rules for the
2598         same output file. Address this by removing the newly-added extra copy.
2599
2600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2601         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2602
2603 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2604
2605         Deprecate WKBundlePageSetDefersLoading
2606         https://bugs.webkit.org/show_bug.cgi?id=191394
2607
2608         Reviewed by Dean Jackson.
2609
2610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2611         (WTR::TestRunner::setDefersLoading):
2612
2613 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2614
2615         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2616         https://bugs.webkit.org/show_bug.cgi?id=194391
2617
2618         Reviewed by Antti Koivisto.
2619
2620         * LayoutReloaded/misc/LFC-passing-tests.txt:
2621
2622 2019-02-06  Keith Rollin  <krollin@apple.com>
2623
2624         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2625         https://bugs.webkit.org/show_bug.cgi?id=193975
2626         <rdar://problem/47643306>
2627
2628         Reviewed by Tim Horton.
2629
2630         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2631         the Info.plist file into the bundle. This step is not necessary as the
2632         implicit "bundle up all the build products into a framework" build
2633         phase does this already. Having the Copy Bundle Resources phase do
2634         this causes a conflict under XCBuild, which objects to two build
2635         phases producing the same file (Info.plist). Address this by removing
2636         Info.plist from the Copy Bundle Resources phase.
2637
2638         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2639
2640 2019-02-06  Keith Rollin  <krollin@apple.com>
2641
2642         Really enable the automatic checking and regenerations of .xcfilelists during builds
2643         https://bugs.webkit.org/show_bug.cgi?id=194357
2644         <rdar://problem/47861231>
2645
2646         Reviewed by Chris Dumez.
2647
2648         Bug 194124 was supposed to enable the automatic checking and
2649         regenerating of .xcfilelist files during the build. While related
2650         changes were included in that patch, the change to actually enable the
2651         operation somehow was omitted. This patch actually enables the
2652         operation. The check-xcfilelist.sh scripts now check
2653         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2654         from the checking.
2655
2656         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2657         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2658
2659 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2660
2661         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2662         <https://webkit.org/b/194286>
2663         <rdar://problem/47815558>
2664
2665         Reviewed by Alexey Proskuryakov.
2666
2667         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2668         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2669         WKRetainPtr<> to avoid leaking the WKDataRef.
2670
2671 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2672
2673         Unreviewed, fix a typo
2674
2675         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2676
2677 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2678
2679         [GTK][WPE] force libpsl build to use ICU in jhbuild
2680         https://bugs.webkit.org/show_bug.cgi?id=194288
2681
2682         Reviewed by Carlos Garcia Campos.
2683
2684         * gtk/jhbuild.modules:
2685         Require ICU for libpsl build in jhbuild, like done in WPE.
2686
2687 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2688
2689         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2690         https://bugs.webkit.org/show_bug.cgi?id=194209
2691
2692         Reviewed by Carlos Garcia Campos.
2693
2694         Enhance TestCookieManager to ensure this doesn't happen again.
2695
2696         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2697         (testCookieManagerPersistentStorage):
2698         (beforeAll):
2699
2700 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2701
2702         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2703         https://bugs.webkit.org/show_bug.cgi?id=194324
2704
2705         Reviewed by Andy Estes.
2706
2707         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2708         part of the name is already implicit, since this is in testing code in TestOptions.
2709
2710         * WebKitTestRunner/TestController.cpp:
2711         (WTR::TestController::generateContextConfiguration const):
2712         (WTR::updateTestOptionsFromTestHeader):
2713         * WebKitTestRunner/TestOptions.h:
2714         (WTR::TestOptions::hasSameInitializationOptions const):
2715
2716 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2717
2718         [ews-build] Allow * as platform for builders and workers
2719         https://bugs.webkit.org/show_bug.cgi?id=188533
2720
2721         Reviewed by Lucas Forschler.
2722
2723         * BuildSlaveSupport/ews-build/loadConfig.py:
2724         (checkWorkersAndBuildersForConsistency):
2725
2726 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2727
2728         [ews-build] Add few bots to config.json
2729         https://bugs.webkit.org/show_bug.cgi?id=194304
2730
2731         Reviewed by Lucas Forschler.
2732
2733         * BuildSlaveSupport/ews-build/config.json:
2734
2735 2019-02-05  Keith Rollin  <krollin@apple.com>
2736
2737         Enable the automatic checking and regenerations of .xcfilelists during builds
2738         https://bugs.webkit.org/show_bug.cgi?id=194124
2739         <rdar://problem/47721277>
2740
2741         Reviewed by Tim Horton.
2742
2743         Bug 193790 add a facility for checking -- during build time -- that
2744         any needed .xcfilelist files are up-to-date and for updating them if
2745         they are not. This facility was initially opt-in by setting
2746         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2747         the process seemed robust. Its now time to enable this facility and
2748         make it opt-out. If there is a need to disable this facility, set and
2749         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2750         running `make` or `build-webkit`, or before running Xcode from the
2751         command line.
2752
2753         Additionally, remove the step that generates a list of source files
2754         going into the UnifiedSources build step. It's only necessarily to
2755         specify Sources.txt and SourcesCocoa.txt as inputs.
2756
2757         * Scripts/generate-xcfilelists:
2758
2759 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2760
2761         [GTK][WPE] force libpsl build to use ICU in jhbuild
2762         https://bugs.webkit.org/show_bug.cgi?id=194288
2763
2764         Reviewed by Philippe Normand.
2765
2766         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2767         This can cause build failures if libidn is detected but libunistring is not available.
2768
2769         Make sure that ICU is used for runtime and builtin PSL data.
2770
2771         * gtk/jhbuild.modules:
2772         * wpe/jhbuild.modules:
2773
2774 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2775
2776         [ews-app] Modified timestamp should be updated on updating data
2777         https://bugs.webkit.org/show_bug.cgi?id=194295
2778
2779         Reviewed by Lucas Forschler.
2780
2781         * BuildSlaveSupport/ews-app/ews/models/build.py:
2782         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2783         * BuildSlaveSupport/ews-app/ews/models/step.py:
2784
2785 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2786
2787         Unreviewed, rolling out r240742.
2788
2789         Causes crashes on iOS simulator.
2790
2791         Reverted changeset:
2792
2793         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2794         not focused in a content-editable element"
2795         https://bugs.webkit.org/show_bug.cgi?id=192824
2796         https://trac.webkit.org/changeset/240742
2797
2798 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2799
2800         run-webkit-tests emits message "...running None" when running tests
2801         https://bugs.webkit.org/show_bug.cgi?id=194133
2802         <rdar://problem/47724738>
2803
2804         Reviewed by Lucas Forschler.
2805
2806         * Scripts/webkitpy/xcode/device_type.py:
2807         (DeviceType.__str__): Use both version mapping tables and use just the variant
2808         name if no version name is available.
2809         * Scripts/webkitpy/xcode/device_type_unittest.py:
2810         (DeviceTypeTest):
2811         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2812         an associated named.
2813
2814 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2815
2816         [WPE] require python3-setuptools for meson build in jhbuild
2817         https://bugs.webkit.org/show_bug.cgi?id=194287
2818
2819         Reviewed by Philippe Normand.
2820
2821         python3-setuptools is needed to build meson in jhbuild.
2822         It is already required by the GTK port.
2823
2824         * wpe/install-dependencies:
2825
2826 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2827
2828         [ews-app] Add method to save BuilderMapping to database
2829         https://bugs.webkit.org/show_bug.cgi?id=194264
2830
2831         Reviewed by Lucas Forschler.
2832
2833         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2834         (BuilderMapping.__str__):
2835         (BuilderMapping):
2836         (BuilderMapping.save_mapping):
2837         (BuilderMapping.update_mapping):
2838         (BuilderMapping.get_existing_mapping):
2839         (BuilderMapping.is_valid_mapping):
2840
2841 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2842
2843         [ews-app] Add timestamp fields for BuilderMappings
2844         https://bugs.webkit.org/show_bug.cgi?id=194266
2845
2846         Reviewed by Lucas Forschler.
2847
2848         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2849         (BuilderMapping):
2850
2851 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2852
2853         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2854         https://bugs.webkit.org/show_bug.cgi?id=174816
2855
2856         Reviewed by Michael Catanzaro.
2857
2858         Add tests for webkit_uri_for_display().
2859
2860         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2861         (testURIForDisplayUnaffected):
2862         (testURIForDisplayAffected):
2863         (beforeAll):
2864         (afterAll):
2865         * TestWebKitAPI/glib/CMakeLists.txt:
2866
2867 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2868
2869         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2870         https://bugs.webkit.org/show_bug.cgi?id=194158
2871         <rdar://problem/47737268>
2872
2873         Rubber-stamped by Aakash Jain.
2874
2875         * Scripts/webkitpy/port/device_port.py:
2876         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2877
2878 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2879
2880         [CG] Enable setAdditionalSupportedImageTypes for WK1
2881         https://bugs.webkit.org/show_bug.cgi?id=194190
2882
2883         Reviewed by Tim Horton.
2884
2885         Add a test similar to the one under WebKit Cocoa but make it create a
2886         WebView instead of a WKWebView.
2887
2888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2889         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2890         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2891         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2892         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2893         (TestWebKitAPI::runTest):
2894         (TestWebKitAPI::TEST):
2895
2896 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2897
2898         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2899         https://bugs.webkit.org/show_bug.cgi?id=194168
2900
2901         Reviewed by Simon Fraser.
2902
2903         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2904
2905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2906         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2907         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2908         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2909         (TEST):
2910         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2911         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2912
2913 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2914
2915         REGRESSION (r237269): webkit-patch what-broke is broken 
2916         https://bugs.webkit.org/show_bug.cgi?id=193025
2917
2918         Reviewed by Aakash Jain.
2919
2920         * Scripts/webkitpy/common/host.py:
2921         (Host.buildbot):
2922         (Host.bugzilla): Renamed to 'buildbot'.
2923
2924 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2925
2926         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2927         https://bugs.webkit.org/show_bug.cgi?id=194207
2928
2929         Reviewed by Tim Horton.
2930
2931         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2932         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2933         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2934         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2935         start and delete forwards to remove the original attachment.
2936
2937         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2938         (TestWebKitAPI::TEST):
2939
2940 2019-02-04  Youenn Fablet  <youenn@apple.com>
2941
2942         Capture state should be managed consistently when doing process swapping
2943         https://bugs.webkit.org/show_bug.cgi?id=194122
2944         <rdar://problem/47609293>
2945
2946         Reviewed by Eric Carlson.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2949         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2950         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2951         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2952         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2953         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2954         (WTR::TestRunner::isDoingMediaCapture const):
2955         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2956         * WebKitTestRunner/TestController.cpp:
2957         (WTR::TestController::isDoingMediaCapture const):
2958         * WebKitTestRunner/TestController.h:
2959         * WebKitTestRunner/TestInvocation.cpp:
2960         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2961         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2962         (WTR::TestController::isDoingMediaCapture const):
2963
2964 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2965
2966         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2967         https://bugs.webkit.org/show_bug.cgi?id=194142
2968
2969         Reviewed by Ross Kirsling.
2970
2971         There three 'separator' variables in TestController.cpp. Renamed
2972         it 'pathSeparator', and unified them.
2973
2974         * WebKitTestRunner/TestController.cpp:
2975         (WTR::TestController::generateContextConfiguration const):
2976         (WTR::createTestURL):
2977         (WTR::TestController::platformAdjustContext):
2978
2979 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2980
2981         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2982         https://bugs.webkit.org/show_bug.cgi?id=194198
2983
2984         Reviewed by Antti Koivisto.
2985
2986         No need to set the banner heights on navigation now, since Page stores them.
2987
2988         * MiniBrowser/mac/WK2BrowserWindowController.m:
2989         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2990
2991 2019-02-03  John Wilander  <wilander@apple.com>
2992
2993         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2994         https://bugs.webkit.org/show_bug.cgi?id=194104
2995         <rdar://problem/47649991>
2996
2997         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2998
2999         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3000         (TestWebKitAPI::TEST):
3001             Changed numeric types from unsigned short to uint32_t.
3002
3003 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3004
3005         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3006         <https://webkit.org/b/194178>
3007         <rdar://problem/47753473>
3008
3009         Reviewed by Alexey Proskuryakov.
3010
3011         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3012         (WTR::uninstallFakeHelvetica): Pass nullptr into
3013         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3014
3015 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3016
3017         [LFC] Initialize ICB's style with fixed width/height.
3018         https://bugs.webkit.org/show_bug.cgi?id=194188
3019
3020         Reviewed by Antti Koivisto.
3021
3022         * LayoutReloaded/misc/LFC-passing-tests.txt:
3023
3024 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3025
3026         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3027         https://bugs.webkit.org/show_bug.cgi?id=194185
3028
3029         Reviewed by Antti Koivisto.
3030
3031         * LayoutReloaded/misc/LFC-passing-tests.txt:
3032
3033 2018-12-16  Darin Adler  <darin@apple.com>
3034
3035         Convert additional String::format clients to alternative approaches
3036         https://bugs.webkit.org/show_bug.cgi?id=192746
3037
3038         Reviewed by Alexey Proskuryakov.
3039
3040         * WebKitTestRunner/TestController.cpp:
3041         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3042         as an intermediate in code that ultimately constructs a WTF::String.
3043         (WTR::userMediaOriginHash): Use makeString.
3044         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3045         (WTR::TestController::didPerformClientRedirect): Ditto.
3046         (WTR::TestController::didPerformServerRedirect): Ditto.
3047         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3048
3049 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-build] Add unit test to verify builder keys
3052         https://bugs.webkit.org/show_bug.cgi?id=194152
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3057         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3058
3059 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3060
3061         [LFC] Expand tests coverage (12 new tests -> 787)
3062
3063         Unreviewed test gardening.
3064
3065         * LayoutReloaded/misc/LFC-passing-tests.txt:
3066
3067 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3068
3069         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3070         https://bugs.webkit.org/show_bug.cgi?id=194163
3071
3072         Reviewed by Simon Fraser.
3073
3074         775
3075
3076         * LayoutReloaded/misc/LFC-passing-tests.txt:
3077
3078 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3079
3080         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3081         https://bugs.webkit.org/show_bug.cgi?id=194140
3082         <rdar://problem/47728098>
3083
3084         Reviewed by Tim Horton.
3085
3086         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3087         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3088         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3089
3090         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3091         test to induce an IPC deadlock when presenting a modal alert during touch start.
3092
3093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3094         * WebKitTestRunner/TestController.cpp:
3095         (WTR::runJavaScriptAlert):
3096
3097         Add a client callback function for running JavaScript alerts.
3098
3099         (WTR::TestController::createOtherPage):
3100         (WTR::TestController::generateContextConfiguration const):
3101
3102         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3103         the fix in this patch.
3104
3105         (WTR::TestController::createWebViewWithOptions):
3106
3107         Plumb TestOptions to generateContextConfiguration.
3108
3109         (WTR::TestController::resetPreferencesToConsistentValues):
3110         (WTR::TestController::resetStateToConsistentValues):
3111         (WTR::updateTestOptionsFromTestHeader):
3112         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3113         (WTR::TestController::handleJavaScriptAlert):
3114         * WebKitTestRunner/TestController.h:
3115         * WebKitTestRunner/TestInvocation.cpp:
3116         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3117         * WebKitTestRunner/TestOptions.h:
3118         (WTR::TestOptions::hasSameInitializationOptions const):
3119
3120 2019-02-01  Chris Dumez  <cdumez@apple.com>
3121
3122         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3123         https://bugs.webkit.org/show_bug.cgi?id=193740
3124         <rdar://problem/47527267>
3125
3126         Reviewed by Alex Christensen.
3127
3128         Add API test coverage.
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3131
3132 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3133
3134         [ews-app] Add display name field to BuilderMapping model
3135         https://bugs.webkit.org/show_bug.cgi?id=194153
3136
3137         Reviewed by Lucas Forschler.
3138
3139         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3140         (BuilderMapping):
3141
3142 2019-02-01  Youenn Fablet  <youenn@apple.com>
3143
3144         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3145         https://bugs.webkit.org/show_bug.cgi?id=194155
3146
3147         Reviewed by Eric Carlson.
3148
3149         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3150         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3151         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3152
3153 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3154
3155         [LFC] Adjust replaced element's intrinsic ratio
3156         https://bugs.webkit.org/show_bug.cgi?id=194154
3157
3158         Reviewed by Antti Koivisto.
3159
3160         761
3161
3162         * LayoutReloaded/misc/LFC-passing-tests.txt:
3163
3164 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3165
3166         [WPE] Show test results in minibrowser
3167         https://bugs.webkit.org/show_bug.cgi?id=194150
3168
3169         Reviewed by Žan Doberšek.
3170
3171         * Scripts/webkitpy/port/wpe.py:
3172         (WPEPort.show_results_html_file):
3173
3174 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3175
3176         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3177         https://bugs.webkit.org/show_bug.cgi?id=194151
3178
3179         Reviewed by Žan Doberšek.
3180
3181         ALT + <- go back
3182         ALT + -> go forward
3183
3184         * MiniBrowser/wpe/main.cpp:
3185         (main):
3186
3187 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3188
3189         [LFC] Set intrinsic size on Layout::Replaced
3190         https://bugs.webkit.org/show_bug.cgi?id=194139
3191
3192         Reviewed by Antti Koivisto.
3193
3194         744
3195
3196         * LayoutReloaded/misc/LFC-passing-tests.txt:
3197
3198 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3199
3200         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3201         https://bugs.webkit.org/show_bug.cgi?id=194146
3202
3203         Reviewed by Xabier Rodriguez-Calvar.
3204
3205         It allows to open relative paths.
3206
3207         * MiniBrowser/wpe/main.cpp:
3208         (main):
3209
3210 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3211
3212         Update flakiness dashboard configuration after recent queue changes
3213         https://bugs.webkit.org/show_bug.cgi?id=194127
3214
3215         Rubber-stamped by Aakash Jain.
3216
3217         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3218
3219         * TestResultServer/static-dashboards/builders.jsonp:
3220
3221 2019-01-31  Youenn Fablet  <youenn@apple.com>
3222
3223         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3224         https://bugs.webkit.org/show_bug.cgi?id=194106
3225         <rdar://problem/47676333>
3226
3227         Reviewed by Ryosuke Niwa.
3228
3229         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3230         (TestWebKitAPI::didFinishNavigation):
3231         (TestWebKitAPI::TEST):
3232         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3233
3234 2019-01-31  Chris Dumez  <cdumez@apple.com>
3235
3236         Page zoom level is lost after a process swap or a crash
3237         https://bugs.webkit.org/show_bug.cgi?id=194105
3238         <rdar://problem/47610781>
3239
3240         Reviewed by Alex Christensen.
3241
3242         Add API test coverage.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3245         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3246
3247 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3248
3249         Revert r238819 which is unneeded and caused a performance regression.
3250         https://bugs.webkit.org/show_bug.cgi?id=192272
3251         <rdar://problem/46664625>
3252
3253         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3254         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3255         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3256
3257 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3258
3259         Formalize WebKitAdditions mechanism of LoadOptimizer
3260         https://bugs.webkit.org/show_bug.cgi?id=193886
3261         <rdar://problem/47696809>
3262
3263         Reviewed by Brent Fulgham.
3264
3265         * MiniBrowser/MiniBrowser.entitlements:
3266         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3267
3268 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3269
3270         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3271         https://bugs.webkit.org/show_bug.cgi?id=194090
3272
3273         Reviewed by Antti Koivisto.
3274
3275         * LayoutReloaded/misc/LFC-passing-tests.txt:
3276
3277 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3278
3279         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3280         https://bugs.webkit.org/show_bug.cgi?id=194074
3281
3282         Reviewed by Antti Koivisto.
3283
3284         * LayoutReloaded/misc/LFC-passing-tests.txt:
3285
3286 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3287
3288         [LFC][BFC] Add support for block level replaced box.
3289         https://bugs.webkit.org/show_bug.cgi?id=194071
3290
3291         Reviewed by Antti Koivisto.
3292
3293         * LayoutReloaded/misc/LFC-passing-tests.txt:
3294
3295 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3296
3297         Fix WebKitTestRunner's testPath with Windows full paths
3298         https://bugs.webkit.org/show_bug.cgi?id=194012
3299
3300         Reviewed by Alex Christensen.
3301
3302         updateTestOptionsFromTestHeader failed to open test files because
3303         testPath returned wrong file paths. It returned a path "/C:/..."
3304         if a URL "file:///C:/..." was given.
3305
3306         * WebKitTestRunner/TestController.cpp:
3307         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3308
3309 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3310
3311         [WPE] Bump font related dependencies to match the GTK+ port
3312         https://bugs.webkit.org/show_bug.cgi?id=194017
3313
3314         Reviewed by Žan Doberšek.
3315
3316         * wpe/jhbuild.modules:
3317         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3318         * wpe/patches/icudata-stdlibs.patch: Added.
3319
3320 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3321
3322         Enable swipe tests on iOS
3323         https://bugs.webkit.org/show_bug.cgi?id=194076
3324
3325         Reviewed by Geoffrey Garen.
3326
3327         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3328         it causes a debug assertion failure in runUIScript.
3329
3330         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3331         (WTR::UIScriptController::beginBackSwipe):
3332         (WTR::UIScriptController::completeBackSwipe):
3333
3334 2019-01-30  Keith Rollin  <krollin@apple.com>
3335
3336         Use correct printf format specifier
3337         https://bugs.webkit.org/show_bug.cgi?id=194062
3338         <rdar://problem/47686167>
3339
3340         Reviewed by Alexey Proskuryakov.
3341
3342         LayoutTestSpellChecker.mm is trying to format a variable of type
3343         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3344         actually an unsigned long long. Fix this by formatting with %llu.
3345
3346         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3347         (-[LayoutTestTextCheckingResult description]):
3348
3349 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3350
3351         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3352         https://bugs.webkit.org/show_bug.cgi?id=193979
3353
3354         Reviewed by Wenson Hsieh.
3355
3356         Fix the test for iOS. Make the test work with iOS UA string.
3357
3358         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3359
3360 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3361
3362         Replace High Sierra LLINT CLoop bot due to hardware failure
3363         https://bugs.webkit.org/show_bug.cgi?id=194066
3364
3365         Reviewed by Aakash Jain.
3366
3367         * BuildSlaveSupport/build.webkit.org-config/config.json:
3368
3369 2019-01-30  Keith Rollin  <krollin@apple.com>
3370
3371         [NSDragItem init] is unavailable
3372         https://bugs.webkit.org/show_bug.cgi?id=194059
3373         <rdar://problem/47685715>
3374
3375         Reviewed by Wenson Hsieh.
3376
3377         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3378         DumpRenderTree and TestWebKitAPI, which both try to create an
3379         NSDragItem in a manner that invokes this method. Address this by using
3380         -initWithPasteboardWriter instead.
3381
3382         Note that the parameter passed to initWithPasteboardWriter is likely
3383         incorrect. In both cases, the object passed does not conform to
3384         NSPasteboardWriting. However, with this fix, we're no worse off than
3385         before, and can now perform builds with newer compilers and SDKs until
3386         a real fix can be crafted. That work is tracked in
3387         https://bugs.webkit.org/show_bug.cgi?id=194060
3388
3389         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3390         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3391         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3392         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3393
3394 2019-01-30  Daniel Bates  <dabates@apple.com>
3395
3396         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3397         https://bugs.webkit.org/show_bug.cgi?id=192824
3398         <rdar://problem/47100332>
3399
3400         Reviewed by Wenson Hsieh.
3401
3402         Fix a bug where the wrong usage code was used for F13 thru F24.
3403
3404         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3405         (keyCodeForDOMFunctionKey):
3406
3407 2019-01-30  Chris Dumez  <cdumez@apple.com>
3408
3409         Regression(PSON) Load hang can occur on history navigation
3410         https://bugs.webkit.org/show_bug.cgi?id=194030
3411         <rdar://problem/47656939>
3412
3413         Reviewed by Antti Koivisto.
3414
3415         Add API test coverage.
3416
3417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3418
3419 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3420
3421         [LFC] Expand tests coverage.
3422
3423         Unreviewed test gardening.
3424
3425         * LayoutReloaded/misc/LFC-passing-tests.txt:
3426
3427 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3428
3429         [Flatpak] Add openjpeg support
3430         https://bugs.webkit.org/show_bug.cgi?id=194019
3431
3432         Reviewed by Michael Catanzaro.
3433
3434         * flatpak/org.webkit.CommonModules.yaml:
3435
3436 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3437
3438         Unreviewed, rolling out r240708.
3439         https://bugs.webkit.org/show_bug.cgi?id=194022
3440
3441         It broke WPE build (Requested by KaL on #webkit).
3442
3443         Reverted changeset:
3444
3445         "[WPE] Bump font related dependencies to match the GTK+ port"
3446         https://bugs.webkit.org/show_bug.cgi?id=194017
3447         https://trac.webkit.org/changeset/240708
3448
3449 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3450
3451         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3452         https://bugs.webkit.org/show_bug.cgi?id=194001
3453
3454         Reviewed by Antti Koivisto.
3455
3456         * LayoutReloaded/misc/LFC-passing-tests.txt:
3457
3458 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3459
3460         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3461         https://bugs.webkit.org/show_bug.cgi?id=194020
3462
3463         Reviewed by Antti Koivisto.
3464
3465         * LayoutReloaded/misc/LFC-passing-tests.txt:
3466
3467 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3468
3469         AX: Support color well on iOS
3470         https://bugs.webkit.org/show_bug.cgi?id=194010
3471
3472         Reviewed by Joanmarie Diggs.
3473
3474         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3475         (WTR::AccessibilityUIElement::stringAttributeValue):
3476
3477 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3478
3479         [WPE] Bump font related dependencies to match the GTK+ port
3480         https://bugs.webkit.org/show_bug.cgi?id=194017
3481
3482         Reviewed by Žan Doberšek.
3483
3484         * wpe/jhbuild.modules:
3485         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3486         * wpe/patches/icudata-stdlibs.patch: Added.
3487
3488 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3489
3490         [Mac] Update window scale API usage
3491         https://bugs.webkit.org/show_bug.cgi?id=193991
3492         rdar://problem/47614795
3493
3494         Reviewed by Tim Horton.
3495
3496         * DumpRenderTree/mac/DumpRenderTree.mm:
3497         (changeWindowScaleIfNeeded):
3498         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3499         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3500         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3501
3502 2019-01-29  Chris Dumez  <cdumez@apple.com>
3503
3504         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3505         https://bugs.webkit.org/show_bug.cgi?id=193977
3506         <rdar://problem/47643716>
3507
3508         Reviewed by Geoff Garen.
3509
3510         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3511         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3512         to the previous provisional committing *before* we make the last load. 
3513
3514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3515
3516 2019-01-29  Youenn Fablet  <youenn@apple.com>
3517
3518         Adopt new SPI to evaluate server certificate trust
3519         https://bugs.webkit.org/show_bug.cgi?id=193355
3520
3521         Reviewed by Alex Christensen.
3522
3523         Add infrastructure to handle HTTPS server trust evaluation testing.
3524
3525         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3526         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3527         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3528         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3529         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3531         * WebKitTestRunner/TestController.cpp:
3532         (WTR::TestController::resetPreferencesToConsistentValues):
3533         (WTR::TestController::didReceiveAuthenticationChallenge):
3534         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3535         * WebKitTestRunner/TestController.h:
3536         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3537         * WebKitTestRunner/TestInvocation.cpp:
3538         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3539         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3540         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3541
3542 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3543
3544         [ews-build] Add build step to print bot Configuration
3545         https://bugs.webkit.org/show_bug.cgi?id=193887
3546
3547         Reviewed by Lucas Forschler.
3548
3549         * BuildSlaveSupport/ews-build/steps.py:
3550         (PrintConfiguration): Build step to print configuration.
3551         * BuildSlaveSupport/ews-build/factories.py:
3552
3553 2019-01-29  Chris Dumez  <cdumez@apple.com>
3554
3555         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3556         https://bugs.webkit.org/show_bug.cgi?id=193967
3557         <rdar://problem/47635348>
3558
3559         Reviewed by Alex Christensen.
3560
3561         Add API test coverage.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3564         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3565
3566 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3567
3568         [ews-app] Handle incoming results data
3569         https://bugs.webkit.org/show_bug.cgi?id=193973
3570
3571         Reviewed by Lucas Forschler.
3572
3573         * BuildSlaveSupport/ews-app/ews/views/results.py:
3574
3575 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3576
3577         [ews-app] Make the results url generic
3578         https://bugs.webkit.org/show_bug.cgi?id=193928
3579
3580         Reviewed by Lucas Forschler.
3581
3582         * BuildSlaveSupport/ews-app/ews/urls.py:
3583
3584 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3585
3586         [ews-build] Configure buildbot to send events to ews-app
3587         https://bugs.webkit.org/show_bug.cgi?id=193968
3588
3589         Reviewed by Lucas Forschler.
3590
3591         * BuildSlaveSupport/ews-build/events.py: Added.
3592         * BuildSlaveSupport/ews-build/master.cfg:
3593
3594 2019-01-29  Keith Rollin  <krollin@apple.com>
3595
3596         Add .xcfilelists to Run Script build phases
3597         https://bugs.webkit.org/show_bug.cgi?id=193792
3598         <rdar://problem/47201785>
3599
3600         Reviewed by Alex Christensen.
3601
3602         As part of supporting XCBuild, update the necessary Run Script build
3603         phases in their Xcode projects to refer to their associated
3604         .xcfilelist files.
3605
3606         Note that the addition of these files bumps the Xcode project version
3607         number to something that's Xcode 10 compatible. This change means that
3608         older versions of the Xcode IDE can't read these projects. Nor can it
3609         fully load workspaces that refer to these projects (the updated
3610         projects are shown as non-expandable placeholders). `xcodebuild` can
3611         still build these projects; it's just that the IDE can't open them.
3612
3613         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3614         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3615
3616 2019-01-29  John Wilander  <wilander@apple.com>
3617
3618         Add data abstraction and validation for Ad Click Attribution
3619         https://bugs.webkit.org/show_bug.cgi?id=193916
3620         <rdar://problem/47603481>
3621
3622         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3623
3624         Ad click attribution has two steps. First, the storage of an ad
3625         campaign ID for a click that takes the user to a destination
3626         site. Second, a conversion on the destination site that can be
3627         attributed to the ad click.
3628
3629         This patch adds a class that represents a request for ad click
3630         attribution. Validation makes sure that the bits of entropy
3631         reported through this mechanism is limited.
3632
3633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3634         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3635         (TestWebKitAPI::TEST):
3636
3637 2019-01-29  Chris Dumez  <cdumez@apple.com>
3638
3639         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3640         https://bugs.webkit.org/show_bug.cgi?id=193932
3641         <rdar://problem/47598947>
3642
3643         Reviewed by Brady Eidson.
3644
3645         Add API test coverage.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3648
3649 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3650
3651         Adding new passing LFC tests.
3652
3653         Unreviewed test gardening.
3654
3655         * LayoutReloaded/misc/LFC-passing-tests.txt:
3656
3657 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3658
3659         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3660         https://bugs.webkit.org/show_bug.cgi?id=193964
3661
3662         Reviewed by Antti Koivisto.
3663
3664         * LayoutReloaded/misc/LFC-passing-tests.txt:
3665
3666 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3667
3668         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3669         https://bugs.webkit.org/show_bug.cgi?id=193954
3670
3671         Reviewed by Antti Koivisto.
3672
3673         * LayoutReloaded/misc/LFC-passing-tests.txt:
3674
3675 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3676
3677         WebDriver: add support for running subtests
3678         https://bugs.webkit.org/show_bug.cgi?id=193904
3679
3680         Reviewed by Michael Catanzaro.
3681
3682         pytest already supports it by passing test.py::subtest, so we can do the same.
3683
3684         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3685         (get_item_name): Made this global.
3686         (CollectRecorder.__init__): Receive the parameter to ignore.
3687         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3688         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3689         (collect): Add parameter to ignore.
3690         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3691         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3692         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3693         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3694         (WebDriverTestRunnerSelenium.run): Ditto.
3695         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3696         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3697         (WebDriverTestRunnerW3C.run): Ditto.
3698
3699 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3700
3701         User agent string override for navigator.userAgent should be site specific quirks
3702         https://bugs.webkit.org/show_bug.cgi?id=193950
3703
3704         Reviewed by Brent Fulgham.
3705
3706         Updated per the _WKWebsitePolicies rename.
3707
3708         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3709         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3710
3711 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3712
3713         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3714         https://bugs.webkit.org/show_bug.cgi?id=193941
3715
3716         Reviewed by Alex Christensen.