Delay WebProcess launch until a load is triggered in a Web view
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-18  Chris Dumez  <cdumez@apple.com>
2
3         Delay WebProcess launch until a load is triggered in a Web view
4         https://bugs.webkit.org/show_bug.cgi?id=195758
5         <rdar://problem/48126013>
6
7         Reviewed by Geoff Garen.
8
9         Add API test coverage. Also update some existing API tests to not expect
10         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
11
12         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
15         (TestWebKitAPI::TEST):
16         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
17         (TEST):
18         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
19         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
20         (TEST):
21         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
22         (TEST):
23         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
24
25 2019-03-18  Xan Lopez  <xan@igalia.com>
26
27         [CMake] Prevent potential warning when determining $architecture
28         https://bugs.webkit.org/show_bug.cgi?id=195891
29
30         Reviewed by Michael Catanzaro.
31
32         It's possible for generateBuildSystemForCMakeProject to be called
33         before determineArchitecture() is ever called. This will make the
34         first eq check with $architecture to be bogus (and print a
35         warning). Change that to an eq check with architecture(), which
36         implicitly calls determineArchitecture() if needed, and change all
37         the other similar cases in the method in the same way to prevent
38         future bugs like this one.
39
40         * Scripts/webkitdirs.pm:
41         (generateBuildSystemFromCMakeProject):
42
43 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
44
45         [WPE] Tarballs generated with “make dist” cannot build documentation
46         https://bugs.webkit.org/show_bug.cgi?id=195885
47
48         Reviewed by Carlos Garcia Campos.
49
50         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
51
52 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
53
54         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
55         https://bugs.webkit.org/show_bug.cgi?id=195883
56
57         Reviewed by Carlos Garcia Campos.
58
59         * gtkdoc/gtkdoc.py:
60         (GTKDoc._run_command): When commands fail to run, include the full command line for
61         the program invocation and the output it has generated on the standard error stream.
62
63 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
64
65         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
66         https://bugs.webkit.org/show_bug.cgi?id=195786
67
68         Reviewed by Philippe Normand.
69
70         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
71         * wpe/jhbuild.modules: Ditto.
72
73 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews-build] Don't run clean builds on EWS builders
76         https://bugs.webkit.org/show_bug.cgi?id=195851
77
78         Reviewed by Geoffrey Garen.
79
80         * BuildSlaveSupport/ews-build/factories.py:
81
82 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
83
84         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
85         https://bugs.webkit.org/show_bug.cgi?id=195849
86
87         Reviewed by Chris Dumez.
88
89         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
92         (runWebsiteDataStoreCustomPaths):
93
94 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
95
96         webkitpy: Upload test results
97         https://bugs.webkit.org/show_bug.cgi?id=195755
98         <rdar://problem/48896182>
99
100         Reviewed by Aakash Jain.
101
102         Establish a new format for uploading results that is not tied to layout tests, apply
103         that format to webkitpy tests.
104
105         * Scripts/webkitpy/common/checkout/scm/git.py:
106         (Git.native_branch): Return what branch the current checkout is on.
107         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
108         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
109         * Scripts/webkitpy/common/checkout/scm/svn.py:
110         (SVN.native_branch): Ditto.
111         * Scripts/webkitpy/common/system/platforminfo.py:
112         (PlatformInfo.build_version): Return a build version for Mac.
113         * Scripts/webkitpy/common/system/platforminfo_mock.py:
114         (MockPlatformInfo.__init__):
115         (MockPlatformInfo.build_version):
116         * Scripts/webkitpy/results: Added.
117         * Scripts/webkitpy/results/__init__.py: Added.
118         * Scripts/webkitpy/results/options.py: Added.
119         (upload_options): OptParse list for upload options.
120         * Scripts/webkitpy/results/upload.py: Added.
121         (Upload): Class which enforces the upload format expected by the results server.
122         (Upload.Expectations):
123         (Upload.create_configuration):
124         (Upload.create_commit):
125         (Upload.create_details):
126         (Upload.create_run_stats):
127         (Upload.create_test_result):
128         (Upload.__init__):
129         (Upload.Encoder): Encode Upload object as json.
130         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
131         * Scripts/webkitpy/results/upload_unittest.py: Added.
132         * Scripts/webkitpy/test/main.py:
133         (Tester._parse_args): Add upload arguments.
134         (Tester._run_tests): Allow results to be uploaded.
135         * Scripts/webkitpy/test/runner.py:
136         (Runner.__init__): Record which tests were run, rather than just counting them.
137         (Runner.handle):
138         * Scripts/webkitpy/test/runner_unittest.py:
139         (RunnerTest.test_run):
140         * Scripts/webkitpy/thirdparty/__init__.py:
141         (AutoinstallImportHook.find_module): Add requests auto-install.
142         (AutoinstallImportHook._install_requests):
143         * Scripts/webkitpy/tool/commands/queues_unittest.py:
144         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
145
146 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
147
148         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
149         https://bugs.webkit.org/show_bug.cgi?id=195810
150
151         Reviewed by Tim Horton.
152
153         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
154         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
155         ending certain layout tests.
156
157         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
158         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
159         (-[TestRunnerWKWebView dealloc]):
160         (-[TestRunnerWKWebView resetInteractionCallbacks]):
161
162         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
163         helper method when destroying the web view, and when resetting state between tests.
164
165         * WebKitTestRunner/ios/TestControllerIOS.mm:
166         (WTR::TestController::platformResetStateToConsistentValues):
167
168         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
169
170 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
171
172         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
173         https://bugs.webkit.org/show_bug.cgi?id=190350
174         <rdar://problem/45089503>
175
176         Reviewed by Geoffrey Garen.
177
178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
179         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
180         (TEST):
181         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
182         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
183         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
184         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
185         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
186         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
187         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
188         (runTest):
189         (createDirectories):
190         (TEST):
191         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
192         (TEST):
193         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
194         (TEST):
195
196 2019-03-15  Timothy Hatcher  <timothy@apple.com>
197
198         Add support to WebPage for getting the contents as an attributed string.
199         https://bugs.webkit.org/show_bug.cgi?id=195636
200         rdar://problem/45055697
201
202         Reviewed by Tim Horton.
203
204         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
205         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
206
207 2019-03-15  Chris Dumez  <cdumez@apple.com>
208
209         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
210         https://bugs.webkit.org/show_bug.cgi?id=195747
211
212         Reviewed by Geoff Garen.
213
214         Add API test coverage.
215
216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
217
218 2019-03-15  Shawn Roberts  <sroberts@apple.com>
219
220         Unreviewed, rolling out r242952.
221
222         Causing API failures on iOS Simulator
223
224         Reverted changeset:
225
226         "[PSON] Make sure the WebProcessCache is leverage when
227         relaunching a process after termination"
228         https://bugs.webkit.org/show_bug.cgi?id=195747
229         https://trac.webkit.org/changeset/242952
230
231 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
232
233         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
234         https://bugs.webkit.org/show_bug.cgi?id=195740
235
236         Reviewed by Ross Kirsling.
237
238         window.open doesn't work for WebKitBrowserWindow because it is not
239         implemented yet.
240
241         1. Implemented createNewPage callback of WKPageUIClient.
242         2. Changed MainWindow to take a BrowserWindow factory function
243           instead of BrowserWindowType to be flexible to create
244           BrowserWindow with extra settings.
245         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
246           because it is not relevant with MainWindow anymore.
247
248         * MiniBrowser/win/Common.cpp:
249         (parseCommandLine):
250         * MiniBrowser/win/Common.h:
251         (CommandLineOptions::CommandLineOptions):
252         * MiniBrowser/win/MainWindow.cpp:
253         (MainWindow::MainWindow):
254         (MainWindow::create):
255         (MainWindow::init):
256         (MainWindow::WndProc):
257         * MiniBrowser/win/MainWindow.h:
258         * MiniBrowser/win/PrintWebUIDelegate.cpp:
259         (PrintWebUIDelegate::createWebViewWithRequest):
260         * MiniBrowser/win/WebKitBrowserWindow.cpp:
261         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
262         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
263         (WebKitBrowserWindow::updateProxySettings):
264         (WebKitBrowserWindow::createNewPage):
265         * MiniBrowser/win/WebKitBrowserWindow.h:
266         * MiniBrowser/win/WinMain.cpp:
267         (wWinMain):
268
269 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
270
271         Make it possible to test scrolling tree layer manipulation more easily
272         https://bugs.webkit.org/show_bug.cgi?id=195780
273
274         Reviewed by Tim Horton.
275         
276         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
277         cuts off communication of scrolling tree scrolls back to the web process
278         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
279         allows tests to trigger scrolls which run the scrolling tree layer positioning
280         logic, but never get another commit from the web process that might mask
281         scrolling tree bugs.
282         
283         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
284         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
285         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
286
287         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
288         (WTR::UIScriptController::scrollUpdatesDisabled const):
289         (WTR::UIScriptController::setScrollUpdatesDisabled):
290         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
291         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
292         (WTR::UIScriptController::scrollUpdatesDisabled const):
293         (WTR::UIScriptController::setScrollUpdatesDisabled):
294         * TestRunnerShared/UIScriptContext/UIScriptController.h:
295         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
296         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
297         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
298         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
299         * WebKitTestRunner/ios/TestControllerIOS.mm:
300         (WTR::TestController::platformResetStateToConsistentValues):
301         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
302         (WTR::UIScriptController::scrollUpdatesDisabled const):
303         (WTR::UIScriptController::setScrollUpdatesDisabled):
304
305 2019-03-14  Youenn Fablet  <youenn@apple.com>
306
307         Move IDB storage in private browsing mode to NetworkProcess
308         https://bugs.webkit.org/show_bug.cgi?id=195602
309
310         Reviewed by Brady Eidson.
311
312         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
313         (TEST):
314
315 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
316
317         [ews-build] Make descriptionDone messages more readable
318         https://bugs.webkit.org/show_bug.cgi?id=195760
319
320         Reviewed by Lucas Forschler.
321
322         * BuildSlaveSupport/ews-build/steps.py:
323         * BuildSlaveSupport/ews-build/steps_unittest.py:
324
325 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
326
327         [ews-build] Generate status-bubble hover-over messages
328         https://bugs.webkit.org/show_bug.cgi?id=195680
329
330         Reviewed by Lucas Forschler.
331
332         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
333         (StatusBubble):
334         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
335         on hover-over.
336         (StatusBubble._iso_time):
337         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
338         hover-over message.
339         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
340
341 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
342
343         [ews-app] Gracefully handle the case when state_string is None
344         https://bugs.webkit.org/show_bug.cgi?id=195753
345
346         Reviewed by Lucas Forschler.
347
348         * BuildSlaveSupport/ews-app/ews/models/build.py:
349         * BuildSlaveSupport/ews-app/ews/models/step.py:
350
351 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-app] Status bubble display pending for currently running build step
354         https://bugs.webkit.org/show_bug.cgi?id=195744
355
356         Reviewed by Lucas Forschler.
357
358         * BuildSlaveSupport/ews-build/events.py:
359         (Events.stepStarted): If state_string is pending, replace it with step name.
360
361 2019-03-14  Chris Dumez  <cdumez@apple.com>
362
363         Add WebsitePolicy for the client to specify the device orientation & motion access policy
364         https://bugs.webkit.org/show_bug.cgi?id=195750
365
366         Reviewed by Geoffrey Garen.
367
368         Add API test coverage.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
371         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
372         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
373         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
374
375 2019-03-14  Chris Dumez  <cdumez@apple.com>
376
377         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
378         https://bugs.webkit.org/show_bug.cgi?id=195747
379
380         Reviewed by Geoff Garen.
381
382         Add API test coverage.
383
384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
385
386 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
387
388         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
389         https://bugs.webkit.org/show_bug.cgi?id=195725
390         <rdar://problem/48545062>
391
392         Reviewed by Tim Horton.
393
394         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
395         handler is nil.
396
397         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
398         (TestWebKitAPI::TEST):
399
400 2019-03-13  Sam Weinig  <sam@webkit.org>
401
402         Add utility function to allow easy reverse range-based iteration of a container
403         https://bugs.webkit.org/show_bug.cgi?id=195542
404
405         Reviewed by Antti Koivisto.
406
407         * TestWebKitAPI/CMakeLists.txt:
408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
409         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
410         (TestWebKitAPI::TEST):
411         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
412
413 2019-03-13  Chris Dumez  <cdumez@apple.com>
414
415         Use a ServiceWorker process per registrable domain
416         https://bugs.webkit.org/show_bug.cgi?id=195649
417
418         Reviewed by Youenn Fablet.
419
420         Update API test coverage.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
423
424 2019-03-13  Chris Dumez  <cdumez@apple.com>
425
426         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
427         https://bugs.webkit.org/show_bug.cgi?id=195684
428         <rdar://problem/48294714>
429
430         Reviewed by Antti Koivisto.
431
432         Add API test coverage.
433
434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
435
436 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
437
438         [ews-app] Remove unused patch view
439         https://bugs.webkit.org/show_bug.cgi?id=195669
440
441         Reviewed by Lucas Forschler.
442
443         * BuildSlaveSupport/ews-app/ews/urls.py:
444         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
445
446 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
447
448         [ews-app] Use Buildbot result code variables
449         https://bugs.webkit.org/show_bug.cgi?id=195668
450
451         Reviewed by Alexey Proskuryakov.
452
453         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
454         (Buildbot): Added Buildbot result code variables.
455         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
456         (StatusBubble._build_bubble): Used Buildbot result code variables.
457
458 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
459
460         [Flatpak] Expand submodule recursively
461         https://bugs.webkit.org/show_bug.cgi?id=195672
462
463         Building WPE with flatpak was impossible without that as it was raising an exception.
464         Also update wpebackend-fdo to match what is built in jhbuild
465
466         Reviewed by Philippe Normand.
467
468         * flatpak/flatpakutils.py:
469         (expand_submodules_recurse):
470         (expand_manifest):
471         * flatpak/org.webkit.WPEModules.yaml:
472
473 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
474
475         [ews-app] status bubble should be hidden for certain builds
476         https://bugs.webkit.org/show_bug.cgi?id=194597
477
478         Reviewed by Dewei Zhu.
479
480         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
481         (StatusBubble._build_bubble):
482         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
483         because the patch didn't have relevant changes.
484         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
485         in production yet.
486
487 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
488
489         [Win] Fix a slew of simple clang-cl warnings.
490         https://bugs.webkit.org/show_bug.cgi?id=195652
491
492         Reviewed by Don Olmstead.
493
494         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
495         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
496
497 2019-03-12  Justin Fan  <justin_fan@apple.com>
498
499         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
500         https://bugs.webkit.org/show_bug.cgi?id=195518
501         <rdar://problem/46322356>
502
503         Reviewed by Myles C. Maxfield.
504
505         * DumpRenderTree/DerivedSources-input.xcfilelist:
506         * DumpRenderTree/DerivedSources-output.xcfilelist:
507
508 2019-03-12  Commit Queue  <commit-queue@webkit.org>
509
510         Unreviewed, rolling out r242825.
511         https://bugs.webkit.org/show_bug.cgi?id=195648
512
513         "Broke webkitpy tests with my change to
514         lldb_dump_class_layout.py" (Requested by rmorisset on
515         #webkit).
516
517         Reverted changeset:
518
519         "Alter Tools/Scripts/dump-class-layout to be able to dump all
520         classes with suspicious padding"
521         https://bugs.webkit.org/show_bug.cgi?id=195573
522         https://trac.webkit.org/changeset/242825
523
524 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
525
526         [ews-build] Show status bubbles while the patch is waiting in queue
527         https://bugs.webkit.org/show_bug.cgi?id=195618
528
529         Reviewed by Lucas Forschler.
530
531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
532         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
533         enabled in initial deployment.
534         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
535         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
536         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
537         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
538         (StatusBubble._build_bubbles_for_patch):
539
540 2019-03-12  Robin Morisset  <rmorisset@apple.com>
541
542         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
543         https://bugs.webkit.org/show_bug.cgi?id=195573
544
545         Reviewed by Simon Fraser.
546
547         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
548
549         * Scripts/dump-class-layout:
550         (main):
551         * lldb/lldb_dump_class_layout.py:
552         (ClassLayout.__init__):
553         (ClassLayout._compute_padding_recursive):
554         (LLDBDebuggerInstance.dump_layout_for_classname):
555         (LLDBDebuggerInstance):
556         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
557         (LLDBDebuggerInstance.layout_for_classname): Deleted.
558
559 2019-03-12  Chris Dumez  <cdumez@apple.com>
560
561         Device Orientation access permission should be denied unless explicitly granted by the client
562         https://bugs.webkit.org/show_bug.cgi?id=195625
563
564         Reviewed by Youenn Fablet.
565
566         add API test coverage.
567
568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
569         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
570         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
571         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
572         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
573         (runDeviceOrientationTest):
574         (TEST):
575         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
576         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
577
578 2019-03-12  Jer Noble  <jer.noble@apple.com>
579
580         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
581         https://bugs.webkit.org/show_bug.cgi?id=195137
582         <rdar://problem/48810307>
583
584         Reviewed by Eric Carlson.
585
586         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
587         (TestWebKitAPI::TEST):
588
589 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
590
591         [ews-build] Change urls from uat to production
592         https://bugs.webkit.org/show_bug.cgi?id=195566
593
594         Reviewed by Lucas Forschler.
595
596         * BuildSlaveSupport/ews-app/ews/config.py:
597         * BuildSlaveSupport/ews-build/events.py:
598         * BuildSlaveSupport/ews-build/steps.py:
599
600 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
601
602         [ews-build] change max_builds for local-worker to 1
603         https://bugs.webkit.org/show_bug.cgi?id=195568
604
605         Reviewed by Lucas Forschler.
606
607         * BuildSlaveSupport/ews-build/loadConfig.py:
608
609 2019-03-12  Tim Horton  <timothy_horton@apple.com>
610
611         Fix the build
612
613         * TestRunnerShared/spi/PencilKitTestSPI.h:
614         * TestWebKitAPI/ios/PencilKitTestSPI.h:
615
616 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
617
618         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
619         https://bugs.webkit.org/show_bug.cgi?id=194131
620
621         Reviewed by Michael Catanzaro.
622
623         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
624         (uriChanged):
625         (testUnfinishedSubresourceLoad):
626         (serverCallback):
627         (beforeAll):
628
629 2019-03-11  Alex Christensen  <achristensen@webkit.org>
630
631         WTF::Expected should use std::addressof instead of operator&
632         https://bugs.webkit.org/show_bug.cgi?id=195604
633
634         Reviewed by Myles Maxfield.
635
636         * TestWebKitAPI/Tests/WTF/Expected.cpp:
637         (TestWebKitAPI::Unique::Unique):
638         (TestWebKitAPI::Unique::operator&):
639         (TestWebKitAPI::TEST):
640
641 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
642
643         Add Optional to Forward.h.
644         https://bugs.webkit.org/show_bug.cgi?id=195586
645
646         Reviewed by Darin Adler.
647
648         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
649         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
650         Remove unnecessary includes from headers.
651
652 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
653
654         Add testing API to hit-test and scroll overflow scrollers
655         https://bugs.webkit.org/show_bug.cgi?id=195278
656
657         Reviewed by Antti Koivisto.
658         
659         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
660         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
661         
662         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
663
664         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
665         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
666         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
667         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
668         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
669         * TestRunnerShared/UIScriptContext/UIScriptController.h:
670         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
671         (WTR::enclosingScrollViewIncludingSelf):
672         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
673
674 2019-03-11  Tim Horton  <timothy_horton@apple.com>
675
676         API test WebKit.RequestTextInputContext fails on iOS
677         https://bugs.webkit.org/show_bug.cgi?id=195585
678
679         Reviewed by Wenson Hsieh and Simon Fraser.
680
681         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
682         (applyStyle):
683         (TEST):
684         Add a viewport, so that the coordinates match up on iOS.
685         Scroll by moving the UIScrollView's contentOffset.
686
687 2019-03-11  Chris Dumez  <cdumez@apple.com>
688
689         Assert in WebPageProxy::suspendCurrentPageIfPossible()
690         https://bugs.webkit.org/show_bug.cgi?id=195506
691         <rdar://problem/48733477>
692
693         Reviewed by Alex Christensen.
694
695         Add API test coverage.
696
697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
698
699 2019-03-11  Shawn Roberts  <sroberts@apple.com>
700
701         Adding myself to contributors.json
702
703         Unreviewed, addming myself to contributors.json .
704
705         * Scripts/webkitpy/common/config/contributors.json:
706
707 2019-03-11  Alex Christensen  <achristensen@webkit.org>
708
709         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
710         https://bugs.webkit.org/show_bug.cgi?id=195511
711         <rdar://problem/44873269>
712
713         Reviewed by Darin Adler.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
716         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
717         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
718         (TEST_F):
719
720 2019-03-11  Chris Dumez  <cdumez@apple.com>
721
722         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
723         https://bugs.webkit.org/show_bug.cgi?id=195561
724
725         Reviewed by Youenn Fablet.
726
727         Make sure the JS in the test requests for permission to receive device orientation events.
728
729         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
730
731 2019-03-11  Youenn Fablet  <youenn@apple.com>
732
733         Allow storage quota increase by default in WTR
734         https://bugs.webkit.org/show_bug.cgi?id=195541
735
736         Reviewed by Geoffrey Garen.
737
738         Allow storage quota increase by default in WTR.
739         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
740         Use this for tests that explicitly need cache increase.
741
742         Instead of increasing quota by 2, make sure the next request is
743         granted by adding all given parameters.
744
745         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
746         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
747         (WTR::TestRunner::setAllowStorageQuotaIncrease):
748         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
749         * WebKitTestRunner/InjectedBundle/TestRunner.h:
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::TestController::setAllowStorageQuotaIncrease):
752         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
753         * WebKitTestRunner/TestController.h:
754         * WebKitTestRunner/TestInvocation.cpp:
755         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
757         (WTR::TestController::cocoaResetStateToConsistentValues):
758         (WTR::TestController::setAllowStorageQuotaIncrease):
759         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
760         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
761         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
762
763 2019-03-11  Xan Lopez  <xan@igalia.com>
764
765         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
766         https://bugs.webkit.org/show_bug.cgi?id=194147
767
768         Reviewed by Michael Saboff.
769
770         To make --32-bit work correctly on Linux/64bit we need to:
771
772         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
773         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
774         unfortunately CMake only allows us to do this during
775         crosscompilation, which is overkill here.
776         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
777         pkg-config detection module uses the x86 .pc files instead of the
778         x86_64 ones.
779         - Set the -m32 flags for the compiler.
780
781         * Scripts/webkitdirs.pm:
782         (generateBuildSystemFromCMakeProject):
783
784 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
785
786         Add MotionMark-1.1 plan file for run-benchmark script.
787         https://bugs.webkit.org/show_bug.cgi?id=195481
788
789         Rubber-stamped by Darin Adler.
790
791         Run-benchmark script should support MontionMark-1.1.
792
793         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
794
795 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
796
797         [ews-app] Add support for submit-to-ews url
798         https://bugs.webkit.org/show_bug.cgi?id=195477
799
800         Reviewed by Lucas Forschler.
801
802         * BuildSlaveSupport/ews-app/ews/fetcher.py:
803         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
804         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
805         * BuildSlaveSupport/ews-app/ews/urls.py:
806         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
807
808 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
809
810         Unreviewed, rolling out r242688, r242643, r242624.
811
812         Caused multiple layout test failures and crashes on iOS and macOS.
813
814         Reverted changeset:
815
816         "requestAnimationFrame should execute before the next frame"
817         https://bugs.webkit.org/show_bug.cgi?id=177484
818         https://trac.webkit.org/changeset/242624/webkit
819
820         * Tracing/SystemTracePoints.plist:
821
822 2019-03-11  John Wilander  <wilander@apple.com>
823
824         Resource Load Statistics: Make it possible exclude localhost from classification
825         https://bugs.webkit.org/show_bug.cgi?id=195474
826         <rdar://problem/47520577>
827
828         Reviewed by Brent Fulgham.
829
830         This patch allows for localhost to be excluded from classification and
831         treatment as a prevalent resource.
832
833         The WebKit Tools change adds a new function called
834         testRunner.setStatisticsIsRunningTest() which can be used to control this
835         behavior.
836
837         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
838         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
839         (WTR::TestRunner::setStatisticsIsRunningTest):
840         * WebKitTestRunner/InjectedBundle/TestRunner.h:
841         * WebKitTestRunner/TestController.cpp:
842         (WTR::TestController::setStatisticsIsRunningTest):
843         * WebKitTestRunner/TestController.h:
844         * WebKitTestRunner/TestInvocation.cpp:
845         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
846
847 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
848
849         [ews-build] Disable waterfall and console view for ews-build.webkit.org
850         https://bugs.webkit.org/show_bug.cgi?id=195560
851
852         Reviewed by Lucas Forschler.
853
854         * BuildSlaveSupport/ews-build/master.cfg:
855
856 2019-03-11  Alex Christensen  <achristensen@webkit.org>
857
858         Unreviewed, rolling out r242698.
859
860         API test crashes on bots.
861
862         Reverted changeset:
863
864         "Add a WKContentRuleList variant that uses copied memory
865         instead of mmap'd shared memory for class A containerized
866         apps"
867         https://bugs.webkit.org/show_bug.cgi?id=195511
868         https://trac.webkit.org/changeset/242698
869
870 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
871
872         [WPE] Enable web process sandbox
873         https://bugs.webkit.org/show_bug.cgi?id=195169
874
875         Reviewed by Daniel Bates.
876
877         * wpe/install-dependencies:
878         * wpe/jhbuild.modules:
879
880 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
881
882         [ews-app] Use port 17000 for worker communication
883         https://bugs.webkit.org/show_bug.cgi?id=195558
884
885         Reviewed by Lucas Forschler.
886
887         * BuildSlaveSupport/ews-build/master.cfg:
888
889 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
890
891         [ews-build] unit-tests fail when passwords.json is missing
892         https://bugs.webkit.org/show_bug.cgi?id=195557
893
894         Reviewed by Lucas Forschler.
895
896         * BuildSlaveSupport/ews-build/loadConfig.py:
897         (loadBuilderConfig):
898         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
899         (ConfigDotJSONTest.test_configuration):
900         * BuildSlaveSupport/ews-build/master.cfg:
901
902 2019-03-11  Truitt Savell  <tsavell@apple.com>
903
904         Unreviewed, rolling out r242702.
905
906         Broke High Sierra builders.
907
908         Reverted changeset:
909
910         "Add utility function to allow easy reverse range-based
911         iteration of a container"
912         https://bugs.webkit.org/show_bug.cgi?id=195542
913         https://trac.webkit.org/changeset/242702
914
915 2019-03-11  Sam Weinig  <sam@webkit.org>
916
917         Add utility function to allow easy reverse range-based iteration of a container
918         https://bugs.webkit.org/show_bug.cgi?id=195542
919
920         Reviewed by Antti Koivisto.
921
922         * TestWebKitAPI/CMakeLists.txt:
923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
924         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
925         (TestWebKitAPI::TEST):
926         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
927
928 2019-03-10  Alex Christensen  <achristensen@webkit.org>
929
930         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
931         https://bugs.webkit.org/show_bug.cgi?id=195511
932         <rdar://problem/44873269>
933
934         Reviewed by Darin Adler.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
937         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
938         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
939         (TEST_F):
940
941 2019-03-10  Tim Horton  <timothy_horton@apple.com>
942
943         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
944         https://bugs.webkit.org/show_bug.cgi?id=195499
945
946         Reviewed by Darin Adler.
947
948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
949         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
950         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
951         (-[WKWebView synchronouslyFocusTextInputContext:]):
952         (applyStyle):
953         (applyIframe):
954         (TEST):
955         Add some tests for this SPI.
956
957 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
958
959         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
960         https://bugs.webkit.org/show_bug.cgi?id=181151
961
962         Reviewed by Don Olmstead.
963
964         * TestWebKitAPI/CMakeLists.txt:
965         * TestWebKitAPI/PlatformWin.cmake:
966         Enable TestWTF RunLoop tests in all platforms.
967
968         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
969         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
970         (TestWebKitAPI::DerivedOneShotTimer::fired):
971         (TestWebKitAPI::TEST):
972         Only a few platforms support nested RunLoop.
973
974         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
975         (TestWebKitAPI::DerivedRepeatingTimer::fired):
976
977 2019-03-10  David Quesada  <david_quesada@apple.com>
978
979         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
980         https://bugs.webkit.org/show_bug.cgi?id=152480
981
982         Reviewed by Chris Dumez.
983
984         Add a unit test based on Daniel Bates's test case that starts a download, ensures
985         there are no additional references to the process pool besides the one held by
986         the download, waits for the download to finish (in the sense that the
987         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
988         measure, also check that the process pool has been deallocated at the end of the
989         test. The test wouldn't be meaningful if the process pool were still alive.
990
991         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
992         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
993         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
994             The download will be canceled because the delegate does not implement the
995             method to decide the download's destination, so this is where we know the
996             DownloadProxyMap is done with the DownloadProxy.
997         (TEST):
998
999 2019-03-08  Chris Dumez  <cdumez@apple.com>
1000
1001         Add support for Device Orientation / Motion permission API
1002         https://bugs.webkit.org/show_bug.cgi?id=195329
1003         <rdar://problem/47645367>
1004
1005         Reviewed by Geoffrey Garen.
1006
1007         Add test infrastructure to help test the Device Orientation / Motion permission API.
1008
1009         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1010         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1011         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1012         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1013         * WebKitTestRunner/TestController.cpp:
1014         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1015         (WTR::TestController::createWebViewWithOptions):
1016         (WTR::TestController::resetStateToConsistentValues):
1017         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1018         * WebKitTestRunner/TestController.h:
1019         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1020         * WebKitTestRunner/TestInvocation.cpp:
1021         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1022
1023 2019-03-08  Saam barati  <sbarati@apple.com>
1024
1025         Add a compare-results script to compare benchmark results
1026         https://bugs.webkit.org/show_bug.cgi?id=195486
1027         <rdar://problem/48723397>
1028
1029         Reviewed by Geoffrey Garen.
1030
1031         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1032         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1033         to extend it to learn about our other benchmarks.
1034
1035         * Scripts/compare-results: Added.
1036         (readJSONFile):
1037         (detectJetStream2):
1038         (JetStream2Results):
1039         (detectSpeedometer2):
1040         (Speedometer2Results):
1041         (detectPLT5):
1042         (PLT5Results):
1043         (detectBenchmark):
1044         (biggerIsBetter):
1045         (ttest):
1046         (getOptions):
1047         (main):
1048
1049 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1050
1051         Ensure old tab state is cleared between iterations of run-benchmark
1052         https://bugs.webkit.org/show_bug.cgi?id=195393
1053         <rdar://problem/46885583>
1054
1055         Reviewed by Dewei Zhu.
1056
1057         a) ensure the default to restore state is not set
1058         b) terminate Safari correctly
1059         c) Set the system default to ignore Persistent State in Safari
1060
1061         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1062         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1063         (OSXBrowserDriver.prepare_env): 
1064         (OSXBrowserDriver.restore_env):
1065         (OSXBrowserDriver.close_browsers):
1066         (OSXBrowserDriver._terminate_processes):
1067         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1068         (OSXChromeDriver):
1069         (OSXChromeCanaryDriver):
1070         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1071         (OSXFirefoxDriver):
1072         (OSXFirefoxNightlyDriver):
1073         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1074         (OSXSafariDriver):
1075         (OSXSafariDriver.prepare_env):
1076
1077 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1078
1079         [GTK] Several InputMethodFilter tests are failing
1080         https://bugs.webkit.org/show_bug.cgi?id=195408
1081
1082         Reviewed by Carlos Garcia Campos.
1083
1084         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1085         Regressed in r241751.
1086         Hexadecimal values of keycodes are expressed now in upper letters.
1087         Composited characters should be cast to UTF8 strings.
1088
1089         (TestWebKitAPI::TEST):
1090
1091 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1092
1093         [GTK] Make Tools/gtkdoc python3 compatible
1094         https://bugs.webkit.org/show_bug.cgi?id=195359
1095
1096         Reviewed by Carlos Garcia Campos.
1097
1098         * gtkdoc/generate-gtkdoc:
1099         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1100         work with Python 2 and 3.
1101         (get_gtkdoc_module_paths):
1102         The iteritems() was removed in Python 3, so let's use items() that's
1103         available in Python 2 and 3.
1104         (get_generator_for_config):
1105         * gtkdoc/gtkdoc.py:
1106         (GTKDoc._run_command):
1107         The sys.stdout.write() is expecting str in Python 3 and not bytes
1108         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1109         for passing the bytes there.
1110
1111 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1112
1113         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1114         https://bugs.webkit.org/show_bug.cgi?id=195346
1115         <rdar://problem/48667048>
1116
1117         Unreviewed build fix for clang-cl.
1118
1119         * DumpRenderTree/win/DumpRenderTree.cpp:
1120         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1121
1122 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1123
1124         requestAnimationFrame should execute before the next frame
1125         https://bugs.webkit.org/show_bug.cgi?id=177484
1126
1127         Reviewed by Simon Fraser.
1128
1129         Add trace points for the page RenderingUpdate.
1130
1131         * Tracing/SystemTracePoints.plist:
1132
1133 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1134
1135         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1136         https://bugs.webkit.org/show_bug.cgi?id=195353
1137         <rdar://problem/48626394>
1138
1139         Reviewed by Simon Fraser.
1140
1141         * WebKitTestRunner/ios/TestControllerIOS.mm:
1142         (WTR::TestController::platformResetPreferencesToConsistentValues):
1143
1144 2019-03-07  John Wilander  <wilander@apple.com>
1145
1146         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1147         https://bugs.webkit.org/show_bug.cgi?id=195383
1148         <rdar://problem/48570136>
1149
1150         Reviewed by Brent Fulgham.
1151
1152         This patch adds test infrastructure to purge only script-accessible cookies,
1153         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1154
1155         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1156         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1157         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1158         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1159         * WebKitTestRunner/TestController.cpp:
1160         (WTR::TestController::statisticsDeleteCookiesForHost):
1161         * WebKitTestRunner/TestController.h:
1162         * WebKitTestRunner/TestInvocation.cpp:
1163         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1164
1165 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1166
1167         Unreviewed, rolling out r242354.
1168         https://bugs.webkit.org/show_bug.cgi?id=195402
1169
1170         breaks layout tests in all configurations (Requested by
1171         zdobersek on #webkit).
1172
1173         Reverted changeset:
1174
1175         "[WPE] Enable web process sandbox"
1176         https://bugs.webkit.org/show_bug.cgi?id=195169
1177         https://trac.webkit.org/changeset/242354
1178
1179 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1180
1181         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1182         https://bugs.webkit.org/show_bug.cgi?id=195346
1183
1184         Reviewed by Fujii Hironori.
1185
1186         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1187         (TestWebKitAPI::TEST):
1188         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1189
1190         * DumpRenderTree/win/DumpRenderTree.cpp:
1191         (findFontFallback):
1192         (addFontFallbackIfPresent):
1193         (removeFontFallbackIfPresent):
1194         (main):
1195         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1196         (TestWebKitAPI::Util::moduleDirectory):
1197         (TestWebKitAPI::Util::createInjectedBundlePath):
1198         Use wchar helpers as needed.
1199
1200 2019-03-06  Rob Buis  <rbuis@igalia.com>
1201
1202         Consider supporting the `referrerpolicy` attribute.
1203         https://bugs.webkit.org/show_bug.cgi?id=179053
1204
1205         Reviewed by Darin Adler.
1206
1207         Add a runtime flag for referrerpolicy attribute.
1208
1209         * DumpRenderTree/mac/DumpRenderTree.mm:
1210         (enableExperimentalFeatures):
1211
1212 2019-03-05  Daniel Bates  <dabates@apple.com>
1213
1214         Update expected API test result following r242379
1215         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1216
1217         Update expected x-coordinate of selection rect now that the left padding of
1218         a textarea is sized in ems (so dependent on the font size) just like the left
1219         padding of a text field.
1220
1221         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1222         (TestWebKitAPI::TEST):
1223
1224 2019-03-05  David Quesada  <david_quesada@apple.com>
1225
1226         [WK2] It should be possible to follow links with 'download' attributes
1227         https://bugs.webkit.org/show_bug.cgi?id=195145
1228         rdar://problem/48462642
1229
1230         Reviewed by Alex Christensen.
1231
1232         Add a unit test to verify that activating links with 'download' attributes now
1233         navigates to the linked resource, rather than starts downloading it. Add another
1234         to verify that it is still possible to explicitly download the link via the
1235         'Download' navigation action policy.
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1238         (-[DownloadAttributeTestDelegate init]):
1239         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1240         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1241         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1242         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1243         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1244         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1245         (TEST):
1246         * WebKitTestRunner/TestController.cpp:
1247         (WTR::TestController::decidePolicyForNavigationAction):
1248         * WebKitTestRunner/TestController.h:
1249
1250 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1251
1252         [Curl] Implement Cookie Accept Policy.
1253         https://bugs.webkit.org/show_bug.cgi?id=191645
1254
1255         Reviewed by Fujii Hironori.
1256
1257         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1258         (TestWebKitAPI::Curl::TEST_F):
1259
1260 2019-03-05  Youenn Fablet  <youenn@apple.com>
1261
1262         Rename requestCacheStorageSpace to requestStorageSpace
1263         https://bugs.webkit.org/show_bug.cgi?id=195282
1264
1265         Reviewed by Chris Dumez.
1266
1267         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1268         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1269         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1270
1271 2019-03-05  Brady Eidson  <beidson@apple.com>
1272
1273         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1274         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1275
1276         Reviewed by Tim Horton.
1277
1278         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1279         different directory into that same WKWebView should work.
1280
1281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1282         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1283
1284 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1285
1286         Add WeakHashSet
1287         https://bugs.webkit.org/show_bug.cgi?id=195152
1288
1289         Reviewed by Antti Koivisto.
1290
1291         Added tests for WeakHashSet.
1292
1293         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1294         (TestWebKitAPI::Base::Base): Moved.
1295         (TestWebKitAPI::Derived::foo): Moved.
1296         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1297         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1298         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1299         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1300
1301 2019-03-04  Chris Dumez  <cdumez@apple.com>
1302
1303         Do not share WebProcesses between private and regular sessions
1304         https://bugs.webkit.org/show_bug.cgi?id=195189
1305         <rdar://problem/48421064>
1306
1307         Reviewed by Alex Christensen.
1308
1309         Add API test coverage.
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1312         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1313
1314 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1315
1316         [WPE] Enable web process sandbox
1317         https://bugs.webkit.org/show_bug.cgi?id=195169
1318
1319         Reviewed by Daniel Bates.
1320
1321         * wpe/install-dependencies:
1322         * wpe/jhbuild.modules:
1323
1324 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1325
1326         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
1327         https://bugs.webkit.org/show_bug.cgi?id=195206
1328
1329         Reviewed by Žan Doberšek.
1330
1331         Add a new test case.
1332
1333         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1334         (testJSCClass):
1335
1336 2019-03-04  Charlie Turner  <cturner@igalia.com>
1337
1338         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
1339         https://bugs.webkit.org/show_bug.cgi?id=194898
1340
1341         Reviewed by Žan Doberšek.
1342
1343         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
1344         a GCC extension that permits arithmetic on void* pointer. Inline
1345         the macro until this issue is fixed upstream.
1346
1347 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1348
1349         Rid the world of WK_API_ENABLED
1350         https://bugs.webkit.org/show_bug.cgi?id=195263
1351
1352         Reviewed by Dan Bernstein.
1353
1354         List of changed files elided because it's useless.
1355
1356 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
1357
1358         Unreviewed follow-up to r242292.
1359
1360         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
1361
1362         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1363         (TestWebKitAPI::testStrip): Renamed from strip.
1364         (TestWebKitAPI::TEST):
1365
1366 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1367
1368         Unreviewed, remove accidentally-committed URLHelpers.cpp test
1369
1370         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
1371         and bug #194272 for details.
1372
1373         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
1374
1375 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1376
1377         Remove some more unused 32-bit code
1378         https://bugs.webkit.org/show_bug.cgi?id=195255
1379
1380         Reviewed by Darin Adler.
1381
1382         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1383         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
1384         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1385         (NPP_New):
1386         (NPP_HandleEvent):
1387         (handleEventCarbon): Deleted.
1388
1389 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
1390
1391         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
1392
1393         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1394         (TestWebKitAPI::TEST):
1395
1396 2019-03-01  Darin Adler  <darin@apple.com>
1397
1398         Finish removing String::format
1399         https://bugs.webkit.org/show_bug.cgi?id=194893
1400
1401         Reviewed by Daniel Bates.
1402 '
1403         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
1404
1405 2019-03-01  Alex Christensen  <achristensen@webkit.org>
1406
1407         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
1408         https://bugs.webkit.org/show_bug.cgi?id=195229
1409         <rdar://problem/48520362>
1410
1411         Reviewed by Chris Dumez.
1412
1413         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1414         (TEST):
1415
1416 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
1417
1418         Add a system trace scope for event region building
1419         https://bugs.webkit.org/show_bug.cgi?id=195226
1420
1421         Reviewed by Jon Lee.
1422
1423         This trace scope measures the time spend converting element rects into Region objects,
1424         which can be large on some pages.
1425
1426         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
1427
1428         * Tracing/SystemTracePoints.plist:
1429
1430 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1431
1432         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
1433         https://bugs.webkit.org/show_bug.cgi?id=194612
1434
1435         Reviewed by Alex Christensen.
1436
1437         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1438         Just test the new string-processing function and don't touch the actual environment.
1439         (Test cases are all as before, but based on operator== instead of strcmp.)
1440
1441 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
1442
1443         [ews-app] Update primary keys for handling multiple Buildbot instances
1444         https://bugs.webkit.org/show_bug.cgi?id=195120
1445
1446         Reviewed by Stephanie Lewis.
1447
1448         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1449         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1450         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1451
1452         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1453         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1454         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1455         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1456         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1457         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1458
1459 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1460
1461         [WinCairo] Enable service worker
1462         https://bugs.webkit.org/show_bug.cgi?id=188318
1463
1464         Reviewed by Youenn Fablet.
1465
1466         * DumpRenderTree/DumpRenderTreePrefix.h:
1467         * TestWebKitAPI/PlatformWin.cmake:
1468         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1469         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1470         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1471
1472 2019-03-01  Justin Fan  <justin_fan@apple.com>
1473
1474         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1475         https://bugs.webkit.org/show_bug.cgi?id=195191
1476
1477         Rubber-stamped by Dean Jackson.
1478
1479         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1480
1481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1482
1483 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1484
1485         Unreviewed, fix lldb webkitpy tests
1486         https://bugs.webkit.org/show_bug.cgi?id=194375
1487
1488         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1489
1490         * lldb/lldb_webkit.py:
1491         (WTFStringImplProvider.is_8bit):
1492
1493 2019-02-28  David Quesada  <david_quesada@apple.com>
1494
1495         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1496         https://bugs.webkit.org/show_bug.cgi?id=195121
1497         rdar://problem/48450302
1498
1499         Reviewed by Alex Christensen.
1500
1501         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1502         configurations where the 'download' attribute is absent, blank, or populated
1503         with a filename, and where the anchor element is same-origin or cross-origin
1504         (meaning the 'download' attribute shouldn't be honored).
1505
1506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1507         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1508         (-[NavigationActionTestDelegate init]):
1509         (-[NavigationActionTestDelegate navigationAction]):
1510         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1511         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1512         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1513         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1514         (TEST):
1515
1516 2019-02-28  Antoine Quint  <graouts@apple.com>
1517
1518         Enable the Pointer Events runtime flag by default
1519         https://bugs.webkit.org/show_bug.cgi?id=195156
1520
1521         Reviewed by Dean Jackson.
1522
1523         * DumpRenderTree/mac/DumpRenderTree.mm:
1524         (enableExperimentalFeatures):
1525
1526 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1527
1528         Several PasteImage API tests are flaky
1529         https://bugs.webkit.org/show_bug.cgi?id=195160
1530
1531         Reviewed by Tim Horton.
1532
1533         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1534         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1535         listening for a "load" event after image load is already complete.
1536
1537         To address this, make these tests first register a "load" event handler, then run script to insert an image
1538         element into the document, and finally wait until the load event is observed before checking image size.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1541
1542 2019-02-28  Chris Dumez  <cdumez@apple.com>
1543
1544         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1545         https://bugs.webkit.org/show_bug.cgi?id=195107
1546
1547         Reviewed by Alex Christensen.
1548
1549         Give some time for the zoom level to get restored.
1550
1551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1552
1553 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1554
1555         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1556         https://bugs.webkit.org/show_bug.cgi?id=194958
1557
1558         Reviewed by Geoffrey Garen.
1559
1560         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1561         (TEST):
1562
1563 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1564
1565         [ews-app] Update method to save build to handle builder_display_name
1566         https://bugs.webkit.org/show_bug.cgi?id=195047
1567
1568         Reviewed by Dewei Zhu.
1569
1570         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1571         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1572
1573 2019-02-28  Justin Fan  <justin_fan@apple.com>
1574
1575         [Web GPU] Enable Web GPU only on 64-bit
1576         https://bugs.webkit.org/show_bug.cgi?id=195139
1577
1578         Because Metal is only supported on 64 bit apps.
1579
1580         Unreviewed build fix.
1581
1582         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1583
1584 2019-02-27  Youenn Fablet  <youenn@apple.com>
1585
1586         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1587         https://bugs.webkit.org/show_bug.cgi?id=194959
1588
1589         Reviewed by Chris Dumez.
1590
1591         Spin loop until getting the condition to remove flakiness.
1592
1593         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1594
1595 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1596
1597         [ews-build] Buildbot should include builder_display_name in the build events
1598         https://bugs.webkit.org/show_bug.cgi?id=195045
1599
1600         Reviewed by Dewei Zhu.
1601
1602         * BuildSlaveSupport/ews-build/events.py:
1603         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1604         buildername to builder_name to be consistent in naming style.
1605         (Events.buildFinished): Ditto.
1606
1607 2019-02-27  Chris Dumez  <cdumez@apple.com>
1608
1609         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1610         https://bugs.webkit.org/show_bug.cgi?id=194480
1611
1612         Reviewed by Brady Eidson.
1613
1614         Update existing API test to make it more likely to reproduce the issue.
1615
1616         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1617
1618 2019-02-27  Brady Eidson  <beidson@apple.com>
1619
1620         Universal links from Google search results pages don't open the app.
1621         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1622
1623         Reviewed by Geoffrey Garen.
1624
1625         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1626         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1627         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1628         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1629
1630 2019-02-27  Chris Dumez  <cdumez@apple.com>
1631
1632         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1633         https://bugs.webkit.org/show_bug.cgi?id=195102
1634
1635         Reviewed by Geoffrey Garen.
1636
1637         If the number of processes is not yet what we expect, wait a bit and check again to give
1638         processes some time to exit.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1641
1642 2019-02-27  Chris Dumez  <cdumez@apple.com>
1643
1644         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1645         https://bugs.webkit.org/show_bug.cgi?id=194545
1646
1647         Reviewed by Brady Eidson.
1648
1649         Make sure the test navigates forward and then back only once. Previously, navigating
1650         back would trigger a navigation again in a timer.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1653
1654 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1655
1656         High Sierra Debug JSC test queue should use faster hardware
1657         https://bugs.webkit.org/show_bug.cgi?id=194603
1658
1659         Rubber-stamped by Alexey Proskuryakov.
1660
1661         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1662
1663         * BuildSlaveSupport/build.webkit.org-config/config.json:
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1665         (BubbleQueueServer):
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1667         (WebKitBuildbot):
1668         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1669         * QueueStatusServer/config/queues.py:
1670         * Scripts/webkitpy/common/config/ews.json:
1671         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1672         (test_ews_name):
1673
1674 2019-02-27  John Wilander  <wilander@apple.com>
1675
1676         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1677         https://bugs.webkit.org/show_bug.cgi?id=195071
1678         <rdar://problem/48417690>
1679
1680         Reviewed by Alex Christensen and Brent Fulgham.
1681
1682         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1683         (TestWebKitAPI::createURL):
1684             Convenience function.
1685         (TestWebKitAPI::TEST):
1686             WebCore::AdClickAttribution now takes a URL when creating Source and
1687             Destination.
1688         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1689         (TestWebKitAPI::TEST):
1690             WebCore::AdClickAttribution now takes a URL when creating Source and
1691             Destination.
1692
1693 2019-02-27  Antoine Quint  <graouts@apple.com>
1694
1695         Support Pointer Events on macOS
1696         https://bugs.webkit.org/show_bug.cgi?id=195008
1697         <rdar://problem/47454419>
1698
1699         Reviewed by Dean Jackson.
1700
1701         * DumpRenderTree/mac/DumpRenderTree.mm:
1702         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1703         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1704
1705 2019-02-26  Mark Lam  <mark.lam@apple.com>
1706
1707         Remove remaining poisoning code.
1708         https://bugs.webkit.org/show_bug.cgi?id=194138
1709
1710         Reviewed by Saam Barati.
1711
1712         * TestWebKitAPI/CMakeLists.txt:
1713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1714         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1715         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1716         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1717         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1718         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1719         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1720
1721 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1722
1723         Move ephemeral local storage from WebProcess to UIProcess
1724         https://bugs.webkit.org/show_bug.cgi?id=195074
1725         <rdar://problem/47937975>
1726
1727         Reviewed by Geoff Garen.
1728
1729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1730
1731 2019-02-20  Jer Noble  <jer.noble@apple.com>
1732
1733         [Cocoa] Media elements will restart network buffering just before suspending
1734         https://bugs.webkit.org/show_bug.cgi?id=193691
1735
1736         Reviewed by Eric Carlson.
1737
1738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1740         (TEST):
1741
1742 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1743
1744         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1745         https://bugs.webkit.org/show_bug.cgi?id=191652
1746
1747         Reviewed by Alex Christensen.
1748
1749         Fix WinCairo MiniBrowser behavior of authentication dialog.
1750
1751         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1752         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1753
1754 2019-02-26  Youenn Fablet  <youenn@apple.com>
1755
1756         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1757         https://bugs.webkit.org/show_bug.cgi?id=195028
1758         <rdar://problem/48243733>
1759
1760         Reviewed by Eric Carlson.
1761
1762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1763
1764 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1765
1766         [WPE] Add API for webview background color configuration
1767         https://bugs.webkit.org/show_bug.cgi?id=192305
1768
1769         Reviewed by Michael Catanzaro.
1770
1771         * MiniBrowser/wpe/main.cpp:
1772         (main): Add a new option to configure the webview background
1773         color. Example: --bg-color=transparent.
1774         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1775         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1776         (beforeAll): Ditto.
1777
1778 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1779
1780         scalableNativeWebpageParameters() is not preserved on new page navigation.
1781         https://bugs.webkit.org/show_bug.cgi?id=194892
1782         <rdar://problem/47538280>
1783
1784         Reviewed by Wenson Hsieh.
1785         
1786         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1787
1788         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1789         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1790         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1791         (WTR::UIScriptController::allowsViewportShrinkToFit):
1792         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1793         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1794         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1796         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1797         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1798
1799 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1800
1801         [ews-app] Add model for handling multiple Buildbot instances
1802         https://bugs.webkit.org/show_bug.cgi?id=194863
1803
1804         Reviewed by Stephanie Lewis.
1805
1806         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1807
1808 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-app] Remove BuilderMapping table
1811         https://bugs.webkit.org/show_bug.cgi?id=194961
1812
1813         Reviewed by Stephanie Lewis.
1814
1815         Store builder name directly in build table, instead of having a separate
1816         table for it.
1817
1818         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1819         * BuildSlaveSupport/ews-app/ews/models/build.py:
1820         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1821         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1822
1823 2019-02-25  John Wilander  <wilander@apple.com>
1824
1825         Introduce and adopt new class RegistrableDomain for eTLD+1
1826         https://bugs.webkit.org/show_bug.cgi?id=194791
1827         <rdar://problem/48179240>
1828
1829         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1830
1831         This patch adds an API test and replaces two instances of
1832         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1833
1834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1835         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1836         (TestWebKitAPI::TEST):
1837             Changed two strings to make sure the registrable domains are still considered
1838             invalid and pass the test.
1839         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1840         (TestWebKitAPI::TEST):
1841         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1842         (WTR::InjectedBundle::didReceiveMessageToPage):
1843
1844 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1845
1846         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1847         https://bugs.webkit.org/show_bug.cgi?id=195001
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         API version 1.0 always includes the functionality previously guarded with
1852         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1853         unconditionally.
1854
1855         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1856         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1857         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1858         (WebViewTest::showInWindow): Ditto.
1859         (WebViewTest::hideView): Ditto.
1860         * wpe/backends/HeadlessViewBackend.cpp:
1861         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1862         * wpe/backends/ViewBackend.cpp:
1863         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1864         * wpe/backends/WindowViewBackend.cpp:
1865         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1866         WPE_BACKEND_CHECK_VERSION().
1867         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1868
1869 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1870
1871         [Flatpak] Add support for flatpak > 1.1.2
1872         https://bugs.webkit.org/show_bug.cgi?id=194088
1873
1874         Flatpak 1.2 is now out so we need to support that
1875         version now.
1876
1877         Reviewed by Michael Catanzaro.
1878
1879         * flatpak/flatpakutils.py:
1880         (check_flatpak):
1881         (FlatpakPackages.__init__):
1882         (FlatpakPackages.__detect_packages):
1883         (FlatpakPackages.__detect_packages.in):
1884         (FlatpakRepos.update):
1885
1886 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1887
1888         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1889         https://bugs.webkit.org/show_bug.cgi?id=194998
1890
1891         Reviewed by Carlos Garcia Campos.
1892
1893         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1894         to a Git checkout and using the latest commit containing various fixes
1895         and improvements.
1896
1897 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1898
1899         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1900         https://bugs.webkit.org/show_bug.cgi?id=194981
1901
1902         Reviewed by Žan Doberšek.
1903
1904         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1905         (TestWebKitAPI::TEST):
1906
1907 2019-02-23  Keith Miller  <keith_miller@apple.com>
1908
1909         Add new mac target numbers
1910         https://bugs.webkit.org/show_bug.cgi?id=194955
1911
1912         Reviewed by Tim Horton.
1913
1914         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1915         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1916         * MiniBrowser/Configurations/Base.xcconfig:
1917         * TestWebKitAPI/Configurations/Base.xcconfig:
1918         * WebKitTestRunner/Configurations/Base.xcconfig:
1919
1920 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1921
1922         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1923         https://bugs.webkit.org/show_bug.cgi?id=194846
1924
1925         Reviewed by Don Olmstead.
1926
1927         Added _search_paths() and _port_specific_expectations_files() for
1928         WinCairoPort.
1929
1930         * Scripts/webkitpy/port/win.py:
1931         (WinCairoPort.default_baseline_search_path):
1932         (WinCairoPort):
1933         (WinCairoPort._port_specific_expectations_files):
1934         (WinCairoPort._search_paths):
1935
1936 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1937
1938         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1939         https://bugs.webkit.org/show_bug.cgi?id=194963
1940
1941         Reviewed by Dean Jackson.
1942
1943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1944         Do a `contains` check instead of `equals`, because in debug builds we
1945         put the GraphicsLayer pointer in a prefix.
1946
1947 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1948
1949         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1950         https://bugs.webkit.org/show_bug.cgi?id=194873
1951         <rdar://problem/46701974>
1952
1953         Reviewed by Tim Horton.
1954
1955         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1956
1957         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1958         (WTR::UIScriptController::menuRect const):
1959         (WTR::UIScriptController::isShowingMenu const):
1960         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1961         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1962         (WTR::UIScriptController::menuRect const):
1963
1964         Add a function to query the bounds of the callout menu in content coordinates.
1965
1966         (WTR::UIScriptController::isShowingMenu const):
1967
1968         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1969
1970         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1971         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1972         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1973         (WTR::UIScriptController::rectForMenuAction const):
1974         (WTR::UIScriptController::menuRect const):
1975         (WTR::UIScriptController::isShowingMenu const):
1976         (WTR::findViewInHierarchyOfType): Deleted.
1977
1978 2019-02-22  Chris Dumez  <cdumez@apple.com>
1979
1980         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1981         https://bugs.webkit.org/show_bug.cgi?id=194954
1982         <rdar://problem/48127957>
1983
1984         Reviewed by Alex Christensen.
1985
1986         Add API test coverage.
1987
1988         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1989         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1990         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1991         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1992
1993 2019-02-22  Chris Dumez  <cdumez@apple.com>
1994
1995         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1996         https://bugs.webkit.org/show_bug.cgi?id=194924
1997         <rdar://problem/48216125>
1998
1999         Reviewed by Geoffrey Garen.
2000
2001         Add API test coverage.
2002
2003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2004
2005 2019-02-22  Chris Dumez  <cdumez@apple.com>
2006
2007         Unreviewed, disable API test added in r241928 on iOS.
2008
2009         The cache is not enabled on devices with less than 3GB of RAM.
2010
2011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2012
2013 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2014
2015         Hardcode Visual Viewports on everywhere except iOS WK1
2016         https://bugs.webkit.org/show_bug.cgi?id=194928
2017
2018         Reviewed by Zalan Bujtas.
2019
2020         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2021         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2022         set it to false. The setting has shipped for several years and there's no need to turn
2023         it off now.
2024
2025         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2026         Visual Viewports are not enabled.
2027         
2028         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2029         that only runs in WK2
2030
2031         * MiniBrowser/mac/SettingsController.h:
2032         * MiniBrowser/mac/SettingsController.m:
2033         (-[SettingsController init]):
2034         (-[SettingsController _populateMenu]):
2035         (-[SettingsController validateMenuItem:]):
2036         (-[SettingsController visualViewportEnabled]): Deleted.
2037         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2038         * MiniBrowser/mac/WK1BrowserWindowController.m:
2039         (-[WK1BrowserWindowController didChangeSettings]):
2040         * MiniBrowser/mac/WK2BrowserWindowController.m:
2041         (-[WK2BrowserWindowController didChangeSettings]):
2042
2043 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2044
2045         Discard cached processes when clearing website data store
2046         https://bugs.webkit.org/show_bug.cgi?id=194894
2047
2048         Reviewed by Chris Dumez.
2049
2050         Added a test case.
2051
2052         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2053         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2054
2055 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2056
2057         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2058         https://bugs.webkit.org/show_bug.cgi?id=194914
2059         <rdar://problem/47586889>
2060
2061         Reviewed by Geoffrey Garen.
2062
2063         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2064         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2065         (TEST):
2066         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2067
2068 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2069
2070         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2071         <https://webkit.org/b/194761>
2072
2073         Reviewed by Myles Maxfield.
2074
2075         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2076         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2077         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2078         to use ARC-compliant cast.
2079         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2080         ARC-compliant cast.
2081         (WTR::installFakeHelvetica): Log `error` to console if
2082         CTFontManagerRegisterFontsForURL() fails, but only on supported
2083         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2084         Call CFRelease() on `error` to fix the leak.  Update to use
2085         ARC-compliant cast.
2086         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2087         cast.
2088
2089 2019-02-21  Chris Dumez  <cdumez@apple.com>
2090
2091         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2092         https://bugs.webkit.org/show_bug.cgi?id=194481
2093
2094         Reviewed by Alex Christensen.
2095
2096         Give the processes a chance to shutdown and wait until we reached the expected number
2097         of processes.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2100
2101 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2102
2103         Fix the macOS build
2104
2105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2106
2107 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2108
2109         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2110
2111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2112         I am a backwards.
2113
2114 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2115
2116         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2117
2118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2119         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2120         We could force on UI-side compositing, but I feel like the test might be more
2121         valuable exercising the normal path on each platform (though the original
2122         bug was also UI-side specific). Though we can't validate that the overlay
2123         layer was installed successfully, there are layout tests that do that.
2124
2125 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2126
2127         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2128         https://bugs.webkit.org/show_bug.cgi?id=194845
2129         <rdar://problem/47944579>
2130
2131         Reviewed by Antti Koivisto.
2132
2133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2135
2136 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2137
2138         [LFC][Floats] Add support for placing formatting roots in-between floats.
2139         https://bugs.webkit.org/show_bug.cgi?id=194902
2140
2141         Reviewed by Antti Koivisto.
2142
2143         * LayoutReloaded/misc/LFC-passing-tests.txt:
2144
2145 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2146
2147         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2148         https://bugs.webkit.org/show_bug.cgi?id=194901
2149
2150         Unreviewed build fix.
2151
2152         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2153         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2154         WPEBackend-fdo-0.1 as library name.
2155
2156 2019-02-21  Rob Buis  <rbuis@igalia.com>
2157
2158         Update MIME type parser
2159         https://bugs.webkit.org/show_bug.cgi?id=180526
2160
2161         Reviewed by Darin Adler.
2162
2163         Add tests involving leading and trailing whitespace, non-token
2164         characters and quoted strings.
2165
2166         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2167         (TestWebKitAPI::TEST):
2168
2169 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2170
2171         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2172         https://bugs.webkit.org/show_bug.cgi?id=194884
2173
2174         Reviewed by Michael Catanzaro.
2175
2176         * PlatformWin.cmake:
2177
2178 2019-02-20  Chris Dumez  <cdumez@apple.com>
2179
2180         Add API test for <rdar://problem/47471222>
2181         https://bugs.webkit.org/show_bug.cgi?id=194847
2182
2183         Reviewed by Alex Christensen.
2184
2185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2186
2187 2019-02-20  Chris Dumez  <cdumez@apple.com>
2188
2189         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2190         https://bugs.webkit.org/show_bug.cgi?id=194872
2191         <rdar://problem/47924500>
2192
2193         Reviewed by Alex Christensen.
2194
2195         Add API test coverage.
2196
2197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2198
2199 2019-02-20  Jer Noble  <jer.noble@apple.com>
2200
2201         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2202         https://bugs.webkit.org/show_bug.cgi?id=191332
2203
2204         Reviewed by Dean Jackson.
2205
2206         * Scripts/git-is-in-range: Added.
2207
2208 2019-02-20  Andy Estes  <aestes@apple.com>
2209
2210         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2211         https://bugs.webkit.org/show_bug.cgi?id=194869
2212
2213         Rubber-stamped by Jer Noble.
2214
2215         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2216         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2217         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2218         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2220         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2221
2222 2019-02-20  Chris Dumez  <cdumez@apple.com>
2223
2224         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2225         https://bugs.webkit.org/show_bug.cgi?id=194857
2226         <rdar://problem/47759323>
2227
2228         Reviewed by Alex Christensen.
2229
2230         Add API test coverage.
2231
2232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2233
2234 2019-02-20  Chris Dumez  <cdumez@apple.com>
2235
2236         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2237         https://bugs.webkit.org/show_bug.cgi?id=194829
2238         <rdar://problem/47889906>
2239
2240         Reviewed by Alexey Proskuryakov.
2241
2242         Every time the TestOptions were changing we were creating both a new Web view and
2243         a new WKContext, which would start a new Network process. In most cases, we only
2244         need to contruct a new Web view and we do can keep reusing the same WKContext.
2245         This patch implements this optimization and thus avoids spinning a lot of new
2246         Network processes while running the layout tests.
2247
2248         * WebKitTestRunner/TestController.cpp:
2249         (WTR::TestController::generateContextConfiguration const):
2250         (WTR::TestController::generatePageConfiguration):
2251         (WTR::TestController::createWebViewWithOptions):
2252         (WTR::TestController::resetPreferencesToConsistentValues):
2253         (WTR::updateTestOptionsFromTestHeader):
2254         * WebKitTestRunner/TestController.h:
2255         * WebKitTestRunner/TestOptions.h:
2256         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2257         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2258         (WTR::TestOptions::hasSameInitializationOptions const):
2259         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2260         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2261         (WTR::TestController::platformAddTestOptions const):
2262
2263 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2264
2265         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2266         https://bugs.webkit.org/show_bug.cgi?id=167941
2267
2268         Reviewed by Carlos Garcia Campos.
2269
2270         * MiniBrowser/gtk/main.c:
2271         (filterSavedCallback): Added.
2272         (main): Support loading a JSON rule set file for content filtering.
2273         * MiniBrowser/wpe/main.cpp:
2274         (filterSavedCallback): Added.
2275         (main): Support loading a JSON rule set file for content filtering.
2276         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2277         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2278         (WTF::derefGPtr): Ditto.
2279         (testEmptyStore):
2280         (testSaveInvalidFilter):
2281         (testSaveLoadFilter):
2282         (testSavedFilterIdentifierMatch):
2283         (testRemoveFilter):
2284         (testSaveMultipleFilters):
2285         (testSaveFilterFromFile):
2286         (testFilterPersistence):
2287         (beforeAll):
2288         (afterAll):
2289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2290         (removeOldInjectedContentAndResetLists): Also reset content filters.
2291         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2292         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2293         the element affected by the style sheet.
2294         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2295         and returns it to be used by tests.
2296         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2297         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2298         (serverCallback): Add support for serving a CSS style sheet for testing.
2299         (beforeAll): Add call to testUserContentManagerContentFilter().
2300         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2301
2302 2019-02-19  Keith Rollin  <krollin@apple.com>
2303
2304         Add timing information to build output
2305         https://bugs.webkit.org/show_bug.cgi?id=194839
2306         <rdar://problem/48219609>
2307
2308         Reviewed by Alexey Proskuryakov.
2309
2310         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2311         emit each project's build time to its output. E.g.,
2312
2313             ** BUILD SUCCEEDED ** [0.132 sec]
2314
2315         * Scripts/webkitdirs.pm:
2316         (XcodeOptions):
2317
2318 2019-02-19  Truitt Savell  <tsavell@apple.com>
2319
2320         Unreviewed, rolling out r241784.
2321
2322         Broke all OpenSource builds.
2323
2324         Reverted changeset:
2325
2326         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
2327         instances view"
2328         https://bugs.webkit.org/show_bug.cgi?id=172848
2329         https://trac.webkit.org/changeset/241784
2330
2331 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2332
2333         [LFC][Floats] Remove redundant intersecting logic
2334         https://bugs.webkit.org/show_bug.cgi?id=194804
2335
2336         Reviewed by Antti Koivisto.
2337
2338         * LayoutReloaded/misc/LFC-passing-tests.txt:
2339
2340 2019-02-19  Dean Jackson  <dino@apple.com>
2341
2342         Clean-up output from generate-xcfilelists so it can be filtered
2343         https://bugs.webkit.org/show_bug.cgi?id=194795
2344
2345         Reviewed by Joseph Pecoraro (and Keith Rollin).
2346
2347         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
2348         make a slight tweak to filter-build-webkit so such lines are marked
2349         as plain.
2350
2351         * Scripts/filter-build-webkit:
2352         * Scripts/generate-xcfilelists:
2353
2354 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
2355
2356         pytest is not correctly auto-installed
2357         https://bugs.webkit.org/show_bug.cgi?id=194707
2358
2359         Reviewed by Carlos Garcia Campos.
2360
2361         * Scripts/webkitpy/thirdparty/__init__.py:
2362         (AutoinstallImportHook._install_pytest):
2363
2364 2019-02-18  Chris Dumez  <cdumez@apple.com>
2365
2366         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
2367         https://bugs.webkit.org/show_bug.cgi?id=194797
2368         <rdar://problem/48055151>
2369
2370         Reviewed by Geoffrey Garen.
2371
2372         Add API test coverage.
2373
2374         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2375
2376 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2377
2378         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
2379         https://bugs.webkit.org/show_bug.cgi?id=194670
2380         <rdar://problem/39066529>
2381
2382         Reviewed by Tim Horton.
2383
2384         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
2385         pasted in an editable area as attachment elements.
2386
2387         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2388         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2389         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
2390         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2391         (TestWebKitAPI::TEST):
2392         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2393         (WTR::InjectedBundlePage::InjectedBundlePage):
2394
2395 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2396
2397         Fix API test after r241728
2398        ​https://bugs.webkit.org/show_bug.cgi?id=194723
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2401         (TEST):
2402         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
2403
2404 2019-02-18  Daniel Bates  <dabates@apple.com>
2405
2406         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2407         https://bugs.webkit.org/show_bug.cgi?id=192824
2408         <rdar://problem/47100332>
2409
2410         Reviewed by Wenson Hsieh.
2411
2412         Fix a bug where the wrong usage code was used for F13 thru F24.
2413
2414         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2415         (keyCodeForDOMFunctionKey):
2416
2417 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
2418
2419         Bytecode cache should a have a boot-specific validation
2420         https://bugs.webkit.org/show_bug.cgi?id=194769
2421         <rdar://problem/48149509>
2422
2423         Reviewed by Keith Miller.
2424
2425         Add test for WTF::bootSessionUUIDString()
2426
2427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2428         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
2429         (TEST):
2430
2431 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2432
2433         Disable safe browsing in WKWebView and remove its WKPreferences API
2434         https://bugs.webkit.org/show_bug.cgi?id=194723
2435         <rdar://problem/48122993>
2436
2437         Reviewed by Geoffrey Garen.
2438
2439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2440         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2441         (TEST):
2442         (safeBrowsingView):
2443         Make tests use SPI instead of API.
2444
2445 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2446
2447         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2448         https://bugs.webkit.org/show_bug.cgi?id=194586
2449
2450         Reviewed by Ross Kirsling.
2451
2452         * DumpRenderTree/win/DumpRenderTree.cpp:
2453         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2454         * Scripts/webkitpy/port/driver.py:
2455         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2456
2457 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2458
2459         Unreviewed, rolling out r241620.
2460
2461         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2462         (Requested by ddkilzer on #webkit.)
2463
2464         Reverted changeset:
2465
2466         "[WTF] Add environment variable helpers"
2467         https://bugs.webkit.org/show_bug.cgi?id=192405
2468         https://trac.webkit.org/changeset/241620
2469
2470 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2471
2472         [LFC] RenderImage's default intrinsic size is 0.
2473         https://bugs.webkit.org/show_bug.cgi?id=194745
2474
2475         Reviewed by Antti Koivisto.
2476
2477         * LayoutReloaded/misc/LFC-passing-tests.txt:
2478
2479 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2480
2481         [LFC][BFC] Add support for block replaced intrinsic width.
2482         https://bugs.webkit.org/show_bug.cgi?id=194705
2483
2484         Reviewed by Simon Fraser.
2485
2486         * LayoutReloaded/misc/LFC-passing-tests.txt:
2487
2488 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2489
2490         [LFC] Apply min/max width constraints to preferred width computation
2491         https://bugs.webkit.org/show_bug.cgi?id=194739
2492
2493         Reviewed by Simon Fraser.
2494
2495         * LayoutReloaded/misc/LFC-passing-tests.txt:
2496
2497 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2498
2499         [WTF] Add environment variable helpers
2500         https://bugs.webkit.org/show_bug.cgi?id=192405
2501
2502         Reviewed by Michael Catanzaro.
2503
2504         * DumpRenderTree/mac/DumpRenderTree.mm:
2505         (libraryPathForDumpRenderTree):
2506         * DumpRenderTree/win/DumpRenderTree.cpp:
2507         (libraryPathForDumpRenderTree):
2508         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2509         (setUpIOSLayoutTestCommunication):
2510         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2511         (beforeAll):
2512         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2513         (main):
2514         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2515         (WebKitTestBus::run):
2516         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2517         (WTR::getOutputDir):
2518         (WTR::initializeFontConfigSetting):
2519         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2520         (WTR::InjectedBundle::platformInitialize):
2521         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2522         (WTR::topLevelPath):
2523         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2524         (WTR::topLevelPath):
2525         (WTR::getOutputDir):
2526         (WTR::activateFonts):
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::TestController::libraryPathForTesting):
2529         (WTR::TestController::generateContextConfiguration const):
2530         (WTR::TestController::generatePageConfiguration):
2531         (WTR::TestController::decideDestinationWithSuggestedFilename):
2532         (WTR::TestController::platformAdjustContext):
2533         * WebKitTestRunner/TestController.h:
2534         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2535         (WTR::TestController::cocoaPlatformInitialize):
2536         (WTR::TestController::platformAdjustContext):
2537         * WebKitTestRunner/gtk/main.cpp:
2538         (main):
2539         * WebKitTestRunner/mac/TestControllerMac.mm:
2540         (WTR::TestController::configureContentExtensionForTest):
2541         * WebKitTestRunner/wpe/main.cpp:
2542         (main):
2543         Utilize WTF::Environment where possible.
2544
2545 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2546
2547         [iOS] WKWebView callout bar is missing Change Writing Direction item
2548         https://bugs.webkit.org/show_bug.cgi?id=190015
2549         <rdar://problem/44810366>
2550
2551         Reviewed by Tim Horton.
2552
2553         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2554         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2555
2556         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2557         (TestWebKitAPI::TEST):
2558
2559 2019-02-15  Chris Dumez  <cdumez@apple.com>
2560
2561         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2562         https://bugs.webkit.org/show_bug.cgi?id=194717
2563         <rdar://problem/47884404>
2564
2565         Reviewed by Brady Eidson.
2566
2567         Add API test coverage.
2568
2569         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2570
2571 2019-02-15  Youenn Fablet  <youenn@apple.com>
2572
2573         Make navigator.mediaDevices SecureContext
2574         https://bugs.webkit.org/show_bug.cgi?id=194666
2575
2576         Reviewed by Eric Carlson.
2577
2578         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2579         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2580         (TEST_F):
2581
2582 2019-02-15  Brian Burg  <bburg@apple.com>
2583
2584         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2585         https://bugs.webkit.org/show_bug.cgi?id=194411
2586         <rdar://problem/47787614>
2587
2588         Reviewed by Joseph Pecoraro.
2589
2590         Remove unnecessary soft linking macro usage.
2591
2592         * DumpRenderTree/mac/TestRunnerMac.mm:
2593         (TestRunner::inspectorTestStubURL):
2594         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2595         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2596         (WTR::TestRunner::inspectorTestStubURL):
2597
2598 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2599
2600         Unreviewed, rolling out r241559 and r241566.
2601         https://bugs.webkit.org/show_bug.cgi?id=194710
2602
2603         Causes layout test crashes under GuardMalloc (Requested by
2604         ryanhaddad on #webkit).
2605
2606         Reverted changesets:
2607
2608         "[WTF] Add environment variable helpers"
2609         https://bugs.webkit.org/show_bug.cgi?id=192405
2610         https://trac.webkit.org/changeset/241559
2611
2612         "Unreviewed build fix for WinCairo Debug after r241559."
2613         https://trac.webkit.org/changeset/241566
2614
2615 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2616
2617         [LFC] Out-of-flow box is never a float box
2618         https://bugs.webkit.org/show_bug.cgi?id=194704
2619
2620         Reviewed by Antti Koivisto.
2621
2622         * LayoutReloaded/misc/LFC-passing-tests.txt:
2623
2624 2019-02-10  Darin Adler  <darin@apple.com>
2625
2626         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2627         https://bugs.webkit.org/show_bug.cgi?id=194487
2628
2629         Reviewed by Daniel Bates.
2630
2631         * DumpRenderTree/win/DumpRenderTree.cpp:
2632         (applicationId): Use makeString instead of String::format.
2633         (main): Ditto.
2634         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2635         (TestWebKitAPI::Util::createURLForResource): Ditto.
2636         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2637         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2638
2639         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2640         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2641         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2642         (WTR::createStringWithAttributes): Use appendLiteral.
2643         (WTR::AccessibilityUIElement::helpText const): Ditto.
2644         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2645         directly instead of using String::format.
2646         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2647         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2648
2649 2019-02-15  Truitt Savell  <tsavell@apple.com>
2650
2651         Unreviewed, rolling out r241564.
2652
2653         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2654
2655         Reverted changeset:
2656
2657         "[Mac] WebInspectorUI.framework does not need to be soft-
2658         linked anymore"
2659         https://bugs.webkit.org/show_bug.cgi?id=194411
2660         https://trac.webkit.org/changeset/241564
2661
2662 2019-02-15  Saam barati  <sbarati@apple.com>
2663
2664         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2665         https://bugs.webkit.org/show_bug.cgi?id=194036
2666
2667         Reviewed by Yusuke Suzuki.
2668
2669         * Scripts/run-jsc-stress-tests:
2670
2671 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2672
2673         Fix the build.
2674
2675         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2676         (WTR::UIScriptController::drawSquareInEditableImage):
2677         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2678         (TestWebKitAPI::drawSquareInEditableImage):
2679
2680 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2681
2682         Fix the build.
2683
2684         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2685         (WTR::UIScriptController::drawSquareInEditableImage):
2686         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2687         (TestWebKitAPI::drawSquareInEditableImage):
2688
2689 2019-02-14  Brian Burg  <bburg@apple.com>
2690
2691         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2692         https://bugs.webkit.org/show_bug.cgi?id=194411
2693         <rdar://problem/47787614>
2694
2695         Reviewed by Joseph Pecoraro.
2696
2697         Remove unnecessary soft linking macro usage.
2698
2699         * DumpRenderTree/mac/TestRunnerMac.mm:
2700         (TestRunner::inspectorTestStubURL):
2701         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2702         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2703         (WTR::TestRunner::inspectorTestStubURL):
2704
2705 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2706
2707         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2708         https://bugs.webkit.org/show_bug.cgi?id=194599
2709
2710         Reviewed by Lucas Forschler.
2711
2712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2713         (StatusBubble._build_bubble):
2714
2715 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2716
2717         [ews-app] Set Foreign Key in Django build model
2718         https://bugs.webkit.org/show_bug.cgi?id=194667
2719
2720         Reviewed by Lucas Forschler.
2721
2722         * BuildSlaveSupport/ews-app/ews/models/build.py:
2723         (Build):
2724
2725 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2726
2727         [WTF] Add environment variable helpers
2728         https://bugs.webkit.org/show_bug.cgi?id=192405
2729
2730         Reviewed by Michael Catanzaro.
2731
2732         * DumpRenderTree/mac/DumpRenderTree.mm:
2733         (libraryPathForDumpRenderTree):
2734         * DumpRenderTree/win/DumpRenderTree.cpp:
2735         (libraryPathForDumpRenderTree):
2736         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2737         (setUpIOSLayoutTestCommunication):
2738         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2739         (TestWebKitAPI::strip):
2740         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2741         (beforeAll):
2742         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2743         (main):
2744         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2745         (WebKitTestBus::run):
2746         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2747         (WTR::getOutputDir):
2748         (WTR::initializeFontConfigSetting):
2749         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2750         (WTR::InjectedBundle::platformInitialize):
2751         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2752         (WTR::topLevelPath):
2753         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2754         (WTR::topLevelPath):
2755         (WTR::getOutputDir):
2756         (WTR::activateFonts):
2757         * WebKitTestRunner/TestController.cpp:
2758         (WTR::TestController::libraryPathForTesting):
2759         (WTR::TestController::generateContextConfiguration const):
2760         (WTR::TestController::generatePageConfiguration):
2761         (WTR::TestController::decideDestinationWithSuggestedFilename):
2762         (WTR::TestController::platformAdjustContext):
2763         * WebKitTestRunner/TestController.h:
2764         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2765         (WTR::TestController::cocoaPlatformInitialize):
2766         (WTR::TestController::platformAdjustContext):
2767         * WebKitTestRunner/gtk/main.cpp:
2768         (main):
2769         * WebKitTestRunner/mac/TestControllerMac.mm:
2770         (WTR::TestController::configureContentExtensionForTest):
2771         * WebKitTestRunner/wpe/main.cpp:
2772         (main):
2773         Utilize WTF::Environment where possible.
2774
2775 2019-02-14  Chris Dumez  <cdumez@apple.com>
2776
2777         [PSON] Introduce a WebContent Process cache
2778         https://bugs.webkit.org/show_bug.cgi?id=194594
2779         <rdar://problem/46793397>
2780
2781         Reviewed by Geoff Garen.
2782
2783         Update API tests to turn on the WebContent Process cache.
2784
2785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2786
2787 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2788
2789         Unreviewed, build fix after r241480
2790
2791         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2792         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2793         (-[DragAndDropSimulator initWithWebView:]):
2794
2795 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2796
2797         AX: ARIA Reflection was disabled in error
2798         https://bugs.webkit.org/show_bug.cgi?id=194647
2799         <rdar://problem/48068336>
2800
2801         Reviewed by Ryosuke Niwa.
2802
2803         Remove test override now that this feature should be enabled by default.
2804
2805         * WebKitTestRunner/TestController.cpp:
2806         (WTR::TestController::resetPreferencesToConsistentValues):
2807
2808 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2809
2810         Unreviewed, rolling out r241486.
2811         https://bugs.webkit.org/show_bug.cgi?id=194655
2812
2813         causing API failures in builds (Requested by ShawnRoberts on
2814         #webkit).
2815
2816         Reverted changeset:
2817
2818         "[Cocoa] Media elements will restart network buffering just
2819         before suspending"
2820         https://bugs.webkit.org/show_bug.cgi?id=193691
2821         https://trac.webkit.org/changeset/241486
2822
2823 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2824
2825         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2826         https://bugs.webkit.org/show_bug.cgi?id=194622
2827
2828         Reviewed by Antti Koivisto.
2829
2830         * LayoutReloaded/misc/LFC-passing-tests.txt:
2831
2832 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2833
2834         [LFC] Shrink-to-fit-width should be constrained by min/max width
2835         https://bugs.webkit.org/show_bug.cgi?id=194653
2836
2837         Reviewed by Antti Koivisto.
2838
2839         * LayoutReloaded/misc/LFC-passing-tests.txt:
2840
2841 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2842
2843         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2844         https://bugs.webkit.org/show_bug.cgi?id=194641
2845
2846         Reviewed by Geoffrey Garen.
2847
2848         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2849         so that the test would fail without this fix.
2850
2851         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2852         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2853
2854 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2855
2856         [ews-app] Change log level for a log statement
2857
2858         Unreviewed minor fix.
2859
2860         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2861         (Patch.save_patch):
2862
2863 2019-02-13  Jer Noble  <jer.noble@apple.com>
2864
2865         [Cocoa] Media elements will restart network buffering just before suspending
2866         https://bugs.webkit.org/show_bug.cgi?id=193691
2867
2868         Reviewed by Eric Carlson.
2869
2870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2872         (TEST):
2873
2874 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2875
2876         [ews-app] Fetch builder id to name mapping
2877         https://bugs.webkit.org/show_bug.cgi?id=194355
2878
2879         Reviewed by Lucas Forschler.
2880
2881         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2882         (Buildbot.get_builder_id_to_name_mapping):
2883         (Buildbot._get_display_name_from_builder_name):
2884
2885 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2886
2887         Further restricting webarchive loads
2888         https://bugs.webkit.org/show_bug.cgi?id=194567
2889         <rdar://problem/47610130>
2890
2891         Reviewed by Youenn Fablet.
2892
2893         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2894         navigations on drop.
2895
2896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2897         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2898         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2899         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2900         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2901         (TestWebKitAPI::TEST):
2902         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2903         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2904         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2905         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2906         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2907         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2908         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2909
2910 2019-02-13  John Wilander  <wilander@apple.com>
2911
2912         Store Ad Click Attribution requests in the network process
2913         https://bugs.webkit.org/show_bug.cgi?id=194510
2914         <rdar://problem/47650118>
2915
2916         Reviewed by Alex Christensen and Daniel Bates.
2917
2918         This patch adds two TestRunner functions:
2919         - dumpAdClickAttribution()
2920         - clearAdClickAttribution()
2921
2922         They call into the network process to dump and clear Ad Click
2923         Attribution state, respectively.
2924
2925         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2926         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2927         (WTR::TestRunner::dumpAdClickAttribution):
2928         (WTR::TestRunner::clearAdClickAttribution):
2929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2930         * WebKitTestRunner/TestController.cpp:
2931         (WTR::TestController::resetStateToConsistentValues):
2932         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2933         (WTR::adClickAttributionStringResultCallback):
2934         (WTR::TestController::dumpAdClickAttribution):
2935         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2936         (WTR::adClickAttributionVoidCallback):
2937         (WTR::TestController::clearAdClickAttribution):
2938         * WebKitTestRunner/TestController.h:
2939         * WebKitTestRunner/TestInvocation.cpp:
2940         (WTR::TestInvocation::dumpResults):
2941         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2942         (WTR::TestInvocation::dumpAdClickAttribution):
2943         * WebKitTestRunner/TestInvocation.h:
2944
2945 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-app] Generate status-bubble
2948         https://bugs.webkit.org/show_bug.cgi?id=194572
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2953         (StatusBubble._build_bubble):
2954         (StatusBubble._should_show_bubble_for):
2955         (StatusBubble._build_bubbles_for_patch):
2956
2957 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2958
2959         [ews-app] Add status bubble html template
2960         https://bugs.webkit.org/show_bug.cgi?id=194571
2961
2962         Reviewed by Lucas Forschler.
2963
2964         * BuildSlaveSupport/ews-app/ews/templates: Added.
2965         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2966
2967 2019-02-12  Chris Dumez  <cdumez@apple.com>
2968
2969         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2970         https://bugs.webkit.org/show_bug.cgi?id=194568
2971         <rdar://problem/47944490>
2972
2973         Reviewed by Ryosuke Niwa.
2974
2975         Add API test coverage.
2976
2977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2978         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2979
2980 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2981
2982         webkitpy: Remove bug_dummy from parsed test expectations
2983         https://bugs.webkit.org/show_bug.cgi?id=194562
2984         <rdar://problem/47853999>
2985
2986         Reviewed by Lucas Forschler.
2987
2988         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2989         (TestExpectationParser):
2990         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2991         skipped tests.
2992         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2993
2994 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2995
2996         [ews-app] Add method to fetch patch
2997         https://bugs.webkit.org/show_bug.cgi?id=194518
2998
2999         Reviewed by Lucas Forschler.
3000
3001         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3002         (Patch.get_patch):
3003
3004 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3005
3006         [LFC] Expand tests coverage (60 new tests -> 860)
3007
3008         Unreviewed test gardening (run-singly, --child-processes=1).
3009
3010         * LayoutReloaded/misc/LFC-passing-tests.txt:
3011
3012 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3013
3014         Allow pages to trigger programmatic paste from script on iOS
3015         https://bugs.webkit.org/show_bug.cgi?id=194271
3016         <rdar://problem/47808810>
3017
3018         Reviewed by Tim Horton.
3019
3020         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3021
3022         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3023         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3024         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3025         (WTR::UIScriptController::rectForMenuAction const):
3026
3027         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3028         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3029         for when the menu is shown or hidden.
3030
3031         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3032         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3033         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3034         (WTR::UIScriptController::setDidShowMenuCallback):
3035         (WTR::UIScriptController::didShowMenuCallback const):
3036         (WTR::UIScriptController::setDidHideMenuCallback):
3037         (WTR::UIScriptController::didHideMenuCallback const):
3038         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3039         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3040         (WTR::UIScriptController::rectForMenuAction const):
3041         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3042         * WebKitTestRunner/TestController.cpp:
3043         (WTR::TestController::resetPreferencesToConsistentValues):
3044         (WTR::updateTestOptionsFromTestHeader):
3045         * WebKitTestRunner/TestOptions.h:
3046
3047         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3048         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3049
3050         (WTR::TestOptions::hasSameInitializationOptions const):
3051         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3052         (WTR::UIScriptController::calendarType const):
3053         (WTR::UIScriptController::platformUndoManager const):
3054         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3055         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3056         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3057         (-[TestRunnerWKWebView dealloc]):
3058         (-[TestRunnerWKWebView _didShowMenu]):
3059         (-[TestRunnerWKWebView _didHideMenu]):
3060
3061         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3062
3063         * WebKitTestRunner/ios/TestControllerIOS.mm:
3064         (WTR::handleMenuWillHideNotification):
3065         (WTR::handleMenuDidHideNotification):
3066         (WTR::TestController::platformInitialize):
3067         (WTR::TestController::platformDestroy):
3068         (WTR::TestController::platformResetStateToConsistentValues):
3069
3070         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
3071         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
3072
3073         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3074         (WTR::forEachViewInHierarchy):
3075         (WTR::findViewInHierarchyOfType):
3076
3077         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
3078         functions that dig through a given view's hierarchy in search of a view of a given class.
3079
3080         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3081         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3082         (WTR::UIScriptController::selectionCaretViewRect const):
3083         (WTR::UIScriptController::selectionRangeViewRects const):
3084         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3085         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3086
3087         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
3088
3089         (WTR::UIScriptController::rectForMenuAction const):
3090
3091         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
3092         callout bar) whose label matches the given string.
3093
3094         (WTR::UIScriptController::platformContentView const):
3095
3096         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
3097         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
3098         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
3099
3100         (WTR::UIScriptController::platformUndoManager const): Deleted.
3101         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3102         (WTR::UIScriptController::platformContentView const):
3103         (WTR::UIScriptController::platformUndoManager const): Deleted.
3104
3105 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3106
3107         webkitpy: No option to only show unexpected failures in results.html for iPad
3108         https://bugs.webkit.org/show_bug.cgi?id=194554
3109         <rdar://problem/47922442>
3110
3111         Rubber-stamped by Aakash Jain.
3112
3113         Just because a TestExpecations file does not exist for a specific platform does not mean that
3114         TestExpecations are not being used, given that platforms inherit test expectations.
3115
3116         * Scripts/webkitpy/port/base.py:
3117         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
3118         * Scripts/webkitpy/port/base_unittest.py:
3119         (PortTest.test_uses_test_expectations_file):
3120
3121 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3122
3123         Remove setDefersLoading infrastructure from WebKit2
3124         https://bugs.webkit.org/show_bug.cgi?id=194506
3125
3126         Reviewed by Brady Eidson.
3127
3128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3130         (WTR::TestRunner::setDefersLoading): Deleted.
3131         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3132
3133 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3134
3135         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
3136         https://bugs.webkit.org/show_bug.cgi?id=194522
3137         <rdar://problem/47789393>
3138
3139         Reviewed by Chris Dumez.
3140
3141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3142         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
3143         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3145
3146 2019-02-12  Andy Estes  <aestes@apple.com>
3147
3148         [iOSMac] Enable Parental Controls Content Filtering
3149         https://bugs.webkit.org/show_bug.cgi?id=194521
3150         <rdar://39732376>
3151
3152         Reviewed by Tim Horton.
3153
3154         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3155
3156 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3157
3158         [LFC][IFC] Add intrinsic width support for float boxes.
3159         https://bugs.webkit.org/show_bug.cgi?id=194528
3160
3161         Reviewed by Antti Koivisto.
3162
3163         Expand tests coverage (2 new tests -> 800).
3164         (This is the correct test ordering --runs-singly --child-processes=1)
3165
3166         * LayoutReloaded/misc/LFC-passing-tests.txt:
3167
3168 2019-02-12  Rob Buis  <rbuis@igalia.com>
3169
3170         Implement serializing in MIME type parser
3171         https://bugs.webkit.org/show_bug.cgi?id=193909
3172
3173         Reviewed by Darin Adler.
3174
3175         Add various tests involving upper case, non-ASCII, control/null characters,
3176         various HTTP whitespace, single quotes and an unpaired surrogate.
3177
3178         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3179         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
3180         (TestWebKitAPI::serializeIfValid):
3181         (TestWebKitAPI::TEST):
3182
3183 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
3184
3185         [Cocoa] Ask platform for generic font family mappings
3186         https://bugs.webkit.org/show_bug.cgi?id=187723
3187         <rdar://problem/41892438>
3188
3189         Reviewed by Brent Fulgham.
3190
3191         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3192
3193         * DumpRenderTree/mac/DumpRenderTree.mm:
3194         (allowedFontFamilySet):
3195         * WebKitTestRunner/mac/TestControllerMac.mm:
3196         (WTR::allowedFontFamilySet):
3197
3198 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
3199
3200         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
3201         https://bugs.webkit.org/show_bug.cgi?id=193622
3202
3203         Reviewed by Michael Catanzaro.
3204
3205         This adds support for loading content extension rule sets from the JSON files which
3206         accompany the corresponding layout test, using the C API. The Cocoa specific parts
3207         of WKTR for this could be removed, but that is left for a follow-up patch with
3208         cleanups.
3209
3210         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
3211         * WebKitTestRunner/TestController.cpp:
3212         (WTR::testPath): Subtract one from the length when constructing the result std::string to
3213         avoid having the null-terminator copied into the result.
3214         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
3215         part of the preparations to run a test.
3216         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
3217         (WTR::contentExtensionStoreCallback): Added.
3218         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
3219         used for content extensions test.
3220         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
3221         extensions and compiling the JSON rule set for tests involving content extensions.
3222         (WTR::TestController::resetContentExtensions): Removes the content extension built for
3223         testing and disables content extensions.
3224         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
3225         resetContentExtensions().
3226         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
3227         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
3228         configureContentExtensionForTest(), and userContentController().
3229
3230 2019-02-11  Daniel Bates  <dabates@apple.com>
3231
3232         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3233         https://bugs.webkit.org/show_bug.cgi?id=191446
3234         <rdar://problem/45929460>
3235
3236         Reviewed by Tim Horton.
3237
3238         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3239
3240         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3241         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3242         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3244         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3245         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3246         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3247         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3248         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3249         (WTR::arrayLength):
3250         (WTR::parseModifierArray):
3251         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3252         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3253         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3254         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3255
3256 2019-02-11  Commit Queue  <commit-queue@webkit.org>
3257
3258         Unreviewed, rolling out r241272 and r241276.
3259         https://bugs.webkit.org/show_bug.cgi?id=194514
3260
3261         Broke the Apple Internal build and the fix requires human
3262         intervention :( (Requested by dydz on #webkit).
3263
3264         Reverted changesets:
3265
3266         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
3267         https://bugs.webkit.org/show_bug.cgi?id=191446
3268         https://trac.webkit.org/changeset/241272
3269
3270         "Fix internal iOS build after r241272"
3271         https://bugs.webkit.org/show_bug.cgi?id=191446
3272         https://trac.webkit.org/changeset/241276
3273
3274 2019-02-11  Truitt Savell  <tsavell@apple.com>
3275
3276         Unreviewed, rolling out r241269.
3277
3278         Caused 5 layout tests crashes on Mac WK1
3279
3280         Reverted changeset:
3281
3282         "DumpRenderTree should report unknown options"
3283         https://bugs.webkit.org/show_bug.cgi?id=191303
3284         https://trac.webkit.org/changeset/241269
3285
3286 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3287
3288         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
3289         https://bugs.webkit.org/show_bug.cgi?id=194313
3290
3291         Reviewed by Tim Horton.
3292
3293         Add a helper to determine whether the web view is presenting modal UI.
3294
3295         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3296         (WTR::UIScriptController::isPresentingModally const):
3297         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3298         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3299         (WTR::UIScriptController::isPresentingModally const):
3300         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3301         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3302         (WTR::UIScriptController::calendarType const): Deleted.
3303         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3304         (WTR::UIScriptController::isPresentingModally const):
3305         (WTR::UIScriptController::calendarType const):
3306         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3307         (WTR::UIScriptController::calendarType const):
3308
3309 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
3310
3311         GCHeapInspector: Show the retained sizes in more places
3312         https://bugs.webkit.org/show_bug.cgi?id=194464
3313
3314         Reviewed by Simon Fraser.
3315
3316         * GCHeapInspector/gc-heap-inspector.html:
3317         * GCHeapInspector/script/interface.js:
3318         (HeapInspectorUtils.humanReadableSize):
3319         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
3320         (HeapInspectorUtils.spanForNode.span.span):
3321         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
3322         (HeapSnapshotInspector.prototype.buildRoots):
3323
3324 2019-02-11  Daniel Bates  <dabates@apple.com>
3325
3326         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3327         https://bugs.webkit.org/show_bug.cgi?id=191446
3328         <rdar://problem/45929460>
3329
3330         Reviewed by Tim Horton.
3331
3332         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3333
3334         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3335         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3336         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3337         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3338         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3339         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3340         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3341         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3342         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3343         (WTR::arrayLength):
3344         (WTR::parseModifierArray):
3345         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3346         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3347         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3348         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3349
3350 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
3351
3352         DumpRenderTree should report unknown options
3353         https://bugs.webkit.org/show_bug.cgi?id=191303
3354
3355         Reviewed by Frédéric Wang.
3356
3357         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
3358         to report unknown options.
3359         Added and assigned test options which are currently used in tests.
3360
3361         * DumpRenderTree/TestOptions.cpp:
3362         (TestOptions::TestOptions):
3363
3364 2019-02-11  Truitt Savell  <tsavell@apple.com>
3365
3366         Unreviewed, rolling out r241229.
3367
3368         Revision broke internal builds for watchOS.
3369
3370         Reverted changeset:
3371
3372         "[Cocoa] Ask platform for generic font family mappings"
3373         https://bugs.webkit.org/show_bug.cgi?id=187723
3374         https://trac.webkit.org/changeset/241229
3375
3376 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
3377
3378         [WinCairo][MiniBrowser] Basic authentication always fails.
3379         https://bugs.webkit.org/show_bug.cgi?id=194496
3380
3381         Reviewed by Don Olmstead.
3382
3383         * MiniBrowser/win/DialogHelper.h:
3384         (Dialog::getText):
3385
3386 2019-02-11  Philippe Normand  <pnormand@igalia.com>
3387
3388         [GStreamer] GstMappedBuffer testsuite build fails
3389         https://bugs.webkit.org/show_bug.cgi?id=194495
3390
3391         Reviewed by Carlos Garcia Campos.
3392
3393         Fix the build by explicitely adding the gstreamer1.0-audio include
3394         directories to the include path.
3395
3396         * TestWebKitAPI/PlatformGTK.cmake:
3397         * TestWebKitAPI/PlatformWPE.cmake:
3398
3399 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         [GTK][WPE] Add enable-javascript-markup setting
3402         https://bugs.webkit.org/show_bug.cgi?id=193439
3403
3404         Reviewed by Michael Catanzaro.
3405
3406         Add test cases to check the new setting.
3407
3408         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3409         (testWebKitSettings):
3410         (testWebKitSettingsJavaScriptMarkup):
3411         (beforeAll):
3412
3413 2019-02-10  Darin Adler  <darin@apple.com>
3414
3415         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
3416         https://bugs.webkit.org/show_bug.cgi?id=194485
3417
3418         Reviewed by Daniel Bates.
3419
3420         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
3421
3422 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3423
3424         Add more tests for clampTo<>()
3425         https://bugs.webkit.org/show_bug.cgi?id=194462
3426
3427         Reviewed by Geoffrey Garen.
3428
3429         Darin suggested to test the very last floating point number
3430         at the boundaries when truncating to integer.
3431         I added test for max/min and max-1/min-1.
3432
3433         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3434         (TestWebKitAPI::TEST):
3435
3436 2019-02-09  Darin Adler  <darin@apple.com>
3437
3438         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
3439         https://bugs.webkit.org/show_bug.cgi?id=194021
3440
3441         Reviewed by Geoffrey Garen.
3442
3443         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3444         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3445         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3446
3447 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3448
3449         [LFC][IFC] Add intrinsic width support for basic inline containers
3450         https://bugs.webkit.org/show_bug.cgi?id=194473
3451
3452         Reviewed by Antti Koivisto.
3453
3454         Expand tests coverage (11 new tests -> 798)
3455
3456         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3457
3458 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3459
3460         Fix MiniBrowser's entitlements
3461         https://bugs.webkit.org/show_bug.cgi?id=192431
3462
3463         Reviewed by Joseph Pecoraro.
3464
3465         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3466         files, making it impossible to load any extension.
3467
3468         * MiniBrowser/MiniBrowser.entitlements:
3469
3470 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3471
3472         [Cocoa] Ask platform for generic font family mappings
3473         https://bugs.webkit.org/show_bug.cgi?id=187723
3474         <rdar://problem/41892438>
3475
3476         Reviewed by Brent Fulgham.
3477
3478         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3479
3480         * DumpRenderTree/mac/DumpRenderTree.mm:
3481         (allowedFontFamilySet):
3482         * WebKitTestRunner/mac/TestControllerMac.mm:
3483         (WTR::allowedFontFamilySet):
3484
3485 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3486
3487         [GTK] Implement back/forward touchpad gesture
3488         https://bugs.webkit.org/show_bug.cgi?id=193919
3489
3490         Reviewed by Michael Catanzaro.
3491
3492         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3493         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3494
3495 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3496
3497         Add SPI to use networking daemon instead of XPC service
3498         https://bugs.webkit.org/show_bug.cgi?id=194427
3499
3500         Reviewed by Geoffrey Garen
3501
3502         * MiniBrowser/MiniBrowser.entitlements:
3503
3504 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3505
3506         [ews-build] Ensure that every builder in config.json has short name
3507         https://bugs.webkit.org/show_bug.cgi?id=194461
3508
3509         Reviewed by Lucas Forschler.
3510
3511         * BuildSlaveSupport/ews-build/loadConfig.py:
3512         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3513
3514 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3515
3516         [ews-build] Add short name to config.json
3517         https://bugs.webkit.org/show_bug.cgi?id=194456
3518
3519         Reviewed by Lucas Forschler.
3520
3521         * BuildSlaveSupport/ews-build/config.json: Added short name.
3522         * BuildSlaveSupport/ews-build/loadConfig.py:
3523         (loadBuilderConfig): Set the short name as the builder description.
3524
3525 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3526
3527         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3528         https://bugs.webkit.org/show_bug.cgi?id=194418
3529
3530         Reviewed by Lucas Forschler.
3531
3532         Do not include errors trying when finding crashlogs at the end of
3533         a run-webkit-tests run since we don't process those errors.
3534
3535         * Scripts/webkitpy/port/darwin.py:
3536         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3537         * Scripts/webkitpy/port/ios_device.py:
3538         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3539         * Scripts/webkitpy/port/watch_device.py:
3540         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3541
3542 2019-02-08  Beth Dakin  <bdakin@apple.com>
3543
3544         Add afterScreenUpdates to WKSnapshotConfiguration
3545         https://bugs.webkit.org/show_bug.cgi?id=194362
3546         -and corresponding-
3547         <rdar://problem/40655528> Please add an "after screen updates" property to 
3548         WKSnapshotConfiguration (to solve blank snapshots)
3549
3550         Reviewed by Tim Horton.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3553         (TEST):
3554
3555 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3556
3557         clampTo(): do not convert the input to double when dealing with integers
3558         https://bugs.webkit.org/show_bug.cgi?id=194263
3559         <rdar://problem/47692312>
3560
3561         Reviewed by Darin Adler.
3562
3563         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3564         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3565         (TestWebKitAPI::testClampFloatingPointToInteger):
3566         (TestWebKitAPI::testClampSameSignIntegers):
3567         (TestWebKitAPI::testClampUnsignedToSigned):
3568         (TestWebKitAPI::testClampSignedToUnsigned):
3569
3570 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3571
3572         webkitpy: Respect --dedicated-simulators flag
3573         https://bugs.webkit.org/show_bug.cgi?id=194416
3574         <rdar://problem/47894722>
3575
3576         Reviewed by Lucas Forschler.
3577
3578         * Scripts/webkitpy/port/device_port.py:
3579         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3580         available devices can be safely ignored.
3581
3582 2019-02-07  Keith Rollin  <krollin@apple.com>
3583
3584         Remove extra copy of 100x100-red.tga
3585         https://bugs.webkit.org/show_bug.cgi?id=194371
3586         <rdar://problem/47873465>
3587
3588         Reviewed by Said Abou-Hallawa.
3589
3590         In order to help it pass its tests, Bug 194190 added a second copy of
3591         the file 100x100-red.tga. However, it turns out that this additional
3592         file wasn't actually needed, and that that sole previous copy was
3593         sufficient. At the same time, this second copy -- which was copied to
3594         the same location in the build output as the first copy -- now caused
3595         XCBuild to complain because there were two production rules for the
3596         same output file. Address this by removing the newly-added extra copy.
3597
3598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3599         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3600
3601 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3602
3603         Deprecate WKBundlePageSetDefersLoading
3604         https://bugs.webkit.org/show_bug.cgi?id=191394
3605
3606         Reviewed by Dean Jackson.
3607
3608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3609         (WTR::TestRunner::setDefersLoading):
3610
3611 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3612
3613         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3614         https://bugs.webkit.org/show_bug.cgi?id=194391
3615
3616         Reviewed by Antti Koivisto.
3617
3618         * LayoutReloaded/misc/LFC-passing-tests.txt:
3619
3620 2019-02-06  Keith Rollin  <krollin@apple.com>
3621
3622         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3623         https://bugs.webkit.org/show_bug.cgi?id=193975
3624         <rdar://problem/47643306>
3625
3626         Reviewed by Tim Horton.
3627
3628         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3629         the Info.plist file into the bundle. This step is not necessary as the
3630         implicit "bundle up all the build products into a framework" build
3631         phase does this already. Having the Copy Bundle Resources phase do
3632         this causes a conflict under XCBuild, which objects to two build
3633         phases producing the same file (Info.plist). Address this by removing
3634         Info.plist from the Copy Bundle Resources phase.
3635
3636         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3637
3638 2019-02-06  Keith Rollin  <krollin@apple.com>
3639
3640         Really enable the automatic checking and regenerations of .xcfilelists during builds
3641         https://bugs.webkit.org/show_bug.cgi?id=194357
3642         <rdar://problem/47861231>
3643
3644         Reviewed by Chris Dumez.
3645
3646         Bug 194124 was supposed to enable the automatic checking and
3647         regenerating of .xcfilelist files during the build. While related
3648         changes were included in that patch, the change to actually enable the
3649         operation somehow was omitted. This patch actually enables the
3650         operation. The check-xcfilelist.sh scripts now check
3651         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3652         from the checking.
3653
3654         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3655         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3656
3657 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3658
3659         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3660         <https://webkit.org/b/194286>
3661         <rdar://problem/47815558>
3662
3663         Reviewed by Alexey Proskuryakov.
3664
3665         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3666         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3667         WKRetainPtr<> to avoid leaking the WKDataRef.
3668
3669 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3670
3671         Unreviewed, fix a typo
3672
3673         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3674
3675 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3676
3677         [GTK][WPE] force libpsl build to use ICU in jhbuild
3678         https://bugs.webkit.org/show_bug.cgi?id=194288
3679
3680         Reviewed by Carlos Garcia Campos.
3681
3682         * gtk/jhbuild.modules:
3683         Require ICU for libpsl build in jhbuild, like done in WPE.
3684
3685 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3686
3687         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3688         https://bugs.webkit.org/show_bug.cgi?id=194209
3689
3690         Reviewed by Carlos Garcia Campos.
3691
3692         Enhance TestCookieManager to ensure this doesn't happen again.
3693
3694         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3695         (testCookieManagerPersistentStorage):
3696         (beforeAll):
3697
3698 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3699
3700         Renam