Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
2
3         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
4         https://bugs.webkit.org/show_bug.cgi?id=209151
5
6         Reviewed by Yusuke Suzuki.
7
8         * Scripts/webkitpy/common/config/contributors.json:
9
10 2020-03-16  Chris Dumez  <cdumez@apple.com>
11
12         Crash under WebCookieCache::clearForHost()
13         https://bugs.webkit.org/show_bug.cgi?id=209149
14         <rdar://problem/60453086>
15
16         Reviewed by Alex Christensen.
17
18         Add API test coverage.
19
20         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
21         (TEST):
22
23 2020-03-16  Keith Rollin  <krollin@apple.com>
24
25         Remove support for WebKitSystemInterface
26         https://bugs.webkit.org/show_bug.cgi?id=208894
27         <rdar://problem/60297590>
28
29         Reviewed by Brent Fulgham.
30
31         This project provided support for facilities that are now handled
32         elsewhere and is no longer needed.
33
34         * Scripts/copy-webkitlibraries-to-product-directory:
35
36 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
37
38         [macOS] Accessibility sandbox regressions
39         https://bugs.webkit.org/show_bug.cgi?id=209065
40
41         Reviewed by Brent Fulgham.
42
43         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
44         (TEST):
45         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
46         (TEST):
47
48 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
49
50         Unreviewed infrastructure fix.
51
52         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
53         while the hardware is out for repair.
54
55 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
56
57         [WebXR] IDLs, stubs and build configuration for WPE
58         https://bugs.webkit.org/show_bug.cgi?id=208702
59
60         Reviewed by Dean Jackson.
61
62         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
63         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
64
65 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
66
67         [Cocoa] Limit set of classes that can be decoded when a preference has changed
68         https://bugs.webkit.org/show_bug.cgi?id=208012
69
70         Reviewed by Brent Fulgham.
71
72         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
73         (TEST):
74
75 2020-03-16  youenn fablet  <youenn@apple.com>
76
77         Unique origins should not be Potentially Trustworthy
78         https://bugs.webkit.org/show_bug.cgi?id=209049
79
80         Reviewed by Darin Adler.
81
82         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
83         (TestWebKitAPI::TEST_F):
84
85 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
86
87         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
88         https://bugs.webkit.org/show_bug.cgi?id=207324
89
90         Reviewed by Darin Adler.
91
92         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
93         (TestWebKitAPI::generateRandomData): Added.
94         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
95
96 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
97
98         Should not use variable-length-array (VLA)
99         https://bugs.webkit.org/show_bug.cgi?id=209043
100
101         Reviewed by Mark Lam.
102
103         * ContentExtensionTester/Configurations/Base.xcconfig:
104         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
105
106 2020-03-13  Alex Christensen  <achristensen@webkit.org>
107
108         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
109         https://bugs.webkit.org/show_bug.cgi?id=209011
110         <rdar://problem/59370588>
111
112         Reviewed by Youenn Fablet.
113
114         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
115         (TestWebKitAPI::TEST):
116
117 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
120         https://bugs.webkit.org/show_bug.cgi?id=209089
121
122         Reviewed by Tim Horton.
123
124         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
125         marketing name for the feature.
126
127         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
128         (runUntilReceivesAutoplayEvent):
129
130         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
131         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
132         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
133         be any compelling reason to compare against different types here (especially since we only set
134         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
135         these all to be `_WKAutoplayEvent`.
136
137         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
138         (-[AutoFillTestView _autofillInputView]):
139         (-[AutoFillTestView textInputHasAutoFillContext]):
140         (TestWebKitAPI::TEST):
141         (-[AutofillTestView initWithFrame:]): Deleted.
142         (-[AutofillTestView _autofillInputView]): Deleted.
143         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
144         * TestWebKitAPI/ios/UIKitSPI.h:
145
146 2020-03-13  Chris Dumez  <cdumez@apple.com>
147
148         Unreviewed, reverting r256232.
149
150         Caused ResizeObserver tests to become flaky
151
152         Reverted changeset:
153
154         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
155         override TestOptions"
156         https://bugs.webkit.org/show_bug.cgi?id=207481
157         https://trac.webkit.org/changeset/256232
158
159 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
160
161         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
162         https://bugs.webkit.org/show_bug.cgi?id=209016
163         <rdar://problem/60329530> 
164
165         Reviewed by Chris Dumez.
166
167         Re-initialize the app-bound domains when the correct
168         TestOptions parameter is set.
169
170         * WebKitTestRunner/TestController.cpp:
171         (WTR::TestController::createWebViewWithOptions):
172         (WTR::TestController::reinitializeAppBoundDomains):
173         * WebKitTestRunner/TestController.h:
174
175 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
176
177         Report all third party loads on a per-page basis
178         https://bugs.webkit.org/show_bug.cgi?id=209032
179         <rdar://problem/60397323>
180
181         Reviewed by Chris Dumez.
182
183         Mostly naming updates to reflect the change in use for this SPI call.
184         It now returns all loaded third party domains, not just prevalent ones.
185
186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
187         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
188         (WTR::InjectedBundle::didReceiveMessageToPage):
189         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
190         (WTR::TestRunner::getLoadedThirdPartyDomains):
191         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
192         (WTR::TestRunner::getPrevalentDomains): Deleted.
193         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
194         * WebKitTestRunner/InjectedBundle/TestRunner.h:
195         * WebKitTestRunner/TestController.cpp:
196         (WTR::TestController::resetStateToConsistentValues):
197         (WTR::TestController::getLoadedThirdPartyDomains):
198         (WTR::TestController::clearLoadedThirdPartyDomains):
199         (WTR::TestController::getPrevalentDomains): Deleted.
200         (WTR::TestController::clearPrevalentDomains): Deleted.
201         * WebKitTestRunner/TestController.h:
202         * WebKitTestRunner/TestInvocation.cpp:
203         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
204         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
205         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
206         * WebKitTestRunner/TestInvocation.h:
207         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
208         (WTR::TestController::getLoadedThirdPartyDomains):
209         (WTR::TestController::clearLoadedThirdPartyDomains):
210         (WTR::TestController::getPrevalentDomains): Deleted.
211         (WTR::TestController::clearPrevalentDomains): Deleted.
212
213 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
214
215         [ews] run FindModifiedChangeLogs early in the build
216         https://bugs.webkit.org/show_bug.cgi?id=209060
217
218         Reviewed by Jonathan Bedard.
219
220         * BuildSlaveSupport/ews-build/factories.py:
221         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
222
223 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
224
225         [GTK] Add EWS testers to run GTK layout tests
226         https://bugs.webkit.org/show_bug.cgi?id=207648
227
228         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
229
230         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
231         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
232         tests (layout tests).
233
234         * BuildSlaveSupport/ews-build/config.json: Added new queue for
235         WK2 tests.
236         * BuildSlaveSupport/ews-build/factories.py:
237         (GTKTestsFactory):
238         * BuildSlaveSupport/ews-build/factories_unittest.py:
239         (TestCommitQueueFactory.test_commit_queue_factory):
240         (TestGTKFactory): Added unit-test.
241         (TestGTKFactory.test_gtk_factory):
242         * BuildSlaveSupport/ews-build/loadConfig.py:
243         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
244         (TagsForBuilderTest.test_getTagsForBuilder):
245
246 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
247
248         Add API endpoint in EWS django app to provide patch status in json format
249         https://bugs.webkit.org/show_bug.cgi?id=208940
250
251         Reviewed by Jonathan Bedard.
252
253         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
254         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
255
256 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
257
258         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
259         https://bugs.webkit.org/show_bug.cgi?id=209055
260         <rdar://problem/60272692>
261
262         Reviewed by Simon Fraser.
263
264         Now that WebKitTestRunner has a bundleID, its' user default values
265         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
266         to NO before running tests. It will be set to YES in PlatformWebView
267         if specified by the test.
268
269         * WebKitTestRunner/mac/main.mm:
270         (setDefaultsToConsistentValuesForTesting):
271
272 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
273
274         [CMake] Eleminate mismatches between Find* module names and variables they set
275         https://bugs.webkit.org/show_bug.cgi?id=208948
276
277         Reviewed by Michael Catanzaro.
278
279         * wpe/backends/CMakeLists.txt:
280
281 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
282
283         [ews-app] reduce logging
284         https://bugs.webkit.org/show_bug.cgi?id=209062
285
286         Reviewed by Jonathan Bedard.
287
288         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
289         (BugzillaBeautifulSoup.authenticate):
290         (BugzillaBeautifulSoup._load_query):
291
292 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
293
294         Crash in TextIterator::node via TextManipulationController::replace
295         https://bugs.webkit.org/show_bug.cgi?id=209048
296
297         Reviewed by Wenson Hsieh.
298
299         Added a regression test.
300
301         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
302         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
303
304 2020-03-13  Saam Barati  <sbarati@apple.com>
305
306         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
307         https://bugs.webkit.org/show_bug.cgi?id=209038
308
309         Reviewed by Keith Miller.
310
311         This allows us to automatically pull in some tests that are in non open sourced Apple
312         checkouts.
313
314         * Scripts/run-javascriptcore-tests:
315         (runJSCStressTests):
316
317 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
318
319         Crash in TextManipulationController::replace
320         https://bugs.webkit.org/show_bug.cgi?id=209021
321
322         Reviewed by Wenson Hsieh.
323
324         Added a regression test.
325
326         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
327         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
328
329 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
330
331         [macOS] _AXSApplicationAccessibilityEnabled should not be called
332         https://bugs.webkit.org/show_bug.cgi?id=208953
333
334         Reviewed by Brent Fulgham.
335
336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
337
338 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
339
340         Resource load statistics data summary should return all third party data
341         https://bugs.webkit.org/show_bug.cgi?id=209000
342         <rdar://problem/60348306>
343
344         Reviewed by John Wilander.
345
346         Marked only 2 of 3 domains prevalent in data summary tests to ensure
347         the call returns all third parties, not just prevalent ones.
348         Added a more aggressive check for the size of the array at the
349         beginning of the test to ensure the array is still returning 3 values. 
350         Also removed the ASSERT statements as they seem to cause timeouts (not
351         clear crashes) when they are not true, which is hard to debug.
352         If these values are nil, the test will fail in the EXPECT_WK_STREQ
353         checks, we don't need ASSERT statements.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
356         (TEST):
357
358 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
359
360         resultsdpy: Add script to run local instance
361         https://bugs.webkit.org/show_bug.cgi?id=208746
362
363         Rubber-stamped by Aakash Jain.
364
365         * resultsdbpy/resultsdbpy/example: Added.
366         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
367         * resultsdbpy/resultsdbpy/example/environment.py: Added.
368         (Environment): Organize environment variables used by results database.
369         (ModelFromEnvironment): Construct the database model from the environment.
370         (main): Create and drop tables, if required.
371         * resultsdbpy/resultsdbpy/example/main.py: Added.
372         (health): Web-server health check.
373         (handle_errors):
374         (main): Run results database web-server.
375         * resultsdbpy/resultsdbpy/example/worker.py: Added.
376         (main): Asynchronously process uploaded results.
377         * resultsdbpy/resultsdbpy/run: Added.
378
379 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
380
381         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
382         https://bugs.webkit.org/show_bug.cgi?id=209004
383
384         Reviewed by Tim Horton.
385
386         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
387         `use_gpu_process` is specified.
388
389         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
390         (parse_args):
391
392 2020-03-12  Matt Lewis  <jlewis3@apple.com>
393
394         Make flatpack import for run-webkit-tests only happen on linux systems
395         https://bugs.webkit.org/show_bug.cgi?id=208954
396
397         Reviewed by Philippe Normand.
398
399         * Scripts/run-webkit-tests: Added an if statement to find the system platform
400         to determine if we need the flatpackutils import. 
401
402 2020-03-12  Alex Christensen  <achristensen@webkit.org>
403
404         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
405         https://bugs.webkit.org/show_bug.cgi?id=207609
406
407         Reviewed by Ryosuke Niwa.
408
409         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
410         (TestWebKitAPI::TEST):
411
412 2020-03-12  Daniel Bates  <dabates@apple.com>
413
414         FocusController::setFocusedElement() should tell client of refocused element
415         https://bugs.webkit.org/show_bug.cgi?id=208880
416
417         Reviewed by Wenson Hsieh.
418
419         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
420         to start an input session. Currently, it does not even try.
421
422         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
423         (TEST):
424
425 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
426
427         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
428         https://bugs.webkit.org/show_bug.cgi?id=208970
429
430         Reviewed by Daniel Bates.
431
432         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
433         #!/usr/bin/env python.
434
435         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
436         probably has similar rules.
437
438         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
439         Everything else that does so is probably only used by webkit-build.
440
441         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
442
443         * gtkdoc/generate-gtkdoc:
444
445 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
446
447         [WebAuthn] Formalize the Keychain schema
448         https://bugs.webkit.org/show_bug.cgi?id=183533
449         <rdar://problem/43347926>
450
451         Reviewed by Brent Fulgham.
452
453         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
454         the original combination of RP ID and user handle.
455
456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
458         (WTR::TestRunner::cleanUpKeychain):
459         (WTR::TestRunner::keyExistsInKeychain):
460         * WebKitTestRunner/InjectedBundle/TestRunner.h:
461         * WebKitTestRunner/TestController.h:
462         * WebKitTestRunner/TestInvocation.cpp:
463         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
464         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
465         (WTR::TestController::cleanUpKeychain):
466         (WTR::TestController::keyExistsInKeychain):
467
468 2020-03-11  Keith Miller  <keith_miller@apple.com>
469
470         Test262-runner should always consider crashes as new failures
471         https://bugs.webkit.org/show_bug.cgi?id=208943
472
473         Reviewed by Yusuke Suzuki.
474
475         Right now the runner will consider crashes with no output as passes, which is obviously bad.
476         Since we should never crash on a conformance test we should consider a crash as a new failure
477         100% of the time.
478
479         * Scripts/test262/Runner.pm:
480         (processFile):
481         (runTest):
482         (processResult):
483
484 2020-03-11  Chris Dumez  <cdumez@apple.com>
485
486         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
487         https://bugs.webkit.org/show_bug.cgi?id=208927
488         <rdar://problem/55448331>
489
490         Reviewed by Alex Christensen.
491
492         Add API test coverage.
493
494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
495
496 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
497
498         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
499         https://bugs.webkit.org/show_bug.cgi?id=208860
500
501         Reviewed by Carlos Alberto Lopez Perez.
502
503         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
504         (StatusBubble): Added 'api-gtk'.
505         * BuildSlaveSupport/ews-build/config.json:
506         * BuildSlaveSupport/ews-build/factories.py:
507         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
508         GTK.
509         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
510         GTK.
511         (GTKBuildFactory):
512         (GTKBuildFactory.__init__): Deleted.
513         (GTKBuildAndTestFactory): Deleted.
514         (GTKBuildAndTestFactory.__init__): Deleted.
515         (GTKAPIBuildAndTestFactory): Deleted.
516         * BuildSlaveSupport/ews-build/loadConfig.py:
517
518 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
519
520         [ews] Add unit test to prevent multiple schedulers for a builder.
521         https://bugs.webkit.org/show_bug.cgi?id=208917
522
523         Reviewed by Carlos Alberto Lopez Perez.
524
525         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
526         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
527         (TagsForBuilderTest): Fixed a typo.
528
529 2020-03-11 Philippe Normand  <pnormand@igalia.com>
530
531         [GTK] Failing API tests under the Flatpak SDK environment
532         https://bugs.webkit.org/show_bug.cgi?id=208871
533
534         Reviewed by Michael Catanzaro.
535
536         The load-failed signal callback should return a boolean result,
537         otherwise we enter in unknown territory depending on how the
538         toolchain compiles this, possibly triggering bad behavior (with
539         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
540         GCC toolchain on buildbots).
541
542         Patch suggested by Michael Catanzaro.
543
544         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
545         (loadFailedCallback):
546
547 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
548
549         Sync FeatureList.pm with CMake definitions
550         https://bugs.webkit.org/show_bug.cgi?id=208866
551
552         Reviewed by Michael Catanzaro.
553
554         * Scripts/webkitperl/FeatureList.pm:
555
556 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
557
558         [ews] Add unit tests for commit queue factory
559         https://bugs.webkit.org/show_bug.cgi?id=208862
560
561         Reviewed by Jonathan Bedard.
562
563         * BuildSlaveSupport/ews-build/factories_unittest.py:
564         (TestCommitQueueFactory):
565         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
566
567 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
568
569         [ews-app] Status bubble should only display important messages in pop-over - part 3
570         https://bugs.webkit.org/show_bug.cgi?id=208865
571
572         Reviewed by Jonathan Bedard.
573
574         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
575         (StatusBubble): Added more strings to STEPS_TO_HIDE.
576
577 2020-03-10  Lauro Moura  <lmoura@igalia.com>
578
579         [WPE] MiniBrowser: Close child WebViews when exiting
580         https://bugs.webkit.org/show_bug.cgi?id=208689
581
582         Reviewed by Carlos Garcia Campos.
583
584         Store created views so we can release them before exiting.
585
586         * MiniBrowser/wpe/main.cpp:
587         (webViewClose):
588         (createWebView):
589         (main):
590
591 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
592
593         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
594         https://bugs.webkit.org/show_bug.cgi?id=208861
595
596         Reviewed by Jonathan Bedard.
597
598         * BuildSlaveSupport/ews-build/factories.py:
599         (Factory.__init__): Remove verifycqplus parameter.
600         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
601         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
602         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
603
604 2020-03-10  Philippe Normand  <pnormand@igalia.com>
605
606         [GTK] API favicon test flaky timeouts
607         https://bugs.webkit.org/show_bug.cgi?id=208189
608
609         Reviewed by Carlos Garcia Campos.
610
611         Sometimes the favicon changes already during the load. Keeping
612         track of it in the WebView favicon property notification handler
613         gets us rid of the race.
614
615         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
616         (testFaviconDatabaseGetFavicon):
617
618 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
619
620         Generate commit-queue status bubble from new EWS
621         https://bugs.webkit.org/show_bug.cgi?id=208811
622
623         Reviewed by Jonathan Bedard.
624
625         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
626         (StatusBubble._build_bubbles_for_patch):
627
628 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
629
630         Remove obsolete feature flags
631         https://bugs.webkit.org/show_bug.cgi?id=208830
632
633         Reviewed by Alex Christensen.
634
635         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
636         are no longer used.
637
638         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
639         when the compilation flag was removed in r258148.
640
641         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
642         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
643
644         * Scripts/webkitperl/FeatureList.pm:
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
646
647 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
648
649         WebKitTestRunner bundleID should not be cleared before every test
650         https://bugs.webkit.org/show_bug.cgi?id=208823
651         <rdar://problem/60204539>
652
653         Reviewed by Per Arne Vollan.
654
655         This is causing test failures for layout tests which rely on the Info.plist 
656         bundle identifier (not the one set via the override method).
657
658         * WebKitTestRunner/TestController.cpp:
659         (WTR::TestController::createWebViewWithOptions):
660         (WTR::TestController::ensureViewSupportsOptionsForTest):
661         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
662
663 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
664
665         [macOS] Notification observer is not removed
666         https://bugs.webkit.org/show_bug.cgi?id=208834
667
668         Reviewed by Tim Horton.
669
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
672         (TEST):
673
674 2020-03-06  Brian Burg  <bburg@apple.com>
675
676         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
677         https://bugs.webkit.org/show_bug.cgi?id=208729
678         <rdar://problem/60105447>
679
680         Reviewed by Jonathan Bedard.
681
682         Improve upload.py to look for the svn branch and revision for the 'webkit'
683         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
684
685         * Scripts/webkitpy/common/checkout/scm/git.py:
686         (Git):
687         (Git.git_svn_id_regexp):
688         (Git._field_from_git_svn_id):
689         (Git.svn_revision):
690         (Git.svn_branch):
691         (Git.svn_url):
692         (Git.native_branch):
693         Refactor svn revision, branch, url to use the same regexp and helper code.
694
695         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
696         (StubRepository.svn_branch):
697         Expose a stub since this is used unconditionally by Port.commits_for_upload.
698
699         * Scripts/webkitpy/common/checkout/scm/svn.py:
700         (SVN.svn_branch):
701         (SVN.native_revision):
702         (SVN):
703         (SVN.native_branch):
704         Refactor so the actual implementation is contained in svn_revision / svn_branch.
705         The native_* methods call out to the SVN equivalents since this is an SVN repository.
706
707         * Scripts/webkitpy/port/base.py:
708         (Port.commits_for_upload):
709         Add special git-svn handling for the WebKit repository so that SVN branch and revision
710         is preferred over the git equivalents.
711
712 2020-03-09  Antoine Quint  <graouts@apple.com>
713
714         TestWebKitAPI fails to build on watchOS
715         https://bugs.webkit.org/show_bug.cgi?id=208820
716
717         Reviewed by Tim Horton.
718
719         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
720
721 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
722
723         resultsdbpy: Add tool to manage resultsdbpy container
724         https://bugs.webkit.org/show_bug.cgi?id=208743
725
726         Rubber-stamped by Aakash Jain.
727
728         Add tool to start, stop and restart the resultsdbpy Docker container.
729
730         * resultsdbpy/resultsdbpy/container: Added.
731
732 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
735         https://bugs.webkit.org/show_bug.cgi?id=208706
736
737         Reviewed by Žan Doberšek.
738
739         Add test case to check surrounding text in multiline context.
740
741         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
742         (testWebKitInputMethodContextSurrounding):
743
744 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
745
746         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
747         https://bugs.webkit.org/show_bug.cgi?id=208783
748
749         Reviewed by Brent Fulgham.
750
751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
752
753 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
754
755         Replace the use of term "rollout" to "revert" in various tools
756         https://bugs.webkit.org/show_bug.cgi?id=208775
757
758         Reviewed by Ryosuke Niwa.
759
760         See this webkit-dev thread for the originating discussion:
761         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
762
763         'rollout' is a confusing term to anyone unacquainted with WebKit;
764         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
765
766         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
767         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
768
769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
777         * BuildSlaveSupport/ews-build/steps.py:
778         * BuildSlaveSupport/ews-build/steps_unittest.py:
779         * Scripts/webkit-tools-completion.sh:
780         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
781         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
782         * Scripts/webkitpy/common/checkout/scm/svn.py:
783         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
784         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
785         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
786         * Scripts/webkitpy/tool/bot/feeders.py:
787         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
788         * Scripts/webkitpy/tool/bot/irc_command.py:
789         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
790         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
791         * Scripts/webkitpy/tool/bot/sheriff.py:
792         * Scripts/webkitpy/tool/commands/download.py:
793         * Scripts/webkitpy/tool/commands/download_unittest.py:
794         * Scripts/webkitpy/tool/commands/newcommitbot.py:
795         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
796         * Scripts/webkitpy/tool/commands/queues_unittest.py:
797         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
798         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
799         * Scripts/webkitpy/tool/steps/__init__.py:
800         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
801         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
802         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
803         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
804
805 2020-03-07  David Quesada  <david_quesada@apple.com>
806
807         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
808         https://bugs.webkit.org/show_bug.cgi?id=208781
809         rdar://problem/60061016
810
811         Reviewed by Alex Christensen.
812
813         Add a test that recreates the conditions of this crash:
814         - Send a message from the injected bundle to the UI process that contains a reply block.
815         - Hold a reference to the reply block.
816         - Let the web view deallocate.
817         - Call the block, and expect not to crash.
818
819         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
820         (localObjectInterface):
821         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
822         (-[LocalObject doSomethingWithCompletionHandler:]):
823         (TEST):
824         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
825         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
826
827 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
828
829         TextManipulationController should work with ARIA labels
830         https://bugs.webkit.org/show_bug.cgi?id=208759
831
832         Reviewed by Wenson Hsieh.
833
834         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
835         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
836         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
837         the expected number of tokens for the first item as the very first image is correctly
838         detected per the code change. 
839         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
840
841 2020-03-07  Alex Christensen  <achristensen@webkit.org>
842
843         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
844         https://bugs.webkit.org/show_bug.cgi?id=208767
845
846         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
847         The frameID of the main frame before loading is only 0 on Mac right now.
848         The test is still good because it validates that execution works in the main frame before loading.
849
850 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
851
852         [ews] commit queue is not skipping layout tests for rollout patches
853         https://bugs.webkit.org/show_bug.cgi?id=208716
854
855         Unreviewed minor fix.
856
857         * BuildSlaveSupport/ews-build/steps.py:
858         (RunWebKitTests.doStepIf):
859         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
860         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
861
862 2020-03-05  Sam Weinig  <weinig@apple.com>
863
864         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
865         https://bugs.webkit.org/show_bug.cgi?id=207436
866         <rdar://problem/59296762>
867
868         Reviewed by Darin Adler.
869
870         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
871         Remove JSC related defines.
872
873 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
874
875         AX: Provide a way to run tests in isolated tree mode
876         https://bugs.webkit.org/show_bug.cgi?id=208629
877         <rdar://problem/60075583>
878
879         Reviewed by Ryosuke Niwa.
880
881         Provide the ability to run tests for accessibility in the isolated tree mode.
882         This sends a flag over to the injected bundle which calls the right HIServices override so that
883         the system thinks it is in isolated mode.
884
885         * Scripts/compare-webkit-configurations:
886         (flag_for_comparison):
887         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
888         (parse_args):
889         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
890         (parse_args):
891         * Scripts/webkitpy/port/driver.py:
892         (Driver.cmd_line):
893         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
894         (WTR::AccessibilityController::AccessibilityController):
895         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
896         (WTR::AccessibilityController::updateIsolatedTreeMode):
897         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
898         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
899         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
900         (WTR::InjectedBundle::didReceiveMessageToPage):
901         (WTR::InjectedBundle::beginTesting):
902         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
903         * WebKitTestRunner/Options.cpp:
904         (WTR::handleOptionAccessibilityIsolatedTreeMode):
905         (WTR::OptionsHandler::OptionsHandler):
906         * WebKitTestRunner/Options.h:
907         * WebKitTestRunner/TestController.cpp:
908         (WTR::TestController::initialize):
909         (WTR::TestController::resetPreferencesToConsistentValues):
910         (WTR::TestController::resetStateToConsistentValues):
911         * WebKitTestRunner/TestController.h:
912         (WTR::TestController::accessibilityIsolatedTreeMode const):
913
914 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
915
916         [Cocoa] Re-enable CFPrefs direct mode
917         https://bugs.webkit.org/show_bug.cgi?id=208690
918
919         Reviewed by Brent Fulgham.
920
921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
922         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
923         (TEST):
924         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
925         (TestWebKitAPI::TEST):
926
927 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
928
929         UIProcess needs mechanism to specify AppBound domains
930         https://bugs.webkit.org/show_bug.cgi?id=208528
931         <rdar://problem/59980340>
932
933         Reviewed by Brent Fulgham.
934
935         Added test app-bound domains to the plist and tested that the domains
936         are properly stored in the website data store after a navigation.
937
938         * TestWebKitAPI/Info.plist:
939         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
940         (TEST):
941
942 2020-03-06  Alex Christensen  <achristensen@webkit.org>
943
944         Add SPI to disable cross origin access control checks
945         https://bugs.webkit.org/show_bug.cgi?id=208748
946
947         Reviewed by Tim Hatcher.
948
949         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
950         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
951
952 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
953
954         [webkitpy] Fix executive on Windows to run wpt server correctly
955         https://bugs.webkit.org/show_bug.cgi?id=208693
956
957         Reviewed by Jonathan Bedard.
958
959         Bug fix for Windows environment a) fixing a typo. b) fixing path
960         c) fix how to kill subprocesses.
961
962         * Scripts/webkitpy/common/system/executive.py:
963         (Executive._windows_kill_command):
964         (Executive.interrupt):
965         (Executive.kill_all):
966         * Scripts/webkitpy/port/base.py:
967         (Port.web_platform_test_server_doc_root):
968
969 2020-03-06  Alex Christensen  <achristensen@webkit.org>
970
971         Evaluating JavaScript in main frame before loading should succeed
972         https://bugs.webkit.org/show_bug.cgi?id=208733
973
974         Reviewed by Tim Horton.
975
976         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
977
978 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
979
980         TextManipulationController should preserve images
981         https://bugs.webkit.org/show_bug.cgi?id=208692
982
983         Reviewed by Wenson Hsieh.
984
985         Added tests for preserving images and their ordering.
986
987         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
988         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
989         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
990         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
991
992 2020-03-06  David Quesada  <david_quesada@apple.com>
993
994         Add _WKResourceLoadInfo.resourceType SPI
995         https://bugs.webkit.org/show_bug.cgi?id=208723
996
997         Reviewed by Alex Christensen.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1000         (TEST):
1001
1002 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
1003
1004         Stop reporting to webkit-test-results.webkit.org
1005         https://bugs.webkit.org/show_bug.cgi?id=207218
1006
1007         Reviewed by Alexey Proskuryakov.
1008
1009         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1010         (RunWebKitTests):
1011
1012 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
1013
1014         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1015         https://bugs.webkit.org/show_bug.cgi?id=208365
1016         <rdar://problem/59877296>
1017
1018         Reviewed by Geoffrey Garen.
1019
1020         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1021         (TEST):
1022
1023 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1024
1025         EWS should be able to fetch patch status for security bugs while processing them
1026         https://bugs.webkit.org/show_bug.cgi?id=206511
1027
1028         Reviewed by Alexey Proskuryakov.
1029
1030         * BuildSlaveSupport/ews-build/steps.py:
1031         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1032         (BugzillaMixin.get_patch_json): 
1033         (BugzillaMixin.get_bug_json):
1034         (BugzillaMixin._is_bug_closed):
1035         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1036         (TransferToS3.hideStepIf): Ditto.
1037
1038 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1039
1040         [ews] commit-queue should show the trac url for the commit on the build page
1041         https://bugs.webkit.org/show_bug.cgi?id=208715
1042
1043         Reviewed by Jonathan Bedard.
1044
1045         * BuildSlaveSupport/ews-build/steps.py:
1046         (PushCommitToWebKitRepo.evaluateCommand):
1047
1048 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1049
1050         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1051         https://bugs.webkit.org/show_bug.cgi?id=208550
1052
1053         * TestWebKitAPI/cocoa/HTTPServer.mm:
1054         (TestWebKitAPI::HTTPServer::respondToRequests):
1055         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1056         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1057
1058 2020-03-06  Lauro Moura <lmoura@igalia.com>
1059
1060         [WPE][WebDriver] MiniBrowser should react to close session commands
1061         https://bugs.webkit.org/show_bug.cgi?id=207529
1062
1063         Reviewed by Carlos Garcia Campos.
1064
1065         Do not call g_object_unref on the first created view if it has already
1066         been disposed in the "close" signal handler.
1067
1068         Based on original patch by Yury Semikhatsky.
1069
1070         * MiniBrowser/wpe/main.cpp:
1071         (main):
1072
1073 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1074
1075         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1076         https://bugs.webkit.org/show_bug.cgi?id=208647
1077
1078         Reviewed by Carlos Garcia Campos.
1079
1080         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1081         (TestWebKitAPI::TEST):
1082
1083 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1084
1085         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1086         https://bugs.webkit.org/show_bug.cgi?id=208670
1087
1088         Reviewed by Brady Eidson.
1089
1090         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1091         (-[FrameNavigationDelegate waitForNavigations:]):
1092         (-[FrameNavigationDelegate requests]):
1093         (-[FrameNavigationDelegate frames]):
1094         (-[FrameNavigationDelegate callbacks]):
1095         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1096         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1097         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1098         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1099         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1100         (TEST):
1101
1102 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1103
1104         Add WKFrameInfo._parentFrameHandle SPI
1105         https://bugs.webkit.org/show_bug.cgi?id=208674
1106
1107         Reviewed by Brady Eidson.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1110
1111 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1112
1113         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1114         https://bugs.webkit.org/show_bug.cgi?id=208626
1115         <rdar://problem/60074148>
1116
1117         Reviewed by Brent Fulgham.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1121         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1122         (TestWebKitAPI::TEST):
1123         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1124         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1125         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1126
1127 2020-03-05  Antoine Quint  <graouts@apple.com>
1128
1129         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1130         https://bugs.webkit.org/show_bug.cgi?id=208644
1131         <rdar://problem/60042429>
1132
1133         Reviewed by Brady Eidson.
1134
1135         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1136         
1137         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1138            empty document has been removed in favor of the document for the requested URL,
1139         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1140            correctly does not injected the style sheet.
1141
1142         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1143
1144 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1145
1146         [ews] Add build step to push commit to WebKit repository
1147         https://bugs.webkit.org/show_bug.cgi?id=208589
1148
1149         Reviewed by Jonathan Bedard.
1150
1151         * BuildSlaveSupport/ews-build/steps.py:
1152         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1153         (PushCommitToWebKitRepo.start): Initialize log observer.
1154         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1155         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1156         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1157         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1158         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1159         * BuildSlaveSupport/ews-build/factories.py:
1160
1161 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1162
1163         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1164         https://bugs.webkit.org/show_bug.cgi?id=208262
1165
1166         Reviewed by Jonathan Bedard.
1167
1168         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1169
1170 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1171
1172         commit-queue should run WK2 tests instead of WK1 tests
1173         https://bugs.webkit.org/show_bug.cgi?id=208544
1174
1175         Reviewed by Jonathan Bedard.
1176
1177         * BuildSlaveSupport/ews-build/factories.py:
1178
1179 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1180
1181         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1182         https://bugs.webkit.org/show_bug.cgi?id=208645
1183
1184         Reviewed by Alexey Proskuryakov.
1185
1186         * BuildSlaveSupport/ews-build/steps.py:
1187         (ValidateCommiterAndReviewer.load_contributors):
1188         (ValidateCommiterAndReviewer.start):
1189
1190 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1191
1192         style-checker: Add UAF to the list of security words to warn about.
1193         https://bugs.webkit.org/show_bug.cgi?id=208643
1194
1195         Reviewed by Jonathan Bedard.
1196
1197         UAF is a common acronym used for use after free.
1198
1199         * Scripts/webkitpy/style/checkers/changelog.py:
1200         (ChangeLogChecker.check_for_unwanted_security_phrases):
1201
1202 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1203
1204         [MSVC] Add .natvis support of WebKit types
1205         https://bugs.webkit.org/show_bug.cgi?id=193119
1206
1207         Reviewed by Don Olmstead.
1208
1209         To help the WebKit developer while debugging, this file defines how
1210         WebKit types are displayed in debugger of Visual Studio.
1211         Very limited set of WebKit types, but it changes the world.
1212
1213         * VisualStudio/WebKit.natvis: Added.
1214
1215 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1216
1217         Add system trace points around display list replay
1218         https://bugs.webkit.org/show_bug.cgi?id=208616
1219
1220         Reviewed by Simon Fraser.
1221
1222         Add a new "Display list replay" trace point.
1223
1224         * Tracing/SystemTracePoints.plist:
1225
1226 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1227
1228         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1229         https://bugs.webkit.org/show_bug.cgi?id=208615
1230         <rdar://problem/59406743>
1231
1232         Reviewed by Alex Christensen.
1233
1234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1235         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1236         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1237         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1238         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1239         (TEST):
1240         Also make a test written in bug 206310 actually run code.
1241
1242 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1243
1244         [build.webkit.org] Remove leaks queue
1245         https://bugs.webkit.org/show_bug.cgi?id=208580
1246
1247         Reviewed by Jonathan Bedard.
1248
1249         * BuildSlaveSupport/build.webkit.org-config/config.json:
1250         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1252
1253 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1254
1255         Add SPI to evaluate JavaScript in an iframe
1256         https://bugs.webkit.org/show_bug.cgi?id=208605
1257
1258         Reviewed by Brady Eidson.
1259
1260         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1261
1262 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1263
1264         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1265         https://bugs.webkit.org/show_bug.cgi?id=208533
1266         <rdar://problem/60010184>
1267
1268         Reviewed by Alex Christensen.
1269
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1272         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1273         (TestWebKitAPI::TEST):
1274         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1275         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1276
1277 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1278
1279         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1280         https://bugs.webkit.org/show_bug.cgi?id=208593
1281
1282         Reviewed by Brady Eidson.
1283
1284         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1285         (TestWebKitAPI::TEST):
1286
1287 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1288
1289         WKWebView's frames accessor should return a traversable type
1290         https://bugs.webkit.org/show_bug.cgi?id=208591
1291
1292         Reviewed by Brady Eidson.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1295
1296 2020-03-04  Antoine Quint  <graouts@apple.com>
1297
1298         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
1299         https://bugs.webkit.org/show_bug.cgi?id=208575
1300         <rdar://problem/59773690>
1301
1302         Reviewed by Brady Eidson.
1303
1304         Add new tests for the new SPI which check:
1305         
1306         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
1307            specified WKWebView alone,
1308         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
1309         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
1310         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
1311         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
1312         6. and that the same test also works with PSON enabled.
1313
1314         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1315
1316 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
1317
1318         [macOS] test-lldb-webkit failing on debug bots
1319         https://bugs.webkit.org/show_bug.cgi?id=208545
1320
1321         Reviewed by Jonathan Bedard.
1322
1323         The lldb-webkit-test step must pass in the build configuration as an
1324         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
1325         binary that is downloaded with the rest of the build products. Without this
1326         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
1327         regardless of their actual build configuration.
1328
1329         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1330         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
1331         * Scripts/test-lldb-webkit:
1332         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
1333
1334 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1335
1336         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
1337         https://bugs.webkit.org/show_bug.cgi?id=208539
1338
1339         Unreviewed follow-up fix.
1340
1341         * BuildSlaveSupport/ews-build/steps.py:
1342
1343 2020-03-04  Daniel Bates  <dabates@apple.com>
1344
1345         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
1346         https://bugs.webkit.org/show_bug.cgi?id=208565
1347
1348         Reviewed by Wenson Hsieh.
1349
1350         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
1351         of its frame as a means to find all the editable elements in the visible content area
1352         of the web view.
1353
1354         Coincidentally this makes no difference to the test results right now because the web view
1355         happens to be located at the origin (0, 0) in the window. However if in the future the
1356         web view would be located at some other point then the tests may fail because the rectangle
1357         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
1358         rectangle for the visible content area.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1361         (TEST):
1362
1363 2020-03-04  Daniel Bates  <dabates@apple.com>
1364
1365         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
1366         https://bugs.webkit.org/show_bug.cgi?id=208564
1367
1368         Reviewed by Alex Christensen.
1369
1370         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
1371         to make it easy to run just these tests.
1372
1373         Currently, the tests are organized under the test case name WebKit. This means you need to
1374         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
1375         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
1376         so that a person can run just these test using:
1377         
1378                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
1379
1380         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1381         (TEST):
1382
1383 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1384
1385         [ews] Add build step to create local git commit for commit-queue
1386         https://bugs.webkit.org/show_bug.cgi?id=208539
1387
1388         Reviewed by Jonathan Bedard.
1389
1390         * BuildSlaveSupport/ews-build/steps.py:
1391         (CreateLocalGITCommit): Build step to create local git commit.
1392         (CreateLocalGITCommit.start):
1393         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
1394         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
1395         * BuildSlaveSupport/ews-build/factories.py:
1396
1397 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
1398
1399         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
1400         https://bugs.webkit.org/show_bug.cgi?id=207948
1401
1402         Reviewed by Zalan Bujtas.
1403
1404         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
1405         so that it receives the wheel events.
1406
1407         * DumpRenderTree/mac/EventSendingController.mm:
1408         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1409         * DumpRenderTree/win/EventSender.cpp:
1410         (mouseScrollBy):
1411
1412 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
1413
1414         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
1415         https://bugs.webkit.org/show_bug.cgi?id=208520
1416         <rdar://problem/60000214>
1417
1418         Reviewed by Chris Fleizach.
1419
1420         Calling InjectedBundle::singleton().page()->page() in the constructor
1421         of the AccessibilityController is having this side effect on iOS.
1422         So #if to MAC where it's actually being used.
1423
1424         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1425         (WTR::AccessibilityController::AccessibilityController):
1426
1427 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1428
1429         Add SPI _WKResourceLoadInfo.loadedFromCache
1430         https://bugs.webkit.org/show_bug.cgi?id=208554
1431
1432         Reviewed by Wenson Hsieh.
1433
1434         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1435         (TEST):
1436
1437 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1438
1439         Batch observations and completions of text manipulations
1440         https://bugs.webkit.org/show_bug.cgi?id=208406
1441
1442         Reviewed by Wenson Hsieh.
1443
1444         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
1445         multiple paragraphs at once.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1448         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
1449         (-[TextManipulationDelegate items]):
1450         (-[LegacyTextManipulationDelegate init]):
1451         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
1452         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
1453         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
1454         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
1455         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
1456         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
1457         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
1458
1459 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
1460
1461         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1462         https://bugs.webkit.org/show_bug.cgi?id=208415
1463
1464         Reviewed by Brent Fulgham.
1465
1466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1468         (TEST):
1469
1470 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1471
1472         Add response to _WKResourceLoadDelegate didCompleteWithError callback
1473         https://bugs.webkit.org/show_bug.cgi?id=208553
1474
1475         Reviewed by Simon Fraser.
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1478         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
1479         (TEST):
1480         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
1481
1482 2020-03-03  Brady Eidson  <beidson@apple.com>
1483
1484         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
1485         https://bugs.webkit.org/show_bug.cgi?id=198795
1486
1487         Reviewed by Chris Dumez.
1488
1489         This test appears to no longer be flaky.
1490         
1491         Let's re-enable it.
1492         
1493         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1494         (TestWebKitAPI::TEST):
1495
1496 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1497
1498         Requests sent to _WKResourceLoadDelegate should include HTTPBody
1499         https://bugs.webkit.org/show_bug.cgi?id=208550
1500
1501         Reviewed by Tim Hatcher.
1502
1503         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1504         (TEST):
1505         * TestWebKitAPI/cocoa/HTTPServer.mm:
1506         (TestWebKitAPI::HTTPServer::respondToRequests):
1507         HTTPServer now looks for Content-Length in its request.
1508         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
1509
1510 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1511
1512         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
1513         https://bugs.webkit.org/show_bug.cgi?id=208522
1514
1515         Reviewed by Brian Weinstein.
1516
1517         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1518         (TEST):
1519
1520 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1521
1522         commit-queue should update working directory and reapply patch just before commiting
1523         https://bugs.webkit.org/show_bug.cgi?id=208521
1524
1525         Reviewed by Jonathan Bedard.
1526
1527         * BuildSlaveSupport/ews-build/factories.py:
1528
1529 2020-03-03  Matt Lewis  <jlewis3@apple.com>
1530
1531         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
1532         https://bugs.webkit.org/show_bug.cgi?id=208485
1533
1534         Reviewed by Jonathan Bedard.
1535
1536         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1537         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
1538         that we don't have to recreate the variables that are already created.
1539         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
1540         from each module, rather than making extra imports that we don't need.
1541         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
1542         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
1543         and not part of the host.
1544         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
1545         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
1546         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
1547         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
1548         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
1549         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
1550         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
1551         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
1552         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
1553         if we were geting any value at all
1554         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
1555         sure we aren't gabking the wrong key:value pair
1556         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
1557         come with the MockHosts and MockHost inherits from MockSystemHost.
1558         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
1559         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
1560         to the various upload steps.
1561
1562 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1563
1564         [ews] Add build step to find list of modified changelogs
1565         https://bugs.webkit.org/show_bug.cgi?id=208514
1566
1567         Reviewed by Jonathan Bedard.
1568
1569         * BuildSlaveSupport/ews-build/factories.py:
1570         * BuildSlaveSupport/ews-build/steps.py:
1571         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
1572         (FindModifiedChangeLogs.start): Initialize log observer.
1573         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
1574         (FindModifiedChangeLogs.evaluateCommand):
1575         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
1576         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
1577         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
1578         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1579
1580 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
1581
1582         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
1583         https://bugs.webkit.org/show_bug.cgi?id=208451
1584
1585         Unreviewed test gardening.
1586
1587         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
1588
1589 2020-03-03  Jiten Mehta  <jmehta@apple.com>
1590
1591         Adopt HTTP Alternative Services Storage
1592         https://bugs.webkit.org/show_bug.cgi?id=208387
1593
1594         Reviewed by Alex Christensen.
1595
1596         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1597         (checkUntilEntryFound):
1598         (TEST):
1599
1600 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
1601
1602         Check for navigation to app-bound domain during script evaluation
1603         https://bugs.webkit.org/show_bug.cgi?id=208319
1604         <rdar://problem/57569321>
1605
1606         Reviewed by Brent Fulgham.
1607
1608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1609         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
1610         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1611         (TEST):
1612         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
1613         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
1614
1615 2020-03-03  Commit Queue  <commit-queue@webkit.org>
1616
1617         Unreviewed, rolling out r257754.
1618         https://bugs.webkit.org/show_bug.cgi?id=208513
1619
1620         Introduced API test failure (Requested by perarne on #webkit).
1621
1622         Reverted changeset:
1623
1624         "[Cocoa] Mapping from MIME type to UTI type should be done in
1625         the UI process"
1626         https://bugs.webkit.org/show_bug.cgi?id=208415
1627         https://trac.webkit.org/changeset/257754
1628
1629 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
1630
1631         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
1632         https://bugs.webkit.org/show_bug.cgi?id=208506
1633
1634         Reviewed by Carlos Garcia Campos.
1635
1636         * WebKitTestRunner/TestController.cpp:
1637         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
1638
1639 2020-03-02  Ben Nham  <nham@apple.com>
1640
1641         Add performance probes for HTML parsing
1642         https://bugs.webkit.org/show_bug.cgi?id=208271
1643
1644         Reviewed by Daniel Bates.
1645
1646         This adds probes that show which lines of HTML are have been parsed.
1647
1648         * Tracing/SystemTracePoints.plist:
1649
1650 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1651
1652         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1653         https://bugs.webkit.org/show_bug.cgi?id=208415
1654
1655         Reviewed by Brent Fulgham.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1658         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1659         (TEST):
1660
1661 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1662
1663         Unreviewed, rolling out r257725.
1664
1665         This commit caused 10 API tests to fail
1666
1667         Reverted changeset:
1668
1669         "[Cocoa] Mapping from MIME type to UTI type should be done in
1670         the UI process"
1671         https://bugs.webkit.org/show_bug.cgi?id=208415
1672         https://trac.webkit.org/changeset/257725
1673
1674 2020-03-02  Saam Barati  <sbarati@apple.com>
1675
1676         Don't skip tests unnecessarily on arm64
1677         https://bugs.webkit.org/show_bug.cgi?id=208470
1678         <rdar://problem/59968869>
1679
1680         Reviewed by Tadeu Zagallo.
1681
1682         * Scripts/run-jsc-stress-tests:
1683
1684 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1685
1686         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1687         https://bugs.webkit.org/show_bug.cgi?id=208434
1688
1689         Reviewed by Chris Fleizach.
1690
1691         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1692         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1693         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1694         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1695         (WTR::AccessibilityController::accessibleElementById): Same as above.
1696
1697 2020-03-02  John Wilander  <wilander@apple.com>
1698
1699         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1700         https://bugs.webkit.org/show_bug.cgi?id=208399
1701         <rdar://problem/24731650>
1702
1703         Reviewed by Brent Fulgham.
1704
1705         The majority of the changes in WTR::TestController is (partially) fixing a bug
1706         where the TestRunner would statically use the default website datastore instead
1707         of the website data store configure for the page. This worked for persistent
1708         storage testing but not for ephemeral sessions which is what this patch is all
1709         about. The previous TestController::websiteDataStore() is now called
1710         TestController::defaultWebsiteDataStore() and the new
1711         TestController::websiteDataStore() returns the configured website data store.
1712         Most of the use of the default website data store should probably change but
1713         that's not really for this patch to deal with. I did however move all of
1714         resource load statistics' use to the new TestController::websiteDataStore().
1715
1716         A new TestRunner function was added: isStatisticsEphemeral()
1717         It allows test cases to query the ephemeral status of resource load statistics.
1718
1719         One problem that is mitigated in this patch but not fully fixed is that for
1720         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1721         TestController::generatePageConfiguration() via C API 
1722         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1723         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1724         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1725         I tried removing the latter since one session for all platforms should be
1726         Enough but got broken behavior as a result. So now both are still there
1727         and both enable resource load statistics.
1728
1729         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1730         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1731         (WTR::TestRunner::isStatisticsEphemeral):
1732         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1733         * WebKitTestRunner/TestController.cpp:
1734         (WTR::TestController::defaultWebsiteDataStore):
1735         (WTR::TestController::websiteDataStore):
1736         (WTR::TestController::generatePageConfiguration):
1737         (WTR::TestController::resetPreferencesToConsistentValues):
1738         (WTR::TestController::resetStateToConsistentValues):
1739         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1740         (WTR::TestController::decidePolicyForNavigationAction):
1741         (WTR::TestController::platformAdjustContext):
1742         (WTR::TestController::clearServiceWorkerRegistrations):
1743         (WTR::TestController::clearDOMCache):
1744         (WTR::TestController::clearDOMCaches):
1745         (WTR::TestController::clearIndexedDatabases):
1746         (WTR::TestController::clearLocalStorage):
1747         (WTR::TestController::hasDOMCache):
1748         (WTR::TestController::domCacheSize):
1749         (WTR::TestController::setStatisticsEnabled):
1750         (WTR::TestController::isStatisticsEphemeral):
1751         (WTR::TestController::setStatisticsDebugMode):
1752         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1753         (WTR::TestController::setStatisticsLastSeen):
1754         (WTR::TestController::setStatisticsMergeStatistic):
1755         (WTR::TestController::setStatisticsPrevalentResource):
1756         (WTR::TestController::setStatisticsVeryPrevalentResource):
1757         (WTR::TestController::dumpResourceLoadStatistics):
1758         (WTR::TestController::isStatisticsPrevalentResource):
1759         (WTR::TestController::isStatisticsVeryPrevalentResource):
1760         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1761         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1762         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1763         (WTR::TestController::setStatisticsHasHadUserInteraction):
1764         (WTR::TestController::isStatisticsHasHadUserInteraction):
1765         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1766         (WTR::TestController::setStatisticsGrandfathered):
1767         (WTR::TestController::isStatisticsGrandfathered):
1768         (WTR::TestController::setUseITPDatabase):
1769         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1770         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1771         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1772         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1773         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1774         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1775         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1776         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1777         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1778         (WTR::TestController::statisticsUpdateCookieBlocking):
1779         (WTR::TestController::statisticsSubmitTelemetry):
1780         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1781         (WTR::TestController::setStatisticsIsRunningTest):
1782         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1783         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1784         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1785         (WTR::TestController::setStatisticsGrandfatheringTime):
1786         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1787         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1788         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1789         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1790         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1791         (WTR::TestController::statisticsDeleteCookiesForHost):
1792         (WTR::TestController::isStatisticsHasLocalStorage):
1793         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1794         (WTR::TestController::hasStatisticsIsolatedSession):
1795         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1796         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1797         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1798         (WTR::TestController::statisticsResetToConsistentState):
1799         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1800         * WebKitTestRunner/TestController.h:
1801         * WebKitTestRunner/TestInvocation.cpp:
1802         (WTR::TestInvocation::invoke):
1803         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1804         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1805         (WTR::initializeWebViewConfiguration):
1806         (WTR::TestController::platformCreateWebView):
1807
1808 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1809
1810         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1811         https://bugs.webkit.org/show_bug.cgi?id=208415
1812
1813         Reviewed by Brent Fulgham.
1814
1815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1816         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1817         (TEST):
1818
1819 2020-03-02  Daniel Bates  <dabates@apple.com>
1820
1821         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1822         https://bugs.webkit.org/show_bug.cgi?id=208352
1823         <rdar://problem/59867815>
1824
1825         Reviewed by Wenson Hsieh.
1826
1827         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1828         to actually scroll the web content. This also means we now execute the same code on both Mac and
1829         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1830         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1831         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1834         (TEST):
1835
1836 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1837
1838         Unreviewed, rolling out r257687.
1839
1840         This commit caused debug tests to crash for macOS & iOS
1841
1842         Reverted changeset:
1843
1844         "[Cocoa] Mapping from MIME type to UTI type should be done in
1845         the UI process"
1846         https://bugs.webkit.org/show_bug.cgi?id=208415
1847         https://trac.webkit.org/changeset/257687
1848
1849 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1850
1851         Unreviewed, rolling out r257618.
1852
1853         This allegedly causes Safari to crash when closing a window
1854         (see rdar://problem/59922725).
1855
1856         Reverted changeset:
1857
1858         "UIProcess crash after using _prepareForMoveToWindow, then
1859         deallocating the WKWebView before moving to the window"
1860         https://bugs.webkit.org/show_bug.cgi?id=208365
1861         https://trac.webkit.org/changeset/257618
1862
1863 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1864
1865         Remove std::lock_guard
1866         https://bugs.webkit.org/show_bug.cgi?id=206451
1867
1868         Reviewed by Anders Carlsson.
1869
1870         Add std::lock_guard lint rule to prevent from using it.
1871
1872         * Scripts/webkitpy/style/checkers/cpp.py:
1873         (check_lock_guard):
1874         (check_style):
1875         (CppChecker):
1876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1877         (WebKitStyleTest.test_lock_guard):
1878         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1879         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1880         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1881         (assertHasObjects):
1882         (assertHasOnlyObjects):
1883         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1884         (WTR::AXThread::dispatch):
1885         (WTR::AXThread::dispatchFunctionsFromAXThread):
1886         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1887         (WTR::AXThread::initializeRunLoop):
1888
1889 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1890
1891         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1892         https://bugs.webkit.org/show_bug.cgi?id=208415
1893
1894         Reviewed by Brent Fulgham.
1895
1896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1897         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1898         (TEST):
1899
1900 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1901
1902         Unreviewed, rolling out r257565.
1903
1904         It broke WinCairo MiniBrowser
1905
1906         Reverted changeset:
1907
1908         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1909         https://bugs.webkit.org/show_bug.cgi?id=206894
1910         https://trac.webkit.org/changeset/257565
1911
1912 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1913
1914         EWS fails to retry build in case of kill-old-processes exception
1915         https://bugs.webkit.org/show_bug.cgi?id=208003
1916
1917         Reviewed by Jonathan Bedard.
1918
1919         * BuildSlaveSupport/ews-build/steps.py:
1920         (KillOldProcesses.evaluateCommand):
1921         (KillOldProcesses.getResultSummary):
1922
1923 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1924
1925         [ews] commit-queue should update the ChangeLog with Reviewer name
1926         https://bugs.webkit.org/show_bug.cgi?id=206535
1927
1928         Reviewed by Jonathan Bedard.
1929
1930         * BuildSlaveSupport/ews-build/steps.py:
1931         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1932
1933 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1934
1935         run-javascriptcore-tests: Make upload format valid
1936         https://bugs.webkit.org/show_bug.cgi?id=208341
1937
1938         Rubber-stamped by Aakash Jain.
1939
1940         * Scripts/run-javascriptcore-tests:
1941         (uploadResults): Remove. FIXME.
1942         * Scripts/webkitdirs.pm:
1943         (splitVersionString): Handle case where the subminor version number has a - in it.
1944         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1945
1946 2020-02-28  youenn fablet  <youenn@apple.com>
1947
1948         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1949         https://bugs.webkit.org/show_bug.cgi?id=208130
1950
1951         Reviewed by Eric Carlson.
1952
1953         * WebKitTestRunner/TestOptions.h:
1954         Use GPU process to capture by default.
1955         We will remove this option once done verifying that every test works smoothly.
1956
1957 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1958
1959         [ews] commit queue should skip building and testing for rollout patches
1960         https://bugs.webkit.org/show_bug.cgi?id=208329
1961
1962         Reviewed by Jonathan Bedard.
1963
1964         * BuildSlaveSupport/ews-build/steps.py:
1965         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1966         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1967         (RunWebKit1Tests.doStepIf): Ditto.
1968         * BuildSlaveSupport/ews-build/steps_unittest.py:
1969         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1970         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1971
1972 2020-02-28  Daniel Bates  <dabates@apple.com>
1973
1974         Update my watch list preferences and contributor's entry.
1975
1976         * Scripts/webkitpy/common/config/contributors.json:
1977         * Scripts/webkitpy/common/config/watchlist:
1978
1979 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1980
1981         Fix WebCore export macros for declspec
1982         https://bugs.webkit.org/show_bug.cgi?id=208363
1983
1984         Reviewed by Konstantin Tokarev.
1985
1986         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1987         files. Removed precompiled headers that were empty.
1988
1989         * DumpRenderTree/DumpRenderTreePrefix.h:
1990         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1991         * MiniBrowser/win/stdafx.h:
1992         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1993         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1994         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1995         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1996         * WebKitTestRunner/PlatformFTW.cmake:
1997         * WebKitTestRunner/PlatformWin.cmake:
1998         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1999
2000 2020-02-27  Tim Horton  <timothy_horton@apple.com>
2001
2002         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2003         https://bugs.webkit.org/show_bug.cgi?id=208365
2004
2005         Reviewed by Alex Christensen.
2006
2007         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2008         (TEST):
2009         Add a test! It was a 100% repro crash before this change.
2010
2011 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
2012
2013         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2014         https://bugs.webkit.org/show_bug.cgi?id=208260
2015         <rdar://problem/59820107>
2016
2017         Reviewed by Tim Horton.
2018
2019         Followed instructions for adding an Info.plist for Single-File Tools
2020         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2021
2022         The default WebsiteDataStore file path will change with this test to
2023         reflect the new bundleID so we must change expectations for any api
2024         tests which rely on knowing the path.
2025
2026         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2028         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2029         (TEST):
2030         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2031         (TEST):
2032         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2033         (TEST):
2034         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2035         (TEST):
2036         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2037         (TEST):
2038         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2039         (TEST):
2040         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2041         (TEST):
2042         (defaultWebsiteCacheDirectory):
2043         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2044         (TEST):
2045         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2046         (TEST):
2047         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2048         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2049         (TEST):
2050         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2051         (TEST):
2052         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2053         (runWebsiteDataStoreCustomPaths):
2054         (TEST):
2055         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2056         (TestWebKitAPI::resetTestState):
2057         Now that we set a bundleID, we have to reset the cache model between
2058         tests, otherwise it gets stored between tests.
2059
2060         (TestWebKitAPI::TEST):
2061         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2062         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2063
2064 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2065
2066         TextManipulationController should not generate a new item for content in manipulated paragraphs
2067         https://bugs.webkit.org/show_bug.cgi?id=208286
2068
2069         Reviewed by Wenson Hsieh.
2070
2071         Added a regression test.
2072
2073         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2074         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2075
2076 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2077
2078         run-javascriptcore-tests: Make upload format valid
2079         https://bugs.webkit.org/show_bug.cgi?id=208341
2080
2081         Reviewed by Aakash Jain.
2082
2083         * Scripts/run-javascriptcore-tests:
2084         (uploadResults): Print json blob for upload after failure for debugging.
2085
2086 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2087
2088         [CMake] Add WebKit::PAL target
2089         https://bugs.webkit.org/show_bug.cgi?id=198493
2090
2091         Reviewed by Michael Catanzaro.
2092
2093         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2094
2095         * DumpRenderTree/PlatformWin.cmake:
2096
2097 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2098
2099         Add SPI to query WKFrameInfos in a WKWebView
2100         https://bugs.webkit.org/show_bug.cgi?id=208212
2101
2102         Reviewed by Brady Eidson.
2103
2104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2105         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2106         * WebKitTestRunner/TestController.cpp:
2107         (WTR::TestController::saltForOrigin):
2108
2109 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2110
2111         Unreviewed, rolling out r257530.
2112
2113         This commit seems to have broke the build internally for
2114         watchOS
2115
2116         Reverted changeset:
2117
2118         "Add SPI to query WKFrameInfos in a WKWebView"
2119         https://bugs.webkit.org/show_bug.cgi?id=208212
2120         https://trac.webkit.org/changeset/257530
2121
2122 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2123
2124         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2125         https://bugs.webkit.org/show_bug.cgi?id=206894
2126
2127         Reviewed by Adrian Perez de Castro.
2128
2129         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2130         MiniBrowsers.
2131
2132         * MiniBrowser/gtk/CMakeLists.txt:
2133         * MiniBrowser/win/CMakeLists.txt:
2134         * MiniBrowser/wpe/CMakeLists.txt:
2135
2136 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2137
2138         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2139         https://bugs.webkit.org/show_bug.cgi?id=206456
2140
2141         Reviewed by Brady Eidson.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2144         (TEST):
2145
2146 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2147
2148         _WKUserContentWorld should be a wrapper around WKContentWorld
2149         https://bugs.webkit.org/show_bug.cgi?id=208274
2150
2151         Reviewed by Brady Eidson.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2154         (TEST):
2155         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2156         (TEST):
2157
2158 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2159
2160         Unreviewed, rolling out r257522.
2161
2162         Caused 16 API test failures on the bots
2163
2164         Reverted changeset:
2165
2166         "TestWebKitAPI and WebKitTestRunner should have bundle
2167         identifiers"
2168         https://bugs.webkit.org/show_bug.cgi?id=208260
2169         https://trac.webkit.org/changeset/257522
2170
2171 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2172
2173         Add SPI to query WKFrameInfos in a WKWebView
2174         https://bugs.webkit.org/show_bug.cgi?id=208212
2175
2176         Reviewed by Brady Eidson.
2177
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2180         * WebKitTestRunner/TestController.cpp:
2181         (WTR::TestController::saltForOrigin):
2182
2183 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2184
2185         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2186         https://bugs.webkit.org/show_bug.cgi?id=208260
2187         <rdar://problem/59820107>
2188
2189         Reviewed by Tim Horton.
2190
2191         Followed instructions for adding an Info.plist for Single-File Tools
2192         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2193
2194         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2195         * TestWebKitAPI/Info.plist: Added.
2196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2197         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2198         * WebKitTestRunner/Info.plist: Added.
2199         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2200
2201 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2202
2203         Tests should each use a unique ResourceLoadStatistics file path for its database store
2204         https://bugs.webkit.org/show_bug.cgi?id=208206
2205         <rdar://problem/59690272>
2206
2207         Reviewed by Brady Eidson.
2208
2209         Initialize a default website data store before checking for the ITP
2210         store to ensure the directory exists after the file has been deleted.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2213         (TEST):
2214
2215 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2216
2217         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2218         https://bugs.webkit.org/show_bug.cgi?id=197684
2219         <rdar://problem/59467397>
2220
2221         Reviewed by Yusuke Suzuki.
2222
2223         Add test for FileSystem::createFile
2224
2225         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2226
2227 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2228
2229         [ews] commit-queue should verify patch committer and reviewer
2230         https://bugs.webkit.org/show_bug.cgi?id=206532
2231
2232         Reviewed by Jonathan Bedard.
2233
2234         * BuildSlaveSupport/ews-build/steps.py:
2235         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2236         (ValidateCommiterAndReviewer._addToLog):
2237         (ValidateCommiterAndReviewer.getResultSummary):
2238         (ValidateCommiterAndReviewer.fail_build):
2239         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2240         (ValidateCommiterAndReviewer.is_reviewer):
2241         (ValidateCommiterAndReviewer.is_committer):
2242         (ValidateCommiterAndReviewer.full_name_from_email):
2243         (ValidateCommiterAndReviewer.start):
2244
2245 2020-02-26  Daniel Bates  <dabates@apple.com>
2246
2247         [iOS] Send focus update immediately on becoming or resigning first responder
2248         https://bugs.webkit.org/show_bug.cgi?id=208082
2249         <rdar://problem/59688413>
2250
2251         Rubber-stamped by Jer Noble.
2252
2253         Add a test to ensure that selecting a position at a point after the web view
2254         becomes first responder is allowed. Such an operation is only allowed if the
2255         web view is focused.
2256
2257         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2258         (-[TestWKWebView selectPositionAtPoint:]):
2259         (TEST):
2260         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2261
2262 2020-02-26  Chris Dumez  <cdumez@apple.com>
2263
2264         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2265
2266         The test was added for macOS and times out on iOS.
2267
2268         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2269         (TEST):
2270
2271 2020-02-26  Youenn Fablet  <youenn@apple.com>
2272
2273         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2274         https://bugs.webkit.org/show_bug.cgi?id=208238
2275
2276         Reviewed by Eric Carlson.
2277
2278         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2279         (TEST):
2280         Remove use of deleted parameter.
2281
2282 2020-02-25  Devin Rousso  <drousso@apple.com>
2283
2284         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2285         https://bugs.webkit.org/show_bug.cgi?id=206911
2286         <rdar://problem/58026635>
2287
2288         Reviewed by Brian Burg.
2289
2290         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2291         (TestWebKitAPI::TEST):
2292         Add test for `WTF::HashSet::reserveInitialCapacity`.
2293
2294         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2295         (TestWebKitAPI::TEST):
2296         Actually check the value of `WTF::HashMap::capacity`.
2297
2298         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
2299         (-[InspectorDelegate _webView:didAttachInspector:])
2300         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
2301         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
2302         (TestWebKitAPI::TEST):
2303         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2304         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
2305         (TestWebKitAPI::TEST): Deleted.
2306
2307 2020-02-25  Matt Lewis  <jlewis3@apple.com>
2308
2309         Add checkout_root to stubrepository.py
2310         https://bugs.webkit.org/show_bug.cgi?id=208213
2311
2312         Reviewed by Jonathan Bedard.
2313
2314         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2315         (StubRepository.__init__):
2316
2317         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
2318         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
2319
2320 2020-02-25  Daniel Bates  <dabates@apple.com>
2321
2322         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
2323         https://bugs.webkit.org/show_bug.cgi?id=208214
2324
2325         Reviewed by Wenson Hsieh.
2326
2327         Wait until the copy operation completes before loading the second web view and testing paste
2328         to ensure that something was actually copied to the clipboard.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
2331         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2332         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
2333         so that we wait until the command completes.
2334
2335 2020-02-25  Chris Dumez  <cdumez@apple.com>
2336
2337         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
2338         https://bugs.webkit.org/show_bug.cgi?id=208199
2339         <rdar://problem/59746887>
2340
2341         Reviewed by Alex Christensen.
2342
2343         Add API test coverage.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2346         (TEST):
2347
2348 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2349
2350         spinRunLoop should take a non-zero integer as parameter
2351         https://bugs.webkit.org/show_bug.cgi?id=208148
2352         <rdar://problem/59766682>
2353
2354         Unreviewed iOS build fix.
2355
2356         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2357         (TestWebKitAPI::Util::spinRunLoop):
2358
2359 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2360
2361         spinRunLoop should take a non-zero integer as parameter
2362         https://bugs.webkit.org/show_bug.cgi?id=208148
2363
2364         Reviewed by Darin Adler.
2365
2366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2367         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2368         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2369         (TestWebKitAPI::Util::spinRunLoop):
2370
2371 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2372
2373         [WTF] Add tests for CompactRefPtrTuple
2374         https://bugs.webkit.org/show_bug.cgi?id=208172
2375
2376         Reviewed by Darin Adler.
2377
2378         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
2379         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
2380
2381         * TestWebKitAPI/CMakeLists.txt:
2382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2383         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
2384         (TestWebKitAPI::TEST):
2385
2386 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
2387
2388         [ews] commit-queue should check that patch have appropriate review flag
2389         https://bugs.webkit.org/show_bug.cgi?id=208138
2390
2391         Reviewed by Jonathan Bedard.
2392
2393         * BuildSlaveSupport/ews-build/steps.py:
2394         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
2395         (BugzillaMixin._is_patch_cq_plus):
2396         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
2397         (ValidatePatch.start):
2398
2399 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
2400
2401         [WebAuthn] Implement SPI for the platform authenticator
2402         https://bugs.webkit.org/show_bug.cgi?id=208087
2403         <rdar://problem/59369305>
2404
2405         Reviewed by Brent Fulgham.
2406
2407         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
2408
2409         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
2410         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2412         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2413         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2414         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
2415         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
2416         (TestWebKitAPI::TEST):
2417         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
2418         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
2419         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
2420         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
2421
2422 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2423
2424         Unreviewed, updating LLDB test for CompactPointerTuple.
2425         https://bugs.webkit.org/show_bug.cgi?id=207827
2426
2427         * lldb/lldb_webkit.py:
2428         (WTFCompactPointerTupleProvider):
2429         (WTFCompactPointerTupleProvider.update):
2430
2431 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
2432
2433         Provide alternate way to name Web Content process
2434         https://bugs.webkit.org/show_bug.cgi?id=205224
2435         rdar://57038084
2436
2437         Reviewed by Alex Christensen.
2438
2439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2440         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
2441         (TestWebKitAPI::TEST):
2442
2443 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
2444
2445         results.webkit.org: Link to result archives
2446         https://bugs.webkit.org/show_bug.cgi?id=207646
2447         <rdar://problem/59395807>
2448
2449         Rubber-stamped by Aakash Jain.
2450
2451         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
2452         (_ArchiveRouter): Retrieve json from archive-router endpoint.
2453         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
2454         return the most specific value.
2455         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
2456         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
2457         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
2458         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2459         (parametersForInstance): Extract from lambda function.
2460         (testRunLink): Use parametersForInstance instead of a lambda function.
2461         (archiveLink): Return an archive link for data. 
2462         (contentForData): Add archive link to view.
2463         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2464         (TimelineFromEndpoint): Accept both suite and test.
2465         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
2466         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
2467         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
2468         * resultsdbpy/resultsdbpy/view/view_routes.py:
2469         (ViewRoutes.__init__): Add archive_route dictionary.
2470
2471 2020-02-24  Alex Christensen  <achristensen@webkit.org>
2472
2473         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
2474         https://bugs.webkit.org/show_bug.cgi?id=208035
2475         <rdar://problem/58011337>
2476
2477         Reviewed by Tim Hatcher.
2478
2479         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2480
2481 2020-02-22  Darin Adler  <darin@apple.com>
2482
2483         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
2484         https://bugs.webkit.org/show_bug.cgi?id=208099
2485
2486         Reviewed by Antti Koivisto.
2487
2488         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2489         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
2490         so we can use the -[NSString createJSStringRef] method.
2491         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
2492         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
2493
2494 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2495
2496         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
2497         https://bugs.webkit.org/show_bug.cgi?id=208096
2498         <rdar://problem/59632008>
2499
2500         Reviewed by Alexey Proskuryakov.
2501
2502         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
2503         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
2504         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
2505
2506         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
2507         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
2508         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
2509         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
2510         in the credit card expiry field.
2511
2512         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
2513
2514         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2515         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2516         (WTR::UIScriptController::setDefaultCalendarType):
2517         * WebKitTestRunner/TestController.h:
2518
2519         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
2520         identifier and calendar locale identifier.
2521
2522         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2523         (WTR::swizzledCalendar):
2524         (WTR::TestController::overriddenCalendarIdentifier const):
2525         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
2526
2527         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
2528
2529         (WTR::TestController::setDefaultCalendarType):
2530
2531         Plumb the new calendar's locale identifier through this method.
2532
2533         (WTR::TestController::cocoaResetStateToConsistentValues):
2534         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
2535         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2536         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2537         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
2538
2539 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
2540
2541         App-bound domains should have separate Network Sessions
2542         https://bugs.webkit.org/show_bug.cgi?id=208026
2543         <rdar://problem/59434006>
2544
2545         Reviewed by Brent Fulgham.
2546
2547         This patch is mostly test infrastructure involving 3 functions.
2548         One sets in-app browser privacy as enabled in the network process
2549         manually for the test. One ensures that setting the WebView category
2550         works properly, and the last one checks for an app-bound session for
2551         an app-bound navigation.
2552
2553         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2555         (WTR::InjectedBundle::didReceiveMessageToPage):
2556         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2557         (WTR::TestRunner::getWebViewCategory):
2558         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
2559         (WTR::TestRunner::hasAppBoundSession):
2560         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
2561         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
2562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2563         * WebKitTestRunner/TestController.cpp:
2564         (WTR::TestController::ensureViewSupportsOptionsForTest):
2565         Clearing the bundleID should happen right before setting a new one, 
2566         otherwise it clears the ID after it is set and returns a null ID.
2567
2568         (WTR::TestController::resetStateToConsistentValues):
2569         (WTR::TestController::getWebViewCategory):
2570         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
2571         (WTR::inAppBrowserPrivacyBooleanResultCallback):
2572         (WTR::inAppBrowserPrivacyVoidResultCallback):
2573         (WTR::TestController::hasAppBoundSession):
2574         (WTR::TestController::setInAppBrowserPrivacyEnabled):
2575         * WebKitTestRunner/TestController.h:
2576         * WebKitTestRunner/TestInvocation.cpp:
2577         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2578         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2579         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
2580         (WTR::TestInvocation::didReceivePrevalentDomains):
2581         (WTR::TestInvocation::didReceiveWebViewCategory):
2582         * WebKitTestRunner/TestInvocation.h:
2583         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2584         (WTR::TestController::getWebViewCategory):
2585
2586 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
2587
2588         Build DumpRenderTree and WebKitTestRunner for macCatalyst
2589         https://bugs.webkit.org/show_bug.cgi?id=208068
2590         <rdar://problem/59676596>
2591
2592         Reviewed by Tim Horton.
2593
2594         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
2595         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2596         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
2597         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
2598         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
2599         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
2600         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
2601         * DumpRenderTree/mac/EventSendingController.h: Ditto.
2602         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
2603         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
2604         * Makefile: Add DumpRenderTree and WebKitTestRunner.
2605         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2606         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
2607         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2608
2609 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2610
2611         [ews] Add build step to Validate ChangeLog for commit-queue
2612         https://bugs.webkit.org/show_bug.cgi?id=208064
2613
2614         Reviewed by Jonathan Bedard.
2615
2616         * BuildSlaveSupport/ews-build/steps.py:
2617         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
2618         (ValidateChangeLogAndReviewer.start):
2619         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
2620         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
2621
2622 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2623
2624         [ews] Add build step to set cq- flag on bugzilla patch
2625         https://bugs.webkit.org/show_bug.cgi?id=208021
2626
2627         Reviewed by Jonathan Bedard.
2628
2629         * BuildSlaveSupport/ews-build/steps.py:
2630         (BugzillaMixin.set_cq_minus_flag_on_patch):
2631         (SetCommitQueueMinusFlagOnPatch):
2632         (SetCommitQueueMinusFlagOnPatch.start):
2633         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
2634
2635 2020-02-20  Matt Lewis  <jlewis3@apple.com>
2636
2637         Stub repositories fail to upload some results due to missing head svn revision
2638         https://bugs.webkit.org/show_bug.cgi?id=207684
2639
2640         Reviewed by Jonathan Bedard.
2641
2642         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
2643         (MockHost.__init__):
2644         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2645         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2646         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2647         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
2648         * Scripts/webkitpy/port/base.py:
2649         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
2650         from using mock SCMs and more
2651         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
2652
2653 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
2654
2655         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
2656         https://bugs.webkit.org/show_bug.cgi?id=208051
2657
2658         Reviewed by Carlos Alberto Lopez Perez.
2659
2660         Verbose flag prints out each test name executed. Without this flag
2661         stdout prints out one or two periods.
2662
2663         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2664         (RunJavaScriptCoreTests.start):
2665
2666 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2667
2668         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2669         https://bugs.webkit.org/show_bug.cgi?id=207984
2670
2671         Reviewed by Daniel Bates.
2672
2673         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2674         (TestWebKitAPI::TEST):
2675
2676 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2677
2678         [GTK] Improve user agent quirk for Google Docs and Google Drive
2679         https://bugs.webkit.org/show_bug.cgi?id=206506
2680
2681         Reviewed by Carlos Garcia Campos.
2682
2683         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2684         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2685         (TestWebKitAPI::TEST):
2686
2687 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2688
2689         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2690         https://bugs.webkit.org/show_bug.cgi?id=207380
2691
2692         Reviewed by Jonathan Bedard.
2693
2694         Added a new rule 'build/export_macro'.
2695
2696         Removed a obsolete rule 'readability/webkit_export' which was used
2697         only by Chromium port (r148185).
2698
2699         * Scripts/webkitpy/style/checkers/cpp.py:
2700         (_FunctionState.export_macro):
2701         (check_function_definition):
2702         (_unix_path): Added.
2703         (is_generated_file): Use _unix_path.
2704         (check_has_config_header): Ditto.
2705         (CppChecker):
2706         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2707         (WebKitStyleTest.test_export_macro_check):
2708         (WebKitStyleTest.test_webkit_export_check): Deleted.
2709
2710 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2711
2712         [Win][MiniBrowser] Add prettier toolbar button icons
2713         https://bugs.webkit.org/show_bug.cgi?id=207999
2714
2715         Reviewed by Ross Kirsling.
2716
2717         Use a custom toolbar button icons instead of system stock icons.
2718
2719         Fixed a bug toolbar button dropdown arrows always looked being
2720         hovered. TBSTYLE_FLAT should be given.
2721
2722         Removed the window border line of Progress Indicator.
2723
2724         * MiniBrowser/win/MainWindow.cpp:
2725         (MainWindow::createToolbar):
2726         * MiniBrowser/win/MiniBrowserLib.rc:
2727         * MiniBrowser/win/MiniBrowserLibResource.h:
2728         * MiniBrowser/win/toolbar.bmp: Added.
2729
2730 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2731
2732         Update run-webkit-tests help description for skip-failing-tests
2733         https://bugs.webkit.org/show_bug.cgi?id=208031
2734
2735         Reviewed by Alexey Proskuryakov.
2736
2737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2738
2739 2020-02-20  Chris Dumez  <cdumez@apple.com>
2740
2741         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2742         https://bugs.webkit.org/show_bug.cgi?id=208015
2743         <rdar://problem/59591630>
2744
2745         Reviewed by Geoffrey Garen.
2746
2747         Add API test coverage.
2748
2749         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2750         (TEST):
2751
2752 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2753
2754         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2755         https://bugs.webkit.org/show_bug.cgi?id=207998
2756         <rdar://problem/40942425>
2757
2758         Reviewed by Sam Weinig.
2759
2760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2761         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2762         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2763         (TestWebKitAPI::TEST):
2764         Add some tests for top content insets.
2765
2766 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2767
2768         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2769         https://bugs.webkit.org/show_bug.cgi?id=207910
2770
2771         Unreviewed infrastructure fix.
2772
2773         * Scripts/run-javascriptcore-tests:
2774         (configurationForUpload): Use the major version instead of the sub-minor version
2775         for version name.
2776
2777 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2778
2779         [CMake] Add WPE::libwpe target
2780         https://bugs.webkit.org/show_bug.cgi?id=207970
2781
2782         Reviewed by Adrian Perez de Castro.
2783
2784         Use the WPE::libwpe target.
2785
2786         * MiniBrowser/wpe/CMakeLists.txt:
2787         * TestWebKitAPI/PlatformWPE.cmake:
2788         * TestWebKitAPI/glib/PlatformWPE.cmake:
2789         * wpe/backends/CMakeLists.txt:
2790
2791 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2792
2793         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2794         https://bugs.webkit.org/show_bug.cgi?id=207749
2795
2796         Reviewed by Ross Kirsling.
2797
2798         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2799
2800         * MiniBrowser/win/MainWindow.cpp:
2801         (MainWindow::createToolbar):
2802         (MainWindow::WndProc):
2803         (MainWindow::setDefaultURLToCurrentURL):
2804         (MainWindow::goHome): Added.
2805         (MainWindow::onURLBarEnter):
2806         * MiniBrowser/win/MainWindow.h:
2807         * MiniBrowser/win/MiniBrowserLib.rc:
2808         * MiniBrowser/win/MiniBrowserLibResource.h:
2809         * MiniBrowser/win/MiniBrowserReplace.h:
2810         * MiniBrowser/win/WinMain.cpp:
2811         (wWinMain):
2812
2813 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2814
2815         Fix check-webkit-style errors related to AVFoundationSPI.h
2816         https://bugs.webkit.org/show_bug.cgi?id=207834
2817
2818         Reviewed by Daniel Bates.
2819
2820         Revert the change in r256770 regarding the headers ordering.
2821         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2822
2823         * Scripts/webkitpy/style/checkers/cpp.py:
2824         (check_include_line):
2825
2826 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2827
2828         results.webkit.org: Correctly report JSC tests for windows
2829         https://bugs.webkit.org/show_bug.cgi?id=207910
2830
2831         Rubber-stamped by Aakash Jain.
2832
2833         * Scripts/run-javascriptcore-tests:
2834         (configurationForUpload): Give Windows a version name.
2835         * Scripts/webkitdirs.pm:
2836         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2837         Version dictionary.
2838
2839 2020-02-19  Chris Dumez  <cdumez@apple.com>
2840
2841         Unreviewed, fix assertions in storage access API layout tests after r256882.
2842
2843         Drop dead testRunner code to toggle storage access API feature.
2844
2845         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2847         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2848         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2849         * WebKitTestRunner/TestInvocation.cpp:
2850         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2851
2852 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2853
2854         [WPE] Support 2D axis, smooth-motion events
2855         https://bugs.webkit.org/show_bug.cgi?id=207881
2856
2857         Reviewed by Carlos Garcia Campos.
2858
2859         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2860
2861 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2862
2863         Unreviewed, rolling out r256851.
2864
2865         Broke internal bots
2866
2867         Reverted changeset:
2868
2869         "Stub repositories fail to upload some results due to missing
2870         head svn revision"
2871         https://bugs.webkit.org/show_bug.cgi?id=207684
2872         https://trac.webkit.org/changeset/256851
2873
2874 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2875
2876         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2877         https://bugs.webkit.org/show_bug.cgi?id=207883
2878
2879         Reviewed by Ross Kirsling.
2880
2881         Unlike other mouse buttons, 4th and 5th mouse buttons are
2882         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2883         WM_XBUTTONUP events to the window under the mouse cursor.
2884         Unhandled WM_XBUTTONUP events are automatically converted to
2885         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2886         parent window.
2887         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2888
2889         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2890         handled.
2891
2892         * MiniBrowser/win/BrowserWindow.h:
2893         * MiniBrowser/win/MainWindow.cpp:
2894         (MainWindow::WndProc):
2895         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2896         (WebKitBrowserWindow::navigateForwardOrBackward):
2897         * MiniBrowser/win/WebKitBrowserWindow.h:
2898         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2899         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2900         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2901
2902 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2903
2904         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2905         https://bugs.webkit.org/show_bug.cgi?id=207912
2906         <rdar://problem/59556922>
2907
2908         Reviewed by Brian Weinstein.
2909
2910         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2911         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2912         (TEST):
2913         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2914         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2915
2916 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2917
2918         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2919         https://bugs.webkit.org/show_bug.cgi?id=207899
2920         <rdar://problem/55658207>
2921
2922         Reviewed by Tim Horton and Simon Fraser.
2923
2924         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2925
2926         * WebKitTestRunner/TestController.cpp:
2927         (WTR::updateTestOptionsFromTestHeader):
2928         * WebKitTestRunner/TestOptions.h:
2929         (WTR::TestOptions::hasSameInitializationOptions const):
2930         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2931         (WTR::TestController::platformCreateWebView):
2932
2933 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2934
2935         Stub repositories fail to upload some results due to missing head svn revision
2936         https://bugs.webkit.org/show_bug.cgi?id=207684
2937
2938         Reviewed by Jonathan Bedard.
2939
2940         * Scripts/webkitpy/api_tests/run_api_tests.py:
2941         (main): Added initializing the scm to the host object.
2942         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2943         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2944         it in line with modern code.
2945         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2946         (main): Added inializing the scm to the host object.
2947         * Scripts/webkitpy/port/base.py:
2948         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2949         from using mock SCMs and more
2950         * Scripts/webkitpy/test/main.py:
2951         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2952         and converted the webkit_root variable to the SCM checkout root.
2953         (Tester._run_tests):
2954
2955 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2956
2957         Move [UIDevice currentDevice] calls to UI process
2958         https://bugs.webkit.org/show_bug.cgi?id=204320
2959
2960         Reviewed by Darin Adler.
2961
2962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2963         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2964         (TEST):
2965
2966 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2967
2968         Move from "layer flush" terminology to "rendering update"
2969         https://bugs.webkit.org/show_bug.cgi?id=207870
2970
2971         Reviewed by Tim Horton.
2972
2973         Rename various functions and member variables to move away from the legacy "layer flush"
2974         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2975         that we have layers is an implementation detail.
2976         
2977         Change LayerFlushThrottlingState to be an OptionSet<>.
2978
2979         * Tracing/SystemTracePoints.plist:
2980
2981 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2982
2983         [Webkit.css] Adding popover style element
2984         This help to prevent us reinventing the wheel ever again
2985         https://bugs.webkit.org/show_bug.cgi?id=207787
2986
2987         Reviewed by Dean Jackson.
2988
2989         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2990         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2991         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2992         (.popover):
2993         (.popover>.content):
2994         (.popover.display):
2995         (.popover .arrow):
2996         (.popover .arrow.point-top):
2997         (.popover .arrow.point-bottom):
2998         (.popover .arrow.point-left):
2999         (.popover .arrow.point-right):
3000         (@media (prefers-color-scheme: dark) .popover>.content):
3001         (@media (prefers-color-scheme: dark) .popover.display):
3002         (@media (prefers-color-scheme: dark) .popover .arrow):
3003         (.popover>.content>.section): Deleted.
3004         (.popover:focus>.content, .popover:hover>.content): Deleted.
3005         (.popover.right>.content): Deleted.
3006         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
3007         (.popover.left>.content): Deleted.
3008         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
3009         (.popover.bottom>.content): Deleted.
3010         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
3011
3012 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
3013
3014         Update WebKit Tools to issue mach extensions as needed
3015         https://bugs.webkit.org/show_bug.cgi?id=207850
3016         <rdar://problem/59521019>
3017
3018         Reviewed by Per Arne Vollan.
3019
3020         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
3021         to its child processes (WebContent, GPU, Network, etc.) as needed.
3022
3023         * MiniBrowser/MiniBrowser.entitlements:
3024         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
3025         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3027         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
3028
3029 2020-02-17  Peng Liu  <peng.liu6@apple.com>
3030
3031         Fix check-webkit-style errors related to AVFoundationSPI.h
3032         https://bugs.webkit.org/show_bug.cgi?id=207834
3033
3034         Reviewed by Eric Carlson.
3035
3036         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
3037         Soft-link headers can be included as either "file.h" or <file.h>.
3038
3039         * Scripts/webkitpy/style/checkers/cpp.py:
3040         (_classify_include):
3041         (check_include_line):
3042
3043 2020-02-17  Keith Rollin  <krollin@apple.com>
3044
3045         Unreviewed build fix after r256715.
3046
3047         Fix tvOS and watchOS builds.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3050
3051 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
3052
3053         Use CF prefs direct mode in the WebContent process
3054         https://bugs.webkit.org/show_bug.cgi?id=203420
3055
3056         Reviewed by Brent Fulgham.
3057
3058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3059         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3060         (TEST):
3061
3062 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3063
3064         EWS should be able to file Bugzilla bugs
3065         https://bugs.webkit.org/show_bug.cgi?id=207845
3066
3067         Reviewed by Alexey Proskuryakov.
3068
3069         * BuildSlaveSupport/ews-build/steps.py:
3070         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3071
3072 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3073
3074         EWS should be able to comment on Bugzilla
3075         https://bugs.webkit.org/show_bug.cgi?id=201927
3076
3077         Reviewed by Jonathan Bedard.
3078
3079         * BuildSlaveSupport/ews-build/steps.py:
3080         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3081         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3082         (BugzillaMixin.close_bug): Ditto.
3083         (CommentOnBug): Build step to comment on bugzilla bug.
3084
3085 2020-02-17  Antti Koivisto  <antti@apple.com>
3086
3087         [macOS] Add trace points for layer flush runloop observer
3088         https://bugs.webkit.org/show_bug.cgi?id=207837
3089
3090         Reviewed by Sam Weinig.
3091
3092         * Tracing/SystemTracePoints.plist:
3093
3094 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3095
3096         [CMake] Use builtin targets
3097         https://bugs.webkit.org/show_bug.cgi?id=205166
3098
3099         Reviewed by Darin Adler.
3100
3101         * TestWebKitAPI/PlatformWin.cmake:
3102
3103 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3104
3105         [ews] add SetBuildSummary step for Windows EWS
3106         https://bugs.webkit.org/show_bug.cgi?id=207556
3107
3108         Reviewed by Jonathan Bedard.
3109
3110         * BuildSlaveSupport/ews-build/factories.py:
3111         (WindowsFactory.__init__):
3112         (GTKBuildAndTestFactory.__init__):
3113         * BuildSlaveSupport/ews-build/factories_unittest.py:
3114         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3115
3116 2020-02-17  Alberto Garcia  <berto@igalia.com>
3117
3118         [WPE] Change the QML plugin install path
3119         https://bugs.webkit.org/show_bug.cgi?id=207761
3120
3121         Reviewed by Philippe Normand.
3122
3123         * Scripts/run-qt-wpe-minibrowser:
3124         * glib/api_test_runner.py:
3125         (TestRunner._run_test_qt):
3126
3127 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3128
3129         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3130         https://bugs.webkit.org/show_bug.cgi?id=207746
3131
3132         Reviewed by Don Olmstead.
3133
3134         * MiniBrowser/win/stdafx.h:
3135
3136 2020-02-16  Brady Eidson  <beidson@apple.com>
3137
3138         Expose "allowsContentJavaScript" on WKWebpagePreferences
3139         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3140
3141         Reviewed by Darin Adler.
3142
3143         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3144         (TEST):
3145         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3146         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3147         (TEST):
3148         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3149         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3150         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3151         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3152         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3153         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3154         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3155         * TestWebKitAPI/cocoa/TestWKWebView.h:
3156         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3157         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3158
3159 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3160
3161         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3162         https://bugs.webkit.org/show_bug.cgi?id=207747
3163
3164         Reviewed by Keith Miller.
3165
3166         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3167         (TestWebKitAPI::TEST):
3168
3169 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3170
3171         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3172         https://bugs.webkit.org/show_bug.cgi?id=207360
3173         <rdar://problem/57825317>
3174
3175         Reviewed by Ryosuke Niwa.
3176
3177         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3178         (TestWebKitAPI::TEST):
3179
3180 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
3181
3182         [CMake] Add Fontconfig::Fontconfig target
3183         https://bugs.webkit.org/show_bug.cgi?id=207730
3184
3185         Reviewed by Adrian Perez de Castro.
3186
3187         Use the Fontconfig::Fontconfig target.
3188
3189         * WebKitTestRunner/PlatformGTK.cmake:
3190
3191 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
3192
3193          Expose prevalent domains on a per-page basis
3194          https://bugs.webkit.org/show_bug.cgi?id=207523
3195          <rdar://problem/59270758>
3196
3197         Reviewed by Chris Dumez.
3198
3199         Added WebKitTestRunner functions so this functionality can be tested.
3200         clearPrevalentDomains should be called between tests to reset the
3201         state.
3202
3203         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3204         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3205         (WTR::InjectedBundle::didReceiveMessageToPage):
3206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3207         (WTR::TestRunner::getPrevalentDomains):
3208         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
3209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3210         * WebKitTestRunner/TestController.cpp:
3211         (WTR::TestController::resetStateToConsistentValues):
3212         (WTR::TestController::getPrevalentDomains):
3213         (WTR::TestController::clearPrevalentDomains):
3214         * WebKitTestRunner/TestController.h:
3215         * WebKitTestRunner/TestInvocation.cpp:
3216         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3217         (WTR::TestInvocation::didReceivePrevalentDomains):
3218         * WebKitTestRunner/TestInvocation.h:
3219         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3220         (WTR::TestController::getPrevalentDomains):
3221         (WTR::TestController::clearPrevalentDomains):
3222
3223 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3224
3225         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
3226         https://bugs.webkit.org/show_bug.cgi?id=207682
3227
3228         Reviewed by Ross Kirsling.
3229
3230         The toolbar placed button common controls as the toolbar buttons.
3231         However, because these buttons are focusable, shortcut keys don't
3232         work after clicking them.
3233
3234         Added Home button, Add to Bookmarks button, dropdown buttons of
3235         back and forward buttons, but they aren't implemented yet. Just
3236         placeholders at the moment.
3237
3238         * MiniBrowser/win/MainWindow.cpp:
3239         (MainWindow::createToolbar): Added.
3240         (MainWindow::resizeToolbar): Added.
3241         (MainWindow::rescaleToolbar): Added.
3242         (MainWindow::init):
3243         (MainWindow::resizeSubViews):
3244         (MainWindow::updateDeviceScaleFactor):
3245         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
3246
3247 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3248
3249         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
3250         https://bugs.webkit.org/show_bug.cgi?id=207676
3251
3252         Reviewed by Wenson Hsieh and Timothy Hatcher.
3253
3254         Added regression tests for pasting content with -apple-system-label and outdenting content.
3255
3256         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3257         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
3258         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
3259
3260 2020-02-13  Alex Christensen  <achristensen@webkit.org>
3261
3262         _WKResourceLoadInfo should conform to NSSecureCoding
3263         https://bugs.webkit.org/show_bug.cgi?id=207667
3264
3265         Reviewed by Brady Eidson.
3266
3267         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3268         (TEST):
3269
3270 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
3271
3272         [PlayStation] Add Buildbots for Debug/Release builds
3273         https://bugs.webkit.org/show_bug.cgi?id=199454
3274
3275         Reviewed by Aakash Jain.
3276
3277         * BuildSlaveSupport/build.webkit.org-config/config.json:
3278         Add PlayStation slaves, builders
3279         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3280         Use higher timeout for playstation as with win bot
3281         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3282         Set PlayStation category for playstation platform
3283         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3284         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
3285         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3286         Add PlayStation expectations
3287
3288 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
3289
3290         [iOS] Check if PIP is supported in the UI process
3291         https://bugs.webkit.org/show_bug.cgi?id=207406
3292
3293         Reviewed by Brent Fulgham.
3294
3295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3296         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
3297         (TEST):
3298
3299 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3300
3301         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
3302         https://bugs.webkit.org/show_bug.cgi?id=207397
3303         <rdar://problem/59268128>
3304
3305         Reviewed by Jer Noble.
3306
3307         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3308         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3309
3310 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3311
3312         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
3313         https://bugs.webkit.org/show_bug.cgi?id=207696
3314
3315         Reviewed by Tim Horton.
3316
3317         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3318
3319 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3320
3321         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
3322         https://bugs.webkit.org/show_bug.cgi?id=207680
3323         <rdar://problem/59340940>
3324
3325         Reviewed by Tim Horton.
3326
3327         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
3328         the current selection works.
3329
3330         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3331         (-[TestWKWebView updateSelectionWithExtentPoint:]):
3332         * TestWebKitAPI/ios/UIKitSPI.h:
3333
3334 2020-02-13  Said Abou-Hallawa  <said@apple.com>
3335
3336         Unreviewed, rolling out r255158, 255405 and r255486
3337
3338         Caused test flakiness and PLT regression.
3339
3340         * DumpRenderTree/mac/DumpRenderTree.mm:
3341         (resetWebPreferencesToConsistentValues):
3342         * DumpRenderTree/win/DumpRenderTree.cpp:
3343         (enableExperimentalFeatures):
3344         * WebKitTestRunner/TestController.cpp:
3345         (WTR::TestController::resetPreferencesToConsistentValues):
3346
3347 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3348
3349         run-javascriptcore-tests: Allow insecure requests on upload
3350         https://bugs.webkit.org/show_bug.cgi?id=207662
3351
3352         Rubber-stamped by Aakash Jain.
3353
3354         * Scripts/run-javascriptcore-tests:
3355         (uploadResults): Allow insecure curl request when posting results.
3356
3357 2020-02-12  Truitt Savell  <tsavell@apple.com>
3358
3359         Unreviewed, rolling out r256463.
3360
3361         Caused major flakiness on Mac wk2
3362
3363         Reverted changeset:
3364
3365         "REGRESSION (r255158): http/tests/frame-throttling/raf-
3366         throttle-in-cross-origin-subframe.html is a flaky failure"
3367         https://bugs.webkit.org/show_bug.cgi?id=206839
3368         https://trac.webkit.org/changeset/256463
3369
3370 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3371
3372         results.webkit.org: Remove debug JS logging
3373         https://bugs.webkit.org/show_bug.cgi?id=207663
3374
3375         Reviewed by Aakash Jain.
3376
3377         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3378         (elapsed):
3379         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3380         (_ToolTip.prototype.toString):
3381         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
3382         (prototype.addWithDelay):
3383         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
3384
3385 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
3386
3387         Remove CSS_DEVICE_ADAPTATION
3388         https://bugs.webkit.org/show_bug.cgi?id=203479
3389
3390         Reviewed by Tim Horton.
3391         
3392         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
3393         so remove the code.
3394
3395         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3396
3397 2020-02-12  Said Abou-Hallawa  <said@apple.com>
3398
3399         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
3400         https://bugs.webkit.org/show_bug.cgi?id=206839
3401
3402         Reviewed by Simon Fraser.
3403
3404         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
3405
3406         * DumpRenderTree/mac/DumpRenderTree.mm:
3407         (resetWebPreferencesToConsistentValues):
3408         * DumpRenderTree/win/DumpRenderTree.cpp:
3409         (enableExperimentalFeatures):
3410         * WebKitTestRunner/TestController.cpp:
3411         (WTR::TestController::resetPreferencesToConsistentValues):
3412
3413 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3414
3415         results.webkit.org: Cache archive content
3416         https://bugs.webkit.org/show_bug.cgi?id=207589
3417
3418         Reviewed by Aakash Jain.
3419
3420         * resultsdbpy/resultsdbpy/flask_support/util.py:
3421         (cache_for): Add decorator function which sets the cache values on the returned response.
3422         * resultsdbpy/resultsdbpy/view/archive_view.py:
3423         (ArchiveView): Cache archive content client-side for 12 hours.
3424         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
3425         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
3426
3427 2020-02-12  Youenn Fablet  <youenn@apple.com>
3428
3429         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3430         https://bugs.webkit.org/show_bug.cgi?id=207537
3431
3432         Reviewed by Chris Dumez.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3435
3436 2020-02-11  Rob Buis  <rbuis@igalia.com>
3437
3438         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
3439         <https://webkit.org/b/207424>
3440         <rdar://problem/59250384>
3441
3442         Reviewed by Rob Buis.
3443
3444         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3445         (TestWebKitAPI::TEST): Add more tests.
3446
3447 2020-02-11  Commit Queue  <commit-queue@webkit.org>
3448
3449         Unreviewed, rolling out r256314.
3450         https://bugs.webkit.org/show_bug.cgi?id=207594
3451
3452         It is breaking an API test (Requested by youenn on #webkit).
3453
3454         Reverted changeset:
3455
3456         "WebSWServerConnection::registerServiceWorkerClient is not
3457         sending IPC message to UIProcess when it should"
3458         https://bugs.webkit.org/show_bug.cgi?id=207537
3459         https://trac.webkit.org/changeset/256314
3460
3461 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
3462
3463         results.webkit.org: Configuration documentation should include architecture
3464         https://bugs.webkit.org/show_bug.cgi?id=207584
3465
3466         Reviewed by Aakash Jain.
3467
3468         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
3469
3470 2020-02-11  Youenn Fablet  <youenn@apple.com>
3471
3472         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
3473         https://bugs.webkit.org/show_bug.cgi?id=207325
3474         <rdar://problem/59224810>
3475
3476         Reviewed by Eric Carlson.
3477
3478         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
3479         (TestWebKitAPI::TEST):
3480         Add a test validating that RTCRtpSender.getCapabilities does not return null.
3481         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3482
3483 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3484
3485         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
3486         https://bugs.webkit.org/show_bug.cgi?id=207557
3487
3488         Reviewed by Jonathan Bedard.
3489
3490         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
3491         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
3492         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
3493         around this by focusing an empty select element instead (for which we won't attempt to create and select any
3494         table view cells).
3495
3496         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3497
3498 2020-02-11  Alex Christensen  <achristensen@webkit.org>
3499
3500         Add WKHTTPCookieStore._getCookiesForURL SPI
3501         https://bugs.webkit.org/show_bug.cgi?id=207527
3502
3503         Reviewed by Brady Eidson.
3504
3505         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3506         (TEST):
3507
3508 2020-02-11  Youenn Fablet  <youenn@apple.com>
3509
3510         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3511         https://bugs.webkit.org/show_bug.cgi?id=207537
3512
3513         Reviewed by Chris Dumez.
3514
3515         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3516
3517 2020-02-11  Lauro Moura  <lmoura@igalia.com>
3518
3519         [WPE][WebDriver] MiniBrowser should react to close session commands
3520         https://bugs.webkit.org/show_bug.cgi?id=207529
3521
3522         Reviewed by Carlos Garcia Campos.
3523
3524         WebDriver delete session command asks to close the WebView associated to the
3525         current automation session. We must react to it to avoid lots of
3526         timeouts and errors.
3527
3528         * MiniBrowser/wpe/main.cpp:
3529         (main): Listen to "close" signal on the main WebView.
3530
3531 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3532
3533         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
3534         https://bugs.webkit.org/show_bug.cgi?id=207525
3535         <rdar://problem/59110543>
3536
3537         Reviewed by Tim Horton.
3538
3539         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
3540         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
3541         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
3542         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
3543         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
3544         causing us to crash upon trying to create the dictionary.
3545
3546         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
3547         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
3548         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
3549         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
3550         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
3551         beginning of each API test.
3552
3553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3554         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3555         (overrideBundleIdentifier):
3556
3557         Move this to the top of the file, so it can be shared.
3558
3559         (+[WKWebView initialize]):
3560
3561         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
3562         internal class method that calls into the internal helper function, with no other side effects.
3563
3564         * TestWebKitAPI/ios/UIKitSPI.h:
3565
3566 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3567
3568         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
3569         https://bugs.webkit.org/show_bug.cgi?id=207501
3570         <rdar://problem/59323414>
3571
3572         Reviewed by Alex Christensen.
3573
3574         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
3575         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
3576         The same behavior.
3577
3578 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
3579
3580         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
3581         https://bugs.webkit.org/show_bug.cgi?id=207352
3582         <rdar://problem/59115798>
3583
3584         Reviewed by Alex Christensen.
3585
3586         Add a test to exercise the new SPI.
3587
3588         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
3589         a webpage that contains text in subframes.
3590
3591
3592 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3593
3594         [iOS] Crash when granting access to asset services
3595         https://bugs.webkit.org/show_bug.cgi?id=207520
3596
3597         Reviewed by Brent Fulgham.
3598
3599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3600         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
3601         (TEST):
3602
3603 2020-02-10  Chris Dumez  <cdumez@apple.com>
3604
3605         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
3606         https://bugs.webkit.org/show_bug.cgi?id=207481
3607
3608         Reviewed by Alexey Proskuryakov.
3609
3610         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
3611         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
3612         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
3613
3614         * DumpRenderTree/mac/DumpRenderTree.mm:
3615         (resetWebViewToConsistentStateBeforeTesting):
3616         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
3617         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
3618         over internal settings.
3619
3620 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3621
3622         [watchOS] Notification listener is never unregistered
3623         https://bugs.webkit.org/show_bug.cgi?id=207459
3624
3625         Reviewed by Maciej Stachowiak.
3626
3627         Add a test which tests that posting a backlight level change notification will not cause a crash.
3628
3629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3630         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
3631         (TEST):
3632
3633 2020-02-10  James Howard  <jameshoward@mac.com>
3634
3635         Standard gamepad mapping for GameControllerGamepads
3636         https://bugs.webkit.org/show_bug.cgi?id=206033
3637
3638         Reviewed by Dean Jackson.
3639
3640         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3642         (WTR::TestRunner::setMockGamepadDetails):
3643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3644         * WebKitTestRunner/TestInvocation.cpp:
3645         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3646
3647 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3648
3649         [ews] Display flaky layout test names in build summary
3650         https://bugs.webkit.org/show_bug.cgi?id=207504
3651
3652         Reviewed by Jonathan Bedard.
3653
3654         * BuildSlaveSupport/ews-build/steps.py:
3655         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
3656         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
3657         (AnalyzeLayoutTestsResults.start):
3658
3659 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3660
3661         [ews] Use SetBuildSummary instead of&nb