[iOS] Cmd-C doesn't copy text from WKWebView

[WebKit-https.git] / Tools / ChangeLog

2017-06-12  Tim Horton  <timothy_horton@apple.com>

        [iOS] Cmd-C doesn't copy text from WKWebView
        https://bugs.webkit.org/show_bug.cgi?id=173277
        <rdar://problem/32396742>

        Reviewed by Dan Bernstein.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
        Add a test ensuring that -copy on WKContentView will cause text to be copied.

2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>

        [WebCrypto] Remove experimental feature flag of SubtleCrypto
        https://bugs.webkit.org/show_bug.cgi?id=173197
        <rdar://problem/32688148>

        Reviewed by Brent Fulgham.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (enableExperimentalFeatures):
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::beginTesting):
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
        * WebKitTestRunner/InjectedBundle/TestRunner.h:

2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>

        [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
        https://bugs.webkit.org/show_bug.cgi?id=173238
        <rdar://problem/31943370>

        Reviewed by Ryosuke Niwa and Tim Horton.

        Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
        element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
        of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/ios/DataInteractionSimulator.h:
        * TestWebKitAPI/ios/DataInteractionSimulator.mm:
        (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
        (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.

2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>

        WebItemProviderPasteboard should call its completion block immediately after a synchronous load
        https://bugs.webkit.org/show_bug.cgi?id=173225
        <rdar://problem/32713144>

        Reviewed by Tim Horton.

        Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
        cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):

2017-06-12  Jonathan Bedard  <jbedard@apple.com>

        Return correct process names for iOS on-device testing
        https://bugs.webkit.org/show_bug.cgi?id=173263

        Reviewed by Alex Christensen.

        When running tests on iOS devices, process names do not end with '.Development'
        as they do on Mac and iOS simulator.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::webProcessName): Return correct process name without '.Development'
        for iOS on-device testing.
        (WTR::TestController::networkProcessName): Ditto.
        (WTR::TestController::databaseProcessName): Ditto.

2017-06-12  Chris Dumez  <cdumez@apple.com>

        Regression(r217867): Legacy SessionHistoryEntryData format should not change
        https://bugs.webkit.org/show_bug.cgi?id=173267
        <rdar://problem/32701257>

        Reviewed by Simon Fraser.

        Restrict test to stop covering saving / restore of scrollRestoration via the legacy
        SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
        though as this covers the crash that r217867 was fixing.

        * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
        (TestWebKitAPI::createSessionStateData):
        (TestWebKitAPI::TEST):
        (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.

2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Stop dismissing menus attached to the web view for every injected event
        https://bugs.webkit.org/show_bug.cgi?id=172708

        Reviewed by Alex Christensen.

        It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
        that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
        events while the menu is open.

        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
        (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
        (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().

2017-06-12  Miguel Gomez  <magomez@igalia.com>

        [GTK][WPE] Enable GStreamer GL on development builds
        https://bugs.webkit.org/show_bug.cgi?id=173248

        Enable GStreamer GL for GTK and WPE.

        Reviewed by Carlos Garcia Campos.

        * Scripts/webkitperl/FeatureList.pm:

2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.

        Notifications are no longer cleared on page navigation.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
        (testWebViewNotification):

2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.

        DBus interface and object path names were updated in r217831.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:

2017-06-10  Dan Bernstein  <mitz@apple.com>

        Reverted r218056 because it made the IDE reindex constantly.

        * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
        * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
        * MiniBrowser/Configurations/DebugRelease.xcconfig:
        * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
        * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
        * WebEditingTester/Configurations/DebugRelease.xcconfig:
        * WebKitTestRunner/Configurations/DebugRelease.xcconfig:

2017-06-10  Dan Bernstein  <mitz@apple.com>

        [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
        https://bugs.webkit.org/show_bug.cgi?id=173223

        Reviewed by Sam Weinig.

        The rebuilds were happening due to a difference in the compiler options that the IDE and
        xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
        xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
        specify an appropriate path in CLANG_INDEX_STORE_PATH.

        * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
        * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
        * MiniBrowser/Configurations/DebugRelease.xcconfig:
        * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
        * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
        * WebEditingTester/Configurations/DebugRelease.xcconfig:
        * WebKitTestRunner/Configurations/DebugRelease.xcconfig:

2017-06-10  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Reduce polling in ServerProcess
        https://bugs.webkit.org/show_bug.cgi?id=173116

        Reviewed by Ryosuke Niwa.

        We should be smarter about polling. We do not need to poll every time a line is read from
        stdout and stderr since lines are usually read from cached data. We should only poll
        when extracting that cached data from stdout and stderr.

        * Scripts/webkitpy/port/driver.py:
        (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
        and on ServerProcess to poll the process if not data is available in stdout and stderr.
        * Scripts/webkitpy/port/driver_unittest.py:
        (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
        ServerProcess.
        * Scripts/webkitpy/port/server_process.py:
        (ServerProcess._read): Allow for data to be read from _output even if the process has
        crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
        * Scripts/webkitpy/port/server_process_mock.py:
        (MockServerProcess): Add number_of_times_polled.
        (MockServerProcess.poll): Increment number_of_times_polled.
        (MockServerProcess.has_crashed): Poll before returning crash state.
        (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
        just like a ServerProcess would.
        (MockServerProcess.read_stdout): Ditto.
        * Scripts/webkitpy/port/server_process_unittest.py:
        (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
        process from ending before stdout and stderr are read. This is the reason this test was flakey.
        (TestServerProcess):
        (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
        the processes is polled.
        (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
        data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.

2017-06-10  Andy Estes  <aestes@apple.com>

        [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
        https://bugs.webkit.org/show_bug.cgi?id=173190
        <rdar://problem/31360659>

        Reviewed by Brady Eidson.
        
        Added a release assert that tries to create a proper test failure if the web process crashes.

        * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
        (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):

2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>

        [iOS DnD] Add a hook to perform two-step drops in editable content
        https://bugs.webkit.org/show_bug.cgi?id=172992
        <rdar://problem/32590174>

        Reviewed by Tim Horton.

        Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
        Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
                DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop

        * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
        (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
        (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):

        Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
        be overridden. Currently, this is overridden to just return true.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):

2017-06-09  Zan Dobersek  <zdobersek@igalia.com>

        [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
        https://bugs.webkit.org/show_bug.cgi?id=173103

        Reviewed by Xabier Rodriguez-Calvar.

        * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
        when building the WPE port through build-webkit.

2017-06-09  Zan Dobersek  <zdobersek@igalia.com>

        [WPE] Enable MEDIA_SOURCE for build-webkit builds
        https://bugs.webkit.org/show_bug.cgi?id=173136

        Reviewed by Xabier Rodriguez-Calvar.

        * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.

2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Use API::FormClient instead of the C API in WebKitFormClient
        https://bugs.webkit.org/show_bug.cgi?id=173098

        Reviewed by Žan Doberšek.

        Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
        assuming that all tests containing forms define ids for the form elements like
        /webkit2/WebKitWebExtension/form-controls-associated-signal does.

        * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
        (formControlsAssociatedCallback):

2017-06-08  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Run sample/spindump on iOS devices
        https://bugs.webkit.org/show_bug.cgi?id=171881
        <rdar://problem/32084602>

        Reviewed by Daniel Bates.

        * Scripts/webkitpy/port/darwin.py:
        (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
        requires sudo to run spindump.
        * Scripts/webkitpy/port/ios_device.py:
        (IOSDevicePort.look_for_new_samples): Deleted.
        (IOSDevicePort.sample_process): Deleted.
        * Scripts/webkitpy/port/ios_device_unittest.py:
        (IOSDeviceTest): iOS devices use 'ios' and their os_name.
        (IOSDeviceTest.test_spindump):
        (IOSDeviceTest.test_sample_process):
        (IOSDeviceTest.test_sample_process_exception):
        * Scripts/webkitpy/port/ios_simulator_unittest.py:
        (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.

2017-06-08  Keith Miller  <keith_miller@apple.com>

        WebAssembly: We should only create wrappers for functions that can be exported
        https://bugs.webkit.org/show_bug.cgi?id=173088

        Reviewed by Saam Barati.

        Add quick mode for wasm tests.

        * Scripts/run-jsc-stress-tests:

2017-06-08  Darin Adler  <darin@apple.com>

        WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
        https://bugs.webkit.org/show_bug.cgi?id=173106

        Reviewed by Sam Weinig.

        * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
        destroyed last.
        * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
        * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.

2017-06-07  Dan Bernstein  <mitz@apple.com>

        [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
        https://bugs.webkit.org/show_bug.cgi?id=173086

        Reviewed by Andy Estes.

        * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
        (TEST):

2017-06-07  Alexey Proskuryakov  <ap@apple.com>

        Add High Sierra support to WebKit tools
        https://bugs.webkit.org/show_bug.cgi?id=173080

        Rubber-stamped by Daniel Bates.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
        Added dashboard support.

        * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
        * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
        Trigger the right build queues on check-in.

        * Scripts/webkitpy/common/system/platforminfo.py:
        * Scripts/webkitpy/common/system/platforminfo_unittest.py:
        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
        * Scripts/webkitpy/port/mac.py:
        * Scripts/webkitpy/port/mac_unittest.py:
        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        Added cases for Sierra, and updated tests for new baseline search paths.

2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>

        Unreviewed, rolling out r217902.

        This change appears to have caused imported/w3c/web-platform-
        tests/fetch/api/cors tests to fail on El Capitan.

        Reverted changeset:

        "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
        https://bugs.webkit.org/show_bug.cgi?id=172930
        http://trac.webkit.org/changeset/217902

2017-06-07  Daniel Bates  <dabates@apple.com>

        Teach run-webkit-tests how to run HTTPS Web Platform Tests
        https://bugs.webkit.org/show_bug.cgi?id=172930
        <rdar://problem/32570201>

        Reviewed by Youenn Fablet.

        Some web platform tests need to be run from an HTTPS server in order to exercise functionality
        that is conditioned on the page being delivered over a secure protocol. One example of such
        a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.

        Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
        to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
        This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.

        * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
        (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
        to the Web Platform Tests HTTPS server.
        * Scripts/webkitpy/port/base.py:
        (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
        * Scripts/webkitpy/port/driver.py:
        (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
        instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
        _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
        indicate that they should be considered private instance variables.
        (Driver.is_web_platform_test): Update code for renamed instance variables.
        (Driver):
        (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
        (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
        determine the base URL to use to access the test.
        (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
        Platform Tests HTTPS URL. Also updated code for renamed instance variables.

2017-06-07  Per Arne Vollan  <pvollan@apple.com>

        Support removal of authentication data through the Website data store API.
        https://bugs.webkit.org/show_bug.cgi?id=171217

        Reviewed by Brady Eidson.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::didReceiveMessageToPage):
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::removeAllSessionCredentials):
        (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
        (WTR::TestInvocation::didRemoveAllSessionCredentials):
        * WebKitTestRunner/TestInvocation.h:
        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
        (WTR::TestController::removeAllSessionCredentials):

2017-06-07  Charlie Turner  <cturner@igalia.com>

        Add Charlie Turner as contributor
        https://bugs.webkit.org/show_bug.cgi?id=173055

        Reviewed by Carlos Alberto Lopez Perez.

        I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
        of webkit-patch upload, which reordered some fields and removed a newline.

        * Scripts/webkitpy/common/config/contributors.json:

2017-06-06  Chris Dumez  <cdumez@apple.com>

        RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
        https://bugs.webkit.org/show_bug.cgi?id=173033
        <rdar://problem/32591099>

        Reviewed by Simon Fraser.

        Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
        WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
        (TestWebKitAPI::didFinishLoadForFrame):
        (TestWebKitAPI::setPageLoaderClient):
        (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
        (TestWebKitAPI::TEST):

2017-06-06  Andy Estes  <aestes@apple.com>

        REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
        https://bugs.webkit.org/show_bug.cgi?id=172849
        <rdar://problem/32567454>

        Reviewed by Darin Adler.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
        (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
        (TestWebKitAPI::TEST):

2017-06-06  Yoav Weiss  <yoav@yoav.ws>

        [preload] Conditional support for media preloading and align media `as` values.
        https://bugs.webkit.org/show_bug.cgi?id=172501

        Reviewed by Dean Jackson.

        Turn on media preloading preference for tests.

        * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
        * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
        * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.

2017-06-06  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Return correct process names from SimulatorProcess
        https://bugs.webkit.org/show_bug.cgi?id=172940

        Reviewed by Aakash Jain.

        * Scripts/webkitpy/port/darwin.py:
        (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
        (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
        (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
        * Scripts/webkitpy/port/driver.py:
        (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
        _server_process.name() will not return the correct process name for iOS.
        (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
        (Driver._read_block): Ditto.
        * Scripts/webkitpy/port/driver_unittest.py:
        (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
        process_name() instead of name().
        * Scripts/webkitpy/port/server_process.py:
        (ServerProcess._start): Use process_name() instead of name().
        (ServerProcess.stop): Ditto.
        (ServerProcess.name): Deleted.
        * Scripts/webkitpy/port/simulator_process.py:
        (SimulatorProcess.process_name): Check the provided bundle for the process name.

2017-06-06  Dean Johnson  <dean_johnson@apple.com>

        test-webkitpy: stop forking unsafely from within a spawned process
        https://bugs.webkit.org/show_bug.cgi?id=172774

        Reviewed by Darin Adler.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
        it's going to be used.
        (Builder.force_build):

2017-06-06  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Process crash-logs for iOS devices
        https://bugs.webkit.org/show_bug.cgi?id=171976
        <rdar://problem/32134551>

        Reviewed by David Kilzer.

        When running layout tests on an iOS device, crash logs should be processed.
        Implement crash log searching and parsing for iOS devices.

        * Scripts/webkitpy/common/system/crashlogs.py:
        (CrashLogs): Moved process regular expression for Darwin to class variable.
        (CrashLogs.__init__): Accept optional list of crash logs to ignore.
        (CrashLogs.find_newest_log): Add iOS as a potential platform.
        (CrashLogs.find_all_logs): Ditto.
        (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
        Do not assume that a Darwin crash log starts with the process.
        (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
        shared code for parsing Darwin crash logs.
        (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
        object so that crash logs already on the system before testing are not parsed.
        (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
        (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
        (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
        * Scripts/webkitpy/common/system/crashlogs_unittest.py:
        (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
        * Scripts/webkitpy/common/system/systemhost.py:
        (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
        systems is just the crashlog, use this behavior by default.
        * Scripts/webkitpy/common/system/systemhost_mock.py:
        (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
        systems is just the crashlog, use this behavior by default.
        * Scripts/webkitpy/port/apple.py:
        (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
        (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
        the system before testing begins
        * Scripts/webkitpy/port/base.py:
        (Port._get_crash_log): Pass optional target host when getting crash logs.
        * Scripts/webkitpy/port/darwin.py:
        (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
        CrashLogs object.
        (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
        logs to be skipped to CrashLogs object.
        * Scripts/webkitpy/port/darwin_testcase.py:
        (DarwinTest.test_get_crash_log): Removed unused local function.
        (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
        * Scripts/webkitpy/port/device.py:
        (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
        name, call it. Otherwise, assume the default behavior and read the file at the provided path.
        * Scripts/webkitpy/port/driver.py:
        (Driver._get_crash_log): Pass optional target host when getting crash logs.
        * Scripts/webkitpy/port/gtk.py:
        (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
        * Scripts/webkitpy/port/ios.py: Ditto.
        (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
        to be skipped for each host.
        * Scripts/webkitpy/port/ios_device.py:
        (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
        (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
        crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
        (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
        host is specified. Else, search all connected devices for the specified crash-log.
        (IOSDevicePort.look_for_new_crash_logs): Deleted.
        * Scripts/webkitpy/port/ios_device_unittest.py:
        (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
        (IOSDeviceTest.test_get_crash_log): Ditto.
        * Scripts/webkitpy/port/simulator_process.py:
        (SimulatorProcess.process_name): Check the provided bundle for the process name.
        * Scripts/webkitpy/port/win.py:
        (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
        logs to be skipped to CrashLogs object.
        * Scripts/webkitpy/port/wpe.py:
        (WPEPort._get_crash_log): Pass optional target host when getting crash logs.

2017-06-06  David Kilzer  <ddkilzer@apple.com>

        Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
        <https://webkit.org/b/172804>

        Reviewed by Darin Adler.

        WTF_ATTRIBUTE_PRINTF() only works outside the current
        compilation unit if it's on the declaration, not the
        implementation, of a function or class method.

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
        - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        - Remove redundant CRASH() macro definition.  Use the one from
          <wtf/Assertions.h> instead.

2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>

        Move Resource Timing / User Timing from experimental features into main preferences
        https://bugs.webkit.org/show_bug.cgi?id=172950

        Reviewed by Darin Adler.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (enableExperimentalFeatures):
        (resetWebPreferencesToConsistentValues):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (enableExperimentalFeatures):
        (resetWebPreferencesToConsistentValues):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetPreferencesToConsistentValues):
        Move out no longer experimental features to the main list.

2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [WPE] Add an install-dependencies script
        https://bugs.webkit.org/show_bug.cgi?id=172948

        Reviewed by Žan Doberšek.

        It is based on the gtk/install-dependencies script.
        Includes support for Debian based distrubutions, Fedora and Arch.
        It has been tested on a minimal Debian 9 chroot.

        * wpe/install-dependencies: Added.

2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>

        Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
        https://bugs.webkit.org/show_bug.cgi?id=172891
        <rdar://problem/32204540>

        Reviewed by Darin Adler.

        Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
        contenteditable. See WebCore ChangeLog for more details.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):

2017-06-05  Daniel Bates  <dabates@apple.com>

        webkitpy: Abstract Executive class
        https://bugs.webkit.org/show_bug.cgi?id=172928
        <rdar://problem/32569531>

        Reviewed by Ryosuke Niwa.

        Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
        This will make it straightforward to create additional derived classes that
        adhere to the same interface, say for iOS on-device testing.

        * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
        (AbstractExecutive):
        (AbstractExecutive.run_and_throw_if_fail):
        (AbstractExecutive.cpu_count):
        (AbstractExecutive.interpreter_for_script):
        (AbstractExecutive.shell_command_for_script):
        (AbstractExecutive.kill_process):
        (AbstractExecutive.check_running_pid):
        (AbstractExecutive.running_pids):
        (AbstractExecutive.wait_newest):
        (AbstractExecutive.wait_limited):
        (AbstractExecutive.interrupt):
        (AbstractExecutive.default_error_handler):
        (AbstractExecutive.ignore_error):
        (AbstractExecutive._stringify_args):
        (AbstractExecutive.command_for_printing):
        (AbstractExecutive.run_command):
        (AbstractExecutive.popen):
        (AbstractExecutive.run_in_parallel):
        * Scripts/webkitpy/common/system/executive.py:
        (Executive):
        (Executive.cpu_count):
        (Executive.running_pids):
        (Executive.kill_all):
        (Executive._compute_stdin):
        (Executive.interpreter_for_script): Deleted.
        (Executive.shell_command_for_script): Deleted.
        (Executive.wait_newest): Deleted.
        (Executive.wait_limited): Deleted.
        (Executive.default_error_handler): Deleted.
        (Executive.ignore_error): Deleted.
        (Executive.command_for_printing): Deleted.

2017-06-05  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Add iOS to platform
        https://bugs.webkit.org/show_bug.cgi?id=172931

        Reviewed by Daniel Bates.

        * Scripts/webkitpy/common/system/platforminfo.py:
        PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
        (PlatformInfo.is_ios): Added.
        (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
        * Scripts/webkitpy/common/system/platforminfo_mock.py:
        (MockPlatformInfo.is_ios): Added.

2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [WPE][JHBuild] Switch github repository from git:// to https://
        https://bugs.webkit.org/show_bug.cgi?id=172921

        Reviewed by Alex Christensen.

        * wpe/jhbuild.modules:

2017-06-05  Tim Horton  <timothy_horton@apple.com>

        ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
        https://bugs.webkit.org/show_bug.cgi?id=172887
        <rdar://problem/32546061>

        Reviewed by Sam Weinig.

        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
        (WTR::UIScriptController::applyAutocorrection):
        applyAutocorrection can call its completion handler synchronously,
        which makes UIScriptController unhappy (see bug 172884).

2017-06-03  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Add contextmanager to disable logging for a block
        https://bugs.webkit.org/show_bug.cgi?id=172876

        Reviewed by Daniel Bates.

        Add a context manager which will use an OutputCapture object to capture logging
        in a block and hold it in a variable.

        * Scripts/webkitpy/common/system/outputcapture.py:
        (OutputCaptureScope):
        (OutputCaptureScope.__init__): Construct with OutputCapture object.
        (OutputCaptureScope.__enter__): Begin capturing output. 
        (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
        output and retain the resulting log.
        * Scripts/webkitpy/common/system/outputcapture_unittest.py:
        (OutputCaptureTest.test_output_capture_scope): Added.

2017-06-02  Zalan Bujtas  <zalan@apple.com>

        Cleanup FrameView::autoSizeIfEnabled.
        https://bugs.webkit.org/show_bug.cgi?id=172889
        <rdar://problem/32550783>

        Reviewed by Tim Horton.

        * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
        (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
        (TEST):

2017-06-02  Chris Dumez  <cdumez@apple.com>

        ResourceLoadStatistics are not using unique paths during test runs
        https://bugs.webkit.org/show_bug.cgi?id=172861
        <rdar://problem/32442251>

        Reviewed by Darin Adler.

        Make sure WebKitTestRunner sets a temporary path for saving resource
        load statistics.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::generateContextConfiguration):

2017-06-02  Brady Eidson  <beidson@apple.com>

        Prevent scheme handlers from handling all built-in URL schemes.
        <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869

        Reviewed by Andy Estes.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:

2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>

        [JSCOnly] Build static jsc.exe on Windows
        https://bugs.webkit.org/show_bug.cgi?id=172833

        Reviewed by Konstantin Tokarev.

        * CMakeLists.txt:
        * Scripts/build-jsc:

2017-06-02  Zalan Bujtas  <zalan@apple.com>

        Disable ViewportSizeForViewportUnits tests on iOS.
        https://bugs.webkit.org/show_bug.cgi?id=172872

        Reviewed by Tim Horton.

        * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:

2017-06-02  Zalan Bujtas  <zalan@apple.com>

        Allow clients to override viewport size for CSS viewport units.
        https://bugs.webkit.org/show_bug.cgi?id=172838
        <rdar://problem/32523441>

        Reviewed by Tim Horton.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
        (TEST):

2017-06-02  Simon Fraser  <simon.fraser@apple.com>

        Get <chrono> out of StdLibExtras.h
        https://bugs.webkit.org/show_bug.cgi?id=172744

        Reviewed by Zalan Bujtas.

        * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

2017-06-02  Zan Dobersek  <zdobersek@igalia.com>

        [WPE] Enable SUBTLE_CRYPTO
        https://bugs.webkit.org/show_bug.cgi?id=172756

        Reviewed by Michael Catanzaro.

        * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
        * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
        * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
        exhausting entropy when running the crypto layout tests.

2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Bump GTK+ and its dependencies in jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=171918

        Reviewed by Carlos Alberto Lopez Perez.

        * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
        (WTR::initializeGtkSettings):
        * gtk/jhbuild.modules:
        * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
        * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.

2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Bump wayland and weston in jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=171921

        Reviewed by Carlos Alberto Lopez Perez.

        * gtk/jhbuild.modules:
        * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.

2017-06-01  Andy Estes  <aestes@apple.com>

        REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
        https://bugs.webkit.org/show_bug.cgi?id=172828

        Reviewed by Beth Dakin.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

2017-06-01  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Remove unneeded simulator teardown
        https://bugs.webkit.org/show_bug.cgi?id=171891

        Reviewed by Aakash Jain.

        * Scripts/webkitpy/port/ios_simulator.py:
        (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
        for communication between Python and WebKitTestRunner/DumpRenderTree.

2017-06-01  Keith Miller  <keith_miller@apple.com>

        Undo rollout in r217638 with bug fix
        https://bugs.webkit.org/show_bug.cgi?id=172824

        Unreviewed, reland patch with unused set_state code removed.

        * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
        (runThreadMessageTest):
        (TEST):

2017-06-01  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Do not send 0 or -1 as a pid to kill_process
        https://bugs.webkit.org/show_bug.cgi?id=172818

        Reviewed by Darin Adler.

        Sending a signal to process 0 will result in all processes in the group receiving 
        the signal. Sending a signal to process -1 will result in all non-system processes
        receiving the signal. Both Executive.kill_process and Executive.check_running_pid
        should consider these cases

        * Scripts/webkitpy/common/system/executive.py:
        (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
        (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
        never be running, although os.kill may succeed.
        * Scripts/webkitpy/port/simulator_process.py:
        (SimulatorProcess.stop): Do not kill process if it is undefined.

2017-05-31  Alexey Proskuryakov  <ap@apple.com>

        JSC EWS bot does not run on WTF only patches
        https://bugs.webkit.org/show_bug.cgi?id=172777
        rdar://problem/32495975

        Reviewed by Aakash Jain.

        * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
        (CheckPatchRelevance): Add a missing comma.

2017-05-31  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r217611 and r217631.
        https://bugs.webkit.org/show_bug.cgi?id=172785

        "caused wasm-hashset-many.html to become flaky." (Requested by
        keith_miller on #webkit).

        Reverted changesets:

        "Reland r216808, underlying lldb bug has been fixed."
        https://bugs.webkit.org/show_bug.cgi?id=172759
        http://trac.webkit.org/changeset/217611

        "Use dispatch queues for mach exceptions"
        https://bugs.webkit.org/show_bug.cgi?id=172775
        http://trac.webkit.org/changeset/217631

2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>

        EWS bots should reboot themselves more frequently
        https://bugs.webkit.org/show_bug.cgi?id=172402

        Reviewed by Alexey Proskuryakov.

        Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.

        * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.

2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>

        Reallocate hardware for iOS bots.
        https://bugs.webkit.org/show_bug.cgi?id=172657

        Reviewed by Alexey Proskuryakov.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2017-05-31  Andy Estes  <aestes@apple.com>

        Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
        https://bugs.webkit.org/show_bug.cgi?id=172366

        Reviewed by Daniel Bates.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>

        Unreviewed, add Jiewen Tan as a reviewer

        * Scripts/webkitpy/common/config/contributors.json:

2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>

        [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
        https://bugs.webkit.org/show_bug.cgi?id=172770

        Reviewed by Michael Catanzaro.

        * MiniBrowser/gtk/BrowserWindow.c:
        (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
        which caused the body of the if-clause to be accidentally empty.

2017-05-31  Keith Miller  <keith_miller@apple.com>

        Reland r216808, underlying lldb bug has been fixed.
        https://bugs.webkit.org/show_bug.cgi?id=172759

        Unreviewed, relanding old patch. See: rdar://problem/31183352

        * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
        (runThreadMessageTest):
        (TEST):

2017-05-31  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, rolling out r217603.

        This patch broke the internal builds.

        Reverted changeset:

        "Get <chrono> out of StdLibExtras.h"
        https://bugs.webkit.org/show_bug.cgi?id=172744
        http://trac.webkit.org/changeset/217603

2017-05-31  Brent Fulgham  <bfulgham@apple.com>

        Make ResourceLoadStatistics testing more reliable
        https://bugs.webkit.org/show_bug.cgi?id=172730
        <rdar://problem/32028373>

        Reviewed by Andy Estes.

        When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
        we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.

        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):

2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [GTK][WPE] run-javascriptcore-tests should use the jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=172757

        Reviewed by Xabier Rodriguez-Calvar.

        When needed, add the jhbuild wrapper at the beginning of the array
        that will be invoked to execute the run-jsc-stress-test or testapi
        commands.

        * Scripts/run-javascriptcore-tests:
        (runJSCStressTests):
        * Scripts/webkitdirs.pm:
        (shouldUseJhbuild):

2017-05-31  Simon Fraser  <simon.fraser@apple.com>

        Get <chrono> out of StdLibExtras.h
        https://bugs.webkit.org/show_bug.cgi?id=172744

        Reviewed by Saam Barati.

        * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

2017-05-30  Tim Horton  <timothy_horton@apple.com>

        Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
        https://bugs.webkit.org/show_bug.cgi?id=172735
        <rdar://problem/32015977>

        Reviewed by Enrica Casucci.

        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
        (WTR::UIScriptController::applyAutocorrection):
        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
        (WTR::UIScriptController::applyAutocorrection):
        * TestRunnerShared/UIScriptContext/UIScriptController.h:
        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
        (WTR::UIScriptController::applyAutocorrection):
        Expose applyAutocorrection to UIScriptController. Use a WKTesting method
        because I don't know how to tap the button in the autocorrection bar from a test.

2017-05-30  Daniel Bates  <dabates@apple.com>

        Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
        https://bugs.webkit.org/show_bug.cgi?id=172671

        Reviewed by Alex Christensen.

        We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
        For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).

        * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
        (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
        to trigger a navigation to test it.
        (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
        (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.

2017-05-30  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Start servers before setting-up for testing
        https://bugs.webkit.org/show_bug.cgi?id=172176
        <rdar://problem/32225538>

        Reviewed by Alexey Proskuryakov.

        On-device testing requires that servers are started before ports set-up their
        test environments.

        * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
        (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
        Servers are unconditionally stopped on exit.
        (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
        Manager now stops servers.
        (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
        (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.__init__): Delay construction of the test runner until we can determine
        if servers need to be started.
        (Manager.run): Determine if servers need to be started and construct the test runner.
        Shut servers down when the test run is finished.
        (Manager._run_tests): Move the determination of servers to run into Manager.run.
        * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
        (is_wpt_server_running): Server is not running if no config is found.
        * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
        (PyWebSocket.is_running): Check if this WebSocket server is running.
        * Scripts/webkitpy/port/base.py:
        (Port.__init__): Define secure WebSocket server.
        (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.

2017-05-30  Daniel Bates  <dabates@apple.com>

        [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=172603
        <rdar://problem/32471306>

        Reviewed by Brady Eidson.

        Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
        method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
        unloading is initiated for a page that registered a onbeforeunload handler.

        Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
        is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
        when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.

        Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
        for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
        as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
        registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.

        * MiniBrowser/mac/WK2BrowserWindowController.m:
        (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
        * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
        * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
        (sawDialog):
        (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
        (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
        (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):

2017-05-30  Alex Christensen  <achristensen@webkit.org>

        Update libwebrtc configuration
        https://bugs.webkit.org/show_bug.cgi?id=172727

        Reviewed by Geoffrey Garen.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>

        [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
        https://bugs.webkit.org/show_bug.cgi?id=172702

        Reviewed by Alex Christensen.

        EGL PlatformDisplay needs to be shut down before existing a
        program on Windows.

        * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
        (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
        * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
        (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.

2017-05-30  Per Arne Vollan  <pvollan@apple.com>

        [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
        https://bugs.webkit.org/show_bug.cgi?id=172709

        Reviewed by Brent Fulgham.

        Exit fullscreen mode after a fullscreen test.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

2017-05-30  Antti Koivisto  <antti@apple.com>

        ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
        https://bugs.webkit.org/show_bug.cgi?id=172713

        Reviewed by Zalan Bujtas.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):

            Remove forced display from plugin resource load delegate. It is testing some long-obsolete
            Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
            because on Mac WK1 it may get invoked from middle of a layout.

            Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.

2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        Add a WPE EWS queue
        https://bugs.webkit.org/show_bug.cgi?id=172693

        Reviewed by Carlos Garcia Campos.

        * QueueStatusServer/config/queues.py:
        * QueueStatusServer/model/queues.py: Capitalize the name of the
        port on the tooltip of the bubbles. Do the same for the GTK port.
        (Queue.display_name):
        * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
        for the GTK+ EWS also. Set for both ports as watcher the alias
        bugs-noreply@webkitgtk.org that maintainers of both ports follow.
        * Scripts/webkitpy/common/config/ports.py:
        (DeprecatedPort.port):
        (WpePort):
        (WpePort.build_webkit_command):
        (WpePort.run_webkit_tests_command):
        * Scripts/webkitpy/common/config/ports_unittest.py:
        (DeprecatedPortTest):
        (DeprecatedPortTest.test_wpe_port):
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (test_ews_name):

2017-05-29  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed. Bumping the WPEBackend-mesa dependency version.

        * wpe/jhbuild.modules: Use the latest version that uses proper GLib
        priorities for IPC communication.

2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>

        [JSC] Map and Set constructors should have fast path for cloning
        https://bugs.webkit.org/show_bug.cgi?id=172413

        Reviewed by Saam Barati.

        * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
        (TestWebKitAPI::TEST):

2017-05-27  Zalan Bujtas  <zalan@apple.com>

        enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
        https://bugs.webkit.org/show_bug.cgi?id=172676

        Reviewed by Simon Fraser.

        * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
        (TestWebKitAPI::TEST):

2017-05-26  Zalan Bujtas  <zalan@apple.com>

        TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
        https://bugs.webkit.org/show_bug.cgi?id=172674

        Reviewed by Simon Fraser.

        * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
        (TestWebKitAPI::TEST):

2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>

        Add test resources back into TestWebKitAPI Copy Resources phase

        Rubber-stamped by Beth Dakin.

        Add two files back into the Copy Resources phase after they were unintentionally
        removed in r217447 and r217496.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2017-05-26  Beth Dakin  <bdakin@apple.com>

        Media documents inside iframes should not get controls in the TouchBar unless the 
        video is playing
        https://bugs.webkit.org/show_bug.cgi?id=172620
        -and corresponding-
        rdar://problem/32165477

        Reviewed by Jon Lee.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.

2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>

        _WKUserStyleSheet and WKUserScript leak string data
        https://bugs.webkit.org/show_bug.cgi?id=172583
        <rdar://problem/32395209>

        Reviewed by Sam Weinig.

        * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
        We should not have been adopting an autoreleased object.

2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>

        [WK1] iframes in layer-backed NSViews are not cleared between successive draws
        https://bugs.webkit.org/show_bug.cgi?id=172554
        <rdar://problem/31247133>

        Reviewed by Simon Fraser.

        Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
        simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
        leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
        we should just tear down and rebuild the window whenever we need a layer-backed WebView.
        We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
        codepath.

        * DumpRenderTree/TestOptions.h:
        * DumpRenderTree/TestOptions.mm:
        (TestOptions::TestOptions):
        (TestOptions::webViewIsCompatibleWithOptions):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (shouldIgnoreWebCoreNodeLeaks):
        (allowedFontFamilySet):
        (-[DRTMockScroller rectForPart:]):
        (-[DRTMockScroller drawKnob]):
        (-[DRTMockScroller drawRect:]):
        (createWebViewAndOffscreenWindow):
        (initializeGlobalsFromCommandLineOptions):
        (prepareConsistentTestingEnvironment):
        (dumpRenderTree):
        (dumpAudio):
        (dumpHistoryItem):
        (dumpBackForwardListForWebView):
        (resetWebViewToConsistentStateBeforeTesting):
        (WebThreadLockAfterDelegateCallbacksHaveCompleted):
        (runTest):

2017-05-25  Sam Weinig  <sam@webkit.org>

        [WebIDL] Use the term 'operation' more consistently
        https://bugs.webkit.org/show_bug.cgi?id=172601

        Reviewed by Chris Dumez.

        We were using the term 'operation', a WebIDL term for function-like
        constructs, inconsistently in the code generator. Now, when we use
        'operation' when referring to the IDL concept (usually the object the
        parser produces) and 'function' when referring to code being generated.

        * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

2017-05-25  Jer Noble  <jer.noble@apple.com>

        Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.

        * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:

2017-05-25  Jer Noble  <jer.noble@apple.com>

        System sleeps while playing to wireless target, ending stream.
        https://bugs.webkit.org/show_bug.cgi?id=172541

        Reviewed by Eric Carlson.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
        * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
        (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
        (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        (TestWebKitAPI::simulateKeyDown):
        (TestWebKitAPI::hasAssertionType):
        (TestWebKitAPI::TEST):

2017-05-25  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r217423 and r217424.
        https://bugs.webkit.org/show_bug.cgi?id=172607

        These caused an api failure on all testers. (Requested by
        mlewis13 on #webkit).

        Reverted changesets:

        "REGRESSION (r216977): 4 leaks introduced in new
        WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
        https://bugs.webkit.org/show_bug.cgi?id=172558
        http://trac.webkit.org/changeset/217423

        "REGRESSION (r217423): Fix last-second typo in 'auto'"
        http://trac.webkit.org/changeset/217424

2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>

        [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
        https://bugs.webkit.org/show_bug.cgi?id=172355

        Reviewed by Chris Fleizach.

        Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
        versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
        releases which support the new platform footnote accessibility role.

        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        * gtk/jhbuild.modules:

2017-05-25  David Kilzer  <ddkilzer@apple.com>

        REGRESSION (r217423): Fix last-second typo in 'auto'

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.

2017-05-24  David Kilzer  <ddkilzer@apple.com>

        REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
        <https://webkit.org/b/172558>

        Reviewed by Sam Weinig.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.

2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>

        [CMake] Consolidate CMake code related to Cairo
        https://bugs.webkit.org/show_bug.cgi?id=172568

        Reviewed by Alex Christensen.

        * DumpRenderTree/config.h:
        * TestWebKitAPI/config.h:

2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>

        Plumb additional image metadata to item providers when beginning data interaction on an image
        https://bugs.webkit.org/show_bug.cgi?id=172536
        <rdar://problem/32371300>

        Reviewed by Beth Dakin.

        Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
        source item providers.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (checkSuggestedNameAndEstimatedSize):
        (TestWebKitAPI::TEST):

2017-05-24  Per Arne Vollan  <pvollan@apple.com>

        [Win] Create unique network storage session for each DRT.
        https://bugs.webkit.org/show_bug.cgi?id=172540

        Reviewed by Brent Fulgham.

        During layout testing, each DRT instance should have its own network storage session.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (prepareConsistentTestingEnvironment):

2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>

        Respect image UTIs when writing to item providers when beginning data interaction on an image
        https://bugs.webkit.org/show_bug.cgi?id=172436
        <rdar://problem/31786569>

        Reviewed by Beth Dakin.

        Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
        details.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
        * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.

        Create a new test page containing a GIF and a file input.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (checkTypeIdentifierIsRegisteredAtIndex):
        (TestWebKitAPI::TEST):

2017-05-23  Per Arne Vollan  <pvollan@apple.com>

        [Win] Increase test timeout for slow tests.
        https://bugs.webkit.org/show_bug.cgi?id=172449

        Reviewed by Alexey Proskuryakov.

        Instead of using a fixed timeout of 30 seconds for all tests, we should use the
        timeout member in the TestRunner class.

        * DumpRenderTree/win/TestRunnerWin.cpp:
        (TestRunner::setWaitToDump):

2017-05-15  Matt Rajca  <mrajca@apple.com>

        Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
        https://bugs.webkit.org/show_bug.cgi?id=172138

        Reviewed by Alex Christensen.

        Added API tests.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
        * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.

2017-05-23  Simon Fraser  <simon.fraser@apple.com>

        Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=172522
        rdar://problem/31071812

        Reviewed by Sam Weinig.

        Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
        We set this in the .xib file now.

        * MiniBrowser/mac/MiniBrowser_Prefix.pch:

2017-05-22  Simon Fraser  <simon.fraser@apple.com>

        Snapshotting via -renderInContext: should do synchronous image decodes
        https://bugs.webkit.org/show_bug.cgi?id=172485
        rdar://problem/32276146

        Reviewed by Tim Horton.

        New API test.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
        (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
        (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
        (TestWebKitAPI::getPixelIndex):
        (TestWebKitAPI::TEST):

2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>

        Remove dead ENABLE(FONT_LOAD_EVENTS) code
        https://bugs.webkit.org/show_bug.cgi?id=172517

        Rubber-stamped by Simon Fraser.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>

        Multiple links should be inserted separately when performing data interaction
        https://bugs.webkit.org/show_bug.cgi?id=172489
        <rdar://problem/31510832>

        Reviewed by Dan Bernstein.

        Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):

2017-05-23  Tim Horton  <timothy_horton@apple.com>

        REGRESSION: API test WebKit2.WKObject is failing
        https://bugs.webkit.org/show_bug.cgi?id=172497
        <rdar://problem/31694641>

        Reviewed by Geoff Garen.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
        (TestWebKitAPI::TEST):
        Add a test that ensures that we pretend to at least be *some* kind of
        NSString, which my first fix would not have passed.

2017-05-23  youenn fablet  <youenn@apple.com>

        There should be an easy way to run HTTP/WPT served tests on a browser
        https://bugs.webkit.org/show_bug.cgi?id=172068

        Reviewed by Sam Weinig.

        Adding a new script open-layout-test to open a layout-test in a
        browser and making sure it is served as done through run-webkit-tests.
        In case tests should be run using a server, detecting whether the
        server are running. If not, calling run-webkit-httpd to run the
        servers and open the URL in a browser.
        Otherwise, open directly the URL.

        Adding an option in run-webkit-httpd to open an URL after having
        started the servers.

        Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
        This allows running run-webkit-httpd once and not having to restart
        servers everytime a test should be served.

        Moving most of run-webkit-httpd logic in its own python file to reuse
        it in open-layout-test script.

        Adding routines to check whether HTTP and WPT servers are running.

        * Scripts/open-layout-test: Added.
        (parse_args):
        (main):
        * Scripts/run-webkit-httpd:
        (main):
        * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
        (LayoutTestFinder.find_tests):
        * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
        (LayoutTestRunner.run_tests):
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):
        * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
        (HttpServerBase._is_server_running_on_all_ports):
        (HttpServerBase):
        (HttpServerBase._is_running_on_port):
        (HttpServerBase._check_that_all_ports_are_available):
        (is_http_server_running):
        * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
        (parse_args):
        (main):
        (run_server):
        * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
        (is_wpt_server_running):
        * Scripts/webkitpy/port/base.py:
        (Port.to.is_http_server_running):
        (Port.to):
        (Port.to.is_wpt_server_running):
        (Port.to.start_web_platform_test_server):
        * Scripts/webkitpy/port/driver.py:
        (DriverProxy.is_web_platform_test):
        (DriverProxy):
        (DriverProxy.is_webkit_specific_web_platform_test):

2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>

        Add a RuntimeEnabledFeature for display: contents, defaulted to false.
        https://bugs.webkit.org/show_bug.cgi?id=171984

        Reviewed by Antti Koivisto.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (enableExperimentalFeatures):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetPreferencesToConsistentValues):

2017-05-20  Alex Christensen  <achristensen@webkit.org>

        REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
        https://bugs.webkit.org/show_bug.cgi?id=172406
        <rdar://32109532>

        Reviewed by Brady Eidson.

        * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
        (TestWebKitAPI::checkBuffer):
        (TestWebKitAPI::TEST_F):

2017-05-22  Jason Marcell  <jmarcell@apple.com>

        Do not enter Subversion-specific logic when parsing Git-based Trac data.
        https://bugs.webkit.org/show_bug.cgi?id=172433
        <rdar://problem/32234188>

        Reviewed by Alexey Proskuryakov.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
        (Trac.prototype._convertCommitInfoElementToObject):

2017-05-22  Tim Horton  <timothy_horton@apple.com>

        ExplicitSnapshotsChangeUponNavigation API test often fails
        https://bugs.webkit.org/show_bug.cgi?id=172475
        <rdar://problem/31688322>

        Reviewed by Simon Fraser.

        * TestWebKitAPI/cocoa/TestWKWebView.mm:
        (-[TestWKWebView _setUpTestWindow:]):
        Make TestWKWebView's window layer-backed. This is now the default,
        and it's also easy to accidentally write a test that depends on it
        (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
        which becomes layer backed, just like the WKWebView, but with no
        common layer-backed ancestor).

2017-05-22  youenn fablet  <youenn@apple.com>

        Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
        https://bugs.webkit.org/show_bug.cgi?id=172426

        Reviewed by Chris Dumez.

        * Scripts/webkitpy/w3c/test_importer.py:
        (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.

2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>

        Unreviewed, change my status to reviewer and fill "expertise" field

        * Scripts/webkitpy/common/config/contributors.json:

2017-05-22  Tomas Popela  <tpopela@redhat.com>

        Remove some of the EFL port leftovers
        https://bugs.webkit.org/show_bug.cgi?id=172440

        Reviewed by Carlos Garcia Campos.

        * BuildSlaveSupport/built-product-archive:
        (archiveBuiltProduct):
        (extractBuiltProduct):
        * BuildSlaveSupport/test-result-archive:
        (archiveTestResults):
        * ImageDiff/PlatformEfl.cmake: Removed.
        * Scripts/run-efl-tests: Removed.
        * Scripts/webkit-build-directory:
        * Scripts/webkitpy/common/config/contributionareas.py:
        * Scripts/webkitpy/common/config/watchlist:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):
        (_set_up_derived_options):
        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner.__init__):
        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:
        (GlobalVariablesTest.test_path_rules_specifier):
        * gtk/manifest.txt.in:
        * jhbuild/jhbuild-wrapper:

2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Do not include WPE files in GTK+ tarballs.

        * gtk/manifest.txt.in:

2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Add webkit_context_menu_item_new_from_gaction
        https://bugs.webkit.org/show_bug.cgi?id=159631

        Reviewed by Michael Catanzaro.

        Update context menu tests to check the new GAction API.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
        (testContextMenuPopulateMenu):

2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>

        [GTK] Remove Firefox user agent quirk for Google domains
        https://bugs.webkit.org/show_bug.cgi?id=171941

        Reviewed by Carlos Garcia Campos.

        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
        (TestWebKitAPI::TEST):
        (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.

2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>

        [GTK] gtkdoc-fixxref needs --module argument to work
        https://bugs.webkit.org/show_bug.cgi?id=172415

        Reviewed by Michael Catanzaro.

        * gtk/gtkdoc.py:
        (GTKDoc._run_gtkdoc_fixxref):

2017-05-20  Alexey Proskuryakov  <ap@apple.com>

        make-new-script-test should create tests that use js-test.js, not js-test-pre.js
        https://bugs.webkit.org/show_bug.cgi?id=172416

        Reviewed by Daniel Bates.

        * Scripts/make-new-script-test:

2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
        https://bugs.webkit.org/show_bug.cgi?id=172267

        Reviewed by Per Arne Vollan.

        TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
        TestWebCoreLib should link only with WebCore. And, TestWebKitLib
        should link only with WebKit.

        Unfortunately, there is a layer violation at the moment.
        WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
        in WebKit. This change contains a stub of loadResourceIntoBuffer
        in TestWebCoreLib for the workaround.

        * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
        TestWebCoreLib. Do not link WebCore to TestWebKitLib.
        * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
        (loadResourceIntoBuffer): Added a stub.

2017-05-19  Simon Fraser  <simon.fraser@apple.com>

        Fix dump-class-layout to handle different file architectures
        https://bugs.webkit.org/show_bug.cgi?id=172392

        Reviewed by Zalan Bujtas.

        Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
        and use the first architecture reported. Also add a "--architecture" argument
        to allow the user to specify an architecture.

        * Scripts/dump-class-layout:
        (import_lldb):
        (verify_type_recursive):
        (get_first_file_architecture):
        (dump_class):
        (main):
        (find_build_directory): Deleted.

2017-05-19  Jonathan Bedard  <jbedard@apple.com>

        Unreviewed infrastructure fix.

        * Scripts/webkitpy/port/ios_simulator.py:
        (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.

2017-05-19  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Use simctl boot to run multiple simulators at once
        https://bugs.webkit.org/show_bug.cgi?id=172374

        Reviewed by Alexey Proskuryakov.

        * Scripts/webkitpy/common/system/platforminfo.py:
        (PlatformInfo.xcode_version): Return the current version of Xcode.
        * Scripts/webkitpy/common/system/platforminfo_mock.py:
        (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
        * Scripts/webkitpy/port/ios_simulator.py:
        (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
        run multiple Simulator.app instances.
        (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
        versions of Xcode.
        (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
        an older version of Xcode.

2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>

        Unreviewed, fix the build on the latest internal SDK.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):

2017-05-19  Filip Pizlo  <fpizlo@apple.com>

        arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
        https://bugs.webkit.org/show_bug.cgi?id=172369

        Reviewed by Mark Lam.
        
        Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
        would be a good idea to write this down.

        * Scripts/run-jsc-stress-tests:

2017-05-19  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Layout tests which have no output will succeed
        https://bugs.webkit.org/show_bug.cgi?id=172322
        <rdar://problem/32258350>

        Reviewed by David Kilzer.

        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
        (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
        * Scripts/webkitpy/layout_tests/models/test_failures.py:
        (determine_result_type): FailureNotTested means that the test could not be loaded. This
        is classified as a MISSING failure.
        (FailureNotTested): Added.
        (FailureNotTested.message):

2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>

        Add SixSpeed benchmark to PerformanceTests
        https://bugs.webkit.org/show_bug.cgi?id=172326

        Reviewed by Sam Weinig.

        * Scripts/run-jsc-benchmarks:

2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>

        [WK1] MiniBrowser should navigate when handling a dropped URL
        https://bugs.webkit.org/show_bug.cgi?id=172350

        Reviewed by Tim Horton.

        Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.

        * MiniBrowser/mac/WK1BrowserWindowController.m:
        (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):

2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>

        REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=172077

        Reviewed by Chris Dumez.

        Fixed perftest.py by updating the lines to ignore in Speedometer.

        Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.

        * Scripts/webkitpy/performance_tests/perftest.py:
        (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
        (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (MainTest.test_collect_tests_with_index_html_and_resources): Added.

2017-05-18  Andy Estes  <aestes@apple.com>

        ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
        https://bugs.webkit.org/show_bug.cgi?id=172305

        Reviewed by Anders Carlsson.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>

        Selection around attachment elements should not persist when beginning a drag
        https://bugs.webkit.org/show_bug.cgi?id=172319
        <rdar://problem/32283008>

        Reviewed by Tim Horton.

        Tests that temporary selection around an attachment does not persist longer than it needs to.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):

2017-05-18  John Wilander  <wilander@apple.com>

        Resource Load Statistics: Grandfather domains for existing data records
        https://bugs.webkit.org/show_bug.cgi?id=172155
        <rdar://problem/24913532>

        Reviewed by Alex Christensen.

        Adds test infrastructure needed for the added functionality.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::didReceiveMessageToPage):
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::setStatisticsGrandfathered):
        (WTR::TestRunner::isStatisticsGrandfathered):
        (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
        (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
        (WTR::TestRunner::setStatisticsGrandfatheringTime):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::setStatisticsGrandfathered):
        (WTR::TestController::isStatisticsGrandfathered):
        (WTR::TestController::setStatisticsGrandfatheringTime):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

2017-05-18  Saam Barati  <sbarati@apple.com>

        WebAssembly: perform stack checks
        https://bugs.webkit.org/show_bug.cgi?id=165546
        <rdar://problem/29760307>

        Reviewed by Filip Pizlo.

        Add some new testing modes for using and not using fast TLS wasm contexts.

        * Scripts/run-jsc-stress-tests:

2017-05-18  Daniel Bates  <dabates@apple.com>

        REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
        window CSP when object-src 'none' is set
        https://bugs.webkit.org/show_bug.cgi?id=172038
        <rdar://problem/32258262>

        Reviewed by Andy Estes.

        Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
        When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):

2017-05-18  Per Arne Vollan  <pvollan@apple.com>

        [Win] Many layout tests are failing.
        https://bugs.webkit.org/show_bug.cgi?id=172286

        Reviewed by Brent Fulgham.

        Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
 
        * DumpRenderTree/win/TestRunnerWin.cpp:
        (TestRunner::grantWebNotificationPermission):
        (TestRunner::denyWebNotificationPermission):
        (TestRunner::removeAllWebNotificationPermissions):
        (TestRunner::simulateWebNotificationClick):

2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>

        [Win] Remove usage of _snprintf
        https://bugs.webkit.org/show_bug.cgi?id=172251

        Reviewed by Per Arne Vollan.

        * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
        * MiniBrowser/win/PageLoadTestClient.cpp:
        (PageLoadTestClient::dumpRunStatistics):

2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>

        Unreviewed, rolling out r217014.

        This change caused mac-wk2 LayoutTests to exit early due to
        crashes.

        Reverted changeset:

        "Resource Load Statistics: Grandfather domains for existing
        data records"
        https://bugs.webkit.org/show_bug.cgi?id=172155
        http://trac.webkit.org/changeset/217014

2017-05-17  John Wilander  <wilander@apple.com>

        Resource Load Statistics: Grandfather domains for existing data records
        https://bugs.webkit.org/show_bug.cgi?id=172155
        <rdar://problem/24913532>

        Reviewed by Alex Christensen.

        Adds test infrastructure needed for the added functionality.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::didReceiveMessageToPage):
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::setStatisticsGrandfathered):
        (WTR::TestRunner::isStatisticsGrandfathered):
        (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
        (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
        (WTR::TestRunner::setStatisticsGrandfatheringTime):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::setStatisticsGrandfathered):
        (WTR::TestController::isStatisticsGrandfathered):
        (WTR::TestController::setStatisticsGrandfatheringTime):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

2017-05-17  Alex Christensen  <achristensen@webkit.org>

        Fix ios-simulator API test after r216977
        https://bugs.webkit.org/show_bug.cgi?id=171987

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (TEST):
        <rdar://problem/32260156> covers the investigation of this, but fixing it is 
        not as urgent as having the rest of this working. Notably the ephemeral part of the
        test works, so something is just wrong with the persistent part.

2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>

        Unreviewed, rolling out r216955.

        This change caused strange behavior with web-platform-tests
        locally and on EWS.

        Reverted changeset:

        "webkitpy: Start servers before setting-up for testing"
        https://bugs.webkit.org/show_bug.cgi?id=172176
        http://trac.webkit.org/changeset/216955

2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>

        A URL type is vended for a non-URL plain text string when starting data interaction
        https://bugs.webkit.org/show_bug.cgi?id=172228
        <rdar://problem/32166729>

        Reviewed by Andy Estes.

        Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
        to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
        still vended when beginning data interaction on something that resembles a link.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

2017-05-17  David Kilzer  <ddkilzer@apple.com>

        BlobDataFileReference::generateReplacementFile() should use mkstemp()
        <https://webkit.org/b/172192>

        Reviewed by Brent Fulgham.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_language): Add check for mktemp.
        (CppChecker): Add 'security/temp_file' category.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTest.test_insecure_temp_file): Add test.

2017-05-17  Devin Rousso  <drousso@apple.com>

        Unreviewed, change my email.

        * Scripts/webkitpy/common/config/contributors.json:

2017-05-17  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, rolling out r216974.

        Revision caused consistent timeouts on all platforms.

        Reverted changeset:

        "Add a RuntimeEnabledFeature for display: contents, defaulted
        to false."
        https://bugs.webkit.org/show_bug.cgi?id=171984
        http://trac.webkit.org/changeset/216974

2017-05-17  Alex Christensen  <achristensen@webkit.org>

        Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
        https://bugs.webkit.org/show_bug.cgi?id=171987

        Reviewed by Brady Eidson.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
        (TEST):

2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>

        Add a RuntimeEnabledFeature for display: contents, defaulted to false.
        https://bugs.webkit.org/show_bug.cgi?id=171984

        Reviewed by Antti Koivisto.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (enableExperimentalFeatures):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetPreferencesToConsistentValues):

2017-05-16  Timothy Horton  <timothy_horton@apple.com>

        Fix the build

        * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
        (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

2017-05-16  Tim Horton  <timothy_horton@apple.com>

        PageVisibilityStateWithWindowChanges tests sometimes time out
        https://bugs.webkit.org/show_bug.cgi?id=172202
        <rdar://problem/29653266>

        Reviewed by Dean Jackson.

        * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
        (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
        Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.

2017-05-16  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Start servers before setting-up for testing
        https://bugs.webkit.org/show_bug.cgi?id=172176
        <rdar://problem/32225538>

        Reviewed by Alexey Proskuryakov.

        On-device testing requires that servers are started before ports set-up their
        test environments.

        * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
        (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
        (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.__init__): Delay construction of the test runner until we can determine
        if servers need to be started.
        (Manager.run): Determine if servers need to be started and construct the test runner.
        (Manager._run_tests): Move the determination of servers to run into Manager.run.

2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>

        Unreviewed, adding myself to contributors.json

        * Scripts/webkitpy/common/config/contributors.json:

2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>

        [GTK] Tests that always pass when run alone, but fail in the bots
        https://bugs.webkit.org/show_bug.cgi?id=168572

        Reviewed by Michael Catanzaro.

        PlatformWebView::viewSupportsOptions() is basically a comparison
        that checks that the passed options are the ones supported by the
        web view. There is no reason for them to be implemented for each
        platform differently. In fact doing so causes issues each time a
        new option is added, if the corresponding platform implementation
        is not updated accordingly.

        A consequence of not updating the viewSupportOptions()
        implementations when new options are added is that tests that need
        these options might fail if they are executed after a test that
        didn't need the option, as the webview will be reused even if the
        option is not supported. This cannot be spotted when running the
        tests individually. See bug #165133 for other example of the same
        problem.

        Remove the platform implementations and make the comparison a
        method of the TestOptions structure, so that the check is in one
        place. For the time being, only include in the comparison the
        options that were checked in the mac platform, which seem to be
        the only ones relevant this far (unless newer ones have also been
        forgotten).

        * WebKitTestRunner/PlatformWebView.h:
        (WTR::PlatformWebView::viewSupportsOptions): Use the method
        defined below.
        * WebKitTestRunner/TestOptions.h:
        (WTR::TestOptions::hasSameInitializationOptions): Added.
        * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
        (WTR::PlatformWebView::viewSupportsOptions): Deleted.
        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
        (WTR::PlatformWebView::viewSupportsOptions): Deleted.
        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::viewSupportsOptions): Deleted.
        * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
        (WTR::PlatformWebView::viewSupportsOptions): Deleted.

2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>

        [JSC] Build testapi in non Apple ports
        https://bugs.webkit.org/show_bug.cgi?id=172103

        Reviewed by Filip Pizlo.

        Now testapi is drived in JSCOnly, GTK and WPE ports too.

        * Scripts/build-jsc:
        * Scripts/run-javascriptcore-tests:

2017-05-15  Youenn Fablet  <youenn@apple.com>

        WPT test importer should not account for slow manual tests
        https://bugs.webkit.org/show_bug.cgi?id=172127

        Reviewed by Ryosuke Niwa.

        Making sure manual tests are not triggering updating tests-options.json file.

        * Scripts/webkitpy/w3c/test_importer.py:
        (TestImporter.find_importable_tests):
        (TestImporter._already_identified_as_resource_file):
        (TestImporter.update_tests_options):
        * Scripts/webkitpy/w3c/test_importer_unittest.py:
        (test_manual_slow_test):

2017-05-15  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
        https://bugs.webkit.org/show_bug.cgi?id=172142

        Reviewed by Tim Horton.

        * Scripts/webkitpy/xcode/simulator.py:
        (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
        around runtime identifiers.
        * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.

2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>

        Update ARES-6 plan file to use the latest version
        https://bugs.webkit.org/show_bug.cgi?id=172139

        Reviewed by Keith Miller.

        Include r216538.

        * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:

2017-05-15  Jeremy Jones  <jeremyj@apple.com>

        Disable Picture In Picture API tests on unsupported platforms.
        https://bugs.webkit.org/show_bug.cgi?id=172125
        rdar://problem/32199477

        Reviewed by Simon Fraser.

        The callbacks and allowing picture-in-picture require new SPI.

        * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:

2017-05-15  Brady Eidson  <beidson@apple.com>

        [ios-simulator] API test WKWebView.ClearAppCache is failing.
        https://bugs.webkit.org/show_bug.cgi?id=172120

        Unreviewed test gardening.

        * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
        (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
          Restoring that code fixes this.

2017-05-15  Timothy Horton  <timothy_horton@apple.com>

        Null deref under WebContentReader::readURL when interacting with a file URL
        https://bugs.webkit.org/show_bug.cgi?id=172045
        <rdar://problem/25880647>

        Reviewed by Wenson Hsieh.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):
        The text of the file URL is pasted because a textual version of it gets
        onto the pasteboard. However, this test would have crashed before. Also
        tests that we don't make an <a>.

2017-05-14  Per Arne Vollan  <pvollan@apple.com>

        [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
        https://bugs.webkit.org/show_bug.cgi?id=172071

        Reviewed by Alexey Proskuryakov.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebPreferencesToConsistentValues):

2017-05-14  Chris Dumez  <cdumez@apple.com>

        Drop PassRefPtr class from WTF
        https://bugs.webkit.org/show_bug.cgi?id=172091

        Reviewed by Alex Christensen.

        Drop API test coverage.

        * TestWebKitAPI/Tests/WTF/Ref.cpp:
        (TestWebKitAPI::TEST):
        (TestWebKitAPI::passWithPassRefPtr): Deleted.

2017-05-13  Eric Carlson  <eric.carlson@apple.com>

        [MediaStream] deviceId constraint doesn't work with getUserMedia
        https://bugs.webkit.org/show_bug.cgi?id=171877
        <rdar://problem/31899730>

        Reviewed by Jer Noble.

        The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
        implement the "checkUserMediaPermission" callback.
        * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
        (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
        (TestWebKitAPI::checkUserMediaPermissionCallback):
        (TestWebKitAPI::TEST):

        * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
        (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):

2017-05-13  Chris Dumez  <cdumez@apple.com>

        Stop using RefPtr::release()
        https://bugs.webkit.org/show_bug.cgi?id=172074

        Reviewed by Geoffrey Garen.

        * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
        (TestWebKitAPI::TEST):

2017-05-13  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r216808.
        https://bugs.webkit.org/show_bug.cgi?id=172075

        caused lldb to hang when debugging (Requested by smfr on
        #webkit).

        Reverted changeset:

        "Use Mach exceptions instead of signals where possible"
        https://bugs.webkit.org/show_bug.cgi?id=171865
        http://trac.webkit.org/changeset/216808

2017-05-12  Alex Christensen  <achristensen@webkit.org>

        Rename WKContentExtension to WKContentRuleList
        https://bugs.webkit.org/show_bug.cgi?id=172053
        <rdar://problem/32141005>

        Reviewed by Geoffrey Garen.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
        (WKContentRuleListStoreTest::SetUp):
        (TEST_F):
        (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
        (WKContentExtensionStoreTest::SetUp): Deleted.
        (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.

2017-05-12  Keith Miller  <keith_miller@apple.com>

        Use Mach exceptions instead of signals where possible
        https://bugs.webkit.org/show_bug.cgi?id=171865

        Reviewed by Mark Lam.

        * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
        (runThreadMessageTest):
        (TEST):

2017-05-12  Jeremy Jones  <jeremyj@apple.com>

        Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
        https://bugs.webkit.org/show_bug.cgi?id=172048
        rdar://problem/32163054

        Reviewed by Simon Fraser.

        Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.

        * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
        * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
        (hasVideoInPictureInPictureDidChange):
        (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
        (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
        (TestWebKitAPI::TEST):

2017-05-12  Brady Eidson  <beidson@apple.com>

        REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
        https://bugs.webkit.org/show_bug.cgi?id=172030

        Unreviewed - Test gardening

        Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
        before the test starts.

        * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
        (defaultWebsiteCacheDirectory):
        (defaultApplicationCacheDirectory):
        (TEST):
        (defaultWebsiteDataDirectory): Deleted.

2017-05-12  David Quesada  <david_quesada@apple.com>

        Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
        https://bugs.webkit.org/show_bug.cgi?id=172000
        rdar://problem/32144756

        Reviewed by Simon Fraser.

        Added API tests to verify that WKWebView provides the expected value for
        _visibleContentRect in various configurations. (i.e. not inside a scrollview,
        inside a scrollview but not clipped, clipped by an ancestor scrollview,
        clipped by the webview's _enclosingViewForExposedRectComputation)

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
        (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
        (TestWebKitAPI::TEST):

2017-05-12  Brady Eidson  <beidson@apple.com>

        REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
        https://bugs.webkit.org/show_bug.cgi?id=172030

        Unreviewed - Test gardening, in effect...

        More exploration as to why this continues to fail on the bots.
        
        This change should give us a smoking gun.
        
        * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
        (TEST):

2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>

        [GTK] Fix compile warnings in PlatformImageCairo.cpp
        https://bugs.webkit.org/show_bug.cgi?id=171850

        Reviewed by Michael Catanzaro.

        * ImageDiff/cairo/PlatformImageCairo.cpp:
        (ImageDiff::PlatformImage::createFromStdin):
        (ImageDiff::PlatformImage::writeAsPNGToStdout):

2017-05-12  Jeremy Jones  <jeremyj@apple.com>

        Add UIClient callback for when picture-in-picture is activated.
        https://bugs.webkit.org/show_bug.cgi?id=172023

        Reviewed by Simon Fraser.

        Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
        * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
        (onLoadedCompletedCallback):
        (waitUntilOnLoadIsCompleted):
        (didFinishLoadForFrame):
        (setHasVideoInPictureInPicture):
        (TestWebKitAPI::TEST):

2017-05-12  Jonathan Bedard  <jbedard@apple.com>

        Unreviewed follow-up to r216776.

        * Scripts/webkitpy/port/base.py:
        (Port.path_to_crash_logs): Raise not implemented.
        * Scripts/webkitpy/port/test.py:
        (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
        * Scripts/webkitpy/port/win.py:
        (WinPort.path_to_crash_logs): Ditto.

2017-05-12  Alexey Proskuryakov  <ap@apple.com>

        Bot watcher's dashboard shows results links twice sometimes
        https://bugs.webkit.org/show_bug.cgi?id=172043

        Reviewed by Tim Horton.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
        (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):

2017-05-12  Brady Eidson  <beidson@apple.com>

        REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
        https://bugs.webkit.org/show_bug.cgi?id=172030

        Unreviewed - Test gardening, in effect...

        This failure is only being seen by the bots.
        
        I believe this test is utterly broken in the first place; when it checks the .wal file's
        size that is not actually an indicator that the records were deleted.
        
        But that isn't what's coming up as failure on the bots.
        
        This patch is an attempt to:
        1 - More forcefully clear the Website data directory of leftovers before the test starts.
        2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.

        * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
        (defaultWebsiteDataDirectory):
        (defaultApplicationCacheDirectory):
        (TEST):

2017-05-12  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Pass directory with crash logs into CrashLogs
        https://bugs.webkit.org/show_bug.cgi?id=172033
        <rdar://problem/32157616>

        Reviewed by Daniel Bates.

        Refactor CrashLogs and the callers of CrashLogs so that the port object owns
        the location of crash logs.

        * Scripts/webkitpy/common/system/crashlogs.py:
        (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
        (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
        generating one.
        (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
        self._results_directory.
        (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
        generating one.
        (CrashLogs._log_directory_darwin): Moved to port.
        * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
        to the crash log is no longer owned by CrashLogs.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
        directory for uploading crash logs. Note that crash logs are only supported on Mac
        and Windows.
        * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
        * Scripts/webkitpy/port/base.py:
        (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
        to be in the results directory.
        * Scripts/webkitpy/port/darwin.py:
        (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
        (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
        (DarwinPort._get_crash_log): Ditto.
        * Scripts/webkitpy/port/darwin_testcase.py:
        (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
        the path to crash logs.
        * Scripts/webkitpy/port/ios_device.py:
        (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
        * Scripts/webkitpy/port/ios_device_unittest.py:
        (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
        * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
        * Scripts/webkitpy/port/mac.py: Ditto.
        * Scripts/webkitpy/port/test.py:
        (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
        * Scripts/webkitpy/port/win.py:
        (WinPort._get_crash_log): Ditto.
        * Scripts/webkitpy/tool/commands/queries.py:
        (execute): Construct a port object since this is the object which owns the path to crash logs.

2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.

        In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
        URL parameter using the default value "about:blank" when not provided.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
        (testWebViewCreateNavigationData):

2017-05-11  Youenn Fablet  <youenn@apple.com>

        Allow WPT server to serve specific WebKit test
        https://bugs.webkit.org/show_bug.cgi?id=171479

        Reviewed by Ryosuke Niwa.

        Adding a new mount point to WPT server.
        It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.

        Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.__init__):
        (Manager._is_http_test):
        (Manager._needs_web_platform_test):
        (Manager._run_tests):
        (Manager._is_web_platform_test): Deleted.
        * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
        (build_routes):
        (main):
        * Scripts/webkitpy/port/driver.py:
        (Driver):
        (Driver.is_webkit_specific_web_platform_test):
        (Driver.test_to_uri):
        (Driver._command_from_driver_input):

2017-05-11  Brady Eidson  <beidson@apple.com>

        [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
        <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994

        Reviewed by Andy Estes.
        Informal review by Maureen Daum.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
        (TEST):

2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>

        REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
        https://bugs.webkit.org/show_bug.cgi?id=171989

        Reviewed by Brian Burg.

        * lldb/lldb_webkit.py:
        (WTFStringImplProvider.get_data8):
        (WTFStringImplProvider.get_data16):
        m_data8 and m_data16 are now part of the superclass StringImplShape
        instead of directly in StringImpl. So first get the shape by getting
        index 0, and the data properties are the same offset within that.

2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>

        Remove Vibration API
        https://bugs.webkit.org/show_bug.cgi?id=171766

        Rubber-stamped by Alexey Proskuryakov.

        * Scripts/webkitperl/FeatureList.pm:

2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        Add WPE release bots
        https://bugs.webkit.org/show_bug.cgi?id=171973

        Reviewed by Žan Doberšek.

        This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
        It also adds a new WPE buildbot category.

        * BuildSlaveSupport/build.webkit.org-config/config.json:
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (InstallWpeDependencies):
        (appendCustomBuildFlags):
        (Factory.__init__):
        (loadBuilderConfig):
        * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
        * BuildSlaveSupport/build.webkit.org-config/templates/root.html:

2017-05-09  Sam Weinig  <sam@webkit.org>

        Remove support for legacy Notifications
        https://bugs.webkit.org/show_bug.cgi?id=171487

        Reviewed by Jon Lee.

        * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
        (DRTDesktopNotificationPresenter::checkNotificationPermission):
        * Scripts/webkitperl/FeatureList.pm:
        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
        Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.

2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>

        Remove user agent quirk for Slack
        https://bugs.webkit.org/show_bug.cgi?id=171869

        Reviewed by Carlos Garcia Campos.

        Remove the corresponding test.

        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
        (TestWebKitAPI::TEST):

2017-05-10  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r216578.
        https://bugs.webkit.org/show_bug.cgi?id=171920

        Broke the GTK+ build with Wayland enabled (Requested by KaL on
        #webkit).

        Reverted changeset:

        "[GTK] Bump GTK+ and its dependencies in jhbuild"
        https://bugs.webkit.org/show_bug.cgi?id=171918
        http://trac.webkit.org/changeset/216578

2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Bump GTK+ and its dependencies in jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=171918

        Reviewed by Carlos Alberto Lopez Perez.

        * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
        (WTR::initializeGtkSettings):
        * gtk/jhbuild.modules:
        * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
        * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.

2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>

        [Win] Set CMake args in build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=171436

        Reviewed by Per Arne Vollan.

        * Scripts/build-webkit:

2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>

        ImageDiff: Add CG implementation for new ImageDiff
        https://bugs.webkit.org/show_bug.cgi?id=170608

        Reviewed Alex Christensen.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
        * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
        * ImageDiff/CMakeLists.txt:
        * ImageDiff/Cairo.cmake:
        * ImageDiff/ImageDiff.cpp:
        (main):
        * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
        * ImageDiff/PlatformImage.cpp:
        * ImageDiff/PlatformImage.h:
        * ImageDiff/cairo/PlatformImageCairo.cpp:
        * ImageDiff/cg/ImageDiff.cpp: Removed.
        * ImageDiff/cg/PlatformImageCG.cpp: Added.
        (ImageDiff::PlatformImage::createFromStdin):
        (ImageDiff::PlatformImage::createFromDiffData):
        (ImageDiff::PlatformImage::PlatformImage):
        (ImageDiff::PlatformImage::~PlatformImage):
        (ImageDiff::PlatformImage::width):
        (ImageDiff::PlatformImage::height):
        (ImageDiff::PlatformImage::rowBytes):
        (ImageDiff::PlatformImage::hasAlpha):
        (ImageDiff::PlatformImage::pixels):
        (ImageDiff::PlatformImage::writeAsPNGToStdout):

2017-05-10  Zan Dobersek  <zdobersek@igalia.com>

        Enable FTL JIT by default on AArch64
        https://bugs.webkit.org/show_bug.cgi?id=144039

        Reviewed by Yusuke Suzuki.

        * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
        * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
        as an unsupported FTL platform.
        * Scripts/webkitdirs.pm:
        (isARM64): Returns 1 if the determined architecture is 'arm64'.
        * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.

2017-05-09  Jonathan Bedard  <jbedard@apple.com>

        webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
        https://bugs.webkit.org/show_bug.cgi?id=170857
        <rdar://problem/31635373>

        Reviewed by Aakash Jain.

        Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
        code to search for crash logs.

        * Scripts/webkitpy/port/darwin.py:
        (DarwinPort._get_crash_log): Moved from MacPort.
        * Scripts/webkitpy/port/darwin_testcase.py:
        (DarwinTest.test_get_crash_log): Moved from MacTest.
        * Scripts/webkitpy/port/ios_device.py:
        (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
        devices must search for crash-logs remotely.
        * Scripts/webkitpy/port/ios_simulator.py:
        (IOSSimulatorPort._get_crash_log): Deleted.
        * Scripts/webkitpy/port/ios_simulator_unittest.py:
        (IOSSimulatorTest.test_get_crash_log): Deleted.
        * Scripts/webkitpy/port/mac.py:
        (MacPort._get_crash_log): Moved to DarwinPort
        * Scripts/webkitpy/port/mac_unittest.py:
        (MacTest.test_get_crash_log): Moved to DarwinTest.

2017-05-09  Jonathan Bedard  <jbedard@apple.com>

        build ImageDiff with host SDK from Make
        https://bugs.webkit.org/show_bug.cgi?id=171835

        Reviewed by Alexey Proskuryakov.

        ImageDiff should be built for the default SDK and default architecture when
        the SDKROOT is set to either iOS device or iOS simulator. Check the
        DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.

        * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
        * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.

2017-05-09  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, adding myself to contributors.json

        * Scripts/webkitpy/common/config/contributors.json:

2017-05-09  Jonathan Bedard  <jbedard@apple.com>

        REGRESSION: ImageDiff not building with make
        https://bugs.webkit.org/show_bug.cgi?id=171788

        Reviewed by Alex Christensen.

        * Makefile: Build ImageDiff for all platforms.

2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win] ImageDiff isn't built since Bug 168945
        https://bugs.webkit.org/show_bug.cgi?id=171847

        Reviewed by Alex Christensen.

        * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
        * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
        * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.

2017-05-09  Zan Dobersek  <zdobersek@igalia.com>

        Upstream the WPE port
        https://bugs.webkit.org/show_bug.cgi?id=171110

        Reviewed by Alex Christensen.

        webkit-dev thread:
        https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

        Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
        In-file changes removed from this ChangeLog entry for brevity.

        * BuildSlaveSupport/built-product-archive:
        * BuildSlaveSupport/test-result-archive:
        * CMakeLists.txt:
        * ImageDiff/PlatformWPE.cmake: Added.
        * Scripts/build-dumprendertree:
        * Scripts/build-webkit:
        * Scripts/build-webkittestrunner:
        * Scripts/update-webkit-libs-jhbuild:
        * Scripts/update-webkitwpe-libs: Added.
        * Scripts/webkitdirs.pm:
        * Scripts/webkitperl/FeatureList.pm:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/port/factory.py:
        * Scripts/webkitpy/port/wpe.py: Added.
        * TestWebKitAPI/PlatformWPE.cmake: Added.
        * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
        * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
        * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
        * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
        * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
        * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
        * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
        * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
        * WebKitTestRunner/PlatformWPE.cmake: Added.
        * WebKitTestRunner/PlatformWebView.h:
        * WebKitTestRunner/TestController.cpp:
        * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
        * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
        * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
        * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
        * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
        * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
        * jhbuild/jhbuild-wrapper:
        * wpe/generate-inspector-gresource-manifest.py: Added.
        * wpe/jhbuild.modules: Added.
        * wpe/jhbuildrc: Added.
        * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
        * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
        * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
        * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
        * wpe/patches/glib-warning-fix.patch: Added.
        * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
        * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
        * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
        * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
        * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.

2017-05-08  Jonathan Bedard  <jbedard@apple.com>

        Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
        https://bugs.webkit.org/show_bug.cgi?id=169421
        <rdar://problem/30950171>

        Reviewed by Tim Horton.

        * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
        (createBitmapContextFromWebView): Implement for IOSurface.
        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
        (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.

2017-05-08  Jonathan Bedard  <jbedard@apple.com>

        buildbot: Cleanup simulators after running tests
        https://bugs.webkit.org/show_bug.cgi?id=171679

        Reviewed by Aakash Jain.

        simctl is partitioned for each user. Since kill-old-processes
        is run as root, we need to specify the buildbot user when tearing
        down simulators between steps.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (KillOldProcesses): Pass buildbot user to kill-old-processes.
        * BuildSlaveSupport/kill-old-processes:
        (main): Specify the user for simctl if one has been provided.

2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
        https://bugs.webkit.org/show_bug.cgi?id=171681

        Reviewed by Carlos Garcia Campos.

        * gtk/install-dependencies:

2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.

        Glib uses now Unicode quotes in error messages.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
        (testWebKitConsoleMessageNetworkError):

2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.

        Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
        should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
        characters to the input. Also fix typo in the function name.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
        (testWebViewJavaScriptDialogs):

2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>

        [GTK] Cannot sign in with new Google sign-in page
        https://bugs.webkit.org/show_bug.cgi?id=171770

        Unreviewed. This just adds a test.

        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
        (TestWebKitAPI::TEST):

2017-05-06  Simon Fraser  <simon.fraser@apple.com>

        [iOS WK2] Make rotation tests more reliable
        https://bugs.webkit.org/show_bug.cgi?id=171778

        Reviewed by Tim Horton.

        Switching between "safari-style" rotation and normal rotation left state on the WKWebView
        that would cause later viewport-sensitive tests to fail. The WKWebView would be left
        with override layout parameters, and an override orientation, and these caused viewport
        size to leak into later tests, and WebCore orientation to not get reset correctly.

        Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
        an override orientation was set, and would never re-register, causing lost orientationchanged
        events.

        Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
        from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.

        Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
        the WebProcess is caught up before proceeding with the test.

        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
        (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
        * WebKitTestRunner/ios/TestControllerIOS.mm:
        (WTR::TestController::platformResetStateToConsistentValues):
        (WTR::TestController::platformConfigureViewForTest):

2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>

        [Mac][cmake] Buildfix after r216047
        https://bugs.webkit.org/show_bug.cgi?id=171769

        Unreviewed buildfix.

        * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

2017-05-05  Brady Eidson  <beidson@apple.com>

        API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
        <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513

        Reviewed by Andy Estes.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
        (TEST):

2017-05-05  Brian Burg  <bburg@apple.com>

        [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
        https://bugs.webkit.org/show_bug.cgi?id=171748
        <rdar://problem/32027327>

        Reviewed by Michael Catanzaro.

        Remove temporary workaround now that the assertion failure is fixed.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (TEST):

2017-05-05  Simon Fraser  <simon.fraser@apple.com>

        Make it possible to test rotation in iOS WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=171755

        Reviewed by Tim Horton.

        Add to UIScriptController:
            void simulateRotation(DeviceOrientation orientation, object callback);
            void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);

        The former just does a view resize, as a simple WKWebView app would do. The second does
        animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
        layout size and interface orientation. The two behaviors produce different resize and
        orientationchange events and sizes, and both need to be tested.

        Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
        which is now a custom subclass (PlatformWebViewController).

        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
        (WTR::UIScriptController::simulateRotation):
        (WTR::UIScriptController::simulateRotationLikeSafari):
        * DumpRenderTree/mac/UIScriptControllerMac.mm:
        (WTR::UIScriptController::simulateRotation):
        (WTR::UIScriptController::simulateRotationLikeSafari):
        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
        (WTR::toDeviceOrientation):
        (WTR::UIScriptController::simulateRotation):
        (WTR::UIScriptController::simulateRotationLikeSafari):
        * TestRunnerShared/UIScriptContext/UIScriptController.h:
        * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
        * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
        (-[TestRunnerWKWebView dealloc]):
        (-[TestRunnerWKWebView _didEndRotation]):
        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
        (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
        (WTR::PlatformWebView::PlatformWebView):
        * WebKitTestRunner/ios/TestControllerIOS.mm:
        (WTR::TestController::platformResetStateToConsistentValues):
        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
        (WTR::toUIDeviceOrientation):
        (WTR::UIScriptController::simulateRotation):
        (WTR::UIScriptController::simulateRotationLikeSafari):
        (WTR::UIScriptController::platformClearAllCallbacks):
        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
        (WTR::UIScriptController::simulateRotation):
        (WTR::UIScriptController::simulateRotationLikeSafari):

2017-05-05  Jonathan Bedard  <jbedard@apple.com>

        Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=168945
        <rdar://problem/30745695>

        Reviewed by David Kilzer.

        Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
        target SDK. These two changes must happen simultaneously because some archives will
        clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.

        * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
        * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
        tools directory still includes ImageDiff.
        * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
        * Scripts/webkitpy/port/darwin.py: 
        (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
        locally or when running archives.
        * Scripts/webkitpy/port/image_diff.py:
        (IOSSimulatorImageDiffer): Deleted.
        * Scripts/webkitpy/port/ios_simulator.py:
        (IOSSimulatorPort.diff_image): Deleted.

2017-05-05  Brian Burg  <bburg@apple.com>

        API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
        https://bugs.webkit.org/show_bug.cgi?id=171748

        Unreviewed test gardening.

        The assertion failure will be investigated separately in order to avoid rolling out
        the fix for "secure" cookies. This assertion fails even without r216258 applied.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (TEST):

2017-05-05  Jonathan Bedard  <jbedard@apple.com>

        Unreviewed, rolling out r216260.

        Breaks internal iOS testers

        Reverted changeset:

        "Use ImageDiff built by host SDK and remove ImageDiff from
        DumpRenderTree"
        https://bugs.webkit.org/show_bug.cgi?id=168945
        http://trac.webkit.org/changeset/216260

2017-05-05  Jonathan Bedard  <jbedard@apple.com>

        Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=168945
        <rdar://problem/30745695>

        Reviewed by David Kilzer.

        Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
        target SDK. These two changes must happen simultaneously because some archives will
        clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.

        * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
        * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
        tools directory still includes ImageDiff.
        * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
        * Scripts/webkitpy/port/darwin.py: 
        (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
        locally or when running archives.
        * Scripts/webkitpy/port/image_diff.py:
        (IOSSimulatorImageDiffer): Deleted.
        * Scripts/webkitpy/port/ios_simulator.py:
        (IOSSimulatorPort.diff_image): Deleted.

2017-05-05  Brian Burg  <bburg@apple.com>

        [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
        https://bugs.webkit.org/show_bug.cgi?id=171700
        <rdar://problem/32017975>

        Reviewed by Brady Eidson.

        Fix a mistake in the test that should have caught this bug.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
        (TEST):
        The assertions that were meant to check round-tripping were actually checking
        the properties of the original cookie objects, not the round-tripped ones.
        This test now fails without the bugfix and passes when it is applied.

2017-05-05  Daniel Bates  <dabates@apple.com>

        Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
        https://bugs.webkit.org/show_bug.cgi?id=171698

        Reviewed by Darin Adler.

        We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
        so that we get pretty diff output when the actual string differs from the expected
        string as opposed to seeing a boolean result. The former makes makes it straightforward
        to diagnose a regression without reading the code for the test or instrumenting it to
        determine the actual string that was compared.

        * TestWebKitAPI/Tests/WTF/WTFString.cpp:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
        (TestWebKitAPI::TEST_F):
        * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
        (TestWebKitAPI::TEST_F):

2017-05-05  Chris Dumez  <cdumez@apple.com>

        Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
        https://bugs.webkit.org/show_bug.cgi?id=171624

        Reviewed by Dan Bernstein.

        Extend API test coverage to cover crashes in addition to terminations requested by the client.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
        (TestWebKitAPI::webProcessWasTerminatedByClient):
        (TestWebKitAPI::webProcessCrashed):
        (TestWebKitAPI::TEST):

2017-05-04  Mark Lam  <mark.lam@apple.com>

        DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
        https://bugs.webkit.org/show_bug.cgi?id=171716
        <rdar://problem/30878027>

        Reviewed by Saam Barati.

        setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
        does JS conversion and therefore, potentially JS allocations) and accessing
        methods of internal JS data structures (which may do JS invocation, etc).

        * DumpRenderTree/TestRunner.cpp:
        (setAudioResultCallback):

2017-05-05  Jonathan Bedard  <jbedard@apple.com>

        buildbot: Cleanup simulators after running tests
        https://bugs.webkit.org/show_bug.cgi?id=171679
        <rdar://problem/31994361>

        Reviewed by Aakash Jain.

        We shutdown the simulator process between tests, but in some cases, this is not
        sufficient. Explicitly shutdown every booted simulator.

        * BuildSlaveSupport/kill-old-processes:
        (main): Shutdown all booted simulators.

2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
        https://bugs.webkit.org/show_bug.cgi?id=171644

        Reviewed by Michael Catanzaro.

        Check that only one WebKitWebContext can have automation enabled.

        * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
        (testAutomationSessionRequestSession):

2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
        https://bugs.webkit.org/show_bug.cgi?id=171724

        Reviewed by Michael Catanzaro.

        It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.

        * WebKitTestRunner/gtk/TestControllerGtk.cpp:
        (WTR::timeoutSource):

2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix wrong assert after r215176.

        Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
        could also be RGB24 when created from a web view snapshot.

        * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
        (WTR::computeMD5HashStringForCairoSurface):

2017-05-04  Brian Burg  <bburg@apple.com>

        lldb_webkit.py should provide a type summary for WebCore::URL
        https://bugs.webkit.org/show_bug.cgi?id=171670

        Reviewed by Jer Noble.

        Just print out the underlying string using the WTFString provider.

        * lldb/lldb_webkit.py:
        (__lldb_init_module):
        (WebCoreURL_SummaryProvider):
        (WebCoreURLProvider):
        (WebCoreURLProvider.__init__):
        (WebCoreURLProvider.to_string):

2017-05-04  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r216206.
        https://bugs.webkit.org/show_bug.cgi?id=171714

        Multiple LayoutTests crashing in Document::page() (Requested
        by ap on #webkit).

        Reverted changeset:

        "Remove support for legacy Notifications"
        https://bugs.webkit.org/show_bug.cgi?id=171487
        http://trac.webkit.org/changeset/216206

2017-05-04  Mark Lam  <mark.lam@apple.com>

        API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
        https://bugs.webkit.org/show_bug.cgi?id=171702

        Reviewed by Filip Pizlo.

        The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
        changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
        confirm that the test will detect a regression.  Unfortunately, I forgot to
        change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
        This patch fixes that.

        * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
        (TestWebKitAPI::neverDestroyedString):

2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>

        Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
        https://bugs.webkit.org/show_bug.cgi?id=170195

        Unreviewed test gardening.

        * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
        (TEST):

2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>

        [Win] Remove redundant macros that are set in the CMake config
        https://bugs.webkit.org/show_bug.cgi?id=171571

        Reviewed by Brent Fulgham.

        * DumpRenderTree/config.h:
        * MiniBrowser/win/stdafx.h:
        * TestWebKitAPI/config.h:

2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>

        Add testRunner.display() to force displaying the web page for testing
        https://bugs.webkit.org/show_bug.cgi?id=171694

        Reviewed by Simon Fraser.

        Unlike testRunner.displayAndTrackRepaints(), this new function forces 
        drawing the web page but without track repaints.

        * DumpRenderTree/TestRunner.cpp:
        (displayCallback):
        (TestRunner::staticFunctions):
        * DumpRenderTree/TestRunner.h:
        * DumpRenderTree/mac/TestRunnerMac.mm:
        (TestRunner::display):
        * DumpRenderTree/win/TestRunnerWin.cpp:
        (TestRunner::display):
        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::display):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:

2017-05-04  Mark Lam  <mark.lam@apple.com>

        NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
        https://bugs.webkit.org/show_bug.cgi?id=171586
        <rdar://problem/31873190>

        Reviewed by Yusuke Suzuki.

        API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.

        * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
        (TestWebKitAPI::neverDestroyedString):
        (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
        (TestWebKitAPI::TEST):

2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>

        [WK2] Add support for keeping the selection in a focused editable element when dragging begins
        https://bugs.webkit.org/show_bug.cgi?id=171585
        <rdar://problem/31544320>

        Reviewed by Beth Dakin and Zalan Bujtas.

        Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
        a drag while editing, content is still moved (and not copied) when performing data interaction on a different
        element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
        operation rather than a copy.

        See WebCore ChangeLog for more details.

        Tests:  DataInteractionSimulator.ContentEditableToContentEditable
                DataInteractionSimulator.ContentEditableToTextarea
                DataInteractionSimulator.ContentEditableMoveParagraphs
                DataInteractionSimulator.TextAreaToInput

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/ios/DataInteractionSimulator.h:
        * TestWebKitAPI/ios/DataInteractionSimulator.mm:
        (-[DataInteractionSimulator initWithWebView:]):
        (-[DataInteractionSimulator dealloc]):
        (-[DataInteractionSimulator _advanceProgress]):
        (-[DataInteractionSimulator waitForInputSession]):
        (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
        (-[DataInteractionSimulator _webView:didStartInputSession:]):

2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>

        Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
        https://bugs.webkit.org/show_bug.cgi?id=171641

        Reviewed by Simon Fraser.

        The plan is to add back the TestRunner.display() which does the display
        only without track repaints.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/TestRunner.cpp:
        (displayAndTrackRepaintsCallback):
        (TestRunner::staticFunctions):
        (displayCallback): Deleted.
        (displayInvalidatedRegionCallback): Deleted.
        * DumpRenderTree/TestRunner.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (displayWebView):
        (displayAndTrackRepaintsWebView):
        * DumpRenderTree/mac/TestRunnerMac.mm:
        (TestRunner::displayAndTrackRepaints):
        (TestRunner::display): Deleted.
        * DumpRenderTree/win/TestRunnerWin.cpp:
        (TestRunner::displayAndTrackRepaints):
        (TestRunner::display): Deleted.
        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::displayAndTrackRepaints):
        (WTR::TestRunner::display): Deleted.
        * WebKitTestRunner/InjectedBundle/TestRunner.h:

2017-05-04  Brady Eidson  <beidson@apple.com>

        [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
        https://bugs.webkit.org/show_bug.cgi?id=171513

        Unreviewed gardening.

        * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
        (TEST): Skip the failing parts of the test on iOS for now.

2017-05-03  Jonathan Bedard  <jbedard@apple.com>

        Make ImageDiff stand-alone
        https://bugs.webkit.org/show_bug.cgi?id=168939

        Reviewed by David Kilzer.

        Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
        stand-alone project. Note that this change does not eliminate the ImageDiff inside
        the DumpRenderTree project.

        * ImageDiff/ImageDiff.xcodeproj: Added.
        * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
        * ImageDiff/Makefile: Use ImageDiff project.
        * ImageDiff/PlatformMac.cmake: Added.
        * ImageDiff/PlatformWin.cmake: Added.
        * ImageDiff/cg: Added.
        * ImageDiff/cg/Configurations: Added.
        * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
        * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
        * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
        * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
        (createImageFromStdin): Stop using RetainPtr.
        (createDifferenceImage): Ditto.
        (main): Ditto.
        * Scripts/build-imagediff: Stop building WTF and bmalloc.

2017-05-04  Sam Weinig  <sam@webkit.org>

        Remove support for legacy Notifications
        https://bugs.webkit.org/show_bug.cgi?id=171487

        Reviewed by Jon Lee.

        * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
        (DRTDesktopNotificationPresenter::checkNotificationPermission):
        * Scripts/webkitperl/FeatureList.pm:
        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
        Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.

2017-05-04  Andy Estes  <aestes@apple.com>

        Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
        https://bugs.webkit.org/show_bug.cgi?id=171673

        Reviewed by Dan Bernstein.

        * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
        (configurationWithContentFilterSettings):
        (-[LazilyLoadPlatformFrameworksController init]):
        * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
        (TEST):
        * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
        (runTestWithWidth):
        * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
        (TEST):
        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/WKWebViewConfigurationExtras.h:
        * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
        (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
        (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
        +_test_configurationWithTestPlugInClassName:

2017-05-04  Eric Carlson  <eric.carlson@apple.com>

        [MediaStream] Allow host application to enable/disable media capture
        https://bugs.webkit.org/show_bug.cgi?id=171292
        <rdar://problem/31821492>

        Reviewed by Jer Noble.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
        (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
        (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
        (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
        (MediaCaptureDisabledTest::SetUp):
        (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
        (TEST_F):
        * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.

2017-05-04  Caio Lima  <ticaiolima@gmail.com>

        Unreviewed, Adding self to contributors.json

        * Scripts/webkitpy/common/config/contributors.json: Added name.

2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>

        Fix compilation with ICU 59.1
        https://bugs.webkit.org/show_bug.cgi?id=171612

        Reviewed by Mark Lam.

        ICU 59.1 has broken source compatibility. Now it defines UChar as
        char16_t, which does not allow automatic type conversion from unsigned
        short in C++ code.

        * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
        (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):

2017-05-04  Andy Estes  <aestes@apple.com>

        [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
        https://bugs.webkit.org/show_bug.cgi?id=171646
        <rdar://problem/30306321>

        Reviewed by Tim Horton.

        * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
        (runTestWithWidth):
        (TEST):
        (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
        * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
        (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
        (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
        (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
        * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:

2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>

        [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
        https://bugs.webkit.org/show_bug.cgi?id=171649

        Reviewed by Carlos Garcia Campos.

        Add two patches picked from the upstream repository to fix building of
        the Fontconfig module in JHBuild. Additionally, this needed a patch to
        add "autogen.sh" as it is not included in release tarballs. Also:
        building the module with srcdir!=builddir prevents "fcobjshash.gperf"
        being regenerated (which is needed) so this is disabled for the
        Fontconfig module.

        * gtk/jhbuild.modules: