459f9008c05e10175b5246385610a5963cb4b6e6
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
2
3         results.webkit.org: 500 errors on API endpoints don't return JSON
4         https://bugs.webkit.org/show_bug.cgi?id=200722
5
6         Reviewed by Aakash Jain.
7
8         * resultsdbpy/resultsdbpy/controller/api_routes.py:
9         (APIRoutes.response_500): We should return the response, instead of abort.
10
11 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
12
13         results.webkit.org: Don't save configuration multiple times in upload
14         https://bugs.webkit.org/show_bug.cgi?id=200719
15
16         Reviewed by Aakash Jain.
17
18         * resultsdbpy/resultsdbpy/model/upload_context.py:
19         (UploadContext.upload_test_results): Move registering of the configuration out
20         of the branch loop.
21
22 2019-08-14  Youenn Fablet  <youenn@apple.com>
23
24         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
25         https://bugs.webkit.org/show_bug.cgi?id=200706
26
27         Reviewed by Alex Christensen.
28
29         Libwebrtc is now soft-linked so we can reenable this test.
30
31         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
32         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
33
34 2019-08-13  Sam Weinig  <weinig@apple.com>
35
36         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
37         https://bugs.webkit.org/show_bug.cgi?id=200675
38
39         Reviewed by Darin Adler.
40
41         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
42         (TestWebKitAPI::TEST):
43         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
44
45 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
46
47         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
48         https://bugs.webkit.org/show_bug.cgi?id=200456
49
50         Reviewed by Jonathan Bedard.
51
52         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
53
54         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
55
56         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
57         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
58         (pointPolygonCollisionDetect): Detact
59         (pointRightRayLineSegmentCollisionDetect):
60         (ColorBatchRender):
61         (ColorBatchRender.prototype.lazyCreateColorSeqs):
62         (ColorBatchRender.prototype.addSeq):
63         (ColorBatchRender.prototype.batchRender):
64         (ColorBatchRender.prototype.clear):
65         (xScrollStreamRenderFactory):
66         (Timeline.CanvasSeriesComponent):
67         (offscreenCachedRenderFactory): Deleted.
68
69 2019-08-13  John Wilander  <wilander@apple.com>
70
71         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
72         https://bugs.webkit.org/show_bug.cgi?id=200642
73         <rdar://problem/53962073>
74
75         Reviewed by Alex Christensen.
76
77         This patch adds test infrastructure to query whether an origin has an
78         isolated NSURLSession or not.
79
80         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
81         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
82         (WTR::TestRunner::hasStatisticsIsolatedSession):
83         * WebKitTestRunner/InjectedBundle/TestRunner.h:
84         * WebKitTestRunner/TestController.cpp:
85         (WTR::TestController::hasStatisticsIsolatedSession):
86         * WebKitTestRunner/TestController.h:
87         * WebKitTestRunner/TestInvocation.cpp:
88         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
89
90 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
91
92         Update my status in contributors.json to committer.
93
94         Reviewed by Unreviewed
95
96         * Scripts/webkitpy/common/config/contributors.json:
97
98 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
99
100         Adds WebAuthn and AppSSO into watchlist
101         https://bugs.webkit.org/show_bug.cgi?id=200647
102
103         Reviewed by Dewei Zhu.
104
105         * Scripts/webkitpy/common/config/watchlist:
106
107 2019-08-13  Chris Dumez  <cdumez@apple.com>
108
109         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
110         https://bugs.webkit.org/show_bug.cgi?id=200674
111         <rdar://problem/50692748>
112
113         Reviewed by Geoff Garen.
114
115         Add API test coverage.
116
117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
118
119 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
120
121         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
122         https://bugs.webkit.org/show_bug.cgi?id=199857
123
124         Reviewed by Yusuke Suzuki.
125
126         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
127         (TestWebKitAPI::countThreadGroups):
128         (TestWebKitAPI::TEST):
129
130 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
131
132         AX: Homebrew is not allowed to run any script under sudo.
133         https://bugs.webkit.org/show_bug.cgi?id=173801
134
135         Reviewed by Carlos Alberto Lopez Perez.
136
137         Latest versions of Homebrew throw an error when run as root.
138         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
139
140         * gtk/install-dependencies:
141
142 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
143
144         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
145         https://bugs.webkit.org/show_bug.cgi?id=200644
146
147         Reviewed by Aakash Jain.
148
149         * Scripts/webkitpy/port/simulator_process.py:
150         (SimulatorProcess._start): Define system PID after launching app.
151
152 2019-08-12  Sam Weinig  <weinig@apple.com>
153
154         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
155         https://bugs.webkit.org/show_bug.cgi?id=200614
156
157         Reviewed by Darin Adler.
158
159         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
160         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
161         
162         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
163         StringBuilder::appendSubstring(...).
164
165         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
166         (TestWebKitAPI::TEST):
167         Update for renames.
168
169 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
170
171         Fix Crash in Mail Search
172         https://bugs.webkit.org/show_bug.cgi?id=200589
173
174         Reviewed by Tim Horton.
175
176         If you search backwards first in mail, we would crash,
177         this tests that codepath.
178
179         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
180         (TEST):
181
182 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
183
184         [iPadOS] Web pages sometimes load at half width in Safari
185         https://bugs.webkit.org/show_bug.cgi?id=200624
186         <rdar://problem/52694257>
187
188         Reviewed by Simon Fraser.
189
190         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
191         web page is created using the post-animated-resize web view dimensions, rather than the original layout
192         dimensions.
193
194         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
195
196 2019-08-12  Daniel Bates  <dabates@apple.com>
197
198         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
199         https://bugs.webkit.org/show_bug.cgi?id=200548
200
201         Reviewed by Darin Adler.
202
203         Expose infrastructure to simulate a literal raw key down and a literal key up event.
204
205         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
206         * TestRunnerShared/UIScriptContext/UIScriptController.h:
207         (WTR::UIScriptController::rawKeyDown):
208         (WTR::UIScriptController::rawKeyUp):
209         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
210         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
211         (WTR::UIScriptControllerIOS::rawKeyDown):
212         (WTR::UIScriptControllerIOS::rawKeyUp):
213
214 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
215
216         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
217         https://bugs.webkit.org/show_bug.cgi?id=200584
218
219         Reviewed by Philippe Normand.
220
221         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
222         Ignore style libwebrtc optionnal 'style issue'
223
224         * Scripts/webkitpy/style/checker.py:
225         * gstreamer/jhbuild.modules:
226         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
227
228 2019-08-12  Youenn Fablet  <youenn@apple.com>
229
230         Remove IDB-specific quota
231         https://bugs.webkit.org/show_bug.cgi?id=196545
232
233         Reviewed by Alex Christensen.
234
235         * DumpRenderTree/TestRunner.cpp:
236         (TestRunner::staticFunctions):
237         (setIDBPerOriginQuotaCallback): Deleted.
238         * DumpRenderTree/TestRunner.h:
239         * DumpRenderTree/mac/DumpRenderTree.mm:
240         (runTest):
241         * DumpRenderTree/mac/TestRunnerMac.mm:
242         (TestRunner::setIDBPerOriginQuota): Deleted.
243         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
244         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
245         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
247         * WebKitTestRunner/TestController.cpp:
248         (WTR::TestController::resetStateToConsistentValues):
249         (WTR::TestController::setIDBPerOriginQuota): Deleted.
250         * WebKitTestRunner/TestController.h:
251         * WebKitTestRunner/TestInvocation.cpp:
252         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
253
254 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
255
256         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
257         https://bugs.webkit.org/show_bug.cgi?id=200621
258
259         Reviewed by Dan Bernstein.
260
261         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
262
263 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
264
265         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
266         https://bugs.webkit.org/show_bug.cgi?id=200604
267         <rdar://problem/51273130>
268
269         Reviewed by Megan Gardner.
270
271         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
272         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
273         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
274         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
275         remains the same.
276
277         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
278         the caret rect at initial scale 1.
279
280         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
281
282 2019-08-09  Ali Juma  <ajuma@chromium.org>
283
284         Don't allow cross-origin iframes to autofocus
285         https://bugs.webkit.org/show_bug.cgi?id=200515
286         <rdar://problem/54092988>
287
288         Reviewed by Ryosuke Niwa.
289
290         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
291         of cross-origin iframes, since it depends on focusing one of the
292         frames.
293
294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
295         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
296         (TestWebKitAPI::TEST):
297         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
298
299 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
300
301         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
302         https://bugs.webkit.org/show_bug.cgi?id=200591
303         <rdar://problem/54102238>
304
305         Reviewed by Ryosuke Niwa and Tim Horton.
306
307         Add a new API test to exercise -supportsImagePaste.
308
309         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/ios/UIKitSPI.h:
312
313 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
314
315         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
316         [ews-build] Set svn:ignore to various EWS Buildbot files
317         https://bugs.webkit.org/show_bug.cgi?id=200581
318
319         Reviewed by Jonathan Bedard.
320
321         * BuildSlaveSupport/ews-build: Added property svn:ignore.
322
323 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
324
325         [ews-build] Set svn:ignore to various EWS Buildbot files
326         https://bugs.webkit.org/show_bug.cgi?id=200581
327
328         Reviewed by Jonathan Bedard.
329
330         * BuildSlaveSupport/ews-build: Added property svn:ignore.
331
332 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
333
334         [ews] Add buildbot.tac to repository
335         https://bugs.webkit.org/show_bug.cgi?id=200580
336
337         Reviewed by Jonathan Bedard.
338
339         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
340
341 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
342
343         [GTK] Add missing spellchecking packages to dependencies script
344         https://bugs.webkit.org/show_bug.cgi?id=200574
345
346         Reviewed by Philippe Normand.
347
348         These are needed for the spellchecking test in WebContext API tests.
349
350         * gtk/install-dependencies:
351
352 2019-08-08  Jon Lee  <jonlee@apple.com>
353
354         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
355
356 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
357
358         webkitpy: Disable shared clipboard between Simulators
359         https://bugs.webkit.org/show_bug.cgi?id=200546
360
361         Reviewed by Aakash Jain.
362
363         * Scripts/webkitpy/xcode/simulated_device.py:
364         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
365         managed by run-webkit-tests.
366
367 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
368
369         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
370         https://bugs.webkit.org/show_bug.cgi?id=200539
371         <rdar://problem/54082550>
372
373         Reviewed by Dean Jackson.
374
375         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
376         * PlatformFTW.cmake: Added.
377
378 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
379
380         [iOS] Position image information should respect the image orientation
381         https://bugs.webkit.org/show_bug.cgi?id=200487
382
383         Reviewed by Simon Fraser.
384
385         Add an API test to verify the position image information is drawn rotated
386         because of respecting its image orientation.
387
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
390         (TestWebKitAPI::TEST):
391         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
392         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
393
394 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
395
396         [GTK] Fix WebContext languages test
397         https://bugs.webkit.org/show_bug.cgi?id=200538
398
399         Reviewed by Alex Christensen.
400
401         This test broke after the format of Accepted-Languages
402         was changed in r238236, update.
403
404         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
405         (testWebContextLanguages):
406
407 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
408
409         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
410         https://bugs.webkit.org/show_bug.cgi?id=200536
411
412         Reviewed by Carlos Alberto Lopez Perez.
413
414         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
415         (testWebsiteDataDatabases): Databases take a moment to be written,
416         wait before fetching the data as it's done in other tests.
417
418 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
419
420         results.webkit.org: Use canvas for timeline
421         https://bugs.webkit.org/show_bug.cgi?id=200172
422
423         Rubber-stamped by Aakash Jain.
424
425         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
426         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
427         (Commit.compare): Ditto.
428         (_CommitBank.commitByUuid): Ditto.
429         (_CommitBank._loadSiblings): Ditto.
430         (_CommitBank._load): Ditto.
431         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
432         (tickForCommit): Deleted.
433         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
434         which encompasses all results. Crucially, this function must exclude an UUIDs which may
435         refer to results excluded because of the limit argument.
436         (renderTimeline): Deleted.
437         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
438         with those results.
439         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
440         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
441         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
442         (inPlaceCombine): Combine result objects together.
443         (statsForSingleResult): Turn a single result into a stat object.
444         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
445         (Dot): Deleted.
446         (TimelineFromEndpoint): Renamed from Timeline.
447         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
448         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
449         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
450         cache contents.
451         (TimelineFromEndpoint.reload): Remove management of nested timelines.
452         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
453         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
454         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
455
456 2019-08-08  Brady Eidson  <beidson@apple.com>
457
458         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
459         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
460
461         Reviewed by Geoff Garen.
462
463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
464         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
465
466 2019-08-08  Rob Buis  <rbuis@igalia.com>
467
468         Add runtime flag for lazy image loading
469         https://bugs.webkit.org/show_bug.cgi?id=199794
470
471         Reviewed by Darin Adler.
472
473         Set lazyImageLoading preference as part of experimental features. Add
474         TestOption for lazy image loading.
475
476         * DumpRenderTree/TestOptions.cpp:
477         (TestOptions::TestOptions):
478         * DumpRenderTree/TestOptions.h:
479         * DumpRenderTree/mac/DumpRenderTree.mm:
480         (enableExperimentalFeatures):
481         (setWebPreferencesForTestOptions):
482         * DumpRenderTree/win/DumpRenderTree.cpp:
483         (enableExperimentalFeatures):
484
485 2019-08-08  Rob Buis  <rbuis@igalia.com>
486
487         Import lazy loading WPT tests
488         https://bugs.webkit.org/show_bug.cgi?id=199795
489
490         Reviewed by Darin Adler.
491
492         Only do loading/ exception for WebKit specific, non WPT tests.
493
494         * DumpRenderTree/mac/DumpRenderTree.mm:
495         (shouldLogFrameLoadDelegates):
496         * WebKitTestRunner/TestInvocation.cpp:
497         (WTR::TestInvocation::TestInvocation):
498
499 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
500
501         [Win][MiniBrowser] Add key accelerators for reload and close window
502         https://bugs.webkit.org/show_bug.cgi?id=200497
503
504         Reviewed by Brent Fulgham.
505
506         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
507
508         * MiniBrowser/win/MainWindow.cpp:
509         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
510         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
511         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
512
513 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
514
515         Add WHLSL and WebGPU to the watchlist file
516         https://bugs.webkit.org/show_bug.cgi?id=200509
517
518         Reviewed by Robin Morisset.
519
520         * Scripts/webkitpy/common/config/watchlist:
521
522 2019-08-07  Keith Rollin  <krollin@apple.com>
523
524         Unreviewed build fix after r248317 -- disable XCBuild because it
525         breaks incremental builds.
526
527         * Scripts/webkitdirs.pm:
528         (canUseXCBuild):
529
530 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
531
532         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
533         https://bugs.webkit.org/show_bug.cgi?id=200465
534
535         Reviewed by Alex Christensen.
536
537         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
538         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
539         finishing the test.
540         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
541         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
542
543 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
544
545         Unreviewed, a build fix after r248308
546
547         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
548
549         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
550
551 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
552
553         Unreviewed, a build fix after r248319
554
555         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
556
557         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
558         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
559         (WTR::TestController::addTestKeyToKeychain):
560         (WTR::TestController::cleanUpKeychain):
561         (WTR::TestController::keyExistsInKeychain):
562
563 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
564
565         Unreviewed, a build fix after r248308
566
567         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
568
569         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
570         (WTR::TestController::addTestKeyToKeychain):
571         (WTR::TestController::cleanUpKeychain):
572         (WTR::TestController::keyExistsInKeychain):
573
574 2019-08-06  Keith Rollin  <krollin@apple.com>
575
576         Enable XCBuild for `make` and `build-webkit` builds
577         https://bugs.webkit.org/show_bug.cgi?id=200476
578         <rdar://problem/50771065>
579
580         Reviewed by Jonathan Bedard.
581
582         All projects have now been tested under XCBuild and successfully
583         build. Enable the use of XCBuild when performing builds with `make` or
584         `build-webkit` and when using a sufficient version of Xcode. We set
585         this version to Xcode 11 since Xcode 10 -- even though it supports
586         XCBuild -- does not support a build facility needed to build WebKit
587         (Bug 197072, Bug 197116, Bug 197340).
588
589         Do not enable XCBuild in the Xcode projects themselves since these
590         projects may need to be used under older versions of Xcode and there's
591         no way to make those project changes sensitive to the version of Xcode
592         being used. This means that builds performed in the Xcode IDE will not
593         use XCBuild.
594
595         * Scripts/webkitdirs.pm:
596         (canUseXCBuild):
597
598 2019-08-06  Chris Dumez  <cdumez@apple.com>
599
600         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
601         https://bugs.webkit.org/show_bug.cgi?id=200475
602
603         Reviewed by Darin Adler.
604
605         * TestWebKitAPI/Tests/WTF/StringView.cpp:
606         (TestWebKitAPI::stringViewFromLiteral):
607         (TestWebKitAPI::stringViewFromUTF8):
608
609 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
610
611         Update my status in contributors.json to reviewer.
612
613         Regained the status after following the procedure for inactive contributors.
614         See r247136 for further explanation.
615
616         * Scripts/webkitpy/common/config/contributors.json:
617
618 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
619
620         [WebAuthN] Enable LocalAuthenticator for macOS
621         https://bugs.webkit.org/show_bug.cgi?id=182772
622         <rdar://problem/43347920>
623
624         Reviewed by Brent Fulgham.
625
626         Add an entitlement file to WebKitTestRunner such that it can access
627         the modern macOS keychain.
628
629         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
630         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
631         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
632         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
633         (WTR::TestController::addTestKeyToKeychain):
634         (WTR::TestController::cleanUpKeychain):
635         (WTR::TestController::keyExistsInKeychain):
636
637 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
638
639         [results.webkit.org Timeline] Performance improvements
640         https://bugs.webkit.org/show_bug.cgi?id=200406
641
642         Reviewed by Jonathan Bedard.
643
644         1. Unhook the scroll event when a series/axis have been removed from the container
645         2. Fix the axis's cache data structure out of sync.
646         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
647         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
648
649
650         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
651         (Signal.prototype.removeListener):
652         (prototype.stopAction): Unregsiter an action handler
653         (Ref):
654         (Ref.prototype.apply):
655         (Ref.prototype.destory):
656         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
657         (ApplyNewChildren):
658         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
659         (Timeline.CanvasSeriesComponent):
660
661 2019-08-06  Jer Noble  <jer.noble@apple.com>
662
663         Add test for behavior introduced in r248174
664         https://bugs.webkit.org/show_bug.cgi?id=200446
665
666         Reviewed by Eric Carlson.
667
668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
669         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
670         (WebKit::configureSecheuristic):
671         (WebKit::TEST):
672
673 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
674
675         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
676         https://bugs.webkit.org/show_bug.cgi?id=200464
677
678         Reviewed by Ross Kirsling.
679
680         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
681         menu, Alt-F4 to close window, and etc) don't work.
682
683         WK1 WebView doesn't have this issue because it processes key events
684         properly.
685
686         * MiniBrowser/win/WebKitBrowserWindow.cpp:
687         (WebKitBrowserWindow::WebKitBrowserWindow):
688         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
689         unhandled key events to the main window.
690         * MiniBrowser/win/WebKitBrowserWindow.h:
691
692 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
693
694         iOS 13: Overflow:hidden on body prevents PDF scroll
695         https://bugs.webkit.org/show_bug.cgi?id=200435
696         rdar://problem/53942888
697
698         Reviewed by Tim Horton.
699
700         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
701         to make sure that the scroll view is scrollable.
702
703         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
704         (TestWebKitAPI::TEST):
705
706 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
707
708         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
709         https://bugs.webkit.org/show_bug.cgi?id=200400
710
711         Reviewed by Jonathan Bedard.
712
713         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
714         (StatusBubble._build_bubble):
715         (StatusBubble._queue_position):
716
717 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
718
719         run-webkit-tests asserts when the iPhone XR simulator is running
720         https://bugs.webkit.org/show_bug.cgi?id=200404
721         <rdar://problem/53878739>
722
723         Reviewed by Dean Jackson.
724
725         Support unicode in all logging statements tied to device model.
726
727         * Scripts/webkitpy/layout_tests/controllers/manager.py:
728         (Manager.run):
729         * Scripts/webkitpy/layout_tests/views/printing.py:
730         (Printer.print_baseline_search_path):
731         * Scripts/webkitpy/port/device.py:
732         (Device.__repr__):
733         * Scripts/webkitpy/port/device_port.py:
734         (DevicePort._install):
735         (DevicePort.setup_test_run):
736         (DevicePort.clean_up_test_run):
737         (DevicePort.configuration_for_upload):
738         * Scripts/webkitpy/port/ios.py:
739         (IOSPort.default_baseline_search_path):
740         * Scripts/webkitpy/xcode/device_type.py:
741         (DeviceType.__str__):
742         * Scripts/webkitpy/xcode/simulated_device.py:
743         (SimulatedDeviceManager.populate_available_devices):
744         (SimulatedDeviceManager._find_available_name):
745         (SimulatedDeviceManager._get_device_identifier_for_type):
746         (SimulatedDeviceManager._create_or_find_device_for_request):
747         (SimulatedDeviceManager._does_fulfill_request):
748         (SimulatedDeviceManager._wait_until_device_in_state):
749         (SimulatedDeviceManager._wait_until_device_is_usable):
750         (SimulatedDeviceManager._boot_device):
751         (SimulatedDeviceManager.initialize_devices):
752         (SimulatedDeviceManager.max_supported_simulators):
753         (SimulatedDeviceManager.swap):
754         (SimulatedDevice.is_usable):
755         (SimulatedDevice._shut_down):
756         (SimulatedDevice._delete):
757         (SimulatedDevice.launch_app):
758         (SimulatedDevice.__repr__):
759
760 2019-08-04  Chris Dumez  <cdumez@apple.com>
761
762         Ping loads should not prevent page caching
763         https://bugs.webkit.org/show_bug.cgi?id=200418
764         <rdar://problem/53901632>
765
766         Reviewed by Darin Adler.
767
768         Add TestOption to enable PageCache at UIProcess-level so that we can test
769         page caching when navigating cross-origin with PSON enabled.
770
771         * WebKitTestRunner/TestController.cpp:
772         (WTR::TestController::resetPreferencesToConsistentValues):
773         (WTR::updateTestOptionsFromTestHeader):
774         * WebKitTestRunner/TestOptions.h:
775         (WTR::TestOptions::hasSameInitializationOptions const):
776
777 2019-08-02  Keith Rollin  <krollin@apple.com>
778
779         Consistently use Obj-C boolean literals
780         https://bugs.webkit.org/show_bug.cgi?id=200405
781         <rdar://problem/53880043>
782
783         Reviewed by Simon Fraser, Joseph Pecoraro.
784
785         There are places where we use equivalent but different expressions for
786         Obj-C boolean objects. For example, we use both [NSNumber
787         numberWithBool:YES] and @YES. There are places where both are used in
788         the same function, such as -[WebPreferences initialize]. The boolean
789         literal is in greater use and is more succinct, so standardize on
790         that. Also, change @(YES/NO) to @YES/NO.
791
792         * DumpRenderTree/mac/ObjCController.m:
793         (-[ObjCController objectOfClass:]):
794         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
795         (TEST):
796         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
797         (overrideAddObserverForName):
798         * TestWebKitAPI/ios/mainIOS.mm:
799         (main):
800         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
801         (TestWebKitAPI::InjectedBundleController::platformInitialize):
802         * TestWebKitAPI/mac/mainMac.mm:
803         (main):
804         * WebKitLauncher/WebKitNightlyEnabler.m:
805         (enableWebKitNightlyBehaviour):
806
807 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
808
809         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
810         https://bugs.webkit.org/show_bug.cgi?id=200402
811         <rdar://problem/53823368>
812
813         Reviewed by Tim Horton.
814
815         Make it possible to run this test using the iPad simulator.
816
817         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
818
819         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
820         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
821         since this would result in differently sized text.
822
823         (mainScreenReferenceBoundsOverride):
824         * TestWebKitAPI/ios/UIKitSPI.h:
825
826 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
827
828         API tests using permanent credentials should clear credentials left by previous tests
829         https://bugs.webkit.org/show_bug.cgi?id=199729
830
831         Reviewed by Alex Christensen.
832
833         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
834         credentials will not affect tests running after. There is a case where permanent credentials were left on the
835         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
836         failure. To prevent this from happening again, add cleanup at the begining of the tests.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
839         (TEST):
840         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
841         (TestWebKitAPI::TEST):
842
843 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
844
845         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
846         https://bugs.webkit.org/show_bug.cgi?id=200394
847         <rdar://problem/52914964>
848
849         Reviewed by Chris Fleizach.
850
851         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
852
853         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
854         (WTR::AccessibilityUIElement::isInTableCell const):
855         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
856         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
857         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
858         (WTR::AccessibilityUIElement::isInTableCell const):
859
860 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
861
862         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
863         https://bugs.webkit.org/show_bug.cgi?id=200397
864
865         Reviewed by Jonathan Bedard.
866
867         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
868
869 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
870
871         [macOS 10.15] Image dragged from Safari does not appear in Notes
872         https://bugs.webkit.org/show_bug.cgi?id=188490
873         <rdar://problem/39462717>
874
875         Reviewed by Andy Estes.
876
877         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
878
879         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
880
881 2019-08-02  Alex Christensen  <achristensen@webkit.org>
882
883         Fix API test after r248139
884         https://bugs.webkit.org/show_bug.cgi?id=200102
885
886         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
887         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
888         This was supposed to be removed as part of reverting r245322.
889
890 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
891
892         results.webkit.org: Force update cache when timeline updated
893         https://bugs.webkit.org/show_bug.cgi?id=200363
894
895         Reviewed by Jonathan Bedard.
896
897         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
898         (offscreenCachedRenderFactory): Add ability to force the redraw.
899         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
900         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
901
902 2019-08-01  Alex Christensen  <achristensen@webkit.org>
903
904         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
905         https://bugs.webkit.org/show_bug.cgi?id=200360
906
907         Reviewed by Tim Horton.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
910         (cleanupITPDatabase):
911         (TEST):
912
913 2019-08-01  Alex Christensen  <achristensen@webkit.org>
914
915         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
916         https://bugs.webkit.org/show_bug.cgi?id=200102
917         <rdar://problem/53275114>
918
919         Reviewed by Darin Adler.
920
921         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
922         and because clicking on a TestWKWebView only works on Mac.
923
924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
925         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
926         (-[UploadDelegate initWithDirectory:]):
927         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
928         (-[UploadDelegate sentDirectory]):
929         (TEST):
930         * TestWebKitAPI/cocoa/TestWKWebView.h:
931         * TestWebKitAPI/cocoa/TestWKWebView.mm:
932         (-[TestWKWebView sendClickAtPoint:]):
933
934 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
935
936         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
937         https://bugs.webkit.org/show_bug.cgi?id=200321
938
939         Reviewed by Jonathan Bedard.
940
941         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
942         Let the axis' height be defined in the option. Timeine component will use this value as
943         padding-top for headers which allows headers start in the right position, even with multiple
944         top axises.
945         (Timeline.CanvasSeriesComponent):
946         (prototype.Timeline.CanvasContainer):
947
948 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
949
950         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
951         https://bugs.webkit.org/show_bug.cgi?id=200347
952
953         Reviewed by Jonathan Bedard.
954
955         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
956         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
957
958 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
959
960         Improve flakiness of SOAuthorizationRedirect tests
961         https://bugs.webkit.org/show_bug.cgi?id=200320
962         <rdar://problem/53767057>
963
964         Reviewed by Alex Christensen.
965
966         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
967         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
968         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
969         is executed.
970
971         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
972         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
973         (resetState):
974         (TestWebKitAPI::TEST):
975
976 2019-08-01  Keith Rollin  <krollin@apple.com>
977
978         Update TestWebKitAPI for XCBuild
979         https://bugs.webkit.org/show_bug.cgi?id=200311
980         <rdar://problem/53773804>
981
982         Reviewed by Alex Christensen.
983
984         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
985         technique. Now update WebKitLegacy to build under XCBuild after those
986         changes. This work involves adding an "Apply Configuration to
987         XCFileLists" build target, adding a check-xcfilelists.sh script,
988         adding a "Check xcfilelists" build phase that calls that script,
989         adding knowledge of the project to the generate-xcfilelists script,
990         creating new .xcfilelist files, and adding those to the project.
991
992         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
993         (Application.__init__):
994         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
995         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
996         (TestWebKitAPIGenerator):
997         (TestWebKitAPIGenerator._get_project_file_path):
998         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
999         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
1002
1003 2019-08-01  Youenn Fablet  <youenn@apple.com>
1004
1005         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
1006         https://bugs.webkit.org/show_bug.cgi?id=200317
1007
1008         Reviewed by Eric Carlson.
1009
1010         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1013         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
1014         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1015         (TestWebKitAPI::TEST):
1016
1017 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
1018
1019         New EWS: Cannot see build status page when patch is waiting for tester
1020         https://bugs.webkit.org/show_bug.cgi?id=200333
1021
1022         Reviewed by Jonathan Bedard.
1023
1024         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1025         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
1026
1027 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1028
1029         [SOUP] Switch to use libsoup WebSockets API
1030         https://bugs.webkit.org/show_bug.cgi?id=200162
1031
1032         Reviewed by Michael Catanzaro.
1033
1034         Update libsoup version to 2.67.90.
1035
1036         * gtk/jhbuild.modules:
1037         * wpe/jhbuild.modules:
1038
1039 2019-07-31  Andy Estes  <aestes@apple.com>
1040
1041         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
1042         https://bugs.webkit.org/show_bug.cgi?id=200293
1043         <rdar://problem/52937749>
1044
1045         Reviewed by Alex Christensen.
1046
1047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
1049         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1050         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1051         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
1052         (TEST):
1053
1054 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
1055
1056         [ews-build] Enable all macOS queues on new EWS
1057         https://bugs.webkit.org/show_bug.cgi?id=199944
1058
1059         Reviewed by Jonathan Bedard.
1060
1061         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
1062         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1063         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
1064         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
1066         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
1067
1068 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1069
1070         Unreviewed test gardening, disable failing test for rdar://51752593.
1071
1072         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1073
1074 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
1075
1076         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
1077         https://bugs.webkit.org/show_bug.cgi?id=200318
1078
1079         Reviewed by Aakash Jain.
1080
1081         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1082         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
1083         (Timeline.CanvasXAxisComponent): Use getLabel function.
1084
1085 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
1086
1087         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
1088         https://bugs.webkit.org/show_bug.cgi?id=200306
1089
1090         Reviewed by Michael Catanzaro.
1091
1092         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
1093         jsc-glib-4.0-scan for example).
1094
1095         * Scripts/webkitdirs.pm:
1096         (generateBuildSystemFromCMakeProject):
1097
1098 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1099
1100         Unreviewed test gardening, disable failing test for rdar://52355829.
1101
1102         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1103         (TEST):
1104
1105 2019-07-31  Keith Rollin  <krollin@apple.com>
1106
1107         Update WebKitLegacy for XCBuild
1108         https://bugs.webkit.org/show_bug.cgi?id=200310
1109         <rdar://problem/53773708>
1110
1111         Reviewed by Alex Christensen.
1112
1113         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
1114         technique. Now update WebKitLegacy to build under XCBuild after those
1115         changes. This work involves adding an "Apply Configuration to
1116         XCFileLists" build target, adding a check-xcfilelists.sh script,
1117         adding a "Check xcfilelists" build phase that calls that script,
1118         adding knowledge of the project to the generate-xcfilelists script,
1119         creating new .xcfilelist files, and adding those to the project.
1120
1121         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1122         (Application.__init__):
1123         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1124         (JavaScriptCoreGenerator):
1125         (WebCoreGenerator):
1126         (WebKitGenerator):
1127         (WebKitGenerator._get_generate_unified_sources_script):
1128         (WebKitLegacyGenerator):
1129         (WebKitLegacyGenerator._get_project_file_path):
1130         (WebKitLegacyGenerator._get_generate_unified_sources_script):
1131
1132 2019-07-31  Chris Dumez  <cdumez@apple.com>
1133
1134         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1135         https://bugs.webkit.org/show_bug.cgi?id=200086
1136         <rdar://problem/53501721>
1137
1138         Reviewed by Alex Christensen.
1139
1140         re-enable the API test.
1141
1142         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1143         (TEST):
1144
1145 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1146
1147         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
1148         https://bugs.webkit.org/show_bug.cgi?id=200291
1149         <rdar://problem/53717946>
1150
1151         Reviewed by Megan Gardner.
1152
1153         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
1154         after closing the web view, while the web view's content view isn't the first responder.
1155
1156         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
1157         * TestWebKitAPI/ios/UIKitSPI.h:
1158
1159 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1160
1161         [GTK] Datalist element support for TextFieldInputType
1162         https://bugs.webkit.org/show_bug.cgi?id=98934
1163
1164         Reviewed by Michael Catanzaro.
1165
1166         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
1167
1168         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1169         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
1170         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
1171
1172 2019-07-30  Tim Horton  <timothy_horton@apple.com>
1173
1174         Remove some needless comments that snuck into the tree
1175
1176         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1177         (WTR::UIScriptController::setHardwareKeyboardAttached):
1178         (WTR::UIScriptController::playBackEventStream):
1179
1180 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1181
1182         [WebKit] Add PageLoadState::Observer C API
1183         https://bugs.webkit.org/show_bug.cgi?id=199848
1184
1185         Reviewed by Alex Christensen.
1186
1187         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1188         (WebKitBrowserWindow::WebKitBrowserWindow):
1189         (WebKitBrowserWindow::didChangeTitle):
1190         (WebKitBrowserWindow::didFinishNavigation): Deleted.
1191         * MiniBrowser/win/WebKitBrowserWindow.h:
1192         * TestWebKitAPI/CMakeLists.txt:
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1195         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1196         (TestWebKitAPI::didChangeActiveURL):
1197         (TestWebKitAPI::didChangeCanGoBack):
1198         (TestWebKitAPI::didChangeCanGoForward):
1199         (TestWebKitAPI::didChangeCertificateInfo):
1200         (TestWebKitAPI::didChangeEstimatedProgress):
1201         (TestWebKitAPI::didChangeHasOnlySecureContent):
1202         (TestWebKitAPI::didChangeIsLoading):
1203         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1204         (TestWebKitAPI::didChangeTitle):
1205         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1206         (TestWebKitAPI::didSwapWebProcesses):
1207         (TestWebKitAPI::willChangeActiveURL):
1208         (TestWebKitAPI::willChangeCanGoBack):
1209         (TestWebKitAPI::willChangeCanGoForward):
1210         (TestWebKitAPI::willChangeCertificateInfo):
1211         (TestWebKitAPI::willChangeEstimatedProgress):
1212         (TestWebKitAPI::willChangeHasOnlySecureContent):
1213         (TestWebKitAPI::willChangeIsLoading):
1214         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1215         (TestWebKitAPI::willChangeTitle):
1216         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1217         (TestWebKitAPI::didFinishNavigation):
1218         (TestWebKitAPI::TEST):
1219
1220 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1221
1222         DumpRenderTree.app: Add CFBundleShortVersionString
1223         https://bugs.webkit.org/show_bug.cgi?id=200269
1224         <rdar://problem/53412596>
1225
1226         Rubber-stamped by Aakash Jain.
1227
1228         * DumpRenderTree/ios/Info.plist:
1229
1230 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1231
1232         Add layout test coverage for <https://webkit.org/b/200215>
1233         https://bugs.webkit.org/show_bug.cgi?id=200245
1234         <rdar://problem/52976965>
1235
1236         Reviewed by Tim Horton.
1237
1238         Add new testing infrastructure. See below for more details.
1239
1240         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1241         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1242         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1243         (WTR::UIScriptController::setWillCreateNewPageCallback):
1244         (WTR::UIScriptController::willCreateNewPageCallback const):
1245
1246         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1247         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1248
1249         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1250         (WTR::UIScriptController::becomeFirstResponder):
1251
1252         Add and implement a Cocoa platform hook to make the web view first responder.
1253
1254         * WebKitTestRunner/TestController.cpp:
1255         (WTR::TestController::createOtherPage):
1256         * WebKitTestRunner/TestInvocation.cpp:
1257         (WTR::TestInvocation::willCreateNewPage):
1258         * WebKitTestRunner/TestInvocation.h:
1259         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1260         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1261         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1262
1263 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1264
1265         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1266         https://bugs.webkit.org/show_bug.cgi?id=200217
1267
1268         Reviewed by Alex Christensen.
1269
1270         * MiniBrowser/win/BrowserWindow.h:
1271         * MiniBrowser/win/MainWindow.cpp:
1272         (MainWindow::init):
1273         (MainWindow::resizeSubViews):
1274         (MainWindow::WndProc):
1275         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
1276         * MiniBrowser/win/MiniBrowserLib.rc:
1277         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
1278         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1279         (WebKitBrowserWindow::reload):
1280         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
1281         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1282         (WebKitLegacyBrowserWindow::reload):
1283         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1284
1285 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1286
1287         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
1288         https://bugs.webkit.org/show_bug.cgi?id=200218
1289
1290         Reviewed by Alex Christensen.
1291
1292         Moved the scheme supplementing logic from
1293         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
1294
1295         * MiniBrowser/win/MainWindow.cpp:
1296         (MainWindow::loadURL):
1297         (MainWindow::onURLBarEnter):
1298         * MiniBrowser/win/MainWindow.h:
1299         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1300         (WebKitLegacyBrowserWindow::loadURL):
1301
1302 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
1303
1304         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1305         https://bugs.webkit.org/show_bug.cgi?id=200254
1306
1307         Unreviewed infrastructure fix.
1308
1309         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
1310
1311 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
1312
1313         [Canvas Timeline] Compact canvas timeline
1314         https://bugs.webkit.org/show_bug.cgi?id=200177
1315
1316         Reviewed by Jonathan Bedard.
1317
1318         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1319         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1320         (Timeline.CanvasSeriesComponent):
1321
1322 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1323
1324         Multiple context menu actions broken for YouTube videos
1325         https://bugs.webkit.org/show_bug.cgi?id=199999
1326
1327         Reviewed by Eric Carlson.
1328
1329         Add a test case to check copy link address, open in new window and download options are not included in the
1330         context menu for non-downloadable media.
1331
1332         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1333         (writeNextChunk):
1334         (serverCallback):
1335         (testContextMenuLiveStream):
1336         (beforeAll):
1337         (afterAll):
1338
1339 2019-07-28  Tim Horton  <timothy_horton@apple.com>
1340
1341         Reorganize UIScriptController into platform-specific subclasses
1342         https://bugs.webkit.org/show_bug.cgi?id=200027
1343
1344         Reviewed by Simon Fraser.
1345
1346         Instead of a mishmash of #ifdefs and extraneous empty functions,
1347         reorganize UIScriptController so that we have a base class
1348         with functions that assert if called (to make it harder to
1349         accidentally write a test that depends on unimplemented
1350         functionality), and override them in platform specific subclasses
1351         as functionality is added.
1352
1353         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1354         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
1355         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1356         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
1357         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1358         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1359         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1360         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1361         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
1362         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
1363         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1364         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
1365         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
1366         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1367         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
1368         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1369
1370 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1371
1372         [Win][MiniBrowser] Remove PageLoadTestClient
1373         https://bugs.webkit.org/show_bug.cgi?id=200155
1374
1375         Reviewed by Brent Fulgham.
1376
1377         It is not used nowadays.
1378
1379         * MiniBrowser/win/CMakeLists.txt:
1380         * MiniBrowser/win/Common.cpp:
1381         (parseCommandLine):
1382         * MiniBrowser/win/Common.h:
1383         * MiniBrowser/win/MainWindow.cpp:
1384         (MainWindow::init):
1385         * MiniBrowser/win/MainWindow.h:
1386         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1387         (MiniBrowserWebHost::updateAddressBar):
1388         (MiniBrowserWebHost::didFinishLoadForFrame):
1389         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
1390         (MiniBrowserWebHost::didFailLoadWithError):
1391         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
1392         (MiniBrowserWebHost::didFirstLayoutInFrame):
1393         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
1394         * MiniBrowser/win/PageLoadTestClient.h: Removed.
1395         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1396         (ResourceLoadDelegate::identifierForInitialRequest):
1397         (ResourceLoadDelegate::willSendRequest):
1398         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1399         (ResourceLoadDelegate::didFailLoadingWithError):
1400         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1401         (WebKitBrowserWindow::create):
1402         (WebKitBrowserWindow::createNewPage):
1403         * MiniBrowser/win/WebKitBrowserWindow.h:
1404         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1405         (WebKitLegacyBrowserWindow::create):
1406         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1407         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
1408         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1409         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
1410         * MiniBrowser/win/WinMain.cpp:
1411         (wWinMain):
1412
1413 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1414
1415         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
1416         https://bugs.webkit.org/show_bug.cgi?id=200150
1417         <rdar://problem/53280170>
1418
1419         Reviewed by Brent Fulgham.
1420
1421         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1422         (TestWebKitAPI::TEST):
1423
1424 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1425
1426         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
1427         https://bugs.webkit.org/show_bug.cgi?id=200090
1428
1429         Unreviewed follow-up fix.
1430
1431         * resultsdbpy/resultsdbpy/view/view_routes.py:
1432         (ViewRoutes.__init__): Keep /search endpoint for existing links
1433
1434 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1435
1436         results.webkit.org: Add switch to filter results by expectation
1437         https://bugs.webkit.org/show_bug.cgi?id=200134
1438
1439         Rubber-stamped by Aakash Jain.
1440
1441         Users of the results database should be able to easily differentiate tests which are expected
1442         to fail verse tests which are unexpectedly failing.
1443
1444         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1445         (Timeline.render): Respect the willFilterExpected variable.
1446         (LegendLabel): Generates html for label in the legend.
1447         (Legend): Add switch for filter results.
1448         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
1449         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1450
1451 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
1452
1453         [ews-build] Use update-webkit script in Style EWS
1454         https://bugs.webkit.org/show_bug.cgi?id=193196
1455
1456         Reviewed by Jonathan Bedard.
1457
1458         * BuildSlaveSupport/ews-build/factories.py:
1459         (StyleFactory): Updated to use CheckOutSource step as well.
1460         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
1461         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1462
1463 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1464
1465         results.webkit.org: Support buildbot 0.8 CI links
1466         https://bugs.webkit.org/show_bug.cgi?id=200146
1467
1468         Reviewed by Aakash Jain.
1469
1470         * resultsdbpy/resultsdbpy/model/ci_context.py:
1471         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
1472         (BuildbotEightURLFactory.__init__):
1473         (BuildbotEightURLFactory.url):
1474         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
1475         (URLFactoryTest.test_old_builder_url):
1476         (URLFactoryTest):
1477         (URLFactoryTest.test_old_worker_url):
1478
1479 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1480
1481         results.webkit.org: Suite results shouldn't be the landing page
1482         https://bugs.webkit.org/show_bug.cgi?id=200090
1483
1484         Reviewed by Aakash Jain.
1485
1486         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
1487         * resultsdbpy/resultsdbpy/view/view_routes.py:
1488         (ViewRoutes.__init__): Make search the landing page instead of suite results.
1489         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1490         (WebSiteUnittest.test_main):
1491
1492 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1493
1494         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
1495         https://bugs.webkit.org/show_bug.cgi?id=200127
1496
1497         Unreviewed follow-up fix.
1498
1499         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1500         (Dot.toString): Use self instead of this in render callback.
1501
1502 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
1503
1504         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
1505         https://bugs.webkit.org/show_bug.cgi?id=200108
1506         <rdar://problem/53521238>
1507
1508         Reviewed by Chris Dumez.
1509
1510         Added an API test.
1511
1512         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1513         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1514         (TEST):
1515
1516 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
1517
1518         results.webkit.org: Color should be the worst result, count should include all results
1519         https://bugs.webkit.org/show_bug.cgi?id=200127
1520
1521         Rubber-stamped by Aakash Jain.
1522
1523         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1524         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
1525
1526 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
1527
1528         [Timeline]: Make timeline header width automatic, instead of fixed width
1529         https://bugs.webkit.org/show_bug.cgi?id=200059
1530
1531         Reviewed by Jonathan Bedard.
1532
1533         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1534         (.dot.crash):
1535         (.timeline>.header): Deleted.
1536         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1537         (.timeline>.content):
1538         (.timeline>.header):
1539
1540 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
1541
1542         [ESNext] Implement nullish coalescing
1543         https://bugs.webkit.org/show_bug.cgi?id=200072
1544
1545         Reviewed by Darin Adler.
1546
1547         * Scripts/run-jsc-stress-tests:
1548
1549 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1550
1551         Add Takashi Komori and Tomoki Imai as contributors
1552
1553         Unreviewed.
1554
1555         * Scripts/webkitpy/common/config/contributors.json:
1556
1557 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
1558
1559         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
1560         https://bugs.webkit.org/show_bug.cgi?id=200103
1561
1562         Reviewed by Mark Lam.
1563
1564         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
1565         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
1566
1567         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
1568         to the future implementation changes while it catches the severe issues we had.
1569
1570         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1571         (assertEmptyPointerSet):
1572         (assertHasOnlyObjects):
1573         (assertClean):
1574         (TEST):
1575         (allocateAndDeallocate):
1576
1577 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1578
1579         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
1580         https://bugs.webkit.org/show_bug.cgi?id=200074
1581
1582         Reviewed by Michael Catanzaro.
1583
1584         There was a latent issue. PluginTest::indicateTestFailure was
1585         using WTF::sleep without linking WTF.
1586
1587         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1588         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
1589
1590 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1591
1592         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
1593         https://bugs.webkit.org/show_bug.cgi?id=200073
1594
1595         Reviewed by Michael Catanzaro.
1596
1597         * TestWebKitAPI/PlatformGTK.cmake:
1598         * TestWebKitAPI/PlatformWPE.cmake:
1599         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
1600
1601 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1602
1603         [webkitperl] runCommand doesn't work in Windows Perl
1604         https://bugs.webkit.org/show_bug.cgi?id=199900
1605
1606         Reviewed by Don Olmstead.
1607
1608         runCommand was always failing implicit fork by using 'open' with
1609         '-|' in Windows Perl. Explicitly specify the command to 'open' not
1610         to do the implicit fork.
1611
1612         There is one more difference between Windows and Unix. 'open'
1613         successes on Windows even for non existent command while it fails
1614         on Unix. So, return the same error code on Unix as well as
1615         Windows.
1616
1617         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1618         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1619         command is not available on Windows. Use Perl ($^X) instead.
1620
1621 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1622
1623         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1624         https://bugs.webkit.org/show_bug.cgi?id=199326
1625         rdar://problem/42816957
1626
1627         Reviewed by Wenson Hsieh.
1628
1629         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1630         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1631         is being properly populated with additional context dictionary.
1632
1633         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1634         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1635         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1636         which will populate the additional autofill context dictionary.
1637
1638         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1639         populates the additional autofill context dictionary.
1640
1641         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1642         context dictionary.
1643
1644         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
1645         input field requires strong password work.
1646
1647         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1648         input field requires strong password work.
1649
1650         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1651         password work.
1652
1653 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1654
1655         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1656         https://bugs.webkit.org/show_bug.cgi?id=199489
1657
1658         Reviewed by Aakash Jain.
1659
1660         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1661         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1662         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1663         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1664         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1665         (runTest): Record test binary failure
1666         (reportTestFailures): Report test binary failure
1667         (runJSCStressTests):
1668         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1669         (JscOnlyPort.build_jsc_command):
1670         (JscOnlyPort):
1671         (JscOnlyPort.run_javascriptcore_tests_command):
1672         * Scripts/webkitpy/common/config/ports_unittest.py:
1673         (DeprecatedPortTest.test_jsconly_port):
1674
1675 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1676
1677         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1678         https://bugs.webkit.org/show_bug.cgi?id=200079
1679         <rdar://problem/53474325>
1680
1681         Reviewed by Wenson Hsieh.
1682
1683         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1684
1685         * WebKitTestRunner/ios/TestControllerIOS.mm:
1686         (WTR::TestController::platformResetPreferencesToConsistentValues):
1687
1688 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1689
1690         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1691         https://bugs.webkit.org/show_bug.cgi?id=199927
1692
1693         Reviewed by Alex Christensen.
1694
1695         convertAbsolutepathToWebKitPath was failing to convert paths on
1696         Windows Perl due to path separators mismatch.
1697
1698         Renamed convertAbsolutepathToWebKitPath to
1699         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1700         paths to relative Unix paths.
1701
1702         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1703         (convertAbsolutePathToRelativeUnixPath): Added.
1704         (convertAbsolutepathToWebKitPath): Deleted.
1705
1706 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1707
1708         Fix iOS API test after r247759
1709         https://bugs.webkit.org/show_bug.cgi?id=200045
1710
1711         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1712         (TEST):
1713         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
1714         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
1715
1716 2019-07-23  Keith Rollin  <krollin@apple.com>
1717
1718         Remove rest of NavigatorContentUtils support
1719         https://bugs.webkit.org/show_bug.cgi?id=200052
1720         <rdar://problem/53467357>
1721
1722         Reviewed by Alex Christensen.
1723
1724         Bug 196070 removes most of the support for the never-used
1725         NavigatorContentUtils facility. However, there were still a couple of
1726         left-over references after that change. This patch sweeps those up.
1727
1728         * Scripts/webkitperl/FeatureList.pm:
1729
1730 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1731
1732         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1733         https://bugs.webkit.org/show_bug.cgi?id=200045
1734
1735         Reviewed by Mark Lam.
1736
1737         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1738         (TEST):
1739
1740 2019-07-23  Russell Epstein  <repstein@apple.com>
1741
1742         Unreviewed, rolling out r247745.
1743
1744         This broke API test
1745         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
1746         indicated by EWS
1747
1748         Reverted changeset:
1749
1750         "Move javaScriptConfigurationDirectory SPI from
1751         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
1752         runtime switchable"
1753         https://bugs.webkit.org/show_bug.cgi?id=200045
1754         https://trac.webkit.org/changeset/247745
1755
1756 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1757
1758         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1759         https://bugs.webkit.org/show_bug.cgi?id=200045
1760
1761         Reviewed by Mark Lam.
1762
1763         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1764         (TEST):
1765
1766 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1767
1768         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
1769         https://bugs.webkit.org/show_bug.cgi?id=199972
1770
1771         Reviewed by Jer Noble.
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1774         (TEST):
1775
1776 2019-07-23  Alicia Boya García  <aboya@igalia.com>
1777
1778         [WTF] Add DataMutex and MainThreadData wrappers
1779         https://bugs.webkit.org/show_bug.cgi?id=199831
1780
1781         Reviewed by Alex Christensen.
1782
1783         Added a very simple test that checks that DataMutex<T> indeed takes
1784         the lock and indeed holds data.
1785
1786         * TestWebKitAPI/CMakeLists.txt:
1787         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
1788         (TestWebKitAPI::TEST):
1789
1790 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1791
1792         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
1793         https://bugs.webkit.org/show_bug.cgi?id=200021
1794         <rdar://problem/53301325>
1795
1796         Reviewed by Ryosuke Niwa.
1797
1798         Add support for grabbing the child menu items of a context menu item.
1799
1800         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1801         (WTR::getMenuItemChildrenCallback):
1802
1803 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1804
1805         WebKit should strip away system font names from the pasted content
1806         https://bugs.webkit.org/show_bug.cgi?id=199975
1807         <rdar://problem/53336353>
1808
1809         Reviewed by Darin Adler.
1810
1811         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
1812
1813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1814         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1815         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
1816
1817 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1818
1819         [ews-build] EWS fails to parse multi-line full_results.json
1820         https://bugs.webkit.org/show_bug.cgi?id=199992
1821
1822         Reviewed by Alexey Proskuryakov.
1823
1824         * BuildSlaveSupport/ews-build/layout_test_failures.py:
1825         (LayoutTestFailures.results_from_string): Concatenate content into single line.
1826         * BuildSlaveSupport/ews-build/steps_unittest.py:
1827         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
1828
1829 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1830
1831         resultsdbpy: Handle case where the previous commit doesn't have the changelog
1832         https://bugs.webkit.org/show_bug.cgi?id=200015
1833
1834         Reviewed by Aakash Jain.
1835
1836         * resultsdbpy/resultsdbpy/model/repository.py:
1837         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
1838
1839 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1840
1841         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
1842         https://bugs.webkit.org/show_bug.cgi?id=200013
1843         <rdar://problem/52526901>
1844
1845         Reviewed by Simon Fraser.
1846
1847         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
1851         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
1852         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
1853         * TestWebKitAPI/ios/UIKitSPI.h:
1854
1855 2019-07-22  Jer Noble  <jer.noble@apple.com>
1856
1857         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
1858         https://bugs.webkit.org/show_bug.cgi?id=199971
1859         <rdar://problem/51951218>
1860
1861         Reviewed by Alex Christensen.
1862
1863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1864         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
1865         (TestWebKitAPI::TEST):
1866
1867 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1868
1869         [ews-build] Add an EWS to run services tests
1870         https://bugs.webkit.org/show_bug.cgi?id=199994
1871
1872         Reviewed by Jonathan Bedard.
1873
1874         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
1875         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
1876         * BuildSlaveSupport/ews-build/steps.py:
1877         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
1878         (RunEWSUnitTests): Build step to run EWS unit-tests.
1879         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
1880         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1881         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
1882
1883 2019-07-22  Youenn Fablet  <youenn@apple.com>
1884
1885         Disable MediaRecorder for legacy WebKit
1886         https://bugs.webkit.org/show_bug.cgi?id=200001
1887         <rdar://problem/53400030>
1888
1889         Reviewed by Eric Carlson.
1890
1891         Enable MediaRecorder for testing purposes.
1892
1893         * DumpRenderTree/mac/DumpRenderTree.mm:
1894         (createWebViewAndOffscreenWindow):
1895
1896 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1897
1898         results.webkit.org: Timeline header is too small
1899         https://bugs.webkit.org/show_bug.cgi?id=199955
1900
1901         Reviewed by Aakash Jain.
1902
1903         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1904         (.timeline>.header): Make timeline header larder to fit configuration names.
1905
1906 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1907
1908         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
1909         https://bugs.webkit.org/show_bug.cgi?id=199954
1910
1911         Reviewed by Geoff Garen.
1912
1913         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1914         (TEST):
1915
1916 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1917
1918         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
1919         https://bugs.webkit.org/show_bug.cgi?id=199917
1920
1921         Reviewed by Sam Weinig.
1922
1923         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1924         (TEST):
1925
1926 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1927
1928         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
1929         https://bugs.webkit.org/show_bug.cgi?id=199980
1930
1931         Reviewed by Jonathan Bedard.
1932
1933         * BuildSlaveSupport/ews-build/steps.py:
1934         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
1935         * BuildSlaveSupport/ews-build/steps_unittest.py:
1936         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
1937         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
1938
1939 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1940
1941         [webkitpy] Add an unit test for setting up the driver environment without starting it.
1942         https://bugs.webkit.org/show_bug.cgi?id=199945
1943
1944         Reviewed by Michael Catanzaro.
1945
1946         This adds an unit test for the change implemented in r247663.
1947
1948         * Scripts/webkitpy/port/driver_unittest.py:
1949         (DriverTest.test_setup_environ_base_vars):
1950         (DriverTest):
1951         (DriverTest.test_setup_environ_without_starting_driver):
1952
1953 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1954
1955         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
1956         https://bugs.webkit.org/show_bug.cgi?id=199993
1957         <rdar://problem/49523528>
1958
1959         Reviewed by Beth Dakin.
1960
1961         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
1962
1963         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1964         (TestWebKitAPI::TEST):
1965         * TestWebKitAPI/cocoa/TestWKWebView.h:
1966
1967 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
1968
1969         Add accessibilityInsertText for text insertion in edit fields.
1970         https://bugs.webkit.org/show_bug.cgi?id=199973
1971
1972         Reviewed by Chris Fleizach.
1973
1974         Renamed accessibilityInsertText to _accessibilityInsertText.
1975
1976         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1977         (AccessibilityUIElement::insertText):
1978         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1979         (AccessibilityUIElement::insertText):
1980         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1981         (WTR::AccessibilityUIElement::insertText):
1982         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1983         (WTR::AccessibilityUIElement::insertText):
1984
1985 2019-07-20  Chris Dumez  <cdumez@apple.com>
1986
1987         Speed up HashTable decoding by reserving capacity and avoiding rehashing
1988         https://bugs.webkit.org/show_bug.cgi?id=199982
1989
1990         Reviewed by Saam Barati.
1991
1992         Add API test coverage.
1993
1994         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1995         (TestWebKitAPI::TEST):
1996
1997 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
1998
1999         Add accessibilityInsertText for text insertion in edit fields.
2000         https://bugs.webkit.org/show_bug.cgi?id=199973
2001
2002         Reviewed by Chris Fleizach.
2003
2004         Glue code to run new LayoutTests.
2005         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2006         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2007         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2008         (WTR::AccessibilityUIElement::insertText):
2009         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2010         (WTR::AccessibilityUIElement::insertText):
2011         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2012         (WTR::AccessibilityUIElement::insertText):
2013         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2014         (WTR::AccessibilityUIElement::insertText):
2015
2016 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2017
2018         Move webkit.css to opensource to support resultsdbpy's frontend
2019         https://bugs.webkit.org/show_bug.cgi?id=199957
2020
2021         Reviewed by Jonathan Bedard.
2022
2023         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
2024         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
2025         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
2026         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
2027
2028 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2029
2030         Move Ref.js to WebKit to support resultsdbpy's frontend
2031         https://bugs.webkit.org/show_bug.cgi?id=199956
2032
2033         Reviewed by Jonathan Bedard.
2034
2035         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2036         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2037         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2038         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
2039         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
2040         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
2041         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
2042         * resultsdbpy/resultsdbpy/view/templates/base.html:
2043         * resultsdbpy/resultsdbpy/view/templates/commits.html:
2044         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
2045         * resultsdbpy/resultsdbpy/view/templates/search.html:
2046         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2047         * resultsdbpy/resultsdbpy/view/view_routes.py:
2048
2049 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2050
2051         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
2052         https://bugs.webkit.org/show_bug.cgi?id=199945
2053
2054         Reviewed by Michael Catanzaro.
2055
2056         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
2057         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
2058         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
2059
2060         * Scripts/webkitpy/port/driver.py:
2061         (Driver._setup_environ_for_driver):
2062         (Driver._create_temporal_directories):
2063         (Driver):
2064         (Driver._start):
2065         (Driver._delete_temporal_directories):
2066         (Driver.stop):
2067         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
2068         (main):
2069         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
2070         (WebDriverTestRunner.__init__):
2071         * glib/api_test_runner.py:
2072         (TestRunner._setup_testing_environment): Ditto.
2073
2074 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
2075
2076         [ews-build] Display pre-existing Layout test failure names in the build summary
2077         https://bugs.webkit.org/show_bug.cgi?id=199941
2078
2079         Reviewed by Jonathan Bedard.
2080
2081         * BuildSlaveSupport/ews-build/steps.py:
2082         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2083
2084 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2085
2086         [GTK][WPE] run-webkit-tests should run with a temporal homedir
2087         https://bugs.webkit.org/show_bug.cgi?id=199738
2088
2089         Reviewed by Michael Catanzaro.
2090
2091         Run the tests with an empty homedir that is created inside the driver tmpdir.
2092         The driver tmpdir is a random directory created for each test runner that is purged after the run.
2093
2094         This is done to ensure that the test results are not affected by the user settings of any library.
2095
2096         * Scripts/webkitpy/port/driver.py:
2097         (Driver._setup_environ_for_driver):
2098         * Scripts/webkitpy/port/driver_unittest.py:
2099         (DriverTest.test_setup_environ_base_vars):
2100         (DriverTest):
2101         (DriverTest.test_create_temporal_home_dir):
2102
2103 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2104
2105         Remove pywebsockets from thirdparty
2106         https://bugs.webkit.org/show_bug.cgi?id=199710
2107
2108         Reviewed by Jonathan Bedard.
2109
2110         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
2111         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
2112
2113         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2114         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
2115         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
2116         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
2117         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
2118         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
2119         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
2120         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
2121         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
2122         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
2123         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
2124         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
2125         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
2126         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
2127         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
2128         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
2129         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
2130         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
2131         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
2132         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
2133         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
2134         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
2135
2136 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
2137
2138         results.webkit.org: Move resultsdbpy to WebKit
2139         https://bugs.webkit.org/show_bug.cgi?id=199837
2140         <rdar://problem/53172130>
2141
2142         Rubber-stamped by Aakash Jain.
2143
2144         Moving the entirety of the resultsdbpy library, which provides utilities to build
2145         a database designed to store, visualize and organize test results, into WebKit.
2146
2147         * Scripts/webkitpy/style/checker.py:
2148         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
2149         * resultsdbpy: Added.
2150         * resultsdbpy/MANIFEST.in: Added.
2151         * resultsdbpy/README.md: Added.
2152         * resultsdbpy/resultsdbpy: Added.
2153         * resultsdbpy/resultsdbpy/__init__.py: Added.
2154         * resultsdbpy/resultsdbpy/controller: Added.
2155         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
2156         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
2157         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
2158         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
2159         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
2160         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
2161         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
2162         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
2163         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
2164         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
2165         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
2166         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
2167         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
2168         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
2169         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
2170         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
2171         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
2172         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
2173         * resultsdbpy/resultsdbpy/flask_support: Added.
2174         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
2175         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
2176         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
2177         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
2178         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
2179         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
2180         * resultsdbpy/resultsdbpy/model: Added.
2181         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
2182         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
2183         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
2184         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
2185         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
2186         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
2187         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
2188         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
2189         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
2190         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
2191         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
2192         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
2193         * resultsdbpy/resultsdbpy/model/docker.py: Added.
2194         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2195         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2196         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2197         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2198         * resultsdbpy/resultsdbpy/model/model.py: Added.
2199         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2200         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2201         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2202         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2203         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2204         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2205         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2206         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2207         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2208         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2209         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2210         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2211         * resultsdbpy/resultsdbpy/run-tests: Added.
2212         * resultsdbpy/resultsdbpy/view: Added.
2213         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2214         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2215         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2216         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2217         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2218         * resultsdbpy/resultsdbpy/view/static: Added.
2219         * resultsdbpy/resultsdbpy/view/static/css: Added.
2220         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2221         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2222         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2223         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2224         * resultsdbpy/resultsdbpy/view/static/js: Added.
2225         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2226         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2227         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2228         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2229         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2230         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2231         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2232         * resultsdbpy/resultsdbpy/view/templates: Added.
2233         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2234         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2235         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2236         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2237         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2238         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2239         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2240         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2241         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2242         * resultsdbpy/setup.py: Added.
2243
2244 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2245
2246         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2247         https://bugs.webkit.org/show_bug.cgi?id=199923
2248
2249         Reviewed by Youenn Fablet.
2250
2251         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2252         (TestWebKitAPI::TEST):
2253
2254 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2255
2256         [ews-build] Enable iOS WK2 tester queue on new EWS
2257         https://bugs.webkit.org/show_bug.cgi?id=199867
2258
2259         Reviewed by Jonathan Bedard.
2260
2261         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2262         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2264         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2265
2266 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2267
2268         [ews-build] Add build step to AnalyzeLayoutTestsResults
2269         https://bugs.webkit.org/show_bug.cgi?id=199877
2270
2271         Reviewed by Jonathan Bedard.
2272
2273         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
2274
2275         * BuildSlaveSupport/ews-build/steps.py:
2276         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
2277         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
2278         (AnalyzeLayoutTestsResults.report_failure):
2279         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2280         (AnalyzeLayoutTestsResults.retry_build):
2281         (AnalyzeLayoutTestsResults._results_failed_different_tests):
2282         (AnalyzeLayoutTestsResults._report_flaky_tests):
2283         (AnalyzeLayoutTestsResults.start):
2284         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2285
2286 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2287
2288         Move NetworkCache ownership from NetworkProcess to NetworkSession
2289         https://bugs.webkit.org/show_bug.cgi?id=199817
2290
2291         Reviewed by Geoff Garen.
2292
2293         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2294         (TEST):
2295         * TestWebKitAPI/cocoa/TestWKWebView.h:
2296         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2297         (-[WKWebView synchronouslyLoadRequest:]):
2298
2299 2019-07-18  Youenn Fablet  <youenn@apple.com>
2300
2301         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
2302         https://bugs.webkit.org/show_bug.cgi?id=199769
2303         <rdar://problem/49390297>
2304
2305         Reviewed by Myles C. Maxfield.
2306
2307         Add a font containing one extended character not found in system fonts.
2308
2309         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2310         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
2311
2312 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
2313
2314         Unreviewed, Add Olivier Blin as contributor
2315
2316         * Scripts/webkitpy/common/config/contributors.json:
2317
2318 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2319
2320         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2321         https://bugs.webkit.org/show_bug.cgi?id=199855
2322
2323         Reviewed by Michael Catanzaro.
2324
2325         The webkitpy drivers for GTK and WPE use their own versions for setting
2326         up the environment and starting/stopping the drivers.
2327         This refactors those drivers to use the base class driver functions.
2328         As a benefit we get some fixes like support for setting the profiler
2329         environment variables, and a simpler code.
2330
2331         * Scripts/webkitpy/port/driver.py:
2332         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2333         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2334         * Scripts/webkitpy/port/headlessdriver.py:
2335         (HeadlessDriver._setup_environ_for_test):
2336         * Scripts/webkitpy/port/waylanddriver.py:
2337         (WaylandDriver._setup_environ_for_test):
2338         * Scripts/webkitpy/port/westondriver.py:
2339         (WestonDriver._setup_environ_for_test):
2340         (WestonDriver.stop):
2341         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2342         (WestonDriverTest.make_driver):
2343         * Scripts/webkitpy/port/xorgdriver.py:
2344         (XorgDriver._setup_environ_for_test):
2345         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2346         (XvfbDriver._setup_environ_for_test):
2347         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2348         (XvfbDriverTest.make_driver):
2349         (XvfbDriverTest.test_start):
2350         (XvfbDriverTest.test_start_arbitrary_worker_number):
2351         * Scripts/webkitpy/w3c/wpt_runner.py:
2352         (main): Start the driver before trying to get its environment to define all the environment variables.
2353         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2354         (WebDriverTestRunner.__init__): Ditto.
2355         * glib/api_test_runner.py:
2356         (TestRunner._setup_testing_environment): Ditto.
2357
2358 2019-07-17  Antoine Quint  <graouts@apple.com>
2359
2360         Disable Pointer Events prior to watchOS 6
2361         https://bugs.webkit.org/show_bug.cgi?id=199890
2362         <rdar://problem/53206113>
2363
2364         Reviewed by Dean Jackson.
2365
2366         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2367
2368 2019-07-17  Christopher Reid  <chris.reid@sony.com>
2369
2370         Bytecode cache should use FileSystem
2371         https://bugs.webkit.org/show_bug.cgi?id=199759
2372
2373         Reviewed by Yusuke Suzuki.
2374
2375         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2376
2377 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
2378
2379         check-webkit-style: Add limited Python3 support
2380         https://bugs.webkit.org/show_bug.cgi?id=199870
2381
2382         Rubber-stamped by Aakash Jain.
2383
2384         Since new services will be added in the near future which are Python 3, we
2385         need to support Python 3 style checks. For now, assume all Python files are
2386         Python 2 unless otherwise specified.
2387
2388         * Scripts/webkitpy/style/checker.py:
2389         (_all_categories): Add pycodestyle to valid categories for testing.
2390         (CheckerDispatcher._create_checker): Check that the provided Python file is in
2391         one of the declared Python 3 directories.
2392         * Scripts/webkitpy/style/checkers/python.py:
2393         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
2394         instead of pep8.
2395         (Python3Checker.__init__):
2396         (Python3Checker.check):
2397         * Scripts/webkitpy/thirdparty/__init__.py:
2398         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
2399         (AutoinstallImportHook._install_pycodestyle):
2400
2401 2019-07-17  Sam Weinig  <weinig@apple.com>
2402
2403         Add StringBuilder member function which allows makeString() style variadic argument construction
2404         https://bugs.webkit.org/show_bug.cgi?id=198997
2405
2406         Reviewed by Darin Adler.
2407
2408         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2409         Add basic test showing that StringBuilder::flexibleAppend can be used to
2410         append one or more string adaptable types.
2411
2412         * TestWebKitAPI/CMakeLists.txt:
2413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2414         Add WTFStringUtilities.cpp
2415
2416         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2417         Add basic test showing that StringBuilder::flexibleAppend can be used to
2418         append one or more string adaptable types.
2419
2420         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2421         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
2422         * TestWebKitAPI/WTFStringUtilities.h:
2423         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
2424         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
2425
2426 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2427
2428         Remove the file superfluously added in r247535.
2429
2430         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
2431         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
2432
2433 2019-07-17  Alex Christensen  <achristensen@webkit.org>
2434
2435         Add a runtime-disabled dialog element skeleton
2436         https://bugs.webkit.org/show_bug.cgi?id=199839
2437
2438         Reviewed by Ryosuke Niwa.
2439
2440         * DumpRenderTree/mac/DumpRenderTree.mm:
2441         (resetWebPreferencesToConsistentValues):
2442         * WebKitTestRunner/TestController.cpp:
2443         (WTR::TestController::resetPreferencesToConsistentValues):
2444         Enable the dialog element for layout tests.
2445
2446 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2447
2448         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
2449         https://bugs.webkit.org/show_bug.cgi?id=199851
2450
2451         Reviewed by Wenson Hsieh.
2452
2453         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
2454         this code is getting directly triggered from UIKeyboard's code.
2455
2456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2457         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
2458         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
2459         * TestWebKitAPI/ios/UIKitSPI.h:
2460
2461 2019-07-17  Commit Queue  <commit-queue@webkit.org>
2462
2463         Unreviewed, rolling out r247505.
2464         https://bugs.webkit.org/show_bug.cgi?id=199871
2465
2466         "Caused failed ASSERT in stress test" (Requested by creid on
2467         #webkit).
2468
2469         Reverted changeset:
2470
2471         "Bytecode cache should use FileSystem"
2472         https://bugs.webkit.org/show_bug.cgi?id=199759
2473         https://trac.webkit.org/changeset/247505
2474
2475 2019-07-17  Russell Epstein  <russell_e@apple.com>
2476
2477         Adding self to contributors.json
2478
2479         Unreviewed.
2480
2481         * Scripts/webkitpy/common/config/contributors.json:
2482
2483 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
2484
2485         [ews-build] Parse full_results.json for layout-tests
2486         https://bugs.webkit.org/show_bug.cgi?id=199804
2487
2488         Reviewed by Jonathan Bedard.
2489
2490         * BuildSlaveSupport/ews-build/steps.py:
2491         (RunWebKitTests.start): Monitor json output.
2492         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
2493         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
2494         by the patch or are pre-existing.
2495         (ReRunWebKitTests.commandComplete): Ditto.
2496         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
2497         * BuildSlaveSupport/ews-build/steps_unittest.py:
2498         (BuildStepMixinAdditions.getProperty): Added.
2499         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
2500         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
2501
2502 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2503
2504         Unreviewed, rolling out r247512.
2505
2506         Broke API test runners
2507
2508         Reverted changeset:
2509
2510         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
2511         for setting up the environment and start the drivers."
2512         https://bugs.webkit.org/show_bug.cgi?id=199855
2513         https://trac.webkit.org/changeset/247512
2514
2515 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2516
2517         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2518         https://bugs.webkit.org/show_bug.cgi?id=199855
2519
2520         Reviewed by Carlos Garcia Campos.
2521
2522         The webkitpy drivers for GTK and WPE use their own versions for setting
2523         up the environment and starting/stopping the drivers.
2524         This refactors those drivers to use the base class driver functions.
2525         As a benefit we get some fixes like support for setting the profiler
2526         environment variables, and a simpler code.
2527
2528         * Scripts/webkitpy/port/driver.py:
2529         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2530         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2531         * Scripts/webkitpy/port/headlessdriver.py:
2532         (HeadlessDriver._setup_environ_for_test):
2533         * Scripts/webkitpy/port/waylanddriver.py:
2534         (WaylandDriver._setup_environ_for_test):
2535         * Scripts/webkitpy/port/westondriver.py:
2536         (WestonDriver._setup_environ_for_test):
2537         (WestonDriver.stop):
2538         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2539         (WestonDriverTest.make_driver):
2540         * Scripts/webkitpy/port/xorgdriver.py:
2541         (XorgDriver._setup_environ_for_test):
2542         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2543         (XvfbDriver._setup_environ_for_test):
2544         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2545         (XvfbDriverTest.make_driver):
2546         (XvfbDriverTest.test_start):
2547         (XvfbDriverTest.test_start_arbitrary_worker_number):
2548
2549 2019-07-16  Christopher Reid  <chris.reid@sony.com>
2550
2551         Bytecode cache should use FileSystem
2552         https://bugs.webkit.org/show_bug.cgi?id=199759
2553
2554         Reviewed by Yusuke Suzuki.
2555
2556         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2557
2558 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
2559
2560         svn-create-patch duplicates diffs when adding directories
2561         https://bugs.webkit.org/show_bug.cgi?id=199842
2562
2563         Reviewed by Dewei Zhu.
2564
2565         * Scripts/svn-create-patch:
2566         (findKind): Add function which returns what 'kind' of file the provided path is.
2567         (generateFileList): If the path is a directory and being added, don't add it.
2568         Instead, rely on the fact that its children will be added.
2569
2570 2019-07-16  Tim Horton  <timothy_horton@apple.com>
2571
2572         NSTextFinder holes don't scroll with the page
2573         https://bugs.webkit.org/show_bug.cgi?id=199815
2574         <rdar://problem/52280514>
2575
2576         Reviewed by Simon Fraser.
2577
2578         * MiniBrowser/mac/WK2BrowserWindowController.m:
2579         (-[MiniBrowserNSTextFinder performAction:]):
2580         (-[WK2BrowserWindowController awakeFromNib]):
2581         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
2582         -performAction: so that we can intercept the close action and
2583         hide our own find UI, since there is no delegate for that action yet.
2584
2585         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2586         (TEST):
2587
2588 2019-07-15  Keith Miller  <keith_miller@apple.com>
2589
2590         JSGlobalObject type macros should support feature flags and WeakRef should have one
2591         https://bugs.webkit.org/show_bug.cgi?id=199601
2592
2593         Reviewed by Mark Lam.
2594
2595         JSC options need to be set before the window is created for the test.
2596
2597         * DumpRenderTree/mac/DumpRenderTree.mm:
2598         (resetWebViewToConsistentStateBeforeTesting):
2599         * DumpRenderTree/win/DumpRenderTree.cpp:
2600         (setJSCOptions):
2601         (resetWebViewToConsistentStateBeforeTesting):
2602
2603 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2604
2605         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
2606         https://bugs.webkit.org/show_bug.cgi?id=193108
2607
2608         Reviewed by Simon Fraser.
2609
2610         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
2611         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
2612         at the wrong scale.
2613
2614         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2615         (takeWindowSnapshot):
2616         (createBitmapContextFromWebView):
2617
2618 2019-07-15  Brady Eidson  <beidson@apple.com>
2619
2620         Make WKURLSchemeTask thread safe.
2621         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2622
2623         Reviewed by Alex Christensen.
2624
2625         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2626
2627 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2628
2629         Unreviewed, a build fix after r247437
2630
2631         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2632         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2633
2634 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2635
2636         [macOS 10.15] Cannot unbold selected text when the system font is used
2637         https://bugs.webkit.org/show_bug.cgi?id=199788
2638         <rdar://problem/52142570>
2639
2640         Reviewed by Tim Horton.
2641
2642         Add a new API test to verify that bolding and unbolding updates the
2643         shared font manager's selected font.
2644
2645         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2646         (TestWebKitAPI::TEST):
2647
2648 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2649
2650         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2651         https://bugs.webkit.org/show_bug.cgi?id=199790
2652         <rdar://problem/52790112>
2653
2654         Reviewed by Brent Fulgham.
2655
2656         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2657
2658         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2659         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2660         (configureSOAuthorizationWebView):
2661         (TestWebKitAPI::TEST):
2662         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2663         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2664         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2665         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2666         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2667
2668 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2669
2670         window.openDatabase is not writable
2671         https://bugs.webkit.org/show_bug.cgi?id=199737
2672         <rdar://problem/52551332>
2673
2674         Reviewed by Chris Dumez.
2675
2676         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2677         (TEST):
2678         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2679
2680 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2681
2682         [ews-build] Parse and display layout test failures
2683         https://bugs.webkit.org/show_bug.cgi?id=199709
2684
2685         Rubber-stamped by Jonathan Bedard.
2686
2687         * BuildSlaveSupport/ews-build/steps.py:
2688         (RunWebKitTests.start): Initialize log_observer.
2689         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2690         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2691         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2692         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2693         (RunWebKitTests.getResultSummary): Update build and step summary.
2694         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2695
2696 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2697
2698         Unreviewed, rolling out r247393.
2699         https://bugs.webkit.org/show_bug.cgi?id=199797
2700
2701         broke mips and arm EWS (Requested by guijemont on #webkit).
2702
2703         Reverted changeset:
2704
2705         "run-javascriptcore-tests won't report test results for
2706         testmasm, testair, testb3, testdfg and test api"
2707         https://bugs.webkit.org/show_bug.cgi?id=199489
2708         https://trac.webkit.org/changeset/247393
2709
2710 2019-07-12  Andy Estes  <aestes@apple.com>
2711
2712         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
2713         https://bugs.webkit.org/show_bug.cgi?id=199768
2714         <rdar://problem/52002206>
2715
2716         Reviewed by Geoffrey Garen.
2717
2718         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2719         (TEST):
2720
2721 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-build] Remove wincairo queue from old EWS and dashboard
2724         https://bugs.webkit.org/show_bug.cgi?id=199776
2725
2726         Reviewed by Don Olmstead.
2727
2728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2729         * QueueStatusServer/config/queues.py:
2730
2731 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-build] Enable wincairo queue on new EWS
2734         https://bugs.webkit.org/show_bug.cgi?id=199593
2735
2736         Reviewed by Don Olmstead.
2737
2738         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
2739         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
2740         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2741         (StatusBubble): Enable wincairo status-bubble.
2742
2743 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews-app] Enable logging for clicking SubmitToEWS button
2746         https://bugs.webkit.org/show_bug.cgi?id=199757
2747
2748         Unreviewed minor infrastructure fix.
2749
2750         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2751         (SubmitToEWS.post): Change logging level from debug to info.
2752
2753 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2754
2755         Enable client certificate authentication unit test
2756         https://bugs.webkit.org/show_bug.cgi?id=199735
2757
2758         Reviewed by Chris Dumez.
2759
2760         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2761         (TEST):
2762         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
2763         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
2764
2765 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2766
2767         Begin unifying TestWebKitAPI build
2768         https://bugs.webkit.org/show_bug.cgi?id=199728
2769
2770         Reviewed by Keith Miller.
2771
2772         * TestWebKitAPI/Configurations/Base.xcconfig:
2773         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
2774         * TestWebKitAPI/Sources.txt: Added.
2775         * TestWebKitAPI/SourcesCocoa.txt: Added.
2776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2777
2778 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
2779
2780         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2781         https://bugs.webkit.org/show_bug.cgi?id=199489
2782         <rdar://problem/47891081>
2783
2784         Reviewed by Aakash Jain.
2785
2786         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2787         (RunJavaScriptCoreTests.countFailures):
2788         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2789         * Scripts/run-javascriptcore-tests:
2790         (runTest):
2791         (reportTestFailures):
2792         (runJSCStressTests):
2793
2794 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2795
2796         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
2797         https://bugs.webkit.org/show_bug.cgi?id=199743
2798
2799         Reviewed by Jonathan Bedard.
2800
2801         * BuildSlaveSupport/ews-build/steps.py:
2802         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2803
2804 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2805
2806         Unreviewed follow-up fix to r247364.
2807         [ews-build] Add build step to clean up .git/index.lock file
2808         https://bugs.webkit.org/show_bug.cgi?id=199722
2809
2810         * BuildSlaveSupport/ews-build/steps.py:
2811         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
2812         to be run after this step.
2813
2814 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
2815
2816         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
2817         https://bugs.webkit.org/show_bug.cgi?id=199524
2818         <rdar://problem/52783816>
2819
2820         Reviewed by Saam Barati.
2821
2822         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
2823         But this test has several problems.
2824
2825         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
2826            number is calculated by pageSize / sizeof(T), and this does not account the header
2827            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
2828            is very small, we can have many objects in one IsoPage. As a result, we need a large
2829            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
2830            less than numObjects.
2831
2832         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
2833            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
2834            page. This also makes the intention of this test wrong.
2835
2836         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
2837
2838         We make this test robust while we still keep this test white-box one to test the critical feature
2839         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
2840         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
2841         tier live, and check whether the deallocated memory is reused.
2842
2843         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2844         (TEST):
2845
2846 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
2847
2848         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
2849         https://bugs.webkit.org/show_bug.cgi?id=199625
2850
2851         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
2852         with ENABLE(ACCESSIBILITY) in the code.
2853
2854         Additionally, the TestRunner code generator now honors the
2855         Conditional IDL format.
2856
2857         Reviewed by Konstantin Tokarev.
2858
2859         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2860         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2861         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2862         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2863         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2864         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2865         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2866         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2867         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2868         (_generateImplementationFile):
2869
2870 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2871
2872         [ews-build] Add build step to clean up .git/index.lock file
2873         https://bugs.webkit.org/show_bug.cgi?id=199722
2874
2875         Reviewed by Jonathan Bedard.
2876
2877         * BuildSlaveSupport/ews-build/steps.py:
2878         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
2879         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
2880         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
2881         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2882
2883 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
2884
2885         [iOS 13] Enable WebKit build
2886         https://bugs.webkit.org/show_bug.cgi?id=199481
2887         <rdar://problem/52619048>
2888
2889         Reviewed by Tim Horton.
2890
2891         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
2892
2893 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
2894
2895         Add test expectations and baselines for iOS 13
2896         https://bugs.webkit.org/show_bug.cgi?id=199329
2897
2898         Reviewed by Jonathan Bedard.
2899
2900         * Scripts/webkitpy/port/ios.py:
2901         (IOSPort): Increment current version to 13.
2902         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
2903         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
2904         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
2905         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
2906         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
2907         (IOSSimulatorTest.make_port):
2908         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
2909         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
2910         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
2911         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
2912         (IOSTest.make_port):
2913
2914 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
2915
2916         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
2917         https://bugs.webkit.org/show_bug.cgi?id=199692
2918
2919         Reviewed by Chris Fleizach.
2920
2921         Add support for output of AXDeletion and AXInsertion roles for tests.
2922         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
2923         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
2924
2925         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2926         * gtk/jhbuild.modules:
2927         * wpe/jhbuild.modules:
2928
2929 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
2930
2931         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
2932         https://bugs.webkit.org/show_bug.cgi?id=199707
2933
2934         Reviewed by Aakash Jain.
2935
2936         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
2937
2938 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
2939
2940         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
2941         https://bugs.webkit.org/show_bug.cgi?id=199693
2942         rdar://problem/51930364
2943
2944         Reviewed by Tim Horton.
2945
2946         New API tests that test scrollability with various combinations of content, insets,
2947         input accessory bars etc.
2948
2949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2950         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
2951         (TestWebKitAPI::webViewWithAutofocusedInput):
2952         (TestWebKitAPI::TEST):
2953
2954 2019-07-10  Tim Horton  <timothy_horton@apple.com>
2955
2956         Long pressing on attachments will crash the WebContent process
2957         https://bugs.webkit.org/show_bug.cgi?id=199696
2958         <rdar://problem/52920241>
2959
2960         Reviewed by Dean Jackson.
2961
2962         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2963         (TestWebKitAPI::TEST):
2964         Add a test that previously crashed.
2965
2966 2019-07-10  Dean Jackson  <dino@apple.com>
2967
2968         Support MacCatalyst in run-webkit-app
2969         https://bugs.webkit.org/show_bug.cgi?id=199690
2970
2971         Reviewed by Tim Horton.
2972
2973         Add a --maccatalyst option to run-webkit-app that
2974         can launch MacCatalyst applications with a built WebKit.
2975
2976         * Scripts/webkitdirs.pm:
2977         (argumentsForConfiguration):
2978         (determineXcodeSDK):
2979         (xcodeSDKPlatformName):
2980         (determineConfigurationProductDir):
2981         (determinePortName):
2982         (isCatalystWebKit):
2983         (isAppleCocoaWebKit):
2984         (willUseCatalystSDK):
2985
2986 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2987
2988         [MacOS] Filter VPA info logged to stdout
2989         https://bugs.webkit.org/show_bug.cgi?id=199673
2990
2991         Reviewed by Eric Carlson.
2992
2993         * Scripts/webkitpy/port/mac.py:
2994         (MacPort.logging_patterns_to_strip):
2995
2996 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2997
2998         Unreviewed, rolling out r247286.
2999
3000         Caused TestWTF.WTF.StringOperators to fail on debug bots
3001
3002         Reverted changeset:
3003
3004         "Add StringBuilder member function which allows makeString()
3005         style variadic argument construction"
3006         https://bugs.webkit.org/show_bug.cgi?id=198997
3007         https://trac.webkit.org/changeset/247286
3008
3009 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
3010
3011         [ews-build] Explicitly use perl or python while invoking scripts
3012         https://bugs.webkit.org/show_bug.cgi?id=199669
3013
3014         Reviewed by Jonathan Bedard.
3015
3016         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
3017         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3018
3019 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
3020
3021         Run tests on mips EWS
3022         https://bugs.webkit.org/show_bug.cgi?id=196854
3023
3024         Reviewed by Carlos Garcia Campos.
3025
3026         * Scripts/webkitpy/common/config/ews.json:
3027
3028 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3029
3030         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
3031         https://bugs.webkit.org/show_bug.cgi?id=199579
3032
3033         Reviewed by Carlos Garcia Campos.
3034
3035         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
3036         (TestWebKitAPI::TEST):
3037
3038 2019-07-09  Chris Dumez  <cdumez@apple.com>
3039
3040         Fix integer type encoding / decoding in WKRemoteObjectCoder
3041         https://bugs.webkit.org/show_bug.cgi?id=199643
3042         <rdar://problem/52732342>
3043
3044         Reviewed by Anders Carlsson.
3045
3046         Update API test coverage.
3047
3048         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3049         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3050         (TEST):
3051         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3052         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
3053         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
3054         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
3055         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
3056
3057 2019-07-09  Sam Weinig  <weinig@apple.com>
3058
3059         Add StringBuilder member function which allows makeString() style variadic argument construction
3060         https://bugs.webkit.org/show_bug.cgi?id=198997
3061
3062         Reviewed by Darin Adler.
3063
3064         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3065         Add basic test showing that StringBuilder::flexibleAppend can be used to
3066         append one or more string adaptable types.
3067
3068 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
3069
3070         Only allow fetching and removing session credentials from WebsiteDataStore
3071         https://bugs.webkit.org/show_bug.cgi?id=199385
3072         <rdar://problem/52622080>
3073
3074         Reviewed by Alex Christensen.
3075
3076         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
3077         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
3078         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
3079
3080         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3081         (TEST):
3082         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3083         (TestWebKitAPI::TEST):
3084
3085 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3086
3087         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
3088         https://bugs.webkit.org/show_bug.cgi?id=199628
3089
3090         Reviewed by Brady Eidson.
3091
3092         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3093         (TestWebKitAPI::TEST_F):
3094
3095 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3096
3097         Remove invalid assertion in URLParser::domainToASCII
3098         https://bugs.webkit.org/show_bug.cgi?id=199624
3099
3100         Reviewed by Brady Eidson.
3101
3102         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3103         (TestWebKitAPI::TEST_F):
3104
3105 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3106
3107         URLParser should reserialize IPv6 addresses that end with a colon
3108         https://bugs.webkit.org/show_bug.cgi?id=199627
3109
3110         Reviewed by Brady Eidson.
3111
3112         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3113         (TestWebKitAPI::TEST_F):
3114
3115 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3116
3117         [ews-build] Do not run unix commands for windows in PrintConfiguration
3118         https://bugs.webkit.org/show_bug.cgi?id=199605
3119
3120         Reviewed by Jonathan Bedard.
3121
3122         * BuildSlaveSupport/ews-build/steps.py:
3123
3124 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3125
3126         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
3127         https://bugs.webkit.org/show_bug.cgi?id=199487
3128
3129         Reviewed by Ross Kirsling.
3130
3131         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
3132         failing to open testglobalscope_constructors_file which was
3133         created by using tempfile.mkstemp() because it keeps the file
3134         open. Use tempfile.mkdtemp() to create temporary files in the
3135         temporary directory instead of tempfile.mkstemp().
3136
3137         * Scripts/webkitpy/bindings/main.py:
3138         (BindingsTests.run_tests):
3139         (BindingsTests.main):
3140         (BindingsTests.close_and_remove): Deleted.
3141
3142 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3143
3144         [ews-build] Add KillOldProcesses step before running API or Layout tests
3145         https://bugs.webkit.org/show_bug.cgi?id=199592
3146
3147         Reviewed by Jonathan Bedard.
3148
3149         * BuildSlaveSupport/ews-build/factories.py:
3150
3151 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
3152
3153         test-webkitpy: Explicitly use Python 2.7 lldb library
3154         https://bugs.webkit.org/show_bug.cgi?id=199578
3155         <rdar://problem/51853557>
3156
3157         Reviewed by Aakash Jain.
3158
3159         * Scripts/webkitpy/common/system/systemhost.py:
3160         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
3161         * Scripts/webkitpy/test/main.py:
3162         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
3163
3164 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
3165
3166         Add test expectations and baselines for Catalina
3167         https://bugs.webkit.org/show_bug.cgi?id=199328
3168
3169         Reviewed by Jonathan Bedard.
3170
3171         * Scripts/webkitpy/port/mac.py:
3172         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
3173
3174 2019-07-08  Christopher Reid  <chris.reid@sony.com>
3175
3176         Implement MappedFileData for Windows
3177         https://bugs.webkit.org/show_bug.cgi?id=198269
3178
3179         Reviewed by Darin Adler.
3180
3181         * TestWebKitAPI/PlatformWin.cmake:
3182
3183 2019-07-08  Charlie Turner  <cturner@igalia.com>
3184
3185         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
3186         https://bugs.webkit.org/show_bug.cgi?id=197558
3187
3188         Reviewed by Xabier Rodriguez-Calvar.
3189
3190         On shutdown we can easily deadlock the web process if we don't
3191         ensure all network operations are completed before comitting state
3192         changes. In HLS, make sure the network operations are cancelled,
3193         and also prevent hlsdemux's retry logic from scuppering our
3194         efforts.
3195
3196         * gstreamer/jhbuild.modules: Include the patch.
3197         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3198
3199 2019-07-08  Antoine Quint  <graouts@apple.com>
3200
3201         [Pointer Events] Enable only on the most recent version of the supported iOS family
3202         https://bugs.webkit.org/show_bug.cgi?id=199562
3203         <rdar://problem/52766511>
3204
3205         Reviewed by Dean Jackson.
3206
3207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3208
3209 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3210
3211         Long hang when loading a cnn.com page on iOS
3212         https://bugs.webkit.org/show_bug.cgi?id=199556
3213
3214         Reviewed by Zalan Bujtas.
3215
3216         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3217         to load a test page of your choice.
3218
3219         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3220         (-[WebViewController viewDidLoad]):
3221
3222 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3223
3224         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3225         https://bugs.webkit.org/show_bug.cgi?id=199503
3226
3227         Reviewed by Wenson Hsieh.
3228
3229         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3230         _requestActivatedElementAtPosition
3231
3232         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3233         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3234         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3235         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3236         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3237         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3238         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3239         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3240         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3241         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3242         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3243         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3244
3245 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3246
3247         Unreviewed, rolling out r247115.
3248
3249         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3250
3251         Reverted changeset:
3252
3253         "[WHLSL] Standard library is too big to directly include in
3254         WebCore"
3255         https://bugs.webkit.org/show_bug.cgi?id=198186
3256         https://trac.webkit.org/changeset/247115
3257
3258 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3259
3260         Unreviewed, rolling out r247123.
3261
3262         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3263         fail.
3264
3265         Reverted changeset:
3266
3267         "Only allow fetching and removing session credentials from
3268         WebsiteDataStore"
3269         https://bugs.webkit.org/show_bug.cgi?id=199385
3270         https://trac.webkit.org/changeset/247123
3271
3272 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3273
3274         Touching media controls sometimes shows software keyboard
3275         https://bugs.webkit.org/show_bug.cgi?id=199490
3276         <rdar://problem/52076270>
3277
3278         Reviewed by Eric Carlson.
3279
3280         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
3281         ChangeLog entries for more detail.
3282
3283         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3284         (WTR::UIScriptController::hasInputSession const):
3285         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3286         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3287         (WTR::UIScriptController::hasInputSession const):
3288         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3289         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3290         (WTR::UIScriptController::hasInputSession const):
3291
3292 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
3293
3294         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
3295         https://bugs.webkit.org/show_bug.cgi?id=199458
3296
3297         Reviewed by Michael Catanzaro.
3298
3299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3300         * QueueStatusServer/config/queues.py:
3301
3302 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3303
3304         [GTK] Fix browserperfdash script after r239522
3305         https://bugs.webkit.org/show_bug.cgi?id=199496
3306
3307         Reviewed by Michael Catanzaro.
3308
3309         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
3310         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
3311
3312 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3313
3314         [webkitpy] test-webkitpy is broken on Linux since r246662
3315         https://bugs.webkit.org/show_bug.cgi?id=199493
3316
3317         Reviewed by Michael Catanzaro.
3318
3319         * Scripts/webkitpy/test/main.py:
3320         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
3321
3322 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3323
3324         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
3325         https://bugs.webkit.org/show_bug.cgi?id=199406
3326
3327         Reviewed by Michael Catanzaro.
3328
3329         Install the Woff2 libraries and headers from the system package
3330         and stop building them on the JHBuild.
3331
3332         * gtk/install-dependencies:
3333         * gtk/jhbuild.modules:
3334         * wpe/install-dependencies:
3335         * wpe/jhbuild.modules:
3336
3337 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3338
3339         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
3340         https://bugs.webkit.org/show_bug.cgi?id=199449
3341
3342         Reviewed by Michael Catanzaro.
3343
3344         * Scripts/webkitdirs.pm:
3345         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
3346
3347 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3348
3349         Unreviewed, GTK a11y tests fix after r247071
3350
3351         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3352         (WTR::AccessibilityUIElement::popupValue const):
3353
3354 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3355
3356         [ews-build] Enable WPE and GTK queues on new EWS
3357         https://bugs.webkit.org/show_bug.cgi?id=199234
3358
3359         Reviewed by Jonathan Bedard.
3360
3361         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
3362         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
3363         * BuildSlaveSupport/ews-build/steps.py:
3364         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
3365         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3367         (StatusBubble): Enable gtk and wpe status-bubbles.
3368
3369 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
3370
3371         Only allow fetching and removing session credentials from WebsiteDataStore
3372         https://bugs.webkit.org/show_bug.cgi?id=199385
3373
3374         Reviewed by Alex Christensen.
3375
3376         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3377         (TestWebKitAPI::TEST):
3378
3379 2019-07-03  Tim Horton  <timothy_horton@apple.com>
3380
3381         UI process exception when dragging an <attachment> with no content type
3382         https://bugs.webkit.org/show_bug.cgi?id=199480
3383         <rdar://problem/44351353>
3384
3385         Reviewed by Wenson Hsieh.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3388         (TestWebKitAPI::TEST):
3389         Add a test; before the change, it crashes.
3390
3391 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
3392
3393         [Catalina] Enable WebKit build
3394         https://bugs.webkit.org/show_bug.cgi?id=199209
3395
3396         Reviewed by Darin Adler.
3397
3398         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
3399
3400 2019-07-03  Sam Weinig  <weinig@apple.com>
3401
3402         Adopt simple structured bindings in more places
3403         https://bugs.webkit.org/show_bug.cgi?id=199247
3404
3405         Reviewed by Alex Christensen.
3406
3407         Replaces simple uses of std::tie() with structured bindings. Does not touch
3408         uses of std::tie() that are not initial declarations, use std::ignore or in
3409         case where the binding is captured by a lambda, as structured bindings don't
3410         work for those cases yet.
3411
3412         * TestWebKitAPI/ios/PreferredContentMode.mm:
3413         (TestWebKitAPI::TEST):
3414
3415 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3416
3417         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
3418
3419         * BuildSlaveSupport/ews-build/steps.py:
3420         (PrintConfiguration.run):
3421
3422 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3423
3424         [ews-build] Add build steps to Install Wpe and Gtk dependencies
3425         https://bugs.webkit.org/show_bug.cgi?id=199408
3426
3427         Reviewed by Michael Catanzaro.
3428
3429         * BuildSlaveSupport/ews-build/steps.py:
3430         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
3431         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
3432         (InstallWpeDependencies): Ditto for WPE.
3433         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3434
3435 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews-build] Allow skipping uploading built product for few builders
3438         https://bugs.webkit.org/show_bug.cgi?id=199422
3439
3440         Reviewed by Michael Catanzaro.
3441
3442         * BuildSlaveSupport/ews-build/steps.py:
3443         (CompileWebKit.__init__): Added optional skipUpload parameter.
3444         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
3445
3446 2019-07-02  Tim Horton  <timothy_horton@apple.com>
3447
3448         REGRESSION (r243240): Unable to swipe back in Safari
3449         https://bugs.webkit.org/show_bug.cgi?id=199394
3450         <rdar://problem/51137447>
3451
3452         Reviewed by Wenson Hsieh.
3453
3454         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3455         Make sure that we actually end up with swipe gesture recognizers installed
3456         after process swap and crash.
3457
3458 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
3459
3460         Enhance support of aria-haspopup per ARIA 1.1 specification.
3461         https://bugs.webkit.org/show_bug.cgi?id=199216
3462         <rdar://problem/46221342>
3463
3464         Reviewed by Chris Fleizach.
3465
3466         * DumpRenderTree/AccessibilityUIElement.cpp:
3467         (getPopupValueCallback):
3468         (AccessibilityUIElement::getJSClass):
3469         * DumpRenderTree/AccessibilityUIElement.h:
3470         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3471         (AccessibilityUIElement::popupValue const):
3472         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3473         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3474         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3475         (WTR::AccessibilityUIElement::popupValue const):
3476         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3477         (WTR::AccessibilityUIElement::popupValue const):
3478
3479 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3480
3481         [ews-build] Do not print worker environment variables in each build step [part 2]
3482         https://bugs.webkit.org/show_bug.cgi?id=199405
3483
3484         Reviewed by Jonathan Bedard.
3485
3486         * BuildSlaveSupport/ews-build/steps.py:
3487         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
3488         (CleanWorkingDirectory.__init__): Ditto.
3489         (RunBindingsTests.__init__): Ditto.
3490         (RunWebKitPerlTests.__init__): Ditto.
3491         (RunWebKitPyTests.__init__): Ditto.
3492         (CompileWebKit.__init__): Ditto.
3493         (ArchiveTestResults.__init__): Ditto.
3494         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3495
3496 2019-07-02  Jer Noble  <jer.noble@apple.com>
3497
3498         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
3499         https://bugs.webkit.org/show_bug.cgi?id=199381
3500         <rdar://problem/52483103>
3501
3502         Reviewed by Eric Carlson.
3503
3504         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
3505
3506 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3507
3508         [ews-build] Update bot configuration for WPE and GTK
3509         https://bugs.webkit.org/show_bug.cgi?id=199238
3510
3511         Reviewed by Michael Catanzaro.
3512
3513         * BuildSlaveSupport/ews-build/config.json:
3514
3515 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3516
3517         [ews-build] Make PrintConfiguration platform aware
3518         https://bugs.webkit.org/show_bug.cgi?id=196657
3519
3520         Reviewed by Lucas Forschler.
3521
3522         * BuildSlaveSupport/ews-build/steps.py:
3523         (PrintConfiguration): Specified platform-specific command lists.
3524         (PrintConfiguration.run): Override run method and specify platform specific commands.
3525         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3526
3527 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
3528
3529         [Wasm-References] Disable references by default
3530         https://bugs.webkit.org/show_bug.cgi?id=199390
3531
3532         Reviewed by Saam Barati.
3533
3534         * Scripts/run-jsc-stress-tests:
3535
3536 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
3537
3538         Unreviewed. Revert r246965 to fix build break
3539         since r247019 reverted its related changes.
3540
3541         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3542         (WTR::AccessibilityUIElement::popupValue const): Deleted.
3543
3544 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3545
3546         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
3547         https://bugs.webkit.org/show_bug.cgi?id=199371
3548         <rdar://problem/52352905>
3549
3550         Reviewed by Tim Horton.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3553         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
3554         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3555         (-[NavigationActionSPIDelegate spiCalled]):
3556         (TEST):
3557
3558 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3559
3560         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
3561         https://bugs.webkit.org/show_bug.cgi?id=199296
3562         <rdar://problem/51041960>
3563
3564         Reviewed by Darin Adler.
3565
3566         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3567         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
3568
3569 2019-07-01  Truitt Savell  <tsavell@apple.com>
3570
3571         Unreviewed, rolling out r246958.
3572
3573         Broke inspector/dom/getAccessibilityPropertiesForNode.html
3574
3575         Reverted changeset:
3576
3577         "Enhance support of aria-haspopup per ARIA 1.1 specification."
3578         https://bugs.webkit.org/show_bug.cgi?id=199216
3579         https://trac.webkit.org/changeset/246958
3580
3581 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3582
3583         Unreviewed, GTK a11y tests fix after r246958
3584
3585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3586         (WTR::AccessibilityUIElement::popupValue const):
3587
3588 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
3589
3590         Enhance support of aria-haspopup per ARIA 1.1 specification.
3591         https://bugs.webkit.org/show_bug.cgi?id=199216
3592         <rdar://problem/46221342>
3593
3594         Reviewed by Chris Fleizach.
3595
3596         * DumpRenderTree/AccessibilityUIElement.cpp:
3597         (getPopupValueCallback):
3598         (AccessibilityUIElement::getJSClass):
3599         * DumpRenderTree/AccessibilityUIElement.h:
3600         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3601         (AccessibilityUIElement::popupValue const):
3602         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3603         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3604         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3605         (WTR::AccessibilityUIElement::popupValue const):
3606         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3607         (WTR::AccessibilityUIElement::popupValue const):
3608
3609 2019-06-28  Robin Morisset  <rmorisset@apple.com>
3610
3611         Adding myself as a reviewer to contributors.json.
3612
3613         Unreviewed.
3614
3615         * Scripts/webkitpy/common/config/contributors.json:
3616
3617 2019-06-28  Jer Noble  <jer.noble@apple.com>
3618
3619         Add new -[WKWebView _closeAllMediaPresentations] SPI
3620         https://bugs.webkit.org/show_bug.cgi?id=199294
3621         <rdar://problem/51965958>
3622
3623         Reviewed by Alex Christensen.
3624
3625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3626         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
3627         (TEST):
3628
3629 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
3630
3631         Add a regression test for change r246901
3632         https://bugs.webkit.org/show_bug.cgi?id=199290
3633
3634         Reviewed by Geoffrey Garen.
3635
3636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3637         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3638         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3639         (TEST):
3640         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
3641
3642 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
3643
3644         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
3645         https://bugs.webkit.org/show_bug.cgi?id=199317
3646
3647         Reviewed by Michael Catanzaro.
3648
3649         While IconDatabase and all code using it was removed,
3650         ENABLE_ICONDATABASE still exists as build option and C++ macro.
3651
3652         * Scripts/webkitperl/FeatureList.pm:
3653         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3654         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
3655         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
3656
3657 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3658
3659         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
3660         https://bugs.webkit.org/show_bug.cgi?id=199310
3661         <rdar://problem/52292137>
3662
3663         Reviewed by Megan Gardner.
3664
3665         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
3666         _elementDidFocus.
3667
3668         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3669         (TestWebKitAPI::TEST):
3670         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3671         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3672         (-[TestInputDelegate setDidStartInputSessionHandler:]):
3673         (-[TestInputDelegate didStartInputSessionHandler]):
3674
3675         Add plumbing for a handler block in TestInputDelegate.
3676
3677         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3678
3679         Drive-by style fixes to add a space between id and < for Objective-C protocols.
3680
3681         (-[TestInputDelegate willStartInputSessionHandler]):
3682         (-[TestInputDelegate _webView:willStartInputSession:]):
3683         (-[TestInputDelegate _webView:didStartInputSession:]):
3684         * TestWebKitAPI/cocoa/TestWKWebView.h:
3685         * TestWebKitAPI/ios/UIKitSPI.h:
3686
3687         Add a declaration for _selectionClipRects.
3688
3689 2019-06-27  Zalan Bujtas  <zalan@apple.com>
3690
3691         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
3692         https://bugs.webkit.org/show_bug.cgi?id=199303
3693         <rdar://problem/51340927>
3694
3695         Reviewed by Tim Horton.
3696
3697         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3698         (TEST):
3699
3700 2019-06-27  Beth Dakin  <bdakin@apple.com>
3701
3702         Upstream use of MACCATALYST
3703         https://bugs.webkit.org/show_bug.cgi?id=199245
3704         rdar://problem/51687723
3705
3706         Reviewed by Tim Horton.
3707
3708         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
3709         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
3710         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
3711         * MiniBrowser/Configurations/SDKVariant.xcconfig:
3712         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
3713         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3714         (JavaScriptCoreGenerator):
3715         (WebCoreGenerator):
3716         (WebKitGenerator):
3717         * TestWebKitAPI/Configurations/Base.xcconfig:
3718         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3719         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
3720         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3721         * WebEditingTester/Configurations/SDKVariant.xcconfig:
3722         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
3723         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
3724         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
3725
3726 2019-06-27  Saam Barati  <sbarati@apple.com>
3727
3728         Make WEBGPU enabled only on Mojave and later.
3729
3730         Rubber-stamped by Myles C. Maxfield.
3731
3732         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3733
3734 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
3735
3736         [ews-build] Do not print worker environment variables in each build step
3737         https://bugs.webkit.org/show_bug.cgi?id=197319
3738
3739         Reviewed by Lucas Forschler.
3740
3741         * BuildSlaveSupport/ews-build/steps.py:
3742         (CheckOutSource.__init__): Disabled logging of environment variables.
3743         (ApplyPatch.__init__): Ditto.
3744         (KillOldProcesses.__init__): Ditto.
3745         (ArchiveBuiltProduct.__init__): Ditto.
3746         (DownloadBuiltProduct.__init__): Ditto.
3747         (ExtractBuiltProduct.__init__): Ditto.
3748         (RunAPITests.__init__): Ditto.
3749         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3750
3751 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
3752
3753         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
3754         https://bugs.webkit.org/show_bug.cgi?id=199232
3755         <rdar://problem/51718328>
3756
3757         Reviewed by Youenn Fablet.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3760         (TestWebKitAPI::TEST):
3761         Add a test that utilizes TCPServer as local files always omit referrer.
3762
3763 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
3764
3765         [ews-build] Add configuration and architecture for WPE and GTK builders
3766         https://bugs.webkit.org/show_bug.cgi?id=199249
3767
3768         Reviewed by Jonathan Bedard.
3769
3770         * BuildSlaveSupport/ews-build/config.json:
3771
3772 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
3773
3774         [ews-build] Add check for duplicate workers in config.json
3775         https://bugs.webkit.org/show_bug.cgi?id=199240
3776
3777         Reviewed by Jonathan Bedard.
3778
3779         * BuildSlaveSupport/ews-build/loadConfig.py:
3780         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
3781         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3782         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
3783
3784 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
3785
3786         [Win] MiniBrowser should make better font choices
3787         https://bugs.webkit.org/show_bug.cgi?id=199244
3788
3789         Reviewed by Brent Fulgham.
3790
3791         * MiniBrowser/win/MainWindow.cpp:
3792         (MainWindow::updateDeviceScaleFactor):
3793         * MiniBrowser/win/MiniBrowserLib.rc:
3794
3795 2019-06-26  Alex Christensen  <achristensen@webkit.org>
3796
3797         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
3798         https://bugs.webkit.org/show_bug.cgi?id=199230
3799         <rdar://51757107>
3800
3801         Reviewed by Andy Estes.
3802
3803         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3804         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3805         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3806         * WebKitTestRunner/TestController.cpp:
3807         (WTR::TestController::generatePageConfiguration):
3808         (WTR::TestController::createWebViewWithOptions):
3809         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
3810         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
3811         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3812         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
3813         * WebKitTestRunner/TestController.h:
3814         * WebKitTestRunner/TestInvocation.cpp:
3815         (WTR::TestInvocation::invoke):
3816         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3817
3818 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
3819
3820         [Win][MiniBrowser] Remove obsolete code after r246814.
3821         https://bugs.webkit.org/show_bug.cgi?id=199233
3822
3823         Reviewed by Fujii Hironori.
3824
3825         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3826         (MiniBrowserWebHost::didFinishLoadForFrame):
3827         (SimpleEventListener::SimpleEventListener): Deleted.
3828         (SimpleEventListener::handleEvent): Deleted.
3829
3830 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
3831
3832         Implement a new SPI to inform clients about AppSSO
3833         https://bugs.webkit.org/show_bug.cgi?id=199085
3834         <rdar://problem/50028246>
3835
3836         Reviewed by Geoffrey Garen.
3837
3838         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3839         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
3840         (-[TestSOAuthorizationNavigationDelegate init]):
3841         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3842         (TestWebKitAPI::TEST):
3843
3844 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3845
3846         [ews-build] Retry Layout test in case of failures
3847         https://bugs.webkit.org/show_bug.cgi?id=199194
3848
3849         Reviewed by Jonathan Bedard.
3850
3851         * BuildSlaveSupport/ews-build/steps.py:
3852         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
3853         (ReRunWebKitTests): Build step to re-run layout tests.
3854         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
3855         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
3856         (RunWebKitTestsWithoutPatch.evaluateCommand):
3857
3858 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3859
3860         [ews-build] Combine various patchFailed*Tests properties
3861         https://bugs.webkit.org/show_bug.cgi?id=199193
3862
3863         Reviewed by Jonathan Bedard.
3864
3865         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property
3866         can also be used for layout-tests later on.
3867         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3868
3869 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
3870
3871         [Win] MiniBrowser should default to webkit.org
3872         https://bugs.webkit.org/show_bug.cgi?id=199201
3873
3874         Reviewed by Don Olmstead.
3875
3876         * MiniBrowser/win/BrowserWindow.h:
3877         * MiniBrowser/win/MiniBrowserReplace.h:
3878         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3879         (WebKitBrowserWindow::loadHTMLString): Deleted.
3880         * MiniBrowser/win/WebKitBrowserWindow.h:
3881         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3882         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
3883         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3884         * MiniBrowser/win/WinMain.cpp:
3885         (wWinMain):
3886
3887 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3888
3889         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
3890         https://bugs.webkit.org/show_bug.cgi?id=199192
3891         <rdar://problem/51554509>
3892
3893         Reviewed by Tim Horton.
3894
3895         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
3896         verify that we gracefully handle web process termination and web view unparenting mid-drag.
3897
3898         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3899         (TestWebKitAPI::TEST):
3900         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3901         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3902         (-[DragAndDropSimulator _resetSimulatedState]):
3903         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3904         (-[DragAndDropSimulator _advanceProgress]):
3905         (-[DragAndDropSimulator liftPreviews]):
3906         (-[DragAndDropSimulator cancellationPreviews]):
3907         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
3908         (-[DragAndDropSimulator sessionWillBeginBlock]):
3909         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
3910
3911 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3912
3913         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
3914         https://bugs.webkit.org/show_bug.cgi?id=199178
3915
3916         Reviewed by Jonathan Bedard.
3917
3918         * BuildSlaveSupport/ews-build/steps.py:
3919         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
3920         (ExtractTestResults.__init__): Ditto.
3921         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
3922
3923 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3924
3925         Add user agent quirk for bankofamerica.com
3926         https://bugs.webkit.org/show_bug.cgi?id=199154
3927
3928         Reviewed by Carlos Garcia Campos.
3929
3930         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3931         (TestWebKitAPI::TEST):
3932
3933 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3934
3935         Fully rename WebKitGTK+ -> WebKitGTK everywhere
3936         https://bugs.webkit.org/show_bug.cgi?id=199159
3937
3938         Reviewed by Carlos Garcia Campos.
3939
3940         * BuildSlaveSupport/gtk/README:
3941         * MiniBrowser/gtk/BrowserWindow.c:
3942         * MiniBrowser/gtk/main.c:
3943         (aboutURISchemeRequestCallback):
3944         * Scripts/webkitpy/common/config/contributionareas.py:
3945         * Scripts/webkitpy/common/config/contributors.json:
3946         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
3947         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3948         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3949         (testWebViewResources):
3950         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3951         (testWebViewMouseTarget):
3952         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3953         (testWebExtensionGetTitle):
3954         (testDocumentLoadedSignal):
3955         (testWebExtensionFormControlsAssociated):
3956         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3957         (testWebKitSettingsUserAgent):
3958         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3959         (testWebViewRunJavaScript):
3960         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
3961         (main):
3962         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3963         (prepareContextMenuTestView):
3964         (testContextMenuPopulateMenu):
3965         (testContextMenuCustomMenu):
3966         (testContextMenuDisableMenu):
3967         (testContextMenuSubMenu):
3968         (testContextMenuDismissed):
3969         (testContextMenuWebExtensionMenu):
3970         (testContextMenuWebExtensionNode):
3971         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3972         (testInspectorDefault):
3973         (testInspectorManualAttachDetach):
3974         (testInspectorCustomContainerDestroyed):
3975         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3976         (testWebViewPrint):
3977         (testPrintOperationPrint):
3978         (testPrintOperationErrors):
3979         * gtk/install-dependencies:
3980         * gtk/jhbuild.modules:
3981         * gtkdoc/generate-gtkdoc:
3982         * wpe/install-dependencies:
3983
3984 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3985
3986         contributors.json not canonicalized since r243297
3987         https://bugs.webkit.org/show_bug.cgi?id=199161
3988
3989         Reviewed by Alexey Proskuryakov.
3990
3991         Canonicalize it using 'validate-committer-lists --canonicalize'
3992
3993         * Scripts/webkitpy/common/config/contributors.json:
3994
3995 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
3996
3997         webkitpy: Build style should be lower-case
3998         https://bugs.webkit.org/show_bug.cgi?id=199158
3999
4000         Reviewed by Aakash Jain.
4001
4002         * Scripts/webkitpy/test/main.py:
4003         (Tester._run_tests): Make all styles lower-case.
4004
4005 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4006
4007         [ews-build] Remove iOS queue from old EWS and dashboard
4008         https://bugs.webkit.org/show_bug.cgi?id=199150
4009
4010         Reviewed by Jonathan Bedard.
4011
4012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4013         * QueueStatusServer/config/queues.py:
4014
4015 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
4016
4017         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
4018         https://bugs.webkit.org/show_bug.cgi?id=198795
4019
4020         Unreviewed test gardening.
4021
4022         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4023         (TestWebKitAPI::TEST): Disable flaky test.
4024
4025 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4026
4027         [ews-build] Enable iOS-12-Build queue on new EWS
4028         https://bugs.webkit.org/show_bug.cgi?id=199149
4029
4030         Reviewed by Jonathan Bedard.
4031
4032         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
4033         this queue.
4034         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4035         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
4036         will keep the builders to the left and testers to the right.
4037
4038 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4039
4040         [ews-build] Upload test results after running layout-tests
4041         https://bugs.webkit.org/show_bug.cgi?id=199120
4042
4043         Reviewed by Jonathan Bedard.
4044
4045         * BuildSlaveSupport/ews-build/steps.py:
4046         (RunWebKitTests.evaluateCommand):
4047         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4048
4049 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4050
4051         [ews-build] EWS should provide option to download layout test results zip file
4052         https://bugs.webkit.org/show_bug.cgi?id=199121
4053
4054         Reviewed by Jonathan Bedard.
4055
4056         * BuildSlaveSupport/ews-build/steps.py:
4057         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url.
4058         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
4059
4060 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4061
4062         Add user agent quirk for Google Drive
4063         https://bugs.webkit.org/show_bug.cgi?id=199153
4064
4065         Reviewed by Carlos Garcia Campos.
4066
4067         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4068         (TestWebKitAPI::TEST):
4069
4070 2019-06-22  Zalan Bujtas  <zalan@apple.com>
4071
4072         [LFC] Expand tests coverage (328 new tests -> 2652).
4073
4074         * LayoutReloaded/misc/LFC-passing-tests.txt:
4075
4076 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
4077
4078         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
4079         https://bugs.webkit.org/show_bug.cgi?id=199107
4080         <rdar://problem/43663611>
4081
4082         Reviewed by Chris Fleizach.
4083
4084         iOS implementation for AccessibilityUIElement::hasPopup.
4085         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4086         (WTR::AccessibilityUIElement::hasPopup const):
4087
4088 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
4089
4090         Unreviewed, add myself to CMake watchlist
4091
4092         * Scripts/webkitpy/common/config/watchlist:
4093
4094 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
4095
4096         openDatabase should return an empty object when WebSQL is disabled
4097         https://bugs.webkit.org/show_bug.cgi?id=198805
4098
4099         Reviewed by Geoffrey Garen.
4100
4101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4102         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
4103         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
4104         (TEST):
4105         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
4106
4107 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
4108
4109         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
4110         https://bugs.webkit.org/show_bug.cgi?id=199114
4111         <rdar://problem/51671674>
4112
4113         Reviewed by Youenn Fablet.
4114
4115         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4116         (-[TestSOAuthorizationNavigationDelegate init]):
4117         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4118         (configureSOAuthorizationWebView):
4119         (TestWebKitAPI::TEST):
4120
4121 2019-06-21  Youenn Fablet  <youenn@apple.com>
4122
4123         WebPageProxy should use the right path for sandbox extension
4124         https://bugs.webkit.org/show_bug.cgi?id=198902
4125         <rdar://problem/50772810>
4126
4127         Reviewed by Geoffrey Garen.
4128
4129         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
4130         (TEST):
4131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4132
4133 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
4134
4135         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
4136         https://bugs.webkit.org/show_bug.cgi?id=199094
4137
4138         Reviewed by Carlos Garcia Campos.
4139
4140         * MiniBrowser/gtk/BrowserTab.c:
4141         (runColorChooserCallback):
4142         (browserTabConstructed):
4143         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4144         (testWebViewSyncRequestOnMaxConns):
4145         (beforeAll):
4146         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4147         (testWebSocketTLSErrors):
4148         (beforeAll):
4149         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4150         (WebKitTestServer::~WebKitTestServer):
4151         (WebKitTestServer::getWebSocketURIForPath const):
4152         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4153         (WTR::AccessibilityUIElement::rowHeaders const):
4154         (WTR::AccessibilityUIElement::columnHeaders const):
4155         (WTR::AccessibilityUIElement::isAttributeSettable):
4156         (WTR::AccessibilityUIElement::x):
4157         (WTR::AccessibilityUIElement::y):
4158         (WTR::AccessibilityUIElement::width):
4159         (WTR::AccessibilityUIElement::height):
4160         (WTR::AccessibilityUIElement::clickPointX):
4161         (WTR::AccessibilityUIElement::clickPointY):
4162         (WTR::AccessibilityUIElement::intValue const):
4163         (WTR::AccessibilityUIElement::minValue):
4164         (WTR::AccessibilityUIElement::maxValue):
4165         (WTR::stringAtOffset):
4166
4167 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
4168
4169         test-webkitpy is broken on macOS Catalina
4170         https://bugs.webkit.org/show_bug.cgi?id=199078
4171
4172         Reviewed by Jonathan Bedard.
4173
4174         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
4175         to the runner.
4176         (main):
4177         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
4178
4179 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
4180
4181         Change status to "committer" in contributors.json
4182
4183         Unreviewed.
4184
4185         * Scripts/webkitpy/common/config/contributors.json:
4186
4187 2019-06-20  Alex Christensen  <achristensen@webkit.org>
4188
4189         Add unit test for UIContextMenuConfiguration API
4190         https://bugs.webkit.org/show_bug.cgi?id=199043
4191
4192         Reviewed by Wenson Hsieh.
4193
4194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4195         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
4196         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
4197         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
4198         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
4199         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
4200         (TEST):
4201         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
4202         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
4203         (-[TestContextMenuDriver delegate]):
4204         (-[TestContextMenuDriver setDelegate:]):
4205         (-[TestContextMenuDriver view]):
4206         (-[TestContextMenuDriver setView:]):
4207         (-[TestContextMenuDriver allowableMovement]):
4208         (-[TestContextMenuDriver setAllowableMovement:]):
4209         (-[TestContextMenuDriver primaryGestureRecognizer]):
4210         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
4211         (-[TestContextMenuDriver touchDuration]):
4212         (-[TestContextMenuDriver setTouchDuration:]):
4213         (-[TestContextMenuDriver locationInCoordinateSpace:]):
4214         (-[TestContextMenuDriver cancelInteraction]):
4215         (-[TestContextMenuDriver begin:]):
4216         (-[TestContextMenuDriver clickDown]):
4217         (-[TestContextMenuDriver clickUp]):
4218         (-[TestContextMenuDriver end]):
4219         * TestWebKitAPI/ios/UIKitSPI.h:
4220
4221 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
4222
4223         [ews-app] Status bubble should not turn orange when any build step is skipped
4224         https://bugs.webkit.org/show_bug.cgi?id=199079
4225
4226         Reviewed by Jonathan Bedard.
4227
4228         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4229
4230 2019-06-20  Alex Christensen  <achristensen@webkit.org>
4231
4232         Fix an internal engineering build after r246605
4233        ​https://bugs.webkit.org/show_bug.cgi?id=197800
4234
4235         * TestWebKitAPI/TCPServer.cpp:
4236
4237 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
4238
4239         [ews-build] Triggered builds should use same revision as parent build
4240         https://bugs.webkit.org/show_bug.cgi?id=198289
4241
4242         Reviewed by Jonathan Bedard.
4243
4244         * BuildSlaveSupport/ews-build/steps.py:
4245         (CheckOutSpecificRevision): Build step to checkout specific revision.
4246         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
4247         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
4248         (CheckOutSpecificRevision.start): Run appropriate git command.
4249         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
4250         builds use same revision as parent build.
4251         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4252         * BuildSlaveSupport/ews-build/factories.py:
4253         (Factory.__init__): Added CheckOutSpecificRevision step.
4254
4255 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
4256
4257         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
4258         https://bugs.webkit.org/show_bug.cgi?id=199073
4259
4260         Reviewed by Jonathan Bedard.
4261
4262         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
4263
4264 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
4265
4266         [GTK] Enable navigation swipe layout tests
4267         https://bugs.webkit.org/show_bug.cgi?id=198995
4268
4269         Reviewed by Michael Catanzaro.
4270
4271         Add a way for tests to enable and then control swipe gesture on GTK.
4272
4273         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
4274         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
4275         * WebKitTestRunner/PlatformGTK.cmake:
4276         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4277         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
4278         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
4279         (WTR::UIScriptController::beginBackSwipe):
4280         (WTR::UIScriptController::completeBackSwipe):
4281
4282 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
4283
4284         [GTK] HTTP layout tests don't run in flatpak
4285         https://bugs.webkit.org/show_bug.cgi?id=199067
4286
4287         Reviewed by Michael Catanzaro.
4288
4289         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
4290         check that path. Instead, add /app/lib/perl to Apache config directly.
4291
4292         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
4293         /.flatpak-info instead.
4294
4295         * Scripts/webkitpy/port/base.py:
4296         (Port._is_flatpak):
4297         (Port._in_flatpak_sandbox):
4298         * flatpak/flatpakutils.py:
4299         (WebkitFlatpak.run_in_sandbox):
4300         (is_sandboxed):
4301
4302 2019-06-18  Darin Adler  <darin@apple.com>
4303
4304         Tidy up the remaining bits of the AtomicString to AtomString rename
4305         https://bugs.webkit.org/show_bug.cgi?id=198990
4306
4307         Reviewed by Michael Catanzaro.
4308
4309         * Scripts/do-webcore-rename: Removed already-done renames.
4310         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
4311
4312 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4313
4314         [GTK] Remove support for GTK2 plugins
4315         https://bugs.webkit.org/show_bug.cgi?id=199065
4316
4317         Reviewed by Sergio Villar Senin.
4318
4319         * EWSTools/ubuntu-ews-packages:
4320         * TestWebKitAPI/PlatformGTK.cmake:
4321         * WebKitTestRunner/PlatformGTK.cmake:
4322         * flatpak/org.webkit.GTK.yaml:
4323         * gtk/install-dependencies:
4324
4325 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
4326
4327         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
4328         https://bugs.webkit.org/show_bug.cgi?id=199053
4329
4330         Reviewed by Saam Barati.
4331
4332         Added a test stressing IsoHeap with multiple threads.
4333
4334         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
4335         (assertHasObjects):
4336      &n