style-checker: Add UAF to the list of security words to warn about.
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         style-checker: Add UAF to the list of security words to warn about.
4         https://bugs.webkit.org/show_bug.cgi?id=208643
5
6         Reviewed by Jonathan Bedard.
7
8         UAF is a common acronym used for use after free.
9
10         * Scripts/webkitpy/style/checkers/changelog.py:
11         (ChangeLogChecker.check_for_unwanted_security_phrases):
12
13 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
14
15         [MSVC] Add .natvis support of WebKit types
16         https://bugs.webkit.org/show_bug.cgi?id=193119
17
18         Reviewed by Don Olmstead.
19
20         To help the WebKit developer while debugging, this file defines how
21         WebKit types are displayed in debugger of Visual Studio.
22         Very limited set of WebKit types, but it changes the world.
23
24         * VisualStudio/WebKit.natvis: Added.
25
26 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
27
28         Add system trace points around display list replay
29         https://bugs.webkit.org/show_bug.cgi?id=208616
30
31         Reviewed by Simon Fraser.
32
33         Add a new "Display list replay" trace point.
34
35         * Tracing/SystemTracePoints.plist:
36
37 2020-03-04  Alex Christensen  <achristensen@webkit.org>
38
39         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
40         https://bugs.webkit.org/show_bug.cgi?id=208615
41         <rdar://problem/59406743>
42
43         Reviewed by Alex Christensen.
44
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
47         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
48         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
49         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
50         (TEST):
51         Also make a test written in bug 206310 actually run code.
52
53 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
54
55         [build.webkit.org] Remove leaks queue
56         https://bugs.webkit.org/show_bug.cgi?id=208580
57
58         Reviewed by Jonathan Bedard.
59
60         * BuildSlaveSupport/build.webkit.org-config/config.json:
61         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
62         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
63
64 2020-03-04  Alex Christensen  <achristensen@webkit.org>
65
66         Add SPI to evaluate JavaScript in an iframe
67         https://bugs.webkit.org/show_bug.cgi?id=208605
68
69         Reviewed by Brady Eidson.
70
71         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
72
73 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
74
75         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
76         https://bugs.webkit.org/show_bug.cgi?id=208533
77         <rdar://problem/60010184>
78
79         Reviewed by Alex Christensen.
80
81         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
82         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
83         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
84         (TestWebKitAPI::TEST):
85         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
86         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
87
88 2020-03-04  Alex Christensen  <achristensen@webkit.org>
89
90         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
91         https://bugs.webkit.org/show_bug.cgi?id=208593
92
93         Reviewed by Brady Eidson.
94
95         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
96         (TestWebKitAPI::TEST):
97
98 2020-03-04  Alex Christensen  <achristensen@webkit.org>
99
100         WKWebView's frames accessor should return a traversable type
101         https://bugs.webkit.org/show_bug.cgi?id=208591
102
103         Reviewed by Brady Eidson.
104
105         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
106
107 2020-03-04  Antoine Quint  <graouts@apple.com>
108
109         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
110         https://bugs.webkit.org/show_bug.cgi?id=208575
111         <rdar://problem/59773690>
112
113         Reviewed by Brady Eidson.
114
115         Add new tests for the new SPI which check:
116         
117         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
118            specified WKWebView alone,
119         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
120         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
121         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
122         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
123         6. and that the same test also works with PSON enabled.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
126
127 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
128
129         [macOS] test-lldb-webkit failing on debug bots
130         https://bugs.webkit.org/show_bug.cgi?id=208545
131
132         Reviewed by Jonathan Bedard.
133
134         The lldb-webkit-test step must pass in the build configuration as an
135         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
136         binary that is downloaded with the rest of the build products. Without this
137         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
138         regardless of their actual build configuration.
139
140         * BuildSlaveSupport/build.webkit.org-config/steps.py:
141         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
142         * Scripts/test-lldb-webkit:
143         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
144
145 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
146
147         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
148         https://bugs.webkit.org/show_bug.cgi?id=208539
149
150         Unreviewed follow-up fix.
151
152         * BuildSlaveSupport/ews-build/steps.py:
153
154 2020-03-04  Daniel Bates  <dabates@apple.com>
155
156         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
157         https://bugs.webkit.org/show_bug.cgi?id=208565
158
159         Reviewed by Wenson Hsieh.
160
161         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
162         of its frame as a means to find all the editable elements in the visible content area
163         of the web view.
164
165         Coincidentally this makes no difference to the test results right now because the web view
166         happens to be located at the origin (0, 0) in the window. However if in the future the
167         web view would be located at some other point then the tests may fail because the rectangle
168         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
169         rectangle for the visible content area.
170
171         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
172         (TEST):
173
174 2020-03-04  Daniel Bates  <dabates@apple.com>
175
176         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
177         https://bugs.webkit.org/show_bug.cgi?id=208564
178
179         Reviewed by Alex Christensen.
180
181         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
182         to make it easy to run just these tests.
183
184         Currently, the tests are organized under the test case name WebKit. This means you need to
185         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
186         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
187         so that a person can run just these test using:
188         
189                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
190
191         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
192         (TEST):
193
194 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
195
196         [ews] Add build step to create local git commit for commit-queue
197         https://bugs.webkit.org/show_bug.cgi?id=208539
198
199         Reviewed by Jonathan Bedard.
200
201         * BuildSlaveSupport/ews-build/steps.py:
202         (CreateLocalGITCommit): Build step to create local git commit.
203         (CreateLocalGITCommit.start):
204         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
205         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
206         * BuildSlaveSupport/ews-build/factories.py:
207
208 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
209
210         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
211         https://bugs.webkit.org/show_bug.cgi?id=207948
212
213         Reviewed by Zalan Bujtas.
214
215         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
216         so that it receives the wheel events.
217
218         * DumpRenderTree/mac/EventSendingController.mm:
219         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
220         * DumpRenderTree/win/EventSender.cpp:
221         (mouseScrollBy):
222
223 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
224
225         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
226         https://bugs.webkit.org/show_bug.cgi?id=208520
227         <rdar://problem/60000214>
228
229         Reviewed by Chris Fleizach.
230
231         Calling InjectedBundle::singleton().page()->page() in the constructor
232         of the AccessibilityController is having this side effect on iOS.
233         So #if to MAC where it's actually being used.
234
235         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
236         (WTR::AccessibilityController::AccessibilityController):
237
238 2020-03-03  Alex Christensen  <achristensen@webkit.org>
239
240         Add SPI _WKResourceLoadInfo.loadedFromCache
241         https://bugs.webkit.org/show_bug.cgi?id=208554
242
243         Reviewed by Wenson Hsieh.
244
245         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
246         (TEST):
247
248 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
249
250         Batch observations and completions of text manipulations
251         https://bugs.webkit.org/show_bug.cgi?id=208406
252
253         Reviewed by Wenson Hsieh.
254
255         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
256         multiple paragraphs at once.
257
258         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
259         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
260         (-[TextManipulationDelegate items]):
261         (-[LegacyTextManipulationDelegate init]):
262         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
263         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
264         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
265         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
266         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
267         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
268         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
269
270 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
271
272         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
273         https://bugs.webkit.org/show_bug.cgi?id=208415
274
275         Reviewed by Brent Fulgham.
276
277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
278         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
279         (TEST):
280
281 2020-03-03  Alex Christensen  <achristensen@webkit.org>
282
283         Add response to _WKResourceLoadDelegate didCompleteWithError callback
284         https://bugs.webkit.org/show_bug.cgi?id=208553
285
286         Reviewed by Simon Fraser.
287
288         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
289         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
290         (TEST):
291         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
292
293 2020-03-03  Brady Eidson  <beidson@apple.com>
294
295         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
296         https://bugs.webkit.org/show_bug.cgi?id=198795
297
298         Reviewed by Chris Dumez.
299
300         This test appears to no longer be flaky.
301         
302         Let's re-enable it.
303         
304         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
305         (TestWebKitAPI::TEST):
306
307 2020-03-03  Alex Christensen  <achristensen@webkit.org>
308
309         Requests sent to _WKResourceLoadDelegate should include HTTPBody
310         https://bugs.webkit.org/show_bug.cgi?id=208550
311
312         Reviewed by Tim Hatcher.
313
314         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
315         (TEST):
316         * TestWebKitAPI/cocoa/HTTPServer.mm:
317         (TestWebKitAPI::HTTPServer::respondToRequests):
318         HTTPServer now looks for Content-Length in its request.
319         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
320
321 2020-03-03  Alex Christensen  <achristensen@webkit.org>
322
323         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
324         https://bugs.webkit.org/show_bug.cgi?id=208522
325
326         Reviewed by Brian Weinstein.
327
328         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
329         (TEST):
330
331 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
332
333         commit-queue should update working directory and reapply patch just before commiting
334         https://bugs.webkit.org/show_bug.cgi?id=208521
335
336         Reviewed by Jonathan Bedard.
337
338         * BuildSlaveSupport/ews-build/factories.py:
339
340 2020-03-03  Matt Lewis  <jlewis3@apple.com>
341
342         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
343         https://bugs.webkit.org/show_bug.cgi?id=208485
344
345         Reviewed by Jonathan Bedard.
346
347         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
348         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
349         that we don't have to recreate the variables that are already created.
350         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
351         from each module, rather than making extra imports that we don't need.
352         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
353         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
354         and not part of the host.
355         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
356         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
357         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
358         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
359         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
360         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
361         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
362         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
363         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
364         if we were geting any value at all
365         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
366         sure we aren't gabking the wrong key:value pair
367         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
368         come with the MockHosts and MockHost inherits from MockSystemHost.
369         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
370         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
371         to the various upload steps.
372
373 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
374
375         [ews] Add build step to find list of modified changelogs
376         https://bugs.webkit.org/show_bug.cgi?id=208514
377
378         Reviewed by Jonathan Bedard.
379
380         * BuildSlaveSupport/ews-build/factories.py:
381         * BuildSlaveSupport/ews-build/steps.py:
382         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
383         (FindModifiedChangeLogs.start): Initialize log observer.
384         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
385         (FindModifiedChangeLogs.evaluateCommand):
386         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
387         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
388         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
389         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
390
391 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
392
393         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
394         https://bugs.webkit.org/show_bug.cgi?id=208451
395
396         Unreviewed test gardening.
397
398         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
399
400 2020-03-03  Jiten Mehta  <jmehta@apple.com>
401
402         Adopt HTTP Alternative Services Storage
403         https://bugs.webkit.org/show_bug.cgi?id=208387
404
405         Reviewed by Alex Christensen.
406
407         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
408         (checkUntilEntryFound):
409         (TEST):
410
411 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
412
413         Check for navigation to app-bound domain during script evaluation
414         https://bugs.webkit.org/show_bug.cgi?id=208319
415         <rdar://problem/57569321>
416
417         Reviewed by Brent Fulgham.
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
421         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
422         (TEST):
423         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
424         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
425
426 2020-03-03  Commit Queue  <commit-queue@webkit.org>
427
428         Unreviewed, rolling out r257754.
429         https://bugs.webkit.org/show_bug.cgi?id=208513
430
431         Introduced API test failure (Requested by perarne on #webkit).
432
433         Reverted changeset:
434
435         "[Cocoa] Mapping from MIME type to UTI type should be done in
436         the UI process"
437         https://bugs.webkit.org/show_bug.cgi?id=208415
438         https://trac.webkit.org/changeset/257754
439
440 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
441
442         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
443         https://bugs.webkit.org/show_bug.cgi?id=208506
444
445         Reviewed by Carlos Garcia Campos.
446
447         * WebKitTestRunner/TestController.cpp:
448         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
449
450 2020-03-02  Ben Nham  <nham@apple.com>
451
452         Add performance probes for HTML parsing
453         https://bugs.webkit.org/show_bug.cgi?id=208271
454
455         Reviewed by Daniel Bates.
456
457         This adds probes that show which lines of HTML are have been parsed.
458
459         * Tracing/SystemTracePoints.plist:
460
461 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
462
463         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
464         https://bugs.webkit.org/show_bug.cgi?id=208415
465
466         Reviewed by Brent Fulgham.
467
468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
469         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
470         (TEST):
471
472 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
473
474         Unreviewed, rolling out r257725.
475
476         This commit caused 10 API tests to fail
477
478         Reverted changeset:
479
480         "[Cocoa] Mapping from MIME type to UTI type should be done in
481         the UI process"
482         https://bugs.webkit.org/show_bug.cgi?id=208415
483         https://trac.webkit.org/changeset/257725
484
485 2020-03-02  Saam Barati  <sbarati@apple.com>
486
487         Don't skip tests unnecessarily on arm64
488         https://bugs.webkit.org/show_bug.cgi?id=208470
489         <rdar://problem/59968869>
490
491         Reviewed by Tadeu Zagallo.
492
493         * Scripts/run-jsc-stress-tests:
494
495 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
496
497         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
498         https://bugs.webkit.org/show_bug.cgi?id=208434
499
500         Reviewed by Chris Fleizach.
501
502         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
503         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
504         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
505         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
506         (WTR::AccessibilityController::accessibleElementById): Same as above.
507
508 2020-03-02  John Wilander  <wilander@apple.com>
509
510         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
511         https://bugs.webkit.org/show_bug.cgi?id=208399
512         <rdar://problem/24731650>
513
514         Reviewed by Brent Fulgham.
515
516         The majority of the changes in WTR::TestController is (partially) fixing a bug
517         where the TestRunner would statically use the default website datastore instead
518         of the website data store configure for the page. This worked for persistent
519         storage testing but not for ephemeral sessions which is what this patch is all
520         about. The previous TestController::websiteDataStore() is now called
521         TestController::defaultWebsiteDataStore() and the new
522         TestController::websiteDataStore() returns the configured website data store.
523         Most of the use of the default website data store should probably change but
524         that's not really for this patch to deal with. I did however move all of
525         resource load statistics' use to the new TestController::websiteDataStore().
526
527         A new TestRunner function was added: isStatisticsEphemeral()
528         It allows test cases to query the ephemeral status of resource load statistics.
529
530         One problem that is mitigated in this patch but not fully fixed is that for
531         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
532         TestController::generatePageConfiguration() via C API 
533         WKPageConfigurationSetWebsiteDataStore(), and then again in 
534         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
535         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
536         I tried removing the latter since one session for all platforms should be
537         Enough but got broken behavior as a result. So now both are still there
538         and both enable resource load statistics.
539
540         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
541         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
542         (WTR::TestRunner::isStatisticsEphemeral):
543         * WebKitTestRunner/InjectedBundle/TestRunner.h:
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::TestController::defaultWebsiteDataStore):
546         (WTR::TestController::websiteDataStore):
547         (WTR::TestController::generatePageConfiguration):
548         (WTR::TestController::resetPreferencesToConsistentValues):
549         (WTR::TestController::resetStateToConsistentValues):
550         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
551         (WTR::TestController::decidePolicyForNavigationAction):
552         (WTR::TestController::platformAdjustContext):
553         (WTR::TestController::clearServiceWorkerRegistrations):
554         (WTR::TestController::clearDOMCache):
555         (WTR::TestController::clearDOMCaches):
556         (WTR::TestController::clearIndexedDatabases):
557         (WTR::TestController::clearLocalStorage):
558         (WTR::TestController::hasDOMCache):
559         (WTR::TestController::domCacheSize):
560         (WTR::TestController::setStatisticsEnabled):
561         (WTR::TestController::isStatisticsEphemeral):
562         (WTR::TestController::setStatisticsDebugMode):
563         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
564         (WTR::TestController::setStatisticsLastSeen):
565         (WTR::TestController::setStatisticsMergeStatistic):
566         (WTR::TestController::setStatisticsPrevalentResource):
567         (WTR::TestController::setStatisticsVeryPrevalentResource):
568         (WTR::TestController::dumpResourceLoadStatistics):
569         (WTR::TestController::isStatisticsPrevalentResource):
570         (WTR::TestController::isStatisticsVeryPrevalentResource):
571         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
572         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
573         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
574         (WTR::TestController::setStatisticsHasHadUserInteraction):
575         (WTR::TestController::isStatisticsHasHadUserInteraction):
576         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
577         (WTR::TestController::setStatisticsGrandfathered):
578         (WTR::TestController::isStatisticsGrandfathered):
579         (WTR::TestController::setUseITPDatabase):
580         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
581         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
582         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
583         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
584         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
585         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
586         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
587         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
588         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
589         (WTR::TestController::statisticsUpdateCookieBlocking):
590         (WTR::TestController::statisticsSubmitTelemetry):
591         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
592         (WTR::TestController::setStatisticsIsRunningTest):
593         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
594         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
595         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
596         (WTR::TestController::setStatisticsGrandfatheringTime):
597         (WTR::TestController::setStatisticsMaxStatisticsEntries):
598         (WTR::TestController::setStatisticsPruneEntriesDownTo):
599         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
600         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
601         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
602         (WTR::TestController::statisticsDeleteCookiesForHost):
603         (WTR::TestController::isStatisticsHasLocalStorage):
604         (WTR::TestController::setStatisticsCacheMaxAgeCap):
605         (WTR::TestController::hasStatisticsIsolatedSession):
606         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
607         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
608         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
609         (WTR::TestController::statisticsResetToConsistentState):
610         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
611         * WebKitTestRunner/TestController.h:
612         * WebKitTestRunner/TestInvocation.cpp:
613         (WTR::TestInvocation::invoke):
614         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
615         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
616         (WTR::initializeWebViewConfiguration):
617         (WTR::TestController::platformCreateWebView):
618
619 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
620
621         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
622         https://bugs.webkit.org/show_bug.cgi?id=208415
623
624         Reviewed by Brent Fulgham.
625
626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
627         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
628         (TEST):
629
630 2020-03-02  Daniel Bates  <dabates@apple.com>
631
632         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
633         https://bugs.webkit.org/show_bug.cgi?id=208352
634         <rdar://problem/59867815>
635
636         Reviewed by Wenson Hsieh.
637
638         Update test results to reflect the new behavior. To do this I also need to fix up the test code
639         to actually scroll the web content. This also means we now execute the same code on both Mac and
640         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
641         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
642         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
643
644         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
645         (TEST):
646
647 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
648
649         Unreviewed, rolling out r257687.
650
651         This commit caused debug tests to crash for macOS & iOS
652
653         Reverted changeset:
654
655         "[Cocoa] Mapping from MIME type to UTI type should be done in
656         the UI process"
657         https://bugs.webkit.org/show_bug.cgi?id=208415
658         https://trac.webkit.org/changeset/257687
659
660 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
661
662         Unreviewed, rolling out r257618.
663
664         This allegedly causes Safari to crash when closing a window
665         (see rdar://problem/59922725).
666
667         Reverted changeset:
668
669         "UIProcess crash after using _prepareForMoveToWindow, then
670         deallocating the WKWebView before moving to the window"
671         https://bugs.webkit.org/show_bug.cgi?id=208365
672         https://trac.webkit.org/changeset/257618
673
674 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
675
676         Remove std::lock_guard
677         https://bugs.webkit.org/show_bug.cgi?id=206451
678
679         Reviewed by Anders Carlsson.
680
681         Add std::lock_guard lint rule to prevent from using it.
682
683         * Scripts/webkitpy/style/checkers/cpp.py:
684         (check_lock_guard):
685         (check_style):
686         (CppChecker):
687         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
688         (WebKitStyleTest.test_lock_guard):
689         * TestWebKitAPI/Tests/WTF/Condition.cpp:
690         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
691         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
692         (assertHasObjects):
693         (assertHasOnlyObjects):
694         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
695         (WTR::AXThread::dispatch):
696         (WTR::AXThread::dispatchFunctionsFromAXThread):
697         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
698         (WTR::AXThread::initializeRunLoop):
699
700 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
701
702         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
703         https://bugs.webkit.org/show_bug.cgi?id=208415
704
705         Reviewed by Brent Fulgham.
706
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
709         (TEST):
710
711 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
712
713         Unreviewed, rolling out r257565.
714
715         It broke WinCairo MiniBrowser
716
717         Reverted changeset:
718
719         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
720         https://bugs.webkit.org/show_bug.cgi?id=206894
721         https://trac.webkit.org/changeset/257565
722
723 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
724
725         EWS fails to retry build in case of kill-old-processes exception
726         https://bugs.webkit.org/show_bug.cgi?id=208003
727
728         Reviewed by Jonathan Bedard.
729
730         * BuildSlaveSupport/ews-build/steps.py:
731         (KillOldProcesses.evaluateCommand):
732         (KillOldProcesses.getResultSummary):
733
734 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
735
736         [ews] commit-queue should update the ChangeLog with Reviewer name
737         https://bugs.webkit.org/show_bug.cgi?id=206535
738
739         Reviewed by Jonathan Bedard.
740
741         * BuildSlaveSupport/ews-build/steps.py:
742         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
743
744 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
745
746         run-javascriptcore-tests: Make upload format valid
747         https://bugs.webkit.org/show_bug.cgi?id=208341
748
749         Rubber-stamped by Aakash Jain.
750
751         * Scripts/run-javascriptcore-tests:
752         (uploadResults): Remove. FIXME.
753         * Scripts/webkitdirs.pm:
754         (splitVersionString): Handle case where the subminor version number has a - in it.
755         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
756
757 2020-02-28  youenn fablet  <youenn@apple.com>
758
759         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
760         https://bugs.webkit.org/show_bug.cgi?id=208130
761
762         Reviewed by Eric Carlson.
763
764         * WebKitTestRunner/TestOptions.h:
765         Use GPU process to capture by default.
766         We will remove this option once done verifying that every test works smoothly.
767
768 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
769
770         [ews] commit queue should skip building and testing for rollout patches
771         https://bugs.webkit.org/show_bug.cgi?id=208329
772
773         Reviewed by Jonathan Bedard.
774
775         * BuildSlaveSupport/ews-build/steps.py:
776         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
777         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
778         (RunWebKit1Tests.doStepIf): Ditto.
779         * BuildSlaveSupport/ews-build/steps_unittest.py:
780         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
781         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
782
783 2020-02-28  Daniel Bates  <dabates@apple.com>
784
785         Update my watch list preferences and contributor's entry.
786
787         * Scripts/webkitpy/common/config/contributors.json:
788         * Scripts/webkitpy/common/config/watchlist:
789
790 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
791
792         Fix WebCore export macros for declspec
793         https://bugs.webkit.org/show_bug.cgi?id=208363
794
795         Reviewed by Konstantin Tokarev.
796
797         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
798         files. Removed precompiled headers that were empty.
799
800         * DumpRenderTree/DumpRenderTreePrefix.h:
801         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
802         * MiniBrowser/win/stdafx.h:
803         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
804         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
805         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
806         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
807         * WebKitTestRunner/PlatformFTW.cmake:
808         * WebKitTestRunner/PlatformWin.cmake:
809         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
810
811 2020-02-27  Tim Horton  <timothy_horton@apple.com>
812
813         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
814         https://bugs.webkit.org/show_bug.cgi?id=208365
815
816         Reviewed by Alex Christensen.
817
818         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
819         (TEST):
820         Add a test! It was a 100% repro crash before this change.
821
822 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
823
824         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
825         https://bugs.webkit.org/show_bug.cgi?id=208260
826         <rdar://problem/59820107>
827
828         Reviewed by Tim Horton.
829
830         Followed instructions for adding an Info.plist for Single-File Tools
831         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
832
833         The default WebsiteDataStore file path will change with this test to
834         reflect the new bundleID so we must change expectations for any api
835         tests which rely on knowing the path.
836
837         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
839         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
840         (TEST):
841         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
842         (TEST):
843         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
844         (TEST):
845         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
846         (TEST):
847         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
848         (TEST):
849         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
850         (TEST):
851         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
852         (TEST):
853         (defaultWebsiteCacheDirectory):
854         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
855         (TEST):
856         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
857         (TEST):
858         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
859         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
860         (TEST):
861         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
862         (TEST):
863         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
864         (runWebsiteDataStoreCustomPaths):
865         (TEST):
866         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
867         (TestWebKitAPI::resetTestState):
868         Now that we set a bundleID, we have to reset the cache model between
869         tests, otherwise it gets stored between tests.
870
871         (TestWebKitAPI::TEST):
872         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
873         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
874
875 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
876
877         TextManipulationController should not generate a new item for content in manipulated paragraphs
878         https://bugs.webkit.org/show_bug.cgi?id=208286
879
880         Reviewed by Wenson Hsieh.
881
882         Added a regression test.
883
884         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
885         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
886
887 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
888
889         run-javascriptcore-tests: Make upload format valid
890         https://bugs.webkit.org/show_bug.cgi?id=208341
891
892         Reviewed by Aakash Jain.
893
894         * Scripts/run-javascriptcore-tests:
895         (uploadResults): Print json blob for upload after failure for debugging.
896
897 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
898
899         [CMake] Add WebKit::PAL target
900         https://bugs.webkit.org/show_bug.cgi?id=198493
901
902         Reviewed by Michael Catanzaro.
903
904         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
905
906         * DumpRenderTree/PlatformWin.cmake:
907
908 2020-02-27  Alex Christensen  <achristensen@webkit.org>
909
910         Add SPI to query WKFrameInfos in a WKWebView
911         https://bugs.webkit.org/show_bug.cgi?id=208212
912
913         Reviewed by Brady Eidson.
914
915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
916         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
917         * WebKitTestRunner/TestController.cpp:
918         (WTR::TestController::saltForOrigin):
919
920 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
921
922         Unreviewed, rolling out r257530.
923
924         This commit seems to have broke the build internally for
925         watchOS
926
927         Reverted changeset:
928
929         "Add SPI to query WKFrameInfos in a WKWebView"
930         https://bugs.webkit.org/show_bug.cgi?id=208212
931         https://trac.webkit.org/changeset/257530
932
933 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
934
935         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
936         https://bugs.webkit.org/show_bug.cgi?id=206894
937
938         Reviewed by Adrian Perez de Castro.
939
940         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
941         MiniBrowsers.
942
943         * MiniBrowser/gtk/CMakeLists.txt:
944         * MiniBrowser/win/CMakeLists.txt:
945         * MiniBrowser/wpe/CMakeLists.txt:
946
947 2020-02-26  Alex Christensen  <achristensen@webkit.org>
948
949         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
950         https://bugs.webkit.org/show_bug.cgi?id=206456
951
952         Reviewed by Brady Eidson.
953
954         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
955         (TEST):
956
957 2020-02-26  Alex Christensen  <achristensen@webkit.org>
958
959         _WKUserContentWorld should be a wrapper around WKContentWorld
960         https://bugs.webkit.org/show_bug.cgi?id=208274
961
962         Reviewed by Brady Eidson.
963
964         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
965         (TEST):
966         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
967         (TEST):
968
969 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
970
971         Unreviewed, rolling out r257522.
972
973         Caused 16 API test failures on the bots
974
975         Reverted changeset:
976
977         "TestWebKitAPI and WebKitTestRunner should have bundle
978         identifiers"
979         https://bugs.webkit.org/show_bug.cgi?id=208260
980         https://trac.webkit.org/changeset/257522
981
982 2020-02-26  Alex Christensen  <achristensen@webkit.org>
983
984         Add SPI to query WKFrameInfos in a WKWebView
985         https://bugs.webkit.org/show_bug.cgi?id=208212
986
987         Reviewed by Brady Eidson.
988
989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
990         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
991         * WebKitTestRunner/TestController.cpp:
992         (WTR::TestController::saltForOrigin):
993
994 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
995
996         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
997         https://bugs.webkit.org/show_bug.cgi?id=208260
998         <rdar://problem/59820107>
999
1000         Reviewed by Tim Horton.
1001
1002         Followed instructions for adding an Info.plist for Single-File Tools
1003         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1004
1005         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1006         * TestWebKitAPI/Info.plist: Added.
1007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1008         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1009         * WebKitTestRunner/Info.plist: Added.
1010         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1011
1012 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
1013
1014         Tests should each use a unique ResourceLoadStatistics file path for its database store
1015         https://bugs.webkit.org/show_bug.cgi?id=208206
1016         <rdar://problem/59690272>
1017
1018         Reviewed by Brady Eidson.
1019
1020         Initialize a default website data store before checking for the ITP
1021         store to ensure the directory exists after the file has been deleted.
1022
1023         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1024         (TEST):
1025
1026 2020-02-26  Christopher Reid  <chris.reid@sony.com>
1027
1028         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
1029         https://bugs.webkit.org/show_bug.cgi?id=197684
1030         <rdar://problem/59467397>
1031
1032         Reviewed by Yusuke Suzuki.
1033
1034         Add test for FileSystem::createFile
1035
1036         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1037
1038 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
1039
1040         [ews] commit-queue should verify patch committer and reviewer
1041         https://bugs.webkit.org/show_bug.cgi?id=206532
1042
1043         Reviewed by Jonathan Bedard.
1044
1045         * BuildSlaveSupport/ews-build/steps.py:
1046         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
1047         (ValidateCommiterAndReviewer._addToLog):
1048         (ValidateCommiterAndReviewer.getResultSummary):
1049         (ValidateCommiterAndReviewer.fail_build):
1050         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
1051         (ValidateCommiterAndReviewer.is_reviewer):
1052         (ValidateCommiterAndReviewer.is_committer):
1053         (ValidateCommiterAndReviewer.full_name_from_email):
1054         (ValidateCommiterAndReviewer.start):
1055
1056 2020-02-26  Daniel Bates  <dabates@apple.com>
1057
1058         [iOS] Send focus update immediately on becoming or resigning first responder
1059         https://bugs.webkit.org/show_bug.cgi?id=208082
1060         <rdar://problem/59688413>
1061
1062         Rubber-stamped by Jer Noble.
1063
1064         Add a test to ensure that selecting a position at a point after the web view
1065         becomes first responder is allowed. Such an operation is only allowed if the
1066         web view is focused.
1067
1068         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1069         (-[TestWKWebView selectPositionAtPoint:]):
1070         (TEST):
1071         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
1072
1073 2020-02-26  Chris Dumez  <cdumez@apple.com>
1074
1075         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
1076
1077         The test was added for macOS and times out on iOS.
1078
1079         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1080         (TEST):
1081
1082 2020-02-26  Youenn Fablet  <youenn@apple.com>
1083
1084         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
1085         https://bugs.webkit.org/show_bug.cgi?id=208238
1086
1087         Reviewed by Eric Carlson.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1090         (TEST):
1091         Remove use of deleted parameter.
1092
1093 2020-02-25  Devin Rousso  <drousso@apple.com>
1094
1095         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
1096         https://bugs.webkit.org/show_bug.cgi?id=206911
1097         <rdar://problem/58026635>
1098
1099         Reviewed by Brian Burg.
1100
1101         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1102         (TestWebKitAPI::TEST):
1103         Add test for `WTF::HashSet::reserveInitialCapacity`.
1104
1105         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1106         (TestWebKitAPI::TEST):
1107         Actually check the value of `WTF::HashMap::capacity`.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
1110         (-[InspectorDelegate _webView:didAttachInspector:])
1111         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
1112         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
1113         (TestWebKitAPI::TEST):
1114         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1115         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
1116         (TestWebKitAPI::TEST): Deleted.
1117
1118 2020-02-25  Matt Lewis  <jlewis3@apple.com>
1119
1120         Add checkout_root to stubrepository.py
1121         https://bugs.webkit.org/show_bug.cgi?id=208213
1122
1123         Reviewed by Jonathan Bedard.
1124
1125         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1126         (StubRepository.__init__):
1127
1128         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
1129         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
1130
1131 2020-02-25  Daniel Bates  <dabates@apple.com>
1132
1133         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
1134         https://bugs.webkit.org/show_bug.cgi?id=208214
1135
1136         Reviewed by Wenson Hsieh.
1137
1138         Wait until the copy operation completes before loading the second web view and testing paste
1139         to ensure that something was actually copied to the clipboard.
1140
1141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
1142         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1143         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
1144         so that we wait until the command completes.
1145
1146 2020-02-25  Chris Dumez  <cdumez@apple.com>
1147
1148         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
1149         https://bugs.webkit.org/show_bug.cgi?id=208199
1150         <rdar://problem/59746887>
1151
1152         Reviewed by Alex Christensen.
1153
1154         Add API test coverage.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1157         (TEST):
1158
1159 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1160
1161         spinRunLoop should take a non-zero integer as parameter
1162         https://bugs.webkit.org/show_bug.cgi?id=208148
1163         <rdar://problem/59766682>
1164
1165         Unreviewed iOS build fix.
1166
1167         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1168         (TestWebKitAPI::Util::spinRunLoop):
1169
1170 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1171
1172         spinRunLoop should take a non-zero integer as parameter
1173         https://bugs.webkit.org/show_bug.cgi?id=208148
1174
1175         Reviewed by Darin Adler.
1176
1177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1178         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1179         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1180         (TestWebKitAPI::Util::spinRunLoop):
1181
1182 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1183
1184         [WTF] Add tests for CompactRefPtrTuple
1185         https://bugs.webkit.org/show_bug.cgi?id=208172
1186
1187         Reviewed by Darin Adler.
1188
1189         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
1190         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
1191
1192         * TestWebKitAPI/CMakeLists.txt:
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
1195         (TestWebKitAPI::TEST):
1196
1197 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
1198
1199         [ews] commit-queue should check that patch have appropriate review flag
1200         https://bugs.webkit.org/show_bug.cgi?id=208138
1201
1202         Reviewed by Jonathan Bedard.
1203
1204         * BuildSlaveSupport/ews-build/steps.py:
1205         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
1206         (BugzillaMixin._is_patch_cq_plus):
1207         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
1208         (ValidatePatch.start):
1209
1210 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
1211
1212         [WebAuthn] Implement SPI for the platform authenticator
1213         https://bugs.webkit.org/show_bug.cgi?id=208087
1214         <rdar://problem/59369305>
1215
1216         Reviewed by Brent Fulgham.
1217
1218         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
1219
1220         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
1221         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1223         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1224         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
1225         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
1226         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
1227         (TestWebKitAPI::TEST):
1228         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
1229         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
1230         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
1231         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
1232
1233 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1234
1235         Unreviewed, updating LLDB test for CompactPointerTuple.
1236         https://bugs.webkit.org/show_bug.cgi?id=207827
1237
1238         * lldb/lldb_webkit.py:
1239         (WTFCompactPointerTupleProvider):
1240         (WTFCompactPointerTupleProvider.update):
1241
1242 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
1243
1244         Provide alternate way to name Web Content process
1245         https://bugs.webkit.org/show_bug.cgi?id=205224
1246         rdar://57038084
1247
1248         Reviewed by Alex Christensen.
1249
1250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1251         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
1252         (TestWebKitAPI::TEST):
1253
1254 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
1255
1256         results.webkit.org: Link to result archives
1257         https://bugs.webkit.org/show_bug.cgi?id=207646
1258         <rdar://problem/59395807>
1259
1260         Rubber-stamped by Aakash Jain.
1261
1262         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
1263         (_ArchiveRouter): Retrieve json from archive-router endpoint.
1264         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
1265         return the most specific value.
1266         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
1267         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
1268         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
1269         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1270         (parametersForInstance): Extract from lambda function.
1271         (testRunLink): Use parametersForInstance instead of a lambda function.
1272         (archiveLink): Return an archive link for data. 
1273         (contentForData): Add archive link to view.
1274         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1275         (TimelineFromEndpoint): Accept both suite and test.
1276         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
1277         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
1278         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
1279         * resultsdbpy/resultsdbpy/view/view_routes.py:
1280         (ViewRoutes.__init__): Add archive_route dictionary.
1281
1282 2020-02-24  Alex Christensen  <achristensen@webkit.org>
1283
1284         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
1285         https://bugs.webkit.org/show_bug.cgi?id=208035
1286         <rdar://problem/58011337>
1287
1288         Reviewed by Tim Hatcher.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1291
1292 2020-02-22  Darin Adler  <darin@apple.com>
1293
1294         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
1295         https://bugs.webkit.org/show_bug.cgi?id=208099
1296
1297         Reviewed by Antti Koivisto.
1298
1299         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1300         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
1301         so we can use the -[NSString createJSStringRef] method.
1302         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
1303         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
1304
1305 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1306
1307         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
1308         https://bugs.webkit.org/show_bug.cgi?id=208096
1309         <rdar://problem/59632008>
1310
1311         Reviewed by Alexey Proskuryakov.
1312
1313         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
1314         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
1315         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
1316
1317         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
1318         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
1319         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
1320         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
1321         in the credit card expiry field.
1322
1323         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
1324
1325         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1326         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1327         (WTR::UIScriptController::setDefaultCalendarType):
1328         * WebKitTestRunner/TestController.h:
1329
1330         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
1331         identifier and calendar locale identifier.
1332
1333         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1334         (WTR::swizzledCalendar):
1335         (WTR::TestController::overriddenCalendarIdentifier const):
1336         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
1337
1338         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
1339
1340         (WTR::TestController::setDefaultCalendarType):
1341
1342         Plumb the new calendar's locale identifier through this method.
1343
1344         (WTR::TestController::cocoaResetStateToConsistentValues):
1345         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
1346         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1347         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1348         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
1349
1350 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
1351
1352         App-bound domains should have separate Network Sessions
1353         https://bugs.webkit.org/show_bug.cgi?id=208026
1354         <rdar://problem/59434006>
1355
1356         Reviewed by Brent Fulgham.
1357
1358         This patch is mostly test infrastructure involving 3 functions.
1359         One sets in-app browser privacy as enabled in the network process
1360         manually for the test. One ensures that setting the WebView category
1361         works properly, and the last one checks for an app-bound session for
1362         an app-bound navigation.
1363
1364         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1365         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1366         (WTR::InjectedBundle::didReceiveMessageToPage):
1367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1368         (WTR::TestRunner::getWebViewCategory):
1369         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
1370         (WTR::TestRunner::hasAppBoundSession):
1371         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
1372         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
1373         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1374         * WebKitTestRunner/TestController.cpp:
1375         (WTR::TestController::ensureViewSupportsOptionsForTest):
1376         Clearing the bundleID should happen right before setting a new one, 
1377         otherwise it clears the ID after it is set and returns a null ID.
1378
1379         (WTR::TestController::resetStateToConsistentValues):
1380         (WTR::TestController::getWebViewCategory):
1381         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
1382         (WTR::inAppBrowserPrivacyBooleanResultCallback):
1383         (WTR::inAppBrowserPrivacyVoidResultCallback):
1384         (WTR::TestController::hasAppBoundSession):
1385         (WTR::TestController::setInAppBrowserPrivacyEnabled):
1386         * WebKitTestRunner/TestController.h:
1387         * WebKitTestRunner/TestInvocation.cpp:
1388         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1389         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1390         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
1391         (WTR::TestInvocation::didReceivePrevalentDomains):
1392         (WTR::TestInvocation::didReceiveWebViewCategory):
1393         * WebKitTestRunner/TestInvocation.h:
1394         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1395         (WTR::TestController::getWebViewCategory):
1396
1397 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
1398
1399         Build DumpRenderTree and WebKitTestRunner for macCatalyst
1400         https://bugs.webkit.org/show_bug.cgi?id=208068
1401         <rdar://problem/59676596>
1402
1403         Reviewed by Tim Horton.
1404
1405         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
1406         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1407         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
1408         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
1409         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
1410         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
1411         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
1412         * DumpRenderTree/mac/EventSendingController.h: Ditto.
1413         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
1414         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1415         * Makefile: Add DumpRenderTree and WebKitTestRunner.
1416         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1417         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
1418         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1419
1420 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1421
1422         [ews] Add build step to Validate ChangeLog for commit-queue
1423         https://bugs.webkit.org/show_bug.cgi?id=208064
1424
1425         Reviewed by Jonathan Bedard.
1426
1427         * BuildSlaveSupport/ews-build/steps.py:
1428         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
1429         (ValidateChangeLogAndReviewer.start):
1430         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
1431         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
1432
1433 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1434
1435         [ews] Add build step to set cq- flag on bugzilla patch
1436         https://bugs.webkit.org/show_bug.cgi?id=208021
1437
1438         Reviewed by Jonathan Bedard.
1439
1440         * BuildSlaveSupport/ews-build/steps.py:
1441         (BugzillaMixin.set_cq_minus_flag_on_patch):
1442         (SetCommitQueueMinusFlagOnPatch):
1443         (SetCommitQueueMinusFlagOnPatch.start):
1444         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
1445
1446 2020-02-20  Matt Lewis  <jlewis3@apple.com>
1447
1448         Stub repositories fail to upload some results due to missing head svn revision
1449         https://bugs.webkit.org/show_bug.cgi?id=207684
1450
1451         Reviewed by Jonathan Bedard.
1452
1453         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
1454         (MockHost.__init__):
1455         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1456         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1457         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1458         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
1459         * Scripts/webkitpy/port/base.py:
1460         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
1461         from using mock SCMs and more
1462         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
1463
1464 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
1465
1466         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
1467         https://bugs.webkit.org/show_bug.cgi?id=208051
1468
1469         Reviewed by Carlos Alberto Lopez Perez.
1470
1471         Verbose flag prints out each test name executed. Without this flag
1472         stdout prints out one or two periods.
1473
1474         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1475         (RunJavaScriptCoreTests.start):
1476
1477 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
1478
1479         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
1480         https://bugs.webkit.org/show_bug.cgi?id=207984
1481
1482         Reviewed by Daniel Bates.
1483
1484         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1485         (TestWebKitAPI::TEST):
1486
1487 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
1488
1489         [GTK] Improve user agent quirk for Google Docs and Google Drive
1490         https://bugs.webkit.org/show_bug.cgi?id=206506
1491
1492         Reviewed by Carlos Garcia Campos.
1493
1494         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1495         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1496         (TestWebKitAPI::TEST):
1497
1498 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1499
1500         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
1501         https://bugs.webkit.org/show_bug.cgi?id=207380
1502
1503         Reviewed by Jonathan Bedard.
1504
1505         Added a new rule 'build/export_macro'.
1506
1507         Removed a obsolete rule 'readability/webkit_export' which was used
1508         only by Chromium port (r148185).
1509
1510         * Scripts/webkitpy/style/checkers/cpp.py:
1511         (_FunctionState.export_macro):
1512         (check_function_definition):
1513         (_unix_path): Added.
1514         (is_generated_file): Use _unix_path.
1515         (check_has_config_header): Ditto.
1516         (CppChecker):
1517         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1518         (WebKitStyleTest.test_export_macro_check):
1519         (WebKitStyleTest.test_webkit_export_check): Deleted.
1520
1521 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1522
1523         [Win][MiniBrowser] Add prettier toolbar button icons
1524         https://bugs.webkit.org/show_bug.cgi?id=207999
1525
1526         Reviewed by Ross Kirsling.
1527
1528         Use a custom toolbar button icons instead of system stock icons.
1529
1530         Fixed a bug toolbar button dropdown arrows always looked being
1531         hovered. TBSTYLE_FLAT should be given.
1532
1533         Removed the window border line of Progress Indicator.
1534
1535         * MiniBrowser/win/MainWindow.cpp:
1536         (MainWindow::createToolbar):
1537         * MiniBrowser/win/MiniBrowserLib.rc:
1538         * MiniBrowser/win/MiniBrowserLibResource.h:
1539         * MiniBrowser/win/toolbar.bmp: Added.
1540
1541 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
1542
1543         Update run-webkit-tests help description for skip-failing-tests
1544         https://bugs.webkit.org/show_bug.cgi?id=208031
1545
1546         Reviewed by Alexey Proskuryakov.
1547
1548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1549
1550 2020-02-20  Chris Dumez  <cdumez@apple.com>
1551
1552         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
1553         https://bugs.webkit.org/show_bug.cgi?id=208015
1554         <rdar://problem/59591630>
1555
1556         Reviewed by Geoffrey Garen.
1557
1558         Add API test coverage.
1559
1560         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
1561         (TEST):
1562
1563 2020-02-20  Tim Horton  <timothy_horton@apple.com>
1564
1565         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
1566         https://bugs.webkit.org/show_bug.cgi?id=207998
1567         <rdar://problem/40942425>
1568
1569         Reviewed by Sam Weinig.
1570
1571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1572         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
1573         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1574         (TestWebKitAPI::TEST):
1575         Add some tests for top content insets.
1576
1577 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
1578
1579         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
1580         https://bugs.webkit.org/show_bug.cgi?id=207910
1581
1582         Unreviewed infrastructure fix.
1583
1584         * Scripts/run-javascriptcore-tests:
1585         (configurationForUpload): Use the major version instead of the sub-minor version
1586         for version name.
1587
1588 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
1589
1590         [CMake] Add WPE::libwpe target
1591         https://bugs.webkit.org/show_bug.cgi?id=207970
1592
1593         Reviewed by Adrian Perez de Castro.
1594
1595         Use the WPE::libwpe target.
1596
1597         * MiniBrowser/wpe/CMakeLists.txt:
1598         * TestWebKitAPI/PlatformWPE.cmake:
1599         * TestWebKitAPI/glib/PlatformWPE.cmake:
1600         * wpe/backends/CMakeLists.txt:
1601
1602 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1603
1604         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
1605         https://bugs.webkit.org/show_bug.cgi?id=207749
1606
1607         Reviewed by Ross Kirsling.
1608
1609         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
1610
1611         * MiniBrowser/win/MainWindow.cpp:
1612         (MainWindow::createToolbar):
1613         (MainWindow::WndProc):
1614         (MainWindow::setDefaultURLToCurrentURL):
1615         (MainWindow::goHome): Added.
1616         (MainWindow::onURLBarEnter):
1617         * MiniBrowser/win/MainWindow.h:
1618         * MiniBrowser/win/MiniBrowserLib.rc:
1619         * MiniBrowser/win/MiniBrowserLibResource.h:
1620         * MiniBrowser/win/MiniBrowserReplace.h:
1621         * MiniBrowser/win/WinMain.cpp:
1622         (wWinMain):
1623
1624 2020-02-19  Peng Liu  <peng.liu6@apple.com>
1625
1626         Fix check-webkit-style errors related to AVFoundationSPI.h
1627         https://bugs.webkit.org/show_bug.cgi?id=207834
1628
1629         Reviewed by Daniel Bates.
1630
1631         Revert the change in r256770 regarding the headers ordering.
1632         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
1633
1634         * Scripts/webkitpy/style/checkers/cpp.py:
1635         (check_include_line):
1636
1637 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
1638
1639         results.webkit.org: Correctly report JSC tests for windows
1640         https://bugs.webkit.org/show_bug.cgi?id=207910
1641
1642         Rubber-stamped by Aakash Jain.
1643
1644         * Scripts/run-javascriptcore-tests:
1645         (configurationForUpload): Give Windows a version name.
1646         * Scripts/webkitdirs.pm:
1647         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
1648         Version dictionary.
1649
1650 2020-02-19  Chris Dumez  <cdumez@apple.com>
1651
1652         Unreviewed, fix assertions in storage access API layout tests after r256882.
1653
1654         Drop dead testRunner code to toggle storage access API feature.
1655
1656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1658         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
1659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1660         * WebKitTestRunner/TestInvocation.cpp:
1661         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1662
1663 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
1664
1665         [WPE] Support 2D axis, smooth-motion events
1666         https://bugs.webkit.org/show_bug.cgi?id=207881
1667
1668         Reviewed by Carlos Garcia Campos.
1669
1670         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
1671
1672 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
1673
1674         Unreviewed, rolling out r256851.
1675
1676         Broke internal bots
1677
1678         Reverted changeset:
1679
1680         "Stub repositories fail to upload some results due to missing
1681         head svn revision"
1682         https://bugs.webkit.org/show_bug.cgi?id=207684
1683         https://trac.webkit.org/changeset/256851
1684
1685 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1686
1687         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
1688         https://bugs.webkit.org/show_bug.cgi?id=207883
1689
1690         Reviewed by Ross Kirsling.
1691
1692         Unlike other mouse buttons, 4th and 5th mouse buttons are
1693         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
1694         WM_XBUTTONUP events to the window under the mouse cursor.
1695         Unhandled WM_XBUTTONUP events are automatically converted to
1696         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
1697         parent window.
1698         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
1699
1700         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
1701         handled.
1702
1703         * MiniBrowser/win/BrowserWindow.h:
1704         * MiniBrowser/win/MainWindow.cpp:
1705         (MainWindow::WndProc):
1706         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1707         (WebKitBrowserWindow::navigateForwardOrBackward):
1708         * MiniBrowser/win/WebKitBrowserWindow.h:
1709         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1710         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
1711         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1712
1713 2020-02-18  Alex Christensen  <achristensen@webkit.org>
1714
1715         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
1716         https://bugs.webkit.org/show_bug.cgi?id=207912
1717         <rdar://problem/59556922>
1718
1719         Reviewed by Brian Weinstein.
1720
1721         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1722         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1723         (TEST):
1724         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1725         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
1726
1727 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1728
1729         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
1730         https://bugs.webkit.org/show_bug.cgi?id=207899
1731         <rdar://problem/55658207>
1732
1733         Reviewed by Tim Horton and Simon Fraser.
1734
1735         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
1736
1737         * WebKitTestRunner/TestController.cpp:
1738         (WTR::updateTestOptionsFromTestHeader):
1739         * WebKitTestRunner/TestOptions.h:
1740         (WTR::TestOptions::hasSameInitializationOptions const):
1741         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1742         (WTR::TestController::platformCreateWebView):
1743
1744 2020-02-18  Matt Lewis  <jlewis3@apple.com>
1745
1746         Stub repositories fail to upload some results due to missing head svn revision
1747         https://bugs.webkit.org/show_bug.cgi?id=207684
1748
1749         Reviewed by Jonathan Bedard.
1750
1751         * Scripts/webkitpy/api_tests/run_api_tests.py:
1752         (main): Added initializing the scm to the host object.
1753         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1754         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1755         it in line with modern code.
1756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1757         (main): Added inializing the scm to the host object.
1758         * Scripts/webkitpy/port/base.py:
1759         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
1760         from using mock SCMs and more
1761         * Scripts/webkitpy/test/main.py:
1762         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
1763         and converted the webkit_root variable to the SCM checkout root.
1764         (Tester._run_tests):
1765
1766 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
1767
1768         Move [UIDevice currentDevice] calls to UI process
1769         https://bugs.webkit.org/show_bug.cgi?id=204320
1770
1771         Reviewed by Darin Adler.
1772
1773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1774         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
1775         (TEST):
1776
1777 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
1778
1779         Move from "layer flush" terminology to "rendering update"
1780         https://bugs.webkit.org/show_bug.cgi?id=207870
1781
1782         Reviewed by Tim Horton.
1783
1784         Rename various functions and member variables to move away from the legacy "layer flush"
1785         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
1786         that we have layers is an implementation detail.
1787         
1788         Change LayerFlushThrottlingState to be an OptionSet<>.
1789
1790         * Tracing/SystemTracePoints.plist:
1791
1792 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
1793
1794         [Webkit.css] Adding popover style element
1795         This help to prevent us reinventing the wheel ever again
1796         https://bugs.webkit.org/show_bug.cgi?id=207787
1797
1798         Reviewed by Dean Jackson.
1799
1800         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
1801         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1802         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1803         (.popover):
1804         (.popover>.content):
1805         (.popover.display):
1806         (.popover .arrow):
1807         (.popover .arrow.point-top):
1808         (.popover .arrow.point-bottom):
1809         (.popover .arrow.point-left):
1810         (.popover .arrow.point-right):
1811         (@media (prefers-color-scheme: dark) .popover>.content):
1812         (@media (prefers-color-scheme: dark) .popover.display):
1813         (@media (prefers-color-scheme: dark) .popover .arrow):
1814         (.popover>.content>.section): Deleted.
1815         (.popover:focus>.content, .popover:hover>.content): Deleted.
1816         (.popover.right>.content): Deleted.
1817         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
1818         (.popover.left>.content): Deleted.
1819         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
1820         (.popover.bottom>.content): Deleted.
1821         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
1822
1823 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
1824
1825         Update WebKit Tools to issue mach extensions as needed
1826         https://bugs.webkit.org/show_bug.cgi?id=207850
1827         <rdar://problem/59521019>
1828
1829         Reviewed by Per Arne Vollan.
1830
1831         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
1832         to its child processes (WebContent, GPU, Network, etc.) as needed.
1833
1834         * MiniBrowser/MiniBrowser.entitlements:
1835         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
1836         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1838         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
1839
1840 2020-02-17  Peng Liu  <peng.liu6@apple.com>
1841
1842         Fix check-webkit-style errors related to AVFoundationSPI.h
1843         https://bugs.webkit.org/show_bug.cgi?id=207834
1844
1845         Reviewed by Eric Carlson.
1846
1847         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
1848         Soft-link headers can be included as either "file.h" or <file.h>.
1849
1850         * Scripts/webkitpy/style/checkers/cpp.py:
1851         (_classify_include):
1852         (check_include_line):
1853
1854 2020-02-17  Keith Rollin  <krollin@apple.com>
1855
1856         Unreviewed build fix after r256715.
1857
1858         Fix tvOS and watchOS builds.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1861
1862 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
1863
1864         Use CF prefs direct mode in the WebContent process
1865         https://bugs.webkit.org/show_bug.cgi?id=203420
1866
1867         Reviewed by Brent Fulgham.
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
1871         (TEST):
1872
1873 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1874
1875         EWS should be able to file Bugzilla bugs
1876         https://bugs.webkit.org/show_bug.cgi?id=207845
1877
1878         Reviewed by Alexey Proskuryakov.
1879
1880         * BuildSlaveSupport/ews-build/steps.py:
1881         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
1882
1883 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1884
1885         EWS should be able to comment on Bugzilla
1886         https://bugs.webkit.org/show_bug.cgi?id=201927
1887
1888         Reviewed by Jonathan Bedard.
1889
1890         * BuildSlaveSupport/ews-build/steps.py:
1891         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
1892         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
1893         (BugzillaMixin.close_bug): Ditto.
1894         (CommentOnBug): Build step to comment on bugzilla bug.
1895
1896 2020-02-17  Antti Koivisto  <antti@apple.com>
1897
1898         [macOS] Add trace points for layer flush runloop observer
1899         https://bugs.webkit.org/show_bug.cgi?id=207837
1900
1901         Reviewed by Sam Weinig.
1902
1903         * Tracing/SystemTracePoints.plist:
1904
1905 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
1906
1907         [CMake] Use builtin targets
1908         https://bugs.webkit.org/show_bug.cgi?id=205166
1909
1910         Reviewed by Darin Adler.
1911
1912         * TestWebKitAPI/PlatformWin.cmake:
1913
1914 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1915
1916         [ews] add SetBuildSummary step for Windows EWS
1917         https://bugs.webkit.org/show_bug.cgi?id=207556
1918
1919         Reviewed by Jonathan Bedard.
1920
1921         * BuildSlaveSupport/ews-build/factories.py:
1922         (WindowsFactory.__init__):
1923         (GTKBuildAndTestFactory.__init__):
1924         * BuildSlaveSupport/ews-build/factories_unittest.py:
1925         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
1926
1927 2020-02-17  Alberto Garcia  <berto@igalia.com>
1928
1929         [WPE] Change the QML plugin install path
1930         https://bugs.webkit.org/show_bug.cgi?id=207761
1931
1932         Reviewed by Philippe Normand.
1933
1934         * Scripts/run-qt-wpe-minibrowser:
1935         * glib/api_test_runner.py:
1936         (TestRunner._run_test_qt):
1937
1938 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1939
1940         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
1941         https://bugs.webkit.org/show_bug.cgi?id=207746
1942
1943         Reviewed by Don Olmstead.
1944
1945         * MiniBrowser/win/stdafx.h:
1946
1947 2020-02-16  Brady Eidson  <beidson@apple.com>
1948
1949         Expose "allowsContentJavaScript" on WKWebpagePreferences
1950         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
1951
1952         Reviewed by Darin Adler.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1955         (TEST):
1956         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1957         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1958         (TEST):
1959         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
1960         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1961         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1962         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1963         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
1964         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
1965         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1966         * TestWebKitAPI/cocoa/TestWKWebView.h:
1967         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1968         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
1969
1970 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
1971
1972         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
1973         https://bugs.webkit.org/show_bug.cgi?id=207747
1974
1975         Reviewed by Keith Miller.
1976
1977         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
1978         (TestWebKitAPI::TEST):
1979
1980 2020-02-14  Alex Christensen  <achristensen@webkit.org>
1981
1982         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
1983         https://bugs.webkit.org/show_bug.cgi?id=207360
1984         <rdar://problem/57825317>
1985
1986         Reviewed by Ryosuke Niwa.
1987
1988         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1989         (TestWebKitAPI::TEST):
1990
1991 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
1992
1993         [CMake] Add Fontconfig::Fontconfig target
1994         https://bugs.webkit.org/show_bug.cgi?id=207730
1995
1996         Reviewed by Adrian Perez de Castro.
1997
1998         Use the Fontconfig::Fontconfig target.
1999
2000         * WebKitTestRunner/PlatformGTK.cmake:
2001
2002 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
2003
2004          Expose prevalent domains on a per-page basis
2005          https://bugs.webkit.org/show_bug.cgi?id=207523
2006          <rdar://problem/59270758>
2007
2008         Reviewed by Chris Dumez.
2009
2010         Added WebKitTestRunner functions so this functionality can be tested.
2011         clearPrevalentDomains should be called between tests to reset the
2012         state.
2013
2014         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2015         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2016         (WTR::InjectedBundle::didReceiveMessageToPage):
2017         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2018         (WTR::TestRunner::getPrevalentDomains):
2019         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
2020         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2021         * WebKitTestRunner/TestController.cpp:
2022         (WTR::TestController::resetStateToConsistentValues):
2023         (WTR::TestController::getPrevalentDomains):
2024         (WTR::TestController::clearPrevalentDomains):
2025         * WebKitTestRunner/TestController.h:
2026         * WebKitTestRunner/TestInvocation.cpp:
2027         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2028         (WTR::TestInvocation::didReceivePrevalentDomains):
2029         * WebKitTestRunner/TestInvocation.h:
2030         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2031         (WTR::TestController::getPrevalentDomains):
2032         (WTR::TestController::clearPrevalentDomains):
2033
2034 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2035
2036         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
2037         https://bugs.webkit.org/show_bug.cgi?id=207682
2038
2039         Reviewed by Ross Kirsling.
2040
2041         The toolbar placed button common controls as the toolbar buttons.
2042         However, because these buttons are focusable, shortcut keys don't
2043         work after clicking them.
2044
2045         Added Home button, Add to Bookmarks button, dropdown buttons of
2046         back and forward buttons, but they aren't implemented yet. Just
2047         placeholders at the moment.
2048
2049         * MiniBrowser/win/MainWindow.cpp:
2050         (MainWindow::createToolbar): Added.
2051         (MainWindow::resizeToolbar): Added.
2052         (MainWindow::rescaleToolbar): Added.
2053         (MainWindow::init):
2054         (MainWindow::resizeSubViews):
2055         (MainWindow::updateDeviceScaleFactor):
2056         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
2057
2058 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2059
2060         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
2061         https://bugs.webkit.org/show_bug.cgi?id=207676
2062
2063         Reviewed by Wenson Hsieh and Timothy Hatcher.
2064
2065         Added regression tests for pasting content with -apple-system-label and outdenting content.
2066
2067         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2068         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
2069         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
2070
2071 2020-02-13  Alex Christensen  <achristensen@webkit.org>
2072
2073         _WKResourceLoadInfo should conform to NSSecureCoding
2074         https://bugs.webkit.org/show_bug.cgi?id=207667
2075
2076         Reviewed by Brady Eidson.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2079         (TEST):
2080
2081 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
2082
2083         [PlayStation] Add Buildbots for Debug/Release builds
2084         https://bugs.webkit.org/show_bug.cgi?id=199454
2085
2086         Reviewed by Aakash Jain.
2087
2088         * BuildSlaveSupport/build.webkit.org-config/config.json:
2089         Add PlayStation slaves, builders
2090         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2091         Use higher timeout for playstation as with win bot
2092         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2093         Set PlayStation category for playstation platform
2094         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2095         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
2096         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2097         Add PlayStation expectations
2098
2099 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
2100
2101         [iOS] Check if PIP is supported in the UI process
2102         https://bugs.webkit.org/show_bug.cgi?id=207406
2103
2104         Reviewed by Brent Fulgham.
2105
2106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2107         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
2108         (TEST):
2109
2110 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2111
2112         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
2113         https://bugs.webkit.org/show_bug.cgi?id=207397
2114         <rdar://problem/59268128>
2115
2116         Reviewed by Jer Noble.
2117
2118         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2119         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2120
2121 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2122
2123         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
2124         https://bugs.webkit.org/show_bug.cgi?id=207696
2125
2126         Reviewed by Tim Horton.
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2129
2130 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2131
2132         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
2133         https://bugs.webkit.org/show_bug.cgi?id=207680
2134         <rdar://problem/59340940>
2135
2136         Reviewed by Tim Horton.
2137
2138         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
2139         the current selection works.
2140
2141         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2142         (-[TestWKWebView updateSelectionWithExtentPoint:]):
2143         * TestWebKitAPI/ios/UIKitSPI.h:
2144
2145 2020-02-13  Said Abou-Hallawa  <said@apple.com>
2146
2147         Unreviewed, rolling out r255158, 255405 and r255486
2148
2149         Caused test flakiness and PLT regression.
2150
2151         * DumpRenderTree/mac/DumpRenderTree.mm:
2152         (resetWebPreferencesToConsistentValues):
2153         * DumpRenderTree/win/DumpRenderTree.cpp:
2154         (enableExperimentalFeatures):
2155         * WebKitTestRunner/TestController.cpp:
2156         (WTR::TestController::resetPreferencesToConsistentValues):
2157
2158 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2159
2160         run-javascriptcore-tests: Allow insecure requests on upload
2161         https://bugs.webkit.org/show_bug.cgi?id=207662
2162
2163         Rubber-stamped by Aakash Jain.
2164
2165         * Scripts/run-javascriptcore-tests:
2166         (uploadResults): Allow insecure curl request when posting results.
2167
2168 2020-02-12  Truitt Savell  <tsavell@apple.com>
2169
2170         Unreviewed, rolling out r256463.
2171
2172         Caused major flakiness on Mac wk2
2173
2174         Reverted changeset:
2175
2176         "REGRESSION (r255158): http/tests/frame-throttling/raf-
2177         throttle-in-cross-origin-subframe.html is a flaky failure"
2178         https://bugs.webkit.org/show_bug.cgi?id=206839
2179         https://trac.webkit.org/changeset/256463
2180
2181 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2182
2183         results.webkit.org: Remove debug JS logging
2184         https://bugs.webkit.org/show_bug.cgi?id=207663
2185
2186         Reviewed by Aakash Jain.
2187
2188         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2189         (elapsed):
2190         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2191         (_ToolTip.prototype.toString):
2192         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2193         (prototype.addWithDelay):
2194         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
2195
2196 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
2197
2198         Remove CSS_DEVICE_ADAPTATION
2199         https://bugs.webkit.org/show_bug.cgi?id=203479
2200
2201         Reviewed by Tim Horton.
2202         
2203         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
2204         so remove the code.
2205
2206         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2207
2208 2020-02-12  Said Abou-Hallawa  <said@apple.com>
2209
2210         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
2211         https://bugs.webkit.org/show_bug.cgi?id=206839
2212
2213         Reviewed by Simon Fraser.
2214
2215         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
2216
2217         * DumpRenderTree/mac/DumpRenderTree.mm:
2218         (resetWebPreferencesToConsistentValues):
2219         * DumpRenderTree/win/DumpRenderTree.cpp:
2220         (enableExperimentalFeatures):
2221         * WebKitTestRunner/TestController.cpp:
2222         (WTR::TestController::resetPreferencesToConsistentValues):
2223
2224 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2225
2226         results.webkit.org: Cache archive content
2227         https://bugs.webkit.org/show_bug.cgi?id=207589
2228
2229         Reviewed by Aakash Jain.
2230
2231         * resultsdbpy/resultsdbpy/flask_support/util.py:
2232         (cache_for): Add decorator function which sets the cache values on the returned response.
2233         * resultsdbpy/resultsdbpy/view/archive_view.py:
2234         (ArchiveView): Cache archive content client-side for 12 hours.
2235         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
2236         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
2237
2238 2020-02-12  Youenn Fablet  <youenn@apple.com>
2239
2240         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2241         https://bugs.webkit.org/show_bug.cgi?id=207537
2242
2243         Reviewed by Chris Dumez.
2244
2245         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2246
2247 2020-02-11  Rob Buis  <rbuis@igalia.com>
2248
2249         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
2250         <https://webkit.org/b/207424>
2251         <rdar://problem/59250384>
2252
2253         Reviewed by Rob Buis.
2254
2255         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2256         (TestWebKitAPI::TEST): Add more tests.
2257
2258 2020-02-11  Commit Queue  <commit-queue@webkit.org>
2259
2260         Unreviewed, rolling out r256314.
2261         https://bugs.webkit.org/show_bug.cgi?id=207594
2262
2263         It is breaking an API test (Requested by youenn on #webkit).
2264
2265         Reverted changeset:
2266
2267         "WebSWServerConnection::registerServiceWorkerClient is not
2268         sending IPC message to UIProcess when it should"
2269         https://bugs.webkit.org/show_bug.cgi?id=207537
2270         https://trac.webkit.org/changeset/256314
2271
2272 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
2273
2274         results.webkit.org: Configuration documentation should include architecture
2275         https://bugs.webkit.org/show_bug.cgi?id=207584
2276
2277         Reviewed by Aakash Jain.
2278
2279         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
2280
2281 2020-02-11  Youenn Fablet  <youenn@apple.com>
2282
2283         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
2284         https://bugs.webkit.org/show_bug.cgi?id=207325
2285         <rdar://problem/59224810>
2286
2287         Reviewed by Eric Carlson.
2288
2289         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2290         (TestWebKitAPI::TEST):
2291         Add a test validating that RTCRtpSender.getCapabilities does not return null.
2292         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2293
2294 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2295
2296         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
2297         https://bugs.webkit.org/show_bug.cgi?id=207557
2298
2299         Reviewed by Jonathan Bedard.
2300
2301         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
2302         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
2303         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
2304         around this by focusing an empty select element instead (for which we won't attempt to create and select any
2305         table view cells).
2306
2307         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2308
2309 2020-02-11  Alex Christensen  <achristensen@webkit.org>
2310
2311         Add WKHTTPCookieStore._getCookiesForURL SPI
2312         https://bugs.webkit.org/show_bug.cgi?id=207527
2313
2314         Reviewed by Brady Eidson.
2315
2316         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2317         (TEST):
2318
2319 2020-02-11  Youenn Fablet  <youenn@apple.com>
2320
2321         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2322         https://bugs.webkit.org/show_bug.cgi?id=207537
2323
2324         Reviewed by Chris Dumez.
2325
2326         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2327
2328 2020-02-11  Lauro Moura  <lmoura@igalia.com>
2329
2330         [WPE][WebDriver] MiniBrowser should react to close session commands
2331         https://bugs.webkit.org/show_bug.cgi?id=207529
2332
2333         Reviewed by Carlos Garcia Campos.
2334
2335         WebDriver delete session command asks to close the WebView associated to the
2336         current automation session. We must react to it to avoid lots of
2337         timeouts and errors.
2338
2339         * MiniBrowser/wpe/main.cpp:
2340         (main): Listen to "close" signal on the main WebView.
2341
2342 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2343
2344         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
2345         https://bugs.webkit.org/show_bug.cgi?id=207525
2346         <rdar://problem/59110543>
2347
2348         Reviewed by Tim Horton.
2349
2350         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
2351         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
2352         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
2353         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
2354         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
2355         causing us to crash upon trying to create the dictionary.
2356
2357         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
2358         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
2359         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
2360         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
2361         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
2362         beginning of each API test.
2363
2364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2365         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2366         (overrideBundleIdentifier):
2367
2368         Move this to the top of the file, so it can be shared.
2369
2370         (+[WKWebView initialize]):
2371
2372         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
2373         internal class method that calls into the internal helper function, with no other side effects.
2374
2375         * TestWebKitAPI/ios/UIKitSPI.h:
2376
2377 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2378
2379         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
2380         https://bugs.webkit.org/show_bug.cgi?id=207501
2381         <rdar://problem/59323414>
2382
2383         Reviewed by Alex Christensen.
2384
2385         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2386         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
2387         The same behavior.
2388
2389 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
2390
2391         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
2392         https://bugs.webkit.org/show_bug.cgi?id=207352
2393         <rdar://problem/59115798>
2394
2395         Reviewed by Alex Christensen.
2396
2397         Add a test to exercise the new SPI.
2398
2399         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
2400         a webpage that contains text in subframes.
2401
2402
2403 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2404
2405         [iOS] Crash when granting access to asset services
2406         https://bugs.webkit.org/show_bug.cgi?id=207520
2407
2408         Reviewed by Brent Fulgham.
2409
2410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2411         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
2412         (TEST):
2413
2414 2020-02-10  Chris Dumez  <cdumez@apple.com>
2415
2416         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
2417         https://bugs.webkit.org/show_bug.cgi?id=207481
2418
2419         Reviewed by Alexey Proskuryakov.
2420
2421         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
2422         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
2423         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
2424
2425         * DumpRenderTree/mac/DumpRenderTree.mm:
2426         (resetWebViewToConsistentStateBeforeTesting):
2427         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
2428         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
2429         over internal settings.
2430
2431 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2432
2433         [watchOS] Notification listener is never unregistered
2434         https://bugs.webkit.org/show_bug.cgi?id=207459
2435
2436         Reviewed by Maciej Stachowiak.
2437
2438         Add a test which tests that posting a backlight level change notification will not cause a crash.
2439
2440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2441         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
2442         (TEST):
2443
2444 2020-02-10  James Howard  <jameshoward@mac.com>
2445
2446         Standard gamepad mapping for GameControllerGamepads
2447         https://bugs.webkit.org/show_bug.cgi?id=206033
2448
2449         Reviewed by Dean Jackson.
2450
2451         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2452         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2453         (WTR::TestRunner::setMockGamepadDetails):
2454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2455         * WebKitTestRunner/TestInvocation.cpp:
2456         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2457
2458 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews] Display flaky layout test names in build summary
2461         https://bugs.webkit.org/show_bug.cgi?id=207504
2462
2463         Reviewed by Jonathan Bedard.
2464
2465         * BuildSlaveSupport/ews-build/steps.py:
2466         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
2467         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
2468         (AnalyzeLayoutTestsResults.start):
2469
2470 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2471
2472         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
2473         https://bugs.webkit.org/show_bug.cgi?id=207492
2474
2475         Reviewed by Jonathan Bedard.
2476
2477         * BuildSlaveSupport/ews-build/steps.py:
2478         (RunWebKitTests.evaluateCommand):
2479         (ReRunWebKitTests.evaluateCommand):
2480         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2481         * BuildSlaveSupport/ews-build/factories.py:
2482         (TestFactory.__init__):
2483
2484 2020-02-10  Truitt Savell  <tsavell@apple.com>
2485
2486         Unreviewed, rolling out r256091.
2487
2488         Broke internal builds
2489
2490         Reverted changeset:
2491
2492         "Move trivial definitions from FeatureDefines.xcconfig to
2493         PlatformEnableCocoa.h"
2494         https://bugs.webkit.org/show_bug.cgi?id=207155
2495         https://trac.webkit.org/changeset/256091
2496
2497 2020-02-10  Truitt Savell  <tsavell@apple.com>
2498
2499         Unreviewed, rolling out r256103.
2500
2501         This patch is blocking the rollout of r256091
2502
2503         Reverted changeset:
2504
2505         "Move JavaScriptCore related feature defines from
2506         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
2507         https://bugs.webkit.org/show_bug.cgi?id=207436
2508         https://trac.webkit.org/changeset/256103
2509
2510 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2511
2512         results.webkit.org: Abstract archive storage solutions
2513         https://bugs.webkit.org/show_bug.cgi?id=207277
2514
2515         Rubber-stamped by Aakash Jain.
2516
2517         * resultsdbpy/resultsdbpy/model/archive_context.py:
2518         (ArchiveContext):
2519         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
2520         (ArchiveContext.__init__): Add archiver member.
2521         (ArchiveContext.__enter__): archiver is a context manager.
2522         (ArchiveContext.__exit__): Ditto.
2523         (ArchiveContext.register): The archiver member owns saving an archive.
2524         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
2525         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
2526         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
2527         (Archiver): Base class for all Archiving systems.
2528         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
2529         (Archiver.archive_size): Given a file-like archive, calculate it's size.
2530         (Archiver.save):
2531         (Archiver.retrieve):
2532         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
2533         (CassandraArchiver):
2534         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
2535         (CassandraArchiver.__init__):
2536         (CassandraArchiver.__enter__):
2537         (CassandraArchiver.__exit__):
2538         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
2539         from ArchiveContext.
2540         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
2541         from ArchiveContext.
2542
2543 2020-02-09  Lauro Moura  <lmoura@igalia.com>
2544
2545         [GTK][WPE] Expose allowTopNavigationToDataURL
2546         https://bugs.webkit.org/show_bug.cgi?id=207384
2547
2548         Reviewed by Adrian Perez de Castro.
2549
2550         Updates with new "allow-top-navigation-to-data-urls" property.
2551
2552         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2553         (testWebViewAllowModalDialogs): This test requires this property to be
2554         set.
2555         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2556         (testWebKitSettings): Added tests for getter/setter.
2557
2558 2020-02-08  Sam Weinig  <weinig@apple.com>
2559
2560         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2561         https://bugs.webkit.org/show_bug.cgi?id=207436
2562
2563         Reviewed by Tim Horton.
2564
2565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2566         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
2567
2568 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
2569
2570         [WTF] Try using 75% load factor for HashTable
2571         https://bugs.webkit.org/show_bug.cgi?id=207183
2572
2573         Reviewed by Mark Lam.
2574
2575         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2576         (TestWebKitAPI::testInitialCapacity):
2577
2578 2020-02-08  Sam Weinig  <weinig@apple.com>
2579
2580         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2581         https://bugs.webkit.org/show_bug.cgi?id=207155
2582
2583         Reviewed by Tim Horton.
2584
2585         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2586         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2587         also has a default value in PlatformEnable.h
2588
2589         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2590
2591 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2592
2593         Several iOS API tests that call -makeKeyWindow assert after r255907
2594         https://bugs.webkit.org/show_bug.cgi?id=207411
2595
2596         Reviewed by Tim Horton.
2597
2598         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
2599         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
2600         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
2601         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
2602
2603         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2604         (TestWebKitAPI::TEST):
2605         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
2606         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2607         (overrideBundleIdentifier):
2608         (setOverriddenApplicationKeyWindow):
2609
2610 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2611
2612         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
2613         https://bugs.webkit.org/show_bug.cgi?id=207405
2614
2615         Reviewed by Wenson Hsieh.
2616
2617         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2618
2619 2020-02-07  Alex Christensen  <achristensen@apple.com>
2620
2621         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
2622         https://bugs.webkit.org/show_bug.cgi?id=207409
2623         rdar://problem/59275641
2624
2625         Reviewed by Chris Dumez.
2626
2627         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2628         (TestWebKitAPI::TEST):
2629
2630 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
2631
2632         Unreviewed, rolling out r256051.
2633
2634         Broke internal builds.
2635
2636         Reverted changeset:
2637
2638         "Move trivial definitions from FeatureDefines.xcconfig to
2639         PlatformEnableCocoa.h"
2640         https://bugs.webkit.org/show_bug.cgi?id=207155
2641         https://trac.webkit.org/changeset/256051
2642
2643 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2644
2645         iPad testers failing to launch processes
2646         https://bugs.webkit.org/show_bug.cgi?id=207401
2647         <rdar://problem/58184777>
2648
2649         Unreviewed infrastructure fix.
2650
2651         This is a speculative fix because I've had problems reproducing this error.
2652         The only time I managed to reproduce the problem was immediately after killing the 
2653         SimulatorTrampoline and CoreSimulator.xpc processes.
2654
2655         * BuildSlaveSupport/kill-old-processes:
2656         (main): Only kill Simulator.app, not all associated simulator processes.
2657
2658 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
2659
2660         [WebAuthn] Report CTAP Client Pin Error to clients
2661         https://bugs.webkit.org/show_bug.cgi?id=205837
2662         <rdar://problem/58356872>
2663
2664         Reviewed by Brent Fulgham.
2665
2666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2667         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2668         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2669         (TestWebKitAPI::TEST):
2670         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2671         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
2672         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2673         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2674         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
2675         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2676         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
2677         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
2678
2679 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2680
2681         run-safari Doesn't work with the latest Xcode version and iOS
2682         https://bugs.webkit.org/show_bug.cgi?id=207394
2683
2684         Reviewed by Ryosuke Niwa.
2685
2686         * Scripts/webkitdirs.pm:
2687         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
2688         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
2689
2690 2020-02-07  Daniel Bates  <dabates@apple.com>
2691
2692         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
2693         https://bugs.webkit.org/show_bug.cgi?id=207366
2694
2695         Reviewed by Brent Fulgham.
2696
2697         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
2698         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
2699         as the actual test instead of under a platform-specific directory even when the tests' behavior
2700         depends on the link-time version of WebKit.
2701
2702         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
2703         and toggling them in a test.
2704
2705         * DumpRenderTree/mac/DumpRenderTree.mm:
2706         (setDefaultsToConsistentValuesForTesting):
2707
2708 2020-02-03  Sam Weinig  <weinig@apple.com>
2709
2710         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2711         https://bugs.webkit.org/show_bug.cgi?id=207155
2712
2713         Reviewed by Tim Horton.
2714
2715         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2716         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2717         also has a default value in PlatformEnable.h
2718
2719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2720
2721 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
2722
2723         Update WebView category name to be more accurate
2724         https://bugs.webkit.org/show_bug.cgi?id=207334
2725         <rdar://problem/59224855>
2726
2727         Reviewed by Brent Fulgham.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2730         (TEST):
2731
2732 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
2733
2734         [ews] add commit-queue build step to close the bug
2735         https://bugs.webkit.org/show_bug.cgi?id=207387
2736
2737         Reviewed by Jonathan Bedard.
2738
2739         * BuildSlaveSupport/ews-build/steps.py:
2740         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
2741         (CloseBug): Build step to close bugzilla bug.
2742
2743 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews] add commit-queue build step to clear flags on patch
2746         https://bugs.webkit.org/show_bug.cgi?id=206536
2747
2748         Reviewed by Jonathan Bedard.
2749
2750         * BuildSlaveSupport/ews-build/steps.py:
2751         (BugzillaMixin): Class for common bugzilla related methods.
2752         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
2753         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
2754         (ValidatePatch):
2755         (RemoveFlagsOnPatch): Class to remove flags on patch.
2756         (RemoveFlagsOnPatch.start):
2757         (ValidatePatch._addToLog): Moved.
2758         (ValidatePatch.fetch_data_from_url): Moved.
2759         (ValidatePatch.get_patch_json): Moved.
2760         (ValidatePatch.get_bug_json): Moved.
2761         (ValidatePatch.get_bug_id_from_patch): Moved.
2762         (ValidatePatch._is_patch_obsolete): Moved.
2763         (ValidatePatch._is_patch_review_denied): Moved.
2764         (ValidatePatch._is_patch_cq_plus): Moved.
2765         (ValidatePatch._is_bug_closed): Moved.
2766
2767 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2768
2769         EWS should run resultsdbpy tests
2770         https://bugs.webkit.org/show_bug.cgi?id=201928
2771
2772         Reviewed by Aakash Jain.
2773
2774         * BuildSlaveSupport/ews-build/factories.py:
2775         (ServicesFactory.__init__): Add RunResultsdbpyTests.
2776         * BuildSlaveSupport/ews-build/factories_unittest.py:
2777         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
2778         * BuildSlaveSupport/ews-build/steps.py:
2779         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
2780         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
2781         * BuildSlaveSupport/ews-build/steps_unittest.py:
2782         (TestRunResultsdbpyTests):
2783         (TestRunResultsdbpyTests.setUp):
2784         (TestRunResultsdbpyTests.tearDown):
2785         (TestRunResultsdbpyTests.test_success):
2786         (TestRunResultsdbpyTests.test_failure):
2787
2788 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
2789
2790         Adding myself to contributors.json
2791         
2792         Unreviewed
2793
2794         * Scripts/webkitpy/common/config/contributors.json:
2795
2796 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
2797
2798         Adding myself to contributors.json
2799         
2800         Unreviewed
2801
2802         * Scripts/webkitpy/common/config/contributors.json:
2803
2804 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
2805
2806         [GTK][WPE] Add same-site cookie support
2807         https://bugs.webkit.org/show_bug.cgi?id=204137
2808
2809         Reviewed by Carlos Garcia Campos.
2810
2811         Update libsoup to 2.69.90 in JHBuild.
2812
2813         * gtk/jhbuild.modules:
2814         * wpe/jhbuild.modules:
2815
2816 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
2817
2818         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
2819         https://bugs.webkit.org/show_bug.cgi?id=207183
2820
2821         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2822         (TestWebKitAPI::testInitialCapacity):
2823
2824 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2825
2826         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
2827         https://bugs.webkit.org/show_bug.cgi?id=207350
2828         <rdar://problem/59239914>
2829
2830         Reviewed by Tim Horton.
2831
2832         Add a test to exercise the corner case in the SPI.
2833
2834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2835         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
2836
2837 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
2838
2839         Adopt new SOAuthorizationOption constants
2840         https://bugs.webkit.org/show_bug.cgi?id=207186
2841         <rdar://problem/48909336>
2842
2843         Reviewed by Brent Fulgham.
2844
2845         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2846         (checkAuthorizationOptions):
2847
2848 2020-02-06  Brady Eidson  <beidson@apple.com>
2849
2850         Cleanup and promote WKContentWorld and its clients in WKWebView.
2851         https://bugs.webkit.org/show_bug.cgi?id=207351
2852
2853         Reviewed by Alex Christensen.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2856         (TestWebKitAPI::TEST):
2857         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2858         (TEST):
2859         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2860         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
2861
2862 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2863
2864         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
2865         https://bugs.webkit.org/show_bug.cgi?id=207250
2866
2867         Reviewed by Alex Christensen.
2868
2869         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
2870         reload. However, they don't work unless the main window is
2871         focused.
2872
2873         Ctrl-W should be processed differently. Ctrl-W should be handled
2874         without dispatching to WebKit, others should be handled only when
2875         WebKit didn't consume. So, this change split the accelerator table
2876         into two, one is for Ctrl-W, another is for other shortcut keys.
2877
2878         For Ctrl-W, key events are processed before dispatching to
2879         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
2880         dispatched to WebView. WebKit2 WebView bubbles up unhandled
2881         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
2882         in the main window's WndProc. However, it doesn't work for WebKit1
2883         because this change doesn't add the bubbling up code to WebKit1
2884         WebView.
2885
2886         For other shortcut keys, for example Ctrl-R, key events are
2887         dispatched to WebView without accelerator key translations. Then,
2888         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
2889         aren't consumed. didNotHandleKeyEvent posts the messasge to the
2890         main window. The message loop processed key events dispatched to
2891         the main window with another accelerator table. However, it
2892         doesn't work for WebKit1, because WebKit1 doesn't have a API
2893         equivalent to didNotHandleKeyEvent.
2894
2895         After switching the active window by pressing Alt-Tab and
2896         reactivating the main window, the main window got the focus. This
2897         was the reason shortcut keys worked only after reactivating the
2898         main window. But, this is not the desired behavior after this
2899         change because other shortcut keys don't work if the main window
2900         is focused. So. set the focus to the brower window when
2901         WM_ACTIVATE of the main window.
2902
2903         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
2904         effective only for keyboard numpad. Add VK_OEM_MINUS and
2905         VK_OEM_PLUS for them.
2906
2907         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
2908
2909         * MiniBrowser/win/MainWindow.cpp:
2910         (MainWindow::isInstance):
2911         (MainWindow::WndProc):
2912         * MiniBrowser/win/MainWindow.h:
2913         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
2914         IDR_ACCELERATORS_PRE for Ctrl-W.
2915         * MiniBrowser/win/MiniBrowserLibResource.h:
2916         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2917         (WebKitBrowserWindow::didNotHandleKeyEvent):
2918         * MiniBrowser/win/WinMain.cpp:
2919         (wWinMain):
2920
2921 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
2922
2923         results.webkitorg: Dead CI links
2924         https://bugs.webkit.org/show_bug.cgi?id=207340
2925
2926         Reviewed by Alexey Proskuryakov.
2927
2928         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2929         (Configuration.prototype.toParams): Version name and version number often duplicate the
2930         same information, exception version number is often more specific than is useful.
2931
2932 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
2933
2934         Prevent navigating top level frames to Data URLs
2935         https://bugs.webkit.org/show_bug.cgi?id=206962
2936         <rdar://problem/56770676>
2937
2938         Reviewed by Youenn Fablet.
2939
2940         Revise test running code to allow data URL navigations by default, since they are so frequently
2941         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
2942         function.
2943
2944         * DumpRenderTree/TestOptions.cpp:
2945         (TestOptions::TestOptions):
2946         * DumpRenderTree/TestOptions.h:
2947         * DumpRenderTree/mac/DumpRenderTree.mm:
2948         (setWebPreferencesForTestOptions):
2949         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2950         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
2951         (StartDownloadWithDownloadAttribute): Ditto.
2952         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2953         (WebViewWillPerformClientRedirect): Ditto.
2954         (WebViewDidCancelClientRedirect): Ditto.
2955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2956         (NavigateToDataURLThenBack): Ditto.
2957         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR::TestController::resetPreferencesToConsistentValues):
2960         (WTR::updateTestOptionsFromTestHeader):
2961         * WebKitTestRunner/TestOptions.h:
2962         (WTR::TestOptions::hasSameInitializationOptions const):
2963         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2964         (WTR::initializeWebViewConfiguration):
2965         (WTR::TestController::platformCreateWebView):
2966
2967 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2968
2969         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
2970         https://bugs.webkit.org/show_bug.cgi?id=207272
2971         <rdar://problem/59190828>
2972
2973         Reviewed by Tim Horton.
2974
2975         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
2976         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
2977         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
2978
2979         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2980         (TestWebKitAPI::overrideBundleIdentifier):
2981         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2982         (setOverriddenApplicationKeyWindow):
2983         (applicationKeyWindowOverride):
2984         (-[TestWKWebViewHostWindow makeKeyWindow]):
2985         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2986         * TestWebKitAPI/ios/UIKitSPI.h:
2987
2988         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
2989         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
2990
2991 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2992
2993         [PlayStation] Build a shared JavaScriptCore
2994         https://bugs.webkit.org/show_bug.cgi?id=198446
2995
2996         Reviewed by Fujii Hironori.
2997
2998         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
2999
3000         * TestWebKitAPI/PlatformPlayStation.cmake:
3001
3002 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
3003
3004         [WinCairo] Set up fonts for layout tests for test bot image
3005         https://bugs.webkit.org/show_bug.cgi?id=207223
3006
3007         Reviewed by Fujii Hironori.
3008
3009         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
3010           Implement activateFonts to load fonts for test
3011
3012 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
3013
3014         [PlayStation] Miscellaneous build fixes February 2020 edition
3015         https://bugs.webkit.org/show_bug.cgi?id=207312
3016
3017         Unreviewed build fix.
3018
3019         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
3020
3021 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
3022
3023         [WTF] Try using 75% load factor for HashTable
3024         https://bugs.webkit.org/show_bug.cgi?id=207183
3025
3026         Reviewed by Mark Lam.
3027
3028         Fix load-factor assumption in existing tests.
3029
3030         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3031         (TestWebKitAPI::testInitialCapacity):
3032
3033 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3034
3035         resulsdbpy: Fix unit tests
3036         https://bugs.webkit.org/show_bug.cgi?id=207304
3037
3038         Reviewed by Aakash Jain.
3039
3040         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
3041         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
3042         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
3043         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
3044         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
3045         (FailureContextTest.test_unexpected_failures): Ditto.
3046         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
3047         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
3048         of knowing how expensive the callback may be.
3049
3050 2020-02-05  Chris Dumez  <cdumez@apple.com>
3051
3052         Unreviewed, another build fix after r255846
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3055
3056 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3057
3058         Unreviewed infrastructure fix.
3059
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3061         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
3062
3063 2020-02-05  Chris Dumez  <cdumez@apple.com>
3064
3065         Unreviewed build fix after r255846.
3066
3067         * TestWebKitAPI/cocoa/HTTPServer.h:
3068
3069 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
3070
3071         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
3072         https://bugs.webkit.org/show_bug.cgi?id=207173
3073         <rdar://problem/55669065>
3074
3075         Reviewed by Brent Fulgham.
3076
3077         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3078         (TestWebKitAPI::TEST):
3079         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3080         (-[TestWKWebView _setUpTestWindow:]):
3081         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
3082
3083 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3084
3085         results.webkit.org: Apply ttl to archive shards
3086         https://bugs.webkit.org/show_bug.cgi?id=207295
3087
3088         Rubber-stamped by Aakash Jain.
3089
3090         * resultsdbpy/resultsdbpy/model/archive_context.py:
3091         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
3092         (ArchiveContext.ArchiveChunks): Use new table.
3093         (ArchiveContext.register): Add ttl to archive shards.
3094
3095 2020-02-05  Alex Christensen  <achristensen@webkit.org>
3096
3097         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
3098         https://bugs.webkit.org/show_bug.cgi?id=207207
3099
3100         Reviewed by Chris Dumez.
3101
3102         HTTPServer now supports HTTPS. Tell your friends!
3103
3104         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3105         (testCertificate):
3106         (testIdentity):
3107         (credentialWithIdentity):
3108         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3109         (TestWebKitAPI::webViewWithNavigationDelegate):
3110         (TestWebKitAPI::TEST):
3111         * TestWebKitAPI/cocoa/HTTPServer.h:
3112         * TestWebKitAPI/cocoa/HTTPServer.mm:
3113         (TestWebKitAPI::HTTPServer::HTTPServer):
3114         (TestWebKitAPI::HTTPServer::request const):
3115
3116 2020-02-05  Brady Eidson  <beidson@apple.com>
3117
3118         _WKDownload should expose the originating FrameInfo.
3119         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
3120
3121         Reviewed by Geoff Garen.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3124         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3125         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
3126         (loaded):
3127         * TestWebKitAPI/cocoa/HTTPServer.mm:
3128
3129 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3130
3131         [GTK] Fix dependencies build
3132         https://bugs.webkit.org/show_bug.cgi?id=207273
3133
3134         Reviewed by Carlos Garcia Campos.
3135
3136         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
3137         added mesa as one of its deps. Added the xserver patch as well.
3138         * gtk/patches/xserver-gl-version.patch: Added.
3139
3140 2020-02-05  Chris Dumez  <cdumez@apple.com>
3141
3142         REGRESSION(r255595): page not closed after beforeunload handler returns true
3143         https://bugs.webkit.org/show_bug.cgi?id=207189
3144         <rdar://problem/59149593>
3145
3146         Reviewed by Youenn Fablet.
3147
3148         Add API test coverage for fix landed in r255677.
3149
3150         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3151         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3152         (TEST):
3153
3154 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3155
3156         results.webkit.org should disable auto-capitalize over the search field
3157         https://bugs.webkit.org/show_bug.cgi?id=207240
3158         <rdar://problem/59053042>
3159
3160         Rubber-stamped by Aakash Jain.
3161
3162         * resultsdbpy/resultsdbpy/view/static/js/search.js:
3163
3164 2020-02-01  Darin Adler  <darin@apple.com>
3165
3166         Replace RGBA32 typedef with a class to improve type safety
3167         https://bugs.webkit.org/show_bug.cgi?id=206862
3168
3169         Reviewed by Sam Weinig.
3170
3171         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
3172         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
3173
3174 2020-02-04  Darin Adler  <darin@apple.com>
3175
3176         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
3177         https://bugs.webkit.org/show_bug.cgi?id=207203
3178
3179         Reviewed by Anders Carlsson.
3180
3181         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
3182         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
3183         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
3184         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
3185         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
3186
3187 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3188
3189         results.webkit.org: Support Internal in run-javascriptcore-tests
3190         https://bugs.webkit.org/show_bug.cgi?id=204095
3191
3192         Rubber-stamped by Aakash Jain.
3193
3194         * Scripts/VCSUtils.pm:
3195         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
3196         (gitBranchForDirectory): Compute branch for directory.
3197         (gitBranch): Compute branch for the current git directory.
3198         (commitForDirectory): Add git support.
3199         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
3200         * Scripts/run-javascriptcore-tests:
3201         (uploadResults): Check for Internal repository.
3202
3203 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3204
3205         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
3206         https://bugs.webkit.org/show_bug.cgi?id=207204
3207
3208         Reviewed by Simon Fraser.
3209
3210         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
3211         in LLDB's python API.
3212
3213         * lldb/lldb_webkit_unittest.py:
3214         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
3215         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
3216         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3217
3218 2020-02-04  Lauro Moura  <lmoura@igalia.com>
3219
3220         [EWS] Stop GTK/WPE build if jhbuild fails.
3221         https://bugs.webkit.org/show_bug.cgi?id=207220
3222
3223         Reviewed by Adrian Perez de Castro.
3224
3225         * BuildSlaveSupport/ews-build/steps.py:
3226         (InstallGtkDependencies): Halt on failure
3227         (InstallWpeDependencies): Ditto
3228
3229 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3230
3231         Fix Mac CMake build
3232         https://bugs.webkit.org/show_bug.cgi?id=207231
3233
3234         * DumpRenderTree/PlatformMac.cmake:
3235         * MiniBrowser/mac/CMakeLists.txt:
3236         * MiniBrowser/mac/WK2BrowserWindowController.m:
3237         (-[WK2BrowserWindowController awakeFromNib]):
3238         * WebKitTestRunner/PlatformMac.cmake:
3239
3240 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
3241
3242         [PlayStation] Enable TestWebKit
3243         https://bugs.webkit.org/show_bug.cgi?id=207211
3244
3245         Reviewed by Ross Kirsling.
3246
3247         Stub out PlayStation implementation of TestWebKit so it builds.
3248
3249         * TestWebKitAPI/PlatformPlayStation.cmake:
3250         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
3251         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
3252         (TestWebKitAPI::Util::createInjectedBundlePath):
3253         (TestWebKitAPI::Util::createURLForResource):
3254         (TestWebKitAPI::Util::URLForNonExistentResource):
3255         (TestWebKitAPI::Util::isKeyDown):
3256         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
3257         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3258         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3259         (TestWebKitAPI::PlatformWebView::initialize):
3260         (TestWebKitAPI::PlatformWebView::page const):
3261         (TestWebKitAPI::PlatformWebView::resizeTo):
3262         (TestWebKitAPI::PlatformWebView::focus):
3263         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3264         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3265         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3266         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3267
3268 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3269
3270         results.webkit.org: Support branches in run-javascriptcore-tests
3271         https://bugs.webkit.org/show_bug.cgi?id=204094
3272
3273         Rubber-stamped by Aakash Jain.
3274
3275         * Scripts/run-javascriptcore-tests:
3276         (uploadResults): Use webkitdirs function to generate commit information.
3277         * Scripts/VCSUtils.pm:
3278         (commitForDirectory): Generate commit information for SVN repository, including
3279         branch name.
3280
3281 2020-02-04  Matt Lewis  <jlewis3@apple.com>
3282
3283         Replace bot677 due to hardware failure
3284         https://bugs.webkit.org/show_bug.cgi?id=207224
3285
3286         Reviewed by Aakash Jain.
3287
3288         * BuildSlaveSupport/build.webkit.org-config/config.json:
3289
3290 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3291
3292         TestWebKitAPI: Handle case where test result does not contain path
3293         https://bugs.webkit.org/show_bug.cgi?id=207216
3294
3295         Reviewed by Tim Horton.
3296
3297         * TestWebKitAPI/TestsController.cpp:
3298         (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
3299         will not contain a file name. We should handle this case.
3300
3301 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3302
3303         results.webkit.org: Better order upload callbacks
3304         https://bugs.webkit.org/show_bug.cgi?id=207219
3305
3306         Reviewed by Aakash Jain.
3307
3308         Order upload callbacks more deliberately so that the quickest callbacks
3309         that are least likely to link to information from unfinished callbacks are
3310         executed first.
3311
3312         * resultsdbpy/resultsdbpy/model/model.py:
3313         (Model.__init__): Generate buildbot links first, then generate a failure
3314         list, then generate the collective suite results and finally, individual
3315         test results.
3316
3317 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [EWS] Do not remove TestWebKitAPI prefix from api test failures
3320         https://bugs.webkit.org/show_bug.cgi?id=207210
3321
3322         Reviewed by Jonathan Bedard.
3323
3324         * BuildSlaveSupport/ews-build/steps.py:
3325         (AnalyzeAPITestsResults.analyzeResults):
3326
3327 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3328
3329         [EWS] Do not remove webkitpy prefix from test failures
3330         https://bugs.webkit.org/show_bug.cgi?id=207206
3331
3332         Reviewed by Jonathan Bedard.
3333
3334         * BuildSlaveSupport/ews-build/steps.py:
3335         (WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
3336         case when json output doesn't have failures/errors key.
3337         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3338
3339 2020-02-04  Ross Kirsling  <ross.kirsling@sony.com>
3340
3341         [CMake] Add Cairo::Cairo target
3342         https://bugs.webkit.org/show_bug.cgi?id=207159
3343
3344         Reviewed by Konstantin Tokarev.
3345
3346         * DumpRenderTree/PlatformWin.cmake:
3347         * ImageDiff/Cairo.cmake:
3348         * TestWebKitAPI/PlatformWPE.cmake:
3349         * TestWebKitAPI/PlatformWin.cmake:
3350         * TestWebKitAPI/glib/CMakeLists.txt:
3351         * WebKitTestRunner/PlatformGTK.cmake:
3352         * WebKitTestRunner/PlatformWPE.cmake:
3353         * WebKitTestRunner/PlatformWin.cmake:
3354         * wpe/backends/CMakeLists.txt:
3355
3356 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
3357
3358         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
3359         https://bugs.webkit.org/show_bug.cgi?id=207079
3360         <rdar://problem/48290464>
3361
3362         Reviewed by Brent Fulgham.
3363
3364         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3365         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3366         (overrideGetAuthorizationHintsWithURL):
3367         (TestWebKitAPI::TEST):
3368
3369 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3370
3371         results.webkit.org: Support jsc stress tests
3372         https://bugs.webkit.org/show_bug.cgi?id=204096
3373
3374         Rubber-stamped by Aakash Jain.
3375
3376         * Scripts/run-javascriptcore-tests:
3377         (runJSCStressTests): Add pass and failures to reported results.
3378
3379 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3380
3381         Make Bugzilla._find_select_element_for_flag more robust
3382         https://bugs.webkit.org/show_bug.cgi?id=207148
3383
3384         Reviewed by Jonathan Bedard.
3385
3386         This patch resolves two FIXMEs:
3387         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
3388         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
3389
3390         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3391         (Bugzilla._fill_attachment_form):
3392         (Bugzilla._find_select_element_for_flag):
3393
3394 2020-02-03  Alex Christensen  <achristensen@webkit.org>
3395
3396         Reduce size of HashMap and HashSet
3397         https://bugs.webkit.org/show_bug.cgi?id=207138
3398
3399         Reviewed by Yusuke Suzuki.
3400
3401         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3402         (TestWebKitAPI::TEST):
3403         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3404         (TestWebKitAPI::TEST):
3405
3406 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3407
3408         obsolete_attachment should not fail when flags do not exist
3409         https://bugs.webkit.org/show_bug.cgi?id=171121
3410
3411         Reviewed by Jonathan Bedard.
3412
3413         Before this change, an error occured if a contributor without EditBugs privileges tried
3414         to obsolete not their own attachment. With this patch, uploading routine continues with
3415         friendly console warning like we have in reassign_bug() method.
3416
3417         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3418         (Bugzilla):
3419         (Bugzilla.obsolete_attachment):
3420         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
3421
3422 2020-02-03  Chris Dumez  <cdumez@apple.com>
3423
3424         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
3425         https://bugs.webkit.org/show_bug.cgi?id=207121
3426         <rdar://problem/58880177>
3427
3428         Reviewed by Alex Christensen.
3429
3430         Add API test coverage.
3431
3432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3433         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
3434         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3435         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3436         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
3437         (TEST):
3438
3439 2020-02-03  Lauro Moura  <lmoura@igalia.com>
3440
3441         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
3442         https://bugs.webkit.org/show_bug.cgi?id=206517
3443
3444         Reviewed by Carlos Alberto Lopez Perez.
3445
3446         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3447         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
3448         starts with a leading slash instead of using the test URL, which could
3449         cause input forms with invalid file data.
3450
3451 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
3452
3453         [ews] Set custom build summary for webkitpy tests
3454         https://bugs.webkit.org/show_bug.cgi?id=207027
3455
3456         Reviewed by Jonathan Bedard.
3457
3458         * BuildSlaveSupport/ews-build/factories.py:
3459         * BuildSlaveSupport/ews-build/steps.py:
3460         (WebKitPyTest.setBuildSummary):
3461         (WebKitPyTest.getResultSummary):
3462         * BuildSlaveSupport/ews-build/factories_unittest.py:
3463
3464 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3465
3466         run-javascriptcore-tests: Don't split binary results
3467         https://bugs.webkit.org/show_bug.cgi?id=207118
3468
3469         Rubber-stamped by Aakash Jain.
3470
3471         * Scripts/run-javascriptcore-tests:
3472         (runTest): Only report aggregated binary results.
3473
3474 2020-02-03  Chris Dumez  <cdumez@apple.com>
3475
3476         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
3477
3478         The ResponsivenessTimer is disabled for those configurations as of r255518.
3479
3480         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
3481
3482 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
3483
3484         Use std::hypot() where possible
3485         https://bugs.webkit.org/show_bug.cgi?id=198483
3486
3487         Reviewed by Carlos Garcia Campos.
3488
3489         Use std::hypot() where possible, allowing for a possibly more precise
3490         calculation of square roots of sums of two or three square values.
3491
3492         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3493         (-[DragAndDropSimulator initialProgressForMouseDrag]):
3494
3495 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3496
3497         [JHBuild] remove libvpx
3498         https://bugs.webkit.org/show_bug.cgi?id=207103
3499
3500         Reviewed by Xabier Rodriguez-Calvar.
3501
3502         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
3503         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
3504
3505         * gstreamer/jhbuild.modules: remove libvpx.
3506
3507 2020-02-02  Sam Weinig  <weinig@apple.com>
3508
3509         Update style checker with new locations OS version checks are allowed
3510         https://bugs.webkit.org/show_bug.cgi?id=207106
3511
3512         Reviewed by Alexey Proskuryakov.
3513
3514         * Scripts/webkitpy/style/checkers/cpp.py:
3515         (check_os_version_checks):
3516         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3517         (WebKitStyleTest.test_os_version_checks):
3518         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
3519
3520 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
3521
3522         Closing a MiniBrowser WK2 window does not release the WKWebView
3523         https://bugs.webkit.org/show_bug.cgi?id=203185
3524
3525         Reviewed by Wenson Hsieh.
3526         
3527         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
3528         to avoid a retain cycle that keeps the window controller and WKWebView alive.
3529
3530         * MiniBrowser/mac/WK2BrowserWindowController.m:
3531         (-[WK2BrowserWindowController awakeFromNib]):
3532
3533 2020-01-31  David Quesada  <david_quesada@apple.com>
3534
3535         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
3536         https://bugs.webkit.org/show_bug.cgi?id=206984
3537         rdar://problem/58999654
3538
3539         Reviewed by Brady Eidson.
3540
3541         Add an API test for a resumed download that receives an authentication challenge. The download
3542         delegate should be asked to handle the challenge, and the download should be able to finish.
3543
3544         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3545         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3546         (-[DownloadCancelingDelegate _download:didReceiveData:]):
3547         (-[DownloadCancelingDelegate _downloadDidCancel:]):
3548         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
3549         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
3550         (TEST):
3551
3552 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3553
3554         Add support for specifying background colors when setting marked text
3555         https://bugs.webkit.org/show_bug.cgi?id=207065
3556         <rdar://problem/57876140>
3557
3558         Reviewed by Tim Horton.
3559
3560         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
3561         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
3562         each describing one range (in the composition) to highlight.
3563
3564         * DumpRenderTree/ios/TextInputControllerIOS.m:
3565         (+[TextInputController isSelectorExcludedFromWebScript:]):
3566         (+[TextInputController webScriptNameForSelector:]):
3567         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3568         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3569         * DumpRenderTree/mac/TextInputControllerMac.m:
3570         (+[TextInputController isSelectorExcludedFromWebScript:]):
3571         (+[TextInputController webScriptNameForSelector:]):
3572         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3573         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3574         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3575         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3576         (WTR::arrayLength):
3577         (WTR::createCompositionHighlightData):
3578
3579         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
3580         is then passed into WebKit via WKBundlePageSetComposition.
3581
3582         (WTR::TextInputController::setMarkedText):
3583         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3584
3585 2020-01-31  Alex Christensen  <achristensen@webkit.org>
3586
3587         Add KVO SPI WKWebView._negotiatedLegacyTLS
3588         https://bugs.webkit.org/show_bug.cgi?id=207067
3589
3590         Reviewed by Andy Estes.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3593         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
3594         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
3595         (TestWebKitAPI::TEST):
3596         * TestWebKitAPI/config.h:
3597
3598 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3599
3600         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
3601         https://bugs.webkit.org/show_bug.cgi?id=207050
3602
3603         Reviewed by Jonathan Bedard.
3604
3605         * BuildSlaveSupport/ews-build/steps.py:
3606         (ReRunWebKitTests.evaluateCommand):
3607
3608 2020-01-31  David Kilzer  <ddkilzer@apple.com>
3609
3610         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
3611         <https://webkit.org/b/206759>
3612         <rdar://problem/58872607>
3613
3614         Reviewed by Brent Fulgham.
3615
3616         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3617         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3618         - Add declaration.
3619         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3620         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3621         - Implement by waiting for
3622           -[UIViewController isPerformingModalTransition] to return NO
3623           while spinning the runloop.
3624         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3625         - Call waitForModalTransitionToFinish() to fix the test.
3626
3627 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3628
3629         [ews] add build step to set custom build summary
3630         https://bugs.webkit.org/show_bug.cgi?id=207026
3631
3632         Reviewed by Jonathan Bedard.
3633
3634         * BuildSlaveSupport/ews-build/steps.py:
3635         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
3636         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
3637         (SetBuildSummary.start):
3638
3639 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
3640
3641         results.webkit.org: Handle modified firewall rules
3642         https://bugs.webkit.org/show_bug.cgi?id=207047
3643
3644         Reviewed by Aakash Jain.
3645
3646         * Scripts/webkitpy/results/upload.py:
3647         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
3648         indicating the upload failed.
3649         * Scripts/webkitpy/results/upload_unittest.py:
3650         (UploadTest.test_archive_upload):
3651
3652 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
3653
3654         Unreviewed, another speculative test fix after r255041
3655