451e12bc448ad3da4f40d04b8b506d19c7c6163d
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
2
3         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
4         https://bugs.webkit.org/show_bug.cgi?id=171989
5
6         Reviewed by Brian Burg.
7
8         * lldb/lldb_webkit.py:
9         (WTFStringImplProvider.get_data8):
10         (WTFStringImplProvider.get_data16):
11         m_data8 and m_data16 are now part of the superclass StringImplShape
12         instead of directly in StringImpl. So first get the shape by getting
13         index 0, and the data properties are the same offset within that.
14
15 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
16
17         Remove Vibration API
18         https://bugs.webkit.org/show_bug.cgi?id=171766
19
20         Rubber-stamped by Alexey Proskuryakov.
21
22         * Scripts/webkitperl/FeatureList.pm:
23
24 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
25
26         Add WPE release bots
27         https://bugs.webkit.org/show_bug.cgi?id=171973
28
29         Reviewed by Žan Doberšek.
30
31         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
32         It also adds a new WPE buildbot category.
33
34         * BuildSlaveSupport/build.webkit.org-config/config.json:
35         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
36         (InstallWpeDependencies):
37         (appendCustomBuildFlags):
38         (Factory.__init__):
39         (loadBuilderConfig):
40         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
41         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
42
43 2017-05-09  Sam Weinig  <sam@webkit.org>
44
45         Remove support for legacy Notifications
46         https://bugs.webkit.org/show_bug.cgi?id=171487
47
48         Reviewed by Jon Lee.
49
50         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
51         (DRTDesktopNotificationPresenter::checkNotificationPermission):
52         * Scripts/webkitperl/FeatureList.pm:
53         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
54         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
55
56 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
57
58         Remove user agent quirk for Slack
59         https://bugs.webkit.org/show_bug.cgi?id=171869
60
61         Reviewed by Carlos Garcia Campos.
62
63         Remove the corresponding test.
64
65         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
66         (TestWebKitAPI::TEST):
67
68 2017-05-10  Commit Queue  <commit-queue@webkit.org>
69
70         Unreviewed, rolling out r216578.
71         https://bugs.webkit.org/show_bug.cgi?id=171920
72
73         Broke the GTK+ build with Wayland enabled (Requested by KaL on
74         #webkit).
75
76         Reverted changeset:
77
78         "[GTK] Bump GTK+ and its dependencies in jhbuild"
79         https://bugs.webkit.org/show_bug.cgi?id=171918
80         http://trac.webkit.org/changeset/216578
81
82 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
83
84         [GTK] Bump GTK+ and its dependencies in jhbuild
85         https://bugs.webkit.org/show_bug.cgi?id=171918
86
87         Reviewed by Carlos Alberto Lopez Perez.
88
89         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
90         (WTR::initializeGtkSettings):
91         * gtk/jhbuild.modules:
92         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
93         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
94
95 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
96
97         [Win] Set CMake args in build-webkit
98         https://bugs.webkit.org/show_bug.cgi?id=171436
99
100         Reviewed by Per Arne Vollan.
101
102         * Scripts/build-webkit:
103
104 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
105
106         ImageDiff: Add CG implementation for new ImageDiff
107         https://bugs.webkit.org/show_bug.cgi?id=170608
108
109         Reviewed Alex Christensen.
110
111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
112         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
113         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
114         * ImageDiff/CMakeLists.txt:
115         * ImageDiff/Cairo.cmake:
116         * ImageDiff/ImageDiff.cpp:
117         (main):
118         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
119         * ImageDiff/PlatformImage.cpp:
120         * ImageDiff/PlatformImage.h:
121         * ImageDiff/cairo/PlatformImageCairo.cpp:
122         * ImageDiff/cg/ImageDiff.cpp: Removed.
123         * ImageDiff/cg/PlatformImageCG.cpp: Added.
124         (ImageDiff::PlatformImage::createFromStdin):
125         (ImageDiff::PlatformImage::createFromDiffData):
126         (ImageDiff::PlatformImage::PlatformImage):
127         (ImageDiff::PlatformImage::~PlatformImage):
128         (ImageDiff::PlatformImage::width):
129         (ImageDiff::PlatformImage::height):
130         (ImageDiff::PlatformImage::rowBytes):
131         (ImageDiff::PlatformImage::hasAlpha):
132         (ImageDiff::PlatformImage::pixels):
133         (ImageDiff::PlatformImage::writeAsPNGToStdout):
134
135 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
136
137         Enable FTL JIT by default on AArch64
138         https://bugs.webkit.org/show_bug.cgi?id=144039
139
140         Reviewed by Yusuke Suzuki.
141
142         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
143         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
144         as an unsupported FTL platform.
145         * Scripts/webkitdirs.pm:
146         (isARM64): Returns 1 if the determined architecture is 'arm64'.
147         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
148
149 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
150
151         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
152         https://bugs.webkit.org/show_bug.cgi?id=170857
153         <rdar://problem/31635373>
154
155         Reviewed by Aakash Jain.
156
157         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
158         code to search for crash logs.
159
160         * Scripts/webkitpy/port/darwin.py:
161         (DarwinPort._get_crash_log): Moved from MacPort.
162         * Scripts/webkitpy/port/darwin_testcase.py:
163         (DarwinTest.test_get_crash_log): Moved from MacTest.
164         * Scripts/webkitpy/port/ios_device.py:
165         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
166         devices must search for crash-logs remotely.
167         * Scripts/webkitpy/port/ios_simulator.py:
168         (IOSSimulatorPort._get_crash_log): Deleted.
169         * Scripts/webkitpy/port/ios_simulator_unittest.py:
170         (IOSSimulatorTest.test_get_crash_log): Deleted.
171         * Scripts/webkitpy/port/mac.py:
172         (MacPort._get_crash_log): Moved to DarwinPort
173         * Scripts/webkitpy/port/mac_unittest.py:
174         (MacTest.test_get_crash_log): Moved to DarwinTest.
175
176 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
177
178         build ImageDiff with host SDK from Make
179         https://bugs.webkit.org/show_bug.cgi?id=171835
180
181         Reviewed by Alexey Proskuryakov.
182
183         ImageDiff should be built for the default SDK and default architecture when
184         the SDKROOT is set to either iOS device or iOS simulator. Check the
185         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
186
187         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
188         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
189
190 2017-05-09  Matt Lewis  <jlewis3@apple.com>
191
192         Unreviewed, adding myself to contributors.json
193
194         * Scripts/webkitpy/common/config/contributors.json:
195
196 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
197
198         REGRESSION: ImageDiff not building with make
199         https://bugs.webkit.org/show_bug.cgi?id=171788
200
201         Reviewed by Alex Christensen.
202
203         * Makefile: Build ImageDiff for all platforms.
204
205 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
206
207         [Win] ImageDiff isn't built since Bug 168945
208         https://bugs.webkit.org/show_bug.cgi?id=171847
209
210         Reviewed by Alex Christensen.
211
212         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
213         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
214         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
215
216 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
217
218         Upstream the WPE port
219         https://bugs.webkit.org/show_bug.cgi?id=171110
220
221         Reviewed by Alex Christensen.
222
223         webkit-dev thread:
224         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
225
226         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
227         In-file changes removed from this ChangeLog entry for brevity.
228
229         * BuildSlaveSupport/built-product-archive:
230         * BuildSlaveSupport/test-result-archive:
231         * CMakeLists.txt:
232         * ImageDiff/PlatformWPE.cmake: Added.
233         * Scripts/build-dumprendertree:
234         * Scripts/build-webkit:
235         * Scripts/build-webkittestrunner:
236         * Scripts/update-webkit-libs-jhbuild:
237         * Scripts/update-webkitwpe-libs: Added.
238         * Scripts/webkitdirs.pm:
239         * Scripts/webkitperl/FeatureList.pm:
240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
241         * Scripts/webkitpy/port/factory.py:
242         * Scripts/webkitpy/port/wpe.py: Added.
243         * TestWebKitAPI/PlatformWPE.cmake: Added.
244         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
245         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
246         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
247         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
248         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
249         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
250         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
253         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
254         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
255         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
256         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
257         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
258         * WebKitTestRunner/PlatformWPE.cmake: Added.
259         * WebKitTestRunner/PlatformWebView.h:
260         * WebKitTestRunner/TestController.cpp:
261         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
262         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
263         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
264         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
265         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
266         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
267         * jhbuild/jhbuild-wrapper:
268         * wpe/generate-inspector-gresource-manifest.py: Added.
269         * wpe/jhbuild.modules: Added.
270         * wpe/jhbuildrc: Added.
271         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
272         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
273         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
274         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
275         * wpe/patches/glib-warning-fix.patch: Added.
276         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
277         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
278         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
279         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
280         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
281
282 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
283
284         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
285         https://bugs.webkit.org/show_bug.cgi?id=169421
286         <rdar://problem/30950171>
287
288         Reviewed by Tim Horton.
289
290         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
291         (createBitmapContextFromWebView): Implement for IOSurface.
292         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
293         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
294
295 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
296
297         buildbot: Cleanup simulators after running tests
298         https://bugs.webkit.org/show_bug.cgi?id=171679
299
300         Reviewed by Aakash Jain.
301
302         simctl is partitioned for each user. Since kill-old-processes
303         is run as root, we need to specify the buildbot user when tearing
304         down simulators between steps.
305
306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
307         (KillOldProcesses): Pass buildbot user to kill-old-processes.
308         * BuildSlaveSupport/kill-old-processes:
309         (main): Specify the user for simctl if one has been provided.
310
311 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
312
313         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
314         https://bugs.webkit.org/show_bug.cgi?id=171681
315
316         Reviewed by Carlos Garcia Campos.
317
318         * gtk/install-dependencies:
319
320 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
321
322         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
323
324         Glib uses now Unicode quotes in error messages.
325
326         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
327         (testWebKitConsoleMessageNetworkError):
328
329 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
332
333         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
334         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
335         characters to the input. Also fix typo in the function name.
336
337         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
338         (testWebViewJavaScriptDialogs):
339
340 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
341
342         [GTK] Cannot sign in with new Google sign-in page
343         https://bugs.webkit.org/show_bug.cgi?id=171770
344
345         Unreviewed. This just adds a test.
346
347         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
348         (TestWebKitAPI::TEST):
349
350 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
351
352         [iOS WK2] Make rotation tests more reliable
353         https://bugs.webkit.org/show_bug.cgi?id=171778
354
355         Reviewed by Tim Horton.
356
357         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
358         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
359         with override layout parameters, and an override orientation, and these caused viewport
360         size to leak into later tests, and WebCore orientation to not get reset correctly.
361
362         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
363         an override orientation was set, and would never re-register, causing lost orientationchanged
364         events.
365
366         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
367         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
368
369         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
370         the WebProcess is caught up before proceeding with the test.
371
372         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
373         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
374         * WebKitTestRunner/ios/TestControllerIOS.mm:
375         (WTR::TestController::platformResetStateToConsistentValues):
376         (WTR::TestController::platformConfigureViewForTest):
377
378 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
379
380         [Mac][cmake] Buildfix after r216047
381         https://bugs.webkit.org/show_bug.cgi?id=171769
382
383         Unreviewed buildfix.
384
385         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
386
387 2017-05-05  Brady Eidson  <beidson@apple.com>
388
389         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
390         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
391
392         Reviewed by Andy Estes.
393
394         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
395         (TEST):
396
397 2017-05-05  Brian Burg  <bburg@apple.com>
398
399         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
400         https://bugs.webkit.org/show_bug.cgi?id=171748
401         <rdar://problem/32027327>
402
403         Reviewed by Michael Catanzaro.
404
405         Remove temporary workaround now that the assertion failure is fixed.
406
407         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
408         (TEST):
409
410 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
411
412         Make it possible to test rotation in iOS WebKitTestRunner
413         https://bugs.webkit.org/show_bug.cgi?id=171755
414
415         Reviewed by Tim Horton.
416
417         Add to UIScriptController:
418             void simulateRotation(DeviceOrientation orientation, object callback);
419             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
420
421         The former just does a view resize, as a simple WKWebView app would do. The second does
422         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
423         layout size and interface orientation. The two behaviors produce different resize and
424         orientationchange events and sizes, and both need to be tested.
425
426         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
427         which is now a custom subclass (PlatformWebViewController).
428
429         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
430         (WTR::UIScriptController::simulateRotation):
431         (WTR::UIScriptController::simulateRotationLikeSafari):
432         * DumpRenderTree/mac/UIScriptControllerMac.mm:
433         (WTR::UIScriptController::simulateRotation):
434         (WTR::UIScriptController::simulateRotationLikeSafari):
435         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
436         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
437         (WTR::toDeviceOrientation):
438         (WTR::UIScriptController::simulateRotation):
439         (WTR::UIScriptController::simulateRotationLikeSafari):
440         * TestRunnerShared/UIScriptContext/UIScriptController.h:
441         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
442         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
443         (-[TestRunnerWKWebView dealloc]):
444         (-[TestRunnerWKWebView _didEndRotation]):
445         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
446         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
447         (WTR::PlatformWebView::PlatformWebView):
448         * WebKitTestRunner/ios/TestControllerIOS.mm:
449         (WTR::TestController::platformResetStateToConsistentValues):
450         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
451         (WTR::toUIDeviceOrientation):
452         (WTR::UIScriptController::simulateRotation):
453         (WTR::UIScriptController::simulateRotationLikeSafari):
454         (WTR::UIScriptController::platformClearAllCallbacks):
455         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
456         (WTR::UIScriptController::simulateRotation):
457         (WTR::UIScriptController::simulateRotationLikeSafari):
458
459 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
460
461         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
462         https://bugs.webkit.org/show_bug.cgi?id=168945
463         <rdar://problem/30745695>
464
465         Reviewed by David Kilzer.
466
467         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
468         target SDK. These two changes must happen simultaneously because some archives will
469         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
470
471         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
472         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
473         tools directory still includes ImageDiff.
474         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
475         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
476         * Scripts/webkitpy/port/darwin.py: 
477         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
478         locally or when running archives.
479         * Scripts/webkitpy/port/image_diff.py:
480         (IOSSimulatorImageDiffer): Deleted.
481         * Scripts/webkitpy/port/ios_simulator.py:
482         (IOSSimulatorPort.diff_image): Deleted.
483
484 2017-05-05  Brian Burg  <bburg@apple.com>
485
486         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
487         https://bugs.webkit.org/show_bug.cgi?id=171748
488
489         Unreviewed test gardening.
490
491         The assertion failure will be investigated separately in order to avoid rolling out
492         the fix for "secure" cookies. This assertion fails even without r216258 applied.
493
494         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
495         (TEST):
496
497 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
498
499         Unreviewed, rolling out r216260.
500
501         Breaks internal iOS testers
502
503         Reverted changeset:
504
505         "Use ImageDiff built by host SDK and remove ImageDiff from
506         DumpRenderTree"
507         https://bugs.webkit.org/show_bug.cgi?id=168945
508         http://trac.webkit.org/changeset/216260
509
510 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
511
512         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
513         https://bugs.webkit.org/show_bug.cgi?id=168945
514         <rdar://problem/30745695>
515
516         Reviewed by David Kilzer.
517
518         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
519         target SDK. These two changes must happen simultaneously because some archives will
520         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
521
522         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
523         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
524         tools directory still includes ImageDiff.
525         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
526         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
527         * Scripts/webkitpy/port/darwin.py: 
528         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
529         locally or when running archives.
530         * Scripts/webkitpy/port/image_diff.py:
531         (IOSSimulatorImageDiffer): Deleted.
532         * Scripts/webkitpy/port/ios_simulator.py:
533         (IOSSimulatorPort.diff_image): Deleted.
534
535 2017-05-05  Brian Burg  <bburg@apple.com>
536
537         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
538         https://bugs.webkit.org/show_bug.cgi?id=171700
539         <rdar://problem/32017975>
540
541         Reviewed by Brady Eidson.
542
543         Fix a mistake in the test that should have caught this bug.
544
545         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
546         (TEST):
547         The assertions that were meant to check round-tripping were actually checking
548         the properties of the original cookie objects, not the round-tripped ones.
549         This test now fails without the bugfix and passes when it is applied.
550
551 2017-05-05  Daniel Bates  <dabates@apple.com>
552
553         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
554         https://bugs.webkit.org/show_bug.cgi?id=171698
555
556         Reviewed by Darin Adler.
557
558         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
559         so that we get pretty diff output when the actual string differs from the expected
560         string as opposed to seeing a boolean result. The former makes makes it straightforward
561         to diagnose a regression without reading the code for the test or instrumenting it to
562         determine the actual string that was compared.
563
564         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
565         (TestWebKitAPI::TEST):
566         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
567         (TestWebKitAPI::TEST_F):
568         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
569         (TestWebKitAPI::TEST_F):
570
571 2017-05-05  Chris Dumez  <cdumez@apple.com>
572
573         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
574         https://bugs.webkit.org/show_bug.cgi?id=171624
575
576         Reviewed by Dan Bernstein.
577
578         Extend API test coverage to cover crashes in addition to terminations requested by the client.
579
580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
581         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
582         (TestWebKitAPI::webProcessWasTerminatedByClient):
583         (TestWebKitAPI::webProcessCrashed):
584         (TestWebKitAPI::TEST):
585
586 2017-05-04  Mark Lam  <mark.lam@apple.com>
587
588         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
589         https://bugs.webkit.org/show_bug.cgi?id=171716
590         <rdar://problem/30878027>
591
592         Reviewed by Saam Barati.
593
594         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
595         does JS conversion and therefore, potentially JS allocations) and accessing
596         methods of internal JS data structures (which may do JS invocation, etc).
597
598         * DumpRenderTree/TestRunner.cpp:
599         (setAudioResultCallback):
600
601 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
602
603         buildbot: Cleanup simulators after running tests
604         https://bugs.webkit.org/show_bug.cgi?id=171679
605         <rdar://problem/31994361>
606
607         Reviewed by Aakash Jain.
608
609         We shutdown the simulator process between tests, but in some cases, this is not
610         sufficient. Explicitly shutdown every booted simulator.
611
612         * BuildSlaveSupport/kill-old-processes:
613         (main): Shutdown all booted simulators.
614
615 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
616
617         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
618         https://bugs.webkit.org/show_bug.cgi?id=171644
619
620         Reviewed by Michael Catanzaro.
621
622         Check that only one WebKitWebContext can have automation enabled.
623
624         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
625         (testAutomationSessionRequestSession):
626
627 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
628
629         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
630         https://bugs.webkit.org/show_bug.cgi?id=171724
631
632         Reviewed by Michael Catanzaro.
633
634         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
635
636         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
637         (WTR::timeoutSource):
638
639 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
640
641         Unreviewed. Fix wrong assert after r215176.
642
643         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
644         could also be RGB24 when created from a web view snapshot.
645
646         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
647         (WTR::computeMD5HashStringForCairoSurface):
648
649 2017-05-04  Brian Burg  <bburg@apple.com>
650
651         lldb_webkit.py should provide a type summary for WebCore::URL
652         https://bugs.webkit.org/show_bug.cgi?id=171670
653
654         Reviewed by Jer Noble.
655
656         Just print out the underlying string using the WTFString provider.
657
658         * lldb/lldb_webkit.py:
659         (__lldb_init_module):
660         (WebCoreURL_SummaryProvider):
661         (WebCoreURLProvider):
662         (WebCoreURLProvider.__init__):
663         (WebCoreURLProvider.to_string):
664
665 2017-05-04  Commit Queue  <commit-queue@webkit.org>
666
667         Unreviewed, rolling out r216206.
668         https://bugs.webkit.org/show_bug.cgi?id=171714
669
670         Multiple LayoutTests crashing in Document::page() (Requested
671         by ap on #webkit).
672
673         Reverted changeset:
674
675         "Remove support for legacy Notifications"
676         https://bugs.webkit.org/show_bug.cgi?id=171487
677         http://trac.webkit.org/changeset/216206
678
679 2017-05-04  Mark Lam  <mark.lam@apple.com>
680
681         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
682         https://bugs.webkit.org/show_bug.cgi?id=171702
683
684         Reviewed by Filip Pizlo.
685
686         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
687         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
688         confirm that the test will detect a regression.  Unfortunately, I forgot to
689         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
690         This patch fixes that.
691
692         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
693         (TestWebKitAPI::neverDestroyedString):
694
695 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
696
697         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
698         https://bugs.webkit.org/show_bug.cgi?id=170195
699
700         Unreviewed test gardening.
701
702         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
703         (TEST):
704
705 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
706
707         [Win] Remove redundant macros that are set in the CMake config
708         https://bugs.webkit.org/show_bug.cgi?id=171571
709
710         Reviewed by Brent Fulgham.
711
712         * DumpRenderTree/config.h:
713         * MiniBrowser/win/stdafx.h:
714         * TestWebKitAPI/config.h:
715
716 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
717
718         Add testRunner.display() to force displaying the web page for testing
719         https://bugs.webkit.org/show_bug.cgi?id=171694
720
721         Reviewed by Simon Fraser.
722
723         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
724         drawing the web page but without track repaints.
725
726         * DumpRenderTree/TestRunner.cpp:
727         (displayCallback):
728         (TestRunner::staticFunctions):
729         * DumpRenderTree/TestRunner.h:
730         * DumpRenderTree/mac/TestRunnerMac.mm:
731         (TestRunner::display):
732         * DumpRenderTree/win/TestRunnerWin.cpp:
733         (TestRunner::display):
734         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::display):
737         * WebKitTestRunner/InjectedBundle/TestRunner.h:
738
739 2017-05-04  Mark Lam  <mark.lam@apple.com>
740
741         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
742         https://bugs.webkit.org/show_bug.cgi?id=171586
743         <rdar://problem/31873190>
744
745         Reviewed by Yusuke Suzuki.
746
747         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
748
749         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
750         (TestWebKitAPI::neverDestroyedString):
751         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
752         (TestWebKitAPI::TEST):
753
754 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
755
756         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
757         https://bugs.webkit.org/show_bug.cgi?id=171585
758         <rdar://problem/31544320>
759
760         Reviewed by Beth Dakin and Zalan Bujtas.
761
762         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
763         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
764         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
765         operation rather than a copy.
766
767         See WebCore ChangeLog for more details.
768
769         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
770                 DataInteractionSimulator.ContentEditableToTextarea
771                 DataInteractionSimulator.ContentEditableMoveParagraphs
772                 DataInteractionSimulator.TextAreaToInput
773
774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
775         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
776         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
777         (TestWebKitAPI::TEST):
778         * TestWebKitAPI/ios/DataInteractionSimulator.h:
779         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
780         (-[DataInteractionSimulator initWithWebView:]):
781         (-[DataInteractionSimulator dealloc]):
782         (-[DataInteractionSimulator _advanceProgress]):
783         (-[DataInteractionSimulator waitForInputSession]):
784         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
785         (-[DataInteractionSimulator _webView:didStartInputSession:]):
786
787 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
788
789         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
790         https://bugs.webkit.org/show_bug.cgi?id=171641
791
792         Reviewed by Simon Fraser.
793
794         The plan is to add back the TestRunner.display() which does the display
795         only without track repaints.
796
797         * DumpRenderTree/DumpRenderTree.h:
798         * DumpRenderTree/TestRunner.cpp:
799         (displayAndTrackRepaintsCallback):
800         (TestRunner::staticFunctions):
801         (displayCallback): Deleted.
802         (displayInvalidatedRegionCallback): Deleted.
803         * DumpRenderTree/TestRunner.h:
804         * DumpRenderTree/mac/DumpRenderTree.mm:
805         (displayWebView):
806         (displayAndTrackRepaintsWebView):
807         * DumpRenderTree/mac/TestRunnerMac.mm:
808         (TestRunner::displayAndTrackRepaints):
809         (TestRunner::display): Deleted.
810         * DumpRenderTree/win/TestRunnerWin.cpp:
811         (TestRunner::displayAndTrackRepaints):
812         (TestRunner::display): Deleted.
813         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
815         (WTR::TestRunner::displayAndTrackRepaints):
816         (WTR::TestRunner::display): Deleted.
817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
818
819 2017-05-04  Brady Eidson  <beidson@apple.com>
820
821         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
822         https://bugs.webkit.org/show_bug.cgi?id=171513
823
824         Unreviewed gardening.
825
826         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
827         (TEST): Skip the failing parts of the test on iOS for now.
828
829 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
830
831         Make ImageDiff stand-alone
832         https://bugs.webkit.org/show_bug.cgi?id=168939
833
834         Reviewed by David Kilzer.
835
836         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
837         stand-alone project. Note that this change does not eliminate the ImageDiff inside
838         the DumpRenderTree project.
839
840         * ImageDiff/ImageDiff.xcodeproj: Added.
841         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
842         * ImageDiff/Makefile: Use ImageDiff project.
843         * ImageDiff/PlatformMac.cmake: Added.
844         * ImageDiff/PlatformWin.cmake: Added.
845         * ImageDiff/cg: Added.
846         * ImageDiff/cg/Configurations: Added.
847         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
848         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
849         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
850         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
851         (createImageFromStdin): Stop using RetainPtr.
852         (createDifferenceImage): Ditto.
853         (main): Ditto.
854         * Scripts/build-imagediff: Stop building WTF and bmalloc.
855
856 2017-05-04  Sam Weinig  <sam@webkit.org>
857
858         Remove support for legacy Notifications
859         https://bugs.webkit.org/show_bug.cgi?id=171487
860
861         Reviewed by Jon Lee.
862
863         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
864         (DRTDesktopNotificationPresenter::checkNotificationPermission):
865         * Scripts/webkitperl/FeatureList.pm:
866         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
867         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
868
869 2017-05-04  Andy Estes  <aestes@apple.com>
870
871         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
872         https://bugs.webkit.org/show_bug.cgi?id=171673
873
874         Reviewed by Dan Bernstein.
875
876         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
877         (TEST):
878         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
879         (TEST):
880         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
881         (TEST):
882         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
883         (TEST):
884         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
885         (TEST):
886         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
887         (configurationWithContentFilterSettings):
888         (-[LazilyLoadPlatformFrameworksController init]):
889         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
890         (TEST):
891         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
892         (runTestWithWidth):
893         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
894         (TEST):
895         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
896         (TestWebKitAPI::TEST):
897         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
898         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
899         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
900         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
901         +_test_configurationWithTestPlugInClassName:
902
903 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
904
905         [MediaStream] Allow host application to enable/disable media capture
906         https://bugs.webkit.org/show_bug.cgi?id=171292
907         <rdar://problem/31821492>
908
909         Reviewed by Jer Noble.
910
911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
912         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
913         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
914         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
915         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
916         (MediaCaptureDisabledTest::SetUp):
917         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
918         (TEST_F):
919         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
920
921 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
922
923         Unreviewed, Adding self to contributors.json
924
925         * Scripts/webkitpy/common/config/contributors.json: Added name.
926
927 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
928
929         Fix compilation with ICU 59.1
930         https://bugs.webkit.org/show_bug.cgi?id=171612
931
932         Reviewed by Mark Lam.
933
934         ICU 59.1 has broken source compatibility. Now it defines UChar as
935         char16_t, which does not allow automatic type conversion from unsigned
936         short in C++ code.
937
938         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
939         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
940
941 2017-05-04  Andy Estes  <aestes@apple.com>
942
943         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
944         https://bugs.webkit.org/show_bug.cgi?id=171646
945         <rdar://problem/30306321>
946
947         Reviewed by Tim Horton.
948
949         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
950         (runTestWithWidth):
951         (TEST):
952         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
953         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
954         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
955         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
956         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
957         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
958
959 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
960
961         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
962         https://bugs.webkit.org/show_bug.cgi?id=171649
963
964         Reviewed by Carlos Garcia Campos.
965
966         Add two patches picked from the upstream repository to fix building of
967         the Fontconfig module in JHBuild. Additionally, this needed a patch to
968         add "autogen.sh" as it is not included in release tarballs. Also:
969         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
970         being regenerated (which is needed) so this is disabled for the
971         Fontconfig module.
972
973         * gtk/jhbuild.modules:
974         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
975         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
976         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
977
978 2017-05-04  Commit Queue  <commit-queue@webkit.org>
979
980         Unreviewed, rolling out r216172.
981         https://bugs.webkit.org/show_bug.cgi?id=171654
982
983         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
984         implementation. (Requested by ddkilzer on #webkit).
985
986         Reverted changeset:
987
988         "[MediaStream] Allow host application to enable/disable media
989         capture"
990         https://bugs.webkit.org/show_bug.cgi?id=171292
991         http://trac.webkit.org/changeset/216172
992
993 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
994
995         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
996         https://bugs.webkit.org/show_bug.cgi?id=171595
997
998         Reviewed by Xabier Rodriguez-Calvar.
999
1000         * gtk/jhbuild.modules:
1001         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1002         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1003         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
1004         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
1005         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1006         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1007         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1008
1009 2017-05-03  Saam Barati  <sbarati@apple.com>
1010
1011         How we build polymorphic cases is wrong when making a call from Wasm
1012         https://bugs.webkit.org/show_bug.cgi?id=171527
1013
1014         Reviewed by JF Bastien.
1015
1016         * Scripts/run-jsc-stress-tests:
1017
1018 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1019
1020         [MediaStream] Allow host application to enable/disable media capture
1021         https://bugs.webkit.org/show_bug.cgi?id=171292
1022         <rdar://problem/31821492>
1023
1024         Reviewed by Jer Noble.
1025
1026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1027         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1028         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1029         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1030         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1031         (MediaCaptureDisabledTest::SetUp):
1032         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1033         (TEST_F):
1034         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1035
1036 2017-05-03  John Wilander  <wilander@apple.com>
1037
1038         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
1039         https://bugs.webkit.org/show_bug.cgi?id=171584
1040         <rdar://problem/24702576>
1041
1042         Reviewed by Brent Fulgham.
1043
1044         New function to call the clear function that takes a modifiedSince parameter.
1045
1046         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1047         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1048         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1049         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1050         * WebKitTestRunner/TestController.cpp:
1051         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1052         * WebKitTestRunner/TestController.h:
1053         * WebKitTestRunner/TestInvocation.cpp:
1054         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1055
1056 2017-05-03  Commit Queue  <commit-queue@webkit.org>
1057
1058         Unreviewed, rolling out r216160 and r216161.
1059         https://bugs.webkit.org/show_bug.cgi?id=171640
1060
1061         These changes broke the iOS build. (Requested by mlewis13 on
1062         #webkit).
1063
1064         Reverted changesets:
1065
1066         "[MediaStream] Allow host application to enable/disable media
1067         capture"
1068         https://bugs.webkit.org/show_bug.cgi?id=171292
1069         http://trac.webkit.org/changeset/216160
1070
1071         "[MediaStream] Allow host application to enable/disable media
1072         capture"
1073         https://bugs.webkit.org/show_bug.cgi?id=171292
1074         http://trac.webkit.org/changeset/216161
1075
1076 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1077
1078         [MediaStream] Allow host application to enable/disable media capture
1079         https://bugs.webkit.org/show_bug.cgi?id=171292
1080         <rdar://problem/31821492>
1081
1082         Reviewed by Jer Noble.
1083
1084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1085         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1086         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1087         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1088         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1089         (MediaCaptureDisabledTest::SetUp):
1090         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1091         (TEST_F):
1092         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1093
1094 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
1095
1096         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
1097         https://bugs.webkit.org/show_bug.cgi?id=171350
1098         <rdar://problem/28600836>
1099
1100         Patched by Brady Eidson.
1101
1102         Reviewed by Brent Fulgham.
1103
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1105         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
1106         (TestWebKitAPI::runJavaScriptAlert):
1107         (TestWebKitAPI::decidePolicyForNavigationAction):
1108         (TestWebKitAPI::decidePolicyForNavigationResponse):
1109         (TestWebKitAPI::TEST):
1110         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
1111
1112 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
1113
1114         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
1115         https://bugs.webkit.org/show_bug.cgi?id=171619
1116         https://bugs.webkit.org/show_bug.cgi?id=170195
1117
1118         Reviewed by Tim Horton.
1119
1120         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
1121
1122         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1123         (TEST):
1124
1125 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1126
1127         YouTube user agent quirk breaks new YouTube
1128         https://bugs.webkit.org/show_bug.cgi?id=171603
1129
1130         Reviewed by Carlos Garcia Campos.
1131
1132         Remove the YouTube quirk test.
1133
1134         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1135         (TestWebKitAPI::TEST):
1136
1137 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1138
1139         Async image decoding should be disabled for snapshots, printing and preview
1140         https://bugs.webkit.org/show_bug.cgi?id=171467
1141
1142         Reviewed by Simon Fraser.
1143
1144         Add a API test for snapshotting with large images. Ensure the images are
1145         drawn correctly which implies they should have been synchronously decoded.
1146
1147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1148         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
1149         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
1150         (TEST):
1151
1152 2017-05-03  Chris Dumez  <cdumez@apple.com>
1153
1154         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
1155         https://bugs.webkit.org/show_bug.cgi?id=171565
1156         <rdar://problem/31204417>
1157
1158         Reviewed by Sam Weinig.
1159
1160         Add API test coverage.
1161
1162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1163         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
1164         (TestWebKitAPI::didFinishNavigation):
1165         (TestWebKitAPI::didCrashWithReason):
1166         (TestWebKitAPI::TEST):
1167
1168 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1169
1170         check-webkit-style should also keep js-test-post[-async].js in sync
1171         <https://webkit.org/b/171568>
1172
1173         Reviewed by Joseph Pecoraro.
1174
1175         * Scripts/webkitpy/style/checker.py:
1176         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
1177         JavaScript files not to be skipped.
1178         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
1179         (CheckerDispatcher._create_checker): Update to use
1180         _NEVER_SKIPPED_JS_FILES.
1181
1182         * Scripts/webkitpy/style/checkers/jstest.py:
1183         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
1184         This is the list of files containing functions that need to be
1185         kept in sync.
1186         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
1187         we can keep more sets of files in sync between
1188         LayoutTests/resources and LayoutTests/http/tests/resources.
1189         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
1190         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
1191         (JSTestChecker.check_js_test_files): Add 'file_group' argument
1192         for list of files to check instead of using
1193         KEEP_JS_TEST_FILES_IN_SYNC.
1194         (JSTestChecker.check_js_test_functions): Update for
1195         ALL_JS_TEST_FUNCTION_FILES rename.
1196
1197         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
1198         (JSTestCheckerTestCase):
1199         (JSTestCheckerTestCase.test_map_functions_to_dict):
1200         - Add test case for map_functions_to_dict() in jstest.py.
1201
1202 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
1203
1204         ews should indicate in logs when it fails to fetch the attachment
1205         https://bugs.webkit.org/show_bug.cgi?id=171583
1206
1207         Reviewed by Alexey Proskuryakov.
1208
1209         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1210         (Bugzilla.fetch_attachment): Added log statement.
1211
1212 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1213
1214         Rolling out jstest_unittest.py so it can be reviewed
1215
1216         Follow-up fix for:
1217         check-webkit-style should keep JavaScript test functions in sync
1218         <https://webkit.org/b/171424>
1219
1220         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
1221
1222 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1223
1224         check-webkit-style should keep JavaScript test functions in sync
1225         <https://webkit.org/b/171424>
1226
1227         Reviewed by Joseph Pecoraro.
1228
1229         Add a new JSTestChecker for check-webkit-style that keeps these
1230         two files in sync:
1231
1232             LayoutTests/http/tests/resources/js-test-pre.js
1233             LayoutTests/resources/js-test-pre.js
1234
1235         And keeps implementations of shouldBe(), shouldNotBe(),
1236         shouldNotThrow(), and shouldThrow() in sync across multiple
1237         files (with the ability to add more functions later):
1238
1239             JSTests/stress/resources/standalone-pre.js
1240             LayoutTests/http/tests/resources/js-test-pre.js
1241             LayoutTests/resources/js-test-pre.js
1242             LayoutTests/resources/js-test.js
1243             LayoutTests/resources/standalone-pre.js
1244
1245         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
1246         import for JSTestChecker.
1247         (_NEVER_SKIPPED_FILES): Add array of file names that are never
1248         skipped regardless of other rules.
1249         (_all_categories): Add JSTestChecker categories.
1250         (CheckerDispatcher.should_skip_without_warning): Use
1251         _NEVER_SKIPPED_FILES.
1252         (CheckerDispatcher._create_checker): Return JSTestChecker for
1253         the files to check.
1254
1255         * Scripts/webkitpy/style/checkers/jstest.py: Add.
1256         (map_functions_to_dict): Parse JavaScript source by splitting on
1257         /^function\s+/ regex.  This is good enough for the sanity checks
1258         to keep function implementations in sync.
1259         (strip_blank_lines_and_comments): Strips blank lines and lines
1260         with comments from the end of a chunk of text representing a
1261         function.
1262         (JSTestChecker): New checker.
1263         (JSTestChecker.__init__):
1264         (JSTestChecker.check):
1265         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
1266         (JSTestChecker.check_js_test_functions): Keeps individual
1267         functions in sync.
1268
1269         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
1270         case.
1271         (JSTestTestCase):
1272         (JSTestTestCase.test_map_functions_to_dict):
1273
1274 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
1275
1276         AX: Update implementation of aria-orientation
1277         https://bugs.webkit.org/show_bug.cgi?id=171166
1278
1279         Reviewed by Chris Fleizach.
1280
1281         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
1282         are both absent from the state set. Before we were returning an empty string
1283         which was not consistent with what the Mac port does, thus making shared tests
1284         harder.
1285
1286         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1287         (WTR::AccessibilityUIElement::orientation):
1288
1289 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1290
1291         Stop using sprintf() in JavaScriptCore debugger
1292         <https://webkit.org/b/171512>
1293
1294         Reviewed by Keith Miller.
1295
1296         * Scripts/webkitpy/style/checker.py:
1297         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
1298         Source/JavaScriptCore/disassembler/udis86/ is generated code.
1299
1300 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
1301
1302         Expose viewport-fit instead of clip-to-safe-area
1303         https://bugs.webkit.org/show_bug.cgi?id=171503
1304         <rdar://problem/31918249>
1305
1306         Reviewed by Simon Fraser.
1307
1308         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1309         (WTR::UIScriptController::setSafeAreaInsets):
1310         (WTR::UIScriptController::setObscuredInsets): Deleted.
1311         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1312         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1313         (WTR::UIScriptController::setSafeAreaInsets):
1314         (WTR::UIScriptController::setObscuredInsets): Deleted.
1315         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1316         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1317         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1318         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
1319         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
1320         * WebKitTestRunner/ios/TestControllerIOS.mm:
1321         (WTR::TestController::platformResetStateToConsistentValues):
1322         * WebKitTestRunner/ios/UIKitSPI.h:
1323         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1324         (WTR::UIScriptController::setSafeAreaInsets):
1325         (WTR::UIScriptController::setObscuredInsets): Deleted.
1326         Expose a safe area inset setter instead of obscured insets.
1327
1328 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1329
1330         Unreviewed, fix the build on a new internal SDK
1331
1332         Replace usages of NSItemProviderRepresentationVisibilityAll with
1333         UIItemProviderRepresentationOptionsVisibilityAll.
1334
1335         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1336         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1337         (TestWebKitAPI::TEST):
1338
1339 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1340
1341         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
1342         <https://webkit.org/b/171493>
1343
1344         Reviewed by Dan Bernstein.
1345
1346         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1347         Remove UIKit soft-link since TestWebKitAPI links to
1348         UIKit.framework.
1349         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
1350         UIWindow and UIWebView classes directly.
1351         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1352         Remove UIKit soft-link since TestWebKitAPI links to
1353         UIKit.framework.
1354         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
1355         class directly.
1356
1357 2017-05-01  Brady Eidson  <beidson@apple.com>
1358
1359         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
1360         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
1361
1362         Reviewed by Andy Estes.
1363
1364         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1365         (-[SchemeHandler webView:startURLSchemeTask:]):
1366         (-[SchemeHandler webView:stopURLSchemeTask:]):
1367         (-[SchemeHandler webView:startTask:]): Deleted.
1368         (-[SchemeHandler webView:stopTask:]): Deleted.
1369
1370 2017-05-01  Jason Marcell  <jmarcell@apple.com>
1371
1372         Add a new function for getting the Git hash for a pure git directory.
1373         https://bugs.webkit.org/show_bug.cgi?id=171450
1374
1375         Reviewed by David Kilzer.
1376
1377         * Scripts/VCSUtils.pm:
1378         (gitHashForDirectory):
1379
1380 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
1381
1382         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
1383         https://bugs.webkit.org/show_bug.cgi?id=171496
1384
1385         Reviewed by Chris Fleizach.
1386
1387         Add new attribute names so that the values of the object attributes can be tested.
1388
1389         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1390         (WTR::AccessibilityUIElement::numberAttributeValue):
1391
1392 2017-05-01  Beth Dakin  <bdakin@apple.com>
1393
1394         On-screen panel for candidate bar is in the wrong place when the caret is at the 
1395         start of a paragraph
1396         https://bugs.webkit.org/show_bug.cgi?id=171453
1397         -and corresponding-
1398         rdar://problem/29779764
1399
1400         Reviewed by Tim Horton.
1401
1402         This test hard-codes the y-coordinate for the expected candidateRect. 
1403         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1404         (TEST):
1405
1406 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1407
1408         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
1409         <https://webkit.org/b/171494>
1410
1411         Reviewed by Brent Fulgham.
1412
1413         * Scripts/webkitpy/style/checkers/cpp.py:
1414         (check_language): Change categories for certain checkers from
1415         'runtime/printf' to 'security/printf' so they are no longer
1416         filtered.
1417         (CppChecker.categories): Add 'security/printf'.
1418         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1419         (CppStyleTest.test_insecure_string_operations): Add new test for
1420         sprintf(), strcat() and strcpy().
1421         (CppStyleTest.test_format_strings): Update test results for new
1422         'security/printf' category use.
1423
1424 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
1425
1426         AX: [GTK] Add support to query for aria-current
1427         https://bugs.webkit.org/show_bug.cgi?id=149016
1428
1429         Reviewed by Chris Fleizach.
1430
1431         Implement support for "AXARIACurrent" string attribute value.
1432
1433         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1434
1435 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1436
1437         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
1438
1439         Unreviewed.
1440
1441         Follow-up fix for:
1442         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
1443         https://bugs.webkit.org/show_bug.cgi?id=171486
1444
1445         * Scripts/webkitpy/style/checkers/cpp.py:
1446         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
1447         match and capture the function name.  The latter also mistakenly
1448         matches C-preprocessor directives.
1449         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
1450         is a requirement for the CppChecker class.
1451
1452 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         [GTK] Add automation session API
1455         https://bugs.webkit.org/show_bug.cgi?id=171428
1456
1457         Reviewed by Carlos Alberto Lopez Perez.
1458
1459         Add an automation mode to MiniBrowser using the new API and add a unit test too.
1460
1461         * MiniBrowser/gtk/BrowserWindow.c:
1462         (webViewTitleChanged):
1463         (webViewDecidePolicy):
1464         (newTabCallback):
1465         (openPrivateWindow):
1466         (browserWindowFinalize):
1467         (browser_window_init):
1468         (browser_window_get_or_create_web_view_for_automation):
1469         * MiniBrowser/gtk/BrowserWindow.h:
1470         * MiniBrowser/gtk/main.c:
1471         (createBrowserTab):
1472         (createWebViewForAutomationCallback):
1473         (automationStartedCallback):
1474         (main):
1475         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1476         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
1477         (testAutomationSessionRequestSession):
1478         (beforeAll):
1479         (afterAll):
1480
1481 2017-04-30  Dan Bernstein  <mitz@apple.com>
1482
1483         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
1484         https://bugs.webkit.org/show_bug.cgi?id=171486
1485
1486         Reviewed by Sam Weinig.
1487
1488         * Scripts/webkitpy/style/checkers/cpp.py:
1489         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
1490           alloc…Instance() instead.
1491         (check_style): Invoke new check.
1492
1493 2017-04-30  Brady Eidson  <beidson@apple.com>
1494
1495         More fixing after r215991
1496         https://bugs.webkit.org/show_bug.cgi?id=171483
1497
1498         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1499         (TEST):
1500
1501 2017-04-30  Brady Eidson  <beidson@apple.com>
1502
1503         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
1504         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
1505
1506         Reviewed by Geoff Garen (and kind of Andy Estes).
1507
1508         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1509         (TEST):
1510
1511 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1512
1513         [ATK] Implement support for aria-autocomplete
1514         https://bugs.webkit.org/show_bug.cgi?id=171167
1515
1516         Reviewed by Chris Fleizach.
1517
1518         Add "AXSupportsAutoCompletion" attribute so the presence of
1519         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
1520
1521         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1522         (WTR::AccessibilityUIElement::boolAttributeValue):
1523
1524 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1525
1526         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
1527         https://bugs.webkit.org/show_bug.cgi?id=171170
1528
1529         Reviewed by Chris Fleizach.
1530
1531         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
1532
1533         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1534         (WTR::AccessibilityUIElement::boolAttributeValue):
1535
1536 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
1537
1538         [ATK] Emit object:state-changed:busy event when aria-busy value changes
1539         https://bugs.webkit.org/show_bug.cgi?id=171181
1540
1541         Reviewed by Chris Fleizach.
1542
1543         Add handler for AXElementBusyChanged notifications.
1544
1545         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1546
1547 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
1548
1549         Use PEP8 style guide for raising exceptions in webkitpy.
1550         https://bugs.webkit.org/show_bug.cgi?id=171439
1551
1552         Reviewed by Daniel Bates.
1553
1554         As per https://www.python.org/dev/peps/pep-0008/
1555         "When raising an exception in Python 2, use raise ValueError('message') 
1556         instead of the older form raise ValueError, 'message'"
1557
1558         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
1559         * Scripts/webkitpy/common/thread/messagepump.py: Same.
1560         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
1561         * Scripts/webkitpy/tool/commands/queues.py: Same.
1562         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
1563         * Scripts/webkitpy/tool/multicommandtool.py: Same.
1564         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
1565
1566 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
1567
1568         Add system trace points for Document::updateTouchEventRegions()
1569         https://bugs.webkit.org/show_bug.cgi?id=171470
1570         rdar://problem/31901239
1571
1572         Reviewed by Tim Horton.
1573
1574         Add trace markers for updateTouchEventRegions.
1575
1576         * Tracing/SystemTracePoints.plist:
1577
1578 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1579
1580         webkitpy: Add apple_additions to webkitpy to insert Internal tools
1581         https://bugs.webkit.org/show_bug.cgi?id=170461
1582         <rdar://problem/31433077>
1583
1584         Reviewed by Daniel Bates.
1585
1586         Allow a package to be pulled in by run-webkit-tests which provides an interface to
1587         run layout tests on an iOS device.  If this package is not available, throw an
1588         exception when attempting to run layout tests on an iOS device.
1589
1590         * Scripts/webkitpy/port/config.py:
1591         (apple_additions): Import apple_additions package.
1592         * Scripts/webkitpy/port/device.py:
1593         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
1594         installed on a device.
1595         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
1596         host, the bundle id of the app to be used for testing and a path to the layout test
1597         directory to be mounted on the device.
1598         (Device.finished_testing):
1599         * Scripts/webkitpy/port/factory.py:
1600         (platform_options): Add apple_additions platform options if apple_additions exists.
1601         * Scripts/webkitpy/port/ios.py:
1602         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
1603         to forward, the bundle ID of the testing app and the layout tests directory to
1604         each device.
1605         * Scripts/webkitpy/port/ios_device.py:
1606         (IOSDevicePort):
1607         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
1608         processes to be run.
1609         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
1610         a single device is used, it is still accessed through an array.
1611         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
1612         for worker number map.
1613         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
1614         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
1615         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
1616         (IOSDevicePort.look_for_new_crash_logs): Ditto.
1617         (IOSDevicePort.look_for_new_samples): Ditto.
1618         (IOSDevicePort.sample_process): Ditto.
1619         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
1620         (IOSDevicePort._create_devices): Check that devices are available for testing and check
1621         that we have enough devices for each child process.
1622         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
1623         * Scripts/webkitpy/port/ios_device_unittest.py:
1624         (IOSDeviceTest.test_operating_system):
1625         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
1626         (IOSDeviceTest.test_sample_process): Ditto.
1627         (IOSDeviceTest.test_sample_process_exception): Ditto.
1628
1629 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1630
1631         Fix and re-enable data interaction unit tests
1632         https://bugs.webkit.org/show_bug.cgi?id=171446
1633         <rdar://problem/31820646>
1634
1635         Reviewed by Tim Horton.
1636
1637         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
1638         registering with the UIItemProvider, and instead just register data directly via
1639         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
1640
1641         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1642         (TestWebKitAPI::TEST):
1643         (temporaryURLForDataInteractionFileLoad): Deleted.
1644         (cleanUpDataInteractionTemporaryPath): Deleted.
1645         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
1646         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1647         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1648
1649 2017-04-28  Brady Eidson  <beidson@apple.com>
1650
1651         Teach the DatabaseProcess to be fully SessionID aware
1652         https://bugs.webkit.org/show_bug.cgi?id=171451
1653
1654         Reviewed by Geoffrey Garen.
1655
1656         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1657
1658 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1659
1660         Unreviewed follow-up to r214705.
1661
1662         shut.copytree will fail if given a file as an argument instead of a directory.
1663
1664         * Scripts/webkitpy/common/system/filesystem.py:
1665         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
1666         when source is a file.
1667         (FileSystem.copy_from_base_host): Ditto.
1668
1669 2017-04-28  Chris Dumez  <cdumez@apple.com>
1670
1671         Update DOMTokenList.replace() to match the latest DOM specification
1672         https://bugs.webkit.org/show_bug.cgi?id=171388
1673
1674         Reviewed by Alex Christensen.
1675
1676         Add API test coverage for new Vector API.
1677
1678         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1679         (TestWebKitAPI::TEST):
1680
1681 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1682
1683         WebKitTestRunner/DumpRenderTree prevent device from sleeping
1684         https://bugs.webkit.org/show_bug.cgi?id=170731
1685
1686         Reviewed by Alex Christensen.
1687
1688         While running layout tests on a device, the device should not be put asleep.
1689
1690         * DumpRenderTree/mac/DumpRenderTree.mm:
1691         (dumpRenderTree): Disable idle timer.
1692         * WebKitTestRunner/ios/TestControllerIOS.mm:
1693         (WTR::TestController::platformInitialize): Ditto.
1694
1695 2017-04-28  Brady Eidson  <beidson@apple.com>
1696
1697         Start of support for multiple WebsiteDataStore/SessionIDs per process
1698         https://bugs.webkit.org/show_bug.cgi?id=171422
1699
1700         Reviewed by Geoffrey Garen.
1701
1702         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1703         (TEST):
1704
1705 2017-04-28  Youenn Fablet  <youenn@apple.com>
1706
1707         Adding a runtime flag specific to MediaDevices
1708         https://bugs.webkit.org/show_bug.cgi?id=171433
1709
1710         Reviewed by Geoffrey Garen.
1711
1712         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
1713         Setting media devices runtime flag to true for WTR and DRT.
1714
1715         * DumpRenderTree/mac/DumpRenderTree.mm:
1716         (enableExperimentalFeatures):
1717         (resetWebPreferencesToConsistentValues):
1718         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
1719         (TestWebKitAPI::TEST):
1720         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1721         (TestWebKitAPI::TEST):
1722         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1723         (WTR::InjectedBundle::beginTesting):
1724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1725         (WTR::TestRunner::setMediaDevicesEnabled):
1726         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
1727         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
1728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::resetPreferencesToConsistentValues):
1731
1732 2017-04-28  Dean Jackson  <dino@apple.com>
1733
1734         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
1735         https://bugs.webkit.org/show_bug.cgi?id=171441
1736         <rdar://problem/31826915>
1737
1738         Reviewed by Tim Horton.
1739
1740         Add an API test for GPUCommandQueue, exercising creation
1741         and setting the label.
1742
1743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1744         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
1745         (TestWebKitAPI::TEST_F):
1746
1747 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1748
1749         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
1750         https://bugs.webkit.org/show_bug.cgi?id=171188
1751
1752         Reviewed by Chris Fleizach.
1753
1754         Add "AXModal" attribute string so that we can test the state's exposure.
1755
1756         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1757         (WTR::AccessibilityUIElement::boolAttributeValue):
1758
1759 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1760
1761         [ATK] GridCellRole should implement AtkTableCell (regression?)
1762         https://bugs.webkit.org/show_bug.cgi?id=171179
1763
1764         Reviewed by Chris Fleizach.
1765
1766         Add new "AXInterfaceTableCell" attribute so that we can test whether or
1767         not there is an implementation of AtkTableCell (i.e. without risking false
1768         negatives from bugs in the interface's implementation).
1769
1770         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1771         (WTR::AccessibilityUIElement::boolAttributeValue):
1772
1773 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1774
1775         Move UUID from WebCore/platform to WTF
1776         https://bugs.webkit.org/show_bug.cgi?id=171372
1777
1778         Reviewed by Michael Catanzaro.
1779
1780         * WebKitTestRunner/TestController.cpp:
1781
1782 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1783
1784         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
1785         https://bugs.webkit.org/show_bug.cgi?id=171399
1786
1787         Reviewed by Brady Eidson.
1788
1789         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
1790         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1791         (TEST):
1792
1793 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
1794
1795         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
1796         https://bugs.webkit.org/show_bug.cgi?id=167914
1797
1798         Unreviewed test gardening.
1799
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
1801         (TEST):
1802
1803 2017-04-26  Saam Barati  <sbarati@apple.com>
1804
1805         Add some more testing modes for Wasm tests now that we have tier up
1806         https://bugs.webkit.org/show_bug.cgi?id=171360
1807
1808         Reviewed by Keith Miller.
1809
1810         Lets enable the FTL on all Wasm tests. Let's also run each
1811         test with and without CJIT.
1812
1813         * Scripts/run-jsc-stress-tests:
1814
1815 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
1816
1817         JSC EWS Patch Relevance skips few JSC scripts
1818         https://bugs.webkit.org/show_bug.cgi?id=171351
1819
1820         Reviewed by Alexey Proskuryakov.
1821
1822         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1823         (CheckPatchRelevance): Added few jsc related scripts.
1824
1825 2017-04-26  Youenn Fablet  <youenn@apple.com>
1826
1827         Test importer should delete obsolete files based on w3c-import.log
1828         https://bugs.webkit.org/show_bug.cgi?id=171348
1829
1830         Reviewed by Chris Dumez.
1831
1832         * Scripts/webkitpy/w3c/test_importer.py:
1833         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
1834         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
1835         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1836         (test_remove_obsolete_content):
1837
1838 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1839
1840         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
1841         <rdar://problem/31816459>
1842
1843         Unreviewed infrastructure fix.
1844
1845         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
1846         DYLD_FRAMEWORK_PATH when installing an app.
1847
1848         * Scripts/webkitpy/port/ios.py:
1849         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
1850
1851 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1852
1853         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
1854         https://bugs.webkit.org/show_bug.cgi?id=171163
1855
1856         Reviewed by Chris Fleizach.
1857
1858         Add support for state-change notifications for ATK_STATE_ACTIVE.
1859
1860         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1861
1862 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1863
1864         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
1865         https://bugs.webkit.org/show_bug.cgi?id=171293
1866
1867         Reviewed by Aakash Jain.
1868
1869         We should make an effort to teardown simulators which we booted even when an exception is
1870         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
1871         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
1872         torn down.
1873
1874         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1875         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
1876         * Scripts/webkitpy/port/ios_simulator.py:
1877         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
1878         iOS simulators and teardown and managed devices.
1879         (IOSSimulatorPort._create_simulators): Register teardown function.
1880         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
1881         (IOSSimulatorPort._remove_device): Deleted.
1882
1883 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1884
1885         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
1886         https://bugs.webkit.org/show_bug.cgi?id=171164
1887
1888         Reviewed by Chris Fleizach.
1889
1890         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
1891         AtkStateSet; not what is found in the AtkObject's attributes.
1892
1893         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1894         (WTR::AccessibilityUIElement::hasPopup):
1895
1896 2017-04-25  Alex Christensen  <achristensen@webkit.org>
1897
1898         Encoded filename should be decoded for WKContentExtension.identifier
1899         https://bugs.webkit.org/show_bug.cgi?id=171316
1900
1901         Reviewed by Andy Estes.
1902
1903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1904         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
1905         (TEST_F):
1906         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
1907
1908 2017-04-25  Alex Christensen  <achristensen@webkit.org>
1909
1910         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
1911         https://bugs.webkit.org/show_bug.cgi?id=171297
1912         <rdar://problem/31530719>
1913
1914         Reviewed by Geoffrey Garen.
1915
1916         * TestWebKitAPI/PlatformWebView.h:
1917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1918         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
1919         (TestWebKitAPI::didFinishLoadForFrame):
1920         (TestWebKitAPI::mouseDidMoveOverElement):
1921         (TestWebKitAPI::setClients):
1922         (TestWebKitAPI::TEST):
1923         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1924         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1925         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1926
1927 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1928
1929         Unreviewed, temporarily disable the data interaction unit tests.
1930
1931         The API around data interaction will change significantly in the near future, and
1932         these tests will begin to fail. These will be reenabled once the bots are on an SDK
1933         that supports the updated data interaction API.
1934
1935         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1936         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1937         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1938
1939 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1940
1941         Limit allowed size of document.title to avoid locking WebKit clients
1942         https://bugs.webkit.org/show_bug.cgi?id=165113
1943         <rdar://problem/28324389>
1944
1945         Reviewed by Darin Adler.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1948         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
1949         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
1950         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
1951
1952 2017-04-25  John Wilander  <wilander@apple.com>
1953
1954         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
1955         https://bugs.webkit.org/show_bug.cgi?id=171295
1956         <rdar://problem/31823818>
1957
1958         Reviewed by Brent Fulgham.
1959
1960         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1961         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1962         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
1963         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
1964         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1965         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
1968         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
1969         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1970         * WebKitTestRunner/TestController.h:
1971         * WebKitTestRunner/TestInvocation.cpp:
1972         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1973
1974 2017-04-25  Tim Horton  <timothy_horton@apple.com>
1975
1976         Try to fix the WKTR build after r215758
1977
1978         * Scripts/build-webkittestrunner:
1979
1980 2017-04-25  Daniel Bates  <dabates@apple.com>
1981
1982         Remove more EFL code
1983         https://bugs.webkit.org/show_bug.cgi?id=171288
1984
1985         Rubber-stamped by Simon Fraser.
1986
1987         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
1988         that was part of the EFL port.
1989
1990         * CMakeLists.txt:
1991         * DumpRenderTree/AccessibilityController.h:
1992         * DumpRenderTree/AccessibilityUIElement.cpp:
1993         (AccessibilityUIElement::getJSClass):
1994         * DumpRenderTree/AccessibilityUIElement.h:
1995         * DumpRenderTree/DumpRenderTree.h:
1996         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1997         * ImageDiff/efl/ImageDiff.cpp: Removed.
1998         * MiniBrowser/efl/CMakeLists.txt: Removed.
1999         * MiniBrowser/efl/main.c: Removed.
2000         * Scripts/build-dumprendertree:
2001         * Scripts/build-jsc:
2002         * Scripts/build-webkit:
2003         * Scripts/build-webkittestrunner:
2004         * Scripts/run-minibrowser:
2005         * Scripts/update-webkit-libs-jhbuild:
2006         * Scripts/update-webkitefl-libs: Removed.
2007         * Scripts/webkitdirs.pm:
2008         (argumentsForConfiguration):
2009         (extractNonMacOSHostConfiguration):
2010         (executableProductDir):
2011         (builtDylibPathForName):
2012         (determinePortName):
2013         (launcherPath):
2014         (launcherName):
2015         (getJhbuildPath):
2016         (wrapperPrefixIfNeeded):
2017         (generateBuildSystemFromCMakeProject):
2018         (buildCMakeProjectOrExit):
2019         (isEfl): Deleted.
2020         * Scripts/webkitperl/FeatureList.pm:
2021         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2022         * Scripts/webkitpy/common/config/ports.py:
2023         (DeprecatedPort.port):
2024         (GtkWK2Port.run_webkit_tests_command):
2025         (EflWK2Port): Deleted.
2026         (EflWK2Port.build_webkit_command): Deleted.
2027         * Scripts/webkitpy/port/builders.py:
2028         * Scripts/webkitpy/port/efl.py: Removed.
2029         * Scripts/webkitpy/port/efl_unittest.py: Removed.
2030         * Scripts/webkitpy/port/factory.py:
2031         (platform_options):
2032         (PortFactory):
2033         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2034         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2035         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2036         (TestRebaselineTest.test_baseline_directory):
2037         (TestRebaselineExpectations.test_rebaseline_expectations):
2038         * TestWebKitAPI/PlatformEfl.cmake: Removed.
2039         * TestWebKitAPI/PlatformWebView.h:
2040         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2041         (TestWebKitAPI::TEST):
2042         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
2043         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
2044         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
2045         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
2046         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
2047         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
2048         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
2049         * TestWebKitAPI/efl/main.cpp: Removed.
2050         * WebKitTestRunner/EventSenderProxy.h:
2051         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2052         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2053         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2054         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2055         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2056         (WTR::EventSendingController::contextClick):
2057         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2058         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2059         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2060         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2061         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
2062         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
2063         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
2064         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
2065         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
2066         * WebKitTestRunner/PlatformEfl.cmake: Removed.
2067         * WebKitTestRunner/PlatformWebView.h:
2068         * WebKitTestRunner/TestController.cpp:
2069         (WTR::TestController::resetStateToConsistentValues):
2070         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
2071         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
2072         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
2073         * WebKitTestRunner/efl/main.cpp: Removed.
2074         * efl/install-dependencies: Removed.
2075         * efl/jhbuild-optional.modules: Removed.
2076         * efl/jhbuild.modules: Removed.
2077         * efl/jhbuildrc: Removed.
2078         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
2079         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
2080         * efl/patches/gst-libav.patch: Removed.
2081         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2082         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2083         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2084         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
2085         * gtk/manifest.txt.in:
2086
2087 2017-04-25  Daniel Bates  <dabates@apple.com>
2088
2089         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2090         https://bugs.webkit.org/show_bug.cgi?id=136452
2091         <rdar://problem/23412620>
2092
2093         Reviewed by Brent Fulgham.
2094
2095         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2096
2097         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
2098         as the EFL port is no longer in the WebKit OpenSource repository.
2099         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2100
2101 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2102
2103         Unreviewed follow-up to r215739 and r215740.
2104
2105         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
2106         This (and r215740) was supposed to land in r215739, but I managed to
2107         specify the previous version of the patch.
2108
2109 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2110
2111         Unreviewed follow-up to r215739.
2112
2113         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
2114         libgcrypt patch that enforces the use of /dev/urandom.
2115
2116 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2117
2118         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
2119         https://bugs.webkit.org/show_bug.cgi?id=171270
2120
2121         Reviewed by Michael Catanzaro.
2122
2123         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
2124         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
2125         that use systems that don't yet provide libgcrypt >= 1.7.0.
2126
2127 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2128
2129         [GTK] Improve an unit test for the JHBuild wrapper.
2130         https://bugs.webkit.org/show_bug.cgi?id=168036
2131
2132         Unreviewed follow-up patch after r215727
2133
2134         * Scripts/webkitpy/port/base_unittest.py:
2135         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
2136         wasn't there before calling MockFileSystem.maybe_make_directory(), and
2137         also that it exists after calling it.
2138
2139 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2140
2141         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
2142         https://bugs.webkit.org/show_bug.cgi?id=168036
2143
2144         Reviewed by Michael Catanzaro.
2145
2146         Call ImageDiff with the JHBuild wrapper if we should use it.
2147         Also add some unit tests for the JHBuild wrapper feature.
2148
2149         * Scripts/webkitpy/port/base.py:
2150         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
2151         * Scripts/webkitpy/port/base_unittest.py:
2152         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
2153         * Scripts/webkitpy/port/image_diff.py:
2154         (ImageDiffer._start): The actual fix, use the wrapper if we should.
2155         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
2156         * Scripts/webkitpy/port/port_testcase.py:
2157         (PortTestCase):
2158         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
2159         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
2160         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
2161
2162 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2163
2164         Support reading NSURL titles from the pasteboard when performing data interaction
2165         https://bugs.webkit.org/show_bug.cgi?id=171156
2166         <rdar://problem/31356937>
2167
2168         Reviewed by Tim Horton.
2169
2170         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
2171
2172         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2173         (TestWebKitAPI::TEST):
2174
2175 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2176
2177         Respect fidelity order when reading web content from item providers
2178         https://bugs.webkit.org/show_bug.cgi?id=171155
2179         <rdar://problem/31356937>
2180
2181         Reviewed by Tim Horton.
2182
2183         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
2184         more details.
2185
2186         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2187         (TestWebKitAPI::TEST):
2188
2189 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2190
2191         SyntaxError fix after r215702.
2192         https://bugs.webkit.org/show_bug.cgi?id=168944
2193
2194         Unreviewed "build" fix.
2195
2196         * BuildSlaveSupport/built-product-archive:
2197         (archiveBuiltProduct):
2198
2199 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
2200
2201         Package ImageDiff built with host SDK
2202         https://bugs.webkit.org/show_bug.cgi?id=168944
2203         <rdar://problem/30745642>
2204
2205         Reviewed by David Kilzer.
2206
2207         iOS Simulator and iOS device should archive the ImageDiff built for the host
2208         machine.
2209
2210         * BuildSlaveSupport/built-product-archive:
2211         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
2212         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
2213
2214 2017-04-24  Keith Miller  <keith_miller@apple.com>
2215
2216         ThreadMessage API tests failing on release bots
2217         https://bugs.webkit.org/show_bug.cgi?id=171246
2218
2219         Reviewed by Saam Barati.
2220
2221         Need to make sure that C++ doesn't optimize away our spin loop.
2222
2223         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2224         (runThreadMessageTest):
2225         (TEST):
2226
2227 2017-04-24  Alex Christensen  <achristensen@webkit.org>
2228
2229         Reduce copies and allocations in SharedBuffer::append
2230         https://bugs.webkit.org/show_bug.cgi?id=170956
2231
2232         Reviewed by Andreas Kling.
2233
2234         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2235         (TestWebKitAPI::TEST_F):
2236
2237 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2238
2239         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
2240         https://bugs.webkit.org/show_bug.cgi?id=166680
2241
2242         Reviewed by Michael Catanzaro.
2243
2244         Update remote inspector unit tests.
2245
2246         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
2247         (main):
2248         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2249         (connectToInspectorServer):
2250         (waitUntilInspectorServerIsReady):
2251         (startTestServer):
2252         (testInspectorServerPageList):
2253         (beforeAll):
2254
2255 2017-04-23  Youenn Fablet  <youenn@apple.com>
2256
2257         Add a tool to update expected.txt files from EWS bot results
2258         https://bugs.webkit.org/show_bug.cgi?id=169538
2259
2260         Reviewed by Ryosuke Niwa.
2261
2262         This script updates expected-txt files from bugzilla posted EWS results.
2263         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
2264         have results different from the generic baseline.
2265
2266         * Scripts/update-test-expectations-from-bugzilla: Added.
2267         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
2268         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
2269         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
2270
2271 2017-04-22  Youenn Fablet  <youenn@apple.com>
2272
2273         Add an option to import tip-of-tree WPT tests
2274         https://bugs.webkit.org/show_bug.cgi?id=171152
2275
2276         Reviewed by Joseph Pecoraro.
2277
2278         Adding a '-t' option to import tip of tree WPT tests.
2279         Updating importer based on the fact that csswg-test is no longer a thing. 
2280
2281         * Scripts/webkitpy/w3c/test_downloader.py:
2282         (TestDownloader.download_tests):
2283         * Scripts/webkitpy/w3c/test_importer.py:
2284         (configure_logging):
2285         (TestImporter.do_import):
2286         (TestImporter.write_import_log):
2287
2288 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2289
2290         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
2291         https://bugs.webkit.org/show_bug.cgi?id=171177
2292         <rdar://problem/31765379>
2293
2294         Reviewed by Andy Estes.
2295
2296         Tests uploading a JSON file to a file input.
2297
2298         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2299         (TestWebKitAPI::TEST):
2300
2301 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2302
2303         Support writing link titles to the pasteboard when beginning data interaction on a link
2304         https://bugs.webkit.org/show_bug.cgi?id=171154
2305         <rdar://problem/31356937>
2306
2307         Reviewed by Andy Estes.
2308
2309         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
2310         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
2311         matching the title of the link.
2312
2313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2314         (TestWebKitAPI::TEST):
2315
2316 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2317
2318         Unreviewed, rolling out r215608.
2319
2320         Hundreds of test failures on GTK bot
2321
2322         Reverted changeset:
2323
2324         "Reduce copies and allocations in SharedBuffer::append"
2325         https://bugs.webkit.org/show_bug.cgi?id=170956
2326         http://trac.webkit.org/changeset/215608
2327
2328 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2329
2330         [WK2] Add delegate hooks for overriding unhanded data interaction operations
2331         https://bugs.webkit.org/show_bug.cgi?id=171005
2332         <rdar://problem/31669646>
2333
2334         Reviewed by Tim Horton.
2335
2336         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
2337         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
2338         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
2339
2340         New API test:
2341         DataInteractionTests.OverrideDataInteractionOperation
2342
2343         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2344         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2345         (TestWebKitAPI::TEST):
2346         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2347         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2348         (-[DataInteractionSimulator initWithWebView:]):
2349         (-[DataInteractionSimulator dealloc]):
2350         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
2351         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
2352         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
2353
2354 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
2355
2356         Temporarily disable two flaky API tests.
2357
2358         Unreviewed test gardening.
2359
2360         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2361         (TEST):
2362         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2363         (TEST):
2364
2365 2017-04-21  Keith Miller  <keith_miller@apple.com>
2366
2367         Unreviewed, rolling out r215634.
2368
2369         underlying build issues should have been fixed
2370
2371         Reverted changeset:
2372
2373         "Unreviewed, rolling out r215620 and r215623."
2374         https://bugs.webkit.org/show_bug.cgi?id=171139
2375         http://trac.webkit.org/changeset/215634
2376
2377 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
2378
2379         Bubbles on dashboard doesn't turn red for test262 failures
2380         https://bugs.webkit.org/show_bug.cgi?id=171129
2381
2382         Reviewed by Alexey Proskuryakov.
2383
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
2385
2386 2017-04-21  Commit Queue  <commit-queue@webkit.org>
2387
2388         Unreviewed, rolling out r215620 and r215623.
2389         https://bugs.webkit.org/show_bug.cgi?id=171139
2390
2391         broke arm64 build (Requested by keith_miller on #webkit).
2392
2393         Reverted changesets:
2394
2395         "Add signaling API"
2396         https://bugs.webkit.org/show_bug.cgi?id=170976
2397         http://trac.webkit.org/changeset/215620
2398
2399         "Unreviewed, fix Cloop build."
2400         http://trac.webkit.org/changeset/215623
2401
2402 2017-04-20  Keith Miller  <keith_miller@apple.com>
2403
2404         Add signaling API
2405         https://bugs.webkit.org/show_bug.cgi?id=170976
2406
2407         Reviewed by Filip Pizlo.
2408
2409         Add tests for ThreadMessages.
2410
2411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2412         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
2413         (runThreadMessageTest):
2414         (TEST):
2415
2416 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
2417
2418         commit-log-editor should respect the git editor if one is set
2419         https://bugs.webkit.org/show_bug.cgi?id=171085
2420         <rdar://problem/31745506>
2421
2422         Reviewed by Daniel Bates.
2423
2424         * Scripts/commit-log-editor:
2425         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
2426         deciding which editor to present. We examine the global editor preference since that may be
2427         set automatically by installers or third-party tools.
2428
2429 2017-04-21  Alex Christensen  <achristensen@webkit.org>
2430
2431         Reduce copies and allocations in SharedBuffer::append
2432         https://bugs.webkit.org/show_bug.cgi?id=170956
2433
2434         Reviewed by Andreas Kling.
2435
2436         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2437         (TestWebKitAPI::TEST_F):
2438
2439 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
2440
2441         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
2442         https://bugs.webkit.org/show_bug.cgi?id=171071
2443
2444         Reviewed by Michael Catanzaro.
2445
2446         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
2447         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
2448         be available for all ports.
2449
2450         * DumpRenderTree/PlatformMac.cmake:
2451         * MiniBrowser/mac/CMakeLists.txt:
2452         * MiniBrowser/win/CMakeLists.txt:
2453         * TestWebKitAPI/PlatformJSCOnly.cmake:
2454         * TestWebKitAPI/PlatformMac.cmake:
2455         * TestWebKitAPI/PlatformWin.cmake:
2456         * WebKitTestRunner/PlatformMac.cmake:
2457
2458 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
2459
2460         Test262 bot does not go red with failures
2461         https://bugs.webkit.org/show_bug.cgi?id=171044
2462
2463         Reviewed by Aakash Jain.
2464
2465         The piped output of run-jsc-stress-tests is different from
2466         its non-piped output. Switch to parsing the correct output.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2469         (RunTest262Tests.countFailures):
2470         Just count the number of lines that start with "FAIL:".
2471
2472         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2473         (RunTest262TestsTest.test_no_regressions_output):
2474         (test_failure_output):
2475         (test_failures_output):
2476         Updated tests with new sample output produced partially from bots and
2477         locally. In cases of failure the return code of run-jsc-stress-tests
2478         is still 0 so update the expected return code in the tests.
2479
2480 2017-04-20  Brady Eidson  <beidson@apple.com>
2481
2482         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
2483         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
2484
2485         Reviewed by Andy Estes.
2486
2487         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
2488         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2489         (resetToConsistentState):
2490         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
2491         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2492         (TEST):
2493         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2494
2495 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2496
2497         [ios-simulator] PositionInformationTests API tests are timing out
2498         https://bugs.webkit.org/show_bug.cgi?id=171089
2499
2500         Rubber-stamped by Tim Horton.
2501
2502         Addresses failures observed in the new position information tests added in r215573 by only running them if the
2503         DATA_INTERACTION feature flag is enabled.
2504
2505         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2506
2507 2017-04-20  Brady Eidson  <beidson@apple.com>
2508
2509         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
2510         https://bugs.webkit.org/show_bug.cgi?id=171083
2511
2512         Unreviewed.
2513
2514         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2515
2516 2017-04-20  Brady Eidson  <beidson@apple.com>
2517
2518         Add CompletionHandlerCallChecker to SPI added in r215545.
2519         https://bugs.webkit.org/show_bug.cgi?id=171067
2520
2521         Reviewed by Dan Bernstein.
2522
2523         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2524         (TEST):
2525         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2526
2527 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2528
2529         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
2530         https://bugs.webkit.org/show_bug.cgi?id=170922
2531         <rdar://problem/31634990>
2532
2533         Reviewed by Tim Horton.
2534
2535         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
2536         WebKit2 ChangeLog for more details.
2537
2538         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2539         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
2540         (TestWebKitAPI::TEST):
2541         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
2542
2543 2017-04-20  Xan Lopez  <xlopez@igalia.com>
2544
2545         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
2546         https://bugs.webkit.org/show_bug.cgi?id=170942
2547
2548         Reviewed by Carlos Garcia Campos.
2549
2550         Update glib and glib-networking to the last stable releases. This
2551         is needed to get working TLS certificate verification at all at
2552         least in Fedora.
2553
2554         * gtk/install-dependencies: add libmount, needed for newer glib.
2555         * gtk/jhbuild.modules: update glib and glib-networking to last
2556         stable releases.
2557
2558 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
2559
2560         [ATK] Implement support for DPub ARIA roles
2561         https://bugs.webkit.org/show_bug.cgi?id=170679
2562
2563         Reviewed by Chris Fleizach.
2564
2565         Add DPub ARIA landmark roles to roleToString().
2566
2567         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2568
2569 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
2570
2571         Remove WebKitTestRunner code for enabling features that are already enabled by default
2572         https://bugs.webkit.org/show_bug.cgi?id=171033
2573
2574         Reviewed by Ryosuke Niwa.
2575
2576         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2577         (WTR::InjectedBundle::beginTesting):
2578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2579         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
2580         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
2581         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
2582         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
2583         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2584
2585 2017-04-19  Youenn Fablet  <youenn@apple.com>
2586
2587         [Mac] Allow customizing H264 encoder
2588         https://bugs.webkit.org/show_bug.cgi?id=170829
2589
2590         Reviewed by Alex Christensen.
2591
2592         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2593
2594 2017-04-19  Brady Eidson  <beidson@apple.com>
2595
2596         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
2597         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
2598
2599         Reviewed by Tim Horton.
2600
2601         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2602         (TEST):
2603         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2604         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
2605
2606 2017-04-19  Brady Eidson  <beidson@apple.com>
2607
2608         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
2609         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
2610
2611         Reviewed by Alex Christensen.
2612
2613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2614         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
2615
2616 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
2617
2618         [WK2] Run tests with ResourceLoadStatistics enabled
2619         https://bugs.webkit.org/show_bug.cgi?id=170952
2620
2621         Reviewed by Andy Estes.
2622
2623         Excercise the load statistics code during tests.
2624
2625         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2626         (WTR::initializeWebViewConfiguration):
2627
2628 2017-04-19  Bill Ming  <mbbill@gmail.com>
2629
2630         close_fds should be set to False on Windows.
2631         https://bugs.webkit.org/show_bug.cgi?id=170838
2632
2633         Reviewed by Brent Fulgham.
2634
2635         * Scripts/webkitpy/common/system/executive.py:
2636         (Executive._should_close_fds):
2637
2638 2017-04-19  David Kilzer  <ddkilzer@apple.com>
2639
2640         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
2641         <https://webkit.org/b/170994>
2642         <rdar://problem/29889932>
2643
2644         Reviewed by Brent Fulgham.
2645
2646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2647         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
2648         target.
2649         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
2650         (TestWebKitAPI::strip): Helper method to set/get environment
2651         variable for testing.
2652         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
2653         tests.
2654
2655 2017-04-19  JF Bastien  <jfbastien@apple.com>
2656
2657         WebAssembly: add script which can import GCC torture tests
2658         https://bugs.webkit.org/show_bug.cgi?id=170740
2659
2660         Reviewed by Saam Barati.
2661
2662         Add a script which can import the GCC torture tests and create a
2663         yaml file to run them as part of jsc's WebAssembly regression
2664         tests.
2665
2666         This patch doesn't commit the tests themselves because they're
2667         licensed differently.
2668
2669         * Scripts/run-jsc-stress-tests: learn how to run
2670         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
2671         the options because WebAssembly is enabled by default.
2672         * Scripts/update-wasm-gcc-torture.py: Added.
2673         (parse_args):
2674         (update_lkgr):
2675         (untar_torture):
2676         (list_js_files):
2677         (waterfall_known_failures):
2678         (create_yaml):
2679         (main):
2680
2681 2017-04-19  Youenn Fablet  <youenn@apple.com>
2682
2683         Import web-platform-tests/tools
2684         https://bugs.webkit.org/show_bug.cgi?id=170718
2685
2686         Reviewed by Alex Christensen.
2687
2688         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2689         (main):
2690         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2691         (WebPlatformTestServer.ports_to_forward):
2692         (WebPlatformTestServer._prepare_config):
2693         (WebPlatformTestServer._install_modules): Deleted.
2694         * Scripts/webkitpy/w3c/test_importer.py:
2695         (TestImporter.write_html_files_for_templated_js_tests):
2696
2697 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2698
2699         [WK2] Add infrastructure and unit tests for file uploads using data interaction
2700         https://bugs.webkit.org/show_bug.cgi?id=170903
2701         <rdar://problem/31314689>
2702
2703         Reviewed by Tim Horton.
2704
2705         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
2706         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
2707         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
2708         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
2709
2710         New tests:
2711         DataInteractionTests.ExternalSourceImageToFileInput
2712         DataInteractionTests.ExternalSourceHTMLToUploadArea
2713         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
2714         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
2715         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
2716
2717         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2718         (testIconImage):
2719         (temporaryURLForDataInteractionFileLoad):
2720         (cleanUpDataInteractionTemporaryPath):
2721
2722         Creates and tears down temporary file directories for testing data interaction.
2723
2724         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
2725         (TestWebKitAPI::TEST):
2726         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2727         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2728
2729         Make necessary changes to be able to test what happens when data interaction ends over an element with no
2730         operation. Previously, we would always simulate performing a data interaction operation when ending the
2731         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
2732         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
2733         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
2734         the phase to Cancelled and end the run.
2735
2736         (-[DataInteractionSimulator _resetSimulatedState]):
2737         (-[DataInteractionSimulator runFrom:to:]):
2738         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2739         (-[DataInteractionSimulator _advanceProgress]):
2740         (-[DataInteractionSimulator externalItemProviders]):
2741         (-[DataInteractionSimulator setExternalItemProviders:]):
2742
2743         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
2744         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
2745         take multiple item providers.
2746
2747         (-[DataInteractionSimulator externalItemProvider]): Deleted.
2748         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
2749
2750 2017-04-18  John Wilander  <wilander@apple.com>
2751
2752         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
2753         https://bugs.webkit.org/show_bug.cgi?id=170798
2754         <rdar://problem/31595108>
2755
2756         Reviewed by Alex Christensen.
2757
2758         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2759         (TestWebKitAPI::TEST_F):
2760             Added two negative test cases for WebCore::isPublicSuffix().
2761             Added test cases with mixed case domains, localhost, and
2762             non-ASCII for WebCore::topPrivatelyControlledDomain().
2763
2764 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
2765
2766         Unreviewed, rolling out r215346 and 215361.
2767
2768         The problem these changes were fixing was addressed in
2769         <https://trac.webkit.org/changeset/215416/webkit>.
2770
2771         Reverted changesets:
2772
2773         "webkitpy: Ignore previously launched pid when system is under
2774         stress"
2775         https://bugs.webkit.org/show_bug.cgi?id=170741
2776         http://trac.webkit.org/changeset/215346
2777         http://trac.webkit.org/changeset/215361
2778
2779 2017-04-17  Alex Christensen  <achristensen@webkit.org>
2780
2781         Allow Variants of RetainPtrs
2782         https://bugs.webkit.org/show_bug.cgi?id=170923
2783
2784         Reviewed by Tim Horton and Sam Weinig.
2785
2786         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2787         (TestWebKitAPI::TEST):
2788         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
2789         work in Variants.
2790
2791 2017-04-17  Brady Eidson  <beidson@apple.com>
2792
2793         Make WKHTTPCookieStore public.
2794         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
2795
2796         Reviewed by Geoffrey Garen.
2797
2798         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2799         (TEST):
2800
2801 2017-04-17  Youenn Fablet  <youenn@apple.com>
2802
2803         Disable outdated WritableStream API
2804         https://bugs.webkit.org/show_bug.cgi?id=170749
2805         <rdar://problem/31446233>
2806
2807         Reviewed by Alex Christensen.
2808
2809         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2810         - A STREAMS_API compilation flag.
2811         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2812
2813         * DumpRenderTree/mac/DumpRenderTree.mm:
2814         (enableExperimentalFeatures):
2815         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2816         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2817         (WTR::InjectedBundle::beginTesting):
2818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2819         (WTR::TestRunner::setFetchAPIEnabled):
2820         (WTR::TestRunner::setWritableStreamAPIEnabled):
2821         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2822         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2823
2824 2017-04-17  Tim Horton  <timothy_horton@apple.com>
2825
2826         Provide a viewport parameter to disable clipping to the safe area
2827         https://bugs.webkit.org/show_bug.cgi?id=170766
2828         <rdar://problem/31564634>
2829
2830         Reviewed by Beth Dakin.
2831
2832         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2833         (WTR::UIScriptController::setObscuredInsets):
2834         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2835         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2836         (WTR::UIScriptController::setObscuredInsets):
2837         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2838         * WebKitTestRunner/ios/TestControllerIOS.mm:
2839         (WTR::TestController::platformResetStateToConsistentValues):
2840         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2841         (WTR::UIScriptController::setObscuredInsets):
2842         Add a UIScriptController mechanism to install obscured insets
2843         on the web view.
2844
2845 2017-04-17  Dan Bernstein  <mitz@apple.com>
2846
2847         [Cocoa] Move isNullFunctionPointer down into WTF
2848         https://bugs.webkit.org/show_bug.cgi?id=170892
2849
2850         Reviewed by Sam Weinig.
2851
2852         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
2853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2854         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
2855         (TestWebKitAPI::TEST):
2856         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
2857         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
2858         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
2859         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
2860
2861 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
2862
2863         webkitpy: Correct poll when killing ServerProcess
2864
2865         Unreviewed infrastructure fix.
2866
2867         * Scripts/webkitpy/port/server_process.py:
2868         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
2869
2870 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
2871
2872         [MediaStream] Enable getUserMedia API test
2873         https://bugs.webkit.org/show_bug.cgi?id=170901
2874         <rdar://problem/31656594>
2875
2876         Reviewed by Youenn Fablet.
2877
2878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
2879
2880         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2881         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2882         (TestWebKitAPI::TEST): Enable capture with mock devices.
2883         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
2884
2885 2017-04-17  Xan Lopez  <xan@igalia.com>
2886
2887         [GTK] Update the Fedora dependencies for WebKitGTK+
2888         https://bugs.webkit.org/show_bug.cgi?id=170590
2889
2890         Reviewed by Carlos Alberto Lopez Perez.
2891
2892         * gtk/install-dependencies: add a bunch of modules necessary to
2893         get a proper set of GStreamer codecs for WebRTC.
2894
2895 2017-04-16  Sam Weinig  <sam@webkit.org>
2896
2897         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
2898         https://bugs.webkit.org/show_bug.cgi?id=170843
2899
2900         Reviewed by Chris Dumez.
2901
2902         * DumpRenderTree/DerivedSources.make:
2903         * WebKitTestRunner/DerivedSources.make:
2904         * Scripts/webkitpy/bindings/main.py:
2905         (BindingsTests.generate_from_idl):
2906         Pass IDLAttributes.json, as it is now mandatory to have one.
2907
2908 2017-04-14  Mark Lam  <mark.lam@apple.com>
2909
2910         Update architectures in xcconfig files.
2911         https://bugs.webkit.org/show_bug.cgi?id=170867
2912         <rdar://problem/31628104>
2913
2914         Reviewed by Joseph Pecoraro.
2915
2916         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2917         * MobileMiniBrowser/Configurations/Base.xcconfig:
2918         * TestWebKitAPI/Configurations/Base.xcconfig:
2919         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2920         * WebKitTestRunner/Configurations/Base.xcconfig:
2921
2922 2017-04-14  Brady Eidson  <beidson@apple.com>
2923
2924         Fix basic WKURLSchemeHandler bugs.
2925         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
2926
2927         Reviewed by Andy Estes.
2928
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
2931         (-[SchemeHandler initWithData:mimeType:]):
2932         (-[SchemeHandler dealloc]):
2933         (-[SchemeHandler webView:startTask:]):
2934         (-[SchemeHandler webView:stopTask:]):
2935         (TEST):
2936
2937 2017-04-14  Bill Ming  <mbbill@gmail.com>
2938
2939         webkit-patch failed to detect git repository
2940         https://bugs.webkit.org/show_bug.cgi?id=170859
2941
2942         Reviewed by Daniel Bates.
2943
2944         Windows cmd does not accept single quoted path. So, using
2945         double quotes here will provide better platform compatibility.
2946
2947         * Scripts/VCSUtils.pm:
2948         (isGitDirectory):
2949         (isGitSVNDirectory):
2950         (svnRevisionForDirectory):
2951         (svnInfoForPath):
2952
2953 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2954
2955         Unreviewed, rolling out r215374.
2956
2957         This change causes LayoutTests to exit early with crashes on
2958         Sierra.
2959
2960         Reverted changeset:
2961
2962         "webkitpy: Ignore previously launched pid when system is under
2963         stress"
2964         https://bugs.webkit.org/show_bug.cgi?id=170741
2965         http://trac.webkit.org/changeset/215374
2966
2967 2017-04-14  Dan Bernstein  <mitz@apple.com>
2968
2969         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
2970         https://bugs.webkit.org/show_bug.cgi?id=170856
2971
2972         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
2973
2974         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2975
2976 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2977
2978         webkitpy: Ignore previously launched pid when system is under stress
2979         https://bugs.webkit.org/show_bug.cgi?id=170741
2980
2981         Unreviewed infrastructure fix.
2982
2983         Drivers are destroyed between failing layout tests, which is not necessary and
2984         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2985
2986         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2987         (Worker._kill_driver): Do not destroy drivers when they are stopped.
2988         * Scripts/webkitpy/port/driver.py:
2989         (Driver.stop): Reset driver values set in initializer.
2990
2991 2017-04-14  Andy Estes  <aestes@apple.com>
2992
2993         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2994         https://bugs.webkit.org/show_bug.cgi?id=167594
2995
2996         Re-enabled this API test now that webkit.org/b/161967 is fixed.
2997
2998         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2999         (TEST):
3000
3001 2017-04-14  Andy Estes  <aestes@apple.com>
3002
3003         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
3004         https://bugs.webkit.org/show_bug.cgi?id=161967
3005
3006         Reviewed by Alexey Proskuryakov.
3007
3008         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3009         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
3010
3011 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
3012
3013         Unreviewed, rolling out r215363.
3014
3015         This change causes LayoutTests to exit early with crashes.
3016
3017         Reverted changeset:
3018
3019         "webkitpy: Ignore previously launched pid when system is under
3020         stress"
3021         https://bugs.webkit.org/show_bug.cgi?id=170741
3022         http://trac.webkit.org/changeset/215363
3023
3024 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3025
3026         webkitpy: Ignore previously launched pid when system is under stress
3027         https://bugs.webkit.org/show_bug.cgi?id=170741
3028
3029         Unreviewed infrastructure fix.
3030
3031         Drivers are destroyed between failing layout tests, which is not necessary and
3032         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3033
3034         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3035         (Worker._kill_driver): Do not destroy drivers when they are stopped.
3036
3037 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3038
3039         webkitpy: Ignore previously launched pid when system is under stress
3040         https://bugs.webkit.org/show_bug.cgi?id=170741
3041
3042         Unreviewed infrastructure fix.
3043
3044         Server processes are destroyed in the driver, which is not necessary and prevents
3045         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3046
3047         * Scripts/webkitpy/port/driver.py:
3048         (Driver.run_test): Do not destroy server process.
3049         (Driver._start): Only create the server process if it is None.
3050         (Driver.stop): Do not destroy server process.
3051
3052 2017-04-13  Dan Bernstein  <mitz@apple.com>
3053
3054         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
3055         https://bugs.webkit.org/show_bug.cgi?id=170387
3056
3057         Reviewed by Sam Weinig.
3058
3059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3060         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
3061         (TEST):
3062         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
3063         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3064         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
3065         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
3066         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
3067
3068 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
3069
3070         webkitpy: Ignore previously launched pid when system is under stress
3071         https://bugs.webkit.org/show_bug.cgi?id=170741
3072
3073         Reviewed by David Kilzer.
3074
3075         We have seen cases where xcrun simctl launch will return a pid of a previous
3076         process and the process will appear to be running even though it is crashing.
3077         Ensure that the PID that simulator_process is receiving is not the pid of the
3078         previously run process.
3079
3080         * Scripts/webkitpy/port/simulator_process.py:
3081         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
3082
3083 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
3084
3085         Build ImageDiff with host SDK
3086         https://bugs.webkit.org/show_bug.cgi?id=168531
3087
3088         Reviewed by David Kilzer.
3089
3090         ImageDiff should be built and run with the host SDK, not the target SDK.
3091         Build ImageDiff twice, once for the target SDK and once for the host
3092         as an intermediate step towards building for only the host SDK.
3093
3094         * ImageDiff/Makefile: Added.
3095         * Makefile: Add ImageDiff to list of targets.
3096         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
3097         * Scripts/build-webkit: Build ImageDiff for host.
3098         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
3099         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
3100         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
3101         * Scripts/webkitpy/port/base.py:
3102         (Port.check_build): Attempt to build image diff if not found.
3103         (Port.check_image_diff): Enable logging flag.
3104         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
3105
3106 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3107
3108         Clean up SharedBuffer public functions
3109         https://bugs.webkit.org/show_bug.cgi?id=170795
3110
3111         Reviewed by Andreas Kling.
3112
3113         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3114         (TestWebKitAPI::TEST_F):
3115
3116 2017-04-12  Dan Bernstein  <mitz@apple.com>
3117
3118         [Mac] Future-proof .xcconfig files
3119         https://bugs.webkit.org/show_bug.cgi?id=170802
3120
3121         Reviewed by Tim Horton.
3122
3123         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3124         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3125         * MiniBrowser/Configurations/Base.xcconfig:
3126         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3127         * TestWebKitAPI/Configurations/Base.xcconfig:
3128         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3130         * WebKitTestRunner/Configurations/Base.xcconfig:
3131         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3132
3133 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3134
3135         Remove unused SharedBuffer::wrapCFDataArray
3136         https://bugs.webkit.org/show_bug.cgi?id=170794
3137
3138         Reviewed by Brady Eidson.
3139
3140         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3141         (TestWebKitAPI::TEST_F):
3142
3143 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3144
3145         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
3146         https://bugs.webkit.org/show_bug.cgi?id=170502
3147
3148         Reviewed by Mark Lam.
3149
3150         Mechanical change. Use Thread:: APIs.
3151
3152         * DumpRenderTree/JavaScriptThreading.cpp:
3153         (runJavaScriptThread):
3154         (startJavaScriptThreads):
3155         (stopJavaScriptThreads):
3156         * DumpRenderTree/mac/DumpRenderTree.mm:
3157         (testThreadIdentifierMap):
3158         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3159         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3160         (TestWebKitAPI::runLockTest):
3161         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3162
3163 2017-04-12  Alex Christensen  <achristensen@webkit.org>
3164
3165         Modernize vector adoption
3166         https://bugs.webkit.org/show_bug.cgi?id=170758
3167
3168         Reviewed by Geoffrey Garen.
3169
3170         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3171         (TestWebKitAPI::TEST_F):
3172
3173 2017-04-11  Dean Jackson  <dino@apple.com>
3174
3175         Disable outdated WritableStream API
3176         https://bugs.webkit.org/show_bug.cgi?id=170749
3177         <rdar://problem/31446233>
3178
3179         Reviewed by Tim Horton.
3180
3181         The API we implement is no longer accurate. Disable it until we
3182         are compatible with the new specification
3183
3184         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3185
3186 2017-04-11  David Quesada  <david_quesada@apple.com>
3187
3188         Add SPI for handling geolocation authorization requests
3189         https://bugs.webkit.org/show_bug.cgi?id=170362
3190         rdar://problem/17508627
3191
3192         Reviewed by Alex Christensen.
3193
3194         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
3195         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
3196         provide a stub object to simulate the various configurations of geolocation permissions:
3197         1. The app doesn't have permission to use geolocation.
3198         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
3199         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
3200
3201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3202         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
3203         (-[TestCoreLocationProvider setListener:]):
3204         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
3205         (-[TestCoreLocationProvider start]):
3206         (-[TestCoreLocationProvider stop]):
3207         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
3208         (expectException):
3209         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
3210         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3211         (TestWebKitAPI::TEST):
3212         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
3213
3214 2017-04-10  Matt Rajca  <mrajca@apple.com>
3215
3216         Change autoplay state to "prevented" when media is paused due to restrictions.
3217         https://bugs.webkit.org/show_bug.cgi?id=170686
3218
3219         Reviewed by Alex Christensen.
3220
3221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3222         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
3223         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3224         (TEST):
3225
3226 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
3227
3228         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
3229         https://bugs.webkit.org/show_bug.cgi?id=170725
3230
3231         Reviewed by Sam Weinig.
3232
3233         * TestWebKitAPI/Tests/WTF/Time.cpp:
3234         (TestWebKitAPI::TEST):
3235
3236 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3237
3238         Revert r215217
3239         https://bugs.webkit.org/show_bug.cgi?id=170703
3240
3241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3242
3243 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3244
3245         Continue enabling WebRTC
3246         https://bugs.webkit.org/show_bug.cgi?id=170703
3247
3248         Reviewed by Youenn Fablet.
3249
3250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3251
3252 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
3253
3254         Have parseRevisionProperty use default repo name as the Buildbot key.
3255         https://bugs.webkit.org/show_bug.cgi?id=170696
3256
3257         Reviewed by Daniel Bates.
3258
3259         Previously, we needed to set a key and a fallbackKey when addressing
3260         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
3261         that the repo name maps exactly to that key for every repository other
3262         than WebKit.
3263
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3265         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
3266
3267 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
3268
3269         Add test262 JavaScriptCore tests to dashboard
3270         https://bugs.webkit.org/show_bug.cgi?id=170711
3271
3272         Rubber-stamped by Joseph Pecoraro.
3273
3274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3275         (WebKitBuildbot): Added test262 JSC tests to dashboard.
3276
3277 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3278
3279         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
3280         https://bugs.webkit.org/show_bug.cgi?id=170707
3281         <rdar://problem/27788755>
3282
3283         Reviewed by Tim Horton.
3284
3285         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
3286         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3287         (TEST_F):
3288         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3289         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3290         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3291         (TEST):
3292
3293 2017-04-10  Alex Christensen  <achristensen@webkit.org>
3294
3295         Add API to get available content extension identifiers in a WKContentExtensionStore
3296         https://bugs.webkit.org/show_bug.cgi?id=170093
3297
3298         Reviewed by Geoffrey Garen.
3299
3300         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
3301         (TEST_F):
3302
3303 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3304
3305         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
3306         https://bugs.webkit.org/show_bug.cgi?id=170658
3307
3308         Reviewed by Tim Horton.
3309
3310         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
3311         preparation is synchronous, or passes if it is asynchronous.
3312
3313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3314         (TestWebKitAPI::TEST):
3315         * TestWebKitAPI/cocoa/TestWKWebView.h:
3316         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3317         (-[TestWKWebView initWithFrame:]):
3318         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
3319         (-[TestWKWebView _setUpTestWindow:]):
3320
3321 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
3322
3323         [WK2][macOS] Block access to Apple Events before launch.
3324         https://bugs.webkit.org/show_bug.cgi?id=170626
3325         <rdar://problem/16079334>
3326
3327         Reviewed by Alexey Proskuryakov.
3328
3329         Add a new TestWebKitAPI test that fails if Apple Events are sent.
3330
3331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3332         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
3333         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3334         (TestWebKitAPI::didFinishLoadForFrame):
3335         (TestWebKitAPI::TEST):
3336         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
3337         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
3338         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
3339
3340 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
3341
3342         [JSC] Do not run FTL stress tests on MIPS
3343         https://bugs.webkit.org/show_bug.cgi?id=170684
3344
3345         Reviewed by Carlos Alberto Lopez Perez.
3346
3347         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
3348         logic to detect if the platform supports FTL ignores that MIPS does
3349         not support FTL. This adds detection of MIPS (with the magic number
3350         determined empirically) and fixes the determination of whether we
3351         support FTL.
3352
3353         * Scripts/run-jsc-stress-tests:
3354
3355 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
3356
3357         webkitpy: Increase estimate for processes run by iOS Simulators
3358         https://bugs.webkit.org/show_bug.cgi?id=170678
3359         <rdar://problem/31534061>
3360
3361         Reviewed by Aakash Jain.
3362
3363         Previously, it was estimated that each simulated iOS device would run about 100
3364         processes.  With newer versions of iOS, this is closer to 125.
3365
3366         * Scripts/webkitpy/port/ios_simulator.py:
3367         (IOSSimulatorPort): Increase process estimate from 100 to 125.
3368
3369 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
3370
3371         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
3372         https://bugs.webkit.org/show_bug.cgi?id=170553
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
3377         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
3378         to properly position popup menus, and also avoids using functions
3379         which were deprecated starting at that GTK+ release.
3380
3381         * MiniBrowser/gtk/BrowserSearchBar.c:
3382         (searchEntryMenuIconPressedCallback):
3383         Update MiniBrowser to use gtk_menu_popup_at_pointer().
3384
3385 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3386
3387         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
3388         https://bugs.webkit.org/show_bug.cgi?id=170677
3389         <rdar://problem/31512633>
3390
3391         Reviewed by Tim Horton.
3392
3393         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
3394         to allow dropping URLs to trigger page navigation.
3395
3396         * DumpRenderTree/TestOptions.h:
3397         * DumpRenderTree/TestOptions.mm:
3398         (TestOptions::TestOptions):
3399         * DumpRenderTree/mac/DumpRenderTree.mm:
3400         (resetWebViewToConsistentStateBeforeTesting):
3401         * DumpRenderTree/mac/UIDelegate.h:
3402         * DumpRenderTree/mac/UIDelegate.mm:
3403         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
3404         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
3405
3406 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3407
3408         update-webkit-dependency should report $response->message for diagnose
3409         https://bugs.webkit.org/show_bug.cgi?id=170666
3410
3411         Reviewed by Alex Christensen.
3412
3413         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
3414
3415 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3416
3417         Data interaction on an image enclosed by an anchor should vend the anchor's URL
3418         https://bugs.webkit.org/show_bug.cgi?id=170660
3419         <rdar://problem/31043220>
3420
3421         Reviewed by Tim Horton.
3422
3423         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
3424         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
3425         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
3426         rects, but should not be.
3427
3428         See WebCore ChangeLog for more details.
3429
3430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3431         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
3432         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3433         (TestWebKitAPI::TEST):
3434
3435 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3436
3437         [GTK] Remove the GDK dependency from ImageDiff
3438         https://bugs.webkit.org/show_bug.cgi?id=85299
3439
3440         Reviewed by Žan Doberšek.
3441
3442         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
3443         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
3444         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
3445         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
3446         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
3447         and also add CG implementation.
3448
3449         * ImageDiff/CMakeLists.txt:
3450         * ImageDiff/Cairo.cmake: Added.
3451         * ImageDiff/ImageDiff.cpp: Added.
3452         (main):
3453         * ImageDiff/PlatformGTK.cmake:
3454         * ImageDiff/PlatformImage.cpp: Added.
3455         (ImageDiff::PlatformImage::isCompatible):
3456         (ImageDiff::PlatformImage::difference):
3457         * ImageDiff/PlatformImage.h: Added.
3458         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
3459         (ImageDiff::PlatformImage::createFromStdin):
3460         (ImageDiff::PlatformImage::createFromDiffData):
3461         (ImageDiff::PlatformImage::PlatformImage):
3462         (ImageDiff::PlatformImage::~PlatformImage):
3463         (ImageDiff::PlatformImage::width):
3464         (ImageDiff::PlatformImage::height):
3465         (ImageDiff::PlatformImage::rowBytes):
3466         (ImageDiff::PlatformImage::hasAlpha):
3467         (ImageDiff::PlatformImage::pixels):
3468         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3469         * ImageDiff/gtk/ImageDiff.cpp: Removed.
3470
3471 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3472
3473         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
3474         https://bugs.webkit.org/show_bug.cgi?id=170667
3475
3476         Reviewed by Žan Doberšek.
3477
3478         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
3479         that value.
3480
3481         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3482         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
3483
3484 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3485
3486         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
3487         https://bugs.webkit.org/show_bug.cgi?id=170653
3488
3489         Reviewed by Tim Horton.
3490
3491         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
3492         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
3493         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
3494         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
3495
3496         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
3497         * WebKitTestRunner/TestInvocation.cpp:
3498         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
3499         results were created in the web process.
3500         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
3501         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3502         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
3503         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
3504         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3505         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
3506         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
3507         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
3508         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
3509         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
3510         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3511         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
3512         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
3513         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3514         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
3515         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3516         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
3517
3518 2017-04-10  Chris Dumez  <cdumez@apple.com>
3519
3520         Drop Timer::startOneShot() overload taking a double
3521         https://bugs.webkit.org/show_bug.cgi?id=170659
3522
3523         Reviewed by Yusuke Suzuki.
3524
3525         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
3526
3527         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3528         (TestWebKitAPI::TEST):
3529         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3530         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3531
3532 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3533
3534         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
3535         https://bugs.webkit.org/show_bug.cgi?id=170658
3536         <rdar://problem/31431450>
3537
3538         Reviewed by Tim Horton.
3539
3540         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
3541         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
3542         should complete before the unresponsiveness timeout is triggered.
3543
3544         See WebKit2 ChangeLog for more details.
3545
3546         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3547         (TestWebKitAPI::TEST):
3548
3549 2017-04-09  Chris Dumez  <cdumez@apple.com>
3550
3551         Drop Timer::startRepeating() overload taking a double
3552         https://bugs.webkit.org/show_bug.cgi?id=170656
3553
3554         Reviewed by Yusuke Suzuki.
3555
3556         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
3557
3558         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3559         (TestWebKitAPI::TEST):
3560
3561 2017-04-09  Youenn Fablet  <youenn@apple.com>
3562
3563         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
3564         https://bugs.webkit.org/show_bug.cgi?id=170647
3565
3566         Reviewed by Sam Weinig.
3567
3568         * Scripts/webkitpy/common/checkout/scm/git.py:
3569         (Git.fetch): Fetching origin remote in case there is more than one.
3570
3571 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
3572
3573         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
3574         https://bugs.webkit.org/show_bug.cgi?id=170643
3575
3576         Reviewed by Chris Dumez.
3577         
3578         Update the CSSProperties.json style checker to allow:
3579             - comments in codegen_properties
3580             - obsolete-category and obsolete-url in specification blocks
3581             - renamed "done" to "supported"
3582             
3583         Fix some references to codegen_properties to be codegen-properties.
3584
3585         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3586         (JSONCSSPropertiesChecker.validate_status_type):
3587         (JSONCSSPropertiesChecker.validate_property_specification):
3588         (JSONCSSPropertiesChecker.check_codegen_properties):
3589
3590 2017-04-08  Youenn Fablet  <youenn@apple.com>
3591
3592         WebRTC tests gardening
3593         https://bugs.webkit.org/show_bug.cgi?id=170508
3594
3595         Reviewed by Eric Carlson.
3596
3597         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3598
3599 2017-04-07  Keith Miller  <keith_miller@apple.com>
3600
3601         Add a PriorityQueue class
3602         https://bugs.webkit.org/show_bug.cgi?id=170579
3603
3604         Reviewed by Saam Barati.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
3608         (operator  _z ):
3609         (enqueue):
3610         (dequeue):
3611         (TEST):
3612         (compareMove):
3613
3614 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
3615
3616         Replace ES6SampleBench by ARES-6 in run-benchmark
3617         https://bugs.webkit.org/show_bug.cgi?id=170585
3618
3619         Reviewed by Saam Barati.
3620
3621         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
3622         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
3623
3624         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
3625         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
3626
3627 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
3628
3629         REGRESSION(r211382): Complex text with justification erroneously overflows containers
3630         https://bugs.webkit.org/show_bug.cgi?id=170399
3631         <rdar://problem/31442008>
3632
3633         Reviewed by Simon Fraser.
3634
3635         Check for the invariant that the sum of the advances is equal to m_totalWidth.
3636
3637         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3638         (TestWebKitAPI::TEST_F):
3639
3640 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
3641
3642         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
3643         https://bugs.webkit.org/show_bug.cgi?id=167594
3644
3645         Unreviewed test gardening.
3646
3647         Disable this test because it is still timing out on the bots.
3648
3649         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: