[WPE][Qt] loadingChanged signal parameter is unusable
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-30  Philippe Normand  <pnormand@igalia.com>
2
3         [WPE][Qt] loadingChanged signal parameter is unusable
4         https://bugs.webkit.org/show_bug.cgi?id=201301
5
6         Reviewed by Carlos Garcia Campos.
7
8         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
9         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
10         readablity/parameter_name code styl checker rule.
11
12 2019-08-29  Keith Rollin  <krollin@apple.com>
13
14         Update .xcconfig symbols to reflect the current set of past and future product versions.
15         https://bugs.webkit.org/show_bug.cgi?id=200720
16         <rdar://problem/54305032>
17
18         Reviewed by Alex Christensen.
19
20         Remove version symbols related to old OS's we no longer support,
21         ensure that version symbols are defined for OS's we do support.
22
23         * ContentExtensionTester/Configurations/Base.xcconfig:
24         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
25         * DumpRenderTree/mac/Configurations/Base.xcconfig:
26         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
27         * ImageDiff/cg/Configurations/Base.xcconfig:
28         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
29         * MiniBrowser/Configurations/Base.xcconfig:
30         * MiniBrowser/Configurations/DebugRelease.xcconfig:
31         * TestWebKitAPI/Configurations/Base.xcconfig:
32         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
33         * WebEditingTester/Configurations/Base.xcconfig:
34         * WebEditingTester/Configurations/DebugRelease.xcconfig:
35         * WebKitTestRunner/Configurations/Base.xcconfig:
36         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
37         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
38         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
39
40 2019-08-29  Keith Rollin  <krollin@apple.com>
41
42         Remove empty FontCache.cpp file in TestWebKitAPI
43         https://bugs.webkit.org/show_bug.cgi?id=201277
44         <rdar://problem/54820726>
45
46         Reviewed by Alex Christensen.
47
48         Bug 200694 emptied out the contents of FontCache.cpp. This patch
49         removes the file from the project.
50
51         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
52         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
53
54 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
55
56         [ews-app] Status bubble should only display important messages in pop-over
57         https://bugs.webkit.org/show_bug.cgi?id=201308
58
59         Reviewed by Jonathan Bedard.
60
61         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
62         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
63
64 2019-08-29  Keith Rollin  <krollin@apple.com>
65
66         Remove support for macOS < 10.13 (part 3)
67         https://bugs.webkit.org/show_bug.cgi?id=201224
68         <rdar://problem/54795934>
69
70         Reviewed by Darin Adler.
71
72         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
73         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
74         like _MACOS_SINCE_1013.
75
76         Also added some macOS target numbers.
77
78         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
79
80 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
81
82         results.webkit.org: Remove border from tooltip
83         https://bugs.webkit.org/show_bug.cgi?id=201239
84
85         Reviewed by Alex Christensen.
86
87         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
88         (.tooltip-content): Remove border.
89
90 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
91
92         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
93         https://bugs.webkit.org/show_bug.cgi?id=201215
94
95         Reviewed by Don Olmstead.
96
97         MiniBrowser crashed if it was going to go to a unreachable page
98         because WKPageCopyActiveURL returned a nullptr.
99
100         * MiniBrowser/win/WebKitBrowserWindow.cpp:
101         (createString): Added null checking of the argument.
102
103 2019-08-28  Tim Horton  <timothy_horton@apple.com>
104
105         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
106         https://bugs.webkit.org/show_bug.cgi?id=201256
107         <rdar://problem/54809509>
108
109         Reviewed by Simon Fraser.
110
111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
112         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
113         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
114         (TestWebKitAPI::TEST):
115         Add a test. I left many comments because I had a great deal of trouble
116         writing this test and wanted to document my findings.
117
118 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
119
120         results.webkit.org: Do not display branch selector if only one branches available
121         https://bugs.webkit.org/show_bug.cgi?id=201244
122
123         Rubber-stamped by Aakash Jain.
124
125         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
126         container if there aren't multiple branches to choose from.
127
128 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
129
130         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
131         https://bugs.webkit.org/show_bug.cgi?id=201241
132         <rdar://problem/54317588>
133
134         Reviewed by Tim Horton.
135
136         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
137         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
138         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
139         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
140         it believes that the web view has rejected the drop from being handled.
141
142         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
143         to make sure that the web process has had time to send a response after each update.
144
145         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
146         (-[DragAndDropSimulator _advanceProgress]):
147
148 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
149
150         Null check webFrame when creating a print preview to prevent a crash.
151         https://bugs.webkit.org/show_bug.cgi?id=201237
152         <rdar://problem/51618863>
153
154         Reviewed by Tim Horton.
155
156         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
157
158         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
159         (TEST):
160
161 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
162
163         results.webkit.org: Move drawer to the right, open by default
164         https://bugs.webkit.org/show_bug.cgi?id=200977
165
166         Rubber-stamped by Aakash Jain.
167
168         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
169         moving the drawer to the right side of the screen, opening it by default and have it displace
170         instead of hide the main content.
171
172         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
173         (CommitViewUnittest.test_drawer): Support new drawer style.
174         (CommitViewUnittest.test_range_slider): Ditto.
175         (CommitViewUnittest.test_one_line_switch): Ditto.
176         (CommitViewUnittest.test_branch_selection): Ditto.
177         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
178         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
179         (setEnableRecursive): Disable all elements underneath this one 
180         (Drawer): Make drawer a sidebar.
181         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
182         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
183         (:root): Move boldInverseColor into webkit.css.
184         (@media (prefers-color-scheme: dark)):
185         (.sidebar): Sidebars on mobile should behave like drawers.
186         (.sidebar.hidden): Add concept of hidden sidebar.
187         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
188         (.mobile-sidebar-control.display):
189         (.main.under-topbar-with-actions):
190         (@media screen and (min-width: 600px) and (orientation: landscape)):
191         (.sidebar.left.hidden):
192         (.sidebar.right.hidden):
193         (.main.right.hidden):
194         (.main.left.hidden):
195         (@media screen and (min-width: 768px) and (orientation: landscape)):
196         (.sidebar.right):
197         (a.disabled): Add ability to disable a link.
198         (.desktop-control): Add a control which only exists on desktop.
199         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
200         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
201         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
202         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
203         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
204         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
205         (WebSiteTestCase.toggle_drawer): Support new drawer style.
206         (WebSiteTestCase.find_input_with_name): Ditto.
207
208 2019-08-28  Keith Rollin  <krollin@apple.com>
209
210         Remove support for macOS < 10.13 (part 2)
211         https://bugs.webkit.org/show_bug.cgi?id=201197
212         <rdar://problem/54759985>
213
214         Reviewed by Darin Adler.
215
216         Update conditionals that reference WK_MACOS_1013 and suffixes like
217         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
218         later and that these conditionals are always True or False.
219
220         See Bug 200694 for earlier changes in this area.
221
222         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
223
224 2019-08-28  Alicia Boya García  <aboya@igalia.com>
225
226         [MSE][GStreamer] WebKitMediaSrc rework
227         https://bugs.webkit.org/show_bug.cgi?id=199719
228
229         Reviewed by Xabier Rodriguez-Calvar.
230
231         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
232         whitelist.
233
234         * Scripts/webkitpy/style/checker.py:
235
236 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
237
238         Updating inactive contributors in contributors.json.
239
240         * Scripts/webkitpy/common/config/contributors.json:
241
242 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
243
244         results.webkit.org: Auto-expand single configurations
245         https://bugs.webkit.org/show_bug.cgi?id=201218
246
247         Rubber-stamped by Aakash Jain.
248
249         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
250         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
251         configuration has been specified.
252         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
253         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
254         is expanded or collapsed by default.
255
256 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
257
258         results.webkit.org: Sanitize all commit arguments on upload
259         https://bugs.webkit.org/show_bug.cgi?id=201189
260         <rdar://problem/54564837>
261
262         Reviewed by Aakash Jain.
263
264         * resultsdbpy/resultsdbpy/controller/commit.py:
265         (Commit.__init__): Only allow commits to be constructed with valid values.
266         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
267         (CommitController.register): Strip potential API key.
268         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
269         (CommitUnittest.test_invalid): Test that commits which contain html inside the
270         repository_id, branch or commit id are rejected.
271
272 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
273
274         [GTK][WPE] Implement HSTS for the soup network backend
275         https://bugs.webkit.org/show_bug.cgi?id=192074
276
277         Reviewed by Carlos Garcia Campos.
278
279         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
280         Add support to the soup network backend by adding the feature to
281         SoupNetworkSession and handling HSTS protocol upgrades, by
282         propagating the scheme change further to clients. This patch adds
283         the HSTS feature unconditionally, but it still possible to add
284         a boolean property to the web context class if desired.
285
286         Additionally, add API to the WebKitWebsiteDataManager to specify
287         the directory where the HSTS database is saved. If the directory
288         is not set or if the data manager is ephemeral, use a
289         non-persistent, memory only HSTS enforcer.
290
291         Implement as well the methods needed to clean-up and delete HSTS
292         policies from the storage and expose the feature in GTK+
293         MiniBrowser's about:data.
294
295         * MiniBrowser/gtk/main.c:
296         (gotWebsiteDataCallback):
297         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
298         (serverCallback):
299         (testWebsiteDataConfiguration):
300         (testWebsiteDataEphemeral):
301         (prepopulateHstsData):
302         (testWebsiteDataHsts):
303         (beforeAll):
304         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
305         (Test::Test):
306         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
307         * wpe/jhbuild.modules: Ditto
308         * MiniBrowser/gtk/main.c:
309         (gotWebsiteDataCallback):
310
311 2019-08-27  James Darpinian  <jdarpinian@google.com>
312
313         Fix applying diffs that only change file mode
314         https://bugs.webkit.org/show_bug.cgi?id=201191
315
316         Reviewed by Daniel Bates.
317
318         * Scripts/svn-apply:
319         (patch): Handle case of file mode change without content change
320
321 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
322
323         [ews] Status bubble should be red for CANCELLED builds
324         https://bugs.webkit.org/show_bug.cgi?id=201204
325
326         Reviewed by Jonathan Bedard.
327
328         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
329         (StatusBubble._build_bubble):
330
331 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
332
333         [results.webkit.org Webkit.css] Center the legend symbols
334         https://bugs.webkit.org/show_bug.cgi?id=201187
335
336         Reviewed by Jonathan Bedard.
337
338         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
339         (.lengend>.item .dot .text): center the dot symbol vertically
340
341 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
342
343         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
344         https://bugs.webkit.org/show_bug.cgi?id=201000
345         <rdar://problem/53778938>
346
347         Unreviewed follow-up fix.
348
349         * Scripts/webkitpy/port/darwin.py:
350         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
351         spindump call failed.
352         * Scripts/webkitpy/port/darwin_testcase.py:
353         * Scripts/webkitpy/port/ios_device_unittest.py:
354
355 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
356
357         [ews-build] Use update-webkit script in Apply-WatchList EWS
358         https://bugs.webkit.org/show_bug.cgi?id=201179
359
360         Reviewed by Jonathan Bedard.
361
362         * BuildSlaveSupport/ews-build/factories.py:
363         (WatchListFactory): Updated to use CheckOutSource step as well.
364
365 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
366
367         W3C test importer should be able to handle expected references with an absolute path.
368         https://bugs.webkit.org/show_bug.cgi?id=200717
369
370         Reviewed by Youenn Fablet.
371
372         This patch implements the logic to resolve test references with absolute paths
373         when importing w3c tests (like web-platform-tests).
374         When an absolute path is found for a test reference, the parser now
375         tries to find the right file by looking for a relative path inside
376         the root directory of the source test repository.
377         It works when the tool is run in download-mode as well as when the
378         tool is run to import the tests from a local directory.
379
380         This fixes the import of test references for tests like
381         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
382
383         * Scripts/webkitpy/w3c/test_importer.py:
384         (TestImporter._source_root_directory_for_path):
385         (TestImporter.find_importable_tests):
386         * Scripts/webkitpy/w3c/test_importer_unittest.py:
387         (TestImporterTest.import_directory):
388         (test_webkit_test_runner_options):
389         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
390         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
391         * Scripts/webkitpy/w3c/test_parser.py:
392         (TestParser.__init__):
393         (TestParser.analyze_test):
394
395 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
396
397         Remove UIHelper.activateElementAtHumanSpeed
398         https://bugs.webkit.org/show_bug.cgi?id=201147
399
400         Reviewed by Tim Horton.
401
402         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
403         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
404         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
405
406         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
407         * TestRunnerShared/UIScriptContext/UIScriptController.h:
408         (WTR::UIScriptController::doAfterDoubleTapDelay):
409         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
410         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
411         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
412
413 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
414
415         [results.webkit.org Timline] Add symbols to the timeline dot
416         https://bugs.webkit.org/show_bug.cgi?id=201105
417
418         Reviewed by Jonathan Bedard.
419
420         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
421         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
422         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
423         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
424
425 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
426
427         Unreviewed, remove useMaximalFlushInsertionPhase use
428         https://bugs.webkit.org/show_bug.cgi?id=201036
429
430         * Scripts/run-jsc-stress-tests:
431
432 2019-08-26  David Kilzer  <ddkilzer@apple.com>
433
434         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
435         <https://webkit.org/b/201144>
436         <rdar://problem/54689399>
437
438         Reviewed by Brent Fulgham.
439
440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
441         DataDetectorsTestIOS.mm to the project.
442         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
443         test for Data Detectors for phone numbers.
444
445 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
446
447         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
448         https://bugs.webkit.org/show_bug.cgi?id=201129
449         <rdar://problem/51857277>
450
451         Reviewed by Tim Horton.
452
453         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
454         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
455         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
456         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
457         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
458         capable of recognizing further touches yet.
459
460         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
461         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
462         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
463         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
464         allows both of them to be reset.
465
466         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
467         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
468         immediately after sending the first tap. This change in dependencies is caused by the introduction of
469         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
470         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
471         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
472         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
473
474         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
475         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
476         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
477         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
478         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
479         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
480         requiring arbitrary 120 ms "human speed" delays.
481
482         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
483
484         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
485         * TestRunnerShared/UIScriptContext/UIScriptController.h:
486         (WTR::UIScriptController::doubleTapAtPoint):
487
488         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
489         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
490         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
491         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
492         recognized only as a single tap instead of a double tap.
493
494         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
495         gestures use instead to wait after simulating the first tap.
496
497         * WebKitTestRunner/ios/HIDEventGenerator.h:
498         * WebKitTestRunner/ios/HIDEventGenerator.mm:
499         (-[HIDEventGenerator _waitFor:]):
500         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
501
502         Plumb the tap gesture delay through to this helper method.
503
504         (-[HIDEventGenerator tap:completionBlock:]):
505         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
506         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
507         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
508         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
509         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
510         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
511         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
512
513         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
514         attempting to simulate single taps (either using a stylus, or with a regular touch).
515
516         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
517         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
518         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
519
520 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
521
522         results.webkit.org: Allow clicking on the tooltip arrow
523         https://bugs.webkit.org/show_bug.cgi?id=201103
524
525         Rubber-stamped by Aakash Jain.
526
527         By design, the arrow sits above the canvas and intercepts mouse events from it.
528         This will often make an element that has a tooltip unclickable.
529
530         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
531         (xAxisFromScale):
532         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
533         (TimelineFromEndpoint.prototype.render):
534         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
535         (_ToolTip):
536         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
537         (_ToolTip.prototype.set): Set the onClick callback.
538
539 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
540
541         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
542         https://bugs.webkit.org/show_bug.cgi?id=201140
543
544         Reviewed by Jonathan Bedard.
545
546         * BuildSlaveSupport/ews-build/steps.py:
547         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
548         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
549
550 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
551
552         run-webkit-tests: Cap the number of automatically booted simulators at 12
553         https://bugs.webkit.org/show_bug.cgi?id=201139
554
555         Reviewed by Aakash Jain.
556
557         To make local development with simulators more pleasant, machines should
558         never automatically boot more than 12 simulators.
559
560         * Scripts/webkitpy/xcode/simulated_device.py:
561         (SimulatedDeviceManager.max_supported_simulators):
562
563 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
564
565         [ews] Add EWS queue for applying watchlist
566         https://bugs.webkit.org/show_bug.cgi?id=201072
567
568         Reviewed by Jonathan Bedard.
569
570         * BuildSlaveSupport/ews-build/steps.py:
571         (ApplyWatchList): Build step to apply watchlist.
572         (ApplyWatchList.__init__): Set logEnviron to False.
573         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
574         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
575         * BuildSlaveSupport/ews-build/factories.py:
576         (WatchListFactory): Build factory for WatchList.
577         * BuildSlaveSupport/ews-build/loadConfig.py:
578         * BuildSlaveSupport/ews-build/config.json:
579
580 2019-08-26  Youenn Fablet  <youenn@apple.com>
581
582         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
583         https://bugs.webkit.org/show_bug.cgi?id=196870
584
585         Reviewed by Alex Christensen.
586
587         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
588         Accept any server certificate by default.
589
590         * WebKitTestRunner/TestController.cpp:
591         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
592         (WTR::TestController::cocoaResetStateToConsistentValues):
593         (WTR::TestController::setAllowsAnySSLCertificate):
594         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
595         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
596         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
597         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
598
599 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
600
601         Increase log level for watchlist result
602         https://bugs.webkit.org/show_bug.cgi?id=201081
603
604         Reviewed by Jonathan Bedard.
605
606         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
607         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
608         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
609
610 2019-08-23  Chris Dumez  <cdumez@apple.com>
611
612         [geolocation] Rename interfaces and remove [NoInterfaceObject]
613         https://bugs.webkit.org/show_bug.cgi?id=200885
614
615         Reviewed by Alex Christensen.
616
617         * DumpRenderTree/mac/TestRunnerMac.mm:
618         (TestRunner::setMockGeolocationPosition):
619
620 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
621
622         Unreviewed, rolling out r249001.
623
624         Caused one layout test to fail on all configurations and
625         another to time out on Catalina / iOS 13.
626
627         Reverted changeset:
628
629         "Add a WebsiteDataStore delegate to handle
630         AuthenticationChallenge that do not come from pages"
631         https://bugs.webkit.org/show_bug.cgi?id=196870
632         https://trac.webkit.org/changeset/249001
633
634 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
635
636         results.webkit.org: Escape html in changelog
637         https://bugs.webkit.org/show_bug.cgi?id=201025
638         <rdar://problem/54564837>
639
640         Reviewed by Darin Adler.
641
642         * resultsdbpy/resultsdbpy/view/commit_view.py:
643         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
644         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
645         directly into a JavaScript dictionary.
646
647 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
648
649         [WebAuthn] Support NFC authenticators for iOS
650         https://bugs.webkit.org/show_bug.cgi?id=188624
651         <rdar://problem/43354214>
652
653         Reviewed by Chris Dumez.
654
655         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
656         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
657         Setup NFC mock testing configuration.
658
659 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
660
661         [ews] Enable Style queue on new EWS
662         https://bugs.webkit.org/show_bug.cgi?id=201071
663
664         Reviewed by Jonathan Bedard.
665
666         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
667         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
668         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
670         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
671
672 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
673
674         [Win][MiniBrowser] URL bar should be updated for in-page navigations
675         https://bugs.webkit.org/show_bug.cgi?id=201032
676
677         Reviewed by Darin Adler.
678
679         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
680         * MiniBrowser/win/MainWindow.cpp:
681         (MainWindow::init):
682         (MainWindow::activeURLChanged): Added.
683         * MiniBrowser/win/MainWindow.h:
684         * MiniBrowser/win/MiniBrowserWebHost.cpp:
685         (MiniBrowserWebHost::didCommitLoadForFrame):
686         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
687         (MiniBrowserWebHost::updateAddressBar): Deleted.
688         (MiniBrowserWebHost::loadURL): Deleted.
689         * MiniBrowser/win/MiniBrowserWebHost.h:
690         (MiniBrowserWebHost::MiniBrowserWebHost):
691         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
692         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
693         * MiniBrowser/win/PrintWebUIDelegate.cpp:
694         * MiniBrowser/win/WebKitBrowserWindow.cpp:
695         (WebKitBrowserWindow::create):
696         (WebKitBrowserWindow::WebKitBrowserWindow):
697         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
698         (WebKitBrowserWindow::didChangeActiveURL): Added.
699         (WebKitBrowserWindow::createNewPage):
700         (WebKitBrowserWindow::didCommitNavigation): Deleted.
701         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
702         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
703         (WebKitLegacyBrowserWindow::create):
704         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
705         (WebKitLegacyBrowserWindow::init):
706         (WebKitLegacyBrowserWindow::navigateToHistory):
707         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
708
709 2019-08-22  Andy Estes  <aestes@apple.com>
710
711         [watchOS] Disable Content Filtering in the simulator build
712         https://bugs.webkit.org/show_bug.cgi?id=201047
713
714         Reviewed by Tim Horton.
715
716         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
717
718 2019-08-22  Chris Dumez  <cdumez@apple.com>
719
720         Try to recover nicely when getting an unexpected schema in the service workers database
721         https://bugs.webkit.org/show_bug.cgi?id=201002
722         <rdar://problem/54574991>
723
724         Reviewed by Youenn Fablet.
725
726         Add API test coverage.
727
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
730
731 2019-08-22  Keith Rollin  <krollin@apple.com>
732
733         Remove support for tvOS < 13.0
734         https://bugs.webkit.org/show_bug.cgi?id=200963
735         <rdar://problem/54541355>
736
737         Reviewed by Tim Horton.
738
739         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
740         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
741         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
742         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
743         130000" are always True.
744
745         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
746         (TestWebKitAPI::TEST):
747
748 2019-08-22  Daniel Bates  <dabates@apple.com>
749
750         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
751         https://bugs.webkit.org/show_bug.cgi?id=200742
752
753         Reviewed by Simon Fraser.
754
755         The OptionSet synthetic provider must respond to requests for the value of m_storage
756         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
757         of the type summary.
758
759         Synthetic providers substitute alternative debug information (children) for the default
760         information for a variable. The OptionSet type summary is implemented in terms of the
761         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
762         before invoking the type summary handler then evaluating GetChildMemberWithName() on
763         the SBValue passed to the type summary handler will access the substitute information
764         instead of the original debug information. As a result OptionSet's synthetic provider's
765         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
766         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
767         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
768         should return a valid value.
769
770         * lldb/lldb_webkit.py:
771         (FlagEnumerationProvider.__init__):
772         (FlagEnumerationProvider):
773         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
774         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
775         (FlagEnumerationProvider.size): Added.
776         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
777         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
778         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
779         and removed self.size. For the latter we can just expose a getter that returns the size of
780         the list self._elements.
781         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
782         value of m_storage.
783         (WTFOptionSetProvider):
784         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
785         matches the specified index.
786         * lldb/lldb_webkit_unittest.py:
787         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
788         that we return the value of m_storage as the last synthetic child.
789
790 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
791
792         results.webkit.org: Remove branch and repository information from commit tooltip
793         https://bugs.webkit.org/show_bug.cgi?id=201035
794
795         Reviewed by Aakash Jain.
796
797         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
798         (xAxisFromScale): Remove branch and repository information from tooltip.
799
800 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
801
802         run-webkit-tests: Use -noBulkSymbolication when calling spindump
803         https://bugs.webkit.org/show_bug.cgi?id=201000
804         <rdar://problem/53778938>
805
806         Reviewed by Alexey Proskuryakov.
807
808         * Scripts/webkitpy/port/darwin.py:
809         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
810         * Scripts/webkitpy/port/darwin_testcase.py:
811         (DarwinTest.test_tailspin):
812         (DarwinTest.test_get_crash_log): Deleted.
813         * Scripts/webkitpy/port/ios_device_unittest.py:
814         (IOSDeviceTest.test_tailspin):
815
816 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
817
818         [results.webkit.org Webkit.css] Change input's disable style
819         The disable input style will always show the label like it has a value 
820         https://bugs.webkit.org/show_bug.cgi?id=200998
821
822         Reviewed by Jonathan Bedard.
823
824         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
825         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
826         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
827         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
828         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
829         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
830         (@media (prefers-color-scheme: dark)):
831
832 2019-08-17  Darin Adler  <darin@apple.com>
833
834         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
835         https://bugs.webkit.org/show_bug.cgi?id=200862
836
837         Reviewed by Ryosuke Niwa.
838
839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
840         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
841         * WebKitTestRunner/TestController.cpp:
842         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
843         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
844         (WTR::TestController::downloadDidFail): Ditto.
845
846 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
847
848         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
849         https://bugs.webkit.org/show_bug.cgi?id=200978
850
851         Unreviewed follow-up fix.
852
853         Update the string format specifier for unsigned it.
854
855         * MiniBrowser/gtk/main.c:
856         (main):
857         * MiniBrowser/wpe/main.cpp:
858         (main):
859
860 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
861
862         [GTK][WPE] Support for command "--version" on the MiniBrowser
863         https://bugs.webkit.org/show_bug.cgi?id=200978
864
865         Reviewed by Žan Doberšek.
866
867         Printing the engine version used from the MiniBrowser is useful.
868         For example, the test scripts on WPT can use this info to better
869         tag the generated results.
870
871         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
872         (main):
873         * MiniBrowser/wpe/main.cpp: Ditto.
874         (main):
875
876 2019-08-22  Youenn Fablet  <youenn@apple.com>
877
878         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
879         https://bugs.webkit.org/show_bug.cgi?id=196870
880
881         Reviewed by Alex Christensen.
882
883         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
884         Accept any server certificate by default.
885
886         * WebKitTestRunner/TestController.cpp:
887         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
888         (WTR::TestController::cocoaResetStateToConsistentValues):
889         (WTR::TestController::setAllowsAnySSLCertificate):
890         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
891         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
892         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
893         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
894
895 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
896
897         results.webkit.org: Fix drawer style
898         https://bugs.webkit.org/show_bug.cgi?id=200988
899
900         Rubber-stamped by Aakash Jain.
901
902         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
903         (Drawer): Nothing in the drawer should be selectable.
904         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
905         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
906         (.action:hover): Disable underline on 'links' which are actually actions
907         (.unselectable): Make a div unselectable.
908         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
909         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
910
911 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
912
913         [Win][MiniBrowser] Add a progress indicator to the main window
914         https://bugs.webkit.org/show_bug.cgi?id=200970
915
916         Reviewed by Alex Christensen.
917
918         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
919         * MiniBrowser/win/MainWindow.cpp:
920         (MainWindow::init):
921         (MainWindow::resizeSubViews):
922         (MainWindow::progressChanged):
923         (MainWindow::progressFinished):
924         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
925         Added m_hProgressIndicator.
926         (MainWindow::hwnd const): Deleted.
927         (MainWindow::browserWindow const): Deleted.
928         (): Deleted.
929         * MiniBrowser/win/MiniBrowserWebHost.cpp:
930         (MiniBrowserWebHost::onNotify):
931         * MiniBrowser/win/MiniBrowserWebHost.h:
932         * MiniBrowser/win/WebKitBrowserWindow.cpp:
933         (WebKitBrowserWindow::create):
934         (WebKitBrowserWindow::WebKitBrowserWindow):
935         (WebKitBrowserWindow::didChangeIsLoading):
936         (WebKitBrowserWindow::didChangeEstimatedProgress):
937         (WebKitBrowserWindow::createNewPage):
938         * MiniBrowser/win/WebKitBrowserWindow.h:
939         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
940         (WebKitLegacyBrowserWindow::create):
941         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
942         (WebKitLegacyBrowserWindow::init):
943         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
944
945 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
946
947         Unreviewed, rolling out r248970.
948
949         Caused
950         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
951         to fail.
952
953         Reverted changeset:
954
955         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
956         non-empty set"
957         https://bugs.webkit.org/show_bug.cgi?id=200742
958         https://trac.webkit.org/changeset/248970
959
960 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
961
962         results.webkit.org: Add database table to save zip archives to
963         https://bugs.webkit.org/show_bug.cgi?id=200718
964
965         Rubber-stamped by Aakash Jain.
966
967         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
968         (ArchiveContext):
969         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
970         (ArchiveContext.ArchivesByCommit.unpack):
971         (ArchiveContext.assert_zipfile):
972         (ArchiveContext.open_zipfile):
973         (ArchiveContext.__init__):
974         (ArchiveContext.__enter__):
975         (ArchiveContext.__exit__):
976         (ArchiveContext.register): Save the provided archive to Cassandra.
977         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
978         (ArchiveContext._files_for_archive):
979         (ArchiveContext.ls): List all files in the matching archives.
980         (ArchiveContext.file): Extract a file from the matching archives.
981         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
982         (ArchiveContextTest):
983         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
984         (MockModelFactory):
985         (MockModelFactory.process_results):
986         (MockModelFactory.add_mock_archives):
987         * resultsdbpy/resultsdbpy/model/model.py:
988         (Model.__init__): Add an ArchiveContext to the model.
989
990 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
991
992         [ews-build] view layout test results option should be displayed next to layout-test build step
993         https://bugs.webkit.org/show_bug.cgi?id=200048
994
995         Reviewed by Jonathan Bedard.
996
997         * BuildSlaveSupport/ews-build/steps.py:
998         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
999         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
1000
1001 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1002
1003         [ews] Fix capitalization in Found x new Test failure message
1004         https://bugs.webkit.org/show_bug.cgi?id=201004
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         * BuildSlaveSupport/ews-build/steps.py:
1009         (AnalyzeLayoutTestsResults.report_failure):
1010         (AnalyzeAPITestsResults.analyzeResults):
1011         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1012
1013 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1014
1015         Assign ews117 to EWS High-Sierra Debug queues
1016         https://bugs.webkit.org/show_bug.cgi?id=200993
1017
1018         Reviewed by Jonathan Bedard.
1019
1020         * BuildSlaveSupport/ews-build/config.json:
1021
1022 2019-08-21  Daniel Bates  <dabates@apple.com>
1023
1024         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
1025         https://bugs.webkit.org/show_bug.cgi?id=200742
1026
1027         Reviewed by Simon Fraser.
1028
1029         The OptionSet synthetic provider must respond to requests for the value of m_storage
1030         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
1031         of the type summary.
1032
1033         Synthetic providers substitute alternative debug information (children) for the default
1034         information for a variable. The OptionSet type summary is implemented in terms of the
1035         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
1036         before invoking the type summary handler then evaluating GetChildMemberWithName() on
1037         the SBValue passed to the type summary handler will access the substitute information
1038         instead of the original debug information. As a result OptionSet's synthetic provider's
1039         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
1040         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
1041         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
1042         should return a valid value.
1043
1044         * lldb/lldb_webkit.py:
1045         (FlagEnumerationProvider.__init__):
1046         (FlagEnumerationProvider):
1047         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
1048         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
1049         (FlagEnumerationProvider.size): Added.
1050         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
1051         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
1052         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
1053         and removed self.size. For the latter we can just expose a getter that returns the size of
1054         the list self._elements.
1055         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
1056         value of m_storage.
1057         (WTFOptionSetProvider):
1058         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
1059         matches the specified index.
1060
1061 2019-08-21  Alex Christensen  <achristensen@webkit.org>
1062
1063         Disabling text autosizing should prevent text autosizing
1064         https://bugs.webkit.org/show_bug.cgi?id=200955
1065         <rdar://problem/48095374>
1066
1067         Reviewed by Simon Fraser.
1068
1069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1070         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
1071         (TEST):
1072
1073 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
1074
1075         [GTK][WPE] Make debug-test-runner work
1076         https://bugs.webkit.org/show_bug.cgi?id=193576
1077
1078         Reviewed by Michael Catanzaro.
1079
1080         * Scripts/webkitdirs.pm:
1081         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
1082         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
1083         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
1084         (execUnixAppForDebugging): Added.
1085         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
1086
1087 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
1088
1089         Put keygen element behind a runtime flag and disable it by default
1090         https://bugs.webkit.org/show_bug.cgi?id=200850
1091
1092         Reviewed by Antti Koivisto.
1093
1094         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
1095
1096         * DumpRenderTree/TestOptions.cpp:
1097         (TestOptions::TestOptions):
1098         * DumpRenderTree/TestOptions.h:
1099         * DumpRenderTree/mac/DumpRenderTree.mm:
1100         (setWebPreferencesForTestOptions):
1101         * DumpRenderTree/win/DumpRenderTree.cpp:
1102         (setWebPreferencesForTestOptions):
1103         * WebKitTestRunner/TestController.cpp:
1104         (WTR::TestController::resetPreferencesToConsistentValues):
1105         (WTR::updateTestOptionsFromTestHeader):
1106         * WebKitTestRunner/TestOptions.h:
1107         (WTR::TestOptions::hasSameInitializationOptions const):
1108
1109 2019-08-21  Chris Dumez  <cdumez@apple.com>
1110
1111         Add internal setting to disable SecureContext checks
1112         https://bugs.webkit.org/show_bug.cgi?id=200980
1113         <rdar://problem/54438512>
1114
1115         Reviewed by Alex Christensen.
1116
1117         Add API test coverage.
1118
1119         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1120         (log):
1121         (requestPermission):
1122
1123 2019-08-21  Keith Rollin  <krollin@apple.com>
1124
1125         Remove support for watchOS < 6.0
1126         https://bugs.webkit.org/show_bug.cgi?id=200937
1127         <rdar://problem/54524009>
1128
1129         Reviewed by Darin Adler.
1130
1131         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
1132         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
1133         60000. This means that expressions like
1134         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
1135         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
1136
1137         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1138         (TestWebKitAPI::TEST):
1139
1140 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
1141
1142         [results.webkit.org Webkit.css] Add right sidebar
1143         https://bugs.webkit.org/show_bug.cgi?id=200946
1144
1145         Reviewed by Jonathan Bedard.
1146
1147         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1148         (@media screen and (min-width: 600px) and (orientation: landscape)):
1149         (.main.left):
1150         (@media screen and (min-width: 768px) and (orientation: landscape)):
1151         (.sidebar.right):
1152
1153 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
1154
1155         results.webkit.org: Add ToolTips
1156         https://bugs.webkit.org/show_bug.cgi?id=200801
1157
1158         Rubber-stamped by Aakash Jain.
1159
1160         When dots or scale labels are hovered over, we should display a tool tip with additional information about
1161         The specific element.
1162
1163         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
1164         (.tooltip): Add class for ToolTip text box.
1165         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
1166         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
1167         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
1168         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
1169         repositories at a given time.
1170         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1171         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
1172         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
1173         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
1174         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
1175         (_ToolTip):
1176         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
1177         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
1178         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
1179         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
1180         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1181         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
1182         dot and scale elements.
1183         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
1184         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1185
1186 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
1187
1188         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
1189         https://bugs.webkit.org/show_bug.cgi?id=200782
1190
1191         Reviewed by Saam Barati.
1192
1193         * Scripts/run-jsc-stress-tests:
1194
1195 2019-08-20  Darin Adler  <darin@apple.com>
1196
1197         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
1198         https://bugs.webkit.org/show_bug.cgi?id=200921
1199
1200         Reviewed by Saam Barati.
1201
1202         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1203         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
1204         need to abort after the first failure. Added three new tests to the VariadicAppend
1205         test to cover various cases of upconverting from 8-bit to 16-bit strings.
1206
1207 2019-08-20  Dean Jackson  <dino@apple.com>
1208
1209         REGRESSION: Open in New Tab is missing from context menu
1210         https://bugs.webkit.org/show_bug.cgi?id=200909
1211         <rdar://problem/54476169>
1212
1213         Reviewed by Simon Fraser.
1214
1215         Add a new test that runs through the legacy context menu
1216         flow, and verifies that it will be called if there aren't
1217         appropriate delegates for the new API.
1218
1219         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1220         (contextMenuWebViewDriver):
1221         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1222         (TEST):
1223         (-[LegacyPreviewViewController previewActionItems]):
1224         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
1225         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
1226         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1227         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
1228         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
1229
1230 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1231
1232         [JSC] OSR entry to Wasm OMG
1233         https://bugs.webkit.org/show_bug.cgi?id=200362
1234
1235         Reviewed by Michael Saboff.
1236
1237         * Scripts/run-jsc-stress-tests:
1238
1239 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
1240
1241         [results.webkit.org Timeline] Disable back gesture
1242         https://bugs.webkit.org/show_bug.cgi?id=200839
1243
1244         Reviewed by Jonathan Bedard.
1245
1246         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1247         * resultsdbpy/resultsdbpy/view/templates/base.html:
1248
1249 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
1250
1251         results-webkit.org: Add timeout to Redis locks
1252         https://bugs.webkit.org/show_bug.cgi?id=200890
1253
1254         Reviewed by Aakash Jain.
1255
1256         * resultsdbpy/resultsdbpy/model/upload_context.py:
1257         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
1258
1259 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
1260
1261         Remove IDB-specific quota
1262         https://bugs.webkit.org/show_bug.cgi?id=196545
1263         <rdar://problem/54201783>
1264
1265         Reviewed by Youenn Fablet.
1266
1267         * DumpRenderTree/TestRunner.cpp:
1268         (TestRunner::staticFunctions):
1269         (setIDBPerOriginQuotaCallback): Deleted.
1270         * DumpRenderTree/TestRunner.h:
1271         * DumpRenderTree/mac/DumpRenderTree.mm:
1272         (runTest):
1273         * DumpRenderTree/mac/TestRunnerMac.mm:
1274         (TestRunner::setIDBPerOriginQuota): Deleted.
1275         * DumpRenderTree/win/TestRunnerWin.cpp:
1276         (TestRunner::setIDBPerOriginQuota): Deleted.
1277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1279         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1280         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1281         * WebKitTestRunner/TestController.cpp:
1282         (WTR::TestController::resetStateToConsistentValues):
1283         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1284         * WebKitTestRunner/TestController.h:
1285         * WebKitTestRunner/TestInvocation.cpp:
1286         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1287
1288 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1289
1290         [WTF] Style checker should tell errors when it finds std::make_unique
1291         https://bugs.webkit.org/show_bug.cgi?id=200878
1292
1293         Reviewed by Ross Kirsling.
1294
1295         * Scripts/webkitpy/style/checkers/cpp.py:
1296         (check_wtf_make_unique):
1297         (check_style):
1298         (CppChecker):
1299
1300 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
1301
1302         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
1303         https://bugs.webkit.org/show_bug.cgi?id=200620
1304
1305         Reviewed by Geoffrey Garen.
1306
1307         * DumpRenderTree/TestRunner.cpp:
1308         (addURLToRedirectCallback):
1309         (setWillSendRequestClearHeaderCallback):
1310         (TestRunner::setAccummulateLogsForChannel):
1311         (TestRunner::runUIScript):
1312         (TestRunner::setOpenPanelFiles):
1313         * DumpRenderTree/mac/DumpRenderTree.mm:
1314         (dumpFramesAsText):
1315         * DumpRenderTree/mac/EventSendingController.mm:
1316         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1317         * DumpRenderTree/win/DRTDataObject.cpp:
1318         (DRTDataObject::SetData):
1319         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1320         (FrameLoadDelegate::FrameLoadDelegate):
1321         * DumpRenderTree/win/UIDelegate.cpp:
1322         (DRTUndoManager::DRTUndoManager):
1323         (UIDelegate::UIDelegate):
1324         (UIDelegate::resetUndoManager):
1325         * TestWebKitAPI/JavaScriptTest.cpp:
1326         (TestWebKitAPI::runJSTest):
1327         * TestWebKitAPI/PlatformUtilities.cpp:
1328         (TestWebKitAPI::Util::toSTD):
1329         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1330         (TestWebKitAPI::TEST):
1331         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
1332         (TestWebKitAPI::TEST):
1333         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1334         (TestWebKitAPI::TEST):
1335         (TestWebKitAPI::testMovingUsingEnsure):
1336         (TestWebKitAPI::testMovingUsingAdd):
1337         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1338         (TestWebKitAPI::TEST):
1339         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1342         (TestWebKitAPI::runLockTest):
1343         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1344         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1345         (TestWebKitAPI::TEST):
1346         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1347         (TestWebKitAPI::TEST):
1348         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1349         (TestWebKitAPI::TEST):
1350         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1351         (TestWebKitAPI::TEST):
1352         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
1353         (TestWebKitAPI::CARingBufferTest::SetUp):
1354         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1355         (TestWebKitAPI::createTestValue):
1356         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1357         (TestWebKitAPI::TEST):
1358         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1359         (TestWebKitAPI::TEST_F):
1360         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1361         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1362         (TestWebKitAPI::createNewPage):
1363         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1364         (TestWebKitAPI::createNewPage):
1365         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
1366         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
1367         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
1368         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
1369         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
1370         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1371         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1372         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1373         (serverCallback):
1374         (testWebViewAuthenticationProxyHTTPS):
1375         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1376         (WebKitDOMDOMWindowTest::create):
1377         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
1378         (TestWebKitAPI::Util::toSTD):
1379         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1380         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1381         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1382         * TestWebKitAPI/mac/TestFontOptions.mm:
1383         (-[TestFontOptions initWithFontOptions:]):
1384         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1385         (WTR::EventSendingController::callAfterScrollingCompletes):
1386         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1387         (WTR::InjectedBundle::didCreatePage):
1388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1389         (WTR::TestRunner::setOpenPanelFiles):
1390         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1391         * WebKitTestRunner/StringFunctions.h:
1392         (WTR::toSTD):
1393         (WTR::toWTFString):
1394         * WebKitTestRunner/TestController.cpp:
1395         (WTR::TestController::initialize):
1396         (WTR::TestController::generatePageConfiguration):
1397         (WTR::TestController::resetStateToConsistentValues):
1398         (WTR::createTestURL):
1399         (WTR::TestController::runTest):
1400         (WTR::TestController::platformCreateWebView):
1401         * WebKitTestRunner/TestInvocation.cpp:
1402         (WTR::TestInvocation::runUISideScript):
1403         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1404         (WTR::TestController::platformCreateWebView):
1405         (WTR::TestController::setDefaultCalendarType):
1406         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1407         (WTR::getGDKKeySymForKeyRef):
1408         * WebKitTestRunner/ios/TestControllerIOS.mm:
1409         (WTR::TestController::platformResetStateToConsistentValues):
1410         (WTR::TestController::setKeyboardInputModeIdentifier):
1411         * WebKitTestRunner/mac/EventSenderProxy.mm:
1412         (WTR::EventSenderProxy::mouseDown):
1413         (WTR::EventSenderProxy::mouseUp):
1414         (WTR::EventSenderProxy::mouseMoveTo):
1415         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1416         (WTR::wpeKeySymForKeyRef):
1417
1418 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
1419
1420         [ESNext] Implement optional chaining
1421         https://bugs.webkit.org/show_bug.cgi?id=200199
1422
1423         Reviewed by Yusuke Suzuki.
1424
1425         * Scripts/run-jsc-stress-tests:
1426
1427 2019-08-17  Tim Horton  <timothy_horton@apple.com>
1428
1429         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
1430         https://bugs.webkit.org/show_bug.cgi?id=200866
1431         <rdar://problem/50254021>
1432
1433         Reviewed by Simon Fraser.
1434
1435         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1436         (WTR::PlatformWebView::windowSnapshotImage):
1437         Replace some logging with release assertions that we are snapshotting a reasonable
1438         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
1439         "silently" failing with just a log that will be ignored is not helpful.
1440
1441 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
1442
1443         [WTF] ThreadGroupRemove test is flaky
1444         https://bugs.webkit.org/show_bug.cgi?id=200763
1445
1446         Reviewed by Mark Lam.
1447
1448         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
1449         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
1450         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
1451         and releasing the lock after that.
1452
1453         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1454         (TestWebKitAPI::TEST):
1455
1456 2019-08-17  Eric Liang  <ericliang@apple.com>
1457
1458         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
1459         https://bugs.webkit.org/show_bug.cgi?id=200367
1460
1461         Reviewed by Darin Adler.
1462
1463         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
1464
1465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1466         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
1467         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
1468         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
1469         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
1470         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1471         (TestWebKitAPI::TEST):
1472
1473 2019-08-17  Sam Weinig  <weinig@apple.com>
1474
1475         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
1476         https://bugs.webkit.org/show_bug.cgi?id=200756
1477
1478         Reviewed by Darin Adler.
1479
1480         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
1481         StringBuilder::append(...).
1482
1483         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1484         (TestWebKitAPI::TEST):
1485
1486 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
1487
1488         [iOS WK2] Scroll indicators disappear sometimes
1489         https://bugs.webkit.org/show_bug.cgi?id=200791
1490
1491         Reviewed by Tim Horton.
1492
1493         Tests that test that scroll indicators survive subview replacement, and that
1494         a custom view also survives subview replacement.
1495
1496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1497         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
1498         (TestWebKitAPI::TEST):
1499         * TestWebKitAPI/cocoa/TestWKWebView.h:
1500         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1501         (-[TestWKWebView performAfterLoading:]):
1502         (-[UIView wkFirstSubviewWithClass:]):
1503         (-[UIView wkFirstSubviewWithBoundsSize:]):
1504         * TestWebKitAPI/ios/composited.html: Added.
1505         * TestWebKitAPI/ios/overflow-scroll.html: Added.
1506
1507 2019-08-16  John Wilander  <wilander@apple.com>
1508
1509         Add John Wilander as WebKit Reviewer
1510         https://bugs.webkit.org/show_bug.cgi?id=200837
1511
1512         Unreviewed update to contributors.json to change my status to reviewer.
1513         See email on reviewers mailing list for proof of granted privileges.
1514
1515         * Scripts/webkitpy/common/config/contributors.json:
1516
1517 2019-08-16  Timothy Hatcher  <timothy@apple.com>
1518
1519         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
1520         https://bugs.webkit.org/show_bug.cgi?id=200802
1521         rdar://problem/54357818
1522
1523         Reviewed by Tim Horton.
1524
1525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
1526         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
1527         (-[OpaqueTestWKWebView isOpaque]): Added.
1528         (-[NonOpaqueTestWKWebView isOpaque]): Added.
1529         (isOpaque): Added.
1530         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
1531         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
1532         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
1533
1534 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews] Add build steps for Windows Factory
1537         https://bugs.webkit.org/show_bug.cgi?id=200813
1538
1539         Reviewed by Jonathan Bedard.
1540
1541         * BuildSlaveSupport/ews-build/factories.py:
1542         (WindowsFactory.__init__):
1543
1544 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1545
1546         [ews] Report machine uptime in PrintConfiguration
1547         https://bugs.webkit.org/show_bug.cgi?id=200812
1548
1549         Reviewed by Jonathan Bedard.
1550
1551         * BuildSlaveSupport/ews-build/steps.py:
1552         (PrintConfiguration): Added uptime command.
1553         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1554
1555 2019-08-16  Chris Lord  <clord@igalia.com>
1556
1557         Add shared-mime-info to WPE WebKit jhbuild
1558         https://bugs.webkit.org/show_bug.cgi?id=200768
1559
1560         Reviewed by Carlos Alberto Lopez Perez.
1561
1562         * wpe/jhbuild.modules:
1563
1564 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
1565
1566         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
1567         https://bugs.webkit.org/show_bug.cgi?id=200620
1568
1569         Reviewed by Geoffrey Garen.
1570
1571         * DumpRenderTree/AccessibilityController.h:
1572         * DumpRenderTree/GCController.h:
1573         * DumpRenderTree/win/DRTDataObject.cpp:
1574         * DumpRenderTree/win/DRTDataObject.h:
1575         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1576         * DumpRenderTree/win/DRTDropSource.h:
1577         * DumpRenderTree/win/DraggingInfo.h:
1578         * DumpRenderTree/win/EditingDelegate.h:
1579         * DumpRenderTree/win/EventSender.cpp:
1580         * DumpRenderTree/win/FrameLoadDelegate.h:
1581         * DumpRenderTree/win/HistoryDelegate.h:
1582         * DumpRenderTree/win/MD5.h:
1583         * DumpRenderTree/win/PolicyDelegate.h:
1584         * DumpRenderTree/win/ResourceLoadDelegate.h:
1585         * DumpRenderTree/win/TextInputController.h:
1586         * DumpRenderTree/win/UIDelegate.cpp:
1587         * DumpRenderTree/win/UIDelegate.h:
1588         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1589         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
1590         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
1591         * TestWebKitAPI/Counters.h:
1592         * TestWebKitAPI/PlatformWebView.h:
1593         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1594         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1595         (TestWebKitAPI::DerefObserver::ref):
1596         (TestWebKitAPI::DerefObserver::deref):
1597         (TestWebKitAPI::TEST):
1598         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1599         (TestWebKitAPI::DerefObserver::ref):
1600         (TestWebKitAPI::DerefObserver::deref):
1601         (TestWebKitAPI::TEST):
1602         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
1603         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1604         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1605         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1606         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1607         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1608         * WebKitTestRunner/EventSenderProxy.h:
1609         * WebKitTestRunner/GeolocationProviderMock.h:
1610         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1611         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1613         * WebKitTestRunner/PlatformWebView.h:
1614         * WebKitTestRunner/TestInvocation.h:
1615
1616 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
1617
1618         Some improvements on web storage
1619         https://bugs.webkit.org/show_bug.cgi?id=200373
1620
1621         Reviewed by Geoffrey Garen.
1622
1623         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1624         (TEST): update expectation for behavior change.
1625
1626         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
1627         database file.
1628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1629         (WTR::TestRunner::syncLocalStorage):
1630         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1631
1632         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
1633         (WTR::TestController::resetStateToConsistentValues):
1634         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
1635         (WTR::StorageVoidCallback):
1636         (WTR::TestController::clearIndexedDatabases):
1637         (WTR::TestController::clearLocalStorage):
1638         (WTR::TestController::syncLocalStorage):
1639         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
1640         with StorageVoidCallbackContext for general usage.
1641         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
1642         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
1643         * WebKitTestRunner/TestController.h:
1644
1645         * WebKitTestRunner/TestInvocation.cpp:
1646         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
1647         SyncLocalStorage.
1648
1649 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
1650
1651         results.webkit.org: Add content hook to FlaskRequestsResponse
1652         https://bugs.webkit.org/show_bug.cgi?id=200721
1653
1654         Rubber-stamped by Aakash Jain.
1655
1656         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
1657         (FlaskRequestsResponse):
1658         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
1659         Response, conforming to request's API.
1660
1661 2019-08-15  Alex Christensen  <achristensen@webkit.org>
1662
1663         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
1664         https://bugs.webkit.org/show_bug.cgi?id=200750
1665         <rdar://problem/54232261> and <rdar://problem/52355829>
1666
1667         Reviewed by Tim Horton.
1668
1669         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1670         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1671         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1672         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1673         (contextMenuWebViewDriver):
1674         (TEST):
1675
1676 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1677
1678         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
1679         https://bugs.webkit.org/show_bug.cgi?id=200726
1680
1681         Reviewed by Simon Fraser.
1682
1683         To get the pixels as an array of colors, draw the image into a memory
1684         context. The backing memory buffer can then be accessed to get the image
1685         pixels' colors.
1686
1687         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1688         (TestWebKitAPI::TEST):
1689
1690 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
1691
1692         Unreviewed, rolling out r248526.
1693
1694         Caused two IndexedDB perf tests to fail
1695
1696         Reverted changeset:
1697
1698         "Remove IDB-specific quota"
1699         https://bugs.webkit.org/show_bug.cgi?id=196545
1700         https://trac.webkit.org/changeset/248526
1701
1702 2019-08-14  Keith Rollin  <krollin@apple.com>
1703
1704         Remove support for macOS < 10.13
1705         https://bugs.webkit.org/show_bug.cgi?id=200694
1706         <rdar://problem/54278851>
1707
1708         Reviewed by Youenn Fablet.
1709
1710         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
1711         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
1712         101300. This means that expressions like
1713         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
1714         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
1715
1716         * MiniBrowser/AppKitCompatibilityDeclarations.h:
1717         * MiniBrowser/mac/SettingsController.m:
1718         (-[SettingsController init]):
1719         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1720         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
1721         (TestWebKitAPI::createPlatformFont): Deleted.
1722         (TestWebKitAPI::compareFonts): Deleted.
1723         (TestWebKitAPI::TEST_F): Deleted.
1724         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1725         (TestWebKitAPI::TEST):
1726         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1727         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1728         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1729         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1730         (runWebsiteDataStoreCustomPaths):
1731         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
1732
1733 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
1734
1735         [JSC] Less contended MetaAllocator
1736         https://bugs.webkit.org/show_bug.cgi?id=200278
1737
1738         Reviewed by Mark Lam.
1739
1740         Update the interface.
1741
1742         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1743
1744 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
1745
1746         results.webkit.org: 500 errors on API endpoints don't return JSON
1747         https://bugs.webkit.org/show_bug.cgi?id=200722
1748
1749         Reviewed by Aakash Jain.
1750
1751         * resultsdbpy/resultsdbpy/controller/api_routes.py:
1752         (APIRoutes.response_500): We should return the response, instead of abort.
1753
1754 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
1755
1756         results.webkit.org: Don't save configuration multiple times in upload
1757         https://bugs.webkit.org/show_bug.cgi?id=200719
1758
1759         Reviewed by Aakash Jain.
1760
1761         * resultsdbpy/resultsdbpy/model/upload_context.py:
1762         (UploadContext.upload_test_results): Move registering of the configuration out
1763         of the branch loop.
1764
1765 2019-08-14  Youenn Fablet  <youenn@apple.com>
1766
1767         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
1768         https://bugs.webkit.org/show_bug.cgi?id=200706
1769
1770         Reviewed by Alex Christensen.
1771
1772         Libwebrtc is now soft-linked so we can reenable this test.
1773
1774         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
1775         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1776
1777 2019-08-13  Sam Weinig  <weinig@apple.com>
1778
1779         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
1780         https://bugs.webkit.org/show_bug.cgi?id=200675
1781
1782         Reviewed by Darin Adler.
1783
1784         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1785         (TestWebKitAPI::TEST):
1786         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
1787
1788 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
1789
1790         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
1791         https://bugs.webkit.org/show_bug.cgi?id=200456
1792
1793         Reviewed by Jonathan Bedard.
1794
1795         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
1796
1797         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
1798
1799         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1800         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1801         (pointPolygonCollisionDetect): Detact
1802         (pointRightRayLineSegmentCollisionDetect):
1803         (ColorBatchRender):
1804         (ColorBatchRender.prototype.lazyCreateColorSeqs):
1805         (ColorBatchRender.prototype.addSeq):
1806         (ColorBatchRender.prototype.batchRender):
1807         (ColorBatchRender.prototype.clear):
1808         (xScrollStreamRenderFactory):
1809         (Timeline.CanvasSeriesComponent):
1810         (offscreenCachedRenderFactory): Deleted.
1811
1812 2019-08-13  John Wilander  <wilander@apple.com>
1813
1814         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
1815         https://bugs.webkit.org/show_bug.cgi?id=200642
1816         <rdar://problem/53962073>
1817
1818         Reviewed by Alex Christensen.
1819
1820         This patch adds test infrastructure to query whether an origin has an
1821         isolated NSURLSession or not.
1822
1823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1825         (WTR::TestRunner::hasStatisticsIsolatedSession):
1826         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1827         * WebKitTestRunner/TestController.cpp:
1828         (WTR::TestController::hasStatisticsIsolatedSession):
1829         * WebKitTestRunner/TestController.h:
1830         * WebKitTestRunner/TestInvocation.cpp:
1831         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1832
1833 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
1834
1835         Update my status in contributors.json to committer.
1836
1837         Reviewed by Unreviewed
1838
1839         * Scripts/webkitpy/common/config/contributors.json:
1840
1841 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
1842
1843         Adds WebAuthn and AppSSO into watchlist
1844         https://bugs.webkit.org/show_bug.cgi?id=200647
1845
1846         Reviewed by Dewei Zhu.
1847
1848         * Scripts/webkitpy/common/config/watchlist:
1849
1850 2019-08-13  Chris Dumez  <cdumez@apple.com>
1851
1852         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
1853         https://bugs.webkit.org/show_bug.cgi?id=200674
1854         <rdar://problem/50692748>
1855
1856         Reviewed by Geoff Garen.
1857
1858         Add API test coverage.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1861
1862 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
1863
1864         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
1865         https://bugs.webkit.org/show_bug.cgi?id=199857
1866
1867         Reviewed by Yusuke Suzuki.
1868
1869         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1870         (TestWebKitAPI::countThreadGroups):
1871         (TestWebKitAPI::TEST):
1872
1873 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
1874
1875         AX: Homebrew is not allowed to run any script under sudo.
1876         https://bugs.webkit.org/show_bug.cgi?id=173801
1877
1878         Reviewed by Carlos Alberto Lopez Perez.
1879
1880         Latest versions of Homebrew throw an error when run as root.
1881         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
1882
1883         * gtk/install-dependencies:
1884
1885 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
1886
1887         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
1888         https://bugs.webkit.org/show_bug.cgi?id=200644
1889
1890         Reviewed by Aakash Jain.
1891
1892         * Scripts/webkitpy/port/simulator_process.py:
1893         (SimulatorProcess._start): Define system PID after launching app.
1894
1895 2019-08-12  Sam Weinig  <weinig@apple.com>
1896
1897         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
1898         https://bugs.webkit.org/show_bug.cgi?id=200614
1899
1900         Reviewed by Darin Adler.
1901
1902         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
1903         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
1904         
1905         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
1906         StringBuilder::appendSubstring(...).
1907
1908         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1909         (TestWebKitAPI::TEST):
1910         Update for renames.
1911
1912 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
1913
1914         Fix Crash in Mail Search
1915         https://bugs.webkit.org/show_bug.cgi?id=200589
1916
1917         Reviewed by Tim Horton.
1918
1919         If you search backwards first in mail, we would crash,
1920         this tests that codepath.
1921
1922         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1923         (TEST):
1924
1925 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1926
1927         [iPadOS] Web pages sometimes load at half width in Safari
1928         https://bugs.webkit.org/show_bug.cgi?id=200624
1929         <rdar://problem/52694257>
1930
1931         Reviewed by Simon Fraser.
1932
1933         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
1934         web page is created using the post-animated-resize web view dimensions, rather than the original layout
1935         dimensions.
1936
1937         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1938
1939 2019-08-12  Daniel Bates  <dabates@apple.com>
1940
1941         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
1942         https://bugs.webkit.org/show_bug.cgi?id=200548
1943
1944         Reviewed by Darin Adler.
1945
1946         Expose infrastructure to simulate a literal raw key down and a literal key up event.
1947
1948         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1949         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1950         (WTR::UIScriptController::rawKeyDown):
1951         (WTR::UIScriptController::rawKeyUp):
1952         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1953         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1954         (WTR::UIScriptControllerIOS::rawKeyDown):
1955         (WTR::UIScriptControllerIOS::rawKeyUp):
1956
1957 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
1958
1959         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
1960         https://bugs.webkit.org/show_bug.cgi?id=200584
1961
1962         Reviewed by Philippe Normand.
1963
1964         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
1965         Ignore style libwebrtc optionnal 'style issue'
1966
1967         * Scripts/webkitpy/style/checker.py:
1968         * gstreamer/jhbuild.modules:
1969         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
1970
1971 2019-08-12  Youenn Fablet  <youenn@apple.com>
1972
1973         Remove IDB-specific quota
1974         https://bugs.webkit.org/show_bug.cgi?id=196545
1975
1976         Reviewed by Alex Christensen.
1977
1978         * DumpRenderTree/TestRunner.cpp:
1979         (TestRunner::staticFunctions):
1980         (setIDBPerOriginQuotaCallback): Deleted.
1981         * DumpRenderTree/TestRunner.h:
1982         * DumpRenderTree/mac/DumpRenderTree.mm:
1983         (runTest):
1984         * DumpRenderTree/mac/TestRunnerMac.mm:
1985         (TestRunner::setIDBPerOriginQuota): Deleted.
1986         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1988         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1989         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1990         * WebKitTestRunner/TestController.cpp:
1991         (WTR::TestController::resetStateToConsistentValues):
1992         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1993         * WebKitTestRunner/TestController.h:
1994         * WebKitTestRunner/TestInvocation.cpp:
1995         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1996
1997 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
1998
1999         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
2000         https://bugs.webkit.org/show_bug.cgi?id=200621
2001
2002         Reviewed by Dan Bernstein.
2003
2004         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2005
2006 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2007
2008         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
2009         https://bugs.webkit.org/show_bug.cgi?id=200604
2010         <rdar://problem/51273130>
2011
2012         Reviewed by Megan Gardner.
2013
2014         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
2015         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
2016         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
2017         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
2018         remains the same.
2019
2020         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
2021         the caret rect at initial scale 1.
2022
2023         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2024
2025 2019-08-09  Ali Juma  <ajuma@chromium.org>
2026
2027         Don't allow cross-origin iframes to autofocus
2028         https://bugs.webkit.org/show_bug.cgi?id=200515
2029         <rdar://problem/54092988>
2030
2031         Reviewed by Ryosuke Niwa.
2032
2033         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
2034         of cross-origin iframes, since it depends on focusing one of the
2035         frames.
2036
2037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2038         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2039         (TestWebKitAPI::TEST):
2040         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
2041
2042 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2043
2044         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
2045         https://bugs.webkit.org/show_bug.cgi?id=200591
2046         <rdar://problem/54102238>
2047
2048         Reviewed by Ryosuke Niwa and Tim Horton.
2049
2050         Add a new API test to exercise -supportsImagePaste.
2051
2052         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2053         (TestWebKitAPI::TEST):
2054         * TestWebKitAPI/ios/UIKitSPI.h:
2055
2056 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2057
2058         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
2059         [ews-build] Set svn:ignore to various EWS Buildbot files
2060         https://bugs.webkit.org/show_bug.cgi?id=200581
2061
2062         Reviewed by Jonathan Bedard.
2063
2064         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2065
2066 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2067
2068         [ews-build] Set svn:ignore to various EWS Buildbot files
2069         https://bugs.webkit.org/show_bug.cgi?id=200581
2070
2071         Reviewed by Jonathan Bedard.
2072
2073         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2074
2075 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2076
2077         [ews] Add buildbot.tac to repository
2078         https://bugs.webkit.org/show_bug.cgi?id=200580
2079
2080         Reviewed by Jonathan Bedard.
2081
2082         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
2083
2084 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
2085
2086         [GTK] Add missing spellchecking packages to dependencies script
2087         https://bugs.webkit.org/show_bug.cgi?id=200574
2088
2089         Reviewed by Philippe Normand.
2090
2091         These are needed for the spellchecking test in WebContext API tests.
2092
2093         * gtk/install-dependencies:
2094
2095 2019-08-08  Jon Lee  <jonlee@apple.com>
2096
2097         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
2098
2099 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2100
2101         webkitpy: Disable shared clipboard between Simulators
2102         https://bugs.webkit.org/show_bug.cgi?id=200546
2103
2104         Reviewed by Aakash Jain.
2105
2106         * Scripts/webkitpy/xcode/simulated_device.py:
2107         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
2108         managed by run-webkit-tests.
2109
2110 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
2111
2112         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
2113         https://bugs.webkit.org/show_bug.cgi?id=200539
2114         <rdar://problem/54082550>
2115
2116         Reviewed by Dean Jackson.
2117
2118         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2119         * PlatformFTW.cmake: Added.
2120
2121 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2122
2123         [iOS] Position image information should respect the image orientation
2124         https://bugs.webkit.org/show_bug.cgi?id=200487
2125
2126         Reviewed by Simon Fraser.
2127
2128         Add an API test to verify the position image information is drawn rotated
2129         because of respecting its image orientation.
2130
2131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2132         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
2135         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
2136
2137 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2138
2139         [GTK] Fix WebContext languages test
2140         https://bugs.webkit.org/show_bug.cgi?id=200538
2141
2142         Reviewed by Alex Christensen.
2143
2144         This test broke after the format of Accepted-Languages
2145         was changed in r238236, update.
2146
2147         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2148         (testWebContextLanguages):
2149
2150 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2151
2152         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
2153         https://bugs.webkit.org/show_bug.cgi?id=200536
2154
2155         Reviewed by Carlos Alberto Lopez Perez.
2156
2157         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2158         (testWebsiteDataDatabases): Databases take a moment to be written,
2159         wait before fetching the data as it's done in other tests.
2160
2161 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2162
2163         results.webkit.org: Use canvas for timeline
2164         https://bugs.webkit.org/show_bug.cgi?id=200172
2165
2166         Rubber-stamped by Aakash Jain.
2167
2168         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2169         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
2170         (Commit.compare): Ditto.
2171         (_CommitBank.commitByUuid): Ditto.
2172         (_CommitBank._loadSiblings): Ditto.
2173         (_CommitBank._load): Ditto.
2174         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2175         (tickForCommit): Deleted.
2176         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
2177         which encompasses all results. Crucially, this function must exclude an UUIDs which may
2178         refer to results excluded because of the limit argument.
2179         (renderTimeline): Deleted.
2180         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
2181         with those results.
2182         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
2183         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
2184         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
2185         (inPlaceCombine): Combine result objects together.
2186         (statsForSingleResult): Turn a single result into a stat object.
2187         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
2188         (Dot): Deleted.
2189         (TimelineFromEndpoint): Renamed from Timeline.
2190         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
2191         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
2192         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
2193         cache contents.
2194         (TimelineFromEndpoint.reload): Remove management of nested timelines.
2195         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
2196         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
2197         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2198
2199 2019-08-08  Brady Eidson  <beidson@apple.com>
2200
2201         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
2202         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
2203
2204         Reviewed by Geoff Garen.
2205
2206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2207         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
2208
2209 2019-08-08  Rob Buis  <rbuis@igalia.com>
2210
2211         Add runtime flag for lazy image loading
2212         https://bugs.webkit.org/show_bug.cgi?id=199794
2213
2214         Reviewed by Darin Adler.
2215
2216         Set lazyImageLoading preference as part of experimental features. Add
2217         TestOption for lazy image loading.
2218
2219         * DumpRenderTree/TestOptions.cpp:
2220         (TestOptions::TestOptions):
2221         * DumpRenderTree/TestOptions.h:
2222         * DumpRenderTree/mac/DumpRenderTree.mm:
2223         (enableExperimentalFeatures):
2224         (setWebPreferencesForTestOptions):
2225         * DumpRenderTree/win/DumpRenderTree.cpp:
2226         (enableExperimentalFeatures):
2227
2228 2019-08-08  Rob Buis  <rbuis@igalia.com>
2229
2230         Import lazy loading WPT tests
2231         https://bugs.webkit.org/show_bug.cgi?id=199795
2232
2233         Reviewed by Darin Adler.
2234
2235         Only do loading/ exception for WebKit specific, non WPT tests.
2236
2237         * DumpRenderTree/mac/DumpRenderTree.mm:
2238         (shouldLogFrameLoadDelegates):
2239         * WebKitTestRunner/TestInvocation.cpp:
2240         (WTR::TestInvocation::TestInvocation):
2241
2242 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2243
2244         [Win][MiniBrowser] Add key accelerators for reload and close window
2245         https://bugs.webkit.org/show_bug.cgi?id=200497
2246
2247         Reviewed by Brent Fulgham.
2248
2249         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
2250
2251         * MiniBrowser/win/MainWindow.cpp:
2252         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
2253         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
2254         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
2255
2256 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
2257
2258         Add WHLSL and WebGPU to the watchlist file
2259         https://bugs.webkit.org/show_bug.cgi?id=200509
2260
2261         Reviewed by Robin Morisset.
2262
2263         * Scripts/webkitpy/common/config/watchlist:
2264
2265 2019-08-07  Keith Rollin  <krollin@apple.com>
2266
2267         Unreviewed build fix after r248317 -- disable XCBuild because it
2268         breaks incremental builds.
2269
2270         * Scripts/webkitdirs.pm:
2271         (canUseXCBuild):
2272
2273 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2274
2275         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
2276         https://bugs.webkit.org/show_bug.cgi?id=200465
2277
2278         Reviewed by Alex Christensen.
2279
2280         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
2281         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
2282         finishing the test.
2283         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2284         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
2285
2286 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2287
2288         Unreviewed, a build fix after r248308
2289
2290         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
2291
2292         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2293
2294 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2295
2296         Unreviewed, a build fix after r248319
2297
2298         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
2299
2300         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2301         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2302         (WTR::TestController::addTestKeyToKeychain):
2303         (WTR::TestController::cleanUpKeychain):
2304         (WTR::TestController::keyExistsInKeychain):
2305
2306 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2307
2308         Unreviewed, a build fix after r248308
2309
2310         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
2311
2312         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2313         (WTR::TestController::addTestKeyToKeychain):
2314         (WTR::TestController::cleanUpKeychain):
2315         (WTR::TestController::keyExistsInKeychain):
2316
2317 2019-08-06  Keith Rollin  <krollin@apple.com>
2318
2319         Enable XCBuild for `make` and `build-webkit` builds
2320         https://bugs.webkit.org/show_bug.cgi?id=200476
2321         <rdar://problem/50771065>
2322
2323         Reviewed by Jonathan Bedard.
2324
2325         All projects have now been tested under XCBuild and successfully
2326         build. Enable the use of XCBuild when performing builds with `make` or
2327         `build-webkit` and when using a sufficient version of Xcode. We set
2328         this version to Xcode 11 since Xcode 10 -- even though it supports
2329         XCBuild -- does not support a build facility needed to build WebKit
2330         (Bug 197072, Bug 197116, Bug 197340).
2331
2332         Do not enable XCBuild in the Xcode projects themselves since these
2333         projects may need to be used under older versions of Xcode and there's
2334         no way to make those project changes sensitive to the version of Xcode
2335         being used. This means that builds performed in the Xcode IDE will not
2336         use XCBuild.
2337
2338         * Scripts/webkitdirs.pm:
2339         (canUseXCBuild):
2340
2341 2019-08-06  Chris Dumez  <cdumez@apple.com>
2342
2343         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
2344         https://bugs.webkit.org/show_bug.cgi?id=200475
2345
2346         Reviewed by Darin Adler.
2347
2348         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2349         (TestWebKitAPI::stringViewFromLiteral):
2350         (TestWebKitAPI::stringViewFromUTF8):
2351
2352 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2353
2354         Update my status in contributors.json to reviewer.
2355
2356         Regained the status after following the procedure for inactive contributors.
2357         See r247136 for further explanation.
2358
2359         * Scripts/webkitpy/common/config/contributors.json:
2360
2361 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2362
2363         [WebAuthN] Enable LocalAuthenticator for macOS
2364         https://bugs.webkit.org/show_bug.cgi?id=182772
2365         <rdar://problem/43347920>
2366
2367         Reviewed by Brent Fulgham.
2368
2369         Add an entitlement file to WebKitTestRunner such that it can access
2370         the modern macOS keychain.
2371
2372         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
2373         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2374         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2375         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2376         (WTR::TestController::addTestKeyToKeychain):
2377         (WTR::TestController::cleanUpKeychain):
2378         (WTR::TestController::keyExistsInKeychain):
2379
2380 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
2381
2382         [results.webkit.org Timeline] Performance improvements
2383         https://bugs.webkit.org/show_bug.cgi?id=200406
2384
2385         Reviewed by Jonathan Bedard.
2386
2387         1. Unhook the scroll event when a series/axis have been removed from the container
2388         2. Fix the axis's cache data structure out of sync.
2389         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
2390         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
2391
2392
2393         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2394         (Signal.prototype.removeListener):
2395         (prototype.stopAction): Unregsiter an action handler
2396         (Ref):
2397         (Ref.prototype.apply):
2398         (Ref.prototype.destory):
2399         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
2400         (ApplyNewChildren):
2401         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2402         (Timeline.CanvasSeriesComponent):
2403
2404 2019-08-06  Jer Noble  <jer.noble@apple.com>
2405
2406         Add test for behavior introduced in r248174
2407         https://bugs.webkit.org/show_bug.cgi?id=200446
2408
2409         Reviewed by Eric Carlson.
2410
2411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2412         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
2413         (WebKit::configureSecheuristic):
2414         (WebKit::TEST):
2415
2416 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2417
2418         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
2419         https://bugs.webkit.org/show_bug.cgi?id=200464
2420
2421         Reviewed by Ross Kirsling.
2422
2423         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
2424         menu, Alt-F4 to close window, and etc) don't work.
2425
2426         WK1 WebView doesn't have this issue because it processes key events
2427         properly.
2428
2429         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2430         (WebKitBrowserWindow::WebKitBrowserWindow):
2431         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
2432         unhandled key events to the main window.
2433         * MiniBrowser/win/WebKitBrowserWindow.h:
2434
2435 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
2436
2437         iOS 13: Overflow:hidden on body prevents PDF scroll
2438         https://bugs.webkit.org/show_bug.cgi?id=200435
2439         rdar://problem/53942888
2440
2441         Reviewed by Tim Horton.
2442
2443         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
2444         to make sure that the scroll view is scrollable.
2445
2446         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
2447         (TestWebKitAPI::TEST):
2448
2449 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
2450
2451         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
2452         https://bugs.webkit.org/show_bug.cgi?id=200400
2453
2454         Reviewed by Jonathan Bedard.
2455
2456         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2457         (StatusBubble._build_bubble):
2458         (StatusBubble._queue_position):
2459
2460 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
2461
2462         run-webkit-tests asserts when the iPhone XR simulator is running
2463         https://bugs.webkit.org/show_bug.cgi?id=200404
2464         <rdar://problem/53878739>
2465
2466         Reviewed by Dean Jackson.
2467
2468         Support unicode in all logging statements tied to device model.
2469
2470         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2471         (Manager.run):
2472         * Scripts/webkitpy/layout_tests/views/printing.py:
2473         (Printer.print_baseline_search_path):
2474         * Scripts/webkitpy/port/device.py:
2475         (Device.__repr__):
2476         * Scripts/webkitpy/port/device_port.py:
2477         (DevicePort._install):
2478         (DevicePort.setup_test_run):
2479         (DevicePort.clean_up_test_run):
2480         (DevicePort.configuration_for_upload):
2481         * Scripts/webkitpy/port/ios.py:
2482         (IOSPort.default_baseline_search_path):
2483         * Scripts/webkitpy/xcode/device_type.py:
2484         (DeviceType.__str__):
2485         * Scripts/webkitpy/xcode/simulated_device.py:
2486         (SimulatedDeviceManager.populate_available_devices):
2487         (SimulatedDeviceManager._find_available_name):
2488         (SimulatedDeviceManager._get_device_identifier_for_type):
2489         (SimulatedDeviceManager._create_or_find_device_for_request):
2490         (SimulatedDeviceManager._does_fulfill_request):
2491         (SimulatedDeviceManager._wait_until_device_in_state):
2492         (SimulatedDeviceManager._wait_until_device_is_usable):
2493         (SimulatedDeviceManager._boot_device):
2494         (SimulatedDeviceManager.initialize_devices):
2495         (SimulatedDeviceManager.max_supported_simulators):
2496         (SimulatedDeviceManager.swap):
2497         (SimulatedDevice.is_usable):
2498         (SimulatedDevice._shut_down):
2499         (SimulatedDevice._delete):
2500         (SimulatedDevice.launch_app):
2501         (SimulatedDevice.__repr__):
2502
2503 2019-08-04  Chris Dumez  <cdumez@apple.com>
2504
2505         Ping loads should not prevent page caching
2506         https://bugs.webkit.org/show_bug.cgi?id=200418
2507         <rdar://problem/53901632>
2508
2509         Reviewed by Darin Adler.
2510
2511         Add TestOption to enable PageCache at UIProcess-level so that we can test
2512         page caching when navigating cross-origin with PSON enabled.
2513
2514         * WebKitTestRunner/TestController.cpp:
2515         (WTR::TestController::resetPreferencesToConsistentValues):
2516         (WTR::updateTestOptionsFromTestHeader):
2517         * WebKitTestRunner/TestOptions.h:
2518         (WTR::TestOptions::hasSameInitializationOptions const):
2519
2520 2019-08-02  Keith Rollin  <krollin@apple.com>
2521
2522         Consistently use Obj-C boolean literals
2523         https://bugs.webkit.org/show_bug.cgi?id=200405
2524         <rdar://problem/53880043>
2525
2526         Reviewed by Simon Fraser, Joseph Pecoraro.
2527
2528         There are places where we use equivalent but different expressions for
2529         Obj-C boolean objects. For example, we use both [NSNumber
2530         numberWithBool:YES] and @YES. There are places where both are used in
2531         the same function, such as -[WebPreferences initialize]. The boolean
2532         literal is in greater use and is more succinct, so standardize on
2533         that. Also, change @(YES/NO) to @YES/NO.
2534
2535         * DumpRenderTree/mac/ObjCController.m:
2536         (-[ObjCController objectOfClass:]):
2537         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2538         (TEST):
2539         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2540         (overrideAddObserverForName):
2541         * TestWebKitAPI/ios/mainIOS.mm:
2542         (main):
2543         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2544         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2545         * TestWebKitAPI/mac/mainMac.mm:
2546         (main):
2547         * WebKitLauncher/WebKitNightlyEnabler.m:
2548         (enableWebKitNightlyBehaviour):
2549
2550 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2551
2552         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
2553         https://bugs.webkit.org/show_bug.cgi?id=200402
2554         <rdar://problem/53823368>
2555
2556         Reviewed by Tim Horton.
2557
2558         Make it possible to run this test using the iPad simulator.
2559
2560         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2561
2562         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
2563         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
2564         since this would result in differently sized text.
2565
2566         (mainScreenReferenceBoundsOverride):
2567         * TestWebKitAPI/ios/UIKitSPI.h:
2568
2569 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
2570
2571         API tests using permanent credentials should clear credentials left by previous tests
2572         https://bugs.webkit.org/show_bug.cgi?id=199729
2573
2574         Reviewed by Alex Christensen.
2575
2576         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
2577         credentials will not affect tests running after. There is a case where permanent credentials were left on the
2578         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
2579         failure. To prevent this from happening again, add cleanup at the begining of the tests.
2580
2581         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2582         (TEST):
2583         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2584         (TestWebKitAPI::TEST):
2585
2586 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
2587
2588         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
2589         https://bugs.webkit.org/show_bug.cgi?id=200394
2590         <rdar://problem/52914964>
2591
2592         Reviewed by Chris Fleizach.
2593
2594         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
2595
2596         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2597         (WTR::AccessibilityUIElement::isInTableCell const):
2598         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2599         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2600         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2601         (WTR::AccessibilityUIElement::isInTableCell const):
2602
2603 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
2604
2605         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
2606         https://bugs.webkit.org/show_bug.cgi?id=200397
2607
2608         Reviewed by Jonathan Bedard.
2609
2610         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2611
2612 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2613
2614         [macOS 10.15] Image dragged from Safari does not appear in Notes
2615         https://bugs.webkit.org/show_bug.cgi?id=188490
2616         <rdar://problem/39462717>
2617
2618         Reviewed by Andy Estes.
2619
2620         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
2621
2622         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2623
2624 2019-08-02  Alex Christensen  <achristensen@webkit.org>
2625
2626         Fix API test after r248139
2627         https://bugs.webkit.org/show_bug.cgi?id=200102
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
2630         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2631         This was supposed to be removed as part of reverting r245322.
2632
2633 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2634
2635         results.webkit.org: Force update cache when timeline updated
2636         https://bugs.webkit.org/show_bug.cgi?id=200363
2637
2638         Reviewed by Jonathan Bedard.
2639
2640         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2641         (offscreenCachedRenderFactory): Add ability to force the redraw.
2642         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
2643         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
2644
2645 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2646
2647         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
2648         https://bugs.webkit.org/show_bug.cgi?id=200360
2649
2650         Reviewed by Tim Horton.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2653         (cleanupITPDatabase):
2654         (TEST):
2655
2656 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2657
2658         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
2659         https://bugs.webkit.org/show_bug.cgi?id=200102
2660         <rdar://problem/53275114>
2661
2662         Reviewed by Darin Adler.
2663
2664         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
2665         and because clicking on a TestWKWebView only works on Mac.
2666
2667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2668         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
2669         (-[UploadDelegate initWithDirectory:]):
2670         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2671         (-[UploadDelegate sentDirectory]):
2672         (TEST):
2673         * TestWebKitAPI/cocoa/TestWKWebView.h:
2674         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2675         (-[TestWKWebView sendClickAtPoint:]):
2676
2677 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2678
2679         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
2680         https://bugs.webkit.org/show_bug.cgi?id=200321
2681
2682         Reviewed by Jonathan Bedard.
2683
2684         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2685         Let the axis' height be defined in the option. Timeine component will use this value as
2686         padding-top for headers which allows headers start in the right position, even with multiple
2687         top axises.
2688         (Timeline.CanvasSeriesComponent):
2689         (prototype.Timeline.CanvasContainer):
2690
2691 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2692
2693         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
2694         https://bugs.webkit.org/show_bug.cgi?id=200347
2695
2696         Reviewed by Jonathan Bedard.
2697
2698         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2699         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
2700
2701 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
2702
2703         Improve flakiness of SOAuthorizationRedirect tests
2704         https://bugs.webkit.org/show_bug.cgi?id=200320
2705         <rdar://problem/53767057>
2706
2707         Reviewed by Alex Christensen.
2708
2709         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
2710         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
2711         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
2712         is executed.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2715         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2716         (resetState):
2717         (TestWebKitAPI::TEST):
2718
2719 2019-08-01  Keith Rollin  <krollin@apple.com>
2720
2721         Update TestWebKitAPI for XCBuild
2722         https://bugs.webkit.org/show_bug.cgi?id=200311
2723         <rdar://problem/53773804>
2724
2725         Reviewed by Alex Christensen.
2726
2727         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
2728         technique. Now update WebKitLegacy to build under XCBuild after those
2729         changes. This work involves adding an "Apply Configuration to
2730         XCFileLists" build target, adding a check-xcfilelists.sh script,
2731         adding a "Check xcfilelists" build phase that calls that script,
2732         adding knowledge of the project to the generate-xcfilelists script,
2733         creating new .xcfilelist files, and adding those to the project.
2734
2735         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
2736         (Application.__init__):
2737         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2738         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
2739         (TestWebKitAPIGenerator):
2740         (TestWebKitAPIGenerator._get_project_file_path):
2741         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
2742         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
2743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2744         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
2745
2746 2019-08-01  Youenn Fablet  <youenn@apple.com>
2747
2748         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
2749         https://bugs.webkit.org/show_bug.cgi?id=200317
2750
2751         Reviewed by Eric Carlson.
2752
2753         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2756         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
2757         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2758         (TestWebKitAPI::TEST):
2759
2760 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
2761
2762         New EWS: Cannot see build status page when patch is waiting for tester
2763         https://bugs.webkit.org/show_bug.cgi?id=200333
2764
2765         Reviewed by Jonathan Bedard.
2766
2767         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2768         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
2769
2770 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2771
2772         [SOUP] Switch to use libsoup WebSockets API
2773         https://bugs.webkit.org/show_bug.cgi?id=200162
2774
2775         Reviewed by Michael Catanzaro.
2776
2777         Update libsoup version to 2.67.90.
2778
2779         * gtk/jhbuild.modules:
2780         * wpe/jhbuild.modules:
2781
2782 2019-07-31  Andy Estes  <aestes@apple.com>
2783
2784         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
2785         https://bugs.webkit.org/show_bug.cgi?id=200293
2786         <rdar://problem/52937749>
2787
2788         Reviewed by Alex Christensen.
2789
2790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2791         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
2792         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2793         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2794         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
2795         (TEST):
2796
2797 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
2798
2799         [ews-build] Enable all macOS queues on new EWS
2800         https://bugs.webkit.org/show_bug.cgi?id=199944
2801
2802         Reviewed by Jonathan Bedard.
2803
2804         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
2805         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2806         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
2807         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
2809         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
2810
2811 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
2812
2813         Unreviewed test gardening, disable failing test for rdar://51752593.
2814
2815         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2816
2817 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
2818
2819         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
2820         https://bugs.webkit.org/show_bug.cgi?id=200318
2821
2822         Reviewed by Aakash Jain.
2823
2824         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2825         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
2826         (Timeline.CanvasXAxisComponent): Use getLabel function.
2827
2828 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
2829
2830         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
2831         https://bugs.webkit.org/show_bug.cgi?id=200306
2832
2833         Reviewed by Michael Catanzaro.
2834
2835         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
2836         jsc-glib-4.0-scan for example).
2837
2838         * Scripts/webkitdirs.pm:
2839         (generateBuildSystemFromCMakeProject):
2840
2841 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
2842
2843         Unreviewed test gardening, disable failing test for rdar://52355829.
2844
2845         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2846         (TEST):
2847
2848 2019-07-31  Keith Rollin  <krollin@apple.com>
2849
2850         Update WebKitLegacy for XCBuild
2851         https://bugs.webkit.org/show_bug.cgi?id=200310
2852         <rdar://problem/53773708>
2853
2854         Reviewed by Alex Christensen.
2855
2856         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
2857         technique. Now update WebKitLegacy to build under XCBuild after those
2858         changes. This work involves adding an "Apply Configuration to
2859         XCFileLists" build target, adding a check-xcfilelists.sh script,
2860         adding a "Check xcfilelists" build phase that calls that script,
2861         adding knowledge of the project to the generate-xcfilelists script,
2862         creating new .xcfilelist files, and adding those to the project.
2863
2864         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
2865         (Application.__init__):
2866         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2867         (JavaScriptCoreGenerator):
2868         (WebCoreGenerator):
2869         (WebKitGenerator):
2870         (WebKitGenerator._get_generate_unified_sources_script):
2871         (WebKitLegacyGenerator):
2872         (WebKitLegacyGenerator._get_project_file_path):
2873         (WebKitLegacyGenerator._get_generate_unified_sources_script):
2874
2875 2019-07-31  Chris Dumez  <cdumez@apple.com>
2876
2877         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
2878         https://bugs.webkit.org/show_bug.cgi?id=200086
2879         <rdar://problem/53501721>
2880
2881         Reviewed by Alex Christensen.
2882
2883         re-enable the API test.
2884
2885         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2886         (TEST):
2887
2888 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2889
2890         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
2891         https://bugs.webkit.org/show_bug.cgi?id=200291
2892         <rdar://problem/53717946>
2893
2894         Reviewed by Megan Gardner.
2895
2896         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
2897         after closing the web view, while the web view's content view isn't the first responder.
2898
2899         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
2900         * TestWebKitAPI/ios/UIKitSPI.h:
2901
2902 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2903
2904         [GTK] Datalist element support for TextFieldInputType
2905         https://bugs.webkit.org/show_bug.cgi?id=98934
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
2910
2911         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
2912         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
2913         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
2914
2915 2019-07-30  Tim Horton  <timothy_horton@apple.com>
2916
2917         Remove some needless comments that snuck into the tree
2918
2919         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2920         (WTR::UIScriptController::setHardwareKeyboardAttached):
2921         (WTR::UIScriptController::playBackEventStream):
2922
2923 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2924
2925         [WebKit] Add PageLoadState::Observer C API
2926         https://bugs.webkit.org/show_bug.cgi?id=199848
2927
2928         Reviewed by Alex Christensen.
2929
2930         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2931         (WebKitBrowserWindow::WebKitBrowserWindow):
2932         (WebKitBrowserWindow::didChangeTitle):
2933         (WebKitBrowserWindow::didFinishNavigation): Deleted.
2934         * MiniBrowser/win/WebKitBrowserWindow.h:
2935         * TestWebKitAPI/CMakeLists.txt:
2936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2937         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
2938         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
2939         (TestWebKitAPI::didChangeActiveURL):
2940         (TestWebKitAPI::didChangeCanGoBack):
2941         (TestWebKitAPI::didChangeCanGoForward):
2942         (TestWebKitAPI::didChangeCertificateInfo):
2943         (TestWebKitAPI::didChangeEstimatedProgress):
2944         (TestWebKitAPI::didChangeHasOnlySecureContent):
2945         (TestWebKitAPI::didChangeIsLoading):
2946         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
2947         (TestWebKitAPI::didChangeTitle):
2948         (TestWebKitAPI::didChangeWebProcessIsResponsive):
2949         (TestWebKitAPI::didSwapWebProcesses):
2950         (TestWebKitAPI::willChangeActiveURL):
2951         (TestWebKitAPI::willChangeCanGoBack):
2952         (TestWebKitAPI::willChangeCanGoForward):
2953         (TestWebKitAPI::willChangeCertificateInfo):
2954         (TestWebKitAPI::willChangeEstimatedProgress):
2955         (TestWebKitAPI::willChangeHasOnlySecureContent):
2956         (TestWebKitAPI::willChangeIsLoading):
2957         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
2958         (TestWebKitAPI::willChangeTitle):
2959         (TestWebKitAPI::willChangeWebProcessIsResponsive):
2960         (TestWebKitAPI::didFinishNavigation):
2961         (TestWebKitAPI::TEST):
2962
2963 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
2964
2965         DumpRenderTree.app: Add CFBundleShortVersionString
2966         https://bugs.webkit.org/show_bug.cgi?id=200269
2967         <rdar://problem/53412596>
2968
2969         Rubber-stamped by Aakash Jain.
2970
2971         * DumpRenderTree/ios/Info.plist:
2972
2973 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2974
2975         Add layout test coverage for <https://webkit.org/b/200215>
2976         https://bugs.webkit.org/show_bug.cgi?id=200245
2977         <rdar://problem/52976965>
2978
2979         Reviewed by Tim Horton.
2980
2981         Add new testing infrastructure. See below for more details.
2982
2983         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2984         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2985         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2986         (WTR::UIScriptController::setWillCreateNewPageCallback):
2987         (WTR::UIScriptController::willCreateNewPageCallback const):
2988
2989         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
2990         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
2991
2992         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2993         (WTR::UIScriptController::becomeFirstResponder):
2994
2995         Add and implement a Cocoa platform hook to make the web view first responder.
2996
2997         * WebKitTestRunner/TestController.cpp:
2998         (WTR::TestController::createOtherPage):
2999         * WebKitTestRunner/TestInvocation.cpp:
3000         (WTR::TestInvocation::willCreateNewPage):
3001         * WebKitTestRunner/TestInvocation.h:
3002         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3003         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3004         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
3005
3006 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3007
3008         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
3009         https://bugs.webkit.org/show_bug.cgi?id=200217
3010
3011         Reviewed by Alex Christensen.
3012
3013         * MiniBrowser/win/BrowserWindow.h:
3014         * MiniBrowser/win/MainWindow.cpp:
3015         (MainWindow::init):
3016         (MainWindow::resizeSubViews):
3017         (MainWindow::WndProc):
3018         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
3019         * MiniBrowser/win/MiniBrowserLib.rc:
3020         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
3021         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3022         (WebKitBrowserWindow::reload):
3023         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
3024         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3025         (WebKitLegacyBrowserWindow::reload):
3026         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3027
3028 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3029
3030         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
3031         https://bugs.webkit.org/show_bug.cgi?id=200218
3032
3033         Reviewed by Alex Christensen.
3034
3035         Moved the scheme supplementing logic from
3036         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
3037
3038         * MiniBrowser/win/MainWindow.cpp:
3039         (MainWindow::loadURL):
3040         (MainWindow::onURLBarEnter):
3041         * MiniBrowser/win/MainWindow.h:
3042         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3043         (WebKitLegacyBrowserWindow::loadURL):
3044
3045 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
3046
3047         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
3048         https://bugs.webkit.org/show_bug.cgi?id=200254
3049
3050         Unreviewed infrastructure fix.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
3053
3054 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
3055
3056         [Canvas Timeline] Compact canvas timeline
3057         https://bugs.webkit.org/show_bug.cgi?id=200177
3058
3059         Reviewed by Jonathan Bedard.
3060
3061         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
3062         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3063         (Timeline.CanvasSeriesComponent):
3064
3065 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3066
3067         Multiple context menu actions broken for YouTube videos
3068         https://bugs.webkit.org/show_bug.cgi?id=199999
3069
3070         Reviewed by Eric Carlson.
3071
3072         Add a test case to check copy link address, open in new window and download options are not included in the
3073         context menu for non-downloadable media.
3074
3075         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3076         (writeNextChunk):
3077         (serverCallback):
3078         (testContextMenuLiveStream):
3079         (beforeAll):
3080         (afterAll):
3081
3082 2019-07-28  Tim Horton  <timothy_horton@apple.com>
3083
3084         Reorganize UIScriptController into platform-specific subclasses
3085         https://bugs.webkit.org/show_bug.cgi?id=200027
3086
3087         Reviewed by Simon Fraser.
3088
3089         Instead of a mishmash of #ifdefs and extraneous empty functions,
3090         reorganize UIScriptController so that we have a base class
3091         with functions that assert if called (to make it harder to
3092         accidentally write a test that depends on unimplemented
3093         functionality), and override them in platform specific subclasses
3094         as functionality is added.
3095
3096         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3097         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
3098         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3099         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
3100         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3101         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3103         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3104         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
3105         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
3106         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3107         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
3108         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
3109         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3110         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
3111         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3112
3113 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3114
3115         [Win][MiniBrowser] Remove PageLoadTestClient
3116         https://bugs.webkit.org/show_bug.cgi?id=200155
3117
3118         Reviewed by Brent Fulgham.
3119
3120         It is not used nowadays.
3121
3122         * MiniBrowser/win/CMakeLists.txt:
3123         * MiniBrowser/win/Common.cpp:
3124         (parseCommandLine):
3125         * MiniBrowser/win/Common.h:
3126         * MiniBrowser/win/MainWindow.cpp:
3127         (MainWindow::init):
3128         * MiniBrowser/win/MainWindow.h:
3129         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3130         (MiniBrowserWebHost::updateAddressBar):
3131         (MiniBrowserWebHost::didFinishLoadForFrame):
3132         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
3133         (MiniBrowserWebHost::didFailLoadWithError):
3134         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
3135         (MiniBrowserWebHost::didFirstLayoutInFrame):
3136         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
3137         * MiniBrowser/win/PageLoadTestClient.h: Removed.
3138         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3139         (ResourceLoadDelegate::identifierForInitialRequest):
3140         (ResourceLoadDelegate::willSendRequest):
3141         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3142         (ResourceLoadDelegate::didFailLoadingWithError):
3143         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3144         (WebKitBrowserWindow::create):
3145         (WebKitBrowserWindow::createNewPage):
3146         * MiniBrowser/win/WebKitBrowserWindow.h:
3147         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3148         (WebKitLegacyBrowserWindow::create):
3149         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
3150         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
3151         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3152         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
3153         * MiniBrowser/win/WinMain.cpp:
3154         (wWinMain):
3155
3156 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
3157
3158         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
3159         https://bugs.webkit.org/show_bug.cgi?id=200150
3160         <rdar://problem/53280170>
3161
3162         Reviewed by Brent Fulgham.
3163
3164         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3165         (TestWebKitAPI::TEST):
3166
3167 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3168
3169         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
3170         https://bugs.webkit.org/show_bug.cgi?id=200090
3171
3172         Unreviewed follow-up fix.
3173
3174         * resultsdbpy/resultsdbpy/view/view_routes.py:
3175         (ViewRoutes.__init__): Keep /search endpoint for existing links
3176
3177 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3178
3179         results.webkit.org: Add switch to filter results by expectation
3180         https://bugs.webkit.org/show_bug.cgi?id=200134
3181
3182         Rubber-stamped by Aakash Jain.
3183
3184         Users of the results database should be able to easily differentiate tests which are expected
3185         to fail verse tests which are unexpectedly failing.
3186
3187         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3188         (Timeline.render): Respect the willFilterExpected variable.
3189         (LegendLabel): Generates html for label in the legend.
3190         (Legend): Add switch for filter results.
3191         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
3192         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3193
3194 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
3195
3196         [ews-build] Use update-webkit script in Style EWS
3197         https://bugs.webkit.org/show_bug.cgi?id=193196
3198
3199         Reviewed by Jonathan Bedard.
3200
3201         * BuildSlaveSupport/ews-build/factories.py:
3202         (StyleFactory): Updated to use CheckOutSource step as well.
3203         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
3204         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3205
3206 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3207
3208         results.webkit.org: Support buildbot 0.8 CI links
3209         https://bugs.webkit.org/show_bug.cgi?id=200146
3210
3211         Reviewed by Aakash Jain.
3212
3213         * resultsdbpy/resultsdbpy/model/ci_context.py:
3214         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
3215         (BuildbotEightURLFactory.__init__):
3216         (BuildbotEightURLFactory.url):
3217         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
3218         (URLFactoryTest.test_old_builder_url):
3219         (URLFactoryTest):
3220         (URLFactoryTest.test_old_worker_url):
3221
3222 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3223
3224         results.webkit.org: Suite results shouldn't be the landing page
3225         https://bugs.webkit.org/show_bug.cgi?id=200090
3226
3227         Reviewed by Aakash Jain.
3228
3229         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
3230         * resultsdbpy/resultsdbpy/view/view_routes.py:
3231         (ViewRoutes.__init__): Make search the landing page instead of suite results.
3232         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
3233         (WebSiteUnittest.test_main):
3234
3235 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3236
3237         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
3238         https://bugs.webkit.org/show_bug.cgi?id=200127
3239
3240         Unreviewed follow-up fix.
3241
3242         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3243         (Dot.toString): Use self instead of this in render callback.
3244
3245 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
3246
3247         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
3248         https://bugs.webkit.org/show_bug.cgi?id=200108
3249         <rdar://problem/53521238>
3250
3251         Reviewed by Chris Dumez.
3252
3253         Added an API test.
3254
3255         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3256         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3257         (TEST):
3258
3259 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
3260
3261         results.webkit.org: Color should be the worst result, count should include all results
3262         https://bugs.webkit.org/show_bug.cgi?id=200127
3263
3264         Rubber-stamped by Aakash Jain.
3265
3266         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3267         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
3268
3269 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
3270
3271         [Timeline]: Make timeline header width automatic, instead of fixed width
3272         https://bugs.webkit.org/show_bug.cgi?id=200059
3273
3274         Reviewed by Jonathan Bedard.
3275
3276         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3277         (.dot.crash):
3278         (.timeline>.header): Deleted.
3279         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3280         (.timeline>.content):
3281         (.timeline>.header):
3282
3283 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
3284
3285         [ESNext] Implement nullish coalescing
3286         https://bugs.webkit.org/show_bug.cgi?id=200072
3287
3288         Reviewed by Darin Adler.
3289
3290         * Scripts/run-jsc-stress-tests:
3291
3292 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3293
3294         Add Takashi Komori and Tomoki Imai as contributors
3295
3296         Unreviewed.
3297
3298         * Scripts/webkitpy/common/config/contributors.json:
3299
3300 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
3301
3302         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
3303         https://bugs.webkit.org/show_bug.cgi?id=200103
3304
3305         Reviewed by Mark Lam.
3306
3307         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
3308         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
3309
3310         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
3311         to the future implementation changes while it catches the severe issues we had.
3312
3313         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3314         (assertEmptyPointerSet):
3315         (assertHasOnlyObjects):
3316         (assertClean):
3317         (TEST):
3318         (allocateAndDeallocate):
3319
3320 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
3321
3322         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
3323         https://bugs.webkit.org/show_bug.cgi?id=200074
3324
3325         Reviewed by Michael Catanzaro.
3326
3327         There was a latent issue. PluginTest::indicateTestFailure was
3328         using WTF::sleep without linking WTF.
3329
3330         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3331         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
3332
3333 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
3334
3335         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
3336         https://bugs.webkit.org/show_bug.cgi?id=200073
3337
3338         Reviewed by Michael Catanzaro.
3339
3340         * TestWebKitAPI/PlatformGTK.cmake:
3341         * TestWebKitAPI/PlatformWPE.cmake:
3342         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
3343
3344 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3345
3346         [webkitperl] runCommand doesn't work in Windows Perl
3347         https://bugs.webkit.org/show_bug.cgi?id=199900
3348
3349         Reviewed by Don Olmstead.
3350
3351         runCommand was always failing implicit fork by using 'open' with
3352         '-|' in Windows Perl. Explicitly specify the command to 'open' not
3353         to do the implicit fork.
3354
3355         There is one more difference between Windows and Unix. 'open'
3356         successes on Windows even for non existent command while it fails
3357         on Unix. So, return the same error code on Unix as well as
3358         Windows.
3359
3360         * Scripts/VCSUtils.pm: Specified the command to 'open'.
3361         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
3362         command is not available on Windows. Use Perl ($^X) instead.
3363
3364 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
3365
3366         Allow Clients to Add Fields to the AutoFillContext Dictionary.
3367         https://bugs.webkit.org/show_bug.cgi?id=199326
3368         rdar://problem/42816957
3369
3370         Reviewed by Wenson Hsieh.
3371
3372         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3373         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
3374         is being properly populated with additional context dictionary.
3375
3376         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3377         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3378         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
3379         which will populate the additional autofill context dictionary.
3380
3381         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
3382         populates the additional autofill context dictionary.
3383
3384         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
3385         context dictionary.
3386
3387         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
3388         input field requires strong password work.
3389
3390         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
3391         input field requires strong password work.
3392
3393         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
3394         password work.
3395
3396 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
3397
3398         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
3399         https://bugs.webkit.org/show_bug.cgi?id=199489
3400
3401         Reviewed by Aakash Jain.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3404         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
3405         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
3406         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3407         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
3408         (runTest): Record test binary failure
3409         (reportTestFailures): Report test binary failure
3410         (runJSCStressTests):
3411         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
3412         (JscOnlyPort.build_jsc_command):
3413         (JscOnlyPort):
3414         (JscOnlyPort.run_javascriptcore_tests_command):
3415         * Scripts/webkitpy/common/config/ports_unittest.py:
3416         (DeprecatedPortTest.test_jsconly_port):
3417
3418 2019-07-24  Zalan Bujtas  <zalan@apple.com>
3419
3420         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
3421         https://bugs.webkit.org/show_bug.cgi?id=200079
3422         <rdar://problem/53474325>
3423
3424         Reviewed by Wenson Hsieh.
3425
3426         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
3427
3428         * WebKitTestRunner/ios/TestControllerIOS.mm:
3429         (WTR::TestController::platformResetPreferencesToConsistentValues):
3430
3431 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
3432
3433         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
3434         https://bugs.webkit.org/show_bug.cgi?id=199927
3435
3436         Reviewed by Alex Christensen.
3437
3438         convertAbsolutepathToWebKitPath was failing to convert paths on
3439         Windows Perl due to path separators mismatch.
3440
3441         Renamed convertAbsolutepathToWebKitPath to
3442         convertAbsolutePathToRelativeUnixPath, and changed it to replace
3443         paths to relative Unix paths.
3444
3445         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3446         (convertAbsolutePathToRelativeUnixPath): Added.
3447         (convertAbsolutepathToWebKitPath): Deleted.
3448
3449 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3450
3451         Fix iOS API test after r247759
3452         https://bugs.webkit.org/show_bug.cgi?id=200045
3453
3454         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3455         (TEST):
3456         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
3457         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
3458
3459 2019-07-23  Keith Rollin  <krollin@apple.com>
3460
3461         Remove rest of NavigatorContentUtils support
3462         https://bugs.webkit.org/show_bug.cgi?id=200052
3463         <rdar://problem/53467357>
3464
3465         Reviewed by Alex Christensen.
3466
3467         Bug 196070 removes most of the support for the never-used
3468         NavigatorContentUtils facility. However, there were still a couple of
3469         left-over references after that change. This patch sweeps those up.
3470
3471         * Scripts/webkitperl/FeatureList.pm:
3472
3473 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3474
3475         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3476         https://bugs.webkit.org/show_bug.cgi?id=200045
3477
3478         Reviewed by Mark Lam.
3479
3480         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3481         (TEST):
3482
3483 2019-07-23  Russell Epstein  <repstein@apple.com>
3484
3485         Unreviewed, rolling out r247745.
3486
3487         This broke API test
3488         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
3489         indicated by EWS
3490
3491         Reverted changeset:
3492
3493         "Move javaScriptConfigurationDirectory SPI from
3494         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
3495         runtime switchable"
3496         https://bugs.webkit.org/show_bug.cgi?id=200045
3497         https://trac.webkit.org/changeset/247745
3498
3499 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3500
3501         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3502         https://bugs.webkit.org/show_bug.cgi?id=200045
3503
3504         Reviewed by Mark Lam.
3505
3506         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3507         (TEST):
3508
3509 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3510
3511         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
3512         https://bugs.webkit.org/show_bug.cgi?id=199972
3513
3514         Reviewed by Jer Noble.
3515
3516         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3517         (TEST):
3518
3519 2019-07-23  Alicia Boya García  <aboya@igalia.com>
3520
3521         [WTF] Add DataMutex and MainThreadData wrappers
3522         https://bugs.webkit.org/show_bug.cgi?id=199831
3523
3524         Reviewed by Alex Christensen.
3525
3526         Added a very simple test that checks that DataMutex<T> indeed takes
3527         the lock and indeed holds data.
3528
3529         * TestWebKitAPI/CMakeLists.txt:
3530         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
3531         (TestWebKitAPI::TEST):
3532
3533 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3534
3535         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
3536         https://bugs.webkit.org/show_bug.cgi?id=200021
3537         <rdar://problem/53301325>
3538
3539         Reviewed by Ryosuke Niwa.
3540
3541         Add support for grabbing the child menu items of a context menu item.
3542
3543         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3544         (WTR::getMenuItemChildrenCallback):
3545
3546 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
3547
3548         WebKit should strip away system font names from the pasted content
3549         https://bugs.webkit.org/show_bug.cgi?id=199975
3550         <rdar://problem/53336353>
3551
3552         Reviewed by Darin Adler.
3553
3554         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
3555
3556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3557         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3558         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
3559
3560 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3561
3562         [ews-build] EWS fails to parse multi-line full_results.json
3563         https://bugs.webkit.org/show_bug.cgi?id=199992
3564
3565         Reviewed by Alexey Proskuryakov.
3566
3567         * BuildSlaveSupport/ews-build/layout_test_failures.py:
3568         (LayoutTestFailures.results_from_string): Concatenate content into single line.
3569         * BuildSlaveSupport/ews-build/steps_unittest.py:
3570         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
3571
3572 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3573
3574         resultsdbpy: Handle case where the previous commit doesn't have the changelog
3575         https://bugs.webkit.org/show_bug.cgi?id=200015
3576
3577         Reviewed by Aakash Jain.
3578
3579         * resultsdbpy/resultsdbpy/model/repository.py:
3580         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
3581
3582 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3583
3584         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
3585         https://bugs.webkit.org/show_bug.cgi?id=200013
3586         <rdar://problem/52526901>
3587
3588         Reviewed by Simon Fraser.
3589
3590         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
3591
3592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3593         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
3594         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
3595         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
3596         * TestWebKitAPI/ios/UIKitSPI.h:
3597
3598 2019-07-22  Jer Noble  <jer.noble@apple.com>
3599
3600         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
3601         https://bugs.webkit.org/show_bug.cgi?id=199971
3602         <rdar://problem/51951218>
3603
3604         Reviewed by Alex Christensen.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
3608         (TestWebKitAPI::TEST):
3609
3610 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3611
3612         [ews-build] Add an EWS to run services tests
3613         https://bugs.webkit.org/show_bug.cgi?id=199994
3614
3615         Reviewed by Jonathan Bedard.
3616
3617         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
3618         * BuildSlaveSupport/ews-build/factories.py: Added Servi