43f8a4e900b2b7edee5e42d99a8cbb9fa21ededc
[WebKit-https.git] / Tools / ChangeLog
1 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
4
5         * Scripts/run-javascriptcore-tests:
6         (runJSCStressTests): Remove wsl-tests.yaml.
7
8 2018-10-15  Christopher Reid  <chris.reid@sony.com>
9
10         [Curl][WinCairo] Add Public Suffix support to WinCairo
11         https://bugs.webkit.org/show_bug.cgi?id=183060
12
13         Reviewed by Alex Christensen.
14
15         Share mac's PublicSuffix tests with all ports.
16
17         * TestWebKitAPI/PlatformWin.cmake:
18         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
20         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
21
22 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
23
24         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
25         https://bugs.webkit.org/show_bug.cgi?id=190555
26
27         Unreviewed.
28
29         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
30
31         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
32         * WebGPUShadingLanguageRI/All.js: Removed.
33         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
34         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
35         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
36         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
37         * WebGPUShadingLanguageRI/Assignment.js: Removed.
38         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
39         * WebGPUShadingLanguageRI/Block.js: Removed.
40         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
41         * WebGPUShadingLanguageRI/Break.js: Removed.
42         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
43         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
44         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
45         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
46         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
47         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
48         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
49         * WebGPUShadingLanguageRI/Casts.js: Removed.
50         * WebGPUShadingLanguageRI/Check.js: Removed.
51         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
52         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
53         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
54         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
55         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
56         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
57         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
58         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
59         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
60         * WebGPUShadingLanguageRI/Checker.js: Removed.
61         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
62         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
63         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
64         * WebGPUShadingLanguageRI/Continue.js: Removed.
65         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
66         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
67         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
68         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
69         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
70         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
71         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
72         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
73         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
74         * WebGPUShadingLanguageRI/EPtr.js: Removed.
75         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
76         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
77         * WebGPUShadingLanguageRI/EnumType.js: Removed.
78         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
79         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
80         * WebGPUShadingLanguageRI/Expression.js: Removed.
81         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
82         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
83         * WebGPUShadingLanguageRI/Field.js: Removed.
84         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
85         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
86         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
87         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
88         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
89         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
90         * WebGPUShadingLanguageRI/Func.js: Removed.
91         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
92         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
93         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
94         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
95         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
96         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
97         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
98         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
99         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
100         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
101         * WebGPUShadingLanguageRI/Inline.js: Removed.
102         * WebGPUShadingLanguageRI/Inliner.js: Removed.
103         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
104         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
105         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
106         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
107         * WebGPUShadingLanguageRI/Lexer.js: Removed.
108         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
109         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
110         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
111         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
112         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
113         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
114         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
115         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
116         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
117         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
118         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
119         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
120         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
121         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
122         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
123         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
124         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
125         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
126         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
127         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
128         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
129         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
130         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
131         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
132         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
133         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
134         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
135         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
136         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
137         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
138         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
139         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
140         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
141         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
142         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
143         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
144         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
145         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
146         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
147         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
148         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
149         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
150         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
151         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
152         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
153         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
154         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
155         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
156         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
157         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
158         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
159         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
160         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
161         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
162         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
163         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
164         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
165         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
166         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
167         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
168         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
169         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
170         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
171         * WebGPUShadingLanguageRI/NameContext.js: Removed.
172         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
173         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
174         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
175         * WebGPUShadingLanguageRI/NativeType.js: Removed.
176         * WebGPUShadingLanguageRI/Node.js: Removed.
177         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
178         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
179         * WebGPUShadingLanguageRI/NullType.js: Removed.
180         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
181         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
182         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
183         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
184         * WebGPUShadingLanguageRI/Parse.js: Removed.
185         * WebGPUShadingLanguageRI/Prepare.js: Removed.
186         * WebGPUShadingLanguageRI/Program.js: Removed.
187         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
188         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
189         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
190         * WebGPUShadingLanguageRI/PtrType.js: Removed.
191         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
192         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
193         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
194         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
195         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
196         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
197         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
198         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
199         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
200         * WebGPUShadingLanguageRI/Return.js: Removed.
201         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
202         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
203         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
204         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
205         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
206         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
207         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
208         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
209         * WebGPUShadingLanguageRI/Sampler.js: Removed.
210         * WebGPUShadingLanguageRI/Semantic.js: Removed.
211         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
212         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
213         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
214         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
215         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
216         * WebGPUShadingLanguageRI/StructType.js: Removed.
217         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
218         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
219         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
220         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
221         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
222         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
223         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
224         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
225         * WebGPUShadingLanguageRI/Test.html: Removed.
226         * WebGPUShadingLanguageRI/Test.js: Removed.
227         * WebGPUShadingLanguageRI/Texture.js: Removed.
228         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
229         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
230         * WebGPUShadingLanguageRI/Type.js: Removed.
231         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
232         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
233         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
234         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
235         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
236         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
237         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
238         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
239         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
240         * WebGPUShadingLanguageRI/Value.js: Removed.
241         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
242         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
243         * WebGPUShadingLanguageRI/VectorType.js: Removed.
244         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
245         * WebGPUShadingLanguageRI/Visitor.js: Removed.
246         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
247         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
248         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
249         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
250         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
251         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
252         * WebGPUShadingLanguageRI/index.html: Removed.
253         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
254         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
255
256 2018-10-15  Philippe Normand  <pnormand@igalia.com>
257
258         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
259         https://bugs.webkit.org/show_bug.cgi?id=190581
260
261         Reviewed by Michael Catanzaro.
262
263         These bots don't use JHBuild and their host GStreamer version is
264         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
265
266         * BuildSlaveSupport/build.webkit.org-config/config.json:
267
268 2018-10-15  Alex Christensen  <achristensen@webkit.org>
269
270         Use pragma once in WTF
271         https://bugs.webkit.org/show_bug.cgi?id=190527
272
273         Reviewed by Chris Dumez.
274
275         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
276
277         * DumpRenderTree/TestRunner.cpp:
278         (TestRunner::queueLoadHTMLString):
279         (TestRunner::queueLoadAlternateHTMLString):
280         (TestRunner::queueBackNavigation):
281         (TestRunner::queueForwardNavigation):
282         (TestRunner::queueLoadingScript):
283         (TestRunner::queueNonLoadingScript):
284         (TestRunner::queueReload):
285         * DumpRenderTree/WorkQueue.cpp:
286         (WorkQueue::singleton): Deleted.
287         (WorkQueue::WorkQueue): Deleted.
288         (WorkQueue::queue): Deleted.
289         (WorkQueue::dequeue): Deleted.
290         (WorkQueue::count): Deleted.
291         (WorkQueue::clear): Deleted.
292         (WorkQueue::processWork): Deleted.
293         * DumpRenderTree/WorkQueue.h:
294         (WorkQueue::setFrozen): Deleted.
295         * DumpRenderTree/WorkQueueItem.h:
296         * DumpRenderTree/mac/DumpRenderTree.mm:
297         (runTest):
298         * DumpRenderTree/mac/FrameLoadDelegate.mm:
299         (-[FrameLoadDelegate processWork:]):
300         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
301         * DumpRenderTree/mac/TestRunnerMac.mm:
302         (TestRunner::notifyDone):
303         (TestRunner::forceImmediateCompletion):
304         (TestRunner::queueLoad):
305         * DumpRenderTree/win/DumpRenderTree.cpp:
306         (runTest):
307         * DumpRenderTree/win/FrameLoadDelegate.cpp:
308         (FrameLoadDelegate::processWork):
309         (FrameLoadDelegate::locationChangeDone):
310         * DumpRenderTree/win/TestRunnerWin.cpp:
311         (TestRunner::notifyDone):
312         (TestRunner::forceImmediateCompletion):
313         (TestRunner::queueLoad):
314
315 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
316
317         [JSC] Remove Option::useAsyncIterator
318         https://bugs.webkit.org/show_bug.cgi?id=190567
319
320         Reviewed by Saam Barati.
321
322         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
323
324 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
325
326         [WPE] Silence a unused-parameter warning
327
328         Unreviewed.
329         * MiniBrowser/wpe/main.cpp:
330         (decidePermissionRequest):
331
332 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
333
334         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
335         https://bugs.webkit.org/show_bug.cgi?id=190537
336
337         Reviewed by Alexey Proskuryakov.
338
339         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
340         needs to be split before adding it to the command since it is treated
341         as a list of args.
342
343         * Scripts/webkitpy/common/config/ports.py:
344         (DeprecatedPort.run_javascriptcore_tests_command):
345
346 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
347
348         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
349         https://bugs.webkit.org/show_bug.cgi?id=190504
350         <rdar://problem/45117760>
351
352         Reviewed by Tim Horton.
353
354         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
355         macOS and iOS.
356
357         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
358         (WTR::UIScriptController::setViewScale):
359         * DumpRenderTree/mac/UIScriptControllerMac.mm:
360         (WTR::UIScriptController::setViewScale):
361         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
362         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
363         (WTR::UIScriptController::setViewScale):
364         * TestRunnerShared/UIScriptContext/UIScriptController.h:
365         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
366
367         Add a new file for UIScriptController methods on Cocoa platforms.
368
369         (WTR::UIScriptController::setViewScale):
370         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
371         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
372         (WTR::TestController::cocoaResetStateToConsistentValues):
373
374         Ensure that _viewScale is reset to 1 after running a layout test.
375
376 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
377
378         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
379         https://bugs.webkit.org/show_bug.cgi?id=190536
380
381         Reviewed by Alexey Proskuryakov.
382
383         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
384
385 2018-10-11  Youenn Fablet  <youenn@apple.com>
386
387         IOS 12 - Service worker cache not shared when added to homescreen
388         https://bugs.webkit.org/show_bug.cgi?id=190269
389         <rdar://problem/45009961>
390
391         Reviewed by Alex Christensen.
392
393         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
394         Add test to ensure that CacheStorage use the default website data store parameters.
395
396 2018-10-11  Tim Horton  <timothy_horton@apple.com>
397
398         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
399         https://bugs.webkit.org/show_bug.cgi?id=190476
400         <rdar://problem/32757191>
401
402         Reviewed by Megan Gardner.
403
404         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
405         (TEST):
406         Add a test that we don't crash.
407
408 2018-10-11  Tim Horton  <timothy_horton@apple.com>
409
410         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
411
412         * Scripts/webkitpy/tool/steps/options.py:
413         (Options):
414         Fix the name of the variable that the --cc-radar option writes into.
415
416 2018-10-10  Dean Jackson  <dino@apple.com>
417
418         Add --cc-radar option to webkit-patch bug creation
419         https://bugs.webkit.org/show_bug.cgi?id=190451
420         <rdar://problem/45176671>
421
422         Reviewed by Antoine Quint.
423
424         Add a new command line option to automatically
425         CC radar to new or updated bugs.
426
427         * Scripts/webkitpy/tool/commands/commandtest.py:
428         (CommandsTest.assert_execute_outputs):
429         * Scripts/webkitpy/tool/commands/upload.py:
430         (CreateBug.__init__):
431         (CreateBug.execute):
432         * Scripts/webkitpy/tool/commands/upload_unittest.py:
433         (test_prepare_with_cc):
434         (test_prepare_with_radar):
435         (test_prepare_with_cc_and_radar):
436         * Scripts/webkitpy/tool/steps/createbug.py:
437         (CreateBug.options):
438         (CreateBug.run):
439         * Scripts/webkitpy/tool/steps/options.py:
440         (Options):
441
442 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
443
444         [GStreamer] Do not build gstgtk plugins
445         https://bugs.webkit.org/show_bug.cgi?id=190463
446
447         Reviewed by Xabier Rodriguez-Calvar.
448
449         These plugins pull a GTK+ dependency that, at least in WPE,
450         is unnecessary. The GTK+ port doesn't need it either, as far
451         as I can tell.
452
453         * gstreamer/jhbuild.modules: Disable gstgtk plugins
454
455 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
456
457         [GTK][WPE] Add mediaDevices.enumerateDevices support
458         https://bugs.webkit.org/show_bug.cgi?id=185761
459
460         Reviewed by Youenn Fablet.
461
462         Added new API test for the mediaDevices.enumerateDevices:
463         usermedia-enumeratedevices-permission-check. And a new API test
464         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
465
466         * MiniBrowser/gtk/main.c:
467         (gotWebsiteDataCallback): Added a new section to the about:data
468         webpage to include the information about the hash salt.
469         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
470         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
471         new test checking the enumerateDevices API when permission is
472         denied and when permission is allowed for the origin.
473         (beforeAll): Defined the new test.
474         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
475         (serverCallback): Register a new URI for the enumerateDevices.
476         (testWebsiteDataConfiguration): Remove the hash salts from the
477         directories.
478         (testWebsiteDataDeviceIdHashSalt): New test cheking the
479         enumerateDevices API.
480         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
481         the init structure.
482         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
483         (WebViewTest::initializeWebView): Make sure the media-stream is
484         activated in the webView.
485
486 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
487
488         Add WinCairo to the flakiness dashboard
489         https://bugs.webkit.org/show_bug.cgi?id=188345
490
491         Reviewed by Lucas Forschler.
492
493         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
494         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
495
496 2018-10-10  Dean Jackson  <dino@apple.com>
497
498         [WHSL -> MSL] Annotate semantics correctly in generated MSL
499         https://bugs.webkit.org/show_bug.cgi?id=190452
500         <rdar://problem/45178272>
501
502         Reviewed by Myles Maxfield.
503
504         Correctly label the appropriate semantics as [[position]]
505         and [[color(N)]].
506
507         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
508         and color attributes. Also use the semantic's index rather than
509         a counter.
510         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
511         output, and only include the actual shader code.
512
513 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
514
515         build-webkit --inspector-frontend shouldn't have a nonzero exit code
516         https://bugs.webkit.org/show_bug.cgi?id=190430
517
518         Reviewed by Brian Burg.
519
520         * Scripts/webkitdirs.pm:
521         (argumentsForConfiguration):
522         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
523         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
524
525 2018-10-10  Tim Horton  <timothy_horton@apple.com>
526
527         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
528         https://bugs.webkit.org/show_bug.cgi?id=190420
529
530         Reviewed by Simon Fraser.
531
532         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
533         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
534         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
535         * DumpRenderTree/mac/UIScriptControllerMac.mm:
536         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
537         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
538         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
539         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
540         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
541         * TestRunnerShared/UIScriptContext/UIScriptController.h:
542         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
543         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
544         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
545         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
546         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
547         Change the testing mechanism for the share sheet such that we up-front
548         set that it should immediately return with a particular state, instead
549         of programmatically dismissing the sheet.
550
551         Otherwise, running the tests on macOS doesn't work, because we pop
552         a context menu, which spins the runloop and prevents dismissal from
553         going through.
554
555 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
556
557         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
558         https://bugs.webkit.org/show_bug.cgi?id=190429
559
560         Reviewed by Saam Barati.
561
562         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
563         (TestWebKitAPI::TEST_F):
564
565 2018-10-10  Chris Dumez  <cdumez@apple.com>
566
567         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
568         https://bugs.webkit.org/show_bug.cgi?id=190418
569         <rdar://problem/45059769>
570
571         Reviewed by Geoffrey Garen.
572
573         Add API test coverage.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
576
577 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
578
579         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
580         https://bugs.webkit.org/show_bug.cgi?id=190191
581
582         Reviewed by Michael Catanzaro.
583
584         * QueueStatusServer/config/queues.py:
585         * Scripts/webkitpy/common/config/ews.json:
586         * Scripts/webkitpy/common/config/ports.py:
587         (DeprecatedPort.run_javascriptcore_tests_command):
588         Add the possibility to pass arguments to run-javascriptcore-tests with
589         the JSCTESTS_OPTIONS environment variable
590         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
591         (test_ews_name):
592
593
594 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
595
596         Allow run-javascriptcore-tests to distribute tests between devices
597         https://bugs.webkit.org/show_bug.cgi?id=190190
598
599         Reviewed by Michael Catanzaro.
600
601         * Scripts/run-jsc-stress-tests:
602         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
603         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
604
605 2018-10-09  Dean Jackson  <dino@apple.com>
606
607         Update WHLSL to Metal tester with semantics
608         https://bugs.webkit.org/show_bug.cgi?id=190416
609         <rdar://problem/45145139>
610
611         Reviewed by Myles Maxfield.
612
613         A few small changes to the WHLSL to Metal tools:
614         - Make it compile by adding some missing JS files :)
615         - Add semantics to the default shader
616         - Add FIXMEs to the other shaders
617         - Create an in-browser test for the WHLSLToMetal codepath
618         - Fix typos in the semantics checker
619
620         * WebGPUShadingLanguageRI/Checker.js:
621         (Checker.prototype._checkSemantics.checkSemanticTypes):
622         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
623         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
624         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
625         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
626         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
627         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
628         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
629
630 2018-10-09  Jer Noble  <jer.noble@apple.com>
631
632         Crash when closing WKWebView during enter fullscreen animation
633         https://bugs.webkit.org/show_bug.cgi?id=190412
634
635         Reviewed by Brian Burg.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
639         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
640         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
641         (TestWebKitAPI::TEST):
642
643 2018-10-09  Chris Dumez  <cdumez@apple.com>
644
645         Anchor target should be ignored on activation when the download attribute is set
646         https://bugs.webkit.org/show_bug.cgi?id=190408
647
648         Reviewed by Geoffrey Garen.
649
650         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
651         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
652         popup blocking.
653
654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
655         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
656         (WTR::TestRunner::setCanOpenWindows):
657         * WebKitTestRunner/InjectedBundle/TestRunner.h:
658         * WebKitTestRunner/TestController.cpp:
659         (WTR::TestController::createOtherPage):
660         * WebKitTestRunner/TestController.h:
661         * WebKitTestRunner/TestInvocation.cpp:
662         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
663         * WebKitTestRunner/TestInvocation.h:
664
665 2018-10-09  Jer Noble  <jer.noble@apple.com>
666
667         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
668         https://bugs.webkit.org/show_bug.cgi?id=190098
669         <rdar://problem/42822671>
670
671         Reviewed by Brian Burg.
672
673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
674         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
675         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
676         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
677         (TestWebKitAPI::TEST):
678
679 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
680
681         [WebAuthN] Import CTAP HID message and packet structure from Chromium
682         https://bugs.webkit.org/show_bug.cgi?id=189289
683         <rdar://problem/44120310>
684
685         Reviewed by Brent Fulgham.
686
687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
688         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
689         (TestWebKitAPI::TEST):
690
691 2018-10-09  Chris Dumez  <cdumez@apple.com>
692
693         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
694         https://bugs.webkit.org/show_bug.cgi?id=190378
695         <rdar://problem/45059466>
696
697         Reviewed by Geoffrey Garen.
698
699         Add API test coverage.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
702
703 2018-10-09  Jer Noble  <jer.noble@apple.com>
704
705         ISOTrackEncryptionBox returns incorrect defaultKeyID
706         https://bugs.webkit.org/show_bug.cgi?id=190368
707
708         Reviewed by Eric Carlson.
709
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
711         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
712         (TestWebKitAPI::TEST):
713
714 2018-10-09  Philippe Normand  <pnormand@igalia.com>
715
716         [JHBuild] Update to GStreamer 1.14.4
717         https://bugs.webkit.org/show_bug.cgi?id=190395
718
719         Reviewed by Xabier Rodriguez-Calvar.
720
721         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
722         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
723         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
724         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
725         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
726
727 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
728
729         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
730         https://bugs.webkit.org/show_bug.cgi?id=190386
731
732         Reviewed by Ryosuke Niwa.
733
734         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
735         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
736         of macOS.
737
738         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
739         (TEST):
740
741 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
742
743         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
744         https://bugs.webkit.org/show_bug.cgi?id=190342
745         <rdar://problem/44767118>
746
747         Reviewed by Tim Horton.
748
749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
750         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
751
752         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
753         moving the selection around text inside nested list elements.
754
755         (TestWebKitAPI::checkParagraphStyles):
756
757         Add a new helper to check an NSParagraphStyle against expected results.
758
759         (TestWebKitAPI::webViewForTestingFontAttributes):
760
761         Allow each test to pass in the name of the test page to load.
762
763         (TestWebKitAPI::TEST):
764         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
765
766         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
769
770         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
771
772 2018-10-08  Justin Fan  <justin_fan@apple.com>
773
774         WebGPU: Rename old WebGPU prototype to WebMetal
775         https://bugs.webkit.org/show_bug.cgi?id=190325
776         <rdar://problem/44990443>
777
778         Reviewed by Dean Jackson.
779
780         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
781
782         * DumpRenderTree/mac/DumpRenderTree.mm:
783         (enableExperimentalFeatures):
784         (resetWebPreferencesToConsistentValues):
785         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
786         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
787         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
788         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
789         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
790         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
791         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
792         (WTR::InjectedBundle::beginTesting):
793         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
794         (WTR::TestRunner::setWebMetalEnabled):
795         (WTR::TestRunner::setWebGPUEnabled): Deleted.
796         * WebKitTestRunner/InjectedBundle/TestRunner.h:
797
798 2018-10-08  Commit Queue  <commit-queue@webkit.org>
799
800         Unreviewed, rolling out r236941.
801         https://bugs.webkit.org/show_bug.cgi?id=190374
802
803         Causing API test failures in new test (Requested by jernoble
804         on #webkit).
805
806         Reverted changeset:
807
808         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
809         https://bugs.webkit.org/show_bug.cgi?id=190368
810         https://trac.webkit.org/changeset/236941
811
812 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
813
814         Make <input type=color> a runtime enabled (on-by-default) feature
815         https://bugs.webkit.org/show_bug.cgi?id=189162
816
817         Reviewed by Wenson Hsieh and Tim Horton.
818
819         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
820
821 2018-10-08  Jer Noble  <jer.noble@apple.com>
822
823         ISOTrackEncryptionBox returns incorrect defaultKeyID
824         https://bugs.webkit.org/show_bug.cgi?id=190368
825
826         Reviewed by Eric Carlson.
827
828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
829         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
830         (TestWebKitAPI::TEST):
831
832 2018-10-08  Alex Christensen  <achristensen@webkit.org>
833
834         Remove WKBundleFileHandleRef
835         https://bugs.webkit.org/show_bug.cgi?id=190360
836
837         Reviewed by Tim Horton.
838
839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
840         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
841         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
842
843 2018-10-08  Dan Bernstein  <mitz@apple.com>
844
845         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
846         https://bugs.webkit.org/show_bug.cgi?id=190250
847
848         Reviewed by Anders Carlsson.
849
850         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
851
852         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
853           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
854           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
855
856         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
857
858         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
859           around deprecated methods or categories on deprecated classes.
860         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
861         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
862         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
863         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
864
865         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
866           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
867           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
868
869         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
870
871         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
872         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
873           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
874
875         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
876           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
877           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
878
879         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
880           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
881
882         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
883           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
884           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
885           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
886           many C SPI headers trigger the strict prototypes warning.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
889
890         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
891         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
892         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
893         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
894         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
895         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
896         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
897         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
898         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
899         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
900         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
901         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
902         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
903         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
904         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
905         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
906         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
907         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
908         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
909         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
910         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
911         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
912         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
913         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
914         * TestWebKitAPI/mac/TestDraggingInfo.mm:
915         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
916
917         In all of the above, suppressed the deprecated implementations warning where needed.
918
919         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
920           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
921           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
922           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
923           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
924           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
925           and GCC_NO_COMMON_BLOCKS.
926
927         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
928
929         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
930         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
931           the deprecated implementations warning.
932
933         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
934         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
935
936 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
937
938         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
939         https://bugs.webkit.org/show_bug.cgi?id=189238
940
941         Reviewed by Xabier Rodriguez-Calvar.
942
943         Modifications on GStreamer, tracked in GStreamer bugzilla:
944         https://bugzilla.gnome.org/show_bug.cgi?id=797231
945         https://bugzilla.gnome.org/show_bug.cgi?id=765275
946
947         * gstreamer/jhbuild.modules: Add new patches.
948         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
949         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
950         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
951         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
952
953 2018-10-06  Dan Bernstein  <mitz@apple.com>
954
955         [Xcode] Never build yasm with ASAN
956         https://bugs.webkit.org/show_bug.cgi?id=190327
957
958         Reviewed by Youenn Fablet.
959
960         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
961           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
962
963 2018-10-05  Chris Dumez  <cdumez@apple.com>
964
965         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
966         https://bugs.webkit.org/show_bug.cgi?id=190320
967         <rdar://problem/45044814>
968
969         Reviewed by Geoffrey Garen.
970
971         Add API test coverage.
972
973         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
974         (TestWebKitAPI::TEST):
975         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
976         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
977
978 2018-10-03  Jer Noble  <jer.noble@apple.com>
979
980         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
981         https://bugs.webkit.org/show_bug.cgi?id=190266
982
983         Reviewed by Eric Carlson.
984
985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
986         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
987         (TestWebKitAPI::TEST):
988
989 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
990
991         Unreviewed, rolling out r236866.
992
993         Breaks internal builds.
994
995         Reverted changeset:
996
997         "Add support for reporting "display composited video frames"
998         through the VideoPlaybackQuality object."
999         https://bugs.webkit.org/show_bug.cgi?id=190266
1000         https://trac.webkit.org/changeset/236866
1001
1002 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1003
1004         [WPE][JSC] Use Unified Sources for Platform-specific sources
1005         https://bugs.webkit.org/show_bug.cgi?id=190300
1006
1007         Reviewed by Yusuke Suzuki.
1008
1009         Currently the GTK port already used Unified Sources with the same source files.
1010         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
1011         to the list of libraries to link with.
1012
1013         * TestWebKitAPI/PlatformWPE.cmake:
1014
1015 2018-10-05  Zach Li  <zachli@apple.com>
1016
1017         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
1018         https://bugs.webkit.org/show_bug.cgi?id=190302
1019         <rdar://problem/45031469>
1020
1021         Reviewed by Tim Horton.
1022
1023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1024         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
1025         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
1026         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
1027         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1028         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1029         (TEST):
1030
1031 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1032
1033         [iOS] [WK2] Expose some more editing SPI on WKWebView
1034         https://bugs.webkit.org/show_bug.cgi?id=190232
1035         <rdar://problem/44963368>
1036
1037         Reviewed by Tim Horton.
1038
1039         Adds new API tests to exercise the new SPIs.
1040
1041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1042         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
1043         (-[TestWKWebView querySelectorExists:]):
1044         (TestWebKitAPI::webViewForEditActionTesting):
1045         (TestWebKitAPI::TEST):
1046         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1047         (-[TestWKWebView collapseToStart]): Deleted.
1048         (-[TestWKWebView collapseToEnd]): Deleted.
1049         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
1050         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
1051         * TestWebKitAPI/cocoa/TestWKWebView.h:
1052         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1053         (-[TestWKWebView stylePropertyAtSelectionStart:]):
1054         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
1055         (-[TestWKWebView collapseToStart]):
1056         (-[TestWKWebView collapseToEnd]):
1057
1058         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
1059
1060 2018-10-04  Jer Noble  <jer.noble@apple.com>
1061
1062         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
1063         https://bugs.webkit.org/show_bug.cgi?id=190266
1064
1065         Reviewed by Eric Carlson.
1066
1067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1068         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
1069         (TestWebKitAPI::TEST):
1070
1071 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1072
1073         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
1074         https://bugs.webkit.org/show_bug.cgi?id=190119
1075         <rdar://problem/44767062>
1076
1077         Reviewed by Tim Horton.
1078
1079         Add a new API test that loads a document containing various rich text styles. This test moves the selection
1080         around the document and checks the last set of font attributes received via the new UI delegate hook.
1081
1082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1083         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
1084         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
1085         (-[FontAttributesListener lastFontAttributes]):
1086         (-[TestWKWebView selectElementWithIdentifier:]):
1087         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
1088         (ColorExpectation::ColorExpectation):
1089         (ShadowExpectation::ShadowExpectation):
1090         (checkColor):
1091         (checkShadow):
1092         (checkFont):
1093         (webViewForTestingFontAttributes):
1094         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
1095
1096 2018-10-04  Alan Coon  <alancoon@apple.com>
1097
1098         Unreviewed, add self as contributor.
1099
1100         * Scripts/webkitpy/common/config/contributors.json:
1101
1102 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1103
1104         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
1105         https://bugs.webkit.org/show_bug.cgi?id=190289
1106         <rdar://problem/45020806>
1107
1108         Reviewed by Ryosuke Niwa.
1109
1110         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
1111         attributes at the current selection.
1112
1113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1114         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
1115         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1116         (webViewForFontManagerTesting):
1117         (TestWebKitAPI::TEST):
1118         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
1119         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
1120
1121         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
1122         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
1123         foreground colors, and background colors.
1124
1125         (sharedFontOptionsForTesting):
1126         (+[TestFontOptions sharedInstance]):
1127         (-[TestFontOptions initWithFontOptions:]):
1128         (-[TestFontOptions selectedAttributes]):
1129         (-[TestFontOptions fontOptions]):
1130         (-[TestFontOptions shadowWidth]):
1131         (-[TestFontOptions setShadowWidth:]):
1132         (-[TestFontOptions shadowHeight]):
1133         (-[TestFontOptions setShadowHeight:]):
1134         (-[TestFontOptions setShadowBlurRadius:]):
1135         (-[TestFontOptions setHasShadow:]):
1136         (-[TestFontOptions foregroundColor]):
1137         (-[TestFontOptions setForegroundColor:]):
1138         (-[TestFontOptions backgroundColor]):
1139         (-[TestFontOptions setBackgroundColor:]):
1140         (-[TestFontOptions _dispatchFontAttributeChanges]):
1141         (-[TestFontOptions convertAttributes:]):
1142         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
1143         (-[TestFontOptions forwardInvocation:]):
1144
1145 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
1146
1147         [WebAuthN] Move time out control from WebProcess to UIProcess
1148         https://bugs.webkit.org/show_bug.cgi?id=189642
1149         <rdar://problem/44476765>
1150
1151         Reviewed by Chris Dumez.
1152
1153         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1154         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1155
1156 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1157
1158         Runtime flag and IDL for MediaRecorder
1159         https://bugs.webkit.org/show_bug.cgi?id=190018
1160
1161         Reviewed by Youenn Fablet and Chris Dumez.
1162
1163         * DumpRenderTree/mac/DumpRenderTree.mm:
1164         (enableExperimentalFeatures):
1165
1166 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1167
1168         [LayoutTests][Win] Stop wpt server correctly.
1169         https://bugs.webkit.org/show_bug.cgi?id=190248
1170
1171         Reviewed by Fujii Hironori.
1172
1173         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
1174         Also refactoring the detection of Windows and cygwin environment check.
1175
1176         * Scripts/webkitpy/common/system/executive.py:
1177         (Executive.__init__): Check environment once.
1178         (Executive._should_close_fds):
1179         (Executive.kill_process):
1180         (Executive.check_running_pid):
1181         (Executive.running_pids):
1182         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
1183         (Executive.kill_all):
1184         (Executive._child_process_encoding):
1185         (Executive._should_encode_child_process_arguments):
1186         (Executive.popen):
1187         (Executive.run_in_parallel):
1188
1189 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1190
1191         Convert tests to use navigation client
1192         https://bugs.webkit.org/show_bug.cgi?id=190153
1193
1194         Reviewed by Alex Christensen.
1195
1196         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
1197
1198         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
1199         (TestWebKitAPI::decidePolicyForNavigationAction):
1200         (TestWebKitAPI::setPagePolicyClient):
1201         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
1202         (TestWebKitAPI::didCommitNavigationCallback):
1203         (TestWebKitAPI::TEST):
1204         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1205
1206 2018-10-03  Dan Bernstein  <mitz@apple.com>
1207
1208         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
1209         https://bugs.webkit.org/show_bug.cgi?id=190270
1210
1211         Reviewed by Wenson Hsieh.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1214         (TestWebKitAPI::TEST):
1215
1216 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1217
1218         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1219         https://bugs.webkit.org/show_bug.cgi?id=190238
1220
1221         Reviewed by Antti Koivisto.
1222
1223         * DumpRenderTree/TestOptions.h:
1224         * DumpRenderTree/mac/DumpRenderTree.mm:
1225         (resetWebPreferencesToConsistentValues):
1226
1227 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1228
1229         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
1230         https://bugs.webkit.org/show_bug.cgi?id=179787
1231         <rdar://problem/35593389>
1232
1233         Reviewed by Tim Horton.
1234
1235         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
1236         menu items.
1237
1238         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1239         (webViewForFontManagerTesting):
1240         (menuItemCellForFontAction):
1241         (TestWebKitAPI::TEST):
1242
1243 2018-10-02  Chris Dumez  <cdumez@apple.com>
1244
1245         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
1246         https://bugs.webkit.org/show_bug.cgi?id=190176
1247         <rdar://problem/44925871>
1248
1249         Reviewed by Alex Christensen.
1250
1251         Use a URL that is truly recognized as invalid by WebCore's URL parser.
1252
1253         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
1254         (TEST):
1255
1256 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1257
1258         Remove ParsedURLString
1259         https://bugs.webkit.org/show_bug.cgi?id=190154
1260
1261         Reviewed by Chris Dumez.
1262
1263         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1264         (TestWebKitAPI::TEST_F):
1265         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1266         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
1267         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
1268         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
1269         (TestWebKitAPI::TEST):
1270
1271 2018-10-02  Daniel Bates  <dabates@apple.com>
1272
1273         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
1274         (https://bugs.webkit.org/show_bug.cgi?id=190017)
1275
1276         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
1277             WKWebViewAutofillTests.AutofillRequiresInputSession
1278             DragAndDropTests.ExternalSourceJPEGOnly
1279             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
1280
1281         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
1282         we will look to swizzle this method for all test by default.
1283
1284         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1285         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
1286         (TestWebKitAPI::TEST):
1287         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1288         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
1289         (TestWebKitAPI::TEST):
1290         * TestWebKitAPI/ios/UIKitSPI.h:
1291
1292 2018-10-02  Dawei Fenton  <realdawei@apple.com>
1293
1294         Unreviewed, rolling out r236751.
1295
1296         broke the iOS Build
1297
1298         Reverted changeset:
1299
1300         "Fix iOS TestWebKitAPI failures following
1301         <https://trac.webkit.org/changeset/236619>"
1302         https://bugs.webkit.org/show_bug.cgi?id=190017
1303         https://trac.webkit.org/changeset/236751
1304
1305 2018-10-02  Daniel Bates  <dabates@apple.com>
1306
1307         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
1308         (https://bugs.webkit.org/show_bug.cgi?id=190017)
1309
1310         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
1311             WKWebViewAutofillTests.AutofillRequiresInputSession
1312             DragAndDropTests.ExternalSourceJPEGOnly
1313             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
1314
1315         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
1316         we will look to swizzle this method for all test by default.
1317
1318         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1319         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
1320         (TestWebKitAPI::TEST):
1321         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1322         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
1323         (TestWebKitAPI::TEST):
1324         * TestWebKitAPI/ios/UIKitSPI.h:
1325
1326 2018-10-01  Dean Jackson  <dino@apple.com>
1327
1328         Remove CSS Animation Triggers
1329         https://bugs.webkit.org/show_bug.cgi?id=190175
1330         <rdar://problem/44925626>
1331
1332         Reviewed by Simon Fraser.
1333
1334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1335
1336 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
1337
1338         [Flatpak] Use our own check of flatpak repos
1339         https://bugs.webkit.org/show_bug.cgi?id=190194
1340
1341         Allowing us to not mess up with user installation
1342         and "--assumeyes" everywhere.
1343
1344         Reviewed by Michael Catanzaro.
1345
1346         * flatpak/flatpakutils.py:
1347         (FlatpakPackage.__init__):
1348         (FlatpakPackage.install):
1349         (FlatpakPackage.update):
1350         (WebkitFlatpak.load_from_args):
1351         (WebkitFlatpak.__init__):
1352         (WebkitFlatpak.clean_args):
1353
1354 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1355
1356         [macOS] Implement a way for the UI process to request typing attributes at the current selection
1357         https://bugs.webkit.org/show_bug.cgi?id=189983
1358         <rdar://problem/44648705>
1359
1360         Reviewed by Ryosuke Niwa.
1361
1362         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
1363
1364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
1366         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1367
1368         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
1369         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
1370         additionally check that shadowed text and strike-through are reflected in typing attributes.
1371
1372         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
1373         (-[TestWKWebView typingAttributes]):
1374
1375         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
1376
1377         (-[TestWKWebView collapseToStart]):
1378         (webViewForFontManagerTesting):
1379         (TestWebKitAPI::TEST):
1380         * TestWebKitAPI/cocoa/TestWKWebView.h:
1381         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
1382         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
1383
1384         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
1385
1386         (-[TestInspectorBarItemController initWithInspectorBar:]):
1387         (-[TestInspectorBarItemController inspectorBar]):
1388         (-[TestInspectorBarItemController updateSelectedAttributes]):
1389         (-[TestInspectorBar initWithWebView:]):
1390         (+[TestInspectorBar standardItemControllerClass]):
1391         (+[TestInspectorBar standardTextItemIdentifiers]):
1392         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
1393         (-[TestInspectorBar chooseFontSize:]):
1394         (-[TestInspectorBar chooseFontFamily:]):
1395         (-[TestInspectorBar _chooseColor:inColorWell:]):
1396         (-[TestInspectorBar chooseForegroundColor:]):
1397         (-[TestInspectorBar chooseBackgroundColor:]):
1398         (-[TestInspectorBar formatBold:]):
1399         (-[TestInspectorBar formatItalic:]):
1400         (-[TestInspectorBar formatUnderline:]):
1401
1402         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
1403         styling controls).
1404
1405         (-[TestInspectorBar itemController]):
1406         (-[TestInspectorBar setItemController:]):
1407
1408 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
1409
1410         [Flatpak] Implement icecream and ccache support
1411         https://bugs.webkit.org/show_bug.cgi?id=190146
1412
1413         Reviewed by Alejandro G. Castro.
1414
1415         * flatpak/flatpakutils.py:
1416         (WebkitFlatpak.load_from_args):
1417         (WebkitFlatpak.__init__):
1418         (WebkitFlatpak.clean_args):
1419         (WebkitFlatpak.run_in_sandbox):
1420         (WebkitFlatpak.save_config):
1421         (WebkitFlatpak):
1422         (WebkitFlatpak.setup_ccache):
1423         (WebkitFlatpak.setup_icecc):
1424         (WebkitFlatpak.setup_dev_env):
1425         * flatpak/org.webkit.WebKit.yaml:
1426
1427 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1428
1429         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
1430
1431         * WebKitTestRunner/TestController.cpp:
1432         (WTR::TestController::keyExistsInKeychain):
1433
1434 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1435
1436         [WinCairo] Enable WPT tests environment.
1437         https://bugs.webkit.org/show_bug.cgi?id=190128
1438
1439         Reviewed by Youenn Fablet.
1440
1441         Escaping backslash of the path not to confuse the JSON parser.
1442
1443         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1444         (WebPlatformTestServer._prepare_config):
1445
1446 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
1447
1448         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
1449         https://bugs.webkit.org/show_bug.cgi?id=190150
1450
1451         Reviewed by Fujii Hironori.
1452
1453         * DumpRenderTree/win/DumpRenderTree.cpp:
1454         (setWebPreferencesForTestOptions):
1455         DRT has been recognizing this field, but not propagating its value to WebPreferences.
1456
1457 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1458
1459         Unreviewed, rolling out r236551.
1460
1461         Fails URL validating too aggressively
1462
1463         Reverted changeset:
1464
1465         "URLWithUserTypedString should return nil for URLs deemed to
1466         be invalid by WebCore::URL"
1467         https://bugs.webkit.org/show_bug.cgi?id=189979
1468         https://trac.webkit.org/changeset/236551
1469
1470 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1471
1472         [iOS] Add SPI to customize the input accessory view when focusing an element
1473         https://bugs.webkit.org/show_bug.cgi?id=190152
1474         <rdar://problem/42754975>
1475
1476         Reviewed by Dan Bernstein.
1477
1478         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
1479         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
1480         `-inputAccessoryView`.
1481
1482         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1483         (webViewWithAutofocusedInput):
1484         (TestWebKitAPI::TEST):
1485         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1486         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1487         (-[TestInputDelegate setWillStartInputSessionHandler:]):
1488         (-[TestInputDelegate willStartInputSessionHandler]):
1489         (-[TestInputDelegate _webView:willStartInputSession:]):
1490
1491 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
1492
1493         Remove StorageProcess
1494         https://bugs.webkit.org/show_bug.cgi?id=189975
1495
1496         Reviewed by Geoffrey Garen.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1499         (TEST):
1500         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1501         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
1502         (TEST):
1503         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1504         (TEST):
1505         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1506         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1507         (WTR::TestRunner::terminateStorageProcess): Deleted.
1508         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::generatePageConfiguration):
1511         (WTR::TestController::databaseProcessName): Deleted.
1512         (WTR::TestController::databaseProcessDidCrash): Deleted.
1513         (WTR::TestController::terminateStorageProcess): Deleted.
1514         * WebKitTestRunner/TestController.h:
1515         * WebKitTestRunner/TestInvocation.cpp:
1516         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1517
1518 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
1519
1520         [WebAuthN] Import a JS CBOR coder
1521         https://bugs.webkit.org/show_bug.cgi?id=189877
1522         <rdar://problem/44701124>
1523
1524         Reviewed by Chris Dumez.
1525
1526         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
1527         only if acceptAttestation is true.
1528
1529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1530         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1531
1532 2018-10-01  Chris Dumez  <cdumez@apple.com>
1533
1534         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
1535         https://bugs.webkit.org/show_bug.cgi?id=190052
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
1540         to log those events. It also uses console.log() before sending those events to indicate what the test is about
1541         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
1542         so that it can log the message.
1543         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
1544         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
1545         handler to be transformed into synchronous IPC.
1546         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
1547         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
1548         messages may end up being out of order, leading to flakiness.
1549
1550         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
1551         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
1552         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
1553
1554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1555         (WTR::InjectedBundle::outputText):
1556
1557 2018-10-01  Daniel Bates  <dabates@apple.com>
1558
1559         [iOS] Special keys are misidentified in DOM keyboard events
1560         https://bugs.webkit.org/show_bug.cgi?id=189974
1561
1562         Reviewed by Wenson Hsieh.
1563
1564         Add support for testing keys Forward Delete and Num Lock / Clear.
1565
1566         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1567         (hidUsageCodeForCharacter):
1568
1569 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1570
1571         URL should not use TextEncoding internally
1572         https://bugs.webkit.org/show_bug.cgi?id=190111
1573
1574         Reviewed by Andy Estes.
1575
1576         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1577         (TestWebKitAPI::testUserPass):
1578         (TestWebKitAPI::TEST_F):
1579
1580 2018-10-01  Daniel Bates  <dabates@apple.com>
1581
1582         LLDB tests may use wrong configuration of lldbWebKitTester
1583         https://bugs.webkit.org/show_bug.cgi?id=189011
1584
1585         Reviewed by Dean Jackson.
1586
1587         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
1588         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
1589
1590         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
1591         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
1592         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
1593         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
1594         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
1595         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
1596         the Python unittest module, the Python multiprocessing module, and the general principle of unit
1597         tests - to test code in isolation). The unit tests make use of the value of this environment
1598         variable to launch lldbWebKitTester binary.
1599
1600         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
1601         out if this script is invoked for a non-Mac platform.
1602         * Scripts/webkitpy/test/main.py:
1603         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
1604         LLDB_WEBKIT_TESTER_EXECUTABLE.
1605         (_build_lldb_webkit_tester): Deleted.
1606         * lldb/dump_class_layout_unittest.py:
1607         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
1608         this is the only call site that needs the Host object now.
1609         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
1610         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
1611         * lldb/lldbWebKitTester/main.cpp:
1612         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
1613         * lldb/lldb_webkit_unittest.py:
1614         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
1615         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
1616         (TestSummaryProviders):
1617         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
1618         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
1619         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
1620         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
1621         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
1622         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
1623         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
1624
1625 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
1626
1627         [WPE] Update install-dependencies
1628         https://bugs.webkit.org/show_bug.cgi?id=190127
1629
1630         Reviewed by Michael Catanzaro.
1631
1632         * wpe/install-dependencies:
1633         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
1634         It is used by gstvaapidisplay_x11.c.
1635         Add it only for Apt, already ok for Pacman and DNF.
1636
1637         Install libevent-dev for WebRTC (like GTK)
1638
1639         Install libasound2-dev for WebRTC.
1640         Add it only for Apt, already ok for Pacam and DNF.
1641
1642         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
1643
1644 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
1645
1646         [Flatpak] Add libunwind in the sandbox
1647         https://bugs.webkit.org/show_bug.cgi?id=190123
1648
1649         Allowing us to get proper traces in GStreamer trace grabing
1650         debug functions.
1651
1652         Reviewed by Philippe Normand.
1653
1654         * flatpak/org.webkit.WebKit.yaml:
1655
1656 2018-09-29  Commit Queue  <commit-queue@webkit.org>
1657
1658         Unreviewed, rolling out r236631.
1659         https://bugs.webkit.org/show_bug.cgi?id=190112
1660
1661         Caused various eventSender tests, including fast/css/pseudo-
1662         active-style-sharing*, to fail (Requested by smfr on #webkit).
1663
1664         Reverted changeset:
1665
1666         "Regression(r236512): http/tests/navigation/keyboard-events-
1667         during-provisional-navigation.html is flaky"
1668         https://bugs.webkit.org/show_bug.cgi?id=190052
1669         https://trac.webkit.org/changeset/236631
1670
1671 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1672
1673         [WHLSL] Fix build after r236635
1674         https://bugs.webkit.org/show_bug.cgi?id=189210
1675
1676         Unreviewed.
1677
1678         * WebGPUShadingLanguageRI/Intrinsics.js:
1679         (Intrinsics.):
1680         * WebGPUShadingLanguageRI/Test.js:
1681         (tests.atomicsNull):
1682         (tests.numThreads):
1683         (tests.textureDimensionsNull):
1684
1685 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1686
1687         [WHLSL] Allow uniform buffers to be used in the interpreter
1688         https://bugs.webkit.org/show_bug.cgi?id=189210
1689
1690         Reviewed by Filip Pizlo.
1691
1692         Every lvalue is associated with an address space, and the propagation of these address spaces
1693         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
1694         of this, so this patch just goes the last few yards. It also updates the standard library to
1695         allow for writing into all writable address spaces for out-params.
1696
1697         * WebGPUShadingLanguageRI/Checker.js:
1698         (Checker.prototype.visitAssignment):
1699         (Checker.prototype._finishVisitingPropertyAccess):
1700         * WebGPUShadingLanguageRI/Intrinsics.js:
1701         (Intrinsics.):
1702         (Intrinsics.checkFalse):
1703         (Intrinsics):
1704         * WebGPUShadingLanguageRI/StandardLibrary.js:
1705         (let.standardLibrary):
1706         * WebGPUShadingLanguageRI/Test.js:
1707         (tests.threadArrayRefLoad):
1708         (tests.threadArrayRefLoadIntLiteral):
1709         (tests.deviceArrayRefLoad):
1710         (tests.threadArrayRefStore):
1711         (tests.deviceArrayRefStore):
1712         (tests.deviceArrayRefStoreIntLiteral):
1713         (tests.threadPointerLoad):
1714         (tests.threadPointerStore):
1715         (tests.devicePointerLoad):
1716         (tests.devicePointerStore):
1717         (tests.arrayLoad):
1718         (tests.constantAddressSpace):
1719         (tests.standardLibraryDevicePointers):
1720         (tests.threadArrayLoad): Deleted.
1721         (tests.threadArrayLoadIntLiteral): Deleted.
1722         (tests.deviceArrayLoad): Deleted.
1723         (tests.threadArrayStore): Deleted.
1724         (tests.deviceArrayStore): Deleted.
1725         (tests.deviceArrayStoreIntLiteral): Deleted.
1726
1727 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1728
1729         No DOM API to instantiate an attachment for an img element
1730         https://bugs.webkit.org/show_bug.cgi?id=189934
1731         <rdar://problem/44743222>
1732
1733         Reviewed by Ryosuke Niwa.
1734
1735         Adds 3 new API tests in WKAttachmentTests:
1736
1737         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
1738         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
1739
1740         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
1741         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
1742
1743         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
1744         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
1745         then result in an image element with the contents of the _WKAttachment's file wrapper.
1746
1747         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1748         (-[TestWKWebView imageElementSize]):
1749         (-[TestWKWebView waitForImageElementSizeToBecome:]):
1750         (TestWebKitAPI::TEST):
1751         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
1752
1753 2018-09-28  Chris Dumez  <cdumez@apple.com>
1754
1755         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
1756         https://bugs.webkit.org/show_bug.cgi?id=190052
1757
1758         Reviewed by Ryosuke Niwa.
1759
1760         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
1761         to log those events. It also uses console.log() before sending those events to indicate what the test is about
1762         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
1763         so that it can log the message.
1764         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
1765         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
1766         handler to be transformed into synchronous IPC.
1767         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
1768         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
1769         messages may end up being out of order, leading to flakiness.
1770
1771         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
1772         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
1773         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
1774
1775         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1776         (WTR::InjectedBundle::outputText):
1777
1778 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1779
1780         [WHLSL] Pointers should have automatically-generated equality checks
1781         https://bugs.webkit.org/show_bug.cgi?id=189986
1782
1783         Reviewed by Filip Pizlo.
1784
1785         C allows for pointer equality, and we need it so people can do null checks.
1786         This is generated the same way all our other NativeFuncs are generated - by Checker
1787         creating NativeFuncs inside CallExpression.resolve().
1788
1789         This patch also does some general cleanup.
1790
1791         * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
1792         The last thing it was doing was making sure that only primitive types are in resources, but
1793         it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
1794         still have to add a check to make sure resources can't live within resources, but I expect
1795         that will be done in the same place that semantics are checked.
1796         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
1797         (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
1798         Name the global struct for debugging purposes.
1799         * WebGPUShadingLanguageRI/CallExpression.js: 
1800         (CallExpression.prototype._resolveByInstantiation): Cleanup
1801         (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
1802         (CallExpression.prototype._resolveWithOperatorLength): Ditto
1803         (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
1804         generate pointer equality NativeFuncs.
1805         * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
1806         * WebGPUShadingLanguageRI/LateChecker.js: Removed.
1807         * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
1808         (layoutBuffers):
1809         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
1810         * WebGPUShadingLanguageRI/NativeFunc.js:
1811         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
1812         (OperatorArrayRefLength.prototype.instantiateImplementation):
1813         (OperatorArrayRefLength):
1814         * WebGPUShadingLanguageRI/Prepare.js:
1815         (let.prepare):
1816         * WebGPUShadingLanguageRI/SPIRV.html:
1817         * WebGPUShadingLanguageRI/Test.html:
1818         * WebGPUShadingLanguageRI/Test.js:
1819         (tests.ternaryExpression):
1820         (tests.break): Speed up testing time
1821         (tests.doWhile): Ditto
1822         (tests.forLoop): Ditto
1823         (tests.atomics): Ditto
1824         (tests.atomicsNull): Ditto
1825         (tests.pointerEquality): Test pointer equality
1826         (tests.standardLibraryDevicePointers):
1827         (tests.devicePtrPtr): Deleted.
1828         (tests.threadgroupPtrPtr): Deleted.
1829         (tests.constantPtrPtr): Deleted.
1830         * WebGPUShadingLanguageRI/index.html:
1831
1832 2018-09-28  Jiewen Tan  <jiewen_tan@apple.com>
1833
1834         [WebAuthN] Polish WebAuthN auto-test environment
1835         https://bugs.webkit.org/show_bug.cgi?id=189283
1836         <rdar://problem/44117828>
1837
1838         Reviewed by Chris Dumez.
1839
1840         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1841         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1842
1843 2018-09-28  Chris Dumez  <cdumez@apple.com>
1844
1845         Drop support for cross-origin-window-policy header
1846         https://bugs.webkit.org/show_bug.cgi?id=190081
1847
1848         Reviewed by Ryosuke Niwa.
1849
1850         190081_DropCrossOriginWindowPolicy
1851
1852         * DumpRenderTree/mac/DumpRenderTree.mm:
1853         (enableExperimentalFeatures):
1854         * DumpRenderTree/win/DumpRenderTree.cpp:
1855         (enableExperimentalFeatures):
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::TestController::resetPreferencesToConsistentValues):
1858
1859 2018-09-28  Koby Boyango  <koby.b@mce.systems>
1860
1861         [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
1862         https://bugs.webkit.org/show_bug.cgi?id=189991
1863
1864         Reviewed by Yusuke Suzuki.
1865
1866         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1867
1868 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
1869
1870         Update flakiness dashboard configuration for Mojave queues
1871         https://bugs.webkit.org/show_bug.cgi?id=190068
1872
1873         Reviewed by Alexey Proskuryakov.
1874
1875         * TestResultServer/static-dashboards/builders.jsonp:
1876
1877 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
1878
1879         Bring up queues for Mojave
1880         https://bugs.webkit.org/show_bug.cgi?id=189935
1881
1882         Unreviewed infrastructure fix.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
1885
1886 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
1887
1888         Bring up queues for Mojave
1889         https://bugs.webkit.org/show_bug.cgi?id=189935
1890
1891         Reviewed by Alexey Proskuryakov.
1892
1893         * BuildSlaveSupport/build.webkit.org-config/config.json:
1894         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1895         (WebKitBuildbot):
1896         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1897
1898 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
1899
1900         Increase the timeout for iOS Simulator data migration
1901         https://bugs.webkit.org/show_bug.cgi?id=190059
1902
1903         Reviewed by Aakash Jain.
1904
1905         3 minutes isn't always enough time for the data migrator to complete
1906         when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
1907
1908         * Scripts/webkitpy/xcode/simulated_device.py:
1909         (SimulatedDeviceManager): Create a constant for the default timeout.
1910         (SimulatedDeviceManager.initialize_devices): Use new constant.
1911         (SimulatedDeviceManager.swap): Ditto.
1912         (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
1913
1914 2018-09-27  Alex Christensen  <achristensen@webkit.org>
1915
1916         URLParser should use TextEncoding through an abstract class
1917         https://bugs.webkit.org/show_bug.cgi?id=190027
1918
1919         Reviewed by Andy Estes.
1920
1921         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1922         (TestWebKitAPI::checkURL):
1923         (TestWebKitAPI::TEST_F):
1924
1925 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
1926
1927         iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
1928         https://bugs.webkit.org/show_bug.cgi?id=190042
1929
1930         Reviewed by Aakash Jain.
1931
1932         To make iOS Simulator bots resilient to issues that can arise from reusing
1933         existing simulators, ensure that dedicated simulators are created for each test run.
1934
1935         * Scripts/webkitpy/common/config/ports.py:
1936         (IOSSimulatorWK2Port.run_webkit_tests_command):
1937
1938 2018-09-27  Alex Christensen  <achristensen@webkit.org>
1939
1940         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
1941         https://bugs.webkit.org/show_bug.cgi?id=189979
1942
1943         Reviewed by Youenn Fablet.
1944
1945         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1946         (TestWebKitAPI::originalDataAsString):
1947         (TestWebKitAPI::TEST):
1948
1949 2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1950
1951         [Win][WebKit] Implement authentication dialog on MiniBrowser.
1952         https://bugs.webkit.org/show_bug.cgi?id=189846
1953
1954         Reviewed by Fujii Hironori.
1955
1956         It was implemented for WebKitLegacy, but not for WebKit.
1957         Also added text field to display Realm information.
1958
1959         * MiniBrowser/win/Common.cpp:
1960         (authDialogProc):
1961         (askCredential):
1962         (displayAuthDialog): Deleted.
1963         * MiniBrowser/win/Common.h:
1964         * MiniBrowser/win/MiniBrowserLib.rc:
1965         * MiniBrowser/win/MiniBrowserLibResource.h:
1966         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1967         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1968         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1969         (createString):
1970         (createUTF8String):
1971         (createWKString):
1972         (createWKURL):
1973         (WebKitBrowserWindow::WebKitBrowserWindow):
1974         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1975         (toNullTerminatedUTF8): Deleted.
1976         * MiniBrowser/win/WebKitBrowserWindow.h:
1977
1978 2018-09-27  Youenn Fablet  <youenn@apple.com>
1979
1980         Enable getUserMedia in mini browser
1981         https://bugs.webkit.org/show_bug.cgi?id=190012
1982
1983         Reviewed by Eric Carlson.
1984
1985         Enable MediaDevices and mock capture devices.
1986         Grant mock devices access to any getUserMedia call.
1987         Covered by manual testing.
1988
1989         * MiniBrowser/mac/AppDelegate.m:
1990         (defaultConfiguration):
1991         * MiniBrowser/mac/WK2BrowserWindowController.m:
1992         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1993         (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1994
1995 2018-09-27  Antoine Quint  <graouts@apple.com>
1996
1997         [Web Animations] Turn Web Animations with CSS integration on
1998         https://bugs.webkit.org/show_bug.cgi?id=184819
1999         <rdar://problem/39597337>
2000
2001         Reviewed by Dean Jackson.
2002
2003         * DumpRenderTree/TestOptions.h:
2004
2005 2018-09-26  Alex Christensen  <achristensen@webkit.org>
2006
2007         Unreviewed, rolling out r236524.
2008
2009         Broke API tests
2010
2011         Reverted changeset:
2012
2013         "URLWithUserTypedString should return nil for URLs deemed to
2014         be invalid by WebCore::URL"
2015         https://bugs.webkit.org/show_bug.cgi?id=189979
2016         https://trac.webkit.org/changeset/236524
2017
2018 2018-09-26  James Savage  <james.savage@apple.com>
2019
2020         Allow override of viewport configuration.
2021         https://bugs.webkit.org/show_bug.cgi?id=188772.
2022         <rdar://problem/43538892>.
2023
2024         Reviewed by Simon Fraser.
2025
2026         * WebKitTestRunner/TestController.cpp:
2027         (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
2028         * WebKitTestRunner/TestOptions.h:
2029         * WebKitTestRunner/ios/TestControllerIOS.mm:
2030         (WTR::TestController::platformConfigureViewForTest): Handle new test option by
2031         modifying the web view's preferences accordingly.
2032
2033 2018-09-26  Alex Christensen  <achristensen@webkit.org>
2034
2035         URLs with mismatched surrogate pairs in the host should fail to parse
2036         https://bugs.webkit.org/show_bug.cgi?id=190005
2037
2038         Reviewed by Chris Dumez.
2039
2040         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2041         (TestWebKitAPI::TEST_F):
2042
2043 2018-09-26  Alex Christensen  <achristensen@webkit.org>
2044
2045         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
2046         https://bugs.webkit.org/show_bug.cgi?id=189979
2047         <rdar://problem/44119696>
2048
2049         Reviewed by Chris Dumez.
2050
2051         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2052         (TestWebKitAPI::TEST):
2053
2054 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2055
2056         Selection should work across shadow boundary when initiated by a mouse drag
2057         https://bugs.webkit.org/show_bug.cgi?id=151380
2058         <rdar://problem/24363872>
2059
2060         Reviewed by Wenson Hsieh.
2061
2062         Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
2063
2064         * DumpRenderTree/TestOptions.cpp:
2065         (TestOptions::TestOptions):
2066         * DumpRenderTree/TestOptions.h:
2067         * DumpRenderTree/mac/DumpRenderTree.mm:
2068         (resetWebPreferencesToConsistentValues):
2069         (setWebPreferencesForTestOptions):
2070
2071 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2072
2073         MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
2074         https://bugs.webkit.org/show_bug.cgi?id=189989
2075
2076         Reviewed by Simon Fraser.
2077
2078         When the preference isn't found in user defaults, use the default value of each feature's enabledness.
2079
2080         * MiniBrowser/mac/AppDelegate.m:
2081         (defaultConfiguration):
2082
2083 2018-09-26  Philippe Normand  <pnormand@igalia.com>
2084
2085         [Flatpak] Bump to apr 1.6.5
2086
2087         Version 1.6.3 is no longer available on Apache's website.
2088
2089         Rubber-stamped by Michael Catanzaro.
2090
2091         * flatpak/org.webkit.WebKit.yaml:
2092
2093 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
2094
2095         [WebAuthN] Make AuthenticatorManager
2096         https://bugs.webkit.org/show_bug.cgi?id=189279
2097         <rdar://problem/44116792>
2098
2099         Reviewed by Chris Dumez.
2100
2101         Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
2102         added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
2103
2104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2105         * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
2106         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2107         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2108         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2109         (WTR::TestRunner::addTestKeyToKeychain):
2110         (WTR::TestRunner::cleanUpKeychain):
2111         (WTR::TestRunner::isKeyExisted):
2112         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::TestController::addTestKeyToKeychain):
2115         (WTR::TestController::cleanUpKeychain):
2116         (WTR::TestController::isKeyExisted):
2117         (WTR::TestController::setWebAuthenticationMockConfiguration):
2118         * WebKitTestRunner/TestController.h:
2119         * WebKitTestRunner/TestInvocation.cpp:
2120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2121         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2122         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2123         (WTR::TestController::addTestKeyToKeychain):
2124         (WTR::TestController::cleanUpKeychain):
2125         (WTR::TestController::keyExistedInKeychain):
2126
2127 2018-09-25  Sihui Liu  <sihui_liu@apple.com>
2128
2129         Move Service Worker Management from Storage Process to Network Process
2130         https://bugs.webkit.org/show_bug.cgi?id=189422
2131
2132         Reviewed by Youenn Fablet.
2133
2134         Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
2135         launched during service worker operations now.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2138
2139 2018-09-25  Eric Carlson  <eric.carlson@apple.com>
2140
2141         [MediaStream] Update constraints supported by getDisplayMedia
2142         https://bugs.webkit.org/show_bug.cgi?id=189930
2143         <rdar://problem/44740305>
2144
2145         Unreviewed, fix test broken by r236465.
2146
2147         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2148         (TestWebKitAPI::TEST_F):
2149
2150 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
2151
2152         [WHSL] Implement semantics
2153         https://bugs.webkit.org/show_bug.cgi?id=189134
2154
2155         Reviewed by Filip Pizlo.
2156
2157         This patch adds parsing support and adds the checks required to support HLSL-style semantics.
2158
2159         There are 3 places where semantics are allowed:
2160
2161         1. In a field in a struct. E.g.
2162
2163         struct R {
2164             float4 position : SV_Position;
2165         }
2166         vertex R foo() {
2167             ...
2168         }
2169
2170         2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
2171
2172         compute void foo(device float[] data : buffer(u0)) {
2173             ...
2174         }
2175
2176         3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
2177
2178         vertex float4 foo() : SV_Position {
2179             ...
2180         }
2181
2182         The semantics are partitioned into 4 types:
2183
2184         1. Built-in variables. For example, : SV_Position.
2185         2. Resources. For example, : register(u0).
2186         3. Stage-in / stage-out variables. For example, : attribute(0).
2187         4. Specialization constants. For example, : specialized.
2188
2189         The semantics are validated according to a collection of rules:
2190
2191         - The same entry point can't list the same semantic twice
2192         - Each built-in type has an appropriate type that is listed in the spec. 
2193         - Each built-in is appropriate as either an input or an output of a particular shader stage
2194         - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
2195         - Resources can't be output from entry points
2196         - The resource semantic mode must match the address space of the resource
2197         - Stage-in and stage-out variables have to be POD
2198         - Specialization constants can't be output from entry points, and have to be numbers
2199
2200         * WebGPUShadingLanguageRI/All.js:
2201         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
2202         (BuiltInSemantic):
2203         (BuiltInSemantic.prototype.get name):
2204         (BuiltInSemantic.prototype.get extraArguments):
2205         (BuiltInSemantic.prototype.isAcceptableType):
2206         (BuiltInSemantic.prototype.isAcceptableForShaderType):
2207         (BuiltInSemantic.prototype.toString):
2208         * WebGPUShadingLanguageRI/CallExpression.js:
2209         (CallExpression.prototype._resolveWithOperatorAnderIndexer):
2210         (CallExpression.prototype._resolveWithOperatorLength):
2211         * WebGPUShadingLanguageRI/Checker.js:
2212         (Checker):
2213         (Checker.prototype.visitProgram):
2214         (Checker.prototype._checkSemantics.Item):
2215         (Checker.prototype._checkSemantics.Item.prototype.get type):
2216         (Checker.prototype._checkSemantics.Item.prototype.get semantic):
2217         (Checker.prototype._checkSemantics.Gatherer):
2218         (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
2219         (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
2220         (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
2221         (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
2222         (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
2223         (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
2224         (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
2225         (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
2226         (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
2227         (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
2228         (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
2229         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
2230         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
2231         (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
2232         (Checker.prototype._checkSemantics.checkDuplicateSemantics):
2233         (Checker.prototype._checkSemantics.checkSemanticTypes):
2234         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
2235         (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
2236         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
2237         (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
2238         (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
2239         (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
2240         (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
2241         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
2242         (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
2243         (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
2244         (Checker.prototype._checkSemantics.PODChecker):
2245         (Checker.prototype._checkSemantics.checkPODData):
2246         (Checker.prototype._checkSemantics):
2247         (Checker.prototype._checkShaderType):
2248         (Checker.prototype._checkOperatorOverload):
2249         (Checker.prototype.visitFuncDef):
2250         (Checker.prototype.visitEnumType):
2251         (Checker.prototype.visitArrayType):
2252         (Checker.prototype.visitMakePtrExpression):
2253         (Checker.prototype.visitMakeArrayRefExpression):
2254         (Checker.prototype._finishVisitingPropertyAccess):
2255         (Checker.prototype.visitIndexExpression):
2256         (Checker.prototype.visitReturn):
2257         (Checker.prototype.visitSwitchStatement):
2258         (Checker.prototype.visitTernaryExpression):
2259         (Checker.prototype.visitCallExpression):
2260         * WebGPUShadingLanguageRI/Field.js:
2261         (Field):
2262         (Field.prototype.get semantic):
2263         (Field.prototype.toString):
2264         * WebGPUShadingLanguageRI/Func.js:
2265         (Func):
2266         (Func.prototype.get semantic):
2267         (Func.prototype.toDeclString):
2268         * WebGPUShadingLanguageRI/FuncDef.js:
2269         (FuncDef):
2270         * WebGPUShadingLanguageRI/FuncParameter.js:
2271         (FuncParameter):
2272         (FuncParameter.prototype.get semantic):
2273         (FuncParameter.prototype.toString):
2274         * WebGPUShadingLanguageRI/Intrinsics.js:
2275         * WebGPUShadingLanguageRI/LateChecker.js:
2276         (LateChecker.prototype.visitReferenceType):
2277         (LateChecker):
2278         (LateChecker.prototype._checkShaderType): Deleted.
2279         (LateChecker.prototype.visitFuncDef): Deleted.
2280         * WebGPUShadingLanguageRI/NativeFunc.js:
2281         (NativeFunc):
2282         * WebGPUShadingLanguageRI/Parse.js:
2283         (parseParameter):
2284         (parseFuncDecl):
2285         (parseFuncDef):
2286         (parseStageInOutSemantic):
2287         (parseResourceSemantic):
2288         (parseSpecializationConstantSemantic):
2289         (parseBuiltInSemantic):
2290         (parseField):
2291         (parseNativeFunc):
2292         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
2293         (programWithUnnecessaryThingsRemoved):
2294         * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
2295         (ResourceSemantic):
2296         (ResourceSemantic.prototype.get resourceMode):
2297         (ResourceSemantic.prototype.get index):
2298         (ResourceSemantic.prototype.get space):
2299         (ResourceSemantic.prototype.isAcceptableType):
2300         (ResourceSemantic.prototype.isAcceptableForShaderType):
2301         (ResourceSemantic.prototype.toString):
2302         * WebGPUShadingLanguageRI/Rewriter.js:
2303         (Rewriter.prototype.visitFuncParameter):
2304         (Rewriter.prototype.visitField):
2305         (Rewriter.prototype.visitBuiltInSemantic):
2306         (Rewriter.prototype.visitResourceSemantic):
2307         (Rewriter.prototype.visitStageInOutSemantic):
2308         (Rewriter.prototype.visitSpecializationConstantSemantic):
2309         (Rewriter):
2310         * WebGPUShadingLanguageRI/SPIRV.html:
2311         * WebGPUShadingLanguageRI/Semantic.js: Added.
2312         (Semantic):
2313         (Semantic.prototype.get origin):
2314         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
2315         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
2316         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
2317         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
2318         (Semantic.prototype.equalToOtherSemantic.Comparer):
2319         (Semantic.prototype.equalToOtherSemantic):
2320         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
2321         (SpecializationConstantSemantic):
2322         (SpecializationConstantSemantic.prototype.isAcceptableType):
2323         (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
2324         (SpecializationConstantSemantic.prototype.toString):
2325         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
2326         (StageInOutSemantic):
2327         (StageInOutSemantic.prototype.get index):
2328         (StageInOutSemantic.prototype.isAcceptableType):
2329         (StageInOutSemantic.prototype.isAcceptableForShaderType):
2330         (StageInOutSemantic.prototype.toString):
2331         * WebGPUShadingLanguageRI/StatementCloner.js:
2332         (StatementCloner.prototype.visitNativeFunc):
2333         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
2334         (synthesizeArrayOperatorLength):
2335         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
2336         (synthesizeCopyConstructorOperator):
2337         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
2338         (synthesizeDefaultConstructorOperator):
2339         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
2340         (synthesizeEnumFunctions):
2341         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
2342         (setupAnder):
2343         (synthesizeStructAccessorsForStructType):
2344         * WebGPUShadingLanguageRI/Test.html:
2345         * WebGPUShadingLanguageRI/Test.js:
2346         (tests.shaderTypes):
2347         * WebGPUShadingLanguageRI/Visitor.js:
2348         (Visitor.prototype.visitFunc):
2349         (Visitor.prototype.visitFuncParameter):
2350         (Visitor.prototype.visitField):
2351         (Visitor.prototype.visitBuiltInSemantic):
2352         (Visitor.prototype.visitResourceSemantic):
2353         (Visitor.prototype.visitStageInOutSemantic):
2354         (Visitor.prototype.visitSpecializationConstantSemantic):
2355         (Visitor):
2356         * WebGPUShadingLanguageRI/index.html:
2357
2358 2018-09-25  Thomas Denney  <tdenney@apple.com>
2359
2360         [WHLSL] Test suite for Metal code generation
2361         https://bugs.webkit.org/show_bug.cgi?id=187738
2362
2363         Reviewed by Myles C. Maxfield.
2364
2365         This patch adds an Xcode project that contains a Cocoa app that can be
2366         used for running WHLSL shaders on the GPU. It also contains an Xcode
2367         test suite that runs all of the tests in Test.js on the GPU.
2368
2369         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
2370         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
2371         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
2372         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
2373         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
2374         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
2375         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
2376         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
2377         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
2378         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
2379         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
2380         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
2381         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
2382         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
2383         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
2384         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
2385         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
2386         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
2387         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
2388         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
2389         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
2390         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
2391         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
2392         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
2393         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
2394         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
2395         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
2396         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
2397         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
2398         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
2399         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
2400         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
2401         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
2402         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
2403         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
2404         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
2405         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
2406         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
2407         * WebGPUShadingLanguageRI/Test.js:
2408         (tests.lotsOfLocalVariables):
2409
2410 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
2411
2412         Unreviewed build fix after r236455
2413         https://bugs.webkit.org/show_bug.cgi?id=189121
2414
2415         * WebGPUShadingLanguageRI/Test.js:
2416         (tests.shaderStages):
2417
2418 2018-09-24  Myles C. Maxfield  <mmaxfield@apple.com>
2419
2420         [WHLSL] Not all functions should be able to run in all shader stages
2421         https://bugs.webkit.org/show_bug.cgi?id=189121
2422
2423         Reviewed by Filip Pizlo.
2424
2425         ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
2426         ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
2427         if/when we make them native.
2428
2429         The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
2430         0. Therefore, those functions are unchanged.
2431
2432         * WebGPUShadingLanguageRI/All.js:
2433         * WebGPUShadingLanguageRI/Intrinsics.js:
2434         * WebGPUShadingLanguageRI/LateChecker.js:
2435         (LateChecker.prototype._checkShaderType):
2436         * WebGPUShadingLanguageRI/NativeFunc.js:
2437         (NativeFunc):
2438         (NativeFunc.prototype.get stage):
2439         (NativeFunc.prototype.toDeclString):
2440         * WebGPUShadingLanguageRI/Parse.js:
2441         (parseFuncDecl):
2442         (parseNativeFunc):
2443         (parseNative):
2444         * WebGPUShadingLanguageRI/Prepare.js:
2445         (let.prepare):
2446         * WebGPUShadingLanguageRI/SPIRV.html:
2447         * WebGPUShadingLanguageRI/StandardLibrary.js:
2448         (let.standardLibrary):
2449         * WebGPUShadingLanguageRI/StatementCloner.js:
2450         (StatementCloner.prototype.visitNativeFunc):
2451         * WebGPUShadingLanguageRI/Test.html:
2452         * WebGPUShadingLanguageRI/Test.js:
2453         (tests.shaderStages):
2454         * WebGPUShadingLanguageRI/WSyntaxError.js:
2455         (WSyntaxError.prototype.toString):
2456         (WSyntaxError):
2457         * WebGPUShadingLanguageRI/index.html:
2458
2459 2018-09-24  Thomas Denney  <tdenney@apple.com>
2460
2461         [WHLSL] Implement trap statements in Metal code generation
2462         https://bugs.webkit.org/show_bug.cgi?id=189615
2463
2464         Reviewed by Myles C. Maxfield.
2465
2466         Each function called by an entry point now receives an additional
2467         boolean pointer parameter, which is set to false if the function traps.
2468         After each function call (to a non-native function) this trap parameter
2469         is checked. The behavior of the interpreter has also been updated so
2470         that a function entry point catches the trap and instead returns zero,
2471         matching the behavior of compiled code.
2472
2473         * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
2474         test suite to check for traps and also returns zero from entry points
2475         whose invocation trapped.
2476         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
2477         declarations.
2478         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
2479         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
2480         property.
2481         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
2482         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
2483         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
2484         new trapping behavior.
2485         * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
2486
2487 2018-09-24  Thomas Denney  <tdenney@apple.com>
2488
2489         [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
2490         https://bugs.webkit.org/show_bug.cgi?id=189290
2491
2492         Reviewed by Myles C. Maxfield.
2493
2494         It is no longer possible for a ternary expression to be treated as an
2495         l-value. This patch adds several test cases to verify that this is the
2496         case.
2497
2498         * WebGPUShadingLanguageRI/Checker.js:
2499         (Checker.prototype.visitTernaryExpression): No longer check isLValue.
2500         * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
2501         (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
2502         * WebGPUShadingLanguageRI/Rewriter.js:
2503         (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
2504         * WebGPUShadingLanguageRI/TernaryExpression.js:
2505         (TernaryExpression):
2506         (TernaryExpression.prototype.get elseExpression):
2507         (TernaryExpression.prototype.get isLValue): Deleted.
2508         (TernaryExpression.prototype.set isLValue): Deleted.
2509         * WebGPUShadingLanguageRI/Test.js:
2510         (tests.ternaryExpression): Add checks for failure if a failure is used
2511         as an l-value.
2512         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
2513         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
2514         (tests.ternaryExpressionIsLValue): Deleted.
2515
2516 2018-09-24  Jer Noble  <jer.noble@apple.com>
2517
2518         SharedBuffer should have an equality test
2519         https://bugs.webkit.org/show_bug.cgi?id=189919
2520
2521         Reviewed by Alex Christensen.
2522
2523         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2524         (TestWebKitAPI::TEST_F):
2525
2526 2018-09-24  Alex Christensen  <achristensen@webkit.org>
2527
2528         Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
2529         https://bugs.webkit.org/show_bug.cgi?id=189929
2530
2531         Reviewed by Andy Estes.
2532
2533         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
2534
2535 2018-09-24  Thomas Denney  <tdenney@apple.com>
2536
2537         [WHLSL] Casting user-created types to themselves should always work
2538         https://bugs.webkit.org/show_bug.cgi?id=189113
2539
2540         Reviewed by Myles C. Maxfield.
2541
2542         Casting user-defined types to themselves worked already, but we didn't
2543         test it anywhere.
2544
2545         * WebGPUShadingLanguageRI/Test.js:
2546         (tests.selfCasts):
2547
2548 2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
2549
2550         Unreviewed build fix for Jhbuild-using ports.
2551
2552         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
2553         Adjust the patch so it applies cleanly on the 1.14.3 version of the
2554         gst-plugins-good package.
2555
2556 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
2557
2558         Update flakiness dashboard configuration for iOS 12 queues
2559         https://bugs.webkit.org/show_bug.cgi?id=189688
2560
2561         Reviewed by Alexey Proskuryakov.
2562
2563         * TestResultServer/static-dashboards/builders.jsonp:
2564
2565 2018-09-24  Alicia Boya García  <aboya@igalia.com>
2566
2567         [GStreamer] Unreviewed build fix.
2568
2569         A GStreamer patch was not applying cleanly on 1.14.3.
2570
2571         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
2572
2573 2018-09-24  Alicia Boya García  <aboya@igalia.com>
2574
2575         [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
2576         https://bugs.webkit.org/show_bug.cgi?id=189868
2577
2578         Reviewed by Xabier Rodriguez-Calvar.
2579
2580         Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
2581
2582         * gstreamer/jhbuild.modules:
2583         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
2584
2585 2018-09-24  Alicia Boya García  <aboya@igalia.com>
2586         [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
2587         https://bugs.webkit.org/show_bug.cgi?id=185731
2588
2589         Reviewed by Xabier Rodriguez-Calvar.
2590
2591         Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
2592
2593         This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
2594         case where two WebM initialization segments are appended on a row).
2595
2596         * gstreamer/jhbuild.modules:
2597         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
2598         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
2599         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
2600
2601 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
2602
2603         [WHSL] Need grammar to specify kernel group size
2604         https://bugs.webkit.org/show_bug.cgi?id=189108
2605
2606         Reviewed by Dean Jackson.
2607
2608         In HLSL, compute functions are annotated with their workgroup size.
2609         For example,
2610
2611         [numthreads(3, 4, 5)] compute void foo(...) { ... }
2612
2613         * WebGPUShadingLanguageRI/All.js:
2614         * WebGPUShadingLanguageRI/Func.js:
2615         (Func):
2616         (Func.prototype.get attributeBlock):
2617         * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
2618         (FuncAttribute):
2619         * WebGPUShadingLanguageRI/FuncDef.js:
2620         (FuncDef):
2621         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
2622         (FuncNumThreadsAttribute):
2623         (FuncNumThreadsAttribute.prototype.get x):
2624         (FuncNumThreadsAttribute.prototype.get y):
2625         (FuncNumThreadsAttribute.prototype.get z):
2626         * WebGPUShadingLanguageRI/LateChecker.js:
2627         (LateChecker.prototype._checkShaderType):
2628         * WebGPUShadingLanguageRI/Parse.js:
2629         (parseAttributeBlock):
2630         (parseFuncDecl):
2631         (parseFuncDef):
2632         (parseNativeFunc):
2633         * WebGPUShadingLanguageRI/SPIRV.html:
2634         * WebGPUShadingLanguageRI/StatementCloner.js:
2635         (StatementCloner.prototype.visitFuncDef):
2636         (StatementCloner.prototype.visitFuncNumThreadsAttribute):
2637         (StatementCloner):
2638         * WebGPUShadingLanguageRI/Test.html:
2639         * WebGPUShadingLanguageRI/Test.js:
2640         (tests.numThreads):
2641         * WebGPUShadingLanguageRI/Visitor.js:
2642         (Visitor.prototype.visitFunc):
2643         (Visitor.prototype.visitFuncNumThreadsAttribute):
2644         (Visitor):
2645         * WebGPUShadingLanguageRI/index.html:
2646
2647 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
2648
2649         Native functions which accept pointers need to do null checks
2650         https://bugs.webkit.org/show_bug.cgi?id=189883
2651
2652         Reviewed by Dean Jackson.
2653
2654         Simply guard all the places where we write through an author-provided pointer.
2655
2656         * WebGPUShadingLanguageRI/Intrinsics.js:
2657         (Intrinsics.):
2658         * WebGPUShadingLanguageRI/Test.js:
2659         (tests.textureDimensionsNull):
2660
2661 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
2662
2663         [WHLSL] Implement atomic operations and barriers
2664         https://bugs.webkit.org/show_bug.cgi?id=189025
2665
2666         Reviewed by Dean Jackson.
2667
2668         In the interpreter, atomic operations don't need to be atomic.
2669
2670         * WebGPUShadingLanguageRI/Intrinsics.js:
2671         (Intrinsics.):
2672         * WebGPUShadingLanguageRI/StandardLibrary.js:
2673         (let.standardLibrary):
2674         * WebGPUShadingLanguageRI/Test.js:
2675         (tests.atomics):
2676
2677 2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
2678
2679         [WPE] Be very permissive in the MiniBrowser.
2680         https://bugs.webkit.org/show_bug.cgi?id=189800
2681
2682         This is just a test tool and we should make
2683         it just work, security and privacy is not really
2684         a primary focus here.
2685
2686         Reviewed by Žan Doberšek.
2687
2688         * MiniBrowser/wpe/main.cpp:
2689         (decidePermissionRequest):
2690         (main):
2691
2692 2018-09-21  Thomas Denney  <tdenney@apple.com>
2693
2694         [WHLSL] Local variables should be statically allocated
2695         https://bugs.webkit.org/show_bug.cgi?id=188402
2696
2697         Reviewed by Myles C. Maxfield.
2698
2699         An additional preparation stage is now performed so that all local
2700         variables and function parameters are allocated in a single struct at
2701         entry points. A pointer to this struct is then passed for function
2702         calls.
2703
2704         * WebGPUShadingLanguageRI/All.js: Update dependencies.
2705         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
2706         * WebGPUShadingLanguageRI/CallExpression.js:
2707         (CallExpression.prototype.set argumentList): Add setter because
2708         allocateAtEntryPoints needs to change this.
2709         * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
2710         constructor that wasn't used anywhere.
2711         * WebGPUShadingLanguageRI/Func.js:
2712         (Func.prototype.set parameters): Add setter.
2713         * WebGPUShadingLanguageRI/FuncDef.js:
2714         (FuncDef.prototype.set body): Ditto.
2715         * WebGPUShadingLanguageRI/Prepare.js:
2716         (let.prepare): Add call to allocateAtEntryPoints. This call cannot
2717         happen any earlier because it depends on having types for call
2718         arguments.
2719         * WebGPUShadingLanguageRI/Rewriter.js:
2720         (Rewriter.prototype.visitReturn): Resolve issue where the return
2721         statement's function wasn't copied. A null check is required as the
2722         Rewriter might be used before this property is set.
2723         * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
2724         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
2725         into a separate function so that allocateAtEntryPoints can create the
2726         accessors for the struct type it introduces.
2727         * WebGPUShadingLanguageRI/Test.html: Update dependencies.
2728         * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
2729         allocation transform works safely.
2730         * WebGPUShadingLanguageRI/index.html: Update dependencies.
2731
2732 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
2733
2734         Bring up queues for iOS 12 (Build fix)
2735         https://bugs.webkit.org/show_bug.cgi?id=189683
2736
2737         Unreviewed build fix.
2738
2739         We should not build ImageDiff as x86 by default since 32 bit projects are
2740         deprecated in Xcode. ImageDiff should only be built once.
2741
2742         * Scripts/build-webkit:
2743         * Scripts/webkitdirs.pm:
2744         (argumentsForConfiguration):
2745
2746 2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
2747
2748         [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
2749         https://bugs.webkit.org/show_bug.cgi?id=189797
2750
2751         Reviewed by Žan Doberšek.
2752
2753         * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
2754         the need for installing it. This works fine because the library only contains utility
2755         code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
2756
2757 2018-09-20  Daniel Bates  <dabates@apple.com>
2758
2759         Move IOKitSPI.h from TestRunnerShared to PAL
2760         https://bugs.webkit.org/show_bug.cgi?id=189804
2761
2762         Reviewed by Wenson Hsieh.
2763
2764         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
2765         declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
2766
2767         No functionality changed. So, no new tests.
2768
2769         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
2770         * TestRunnerShared/spi/UIKitTestSPI.h:
2771         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2772         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2773
2774 2018-09-20  Thomas Denney  <tdenney@apple.com>
2775
2776         [WHLSL] Metal code generation
2777         https://bugs.webkit.org/show_bug.cgi?id=187735
2778
2779         Reviewed by Myles C. Maxfield.
2780
2781         Adds support for generating Metal Shading Language from WHLSL. Clients
2782         should include the file MetalCodegenAll.js and then call whlslToMsl
2783         with their program source code to compile to Metal.
2784
2785         * WebGPUShadingLanguageRI/ArrayType.js:
2786         (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
2787         all types to find the type of that expression when it is used in a
2788         MakeArrayRefExpression.
2789         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
2790         (MakeArrayRefExpression):
2791         (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
2792         getter on all types to find the type of the expression.
2793         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
2794         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
2795         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
2796         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
2797         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
2798         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
2799         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
2800         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
2801         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
2802         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
2803         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
2804         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
2805         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
2806         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
2807         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
2808         * WebGPUShadingLanguageRI/PropertyResolver.js:
2809         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
2810         * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
2811         to generate code for.
2812         (tests.incrementAndDecrement):
2813         (tests.returnIntLiteralUint):
2814         (tests.returnIntLiteralFloat):
2815         (tests.nestedSubscriptWithArraysInStructs):
2816         (tests.nestedSubscript):
2817         (tests.lotsOfLocalVariables):
2818         * WebGPUShadingLanguageRI/Type.js:
2819         (Type.prototype.get arrayRefType): See above.
2820
2821 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
2822
2823         Bring up queues for iOS 12
2824         https://bugs.webkit.org/show_bug.cgi?id=189683
2825
2826         Unreviewed infrastructure fix.
2827
2828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
2829         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2830         (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
2831
2832 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
2833
2834         Bring up queues for iOS 12
2835         https://bugs.webkit.org/show_bug.cgi?id=189683
2836
2837         Reviewed by Aakash Jain.
2838
2839         * BuildSlaveSupport/build.webkit.org-config/config.json:
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
2841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2846         (WebKitBuildbot):
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2848         (table.queue-grid tr.platform.ios-simulator-12 img.logo):
2849         (table.queue-grid tr.platform.ios-12 img.logo):
2850         (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
2851         (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
2852         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2853         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2854         (_should_file_trigger_build):
2855         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2856         (ShouldBuildTest):
2857         (ShouldBuildTest.test_should_build):
2858
2859 2018-09-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2860
2861         [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
2862         https://bugs.webkit.org/show_bug.cgi?id=189679
2863
2864         Reviewed by Fujii Hironori.
2865
2866         Replace the implementation with correct API call.
2867
2868         * DumpRenderTree/win/TestRunnerWin.cpp:
2869         (TestRunner::queueLoad): Call UrlCombineW.
2870
2871 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2872
2873         [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
2874         https://bugs.webkit.org/show_bug.cgi?id=189556
2875
2876         Reviewed by Konstantin Tokarev.
2877
2878         This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
2879         libepoxy.
2880
2881         * wpe/backends/CMakeLists.txt:
2882
2883 2018-09-20  Daniel Bates  <dabates@apple.com>
2884
2885         [iOS] Support testing more hardware special keys
2886         https://bugs.webkit.org/show_bug.cgi?id=189793
2887
2888         Reviewed by Simon Fraser.
2889
2890         * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
2891         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2892         (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
2893         key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
2894         F13, F14, ..., F24 keys.
2895         (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
2896
2897 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2898
2899         Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
2900
2901         Aaaaaah maybe this is why changes are supposed to be reviewed.
2902
2903         * flatpak/flatpakutils.py:
2904         (WebkitFlatpak.clean_args):
2905
2906 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2907
2908         Unreviewed, manually rollout our switch to master runtime
2909
2910         Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
2911         meantime, where we were already building GStreamer ourselves anyway. But use an updated
2912         SDK revision.
2913
2914         * flatpak/files/httpd-autogen.sh: Added.
2915         * flatpak/flatpakutils.py:
2916         (WebkitFlatpak.clean_args):
2917         * flatpak/org.webkit.GTK.yaml:
2918         * flatpak/org.webkit.WebKit.yaml:
2919         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
2920         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
2921
2922 2018-09-20  Thibault Saunier  <tsaunier@igalia.com>
2923
2924         [WPE][GTK] webkit-flatpak intercepts --help for other commands
2925         https://bugs.webkit.org/show_bug.cgi?id=189058
2926
2927         The approach of run_in_sandbox_if_available is that we basically have the
2928         same set of arguments to setup the sandbox (ie. port name, build type, etc...)
2929         and we can pass those args first to setup the flatpak launcher object
2930         and then to the underlying script. That doesn't work well with the `--help` argument
2931         as once processed it 1. prints the help (which make no sense to the user of the calling script)
2932         2. exits the app - The solution is to just make sure that `--help` is not used when using
2933         flatpakutils from any script that is not `webkit-flatpak` itself.
2934
2935         Reviewed by Michael Catanzaro.
2936
2937         * flatpak/flatpakutils.py:
2938         (WebkitFlatpak.load_from_args):
2939         (run_in_sandbox_if_available):
2940
2941 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2942
2943         Unreviewed. Add W3C imported tests to the MSEEME watchlist.
2944
2945         * Scripts/webkitpy/common/config/watchlist:
2946
2947 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2948
2949         Unreviewed. Fix the Streams API watchlist.
2950
2951         * Scripts/webkitpy/common/config/watchlist:
2952
2953 2018-09-19  Chris Dumez  <cdumez@apple.com>
2954
2955         Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
2956         https://bugs.webkit.org/show_bug.cgi?id=189721
2957         <rdar://problem/44359788>
2958
2959         Reviewed by Geoffrey Garen.
2960
2961         Add API test coverage.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2964
2965 2018-09-19  Thomas Denney  <tdenney@apple.com>
2966
2967         [WHLSL] Improve test suite type safety
2968         https://bugs.webkit.org/show_bug.cgi?id=189502
2969
2970         Reviewed by Myles C. Maxfield.
2971
2972         Each of the 'makeT' functions now call the relevant cast function on the
2973         value before hand. The checkNumber function has also been removed and
2974         its uses have been replaced with functions that also check the type.
2975         Some of the arithmetic checks have been updated to reflect that the
2976         casts happen outside of WHLSL evaluation. Other tests have also been
2977         updated to reflect that some values cannot be precisely expressed in
2978         32-bit floating point.
2979
2980         * WebGPUShadingLanguageRI/Casts.js:
2981         (castToBool): Added.
2982         (castAndCheckValue): Added.
2983         (isBitwiseEquivalent): Moved from Intrinsics.js.
2984         * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
2985         * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
2986         * WebGPUShadingLanguageRI/Test.html: Ditto.
2987         * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
2988         and check the result. Some tests were also updated to reflect the change
2989         in the behavior of these functions.
2990         * WebGPUShadingLanguageRI/index.html: Update dependencies.
2991
2992 2018-09-19  John Wilander  <wilander@apple.com>
2993
2994         Resource Load Statistics: Add optional cap on partitioned cache max age
2995         https://bugs.webkit.org/show_bug.cgi?id=189711
2996         <rdar://problem/39246837>
2997
2998         Reviewed by Antti Koivisto and Chris Dumez.
2999
3000         This change adds infrastructure for layout tests of capped cache max age.
3001
3002         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3003         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3004         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3005         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::TestController::setStatisticsCacheMaxAgeCap):
3008         * WebKitTestRunner/TestController.h:
3009         * WebKitTestRunner/TestInvocation.cpp:
3010         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3011
3012 2018-09-19  Dawei Fenton  <realdawei@apple.com>
3013
3014        Unreviewed. Update my email and alias in list of contributors.
3015
3016         * Scripts/webkitpy/common/config/contributors.json:
3017
3018 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3019
3020         [WPE][GTK] Unreviewed, try #3 to fix a typo
3021
3022         I feel like Charlie Brown, how hard this has been for me....
3023
3024         * Scripts/run-minibrowser:
3025         * Scripts/webkitdirs.pm:
3026         (runInFlatpakIfAvailable):
3027         (runInFlatpakIfAvailible): Deleted.
3028
3029 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3030
3031         [WPE][GTK] Unreviewed, fix that typo in more places
3032
3033         It got copied into webkitdirs.pm!
3034
3035         * Scripts/webkitdirs.pm:
3036         (runInFlatpakIfAvailible):
3037         (runInFlatpakIfAvalaible): Deleted.
3038
3039 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3040
3041         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
3042
3043         * flatpak/flatpakutils.py:
3044         (WebkitFlatpak.load_from_args):
3045         (WebkitFlatpak.__init__):
3046         (WebkitFlatpak.run):
3047
3048 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3049
3050         [WPE][GTK] Unreviewed, update to latest GNOME SDK
3051
3052         * flatpak/org.webkit.WebKit.yaml:
3053
3054 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3055
3056         Unreviewed, rolling out r235500.
3057
3058         Time to switch back to master runtime
3059
3060         Reverted changeset:
3061
3062         "Unreviewed, rolling out r235114."
3063         https://bugs.webkit.org/show_bug.cgi?id=188731
3064         https://trac.webkit.org/changeset/235500
3065
3066 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
3067
3068         Unreviewed. Add Pablo Saavedra to the list of contributors.
3069
3070         * Scripts/webkitpy/common/config/contributors.json:
3071
3072 2018-09-19  Philippe Normand  <pnormand@igalia.com>
3073
3074         [GStreamer] Add support for AV1 decoding
3075         https://bugs.webkit.org/show_bug.cgi?id=189647
3076
3077         Reviewed by Žan Doberšek.
3078
3079         Add patches required for AV1 decoding support. They're all
3080         upstream already and will be shipped in GStreamer 1.16. The aom
3081         GStreamer plugin depends on the aom library for which there's no
3082         official release yet.
3083
3084         * gstreamer/jhbuild.modules:
3085         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
3086         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
3087         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
3088         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
3089         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
3090         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
3091
3092 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
3093
3094         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
3095         https://bugs.webkit.org/show_bug.cgi?id=189702
3096         <rdar://problem/44541704>
3097
3098         Reviewed by Aakash Jain.
3099
3100         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3101         (Manager._set_up_run): Move build check and clobbering to run, since set up is
3102         run multiple times for iOS simulator.
3103         (Manager.run):
3104
3105 2018-09-18  Chris Dumez  <cdumez@apple.com>
3106
3107         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
3108         https://bugs.webkit.org/show_bug.cgi?id=189681
3109         <rdar://problem/44526171>
3110
3111         Reviewed by Alex Christensen and Zalan Bujtas.
3112
3113         Add API test coverage.
3114
3115         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3116         (TestWebKitAPI::didFinishNavigation):
3117         (TestWebKitAPI::TEST):
3118
3119 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
3120
3121         [WPE] Implement mouse event modifiers
3122         https://bugs.webkit.org/show_bug.cgi?id=189697
3123
3124         Reviewed by Carlos Garcia Campos.
3125
3126         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3127         (WTR::wkEventModifiersToWPE):
3128         (WTR::EventSenderProxy::mouseDown):
3129         (WTR::EventSenderProxy::mouseUp):
3130
3131 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3132
3133         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
3134         https://bugs.webkit.org/show_bug.cgi?id=185339
3135
3136         Reviewed by Mark Lam.
3137
3138         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
3139         (TestWebKitAPI::ToUpperConverter::stopProducing):
3140         (TestWebKitAPI::ToUpperConverter::stopConsuming):
3141
3142 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
3143
3144         Many modern media control tests leak documents in testing
3145         https://bugs.webkit.org/show_bug.cgi?id=189437
3146
3147         Reviewed by Darin Adler.
3148         
3149         In order to accurately detect leaks in media controls tests which use lots of
3150         SVGImages, we have to:
3151         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
3152           to clear references to elements.
3153         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
3154           to drop the last handle to the CachedResource for an SVGImage.
3155         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
3156           to run again after that timer has fired.
3157         
3158         This should fix most of the spurious leak reports involving SVGImage documents.
3159
3160         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3161         (WTR::InjectedBundle::reportLiveDocuments):
3162         (WTR::InjectedBundle::didReceiveMessageToPage):
3163
3164 2018-09-17  Chris Dumez  <cdumez@apple.com>
3165
3166         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
3167         https://bugs.webkit.org/show_bug.cgi?id=189602
3168         <rdar://problem/44430549>
3169
3170         Reviewed by Geoff Garen.
3171
3172         Add API test coverage.
3173
3174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3175
3176 2018-09-17  Philippe Normand  <pnormand@igalia.com>
3177
3178         [JHBuild] Update to GStreamer 1.14.3
3179         https://bugs.webkit.org/show_bug.cgi?id=189450
3180
3181         Reviewed by Xabier Rodriguez-Calvar.
3182
3183         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
3184
3185 2018-09-17  Philippe Normand  <pnormand@igalia.com>
3186
3187         [JHBuild] Doesn't check sha256 sums
3188         https://bugs.webkit.org/show_bug.cgi?id=189646
3189
3190         Reviewed by Michael Catanzaro.
3191
3192         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
3193
3194 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
3195
3196         Move IndexedDB to Network Process
3197         https://bugs.webkit.org/show_bug.cgi?id=189415
3198         <rdar://problem/44396973>
3199
3200         Reviewed by Chris Dumez.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
3203         (TEST):
3204         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3205         (TEST):
3206         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
3207         (TEST):
3208         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
3209         (TEST):
3210         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3211         (TEST):
3212
3213 2018-09-08  Darin Adler  <darin@apple.com>
3214
3215         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
3216         https://bugs.webkit.org/show_bug.cgi?id=189455
3217
3218         Reviewed by Keith Miller.
3219
3220         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
3221         testing and even for macOS vs. iOS vs. Windows platform-specific code.
3222         For now, this patch just makes corresponding changes to the copied code.
3223         Later we might get better results by merging more code instead of having
3224         all these separate copies.
3225
3226         * DumpRenderTree/AccessibilityController.cpp:
3227         (AccessibilityController::makeWindowObject): Use the adopt function
3228         instead of the special Adopt constructor of JSRetainPtr.
3229
3230         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
3231
3232         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
3233         (allAttributesCallback): Don't adopt at this level; changed the
3234         underlying function to return a JSRetainPtr so the adopt is right next
3235         to the call to the create or copy function.
3236         (attributesOfLinkedUIElementsCallback): Ditto.
3237         (attributesOfDocumentLinksCallback): Ditto.
3238         (attributesOfChildrenCallback): Ditto.
3239         (parameterizedAttributeNamesCallback): Ditto.
3240         (attributesOfColumnHeadersCallback): Ditto.
3241         (attributesOfRowHeadersCallback): Ditto.
3242         (attributesOfColumnsCallback): Ditto.
3243         (attributesOfRowsCallback): Ditto.
3244         (attributesOfVisibleCellsCallback): Ditto.
3245         (attributesOfHeaderCallback): Ditto.
3246         (rowIndexRangeCallback): Ditto.
3247         (columnIndexRangeCallback): Ditto.
3248         (rangeForLineCallback): Ditto.
3249         (boundsForRangeCallback): Ditto.
3250         (rangeForPositionCallback): Ditto.
3251         (stringForRangeCallback): Ditto.
3252         (attributedStringForRangeCallback): Ditto.
3253         (uiElementCountForSearchPredicateCallback): Use the free adopt
3254         function instead of the adopt member function.
3255         (uiElementForSearchPredicateCallback): Ditto.
3256         (selectTextWithCriteriaCallback): Don't adopt at this level.
3257         (attributedStringForElementCallback): Ditto.
3258         (setValueCallback): Use free adopt.
3259         (stringAttributeValueCallback): Don't adopt at this level.
3260         (uiElementArrayAttributeValueCallback): Ditto.
3261         (uiElementAttributeValueCallback): Ditto.
3262         (stringForTextMarkerRangeCallback): Ditto.
3263         (attributedStringForTextMarkerRangeCallback): Ditto.
3264         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
3265         (getARIADropEffectsCallback): Ditto.
3266         (getClassListCallback): Ditto.
3267         (getRoleCallback): Ditto.
3268         (getSubroleCallback): Ditto.
3269         (getRoleDescriptionCallback): Ditto.
3270         (getComputedRoleStringCallback): Ditto.
3271         (getTitleCallback): Ditto.
3272         (getDescriptionCallback): Ditto.
3273         (getStringValueCallback): Ditto.
3274         (getLanguageCallback): Ditto.
3275         (getHelpTextCallback): Ditto.
3276         (getOrientationCallback): Ditto.
3277         (getPathDescriptionCallback): Ditto.
3278         (getSelectedTextRangeCallback): Ditto.
3279         (speakAsCallback): Ditto.
3280         (getValueDescriptionCallback): Ditto.
3281         (getAccessibilityValueCallback): Ditto.
3282         (getDocumentEncodingCallback): Ditto.
3283         (getDocumentURICallback): Ditto.
3284         (getURLCallback): Ditto.
3285         (characterAtOffsetCallback): Ditto.
3286         (wordAtOffsetCallback): Ditto.
3287         (lineAtOffsetCallback): Ditto.
3288         (sentenceAtOffsetCallback): Ditto.
3289         (stringForSelectionCallback): Ditto.
3290         (getIdentifierCallback): Ditto.
3291         (getTraitsCallback): Ditto.
3292         (supportedActionsCallback): Ditto.
3293         (mathPostscriptsDescriptionCallback): Ditto.
3294         (mathPrescriptsDescriptionCallback): Ditto.
3295         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
3296         (AccessibilityUIElement::rangeForPosition): Ditto.
3297         (AccessibilityUIElement::speakAs): Ditto.
3298         (AccessibilityUIElement::pathDescription const): Ditto.
3299         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
3300         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
3301         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
3302
3303         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
3304         raw pointers for the results of the functions that create strings.
3305         The old way was difficult to get right; the functions didn't even follow
3306         the create/copy naming rule.
3307
3308         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3309         (_platformTypeConstructor): Use the adopt function instead of the
3310         JSRetainPtr adopt constructor. Also nullptr instead of 0.
3311
3312         * DumpRenderTree/GCController.cpp:
3313         (GCController::makeWindowObject): Use adopt function instead of constructor.
3314
3315         * DumpRenderTree/TestRunner.cpp:
3316         (pathToLocalResourceCallback): Use adopt function instead of constructor.
3317         (addDisallowedURLCallback): Ditto.
3318         (addURLToRedirectCallback): Ditto.
3319         (clearApplicationCacheForOriginCallback): Ditto.
3320         (applicationCacheDiskUsageForOriginCallback): Ditto.
3321         (decodeHostNameCallback): Don't adopt at this level.
3322         (encodeHostNameCallback): Ditto.
3323         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
3324         (findStringCallback): Use adopt function instead of constructor.
3325         (isCommandEnabledCallback): Ditto.
3326         (overridePreferenceCallback): Ditto.
3327         (queueLoadCallback): Ditto.
3328         (queueLoadHTMLStringCallback): Ditto.
3329         (queueLoadingScriptCallback): Ditto.
3330         (queueNonLoadingScriptCallback): Ditto.
3331         (setAuthenticationPasswordCallback): Ditto.
3332         (setAuthenticationUsernameCallback): Ditto.
3333         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
3334         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
3335         (setPOSIXLocaleCallback): Ditto.
3336         (setPersistentUserStyleSheetLocationCallback): Ditto.
3337         (setUserStyleSheetLocationCallback): Ditto.
3338         (setValueForUserCallback): Ditto.
3339         (setWillSendRequestClearHeaderCallback): Ditto.
3340         (setPageVisibilityCallback): Ditto.
3341         (evaluateInWebInspectorCallback): Ditto.
3342         (evaluateScriptInIsolatedWorldCallback): Ditto.
3343         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
3344         (addOriginAccessWhitelistEntryCallback): Ditto.
3345         (removeOriginAccessWhitelistEntryCallback): Ditto.
3346         (setScrollbarPolicyCallback): Ditto.
3347         (addUserScriptCallback): Ditto.
3348         (addUserStyleSheetCallback): Ditto.
3349         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
3350         (authenticateSessionCallback): Ditto.
3351         (getTitleTextDirectionCallback): Ditto.
3352         (getInspectorTestStubURLCallback): Ditto.
3353         (simulateLegacyWebNotificationClickCallback): Ditto.
3354         (setTextDirectionCallback): Ditto.
3355         (grantWebNotificationPermissionCallback): Ditto.
3356         (denyWebNotificationPermissionCallback): Ditto.
3357         (accummulateLogsForChannel): Ditto.
3358         (runUIScriptCallback): Ditto.
3359         (TestRunner::makeWindowObject): Ditto.
3360         (TestRunner::uiScriptDidComplete): Ditto.
3361         (TestRunner::setOpenPanelFiles): Ditto.
3362
3363         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
3364         raw pointers for the results of the functions that create strings.
3365
3366         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3367         (AccessibilityController::platformName const): Use the adopt
3368         function instead of the adopt constructor.
3369
3370         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3371         (createEmptyJSString): Added. This helper function makes reduces the
3372         repetitive code to create empty strings.
3373         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
3374         (AccessibilityUIElement::identifier): Ditto.
3375         (AccessibilityUIElement::traits): Ditto.
3376         (AccessibilityUIElement::url): Ditto.
3377         (AccessibilityUIElement::speakAs): Ditto.
3378         (AccessibilityUIElement::stringForSelection): Ditto.
3379         (AccessibilityUIElement::stringForRange): Ditto.
3380         (AccessibilityUIElement::attributedStringForRange): Ditto.
3381         (AccessibilityUIElement::attributedStringForElement): Ditto.
3382         (AccessibilityUIElement::pathDescription const): Ditto.
3383         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
3384         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
3385         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
3386         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
3387         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
3388         (AccessibilityUIElement::attributesOfChildren): Ditto.
3389         (AccessibilityUIElement::allAttributes): Ditto.
3390         (AccessibilityUIElement::stringAttributeValue): Ditto.
3391         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
3392         (AccessibilityUIElement::role): Ditto.
3393         (AccessibilityUIElement::subrole): Ditto.
3394         (AccessibilityUIElement::roleDescription): Ditto.
3395         (AccessibilityUIElement::computedRoleString): Ditto.
3396         (AccessibilityUIElement::title): Ditto.
3397         (AccessibilityUIElement::description): Ditto.
3398         (AccessibilityUIElement::orientation const): Ditto.
3399         (AccessibilityUIElement::stringValue): Ditto.
3400         (AccessibilityUIElement::language): Ditto.
3401         (AccessibilityUIElement::helpText const): Ditto.
3402         (AccessibilityUIElement::valueDescription): Ditto.
3403         (AccessibilityUIElement::ariaDropEffects const): Ditto.
3404         (AccessibilityUIElement::boundsForRange): Ditto.
3405         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
3406         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
3407         (AccessibilityUIElement::attributesOfColumns): Ditto.
3408         (AccessibilityUIElement::attributesOfRows): Ditto.
3409         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
3410         (AccessibilityUIElement::attributesOfHeader): Ditto.
3411         (AccessibilityUIElement::rowIndexRange): Ditto.
3412         (AccessibilityUIElement::columnIndexRange): Ditto.
3413         (AccessibilityUIElement::selectedTextRange): Ditto.
3414         (AccessibilityUIElement::accessibilityValue const): Ditto.
3415         (AccessibilityUIElement::documentEncoding): Ditto.
3416         (AccessibilityUIElement::documentURI): Ditto.
3417         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
3418         (AccessibilityUIElement::classList const): Ditto.
3419
3420         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
3421         createJSStringRef method to return a JSRetainPtr.
3422         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
3423         (-[NSString createJSStringRef]): Ditto.
3424         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
3425         adopt function instead of the adopt constructor.
3426         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3427         (AccessibilityController::platformName const): Ditto.
3428
3429         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3430         (-[NSString createJSStringRef]): Return a JSRetainPtr.
3431         (makeValueRefForValue): Updated for the above, no adopt needed here now.
3432         (makeObjectRefForDictionary): Ditto.
3433         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
3434
3435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3436         (createEmptyJSString): Added. This helper function makes reduces the
3437         repetitive code to create empty strings.
3438         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
3439         (descriptionOfElements): Ditto.
3440         (selectTextParameterizedAttributeForCriteria): Ditto.
3441         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
3442         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
3443         (AccessibilityUIElement::attributesOfChildren): Ditto.
3444         (AccessibilityUIElement::allAttributes): Ditto.
3445         (AccessibilityUIElement::stringAttributeValue): Ditto.
3446         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
3447         (AccessibilityUIElement::role): Ditto.
3448         (AccessibilityUIElement::subrole): Ditto.
3449         (AccessibilityUIElement::roleDescription): Ditto.
3450         (AccessibilityUIElement::computedRoleString): Ditto.
3451         (AccessibilityUIElement::title): Ditto.
3452         (AccessibilityUIElement::description): Ditto.
3453         (AccessibilityUIElement::orientation const): Ditto.
3454         (AccessibilityUIElement::stringValue): Ditto.
3455         (AccessibilityUIElement::language): Ditto.
3456         (AccessibilityUIElement::helpText const): Ditto.
3457         (AccessibilityUIElement::valueDescription): Ditto.
3458         (AccessibilityUIElement::speakAs): Ditto.
3459         (AccessibilityUIElement::classList const): Ditto.
3460         (AccessibilityUIElement::ariaDropEffects const): Ditto.
3461         (AccessibilityUIElement::rangeForLine): Ditto.
3462         (AccessibilityUIElement::rangeForPosition): Ditto.
3463         (AccessibilityUIElement::boundsForRange): Ditto.
3464         (AccessibilityUIElement::stringForRange): Ditto.
3465         (AccessibilityUIElement::attributedStringForRange): Ditto.
3466         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
3467         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
3468         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
3469         (AccessibilityUIElement::attributesOfColumns): Ditto.
3470         (AccessibilityUIElement::attributesOfRows): Ditto.
3471         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
3472         (AccessibilityUIElement::attributesOfHeader): Ditto.
3473         (AccessibilityUIElement::rowIndexRange): Ditto.
3474         (AccessibilityUIElement::columnIndexRange): Ditto.
3475         (AccessibilityUIElement::pathDescription const): Ditto.
3476         (AccessibilityUIElement::selectedTextRange): Ditto.
3477         (AccessibilityUIElement::accessibilityValue const): Ditto.
3478         (AccessibilityUIElement::documentEncoding): Ditto.
3479         (AccessibilityUIElement::documentURI): Ditto.
3480         (AccessibilityUIElement::url): Ditto.
3481         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
3482         (createJSStringRef): Ditto.
3483         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
3484         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
3485         (AccessibilityUIElement::supportedActions): Ditto.
3486         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
3487         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
3488
3489         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3490         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
3491         Use the adopt function instead of the adopt constructor.
3492         * DumpRenderTree/mac/TestRunnerMac.mm:
3493         (originsArrayToJS): Ditto.
3494         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
3495         (TestRunner::copyEncodedHostName): Ditto.
3496         (TestRunner::pathToLocalResource): Ditto.
3497         (TestRunner::queueLoad): Use adopt function instead of constructor.
3498         (TestRunner::findString): Ditto.
3499         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
3500
3501         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3502         (AccessibilityController::winNotificationReceived): Use adopt function
3503         instead of adopt constructor.
3504         (AccessibilityController::platformName const): Ditto.
3505
3506         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3507         (createEmptyJSString): Added. This helper function makes reduces the
3508         repetitive code to create empty strings.
3509         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
3510         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
3511         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
3512         (AccessibilityUIElement::attributesOfChildren): Ditto.
3513         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
3514         (AccessibilityUIElement::role): Ditto.
3515         (AccessibilityUIElement::subrole): Ditto.
3516         (AccessibilityUIElement::roleDescription): Ditto.
3517         (AccessibilityUIElement::computedRoleString): Ditto.
3518         (AccessibilityUIElement::title): Ditto.
3519         (AccessibilityUIElement::description): Ditto.
3520         (AccessibilityUIElement::stringValue): Ditto.
3521         (AccessibilityUIElement::language): Ditto.
3522         (AccessibilityUIElement::helpText const): Ditto.
3523         (AccessibilityUIElement::valueDescription): Ditto.
3524         (AccessibilityUIElement::ariaDropEffects const): Ditto.
3525         (AccessibilityUIElement::orientation const): Ditto.
3526         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
3527         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
3528         (AccessibilityUIElement::attributesOfColumns): Ditto.
3529         (AccessibilityUIElement::attributesOfRows): Ditto.
3530         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
3531         (AccessibilityUIElement::attributesOfHeader): Ditto.
3532         (AccessibilityUIElement::rowIndexRange): Ditto.
3533         (AccessibilityUIElement::columnIndexRange): Ditto.
3534         (AccessibilityUIElement::boundsForRange): Ditto.
3535         (AccessibilityUIElement::stringForRange): Ditto.
3536         (AccessibilityUIElement::attributedStringForRange): Ditto.
3537         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
3538         (AccessibilityUIElement::selectedTextRange): Ditto.
3539         (AccessibilityUIElement::stringAttributeValue): Ditto.
3540         (AccessibilityUIElement::accessibilityValue const): Ditto.
3541         (AccessibilityUIElement::documentEncoding): Ditto.
3542         (AccessibilityUIElement::documentURI): Ditto.
3543         (AccessibilityUIElement::url): Ditto.
3544         (AccessibilityUIElement::classList const): Ditto.
3545
3546         * DumpRenderTree/win/TestRunnerWin.cpp:
3547         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
3548         (TestRunner::copyEncodedHostName): Ditto.
3549         (TestRunner::pathToLocalResource): Ditto.
3550         (TestRunner::queueLoad): Ditto.
3551         (TestRunner::findString): Ditto.
3552         (TestRunner::inspectorTestStubURL): Ditto.
3553
3554         * TestRunnerShared/Bindings/JSWrapper.h:
3555         (WTR::setProperty): Use adopt function instead of constructor.
3556         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3557         (UIScriptContext::UIScriptContext): Ditto.
3558         (UIScriptContext::runUIScript): Ditto.
3559         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3560         (WTR::toDeviceOrientation): Ditto.
3561
3562         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3563         (nsTextCheckingType): Changed this function to not take an rvalue
3564         reference to a JSRetainPtr since it doesn't take ownership.
3565         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
3566         for the above change.
3567
3568         * TestWebKitAPI/JavaScriptTest.cpp:
3569         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
3570         adopt member function.
3571
3572         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
3573         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
3574         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
3575         adopt constructor.
3576         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
3577
3578         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3579         Removed unneeded includes.
3580         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
3581         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
3582         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
3583
3584         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3585         (_platformTypeConstructor): Use the adopt function instead of the
3586         JSRetainPtr adopt constructor. Also nullptr instead of 0.
3587
3588         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3589         (WTR::arrayLength): Use adopt function instead of constructor.
3590         (WTR::parseModifierArray): Ditto.
3591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3592         (WTR::propertyValue): Ditto.
3593         (WTR::dumpPath): Ditto.
3594         (WTR::toJS): Ditto.
3595         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3596         (WTR::TestRunner::findString): Ditto.
3597         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
3598         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
3599         (WTR::TestRunner::setOpenPanelFiles): Ditto.
3600         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3601         (WTR::AccessibilityController::platformName): Ditto.
3602
3603         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3604         (-[NSString createJSStringRef]): Return a JSRetainPtr.
3605         This fixes storage leaks in many functions below, which were using
3606         the create function and putting the value right into a JSRetainPtr
3607         without adoption.
3608         (WTR::createEmptyJSString): Added. This helper function reduces the
3609         repetitive code to create empty strings.
3610         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
3611         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
3612         Use createEmptyJSString, fixing a storage leak due to missing adoption.
3613         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
3614         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
3615         (WTR::AccessibilityUIElement::allAttributes): Ditto.
3616         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3617         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
3618         (WTR::AccessibilityUIElement::role): Ditto.
3619         (WTR::AccessibilityUIElement::subrole): Ditto.
3620         (WTR::AccessibilityUIElement::roleDescription): Ditto.
3621         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
3622         (WTR::AccessibilityUIElement::title): Ditto.
3623         (WTR::AccessibilityUIElement::orientation const): Ditto.
3624         (WTR::AccessibilityUIElement::language): Ditto.
3625         (WTR::AccessibilityUIElement::valueDescription): Ditto.
3626         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
3627         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
3628         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
3629         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
3630         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3631         Use createEmptyJSString, fixing a storage leak due to missing adoption.
3632         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
3633         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
3634         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
3635         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
3636         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
3637         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
3638         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
3639         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
3640         (WTR::AccessibilityUIElement::documentURI): Ditto.
3641         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
3642         null check.
3643         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3644         Use createEmptyJSString, fixing a storage leak due to missing adoption.
3645
3646         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
3647         Use JSRetainPtr for the return value of createJSStringRef.
3648         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
3649         (-[NSString createJSStringRef]): Ditto.
3650         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
3651         adopt function instead of the adopt constructor.
3652         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3653         (WTR::AccessibilityController::platformName): Ditto
3654
3655         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3656         (-[NSString createJSStringRef]): Return a JSRetainPtr.
3657         (makeValueRefForValue): Updated for above by removing adopt.
3658         (makeObjectRefForDictionary): Ditto.
3659         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
3660
3661         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3662         (WTR::createEmptyJSString): Added. This helper function makes reduces the
3663         repetitive code to create empty strings.
3664         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
3665         (WTR::descriptionOfElements): Ditto.
3666         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
3667         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
3668         fixing a storage leak due to missing adoption.
3669         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
3670         (WTR::AccessibilityUIElement::documentURI): Ditto.
3671         (WTR::createJSStringRef): Return a JSRetainPtr.
3672
3673         * WebKitTestRunner/StringFunctions.h:
3674         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
3675         (WTR::toJS): Use the adopt function instead of the constructor.
3676
3677 2018-09-14  Dean Jackson  <dino@grorg.org>
3678
3679         Add Justin Michaud.
3680
3681         * Scripts/webkitpy/common/config/contributors.json:
3682
3683 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
3684
3685         bots should pass --clobber-old-results to run-webkit-tests
3686         https://bugs.webkit.org/show_bug.cgi?id=189623
3687
3688         Reviewed by Aakash Jain.
3689
3690         In order to ensure that bots to not produce confusing results due to transient execptions,
3691         or run out of space if they continually hit an exception, old layout test results should be clobbered.
3692
3693         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3694         (RunWebKitTests):
3695
3696 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
3697
3698         Unreviewed, rolling out r235954.
3699
3700         Breaks the watchOS build.
3701
3702         Reverted changeset:
3703
3704         "Move IndexedDB to Network Process"
3705         https://bugs.webkit.org/show_bug.cgi?id=189415
3706         https://trac.webkit.org/changeset/235954
3707
3708 2018-09-13  Daniel Bates  <dabates@apple.com>
3709
3710         Add Copy WebKit Permalink plugin for Sublime Text
3711         https://bugs.webkit.org/show_bug.cgi?id=189589
3712
3713         Rubber-stamped by Joseph Pecoraro.
3714
3715         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
3716         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
3717         active document with or without blame annotations.
3718
3719         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
3720         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
3721         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
3722         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
3723         and Command + Shift + Control + Option + C, respectively.
3724
3725         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
3726         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
3727         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
3728         * CopyPermalink/Sublime Text/INSTALL: Added.
3729         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
3730         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
3731         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
3732
3733 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3734
3735         Unreviewed. Fix WebDriver tests after r235225.
3736
3737         Use wpt serve command to run the http server.
3738
3739         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
3740         (WebDriverW3CWebServer.__init__):
3741         (WebDriverW3CWebServer.start):
3742         (WebDriverW3CWebServer.stop):
3743
3744 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3745
3746         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
3747         https://bugs.webkit.org/show_bug.cgi?id=189544
3748
3749         Reviewed by Michael Catanzaro.
3750
3751         Add test cases for the new API.
3752
3753         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3754         (testWebViewJavaScriptDialogs):
3755
3756 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3757
3758         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
3759         https://bugs.webkit.org/show_bug.cgi?id=189496
3760         <rdar://problem/44370981>
3761
3762         Unreviewed warning fix.
3763
3764         r235929 has introduced a new compilation warning:
3765         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
3766
3767         * ImageDiff/cairo/PlatformImageCairo.cpp:
3768         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
3769
3770 2018-09-12  Dan Bernstein  <mitz@apple.com>
3771
3772         [Cocoa] Complete support for Paste as Quotation
3773         https://bugs.webkit.org/show_bug.cgi?id=189504
3774
3775         Reviewed by Wenson Hsieh.
3776
3777         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
3778
3779 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
3780
3781         Move IndexedDB to Network Process
3782         https://bugs.webkit.org/show_bug.cgi?id=189415
3783
3784         Reviewed by Geoffrey Garen.
3785
3786         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
3787         (TEST):
3788         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3789         (TEST):
3790         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
3791         (TEST):
3792         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
3793         (TEST):
3794         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3795         (TEST):
3796
3797 2018-09-12  Chris Dumez  <cdumez@apple.com>
3798
3799         PSON: No process swap on back navigation after URL bar navigation
3800         https://bugs.webkit.org/show_bug.cgi?id=189557
3801         <rdar://problem/44353108>
3802
3803         Reviewed by Alex Christensen.
3804
3805         Add API test coverage.
3806
3807         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3808
3809 2018-09-11  Dean Jackson  <dino@apple.com>
3810
3811         Header parsing for experimental and internal debug features
3812         https://bugs.webkit.org/show_bug.cgi?id=189486
3813         <rdar://problem/44320618>
3814
3815         Reviewed by Tim Horton.
3816
3817         Keep track of experimental and internal debug features in TestOptions, and
3818         allow webkit-test-runner headers to toggle them by name.
3819
3820         * DumpRenderTree/TestOptions.cpp:
3821         (TestOptions::TestOptions):
3822         * WebKitTestRunner/TestController.cpp:
3823         (WTR::TestController::resetPreferencesToConsistentValues):
3824         (WTR::updateTestOptionsFromTestHeader):
3825         * WebKitTestRunner/TestOptions.h:
3826         (WTR::TestOptions::hasSameInitializationOptions const):
3827
3828 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3829
3830         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
3831         https://bugs.webkit.org/show_bug.cgi?id=189492
3832
3833         Reviewed by Alex Christensen.
3834
3835         0 and nullptr can't be implicitly converted to
3836         AccessibilityUIElement because only Windows port typedefs
3837         PlatformUIElement as COMPtr<IAccessible> not a pointer.
3838
3839         Replaced "return 0" and "return nullptr" with "return { nullptr }".
3840
3841         * DumpRenderTree/AccessibilityUIElement.cpp:
3842         (AccessibilityUIElement::horizontalScrollbar const):
3843         (AccessibilityUIElement::verticalScrollbar const):
3844         (AccessibilityUIElement::uiElementAttributeValue const):
3845         (AccessibilityUIElement::accessibilityElementForTextMarker):
3846         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3847         (AccessibilityController::elementAtPoint):
3848         (AccessibilityController::accessibleElementById):
3849         (AccessibilityController::focusedElement):
3850         (AccessibilityController::rootElement):
3851         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3852         (AccessibilityUIElement::elementAtPoint):
3853         (AccessibilityUIElement::linkedUIElementAtIndex):
3854         (AccessibilityUIElement::getChildAtIndex):
3855         (AccessibilityUIElement::titleUIElement):
3856         (AccessibilityUIElement::parentElement):
3857         (AccessibilityUIElement::uiElementForSearchPredicate):
3858         (AccessibilityUIElement::cellForColumnAndRow):
3859         (AccessibilityUIElement::disclosedRowAtIndex):
3860         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3861         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3862         (AccessibilityUIElement::ariaControlsElementAtIndex):
3863         (AccessibilityUIElement::selectedRowAtIndex):
3864         (AccessibilityUIElement::rowAtIndex):
3865         (AccessibilityUIElement::disclosedByRow):
3866         (AccessibilityUIElement::selectedChildAtIndex const):
3867
3868 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3869
3870         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
3871         https://bugs.webkit.org/show_bug.cgi?id=189382
3872
3873         Reviewed by Ryosuke Niwa.
3874
3875         Fix the test by specifying colors in RGB colorspace.
3876
3877         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3878         (TestWebKitAPI::TEST):
3879
3880 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3881
3882         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
3883         https://bugs.webkit.org/show_bug.cgi?id=189496
3884
3885         Reviewed by Alex Christensen.
3886
3887         * ImageDiff/cairo/PlatformImageCairo.cpp:
3888         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
3889         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
3890
3891 2018-09-07  Dean Jackson  <dino@apple.com>
3892
3893         Add and expose Internal features from WebKit
3894         https://bugs.webkit.org/show_bug.cgi?id=189442
3895         <rdar://problem/44243404>
3896
3897         Reviewed by Simon Fraser.
3898
3899         Update MiniBrowser to expose an Internal feature menu.
3900
3901         * MiniBrowser/mac/AppDelegate.m:
3902         (defaultConfiguration):
3903         * MiniBrowser/mac/SettingsController.m:
3904         (-[SettingsController _populateMenu]):
3905         (-[SettingsController validateMenuItem:]):
3906         (-[SettingsController toggleExperimentalFeature:]):
3907         (-[SettingsController toggleInternalDebugFeature:]):
3908
3909 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3910
3911         [macOS] [WK2] Support changing foreground colors via color panel
3912         https://bugs.webkit.org/show_bug.cgi?id=189382
3913         <rdar://problem/44227311>
3914
3915         Reviewed by Ryosuke Niwa.
3916
3917         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
3918         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
3919         colors, as well as making different parts of a word different colors.
3920
3921         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3922         (-[TestWKWebView collapseToEnd]):
3923         (webViewForFontManagerTesting):
3924         (TestWebKitAPI::TEST):
3925         * TestWebKitAPI/cocoa/TestWKWebView.h:
3926
3927 == Rolled over to ChangeLog-2018-09-11 ==