43ed5da6fef85284abeab28b349578fa52e58281
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         W3C test importer should not import reference files as regular tests
4         https://bugs.webkit.org/show_bug.cgi?id=150331
5
6         Reviewed by Darin Adler.
7
8         Updated test_parser to return information that a file can be a referencefile or a manual test.
9         Updated test importer to skip those files.
10         Updated/Added test parser unit tests accordingly.
11
12         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
13         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
14         to mark these files as Skip, since they are not direct tests. 
15
16         * Scripts/webkitpy/w3c/test_importer.py:
17         (TestImporter.__init__):
18         (TestImporter.find_importable_tests):
19         (TestImporter.import_tests):
20         * Scripts/webkitpy/w3c/test_parser.py:
21         (TestParser.analyze_test):
22         * Scripts/webkitpy/w3c/test_parser_unittest.py:
23         (test_analyze_non_html_file):
24         (test_reference_test):
25
26 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
27
28         run-webkit-tests does not copy all crash logs for layout test failures on iOS
29         https://bugs.webkit.org/show_bug.cgi?id=150056
30         <rdar://problem/9280656>
31
32         Reviewed by Alexey Proskuryakov.
33
34         * Scripts/webkitpy/common/system/crashlogs.py:
35         (CrashLogs.find_all_logs): Generic method to find all crash logs.
36         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
37         It iterates through log directory and returns all the logs based on timestamp.
38         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
39         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
40         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
41         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
42         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43         (Manager.run): Modified start_time to start counting before simulator launch
44         so that we can capture crashes during simualator launch.
45         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
46         any test which is not already marked as CRASH to the run_results.
47         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
48         (TestExpectationsModel.get_expectations_string): return PASS in case there
49         are no expectations defined for this test.
50         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
51         (summarize_results): Add other_crashes in a separte category in full_results.json.
52         * Scripts/webkitpy/port/ios.py:
53         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
54         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
55         from the log directory.
56         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
57         logs from log directory and merge them with the list of already crashed tests.
58
59 2015-10-20  Dana Burkart  <dburkart@apple.com>
60
61         Fix the build
62
63         Unreviewed.
64
65         My previous patch was missing a necessary space character.
66
67         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
68
69 2015-10-20  Dana Burkart  <dburkart@apple.com>
70
71         svn-apply fails to apply binary diffs in some cases
72         https://bugs.webkit.org/show_bug.cgi?id=64647
73
74         Reviewed by Daniel Bates.
75
76         * Scripts/VCSUtils.pm:
77         (decodeGitBinaryPatchDeltaSize): Modified.
78         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
79         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
80
81 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
82
83         Mac Debug EWS never finishes when there are failures
84         https://bugs.webkit.org/show_bug.cgi?id=150334
85
86         Reviewed by Daniel Bates.
87
88         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
89         * Scripts/webkitpy/tool/commands/queues.py:
90
91 2015-10-20  Philippe Normand  <pnormand@igalia.com>
92
93         [GTK] Enable OpenWebRTC test video/audio sources in tests
94
95         This is needed because we can't expect the buildbots to have
96         webcam/mic devices plugged in.
97
98         Rubber-stamped by Carlos Garcia Campos.
99
100         * Scripts/run-gtk-tests:
101         (TestRunner._setup_testing_environment):
102         * Scripts/webkitpy/port/gtk.py:
103         (GtkPort.setup_environ_for_server):
104
105 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
106
107         Rename the PICTURE_SIZES flag to CURRENTSRC
108         https://bugs.webkit.org/show_bug.cgi?id=150275
109
110         Reviewed by Dean Jackson.
111
112         * Scripts/webkitperl/FeatureList.pm:
113
114 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
115
116         Unreviewed, add myself to the committers list.
117
118         * Scripts/webkitpy/common/config/contributors.json:
119
120 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
121
122         Add new EWS queues to bot watcher's dashboard
123         https://bugs.webkit.org/show_bug.cgi?id=150297
124
125         Reviewed by Darin Adler.
126
127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
128         (BubbleQueueServer):
129
130 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
131
132         REGRESSION(r190262): User media unit test failures after r190262
133         https://bugs.webkit.org/show_bug.cgi?id=149580
134
135         Reviewed by Carlos Garcia Campos.
136
137         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
138         So we do not need to skip them anymore.
139
140         * Scripts/run-gtk-tests:
141         (TestRunner): Deleted.
142
143 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
144
145         Add historical addresses to contributors.json
146         https://bugs.webkit.org/show_bug.cgi?id=150227
147
148         Reviewed by Darin Adler.
149
150         * Scripts/webkitpy/common/config/contributors.json:
151
152 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
153
154         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
155         https://bugs.webkit.org/show_bug.cgi?id=150307
156
157         Reviewed by Brent Fulgham.
158
159         The DLL build rules have been changed to generate "{Name}Lib.DLL",
160         but these changes have not yet been applied to the Visual Studio builds.
161
162         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
163
164 2015-10-16  Andreas Kling  <akling@apple.com>
165
166         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
167         <https://webkit.org/b/150153>
168
169         Unreviewed.
170
171         Just use simple arrays of LChar and UChar for this test instead of creating String
172         objects and then getting the characters8()/characters16() from them, since that
173         doesn't guarantee null-termination (the bug.)
174
175         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
176         (TestWebKitAPI::TEST):
177         (TestWebKitAPI::build): Deleted.
178
179 2015-10-16  Tim Horton  <timothy_horton@apple.com>
180
181         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
182         https://bugs.webkit.org/show_bug.cgi?id=150255
183
184         Reviewed by Simon Fraser.
185
186         * Scripts/run-api-tests:
187         (runTest):
188         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
189         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
190         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
191         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
192         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
193         Don't set the layout size until after the load finishes and we're waiting
194         for the reply, so that there is no race between the new size coming in
195         and us waiting for it.
196
197 2015-10-16  Anders Carlsson  <andersca@apple.com>
198
199         WebEditingDelegate should be a formal protocol
200         https://bugs.webkit.org/show_bug.cgi?id=150254
201         <rdar://problem/23149847>
202
203         Reviewed by Dan Bernstein.
204
205         * DumpRenderTree/mac/EditingDelegate.h:
206         Conform to the WebEditingDelegate protocol.
207
208 2015-10-16  Tim Horton  <timothy_horton@apple.com>
209
210         Hook up autolayout intrinsic sizing for WKWebView
211         https://bugs.webkit.org/show_bug.cgi?id=150219
212         <rdar://problem/20016905>
213
214         Reviewed by Simon Fraser.
215
216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
217         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
218         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
219         (-[AutoLayoutWKWebView load:expectingContentSize:]):
220         (-[AutoLayoutWKWebView expectContentSizeChange:]):
221         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
222         (TEST):
223         Add a variety of tests, including one which catches the bug that
224         the WebCore part of this patch fixes.
225
226 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
227
228         Update the help message of --system-malloc
229         https://bugs.webkit.org/show_bug.cgi?id=150169
230
231         Reviewed by Geoffrey Garen.
232
233         * Scripts/webkitperl/FeatureList.pm:
234
235 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
236
237         Update ImportExpectations according currently imported wpt tests
238         https://bugs.webkit.org/show_bug.cgi?id=150158
239
240         Reviewed by Chris Dumez.
241
242         * Scripts/webkitpy/w3c/test_downloader.py:
243         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
244
245 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
246
247         Unreviewed, Update my email address.
248
249         * Scripts/webkitpy/common/config/contributors.json:
250
251 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
252
253         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
254         https://bugs.webkit.org/show_bug.cgi?id=84960
255
256         Reviewed by Žan Doberšek.
257
258         * Scripts/run-gtk-tests:
259         (TestRunner): Unskip tests using SessionState.
260         * TestWebKitAPI/PlatformGTK.cmake: Add
261         WKPageCopySessionStateWithFiltering test.
262
263 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
264
265         [GTK] Missing return value on TestWebExtensions.cpp:193
266         https://bugs.webkit.org/show_bug.cgi?id=149755
267
268         Unreviewed. Add missing return value.
269
270         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
271         (permissionRequestCallback):
272
273 2015-10-14  Andy Estes  <aestes@apple.com>
274
275         [iOS] build-dumprendertree does not build ImageDiff
276         https://bugs.webkit.org/show_bug.cgi?id=150152
277
278         Reviewed by Tim Horton.
279
280         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
281         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
282         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
283         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
284
285         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
286         fine on that platform, and results in ImageDiff being built.
287
288         * Scripts/build-dumprendertree:
289
290 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
291
292         [Win] Enforce launcher/library naming scheme
293         https://bugs.webkit.org/show_bug.cgi?id=150124
294
295         Reviewed by Alex Christensen.
296
297         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
298         * MiniBrowser/win/CMakeLists.txt: Ditto.
299         * TestWebKitAPI/PlatformWin.cmake: Ditto.
300         * win/DLLLauncher/DLLLauncherMain.cpp:
301         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
302         original {name}.dll.
303
304 2015-10-14  Andreas Kling  <akling@apple.com>
305
306         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
307         <https://webkit.org/b/150135>
308
309         Reviewed by Geoffrey Garen.
310
311         Add a new WTF API test that covers this issue.
312
313         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
314         (TestWebKitAPI::build):
315         (TestWebKitAPI::TEST):
316
317 2015-10-14  Alex Christensen  <achristensen@webkit.org>
318
319         Add SPI for reloading without content blockers
320         https://bugs.webkit.org/show_bug.cgi?id=150058
321         rdar://problem/22742222
322
323         Reviewed by Sam Weinig.
324
325         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
326         (WTR::TestController::cocoaResetStateToConsistentValues):
327         * WebKitTestRunner/mac/TestControllerMac.mm:
328         (WTR::TestController::platformConfigureViewForTest):
329
330 2015-10-14  Mark Lam  <mark.lam@apple.com>
331
332         Rename some JSC option names to be more uniform.
333         https://bugs.webkit.org/show_bug.cgi?id=150127
334
335         Reviewed by Geoffrey Garen.
336
337         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
338         * Scripts/run-jsc-stress-tests:
339
340 2015-10-14  Anders Carlsson  <andersca@apple.com>
341
342         Change the bundle app cache APIs to take a page
343         https://bugs.webkit.org/show_bug.cgi?id=150123
344
345         Reviewed by Sam Weinig.
346
347         Update APIs.
348
349         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
350         (WTR::InjectedBundle::beginTesting):
351         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
352         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
354         (WTR::TestRunner::clearAllApplicationCaches):
355         (WTR::TestRunner::clearApplicationCacheForOrigin):
356         (WTR::TestRunner::setAppCacheMaximumSize):
357         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
358         (WTR::TestRunner::originsWithApplicationCache):
359
360 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
361
362         Update web-platform-tests tools to the latest revision
363         https://bugs.webkit.org/show_bug.cgi?id=149645
364
365         Reviewed by Darin Adler.
366
367         Disabling git submodules information conversion to json install file for web-platform-tests.
368         Disabling related python unit tests.
369         The tools submodules contain submodules and the conversion tool does not support that yet.
370
371         Updating wpt launcher script to aling it with web-platform-test main script.
372
373         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
374         (main):
375         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
376         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
377         * Scripts/webkitpy/w3c/test_importer_unittest.py:
378         (TestImporterTest.test_submodules_generation):
379
380 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
381
382         More debug queue build fixing.
383
384         Preserve the build style in one more place. Changed mock build_style from "both"
385         to "release", as we don't support testing both debug and release.
386
387         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
388         (MockCommitQueue.archive_last_test_results):
389         (MockCommitQueue):
390         (MockCommitQueue.build_style):
391         (MockCommitQueue.did_pass_testing_ews):
392         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
393         (PatchAnalysisTask._test):
394         (PatchAnalysisTask._build_and_test_without_patch):
395         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
396         (EarlyWarningSystemTest._default_expected_logs):
397         * Scripts/webkitpy/tool/commands/queues_unittest.py:
398
399 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
400
401         More debug queue build fixing.
402
403         Add build_style argument to derived classes as well.
404
405         * Scripts/webkitpy/common/config/ports.py:
406         (MacPort):
407         (MacPort.run_webkit_tests_command):
408         (WinPort.run_bindings_tests_command):
409         (WinPort):
410         (WinPort.run_webkit_tests_command):
411         (GtkWK2Port.build_webkit_command):
412         (GtkWK2Port):
413         (GtkWK2Port.run_webkit_tests_command):
414
415 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
416
417         [iOS] Build fix
418
419         Unreviewed.
420
421         Mach-O section names are limited to 16 characters.
422
423         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
424         * DumpRenderTree/mac/DumpRenderTree.mm:
425         (activateFontsIOS):
426
427 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
428
429         Build fix for mac-debug EWS queue.
430
431         Unreviewed.
432
433         Pass --debug to run-webkit-tests.
434
435         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
436         will need to be substantially modified to work in EWS, so the dummy implementation
437         was not helpful.
438
439         * Scripts/webkitpy/common/config/ports.py:
440         (DeprecatedPort.run_javascriptcore_tests_command):
441         (DeprecatedPort):
442         (DeprecatedPort.run_webkit_tests_command):
443         (DeprecatedPort.run_python_unittests_command):
444         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
445         * Scripts/webkitpy/common/config/ports_mock.py:
446         (MockPort.run_javascriptcore_tests_command):
447         (MockPort):
448         (MockPort.run_webkit_tests_command):
449         (MockPort.run_bindings_tests_command):
450         (MockPort.run_webkit_unit_tests_command): Deleted.
451         * Scripts/webkitpy/tool/commands/download_unittest.py:
452         * Scripts/webkitpy/tool/steps/runtests.py:
453         (RunTests.run):
454         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
455         (RunTestsTest.test_webkit_run_unit_tests):
456         * Scripts/webkitpy/tool/steps/steps_unittest.py:
457         (StepsTest.test_runtests_args):
458
459 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
460
461         [Win] Generate Crash Traces
462         https://bugs.webkit.org/show_bug.cgi?id=150103
463
464         Reviewed by Daniel Bates.
465
466         We were using an exception filter to try to emit "#CRASHED" to stderr
467         when a test program crashed. However, the modern Python implementation
468         seems capable of recognizing crashes on its own. Furthermore, registering
469         the exception handler was preventing the JIT debugger (NTSD) from
470         automatically attaching to the crashing program, so we were not getting
471         crash traces.
472         
473         * DumpRenderTree/win/DumpRenderTree.cpp:
474         (main): Don't register an exception filter.
475         (exceptionFilter): Deleted.
476         * Scripts/webkitpy/common/system/crashlogs.py:
477         (CrashLogs): Add another regular expression to handle a second crash trace
478         syntax I encountered during testing.
479         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
480         try the new one. The PID found by the new expression is in hexadecimal, so
481         convert it to an integer before returning it.
482         * Scripts/webkitpy/port/driver.py:
483         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
484         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
485         check for "#CRASHED" after stripping off the EOL characters.
486         * Scripts/webkitpy/port/win.py:
487         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
488         invocation. This is apparently used to signal an event when the debugger is finished.
489
490 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
491
492         Mac Debug and 32-bit queues should be separate
493         https://bugs.webkit.org/show_bug.cgi?id=150092
494
495         Reviewed by Lucas Forschler.
496
497         * QueueStatusServer/config/queues.py:
498         * QueueStatusServer/model/queues.py:
499         (Queue._capitalize_after_dash):
500         (Queue._caplitalize_after_dash): Deleted.
501         * Scripts/webkitpy/common/config/ews.json:
502
503 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
504
505         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
506         https://bugs.webkit.org/show_bug.cgi?id=150085
507
508         Reviewed by Carlos Garcia Campos.
509
510         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
511
512 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
513
514         Unreviewed, add myself to the committers list.
515
516         * Scripts/webkitpy/common/config/contributors.json:
517
518 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
519
520         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
521         https://bugs.webkit.org/show_bug.cgi?id=149983
522
523         Reviewed by Dan Bates.
524
525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
526         (BubbleQueueServer):
527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
528
529 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
530
531         Fix webkitpy tests after r190922.
532
533         * Scripts/webkitpy/common/config/ews.json:
534         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
535         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
536
537 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
538
539         Add a Mac debug EWS queue
540         https://bugs.webkit.org/show_bug.cgi?id=150069
541
542         Reviewed by Geoffrey Garen.
543
544         * QueueStatusServer/config/queues.py:
545         * Scripts/webkitpy/common/config/ews.json:
546         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
547         (AbstractEarlyWarningSystem):
548         (AbstractEarlyWarningSystem.archive_last_test_results):
549         (AbstractEarlyWarningSystem.build_style):
550         (AbstractEarlyWarningSystem.refetch_patch):
551         (AbstractEarlyWarningSystem.load_ews_classes):
552
553 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
554
555         [GTK] Update jhbuild's version of harfbuzz
556         https://bugs.webkit.org/show_bug.cgi?id=149749
557
558         Reviewed by Martin Robinson.
559
560         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
561
562         * gtk/jhbuild.modules: Updated details for harfbuzz.
563
564 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
565
566         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
567         https://bugs.webkit.org/show_bug.cgi?id=150026
568
569         Reviewed by Philippe Normand.
570
571         Backport upstream patch from gst-plugins-bad so that the right version
572         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
573         gets compiled properly, avoiding crashes on runtime while running tests.
574
575         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
576         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
577
578 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
579
580         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
581         https://bugs.webkit.org/show_bug.cgi?id=149777
582
583         Reviewed by Simon Fraser.
584
585         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
586         to the list of tests to preinstall at startup time.
587
588         Also, update the generation of the 'name' table in the FontWithFeatures font.
589
590         * DumpRenderTree/mac/DumpRenderTree.mm:
591         (allowedFontFamilySet):
592         (activateTestingFonts):
593         (activateFontsIOS):
594         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
595         (Generator::generate):
596         (Generator::appendCFFTable):
597         (Generator::appendNameSubtable):
598         (Generator::appendNAMETable):
599         * FontWithFeatures/FontWithFeatures/main.cpp:
600         (main):
601         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
602         (WTR::allowedFontFamilySet):
603         (WTR::activateFonts):
604         * WebKitTestRunner/mac/TestControllerMac.mm:
605         (WTR::allowedFontFamilySet):
606
607 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
608
609         Unreviewed. Add Jinyoung Hur as a committer. 
610
611         * Scripts/webkitpy/common/config/contributors.json:
612
613 2015-10-10  Dan Bernstein  <mitz@apple.com>
614
615         [iOS] Remove unnecessary iOS version checks
616         https://bugs.webkit.org/show_bug.cgi?id=150002
617
618         Reviewed by Alexey Proskuryakov.
619
620         * WebKitTestRunner/ios/HIDEventGenerator.mm:
621         (-[HIDEventGenerator _createIOHIDEventType:]):
622         (-[HIDEventGenerator _sendHIDEvent:]):
623         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
624         * WebKitTestRunner/ios/UIKitSPI.h:
625
626 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
627
628         Unreviewed, rolling out r190689
629         https://bugs.webkit.org/show_bug.cgi?id=149992
630
631         Fixed in other repository.
632
633         Reverted changesets:
634
635         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
636         https://bugs.webkit.org/show_bug.cgi?id=149897
637
638 2015-10-09  Brian Burg  <bburg@apple.com>
639
640         Teach webkitperl how to figure out IOS versions from the SDK
641         https://bugs.webkit.org/show_bug.cgi?id=149963
642
643         Reviewed by Daniel Bates.
644
645         It should be easier to check the major and minor version of IOS SDKs.
646
647         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
648         * Scripts/webkitdirs.pm:
649         (splitVersionString): Added.
650         (determineOSXVersion): Use splitVersionString.
651         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
652         (iosVersion): Added.
653
654 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
655
656         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
657         https://bugs.webkit.org/show_bug.cgi?id=149960
658
659         Reviewed by Tim Horton.
660         
661         Use adoptWK(), and null out some members (file is not using ARC).
662
663         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
664         (UIScriptContext::uiScriptComplete):
665         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
666         (-[TestRunnerWKWebView dealloc]):
667
668 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
669
670         Remove ENABLE_SUID_SANDBOX_LINUX cruft
671         https://bugs.webkit.org/show_bug.cgi?id=149954
672
673         Reviewed by Darin Adler.
674
675         * Scripts/webkitperl/FeatureList.pm:
676
677 2015-10-09  Daniel Bates  <dabates@apple.com>
678
679         Make iOS builders generate debug information in a separate dSYM file
680         https://bugs.webkit.org/show_bug.cgi?id=149696
681
682         Reviewed by Darin Adler.
683
684         Similar to the Mac builders, the iOS builders should write debug information
685         into a separate dSYM file instead of including such information in the binary
686         itself (default Xcode behavior)
687
688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
689         (CompileWebKit.start):
690
691 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
692
693         Fix webkitpy tests after r190779
694         https://bugs.webkit.org/show_bug.cgi?id=149949
695
696         Reviewed by Ryosuke Niwa.
697
698         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
699         (BenchmarkResults.format):
700         (BenchmarkResults._format_values):
701
702 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
703
704         Extend run-benchmark script to support human-readable results conversion.
705         https://bugs.webkit.org/show_bug.cgi?id=149944
706
707         Reviewed by Ryosuke Niwa.
708
709         Add '--read-results-json' and '--no-adjust-unit' options.
710         '--read-results-json' option converts result file to human readable format.
711         '--no-adjust-unit' option skips scientific notation convertion.
712         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
713
714         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
715         (BenchmarkResults.format):
716         (BenchmarkResults._format_tests):
717         (BenchmarkResults._format_values):
718         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
719         (BenchmarkRunner.__init__):
720         (BenchmarkRunner._run_benchmark):
721         (BenchmarkRunner._dump):
722         (BenchmarkRunner.show_results):
723         (BenchmarkRunner._show_results): Deleted.
724         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
725         (parse_args):
726         (start):
727
728 2015-10-08  Daniel Bates  <dabates@apple.com>
729
730         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
731         https://bugs.webkit.org/show_bug.cgi?id=149945
732
733         Reviewed by Dan Bernstein.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
739         (WebKitBuildbot):
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
741         (table.queue-grid tr.platform.ios-9 img.logo):
742
743 2015-10-08  Daniel Bates  <dabates@apple.com>
744
745         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
746         https://bugs.webkit.org/show_bug.cgi?id=149943
747
748         Reviewed by Dan Bernstein.
749
750         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
751         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
752
753         * Scripts/build-webkit:
754
755 2015-10-08  Daniel Bates  <dabates@apple.com>
756
757         Add LLVM binaries for iOS 9 device
758         https://bugs.webkit.org/show_bug.cgi?id=149913
759
760         Reviewed by Filip Pizlo.
761
762         Implement support for building LLVM for ARM64-based iOS devices.
763
764         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
765         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
766         an existing build earlier in the file such that remove previously built
767         libraries before building/copying new ones (if applicable).
768         (fileContains): Moved function outside of if-block.
769         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
770         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
771         added logic to build LLVM for ARM64-based iOS devices.
772         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
773         LLVM into the WebKitBuild directory.
774
775 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
776
777         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
778         https://bugs.webkit.org/show_bug.cgi?id=149848
779
780         Reviewed by Darin Adler.
781
782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
783
784 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
785
786         [Win] Support 64-bit Build and Testing
787         https://bugs.webkit.org/show_bug.cgi?id=149904
788
789         Reviewed by Daniel Bates.
790
791         Extend our existing scripts to support 64-bit build and test operations on
792         Windows.
793
794         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
795         Windows always builds the whole stack.
796         * Scripts/webkit-build-directory: Add an option to return the location of
797         the executable files produced by a specific configuration. This change is
798         actually useful for Gtk and EFL, too.
799         * Scripts/webkitdirs.pm:
800         (executableProductDir): Added. This function appends the proper binary
801         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
802         (jscProductDir): Use the new 'executableProductDir' method.
803         (setPathForRunningWebKitApp): Ditto.
804         (runSafari): Ditto.
805         (runMiniBrowser): Ditto.
806         * Scripts/webkitpy/port/factory.py:
807         (configuration_options): Add a 64-bit option, used on Windows to specify
808         which binary target should be used for testing.
809         * Scripts/webkitpy/port/win.py:
810         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
811         processes when needed.
812         (WinPort._build_path): Add the correct binary target path to _build_path.
813         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
814         64-bit paths for 64-bit tests.
815         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
816         NTSD debugger does not understand this argument.
817
818 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
819
820         Test font-variant-* and font-feature-settings with TrueType fonts
821         https://bugs.webkit.org/show_bug.cgi?id=149776
822
823         Reviewed by Simon Fraser.
824
825         This test extends our existing FontWithFeatures project to be able to generate a
826         TrueType font. This font is conceptually similar as the existing OpenType font,
827         except the feature -> character mapping is different.
828
829         The font itself only supports the following characters:
830         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
831         However, the shape of these letters are either an X or a check mark.
832         The letter "A" always is a check mark.
833         The letter "B" always is an X.
834         Each font feature has an letter associated with it. When the font feature is enabled,
835         that letter is shown as a check mark. For example, when
836         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
837         mark.
838
839         Here are the mappings of font features to letters:
840         kLigaturesType / kCommonLigaturesOnSelector: C
841         kLigaturesType / kContextualLigaturesOnSelector: D
842         kLigaturesType / kRareLigaturesOnSelector: G
843         kLigaturesType / kHistoricalLigaturesOnSelector: I
844         kContextualAlternatesType / kContextualAlternatesOnSelector: L
845         kVerticalPositionType / kInferiorsSelector: O
846         kVerticalPositionType / kSuperiorsSelector: P
847         kLowerCaseType / kLowerCaseSmallCapsSelector: S
848         kUpperCaseType / kUpperCaseSmallCapsSelector: V
849         kLowerCaseType / kLowerCasePetiteCapsSelector: T
850         kUpperCaseType / kUpperCasePetiteCapsSelector: W
851         kLetterCaseType / 14: Y
852         kStyleOptionsType / kTitlingCapsSelector: a
853         kNumberCaseType / kUpperCaseNumbersSelector: c
854         kNumberCaseType / kLowerCaseNumbersSelector: d
855         kNumberSpacingType / kProportionalNumbersSelector: f
856         kNumberSpacingType / kMonospacedNumbersSelector: g
857         kFractionsType / kDiagonalFractionsSelector: i
858         kFractionsType / kVerticalFractionsSelector: j
859         kVerticalPositionType / kOrdinalsSelector: Q
860         kTypographicExtrasType / kSlashedZeroOnSelector: k
861         kLigaturesType / kHistoricalLigaturesOnSelector: K
862         kCharacterShapeType / kJIS1978CharactersSelector: m
863         kCharacterShapeType / kJIS1983CharactersSelector: n
864         kCharacterShapeType / kJIS1990CharactersSelector: o
865         kCharacterShapeType / kJIS2004CharactersSelector: p
866         kCharacterShapeType / kSimplifiedCharactersSelector: q
867         kCharacterShapeType / kTraditionalCharactersSelector: r
868         kTextSpacingType / kMonospacedTextSelector: t
869         kTextSpacingType / kProportionalTextSelector: u
870         kRubyKanaType / kRubyKanaOnSelector: v
871
872         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
873         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
874         (CFFBuilder::moveTo):
875         (CFFBuilder::lineTo):
876         (GLYFBuilder::GLYFBuilder):
877         (GLYFBuilder::takeResult):
878         (GLYFBuilder::moveTo):
879         (GLYFBuilder::lineTo):
880         (GLYFBuilder::closePath):
881         (GLYFBuilder::writePoint):
882         (GLYFBuilder::append16):
883         (generateBoxCharString):
884         (generateCheckCharString):
885         (generateXCharString):
886         (itemForGlyph):
887         (Generator::generate):
888         (Generator::insertSelector):
889         (Generator::insertFeature):
890         (Generator::generateFeatureDescription):
891         (Generator::appendCFFTable):
892         (Generator::appendGLYFTable):
893         (Generator::appendLOCATable):
894         (Generator::appendFEATTable):
895         (Generator::appendMetamorphosisChain):
896         (Generator::appendMORXTable):
897         (Generator::appendHEADTable):
898         (Generator::appendHMTXTable):
899         (Generator::appendNameSubtable):
900         (Generator::append2ByteASCIIString):
901         (Generator::appendNAMETable):
902         (generateFont):
903         (CFFBuilder::curveToCubic): Deleted.
904         (charStringForGlyph): Deleted.
905         * FontWithFeatures/FontWithFeatures/FontCreator.h:
906         * FontWithFeatures/FontWithFeatures/main.cpp:
907         (constructFontWithTrueTypeFeature):
908         (constructFontWithOpenTypeFeature):
909         (drawText):
910         (main):
911         (drawTextWithFeature): Deleted.
912
913 2015-10-07  Commit Queue  <commit-queue@webkit.org>
914
915         Unreviewed, rolling out r190572, r190593, r190594, and
916         r190639.
917         https://bugs.webkit.org/show_bug.cgi?id=149897
918
919         Breaks Mavericks build (Requested by litherum on #webkit).
920
921         Reverted changesets:
922
923         "Allow WKRetainPtrs to be used as keys in hashing data
924         structures"
925         https://bugs.webkit.org/show_bug.cgi?id=149762
926         http://trac.webkit.org/changeset/190572
927
928         "REGRESSION(189668?): http/tests/notifications/events.html
929         flakily asserts or times out"
930         https://bugs.webkit.org/show_bug.cgi?id=149218
931         http://trac.webkit.org/changeset/190593
932
933         "Prospective Mavericks build fix."
934         http://trac.webkit.org/changeset/190594
935
936         "Post-review cleanup after r190572."
937         http://trac.webkit.org/changeset/190639
938
939 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
940
941         [GTK] Add autocleanups
942         https://bugs.webkit.org/show_bug.cgi?id=149588
943
944         Reviewed by Darin Adler.
945
946         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
947         (AutocleanupsTest::create):
948         (AutocleanupsTest::testWebProcessAutocleanups):
949         (registerTests):
950         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
951         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
952         (testUIProcessAutocleanups):
953         (testWebProcessAutocleanups):
954         (beforeAll):
955         (afterAll):
956
957 2015-10-06  Brian Burg  <bburg@apple.com>
958
959         Unreviewed, try to fix the iOS 8 build after r190368.
960
961         On older versions, IOHIDEventCreateForceEvent is not available.
962
963         * WebKitTestRunner/ios/HIDEventGenerator.mm:
964         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
965
966 2015-10-06  Keith Miller  <keith_miller@apple.com>
967
968         Add gmalloc option to run-javascriptcore-tests.
969         https://bugs.webkit.org/show_bug.cgi?id=149858
970
971         Reviewed by Geoffrey Garen.
972
973         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
974         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
975
976         * Scripts/run-javascriptcore-tests:
977
978 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
979
980         Post-review cleanup after r190572.
981
982         Unreviewed.
983
984         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
985
986 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
987
988         [Win] Unreviewed build correction.
989
990         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
991         are soft-linked at runtime.
992
993 2015-10-06  Keith Miller  <keith_miller@apple.com>
994
995         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
996         https://bugs.webkit.org/show_bug.cgi?id=149815
997
998         Reviewed by Filip Pizlo.
999
1000         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1001         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1002         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1003         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1004         so should just use one test runner.
1005
1006         * Scripts/run-javascriptcore-tests:
1007         (runJSCStressTests):
1008         (runMozillaTests): Deleted.
1009         (defaultJsDriverArgsForMozillaTests): Deleted.
1010         * Scripts/run-jsc-stress-tests:
1011
1012 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1013
1014         [GTK] Make update-webkitgtk-libs work behind firewall
1015
1016         update-webkitgtk-libs can work behind a firewall with changes to
1017         a few packages.  Where outbound git and active FTP connections
1018         fail, using http protocol succeeds.  Most packages are
1019         already accessed using http.
1020
1021         https://bugs.webkit.org/show_bug.cgi?id=148941
1022
1023         Reviewed by Martin Robinson.
1024
1025         Tools
1026         * gtk/jhbuild.modules:
1027             Replace git URLs with http.  Remove no longer used ftp repositories.
1028             Update argument for libxml2's autogen.sh script (--without-python
1029             is ignored; --with-python=no is correct).
1030         * jhbuild/jhbuild-wrapper:
1031             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1032             http://git.gnome.org/browse/jhbuild.
1033
1034 2015-10-06  Daniel Bates  <dbates@webkit.org>
1035
1036         Enable XSLT when building WebKit for iOS using the public iOS SDK
1037         https://bugs.webkit.org/show_bug.cgi?id=149827
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1042         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1043         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1044         headers cannot be found.
1045
1046         * Scripts/configure-xcode-for-ios-development:
1047         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1048
1049 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1050
1051         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1052         https://bugs.webkit.org/show_bug.cgi?id=149218
1053
1054         Reviewed by Alexey Proskuryakov.
1055
1056         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1057         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1058         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1059         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1060         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1061         WebNotificationProvider must be updated to appropriately handle multiple
1062         WKNotificationManagerRefs in flight at the same time.
1063
1064         * WebKitTestRunner/WebNotificationProvider.cpp:
1065         (WTR::WebNotificationProvider::~WebNotificationProvider):
1066         (WTR::WebNotificationProvider::showWebNotification):
1067         (WTR::WebNotificationProvider::closeWebNotification):
1068         (WTR::WebNotificationProvider::addNotificationManager):
1069         (WTR::WebNotificationProvider::removeNotificationManager):
1070         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1071         (WTR::WebNotificationProvider::reset):
1072         * WebKitTestRunner/WebNotificationProvider.h:
1073
1074 2015-10-05  Daniel Bates  <dabates@apple.com>
1075
1076         Disable Bitcode when building for iOS device
1077         https://bugs.webkit.org/show_bug.cgi?id=149818
1078
1079         Reviewed by Alexey Proskuryakov.
1080
1081         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1082         when building for iOS device.
1083
1084         * Scripts/webkitdirs.pm:
1085         (XcodeOptions):
1086
1087 2015-10-05  Daniel Bates  <dabates@apple.com>
1088
1089         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1090         https://bugs.webkit.org/show_bug.cgi?id=140828
1091         <rdar://problem/19520599>
1092
1093         Reviewed by Alexey Proskuryakov.
1094
1095         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1096         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1097         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1098         to build-webkit.
1099
1100         * Scripts/webkitdirs.pm:
1101         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1102         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1103         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1104         (hasIOSDevelopmentCertificate): Added.
1105
1106 2015-10-05  Daniel Bates  <dabates@apple.com>
1107
1108         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1109         https://bugs.webkit.org/show_bug.cgi?id=149766
1110
1111         Reviewed by Alexey Proskuryakov.
1112
1113         Create network storage testing session on iOS.
1114
1115         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1116         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1117         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1118         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1119         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1120         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1121         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1122         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1123         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1124
1125         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1126         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1127         returns a non-null pointer to a cookie store.
1128
1129         * DumpRenderTree/mac/DumpRenderTree.mm:
1130         (prepareConsistentTestingEnvironment):
1131
1132 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1133
1134         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1135         available.
1136
1137         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1138         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1139
1140 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1141
1142         Allow WKRetainPtrs to be used as keys in hashing data structures
1143         https://bugs.webkit.org/show_bug.cgi?id=149762
1144
1145         Reviewed by Anders Carlsson.
1146
1147         * TestWebKitAPI/PlatformGTK.cmake:
1148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1149         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1150         (TestWebKitAPI::TEST):
1151
1152 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1153
1154         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1155         available, and tidy up the #ifdefs in the UIKitSPI header.
1156
1157         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1158         (-[HIDEventGenerator _sendHIDEvent:]):
1159         * WebKitTestRunner/ios/UIKitSPI.h:
1160
1161 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1162
1163         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1164         https://bugs.webkit.org/show_bug.cgi?id=149792
1165
1166         Reviewed by Martin Robinson.
1167
1168         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1169         for WebKitTestRunner multiple times.
1170
1171 2015-10-04  Daniel Bates  <dabates@apple.com>
1172
1173         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1174         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1175
1176         For now, support calling build-layouttestrelay without --ios-simulator so long
1177         as we are building on a Mac.
1178
1179         * Scripts/build-layouttestrelay:
1180
1181 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1182
1183         Support Trac 1.0.x XML timeline link format
1184         https://bugs.webkit.org/show_bug.cgi?id=149786
1185
1186         Reviewed by Lucas Forschler.
1187
1188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1189         (Trac.prototype._convertCommitInfoElementToObject):
1190
1191 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1192
1193         Fix some errors on bot watcher's dashboard
1194         https://bugs.webkit.org/show_bug.cgi?id=149789
1195
1196         Reviewed by Lucas Forschler.
1197
1198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1199         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1200         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1201
1202 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1203
1204         Bot watcher's dashboard builders should turn yellow when svn fails
1205         https://bugs.webkit.org/show_bug.cgi?id=149791
1206
1207         Reviewed by Lucas Forschler.
1208
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1210         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1211         (BuildbotBuilderQueueView.prototype.update):
1212
1213 2015-10-02  Daniel Bates  <dabates@apple.com>
1214
1215         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1216         https://bugs.webkit.org/show_bug.cgi?id=149769
1217
1218         Reviewed by Alexey Proskuryakov.
1219
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1224         (WebKitBuildbot):
1225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1226         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1227
1228 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1229
1230         REGRESSION(r190370): Speedometer spits out an extra console message
1231         https://bugs.webkit.org/show_bug.cgi?id=149720
1232
1233         Unreviewed. Temporarily ignore the console error message.
1234
1235         * Scripts/webkitpy/performance_tests/perftest.py:
1236         (PerfTest._filter_output):
1237
1238 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1239
1240         Provide "--no-ninja" option to avoid using Ninja
1241         https://bugs.webkit.org/show_bug.cgi?id=149757
1242
1243         Reviewed by Alex Christensen.
1244
1245         Add a new command line argument understood by webkitdirs.pm so
1246         that we can conditionally avoid using Ninja. This is an
1247         'opt-out' argument, so no existing Ninja users should be affected.
1248         
1249         * Scripts/webkitdirs.pm:
1250         (canUseNinja): Check for option and block ninja if present.
1251
1252 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1253
1254         Flakiness dashboard should support OS X El Capitan
1255         https://bugs.webkit.org/show_bug.cgi?id=149648
1256
1257         Reviewed by Alexey Proskuryakov.
1258
1259         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1260
1261 2015-10-02  Daniel Bates  <dabates@apple.com>
1262
1263         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1264         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1265
1266         For now, pass --ios-simulator.
1267
1268         * Scripts/webkitpy/port/ios.py:
1269         (IOSSimulatorPort._build_relay):
1270
1271 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1272
1273         Remove a "nullable" that breaks the iOS 8 build.
1274
1275         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1276         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1277
1278 2015-10-02  Daniel Bates  <dabates@apple.com>
1279
1280         LayoutTestRelay is not built and archived when building for iOS Simulator
1281         https://bugs.webkit.org/show_bug.cgi?id=149753
1282
1283         Reviewed by Alexey Proskuryakov and Andy Estes.
1284
1285         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1286         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1287         product archive when building for iOS Simulator, respectively.
1288
1289         * BuildSlaveSupport/built-product-archive:
1290         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1291         differentiate between iOS device and iOS Simulator platforms.
1292         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1293         from determineWebKitBuildDirectories() into this function so that it can be used by both
1294         determineWebKitBuildDirectories() and archiveBuiltProduct().
1295         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1296         webkitBuildDirectoryForConfigurationAndPlatform().
1297         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1298         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1299         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1300         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1301         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1302         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1303         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1304         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1305         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1306         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1307         * Scripts/build-layouttestrelay:
1308             - Remove unnecessary include of Perl module POSIX.
1309             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1310         * Scripts/build-webkit:
1311             - Invoke script build-layouttestrelay when building for iOS Simulator.
1312
1313 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1314
1315         [Win] Unreviewed test fix.
1316
1317         You cannot run 'run-webkit-tests' from the command line because it does not know
1318         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1319         because they explicitly set use the 'root' argument to provide the full path to
1320         the test binaries.
1321
1322         * Scripts/webkitpy/port/win.py:
1323         (WinPort._build_path): Added.
1324
1325 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1326
1327         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1328         https://bugs.webkit.org/show_bug.cgi?id=149430
1329         rdar://problem/22742222
1330
1331         Reviewed by Geoffrey Garen.
1332
1333         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1334         (WTR::TestController::cocoaResetStateToConsistentValues):
1335         * WebKitTestRunner/mac/TestControllerMac.mm:
1336         (WTR::TestController::platformConfigureViewForTest):
1337         Test what happens when you disable content blockers from the SPI.
1338
1339 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1340
1341         [Win] Unreviewed build fix for run-api-tests
1342
1343         * Scripts/run-api-tests:
1344         (testToolPaths): Windows run needs to specify the binary path.
1345
1346 2015-10-01  Daniel Bates  <dabates@apple.com>
1347
1348         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1349         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1350
1351         Following r190424 we can now rely on webkit-build-directory to return the path to
1352         the correct configuration-specific build directory on Windows.
1353
1354         * BuildSlaveSupport/built-product-archive:
1355         (archiveBuiltProduct):
1356
1357 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1358
1359         [Win] Unreviewed build fix.
1360
1361         * Scripts/webkitdirs.pm:
1362         (setupAppleWinEnv): Use 64-bit build tools if available
1363
1364 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1365
1366         [Win] Fix TestWebKitAPI build under CMake.
1367
1368         Reviewed by Alex Christensen.
1369
1370         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1371         for Psapi.lib.
1372
1373 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1374
1375         [Win] Fix behavior of webkit-build-directory script
1376         https://bugs.webkit.org/show_bug.cgi?id=149718
1377
1378         Reviewed by Alex Christensen.
1379
1380         * Scripts/webkitdirs.pm:
1381         (determineConfigurationProductDir): Do not include the binary
1382         sub-directory in the configuration product directory output.
1383         (jscProductDir): Append correct binary path for Windows build.
1384         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1385         (runSafari): Update for revised productDir behavior.
1386         (runMiniBrowser): Ditto.
1387
1388 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1389
1390         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1391         use iOS SDK, like with all the others.
1392
1393         * Scripts/build-webkit:
1394
1395 2015-10-01  Daniel Bates  <dabates@apple.com>
1396
1397         Attempt to fix the iOS 9 Simulator testers
1398
1399         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1400         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1401         LayoutTestRelay when building for iOS Simulator.
1402
1403         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1404         * Scripts/build-webkit:
1405
1406 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1407
1408         [GTK] Websites with invalid auth header keep loading forever
1409         https://bugs.webkit.org/show_bug.cgi?id=149710
1410
1411         Reviewed by Martin Robinson.
1412
1413         Add test case to check that we can authenticate sites with an
1414         empty realm.
1415
1416         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1417         (testWebViewAuthenticationEmptyRealm):
1418         (serverCallback):
1419         (beforeAll):
1420
1421 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1422
1423         [Mac] Make run-api-tests work with System Integrity Protection
1424         https://bugs.webkit.org/show_bug.cgi?id=149711
1425         rdar://problem/22928202
1426
1427         Reviewed by Dan Bernstein.
1428
1429         * Scripts/run-api-tests:
1430         (runTest):
1431         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1432
1433 2015-10-01  Daniel Bates  <dabates@apple.com>
1434
1435         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1436         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1437
1438         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1439         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1440         specific build directory.
1441
1442         * BuildSlaveSupport/built-product-archive:
1443         (archiveBuiltProduct):
1444
1445 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1446
1447         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1448         https://bugs.webkit.org/show_bug.cgi?id=145837
1449
1450         Reviewed by Philippe Normand.
1451
1452         * efl/jhbuild.modules:
1453         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1454         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1455
1456 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1457
1458         Unreviewed. Fix the iOS build after r190407.
1459
1460         * WebKitTestRunner/ios/IOKitSPI.h:
1461
1462 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1463
1464         Implement keyboard event sending for iOS in WebKitTestRunner
1465         https://bugs.webkit.org/show_bug.cgi?id=149676
1466
1467         Reviewed by Simon Fraser.
1468
1469         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1470         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1471         allows us to run code when the keyboard is shown or hidden.
1472
1473         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1474         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1475         (WTR::UIScriptController::setDidShowKeyboardCallback):
1476         (WTR::UIScriptController::didShowKeyboardCallback):
1477         (WTR::UIScriptController::setDidHideKeyboardCallback):
1478         (WTR::UIScriptController::didHideKeyboardCallback):
1479         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1480         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1481         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1482         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1483         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1484         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1485         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1486                 the notifications that the keyboard has been raised or lowered.
1487         (-[TestRunnerWKWebView _keyboardDidShow:]):
1488         (-[TestRunnerWKWebView _keyboardDidHide:]):
1489         * WebKitTestRunner/ios/HIDEventGenerator.h:
1490         * WebKitTestRunner/ios/HIDEventGenerator.m:
1491         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1492         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1493         (hidUsageCodeForCharacter): Ditto.
1494         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1495                 a keyDown event in WebKit.
1496         * WebKitTestRunner/ios/IOKitSPI.h:
1497         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1498
1499 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1500
1501         Unreviewed, rolling out r190399.
1502
1503         Tests are still failing even after r190362
1504
1505         Reverted changeset:
1506
1507         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1508         http://trac.webkit.org/changeset/190399
1509
1510 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1511
1512         [jhbuild] switch to new upstream usrsctp library
1513         https://bugs.webkit.org/show_bug.cgi?id=149494
1514
1515         Reviewed by Philippe Normand.
1516
1517         * efl/jhbuild.modules:
1518         * gtk/jhbuild.modules:
1519
1520 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1521
1522         Unreviewed. Unskip GTK+ user media unit tests after r190362.
1523
1524         They should pass now.
1525
1526         * Scripts/run-gtk-tests:
1527         (TestRunner):
1528
1529 2015-09-30  Daniel Bates  <dabates@apple.com>
1530
1531         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1532         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1533
1534         * BuildSlaveSupport/built-product-archive:
1535         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1536         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1537
1538 2015-09-30  Daniel Bates  <dabates@apple.com>
1539
1540         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1541         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1542
1543         Actually, we need to pass --configuration to script webkit-build-directory to have
1544         it return the path to the configuration-specific build directory.
1545
1546         * BuildSlaveSupport/built-product-archive:
1547         (determineWebKitBuildDirectories):
1548
1549 2015-09-30  Daniel Bates  <dabates@apple.com>
1550
1551         built-product-archive archives incorrect build directory for iOS port
1552         https://bugs.webkit.org/show_bug.cgi?id=149695
1553
1554         Reviewed by Darin Adler.
1555
1556         Fixes an issue where the script built-product-archive archives a non-existent
1557         build directory for the iOS port. Without loss of generality, the script assumes
1558         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1559         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1560
1561         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1562         to determine the top-level build directory and computes the configuration-specific
1563         build directory to be the concatenation of the the top-level build directory and
1564         the configuration (e.g. Release). This is incorrect. Instead we should call
1565         webkit-build-directory omitting the flag --top-level to compute the path to the
1566         configuration-specific build directory.
1567
1568         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1569         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1570         its purpose and added global variable _configurationBuildDirectory to store the path
1571         to the configuration-specific build directory. Ensure that we have a non-empty string
1572         for both the top-level and configuration-specific build directories.
1573         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1574         Compute the configuration-specific build directory and store it in the global variable
1575         _configurationBuildDirectory.
1576         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1577         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1578         as needed.
1579         (determineWebKitBuildDirectory): Deleted.
1580
1581 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
1582
1583         [EFL] css3/device-adapt/* tests failed after r190335.
1584         https://bugs.webkit.org/show_bug.cgi?id=149655
1585
1586         Reviewed by Simon Fraser.
1587
1588         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1589         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1590
1591         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1592         (WTR::shouldUseFixedLayout):
1593
1594 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
1595
1596         Extend JetStream timeout for slow devices.
1597
1598         Reviewed by Chris Dumez.
1599
1600         Extend JetStream timeout to 20 minutes.
1601
1602         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1603
1604 2015-09-30  Daniel Bates  <dabates@apple.com>
1605
1606         Rename iOS builders/testers to include version
1607         https://bugs.webkit.org/show_bug.cgi?id=149685
1608
1609         Reviewed by Simon Fraser.
1610
1611         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1612         make it clear to a reader the version of iOS these builders/testers are using.
1613
1614         * BuildSlaveSupport/build.webkit.org-config/config.json:
1615         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1616
1617 2015-09-30  Daniel Bates  <dabates@apple.com>
1618
1619         Add iOS criterion for triggering a build
1620         https://bugs.webkit.org/show_bug.cgi?id=149679
1621
1622         Rubber-stamped by Alexey Proskuryakov.
1623
1624         First pass at defining criterion for triggering an iOS build.
1625
1626         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1627         (_should_file_trigger_build):
1628         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1629         (ShouldBuildTest):
1630         (ShouldBuildTest.test_should_build):
1631
1632 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1633
1634         [iOS] Allow tests to generate user gestures for UI testing
1635         https://bugs.webkit.org/show_bug.cgi?id=149653
1636
1637         Reviewed by Tim Horton.
1638
1639         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1640         and to listen for completion of scrolling and zooming in the WKWebView.
1641         
1642         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1643         which hides the complexity of creating these events. Event dispatch is asynchronous.
1644         We detect when the last event has been handled by dispatching a vendor-specific event,
1645         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1646         
1647         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1648         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1649         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1650         single and double taps.
1651         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1652         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1653         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1654         (UIScriptContext::unregisterCallback):
1655         (UIScriptContext::callbackWithID):
1656         (UIScriptContext::fireCallback):
1657         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1658         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1659         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1660         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1661         (WTR::UIScriptController::setDidEndZoomingCallback):
1662         (WTR::UIScriptController::didEndZoomingCallback):
1663         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1664         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1665         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1666         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1667         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1668         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1669         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1670         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1671         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1672         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1673         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1674         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1675         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1676         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1677         (simpleDragCurve):
1678         (calculateNextLocation):
1679         (delayBetweenMove):
1680         (+[HIDEventGenerator sharedHIDEventGenerator]):
1681         (+[HIDEventGenerator nextEventCallbackID]):
1682         (-[HIDEventGenerator init]):
1683         (-[HIDEventGenerator _createIOHIDEventType:]):
1684         (-[HIDEventGenerator _sendHIDEvent:]):
1685         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1686         (-[HIDEventGenerator _updateTouchPoints:count:]):
1687         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1688         (-[HIDEventGenerator touchDown:touchCount:]):
1689         (-[HIDEventGenerator touchDown:]):
1690         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1691         (-[HIDEventGenerator liftUp:touchCount:]):
1692         (-[HIDEventGenerator liftUp:]):
1693         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1694         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1695         (-[HIDEventGenerator tap:completionBlock:]):
1696         (-[HIDEventGenerator doubleTap:completionBlock:]):
1697         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1698         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1699         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1700         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1701         (-[HIDEventGenerator markerEventReceived:]):
1702         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1703         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1704         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1705         (WTR::globalToContentCoordinates):
1706         (WTR::UIScriptController::singleTapAtPoint):
1707         (WTR::UIScriptController::doubleTapAtPoint):
1708         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1709         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1710         * WebKitTestRunner/ios/mainIOS.mm:
1711         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1712
1713 2015-09-30  Dana Burkart  <dburkart@apple.com>
1714
1715         git-add-reviewer should trim trailing spaces/newlines
1716         https://bugs.webkit.org/show_bug.cgi?id=149513
1717
1718         Reviewed by Darin Adler.
1719
1720         * Scripts/git-add-reviewer:
1721         (nonInteractive):
1722
1723 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1724
1725         REGRESSION(r190262): User media unit test failures after r190262
1726         https://bugs.webkit.org/show_bug.cgi?id=149580
1727
1728         Reviewed by Darin Adler.
1729
1730         * WebKitTestRunner/TestController.cpp:
1731         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1732           order to WKUserMediaPermissionRequestAllow.
1733
1734 2015-09-30  Daniel Bates  <dabates@apple.com>
1735
1736         Add iOS builders and testers
1737         https://bugs.webkit.org/show_bug.cgi?id=149549
1738
1739         Reviewed by Alexey Proskuryakov.
1740
1741         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1742         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1743
1744         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1745         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1746
1747 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1748
1749         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1750         https://bugs.webkit.org/show_bug.cgi?id=149674
1751
1752         Reviewed by Lucas Forschler.
1753
1754         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1755         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1756
1757 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1758
1759         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1760         have an associated trac instance.
1761         https://bugs.webkit.org/show_bug.cgi?id=149673
1762
1763         Reviewed by Alexey Proskuryakov.
1764
1765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1766         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1767         have an associated trac instance.
1768
1769 2015-09-30  Daniel Bates  <dabates@apple.com>
1770
1771         Prioritize testing latest build request on iOS test bots
1772         https://bugs.webkit.org/show_bug.cgi?id=149669
1773
1774         Reviewed by Darin Adler.
1775
1776         We should prioritize testing of the latest build request on the iOS test bots
1777         as we do for Mac and Windows test bots.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1780         (loadBuilderConfig):
1781
1782 2015-09-30  Daniel Bates  <dabates@apple.com>
1783
1784         Add buildbot category for iOS builders and testers
1785         https://bugs.webkit.org/show_bug.cgi?id=149667
1786
1787         Reviewed by Darin Adler.
1788
1789         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1790         for iOS to the build.webkit.org home page.
1791
1792         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1793         (loadBuilderConfig):
1794         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1795
1796 2015-09-30  Daniel Bates  <dabates@apple.com>
1797
1798         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1799         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1800
1801         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1802         in <http://trac.webkit.org/changeset/190351>.
1803
1804         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1805         (CompileWebKit.start):
1806
1807 2015-09-30  Daniel Bates  <dabates@apple.com>
1808
1809         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1810         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1811
1812         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1813         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1814
1815         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1816         (CompileWebKit.start):
1817
1818 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1819
1820         bot210 was configured for a queue instead of bot126.
1821         
1822         Unreviewed config.json fix.
1823         
1824         * BuildSlaveSupport/build.webkit.org-config/config.json:
1825
1826 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1827
1828         Bring El Capitan buildbot infrastructure online.
1829         https://bugs.webkit.org/show_bug.cgi?id=149605
1830         
1831         Reviewed by Darin Adler.
1832
1833         * BuildSlaveSupport/build.webkit.org-config/config.json:
1834
1835 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1836
1837         [GTK] Deprecation warnings in DOMNodeTest
1838         https://bugs.webkit.org/show_bug.cgi?id=149663
1839
1840         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1841         need to update the tests to use webkit_dom_document_query_selector_all
1842         to avoid compilation warnings.
1843
1844         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1845         (the suggested replacement for the deprecated function).
1846
1847         Reviewed by Carlos Garcia Campos.
1848
1849         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1850         (WebKitDOMNodeTest::testTagNamesNodeList):
1851         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1852         (registerTests):
1853         (WebKitDOMNodeTest::testTagNames): Deleted.
1854         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1855         (prepareDOMForTagNamesTests):
1856         (testWebKitDOMNodeTagNamesNodeList):
1857         (testWebKitDOMNodeTagNamesHTMLCollection):
1858         (beforeAll):
1859         (testWebKitDOMNodeTagNames): Deleted.
1860
1861 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1862
1863         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1864         https://bugs.webkit.org/show_bug.cgi?id=149650
1865
1866         Reviewed by Tim Horton.
1867         
1868         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1869         looks at the file path, and not the custom options that come from file comments.
1870         
1871         Fix by computing TestOptions before making the TestInvocation, and setting them
1872         as const TestInvocation data. This meant changing various call sites to take
1873         the std::string pathOrURL, rather than the TestInvocation itself.
1874         
1875         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1876
1877         * WebKitTestRunner/CMakeLists.txt:
1878         * WebKitTestRunner/TestController.cpp:
1879         (WTR::TestController::ensureViewSupportsOptionsForTest):
1880         (WTR::testPath):
1881         (WTR::createTestURL):
1882         (WTR::updateTestOptionsFromTestHeader):
1883         (WTR::TestController::testOptionsForTest):
1884         (WTR::TestController::updateWebViewSizeForTest):
1885         (WTR::TestController::updateWindowScaleForTest):
1886         (WTR::TestController::runTest):
1887         * WebKitTestRunner/TestController.h:
1888         * WebKitTestRunner/TestInvocation.cpp:
1889         (WTR::TestInvocation::TestInvocation):
1890         (WTR::TestInvocation::invoke):
1891         (WTR::createWKURL): Deleted.
1892         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1893         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1894         * WebKitTestRunner/TestInvocation.h:
1895         (WTR::TestInvocation::options):
1896         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1897         (WTR::pathContains):
1898         (WTR::shouldMakeViewportFlexible):
1899         (WTR::shouldUseFixedLayout):
1900         (WTR::isSVGTestPath):
1901         (WTR::isHiDPITestPath):
1902         (WTR::TestOptions::TestOptions):
1903         * WebKitTestRunner/TestOptions.h:
1904         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1905         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1906         (WTR::pathContains):
1907         (WTR::shouldUseFixedLayout):
1908         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1909         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1910         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1911         * WebKitTestRunner/ios/TestControllerIOS.mm:
1912         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1913         * WebKitTestRunner/mac/TestControllerMac.mm:
1914         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1915
1916 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1917
1918         Flakiness dashboard should support OS X El Capitan
1919         https://bugs.webkit.org/show_bug.cgi?id=149648
1920
1921         Reviewed by Alexey Proskuryakov.
1922
1923         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
1924         difference between new appscale and old Google App Engine implementation.
1925         * TestResultServer/app.yaml: Same.
1926         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1927
1928 2015-09-29  Daniel Bates  <dabates@apple.com>
1929
1930         configure-xcode-for-ios-development does not work with Xcode 7
1931         https://bugs.webkit.org/show_bug.cgi?id=149640
1932
1933         Reviewed by Alexey Proskuryakov.
1934
1935         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1936         because it cannot find the Xcode specification files for iOS simulator and device. These
1937         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1938         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1939         new specification files with the added definitions (as we did in older versions of Xcode)
1940         in order for Xcode 7 to honor these definitions.
1941
1942         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1943         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1944         (updateXcode7SpecificationFile): Added.
1945         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1946         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1947         appropriate success message.
1948         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1949         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1950         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1951
1952 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1953
1954         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1955         https://bugs.webkit.org/show_bug.cgi?id=149639
1956
1957         Reviewed by Alex Christensen.
1958
1959         * Scripts/VCSUtils.pm:
1960         (exitStatus): Use 'isWindows()' method.
1961         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1962         an error. This method could probably just go away.
1963         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1964         always changing to Unix style. 
1965         (unixPath): Added. Needed so Windows can always show a Unix path in the
1966         ChangeLog file.
1967         (changeLogName): Work around the fact that 'getpwuid' is not available on
1968         a pure Windows build of Perl.
1969         * Scripts/prepare-ChangeLog:
1970         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1971         path on Windows.
1972         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1973         support using arrays for 'open' arguments.
1974         (resolveChangeLogsPath): Ditto.
1975         (resolveConflictedChangeLogs): Use new helper functions.
1976         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1977         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1978         quotes. Unix systems are happy either way.
1979         (statusCommand): Ditto.
1980         * Scripts/webkitdirs.pm:
1981         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1982
1983 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1984
1985         [Win] Unreviewed 64-bit build fix after switch to CMake.
1986
1987         * Scripts/webkitdirs.pm:
1988         (determineIsWin64FromArchitecture): Added.
1989
1990 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1991
1992         printing does not use minimum page zoom factor
1993         https://bugs.webkit.org/show_bug.cgi?id=108507
1994
1995         Reviewed by Darin Adler.
1996
1997         WebKitTestRunner always takes the snapshots from the UI process
1998         (expect for IOS), so in the case of printing, the layout in the
1999         web view is not the expected one. When printing, we need to take
2000         the snapshot in the web process and ensure it's rendered with a
2001         PrintContext.
2002
2003         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2004         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2005         kWKSnapshotOptionsPrinting option to
2006         WKBundlePageCreateSnapshotWithOptions() when printing.
2007
2008 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2009
2010         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2011         https://bugs.webkit.org/show_bug.cgi?id=149595
2012
2013         Reviewed by Tim Horton.
2014
2015         All ports except IOS implement
2016         PlatformWebView::windowSnapshotImage() to generate the snapshot
2017         for the pixel tests in the UI process. But we are still generating
2018         a snapshot for pixel tests in the Web process too, that is passed
2019         to the UI process but ignored.
2020         Whether a pixel result is needed or not, is only known by the web
2021         process depending on whether the test called dumpAsText with
2022         dumpPixels == true or not. Since the pixels are now dump in the UI
2023         process, we need to pass that information to the UI process when
2024         the test is done. For that we set a PixelResultIsPending bool
2025         parameter to the Done message, and we only add the PixelResult
2026         when UI process doesn't need to generate the pixels dump.
2027
2028         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2029         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2030         m_pixelResultIsPending to false on reset.
2031         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2032         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2033         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2034         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2035         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2036         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2037         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2038         port.
2039         * WebKitTestRunner/TestInvocation.cpp:
2040         (WTR::TestInvocation::dumpResults): Use either the pixel result
2041         from the web process or generate a pixel result from the web view
2042         if need it.
2043         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2044         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2045         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2046         is created by the caller now, but the CG implementation needs to
2047         know if it's a Web or UI process snapshot.
2048         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2049         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2050         cairo surface for the given image.
2051         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2052         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2053         CGContext for the given image.
2054
2055 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2056
2057         Fix JS errors on dashboard metrics page
2058         https://bugs.webkit.org/show_bug.cgi?id=149608
2059
2060         Reviewed by Alexey Proskuryakov.
2061
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2063         (initPlatformsByFamily): 
2064         (updateHiddenPlatforms):
2065         (parsePlatformFamily): Deleted.
2066         (updateToggleButtons): Deleted.
2067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2068         (updateHiddenPlatforms): Added to remove errors.
2069         (initPlatformsByFamily): Added to remove errors.
2070         (unhiddenQueues): Updated to use Settings.
2071         (documentReady): Added logic to add toggle buttons to the settings menu.
2072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2073         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2074         MetricsMain.js to Settings.
2075         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2076         MetricsMain.js to Settings.
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2078         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2079
2080 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2081
2082         Appscale query fails because of missing index
2083         https://bugs.webkit.org/show_bug.cgi?id=149609
2084
2085         Reviewed by Darin Adler.
2086
2087         * QueueStatusServer/index.yaml: Added the required index.
2088
2089 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2090
2091         [Win] Fix the 64-bit build after switch to cmake.
2092
2093         Reviewed by Alex Christensen.
2094
2095         * Scripts/webkitdirs.pm:
2096         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2097         run a 64-bit build.
2098
2099 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2100
2101         [Win] Allow Windows to run test-webkitpy without Cygwin
2102         https://bugs.webkit.org/show_bug.cgi?id=149602
2103
2104         Reviewed by Alex Christensen.
2105
2106         These changes mostly shift from hard-coded paths using UNIX-style
2107         separators to Python's "os.path.join" syntax that uses the correct
2108         path separator for each platform.
2109         
2110         * Scripts/webkitpy/common/system/path.py:
2111         (cygpath): Don't pass paths through Cygpath on native Windows.
2112         * Scripts/webkitpy/port/win.py:
2113         (WinPort._path_to_apache): Use os.path.join.
2114         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2115         in 64-bit environments).
2116         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2117         * Scripts/webkitpy/style/checker_unittest.py:
2118         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2119         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2120         (GlobalVariablesTest): Ditto.
2121         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2122         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2123         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2124         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2125         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2126         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2127         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2128         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2129         (StyleProcessor_CodeCoverageTest): Ditto.
2130         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2131         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2132         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2133         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2134         manual string concatenation of paths.
2135
2136 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2137
2138         Add bugzilla addresses of committers to contributors.json
2139         https://bugs.webkit.org/show_bug.cgi?id=149520
2140
2141         Reviewed by Darin Adler.
2142
2143         * Scripts/webkitpy/common/config/contributors.json:
2144
2145 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2146
2147         validate-committer-lists -b shouldn't need edituser privileges
2148         https://bugs.webkit.org/show_bug.cgi?id=149519
2149
2150         Reviewed by Darin Adler.
2151
2152         * Scripts/validate-committer-lists:
2153         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2154         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2155         (BugzillaQueries.is_invalid_bugzilla_email):
2156         (BugzillaQueries): Deleted.
2157         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2158
2159 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2160
2161         Unreviewed. Gardening: skip media stream tests failing after r190262.
2162
2163         * Scripts/run-gtk-tests:
2164         (TestRunner):
2165
2166 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2167
2168         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2169         https://bugs.webkit.org/show_bug.cgi?id=149571
2170
2171         Reviewed by Dan Bernstein.
2172
2173         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2174
2175         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2176         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2177         * LayoutTestRelay/Configurations/Base.xcconfig:
2178         * MiniBrowser/Configurations/Base.xcconfig:
2179         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2180         * TestWebKitAPI/Configurations/Base.xcconfig:
2181         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2182         * WebEditingTester/Configurations/Base.xcconfig:
2183         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2184         * WebKitTestRunner/Configurations/Base.xcconfig:
2185         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2186         * WebKitTestRunner/iOS.xcconfig: Removed.
2187
2188 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2189
2190         Clean up user media request internal API
2191         https://bugs.webkit.org/show_bug.cgi?id=149527
2192
2193         Reviewed by Tim Horton.
2194
2195         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2196         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2197
2198         * WebKitTestRunner/TestController.cpp:
2199         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2200
2201 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2202
2203         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2204         https://bugs.webkit.org/show_bug.cgi?id=149577
2205
2206         Reviewed by Tim Horton.
2207         
2208         When calling testRunner.runUIScript() from a page load event, the script could run
2209         in the UI process before the current remote layer tree transaction had been handled
2210         there. This meant that runUIScript() could query state which was about to change.
2211         
2212         Fix by delaying the execution of the UI script until a layer tree transaction has
2213         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2214
2215         * WebKitTestRunner/TestInvocation.cpp:
2216         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2217         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2218         * WebKitTestRunner/TestInvocation.h:
2219
2220 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2221
2222         [Mac] Media tests start to time out after a few days of bot uptime
2223         https://bugs.webkit.org/show_bug.cgi?id=149468
2224
2225         Reviewed by Darin Adler.
2226
2227         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2228         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2229         all temporary and cache files go to a custom location.
2230
2231         * Scripts/webkitpy/port/base.py:
2232         * Scripts/webkitpy/port/driver.py:
2233         * Scripts/webkitpy/port/mac.py:
2234         * Scripts/webkitpy/port/win.py:
2235         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2236
2237 2015-09-25  Dan Bernstein  <mitz@apple.com>
2238
2239         Removed MiniBrowser.entitlements.
2240
2241         Rubber-stamped by Anders Carlsson.
2242
2243         The entitlements weren’t used anyway.
2244
2245         * MiniBrowser/MiniBrowser.entitlements: Removed.
2246         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2247
2248 2015-09-24  Daniel Bates  <dabates@apple.com>
2249
2250         Add WebKitSystemInterface for iOS 9.0
2251         https://bugs.webkit.org/show_bug.cgi?id=149550
2252
2253         Rubber-stamped by Alexey Proskuryakov.
2254
2255         * Scripts/copy-webkitlibraries-to-product-directory:
2256
2257 2015-09-24  Daniel Bates  <dabates@apple.com>
2258
2259         Support building for arbitrary architectures
2260         https://bugs.webkit.org/show_bug.cgi?id=149539
2261
2262         Reviewed by Alexey Proskuryakov.
2263
2264         Teach buildbot to pass the architectures associated with the builder to build-webkit
2265         when building on OS X and iOS. As a side effect of this change we now support building
2266         universal binaries when multiples architectures are specified.
2267
2268         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2269         (CompileWebKit.start):
2270
2271 2015-09-24  Daniel Bates  <dabates@apple.com>
2272
2273         Fix the build after <http://trac.webkit.org/changeset/190212>
2274         (http://trac.webkit.org/changeset/190212)
2275
2276         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2277
2278         * BuildSlaveSupport/built-product-archive:
2279         (main):
2280
2281 2015-09-24  Daniel Bates  <dabates@apple.com>
2282
2283         Support running unit tests on iOS Simulator test bot
2284         https://bugs.webkit.org/show_bug.cgi?id=149536
2285
2286         Reviewed by Alexey Proskuryakov.
2287
2288         Implements support for running unit tests on a iOS test bot. At the time of writing,
2289         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2290
2291         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2292         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2293         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2294
2295 2015-09-24  Daniel Bates  <dabates@apple.com>
2296
2297         Add support infrastructure for OpenSource iOS builders and testers
2298         https://bugs.webkit.org/show_bug.cgi?id=149534
2299
2300         Reviewed by Darin Adler.
2301
2302         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2303         scripts about iOS.
2304
2305         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2306         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2307         --ios-simulator or --device for a builder/tester whose full platform name begins with
2308         "ios-simulator" or "ios", respectively.
2309         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2310         * BuildSlaveSupport/built-product-archive:
2311         (main): Pass the full platform name to determineWebKitBuildDirectory().
2312         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2313         command line flag when building for iOS.
2314         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2315         parameter fullPlatform. This parameter was originally added in r125066 to support the
2316         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2317         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2318         * BuildSlaveSupport/clean-build:
2319         (main): Call script webkit-build-directory with the appropriate command line flag when
2320         building for iOS.
2321         * BuildSlaveSupport/delete-stale-build-files:
2322         (main): Use the same logic for iOS as we do for Mac.
2323         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2324         flag when building for iOS.
2325         * BuildSlaveSupport/test-result-archive:
2326         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2327
2328 2015-09-24  Daniel Bates  <dabates@apple.com>
2329
2330         Remove Chromium-specific changes to script built-product-archive
2331         https://bugs.webkit.org/show_bug.cgi?id=149530
2332
2333         Rubber-stamped by Csaba Osztrogonác.
2334
2335         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2336         Chromium code has long since been removed from the OpenSource WebKit Project.
2337
2338         * BuildSlaveSupport/built-product-archive:
2339         (createZipManually):
2340         (createZip):
2341         (archiveBuiltProduct):
2342
2343 2015-09-24  Dan Bernstein  <mitz@apple.com>
2344
2345         Build fix.
2346
2347         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2348
2349 2015-09-24  Mark Lam  <mark.lam@apple.com>
2350
2351         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2352
2353         * Scripts/webkitpy/common/config/contributors.json:
2354
2355 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2356
2357         Unreviewed. Fix GObject DOM API breaks after r190120.
2358
2359         Bring back code removed in r169931 to handle documentation of
2360         deleted classes.
2361
2362         * gtk/webkitdom.py:
2363         (WebKitDOMDocGenerator):
2364         (WebKitDOMDocGenerator.write_deleted_classes):
2365         (WebKitDOMDocGenerator.generate):
2366         (write_deleted_classes):
2367         (WebKitDOMDocGeneratorSections._deleted_class):
2368         (WebKitDOMDocGeneratorSections._deleted_class.in):
2369         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2370         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2371
2372 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2373
2374         [Cocoa] [Font Features] Implement font-variant-*
2375         https://bugs.webkit.org/show_bug.cgi?id=148413
2376
2377         Reviewed by Darin Adler.
2378
2379         Update test font to use "lnum" feature.
2380
2381         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2382         (Generator::appendGSUBTable):
2383
2384 2015-09-22  Andy Estes  <aestes@apple.com>
2385
2386         ContentFiltering.AllowDownloadAfterAddData is very flaky
2387         https://bugs.webkit.org/show_bug.cgi?id=148885
2388         <rdar://problem/22729563>
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2393         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2394         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2395
2396         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2397         (downloadTest):
2398
2399 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2400
2401         Mavericks: Media tests start to time out after a few days of bot uptime
2402         https://bugs.webkit.org/show_bug.cgi?id=149468
2403
2404         Reviewed by Chris Dumez.
2405
2406         * Scripts/webkitpy/port/base.py:
2407         * Scripts/webkitpy/port/driver.py:
2408         * Scripts/webkitpy/port/mac.py:
2409
2410 2015-09-22  Nan Wang  <n_wang@apple.com>
2411
2412         Unreviewed, add myself to the committers list.
2413
2414         * Scripts/webkitpy/common/config/contributors.json:
2415
2416 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2417
2418         Remove 'nullable' to fix older iOS builds.
2419
2420         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2421         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2422
2423 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2424
2425         [Win] Show tiled drawing debug overlay on Windows
2426         https://bugs.webkit.org/show_bug.cgi?id=149426
2427
2428         Reviewed by Dean Jackson.
2429
2430         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2431         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2432         * MiniBrowser/win/Common.cpp:
2433         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2434         flag if needed.
2435         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2436
2437 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2438
2439         [Win] Use command-line argument to launch in regular or High DPI mode.
2440         https://bugs.webkit.org/show_bug.cgi?id=149417
2441
2442         Reviewed by Dean Jackson.
2443
2444         * MiniBrowser/win/Common.cpp:
2445         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2446         very start of execution, before the MiniBrowser.dll is loaded.
2447         * win/DLLLauncher/DLLLauncherMain.cpp:
2448         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2449         present. On WinCairo, always use High DPI.
2450
2451 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2452
2453         32-bit Mac build fix attempt after r190065.
2454
2455         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2456
2457 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2458
2459         [OS X] Update for Xcode 7.0 on Yosemite
2460         https://bugs.webkit.org/show_bug.cgi?id=149389
2461
2462         Reviewed by Dan Bernstein.
2463
2464         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2465         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2466         Removed unneeded declarations - conforming to a protocol is sufficient.
2467
2468         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2469         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2470         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2471         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2472
2473 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2474
2475         Add the ability for tests to run script in the UI process in WebKitTestRunner
2476         https://bugs.webkit.org/show_bug.cgi?id=149356
2477
2478         Reviewed by Tim Horton.
2479
2480         This change adds testRunner.runUIScript(script, callback), which allows a test
2481         to execute script in a JSContext which runs in the UI process. That context
2482         has bindings exposed through the UIScriptController interface; currently one test
2483         function, and some iOS-specific functions are included. UIScriptController can be
2484         async with a callback, and runUIScript() itself is asynchronous. When the UI 
2485         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2486         is a string passed back to the web process, and given to the runUIScript()
2487         callback function.
2488         
2489         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2490
2491         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2492         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2493         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2494         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2495         complete, call back into TestRunner.
2496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2497         (WTR::nextUIScriptCallbackID):
2498         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2499         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2500         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2501         * WebKitTestRunner/PlatformWebView.h:
2502         * WebKitTestRunner/TestController.cpp:
2503         (WTR::updateTestOptionsFromTestHeader):
2504         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2505         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2506         * WebKitTestRunner/TestInvocation.cpp:
2507         (WTR::TestInvocation::shouldUseFixedLayout):
2508         (WTR::TestInvocation::shouldUseThreadedScrolling):
2509         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2510         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2511         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2512         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2513         * WebKitTestRunner/TestInvocation.h:
2514         * WebKitTestRunner/TestOptions.h:
2515         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2516         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2517         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2518         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2519         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2520         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2521         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2522         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2523         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2524         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2525         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2526         (WTR::UIScriptController::doAsyncTask):
2527         (WTR::UIScriptController::zoomToScale):
2528         (WTR::UIScriptController::zoomScale):
2529         (WTR::UIScriptController::minimumZoomScale):
2530         (WTR::UIScriptController::maximumZoomScale):
2531         (WTR::UIScriptController::contentVisibleRect):
2532         * WebKitTestRunner/mac/EventSenderProxy.mm:
2533         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2534         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2535         * WebKitTestRunner/mac/TestControllerMac.mm:
2536         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2537         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2538         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2539         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2540         (UIScriptContext::UIScriptContext):
2541         (UIScriptContext::~UIScriptContext):
2542         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2543         asynchronous, call the callback.
2544         (UIScriptContext::nextTaskCallbackID):
2545         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2546         that has a callback). Has to store the callbackID of the script, so code called from the completion
2547         callback knows which UI script invoked it.
2548         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2549         (UIScriptContext::uiScriptComplete):
2550         (UIScriptContext::objectFromRect): Make a JS object from a rect.
2551         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2552         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2553         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2554         (WTR::UIScriptController::UIScriptController):
2555         (WTR::UIScriptController::makeWindowObject):
2556         (WTR::UIScriptController::wrapperClass):
2557         (WTR::UIScriptController::doAsyncTask):
2558         (WTR::UIScriptController::zoomToScale):
2559         (WTR::UIScriptController::zoomScale):
2560         (WTR::UIScriptController::minimumZoomScale):
2561         (WTR::UIScriptController::maximumZoomScale):
2562         (WTR::UIScriptController::contentVisibleRect):
2563         (WTR::UIScriptController::uiScriptComplete):
2564         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2565         (WTR::UIScriptController::create):
2566         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2567
2568 2015-09-21  Tim Horton  <timothy_horton@apple.com>
2569
2570         Turn on threaded scrolling by default in the tests
2571         https://bugs.webkit.org/show_bug.cgi?id=149377
2572
2573         Reviewed by Simon Fraser.
2574
2575         * WebKitTestRunner/mac/TestControllerMac.mm:
2576         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2577         (WTR::shouldUseThreadedScrolling): Deleted.
2578         Turn on threaded scrolling by default.
2579
2580 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2581
2582         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2583         https://bugs.webkit.org/show_bug.cgi?id=149252
2584
2585         Reviewed by Darin Adler.
2586
2587         In case of glib tests the test runner notifies about tests
2588         crashing, but for google tests we don't get any feedback, which
2589         means that in case of a test crashing we get a list of **PASS**
2590         messages and at the summary we are notified that the test suite
2591         has failed, but it's impossible to know which test cases have failed.
2592
2593         * Scripts/run-gtk-tests:
2594         (TestRunner._run_google_test): Add a **CRASH** message if test
2595         case crashed.
2596
2597 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2598
2599         WebKitTestRunner can leak user content script results between tests
2600         https://bugs.webkit.org/show_bug.cgi?id=149391
2601
2602         Reviewed by Sam Weinig.
2603
2604         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2605         about:blank, and thus about:blank doesn't have unintended side effects.
2606
2607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2608         (WTR::InjectedBundle::beginTesting):
2609         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2610         (WTR::InjectedBundlePage::resetAfterTest):
2611
2612 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2613
2614         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2615         https://bugs.webkit.org/show_bug.cgi?id=149384
2616
2617         Reviewed by Chris Fleizach.
2618
2619         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2620         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2621         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2622         regardless of whether someone else holds a reference (we also call -stopListening in
2623         -dealloc).
2624
2625         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2626         (AccessibilityController::platformResetToConsistentState):
2627         (AccessibilityController::addNotificationListener):
2628         Ditto.
2629
2630 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2631
2632         Remove XHR_TIMEOUT compilation guard
2633         https://bugs.webkit.org/show_bug.cgi?id=149260
2634
2635         Reviewed by Benjamin Poulain.
2636
2637         * Scripts/webkitperl/FeatureList.pm:
2638
2639 2015-09-19  Dan Bernstein  <mitz@apple.com>
2640
2641         Attempted build fix.
2642
2643         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2644
2645 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2646
2647         Unreviewed, rolling out r189908.
2648         https://bugs.webkit.org/show_bug.cgi?id=149368
2649
2650         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2651
2652         Reverted changeset:
2653
2654         "printing does not use minimum page zoom factor"
2655         https://bugs.webkit.org/show_bug.cgi?id=108507
2656         http://trac.webkit.org/changeset/189908
2657
2658 2015-09-18  Andy Estes  <aestes@apple.com>
2659
2660         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2661         https://bugs.webkit.org/show_bug.cgi?id=149360
2662
2663         Reviewed by Tim Horton.
2664
2665         Added an API test.
2666
2667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2668         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2669         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2670         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2671         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2672         (TEST):
2673         * TestWebKitAPI/ios/pages.pages: Added.
2674
2675 2015-09-18  Nan Wang  <n_wang@apple.com>
2676
2677         AX: Implement ARIA 1.1 @aria-current on iOS
2678         https://bugs.webkit.org/show_bug.cgi?id=149297
2679
2680         Reviewed by Chris Fleizach.
2681
2682         Added support to test aria-current on iOS.
2683
2684         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2685         (AccessibilityUIElement::stringAttributeValue):
2686         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2687         (WTR::AccessibilityUIElement::stringAttributeValue):
2688
2689 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2690
2691         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2692         https://bugs.webkit.org/show_bug.cgi?id=149352
2693
2694         Reviewed by Simon Fraser.
2695
2696         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2697         m_context can be null. This may indicate a bug in webkitpy too, but
2698         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2699         wrong with opening and immediately closing it.
2700
2701 2015-09-18  Daniel Bates  <dabates@apple.com>
2702
2703         isGitSVNDirectory() returns true when Git is not installed
2704         https://bugs.webkit.org/show_bug.cgi?id=149351
2705
2706         Reviewed by Alexey Proskuryakov.
2707
2708         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2709         Git is not installed on the machine.
2710
2711         * Scripts/VCSUtils.pm:
2712         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2713         status code 0 (success).
2714
2715 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2716
2717         Prevent build-webkit from building four times on Windows 
2718         https://bugs.webkit.org/show_bug.cgi?id=149336
2719
2720         Reviewed by Brent Fulgham.
2721
2722         * Scripts/build-webkit:
2723         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2724         They're built all at once.
2725         * Scripts/webkitdirs.pm:
2726         (buildVisualStudioProject):
2727         (cmakeGeneratedBuildfile):
2728         Don't generate the Visual Studio solution if it already exists.
2729         It will run CMake again if necessary.
2730
2731 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2732
2733         [iOS WK2] WTR fails to set the key window in the UIKit sense
2734         https://bugs.webkit.org/show_bug.cgi?id=149325
2735
2736         Reviewed by Tim Horton.
2737
2738         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2739         This causes UIKit to bypass code that actually sets the key window, resulting in
2740         [UIAppliation sharedApplication].keyWindow always being nil.
2741
2742         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2743         -[WebKitTestRunnerWindow isKeyWindow] call super.
2744
2745         * WebKitTestRunner/PlatformWebView.h:
2746         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2747         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2748         (WTR::PlatformWebView::setWindowIsKey):
2749         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2750         (WTR::PlatformWebView::setWindowIsKey):
2751         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2752         (-[WebKitTestRunnerWindow isKeyWindow]):
2753         (WTR::PlatformWebView::PlatformWebView):
2754         (WTR::PlatformWebView::~PlatformWebView):
2755         (WTR::PlatformWebView::setWindowIsKey):
2756         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2757         (WTR::PlatformWebView::setWindowIsKey):
2758
2759 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2760
2761         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2762         https://bugs.webkit.org/show_bug.cgi?id=149321
2763
2764         Reviewed by Tim Horton.
2765         
2766         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
2767         enabled the "testing" viewport configuration, which disables page scaling.
2768         
2769         If we're running viewport tests, we want the normal web page configuration.
2770         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2771         based on whether the test is in a "viewport" directory.
2772
2773         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2774         (WTR::InjectedBundle::beginTesting):
2775         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2776         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2777         * WebKitTestRunner/TestInvocation.cpp:
2778         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2779         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2780         (WTR::TestInvocation::shouldMakeViewportFlexible):
2781         (WTR::TestInvocation::invoke):
2782         * WebKitTestRunner/TestInvocation.h:
2783         * WebKitTestRunner/ios/TestControllerIOS.mm:
2784         (WTR::TestController::platformConfigureViewForTest):
2785         (WTR::shouldMakeViewportFlexible): Deleted.
2786
2787 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2788
2789         Give iOS WebKitTestRunner a launch storyboard
2790         https://bugs.webkit.org/show_bug.cgi?id=149314
2791
2792         Reviewed by Dan Bates.
2793         
2794         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2795         that it's been built for specific device configurations, and puts the window
2796         at the top of the screen. This simplifies coordinate conversions in a future patch.
2797
2798         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2799         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2800         * WebKitTestRunner/ios/Launch.storyboard: Added.
2801
2802 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2803
2804         Update licence in r189890
2805         https://bugs.webkit.org/show_bug.cgi?id=149306
2806
2807         Reviewed by Dean Jackson.
2808
2809         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2810         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2811         * FontWithFeatures/FontWithFeatures/main.cpp:
2812
2813 2015-09-17  Mark Lam  <mark.lam@apple.com>
2814
2815         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2816         https://bugs.webkit.org/show_bug.cgi?id=149285
2817
2818         Reviewed by Saam Barati.
2819
2820         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2821
2822         * Scripts/run-javascriptcore-tests:
2823         (runJSCStressTests):
2824
2825 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2826
2827         Switch AppleWin build to use CMake
2828         https://bugs.webkit.org/show_bug.cgi?id=149163
2829
2830         Reviewed by Brent Fulgham.
2831
2832         * Scripts/build-webkit:
2833         * Scripts/run-api-tests:
2834         (runTest):
2835         (listAllTests):
2836         (prepareEnvironmentForRunningTestTool):
2837         (testToolPaths):
2838         (testToolPath): Deleted.
2839         Run the API tests as separate executables on Windows.
2840         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2841         * Scripts/webkitdirs.pm:
2842         (checkRequiredSystemConfig):
2843         (jhbuildWrapperPrefixIfNeeded):
2844         (generateBuildSystemFromCMakeProject):
2845         Fix configuration quirks.
2846
2847 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2848
2849         Added toggle options for hiding and showing certain platform families on the dashboard.
2850         https://bugs.webkit.org/show_bug.cgi?id=148403
2851
2852         Reviewed by David Kilzer.
2853
2854         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2855         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2856         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2857         in lieu of an "all" button in the toggle menu.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2860         (parsePlatformFamily): Helper function to parse out a platform family.
2861         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2862         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2863         (updateToggleButtons): Updates the status of the toggle buttons.
2864         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2865         (documentReady): Added creation of toggle buttons.
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2867         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2868         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2869         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
2870         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2872         (QueueView): Updated to use hiddenPlatformFamilies.
2873         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2875         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2876         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2877         (Settings.prototype.toggleHiddenPlatform): Deleted.
2878         (Settings.prototype.clearHiddenPlatforms): Deleted.
2879         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2881         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2882         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2883         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2884         (table.queue-grid tr.headers th):
2885         (div.settingsWrapper.hide):
2886         (div.settingsWrapper):
2887         (div.familyToggleWrapper):
2888         (div.platformFamilyToggleButton):
2889         (div.platformFamilyShowToggleButton:not(:last-child)):
2890         (div.familyShown):
2891         (div.accessibilityButton):
2892         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2893         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2894         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2895         platformFamilyToggleButton and settingsWrapper class.
2896         (.accessibilityButton): Deleted.
2897
2898 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2899
2900         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2901         https://bugs.webkit.org/show_bug.cgi?id=148904
2902
2903         Reviewed by Myles Maxfield.
2904
2905         * WebKitTestRunner/TestController.cpp:
2906         (WTR::parseBooleanTestHeaderValue):
2907         (WTR::updateViewOptionsFromTestHeader):
2908         Check for the key "useThreadedScrolling".
2909         Add some code to check for "true" and "false" for boolean options.
2910
2911         (WTR::TestController::viewOptionsForTest):
2912         Apply the test's overrides last, even after the platform's.
2913
2914 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2915
2916         printing does not use minimum page zoom factor
2917         https://bugs.webkit.org/show_bug.cgi?id=108507
2918
2919         Reviewed by Darin Adler.
2920
2921         WebKitTestRunner always takes the snapshots from the UI process
2922         (expect for IOS), so in the case of printing, the layout in the
2923         web view is not the expected one. When printing, we need to take
2924         the snapshot in the web process and ensure it's rendered with a
2925         PrintContext.
2926
2927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2928         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2929         kWKSnapshotOptionsPrinting option to
2930         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2931         printing, don't even create the snapshot, since it will be ignored
2932         by the UI process that always creates its own from the WebView (expect for IOS platform)
2933         * WebKitTestRunner/TestInvocation.cpp:
2934         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2935         received from the web process if any when comparing pixel
2936         results. Now we only receive a snapshot from the web process in
2937         case of printing, or when platform is IOS. Otherwhise, generate
2938         the snapshot from the WebView as usual.
2939         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2940         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2941         is created by the caller now, but the CG implementation needs to
2942         know if it's a Web or UI process snapshot.
2943         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2944         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2945         cairo surface for the given image.
2946         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2947         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2948         CGContext for the given image.
2949
2950 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2951
2952         Create a font which can be used for testing font features
2953         https://bugs.webkit.org/show_bug.cgi?id=149237
2954
2955         Reviewed by Simon Fraser.
2956
2957         This patch adds a new project in the Tools/ directory which generates a font which can
2958         be used for testing font features. This is a standalone project consisting of two files:
2959         1. A file which actually generates the byte vector representing the font. This file has
2960         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2961         specific, and only relies on the C++ STL.
2962         2. A file with a main() which calls generateFont() and writes out the font, as well as
2963         uses the font to render some demonstration text into a .png file. This file is platform
2964         specific.
2965
2966         The font itself only supports the following characters:
2967         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2968         However, the shape of these letters are either an X or a check mark.
2969
2970         The letter "A" always is a check mark.
2971         The letter "B" always is an X.
2972         Without any font features turned on, the rest of the letters are shown as X.
2973
2974         Each font feature has an letter associated with it. When the font feature is enabled,
2975         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2976         as a check mark.
2977
2978         Here are the mappings of font features to letters:
2979         liga: C
2980         clig: D
2981         dlig: E
2982         hlig: F
2983         calt: G
2984         subs: H
2985         sups: I
2986         smcp: J
2987         c2sc: K
2988         pcap: L
2989         c2pc: M
2990         unic: N
2991         titl: O
2992         onum: P
2993         pnum: Q
2994         tnum: R
2995         frac: S
2996         afrc: T
2997         ordn: U
2998         zero: V
2999         hist: W
3000         jp78: X
3001         jp83: Y
3002         jp90: Z
3003         jp04: a
3004         smpl: b
3005         trad: c
3006         fwid: d
3007         pwid: e
3008         ruby: f
3009
3010         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3011         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3012         (integralLog2):
3013         (roundDownToPowerOfTwo):
3014         (isFourByteAligned):
3015         (clampTo):
3016         (append32):
3017         (writeCFFEncodedNumber):
3018         (CFFBuilder::CFFBuilder):
3019         (CFFBuilder::takeResult):
3020         (CFFBuilder::moveTo):
3021         (CFFBuilder::lineTo):
3022         (CFFBuilder::curveToCubic):
3023         (CFFBuilder::closePath):
3024         (CFFBuilder::writePoint):
3025         (generateBoxCharString):
3026         (generateCheckCharString):
3027         (generateXCharString):
3028         (charStringForGlyph):
3029         (Generator::generate):
3030         (Generator::Placeholder::Placeholder):
3031         (Generator::Placeholder::populate):
3032         (Generator::Placeholder::~Placeholder):
3033         (Generator::placeholder):
3034         (Generator::append16):
3035         (Generator::append32):
3036         (Generator::append32BitCode):
3037         (Generator::overwrite16):
3038         (Generator::overwrite32):
3039         (Generator::appendCFFTable):
3040         (Generator::appendSubstitutionSubtable):
3041         (Generator::appendScriptSubtable):
3042         (Generator::appendGSUBTable):
3043         (Generator::appendOS2Table):
3044         (Generator::appendFormat12CMAPTable):
3045         (Generator::appendFormat4CMAPTable):
3046         (Generator::appendCMAPTable):
3047         (Generator::appendHEADTable):
3048         (Generator::appendHHEATable):
3049         (Generator::appendHMTXTable):
3050         (Generator::appendMAXPTable):
3051         (Generator::appendNAMETable):
3052         (Generator::appendPOSTTable):
3053         (Generator::calculateChecksum):
3054         (Generator::appendTable):
3055         (generateFont):
3056         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3057         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3058         (drawTextWithFeature):
3059         (main):
3060
3061 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3062
3063         Unreviewed, rolling out r189875 and r189878.
3064         https://bugs.webkit.org/show_bug.cgi?id=149235
3065
3066         cygwin cmake build not ready yet (Requested by alexchristensen
3067         on #webkit).
3068
3069         Reverted changesets:
3070
3071         "Switch AppleWin build to use CMake"
3072         https://bugs.webkit.org/show_bug.cgi?id=149163
3073         http://trac.webkit.org/changeset/189875
3074
3075         "Cygwin build fix after r189875"
3076         http://trac.webkit.org/changeset/189878
3077
3078 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3079
3080         Cygwin build fix after r189875
3081
3082         * Scripts/build-webkit:
3083         * Scripts/webkitdirs.pm:
3084         (jhbuildWrapperPrefixIfNeeded):
3085         (generateBuildSystemFromCMakeProject):
3086         Make things work with cygwin and cmake.
3087
3088 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3089
3090         Switch AppleWin build to use CMake
3091         https://bugs.webkit.org/show_bug.cgi?id=149163
3092
3093         Reviewed by Brent Fulgham.
3094
3095         * Scripts/build-webkit:
3096         Build with CMake.
3097         * Scripts/run-api-tests:
3098         (runTest):
3099         (listAllTests):
3100         (prepareEnvironmentForRunningTestTool):
3101         (testToolPaths):
3102         (testToolPath): Deleted.
3103         Run the API tests as separate executables on Windows.
3104         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3105
3106 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
3107
3108         Add newer build.webkit.org pages to robots.txt
3109         https://bugs.webkit.org/show_bug.cgi?id=149219
3110
3111         Reviewed by Darin Adler.
3112
3113         Indexing bot watcher's dashboard can't be good.
3114
3115         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3116
3117 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3118
3119         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3120
3121         * BuildSlaveSupport/built-product-archive:
3122         (unzipArchive):
3123
3124 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3125
3126         [EFL] Fix the help message of separated web process option of MiniBrowser
3127         https://bugs.webkit.org/show_bug.cgi?id=149212
3128
3129         Reviewed by Gyuyoung Kim.
3130
3131         * MiniBrowser/efl/main.c:
3132
3133 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3134
3135         Fix python syntax after r189851.
3136
3137         * BuildSlaveSupport/built-product-archive:
3138         (unzipArchive):
3139         For loops need a colon.
3140
3141 2015-09-15  Alex Christensen  <achristensen@webkit.org>
3142
3143         Fix Windows test bots after changing to non-cygwin build
3144         https://bugs.webkit.org/show_bug.cgi?id=149196
3145
3146         Reviewed by Daniel Bates.
3147
3148         * BuildSlaveSupport/built-product-archive:
3149         (unzipArchive):
3150         Using different versions of python makes what I think is https://bugs.python.org/issue15795
3151         prevent us from executing files from the archive on the test bots.
3152
3153 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
3154
3155         Add ShadowRoot interface and Element.prototype.attachShadow
3156         https://bugs.webkit.org/show_bug.cgi?id=149187
3157
3158         Reviewed by Antti Koivisto.
3159
3160         * Scripts/webkitperl/FeatureList.pm:
3161
3162 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
3163
3164         Appscale queue status json output lacks bots
3165         https://bugs.webkit.org/show_bug.cgi?id=149194
3166         <rdar://problem/22171089>
3167
3168         Reviewed by Alexey Proskuryakov.
3169
3170         * QueueStatusServer/handlers/queuestatusjson.py:
3171         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3172         * QueueStatusServer/index.yaml: Index according to appscale requirements.
3173
3174 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
3175
3176         [Win] Provide a means for viewing the layer tree
3177         https://bugs.webkit.org/show_bug.cgi?id=149165
3178
3179         Reviewed by Simon Fraser.
3180
3181         Update MiniBrowser with a new Debug menu option that will
3182         dump the current layer tree to the debug console.
3183         
3184         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3185         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3186         * MiniBrowser/win/Common.cpp:
3187         (WndProc): Add handler for 'Print Layer Tree' menu option.
3188         * MiniBrowser/win/MiniBrowser.cpp:
3189         (MiniBrowser::printLayerTree): Added Handler.
3190         * MiniBrowser/win/MiniBrowser.h:
3191
3192 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
3193
3194         WebKitTestRunner declarative language setting is broken for iOS
3195         https://bugs.webkit.org/show_bug.cgi?id=149119
3196
3197         Unreviewed.
3198
3199         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3200         lost in the final version which got committed. This simply implements the existing
3201         OS X behavior on iOS.
3202
3203         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3204         (WTR::InjectedBundle::platformInitialize):
3205
3206 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
3207
3208         Unreviewed, add myself to committers list.
3209
3210         * Scripts/webkitpy/common/config/contributors.json:
3211
3212 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3213
3214         [Cocoa] Allow testing with the system language
3215         https://bugs.webkit.org/show_bug.cgi?id=148671
3216
3217         Reviewed by Anders Carlsson and Alexey Proskuryakov.
3218
3219         React to tests marked with language=lang1,lang2,etc in their header.
3220         Once this information is parsed, pass it to
3221         WKContextConfigurationSetOverrideLanguages().
3222
3223         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3224         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3225         list.
3226         * WebKitTestRunner/TestController.cpp:
3227         (WTR::TestController::createWebViewWithOptions): Call
3228         WKContextConfigurationSetOverrideLanguages().
3229         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3230         * WebKitTestRunner/TestOptions.h:
3231         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3232         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3233         option to restart the web process.
3234         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3235         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3236
3237 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3238
3239         [WKTR] Allow changing the WKContextConfiguration between successive tests
3240         https://bugs.webkit.org/show_bug.cgi?id=148833
3241
3242         Reviewed by Tim Horton.
3243
3244         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3245         However, there are certain tests which require specifying options in this object. This patch makes
3246         our existing code for recreating the test runner web view also recreate the WKContext.
3247
3248         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3249         class.
3250
3251         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3252         * WebKitTestRunner/PlatformWebView.h:
3253         (WTR::PlatformWebView::options):
3254         * WebKitTestRunner/TestController.cpp:
3255         (WTR::TestController::initialize):
3256         (WTR::TestController::generateContextConfiguration):
3257         (WTR::TestController::generatePageConfiguration):
3258         (WTR::TestController::createWebViewWithOptions):
3259         (WTR::TestController::ensureViewSupportsOptionsForTest):
3260         (WTR::updateContextConfigurationOptionsFromTestHeader):
3261         (WTR::TestController::contextConfigurationOptionsForTest):
3262         (WTR::TestController::platformCreateWebView):
3263         (WTR::TestController::platformCreateOtherPage):
3264         (WTR::updateViewOptionsFromTestHeader): Deleted.
3265         (WTR::TestController::viewOptionsForTest): Deleted.
3266         * WebKitTestRunner/TestController.h:
3267         (WTR::TestController::injectedBundlePath):
3268         (WTR::TestController::testPluginDirectory):
3269         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3270         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3271         (WTR::TestController::platformCreateWebView):
3272         (WTR::TestController::platformCreateOtherPage):
3273         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3274         (WTR::PlatformWebView::PlatformWebView):
3275         (WTR::PlatformWebView::viewSupportsOptions):
3276         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3277         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3278         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3279         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3280         (WTR::PlatformWebView::PlatformWebView):
3281         (WTR::PlatformWebView::viewSupportsOptions):
3282         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3283         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3284         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3285         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3286         (WTR::PlatformWebView::PlatformWebView):
3287         (WTR::PlatformWebView::viewSupportsOptions):
3288         * WebKitTestRunner/ios/TestControllerIOS.mm:
3289         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3290         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3291         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3292         (WTR::PlatformWebView::PlatformWebView):
3293         (WTR::PlatformWebView::viewSupportsOptions):
3294         * WebKitTestRunner/mac/TestControllerMac.mm:
3295         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3296         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3297
3298 2015-09-11  Michael Saboff  <msaboff@apple.com>
3299
3300         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
3301         https://bugs.webkit.org/show_bug.cgi?id=149083
3302
3303         Reviewed by Alexey Proskuryakov.
3304
3305         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
3306
3307         * DumpRenderTree/mac/LayoutTestHelper.m:
3308         (colorProfileURLForDisplay):
3309
3310 2015-09-11  Saam barati  <sbarati@apple.com>
3311
3312         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
3313         https://bugs.webkit.org/show_bug.cgi?id=149058
3314
3315         Reviewed by Geoffrey Garen.
3316
3317         * Scripts/run-jsc-stress-tests:
3318
3319 2015-09-10  Commit Queue  <commit-queue@webkit.org>
3320
3321         Unreviewed, rolling out r189595.
3322         https://bugs.webkit.org/show_bug.cgi?id=149052
3323
3324         The tests still fail (Requested by ap on #webkit).
3325
3326         Reverted changeset:
3327
3328         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
3329         error -1"
3330         https://bugs.webkit.org/show_bug.cgi?id=142929
3331         http://trac.webkit.org/changeset/189595
3332
3333 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
3334
3335         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
3336         https://bugs.webkit.org/show_bug.cgi?id=142929
3337
3338         Reviewed by Brent Fulgham.
3339
3340         Silence the logging. We'll track fixing the root cause in Radar.
3341
3342         * Scripts/webkitpy/port/mac.py:
3343         (MacPort.stderr_patterns_to_strip): Added a FIXME.
3344
3345         * Scripts/webkitpy/port/win.py:
3346         (WinPort.logging_patterns_to_strip): Added.
3347
3348 2015-09-09  Andy Estes  <aestes@apple.com>
3349
3350         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
3351         https://bugs.webkit.org/show_bug.cgi?id=149022
3352
3353         Reviewed by Daniel Bates.
3354
3355         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
3356         did not account for this.
3357
3358         * Scripts/webkitpy/xcode/simulator.py:
3359         (Simulator): Optionally matched a revision at the end of a runtime version number.
3360         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
3361
3362 2015-09-09  Andy Estes  <aestes@apple.com>
3363
3364         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
3365         https://bugs.webkit.org/show_bug.cgi?id=149029
3366         <rdar://problem/22432624>
3367
3368         Reviewed by Daniel Bates.
3369
3370         * Scripts/webkitpy/xcode/simulator.py:
3371         (Simulator): Taught to parse tvOS runtimes.
3372         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3373
3374 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3375
3376         Fix bit rot on bot watcher's dashboard page
3377         https://bugs.webkit.org/show_bug.cgi?id=149012
3378
3379         Reviewed by Tim Horton.
3380
3381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3382         The code path used by the metrics page was trying to add properties to an undefined.
3383
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3385         Silence an expection that would occur when the step has no logs. This should never
3386         happen, but it did (perhaps buildbot was misconfigured for a while).
3387
3388 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3389
3390         Update LayoutTestRelay xcconfig file.
3391
3392         Rubber-stamped by Dan Bernstein.
3393
3394         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3395
3396 2015-09-09  Saam barati  <sbarati@apple.com>
3397
3398         DFG should have a debugging option that runs a phase that flushes all locals
3399         https://bugs.webkit.org/show_bug.cgi?id=148916
3400
3401         Reviewed by Filip Pizlo.
3402
3403         * Scripts/run-jsc-stress-tests:
3404
3405 2015-09-09  Commit Queue  <commit-queue@webkit.org>
3406
3407         Unreviewed, rolling out r189530 and r189534.
3408         https://bugs.webkit.org/show_bug.cgi?id=148996
3409
3410         Caused assertion failures on Yosemite (Requested by litherum
3411         on #webkit).
3412
3413         Reverted changesets:
3414
3415         "[WKTR] Allow changing the WKContextConfiguration between
3416         successive tests"
3417         https://bugs.webkit.org/show_bug.cgi?id=148833
3418         http://trac.webkit.org/changeset/189530
3419
3420         "[Cocoa] Fix the tests after r189530"
3421         http://trac.webkit.org/changeset/189534
3422
3423 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3424
3425         [Cocoa] Fix the tests after r189530
3426
3427         Unreviewed.
3428
3429         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3430         (WTR::initializeWebViewConfiguration):
3431
3432 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3433
3434         [WKTR] Allow changing the WKContextConfiguration between successive tests
3435         https://bugs.webkit.org/show_bug.cgi?id=148833
3436
3437         Reviewed by Tim Horton.
3438
3439         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3440         However, there are certain tests which require specifying options in this object. This patch makes
3441         our existing code for recreating the test runner web view also recreate the WKContext.
3442
3443         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3444         class.
3445
3446         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3447         * WebKitTestRunner/PlatformWebView.h:
3448         (WTR::PlatformWebView::options):
3449         * WebKitTestRunner/TestController.cpp:
3450         (WTR::TestController::initialize):
3451         (WTR::TestController::generateContextConfiguration):
3452         (WTR::TestController::generatePageConfiguration):
3453         (WTR::TestController::createWebViewWithOptions):
3454         (WTR::TestController::ensureViewSupportsOptionsForTest):
3455         (WTR::updateContextConfigurationOptionsFromTestHeader):
3456         (WTR::TestController::contextConfigurationOptionsForTest):
3457         (WTR::TestController::platformCreateWebView):
3458         (WTR::TestController::platformCreateOtherPage):
3459         (WTR::updateViewOptionsFromTestHeader): Deleted.
3460         (WTR::TestController::viewOptionsForTest): Deleted.
3461         * WebKitTestRunner/TestController.h:
3462         (WTR::TestController::injectedBundlePath):
3463         (WTR::TestController::testPluginDirectory):
3464         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3465         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3466         (WTR::TestController::platformCreateWebView):
3467         (WTR::TestController::platformCreateOtherPage):
3468         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3469         (WTR::PlatformWebView::PlatformWebView):
3470         (WTR::PlatformWebView::viewSupportsOptions):
3471         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3472         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3473         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3474         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3475         (WTR::PlatformWebView::PlatformWebView):
3476         (WTR::PlatformWebView::viewSupportsOptions):
3477         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3478         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3479         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3480         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3481         (WTR::PlatformWebView::PlatformWebView):
3482         (WTR::PlatformWebView::viewSupportsOptions):
3483         * WebKitTestRunner/ios/TestControllerIOS.mm:
3484         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3485         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3486         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3487         (WTR::PlatformWebView::PlatformWebView):
3488         (WTR::PlatformWebView::viewSupportsOptions):
3489         * WebKitTestRunner/mac/TestControllerMac.mm:
3490         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3491         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3492
3493 2015-09-08  Daniel Bates  <dabates@apple.com>
3494
3495         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
3496         https://bugs.webkit.org/show_bug.cgi?id=148980
3497
3498         Reviewed by Alexey Proskuryakov.
3499
3500         Add setting to enable/disable accelerated drawing so as to support testing
3501         this feature in MiniBrowser on Mac.
3502
3503         * MiniBrowser/mac/SettingsController.h:
3504         * MiniBrowser/mac/SettingsController.m:
3505         (-[SettingsController _populateMenu]): Add menu item.
3506         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
3507         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
3508         (-[SettingsController acceleratedDrawingEnabled]): Added.
3509         * MiniBrowser/mac/WK1BrowserWindowController.m:
3510         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
3511         * MiniBrowser/mac/WK2BrowserWindowController.m:
3512         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
3513
3514 2015-09-08  Jason Marcell  <jmarcell@apple.com>
3515
3516         Unreviewed. Added myself as a commiter in contributors.json.
3517
3518         * Scripts/webkitpy/common/config/contributors.json:
3519
3520 2015-09-08  Keith Miller  <keith_miller@apple.com>
3521
3522         Unreviewed, added myself to the list of contributors.
3523
3524         * Scripts/webkitpy/common/config/contributors.json:
3525
3526 2015-09-08  Daniel Bates  <dabates@apple.com>
3527
3528         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
3529         https://bugs.webkit.org/show_bug.cgi?id=148921
3530
3531         Reviewed by Alexey Proskuryakov.
3532
3533         The ring image is positioned above the platform icon in markup and we specify the CSS
3534         property z-index for the ring image so that it is painted on top of the platform icon
3535         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
3536         of the ring image, switch the order of these DOM elements and remove the use of the CSS
3537         property z-index to achieve a similar effect.
3538
3539         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3540         (documentReady): Create the platform icon image element before the ring image such that
3541         the ring image is painted on top of the platform icon.
3542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3543         (table.queue-grid td.logo img.ring): Removed property z-index.
3544
3545 2015-09-08  Daniel Bates  <dabates@apple.com>
3546
3547         Dashboard: Remove duplicate gear icon data URLs
3548         https://bugs.webkit.org/show_bug.cgi?id=148920
3549
3550         Reviewed by Alexey Proskuryakov.
3551
3552         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
3553         background-image associated with each of the three gear icon states: collapsed (.settings), hover
3554         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
3555         as a mask and make use of the CSS background-color to define the fill color for each of these three
3556         states.
3557
3558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3559         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
3560         (.settings:hover): Override CSS background-color for hover state.
3561         (.settings-visible .settings): Override CSS background-color for expanded state.
3562
3563 2015-09-07  Andy Estes  <aestes@apple.com>
3564
3565         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
3566         https://bugs.webkit.org/show_bug.cgi?id=148946
3567         <rdar://problem/22603981>
3568
3569         Reviewed by Dan Bernstein.
3570
3571         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3572         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3573
3574 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
3575
3576         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
3577         https://bugs.webkit.org/show_bug.cgi?id=148927
3578
3579         Reviewed by Csaba Osztrogonác.
3580
3581         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3582         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
3583
3584         * WebKitTestRunner/TestController.cpp:
3585         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
3586         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3587         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
3588
3589 2015-09-07  Andy Estes  <aestes@apple.com>
3590
3591         Fix the Production build after r189455.
3592
3593         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
3594         In-App Purchase template instead of the Aggregate template. Whoops.
3595
3596 2015-09-06  Andy Estes  <aestes@apple.com>
3597
3598         WebKit.xcworkspace should be be able to build iOS platforms
3599         https://bugs.webkit.org/show_bug.cgi?id=148881
3600
3601         Reviewed by Daniel Bates.
3602
3603         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
3604         for all supported platforms.
3605
3606         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
3607         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
3608         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
3609         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
3610
3611 2015-09-06  Andy Estes  <aestes@apple.com>
3612
3613         WebKitTestRunner should build for iOS using the default target
3614         https://bugs.webkit.org/show_bug.cgi?id=148918
3615
3616         Reviewed by Daniel Bates.
3617
3618         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
3619         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
3620         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
3621
3622         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
3623         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
3624         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
3625         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
3626         WebKitTestRunner is skipped when installing on iOS.
3627
3628         The target dependency graph now looks like this:
3629
3630             All
3631                 WebKitTestRunnerApp
3632                     WebKitTestRunner (Library)
3633                         WebKitTestRunnerInjectedBundle
3634                             Derived Sources
3635                 WebKitTestRunner
3636                     WebKitTestRunner (Library)
3637                         WebKitTestRunnerInjectedBundle
3638                             Derived Sources
3639
3640         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
3641         * Scripts/build-webkittestrunner: Ditto.
3642         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
3643         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
3644         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
3645         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
3646         excluded iOS-only files, and skipped installing on iOS.
3647         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
3648         excluded Mac-only files, and skipped installing on Mac.
3649         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
3650         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
3651         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
3652         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
3653         new configuration files.
3654
3655 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
3656
3657         Web Inspector: Improve prepare-ChangeLog for multiple cases
3658         https://bugs.webkit.org/show_bug.cgi?id=148875
3659
3660         Reviewed by Timothy Hatcher.
3661
3662         * Scripts/prepare-ChangeLog:
3663         (get_function_line_ranges_for_javascript):
3664         - We were ignoring everything inside of an anonymous function expression,
3665           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
3666           Better handle this by inserting a few tweaks.
3667         - Allow method syntax outside of classes as long as they are at the global level.
3668         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
3669
3670         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3671         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3672         (Foo.prototype.method1):
3673         (Foo.prototype.method2):
3674         (Foo.prototype.method3.innerFunction):
3675         (Foo.prototype.method3):
3676         (insideGlobalAnonymousFunctionExpression):
3677         (foo.insideGlobalFunctionExpression):
3678         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
3679         (IssueWithMapGetAndSet.prototype.method1):
3680         (IssueWithMapGetAndSet.prototype.method2):
3681         (IssueWithMapGetAndSet.prototype.method3):
3682         (IssueWithMapGetAndSet):
3683
3684 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3685
3686         [ES6] Enable ES6 Module in JSC shell by default
3687         https://bugs.webkit.org/show_bug.cgi?id=148689
3688
3689         Reviewed by Geoffrey Garen.
3690
3691         * Scripts/run-javascriptcore-tests:
3692         (runJSCStressTests):
3693         * Scripts/run-jsc-stress-tests:
3694
3695 2015-09-04  Basile Clement  <basile_clement@apple.com>
3696
3697         Unreviewed, change my email address.
3698
3699         * Scripts/webkitpy/common/config/contributors.json:
3700
3701 2015-09-04  Beth Dakin  <bdakin@apple.com>
3702
3703         Should have a test to make sure links don't navigate after a cancelled force 
3704         click
3705         https://bugs.webkit.org/show_bug.cgi?id=148846
3706
3707         Reviewed by Tim Horton.
3708
3709         New EventSender function for a started then cancelled force click.
3710         * WebKitTestRunner/EventSenderProxy.h:
3711         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3712         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3713         (WTR::EventSendingController::mouseForceClick):
3714         (WTR::EventSendingController::startAndCancelMouseForceClick):
3715         (WTR::EventSendingController::mouseForceDown):
3716         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3717         * WebKitTestRunner/TestController.cpp:
3718         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3719         * WebKitTestRunner/mac/EventSenderProxy.mm:
3720         (WTR::EventSenderProxy::mouseForceClick):
3721         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3722         (WTR::EventSenderProxy::mouseForceDown):
3723         (WTR::EventSenderProxy::mouseMoveTo):
3724
3725 2015-09-04  Tim Horton  <timothy_horton@apple.com>
3726
3727         Add a test for r179736 (programmatic navigation during swipe causing a crash)
3728         https://bugs.webkit.org/show_bug.cgi?id=148830
3729
3730         Reviewed by Beth Dakin.
3731
3732         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3733         (WTR::InjectedBundle::beginTesting):
3734         Make sure that TestRunner callbacks don't leak between tests!
3735
3736 2015-09-04  Anders Carlsson  <andersca@apple.com>
3737
3738         It should be possible to pass relative HTTP test paths to DumpRenderTree
3739         https://bugs.webkit.org/show_bug.cgi?id=148825
3740         <rdar://problem/22583866>
3741
3742         Reviewed by Tim Horton.
3743
3744         Convert the path to an absolute path if needed.
3745
3746         * DumpRenderTree/mac/DumpRenderTree.mm:
3747         (computeTestURL):
3748
3749 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3750
3751         Fix Swift unit tests for prepare-ChangeLog.
3752         https://bugs.webkit.org/show_bug.cgi?id=148817
3753
3754         Reviewed by Alexey Proskuryakov.
3755
3756         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
3757         Swift unit tests for prepare-ChangeLog.
3758
3759 2015-09-04  Lucas Forschler  <lforschler@apple.com>
3760
3761         Modifications to the webkit-nightly logic.
3762         
3763         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3764         (updateAlertPanel):
3765         * WebKitLauncher/main.m:
3766         (displayErrorAndQuit):
3767
3768 2015-09-04  Beth Dakin  <bdakin@apple.com>
3769
3770         Speculative build fix.
3771
3772         * WebKitTestRunner/mac/EventSenderProxy.mm:
3773
3774 2015-09-04  Brian Burg  <bburg@apple.com>
3775
3776         Web Inspector: InspectorController should support multiple frontend channels
3777         https://bugs.webkit.org/show_bug.cgi?id=148538
3778
3779         Reviewed by Joseph Pecoraro.
3780
3781         InspectorClients must explicitly disconnect their frontend channel(s) from the
3782         inspected page's InspectorController.
3783
3784         To make this possible, DumpRenderTree should not destroy non-primary views until
3785         it has tried to close any abandoned Web Inspector instances. Performing teardown
3786         in the reverse order prevents disconnection of the frontend channel because that
3787         prematurely destroys the inspector frontend client.
3788
3789         * DumpRenderTree/mac/DumpRenderTree.mm:
3790         (runTest):
3791         * DumpRenderTree/win/DumpRenderTree.cpp:
3792         (runTest):
3793
3794 2015-09-04  Beth Dakin  <bdakin@apple.com>
3795
3796         Need to be able to test default behaviors on force click
3797         https://bugs.webkit.org/show_bug.cgi?id=148758
3798
3799         Reviewed by Tim Horton.
3800
3801         This patch adds a new eventSender method to do a full, completed force click, 
3802         and it re-works all of the existing force methods to dispatch their events in 
3803         such a way that they will trigger the NSImmediateAction gesture recognizer. 
3804         To do this, first we need to send the events to the app rather than straight 
3805         to the view, and also needed to tweak some state and send the events in a 
3806         delayed fashion.
3807
3808         New public function mouseForceClick() and private helper functions to make 
3809         NSEvents.
3810         * WebKitTestRunner/EventSenderProxy.h:
3811
3812         New public function mouseForceClick().
3813         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3814         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3815         (WTR::EventSendingController::mouseMoveTo):
3816         (WTR::EventSendingController::mouseForceClick):
3817         (WTR::EventSendingController::mouseForceDown):
3818         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3819         * WebKitTestRunner/TestController.cpp:
3820         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3821
3822         initPressureEventAtLocation needs to take a stageTransition and a window.
3823         * WebKitTestRunner/mac/EventSenderProxy.mm:
3824         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3825         (-[EventSenderSyntheticEvent stageTransition]):
3826         (-[EventSenderSyntheticEvent timestamp]):
3827         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3828         (-[EventSenderSyntheticEvent window]):
3829
3830         In order to enter the gesture recognizer, we need to start with a mouse down 
3831         that has a NSEventMaskPressure modifier.
3832         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3833
3834         This ensures that the events queue properly for the force monitor in AppKit.
3835         (WTR::spinRunLoopForForce):
3836
3837          We need to start the pressure change events with a began.
3838         (WTR::EventSenderProxy::beginPressureEvent):
3839
3840         These functions can be used to create the NSEvent for a pressure change every 
3841         time we need one.
3842         (WTR::EventSenderProxy::pressureChangeEvent):
3843
3844         Send the right series of events to emulate a full, completed force click.
3845         (WTR::EventSenderProxy::mouseForceClick):
3846
3847         Use all of the new things for these existing functions.
3848         (WTR::EventSenderProxy::mouseForceDown):
3849         (WTR::EventSenderProxy::mouseForceUp):
3850         (WTR::EventSenderProxy::mouseForceChanged):
3851
3852         Set NSFakeForceTouchDevice to YES.
3853         * WebKitTestRunner/mac/main.mm:
3854         (setDefaultsToConsistentValuesForTesting):
3855
3856 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3857
3858         prepare-ChangeLog needs to know how to parse Swift files.
3859         https://bugs.webkit.org/show_bug.cgi?id=148784
3860         <rdar://problem/22510062>
3861
3862         Reviewed by Darin Adler.
3863
3864         * Scripts/prepare-ChangeLog:
3865         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
3866         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
3867         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
3868         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3869         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
3870         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
3871         (freeFunction): Ditto.
3872         (MyClass.function): Ditto.
3873         (MyClass.functionWithArgument(_:)): Ditto.
3874         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
3875         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
3876         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
3877         (MyClass.classFunction): Ditto.
3878         (MyClass.readWriteComputedVariable): Ditto.
3879         (MyClass.readOnlyComputedVariable): Ditto.
3880
3881 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
3882
3883         Import css/css-color-3
3884         https://bugs.webkit.org/show_bug.cgi?id=148803
3885
3886         Reviewed by Chris Dumez.
3887
3888         Fixed a bug that the imported reference files used the same extention as tests.
3889         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
3890
3891         * Scripts/webkitpy/w3c/test_importer.py:
3892         (TestImporter.find_importable_tests):
3893
3894 2015-09-03  Commit Queue  <commit-queue@webkit.org>
3895
3896         Unreviewed, rolling out r189338.
3897         https://bugs.webkit.org/show_bug.cgi?id=148785
3898
3899         Caused tons of crashes (Requested by cdumez on #webkit).
3900
3901         Reverted changeset:
3902
3903         "Web Inspector: InspectorController should support multiple
3904         frontend channels"
3905         https://bugs.webkit.org/show_bug.cgi?id=148538
3906         http://trac.webkit.org/changeset/189338
3907
3908 2015-09-03  Brian Burg  <bburg@apple.com>
3909
3910         Web Inspector: InspectorController should support multiple frontend channels
3911         https://bugs.webkit.org/show_bug.cgi?id=148538
3912
3913         Reviewed by Joseph Pecoraro.
3914
3915         InspectorClients must explicitly disconnect their frontend channel(s) from the
3916         inspected page's InspectorController.
3917
3918         To make this possible, DumpRenderTree should not destroy non-primary views until
3919         it has tried to close any abandoned Web Inspector instances. Performing teardown
3920         in the reverse order prevents disconnection of the frontend channel because that
3921         prematurely destroys the inspector frontend client.
3922
3923         * DumpRenderTree/mac/DumpRenderTree.mm:
3924         (runTest):
3925         * DumpRenderTree/win/DumpRenderTree.cpp:
3926         (runTest):
3927
3928 2015-09-03  Timothy Hatcher  <timothy@apple.com>
3929
3930         Update WebKit nightly icon to be more like Safari
3931         https://bugs.webkit.org/show_bug.cgi?id=148768
3932
3933         Reviewed by Joseph Pecoraro.
3934
3935         * WebKitLauncher/webkit.icns:
3936
3937 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
3938
3939         JavaScriptCore should have some ES6 conformance tests
3940         https://bugs.webkit.org/show_bug.cgi?id=148771
3941
3942         Reviewed by Chris Dumez.
3943
3944         * Scripts/run-javascriptcore-tests:
3945         (runJSCStressTests): Added es6 as a test suite.
3946
3947         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
3948
3949         Some of these tests currently fail, so I also added a way to expect
3950         failure for now. We'll migrate failing tests to expected passes as we
3951         fix them.
3952
3953 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3954
3955         Add a test for swipe-start hysteresis
3956         https://bugs.webkit.org/show_bug.cgi?id=148756
3957
3958         Reviewed by Anders Carlsson.
3959
3960         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3961         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3962         (WTR::cacheTestRunnerCallback):
3963         (WTR::TestRunner::clearTestRunnerCallbacks):
3964         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3965         Make sure that we log if a client tries to install a callback twice
3966         (since we use .add, the second call would not work).
3967
3968         Also, add clearTestRunnerCallbacks so tests can swap out installed
3969         callbacks.
3970
3971 2015-09-03  Anders Carlsson  <andersca@apple.com>
3972
3973         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
3974         https://bugs.webkit.org/show_bug.cgi?id=148746
3975         rdar://problem/22568073
3976
3977         Reviewed by Tim Horton.
3978
3979         * DumpRenderTree/mac/DumpRenderTree.mm:
3980         (computeTestURL):
3981         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
3982
3983         (runTest):
3984         Call computeTestURL.
3985
3986         (testPathFromURL):
3987         Get rid of this; computeTestURL does this for us now.
3988
3989         * Scripts/webkitpy/port/driver.py:
3990         (Driver._command_from_driver_input):
3991         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
3992
3993 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3994
3995         Swipe tests fail on Mavericks
3996         https://bugs.webkit.org/show_bug.cgi?id=148752
3997
3998         Reviewed by Beth Dakin.
3999
4000         * WebKitTestRunner/mac/EventSenderProxy.mm:
4001
4002 2015-09-03  Tim Horton  <timothy_horton@apple.com>
4003
4004         Fix the 32-bit build
4005
4006         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4007         (WTR::PlatformWebView::setNavigationGesturesEnabled):
4008
4009 2015-09-03  Tim Horton  <timothy_horton@apple.com>
4010
4011         Remove some logging that wasn't meant to be in the tree
4012
4013         * WebKitTestRunner/mac/EventSenderProxy.mm:
4014         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
4015
4016 2015-09-03  Tim Horton  <timothy_horton@apple.com>
4017
4018         [Mac] Add support for testing swipes
4019         https://bugs.webkit.org/show_bug.cgi?id=148700
4020
4021         Reviewed by Beth Dakin.
4022
4023         * WebKitTestRunner/EventSenderProxy.h:
4024         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4025         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4026         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4027         (WTR::cgEventPhaseFromString):
4028         (WTR::cgEventMomentumPhaseFromString):
4029         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
4030         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
4031         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4032         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4033         (WTR::InjectedBundle::didReceiveMessageToPage):
4034         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4035         (WTR::TestRunner::installDidBeginSwipeCallback):
4036         (WTR::TestRunner::installWillEndSwipeCallback):
4037         (WTR::TestRunner::installDidEndSwipeCallback):
4038         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
4039         (WTR::TestRunner::callDidBeginSwipeCallback):
4040         (WTR::TestRunner::callWillEndSwipeCallback):
4041         (WTR::TestRunner::callDidEndSwipeCallback):
4042         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
4043         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4044         * WebKitTestRunner/TestController.cpp:
4045         (WTR::TestController::createOtherPage):
4046         (WTR::TestController::createWebViewWithOptions):
4047         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4048         (WTR::TestController::didBeginNavigationGesture):
4049         (WTR::TestController::willEndNavigationGesture):
4050         (WTR::TestController::didEndNavigationGesture):
4051         (WTR::TestController::didRemoveNavigationGestureSnapshot):
4052         * WebKitTestRunner/TestController.h:
4053         * WebKitTestRunner/TestInvocation.cpp:
4054         (WTR::TestInvocation::didBeginSwipe):
4055         (WTR::TestInvocation::willEndSwipe):
4056         (WTR::TestInvocation::didEndSwipe):
4057         (WTR::TestInvocation::didRemoveSwipeSnapshot):
4058         * WebKitTestRunner/TestInvocation.h:
4059         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
4060         when the snapshot is removed.
4061
4062         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
4063         mouseScrollBy function.
4064
4065         * WebKitTestRunner/mac/EventSenderProxy.mm:
4066         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
4067         (-[EventSenderSyntheticEvent type]):
4068         (-[EventSenderSyntheticEvent subtype]):
4069         (-[EventSenderSyntheticEvent locationInWindow]):
4070         (-[EventSenderSyntheticEvent location]):
4071         (-[EventSenderSyntheticEvent momentumPhase]):
4072         (-[EventSenderSyntheticEvent _isTouchesEnded]):
4073         (-[EventSenderSyntheticEvent _cgsEventRecord]):
4074         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
4075         more adjustable values.
4076
4077         (WTR::EventSenderProxy::mouseForceDown):
4078         (WTR::EventSenderProxy::mouseForceUp):
4079         (WTR::EventSenderProxy::mouseForceChanged):
4080         Adopt EventSenderSyntheticEvent.
4081
4082         (WTR::nsEventPhaseFromCGEventPhase):
4083         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
4084         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
4085
4086         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4087         (WTR::PlatformWebView::PlatformWebView):
4088         Enable swipe.
4089
4090 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
4091
4092         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
4093         https://bugs.webkit.org/show_bug.cgi?id=148723
4094
4095         Reviewed by Anders Carlsson.
4096
4097         * WebKitTestRunner/TestController.cpp:
4098         (WTR::testPath):
4099         (WTR::updateViewOptionsFromTestHeader):
4100         (WTR::TestController::viewOptionsForTest):
4101
4102 2015-09-03  Lucas Forschler  <lforschler@apple.com>
4103
4104         Test commit.
4105
4106 2015-09-02  Tim Horton  <timothy_horton@apple.com>
4107
4108         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
4109         https://bugs.webkit.org/show_bug.cgi?id=148693
4110
4111         Reviewed by Anders Carlsson.
4112
4113         * WebKitTestRunner/TestController.cpp:
4114         (WTR::TestController::createOtherPage):
4115         (WTR::TestController::createWebViewWithOptions):
4116
4117 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4118
4119         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
4120         https://bugs.webkit.org/show_bug.cgi?id=148529
4121
4122         Reviewed by Darin Adler.
4123
4124         When there are pending EventSender messages after a test finishes,
4125         they could be processed in the main loop started by the
4126         resetStateToConsistentValues(), but the old EventSender has been
4127         replaced by a new one at that point. The new Eventsender can crash
4128         when processing messages that were sent to the old one. To avoid
4129         this, we return early when receiving an EventSender message and
4130         the TestController state is not RunningTest.
4131
4132         * WebKitTestRunner/TestController.cpp:
4133         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
4134         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4135
4136 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4137
4138         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
4139         https://bugs.webkit.org/show_bug.cgi?id=148528
4140
4141         Reviewed by Darin Adler.
4142
4143         Before r188548 resetStateToConsistentValues() was called in
4144         TestController::run(), before tests are run, but now it's called
4145         for every test in TestInvocation::invoke(), after m_status has
4146         changed to RunningTest.
4147
4148         * WebKitTestRunner/TestController.cpp:
4149         (WTR::TestController::resetStateToConsistentValues): Use
4150         TemporaryChange to reset m_state ot its previous value after reset
4151         is done.
4152
4153 2015-08-31  Jason Marcell  <jmarcell@apple.com>
4154
4155         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
4156         that are marked as requiring corresponding tests.
4157         https://bugs.webkit.org/show_bug.cgi?id=148498
4158         <rdar://problem/21555314>
4159
4160         Reviewed by Dan Bernstein and David Kilzer.
4161
4162         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
4163         simulate Git's attribute behevaior.
4164         (main): Added "requiresTests" array to contain files that require tests.
4165         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
4166         section in ChangeLog.
4167         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
4168         however, we check if the file or any containing folder has the given property set to "1" and
4169         return 1 if so; return 0 otherwise.
4170         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
4171         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
4172
4173 2015-08-26  Andy Estes  <aestes@apple.com>
4174
4175         [Content Filtering] Determine navigation and content policy before continuing to filter a load
4176         https://bugs.webkit.org/show_bug.cgi?id=148506
4177
4178         Reviewed by Brady Eidson.
4179
4180         Added download API tests covering every decision and decision point.
4181         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
4182
4183         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
4184         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
4185         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
4186         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
4187         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
4188         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
4189         decision and decision point as a bundle parameter.
4190         (+[MockContentFilterEnabler supportsSecureCoding]):
4191         (-[MockContentFilterEnabler copyWithZone:]):
4192         (-[MockContentFilterEnabler initWithCoder:]):
4193         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
4194         (-[MockContentFilterEnabler encodeWithCoder:]):
4195         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
4196         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
4197         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
4198         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
4199         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
4200         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
4201         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
4202         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
4203         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
4204         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
4205         (+[MockContentFilterEnabler supportsSecureCoding]):
4206         (-[MockContentFilterEnabler copyWithZone:]):
4207         (-[MockContentFilterEnabler initWithCoder:]):
4208         (-[MockContentFilterEnabler dealloc]):
4209         (-[MockContentFilterEnabler encodeWithCoder:]):
4210         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
4211         (-[ContentFilteringPlugIn dealloc]): Stop observing.
4212         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
4213         (+[ServerRedirectPlugIn initialize]): Deleted.
4214         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4215         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4216         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
4217         (TEST): Deleted.
4218
4219 2015-08-31  Filip Pizlo  <fpizlo@apple.com>