43c79454e18119a86e36012135552bffa37fdc7a
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Use port 17000 for worker communication
4         https://bugs.webkit.org/show_bug.cgi?id=195558
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/master.cfg:
9
10 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
11
12         [ews-build] unit-tests fail when passwords.json is missing
13         https://bugs.webkit.org/show_bug.cgi?id=195557
14
15         Reviewed by Lucas Forschler.
16
17         * BuildSlaveSupport/ews-build/loadConfig.py:
18         (loadBuilderConfig):
19         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
20         (ConfigDotJSONTest.test_configuration):
21         * BuildSlaveSupport/ews-build/master.cfg:
22
23 2019-03-11  Truitt Savell  <tsavell@apple.com>
24
25         Unreviewed, rolling out r242702.
26
27         Broke High Sierra builders.
28
29         Reverted changeset:
30
31         "Add utility function to allow easy reverse range-based
32         iteration of a container"
33         https://bugs.webkit.org/show_bug.cgi?id=195542
34         https://trac.webkit.org/changeset/242702
35
36 2019-03-11  Sam Weinig  <sam@webkit.org>
37
38         Add utility function to allow easy reverse range-based iteration of a container
39         https://bugs.webkit.org/show_bug.cgi?id=195542
40
41         Reviewed by Antti Koivisto.
42
43         * TestWebKitAPI/CMakeLists.txt:
44         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
45         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
46         (TestWebKitAPI::TEST):
47         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
48
49 2019-03-10  Alex Christensen  <achristensen@webkit.org>
50
51         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
52         https://bugs.webkit.org/show_bug.cgi?id=195511
53         <rdar://problem/44873269>
54
55         Reviewed by Darin Adler.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
58         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
59         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
60         (TEST_F):
61
62 2019-03-10  Tim Horton  <timothy_horton@apple.com>
63
64         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
65         https://bugs.webkit.org/show_bug.cgi?id=195499
66
67         Reviewed by Darin Adler.
68
69         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
70         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
71         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
72         (-[WKWebView synchronouslyFocusTextInputContext:]):
73         (applyStyle):
74         (applyIframe):
75         (TEST):
76         Add some tests for this SPI.
77
78 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
79
80         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
81         https://bugs.webkit.org/show_bug.cgi?id=181151
82
83         Reviewed by Don Olmstead.
84
85         * TestWebKitAPI/CMakeLists.txt:
86         * TestWebKitAPI/PlatformWin.cmake:
87         Enable TestWTF RunLoop tests in all platforms.
88
89         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
90         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
91         (TestWebKitAPI::DerivedOneShotTimer::fired):
92         (TestWebKitAPI::TEST):
93         Only a few platforms support nested RunLoop.
94
95         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
96         (TestWebKitAPI::DerivedRepeatingTimer::fired):
97
98 2019-03-10  David Quesada  <david_quesada@apple.com>
99
100         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
101         https://bugs.webkit.org/show_bug.cgi?id=152480
102
103         Reviewed by Chris Dumez.
104
105         Add a unit test based on Daniel Bates's test case that starts a download, ensures
106         there are no additional references to the process pool besides the one held by
107         the download, waits for the download to finish (in the sense that the
108         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
109         measure, also check that the process pool has been deallocated at the end of the
110         test. The test wouldn't be meaningful if the process pool were still alive.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
113         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
114         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
115             The download will be canceled because the delegate does not implement the
116             method to decide the download's destination, so this is where we know the
117             DownloadProxyMap is done with the DownloadProxy.
118         (TEST):
119
120 2019-03-08  Chris Dumez  <cdumez@apple.com>
121
122         Add support for Device Orientation / Motion permission API
123         https://bugs.webkit.org/show_bug.cgi?id=195329
124         <rdar://problem/47645367>
125
126         Reviewed by Geoffrey Garen.
127
128         Add test infrastructure to help test the Device Orientation / Motion permission API.
129
130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
132         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
133         * WebKitTestRunner/InjectedBundle/TestRunner.h:
134         * WebKitTestRunner/TestController.cpp:
135         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
136         (WTR::TestController::createWebViewWithOptions):
137         (WTR::TestController::resetStateToConsistentValues):
138         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
139         * WebKitTestRunner/TestController.h:
140         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
141         * WebKitTestRunner/TestInvocation.cpp:
142         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
143
144 2019-03-08  Saam barati  <sbarati@apple.com>
145
146         Add a compare-results script to compare benchmark results
147         https://bugs.webkit.org/show_bug.cgi?id=195486
148         <rdar://problem/48723397>
149
150         Reviewed by Geoffrey Garen.
151
152         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
153         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
154         to extend it to learn about our other benchmarks.
155
156         * Scripts/compare-results: Added.
157         (readJSONFile):
158         (detectJetStream2):
159         (JetStream2Results):
160         (detectSpeedometer2):
161         (Speedometer2Results):
162         (detectPLT5):
163         (PLT5Results):
164         (detectBenchmark):
165         (biggerIsBetter):
166         (ttest):
167         (getOptions):
168         (main):
169
170 2019-03-08  Stephanie Lewis  <slewis@apple.com>
171
172         Ensure old tab state is cleared between iterations of run-benchmark
173         https://bugs.webkit.org/show_bug.cgi?id=195393
174         <rdar://problem/46885583>
175
176         Reviewed by Dewei Zhu.
177
178         a) ensure the default to restore state is not set
179         b) terminate Safari correctly
180         c) Set the system default to ignore Persistent State in Safari
181
182         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
183         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
184         (OSXBrowserDriver.prepare_env): 
185         (OSXBrowserDriver.restore_env):
186         (OSXBrowserDriver.close_browsers):
187         (OSXBrowserDriver._terminate_processes):
188         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
189         (OSXChromeDriver):
190         (OSXChromeCanaryDriver):
191         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
192         (OSXFirefoxDriver):
193         (OSXFirefoxNightlyDriver):
194         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
195         (OSXSafariDriver):
196         (OSXSafariDriver.prepare_env):
197
198 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
199
200         [GTK] Several InputMethodFilter tests are failing
201         https://bugs.webkit.org/show_bug.cgi?id=195408
202
203         Reviewed by Carlos Garcia Campos.
204
205         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
206         Regressed in r241751.
207         Hexadecimal values of keycodes are expressed now in upper letters.
208         Composited characters should be cast to UTF8 strings.
209
210         (TestWebKitAPI::TEST):
211
212 2019-03-07  Tomas Popela  <tpopela@redhat.com>
213
214         [GTK] Make Tools/gtkdoc python3 compatible
215         https://bugs.webkit.org/show_bug.cgi?id=195359
216
217         Reviewed by Carlos Garcia Campos.
218
219         * gtkdoc/generate-gtkdoc:
220         ConfigParser was reworked in Python 3.2 so we have adapt the code to
221         work with Python 2 and 3.
222         (get_gtkdoc_module_paths):
223         The iteritems() was removed in Python 3, so let's use items() that's
224         available in Python 2 and 3.
225         (get_generator_for_config):
226         * gtkdoc/gtkdoc.py:
227         (GTKDoc._run_command):
228         The sys.stdout.write() is expecting str in Python 3 and not bytes
229         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
230         for passing the bytes there.
231
232 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
233
234         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
235         https://bugs.webkit.org/show_bug.cgi?id=195346
236         <rdar://problem/48667048>
237
238         Unreviewed build fix for clang-cl.
239
240         * DumpRenderTree/win/DumpRenderTree.cpp:
241         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
242
243 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
244
245         requestAnimationFrame should execute before the next frame
246         https://bugs.webkit.org/show_bug.cgi?id=177484
247
248         Reviewed by Simon Fraser.
249
250         Add trace points for the page RenderingUpdate.
251
252         * Tracing/SystemTracePoints.plist:
253
254 2019-03-07  Zalan Bujtas  <zalan@apple.com>
255
256         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
257         https://bugs.webkit.org/show_bug.cgi?id=195353
258         <rdar://problem/48626394>
259
260         Reviewed by Simon Fraser.
261
262         * WebKitTestRunner/ios/TestControllerIOS.mm:
263         (WTR::TestController::platformResetPreferencesToConsistentValues):
264
265 2019-03-07  John Wilander  <wilander@apple.com>
266
267         Resource Load Statistics: Make it possible to purge only script-accessible cookies
268         https://bugs.webkit.org/show_bug.cgi?id=195383
269         <rdar://problem/48570136>
270
271         Reviewed by Brent Fulgham.
272
273         This patch adds test infrastructure to purge only script-accessible cookies,
274         including a new testRunner function called statisticsDeleteCookiesForHost().git a
275
276         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
277         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
278         (WTR::TestRunner::statisticsDeleteCookiesForHost):
279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
280         * WebKitTestRunner/TestController.cpp:
281         (WTR::TestController::statisticsDeleteCookiesForHost):
282         * WebKitTestRunner/TestController.h:
283         * WebKitTestRunner/TestInvocation.cpp:
284         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
285
286 2019-03-07  Commit Queue  <commit-queue@webkit.org>
287
288         Unreviewed, rolling out r242354.
289         https://bugs.webkit.org/show_bug.cgi?id=195402
290
291         breaks layout tests in all configurations (Requested by
292         zdobersek on #webkit).
293
294         Reverted changeset:
295
296         "[WPE] Enable web process sandbox"
297         https://bugs.webkit.org/show_bug.cgi?id=195169
298         https://trac.webkit.org/changeset/242354
299
300 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
301
302         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
303         https://bugs.webkit.org/show_bug.cgi?id=195346
304
305         Reviewed by Fujii Hironori.
306
307         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
308         (TestWebKitAPI::TEST):
309         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
310
311         * DumpRenderTree/win/DumpRenderTree.cpp:
312         (findFontFallback):
313         (addFontFallbackIfPresent):
314         (removeFontFallbackIfPresent):
315         (main):
316         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
317         (TestWebKitAPI::Util::moduleDirectory):
318         (TestWebKitAPI::Util::createInjectedBundlePath):
319         Use wchar helpers as needed.
320
321 2019-03-06  Rob Buis  <rbuis@igalia.com>
322
323         Consider supporting the `referrerpolicy` attribute.
324         https://bugs.webkit.org/show_bug.cgi?id=179053
325
326         Reviewed by Darin Adler.
327
328         Add a runtime flag for referrerpolicy attribute.
329
330         * DumpRenderTree/mac/DumpRenderTree.mm:
331         (enableExperimentalFeatures):
332
333 2019-03-05  Daniel Bates  <dabates@apple.com>
334
335         Update expected API test result following r242379
336         (https://bugs.webkit.org/show_bug.cgi?id=195125)
337
338         Update expected x-coordinate of selection rect now that the left padding of
339         a textarea is sized in ems (so dependent on the font size) just like the left
340         padding of a text field.
341
342         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
343         (TestWebKitAPI::TEST):
344
345 2019-03-05  David Quesada  <david_quesada@apple.com>
346
347         [WK2] It should be possible to follow links with 'download' attributes
348         https://bugs.webkit.org/show_bug.cgi?id=195145
349         rdar://problem/48462642
350
351         Reviewed by Alex Christensen.
352
353         Add a unit test to verify that activating links with 'download' attributes now
354         navigates to the linked resource, rather than starts downloading it. Add another
355         to verify that it is still possible to explicitly download the link via the
356         'Download' navigation action policy.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
359         (-[DownloadAttributeTestDelegate init]):
360         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
361         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
362         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
363         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
364         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
365         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
366         (TEST):
367         * WebKitTestRunner/TestController.cpp:
368         (WTR::TestController::decidePolicyForNavigationAction):
369         * WebKitTestRunner/TestController.h:
370
371 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
372
373         [Curl] Implement Cookie Accept Policy.
374         https://bugs.webkit.org/show_bug.cgi?id=191645
375
376         Reviewed by Fujii Hironori.
377
378         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
379         (TestWebKitAPI::Curl::TEST_F):
380
381 2019-03-05  Youenn Fablet  <youenn@apple.com>
382
383         Rename requestCacheStorageSpace to requestStorageSpace
384         https://bugs.webkit.org/show_bug.cgi?id=195282
385
386         Reviewed by Chris Dumez.
387
388         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
389         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
390         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
391
392 2019-03-05  Brady Eidson  <beidson@apple.com>
393
394         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
395         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
396
397         Reviewed by Tim Horton.
398
399         Loading a file: URL into a WKWebView and then loading another file: url from a completely
400         different directory into that same WKWebView should work.
401
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
404
405 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
406
407         Add WeakHashSet
408         https://bugs.webkit.org/show_bug.cgi?id=195152
409
410         Reviewed by Antti Koivisto.
411
412         Added tests for WeakHashSet.
413
414         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
415         (TestWebKitAPI::Base::Base): Moved.
416         (TestWebKitAPI::Derived::foo): Moved.
417         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
418         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
419         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
420         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
421
422 2019-03-04  Chris Dumez  <cdumez@apple.com>
423
424         Do not share WebProcesses between private and regular sessions
425         https://bugs.webkit.org/show_bug.cgi?id=195189
426         <rdar://problem/48421064>
427
428         Reviewed by Alex Christensen.
429
430         Add API test coverage.
431
432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
433         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
434
435 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
436
437         [WPE] Enable web process sandbox
438         https://bugs.webkit.org/show_bug.cgi?id=195169
439
440         Reviewed by Daniel Bates.
441
442         * wpe/install-dependencies:
443         * wpe/jhbuild.modules:
444
445 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
446
447         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
448         https://bugs.webkit.org/show_bug.cgi?id=195206
449
450         Reviewed by Žan Doberšek.
451
452         Add a new test case.
453
454         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
455         (testJSCClass):
456
457 2019-03-04  Charlie Turner  <cturner@igalia.com>
458
459         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
460         https://bugs.webkit.org/show_bug.cgi?id=194898
461
462         Reviewed by Žan Doberšek.
463
464         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
465         a GCC extension that permits arithmetic on void* pointer. Inline
466         the macro until this issue is fixed upstream.
467
468 2019-03-03  Tim Horton  <timothy_horton@apple.com>
469
470         Rid the world of WK_API_ENABLED
471         https://bugs.webkit.org/show_bug.cgi?id=195263
472
473         Reviewed by Dan Bernstein.
474
475         List of changed files elided because it's useless.
476
477 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
478
479         Unreviewed follow-up to r242292.
480
481         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
482
483         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
484         (TestWebKitAPI::testStrip): Renamed from strip.
485         (TestWebKitAPI::TEST):
486
487 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
488
489         Unreviewed, remove accidentally-committed URLHelpers.cpp test
490
491         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
492         and bug #194272 for details.
493
494         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
495
496 2019-03-03  Tim Horton  <timothy_horton@apple.com>
497
498         Remove some more unused 32-bit code
499         https://bugs.webkit.org/show_bug.cgi?id=195255
500
501         Reviewed by Darin Adler.
502
503         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
504         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
505         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
506         (NPP_New):
507         (NPP_HandleEvent):
508         (handleEventCarbon): Deleted.
509
510 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
511
512         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
513
514         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
515         (TestWebKitAPI::TEST):
516
517 2019-03-01  Darin Adler  <darin@apple.com>
518
519         Finish removing String::format
520         https://bugs.webkit.org/show_bug.cgi?id=194893
521
522         Reviewed by Daniel Bates.
523 '
524         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
525
526 2019-03-01  Alex Christensen  <achristensen@webkit.org>
527
528         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
529         https://bugs.webkit.org/show_bug.cgi?id=195229
530         <rdar://problem/48520362>
531
532         Reviewed by Chris Dumez.
533
534         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
535         (TEST):
536
537 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
538
539         Add a system trace scope for event region building
540         https://bugs.webkit.org/show_bug.cgi?id=195226
541
542         Reviewed by Jon Lee.
543
544         This trace scope measures the time spend converting element rects into Region objects,
545         which can be large on some pages.
546
547         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
548
549         * Tracing/SystemTracePoints.plist:
550
551 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
552
553         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
554         https://bugs.webkit.org/show_bug.cgi?id=194612
555
556         Reviewed by Alex Christensen.
557
558         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
559         Just test the new string-processing function and don't touch the actual environment.
560         (Test cases are all as before, but based on operator== instead of strcmp.)
561
562 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
563
564         [ews-app] Update primary keys for handling multiple Buildbot instances
565         https://bugs.webkit.org/show_bug.cgi?id=195120
566
567         Reviewed by Stephanie Lewis.
568
569         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
570         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
571         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
572
573         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
574         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
575         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
576         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
577         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
578         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
579
580 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
581
582         [WinCairo] Enable service worker
583         https://bugs.webkit.org/show_bug.cgi?id=188318
584
585         Reviewed by Youenn Fablet.
586
587         * DumpRenderTree/DumpRenderTreePrefix.h:
588         * TestWebKitAPI/PlatformWin.cmake:
589         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
590         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
591         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
592
593 2019-03-01  Justin Fan  <justin_fan@apple.com>
594
595         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
596         https://bugs.webkit.org/show_bug.cgi?id=195191
597
598         Rubber-stamped by Dean Jackson.
599
600         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
601
602         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
603
604 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
605
606         Unreviewed, fix lldb webkitpy tests
607         https://bugs.webkit.org/show_bug.cgi?id=194375
608
609         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
610
611         * lldb/lldb_webkit.py:
612         (WTFStringImplProvider.is_8bit):
613
614 2019-02-28  David Quesada  <david_quesada@apple.com>
615
616         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
617         https://bugs.webkit.org/show_bug.cgi?id=195121
618         rdar://problem/48450302
619
620         Reviewed by Alex Christensen.
621
622         Add API tests for -WKNavigationAction._shouldPerformDownload in various
623         configurations where the 'download' attribute is absent, blank, or populated
624         with a filename, and where the anchor element is same-origin or cross-origin
625         (meaning the 'download' attribute shouldn't be honored).
626
627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
628         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
629         (-[NavigationActionTestDelegate init]):
630         (-[NavigationActionTestDelegate navigationAction]):
631         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
632         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
633         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
634         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
635         (TEST):
636
637 2019-02-28  Antoine Quint  <graouts@apple.com>
638
639         Enable the Pointer Events runtime flag by default
640         https://bugs.webkit.org/show_bug.cgi?id=195156
641
642         Reviewed by Dean Jackson.
643
644         * DumpRenderTree/mac/DumpRenderTree.mm:
645         (enableExperimentalFeatures):
646
647 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
648
649         Several PasteImage API tests are flaky
650         https://bugs.webkit.org/show_bug.cgi?id=195160
651
652         Reviewed by Tim Horton.
653
654         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
655         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
656         listening for a "load" event after image load is already complete.
657
658         To address this, make these tests first register a "load" event handler, then run script to insert an image
659         element into the document, and finally wait until the load event is observed before checking image size.
660
661         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
662
663 2019-02-28  Chris Dumez  <cdumez@apple.com>
664
665         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
666         https://bugs.webkit.org/show_bug.cgi?id=195107
667
668         Reviewed by Alex Christensen.
669
670         Give some time for the zoom level to get restored.
671
672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
673
674 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
675
676         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
677         https://bugs.webkit.org/show_bug.cgi?id=194958
678
679         Reviewed by Geoffrey Garen.
680
681         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
682         (TEST):
683
684 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
685
686         [ews-app] Update method to save build to handle builder_display_name
687         https://bugs.webkit.org/show_bug.cgi?id=195047
688
689         Reviewed by Dewei Zhu.
690
691         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
692         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
693
694 2019-02-28  Justin Fan  <justin_fan@apple.com>
695
696         [Web GPU] Enable Web GPU only on 64-bit
697         https://bugs.webkit.org/show_bug.cgi?id=195139
698
699         Because Metal is only supported on 64 bit apps.
700
701         Unreviewed build fix.
702
703         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
704
705 2019-02-27  Youenn Fablet  <youenn@apple.com>
706
707         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
708         https://bugs.webkit.org/show_bug.cgi?id=194959
709
710         Reviewed by Chris Dumez.
711
712         Spin loop until getting the condition to remove flakiness.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
715
716 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
717
718         [ews-build] Buildbot should include builder_display_name in the build events
719         https://bugs.webkit.org/show_bug.cgi?id=195045
720
721         Reviewed by Dewei Zhu.
722
723         * BuildSlaveSupport/ews-build/events.py:
724         (Events.buildStarted): Included builder_display_name in event data. Also renamed
725         buildername to builder_name to be consistent in naming style.
726         (Events.buildFinished): Ditto.
727
728 2019-02-27  Chris Dumez  <cdumez@apple.com>
729
730         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
731         https://bugs.webkit.org/show_bug.cgi?id=194480
732
733         Reviewed by Brady Eidson.
734
735         Update existing API test to make it more likely to reproduce the issue.
736
737         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
738
739 2019-02-27  Brady Eidson  <beidson@apple.com>
740
741         Universal links from Google search results pages don't open the app.
742         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
743
744         Reviewed by Geoffrey Garen.
745
746         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
747         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
748         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
749         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
750
751 2019-02-27  Chris Dumez  <cdumez@apple.com>
752
753         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
754         https://bugs.webkit.org/show_bug.cgi?id=195102
755
756         Reviewed by Geoffrey Garen.
757
758         If the number of processes is not yet what we expect, wait a bit and check again to give
759         processes some time to exit.
760
761         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
762
763 2019-02-27  Chris Dumez  <cdumez@apple.com>
764
765         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
766         https://bugs.webkit.org/show_bug.cgi?id=194545
767
768         Reviewed by Brady Eidson.
769
770         Make sure the test navigates forward and then back only once. Previously, navigating
771         back would trigger a navigation again in a timer.
772
773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
774
775 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
776
777         High Sierra Debug JSC test queue should use faster hardware
778         https://bugs.webkit.org/show_bug.cgi?id=194603
779
780         Rubber-stamped by Alexey Proskuryakov.
781
782         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
783
784         * BuildSlaveSupport/build.webkit.org-config/config.json:
785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
786         (BubbleQueueServer):
787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
788         (WebKitBuildbot):
789         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
790         * QueueStatusServer/config/queues.py:
791         * Scripts/webkitpy/common/config/ews.json:
792         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
793         (test_ews_name):
794
795 2019-02-27  John Wilander  <wilander@apple.com>
796
797         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
798         https://bugs.webkit.org/show_bug.cgi?id=195071
799         <rdar://problem/48417690>
800
801         Reviewed by Alex Christensen and Brent Fulgham.
802
803         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
804         (TestWebKitAPI::createURL):
805             Convenience function.
806         (TestWebKitAPI::TEST):
807             WebCore::AdClickAttribution now takes a URL when creating Source and
808             Destination.
809         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
810         (TestWebKitAPI::TEST):
811             WebCore::AdClickAttribution now takes a URL when creating Source and
812             Destination.
813
814 2019-02-27  Antoine Quint  <graouts@apple.com>
815
816         Support Pointer Events on macOS
817         https://bugs.webkit.org/show_bug.cgi?id=195008
818         <rdar://problem/47454419>
819
820         Reviewed by Dean Jackson.
821
822         * DumpRenderTree/mac/DumpRenderTree.mm:
823         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
825
826 2019-02-26  Mark Lam  <mark.lam@apple.com>
827
828         Remove remaining poisoning code.
829         https://bugs.webkit.org/show_bug.cgi?id=194138
830
831         Reviewed by Saam Barati.
832
833         * TestWebKitAPI/CMakeLists.txt:
834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
835         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
836         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
837         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
838         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
839         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
840         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
841
842 2019-02-26  Alex Christensen  <achristensen@webkit.org>
843
844         Move ephemeral local storage from WebProcess to UIProcess
845         https://bugs.webkit.org/show_bug.cgi?id=195074
846         <rdar://problem/47937975>
847
848         Reviewed by Geoff Garen.
849
850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
851
852 2019-02-20  Jer Noble  <jer.noble@apple.com>
853
854         [Cocoa] Media elements will restart network buffering just before suspending
855         https://bugs.webkit.org/show_bug.cgi?id=193691
856
857         Reviewed by Eric Carlson.
858
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
861         (TEST):
862
863 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
864
865         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
866         https://bugs.webkit.org/show_bug.cgi?id=191652
867
868         Reviewed by Alex Christensen.
869
870         Fix WinCairo MiniBrowser behavior of authentication dialog.
871
872         * MiniBrowser/win/WebKitBrowserWindow.cpp:
873         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
874
875 2019-02-26  Youenn Fablet  <youenn@apple.com>
876
877         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
878         https://bugs.webkit.org/show_bug.cgi?id=195028
879         <rdar://problem/48243733>
880
881         Reviewed by Eric Carlson.
882
883         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
884
885 2019-02-26  Philippe Normand  <pnormand@igalia.com>
886
887         [WPE] Add API for webview background color configuration
888         https://bugs.webkit.org/show_bug.cgi?id=192305
889
890         Reviewed by Michael Catanzaro.
891
892         * MiniBrowser/wpe/main.cpp:
893         (main): Add a new option to configure the webview background
894         color. Example: --bg-color=transparent.
895         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
896         (testWebViewBackgroundColor): Enable background color API tests for WPE.
897         (beforeAll): Ditto.
898
899 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
900
901         scalableNativeWebpageParameters() is not preserved on new page navigation.
902         https://bugs.webkit.org/show_bug.cgi?id=194892
903         <rdar://problem/47538280>
904
905         Reviewed by Wenson Hsieh.
906         
907         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
908
909         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
910         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
911         * DumpRenderTree/mac/UIScriptControllerMac.mm:
912         (WTR::UIScriptController::allowsViewportShrinkToFit):
913         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
914         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
915         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
916         * TestRunnerShared/UIScriptContext/UIScriptController.h:
917         * WebKitTestRunner/UIScriptControllerCocoa.mm:
918         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
919
920 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
921
922         [ews-app] Add model for handling multiple Buildbot instances
923         https://bugs.webkit.org/show_bug.cgi?id=194863
924
925         Reviewed by Stephanie Lewis.
926
927         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
928
929 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
930
931         [ews-app] Remove BuilderMapping table
932         https://bugs.webkit.org/show_bug.cgi?id=194961
933
934         Reviewed by Stephanie Lewis.
935
936         Store builder name directly in build table, instead of having a separate
937         table for it.
938
939         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
940         * BuildSlaveSupport/ews-app/ews/models/build.py:
941         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
942         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
943
944 2019-02-25  John Wilander  <wilander@apple.com>
945
946         Introduce and adopt new class RegistrableDomain for eTLD+1
947         https://bugs.webkit.org/show_bug.cgi?id=194791
948         <rdar://problem/48179240>
949
950         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
951
952         This patch adds an API test and replaces two instances of
953         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
954
955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
956         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
957         (TestWebKitAPI::TEST):
958             Changed two strings to make sure the registrable domains are still considered
959             invalid and pass the test.
960         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
961         (TestWebKitAPI::TEST):
962         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
963         (WTR::InjectedBundle::didReceiveMessageToPage):
964
965 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
966
967         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
968         https://bugs.webkit.org/show_bug.cgi?id=195001
969
970         Reviewed by Carlos Garcia Campos.
971
972         API version 1.0 always includes the functionality previously guarded with
973         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
974         unconditionally.
975
976         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
977         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
978         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
979         (WebViewTest::showInWindow): Ditto.
980         (WebViewTest::hideView): Ditto.
981         * wpe/backends/HeadlessViewBackend.cpp:
982         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
983         * wpe/backends/ViewBackend.cpp:
984         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
985         * wpe/backends/WindowViewBackend.cpp:
986         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
987         WPE_BACKEND_CHECK_VERSION().
988         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
989
990 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
991
992         [Flatpak] Add support for flatpak > 1.1.2
993         https://bugs.webkit.org/show_bug.cgi?id=194088
994
995         Flatpak 1.2 is now out so we need to support that
996         version now.
997
998         Reviewed by Michael Catanzaro.
999
1000         * flatpak/flatpakutils.py:
1001         (check_flatpak):
1002         (FlatpakPackages.__init__):
1003         (FlatpakPackages.__detect_packages):
1004         (FlatpakPackages.__detect_packages.in):
1005         (FlatpakRepos.update):
1006
1007 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1008
1009         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1010         https://bugs.webkit.org/show_bug.cgi?id=194998
1011
1012         Reviewed by Carlos Garcia Campos.
1013
1014         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1015         to a Git checkout and using the latest commit containing various fixes
1016         and improvements.
1017
1018 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1019
1020         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1021         https://bugs.webkit.org/show_bug.cgi?id=194981
1022
1023         Reviewed by Žan Doberšek.
1024
1025         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1026         (TestWebKitAPI::TEST):
1027
1028 2019-02-23  Keith Miller  <keith_miller@apple.com>
1029
1030         Add new mac target numbers
1031         https://bugs.webkit.org/show_bug.cgi?id=194955
1032
1033         Reviewed by Tim Horton.
1034
1035         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1036         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1037         * MiniBrowser/Configurations/Base.xcconfig:
1038         * TestWebKitAPI/Configurations/Base.xcconfig:
1039         * WebKitTestRunner/Configurations/Base.xcconfig:
1040
1041 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1042
1043         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1044         https://bugs.webkit.org/show_bug.cgi?id=194846
1045
1046         Reviewed by Don Olmstead.
1047
1048         Added _search_paths() and _port_specific_expectations_files() for
1049         WinCairoPort.
1050
1051         * Scripts/webkitpy/port/win.py:
1052         (WinCairoPort.default_baseline_search_path):
1053         (WinCairoPort):
1054         (WinCairoPort._port_specific_expectations_files):
1055         (WinCairoPort._search_paths):
1056
1057 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1058
1059         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1060         https://bugs.webkit.org/show_bug.cgi?id=194963
1061
1062         Reviewed by Dean Jackson.
1063
1064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1065         Do a `contains` check instead of `equals`, because in debug builds we
1066         put the GraphicsLayer pointer in a prefix.
1067
1068 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1069
1070         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1071         https://bugs.webkit.org/show_bug.cgi?id=194873
1072         <rdar://problem/46701974>
1073
1074         Reviewed by Tim Horton.
1075
1076         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1077
1078         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1079         (WTR::UIScriptController::menuRect const):
1080         (WTR::UIScriptController::isShowingMenu const):
1081         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1082         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1083         (WTR::UIScriptController::menuRect const):
1084
1085         Add a function to query the bounds of the callout menu in content coordinates.
1086
1087         (WTR::UIScriptController::isShowingMenu const):
1088
1089         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1090
1091         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1092         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1093         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1094         (WTR::UIScriptController::rectForMenuAction const):
1095         (WTR::UIScriptController::menuRect const):
1096         (WTR::UIScriptController::isShowingMenu const):
1097         (WTR::findViewInHierarchyOfType): Deleted.
1098
1099 2019-02-22  Chris Dumez  <cdumez@apple.com>
1100
1101         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1102         https://bugs.webkit.org/show_bug.cgi?id=194954
1103         <rdar://problem/48127957>
1104
1105         Reviewed by Alex Christensen.
1106
1107         Add API test coverage.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1110         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1111         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1112         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1113
1114 2019-02-22  Chris Dumez  <cdumez@apple.com>
1115
1116         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1117         https://bugs.webkit.org/show_bug.cgi?id=194924
1118         <rdar://problem/48216125>
1119
1120         Reviewed by Geoffrey Garen.
1121
1122         Add API test coverage.
1123
1124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1125
1126 2019-02-22  Chris Dumez  <cdumez@apple.com>
1127
1128         Unreviewed, disable API test added in r241928 on iOS.
1129
1130         The cache is not enabled on devices with less than 3GB of RAM.
1131
1132         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1133
1134 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1135
1136         Hardcode Visual Viewports on everywhere except iOS WK1
1137         https://bugs.webkit.org/show_bug.cgi?id=194928
1138
1139         Reviewed by Zalan Bujtas.
1140
1141         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1142         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1143         set it to false. The setting has shipped for several years and there's no need to turn
1144         it off now.
1145
1146         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1147         Visual Viewports are not enabled.
1148         
1149         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1150         that only runs in WK2
1151
1152         * MiniBrowser/mac/SettingsController.h:
1153         * MiniBrowser/mac/SettingsController.m:
1154         (-[SettingsController init]):
1155         (-[SettingsController _populateMenu]):
1156         (-[SettingsController validateMenuItem:]):
1157         (-[SettingsController visualViewportEnabled]): Deleted.
1158         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1159         * MiniBrowser/mac/WK1BrowserWindowController.m:
1160         (-[WK1BrowserWindowController didChangeSettings]):
1161         * MiniBrowser/mac/WK2BrowserWindowController.m:
1162         (-[WK2BrowserWindowController didChangeSettings]):
1163
1164 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1165
1166         Discard cached processes when clearing website data store
1167         https://bugs.webkit.org/show_bug.cgi?id=194894
1168
1169         Reviewed by Chris Dumez.
1170
1171         Added a test case.
1172
1173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1174         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1175
1176 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1177
1178         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1179         https://bugs.webkit.org/show_bug.cgi?id=194914
1180         <rdar://problem/47586889>
1181
1182         Reviewed by Geoffrey Garen.
1183
1184         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1185         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1186         (TEST):
1187         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1188
1189 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1190
1191         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1192         <https://webkit.org/b/194761>
1193
1194         Reviewed by Myles Maxfield.
1195
1196         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1197         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1198         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1199         to use ARC-compliant cast.
1200         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1201         ARC-compliant cast.
1202         (WTR::installFakeHelvetica): Log `error` to console if
1203         CTFontManagerRegisterFontsForURL() fails, but only on supported
1204         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1205         Call CFRelease() on `error` to fix the leak.  Update to use
1206         ARC-compliant cast.
1207         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1208         cast.
1209
1210 2019-02-21  Chris Dumez  <cdumez@apple.com>
1211
1212         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1213         https://bugs.webkit.org/show_bug.cgi?id=194481
1214
1215         Reviewed by Alex Christensen.
1216
1217         Give the processes a chance to shutdown and wait until we reached the expected number
1218         of processes.
1219
1220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1221
1222 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1223
1224         Fix the macOS build
1225
1226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1227
1228 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1229
1230         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1233         I am a backwards.
1234
1235 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1236
1237         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1238
1239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1240         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1241         We could force on UI-side compositing, but I feel like the test might be more
1242         valuable exercising the normal path on each platform (though the original
1243         bug was also UI-side specific). Though we can't validate that the overlay
1244         layer was installed successfully, there are layout tests that do that.
1245
1246 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1247
1248         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1249         https://bugs.webkit.org/show_bug.cgi?id=194845
1250         <rdar://problem/47944579>
1251
1252         Reviewed by Antti Koivisto.
1253
1254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1256
1257 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1258
1259         [LFC][Floats] Add support for placing formatting roots in-between floats.
1260         https://bugs.webkit.org/show_bug.cgi?id=194902
1261
1262         Reviewed by Antti Koivisto.
1263
1264         * LayoutReloaded/misc/LFC-passing-tests.txt:
1265
1266 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1267
1268         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1269         https://bugs.webkit.org/show_bug.cgi?id=194901
1270
1271         Unreviewed build fix.
1272
1273         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1274         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1275         WPEBackend-fdo-0.1 as library name.
1276
1277 2019-02-21  Rob Buis  <rbuis@igalia.com>
1278
1279         Update MIME type parser
1280         https://bugs.webkit.org/show_bug.cgi?id=180526
1281
1282         Reviewed by Darin Adler.
1283
1284         Add tests involving leading and trailing whitespace, non-token
1285         characters and quoted strings.
1286
1287         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1288         (TestWebKitAPI::TEST):
1289
1290 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1291
1292         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1293         https://bugs.webkit.org/show_bug.cgi?id=194884
1294
1295         Reviewed by Michael Catanzaro.
1296
1297         * PlatformWin.cmake:
1298
1299 2019-02-20  Chris Dumez  <cdumez@apple.com>
1300
1301         Add API test for <rdar://problem/47471222>
1302         https://bugs.webkit.org/show_bug.cgi?id=194847
1303
1304         Reviewed by Alex Christensen.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1307
1308 2019-02-20  Chris Dumez  <cdumez@apple.com>
1309
1310         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1311         https://bugs.webkit.org/show_bug.cgi?id=194872
1312         <rdar://problem/47924500>
1313
1314         Reviewed by Alex Christensen.
1315
1316         Add API test coverage.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1319
1320 2019-02-20  Jer Noble  <jer.noble@apple.com>
1321
1322         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1323         https://bugs.webkit.org/show_bug.cgi?id=191332
1324
1325         Reviewed by Dean Jackson.
1326
1327         * Scripts/git-is-in-range: Added.
1328
1329 2019-02-20  Andy Estes  <aestes@apple.com>
1330
1331         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1332         https://bugs.webkit.org/show_bug.cgi?id=194869
1333
1334         Rubber-stamped by Jer Noble.
1335
1336         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1337         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1338         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1339         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1341         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1342
1343 2019-02-20  Chris Dumez  <cdumez@apple.com>
1344
1345         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1346         https://bugs.webkit.org/show_bug.cgi?id=194857
1347         <rdar://problem/47759323>
1348
1349         Reviewed by Alex Christensen.
1350
1351         Add API test coverage.
1352
1353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1354
1355 2019-02-20  Chris Dumez  <cdumez@apple.com>
1356
1357         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1358         https://bugs.webkit.org/show_bug.cgi?id=194829
1359         <rdar://problem/47889906>
1360
1361         Reviewed by Alexey Proskuryakov.
1362
1363         Every time the TestOptions were changing we were creating both a new Web view and
1364         a new WKContext, which would start a new Network process. In most cases, we only
1365         need to contruct a new Web view and we do can keep reusing the same WKContext.
1366         This patch implements this optimization and thus avoids spinning a lot of new
1367         Network processes while running the layout tests.
1368
1369         * WebKitTestRunner/TestController.cpp:
1370         (WTR::TestController::generateContextConfiguration const):
1371         (WTR::TestController::generatePageConfiguration):
1372         (WTR::TestController::createWebViewWithOptions):
1373         (WTR::TestController::resetPreferencesToConsistentValues):
1374         (WTR::updateTestOptionsFromTestHeader):
1375         * WebKitTestRunner/TestController.h:
1376         * WebKitTestRunner/TestOptions.h:
1377         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1378         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1379         (WTR::TestOptions::hasSameInitializationOptions const):
1380         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1381         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1382         (WTR::TestController::platformAddTestOptions const):
1383
1384 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1385
1386         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1387         https://bugs.webkit.org/show_bug.cgi?id=167941
1388
1389         Reviewed by Carlos Garcia Campos.
1390
1391         * MiniBrowser/gtk/main.c:
1392         (filterSavedCallback): Added.
1393         (main): Support loading a JSON rule set file for content filtering.
1394         * MiniBrowser/wpe/main.cpp:
1395         (filterSavedCallback): Added.
1396         (main): Support loading a JSON rule set file for content filtering.
1397         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1398         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1399         (WTF::derefGPtr): Ditto.
1400         (testEmptyStore):
1401         (testSaveInvalidFilter):
1402         (testSaveLoadFilter):
1403         (testSavedFilterIdentifierMatch):
1404         (testRemoveFilter):
1405         (testSaveMultipleFilters):
1406         (testSaveFilterFromFile):
1407         (testFilterPersistence):
1408         (beforeAll):
1409         (afterAll):
1410         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1411         (removeOldInjectedContentAndResetLists): Also reset content filters.
1412         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1413         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1414         the element affected by the style sheet.
1415         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1416         and returns it to be used by tests.
1417         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1418         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1419         (serverCallback): Add support for serving a CSS style sheet for testing.
1420         (beforeAll): Add call to testUserContentManagerContentFilter().
1421         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1422
1423 2019-02-19  Keith Rollin  <krollin@apple.com>
1424
1425         Add timing information to build output
1426         https://bugs.webkit.org/show_bug.cgi?id=194839
1427         <rdar://problem/48219609>
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1432         emit each project's build time to its output. E.g.,
1433
1434             ** BUILD SUCCEEDED ** [0.132 sec]
1435
1436         * Scripts/webkitdirs.pm:
1437         (XcodeOptions):
1438
1439 2019-02-19  Truitt Savell  <tsavell@apple.com>
1440
1441         Unreviewed, rolling out r241784.
1442
1443         Broke all OpenSource builds.
1444
1445         Reverted changeset:
1446
1447         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1448         instances view"
1449         https://bugs.webkit.org/show_bug.cgi?id=172848
1450         https://trac.webkit.org/changeset/241784
1451
1452 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1453
1454         [LFC][Floats] Remove redundant intersecting logic
1455         https://bugs.webkit.org/show_bug.cgi?id=194804
1456
1457         Reviewed by Antti Koivisto.
1458
1459         * LayoutReloaded/misc/LFC-passing-tests.txt:
1460
1461 2019-02-19  Dean Jackson  <dino@apple.com>
1462
1463         Clean-up output from generate-xcfilelists so it can be filtered
1464         https://bugs.webkit.org/show_bug.cgi?id=194795
1465
1466         Reviewed by Joseph Pecoraro (and Keith Rollin).
1467
1468         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1469         make a slight tweak to filter-build-webkit so such lines are marked
1470         as plain.
1471
1472         * Scripts/filter-build-webkit:
1473         * Scripts/generate-xcfilelists:
1474
1475 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1476
1477         pytest is not correctly auto-installed
1478         https://bugs.webkit.org/show_bug.cgi?id=194707
1479
1480         Reviewed by Carlos Garcia Campos.
1481
1482         * Scripts/webkitpy/thirdparty/__init__.py:
1483         (AutoinstallImportHook._install_pytest):
1484
1485 2019-02-18  Chris Dumez  <cdumez@apple.com>
1486
1487         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1488         https://bugs.webkit.org/show_bug.cgi?id=194797
1489         <rdar://problem/48055151>
1490
1491         Reviewed by Geoffrey Garen.
1492
1493         Add API test coverage.
1494
1495         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1496
1497 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1498
1499         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1500         https://bugs.webkit.org/show_bug.cgi?id=194670
1501         <rdar://problem/39066529>
1502
1503         Reviewed by Tim Horton.
1504
1505         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1506         pasted in an editable area as attachment elements.
1507
1508         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1509         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1510         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1511         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1512         (TestWebKitAPI::TEST):
1513         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1514         (WTR::InjectedBundlePage::InjectedBundlePage):
1515
1516 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1517
1518         Fix API test after r241728
1519        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1520
1521         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1522         (TEST):
1523         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1524
1525 2019-02-18  Daniel Bates  <dabates@apple.com>
1526
1527         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1528         https://bugs.webkit.org/show_bug.cgi?id=192824
1529         <rdar://problem/47100332>
1530
1531         Reviewed by Wenson Hsieh.
1532
1533         Fix a bug where the wrong usage code was used for F13 thru F24.
1534
1535         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1536         (keyCodeForDOMFunctionKey):
1537
1538 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1539
1540         Bytecode cache should a have a boot-specific validation
1541         https://bugs.webkit.org/show_bug.cgi?id=194769
1542         <rdar://problem/48149509>
1543
1544         Reviewed by Keith Miller.
1545
1546         Add test for WTF::bootSessionUUIDString()
1547
1548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1549         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1550         (TEST):
1551
1552 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1553
1554         Disable safe browsing in WKWebView and remove its WKPreferences API
1555         https://bugs.webkit.org/show_bug.cgi?id=194723
1556         <rdar://problem/48122993>
1557
1558         Reviewed by Geoffrey Garen.
1559
1560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1561         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1562         (TEST):
1563         (safeBrowsingView):
1564         Make tests use SPI instead of API.
1565
1566 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1567
1568         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1569         https://bugs.webkit.org/show_bug.cgi?id=194586
1570
1571         Reviewed by Ross Kirsling.
1572
1573         * DumpRenderTree/win/DumpRenderTree.cpp:
1574         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1575         * Scripts/webkitpy/port/driver.py:
1576         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1577
1578 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1579
1580         Unreviewed, rolling out r241620.
1581
1582         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1583         (Requested by ddkilzer on #webkit.)
1584
1585         Reverted changeset:
1586
1587         "[WTF] Add environment variable helpers"
1588         https://bugs.webkit.org/show_bug.cgi?id=192405
1589         https://trac.webkit.org/changeset/241620
1590
1591 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1592
1593         [LFC] RenderImage's default intrinsic size is 0.
1594         https://bugs.webkit.org/show_bug.cgi?id=194745
1595
1596         Reviewed by Antti Koivisto.
1597
1598         * LayoutReloaded/misc/LFC-passing-tests.txt:
1599
1600 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1601
1602         [LFC][BFC] Add support for block replaced intrinsic width.
1603         https://bugs.webkit.org/show_bug.cgi?id=194705
1604
1605         Reviewed by Simon Fraser.
1606
1607         * LayoutReloaded/misc/LFC-passing-tests.txt:
1608
1609 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1610
1611         [LFC] Apply min/max width constraints to preferred width computation
1612         https://bugs.webkit.org/show_bug.cgi?id=194739
1613
1614         Reviewed by Simon Fraser.
1615
1616         * LayoutReloaded/misc/LFC-passing-tests.txt:
1617
1618 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1619
1620         [WTF] Add environment variable helpers
1621         https://bugs.webkit.org/show_bug.cgi?id=192405
1622
1623         Reviewed by Michael Catanzaro.
1624
1625         * DumpRenderTree/mac/DumpRenderTree.mm:
1626         (libraryPathForDumpRenderTree):
1627         * DumpRenderTree/win/DumpRenderTree.cpp:
1628         (libraryPathForDumpRenderTree):
1629         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1630         (setUpIOSLayoutTestCommunication):
1631         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1632         (beforeAll):
1633         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1634         (main):
1635         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1636         (WebKitTestBus::run):
1637         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1638         (WTR::getOutputDir):
1639         (WTR::initializeFontConfigSetting):
1640         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1641         (WTR::InjectedBundle::platformInitialize):
1642         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1643         (WTR::topLevelPath):
1644         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1645         (WTR::topLevelPath):
1646         (WTR::getOutputDir):
1647         (WTR::activateFonts):
1648         * WebKitTestRunner/TestController.cpp:
1649         (WTR::TestController::libraryPathForTesting):
1650         (WTR::TestController::generateContextConfiguration const):
1651         (WTR::TestController::generatePageConfiguration):
1652         (WTR::TestController::decideDestinationWithSuggestedFilename):
1653         (WTR::TestController::platformAdjustContext):
1654         * WebKitTestRunner/TestController.h:
1655         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1656         (WTR::TestController::cocoaPlatformInitialize):
1657         (WTR::TestController::platformAdjustContext):
1658         * WebKitTestRunner/gtk/main.cpp:
1659         (main):
1660         * WebKitTestRunner/mac/TestControllerMac.mm:
1661         (WTR::TestController::configureContentExtensionForTest):
1662         * WebKitTestRunner/wpe/main.cpp:
1663         (main):
1664         Utilize WTF::Environment where possible.
1665
1666 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1667
1668         [iOS] WKWebView callout bar is missing Change Writing Direction item
1669         https://bugs.webkit.org/show_bug.cgi?id=190015
1670         <rdar://problem/44810366>
1671
1672         Reviewed by Tim Horton.
1673
1674         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1675         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1676
1677         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1678         (TestWebKitAPI::TEST):
1679
1680 2019-02-15  Chris Dumez  <cdumez@apple.com>
1681
1682         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1683         https://bugs.webkit.org/show_bug.cgi?id=194717
1684         <rdar://problem/47884404>
1685
1686         Reviewed by Brady Eidson.
1687
1688         Add API test coverage.
1689
1690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1691
1692 2019-02-15  Youenn Fablet  <youenn@apple.com>
1693
1694         Make navigator.mediaDevices SecureContext
1695         https://bugs.webkit.org/show_bug.cgi?id=194666
1696
1697         Reviewed by Eric Carlson.
1698
1699         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1700         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1701         (TEST_F):
1702
1703 2019-02-15  Brian Burg  <bburg@apple.com>
1704
1705         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1706         https://bugs.webkit.org/show_bug.cgi?id=194411
1707         <rdar://problem/47787614>
1708
1709         Reviewed by Joseph Pecoraro.
1710
1711         Remove unnecessary soft linking macro usage.
1712
1713         * DumpRenderTree/mac/TestRunnerMac.mm:
1714         (TestRunner::inspectorTestStubURL):
1715         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1716         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1717         (WTR::TestRunner::inspectorTestStubURL):
1718
1719 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1720
1721         Unreviewed, rolling out r241559 and r241566.
1722         https://bugs.webkit.org/show_bug.cgi?id=194710
1723
1724         Causes layout test crashes under GuardMalloc (Requested by
1725         ryanhaddad on #webkit).
1726
1727         Reverted changesets:
1728
1729         "[WTF] Add environment variable helpers"
1730         https://bugs.webkit.org/show_bug.cgi?id=192405
1731         https://trac.webkit.org/changeset/241559
1732
1733         "Unreviewed build fix for WinCairo Debug after r241559."
1734         https://trac.webkit.org/changeset/241566
1735
1736 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1737
1738         [LFC] Out-of-flow box is never a float box
1739         https://bugs.webkit.org/show_bug.cgi?id=194704
1740
1741         Reviewed by Antti Koivisto.
1742
1743         * LayoutReloaded/misc/LFC-passing-tests.txt:
1744
1745 2019-02-10  Darin Adler  <darin@apple.com>
1746
1747         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1748         https://bugs.webkit.org/show_bug.cgi?id=194487
1749
1750         Reviewed by Daniel Bates.
1751
1752         * DumpRenderTree/win/DumpRenderTree.cpp:
1753         (applicationId): Use makeString instead of String::format.
1754         (main): Ditto.
1755         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1756         (TestWebKitAPI::Util::createURLForResource): Ditto.
1757         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1758         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1759
1760         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1761         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1762         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1763         (WTR::createStringWithAttributes): Use appendLiteral.
1764         (WTR::AccessibilityUIElement::helpText const): Ditto.
1765         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1766         directly instead of using String::format.
1767         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1768         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1769
1770 2019-02-15  Truitt Savell  <tsavell@apple.com>
1771
1772         Unreviewed, rolling out r241564.
1773
1774         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1775
1776         Reverted changeset:
1777
1778         "[Mac] WebInspectorUI.framework does not need to be soft-
1779         linked anymore"
1780         https://bugs.webkit.org/show_bug.cgi?id=194411
1781         https://trac.webkit.org/changeset/241564
1782
1783 2019-02-15  Saam barati  <sbarati@apple.com>
1784
1785         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1786         https://bugs.webkit.org/show_bug.cgi?id=194036
1787
1788         Reviewed by Yusuke Suzuki.
1789
1790         * Scripts/run-jsc-stress-tests:
1791
1792 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1793
1794         Fix the build.
1795
1796         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1797         (WTR::UIScriptController::drawSquareInEditableImage):
1798         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1799         (TestWebKitAPI::drawSquareInEditableImage):
1800
1801 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1802
1803         Fix the build.
1804
1805         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1806         (WTR::UIScriptController::drawSquareInEditableImage):
1807         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1808         (TestWebKitAPI::drawSquareInEditableImage):
1809
1810 2019-02-14  Brian Burg  <bburg@apple.com>
1811
1812         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1813         https://bugs.webkit.org/show_bug.cgi?id=194411
1814         <rdar://problem/47787614>
1815
1816         Reviewed by Joseph Pecoraro.
1817
1818         Remove unnecessary soft linking macro usage.
1819
1820         * DumpRenderTree/mac/TestRunnerMac.mm:
1821         (TestRunner::inspectorTestStubURL):
1822         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1823         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1824         (WTR::TestRunner::inspectorTestStubURL):
1825
1826 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1829         https://bugs.webkit.org/show_bug.cgi?id=194599
1830
1831         Reviewed by Lucas Forschler.
1832
1833         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1834         (StatusBubble._build_bubble):
1835
1836 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1837
1838         [ews-app] Set Foreign Key in Django build model
1839         https://bugs.webkit.org/show_bug.cgi?id=194667
1840
1841         Reviewed by Lucas Forschler.
1842
1843         * BuildSlaveSupport/ews-app/ews/models/build.py:
1844         (Build):
1845
1846 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1847
1848         [WTF] Add environment variable helpers
1849         https://bugs.webkit.org/show_bug.cgi?id=192405
1850
1851         Reviewed by Michael Catanzaro.
1852
1853         * DumpRenderTree/mac/DumpRenderTree.mm:
1854         (libraryPathForDumpRenderTree):
1855         * DumpRenderTree/win/DumpRenderTree.cpp:
1856         (libraryPathForDumpRenderTree):
1857         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1858         (setUpIOSLayoutTestCommunication):
1859         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1860         (TestWebKitAPI::strip):
1861         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1862         (beforeAll):
1863         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1864         (main):
1865         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1866         (WebKitTestBus::run):
1867         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1868         (WTR::getOutputDir):
1869         (WTR::initializeFontConfigSetting):
1870         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1871         (WTR::InjectedBundle::platformInitialize):
1872         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1873         (WTR::topLevelPath):
1874         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1875         (WTR::topLevelPath):
1876         (WTR::getOutputDir):
1877         (WTR::activateFonts):
1878         * WebKitTestRunner/TestController.cpp:
1879         (WTR::TestController::libraryPathForTesting):
1880         (WTR::TestController::generateContextConfiguration const):
1881         (WTR::TestController::generatePageConfiguration):
1882         (WTR::TestController::decideDestinationWithSuggestedFilename):
1883         (WTR::TestController::platformAdjustContext):
1884         * WebKitTestRunner/TestController.h:
1885         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1886         (WTR::TestController::cocoaPlatformInitialize):
1887         (WTR::TestController::platformAdjustContext):
1888         * WebKitTestRunner/gtk/main.cpp:
1889         (main):
1890         * WebKitTestRunner/mac/TestControllerMac.mm:
1891         (WTR::TestController::configureContentExtensionForTest):
1892         * WebKitTestRunner/wpe/main.cpp:
1893         (main):
1894         Utilize WTF::Environment where possible.
1895
1896 2019-02-14  Chris Dumez  <cdumez@apple.com>
1897
1898         [PSON] Introduce a WebContent Process cache
1899         https://bugs.webkit.org/show_bug.cgi?id=194594
1900         <rdar://problem/46793397>
1901
1902         Reviewed by Geoff Garen.
1903
1904         Update API tests to turn on the WebContent Process cache.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1907
1908 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1909
1910         Unreviewed, build fix after r241480
1911
1912         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1913         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1914         (-[DragAndDropSimulator initWithWebView:]):
1915
1916 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1917
1918         AX: ARIA Reflection was disabled in error
1919         https://bugs.webkit.org/show_bug.cgi?id=194647
1920         <rdar://problem/48068336>
1921
1922         Reviewed by Ryosuke Niwa.
1923
1924         Remove test override now that this feature should be enabled by default.
1925
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::TestController::resetPreferencesToConsistentValues):
1928
1929 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1930
1931         Unreviewed, rolling out r241486.
1932         https://bugs.webkit.org/show_bug.cgi?id=194655
1933
1934         causing API failures in builds (Requested by ShawnRoberts on
1935         #webkit).
1936
1937         Reverted changeset:
1938
1939         "[Cocoa] Media elements will restart network buffering just
1940         before suspending"
1941         https://bugs.webkit.org/show_bug.cgi?id=193691
1942         https://trac.webkit.org/changeset/241486
1943
1944 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1945
1946         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1947         https://bugs.webkit.org/show_bug.cgi?id=194622
1948
1949         Reviewed by Antti Koivisto.
1950
1951         * LayoutReloaded/misc/LFC-passing-tests.txt:
1952
1953 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1954
1955         [LFC] Shrink-to-fit-width should be constrained by min/max width
1956         https://bugs.webkit.org/show_bug.cgi?id=194653
1957
1958         Reviewed by Antti Koivisto.
1959
1960         * LayoutReloaded/misc/LFC-passing-tests.txt:
1961
1962 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1963
1964         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1965         https://bugs.webkit.org/show_bug.cgi?id=194641
1966
1967         Reviewed by Geoffrey Garen.
1968
1969         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1970         so that the test would fail without this fix.
1971
1972         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1973         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1974
1975 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1976
1977         [ews-app] Change log level for a log statement
1978
1979         Unreviewed minor fix.
1980
1981         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1982         (Patch.save_patch):
1983
1984 2019-02-13  Jer Noble  <jer.noble@apple.com>
1985
1986         [Cocoa] Media elements will restart network buffering just before suspending
1987         https://bugs.webkit.org/show_bug.cgi?id=193691
1988
1989         Reviewed by Eric Carlson.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1993         (TEST):
1994
1995 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1996
1997         [ews-app] Fetch builder id to name mapping
1998         https://bugs.webkit.org/show_bug.cgi?id=194355
1999
2000         Reviewed by Lucas Forschler.
2001
2002         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2003         (Buildbot.get_builder_id_to_name_mapping):
2004         (Buildbot._get_display_name_from_builder_name):
2005
2006 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2007
2008         Further restricting webarchive loads
2009         https://bugs.webkit.org/show_bug.cgi?id=194567
2010         <rdar://problem/47610130>
2011
2012         Reviewed by Youenn Fablet.
2013
2014         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2015         navigations on drop.
2016
2017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2018         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2019         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2020         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2021         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2022         (TestWebKitAPI::TEST):
2023         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2024         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2025         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2026         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2027         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2028         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2029         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2030
2031 2019-02-13  John Wilander  <wilander@apple.com>
2032
2033         Store Ad Click Attribution requests in the network process
2034         https://bugs.webkit.org/show_bug.cgi?id=194510
2035         <rdar://problem/47650118>
2036
2037         Reviewed by Alex Christensen and Daniel Bates.
2038
2039         This patch adds two TestRunner functions:
2040         - dumpAdClickAttribution()
2041         - clearAdClickAttribution()
2042
2043         They call into the network process to dump and clear Ad Click
2044         Attribution state, respectively.
2045
2046         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2047         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2048         (WTR::TestRunner::dumpAdClickAttribution):
2049         (WTR::TestRunner::clearAdClickAttribution):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::resetStateToConsistentValues):
2053         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2054         (WTR::adClickAttributionStringResultCallback):
2055         (WTR::TestController::dumpAdClickAttribution):
2056         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2057         (WTR::adClickAttributionVoidCallback):
2058         (WTR::TestController::clearAdClickAttribution):
2059         * WebKitTestRunner/TestController.h:
2060         * WebKitTestRunner/TestInvocation.cpp:
2061         (WTR::TestInvocation::dumpResults):
2062         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2063         (WTR::TestInvocation::dumpAdClickAttribution):
2064         * WebKitTestRunner/TestInvocation.h:
2065
2066 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2067
2068         [ews-app] Generate status-bubble
2069         https://bugs.webkit.org/show_bug.cgi?id=194572
2070
2071         Reviewed by Lucas Forschler.
2072
2073         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2074         (StatusBubble._build_bubble):
2075         (StatusBubble._should_show_bubble_for):
2076         (StatusBubble._build_bubbles_for_patch):
2077
2078 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-app] Add status bubble html template
2081         https://bugs.webkit.org/show_bug.cgi?id=194571
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-app/ews/templates: Added.
2086         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2087
2088 2019-02-12  Chris Dumez  <cdumez@apple.com>
2089
2090         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2091         https://bugs.webkit.org/show_bug.cgi?id=194568
2092         <rdar://problem/47944490>
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         Add API test coverage.
2097
2098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2099         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2100
2101 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2102
2103         webkitpy: Remove bug_dummy from parsed test expectations
2104         https://bugs.webkit.org/show_bug.cgi?id=194562
2105         <rdar://problem/47853999>
2106
2107         Reviewed by Lucas Forschler.
2108
2109         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2110         (TestExpectationParser):
2111         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2112         skipped tests.
2113         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2114
2115 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2116
2117         [ews-app] Add method to fetch patch
2118         https://bugs.webkit.org/show_bug.cgi?id=194518
2119
2120         Reviewed by Lucas Forschler.
2121
2122         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2123         (Patch.get_patch):
2124
2125 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2126
2127         [LFC] Expand tests coverage (60 new tests -> 860)
2128
2129         Unreviewed test gardening (run-singly, --child-processes=1).
2130
2131         * LayoutReloaded/misc/LFC-passing-tests.txt:
2132
2133 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2134
2135         Allow pages to trigger programmatic paste from script on iOS
2136         https://bugs.webkit.org/show_bug.cgi?id=194271
2137         <rdar://problem/47808810>
2138
2139         Reviewed by Tim Horton.
2140
2141         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2142
2143         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2144         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2145         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2146         (WTR::UIScriptController::rectForMenuAction const):
2147
2148         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2149         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2150         for when the menu is shown or hidden.
2151
2152         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2153         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2154         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2155         (WTR::UIScriptController::setDidShowMenuCallback):
2156         (WTR::UIScriptController::didShowMenuCallback const):
2157         (WTR::UIScriptController::setDidHideMenuCallback):
2158         (WTR::UIScriptController::didHideMenuCallback const):
2159         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2160         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2161         (WTR::UIScriptController::rectForMenuAction const):
2162         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2163         * WebKitTestRunner/TestController.cpp:
2164         (WTR::TestController::resetPreferencesToConsistentValues):
2165         (WTR::updateTestOptionsFromTestHeader):
2166         * WebKitTestRunner/TestOptions.h:
2167
2168         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2169         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2170
2171         (WTR::TestOptions::hasSameInitializationOptions const):
2172         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2173         (WTR::UIScriptController::calendarType const):
2174         (WTR::UIScriptController::platformUndoManager const):
2175         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2176         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2177         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2178         (-[TestRunnerWKWebView dealloc]):
2179         (-[TestRunnerWKWebView _didShowMenu]):
2180         (-[TestRunnerWKWebView _didHideMenu]):
2181
2182         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2183
2184         * WebKitTestRunner/ios/TestControllerIOS.mm:
2185         (WTR::handleMenuWillHideNotification):
2186         (WTR::handleMenuDidHideNotification):
2187         (WTR::TestController::platformInitialize):
2188         (WTR::TestController::platformDestroy):
2189         (WTR::TestController::platformResetStateToConsistentValues):
2190
2191         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2192         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2193
2194         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2195         (WTR::forEachViewInHierarchy):
2196         (WTR::findViewInHierarchyOfType):
2197
2198         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2199         functions that dig through a given view's hierarchy in search of a view of a given class.
2200
2201         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2202         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2203         (WTR::UIScriptController::selectionCaretViewRect const):
2204         (WTR::UIScriptController::selectionRangeViewRects const):
2205         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2206         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2207
2208         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2209
2210         (WTR::UIScriptController::rectForMenuAction const):
2211
2212         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2213         callout bar) whose label matches the given string.
2214
2215         (WTR::UIScriptController::platformContentView const):
2216
2217         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2218         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2219         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2220
2221         (WTR::UIScriptController::platformUndoManager const): Deleted.
2222         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2223         (WTR::UIScriptController::platformContentView const):
2224         (WTR::UIScriptController::platformUndoManager const): Deleted.
2225
2226 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2227
2228         webkitpy: No option to only show unexpected failures in results.html for iPad
2229         https://bugs.webkit.org/show_bug.cgi?id=194554
2230         <rdar://problem/47922442>
2231
2232         Rubber-stamped by Aakash Jain.
2233
2234         Just because a TestExpecations file does not exist for a specific platform does not mean that
2235         TestExpecations are not being used, given that platforms inherit test expectations.
2236
2237         * Scripts/webkitpy/port/base.py:
2238         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2239         * Scripts/webkitpy/port/base_unittest.py:
2240         (PortTest.test_uses_test_expectations_file):
2241
2242 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2243
2244         Remove setDefersLoading infrastructure from WebKit2
2245         https://bugs.webkit.org/show_bug.cgi?id=194506
2246
2247         Reviewed by Brady Eidson.
2248
2249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2251         (WTR::TestRunner::setDefersLoading): Deleted.
2252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2253
2254 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2255
2256         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2257         https://bugs.webkit.org/show_bug.cgi?id=194522
2258         <rdar://problem/47789393>
2259
2260         Reviewed by Chris Dumez.
2261
2262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2263         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2264         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2266
2267 2019-02-12  Andy Estes  <aestes@apple.com>
2268
2269         [iOSMac] Enable Parental Controls Content Filtering
2270         https://bugs.webkit.org/show_bug.cgi?id=194521
2271         <rdar://39732376>
2272
2273         Reviewed by Tim Horton.
2274
2275         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2276
2277 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2278
2279         [LFC][IFC] Add intrinsic width support for float boxes.
2280         https://bugs.webkit.org/show_bug.cgi?id=194528
2281
2282         Reviewed by Antti Koivisto.
2283
2284         Expand tests coverage (2 new tests -> 800).
2285         (This is the correct test ordering --runs-singly --child-processes=1)
2286
2287         * LayoutReloaded/misc/LFC-passing-tests.txt:
2288
2289 2019-02-12  Rob Buis  <rbuis@igalia.com>
2290
2291         Implement serializing in MIME type parser
2292         https://bugs.webkit.org/show_bug.cgi?id=193909
2293
2294         Reviewed by Darin Adler.
2295
2296         Add various tests involving upper case, non-ASCII, control/null characters,
2297         various HTTP whitespace, single quotes and an unpaired surrogate.
2298
2299         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2300         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2301         (TestWebKitAPI::serializeIfValid):
2302         (TestWebKitAPI::TEST):
2303
2304 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2305
2306         [Cocoa] Ask platform for generic font family mappings
2307         https://bugs.webkit.org/show_bug.cgi?id=187723
2308         <rdar://problem/41892438>
2309
2310         Reviewed by Brent Fulgham.
2311
2312         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2313
2314         * DumpRenderTree/mac/DumpRenderTree.mm:
2315         (allowedFontFamilySet):
2316         * WebKitTestRunner/mac/TestControllerMac.mm:
2317         (WTR::allowedFontFamilySet):
2318
2319 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2320
2321         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2322         https://bugs.webkit.org/show_bug.cgi?id=193622
2323
2324         Reviewed by Michael Catanzaro.
2325
2326         This adds support for loading content extension rule sets from the JSON files which
2327         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2328         of WKTR for this could be removed, but that is left for a follow-up patch with
2329         cleanups.
2330
2331         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2332         * WebKitTestRunner/TestController.cpp:
2333         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2334         avoid having the null-terminator copied into the result.
2335         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2336         part of the preparations to run a test.
2337         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2338         (WTR::contentExtensionStoreCallback): Added.
2339         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2340         used for content extensions test.
2341         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2342         extensions and compiling the JSON rule set for tests involving content extensions.
2343         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2344         testing and disables content extensions.
2345         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2346         resetContentExtensions().
2347         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2348         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2349         configureContentExtensionForTest(), and userContentController().
2350
2351 2019-02-11  Daniel Bates  <dabates@apple.com>
2352
2353         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2354         https://bugs.webkit.org/show_bug.cgi?id=191446
2355         <rdar://problem/45929460>
2356
2357         Reviewed by Tim Horton.
2358
2359         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2360
2361         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2362         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2363         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2364         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2365         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2366         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2367         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2368         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2369         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2370         (WTR::arrayLength):
2371         (WTR::parseModifierArray):
2372         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2373         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2374         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2375         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2376
2377 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2378
2379         Unreviewed, rolling out r241272 and r241276.
2380         https://bugs.webkit.org/show_bug.cgi?id=194514
2381
2382         Broke the Apple Internal build and the fix requires human
2383         intervention :( (Requested by dydz on #webkit).
2384
2385         Reverted changesets:
2386
2387         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2388         https://bugs.webkit.org/show_bug.cgi?id=191446
2389         https://trac.webkit.org/changeset/241272
2390
2391         "Fix internal iOS build after r241272"
2392         https://bugs.webkit.org/show_bug.cgi?id=191446
2393         https://trac.webkit.org/changeset/241276
2394
2395 2019-02-11  Truitt Savell  <tsavell@apple.com>
2396
2397         Unreviewed, rolling out r241269.
2398
2399         Caused 5 layout tests crashes on Mac WK1
2400
2401         Reverted changeset:
2402
2403         "DumpRenderTree should report unknown options"
2404         https://bugs.webkit.org/show_bug.cgi?id=191303
2405         https://trac.webkit.org/changeset/241269
2406
2407 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2408
2409         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2410         https://bugs.webkit.org/show_bug.cgi?id=194313
2411
2412         Reviewed by Tim Horton.
2413
2414         Add a helper to determine whether the web view is presenting modal UI.
2415
2416         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2417         (WTR::UIScriptController::isPresentingModally const):
2418         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2419         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2420         (WTR::UIScriptController::isPresentingModally const):
2421         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2422         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2423         (WTR::UIScriptController::calendarType const): Deleted.
2424         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2425         (WTR::UIScriptController::isPresentingModally const):
2426         (WTR::UIScriptController::calendarType const):
2427         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2428         (WTR::UIScriptController::calendarType const):
2429
2430 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2431
2432         GCHeapInspector: Show the retained sizes in more places
2433         https://bugs.webkit.org/show_bug.cgi?id=194464
2434
2435         Reviewed by Simon Fraser.
2436
2437         * GCHeapInspector/gc-heap-inspector.html:
2438         * GCHeapInspector/script/interface.js:
2439         (HeapInspectorUtils.humanReadableSize):
2440         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2441         (HeapInspectorUtils.spanForNode.span.span):
2442         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2443         (HeapSnapshotInspector.prototype.buildRoots):
2444
2445 2019-02-11  Daniel Bates  <dabates@apple.com>
2446
2447         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2448         https://bugs.webkit.org/show_bug.cgi?id=191446
2449         <rdar://problem/45929460>
2450
2451         Reviewed by Tim Horton.
2452
2453         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2454
2455         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2456         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2457         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2458         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2459         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2460         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2461         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2462         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2464         (WTR::arrayLength):
2465         (WTR::parseModifierArray):
2466         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2467         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2468         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2469         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2470
2471 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2472
2473         DumpRenderTree should report unknown options
2474         https://bugs.webkit.org/show_bug.cgi?id=191303
2475
2476         Reviewed by Frédéric Wang.
2477
2478         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2479         to report unknown options.
2480         Added and assigned test options which are currently used in tests.
2481
2482         * DumpRenderTree/TestOptions.cpp:
2483         (TestOptions::TestOptions):
2484
2485 2019-02-11  Truitt Savell  <tsavell@apple.com>
2486
2487         Unreviewed, rolling out r241229.
2488
2489         Revision broke internal builds for watchOS.
2490
2491         Reverted changeset:
2492
2493         "[Cocoa] Ask platform for generic font family mappings"
2494         https://bugs.webkit.org/show_bug.cgi?id=187723
2495         https://trac.webkit.org/changeset/241229
2496
2497 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2498
2499         [WinCairo][MiniBrowser] Basic authentication always fails.
2500         https://bugs.webkit.org/show_bug.cgi?id=194496
2501
2502         Reviewed by Don Olmstead.
2503
2504         * MiniBrowser/win/DialogHelper.h:
2505         (Dialog::getText):
2506
2507 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2508
2509         [GStreamer] GstMappedBuffer testsuite build fails
2510         https://bugs.webkit.org/show_bug.cgi?id=194495
2511
2512         Reviewed by Carlos Garcia Campos.
2513
2514         Fix the build by explicitely adding the gstreamer1.0-audio include
2515         directories to the include path.
2516
2517         * TestWebKitAPI/PlatformGTK.cmake:
2518         * TestWebKitAPI/PlatformWPE.cmake:
2519
2520 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2521
2522         [GTK][WPE] Add enable-javascript-markup setting
2523         https://bugs.webkit.org/show_bug.cgi?id=193439
2524
2525         Reviewed by Michael Catanzaro.
2526
2527         Add test cases to check the new setting.
2528
2529         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2530         (testWebKitSettings):
2531         (testWebKitSettingsJavaScriptMarkup):
2532         (beforeAll):
2533
2534 2019-02-10  Darin Adler  <darin@apple.com>
2535
2536         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2537         https://bugs.webkit.org/show_bug.cgi?id=194485
2538
2539         Reviewed by Daniel Bates.
2540
2541         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2542
2543 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2544
2545         Add more tests for clampTo<>()
2546         https://bugs.webkit.org/show_bug.cgi?id=194462
2547
2548         Reviewed by Geoffrey Garen.
2549
2550         Darin suggested to test the very last floating point number
2551         at the boundaries when truncating to integer.
2552         I added test for max/min and max-1/min-1.
2553
2554         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2555         (TestWebKitAPI::TEST):
2556
2557 2019-02-09  Darin Adler  <darin@apple.com>
2558
2559         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2560         https://bugs.webkit.org/show_bug.cgi?id=194021
2561
2562         Reviewed by Geoffrey Garen.
2563
2564         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2565         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2566         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2567
2568 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2569
2570         [LFC][IFC] Add intrinsic width support for basic inline containers
2571         https://bugs.webkit.org/show_bug.cgi?id=194473
2572
2573         Reviewed by Antti Koivisto.
2574
2575         Expand tests coverage (11 new tests -> 798)
2576
2577         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2578
2579 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2580
2581         Fix MiniBrowser's entitlements
2582         https://bugs.webkit.org/show_bug.cgi?id=192431
2583
2584         Reviewed by Joseph Pecoraro.
2585
2586         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2587         files, making it impossible to load any extension.
2588
2589         * MiniBrowser/MiniBrowser.entitlements:
2590
2591 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2592
2593         [Cocoa] Ask platform for generic font family mappings
2594         https://bugs.webkit.org/show_bug.cgi?id=187723
2595         <rdar://problem/41892438>
2596
2597         Reviewed by Brent Fulgham.
2598
2599         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2600
2601         * DumpRenderTree/mac/DumpRenderTree.mm:
2602         (allowedFontFamilySet):
2603         * WebKitTestRunner/mac/TestControllerMac.mm:
2604         (WTR::allowedFontFamilySet):
2605
2606 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2607
2608         [GTK] Implement back/forward touchpad gesture
2609         https://bugs.webkit.org/show_bug.cgi?id=193919
2610
2611         Reviewed by Michael Catanzaro.
2612
2613         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2614         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2615
2616 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2617
2618         Add SPI to use networking daemon instead of XPC service
2619         https://bugs.webkit.org/show_bug.cgi?id=194427
2620
2621         Reviewed by Geoffrey Garen
2622
2623         * MiniBrowser/MiniBrowser.entitlements:
2624
2625 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2626
2627         [ews-build] Ensure that every builder in config.json has short name
2628         https://bugs.webkit.org/show_bug.cgi?id=194461
2629
2630         Reviewed by Lucas Forschler.
2631
2632         * BuildSlaveSupport/ews-build/loadConfig.py:
2633         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2634
2635 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2636
2637         [ews-build] Add short name to config.json
2638         https://bugs.webkit.org/show_bug.cgi?id=194456
2639
2640         Reviewed by Lucas Forschler.
2641
2642         * BuildSlaveSupport/ews-build/config.json: Added short name.
2643         * BuildSlaveSupport/ews-build/loadConfig.py:
2644         (loadBuilderConfig): Set the short name as the builder description.
2645
2646 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2647
2648         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2649         https://bugs.webkit.org/show_bug.cgi?id=194418
2650
2651         Reviewed by Lucas Forschler.
2652
2653         Do not include errors trying when finding crashlogs at the end of
2654         a run-webkit-tests run since we don't process those errors.
2655
2656         * Scripts/webkitpy/port/darwin.py:
2657         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2658         * Scripts/webkitpy/port/ios_device.py:
2659         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2660         * Scripts/webkitpy/port/watch_device.py:
2661         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2662
2663 2019-02-08  Beth Dakin  <bdakin@apple.com>
2664
2665         Add afterScreenUpdates to WKSnapshotConfiguration
2666         https://bugs.webkit.org/show_bug.cgi?id=194362
2667         -and corresponding-
2668         <rdar://problem/40655528> Please add an "after screen updates" property to 
2669         WKSnapshotConfiguration (to solve blank snapshots)
2670
2671         Reviewed by Tim Horton.
2672
2673         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2674         (TEST):
2675
2676 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2677
2678         clampTo(): do not convert the input to double when dealing with integers
2679         https://bugs.webkit.org/show_bug.cgi?id=194263
2680         <rdar://problem/47692312>
2681
2682         Reviewed by Darin Adler.
2683
2684         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2685         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2686         (TestWebKitAPI::testClampFloatingPointToInteger):
2687         (TestWebKitAPI::testClampSameSignIntegers):
2688         (TestWebKitAPI::testClampUnsignedToSigned):
2689         (TestWebKitAPI::testClampSignedToUnsigned):
2690
2691 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2692
2693         webkitpy: Respect --dedicated-simulators flag
2694         https://bugs.webkit.org/show_bug.cgi?id=194416
2695         <rdar://problem/47894722>
2696
2697         Reviewed by Lucas Forschler.
2698
2699         * Scripts/webkitpy/port/device_port.py:
2700         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2701         available devices can be safely ignored.
2702
2703 2019-02-07  Keith Rollin  <krollin@apple.com>
2704
2705         Remove extra copy of 100x100-red.tga
2706         https://bugs.webkit.org/show_bug.cgi?id=194371
2707         <rdar://problem/47873465>
2708
2709         Reviewed by Said Abou-Hallawa.
2710
2711         In order to help it pass its tests, Bug 194190 added a second copy of
2712         the file 100x100-red.tga. However, it turns out that this additional
2713         file wasn't actually needed, and that that sole previous copy was
2714         sufficient. At the same time, this second copy -- which was copied to
2715         the same location in the build output as the first copy -- now caused
2716         XCBuild to complain because there were two production rules for the
2717         same output file. Address this by removing the newly-added extra copy.
2718
2719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2720         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2721
2722 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2723
2724         Deprecate WKBundlePageSetDefersLoading
2725         https://bugs.webkit.org/show_bug.cgi?id=191394
2726
2727         Reviewed by Dean Jackson.
2728
2729         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2730         (WTR::TestRunner::setDefersLoading):
2731
2732 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2733
2734         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2735         https://bugs.webkit.org/show_bug.cgi?id=194391
2736
2737         Reviewed by Antti Koivisto.
2738
2739         * LayoutReloaded/misc/LFC-passing-tests.txt:
2740
2741 2019-02-06  Keith Rollin  <krollin@apple.com>
2742
2743         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2744         https://bugs.webkit.org/show_bug.cgi?id=193975
2745         <rdar://problem/47643306>
2746
2747         Reviewed by Tim Horton.
2748
2749         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2750         the Info.plist file into the bundle. This step is not necessary as the
2751         implicit "bundle up all the build products into a framework" build
2752         phase does this already. Having the Copy Bundle Resources phase do
2753         this causes a conflict under XCBuild, which objects to two build
2754         phases producing the same file (Info.plist). Address this by removing
2755         Info.plist from the Copy Bundle Resources phase.
2756
2757         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2758
2759 2019-02-06  Keith Rollin  <krollin@apple.com>
2760
2761         Really enable the automatic checking and regenerations of .xcfilelists during builds
2762         https://bugs.webkit.org/show_bug.cgi?id=194357
2763         <rdar://problem/47861231>
2764
2765         Reviewed by Chris Dumez.
2766
2767         Bug 194124 was supposed to enable the automatic checking and
2768         regenerating of .xcfilelist files during the build. While related
2769         changes were included in that patch, the change to actually enable the
2770         operation somehow was omitted. This patch actually enables the
2771         operation. The check-xcfilelist.sh scripts now check
2772         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2773         from the checking.
2774
2775         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2776         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2777
2778 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2779
2780         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2781         <https://webkit.org/b/194286>
2782         <rdar://problem/47815558>
2783
2784         Reviewed by Alexey Proskuryakov.
2785
2786         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2787         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2788         WKRetainPtr<> to avoid leaking the WKDataRef.
2789
2790 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2791
2792         Unreviewed, fix a typo
2793
2794         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2795
2796 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2797
2798         [GTK][WPE] force libpsl build to use ICU in jhbuild
2799         https://bugs.webkit.org/show_bug.cgi?id=194288
2800
2801         Reviewed by Carlos Garcia Campos.
2802
2803         * gtk/jhbuild.modules:
2804         Require ICU for libpsl build in jhbuild, like done in WPE.
2805
2806 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2807
2808         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2809         https://bugs.webkit.org/show_bug.cgi?id=194209
2810
2811         Reviewed by Carlos Garcia Campos.
2812
2813         Enhance TestCookieManager to ensure this doesn't happen again.
2814
2815         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2816         (testCookieManagerPersistentStorage):
2817         (beforeAll):
2818
2819 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2820
2821         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2822         https://bugs.webkit.org/show_bug.cgi?id=194324
2823
2824         Reviewed by Andy Estes.
2825
2826         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2827         part of the name is already implicit, since this is in testing code in TestOptions.
2828
2829         * WebKitTestRunner/TestController.cpp:
2830         (WTR::TestController::generateContextConfiguration const):
2831         (WTR::updateTestOptionsFromTestHeader):
2832         * WebKitTestRunner/TestOptions.h:
2833         (WTR::TestOptions::hasSameInitializationOptions const):
2834
2835 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2836
2837         [ews-build] Allow * as platform for builders and workers
2838         https://bugs.webkit.org/show_bug.cgi?id=188533
2839
2840         Reviewed by Lucas Forschler.
2841
2842         * BuildSlaveSupport/ews-build/loadConfig.py:
2843         (checkWorkersAndBuildersForConsistency):
2844
2845 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2846
2847         [ews-build] Add few bots to config.json
2848         https://bugs.webkit.org/show_bug.cgi?id=194304
2849
2850         Reviewed by Lucas Forschler.
2851
2852         * BuildSlaveSupport/ews-build/config.json:
2853
2854 2019-02-05  Keith Rollin  <krollin@apple.com>
2855
2856         Enable the automatic checking and regenerations of .xcfilelists during builds
2857         https://bugs.webkit.org/show_bug.cgi?id=194124
2858         <rdar://problem/47721277>
2859
2860         Reviewed by Tim Horton.
2861
2862         Bug 193790 add a facility for checking -- during build time -- that
2863         any needed .xcfilelist files are up-to-date and for updating them if
2864         they are not. This facility was initially opt-in by setting
2865         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2866         the process seemed robust. Its now time to enable this facility and
2867         make it opt-out. If there is a need to disable this facility, set and
2868         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2869         running `make` or `build-webkit`, or before running Xcode from the
2870         command line.
2871
2872         Additionally, remove the step that generates a list of source files
2873         going into the UnifiedSources build step. It's only necessarily to
2874         specify Sources.txt and SourcesCocoa.txt as inputs.
2875
2876         * Scripts/generate-xcfilelists:
2877
2878 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2879
2880         [GTK][WPE] force libpsl build to use ICU in jhbuild
2881         https://bugs.webkit.org/show_bug.cgi?id=194288
2882
2883         Reviewed by Philippe Normand.
2884
2885         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2886         This can cause build failures if libidn is detected but libunistring is not available.
2887
2888         Make sure that ICU is used for runtime and builtin PSL data.
2889
2890         * gtk/jhbuild.modules:
2891         * wpe/jhbuild.modules:
2892
2893 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2894
2895         [ews-app] Modified timestamp should be updated on updating data
2896         https://bugs.webkit.org/show_bug.cgi?id=194295
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * BuildSlaveSupport/ews-app/ews/models/build.py:
2901         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2902         * BuildSlaveSupport/ews-app/ews/models/step.py:
2903
2904 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2905
2906         Unreviewed, rolling out r240742.
2907
2908         Causes crashes on iOS simulator.
2909
2910         Reverted changeset:
2911
2912         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2913         not focused in a content-editable element"
2914         https://bugs.webkit.org/show_bug.cgi?id=192824
2915         https://trac.webkit.org/changeset/240742
2916
2917 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2918
2919         run-webkit-tests emits message "...running None" when running tests
2920         https://bugs.webkit.org/show_bug.cgi?id=194133
2921         <rdar://problem/47724738>
2922
2923         Reviewed by Lucas Forschler.
2924
2925         * Scripts/webkitpy/xcode/device_type.py:
2926         (DeviceType.__str__): Use both version mapping tables and use just the variant
2927         name if no version name is available.
2928         * Scripts/webkitpy/xcode/device_type_unittest.py:
2929         (DeviceTypeTest):
2930         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2931         an associated named.
2932
2933 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2934
2935         [WPE] require python3-setuptools for meson build in jhbuild
2936         https://bugs.webkit.org/show_bug.cgi?id=194287
2937
2938         Reviewed by Philippe Normand.
2939
2940         python3-setuptools is needed to build meson in jhbuild.
2941         It is already required by the GTK port.
2942
2943         * wpe/install-dependencies:
2944
2945 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-app] Add method to save BuilderMapping to database
2948         https://bugs.webkit.org/show_bug.cgi?id=194264
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2953         (BuilderMapping.__str__):
2954         (BuilderMapping):
2955         (BuilderMapping.save_mapping):
2956         (BuilderMapping.update_mapping):
2957         (BuilderMapping.get_existing_mapping):
2958         (BuilderMapping.is_valid_mapping):
2959
2960 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2961
2962         [ews-app] Add timestamp fields for BuilderMappings
2963         https://bugs.webkit.org/show_bug.cgi?id=194266
2964
2965         Reviewed by Lucas Forschler.
2966
2967         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2968         (BuilderMapping):
2969
2970 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2971
2972         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2973         https://bugs.webkit.org/show_bug.cgi?id=174816
2974
2975         Reviewed by Michael Catanzaro.
2976
2977         Add tests for webkit_uri_for_display().
2978
2979         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2980         (testURIForDisplayUnaffected):
2981         (testURIForDisplayAffected):
2982         (beforeAll):
2983         (afterAll):
2984         * TestWebKitAPI/glib/CMakeLists.txt:
2985
2986 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2987
2988         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2989         https://bugs.webkit.org/show_bug.cgi?id=194158
2990         <rdar://problem/47737268>
2991
2992         Rubber-stamped by Aakash Jain.
2993
2994         * Scripts/webkitpy/port/device_port.py:
2995         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2996
2997 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2998
2999         [CG] Enable setAdditionalSupportedImageTypes for WK1
3000         https://bugs.webkit.org/show_bug.cgi?id=194190
3001
3002         Reviewed by Tim Horton.
3003
3004         Add a test similar to the one under WebKit Cocoa but make it create a
3005         WebView instead of a WKWebView.
3006
3007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3008         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3009         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3010         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3011         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3012         (TestWebKitAPI::runTest):
3013         (TestWebKitAPI::TEST):
3014
3015 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3016
3017         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3018         https://bugs.webkit.org/show_bug.cgi?id=194168
3019
3020         Reviewed by Simon Fraser.
3021
3022         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3023
3024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3025         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3026         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3027         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3028         (TEST):
3029         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3030         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3031
3032 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3033
3034         REGRESSION (r237269): webkit-patch what-broke is broken 
3035         https://bugs.webkit.org/show_bug.cgi?id=193025
3036
3037         Reviewed by Aakash Jain.
3038
3039         * Scripts/webkitpy/common/host.py:
3040         (Host.buildbot):
3041         (Host.bugzilla): Renamed to 'buildbot'.
3042
3043 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3044
3045         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3046         https://bugs.webkit.org/show_bug.cgi?id=194207
3047
3048         Reviewed by Tim Horton.
3049
3050         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3051         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3052         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3053         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3054         start and delete forwards to remove the original attachment.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3057         (TestWebKitAPI::TEST):
3058
3059 2019-02-04  Youenn Fablet  <youenn@apple.com>
3060
3061         Capture state should be managed consistently when doing process swapping
3062         https://bugs.webkit.org/show_bug.cgi?id=194122
3063         <rdar://problem/47609293>
3064
3065         Reviewed by Eric Carlson.
3066
3067         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3068         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3069         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3070         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3071         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3072         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3073         (WTR::TestRunner::isDoingMediaCapture const):
3074         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3075         * WebKitTestRunner/TestController.cpp:
3076         (WTR::TestController::isDoingMediaCapture const):
3077         * WebKitTestRunner/TestController.h:
3078         * WebKitTestRunner/TestInvocation.cpp:
3079         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3080         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3081         (WTR::TestController::isDoingMediaCapture const):
3082
3083 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3084
3085         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3086         https://bugs.webkit.org/show_bug.cgi?id=194142
3087
3088         Reviewed by Ross Kirsling.
3089
3090         There three 'separator' variables in TestController.cpp. Renamed
3091         it 'pathSeparator', and unified them.
3092
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::TestController::generateContextConfiguration const):
3095         (WTR::createTestURL):
3096         (WTR::TestController::platformAdjustContext):
3097
3098 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3099
3100         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3101         https://bugs.webkit.org/show_bug.cgi?id=194198
3102
3103         Reviewed by Antti Koivisto.
3104
3105         No need to set the banner heights on navigation now, since Page stores them.
3106
3107         * MiniBrowser/mac/WK2BrowserWindowController.m:
3108         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3109
3110 2019-02-03  John Wilander  <wilander@apple.com>
3111
3112         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3113         https://bugs.webkit.org/show_bug.cgi?id=194104
3114         <rdar://problem/47649991>
3115
3116         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3117
3118         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3119         (TestWebKitAPI::TEST):
3120             Changed numeric types from unsigned short to uint32_t.
3121
3122 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3123
3124         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3125         <https://webkit.org/b/194178>
3126         <rdar://problem/47753473>
3127
3128         Reviewed by Alexey Proskuryakov.
3129
3130         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3131         (WTR::uninstallFakeHelvetica): Pass nullptr into
3132         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3133
3134 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3135
3136         [LFC] Initialize ICB's style with fixed width/height.
3137         https://bugs.webkit.org/show_bug.cgi?id=194188
3138
3139         Reviewed by Antti Koivisto.
3140
3141         * LayoutReloaded/misc/LFC-passing-tests.txt:
3142
3143 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3144
3145         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3146         https://bugs.webkit.org/show_bug.cgi?id=194185
3147
3148         Reviewed by Antti Koivisto.
3149
3150         * LayoutReloaded/misc/LFC-passing-tests.txt:
3151
3152 2018-12-16  Darin Adler  <darin@apple.com>
3153
3154         Convert additional String::format clients to alternative approaches
3155         https://bugs.webkit.org/show_bug.cgi?id=192746
3156
3157         Reviewed by Alexey Proskuryakov.
3158
3159         * WebKitTestRunner/TestController.cpp:
3160         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3161         as an intermediate in code that ultimately constructs a WTF::String.
3162         (WTR::userMediaOriginHash): Use makeString.
3163         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3164         (WTR::TestController::didPerformClientRedirect): Ditto.
3165         (WTR::TestController::didPerformServerRedirect): Ditto.
3166         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3167
3168 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3169
3170         [ews-build] Add unit test to verify builder keys
3171         https://bugs.webkit.org/show_bug.cgi?id=194152
3172
3173         Reviewed by Lucas Forschler.
3174
3175         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3176         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3177
3178 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3179
3180         [LFC] Expand tests coverage (12 new tests -> 787)
3181
3182         Unreviewed test gardening.
3183
3184         * LayoutReloaded/misc/LFC-passing-tests.txt:
3185
3186 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3187
3188         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3189         https://bugs.webkit.org/show_bug.cgi?id=194163
3190
3191         Reviewed by Simon Fraser.
3192
3193         775
3194
3195         * LayoutReloaded/misc/LFC-passing-tests.txt:
3196
3197 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3198
3199         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3200         https://bugs.webkit.org/show_bug.cgi?id=194140
3201         <rdar://problem/47728098>
3202
3203         Reviewed by Tim Horton.
3204
3205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3207         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3208
3209         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3210         test to induce an IPC deadlock when presenting a modal alert during touch start.
3211
3212         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3213         * WebKitTestRunner/TestController.cpp:
3214         (WTR::runJavaScriptAlert):
3215
3216         Add a client callback function for running JavaScript alerts.
3217
3218         (WTR::TestController::createOtherPage):
3219         (WTR::TestController::generateContextConfiguration const):
3220
3221         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3222         the fix in this patch.
3223
3224         (WTR::TestController::createWebViewWithOptions):
3225
3226         Plumb TestOptions to generateContextConfiguration.
3227
3228         (WTR::TestController::resetPreferencesToConsistentValues):
3229         (WTR::TestController::resetStateToConsistentValues):
3230         (WTR::updateTestOptionsFromTestHeader):
3231         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3232         (WTR::TestController::handleJavaScriptAlert):
3233         * WebKitTestRunner/TestController.h:
3234         * WebKitTestRunner/TestInvocation.cpp:
3235         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3236         * WebKitTestRunner/TestOptions.h:
3237         (WTR::TestOptions::hasSameInitializationOptions const):
3238
3239 2019-02-01  Chris Dumez  <cdumez@apple.com>
3240
3241         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3242         https://bugs.webkit.org/show_bug.cgi?id=193740
3243         <rdar://problem/47527267>
3244
3245         Reviewed by Alex Christensen.
3246
3247         Add API test coverage.
3248
3249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3250
3251 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3252
3253         [ews-app] Add display name field to BuilderMapping model
3254         https://bugs.webkit.org/show_bug.cgi?id=194153
3255
3256         Reviewed by Lucas Forschler.
3257
3258         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3259         (BuilderMapping):
3260
3261 2019-02-01  Youenn Fablet  <youenn@apple.com>
3262
3263         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3264         https://bugs.webkit.org/show_bug.cgi?id=194155
3265
3266         Reviewed by Eric Carlson.
3267
3268         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3269         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3270         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3271
3272 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3273
3274         [LFC] Adjust replaced element's intrinsic ratio
3275         https://bugs.webkit.org/show_bug.cgi?id=194154
3276
3277         Reviewed by Antti Koivisto.
3278
3279         761
3280
3281         * LayoutReloaded/misc/LFC-passing-tests.txt:
3282
3283 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3284
3285         [WPE] Show test results in minibrowser
3286         https://bugs.webkit.org/show_bug.cgi?id=194150
3287
3288         Reviewed by Žan Doberšek.
3289
3290         * Scripts/webkitpy/port/wpe.py:
3291         (WPEPort.show_results_html_file):
3292
3293 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3294
3295         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3296         https://bugs.webkit.org/show_bug.cgi?id=194151
3297
3298         Reviewed by Žan Doberšek.
3299
3300         ALT + <- go back
3301         ALT + -> go forward
3302
3303         * MiniBrowser/wpe/main.cpp:
3304         (main):
3305
3306 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3307
3308         [LFC] Set intrinsic size on Layout::Replaced
3309         https://bugs.webkit.org/show_bug.cgi?id=194139
3310
3311         Reviewed by Antti Koivisto.
3312
3313         744
3314
3315         * LayoutReloaded/misc/LFC-passing-tests.txt:
3316
3317 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3318
3319         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3320         https://bugs.webkit.org/show_bug.cgi?id=194146
3321
3322         Reviewed by Xabier Rodriguez-Calvar.
3323
3324         It allows to open relative paths.
3325
3326         * MiniBrowser/wpe/main.cpp:
3327         (main):
3328
3329 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3330
3331         Update flakiness dashboard configuration after recent queue changes
3332         https://bugs.webkit.org/show_bug.cgi?id=194127
3333
3334         Rubber-stamped by Aakash Jain.
3335
3336         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3337
3338         * TestResultServer/static-dashboards/builders.jsonp:
3339
3340 2019-01-31  Youenn Fablet  <youenn@apple.com>
3341
3342         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3343         https://bugs.webkit.org/show_bug.cgi?id=194106
3344         <rdar://problem/47676333>
3345
3346         Reviewed by Ryosuke Niwa.
3347
3348         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3349         (TestWebKitAPI::didFinishNavigation):
3350         (TestWebKitAPI::TEST):
3351         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3352
3353 2019-01-31  Chris Dumez  <cdumez@apple.com>
3354
3355         Page zoom level is lost after a process swap or a crash
3356         https://bugs.webkit.org/show_bug.cgi?id=194105
3357         <rdar://problem/47610781>
3358
3359         Reviewed by Alex Christensen.
3360
3361         Add API test coverage.
3362
3363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3364         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3365
3366 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3367
3368         Revert r238819 which is unneeded and caused a performance regression.
3369         https://bugs.webkit.org/show_bug.cgi?id=192272
3370         <rdar://problem/46664625>
3371
3372         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3373         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3374         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3375
3376 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3377
3378         Formalize WebKitAdditions mechanism of LoadOptimizer
3379         https://bugs.webkit.org/show_bug.cgi?id=193886
3380         <rdar://problem/47696809>
3381
3382         Reviewed by Brent Fulgham.
3383
3384         * MiniBrowser/MiniBrowser.entitlements:
3385         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3386
3387 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3388
3389         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3390         https://bugs.webkit.org/show_bug.cgi?id=194090
3391
3392         Reviewed by Antti Koivisto.
3393
3394         * LayoutReloaded/misc/LFC-passing-tests.txt:
3395
3396 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3397
3398         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3399         https://bugs.webkit.org/show_bug.cgi?id=194074
3400
3401         Reviewed by Antti Koivisto.
3402
3403         * LayoutReloaded/misc/LFC-passing-tests.txt:
3404
3405 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3406
3407         [LFC][BFC] Add support for block level replaced box.
3408         https://bugs.webkit.org/show_bug.cgi?id=194071
3409
3410         Reviewed by Antti Koivisto.
3411
3412         * LayoutReloaded/misc/LFC-passing-tests.txt:
3413
3414 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3415
3416         Fix WebKitTestRunner's testPath with Windows full paths
3417         https://bugs.webkit.org/show_bug.cgi?id=194012
3418
3419         Reviewed by Alex Christensen.
3420
3421         updateTestOptionsFromTestHeader failed to open test files because
3422         testPath returned wrong file paths. It returned a path "/C:/..."
3423         if a URL "file:///C:/..." was given.
3424
3425         * WebKitTestRunner/TestController.cpp:
3426         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3427
3428 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3429
3430         [WPE] Bump font related dependencies to match the GTK+ port
3431         https://bugs.webkit.org/show_bug.cgi?id=194017
3432
3433         Reviewed by Žan Doberšek.
3434
3435         * wpe/jhbuild.modules:
3436         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3437         * wpe/patches/icudata-stdlibs.patch: Added.
3438
3439 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3440
3441         Enable swipe tests on iOS
3442         https://bugs.webkit.org/show_bug.cgi?id=194076
3443
3444         Reviewed by Geoffrey Garen.
3445
3446         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3447         it causes a debug assertion failure in runUIScript.
3448
3449         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3450         (WTR::UIScriptController::beginBackSwipe):
3451         (WTR::UIScriptController::completeBackSwipe):
3452
3453 2019-01-30  Keith Rollin  <krollin@apple.com>
3454
3455         Use correct printf format specifier
3456         https://bugs.webkit.org/show_bug.cgi?id=194062
3457         <rdar://problem/47686167>
3458
3459         Reviewed by Alexey Proskuryakov.
3460
3461         LayoutTestSpellChecker.mm is trying to format a variable of type
3462         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3463         actually an unsigned long long. Fix this by formatting with %llu.
3464
3465         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3466         (-[LayoutTestTextCheckingResult description]):
3467
3468 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3469
3470         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3471         https://bugs.webkit.org/show_bug.cgi?id=193979
3472
3473         Reviewed by Wenson Hsieh.
3474
3475         Fix the test for iOS. Make the test work with iOS UA string.
3476
3477         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3478
3479 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3480
3481         Replace High Sierra LLINT CLoop bot due to hardware failure
3482         https://bugs.webkit.org/show_bug.cgi?id=194066
3483
3484         Reviewed by Aakash Jain.
3485
3486         * BuildSlaveSupport/build.webkit.org-config/config.json:
3487
3488 2019-01-30  Keith Rollin  <krollin@apple.com>
3489
3490         [NSDragItem init] is unavailable
3491         https://bugs.webkit.org/show_bug.cgi?id=194059
3492         <rdar://problem/47685715>
3493
3494         Reviewed by Wenson Hsieh.
3495
3496         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3497         DumpRenderTree and TestWebKitAPI, which both try to create an
3498         NSDragItem in a manner that invokes this method. Address this by using
3499         -initWithPasteboardWriter instead.
3500
3501         Note that the parameter passed to initWithPasteboardWriter is likely
3502         incorrect. In both cases, the object passed does not conform to
3503         NSPasteboardWriting. However, with this fix, we're no worse off than
3504         before, and can now perform builds with newer compilers and SDKs until
3505         a real fix can be crafted. That work is tracked in
3506         https://bugs.webkit.org/show_bug.cgi?id=194060
3507
3508         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3509         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3510         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3511         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3512
3513 2019-01-30  Daniel Bates  <dabates@apple.com>
3514
3515         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3516         https://bugs.webkit.org/show_bug.cgi?id=192824
3517         <rdar://problem/47100332>
3518
3519         Reviewed by Wenson Hsieh.
3520
3521         Fix a bug where the wrong usage code was used for F13 thru F24.
3522
3523         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3524         (keyCodeForDOMFunctionKey):
3525
3526 2019-01-30  Chris Dumez  <cdumez@apple.com>
3527
3528         Regression(PSON) Load hang can occur on history navigation
3529         https://bugs.webkit.org/show_bug.cgi?id=194030
3530         <rdar://problem/47656939>
3531
3532         Reviewed by Antti Koivisto.
3533
3534         Add API test coverage.
3535
3536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3537
3538 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3539
3540         [LFC] Expand tests coverage.
3541
3542         Unreviewed test gardening.
3543
3544         * LayoutReloaded/misc/LFC-passing-tests.txt:
3545
3546 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3547
3548         [Flatpak] Add openjpeg support
3549         https://bugs.webkit.org/show_bug.cgi?id=194019
3550
3551         Reviewed by Michael Catanzaro.
3552
3553         * flatpak/org.webkit.CommonModules.yaml:
3554
3555 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3556
3557         Unreviewed, rolling out r240708.
3558         https://bugs.webkit.org/show_bug.cgi?id=194022
3559
3560         It broke WPE build (Requested by KaL on #webkit).
3561
3562         Reverted changeset:
3563
3564         "[WPE] Bump font related dependencies to match the GTK+ port"
3565         https://bugs.webkit.org/show_bug.cgi?id=194017
3566         https://trac.webkit.org/changeset/240708
3567
3568 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3569
3570         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3571         https://bugs.webkit.org/show_bug.cgi?id=194001
3572
3573         Reviewed by Antti Koivisto.
3574
3575         * LayoutReloaded/misc/LFC-passing-tests.txt:
3576
3577 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3578
3579         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3580         https://bugs.webkit.org/show_bug.cgi?id=194020
3581
3582         Reviewed by Antti Koivisto.
3583
3584         * LayoutReloaded/misc/LFC-passing-tests.txt:
3585
3586 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3587
3588         AX: Support color well on iOS
3589         https://bugs.webkit.org/show_bug.cgi?id=194010
3590
3591         Reviewed by Joanmarie Diggs.
3592
3593         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3594         (WTR::AccessibilityUIElement::stringAttributeValue):
3595
3596 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3597
3598         [WPE] Bump font related dependencies to match the GTK+ port
3599         https://bugs.webkit.org/show_bug.cgi?id=194017
3600
3601         Reviewed by Žan Doberšek.
3602
3603         * wpe/jhbuild.modules:
3604         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3605         * wpe/patches/icudata-stdlibs.patch: Added.
3606
3607 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3608
3609         [Mac] Update window scale API usage
3610         https://bugs.webkit.org/show_bug.cgi?id=193991
3611         rdar://problem/47614795
3612
3613         Reviewed by Tim Horton.
3614
3615         * DumpRenderTree/mac/DumpRenderTree.mm:
3616         (changeWindowScaleIfNeeded):
3617         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3618         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3619         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3620
3621 2019-01-29  Chris Dumez  <cdumez@apple.com>
3622
3623         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3624         https://bugs.webkit.org/show_bug.cgi?id=193977
3625         <rdar://problem/47643716>
3626
3627         Reviewed by Geoff Garen.
3628
3629         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3630         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3631         to the previous provisional committing *before* we make the last load. 
3632
3633         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3634
3635 2019-01-29  Youenn Fablet  <youenn@apple.com>
3636
3637         Adopt new SPI to evaluate server certificate trust
3638         https://bugs.webkit.org/show_bug.cgi?id=193355
3639
3640         Reviewed by Alex Christensen.
3641
3642         Add infrastructure to handle HTTPS server trust evaluation testing.
3643
3644         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3645         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3646         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3647         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3648         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3649         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3650         * WebKitTestRunner/TestController.cpp:
3651         (WTR::TestController::resetPreferencesToConsistentValues):
3652         (WTR::TestController::didReceiveAuthenticationChallenge):
3653         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3654         * WebKitTestRunner/TestController.h:
3655         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3656         * WebKitTestRunner/TestInvocation.cpp:
3657         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3658         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3659         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3660
3661 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3662
3663         [ews-build] Add build step to print bot Configuration
3664         https://bugs.webkit.org/show_bug.cgi?id=193887
3665
3666         Reviewed by Lucas Forschler.
3667
3668         * BuildSlaveSupport/ews-build/steps.py:
3669         (PrintConfiguration): Build step to print configuration.
3670         * BuildSlaveSupport/ews-build/factories.py:
3671
3672 2019-01-29  Chris Dumez  <cdumez@apple.com>
3673
3674         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3675         https://bugs.webkit.org/show_bug.cgi?id=193967
3676         <rdar://problem/47635348>
3677
3678         Reviewed by Alex Christensen.
3679
3680         Add API test coverage.
3681
3682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3683         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3684
3685 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3686
3687         [ews-app] Handle incoming results data
3688         https://bugs.webkit.org/show_bug.cgi?id=193973
3689
3690         Reviewed by Lucas Forschler.
3691
3692         * BuildSlaveSupport/ews-app/ews/views/results.py:
3693
3694 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3695
3696         [ews-app] Make the results url generic
3697         https://bugs.webkit.org/show_bug.cgi?id=193928
3698
3699         Reviewed by Lucas Forschler.
3700
3701         * BuildSlaveSupport/ews-app/ews/urls.py:
3702
3703 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3704
3705         [ews-build] Configure buildbot to send events to ews-app
3706         https://bugs.webkit.org/show_bug.cgi?id=193968
3707
3708         Reviewed by Lucas Forschler.
3709
3710         * BuildSlaveSupport/ews-build/events.py: Added.
3711         * BuildSlaveSupport/ews-build/master.cfg:
3712
3713 2019-01-29  Keith Rollin  <krollin@apple.com>
3714
3715         Add .xcfilelists to Run Script build phases
3716         https://bugs.webkit.org/show_bug.cgi?id=193792
3717         <rdar://problem/47201785>
3718
3719         Reviewed by Alex Christensen.
3720
3721         As part of supporting XCBuild, update the necessary Run Script build
3722         phases in their Xcode projects to refer to their associated
3723         .xcfilelist files.
3724
3725         Note that the addition of these files bumps the Xcode project version
3726         number to something that's Xcode 10 compatible. This change means that
3727         older versions of the Xcode IDE can't read these projects. Nor can it
3728         fully load workspaces that refer to these projects (the updated
3729         projects are shown as non-expandable placeholders). `xcodebuild` can
3730         still build these projects; it's just that the IDE can't open them.
3731
3732         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3733         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3734
3735 2019-01-29  John Wilander  <wilander@apple.com>
3736
3737         Add data abstraction and validation for Ad Click Attribution
3738         https://bugs.webkit.org/show_bug.cgi?id=193916
3739         <rdar://problem/47603481>
3740
3741         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3742
3743         Ad click attribution has two steps. First, the storage of an ad
3744         campaign ID for a click that takes the user to a destination
3745         site. Second, a conversion on the destination site that can be
3746         attributed to the ad click.
3747
3748         This patch adds a class that represents a request for ad click
3749         attribution. Validation makes sure that the bits of entropy
3750         reported through this mechanism is limited.
3751
3752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3753         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3754         (TestWebKitAPI::TEST):
3755
3756 2019-01-29  Chris Dumez  <cdumez@apple.com>
3757
3758         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3759         https://bugs.webkit.org/show_bug.cgi?id=193932
3760         <rdar://problem/47598947>
3761
3762         Reviewed by Brady Eidson.
3763
3764         Add API test coverage.
3765
3766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3767
3768 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3769
3770         Adding new passing LFC tests.
3771
3772         Unreviewed test gardening.
3773
3774         * LayoutReloaded/misc/LFC-passing-tests.txt:
3775
3776 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3777
3778         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3779         https://bugs.webkit.org/show_bug.cgi?id=193964
3780
3781         Reviewed by Antti Koivisto.
3782
3783         * LayoutReloaded/misc/LFC-passing-tests.txt:
3784
3785 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3786
3787         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3788         https://bugs.webkit.org/show_bug.cgi?id=193954
3789
3790         Reviewed by Antti Koivisto.
3791
3792         * LayoutReloaded/misc/LFC-passing-tests.txt:
3793
3794 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3795
3796         WebDriver: add support for running subtests
3797         https://bugs.webkit.org/show_bug.cgi?id=193904
3798
3799         Reviewed by Michael Catanzaro.
3800
3801         pytest already supports it by passing test.py::subtest, so we can do the same.
3802
3803         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3804         (get_item_name): Made this global.
3805         (CollectRecorder.__init__): Receive the parameter to ignore.
3806         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3807         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3808         (collect): Add parameter to ignore.
3809         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3810         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3811         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3812         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3813         (WebDriverTestRunnerSelenium.run): Ditto.
3814         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3815         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3816         (WebDriverTestRunnerW3C.run): Ditto.
3817
3818 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3819
3820         User agent string override for navigator.userAgent should be site specific quirks
3821         https://bugs.webkit.org/show_bug.cgi?id=193950
3822
3823         Reviewed by Brent Fulgham.
3824
3825         Updated per the _WKWebsitePolicies rename.
3826
3827         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3828         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3829
3830 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3831
3832         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3833         https://bugs.webkit.org/show_bug.cgi?id=193941
3834
3835         Reviewed by Alex Christensen.
3836
3837         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3838         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3839         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3840         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3841         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3842         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3843         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3844         * TestWebKitAPI/Tests/WTF/Time.cpp:
3845         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3846         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3847         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3848         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3849
3850 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3851
3852         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3853
3854         * Scripts/webkitpy/common/config/contributors.json:
3855
3856 2019-01-28  Andy Estes  <aestes@apple.com>
3857
3858         [watchOS] Enable Parental Controls content filtering
3859         https://bugs.webkit.org/show_bug.cgi?id=193939
3860         <rdar://problem/46641912>
3861
3862         Reviewed by Ryosuke Niwa.
3863
3864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3865
3866 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3867
3868         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3869         <https://webkit.org/b/193884>
3870
3871         Reviewed by Jiewen Tan.
3872
3873         * Scripts/webkitpy/style/checkers/cpp.py:
3874         (check_language): Add LocalAuthentication to
3875         `frameworks_with_soft_links`.
3876
3877 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3878
3879         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3880         https://bugs.webkit.org/show_bug.cgi?id=193891
3881
3882         Reviewed by Ross Kirsling.
3883
3884         There were three problems in window sizes of WebView and the host window.
3885         1. The sizes of pixel image output were incorrect.
3886         2. The host window is going to appear after window.resize was invoked.
3887         3. window.resize resized only the host window, not WebView.
3888
3889         This change solves them with a following approach.
3890         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3891         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3892            as well as DumpRenderTree in order to match the client area and the window area.
3893         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3894         d. PlatformWebView::setWindowFrame changes both window sizes.
3895         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3896
3897         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3898         (WTR::PlatformWebView::PlatformWebView): Create the host window
3899         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3900         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3901         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3902
3903 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3904
3905         [ews-app] Add method to save Step data to database
3906         https://bugs.webkit.org/show_bug.cgi?id=193890
3907
3908         Reviewed by Lucas Forschler.
3909
3910         * BuildSlaveSupport/ews-app/ews/models/step.py:
3911         (Step.save_step): Method to save step data.
3912         (Step.update_step): Method to update step data.
3913         (Step.get_existing_step): Method to fetch existing step from database.
3914         (Step.is_valid_result): Method to validate valid step result.
3915
3916 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3917
3918         [ews-app] Add method to save Build data to database
3919         https://bugs.webkit.org/show_bug.cgi?id=193735
3920
3921         Reviewed by Lucas Forschler.
3922
3923         * BuildSlaveSupport/ews-app/ews/models/build.py:
3924         (Build.save_build): Method to save build information to database.
3925         (Build.get_existing_build): Method to fetch existing build from database.
3926         (Build.is_valid_result): Method to validate build result.
3927         * BuildSlaveSupport/ews-app/ews/common/util.py:
3928         (is_valid_int_id): Method to validate valid id.
3929
3930 2019-01-28  Chris Dumez  <cdumez@apple.com>
3931
3932         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3933         https://bugs.webkit.org/show_bug.cgi?id=193915
3934         <rdar://problem/47560907>
3935
3936         Reviewed by Alex Christensen.
3937
3938         Add API test coverage.
3939
3940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3941
3942 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3943
3944         [ews-app] Rename id variables
3945         https://bugs.webkit.org/show_bug.cgi?id=193883
3946
3947         Reviewed by Lucas Forschler.
3948
3949         * BuildSlaveSupport/ews-app/ews/models/build.py:
3950         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3951         * BuildSlaveSupport/ews-app/ews/models/step.py:
3952         * BuildSlaveSupport/ews-app/ews/urls.py:
3953         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3954         * BuildSlaveSupport/ews-app/ews/views/results.py:
3955         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3956
3957 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3958
3959         [ews-app] Allow certain fields to be empty
3960         https://bugs.webkit.org/show_bug.cgi?id=193892
3961
3962         Reviewed by Lucas Forschler.
3963
3964         * BuildSlaveSupport/ews-app/ews/models/build.py:
3965         * BuildSlaveSupport/ews-app/ews/models/step.py:
3966
3967 2019-01-28  Rob Buis  <rbuis@igalia.com>
3968
3969         Update MIME type parser
3970         https://bugs.webkit.org/show_bug.cgi?id=180526
3971
3972         Reviewed by Frédéric Wang.
3973
3974         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3975         (TestWebKitAPI::TEST):
3976
3977 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3978
3979         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3980         https://bugs.webkit.org/show_bug.cgi?id=193896
3981
3982         Reviewed by Antti Koivisto.
3983
3984         * LayoutReloaded/misc/LFC-passing-tests.txt:
3985
3986 2018-12-15  Darin Adler  <darin@apple.com>
3987
3988         Replace many uses of String::format with more type-safe alternatives
3989         https://bugs.webkit.org/show_bug.cgi?id=192742
3990
3991         Reviewed by Mark Lam.
3992
3993         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3994         (WTR::cacheTestRunnerCallback): Use makeString.
3995         * WebKitTestRunner/TestController.cpp:
3996         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3997         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3998
3999 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
4000
4001         Use a load optimizer for some sites
4002         https://bugs.webkit.org/show_bug.cgi?id=193881
4003         <rdar://problem/46325455>
4004
4005         Reviewed by Brent Fulgham.
4006
4007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4008         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
4009
4010 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
4011
4012         AX: Introduce a static accessibility tree
4013         https://bugs.webkit.org/show_bug.cgi?id=193348
4014         <rdar://problem/47203295>
4015
4016         Reviewed by Ryosuke Niwa.
4017
4018         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4019
4020 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4021
4022         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
4023         https://bugs.webkit.org/show_bug.cgi?id=193867
4024
4025         Reviewed by Antti Koivisto.
4026
4027         * LayoutReloaded/misc/LFC-passing-tests.txt:
4028
4029 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4030
4031         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
4032         https://bugs.webkit.org/show_bug.cgi?id=193865
4033
4034         Reviewed by Antti Koivisto.
4035
4036         * LayoutReloaded/misc/LFC-passing-tests.txt:
4037
4038 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
4039
4040         Need a mechanism to override navigator.userAgent
4041         https://bugs.webkit.org/show_bug.cgi?id=193762
4042         <rdar://problem/47504939>
4043
4044         Reviewed by Brent Fulgham.
4045
4046         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
4047
4048         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4049         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4050         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
4051
4052 2019-01-25  Dean Jackson  <dino@apple.com>
4053
4054         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
4055         https://bugs.webkit.org/show_bug.cgi?id=193831
4056         <rdar://problem/47399263>
4057
4058         Reviewed by Chris Dumez.
4059
4060         Two new tests that exercise cross-origin and same-origin System
4061         Previews.
4062
4063         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4064
4065 2019-01-25  Keith Rollin  <krollin@apple.com>
4066
4067         Update Xcode projects with "Check .xcfilelists" build phase
4068         https://bugs.webkit.org/show_bug.cgi?id=193790
4069         <rdar://problem/47201374>
4070
4071         Reviewed by Alex Christensen.
4072
4073         Support for XCBuild includes specifying inputs and outputs to various
4074         Run Script build phases. These inputs and outputs are specified as
4075         .xcfilelist files. Once created, these .xcfilelist files need to be
4076         kept up-to-date. In order to check that they are up-to-date or not,
4077         add an Xcode build step that invokes an external script that performs
4078         the checking. If the .xcfilelists are found to be out-of-date, update
4079         them, halt the build, and instruct the developer to restart the build
4080         with up-to-date files.
4081
4082         At this time, the checking and regenerating is performed only if the
4083         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
4084         who want to use this facility can set this variable and test out the
4085         checking/regenerating. Once it seems like there are no egregious
4086         issues that upset a developer's workflow, we'll unconditionally enable
4087         this facility.
4088
4089         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4090         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
4091         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
4092         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4093
4094 2019-01-25  Keith Rollin  <krollin@apple.com>
4095
4096         Update Xcode projects with "Apply Configuration to XCFileLists" build target
4097         https://bugs.webkit.org/show_bug.cgi?id=193781
4098         <rdar://problem/47201153>
4099
4100         Reviewed by Alex Christensen.
4101
4102         Part of generating the .xcfilelists used as part of adopting XCBuild
4103         includes running `make DerivedSources.make` from a standalone script.
4104         It’s important for this invocation to have the same environment as
4105         when the actual build invokes `make DerivedSources.make`. If the
4106         environments are different, then the two invocations will provide
4107         different results. In order to get the same environment in the
4108         standalone script, have the script launch xcodebuild targeting the
4109         "Apply Configuration to XCFileLists" build target, which will then
4110         re-invoke our standalone script. The script is now running again, this
4111         time in an environment with all workspace, project, target, xcconfig
4112         and other environment variables established.
4113
4114         The "Apply Configuration to XCFileLists" build target accomplishes
4115         this task via a small embedded shell script that consists only of:
4116
4117             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
4118
4119         The process that invokes "Apply Configuration to XCFileLists" first
4120         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
4121         evaluated and exports it into the shell environment. When xcodebuild
4122         is invoked, it inherits the value of this variable and can `eval` the
4123         contents of that variable. Our external standalone script can then set
4124         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
4125         of command-line parameters needed to restart itself in the appropriate
4126         state.
4127
4128         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4129         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4130
4131 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4132
4133         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
4134         https://bugs.webkit.org/show_bug.cgi?id=193802
4135         <rdar://problem/46010580>
4136
4137         Reviewed by Andy Estes.
4138
4139         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4140         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
4141         (TEST):
4142
4143 2019-01-25  Daniel Bates  <dabates@apple.com>
4144
4145         [iOS] uiController.keyDown() does not translate Control modified key
4146         https://bugs.webkit.org/show_bug.cgi?id=192898
4147
4148         Reviewed by Wenson Hsieh.
4149
4150         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
4151         key translation, as applicable. Among other cases, key translation occurs when performing
4152         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
4153         also makes the behavior of uiController.keyDown() more closely match the behavior of a
4154         human pressing down and releasing key(s) using a hardware keyboard.
4155
4156         * WebKitTestRunner/ios/HIDEventGenerator.h:
4157         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4158         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
4159
4160         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
4161         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
4162         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4163         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4164         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
4165         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4166         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
4167         (-[HIDEventGenerator longPress:completionBlock:]):
4168         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
4169         Update code for above renaming.
4170
4171         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
4172         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
4173
4174         (-[HIDEventGenerator keyDown:]): Added.
4175         (-[HIDEventGenerator keyUp:]): Added.
4176         (-[HIDEventGenerator keyPress:completionBlock:]):
4177         (-[HIDEventGenerator eventDispatchThreadEntry:]):
4178         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
4179         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4180         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
4181         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
4182         (WTR::parseModifier): Deleted.
4183
4184 2019-01-25  Keith Rollin  <krollin@apple.com>
4185
4186         Complete the implementation of generate-xcfilelists
4187         https://bugs.webkit.org/show_bug.cgi?id=193782
4188
4189         Reviewed by Alex Christensen.
4190
4191         A preliminary version of generate-xcfilelists was added in r238008.
4192         This patch updates that script in order to:
4193
4194         - Support checking of .xcfilelists
4195         - Perform better execution of `make DerivedSources.make` by
4196           relaunching generate-xcfilelists under xcodebuild
4197         - Support incremental generation and checking of .xcfilelists
4198         - Support supplementary .xcfilelists files from WebKitAdditions
4199         - Support being wrapped by parallel version of generate-xcfilelists in
4200           Internal that adds support for (re)generating WebKit projects in
4201           that repo.
4202         - Support builds that have been performed in WebKitBuild as well as
4203           ~/Library/Developer/code/DerivedData
4204         - Increase robustness and debugging facilities.
4205
4206         * Scripts/generate-xcfilelists:
4207
4208 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4209
4210         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4211         https://bugs.webkit.org/show_bug.cgi?id=193297
4212         <rdar://problem/47158841>
4213
4214         Unreviewed test case fix.
4215
4216         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
4217         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
4218
4219         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4220         (TEST):
4221
4222 2019-01-25  Keith Rollin  <krollin@apple.com>
4223
4224         Update existing .xcfilelists
4225         https://bugs.webkit.org/show_bug.cgi?id=193791
4226         <rdar://problem/47201706>
4227
4228         Reviewed by Alex Christensen.
4229
4230         Many .xcfilelist files were added in r238824 in order to support
4231         XCBuild. Update these with recent changes to the set of build files
4232         and with the current generate-xcfilelist script.
4233
4234         * DumpRenderTree/DerivedSources-input.xcfilelist:
4235         * DumpRenderTree/DerivedSources-output.xcfilelist:
4236         * WebKitTestRunner/DerivedSources-input.xcfilelist:
4237         * WebKitTestRunner/DerivedSources-output.xcfilelist:
4238
4239 2019-01-25  Keith Rollin  <krollin@apple.com>
4240
4241         Fix missing dependencies in extract-dependencies-from-makefile
4242         https://bugs.webkit.org/show_bug.cgi?id=193783
4243         <rdar://problem/47201571>
4244
4245         Reviewed by Alex Christensen.
4246
4247         The extract-dependencies-from-makefile script generates .xcfilelists
4248         for XCBuild by invoking a makefile in --debug mode, parsing the
4249         dependency information in the output, and extracting information
4250         regarding targets and dependents. However, the way `make` emits this
4251         dependency information is not rigorous, and so we need to determine
4252         what lines to look for and parse by trial and error. This approach
4253         didn't coriginally atch all the information we needed to collect, so
4254         update the script to look for the additional lines we now know to look
4255         for.
4256
4257         * Scripts/extract-dependencies-from-makefile:
4258         (Parser):
4259         (Parser.addTarget):
4260         (Parser.addPrereq):
4261         (Parser.doParse):
4262
4263 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4264
4265         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4266         https://bugs.webkit.org/show_bug.cgi?id=193297
4267         <rdar://problem/47158841>
4268
4269         Reviewed by Alex Christensen.
4270
4271         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
4272             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
4273         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4274         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4275         activating the message used to trigger the callback when it is set.
4276
4277 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4278
4279         WKWebView.goBack should reload if there is a safe browsing warning
4280         https://bugs.webkit.org/show_bug.cgi?id=193805
4281         <rdar://problem/46908216>
4282
4283         Reviewed by Geoff Garen.
4284
4285         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4286         (+[Simple3LookupContext sharedLookupContext]):
4287         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4288         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4289         (TEST):
4290
4291 2019-01-25  Chris Dumez  <cdumez@apple.com>
4292
4293         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4294         https://bugs.webkit.org/show_bug.cgi?id=193788
4295         <rdar://problem/47531231>
4296
4297         Reviewed by Alex Christensen.
4298
4299         Add API test coverage.
4300
4301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4302         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4303
4304 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4305
4306         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4307         https://bugs.webkit.org/show_bug.cgi?id=193771
4308
4309         Unreviewed infrastructure fix.
4310
4311         * Scripts/webkitpy/port/darwin.py:
4312         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4313
4314 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4315
4316         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4317
4318 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4319
4320         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4321
4322         * Scripts/webkitpy/common/config/contributors.json:
4323
4324 2019-01-25  Chris Dumez  <cdumez@apple.com>
4325
4326         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4327         https://bugs.webkit.org/show_bug.cgi?id=193779
4328         <rdar://problem/46170903>
4329
4330         Reviewed by Antti Koivisto.
4331
4332         Add API test that quickly navigates forward to a previous process without waiting for it to
4333         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4334         the process' previous page when reconnecting the it for the forward navigation.
4335
4336         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4337
4338 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4339
4340         Need a way for JavaScript (or bundle) code to participate in undo
4341         https://bugs.webkit.org/show_bug.cgi?id=190009
4342         <rdar://problem/44807048>
4343
4344         Reviewed by Ryosuke Niwa.
4345
4346         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4347         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4348
4349         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4350         (WTR::UIScriptController::lastUndoLabel const):
4351         (WTR::UIScriptController::firstRedoLabel const):
4352         (WTR::UIScriptController::platformUndoManager const):
4353         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4354         (WTR::UIScriptController::lastUndoLabel const):
4355         (WTR::UIScriptController::firstRedoLabel const):
4356         (WTR::UIScriptController::platformUndoManager const):
4357         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4358         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4359         (WTR::UIScriptController::lastUndoLabel const):
4360         (WTR::UIScriptController::firstRedoLabel const):
4361         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4362         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4363         (WTR::UIScriptController::lastUndoLabel const):
4364         (WTR::UIScriptController::firstRedoLabel const):
4365         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4366         (WTR::UIScriptController::platformUndoManager const):
4367         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4368         (WTR::UIScriptController::platformUndoManager const):
4369
4370 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4371
4372         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4373         https://bugs.webkit.org/show_bug.cgi?id=193824
4374
4375         Reviewed by Antti Koivisto.
4376
4377         * LayoutReloaded/misc/LFC-passing-tests.txt:
4378
4379 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4380
4381         Update macOS JSC bot configurations
4382         https://bugs.webkit.org/show_bug.cgi?id=193739
4383
4384         Reviewed by Alexey Proskuryakov.
4385
4386         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.