Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
[WebKit-https.git] / Tools / ChangeLog
1 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
2
3         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
4         https://bugs.webkit.org/show_bug.cgi?id=207079
5         <rdar://problem/48290464>
6
7         Reviewed by Brent Fulgham.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
10         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
11         (overrideGetAuthorizationHintsWithURL):
12         (TestWebKitAPI::TEST):
13
14 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
15
16         results.webkit.org: Support jsc stress tests
17         https://bugs.webkit.org/show_bug.cgi?id=204096
18
19         Rubber-stamped by Aakash Jain.
20
21         * Scripts/run-javascriptcore-tests:
22         (runJSCStressTests): Add pass and failures to reported results.
23
24 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
25
26         Make Bugzilla._find_select_element_for_flag more robust
27         https://bugs.webkit.org/show_bug.cgi?id=207148
28
29         Reviewed by Jonathan Bedard.
30
31         This patch resolves two FIXMEs:
32         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
33         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
34
35         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
36         (Bugzilla._fill_attachment_form):
37         (Bugzilla._find_select_element_for_flag):
38
39 2020-02-03  Alex Christensen  <achristensen@webkit.org>
40
41         Reduce size of HashMap and HashSet
42         https://bugs.webkit.org/show_bug.cgi?id=207138
43
44         Reviewed by Yusuke Suzuki.
45
46         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
47         (TestWebKitAPI::TEST):
48         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
49         (TestWebKitAPI::TEST):
50
51 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
52
53         obsolete_attachment should not fail when flags do not exist
54         https://bugs.webkit.org/show_bug.cgi?id=171121
55
56         Reviewed by Jonathan Bedard.
57
58         Before this change, an error occured if a contributor without EditBugs privileges tried
59         to obsolete not their own attachment. With this patch, uploading routine continues with
60         friendly console warning like we have in reassign_bug() method.
61
62         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
63         (Bugzilla):
64         (Bugzilla.obsolete_attachment):
65         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
66
67 2020-02-03  Chris Dumez  <cdumez@apple.com>
68
69         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
70         https://bugs.webkit.org/show_bug.cgi?id=207121
71         <rdar://problem/58880177>
72
73         Reviewed by Alex Christensen.
74
75         Add API test coverage.
76
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
79         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
80         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
81         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
82         (TEST):
83
84 2020-02-03  Lauro Moura  <lmoura@igalia.com>
85
86         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
87         https://bugs.webkit.org/show_bug.cgi?id=206517
88
89         Reviewed by Carlos Alberto Lopez Perez.
90
91         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
92         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
93         starts with a leading slash instead of using the test URL, which could
94         cause input forms with invalid file data.
95
96 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
97
98         [ews] Set custom build summary for webkitpy tests
99         https://bugs.webkit.org/show_bug.cgi?id=207027
100
101         Reviewed by Jonathan Bedard.
102
103         * BuildSlaveSupport/ews-build/factories.py:
104         * BuildSlaveSupport/ews-build/steps.py:
105         (WebKitPyTest.setBuildSummary):
106         (WebKitPyTest.getResultSummary):
107         * BuildSlaveSupport/ews-build/factories_unittest.py:
108
109 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
110
111         run-javascriptcore-tests: Don't split binary results
112         https://bugs.webkit.org/show_bug.cgi?id=207118
113
114         Rubber-stamped by Aakash Jain.
115
116         * Scripts/run-javascriptcore-tests:
117         (runTest): Only report aggregated binary results.
118
119 2020-02-03  Chris Dumez  <cdumez@apple.com>
120
121         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
122
123         The ResponsivenessTimer is disabled for those configurations as of r255518.
124
125         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
126
127 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
128
129         Use std::hypot() where possible
130         https://bugs.webkit.org/show_bug.cgi?id=198483
131
132         Reviewed by Carlos Garcia Campos.
133
134         Use std::hypot() where possible, allowing for a possibly more precise
135         calculation of square roots of sums of two or three square values.
136
137         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
138         (-[DragAndDropSimulator initialProgressForMouseDrag]):
139
140 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
141
142         [JHBuild] remove libvpx
143         https://bugs.webkit.org/show_bug.cgi?id=207103
144
145         Reviewed by Xabier Rodriguez-Calvar.
146
147         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
148         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
149
150         * gstreamer/jhbuild.modules: remove libvpx.
151
152 2020-02-02  Sam Weinig  <weinig@apple.com>
153
154         Update style checker with new locations OS version checks are allowed
155         https://bugs.webkit.org/show_bug.cgi?id=207106
156
157         Reviewed by Alexey Proskuryakov.
158
159         * Scripts/webkitpy/style/checkers/cpp.py:
160         (check_os_version_checks):
161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
162         (WebKitStyleTest.test_os_version_checks):
163         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
164
165 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
166
167         Closing a MiniBrowser WK2 window does not release the WKWebView
168         https://bugs.webkit.org/show_bug.cgi?id=203185
169
170         Reviewed by Wenson Hsieh.
171         
172         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
173         to avoid a retain cycle that keeps the window controller and WKWebView alive.
174
175         * MiniBrowser/mac/WK2BrowserWindowController.m:
176         (-[WK2BrowserWindowController awakeFromNib]):
177
178 2020-01-31  David Quesada  <david_quesada@apple.com>
179
180         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
181         https://bugs.webkit.org/show_bug.cgi?id=206984
182         rdar://problem/58999654
183
184         Reviewed by Brady Eidson.
185
186         Add an API test for a resumed download that receives an authentication challenge. The download
187         delegate should be asked to handle the challenge, and the download should be able to finish.
188
189         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
190         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
191         (-[DownloadCancelingDelegate _download:didReceiveData:]):
192         (-[DownloadCancelingDelegate _downloadDidCancel:]):
193         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
194         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
195         (TEST):
196
197 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
198
199         Add support for specifying background colors when setting marked text
200         https://bugs.webkit.org/show_bug.cgi?id=207065
201         <rdar://problem/57876140>
202
203         Reviewed by Tim Horton.
204
205         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
206         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
207         each describing one range (in the composition) to highlight.
208
209         * DumpRenderTree/ios/TextInputControllerIOS.m:
210         (+[TextInputController isSelectorExcludedFromWebScript:]):
211         (+[TextInputController webScriptNameForSelector:]):
212         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
213         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
214         * DumpRenderTree/mac/TextInputControllerMac.m:
215         (+[TextInputController isSelectorExcludedFromWebScript:]):
216         (+[TextInputController webScriptNameForSelector:]):
217         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
218         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
219         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
220         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
221         (WTR::arrayLength):
222         (WTR::createCompositionHighlightData):
223
224         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
225         is then passed into WebKit via WKBundlePageSetComposition.
226
227         (WTR::TextInputController::setMarkedText):
228         * WebKitTestRunner/InjectedBundle/TextInputController.h:
229
230 2020-01-31  Alex Christensen  <achristensen@webkit.org>
231
232         Add KVO SPI WKWebView._negotiatedLegacyTLS
233         https://bugs.webkit.org/show_bug.cgi?id=207067
234
235         Reviewed by Andy Estes.
236
237         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
238         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
239         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
240         (TestWebKitAPI::TEST):
241         * TestWebKitAPI/config.h:
242
243 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
244
245         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
246         https://bugs.webkit.org/show_bug.cgi?id=207050
247
248         Reviewed by Jonathan Bedard.
249
250         * BuildSlaveSupport/ews-build/steps.py:
251         (ReRunWebKitTests.evaluateCommand):
252
253 2020-01-31  David Kilzer  <ddkilzer@apple.com>
254
255         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
256         <https://webkit.org/b/206759>
257         <rdar://problem/58872607>
258
259         Reviewed by Brent Fulgham.
260
261         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
262         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
263         - Add declaration.
264         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
265         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
266         - Implement by waiting for
267           -[UIViewController isPerformingModalTransition] to return NO
268           while spinning the runloop.
269         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
270         - Call waitForModalTransitionToFinish() to fix the test.
271
272 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
273
274         [ews] add build step to set custom build summary
275         https://bugs.webkit.org/show_bug.cgi?id=207026
276
277         Reviewed by Jonathan Bedard.
278
279         * BuildSlaveSupport/ews-build/steps.py:
280         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
281         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
282         (SetBuildSummary.start):
283
284 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
285
286         results.webkit.org: Handle modified firewall rules
287         https://bugs.webkit.org/show_bug.cgi?id=207047
288
289         Reviewed by Aakash Jain.
290
291         * Scripts/webkitpy/results/upload.py:
292         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
293         indicating the upload failed.
294         * Scripts/webkitpy/results/upload_unittest.py:
295         (UploadTest.test_archive_upload):
296
297 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
298
299         Unreviewed, another speculative test fix after r255041
300
301         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
302         (WTR::TestController::addTestKeyToKeychain):
303         Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
304         potential error due to screen locks.
305
306 2020-01-30  Alex Christensen  <achristensen@webkit.org>
307
308         Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1
309         https://bugs.webkit.org/show_bug.cgi?id=206979
310
311         Reviewed by Brady Eidson.
312
313         * MiniBrowser/mac/SettingsController.m:
314         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
315         (-[TLSNavigationDelegate waitForDidFinishNavigation]):
316         (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]):
317         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]):
318         (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
319         (-[TLSNavigationDelegate webView:didFinishNavigation:]):
320         (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
321         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]):
322         (TestWebKitAPI::TEST):
323
324 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
325
326         PAL: Remove old iOS version macros
327         https://bugs.webkit.org/show_bug.cgi?id=206905
328
329         Reviewed by Darin Adler.
330
331         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Remove USE(NSPROGRESS_PUBLISHING_SPI)
332         with HAVE(NSPROGRESS_PUBLISHING_SPI)
333
334 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
335
336         TestWebKitAPI: Re-baseline AccessibilityTests for Catalyst
337         https://bugs.webkit.org/show_bug.cgi?id=206997
338
339         Reviewed by Wenson Hsieh.
340
341         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
342         (TestWebKitAPI::TEST):
343
344 2020-01-29  Jonathan Bedard  <jbedard@apple.com>
345
346         run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
347         https://bugs.webkit.org/show_bug.cgi?id=206932
348
349         Reviewed by Alexey Proskuryakov.
350
351         * Scripts/webkitpy/xcode/simulated_device.py:
352         (SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
353         some version will return a runtime of the same major version with a minor version
354         that is equal to or greater than the specified minor version.
355         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
356         (test_matching_up_success):
357         (test_matching_up_failure):
358
359 2020-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
360
361         [JSC] Give up IC when unknown structure transition happens
362         https://bugs.webkit.org/show_bug.cgi?id=206846
363
364         Reviewed by Mark Lam.
365
366         Add `crash!` annotation, which allows us to write a crashing JS test.
367
368         * Scripts/run-jsc-stress-tests:
369         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
370         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
371         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
372
373 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
374
375         [GTK] Add api-gtk to EWS bubbles.
376         https://bugs.webkit.org/show_bug.cgi?id=206930
377
378         Reviewed by Aakash Jain.
379
380         A new queue has been added to the EWS to run GTK API tests in r255238.
381         The queue is now running fine with no pre-existent failures.
382         Let's add it to the EWS bubbles.
383
384         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
385         (StatusBubble):
386
387 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
388
389         [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
390         https://bugs.webkit.org/show_bug.cgi?id=206927
391
392         Reviewed by Carlos Garcia Campos.
393
394         Update the default value tested from 4MB to 5MB.
395
396         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
397         (testsJSCOptions):
398
399 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
400
401         [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
402         https://bugs.webkit.org/show_bug.cgi?id=206925
403
404         Reviewed by Carlos Garcia Campos.
405
406         Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
407         run the printing related GTK API tests. Add also the liberation fonts, which are needed to
408         run the complex text controller API tests.
409
410         * gtk/install-dependencies:
411         * wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
412
413 2020-01-28  Tim Horton  <timothy_horton@apple.com>
414
415         macCatalyst: Right clicking on a link follows it immediately
416         https://bugs.webkit.org/show_bug.cgi?id=206919
417         <rdar://problem/58936679>
418
419         Reviewed by Wenson Hsieh.
420
421         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:
422         (TEST):
423         Add a test ensuring that mouseup is still called with the secondary button,
424         even if the event's buttonmask is 0.
425
426 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
427
428         TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
429         https://bugs.webkit.org/show_bug.cgi?id=206913
430         <rdar://problem/58973357>
431
432         Reviewed by Chris Dumez.
433
434         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
435
436 2020-01-28  Tim Horton  <timothy_horton@apple.com>
437
438         macCatalyst: Triple clicking to select a sentence results in an empty selection
439         https://bugs.webkit.org/show_bug.cgi?id=206863
440         <rdar://problem/58776993>
441
442         Reviewed by Wenson Hsieh.
443
444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
445         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm: Added.
446         (-[WKTestingEvent locationInView:]):
447         (-[WKTestingEvent _setButtonMask:]):
448         (-[WKTestingEvent _buttonMask]):
449         (-[WKTestingTouch locationInView:]):
450         (-[WKTestingTouch setTapCount:]):
451         (-[WKTestingTouch tapCount]):
452         (mouseGesture):
453         (TEST):
454         Add a test ensuring that simply plumbing mouse events to WebCore
455         does not result in a selection change in macCatalyst (because UIKit
456         will handle the selection change itself, instead).
457
458 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
459
460         TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
461         https://bugs.webkit.org/show_bug.cgi?id=206907
462         <rdar://problem/58969924>
463
464         Rubber-stamped by Alexey Proskuryakov.
465
466         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm: Conditionalize on USE(QUICK_LOOK).
467
468 2020-01-28  Sihui Liu  <sihui_liu@apple.com>
469
470         IndexedDB: speed up index records deletion
471         https://bugs.webkit.org/show_bug.cgi?id=206196
472
473         Reviewed by Brady Eidson.
474
475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
476         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgrade.sqlite3: Added.
477         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.html: Added.
478         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm: Added.
479         (-[IDBObjectStoreInfoUpgradeToV2MessageHandler userContentController:didReceiveScriptMessage:]):
480         (TEST):
481
482 2020-01-28  James Darpinian  <jdarpinian@chromium.org>
483
484         Quote file argument to git check-attr
485         https://bugs.webkit.org/show_bug.cgi?id=206322
486
487         Reviewed by Jonathan Bedard.
488
489         * Scripts/prepare-ChangeLog:
490         (attributeCommand):
491         * Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: Added.
492         (writeFileWithContent):
493
494 2020-01-28  Brent Fulgham  <bfulgham@apple.com>
495
496         Reset the application bundle identifier between test runs
497         https://bugs.webkit.org/show_bug.cgi?id=206858
498         <rdar://problem/58844002>
499
500         Reviewed by Per Arne Vollan.
501
502         Clear the application bundle identifier set during testing when resetting the test system
503         to a known state in preparation for the next run.
504
505         * WebKitTestRunner/TestController.cpp:
506         (WTR::TestController::resetStateToConsistentValues): Clear any override for the application
507         bundle identifier before the next test invocation.
508         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
509         (WTR::TestController::setApplicationBundleIdentifier): Correct an over-release caused by assigning
510         an autorelease return value to an NSRetainPtr.
511         (WTR::TestController::clearApplicationBundleIdentifierTestingOverride): Added.
512
513 2020-01-28  Aakash Jain  <aakash_jain@apple.com>
514
515         EWS django app should send cq+ patches to commit-queue
516         https://bugs.webkit.org/show_bug.cgi?id=206534
517
518         Reviewed by Jonathan Bedard.
519
520         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
521         (Buildbot.send_patch_to_buildbot): Added support to send to commit queue.
522         * BuildSlaveSupport/ews-app/ews/config.py: Added COMMIT_QUEUE_PORT.
523         * BuildSlaveSupport/ews-app/ews/fetcher.py: Added support for sending patches to commit queue.
524         * BuildSlaveSupport/ews-app/ews/migrations/0003_patch_sent_to_commit_queue.py: Added.
525         * BuildSlaveSupport/ews-app/ews/models/patch.py:
526         (Patch): Added sent_to_commit_queue field in patch table.
527         (Patch.is_patch_sent_to_commit_queue): Method to check if patch is sent to commit queue.
528         (Patch.set_sent_to_commit_queue): Set sent_to_commit_queue field.
529
530 2020-01-28  Stephan Szabo  <stephan.szabo@sony.com>
531
532         Python 3: Update windows scripts and uses of is constant
533         https://bugs.webkit.org/show_bug.cgi?id=206856
534
535         Reviewed by Jonathan Bedard.
536
537         * Scripts/download-github-release.py: Update for python 3
538         * Scripts/webkitpy/common/system/profiler.py: Change is constant usage
539         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Change is constant usage
540         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Change is constant usage
541         * Scripts/webkitpy/port/westondriver.py: Change is constant usage
542         * Scripts/webkitpy/port/win.py: Update for python 3
543         * Scripts/webkitpy/port/xvfbdriver.py: Change is constant usage
544         * Scripts/webkitpy/xcode/device_type.py: Change is constant usage
545
546 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
547
548         run-webkit-tests: clobber-old-results should remove the entire results folder
549         https://bugs.webkit.org/show_bug.cgi?id=205875
550         <rdar://problem/58236117>
551
552         Reviewed by Alexey Proskuryakov.
553
554         * Scripts/webkitpy/layout_tests/controllers/manager.py:
555         (Manager.run): Boot http servers after the build check and after clobbering
556         old results.
557         (Manager._clobber_old_results): Remove entire results folder.
558         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
559         (RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
560         entire results directory.
561
562 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
563
564         [GTK] Add EWS testers to run GTK unit tests.
565         https://bugs.webkit.org/show_bug.cgi?id=202361
566
567         Reviewed by Aakash Jain.
568
569         This switches two of the GTK BuildOnly EWS bots to be BuildAndRunAPITests bots.
570         It doesn't make it a test-only bot because of concerns related with having to
571         upload and download much data constantly over the network. It reuses the same
572         logic for running Mac API tests, but simply using a different command at startup.
573
574         * BuildSlaveSupport/ews-build/config.json:
575         * BuildSlaveSupport/ews-build/factories.py:
576         (GTKBuildFactory):
577         (GTKBuildAndTestFactory):
578         (GTKBuildAndTestFactory.__init__):
579         (GTKAPIBuildAndTestFactory):
580         * BuildSlaveSupport/ews-build/loadConfig.py:
581         * BuildSlaveSupport/ews-build/steps.py:
582         (RunAPITests.start):
583         (ReRunAPITests.evaluateCommand):
584         * BuildSlaveSupport/ews-build/steps_unittest.py:
585
586 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
587
588         WPT test importer only rewrites the first URL on <style> tags.
589         https://bugs.webkit.org/show_bug.cgi?id=206842
590
591         Reviewed by Jonathan Bedard.
592
593         There was an issue, when a <style> tag had several URL() paths
594         to local references, only the first one was converted.
595         This was caused because the test parser was only seeing the
596         first one (re.search() only finds the first regex), instead use
597         re.findall() to find all the ocurrences.
598         Then in the test converter for relative paths, when there are
599         several paths to be converted, convert from the last conversion
600         instead of the original text.
601
602         * Scripts/webkitpy/w3c/test_converter.py:
603         (_W3CTestConverter.convert_reference_relpaths):
604         * Scripts/webkitpy/w3c/test_converter_unittest.py:
605         (test_convert_style_multiple_url):
606         * Scripts/webkitpy/w3c/test_parser.py:
607         (TestParser.support_files):
608         * Scripts/webkitpy/w3c/test_parser_unittest.py:
609
610 2020-01-28  Antoine Quint  <graouts@apple.com>
611
612         [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled
613         https://bugs.webkit.org/show_bug.cgi?id=206173
614         <rdar://problem/58527432>
615
616         Reviewed by Dean Jackson.
617
618         Manually enable the new WebAnimationsMutableTimelines runtime flag in DumpRenderTree.
619
620         * DumpRenderTree/mac/DumpRenderTree.mm:
621         (enableExperimentalFeatures):
622         * DumpRenderTree/win/DumpRenderTree.cpp:
623         (enableExperimentalFeatures):
624
625 2020-01-27  Aakash Jain  <aakash_jain@apple.com>
626
627         [ews] Add method to fetch cq+ patches from Bugzilla
628         https://bugs.webkit.org/show_bug.cgi?id=206774
629
630         Reviewed by Jonathan Bedard.
631
632         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
633         (Bugzilla._get_commit_queue_patches_from_bug): Method to get cq+ patches for a given bug.
634         (Bugzilla._is_patch_cq_plus): Method to check if patch has cq+ flag set.
635         (Bugzilla.get_list_of_patches_for_commit_queue): Method to fetch list of cq+ patches from Bugzilla.
636         (BugzillaBeautifulSoup.fetch_bug_ids_for_commit_queue):
637
638 2020-01-27  Noam Rosenthal  <noam@webkit.org>
639
640         Unreviewed. Adding myself back as a reviewer.
641
642         * Scripts/webkitpy/common/config/contributors.json:
643
644 2020-01-27  Keith Rollin  <krollin@apple.com>
645
646         Fix internal builds
647         https://bugs.webkit.org/show_bug.cgi?id=206790
648         <rdar://problem/58888951>
649
650         Reviewed by Maciej Stachowiak.
651
652         TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In
653         some circumstances, this file can include <os/thread_self_restrict.h>,
654         which in turn includes <machine/cpu_capabilities.h>. This latter file
655         does not exist at a standard location, and the build fails due to not
656         being able to find the file. Fix this by adding a path to it to the
657         build command line.
658
659         * DumpRenderTree/mac/Configurations/Base.xcconfig:
660
661 2020-01-27  Robin Morisset  <rmorisset@apple.com>
662
663         Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
664         https://bugs.webkit.org/show_bug.cgi?id=206833
665
666         Reviewed by Jonathan Bedard.
667
668         Just a trivial fix to the arguments validation code of the script.
669
670         * Scripts/set-webkit-configuration:
671
672 2020-01-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
673
674         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
675         https://bugs.webkit.org/show_bug.cgi?id=204713
676
677         Reviewed by Simon Fraser.
678
679         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
680         WTR. In some cases, the page may not get visually active while it's
681         waiting for rAF. Throttling tests will have to explicitly turn it on.
682
683         * DumpRenderTree/mac/DumpRenderTree.mm:
684         (resetWebPreferencesToConsistentValues):
685         * DumpRenderTree/win/DumpRenderTree.cpp:
686         (resetWebPreferencesToConsistentValues):
687         * WebKitTestRunner/TestController.cpp:
688         (WTR::TestController::resetPreferencesToConsistentValues):
689
690 2020-01-26  Aakash Jain  <aakash_jain@apple.com>
691
692         [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
693         https://bugs.webkit.org/show_bug.cgi?id=206807
694
695         Reviewed by Jonathan Bedard.
696
697         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
698
699 2020-01-27  Kate Cheney  <katherine_cheney@apple.com>
700
701         Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type
702         https://bugs.webkit.org/show_bug.cgi?id=206601
703         <rdar://problem/58696521>
704
705         Reviewed by Alex Christensen.
706
707         This patch caused some API tests to fail which relied on the ITP files
708         always existing. Now the tests ensure the respective file exists when 
709         switching between in-memory and database storage before running the tests.
710
711         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
712         (ensureITPFileIsCreated):
713         (TEST):
714
715 2020-01-27  Ryan Haddad  <ryanhaddad@apple.com>
716
717         Unreviewed, rolling out r255131.
718
719         Caused assertion failures on iOS debug bots.
720
721         Reverted changeset:
722
723         "Throttling requestAnimationFrame should be controlled by
724         RenderingUpdateScheduler"
725         https://bugs.webkit.org/show_bug.cgi?id=204713
726         https://trac.webkit.org/changeset/255131
727
728 2020-01-27  Jonathan Bedard  <jbedard@apple.com>
729
730         webkitpy: Replace StringIO.StringIO in statusserver.py
731         https://bugs.webkit.org/show_bug.cgi?id=206825
732
733         Reviewed by Aakash Jain.
734
735         * Scripts/webkitpy/common/net/statusserver.py:
736         (StatusServer._upload_attachment_to_server): The Python 3 compatible StringIO
737         object cannot be referenced as StringIO.StringIO
738
739 2020-01-26  Said Abou-Hallawa  <said@apple.com>
740
741         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
742         https://bugs.webkit.org/show_bug.cgi?id=204713
743
744         Reviewed by Simon Fraser.
745
746         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
747         WTR. In some cases, the page may not get visually active while it's
748         waiting for rAF. Throttling tests will have to explicitly turn it on.
749
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (resetWebPreferencesToConsistentValues):
752         * DumpRenderTree/win/DumpRenderTree.cpp:
753         (resetWebPreferencesToConsistentValues):
754         * WebKitTestRunner/TestController.cpp:
755         (WTR::TestController::resetPreferencesToConsistentValues):
756
757 2020-01-25  Mark Lam  <mark.lam@apple.com>
758
759         Add some tests for dynamically allocated StaticStringImpls.
760         https://bugs.webkit.org/show_bug.cgi?id=206802
761
762         Reviewed by Darin Adler.
763
764         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
765         (TestWebKitAPI::doStaticStringImplTests):
766         (TestWebKitAPI::TEST):
767
768 2020-01-25  Aakash Jain  <aakash_jain@apple.com>
769
770         webkit-patch upload should not submit automatically to old EWS
771         https://bugs.webkit.org/show_bug.cgi?id=206801
772
773         Reviewed by Alexey Proskuryakov.
774
775         * Scripts/webkitpy/tool/commands/upload_unittest.py:
776         * Scripts/webkitpy/tool/steps/submittoews.py:
777
778 2020-01-25  Per Arne Vollan  <pvollan@apple.com>
779
780         [Cocoa] Media mime types map should be created in the UI process
781         https://bugs.webkit.org/show_bug.cgi?id=206478
782
783         Reviewed by Darin Adler.
784
785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
786         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
787         (TEST):
788
789 2020-01-25  Antti Koivisto  <antti@apple.com>
790
791         [LFC][Integration] Re-enable line layout integration
792         https://bugs.webkit.org/show_bug.cgi?id=206795
793         <rdar://problem/58853907>
794
795         Reviewed by Zalan Bujtas.
796
797         * DumpRenderTree/TestOptions.h:
798
799 2020-01-25  Youenn Fablet  <youenn@apple.com>
800
801         HTMLMediaElement should not remove the media session at DOM suspension time
802         https://bugs.webkit.org/show_bug.cgi?id=206661
803         <rdar://problem/58800787>
804
805         Reviewed by Eric Carlson.
806
807         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
808         (TestWebKitAPI::TEST):
809         Suspend/resume Active DOM Objects from time to time as would do scrolling.
810         This allows pending tasks to be executed asynchronously when not scrolling.
811
812 2020-01-23  Matt Lewis  <jlewis3@apple.com>
813
814         Remove Apple windows 7 queues.
815         https://bugs.webkit.org/show_bug.cgi?id=206702
816
817         Reviewed by Jonathan Bedard.
818
819         * BuildSlaveSupport/build.webkit.org-config/config.json:
820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
823         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
824         Removed Windows 7 queues from config and from dashboard.
825
826 2020-01-24  Per Arne Vollan  <pvollan@apple.com>
827
828         Unreviewed, rolling out r255050.
829
830         Introduced crashes on bots
831
832         Reverted changeset:
833
834         "[Cocoa] Media mime types map should be created in the UI
835         process"
836         https://bugs.webkit.org/show_bug.cgi?id=206478
837         https://trac.webkit.org/changeset/255050
838
839 2020-01-24  Jonathan Bedard  <jbedard@apple.com>
840
841         run-webkit-tests: Handle case where device socket make handle invalid
842         https://bugs.webkit.org/show_bug.cgi?id=206707
843
844         Reviewed by Stephanie Lewis.
845
846         * Scripts/webkitpy/port/simulator_process.py:
847         (SimulatorProcess.NonBlockingFileFromSocket.close): Catch IOError when closing file.
848
849 2020-01-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
850
851         [GTK] API test runner fails with error: too many open files.
852         https://bugs.webkit.org/show_bug.cgi?id=206743
853
854         Reviewed by Carlos Garcia Campos.
855
856         The API test runner for google tests was leaking file descriptors because
857         it was not closing the file descriptor of the pseudo-terminal of the child,
858         which was referred in the parent because of the forkpty() call.
859         This was causing a small but constant increase of open file descriptors,
860         until the point it reached the limit of maximum open files (1024 usually)
861         causing this error.
862
863         Fix that by closing the reference to the fd of the child's pseudo-terminal.
864
865         * glib/api_test_runner.py:
866         (TestRunner._run_google_test):
867
868 2020-01-24  Zan Dobersek  <zdobersek@igalia.com>
869
870         Unreviewed WPE dependency bump.
871
872         * wpe/jhbuild.modules: Bump the libwpe checkout commit to include fixes
873         for configuration errors that can occur with older (but still supported)
874         CMake versions.
875
876 2020-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
877
878         Unreviewed GTK gardening. Mark /webkit/WebKitWebPage/get-uri as flaky
879
880         * TestWebKitAPI/glib/TestExpectations.json:
881
882 2020-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
883
884         [iOS] Support setting minimum effective device width during dynamic viewport size updates
885         https://bugs.webkit.org/show_bug.cgi?id=206709
886         <rdar://problem/58713872>
887
888         Reviewed by Tim Horton.
889
890         Adds a new API test that changes both the effective minimum device width and view size during animated resize.
891
892         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
893
894 2020-01-23  Per Arne Vollan  <pvollan@apple.com>
895
896         [Cocoa] Media mime types map should be created in the UI process
897         https://bugs.webkit.org/show_bug.cgi?id=206478
898
899         Reviewed by Darin Adler.
900
901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
902         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
903         (TEST):
904
905 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
906
907         WebKitTestRunner: use ad hoc signing for internal Production builds
908         https://bugs.webkit.org/show_bug.cgi?id=206607
909         <rdar://problem/56087327>
910
911         Reviewed by Jonathan Bedard.
912
913         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
914
915 2020-01-23  Tuomas Karkkainen  <tuomas.webkit@apple.com>
916
917         Add missing coverage.xcconfig
918         https://bugs.webkit.org/show_bug.cgi?id=206686
919
920         Reviewed by Mark Lam.
921
922         * coverage/coverage.xcconfig: Added.
923
924 2020-01-23  Per Arne Vollan  <pvollan@apple.com>
925
926         [Cocoa] Broker access to the PowerManagement API
927         https://bugs.webkit.org/show_bug.cgi?id=206373
928
929         Reviewed by Darin Adler.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/WebKit/Battery.mm: Added.
933         (TEST):
934
935 2020-01-23  Jonathan Bedard  <jbedard@apple.com>
936
937         Fix iOS 13.2 iphoneos build
938         https://bugs.webkit.org/show_bug.cgi?id=206618
939
940         Reviewed by Alexey Proskuryakov.
941
942         * Scripts/webkitdirs.pm:
943         (XcodeOptions): Relax provisioning profile rules on embedded SDKs.
944
945 2020-01-23  Takashi Komori  <Takashi.Komori@sony.com>
946
947         KeyedDecoderGeneric crashes when it accesses a data with empty string key.
948         https://bugs.webkit.org/show_bug.cgi?id=206572
949
950         Reviewed by Fujii Hironori.
951
952         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
953         (TestWebKitAPI::TEST):
954
955 2020-01-23  Tuomas Karkkainen  <tuomas.webkit@apple.com>
956
957         It should be possible to build JavaScriptCore with LLVM Source-based Code Coverage, run the tests and see the coverage data
958         https://bugs.webkit.org/show_bug.cgi?id=206389
959
960         Reviewed by Alexey Proskuryakov.
961
962         * Scripts/run-javascriptcore-tests:
963         * Scripts/set-webkit-configuration:
964         * Scripts/webkitdirs.pm:
965         * coverage/coverage.xcconfig: Added.
966
967 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
968
969         Unreviewed, rolling out r254955.
970
971         Broke internal builds
972
973         Reverted changeset:
974
975         "WebKitTestRunner: move code sign configurations from
976         WebKitTestRunner.xcconfig to DebugRelease.xcconfig"
977         https://bugs.webkit.org/show_bug.cgi?id=206607
978         https://trac.webkit.org/changeset/254955
979
980 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
981
982         WebKitTestRunner: move code sign configurations from WebKitTestRunner.xcconfig to DebugRelease.xcconfig
983         https://bugs.webkit.org/show_bug.cgi?id=206607
984         <rdar://problem/56087327>
985
986         Reviewed by Alexey Proskuryakov.
987
988         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
989
990 2020-01-22  Brady Eidson  <beidson@apple.com>
991
992         REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated
993         <rdar://problem/58544942> and https://bugs.webkit.org/show_bug.cgi?id=206608
994
995         Reviewed by Alex Christensen.
996
997         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
998         (TEST):
999
1000 2020-01-22  Jonathan Bedard  <jbedard@apple.com>
1001
1002         webkitpy: WebSocket server doesn't support Python 3 (Workaround)
1003         https://bugs.webkit.org/show_bug.cgi?id=206546
1004
1005         Reviewed by Alexey Proskuryakov.
1006
1007         websocket_server.py doesn't support Python 3, and needs to be run with
1008         Python 2.
1009
1010         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1011         (PyWebSocket._prepare_config): Use Python 2 explicitly.
1012
1013 2020-01-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1014
1015         [build-webkit] Add option for toggling unified build
1016         https://bugs.webkit.org/show_bug.cgi?id=206597
1017
1018         Reviewed by Adrian Perez de Castro.
1019
1020         Added command line option for build-webkit script to toggle unified build.
1021
1022         * Scripts/webkitperl/FeatureList.pm:
1023
1024 2020-01-22  Don Olmstead  <don.olmstead@sony.com>
1025
1026         Share InjectedBundleController::platformInitialize
1027         https://bugs.webkit.org/show_bug.cgi?id=206598
1028
1029         Reviewed by Konstantin Tokarev.
1030
1031         Add a stub for platformInitialize in InjectedBundleController.cpp which is
1032         used for non-Cocoa ports. Remove the platform specific stubs.
1033
1034         * TestWebKitAPI/InjectedBundleController.cpp:
1035         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1036         * TestWebKitAPI/PlatformGTK.cmake:
1037         * TestWebKitAPI/PlatformWPE.cmake:
1038         * TestWebKitAPI/PlatformWin.cmake:
1039         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp: Removed.
1040         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Removed.
1041         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Removed.
1042
1043 2020-01-22  Jonathan Bedard  <jbedard@apple.com>
1044
1045         webkitpy: Make logging during ImageDiff crashes accurate
1046         https://bugs.webkit.org/show_bug.cgi?id=206542
1047
1048         Reviewed by Aakash Jain.
1049
1050         When ImageDiff crashes, the generated logs are not accurate, they
1051         reference a crash in test output when the test will actually fail
1052         with an Image failure. The owner of a ServerProcess should be able
1053         to customize this error message.
1054
1055         * Scripts/webkitpy/port/image_diff.py:
1056         (ImageDiffer._start): Pass ImageDiff specific crash message.
1057         * Scripts/webkitpy/port/port_testcase.py:
1058         (PortTestCase.test_diff_image.make_proc): Match ImageDiff calcite.
1059         (PortTestCase.test_diff_image_passed): Ditto.
1060         (PortTestCase.test_diff_image_failed): Ditto.
1061         (PortTestCase.test_diff_image_crashed.make_proc): Ditto.
1062         * Scripts/webkitpy/port/server_process.py:
1063         (ServerProcess.__init__): Support a custom message when the process crashes.
1064         (ServerProcess.write): Ditto.
1065         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
1066         (ServerProcess.has_crashed): Ditto.
1067         * Scripts/webkitpy/port/server_process_mock.py:
1068         (MockServerProcess.__init__): Match the ServerProcess constructor.
1069         * Scripts/webkitpy/port/simulator_process.py:
1070         (SimulatorProcess.__init__): Support a custom message when the process crashes.
1071
1072 2020-01-21  Matt Lewis  <jlewis3@apple.com>
1073
1074         Test history links on the dashboard should go to the new results database
1075         https://bugs.webkit.org/show_bug.cgi?id=205821
1076
1077         Reviewed by Jonathan Bedard.
1078
1079         Made changes to the various locations that we use the old database in the main dashboard
1080         and test results pages.
1081         
1082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1083         (ui.urlForFlakinessDashboard):
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1085         (ui.results.FlakinessData.base._handleMessage):
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1087         (TestHistory):
1088         (TestHistory.prototype.historyPageURLForTest):
1089         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1090
1091 2020-01-22  Antti Koivisto  <antti@apple.com>
1092
1093         [LFC][Integration] Disable integration to see performance impact
1094         https://bugs.webkit.org/show_bug.cgi?id=206576
1095         <rdar://problem/58562185>
1096
1097         Reviewed by Zalan Bujtas.
1098
1099         * DumpRenderTree/TestOptions.h:
1100
1101 2020-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1102
1103         A partially selected RTL text is placed at a wrong vertical position if it has a vertical initial advance
1104         https://bugs.webkit.org/show_bug.cgi?id=205990
1105
1106         Reviewed by Darin Adler.
1107
1108         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1109         Replaced all "controller.totalWidth()" with "controller.totalAdvance().width()".
1110
1111 2020-01-21  Sihui Liu  <sihui_liu@apple.com>
1112
1113         REGRESSION (r254856?): [Win] http/tests/security/same-origin-websql-blocked.html and 2 fast/dom/Window/window-function-* tests failing
1114         https://bugs.webkit.org/show_bug.cgi?id=206552
1115
1116         Unreviewed fix after r254856. r254856 wanted to enable WebSQL on layout tests but enableWebSQL was set to false.
1117
1118         * DumpRenderTree/TestOptions.h:
1119
1120 2020-01-21  Jiewen Tan  <jiewen_tan@apple.com>
1121
1122         ProvisionalPageProxy::loadData should pass last navigation's shouldOpenExternalURLsPolicy flag to WebPageProxy
1123         https://bugs.webkit.org/show_bug.cgi?id=206462
1124         <rdar://problem/57468718>
1125
1126         Reviewed by Chris Dumez.
1127
1128         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1129         (TestWebKitAPI::TEST):
1130
1131 2020-01-21  Rob Buis  <rbuis@igalia.com>
1132
1133         Add build flag for stale-while-revalidate
1134         https://bugs.webkit.org/show_bug.cgi?id=204169
1135
1136         Reviewed by Youenn Fablet.
1137
1138         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1139
1140 2020-01-21  Yusuke Suzuki  <ysuzuki@apple.com>
1141
1142         [WTF] AtomStringTable should be small
1143         https://bugs.webkit.org/show_bug.cgi?id=206400
1144
1145         Reviewed by Sam Weinig.
1146
1147         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1148         (TestWebKitAPI::TEST):
1149         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1150         (TestWebKitAPI::TEST):
1151         * TestWebKitAPI/Tests/WTF/Packed.cpp:
1152         (TestWebKitAPI::TEST):
1153
1154 2020-01-21  Alex Christensen  <achristensen@webkit.org>
1155
1156         Add SPI on WKURLSchemeTask to access WKFrameInfo of originating frame
1157         https://bugs.webkit.org/show_bug.cgi?id=204265
1158         <rdar://57193883>
1159
1160         Reviewed by Brady Eidson.
1161
1162         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1163         (-[FrameSchemeHandler waitForAllRequests]):
1164         (-[FrameSchemeHandler setExpectedWebView:]):
1165         (-[FrameSchemeHandler webView:startURLSchemeTask:]):
1166         (-[FrameSchemeHandler webView:stopURLSchemeTask:]):
1167
1168 2020-01-21  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews] commit-queue should check cq+ flag
1171         https://bugs.webkit.org/show_bug.cgi?id=206530
1172
1173         Reviewed by Jonathan Bedard.
1174
1175         * BuildSlaveSupport/ews-build/steps.py:
1176         ValidatePatch._is_patch_cq_plus): Method to check cq+ flag on patch.
1177         (ValidatePatch.start):
1178         * BuildSlaveSupport/ews-build/factories.py:
1179         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-tests.
1180
1181 2020-01-21  Keith Rollin  <krollin@apple.com>
1182
1183         Fix tvOS values in SUPPORTED_PLATFORMS
1184         https://bugs.webkit.org/show_bug.cgi?id=206435
1185         <rdar://problem/58674587>
1186
1187         Reviewed by Alexey Proskuryakov.
1188
1189         A number of targets in WebKit have 'tvos' and 'tvsimulator' in
1190         SUPPORTED_PLATFORMS. The correct values are 'appletvos' and
1191         'appletvsimulator'. These should be updated to the correct ones as the
1192         wrong values prevent the tvOS run destination from being usable in the
1193         UI to build for tvOS.
1194
1195         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1196         * ImageDiff/cg/Configurations/Base.xcconfig:
1197         * MiniBrowser/Configurations/Base.xcconfig:
1198         * WebKitTestRunner/Configurations/Base.xcconfig:
1199
1200 2020-01-21  Sihui Liu  <sihui_liu@apple.com>
1201
1202         Disable WebSQL everywhere by default except in tests
1203         https://bugs.webkit.org/show_bug.cgi?id=204907
1204
1205         Reviewed by Ryosuke Niwa.
1206
1207         * DumpRenderTree/TestOptions.h:
1208         * DumpRenderTree/mac/DumpRenderTree.mm:
1209         (resetWebPreferencesToConsistentValues):
1210         * DumpRenderTree/win/DumpRenderTree.cpp:
1211         (setWebPreferencesForTestOptions):
1212
1213 2020-01-20  Aakash Jain  <aakash_jain@apple.com>
1214
1215         [ews] Add build and layout-test steps for commit-queue in new ews
1216         https://bugs.webkit.org/show_bug.cgi?id=206510
1217
1218         Reviewed by Jonathan Bedard.
1219
1220         * BuildSlaveSupport/ews-build/factories.py:
1221
1222 2020-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1223
1224         [GTK][WPE] Enable WebGL by default
1225         https://bugs.webkit.org/show_bug.cgi?id=205335
1226
1227         Reviewed by Adrian Perez de Castro.
1228
1229         Update the unit test.
1230
1231         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1232         (testWebKitSettings):
1233
1234 2020-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1235
1236         [GTK][WPE] Enable WebAudio by default
1237         https://bugs.webkit.org/show_bug.cgi?id=205334
1238
1239         Reviewed by Adrian Perez de Castro.
1240
1241         Update the unit test.
1242
1243         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1244         (testWebKitSettings):
1245
1246 2020-01-20  Sam Weinig  <weinig@apple.com>
1247
1248         Platform.h is out of control Part 8: Macros are used inconsistently
1249         https://bugs.webkit.org/show_bug.cgi?id=206425
1250
1251         Reviewed by Darin Adler.
1252
1253         * TestWebKitAPI/Tests/WTF/Packed.cpp:
1254         (TestWebKitAPI::TEST):
1255         Update to use OS_CONSTANT.
1256
1257 2020-01-20  Saam Barati  <sbarati@apple.com>
1258
1259         REGRESSION(r254788): mozilla-tests.yaml/js1_5/Regress/regress-191633.js.mozilla fails
1260         https://bugs.webkit.org/show_bug.cgi?id=206477
1261         <rdar://problem/58714886>
1262
1263         Unreviewed.
1264
1265         In r232603 when we added test specific options, the implementation did not
1266         clear the test specific options before parsing each test inside a yaml
1267         file. It only worked for tests where we ran each js file inside a directory.
1268         This patch makes it also work for yaml files.
1269
1270         * Scripts/run-jsc-stress-tests:
1271
1272 2020-01-20  David Kilzer  <ddkilzer@apple.com>
1273
1274         Fix missing header guards and clean up empty files in WebCore, WebKitLegacy, WebKit, Tools
1275         <https://webkit.org/b/206505>
1276
1277         Reviewed by Eric Carlson.
1278
1279         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1280         * TestWebKitAPI/JavaScriptTest.h:
1281         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1282         - Add #pragma once statement.
1283
1284 2020-01-20  David Kilzer  <ddkilzer@apple.com>
1285
1286         check-webkit-style: Improve header guard checks
1287         <https://webkit.org/b/206480>
1288
1289         Reviewed by Darin Adler.
1290
1291         * Scripts/webkitpy/style/checkers/cpp.py:
1292         (check_for_header_guard):
1293         - Add `file_path` (filename) argument to check for config.h and
1294           *Prefix.h headers.
1295         - Use hints in header file to determine if this is a header file
1296           only used by Objective-C or not.
1297         - Change #ifndef/#define check to use both lines instead of
1298           assuming a format for the macro.
1299         - Emit new 'build/header_guard_missing' error.
1300         (_process_lines):
1301         - Pass `filename` argument to check_for_header_guard().
1302         (CppChecker):
1303         - Enable new 'build/header_guard_missing' check.
1304
1305         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1306         (CppStyleTestBase.perform_header_guard_check):
1307         (CppStyleTestBase.assert_header_guard):
1308         - Move default `filename` argument from
1309           perform_header_guard_check() to assert_header_guard() so tests
1310           may pass in different values for header paths.
1311         (CppStyleTest):
1312         - Add tests for config.h, *Prefix.h headers.
1313         - Update test for `build/header_guard' (legacy header guard)
1314           error.
1315         - Update test for missing header guard so that it now expects a
1316           'build/header_guard_missing' error message.
1317         - Add tests for Objective-C headers with and without __OBJC__
1318           checks.
1319
1320 2020-01-20  Zan Dobersek  <zdobersek@igalia.com>
1321
1322         [WPE] Add WebKitRectangle, use it for WebKitWebView's SHOW_MENU signal
1323         https://bugs.webkit.org/show_bug.cgi?id=206495
1324
1325         Reviewed by Carlos Garcia Campos.
1326
1327         Update the TestOptionMenu test case for WPE now that a rectangle object
1328         is also passed through to the signal handler.
1329
1330         * TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:
1331         (OptionMenuTest::showOptionMenuCallback):
1332         (OptionMenuTest::showOptionMenu):
1333
1334 2020-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1335
1336         [GTK][WPE] Also include the selection index in webkit_input_method_context_notify_surrounding()
1337         https://bugs.webkit.org/show_bug.cgi?id=206497
1338
1339         Reviewed by Adrian Perez de Castro.
1340
1341         Add new test case to check the selection index when there's a selection.
1342
1343         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1344         (webkitInputMethodContextMockNotifySurrounding):
1345         (webkitInputMethodContextMockReset):
1346         (testWebKitInputMethodContextSurrounding):
1347
1348 2020-01-20  Zan Dobersek  <zdobersek@igalia.com>
1349
1350         [WPE] Expose the WebKitOptionMenu APIs
1351         https://bugs.webkit.org/show_bug.cgi?id=206287
1352
1353         Move TestOptionMenu under the WebKitGLib directory, adding the
1354         appropriate adjustments for the WPE variant of the API
1355
1356         * TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp.
1357         (OptionMenuTest::OptionMenuTest):
1358         (OptionMenuTest::~OptionMenuTest):
1359         (OptionMenuTest::destroyMenu):
1360         (OptionMenuTest::showOptionMenuCallback):
1361         (OptionMenuTest::menuCloseCallback):
1362         (OptionMenuTest::showOptionMenu):
1363         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1364         (OptionMenuTest::close):
1365         (OptionMenuTest::activateItem):
1366         (OptionMenuTest::selectItem):
1367         (testOptionMenuSimple):
1368         (testOptionMenuGroups):
1369         (testOptionMenuActivate):
1370         (testOptionMenuSelect):
1371         (beforeAll):
1372         (afterAll):
1373         * TestWebKitAPI/glib/CMakeLists.txt:
1374         * TestWebKitAPI/glib/PlatformGTK.cmake:
1375
1376 2020-01-20  Rob Buis  <rbuis@igalia.com>
1377
1378         Make isValidUserAgentHeaderValue GLib only
1379         https://bugs.webkit.org/show_bug.cgi?id=206475
1380
1381         Reviewed by Youenn Fablet.
1382
1383         Make the unit test that tests isValidUserAgentHeaderValue
1384         depend on USE(GLIB) as well.
1385
1386         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1387
1388 2020-01-20  Takashi Komori  <Takashi.Komori@sony.com>
1389
1390         KeyedDecoderGeneric crashes when it accesses data with non-existing key
1391         https://bugs.webkit.org/show_bug.cgi?id=205902
1392
1393         Reviewed by Fujii Hironori.
1394
1395         * TestWebKitAPI/CMakeLists.txt:
1396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1397         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp: Added.
1398         (TestWebKitAPI::checkDecodedBytes):
1399         (TestWebKitAPI::TEST):
1400         (TestWebKitAPI::testSimpleValue):
1401         (TestWebKitAPI::KeyedCodingTestObject::encode):
1402         (TestWebKitAPI::KeyedCodingTestObject::decode):
1403         (TestWebKitAPI::KeyedCodingTestObject::KeyedCodingTestObject):
1404         (TestWebKitAPI::KeyedCodingTestObject::equals const):
1405         (TestWebKitAPI::operator==):
1406
1407 2020-01-19  Zan Dobersek  <zdobersek@igalia.com>
1408
1409         [WPE] HeadlessViewBackend should hande SHM-based buffer exports
1410         https://bugs.webkit.org/show_bug.cgi?id=206283
1411
1412         Reviewed by Adrian Perez de Castro.
1413
1414         The ViewBackend class should also handle any SHM-based exports from
1415         the wpe_view_backend_exportable_fdo_egl instance. In case of such an
1416         export, the buffer is transported down into the implementing object.
1417
1418         For WindowViewBackend, we do nothing with this yet, except emit a
1419         warning. For HeadlessViewBackend, we repeat what's currently done with
1420         EGL exports, storing pending updates until the update timer is fired
1421         and we move the buffer into the locked position, clearing up any
1422         previous locked buffer.
1423
1424         Upon creating a snapshot of the current contents, we add additional
1425         separation in how EGL and SHM exports are handled. Nothing changes
1426         for the former, while for the latter we simply retrieve the
1427         wl_shm_buffer object, map it, copy data from it into the pixel data
1428         storage that's basis for the returned Cairo surface, and unmap it.
1429
1430         * Scripts/webkitpy/port/wpe.py:
1431         (WPEPort.setup_environ_for_server): Copy the LIBGL_ALWAYS_SOFTWARE
1432         environment variable, if present. This variable is normally used to
1433         force Mesa into software rasterizing mode.
1434         * wpe/backends/HeadlessViewBackend.cpp:
1435         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1436         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1437         (WPEToolingBackends::HeadlessViewBackend::createEGLSnapshot):
1438         (WPEToolingBackends::HeadlessViewBackend::createSHMSnapshot):
1439         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1440         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1441         * wpe/backends/HeadlessViewBackend.h:
1442         * wpe/backends/ViewBackend.cpp:
1443         (WPEToolingBackends::ViewBackend::initialize):
1444         * wpe/backends/ViewBackend.h:
1445         * wpe/backends/WindowViewBackend.cpp:
1446         * wpe/backends/WindowViewBackend.h:
1447
1448 2020-01-17  Cathie Chen  <cathiechen@igalia.com>
1449
1450         Add support for scroll behavior parsing
1451         https://bugs.webkit.org/show_bug.cgi?id=205009
1452
1453         Reviewed by Frédéric Wang.
1454
1455         Based on the patch by Frédéric Wang.
1456
1457         * DumpRenderTree/TestOptions.cpp:
1458         (TestOptions::TestOptions): Parse CSSOMViewSmoothScrollingEnabled.
1459         * DumpRenderTree/TestOptions.h: Add CSSOMViewSmoothScrollingEnabled, disabled by default.
1460         * DumpRenderTree/mac/DumpRenderTree.mm:
1461         (enableExperimentalFeatures):
1462         (setWebPreferencesForTestOptions): Set CSSOMViewSmoothScrollingEnabled from the test options.
1463
1464 2020-01-16  Simon Fraser  <simon.fraser@apple.com>
1465
1466         fast/forms/ios/zoom-after-input-tap-wide-input.html is timing out
1467         https://bugs.webkit.org/show_bug.cgi?id=206313
1468
1469         Reviewed by Wenson Hsieh.
1470         
1471         The timeout was caused by the previous test, fast/forms/ios/validation-bubble-dismiss-on-tap.html, 
1472         which puts up a validation bubble whose implementation involves showing a modal UIViewController.
1473         That view controller disappears with an animation, which happened after we're proceeded to the next
1474         test, and the overlay view could intercept touches thus breaking any subsequent touch-based test.
1475
1476         Fix by having platformResetStateToConsistentValues() wait for the presentedViewController to
1477         go to nil, which requires spinning the runloop.
1478
1479         platformResetStateToConsistentValues() will return false if we fail to remove the presented view controller,
1480         which will trigger a timeout with a log.
1481
1482         * WebKitTestRunner/TestController.cpp:
1483         (WTR::TestController::resetStateToConsistentValues):
1484         (WTR::TestController::platformResetStateToConsistentValues):
1485         * WebKitTestRunner/TestController.h:
1486         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1487         (WTR::TestController::cocoaResetStateToConsistentValues):
1488         * WebKitTestRunner/ios/TestControllerIOS.mm:
1489         (WTR::TestController::platformResetStateToConsistentValues):
1490         * WebKitTestRunner/mac/TestControllerMac.mm:
1491         (WTR::TestController::platformResetStateToConsistentValues):
1492
1493 2020-01-17  Aakash Jain  <aakash_jain@apple.com>
1494
1495         [EWS] Print disk space usage for windows bots
1496         https://bugs.webkit.org/show_bug.cgi?id=206421
1497
1498         Reviewed by Jonathan Bedard.
1499
1500         * BuildSlaveSupport/ews-build/steps.py:
1501         (PrintConfiguration): Windows bot use cygwin, so df command works.
1502
1503 2020-01-17  Aakash Jain  <aakash_jain@apple.com>
1504
1505         [ews] Perform validation of patch before running layout-tests on Windows
1506         https://bugs.webkit.org/show_bug.cgi?id=206424
1507
1508         Reviewed by Jonathan Bedard.
1509
1510         * BuildSlaveSupport/ews-build/factories.py:
1511
1512 2020-01-17  Megan Gardner  <megan_gardner@apple.com>
1513
1514         Fix assertion when test fast/events/ios/rotation/basic-rotation.html is followed by fast/events/ios/rotation/do-not-shrink-to-fit-content-after-rotation.html
1515         https://bugs.webkit.org/show_bug.cgi?id=206383
1516         <rdar://problem/58618513>
1517
1518         Reviewed by Tim Horton.
1519
1520         Rotation tests are asserting because _didEndRotation is being called multiple times.
1521         The call is at the end of viewWillTransitionToSize, which is called with the same
1522         size that the view already is. Therefore, if no size is changing, early out,
1523         which keeps this double call from happening.
1524
1525         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1526         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
1527
1528 2020-01-17  Jonathan Bedard  <jbedard@apple.com>
1529
1530         Python 3: Add support to run-webkit-tests (Follow-up fix)
1531         https://bugs.webkit.org/show_bug.cgi?id=205291
1532
1533         Unreviewed follow-up fix.
1534
1535         * Scripts/webkitpy/common/unicode_compatibility.py:
1536         (decode_for): Handle case where provided value is None.
1537
1538 2020-01-17  Brady Eidson  <beidson@apple.com>
1539
1540         TestWebKitAPI.AsyncFunction.Promise times out on slower machines in debug builds.
1541         <rdar://problem/58445164> and https://bugs.webkit.org/show_bug.cgi?id=206012
1542
1543         Reviewed by Keith Miller.
1544
1545         Previously, to force GC, over 30,000 function calls would be made.
1546         This was too slow on slower machines in debug builds. It eventually would've worked given enough time, but...
1547         It turns just a few hundred function calls with an API call to force GC seems reliable and is much faster.
1548         
1549         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1550         (TestWebKitAPI::TEST):
1551         (TestWebKitAPI::tryGCPromise): Deleted.
1552
1553 2020-01-16  Keith Miller  <keith_miller@apple.com>
1554
1555         Reland bytecode checkpoints since bugs have been fixed
1556         https://bugs.webkit.org/show_bug.cgi?id=206361
1557
1558         Unreviewed, reland.
1559
1560         The watch bugs have been fixed by https://trac.webkit.org/changeset/254674
1561
1562         * Scripts/run-jsc-stress-tests:
1563
1564 2020-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1565
1566         Unreviewed, rolling out r254678.
1567
1568         API tests failures for Mac port
1569
1570         Reverted changeset:
1571
1572         "KeyedDecoderGeneric crashes when it accesses data with non-
1573         existing key"
1574         https://bugs.webkit.org/show_bug.cgi?id=205902
1575         https://trac.webkit.org/changeset/254678
1576
1577 2020-01-16  Chris Dumez  <cdumez@apple.com>
1578
1579         Regression(r253224) No longer able to prevent a tab from closing via the beforeunload prompt
1580         https://bugs.webkit.org/show_bug.cgi?id=206366
1581         <rdar://problem/58537467>
1582
1583         Reviewed by Geoffrey Garen.
1584
1585         tryClose_timeout_fix
1586
1587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588         * TestWebKitAPI/Tests/WebKit/beforeunload.html: Added.
1589         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
1590         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1591         (-[SlowBeforeUnloadPromptUIDelegate webViewDidClose:]):
1592         (TEST):
1593
1594 2020-01-16  Jiewen Tan  <jiewen_tan@apple.com>
1595
1596         [WebAuthn] User Verification (UV) option present on a CTAP2 authenticatorMakeCredential while the authenticator has not advertised support for it
1597         https://bugs.webkit.org/show_bug.cgi?id=204111
1598         <rdar://problem/57019604>
1599
1600         Reviewed by Brent Fulgham.
1601
1602         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1603         (TestWebKitAPI::TEST):
1604         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1605
1606 2020-01-16  Yusuke Suzuki  <ysuzuki@apple.com>
1607
1608         [bmalloc] IsoHeap's initial setup should be small
1609         https://bugs.webkit.org/show_bug.cgi?id=206214
1610
1611         Reviewed by Michael Saboff.
1612
1613         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1614         (assertHasObjects):
1615         (assertHasOnlyObjects):
1616         (assertClean):
1617         (TEST):
1618
1619 2020-01-16  Brady Eidson  <beidson@apple.com>
1620
1621         Make the callAsyncJavaScriptFunction function actually be async (so await works).
1622         <rdar://problem/58571682> and https://bugs.webkit.org/show_bug.cgi?id=206364
1623
1624         Reviewed by Geoffrey Garen.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1627         (TestWebKitAPI::TEST):
1628
1629 2020-01-16  Philippe Normand  <philn@igalia.com>
1630
1631         [GStreamer][WPE] Client-side video rendering support
1632         https://bugs.webkit.org/show_bug.cgi?id=206289
1633
1634         Reviewed by Xabier Rodriguez-Calvar.
1635
1636         * wpe/jhbuild.modules: Bump to libwpe and wpebackend-fdo git
1637         snapshots, until 1.5.x releases are published.
1638
1639 2020-01-16  Takashi Komori  <Takashi.Komori@sony.com>
1640
1641         KeyedDecoderGeneric crashes when it accesses data with non-existing key
1642         https://bugs.webkit.org/show_bug.cgi?id=205902
1643
1644         Reviewed by Fujii Hironori.
1645
1646         * TestWebKitAPI/CMakeLists.txt:
1647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1648         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp: Added.
1649         (TestWebKitAPI::checkDecodedBytes):
1650         (TestWebKitAPI::TEST):
1651         (TestWebKitAPI::testSimpleValue):
1652         (TestWebKitAPI::KeyedCodingTestObject::encode):
1653         (TestWebKitAPI::KeyedCodingTestObject::decode):
1654         (TestWebKitAPI::KeyedCodingTestObject::KeyedCodingTestObject):
1655         (TestWebKitAPI::KeyedCodingTestObject::equals const):
1656         (TestWebKitAPI::operator==):
1657
1658 2020-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1659
1660         [GTK][WPE] Password field doesn't get input method
1661         https://bugs.webkit.org/show_bug.cgi?id=34285
1662
1663         Reviewed by Žan Doberšek.
1664
1665         Enable the test case for password field.
1666
1667         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1668         (testWebKitInputMethodContextContentType):
1669
1670 2020-01-16  Cathie Chen  <cathiechen@igalia.com>
1671
1672         Mapping HTML attributes width/height to the default aspect ratio of <img>
1673         https://bugs.webkit.org/show_bug.cgi?id=201641
1674
1675         Reviewed by Frédéric Wang
1676
1677         Add experimental flag: AspectRatioOfImgFromWidthAndHeightEnabled.
1678
1679         (enableExperimentalFeatures):
1680         (setWebPreferencesForTestOptions):
1681         * DumpRenderTree/win/DumpRenderTree.cpp:
1682         (enableExperimentalFeatures):
1683
1684 2020-01-15  Brady Eidson  <beidson@apple.com>
1685
1686         Add WKContentWorld SPI, and use it in JavaScript execution.
1687         https://bugs.webkit.org/show_bug.cgi?id=206310
1688
1689         Reviewed by Alex Christensen.
1690         
1691         Update previous callAsyncFunction calls with the new signature.
1692         Add tests for new _WKContentWorld class and its behavior with regard to executing JavaScript.
1693
1694         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1695         (TestWebKitAPI::tryGCPromise):
1696         (TestWebKitAPI::TEST):
1697         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1698         (TEST):
1699         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1700         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
1701
1702 2020-01-15  Jonathan Bedard  <jbedard@apple.com>
1703
1704         run-api-tests no longer supports wildcards in test names
1705         https://bugs.webkit.org/show_bug.cgi?id=206319
1706         <rdar://problem/58351608>
1707
1708         Reviewed by Chris Dumez.
1709
1710         * Scripts/webkitpy/api_tests/manager.py:
1711         (Manager._find_test_subset):
1712
1713 2020-01-17  Simon Fraser  <simon.fraser@apple.com>
1714
1715         Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
1716         https://bugs.webkit.org/show_bug.cgi?id=206441
1717         rdar://problem/56714139
1718
1719         Reviewed by Wenson Hsieh.
1720
1721         The way that HIDEventGenerator sends all the generated events in a blocking loop seems to
1722         trigger an issue where the events, when received by the scroll view gesture recognizers,
1723         don't actually trigger a scroll.
1724
1725         Attempt to fix by creating an event stream in UIScriptControllerIOS::dragFromPointToPoint,
1726         and dispatching via -[HIDEventGenerator sendEventStream:completionBlock:]. This spawns a
1727         thread to dispatch the events, which will hopefully be closer to user behavior and more
1728         reliably trigger the gesture recognizer.
1729
1730         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1731         (WTR::dictionaryForFingerEventWithContentPoint):
1732         (WTR::UIScriptControllerIOS::dragFromPointToPoint):
1733
1734 2020-01-15  David Kilzer  <ddkilzer@apple.com>
1735
1736         Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
1737         <https://webkit.org/b/206269>
1738         <rdar://problem/58589158>
1739
1740         Reviewed by Brent Fulgham.
1741
1742         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1743         (WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
1744         * DumpRenderTree/mac/UIDelegate.mm:
1745         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1746         Initialize `imageRef` stack variable to `nullptr`.
1747         * WebKitTestRunner/Configurations/Base.xcconfig:
1748         (WARNING_CFLAGS): Add -Wconditional-uninitialized switch.
1749
1750 2020-01-15  Keith Miller  <keith_miller@apple.com>
1751
1752         Revert bytecode checkpoints since it breaks watch
1753         https://bugs.webkit.org/show_bug.cgi?id=206301
1754
1755         Unreviewed, revert.
1756
1757 2020-01-15  Jonathan Bedard  <jbedard@apple.com>
1758
1759         webkitpy: Remove self assignments
1760         https://bugs.webkit.org/show_bug.cgi?id=206294
1761
1762         Reviewed by Aakash Jain.
1763
1764         * Scripts/webkitpy/common/webkit_finder.py:
1765         (WebKitFinder.webkit_base):
1766         * Scripts/webkitpy/port/factory.py:
1767         (_builder_options):
1768
1769 2020-01-15  Alicia Boya García  <aboya@igalia.com>
1770
1771         [WTF] Remove MediaTime.cpp test warning in GCC
1772         https://bugs.webkit.org/show_bug.cgi?id=206238
1773
1774         Reviewed by Xabier Rodriguez-Calvar.
1775
1776         GCC emits warnings when it finds clang pragmas, so I'm wrapping them
1777         in #if COMPILER(CLANG) to reduce the noise.
1778
1779         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1780
1781 2020-01-14  Commit Queue  <commit-queue@webkit.org>
1782
1783         Unreviewed, rolling out r254480, r254496, and r254517.
1784         https://bugs.webkit.org/show_bug.cgi?id=206278
1785
1786         "It regressed JetStream2 and Speedometer2" (Requested by
1787         saamyjoon on #webkit).
1788
1789         Reverted changesets:
1790
1791         "Throw away baseline code if there is an optimized
1792         replacement"
1793         https://bugs.webkit.org/show_bug.cgi?id=202503
1794         https://trac.webkit.org/changeset/254480
1795
1796         "Unreviewed. Change useLLInt=0 to forceBaseline=1"
1797         https://trac.webkit.org/changeset/254496
1798
1799         "Add an option that enables/disables throwing away baseline
1800         JIT code"
1801         https://bugs.webkit.org/show_bug.cgi?id=206244
1802         https://trac.webkit.org/changeset/254517
1803
1804 2020-01-14  Chris Dumez  <cdumez@apple.com>
1805
1806         document.cookie should not do a sync IPC to the network process for iframes that do not have storage access
1807         https://bugs.webkit.org/show_bug.cgi?id=206108
1808
1809         Reviewed by Geoff Garen and John Wilander.
1810
1811         Make setStatisticsShouldBlockThirdPartyCookies IPC from the WebProcess to the UIProcess asynchronous
1812         since this ends up sending an IPC back to the WebProcess now (which would deadlock).
1813
1814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1815         (WTR::TestRunner::setStatisticsShouldBlockThirdPartyCookies):
1816         * WebKitTestRunner/TestInvocation.cpp:
1817         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1818         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1819
1820 2020-01-10  Jiewen Tan  <jiewen_tan@apple.com>
1821
1822         [WebAuthn] Implement SPI to tell UI clients to select assertion responses
1823         https://bugs.webkit.org/show_bug.cgi?id=206112
1824         <rdar://problem/58495733>
1825
1826         Reviewed by Alex Christensen.
1827
1828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1829         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1830         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponses:completionHandler:]):
1831         (TestWebKitAPI::TEST):
1832         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html: Added.
1833         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html:
1834
1835 2020-01-14  Luming Yin  <luming_yin@apple.com>
1836
1837         Update API availability for autoplay event
1838         https://bugs.webkit.org/show_bug.cgi?id=202214
1839         <rdar://problem/55710395>
1840
1841         Reviewed by Tim Horton.
1842
1843         * TestWebKitAPI/Tests/WebKit/js-play-with-controls.html:
1844         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html:
1845         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html:
1846         Provide an id for each play button on various testing pages so that they can be triggered on iOS.
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1849         (-[AutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
1850         (-[AsyncAutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
1851         (TEST):
1852         Enable tests related to autoplay policy on iOS.
1853
1854         * TestWebKitAPI/cocoa/TestWKWebView.h:
1855         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1856         (-[TestWKWebView clickOnElementID:]):
1857         Helper method that performs a click on a given element ID.
1858
1859 2020-01-14  Jonathan Bedard  <jbedard@apple.com>
1860
1861         EWS: Run webkitpy tests with Python 2 and 3
1862         https://bugs.webkit.org/show_bug.cgi?id=206113
1863
1864         Reviewed by Aakash Jain.
1865
1866         * BuildSlaveSupport/ews-build/factories.py:
1867         (WebKitPyFactory.__init__): Run webkitpy tests in Python 2 and Python 3.
1868         * BuildSlaveSupport/ews-build/factories_unittest.py:
1869         (TestTestsFactory.test_webkitpy_factory):
1870         * BuildSlaveSupport/ews-build/steps.py:
1871         (WebKitPyTest): Renamed from RunWebKitPyTests.
1872         (RunWebKitPyPython2Tests):
1873         (RunWebKitPyPython3Tests):
1874         (RunWebKitPyTests): Renamed to WebKitPyTest.
1875         * BuildSlaveSupport/ews-build/steps_unittest.py:
1876         (TestWebKitPyPython2Tests): Moved from TestWebKitPyTests.
1877         (TestWebKitPyTests): Moved to TestWebKitPyPython2Tests.
1878         (TestWebKitPyPython3Tests): Copied from TestWebKitPyPython2Tests.
1879
1880 2020-01-14  Aakash Jain  <aakash_jain@apple.com>
1881
1882         [EWS] Status bubble tooltip might display success message sometimes on a failed build
1883         https://bugs.webkit.org/show_bug.cgi?id=206180
1884
1885         Reviewed by Jonathan Bedard.
1886
1887         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1888         (StatusBubble._build_bubble):
1889         (StatusBubble._most_recent_failure_message): Returns the status from failed step instead of last step.
1890
1891 2020-01-14  Jonathan Bedard  <jbedard@apple.com>
1892
1893         test-webkitpy: Make json file creation Python 3 compatible
1894         https://bugs.webkit.org/show_bug.cgi?id=206255
1895
1896         Reviewed by Aakash Jain.
1897
1898         * Scripts/webkitpy/test/main.py:
1899         (_print_results_as_json): Convert maps to lists.
1900
1901 2020-01-14  Commit Queue  <commit-queue@webkit.org>
1902
1903         Unreviewed, rolling out r254533 and r254535.
1904         https://bugs.webkit.org/show_bug.cgi?id=206263
1905
1906         Breaks iOS and macOS builds (Requested by ryanhaddad on
1907         #webkit).
1908
1909         Reverted changesets:
1910
1911         "[WebAuthn] Implement SPI to tell UI clients to select
1912         assertion responses"
1913         https://bugs.webkit.org/show_bug.cgi?id=206112
1914         https://trac.webkit.org/changeset/254533
1915
1916         "Unreviewed, a build fix after r254533"
1917         https://trac.webkit.org/changeset/254535
1918
1919 2020-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1920
1921         [iOS] Keyboard input is severely delayed after switching away from unresponsive tab
1922         https://bugs.webkit.org/show_bug.cgi?id=206242
1923         <rdar://problem/57132891>
1924
1925         Reviewed by Tim Horton.
1926
1927         Add a couple of new API tests: (1) verify that the key event completion handler can still be invoked in an
1928         unresponsive web view after resigning first responder, and (2) verify that we'll try to wait for the current
1929         key event to be processed in a web view, if it remains the first responder.
1930
1931         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1932
1933 2020-01-10  Jiewen Tan  <jiewen_tan@apple.com>
1934
1935         [WebAuthn] Implement SPI to tell UI clients to select assertion responses
1936         https://bugs.webkit.org/show_bug.cgi?id=206112
1937         <rdar://problem/58495733>
1938
1939         Reviewed by Alex Christensen.
1940
1941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1942         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1943         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponses:completionHandler:]):
1944         (TestWebKitAPI::TEST):
1945         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html: Added.
1946         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html:
1947
1948 2020-01-14  Jonathan Bedard  <jbedard@apple.com>
1949
1950         webkitpy: Pass ImageDiff commands in a single write
1951         https://bugs.webkit.org/show_bug.cgi?id=206194
1952         <rdar://problem/58578775>
1953
1954         Reviewed by Stephanie Lewis.
1955
1956         ImageDiff can encounter race conditions if it is fed content in multiple writes,
1957         instead of in a single block.
1958
1959         * Scripts/webkitpy/port/image_diff.py:
1960         (ImageDiffer.diff_image): Pass ImageDiff data in a single write command.
1961         * Scripts/webkitpy/port/port_testcase.py:
1962         (PortTestCase.test_diff_image__missing_both): diff_image only accepts byte arrays.
1963         (PortTestCase.test_diff_image__missing_actual): Ditto.
1964         (PortTestCase.test_diff_image__missing_expected): Ditto.
1965         (PortTestCase.test_diff_image): Ditto.
1966         (PortTestCase.test_diff_image_passed): Ditto.
1967         (PortTestCase.test_diff_image_failed): Ditto.
1968         (PortTestCase.test_diff_image_crashed): Ditto.
1969
1970 2020-01-14  Antti Koivisto  <antti@apple.com>
1971
1972         [LFC][Integration] Support the feature flag in DumpRenderTree
1973         https://bugs.webkit.org/show_bug.cgi?id=206218
1974
1975         Reviewed by Zalan Bujtas.
1976
1977         This allows tests to turn off the feature in WK1 if needed.
1978
1979         * DumpRenderTree/TestOptions.cpp:
1980         (TestOptions::TestOptions):
1981         * DumpRenderTree/TestOptions.h:
1982         * DumpRenderTree/mac/DumpRenderTree.mm:
1983         (setWebPreferencesForTestOptions):
1984
1985 2020-01-14  Alicia Boya García  <aboya@igalia.com>
1986
1987         [WTF] Make MediaTime constructor constexpr
1988         https://bugs.webkit.org/show_bug.cgi?id=206036
1989
1990         Reviewed by Adrian Perez de Castro.
1991
1992         Added test for global static MediaTime constants.
1993
1994         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1995         (TestWebKitAPI::TEST):
1996
1997 2020-01-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1998
1999         Unreviewed sort-Xcode-project-file
2000
2001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2002
2003 2020-01-13  Saam Barati  <sbarati@apple.com>
2004
2005         Throw away baseline code if there is an optimized replacement
2006         https://bugs.webkit.org/show_bug.cgi?id=202503
2007
2008         Reviewed by Yusuke Suzuki.
2009
2010         * Scripts/run-jsc-stress-tests:
2011
2012 2020-01-13  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
2013
2014         Fix path-specific filters on Windows
2015         https://bugs.webkit.org/show_bug.cgi?id=205786
2016
2017         Reviewed by David Kilzer.
2018
2019         * Scripts/webkitpy/style/filter.py:
2020         (FilterConfiguration._path_rules_from_path):
2021         Convert forward slashes to backward slashes on Windows by using
2022         os.path.normcase(). Nothing changed on other OSs.
2023         * Scripts/webkitpy/style/filter_unittest.py:
2024         (FilterConfigurationTest.test_path_with_different_case):
2025
2026 2020-01-13  David Kilzer  <ddkilzer@apple.com>
2027
2028         WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert
2029         <https://webkit.org/b/206105>
2030
2031         Reviewed by Brent Fulgham.
2032
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::TestController::decidePolicyForPluginLoad): Change
2035         RELEASE_ASSERT_NOT_REACHED() to
2036         RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE() with bundle
2037         identifier.
2038
2039 2020-01-13  Aakash Jain  <aakash_jain@apple.com>
2040
2041         [EWS] Add unit tests for factories
2042         https://bugs.webkit.org/show_bug.cgi?id=206159
2043
2044         Reviewed by Jonathan Bedard.
2045
2046         * BuildSlaveSupport/ews-build/factories_unittest.py: Added unit tests for factories.
2047
2048 2020-01-13  Eric Carlson  <eric.carlson@apple.com>
2049
2050         Don't softlink AVCapture classes on watchOS or tvOS
2051         https://bugs.webkit.org/show_bug.cgi?id=205974
2052         <rdar://problem/58427281>
2053
2054         Unreviewed test fix after r254257.
2055
2056         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2057         (TestWebKitAPI::TEST):
2058
2059 2020-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2060
2061         [WebAuthn] Support CTAP Client Pin
2062         https://bugs.webkit.org/show_bug.cgi?id=191516
2063         <rdar://problem/56558558>
2064
2065         Reviewed by Brent Fulgham.
2066
2067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2068         * TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp:
2069         (TestWebKitAPI::TEST):
2070         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2071         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2072         (-[TestWebAuthenticationPanelDelegate panel:requestPINWithRemainingRetries:completionHandler:]):
2073         (TestWebKitAPI::TEST):
2074         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin.html: Added.
2075         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-key-agreement-error.html: Added.
2076         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html: Added.
2077         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-retries-error.html: Added.
2078         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin.html: Added.
2079
2080 2020-01-11  Alex Christensen  <achristensen@webkit.org>
2081
2082         Expose frame information on _WKResourceLoadInfo
2083         https://bugs.webkit.org/show_bug.cgi?id=206104
2084         <rdar://problem/57132290>
2085
2086         Reviewed by Dean Jackson.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2089         (TEST):
2090
2091 2020-01-11  Kate Cheney  <katherine_cheney@apple.com>
2092
2093         Add correct grandfathering functionality to the ITP database backend
2094         https://bugs.webkit.org/show_bug.cgi?id=205844
2095         <rdar://problem/58360450>
2096
2097         Reviewed by John Wilander.
2098
2099         In order to test both the ITP database and memory stores, this patch
2100         had to restructure the grandfathering API tests.
2101
2102         If the test is for the database backend (ends in *Database), it will
2103         check if the default store matches. If so, it continues on with the
2104         normal test. If not, it has to use an API call to reconstruct the
2105         new store and ensure the grandfathering still happens. Vice versa for
2106         the memory store tests.
2107
2108         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2109         (isITPDatabaseEnabled):
2110         (TEST):
2111
2112 2020-01-10  Myles C. Maxfield  <mmaxfield@apple.com>
2113
2114         REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
2115         https://bugs.webkit.org/show_bug.cgi?id=200043
2116
2117         Reviewed by Dean Jackson.
2118
2119         Migrate system language tests to LayoutTests, to match the rest of our system language tests.
2120
2121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2122         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Removed.
2123
2124 2020-01-10  Jer Noble  <jer.noble@apple.com>
2125
2126         [iOS] Audio from non-frontmost tab continues when app is backgrounded
2127         https://bugs.webkit.org/show_bug.cgi?id=206101
2128         <rdar://problem/58089916>
2129
2130         Reviewed by Eric Carlson.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm: Added.
2134         (TestWebKitAPI::autoplayingConfiguration):
2135         (TestWebKitAPI::TEST):
2136
2137 2020-01-10  Jonathan Bedard  <jbedard@apple.com>
2138
2139         Python3: Support Source/WebKit/Scripts/webkit
2140         https://bugs.webkit.org/show_bug.cgi?id=206078
2141
2142         Reviewed by Stephanie Lewis.
2143
2144         * Scripts/test-webkitpy-python3: Call test-webkitpy with Python 3 since
2145         everything is now compatible.
2146
2147 2020-01-10  Jonathan Bedard  <jbedard@apple.com>
2148
2149         webkit-patch crashes when creating new bug with Python 3
2150         https://bugs.webkit.org/show_bug.cgi?id=205911
2151
2152         Reviewed by Stephanie Lewis.
2153
2154         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2155         (BugzillaQueries.is_invalid_bugzilla_email): Decode page before applying regex.
2156         (Bugzilla.authenticate): Decode group before printing.
2157         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Ensure HTML response
2158         Is a string before applying the regex.
2159         (Bugzilla._check_create_bug_response): Ditto.
2160         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Attachment ID should be a string,
2161         not a byte array.
2162
2163 2020-01-10  Alex Christensen  <achristensen@webkit.org>
2164
2165         Fix test assertions after r254345
2166         https://bugs.webkit.org/show_bug.cgi?id=206037
2167
2168         There were two assertions being hit in the new tests:
2169         1. Beacon sends POST requests, so the HTTP server that receives them needs to be able to handle POST requests.
2170         2. There was an assertion in the destructor of NetworkResourceLoader because we were destroying a WKWebView during a sync xhr.
2171         This isn't a problem in practice, but we may as well wait for the sync xhr to finish before completing the test so we can
2172         keep the sync xhr assertion, which is useful to prevent hangs.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2175         (-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2176         (TEST):
2177         * TestWebKitAPI/cocoa/HTTPServer.mm:
2178         (TestWebKitAPI::HTTPServer::respondToRequests):
2179
2180 2020-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2181
2182         [GTK][WPE] EWS should not wipe the JHBuild in the unapply patch step
2183         https://bugs.webkit.org/show_bug.cgi?id=206061
2184
2185         Reviewed by Aakash Jain.
2186
2187         The current unapply patch step on the EWS calls the script clean-webkit, which wipes everything.
2188         Rebuilding the JHBuild takes around 30 minutes, even with ccache.
2189         And its not needed to wipe the JHBuild directories on the clean-webkit step, because the WebKit
2190         tooling for building the JHBuild (update-webkitgtk-libs) already detects when the moduleset has
2191         been modified and wipes it when necessary.
2192
2193         This patch adds the optional argument --keep-jhbuild-directory to the script clean-webkit,
2194         that the EWS will pass when doing the unapply patch step for platform GTK or WPE.
2195
2196         * BuildSlaveSupport/ews-build/steps.py:
2197         (CleanWorkingDirectory.start):
2198         * Scripts/clean-webkit:
2199         (main):
2200         * Scripts/webkitpy/common/checkout/scm/scm.py:
2201         (SCM.discard_untracked_files):
2202         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2203
2204 2020-01-10  Alex Christensen  <achristensen@webkit.org>
2205
2206         Build fix for builds without libwebrtc's BoringSSL.
2207         https://bugs.webkit.org/show_bug.cgi?id=206037
2208
2209         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2210
2211 2020-01-10  Jiewen Tan  <jiewen_tan@apple.com>
2212
2213         [WebAuthn] Support authenticatorGetNextAssertion
2214         https://bugs.webkit.org/show_bug.cgi?id=203346
2215         <rdar://problem/56558488>
2216
2217         Reviewed by Brent Fulgham.
2218
2219         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2220         (TestWebKitAPI::TEST):
2221         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2222         Adds new test case for new logic in DeviceResponseConverter.
2223
2224 2020-01-10  Jonathan Bedard  <jbedard@apple.com>
2225
2226         Python 3: Add support to run-webkit-tests (Follow-up fix)
2227         https://bugs.webkit.org/show_bug.cgi?id=205291
2228
2229         Unreviewed follow-up fix.
2230
2231         * Scripts/webkitpy/port/port_testcase.py:
2232         (PortTestCase.test_diff_image): Diff output is byte array, not string.
2233         (PortTestCase.test_diff_image_failed): Ditto.
2234         (PortTestCase.test_diff_image_crashed): Ditto.
2235
2236 2020-01-10  Alex Christensen  <achristensen@webkit.org>
2237
2238         Expand _WKResourceLoadDelegate callbacks
2239         https://bugs.webkit.org/show_bug.cgi?id=206037
2240
2241         Reviewed by Youenn Fablet.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2244         (-[TestResourceLoadDelegate webView:resourceLoad:didSendRequest:]):
2245         (-[TestResourceLoadDelegate webView:resourceLoad:didPerformHTTPRedirection:newRequest:]):
2246         (-[TestResourceLoadDelegate webView:resourceLoad:didReceiveChallenge:]):
2247         (-[TestResourceLoadDelegate webView:resourceLoad:didReceiveResponse:]):
2248         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]):
2249         (TEST):
2250         (-[TestResourceLoadDelegate webView:willSendRequest:]): Deleted.
2251         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2252         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2253         (TEST):
2254         * TestWebKitAPI/cocoa/HTTPServer.h:
2255         (TestWebKitAPI::HTTPServer::HTTPResponse::HTTPResponse):
2256         Add the ability to have non-200 status codes in responses.
2257         Also switch the order of parameters to reflect the fact that header fields are sent before the body.
2258         * TestWebKitAPI/cocoa/HTTPServer.mm:
2259         (TestWebKitAPI::statusText):
2260         (TestWebKitAPI::HTTPServer::respondToRequests):
2261
2262 2020-01-10  Alex Christensen  <achristensen@webkit.org>
2263
2264         Add SPI to enable TLS 1.0 and 1.1 in WKWebViews
2265         https://bugs.webkit.org/show_bug.cgi?id=206046
2266
2267         Reviewed by Youenn Fablet.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2270         (TestWebKitAPI::TEST):
2271
2272 2020-01-10  Alex Christensen  <achristensen@webkit.org>
2273
2274         Remove WebsiteDataStore::setCacheStorageDirectory which has been replaced by WebsiteDataStoreConfiguration::setCacheStorageDirectory
2275         https://bugs.webkit.org/show_bug.cgi?id=205841
2276
2277         Reviewed by Youenn Fablet.
2278
2279         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2280         * WebKitTestRunner/TestController.cpp:
2281         (WTR::TestController::websiteDataStore):
2282         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2283         (WTR::initializeWebViewConfiguration):
2284
2285 2020-01-10  youenn fablet  <youenn@apple.com>
2286
2287         [WTR] Use short heart beat timer as a TestOption
2288         https://bugs.webkit.org/show_bug.cgi?id=205795
2289
2290         Reviewed by Chris Dumez.
2291
2292         Using short service worker heartbeat timeout values creates flakiness on slow bots.
2293         By default, use regular service worker heartbeat timeout values for layout tests.
2294         Add a WTR option value to use short service worker timeout values.
2295         Use this option for service worker spinning layout tests.
2296
2297         * WebKitTestRunner/TestController.cpp:
2298         (WTR::TestController::resetPreferencesToConsistentValues):
2299         (WTR::updateTestOptionsFromTestHeader):
2300         * WebKitTestRunner/TestOptions.h:
2301         (WTR::TestOptions::hasSameInitializationOptions const):
2302
2303 2020-01-10  Jonathan Bedard  <jbedard@apple.com>
2304
2305         Python 3: Add support to run-webkit-tests
2306         https://bugs.webkit.org/show_bug.cgi?id=205291
2307
2308         Reviewed by Stephanie Lewis.
2309
2310         * Scripts/test-webkitpy-python3: Add webkitpy.layout_tests.
2311         * Scripts/webkitpy/common/message_pool.py:
2312         (_MessagePool._loop): Move exception inside of loop.
2313         (_Message.__repr__): Use .format strings.
2314         (_Worker.__init__): Ditto.
2315         * Scripts/webkitpy/common/wavediff.py:
2316         (WaveDiff.__init__): Use Python 3 compatible BytesIO and StringIO.
2317         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2318         (LayoutTestFinder._read_test_names_from_file): Use .format string.
2319         (LayoutTestFinder.split_into_chunks): Explicitly use integer division.
2320         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2321         (Manager._get_test_inputs): Use range over xrange.
2322         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2323         (SingleTestRunner._handle_error): Use .format strings.
2324         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2325         (JSONLayoutResultsGenerator._insert_failure_summaries): Use Python 3 compatible itervalues.
2326         * Scripts/webkitpy/layout_tests/models/test_results.py:
2327         (TestResult.__init__): Sort type list.
2328         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2329         (RunTest.setUp): Multiple processes are buggy in test-webkitpy.
2330         (RunTest.test_basic): replace buflist with getvalue().
2331         (RunTest.test_child_processes_2): Ditto.
2332         (RunTest.test_child_processes_min): Ditto.
2333         (RunTest.test_keyboard_interrupt): Ditto.
2334         (RunTest.test_missing_and_unexpected_results): Compare dictionaries instead of json strings.
2335         (RunTest.test_crash_with_stderr): Ditto.
2336         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist): Ditto.
2337         (EndToEndTest.test_reftest_with_two_notrefs): Ditto.
2338         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2339         (MeteredStream.write): Flush stream after writing.
2340         (MeteredStream._erase_last_partial_line): Ditto.
2341         * Scripts/webkitpy/layout_tests/views/printing.py:
2342         (Printer._print_directory_timings): Can't compare string to integer.
2343         (Printer._print_statistics_for_test_timings): Use integer division.
2344         * Scripts/webkitpy/port/darwin.py:
2345         (DarwinPort._merge_crash_logs): Use items over iteritems.
2346         * Scripts/webkitpy/port/device.py:
2347         (Device.__hash__): Allow hashing of devices.
2348         * Scripts/webkitpy/port/device_port.py:
2349         (DevicePort._install): Use range over xrange.
2350         (DevicePort.setup_test_run): Ditto.
2351         (DevicePort.clean_up_test_run): Ditto.
2352         * Scripts/webkitpy/port/driver.py:
2353         (DriverOutput.__init__): Text should be decoded, audio encoded.
2354         (Driver.__init__):
2355         (Driver.run_test):
2356         (Driver._parse_child_processes_output): Output is byte array.
2357         (Driver._check_for_driver_timeout): Ditto.
2358         (Driver._check_for_address_sanitizer_violation): Error lines are byte arrays.
2359         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2360         (Driver._read_optional_image_block): If a block is base64 encoded, we want the decoded
2361         content, otherwise, we want the encoded content.
2362         (Driver._read_header): Lines are byte arrays, decode them before processing.
2363         (Driver._process_stdout_line): Blocks are byte arrays.
2364         (Driver._strip_eof): Lines should be byte arrays, not strings.
2365         (Driver._read_block): Standardize encoding in blocks.
2366         (ContentBlock.__init__): Content should be a byte array.
2367         (ContentBlock.decode_content): Attempt to decode content.
2368         * Scripts/webkitpy/port/driver_unittest.py:
2369         (DriverTest.test_read_binary_block): Content should be encoded.
2370         (DriverTest.test_read_base64_block): Ditto.
2371         (DriverTest.test_check_for_driver_crash): ServerProcess output should be a byte array.
2372         * Scripts/webkitpy/port/image_diff.py:
2373         (ImageDiffer.diff_image): ImageDiff output is in byte arrays.
2374         (ImageDiffer._read): Ditto.
2375         * Scripts/webkitpy/port/server_process.py:
2376         (ServerProcess.write): Encode data before writing it.
2377         * Scripts/webkitpy/port/server_process_mock.py:
2378         (MockServerProcess.__init__): Convert string mock output to bytes.
2379         (MockServerProcess.read_stdout_line): Stdout lines are byte arrays.
2380         (MockServerProcess.read_stdout): Ditto.
2381         * Scripts/webkitpy/port/simulator_process.py:
2382         (SimulatorProcess.NonBlockingFileFromSocket.close): Don't double close socket in Python 3.
2383         (SimulatorProcess._start): Stdin should be a binary stream.
2384         * Scripts/webkitpy/port/test.py:
2385         (unit_test_list): Convert audio streams to byte arrays.
2386         * Scripts/webkitpy/xcode/simulated_device.py:
2387         (SimulatedDevice.is_usable): Decode xcrun output.
2388         (SimulatedDevice.install_app): Use xrange over range.
2389
2390 2020-01-10  Adrian Perez de Castro  <aperez@igalia.com>
2391
2392         [Flatpak] Update IceCC to version 1.2
2393         https://bugs.webkit.org/show_bug.cgi?id=206059
2394
2395         Reviewed by Philippe Normand.
2396
2397         Update IceCC/Icecream to version 1.2, which is the same version
2398         currently shipped with Debian stable (Buster). This bump is needed
2399         because IceCC 1.1 does not seem to interoperate with the scheduler
2400         from newer versions and it is expected that people who run IceCC will
2401         install IceCC in their build farm from distribution packages.
2402
2403         * flatpak/org.webkit.CommonModules.yaml: Bump IceCC version to 1.2,
2404         add the Git commit-id for the release tag.
2405
2406 2020-01-10  Charlie Turner  <mail@charles.plus>
2407
2408         [EME][ClearKey] Refactor CDMClearKey::update()
2409         https://bugs.webkit.org/show_bug.cgi?id=205999
2410
2411         Reviewed by Xabier Rodriguez-Calvar.
2412
2413         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2414         (TestWebKitAPI::TEST_F): Added a test for the new toHexString
2415         helper. It should make sure to zero pad each byte to two
2416         characters, so that it's easy to read.
2417
2418 2020-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2419
2420         [GLIB] Add GLib specific API for JSC JSValueRef.h's JSValueMakeFromJSONString and JSValueCreateJSONString methods
2421         https://bugs.webkit.org/show_bug.cgi?id=205161
2422
2423         Reviewed by Adrian Perez de Castro.
2424
2425         Add tests for new API.
2426
2427         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2428         (testJSCJSON):
2429         (main):
2430
2431 2020-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2432
2433         Move macOS Test262, JSC, and perf queues to Catalina
2434         https://bugs.webkit.org/show_bug.cgi?id=205971
2435
2436         Unreviewed.
2437
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2439         (WebKitBuildbot): Update queue names on dashboard to match new naming scheme (dashes instead of spaces)
2440
2441 2020-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2442
2443         [Win] Use ComplexTextController instead of UniscribeController
2444         https://bugs.webkit.org/show_bug.cgi?id=204884
2445
2446         Reviewed by Brent Fulgham.
2447
2448         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Enabled these tests for PLATFORM(WIN).
2449
2450 2020-01-09  David Kilzer  <ddkilzer@apple.com>
2451
2452         TestController::platformLibraryPathForTesting() returns inner pointer to autoreleased NSString
2453         <https://webkit.org/b/206018>
2454         <rdar://problem/58449733>
2455
2456         Reviewed by Darin Adler.
2457
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::TestController::initialize):
2460         - Use WTF::AutodrainedPool to fix remaining autoreleasePool
2461           leaks.
2462         * WebKitTestRunner/ios/TestControllerIOS.mm:
2463         (WTR::TestController::platformLibraryPathForTesting):
2464         * WebKitTestRunner/mac/TestControllerMac.mm:
2465         (WTR::TestController::platformLibraryPathForTesting):
2466         - Retain NSString since these methods return an inner pointer.
2467           This also only needs to be initialized once.
2468
2469 2020-01-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2470
2471         Text manipulation controller should not observe changes in new replacement elements
2472         https://bugs.webkit.org/show_bug.cgi?id=206015
2473         <rdar://problem/58353667>
2474
2475         Reviewed by Tim Horton.
2476
2477         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2478
2479         Add a new API test to verify that we don't fire text manipulation item callbacks due to inserting elements when
2480         completing text manipulation.
2481
2482         (-[TextManipulationDelegate initWithItemCallback]): Deleted.
2483
2484         Remove a stray initializer that was unused (and also doesn't take an ItemCallback, as its name might suggest).
2485
2486 2020-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2487
2488         Move macOS Test262, JSC, and perf queues to Catalina
2489         https://bugs.webkit.org/show_bug.cgi?id=205971
2490
2491         Unreviewed infrastructure fix.
2492
2493         * BuildSlaveSupport/build.webkit.org-config/config.json: Add missing scheduler for perf queue.
2494
2495 2020-01-09  John Wilander  <wilander@apple.com>
2496
2497         Resource Load Statistics: Add timing information to WebPageProxy::logFrameNavigation() to detect delayed client-side redirects
2498         https://bugs.webkit.org/show_bug.cgi?id=205522
2499         <rdar://problem/58125759>
2500
2501         Reviewed by Chris Dumez.
2502
2503         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2504         (WTR::initializeWebViewConfiguration):
2505             Removed dead code.
2506
2507 2020-01-09  Paulo Matos  <pmatos@igalia.com>
2508
2509         Race condition in run-jsc-stress-tests chdir
2510         https://bugs.webkit.org/show_bug.cgi?id=205910
2511
2512         Reviewed by Keith Miller.
2513
2514         chdir block was in a race condition when multiple remotes are used.
2515         As an example of this see line 3345 of:
2516           https://ews-build.webkit.org/#/builders/26/builds/5719/steps/12/logs/stdio
2517
2518         quote error:
2519         Tools/Scripts/run-jsc-stress-tests:1946: warning: conflicting chdir during another chdir block
2520
2521         Multiple threads should not enter a chdir block simultaneously, therefore we need
2522         a mutex to guard it. More information is here:
2523           https://bugs.ruby-lang.org/issues/15661
2524
2525         * Scripts/run-jsc-stress-tests:
2526
2527 2020-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2528
2529         Move commit queue to Mojave
2530         https://bugs.webkit.org/show_bug.cgi?id=205972
2531
2532         Reviewed by Alexey Proskuryakov.
2533
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2535         (BubbleQueueServer):
2536
2537 2020-01-08  Ryan Haddad  <ryanhaddad@apple.com>
2538
2539         Move macOS Test262, JSC, and perf queues to Catalina
2540         https://bugs.webkit.org/show_bug.cgi?id=205971
2541
2542         Reviewed by Alexey Proskuryakov.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/config.json:
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2546         (WebKitBuildbot):
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2548         (table.queue-grid tr.platform.macos-highsierra img.logo): Deleted.
2549         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2550
2551 2020-01-09  David Kilzer  <ddkilzer@apple.com>
2552
2553         WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
2554         <https://webkit.org/b/205950>
2555         <rdar://problem/50987831>
2556
2557         Reviewed by Joseph Pecoraro.
2558
2559         * WebKitTestRunner/ios/mainIOS.mm:
2560         (main):
2561         - Add an @autoreleasepool block around a line of code
2562           that generates autoreleased objects.  These objects
2563           would never be released for the life of the process
2564           prior to this change.
2565         * WebKitTestRunner/mac/main.mm:
2566         (main):
2567         - Move instantiation of WTR::TestController outside of
2568           @autoreleasepool block so the pool can be drained
2569           while running tests.  Prior to this change, this
2570           autoreleasePool would never be drained.
2571
2572 2020-01-08  Saam Barati  <sbarati@apple.com>
2573
2574         build-jsc should work with "testing" and "release+assert" targets
2575         https://bugs.webkit.org/show_bug.cgi?id=205978
2576
2577         Reviewed by Mark Lam.
2578
2579         * Scripts/webkitdirs.pm:
2580         (determineConfiguration):
2581         (determinePassedConfiguration):
2582
2583 2020-01-08  Saam Barati  <sbarati@apple.com>
2584
2585         build-jsc should invoke make instead of calling xcodebuild directly
2586         https://bugs.webkit.org/show_bug.cgi?id=205960
2587
2588         Reviewed by Keith Miller.
2589
2590         This makes build-jsc invoke make instead of directly invoking xcodebuild.
2591         There are some benefits here:
2592         - 'make' is a more standard way to build than build-jsc, so as we make
2593         improvements to the make build (e.g r254234), we'll get the same improvements
2594         in build-jsc.
2595         
2596         - There has been a longstanding bug where if you did if you did
2597         `build-jsc --release && cd Source/JavaScriptCore && make release`
2598         then the `make release` call would rebuild all of JavaScriptCore.
2599         If build-jsc directly invokes make, this issue goes away and allows
2600         the two to interoperate as expected.
2601
2602         * Scripts/build-jsc:
2603         (buildMyProject):
2604
2605 2020-01-08  Commit Queue  <commit-queue@webkit.org>
2606
2607         Unreviewed, rolling out r254235.
2608         https://bugs.webkit.org/show_bug.cgi?id=205981
2609
2610         Broke layout tests (Requested by aakashja_ on #webkit).
2611
2612         Reverted changeset:
2613
2614         "run-webkit-tests: clobber-old-results should remove the
2615         entire results folder"
2616         https://bugs.webkit.org/show_bug.cgi?id=205875
2617         https://trac.webkit.org/changeset/254235
2618
2619 2020-01-08  Aakash Jain  <aakash_jain@apple.com>
2620
2621         [ews] Perform validation of patch before retrying CompileWebKit on ToT
2622         https://bugs.webkit.org/show_bug.cgi?id=205953
2623         <rdar://problem/58064430>
2624
2625         Reviewed by Jonathan Bedard.
2626
2627         * BuildSlaveSupport/ews-build/steps.py:
2628         (CompileWebKit.evaluateCommand):
2629
2630 2020-01-08  Jonathan Bedard  <jbedard@apple.com>
2631
2632         run-webkit-tests: clobber-old-results should remove the entire results folder
2633         https://bugs.webkit.org/show_bug.cgi?id=205875
2634         <rdar://problem/58236117>
2635
2636         Reviewed by Alexey Proskuryakov.
2637
2638         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2639         (Manager._clobber_old_results): Remove entire results folder.
2640         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2641         (RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
2642         entire results directory.
2643
2644 2020-01-08  Mark Lam  <mark.lam@apple.com>
2645
2646         Rename testing build configuration to release+assert, and add new testing build configuration.
2647         https://bugs.webkit.org/show_bug.cgi?id=205954
2648
2649         Reviewed by Yusuke Suzuki.
2650
2651         Added a --force-opt shortcut for the --force-optimization-level option of
2652         set-webkit-configuration.  This makes it less painful to type this on the command
2653         line for those of us who would like to use this option often in our local builds.
2654
2655         * Makefile:
2656         * Scripts/set-webkit-configuration:
2657
2658 2020-01-08  Matt Lewis  <jlewis3@apple.com>
2659
2660         Move EWS from macOS High Sierra to macOS Mojave
2661         https://bugs.webkit.org/show_bug.cgi?id=205948
2662         
2663         Reviewed by Aakash Jain.
2664
2665         * BuildSlaveSupport/ews-build/config.json:
2666
2667 2020-01-08  Brady Eidson  <beidson@apple.com>
2668
2669         Make _callAsyncFunction:withArguments: work with promises.
2670         https://bugs.webkit.org/show_bug.cgi?id=205654
2671
2672         Reviewed by Saam Barati.
2673
2674         Test that:
2675         - Resolve results in success handler being called
2676         - Reject results in error handler being called
2677         - Both resolve and reject becoming unreachable results in the error handler being called
2678         - Both native Promise objects and arbitrary thenables work
2679         - Any object where "then" is callable - even if not a function - works
2680         
2681         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2682         (TestWebKitAPI::tryGCPromise):
2683         (TestWebKitAPI::TEST): 
2684
2685 2020-01-08  Daniel Bates  <dabates@apple.com>
2686
2687         Regression r254160: 6 API test failures
2688         https://bugs.webkit.org/show_bug.cgi?id=205935
2689         <rdar://problem/58411559>
2690
2691         Revert API test changes in r254160. I mistakenly thought this were legitimate changes,
2692         but they were actually the result of a bug I have since corrected in r254167.
2693
2694         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2695         (TEST):
2696         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2697         (TestWebKitAPI::TEST):
2698         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
2699         (TEST):
2700
2701 2020-01-08  Keith Miller  <keith_miller@apple.com>
2702
2703         Fix testing Makefile to inherit preprocessor definitions
2704         https://bugs.webkit.org/show_bug.cgi?id=205940
2705
2706         Reviewed by Mark Lam.
2707
2708         * Makefile:
2709
2710 2020-01-08  Paulo Matos  <pmatos@igalia.com>
2711
2712         Allow multiple cmakeargs inside inside envvar
2713         https://bugs.webkit.org/show_bug.cgi?id=205722
2714
2715         Reviewed by Carlos Alberto Lopez Perez.
2716
2717         Allow sub-argument lists to be passed in a build environment variable.
2718
2719         * Scripts/build-jsc:
2720         * Scripts/build-webkit:
2721
2722 2020-01-07  Saam Barati  <sbarati@apple.com>
2723
2724         run-jsc should not print "... I should not be here ..." when it doesn't get killed when sending a signal to itself
2725         https://bugs.webkit.org/show_bug.cgi?id=205907
2726
2727         Reviewed by Ross Kirsling.
2728
2729         In r253024, I added code that would try to make run-jsc exit with the same
2730         signal that the actual jsc binary exitted with. This made it so crashes and
2731         in the `jsc` process would look like equivalent crashes in `run-jsc` process.
2732         Not thinking of non terminating signals, I added code like this:
2733         ```
2734         system("kill -" . $signal . " " . $PID);
2735         print STDERR "\n... I should not be here ...\n";
2736         ```
2737         
2738         However, this print will happen for totally legitimate reasons, like when
2739         you Ctrl+C from the REPL when  using `run-jsc`. This patch removes this print.
2740
2741         * Scripts/run-jsc:
2742
2743 2020-01-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2744
2745         Implement css3-images image-orientation
2746         https://bugs.webkit.org/show_bug.cgi?id=89052
2747
2748         Reviewed by Simon Fraser.
2749
2750         Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.
2751
2752         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2753
2754 2020-01-07  Alex Christensen  <achristensen@webkit.org>
2755
2756         Introduce _WKResourceLoadDelegate
2757         https://bugs.webkit.org/show_bug.cgi?id=205887
2758
2759         Reviewed by Dean Jackson.
2760
2761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2762         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm: Added.
2763         (-[TestResourceLoadDelegate webView:willSendRequest:]):
2764         (TEST):
2765
2766 2020-01-07  Keith Miller  <keith_miller@apple.com>
2767
2768         Add a testing target to make that is release + assertions
2769         https://bugs.webkit.org/show_bug.cgi?id=205895
2770
2771         Reviewed by Mark Lam.
2772
2773         * Makefile:
2774
2775 2020-01-07  Kate Cheney  <katherine_cheney@apple.com>
2776
2777         Create a mechanism for 'safe by default' web views
2778         https://bugs.webkit.org/show_bug.cgi?id=205407
2779         <rdar://problem/58053071>
2780
2781         Reviewed by Alex Christensen.
2782
2783         Test the default WebView category is correct and that the setter works
2784         properly.
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2787         (TEST):
2788
2789 2020-01-07  Truitt Savell  <tsavell@apple.com>
2790
2791         Unreviewed, rolling out r254165.
2792
2793         Caused 500+ missing results on Mac
2794
2795         Reverted changeset:
2796
2797         "run-webkit-tests: clobber-old-results should remove the
2798         entire results folder"
2799         https://bugs.webkit.org/show_bug.cgi?id=205875
2800         https://trac.webkit.org/changeset/254165
2801
2802 2020-01-07  Jonathan Bedard  <jbedard@apple.com>
2803
2804         run-webkit-tests: clobber-old-results should remove the entire results folder
2805         https://bugs.webkit.org/show_bug.cgi?id=205875
2806         <rdar://problem/58236117>
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2811         (Manager._clobber_old_results): Remove entire results folder.
2812         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2813         (RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
2814         entire results directory.
2815
2816 2020-01-07  Aakash Jain  <aakash_jain@apple.com>
2817
2818         [EWS] Limit pre-existing JSC tests failures to display in buildbot summary
2819         https://bugs.webkit.org/show_bug.cgi?id=205878
2820
2821         Reviewed by Jonathan Bedard.
2822
2823         * BuildSlaveSupport/ews-build/steps.py:
2824         (AnalyzeJSCTestsResults.start): Limit the number of failures to display.
2825
2826 2020-01-07  Daniel Bates  <dabates@apple.com>
2827
2828         First character in each word-wrapped line has incorrect character rect when requested range spans multiple lines
2829         https://bugs.webkit.org/show_bug.cgi?id=205842
2830         <rdar://problem/56884325>
2831
2832         Reviewed by Zalan Bujtas.
2833
2834         Add a new test.
2835
2836         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2837         (TEST):
2838
2839 2020-01-07  Ryan Haddad  <ryanhaddad@apple.com>
2840
2841         Unreviewed, rolling out r254144.
2842
2843         Broke the iOS build.
2844
2845         Reverted changeset:
2846
2847         "First character in each word-wrapped line has incorrect
2848         character rect when requested range spans multiple lines"
2849         https://bugs.webkit.org/show_bug.cgi?id=205842
2850         https://trac.webkit.org/changeset/254144
2851
2852 2020-01-07  Jonathan Bedard  <jbedard@apple.com>
2853
2854         results.webkit.org: Handle case where processing data is undefined
2855         https://bugs.webkit.org/show_bug.cgi?id=205870
2856
2857         Rubber-stamped by Aakash Jain.
2858
2859         * resultsdbpy/resultsdbpy/model/upload_context.py:
2860         (UploadContext._do_job_for_key): If the job content is undefined, mark the job as
2861         finished.
2862
2863 2020-01-07  Daniel Bates  <dabates@apple.com>
2864
2865         First character in each word-wrapped line has incorrect character rect when requested range spans multiple lines
2866         https://bugs.webkit.org/show_bug.cgi?id=205842
2867         <rdar://problem/56884325>
2868
2869         Reviewed by Zalan Bujtas.
2870
2871         Add a new test.
2872
2873         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2874         (TEST):
2875
2876 2020-01-07  Basuke Suzuki  <basuke.suzuki@sony.com>
2877
2878         check-webkit-style: bmalloc doesn't use config.h
2879         https://bugs.webkit.org/show_bug.cgi?id=205840
2880
2881         Reviewed by Jonathan Bedard.
2882
2883         * Scripts/webkitpy/style/checkers/cpp.py:
2884         (_IncludeState.check_next_include_order):
2885         (check_include_line):
2886         (check_has_config_header):
2887
2888 2020-01-07  youenn fablet  <youenn@apple.com>
2889
2890         Add an option to make video capture in GPUProcess
2891         https://bugs.webkit.org/show_bug.cgi?id=205853
2892
2893         Reviewed by Eric Carlson.
2894
2895         * WebKitTestRunner/TestController.cpp:
2896         (WTR::TestController::resetPreferencesToConsistentValues):
2897         (WTR::updateTestOptionsFromTestHeader):
2898         * WebKitTestRunner/TestOptions.h:
2899         (WTR::TestOptions::hasSameInitializationOptions const):
2900
2901 2020-01-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2902
2903         [GTK][WPE] Add API to retrieve and delete surrounding text for input methods
2904         https://bugs.webkit.org/show_bug.cgi?id=205716
2905
2906         Reviewed by Žan Doberšek.
2907
2908         Add new test case for the new API.
2909
2910         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
2911         (webkitInputMethodContextMockFinalize):
2912         (webkitInputMethodContextMockNotifySurrounding):
2913         (webkitInputMethodContextMockReset):
2914         (webkit_input_method_context_mock_class_init):
2915         (testWebKitInputMethodContextSurrounding):
2916         (beforeAll):
2917
2918 2020-01-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2919
2920         [GTK][WPE] Add API to set purpose and hints of active editable element to input methods
2921         https://bugs.webkit.org/show_bug.cgi?id=205605
2922
2923         Reviewed by Žan Doberšek.
2924
2925         Add new test case to check the purpose and hints API.
2926
2927         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
2928         (testWebKitInputMethodContextContentType):
2929         (beforeAll):
2930
2931 2020-01-06  Jonathan Bedard  <jbedard@apple.com>
2932
2933         results.webkit.org: Tweak processing constants
2934         https://bugs.webkit.org/show_bug.cgi?id=205828
2935         <rdar://problem/58146698>
2936
2937         Rubber-stamped by Aakash Jain.
2938
2939         * resultsdbpy/resultsdbpy/model/upload_context.py:
2940         (UploadContext):
2941         Increase process timeout to 1 week.
2942         Allow 5 retries instead of 3.
2943         Retry stuck tasks after 10 minutes instead of 5.
2944         Include more tasks so that a scan is always greater than the number of workers.
2945
2946 2020-01-06  Jonathan Bedard  <jbedard@apple.com>
2947
2948         test-lldb-webkit: Use logging module
2949         https://bugs.webkit.org/show_bug.cgi?id=205832
2950
2951         Reviewed by Stephanie Lewis.
2952
2953         * Scripts/test-lldb-webkit:
2954         (LldbTester.run): Configure logger.
2955
2956 2020-01-06  Daniel Bates  <dabates@apple.com>
2957
2958         Precision of getClientRects(), getBoundingClientRect() differs depending whether simple line layout or line box layout is used
2959         https://bugs.webkit.org/show_bug.cgi?id=205563
2960         <rdar://problem/58165528>
2961
2962         Reviewed by Zalan Bujtas.
2963
2964         Update test results.
2965
2966         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2967         (TEST):
2968         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2969         (TestWebKitAPI::TEST):
2970         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
2971         (TEST):
2972
2973 2020-01-06  youenn fablet  <youenn@apple.com>
2974
2975         XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
2976         https://bugs.webkit.org/show_bug.cgi?id=205685
2977
2978         Reviewed by Alex Christensen.
2979
2980         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2981
2982 2020-01-06  Alex Christensen  <achristensen@webkit.org>
2983
2984         Remove WebsiteDataStore::setServiceWorkerRegistrationDirectory
2985         https://bugs.webkit.org/show_bug.cgi?id=205754
2986
2987         Reviewed by Youenn Fablet.
2988
2989         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2990         * WebKitTestRunner/TestController.cpp:
2991         (WTR::TestController::websiteDataStore):
2992         (WTR::TestController::platformAdjustContext):
2993         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2994         (WTR::initializeWebViewConfiguration):
2995
2996 2020-01-06  Alex Christensen  <achristensen@webkit.org>
2997
2998         Allow wildcard scheme in UserContentURLPattern
2999         https://bugs.webkit.org/show_bug.cgi?id=205695
3000
3001         Reviewed by Darin Adler.
3002
3003         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3004
3005 2020-01-06  Antoine Quint  <graouts@apple.com>
3006
3007         REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing
3008         https://bugs.webkit.org/show_bug.cgi?id=205458
3009         <rdar://problem/58081704>
3010
3011         Reviewed by Wenson Hsieh.
3012
3013         The last sub-test in imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html checks on the
3014         ability to activate various form controls after disabling and re-enabling them. Two of those form controls, <select>
3015         and <textarea>, would trigger animations of the web view's UIScrollView causing touches to be consumed by UIKit and
3016         never seen by the WKContentView, and as such the expected "click" events would not be received. It would have been
3017         possible to modify the test to wait on any potential page scroll to complete before dispatching taps, but since this
3018         is a WPT test, we cannot modify it. Instead, we make a change to the function called by uiScriptController.singleTapAtPoint()
3019         to interrupt any pending UIScrollView animation when a tap is being triggered on the web view. Credit to Wenson Hsieh
3020         for suggesting this simple and effective approach.
3021
3022         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3023         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3024
3025 2020-01-06  Mark Lam  <mark.lam@apple.com>
3026
3027         Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
3028         https://bugs.webkit.org/show_bug.cgi?id=205776
3029
3030         Reviewed by Saam Barati.
3031
3032         * DumpRenderTree/mac/ObjCController.m:
3033         (-[ObjCController accessStoredWebScriptObject]):
3034
3035 2020-01-06  Mark Lam  <mark.lam@apple.com>
3036
3037         Add --force-optimization-level option to Tools/Scripts/set-webkit-configuration.
3038         https://bugs.webkit.org/show_bug.cgi?id=205787
3039
3040         Reviewed by Saam Barati.
3041
3042         Usage:
3043             --force-optimization-level=<opt> Force optimization: O3, O2, O1, O0, Os, Ofast, Og, or none
3044
3045         This can be used to force debug builds to be built with a higher level optimization
3046         so that tests can run to completion faster.
3047
3048         It can also be useful as a simple way to force release builds to be built with
3049         different optimization levels for performance comparison.
3050
3051         Setting --force-optimization-level=none restores the default optimization levels.
3052         Of course, the build targets need to be rebuilt for this to take effect.
3053
3054         * Scripts/set-webkit-configuration:
3055         * Scripts/webkitdirs.pm:
3056         (determineForceOptimizationLevel):
3057         (forceOptimizationLevel):
3058         (XcodeOptions):
3059
3060 2020-01-05  Dean Jackson  <dino@apple.com>
3061
3062         Rename GraphicsContext3D to GraphicsContextGL
3063         https://bugs.webkit.org/show_bug.cgi?id=205778
3064         <rdar://problem/58327597>
3065
3066         Reviewed by Sam Weinig.
3067
3068         Rename all the GraphicsContext3D things to GraphicsContextGL
3069         (includes Extensions3D and GRAPHICS_CONTEXT_3D).
3070
3071         GraphicsContext3DBase now becomes GraphicsContextGL.
3072         GraphicsContext3D is now GraphicsContextGLOpenGL (since it represents
3073         the OpenGL implementation of the API).
3074
3075         * Scripts/webkitpy/common/config/watchlist:
3076
3077 2020-01-06  Paulo Matos  <pmatos@igalia.com>
3078
3079         Remove unused variable jsDriverArgs from script
3080         https://bugs.webkit.org/show_bug.cgi?id=205797
3081
3082         Reviewed by Žan Doberšek.
3083
3084         * Scripts/run-javascriptcore-tests:
3085
3086 2020-01-06  Paulo Matos  <pmatos@igalia.com>
3087
3088         Add support for passing test arguments in envvar TEST_JSC_ARGS
3089         https://bugs.webkit.org/show_bug.cgi?id=205800
3090
3091         Reviewed by Žan Doberšek.
3092
3093         Similarly to what is done in build-jsc, we add support to pass
3094         extra command line arguments in environment variable TEST_JSC_ARGS.
3095
3096         * Scripts/run-javascriptcore-tests:
3097
3098 2020-01-06  Per Arne Vollan  <pvollan@apple.com>
3099
3100         [iOS] Issue mach lookup extension to launch services daemon for Mail
3101         https://bugs.webkit.org/show_bug.cgi?id=205316
3102
3103         Reviewed by Brent Fulgham.
3104
3105         Add test option to set bundle identifier. Using this, WebKitTestRunner can pretend to be any client, e.g. Mail.
3106
3107         Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html
3108
3109         * WebKitTestRunner/TestController.cpp:
3110         (WTR::TestController::createWebViewWithOptions):
3111         (WTR::updateTestOptionsFromTestHeader):
3112         * WebKitTestRunner/TestController.h:
3113         * WebKitTestRunner/TestOptions.h:
3114         (WTR::TestOptions::hasSameInitializationOptions const):
3115         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3116         (WTR::TestController::setApplicationBundleIdentifier):
3117
3118 2020-01-06  Philippe Normand  <pnormand@igalia.com>
3119
3120         [WPE][Qt] TestRunJavaScript failure
3121         https://bugs.webkit.org/show_bug.cgi?id=205766
3122
3123         Reviewed by Carlos Garcia Campos.
3124
3125         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
3126         (TestRunJavaScript::main): Surround JS function with parentheses
3127         to comply with the ECMAScript specification.
3128
3129 2020-01-05  Sam Weinig  <weinig@apple.com>
3130
3131         Further simplify StringBuilder usage by standardizing hex formating to a single hex() function
3132         https://bugs.webkit.org/show_bug.cgi?id=205759
3133
3134         Reviewed by Dean Jackson.
3135
3136         * TestWebKitAPI/CMakeLists.txt:
3137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3138         * TestWebKitAPI/Tests/WTF/HexNumber.cpp: Added.
3139         Add testing for hex formatting of integers.
3140
3141 2020-01-05  Simon Fraser  <simon.fraser@apple.com>
3142
3143         DumpRenderTree doesn't always call updateRendering() when a test completes
3144         https://bugs.webkit.org/show_bug.cgi?id=205761
3145
3146         Reviewed by Darin Adler.
3147         
3148         Some animation tests (and possibly many others) are flakey or broken in WK1 because
3149         there was no code to guarantee that Page::updateRendering() was called at notifyDone()
3150         time.
3151
3152         WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers,
3153         and flushes a CATransaction.
3154
3155         In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView,
3156         and just called [webView display] to make this happen. However, with layer backing, AppKit behavior
3157         changes, and WebCore changes that make more things happen with HTML event loop timing, this
3158         approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what
3159         WK2 is doing.
3160
3161         * DumpRenderTree/mac/DumpRenderTree.mm:
3162         (updateDisplay):
3163         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3164
3165 2020-01-03  Tim Horton  <timothy_horton@apple.com>
3166
3167         REGRESSION: 150+ flaky failures on some bots (color mismatches)
3168         https://bugs.webkit.org/show_bug.cgi?id=205755
3169         <rdar://problem/58248136>
3170
3171         Reviewed by Simon Fraser.
3172
3173         * DumpRenderTree/mac/LayoutTestHelper.m:
3174         (colorProfileURLForDisplay):
3175         (displayUUIDStrings):
3176         Use CGGetOnlineDisplayList instead of CGGetActiveDisplayList; we want
3177         all attached displays, even if they are sleeping.
3178
3179 2020-01-03  Keith Miller  <keith_miller@apple.com>
3180
3181         Update test262 tests to commit 157b18d
3182         https://bugs.webkit.org/show_bug.cgi?id=205741
3183
3184         Reviewed by Yusuke Suzuki.
3185
3186         Using --save and --latest-import should update expectations rather than overwrite.
3187
3188         * Scripts/test262/Runner.pm:
3189         (main):
3190
3191 2020-01-03  Simon Fraser  <simon.fraser@apple.com>
3192
3193         Add some shared schemes to the WebKit.xcworkspace
3194         https://bugs.webkit.org/show_bug.cgi?id=205698
3195
3196         Reviewed by Tim Horton.
3197         
3198         Make WebKit.xcworkspace show the following schemes by default:
3199             All Source
3200             All Tools
3201             WTF
3202             JavaScriptCore
3203             WebCore
3204             WebKit
3205             WebKitLegacy
3206             DumpRenderTree
3207             WebKitTestRunner
3208             TestWebKitAPI
3209             MiniBrowser
3210             MobileMiniBrowser.
3211             
3212         Also remove the MobileMiniBrowserUITests scheme.
3213
3214         * DumpRenderTree/DumpRenderTree.xcodeproj/xcshareddata/xcschemes/DumpRenderTree.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
3215         * MiniBrowser/MiniBrowser.xcodeproj/xcshareddata/xcschemes/MiniBrowser.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
3216         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowser.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
3217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
3218         * WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
3219
3220 2020-01-03  youenn fablet  <youenn@apple.com>
3221
3222         Provide pid to crashing service worker process and GPU process
3223         https://bugs.webkit.org/show_bug.cgi?id=205564
3224
3225         Reviewed by Alex Christensen.
3226
3227         Exposing the pid allows WebKitTestRunner to provide better information.
3228
3229         * WebKitTestRunner/TestController.cpp:
3230         (WTR::TestController::serviceWorkerProcessDidCrash):
3231         (WTR::TestController::gpuProcessDidCrash):
3232         * WebKitTestRunner/TestController.h:
3233
3234 2020-01-03  Alex Christensen  <achristensen@webkit.org>
3235
3236         Deprecate _WKWebsitePolicies
3237         https://bugs.webkit.org/show_bug.cgi?id=205539
3238
3239         Reviewed by Wenson Hsieh.
3240
3241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3242         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3243         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3244         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
3245         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3246         (-[ContentBlockingWebsitePoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3247         (TEST):
3248         (-[AutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3249         (-[AsyncAutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3250         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3251         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3252         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3253         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3254         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3255         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3256         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3257         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3258         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3259         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3260         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
3261         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
3262         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3263
3264 2020-01-03  Alicia Boya García  <aboya@igalia.com>
3265
3266         [GStreamer][MSE] Player stalling too soon
3267         https://bugs.webkit.org/show_bug.cgi?id=205117
3268
3269         Reviewed by Xabier Rodriguez-Calvar.
3270
3271         Backported patch to jhbuild.
3272
3273         Small modifications were necessary to make it apply on 1.16.1.
3274
3275         * gstreamer/jhbuild.modules:
3276         * gstreamer/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.
3277
3278 2020-01-02  Alex Christensen  <achristensen@webkit.org>
3279
3280         Add SPI to disable CORS on requests to URLs matching a pattern
3281         https://bugs.webkit.org/show_bug.cgi?id=205534
3282         <rdar://problem/58011337>
3283
3284         Reviewed by Chris Dumez.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3287
3288 2020-01-02  Sam Weinig  <weinig@apple.com>
3289
3290         Simplify StringBuilder API/align with makeString by removing appendFixed* functions and using FormatNumber struct instead
3291         https://bugs.webkit.org/show_bug.cgi?id=205671
3292
3293         Reviewed by Alex Christensen.
3294
3295         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3296         Replace all uses of builder.appendFixedPrecisionNumber(...) with builder.append(FormattedNumber::fixedPrecision(...)).
3297
3298 2019-12-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3299
3300         [WPE] OpenJPEG missing in install dependencies script.
3301         https://bugs.webkit.org/show_bug.cgi?id=205647
3302
3303         Unreviewed follow-up fix.
3304
3305         Add also the OpenJPEG-2 package to the WPE install list.
3306
3307         * wpe/install-dependencies:
3308
3309 2019-12-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3310
3311         [GTK][WPE] OpenJPEG missing in install dependencies script
3312         https://bugs.webkit.org/show_bug.cgi?id=205647
3313
3314         Reviewed by Adrian Perez de Castro.
3315
3316         * gtk/install-dependencies: Add OpenJPEG-2 package to the list.
3317
3318 2019-12-30  Brady Eidson  <beidson@apple.com>
3319
3320         Add WKWebView SPI to evaluate a function with arguments
3321         https://bugs.webkit.org/show_bug.cgi?id=205239
3322
3323         Reviewed by Alex Christensen.
3324
3325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3326         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm: Added.
3327         (TestWebKitAPI::TEST):
3328         * TestWebKitAPI/cocoa/TestWKWebView.h:
3329         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3330         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
3331
3332 2019-12-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3333
3334         [GTK][WPE] Report number of total tests run and failed in API test runner like run-api-tests does
3335         https://bugs.webkit.org/show_bug.cgi?id=205608
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         Calculate the total number of tests (including subtests) executed
3340         and report it at the end of the step in the same format than run-api-tests does.
3341
3342         * glib/api_test_runner.py:
3343         (TestRunner._run_test_glib): Pass the list of skipped tests instead of calculating it here to avoid calculating it twice.
3344         (TestRunner._get_tests_from_google_test_suite): Ditto.
3345         (TestRunner._run_google_test_suite): Ditto.
3346         (TestRunner._run_test): Ditto.
3347         (TestRunner.run_tests):
3348         (TestRunner.run_tests.number_of_tests):
3349         (TestRunner.run_tests.report):
3350
3351 2019-12-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3352
3353         [GTK][WPE] support output of results in json format in API test runner.
3354         https://bugs.webkit.org/show_bug.cgi?id=205579
3355
3356         Reviewed by Carlos Garcia Campos.
3357
3358         Write the results of the tests in json format when the option --json-output
3359         is passed to run-gtk-tests or run-wpe-tests. Use the same format than mac's
3360         run-api-tests.
3361
3362         * glib/api_test_runner.py:
3363         (TestRunner.run_tests):
3364         (TestRunner.run_tests.generate_test_list_for_json_output):
3365         (TestRunner):
3366         (add_options):
3367
3368 2019-12-28  Commit Queue  <commit-queue@webkit.org>
3369
3370         Unreviewed, rolling out r253804.
3371         https://bugs.webkit.org/show_bug.cgi?id=205622
3372
3373         Seeing strange test results after this change (Requested by ap
3374         on #webkit).
3375
3376         Reverted changeset:
3377
3378         "Python 3: Add support to run-webkit-tests"
3379         https://bugs.webkit.org/show_bug.cgi?id=205291
3380         https://trac.webkit.org/changeset/253804
3381
3382 2019-12-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3383
3384         [iOS] Layout tests sometimes throw an exception under checkForOutstandingCallbacks
3385         https://bugs.webkit.org/show_bug.cgi?id=205612
3386         <rdar://problem/57789693>
3387
3388         Reviewed by Tim Horton.
3389
3390         On iOS, layout tests that synthesize HID events but end before WebKitTestRunnerApp finishes dequeueing and
3391         handling those events occasionally cause the next test to crash with an Objective-C exception under
3392         UIScriptControllerIOS::checkForOutstandingCallbacks. This happens when UIScriptContext is destroyed after a HID
3393         marker event is dispatched, but before that HID marker event has been handled. (For clarity, the HID marker
3394         event is a special vendor-defined event used by HIDEventGenerator to signify the end of a series of synthesized
3395         HID events that were previously dispatched to the application).
3396
3397         This is typically fixed by ensuring that all iOS layout tests always wait for synthesized HID events to finish
3398         before ending the test (i.e. by calling `testRunner.notifyDone()`). However, some tests that fall into this
3399         category are imported: e.g. dom/events/document-level-touchmove-event-listener-passive-by-default.html in
3400         web-platform-tests/, which does not wait for the swipe gesture to finish before completing. This current causes
3401         us to dispatch the end of the gesture while the following test (dom/events/event-disabled-dynamic.html) begins.
3402
3403         While I wasn't able to trivially reproduce the exception locally, it was consistently reproducible by forcing a
3404         50 ms `sleep` in -[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:], right before queueing the marker
3405         event. This suggests that the crash is timing-dependent, and just seems to occasionally reproduce more
3406         frequently in internal automation.
3407
3408         This test seems to be passing reliably in other engines (e.g. Chrome and Edge), so instead of trying to fix the
3409         test to always wait for events to finish dispatching, we can address the issue by teaching WebKitTestRunner to
3410         simply wait for outgoing marker events to finish dispatching before proceeding with the next test, rather than
3411         crashing. This should not only fix the crash, but also address sporadic flakiness that may result from tests
3412         that handle synthetic HID events that were dispatched by the previous test.
3413
3414         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3415         (UIScriptContext::~UIScriptContext):
3416         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3417         (WTR::UIScriptController::waitForOutstandingCallbacks):
3418         (WTR::UIScriptController::checkForOutstandingCallbacks): Deleted.
3419
3420         Rename checkForOutstandingCallbacks to waitForOutstandingCallbacks, and make it wait up to a second for the
3421         application to finish handling any outgoing marker HID event. In the event that the timeout is hit, we still
3422         throw an Objective-C exception to avoid beginning the next test in an unpredictable state.
3423
3424         * WebKitTestRunner/ios/HIDEventGenerator.h:
3425         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3426         (-[HIDEventGenerator init]):
3427
3428         Perform some minor cleanup here, by removing excess private category properties in HIDEventGenerator (including
3429         -debugTouchViews, which was unused); also, change _eventCallbacks into a `RetainPtr`, so that we don't need to
3430         worry about manually releasing it.
3431
3432         (-[HIDEventGenerator dealloc]): Deleted.
3433         (-[HIDEventGenerator hasOutstandingCallbacks]):
3434         (-[HIDEventGenerator checkForOutstandingCallbacks]): Deleted.
3435
3436         Rename -checkForOutstandingCallbacks to -hasOutstandingCallbacks, and flip the return result.
3437
3438         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3439         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3440         (WTR::UIScriptControllerIOS::waitForOutstandingCallbacks):
3441         (WTR::UIScriptControllerIOS::checkForOutstandingCallbacks): Deleted.
3442
3443 2019-12-28  Antti Koivisto  <antti@apple.com>
3444
3445         Allow disabling internal and experimental features in run-webkit-tests
3446         https://bugs.webkit.org/show_bug.cgi?id=205614
3447
3448         Reviewed by Tim Horton.
3449
3450         Add an optional true/false parameter to --internal-feature/--experimental-feature options.
3451         This can be useful for isolating problems in features that are enabled by default. Example:
3452
3453         --internal-feature LayoutFormattingContextIntegrationEnabled=false
3454
3455         The [=true|false] syntax is the same as used in test headers.
3456
3457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3458         (parse_args):
3459         * WebKitTestRunner/Options.cpp:
3460         (WTR::parseFeature):
3461         (WTR::handleOptionExperimentalFeature):
3462         (WTR::handleOptionInternalFeature):
3463         * WebKitTestRunner/Options.h:
3464         * WebKitTestRunner/TestController.cpp:
3465         (WTR::TestController::testOptionsForTest const):
3466         * WebKitTestRunner/TestController.h:
3467
3468 2019-12-25  Dean Jackson  <dino@apple.com>
3469
3470         WKTR/DRT always trigger the Discrete GPU on dual GPU systems
3471         https://bugs.webkit.org/show_bug.cgi?id=205546
3472         <rdar://problem/58139610>
3473
3474         Reviewed by Alexey Proskuryakov.
3475
3476         Add an option "--prefer-integrated-gpu" to run-webkit-test
3477         that causes the LayoutTestHelper to NOT lock the
3478         machine to a discrete GPU on a dual-GPU system.
3479         The default is false.
3480
3481         * DumpRenderTree/mac/LayoutTestHelper.m:
3482         (main):
3483         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3484         (Manager._set_up_run):
3485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3486         (parse_args):
3487         * Scripts/webkitpy/port/base.py:
3488         (Port.start_helper):
3489         * Scripts/webkitpy/port/mac.py:
3490         (MacPort.start_helper):
3491         * Scripts/webkitpy/port/mock_drt.py:
3492         (MockDRTPort.start_helper):
3493
3494 2019-12-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3495
3496         REGRESSION (r253282): Tests that use applyAutocorrection assert in UIScriptContext::requestUIScriptCompletion
3497         https://bugs.webkit.org/show_bug.cgi?id=205588
3498         <rdar://problem/58109942>
3499
3500         Reviewed by Tim Horton.
3501
3502         The change made in r253282 intended to defer completing the async task prepared in
3503         UIScriptController::applyAutocorrection until after the current runloop; however, it ended up keeping the
3504         synchronous call to asyncTaskComplete. Fix this by removing this code, so that we instead wait for the
3505         dispatch_async block to invoke asyncTaskComplete.
3506
3507         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3508         (WTR::UIScriptControllerIOS::applyAutocorrection):
3509
3510 2019-12-24  Youenn Fablet  <youenn@apple.com>
3511
3512         Deny Notification API access for non secure contexts
3513         https://bugs.webkit.org/show_bug.cgi?id=205496
3514         <rdar://problem/58074660>
3515
3516         Reviewed by Chris Dumez.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3519         (TEST):
3520
3521 2019-12-24  youenn fablet  <youenn@apple.com>
3522
3523         Service Worker doesn't terminate after a period of time when thread blocking
3524         https://bugs.webkit.org/show_bug.cgi?id=202992
3525         <rdar://problem/56298596>
3526
3527         Reviewed by Chris Dumez.
3528
3529         * WebKitTestRunner/TestController.cpp:
3530         (WTR::TestController::resetPreferencesToConsistentValues):
3531         Enable small timeout values.
3532
3533 2019-12-23  Keith Miller  <keith_miller@apple.com>
3534
3535         DFG/FTL should be able to exit to the middle of a bytecode
3536         https://bugs.webkit.org/show_bug.cgi?id=205232
3537
3538         Reviewed by Saam Barati.
3539
3540         * Scripts/run-jsc-stress-tests:
3541
3542 2019-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3543
3544         [GTK] InputMethod API unit tests don't work under X11
3545         https://bugs.webkit.org/show_bug.cgi?id=205497
3546
3547         Reviewed by Žan Doberšek.
3548
3549         Use a toplevel window instead of a popup for the input method tests, since that's required in X11 to get the web
3550         view focused.
3551
3552         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
3553         (testWebKitInputMethodContextSimple):
3554         (testWebKitInputMethodContextSequence):
3555         (testWebKitInputMethodContextInvalidSequence):
3556         (testWebKitInputMethodContextCancelSequence):
3557         (testWebKitInputMethodContextReset):
3558
3559 2019-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3560
3561         [GTK][WPE] Special combination characters doesn't respect the keystroke order when high CPU load
3562         https://bugs.webkit.org/show_bug.cgi?id=185248
3563
3564         Reviewed by Žan Doberšek.
3565
3566         Remove the waits() that were added to work around this bug.
3567
3568         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
3569         (testWebKitInputMethodContextSequence):
3570         (testWebKitInputMethodContextInvalidSequence):
3571         (testWebKitInputMethodContextCancelSequence):
3572         (testWebKitInputMethodContextReset):
3573
3574 2019-12-21  Yusuke Suzuki  <ysuzuki@apple.com>
3575
3576         [JSC] Improve our bound function implementation
3577         https://bugs.webkit.org/show_bug.cgi?id=205327
3578
3579         Reviewed by Keith Miller.
3580
3581         Support running slow-microbenchmarks.
3582
3583         * Scripts/run-jsc-benchmarks:
3584
3585 2019-12-21  Kate Cheney  <katherine_cheney@apple.com>
3586
3587         Add timeStamp to ITP database
3588         https://bugs.webkit.org/show_bug.cgi?id=205121
3589         <rdar://problem/57633021>
3590
3591         Reviewed by John Wilander.
3592
3593         Added checks to test that the timestamp is properly exposed via API
3594         in the ITP database backend. This also adds an API test case using the
3595         ITP database store. It was previously only testing the ITP memory store.
3596
3597         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3598         (TEST):
3599
3600 2019-12-20  Ryosuke Niwa  <rniwa@webkit.org>
3601
3602         TextManipulationController should respect new token orders
3603         https://bugs.webkit.org/show_bug.cgi?id=205378
3604
3605         Reviewed by Wenson Hsieh.
3606
3607         Added a bunch of tests for WKTextManipulation.
3608
3609         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3610         (TextManipulation.CompleteTextManipulationReplaceSimpleSingleParagraph):
3611         (TextManipulation.CompleteTextManipulationDisgardsTokens):
3612         (TextManipulation.CompleteTextManipulationReordersContent):
3613         (TextManipulation.CompleteTextManipulationCanSplitContent):
3614         (TextManipulation.CompleteTextManipulationCanMergeContent):
3615         (TextManipulation.CompleteTextManipulationFailWhenContentIsRemoved):
3616         (TextManipulation.CompleteTextManipulationFailWhenExcludedContentAppearsMoreThanOnce):
3617         (TextManipulation.CompleteTextManipulationPreservesExcludedContent):
3618
3619 2019-12-20  Megan Gardner  <megan_gardner@apple.com>
3620
3621         Paint highlights specified in CSS Highlight API
3622         https://bugs.webkit.org/show_bug.cgi?id=205318
3623
3624         Reviewed by Ryosuke Niwa.
3625
3626         Expand MarkedText to take a style name.
3627
3628         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
3629         (WebCore::operator<<):
3630
3631 2019-12-20  Jonathan Bedard  <jbedard@apple.com>
3632
3633         lldbwebkittester: Strip CLANG_DEBUG_INFORMATION_LEVEL option while building
3634         https://bugs.webkit.org/show_bug.cgi?id=205513
3635
3636         Reviewed by Alexey Proskuryakov.
3637
3638         * Scripts/webkitdirs.pm:
3639         (buildXCodeProject): Strip CLANG_DEBUG_INFORMATION_LEVEL from lldbWebKitTester.
3640
3641 2019-12-20  Simon Fraser  <simon.fraser@apple.com>
3642
3643         Add a Custom User Agent menu to MiniBrowser, and related cleanup
3644         https://bugs.webkit.org/show_bug.cgi?id=205507
3645
3646         Reviewed by Wenson Hsieh.
3647         
3648         Add a User Agent" submenu to the Settings menu, and construct it with some built-in
3649         UA strings. When changed, it sets the customUserAgent on the WKWebView/WebView and
3650         triggers a reload.
3651         
3652         I also rearranged the menus so that "Settings" and "Debug" are no longer to the right
3653         of the "Help" menu, which means getting the Settings menu from the xib. It was then
3654         easier if SettingsController was no longer a singleton, but owned by AppDelegate.
3655         Added a category on NSApplication to make it easier to get to BrowserAppDelegate
3656         and thence to the SettingsController.
3657
3658         * MiniBrowser/mac/AppDelegate.h:
3659         * MiniBrowser/mac/AppDelegate.m:
3660         (-[NSApplication browserAppDelegate]):
3661         (-[BrowserAppDelegate awakeFromNib]):
3662         (-[BrowserAppDelegate defaultConfiguration]):
3663         (-[BrowserAppDelegate defaultPreferences]):
3664       &n