43330a6667b6a42b921d32310b8489e18fa3ad99
[WebKit-https.git] / Tools / ChangeLog
1 2016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         resolve-ChangeLogs: Specify --no-page to git diff
4         https://bugs.webkit.org/show_bug.cgi?id=163441
5
6         Reviewed by Darin Adler.
7
8         resolve-ChangeLogs shows the result after resolving by invoking
9         'git diff'. It runs a pager for every ChangeLog if it is under
10         TTY.
11
12         * Scripts/resolve-ChangeLogs:
13         (showStatus): Specify '--no-page' to git diff.
14
15 2016-10-17  Michael Catanzaro  <mcatanzaro@igalia.com>
16
17         Move user agent quirks to cross-platform location
18         https://bugs.webkit.org/show_bug.cgi?id=163508
19
20         Reviewed by Carlos Garcia Campos.
21
22         Move the test to a cross-platform location and improve it to better check the full list of
23         sites we have defined quirks for.
24
25         * TestWebKitAPI/PlatformGTK.cmake:
26         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
27         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
28         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
29         (TestWebKitAPI::TEST):
30
31 2016-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
32
33         [SOUP] Downloads should always sniff contents
34         https://bugs.webkit.org/show_bug.cgi?id=163538
35
36         Reviewed by Michael Catanzaro.
37
38         Add a test case to check that the MIME type is correctly guessed for downloads.
39
40         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
41         (writeNextChunk):
42         (serverCallback):
43         (testDownloadMIMEType):
44         (beforeAll):
45         (writeNextChunkIdle): Deleted.
46
47 2016-10-16  Daniel Bates  <dabates@apple.com>
48
49         Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
50         (https://bugs.webkit.org/show_bug.cgi?id=163456)
51
52         * Scripts/prepare-ChangeLog:
53         (actuallyGenerateFunctionLists):
54
55 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
56
57         Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
58
59         After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
60         actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
61         g_assert_cmpstr for tests.
62
63         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
64         (testWebContextLanguages):
65
66 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
67
68         [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
69         https://bugs.webkit.org/show_bug.cgi?id=163389
70
71         Reviewed by Michael Catanzaro.
72
73         Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
74         modified by WebKitWebPage::send-request signal.
75
76         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
77         (testWebPageURI):
78
79 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
80
81         Document request not updated after willSendRequest is called for a redirect
82         https://bugs.webkit.org/show_bug.cgi?id=163436
83
84         Reviewed by Michael Catanzaro.
85
86         Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
87         WebKitPage::send-request signal in a web extension.
88
89         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
90         (testWebViewActiveURI):
91         (serverCallback):
92         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
93         (sendRequestCallback):
94         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
95         (loadChangedCallback):
96
97 2016-10-15  Dan Bernstein  <mitz@apple.com>
98
99         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
100         https://bugs.webkit.org/show_bug.cgi?id=163492
101         <rdar://problem/28654799>
102
103         Reviewed by Darin Adler.
104
105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
106         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
107         (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
108         (TestWebKitAPI::TEST):
109
110 2016-10-15  Daniel Bates  <dabates@apple.com>
111
112         prepare-ChangeLog erroneously said that a python __init__ method was deleted
113         https://bugs.webkit.org/show_bug.cgi?id=163456
114
115         Reviewed by Simon Fraser.
116
117         Fixes an issue where prepare-ChangeLog may list as deleted functions that are
118         immediately above added code.
119
120         Currently prepare-ChangeLog makes use of the same overlap detection algorithm
121         to compute the list of deleted functions as it does to compute added and modified
122         functions. We consider a function deleted if its entire function body and signature
123         are removed. It is sufficient to compare the list of functions before the patch
124         is applied and the list of functions are the patch is applied to identify
125         these functions.
126
127         * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
128         variable names.
129         (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
130         compute the list of functions in the file after the patch regardless of whether the
131         patch only contains deletions. We will compare this list against the list of functions
132         before the patch was applied to determine the deleted functions.
133         (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
134         Removed out argument for the seen functions as we no longer make use of when computing
135         the list of deleted functions.
136         (diffCommand): Update comment.
137         (generateFunctionListsByRanges): Deleted.
138         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
139
140 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
141
142         REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
143         https://bugs.webkit.org/show_bug.cgi?id=163478
144
145         Reviewed by Daniel Bates.
146         
147         Handle a None other in Contributor.__eq__.
148
149         * Scripts/webkitpy/common/config/committers.py:
150         (Contributor.__eq__):
151
152 2016-10-14  JF Bastien  <jfbastien@apple.com>
153
154         Basic WebAssembly testing
155
156         Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
157         https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
158
159         This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
160
161         Details and example in README.md.
162
163         Basic WebAssembly testing
164         https://bugs.webkit.org/show_bug.cgi?id=163267
165
166         Reviewed by Keith Miller.
167
168         * Scripts/run-javascriptcore-tests:
169         (runJSCStressTests): run wasm.yaml tests
170         * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
171
172 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
173
174         Annotate bots in contributors.json and don't show them on webkit.org/team
175         https://bugs.webkit.org/show_bug.cgi?id=163317
176
177         Reviewed by Daniel Bates.
178         
179         Add "class" : "bot" for non-humans in contributors.json and round-trip it.
180
181         * Scripts/webkitpy/common/config/committers.py:
182         (Contributor.__init__):
183         (Contributor.as_dict):
184         (Bot):
185         (Bot.__init__):
186         (CommitterList.load_json):
187         * Scripts/webkitpy/common/config/contributors.json:
188
189 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
190
191         Fix printing in WK2 MiniBrowser
192         https://bugs.webkit.org/show_bug.cgi?id=163455
193
194         Reviewed by Tim Horton.
195         
196         Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
197
198         * MiniBrowser/mac/WK2BrowserWindowController.m:
199         (-[WK2BrowserWindowController printWebView:]):
200
201 2016-10-14  Commit Queue  <commit-queue@webkit.org>
202
203         Unreviewed, rolling out r207335.
204         https://bugs.webkit.org/show_bug.cgi?id=163445
205
206         WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
207         out on Mac bots (Requested by youenn on #webkit).
208
209         Reverted changeset:
210
211         "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
212         ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
213         builds"
214         https://bugs.webkit.org/show_bug.cgi?id=163440
215         http://trac.webkit.org/changeset/207335
216
217 2016-10-14  Youenn Fablet  <youenn@apple.com>
218
219         Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
220         https://bugs.webkit.org/show_bug.cgi?id=163440
221
222         Unreviewed.
223
224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
225         https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
226
227 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
228
229         Unreviewed. Removed myself from BindingsScripts watch list.
230
231         * Scripts/webkitpy/common/config/watchlist:
232
233 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
234
235         WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
236         https://bugs.webkit.org/show_bug.cgi?id=146306
237
238         Reviewed by Darin Adler.
239
240         Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
241
242         * TestWebKitAPI/CMakeLists.txt:
243         * TestWebKitAPI/PlatformEfl.cmake:
244         * TestWebKitAPI/PlatformGTK.cmake:
245         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
246         (TestWebKitAPI::didCommitLoadForFrame):
247         (TestWebKitAPI::TEST):
248         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
249         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
250         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
251         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
252
253 2016-10-13  Alex Christensen  <achristensen@webkit.org>
254
255         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
256         https://bugs.webkit.org/show_bug.cgi?id=163413
257
258         Reviewed by Tim Horton.
259
260         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
261         (TestWebKitAPI::TEST_F):
262         Update parsing results.  There are now fewer differences between the new URLParser and the old URL::parse.
263
264 2016-10-13  Alex Christensen  <achristensen@webkit.org>
265
266         Rebase API tests after r207305.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
270         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
271         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
272         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
273         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
274         Change results back to what they were before r207162, r207167, and r207184.
275
276 2016-10-13  Alex Christensen  <achristensen@webkit.org>
277
278         Disable URLParser for non-Safari iOS and Mac apps for now
279         https://bugs.webkit.org/show_bug.cgi?id=163397
280
281         Reviewed by Tim Horton.
282
283         * DumpRenderTree/mac/DumpRenderTree.mm:
284         (DumpRenderTreeMain):
285         * WebKitTestRunner/TestController.cpp:
286         Enable the URLParser for testing.
287         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
288         Link with WebCoreTestSupport so we can find setURLParserEnabled.
289
290 2016-10-13  Ryan Haddad  <ryanhaddad@apple.com>
291
292         Unreviewed, rolling out r207297.
293
294         This change broke the iOS build.
295
296         Reverted changeset:
297
298         "Disable URLParser for non-Safari iOS and Mac apps for now"
299         https://bugs.webkit.org/show_bug.cgi?id=163397
300         http://trac.webkit.org/changeset/207297
301
302 2016-10-13  Alex Christensen  <achristensen@webkit.org>
303
304         Disable URLParser for non-Safari iOS and Mac apps for now
305         https://bugs.webkit.org/show_bug.cgi?id=163397
306
307         Reviewed by Tim Horton.
308
309         * DumpRenderTree/mac/DumpRenderTree.mm:
310         (DumpRenderTreeMain):
311         * WebKitTestRunner/ios/mainIOS.mm:
312         (main):
313         * WebKitTestRunner/mac/main.mm:
314         (main):
315
316 2016-10-12  Alex Christensen  <achristensen@webkit.org>
317
318         Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
319         https://bugs.webkit.org/show_bug.cgi?id=163376
320
321         Reviewed by Saam Barati.
322
323         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
324         (TestWebKitAPI::TEST_F):
325
326 2016-10-11  Dean Jackson  <dino@apple.com>
327
328         Add preliminary support for extended colors to WebCore::Color
329         https://bugs.webkit.org/show_bug.cgi?id=162878
330         <rdar://problem/28596413>
331
332         Reviewed by Darin Adler.
333
334         A new API test for Colors.
335
336         * TestWebKitAPI/Tests/WebCore/Color.cpp:
337         (TestWebKitAPI::TEST):
338
339 2016-10-12  Ryan Haddad  <ryanhaddad@apple.com>
340
341         Unreviewed, rolling out r207225.
342
343         This change causes debug tests to exit early with crashes.
344
345         Reverted changeset:
346
347         "Optional's move-constructor and move-assignment operator
348         don't disengage the value being moved from"
349         https://bugs.webkit.org/show_bug.cgi?id=163309
350         http://trac.webkit.org/changeset/207225
351
352 2016-10-12  Alex Christensen  <achristensen@webkit.org>
353
354         Fix assertion after switching to URLParser
355         https://bugs.webkit.org/show_bug.cgi?id=163350
356         rdar://problem/28739938
357
358         Reviewed by Brady Eidson.
359
360         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
361         (TEST):
362
363 2016-10-11  Sam Weinig  <sam@webkit.org>
364
365         Optional's move-constructor and move-assignment operator don't disengage the value being moved from
366         https://bugs.webkit.org/show_bug.cgi?id=163309
367
368         Reviewed by Anders Carlsson.
369
370         * TestWebKitAPI/Tests/WTF/Optional.cpp:
371         (TestWebKitAPI::TEST):
372         Add tests for Optional's move-constructor and move-assignment operator.
373
374 2016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
375
376         Now playing media sessions are always cleared for the active foreground tab
377         https://bugs.webkit.org/show_bug.cgi?id=163310
378         <rdar://problem/28573301>
379
380         Reviewed by Jer Noble.
381
382         Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
383         that media session info is correctly cleared out if the media session itself is no longer eligible for Now
384         Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
385         always clear out the information, but this is incorrect, and is the source of the problem.
386
387         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
388         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
389         (TestWebKitAPI::TEST):
390
391 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
392
393         [Win] Parallel DRTs are sharing preferences and cache.
394         https://bugs.webkit.org/show_bug.cgi?id=163013
395
396         Reviewed by Brent Fulgham.
397
398         Use separate cache and preferences for each DRT instance.
399
400         * DumpRenderTree/win/DumpRenderTree.cpp:
401         (applicationId):
402         (setApplicationId):
403         (setCacheFolder):
404         (setDefaultsToConsistentValuesForTesting):
405         * Scripts/webkitpy/port/win.py:
406         (WinPort.setup_test_run):
407
408 2016-10-11  Alex Christensen  <achristensen@webkit.org>
409
410         Update API test expectation after r207162.
411        ​https://bugs.webkit.org/show_bug.cgi?id=162660
412
413         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
414         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
415         Like r207167 but with a WebKit2 test.
416         "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
417
418 2016-10-11  Alex Christensen  <achristensen@webkit.org>
419
420         Update API test expectation after r207162.
421         https://bugs.webkit.org/show_bug.cgi?id=162660
422
423         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
424         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
425         "https://www.example.com<>/" was an invalid URL with the old URL parser.
426         It is now a valid URL, but NSURL still considers it invalid.
427         This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
428
429 2016-10-11  Edward O'Connor  <eoconnor@apple.com>
430
431         Update my name in contributors.json
432         https://bugs.webkit.org/show_bug.cgi?id=163251
433
434         Reviewed by Simon Fraser.
435
436         * Scripts/webkitpy/common/config/contributors.json:
437
438 2016-10-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
439
440         Add SynchronizedFixedQueue class
441         https://bugs.webkit.org/show_bug.cgi?id=162478
442
443         Reviewed by Geoffrey Garen.
444
445         Add a new test for SynchronizedFixedQueue. The test defines a new class
446         called ToUpperConverter which converts strings from lower case to upper
447         case. It creates two threads : (1) produce thread and (2) consume thread.
448         Here is what each thread does:
449
450         1. Main threads: Enqueues lower case strings into m_lowerQueue.
451         2. Produce thread: Dequeues lower case strings from m_lowerQueue and 
452            enqueue their upper case strings in the m_upperQueue.
453         3. Consume thread: Dequeues upper case strings from m_upperQueue.
454
455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
456         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
457         (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
458         (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
459         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
460         (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
461         (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
462         (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
463         (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
464         (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
465         (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
466         (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
467         (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
468         (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
469         (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
470         (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
471         (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
472         (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
473         (TestWebKitAPI::TEST):
474
475 2016-10-11  Megan Gardner  <megan_gardner@apple.com>
476
477         Extend event stream to include interpolated events and add a force press test that uses that interpolation
478         https://bugs.webkit.org/show_bug.cgi?id=163161
479
480         Reviewed by Simon Fraser.
481
482         Added functionality to the event stream to allow for interpolated events.
483         Can now do long press, as well as a better way to do drag and other time-based
484         events that require a large stream of descrete HID events.
485         Added a basic force touch test to demostrate this interpolation.
486         Also updated the script to allow for iPhone 7 specific tests, as force touch
487         needs to be on a device that had force touch.
488
489         * Scripts/webkitpy/port/ios.py:
490         (IOSSimulatorPort):
491         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
492         * WebKitTestRunner/ios/HIDEventGenerator.mm:
493         (linearInterpolation):
494         (simpleCurveInterpolation):
495         (calculateNextCurveLocation):
496         (phaseFromString):
497         (interpolationFromString):
498         (-[HIDEventGenerator eventMaskFromEventInfo:]):
499         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
500         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
501         (-[HIDEventGenerator interpolatedEvents:]):
502         (-[HIDEventGenerator processEventsArray:withStartTime:]):
503         (-[HIDEventGenerator eventDispatchThreadEntry:]):
504         (simpleDragCurve): Deleted.
505         (calculateNextLocation): Deleted.
506
507 2016-10-11  Alex Christensen  <achristensen@webkit.org>
508
509         URLParser should percent-encode non-ASCII and non-printable characters in fragment
510         https://bugs.webkit.org/show_bug.cgi?id=163287
511
512         Reviewed by Brady Eidson.
513
514         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
515         (TestWebKitAPI::TEST_F):
516
517 2016-10-11  Alex Christensen  <achristensen@webkit.org>
518
519         Remove dead networking code
520         https://bugs.webkit.org/show_bug.cgi?id=163263
521
522         Reviewed by Daniel Bates.
523
524         * DumpRenderTree/DumpRenderTree.h:
525         * DumpRenderTree/config.h:
526         * DumpRenderTree/win/DumpRenderTree.cpp:
527         (main):
528
529 2016-10-11  John Wilander  <wilander@apple.com>
530
531         Modify check-webkit-style to prohibit sensitive phrases
532         https://bugs.webkit.org/show_bug.cgi?id=163048
533         <rdar://problem/28289755>
534
535         Terms considered or found to be too general to flag:
536         ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
537         denial of service, dereference, disclosure, error, exploit,
538         failure, heap, integer overflow, leak, null dereference,
539         null pointer dereference, out of bounds, overflow,
540         race condition, sensitive information, stack, type confusion.
541
542         Reviewed by Brent Fulgham.
543
544         * Scripts/webkitpy/style/checkers/changelog.py:
545         (ChangeLogChecker.check_entry):
546             Now calls ChangeLogChecker.check_for_unwanted_security_terms().
547         (ChangeLogChecker):
548         (ChangeLogChecker.check_for_unwanted_security_terms):
549             New function to check for sensitive terms.
550         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
551         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
552             Convenience class.
553         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
554         (ChangeLogCheckerTest.test_unwanted_security_terms):
555
556 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
557
558         Unreviewed, rolling out r207067.
559
560         This change caused webkitpy test failures.
561
562         Reverted changeset:
563
564         "[Win] Parallel DRTs are sharing preferences and cache."
565         https://bugs.webkit.org/show_bug.cgi?id=163013
566         http://trac.webkit.org/changeset/207067
567
568 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
569
570         [Win] Parallel DRTs are sharing preferences and cache.
571         https://bugs.webkit.org/show_bug.cgi?id=163013
572
573         Reviewed by Brent Fulgham.
574
575         Use separate cache and preferences for each DRT instance.
576
577         * DumpRenderTree/win/DumpRenderTree.cpp:
578         (applicationId):
579         (setApplicationId):
580         (setCacheFolder):
581         (setDefaultsToConsistentValuesForTesting):
582         * Scripts/webkitpy/port/win.py:
583         (WinPort.setup_test_run):
584
585 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
586
587         Add ENABLE_ENCRYPTED_MEDIA configuration option
588         https://bugs.webkit.org/show_bug.cgi?id=163219
589
590         Reviewed by Darin Adler.
591
592         * Scripts/webkitperl/FeatureList.pm:
593         Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
594         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
595         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
596         to enable or disable the new EME implementation at build-time.
597
598 2016-10-10  Commit Queue  <commit-queue@webkit.org>
599
600         Unreviewed, rolling out r206972.
601         https://bugs.webkit.org/show_bug.cgi?id=163227
602
603         Making EWS flaky (Requested by bfulgham_ on #webkit).
604
605         Reverted changeset:
606
607         "[CMake] CMake does not support the dep files for implicit
608         dependency"
609         https://bugs.webkit.org/show_bug.cgi?id=161433
610         http://trac.webkit.org/changeset/206972
611
612 2016-10-10  Youenn Fablet  <youenn@apple.com>
613
614         W3C test downloader should be able to import specific files/sub-directories in a skipped directory
615         https://bugs.webkit.org/show_bug.cgi?id=161789
616
617         Reviewed by Ryosuke Niwa.
618
619         Removed tests_directory option and corresponding test.
620         This option was allowing to import a sub-directory from a test repository.
621         We can readd it if necessary.
622
623         Adding support for finer-grained import rules.
624         Previously skipped directories were fully removed.
625         Now, directories may be skipped but sub directories of them may be imported.
626         This currently happens in web-platform-tests repo.
627
628         * Scripts/webkitpy/w3c/test_downloader.py:
629         (TestDownloader._add_test_suite_paths): Removing tests_directory option.
630         (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
631         (TestDownloader.copy_tests.should_copy_dir):
632         (TestDownloader.copy_tests.should_copy_file):
633         * Scripts/webkitpy/w3c/test_importer_unittest.py:
634         (TestImporterTest.test_tests_directory): Deleted.
635         (TestImporterTest.test_skip_test_import): Added.
636
637 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
638
639         Make validate-committer-lists show inactive reviewers
640         https://bugs.webkit.org/show_bug.cgi?id=163193
641
642         Reviewed by Sam Weinig.
643         
644         In preparation for updating contributors.json with the WebKit policy of retiring
645         inactive reviewers, make validate-committer-lists show the list of reviewers who
646         have not reviewed in the past year.
647         
648         This list is computed by grepping the output of 'git log --since=1.year" for
649         the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
650         which looks for full names, aliases, irc nicks and email addresses.
651         
652         Support for aliases is added to Contributor. Aliases are alternates
653         or misspellings of the reviewer's name. Some common aliases were added to
654         contributors.json by manual examination of "Reviewed by" lines.
655
656         * Scripts/validate-committer-lists:
657         (CommitterListFromGit.possibly_expired_committers):
658         (CommitterListFromGit):
659         (CommitterListFromGit.possibly_inactive_reviewers):
660         (CommitterListFromGit.print_possibly_expired_committers):
661         (CommitterListFromGit.print_possibly_inactive_reviewers):
662         * Scripts/webkitpy/common/config/committers.py:
663         (Contributor.__init__):
664         (Contributor.contains_string):
665         (Contributor.mentioned_in_text):
666         (Contributor.as_dict):
667         (Committer.__init__):
668         (Reviewer.__init__):
669         (CommitterList.load_json):
670         * Scripts/webkitpy/common/config/contributors.json:
671
672 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
673
674         Convert contributors.json to a flat list
675         https://bugs.webkit.org/show_bug.cgi?id=163183
676
677         Reviewed by Darin Adler.
678         
679         Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
680         and moving that data to a "status" property on each contributor.
681
682         * Scripts/webkitpy/common/config/committers.py:
683         (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
684         (Contributor.as_dict): Include status in the dict.
685         (CommitterList.__init__): Clean up to make the testing code path more explicit.
686         (CommitterList.load_json):
687         (CommitterList.load_test_data):
688         (CommitterList.as_json):
689         (Contributor.__unicode__): Deleted.
690         * Scripts/webkitpy/common/config/contributors.json:
691         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
692         (IRCCommandTest.test_whois): The ordering here is now alphabetical.
693
694 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
695
696         [CMake] CMake does not support the dep files for implicit dependency
697         https://bugs.webkit.org/show_bug.cgi?id=161433
698
699         Reviewed by Brent Fulgham.
700
701         Created a Perl script to generate all IDL bindings for CMake.
702         This script can regenerate outdated bindings by based on the
703         supplemental dependency and dep files created by
704         '--write-dependencies' switch of generate-bindings.pl.
705
706         add_custom_target is used to invoke the script instead of
707         add_custom_command because Ninja deletes all output files before
708         executing the command in case of add_custom_command.
709
710         USES_TERMINAL option of add_custom_target has two effects:
711         1) Not buffering output of the command
712         2) Invoking the command in the special Ninja pool which inhibits parallel build
713         One needs to use CMake 3.2 or later to enable this feature.
714
715         * DumpRenderTree/CMakeLists.txt: Specified a target name for
716         GENERATE_BINDINGS. Added dependency for the target.
717         * WebKitTestRunner/CMakeLists.txt: Ditto.
718
719 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
720
721         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
722         https://bugs.webkit.org/show_bug.cgi?id=163177
723
724         Follow-up fix.
725         
726         For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
727         Rename it to as_dict().
728
729         * Scripts/webkitpy/common/config/committers.py:
730         (Contributor.as_dict):
731         (CommitterList._contributor_list_to_dict):
732         (Contributor.__dict__): Deleted.
733
734 2016-10-08  Simon Fraser  <simon.fraser@apple.com>
735
736         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
737         https://bugs.webkit.org/show_bug.cgi?id=163177
738
739         Reviewed by Ryosuke Niwa.
740         
741         Make it possible to round-trip contributors.json through CommitterList, so we can
742         support writing out contributors.json in canonical format. This requires saving
743         the case-preserved email and expertise in Contributor. CommitterList also needs
744         to be able to generate the "exclusive" lists, since it currently uses lists
745         that are the union of, say, committers and reviewers.
746         
747         If contributors.json is malformed (invalid JSON), catch the Exception, report it
748         and exit rather than allowing the exception to propagate. With an invalid file,
749         an exception would be thrown before the JSON style checker reached this file, so
750         the error was not correctly reported.
751         
752         Add style/checker/committer.py for checking that committers.json has the canonical format.
753         
754         Add support to validate-committer-lists to dump out the canonical json (-d) or update
755         the file in-place (-c).
756
757         * Scripts/validate-committer-lists:
758         (CommitterListFromGit._print_three_column_row):
759         (CommitterListFromGit.possibly_expired_committers):
760         (CommitterListFromGit):
761         (CommitterListFromGit.print_possibly_expired_committers):
762         (main):
763         * Scripts/webkitpy/common/config/committers.py:
764         (Contributor.__init__):
765         (Contributor.__dict__):
766         (Committer.__init__):
767         (Reviewer.__init__):
768         (CommitterList.load_json):
769         (CommitterList):
770         (CommitterList._contributor_list_to_dict):
771         (CommitterList.as_json):
772         (CommitterList.reformat_in_place):
773         (CommitterList._exclusive_contributors):
774         (CommitterList._exclusive_committers):
775         (Contributor.matches_glob): Deleted.
776         (CommitterList.contributors): Deleted.
777         * Scripts/webkitpy/common/config/contributors.json:
778         * Scripts/webkitpy/style/checker.py:
779         (CheckerDispatcher._create_checker):
780         * Scripts/webkitpy/style/checkers/contributors.py: Added.
781         (ContributorsChecker):
782         (ContributorsChecker.__init__):
783         (ContributorsChecker.check):
784         (ContributorsChecker._unidiff_output):
785
786 2016-10-06  Darin Adler  <darin@apple.com>
787
788         Next step on moving to modern way to return DOM exceptions
789         https://bugs.webkit.org/show_bug.cgi?id=163016
790
791         Reviewed by Ryosuke Niwa.
792
793         * Scripts/do-webcore-rename: Add proposed name change of setDOMException
794         to propagateException, since this function is primarily used to take an
795         exception already effectively "thrown" by setting an ExceptionCode out
796         argument and propagate it into the JavaScript engine's exception machinery.
797
798 2016-10-07  Alex Christensen  <achristensen@webkit.org>
799
800         Non-special URL fragments should percent-encode non-ASCII characters
801         https://bugs.webkit.org/show_bug.cgi?id=163153
802
803         Reviewed by Tim Horton.
804
805         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
806         (TestWebKitAPI::TEST_F):
807
808 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
809
810         Build fix for “Move functionality common to Darwin ports into a base class”
811         https://bugs.webkit.org/show_bug.cgi?id=160709
812
813         Unreviewed build fix.
814
815         * Scripts/webkitpy/port/ios.py:
816         (IOSSimulatorPort._get_crash_log): Added iOS implementation.
817         * Scripts/webkitpy/port/mac.py:
818         (MacPort._get_crash_log): Added Mac implementation.
819
820 2016-10-07  Chelsea Pugh  <cpugh@apple.com>
821
822         Unreviewed. Added myself to the list of committers.
823
824         * Scripts/webkitpy/common/config/contributors.json:
825
826 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
827
828         Move functionality common to Darwin ports into a base class
829         https://bugs.webkit.org/show_bug.cgi?id=160709
830
831         Reviewed by Darin Adler.
832
833         * Scripts/webkitpy/port/apple.py:
834         (ApplePort.determine_full_port_name): Specific iOS port check.
835         (ApplePort.__init__): Move leak detector to DarwinPort.
836         (ApplePort._make_leak_detector): Moved to DarwinPort.
837         (ApplePort.supports_per_test_timeout): Moved to Port.
838         (ApplePort.check_for_leaks): Moved to DarwinPort.
839         (ApplePort.print_leaks_summary): Moved to DarwinPort.
840         (ApplePort._path_to_webcore_library): Moved to DarwinPort.
841         (ApplePort.show_results_html_file): Moved to DarwinPort.
842         (ApplePort._merge_crash_logs): Moved to DarwinPort.
843         (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
844         (ApplePort._get_crash_log): Moved to DarwinPort.
845         (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
846         (ApplePort.sample_process): Moved to DarwinPort.
847         (ApplePort.sample_file_path): Moved to DarwinPort.
848         (ApplePort.look_for_new_samples): Moved to DarwinPort.
849         * Scripts/webkitpy/port/base.py:
850         (Port.supports_per_test_timeout): Return true for all ports.
851         * Scripts/webkitpy/port/darwin.py: Added.
852         (DarwinPort): Shared iOS and Mac functions.
853         * Scripts/webkitpy/port/darwin_testcase.py: Added.
854         (DarwinTest): Shared iOS and Mac testing.
855         * Scripts/webkitpy/port/efl.py:
856         (EflPort):
857         (EflPort.supports_per_test_timeout): Moved to Port.
858         * Scripts/webkitpy/port/gtk.py:
859         (GtkPort._driver_class):
860         (GtkPort):
861         (GtkPort.supports_per_test_timeout): Moved to Port.
862         * Scripts/webkitpy/port/ios.py:
863         (IOSPort):
864         (IOSPort.operating_system):
865         (IOSSimulatorPort):
866         (IOSSimulatorPort.__init__): Inherits from DarwinPort.
867         (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
868         (IOSSimulatorPort._get_crash_log): Deleted.
869         (IOSSimulatorPort.xcrun_find): Deleted.
870         * Scripts/webkitpy/port/ios_unittest.py: Added.
871         (iosTest): Unit tests for the iOS port.
872         * Scripts/webkitpy/port/mac.py:
873         (MacPort):
874         (MacPort.__init__): Inherits from DarwinPort.
875         (MacPort._port_specific_expectations_files): Moved to DarwinPort.
876         (MacPort.make_command): Moved to DarwinPort.
877         (MacPort._get_crash_log): Moved to DarwinPort.
878         (MacPort.nm_command): Moved to DarwinPort.
879         * Scripts/webkitpy/port/mac_unittest.py:
880         (MacTest):
881         (MacTest.test_sdk_name): Added test.
882         (MacTest.test_xcrun): Added test.
883         (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
884         (MacTest.test_default_timeout_ms): Moved to DarwinTest.
885         (MacTest.assert_name): Moved to DarwinTest.
886         (MacTest.test_helper_starts): Moved to DarwinTest.
887         (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
888         (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
889         (MacTest.test_spindump): Moved to DarwinTest.
890         (MacTest.test_sample_process): Moved to DarwinTest.
891         (MacTest.test_sample_process_exception): Moved to DarwinTest.
892         * Scripts/webkitpy/port/port_testcase.py:
893         (PortTestCase):
894         (PortTestCase.test_diff_image): Added is_simulator flag.
895         (PortTestCase.test_diff_image): Skip test if on a simulator.
896         (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
897         * Scripts/webkitpy/port/win.py:
898         (WinPort):
899         (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
900         (WinPort.sample_process): Ditto.
901         (WinPort._make_leak_detector): Ditto.
902         (WinPort.check_for_leaks): Ditto.
903         (WinPort.print_leaks_summary): Ditto.
904         (WinPort._path_to_webcore_library): Ditto.
905
906 2016-10-07  Anders Carlsson  <andersca@apple.com>
907
908         Get rid of WKPageSetSession
909         https://bugs.webkit.org/show_bug.cgi?id=163129
910
911         Reviewed by Tim Horton.
912
913         Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
914
915         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
916         (TestWebKitAPI::TEST):
917
918 2016-10-07  Andreas Kling  <akling@apple.com>
919
920         [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
921         <https://webkit.org/b/163098>
922         <rdar://problem/28663488>
923
924         Reviewed by Antti Koivisto.
925
926         Add an API test that puts a 10-subframe page into the page cache, then loads other pages
927         until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
928         callbacks for all the subframes.
929
930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
931         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
932         (TestWebKitAPI::didFinishLoadForFrame):
933         (TestWebKitAPI::setPageLoaderClient):
934         (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
935         (TestWebKitAPI::setInjectedBundleClient):
936         (TestWebKitAPI::TEST):
937         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
938         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
939         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
940         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
941         * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
942
943 2016-10-07  Emanuele Aina  <emanuele.aina@collabora.com>
944
945         Replace bug URL placeholders independently of the short desc one
946         https://bugs.webkit.org/show_bug.cgi?id=161684
947
948         Reviewed by Darin Adler.
949
950         Instead of adding the bug URL when replacing the short description
951         placeholder and then ignoring the bug URL placeholder, use the former
952         to set the short description and the latter for the bug URL.
953         This means that developers can fully prepare the changelog with short
954         and long description before submission leaving the bug placeholder in
955         place, and the changelog machinery will make sure to replace the
956         latter with the URL of the newly created bug while submitting.
957
958         Note that this also means that the short description placeholder alone
959         no longer causes the bug URL to be added.
960
961         * Scripts/webkitpy/common/checkout/changelog.py:
962         (ChangeLog.set_short_description_and_bug_url):
963         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
964         (test_set_short_description_and_bug_url):
965
966 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
967
968         Style Checking Error when Objective C Blocks passed as Argument
969         https://bugs.webkit.org/show_bug.cgi?id=162463
970
971         Reviewed by Darin Adler.
972
973         * Scripts/webkitpy/style/checkers/cpp.py:
974         (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
975         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
976         (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 
977
978 2016-10-07  Philippe Normand  <pnormand@igalia.com>
979
980         [GTK] Docs build failure
981         https://bugs.webkit.org/show_bug.cgi?id=163102
982
983         Reviewed by Carlos Garcia Campos.
984
985         * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
986
987 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
988
989         check-webkit-style: Enable the legal/copyright rule for cpp/h files
990         https://bugs.webkit.org/show_bug.cgi?id=162707
991
992         Reviewed by Darin Adler.
993
994         * Scripts/webkitpy/style/checker.py:
995         Enable this rule by default.
996
997 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
998
999         Header guard style should be updated to be "#pragma once"
1000         https://bugs.webkit.org/show_bug.cgi?id=159785
1001
1002         Reviewed by Darin Adler.
1003
1004         * Scripts/webkitpy/style/checkers/cpp.py:
1005         (check_for_header_guard):
1006         (_process_lines):
1007         Simplify header_guard check to warn for a missing #pragma once
1008         in header files. For legacy files that contain an #ifndef only
1009         warn if the #ifndef line itself is changing.
1010
1011         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1012         (CppStyleTestBase.perform_header_guard_check):
1013         (CppStyleTestBase.assert_header_guard):
1014         Helpers for enabling just this warning.
1015
1016         (CppStyleTest.test_build_header_guard):
1017         Test different header guard cases.
1018
1019         * Scripts/webkitpy/style/error_handlers.py:
1020         (DefaultStyleErrorHandler.should_line_be_checked):
1021         Always allow warnings that output for "line 0" which won't be in
1022         the list of modified lines that are 1-based.
1023
1024 2016-10-06  Commit Queue  <commit-queue@webkit.org>
1025
1026         Unreviewed, rolling out r206713.
1027         https://bugs.webkit.org/show_bug.cgi?id=163097
1028
1029         triggers apparent codegen bug on ARM 32-bit (Requested by smfr
1030         on #webkit).
1031
1032         Reverted changeset:
1033
1034         "Support transitions/animations of background-position with
1035         right/bottom-relative values"
1036         https://bugs.webkit.org/show_bug.cgi?id=162048
1037         http://trac.webkit.org/changeset/206713
1038
1039 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1040
1041         URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
1042         https://bugs.webkit.org/show_bug.cgi?id=163089
1043
1044         Reviewed by Tim Horton.
1045
1046         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1047         (TestWebKitAPI::checkURL):
1048         (TestWebKitAPI::TEST_F):
1049
1050 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1051
1052         Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
1053         https://bugs.webkit.org/show_bug.cgi?id=163071
1054
1055         Reviewed by Tim Horton.
1056
1057         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1058         (TestWebKitAPI::TEST_F):
1059
1060 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1061
1062         URLParser should parse file URLs with ports consistently
1063         https://bugs.webkit.org/show_bug.cgi?id=163075
1064
1065         Reviewed by Brady Eidson.
1066
1067         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1068         (TestWebKitAPI::TEST_F):
1069
1070 2016-10-06  John Wilander  <wilander@apple.com>
1071
1072         Update Resource Load Statistics
1073         https://bugs.webkit.org/show_bug.cgi?id=162811
1074
1075         Reviewed by Alex Christensen.
1076
1077         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
1078             Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
1079
1080 2016-10-05  Philippe Normand  <pnormand@igalia.com>
1081
1082         [GStreamer][OWR] GL rendering support
1083         https://bugs.webkit.org/show_bug.cgi?id=162972
1084
1085         Reviewed by Žan Doberšek.
1086
1087         When GStreamer-GL is enabled the GL context needs to be properly passed
1088         to the GStreamer pipeline running within the OpenWebRTC video renderer.
1089         This is now supported using a new OpenWebRTC API that allows the
1090         renderer to request the context from the application using a callback
1091         registered within the renderer.
1092
1093         * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
1094         owr_video_renderer_set_request_context_callback API added
1095         recently.
1096
1097 2016-10-05  Youenn Fablet  <youenn@apple.com>
1098
1099         Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
1100         https://bugs.webkit.org/show_bug.cgi?id=162960
1101
1102         Reviewed by Alex Christensen.
1103
1104         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1105         (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
1106         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1107         (WriteData): Ditto.
1108
1109 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1110
1111         URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
1112         https://bugs.webkit.org/show_bug.cgi?id=162991
1113
1114         Reviewed by Saam Barati.
1115
1116         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1117         (TestWebKitAPI::TEST_F):
1118
1119 2016-10-05  Tim Horton  <timothy_horton@apple.com>
1120
1121         Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
1122         https://bugs.webkit.org/show_bug.cgi?id=162955
1123         <rdar://problem/27659173>
1124
1125         Reviewed by Simon Fraser.
1126
1127         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1128         (-[SnapshotTestWKWebView init]):
1129         (forceRepaintCallback):
1130         (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
1131         (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
1132         (TEST):
1133         (makeRedSquareView):
1134         Add a test that restoring session state into a web view without navigating,
1135         then explicitly snapshotting and navigating away, leaves the original snapshot alone.
1136
1137         Adjust the existing test, as well, to ensure that it will reliably fail
1138         if the feature is broken. Use an explicitly added and removed red square
1139         instead of scrolling, because we can't scroll in the restore-without-navigating case.
1140
1141         Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
1142         and isn't necessary; instead just multiply the expected value by the page scale.
1143
1144         (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
1145         * TestWebKitAPI/mac/TestWKWebViewMac.h:
1146         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1147         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1148         Reorganize to reduce duplication.
1149
1150 2016-10-05  Tim Horton  <timothy_horton@apple.com>
1151
1152         Make it possible to test ViewSnapshotStore behaviors
1153         https://bugs.webkit.org/show_bug.cgi?id=162983
1154
1155         Reviewed by Simon Fraser.
1156
1157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1158         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
1159         (-[SnapshotTestWKWebView init]):
1160         (-[SnapshotTestWKWebView loadPageNamed:]):
1161         (imagesAreEqual):
1162         Add tests for existing basic snapshotting behavior:
1163
1164         - a back-forward item shouldn't have a snapshot
1165           until it is navigated away from
1166
1167         - causing a back-forward item to fall out of the
1168           back-forward list should remove the snapshot
1169
1170         - calling the explicit snapshotting SPI, then navigating away from the page,
1171           should result in the snapshot being retaken
1172
1173 2016-10-05  Chris Dumez  <cdumez@apple.com>
1174
1175         KeyboardEvent.getModifierState() should support "CapsLock" modifier
1176         https://bugs.webkit.org/show_bug.cgi?id=162861
1177
1178         Reviewed by Darin Adler.
1179
1180         Add support for 'capsLockKey' modifier for EventSender.keyDown() so
1181         that we can test this new modifier support for layout tests.
1182
1183         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1184         (TestWebKitAPI::modifierFlagsForWKModifiers):
1185         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1186         (WTR::parseModifier):
1187         * WebKitTestRunner/mac/EventSenderProxy.mm:
1188         (WTR::buildModifierFlags):
1189
1190 2016-10-05  Jeremy Jones  <jeremyj@apple.com>
1191
1192         Add MobileMiniBrowser tests for control center and looping fullscreen.
1193         https://bugs.webkit.org/show_bug.cgi?id=162748
1194
1195         Reviewed by Jer Noble.
1196
1197         Refactor existing MobileMiniBrowserTests and add new tests for 
1198         - fullscreen rotation
1199         - fullscreen looping (failing)
1200         - control center interruption (failing)
1201
1202         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1203         * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
1204         * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
1205         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1206         (-[MobileMiniBrowserUITests setUp]):
1207         (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
1208         (-[MobileMiniBrowserUITests loadURL:]):
1209         (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
1210         (-[MobileMiniBrowserUITests ensureFullscreenControls]):
1211         (-[MobileMiniBrowserUITests timeForTimeString:]):
1212         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1213         (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
1214         (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
1215         (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
1216         (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
1217
1218 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1219
1220         URLParser should correctly strip unnecessary 0's in IPv6 addresses
1221         https://bugs.webkit.org/show_bug.cgi?id=162979
1222
1223         Reviewed by Brady Eidson.
1224
1225         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1226         (TestWebKitAPI::TEST_F):
1227
1228 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1229
1230         UTF-8 encode queries of nonspecial and websocket schemes
1231         https://bugs.webkit.org/show_bug.cgi?id=162956
1232
1233         Reviewed by Geoffrey Garen and Brady Eidson.
1234
1235         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1236         (TestWebKitAPI::TEST_F):
1237
1238 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1239
1240         Prepare to enable URLParser
1241         https://bugs.webkit.org/show_bug.cgi?id=162974
1242
1243         Reviewed by Brady Eidson.
1244
1245         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1246         (TestWebKitAPI::TEST_F):
1247         Added some tests that are unrelated to the code change, but these are
1248         reflected in changed LayoutTest results when enabling the URLParser,
1249         and they weren't in the URLParser tests yet.  They should be.
1250
1251 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
1252
1253         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
1254         https://bugs.webkit.org/show_bug.cgi?id=162903
1255
1256         Reviewed by Alex Christensen.
1257
1258         Rename build guards for the remaining implementation of the legacy EME API
1259         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
1260         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
1261
1262         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
1263         ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
1264         throwing up style checker errors.
1265
1266 2016-10-04  Andy Estes  <aestes@apple.com>
1267
1268         [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
1269         https://bugs.webkit.org/show_bug.cgi?id=162950
1270         <rdar://problem/23759114>
1271
1272         Reviewed by Brady Eidson.
1273
1274         Added a new API test.
1275
1276         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
1277         initialization of static bools.
1278         (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
1279         QuickLook.CancelNavigationAfterResponse.
1280         (TEST): Added QuickLook.CancelNavigationAfterResponse.
1281         (-[QuickLookDecidePolicyDelegate
1282         webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
1283         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
1284         isDone to true.
1285
1286 2016-10-04  Ryosuke Niwa  <rniwa@webkit.org>
1287
1288         Add the support for running ES6SampleBench to run-benchmark
1289         https://bugs.webkit.org/show_bug.cgi?id=162890
1290
1291         Reviewed by Saam Barati.
1292
1293         Added the support for running ES6SampleBench as "es6bench".
1294         e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
1295
1296         Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
1297         for the total of 20 iterations.
1298
1299         * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
1300         * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
1301         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1302         (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
1303         removing it if it's present.
1304
1305 2016-10-04  Simon Fraser  <simon.fraser@apple.com>
1306
1307         [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
1308         https://bugs.webkit.org/show_bug.cgi?id=162934
1309
1310         Reviewed by Dean Jackson.
1311
1312         With this change, a test can describe a user gesture in an "event stream", which is
1313         some JSON describing an array of events with their underlying touches. The added
1314         test describes a single tap.
1315         
1316         The implementation fires up an NSThread, and sleeps the thread between events to dispatch
1317         them at close to real time.
1318         
1319         In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
1320
1321         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1322         (WTR::UIScriptController::sendEventStream):
1323         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1324         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1325         (WTR::UIScriptController::sendEventStream):
1326         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1327         * WebKitTestRunner/ios/HIDEventGenerator.h:
1328         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1329         (transducerTypeFromString):
1330         (phaseFromString):
1331         (-[HIDEventGenerator eventMaskFromEventInfo:]):
1332         (-[HIDEventGenerator touchFromEventInfo:]):
1333         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
1334         (-[HIDEventGenerator dispatchEventWithInfo:]):
1335         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1336         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1337         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1338         (WTR::UIScriptController::sendEventStream):
1339
1340 2016-10-04  Megan Gardner  <megan_gardner@apple.com>
1341
1342         Add Megan to contributor's list
1343         https://bugs.webkit.org/show_bug.cgi?id=162944
1344
1345         Reviewed by Tim Horton.
1346
1347         Add Megan to the contributor's lists so that her e-mail autocompletes for CC
1348
1349         * Scripts/webkitpy/common/config/contributors.json:
1350
1351 2016-10-04  Alex Christensen  <achristensen@webkit.org>
1352
1353         Add tests verifying non-special URL hosts are parsed according to spec
1354         https://bugs.webkit.org/show_bug.cgi?id=162885
1355
1356         Reviewed by Sam Weinig.
1357
1358         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1359         (TestWebKitAPI::TEST_F):
1360
1361 2016-10-04  Anders Carlsson  <andersca@apple.com>
1362
1363         Properly kill web processes in the launching state
1364         https://bugs.webkit.org/show_bug.cgi?id=162938
1365
1366         Reviewed by Tim Horton.
1367
1368         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1369         Enable this test again.
1370
1371 2016-10-04  Alex Christensen  <achristensen@webkit.org>
1372
1373         URLParser: query-only URLs relative to file URLs should just add a query
1374         https://bugs.webkit.org/show_bug.cgi?id=162888
1375
1376         Reviewed by Tim Horton.
1377
1378         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1379         (TestWebKitAPI::TEST_F):
1380
1381 2016-10-04  Alex Christensen  <achristensen@webkit.org>
1382
1383         URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
1384         https://bugs.webkit.org/show_bug.cgi?id=162909
1385
1386         Reviewed by Tim Horton.
1387
1388         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1389         (TestWebKitAPI::TEST_F):
1390
1391 2016-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1392
1393         [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
1394         https://bugs.webkit.org/show_bug.cgi?id=162916
1395
1396         Reviewed by Filip Pizlo.
1397
1398         * DumpRenderTree/CMakeLists.txt:
1399
1400 2016-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1401
1402         Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
1403         https://bugs.webkit.org/show_bug.cgi?id=162766
1404         <rdar://problem/28533523>
1405
1406         Reviewed by Jer Noble.
1407
1408         Adds new tests and tweaks existing tests to verify last updated Now Playing information.
1409
1410         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1411         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
1412         (TestWebKitAPI::TEST):
1413         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
1414         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
1415
1416 2016-10-03  Alex Christensen  <achristensen@webkit.org>
1417
1418         URLParser should ignore tabs at all locations
1419         https://bugs.webkit.org/show_bug.cgi?id=162836
1420
1421         Reviewed by Geoffrey Garen.
1422
1423         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1424         (TestWebKitAPI::checkURL):
1425         (TestWebKitAPI::checkRelativeURL):
1426         (TestWebKitAPI::checkURLDifferences):
1427         (TestWebKitAPI::checkRelativeURLDifferences):
1428         (TestWebKitAPI::TEST_F):
1429
1430 2016-10-03  Alex Christensen  <achristensen@webkit.org>
1431
1432         URLParser: fragment-only URLs relative to file URLs should just add a fragment
1433         https://bugs.webkit.org/show_bug.cgi?id=162871
1434
1435         Reviewed by Geoffrey Garen.
1436
1437         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1438         (TestWebKitAPI::TEST_F):
1439
1440 2016-10-03  Per Arne Vollan  <pvollan@apple.com>
1441
1442         [Win] DRT temp folder is not used.
1443         https://bugs.webkit.org/show_bug.cgi?id=162863
1444
1445         Reviewed by Alex Christensen.
1446
1447         Convert DRT temp folder to DOS path, which DRT can use.
1448
1449         * Scripts/webkitpy/port/driver.py:
1450         (Driver._setup_environ_for_driver):
1451
1452 2016-10-03  Alex Christensen  <achristensen@webkit.org>
1453
1454         URLParser: empty relative URLs should not copy fragment from the base URL
1455         https://bugs.webkit.org/show_bug.cgi?id=162864
1456
1457         Reviewed by Chris Dumez.
1458
1459         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1460         (TestWebKitAPI::TEST_F):
1461
1462 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1463
1464         [SOUP] Cleanup persistent credential storage code
1465         https://bugs.webkit.org/show_bug.cgi?id=162777
1466
1467         Reviewed by Alex Christensen.
1468
1469         Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
1470
1471         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1472         (testWebViewAuthenticationStorage):
1473
1474 2016-10-02  Darin Adler  <darin@apple.com>
1475
1476         Rename ExceptionCode-based exception handling to "legacy"
1477         https://bugs.webkit.org/show_bug.cgi?id=162859
1478
1479         Reviewed by Chris Dumez.
1480
1481         * Scripts/do-webcore-rename: Updated script to do this round of renames.
1482
1483 2016-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1484
1485         Media controls for Soundcloud easily falls out of sync with what's actually playing
1486         https://bugs.webkit.org/show_bug.cgi?id=162843
1487         <rdar://problem/28176874>
1488
1489         Reviewed by Beth Dakin.
1490
1491         Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
1492         message handling logic to support having multiple message-handler mappings.
1493
1494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1495         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1496         (TestWebKitAPI::TEST):
1497         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
1498         * TestWebKitAPI/mac/TestWKWebViewMac.h:
1499         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1500         (-[TestMessageHandler addMessage:withHandler:]):
1501         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1502         (-[TestWKWebView performAfterReceivingMessage:action:]):
1503         (-[TestWKWebView performAfterLoading:]):
1504         (-[TestMessageHandler initWithMessage:handler:]): Deleted.
1505
1506 2016-09-30  Alex Christensen  <achristensen@webkit.org>
1507
1508         Fix off-by-one error in URLParser::parseIPv4Host
1509         https://bugs.webkit.org/show_bug.cgi?id=162789
1510
1511         Reviewed by Tim Horton.
1512
1513         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1514         (TestWebKitAPI::TEST_F):
1515
1516 2016-09-30  Alex Christensen  <achristensen@webkit.org>
1517
1518         URLParser: parsing a URL with an empty host and a colon should fail
1519         https://bugs.webkit.org/show_bug.cgi?id=162795
1520
1521         Reviewed by Tim Horton.
1522
1523         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1524         (TestWebKitAPI::TEST_F):
1525
1526 2016-09-30  Alex Christensen  <achristensen@webkit.org>
1527
1528         URLParser: handle syntax violations in non-UTF-8 encoded queries
1529         https://bugs.webkit.org/show_bug.cgi?id=162770
1530
1531         Reviewed by Tim Horton.
1532
1533         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1534         (TestWebKitAPI::checkURL):
1535         (TestWebKitAPI::TEST_F):
1536         Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
1537         insert-tab-at-each-location verification that syntax violations are handled correctly.
1538
1539 2016-09-30  Megan Gardner  <megan_gardner@apple.com>
1540
1541         Make it possible to test web-related user-interface features
1542         https://bugs.webkit.org/show_bug.cgi?id=162657
1543
1544         Reviewed by Simon Fraser.
1545
1546         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1547         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1548         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
1549         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1550         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1551         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1552         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
1553         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1554         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1555         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1556         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
1557
1558 2016-09-29  Jiewen Tan  <jiewen_tan@apple.com>
1559
1560         Expose CryptoKey to web workers
1561         https://bugs.webkit.org/show_bug.cgi?id=162640
1562         <rdar://problem/28182204>
1563
1564         Reviewed by Brent Fulgham.
1565
1566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1567         * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
1568         (TestWebKitAPI::TEST_F):
1569         Add API tests for SerializedCryptoKeyWrap APIs.
1570
1571 2016-09-29  Alex Christensen  <achristensen@webkit.org>
1572
1573         Fix syntax violation handling in IPv4 address parsing
1574         https://bugs.webkit.org/show_bug.cgi?id=162756
1575
1576         Reviewed by Tim Horton.
1577
1578         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1579         (TestWebKitAPI::TEST_F):
1580
1581 2016-09-29  Alex Christensen  <achristensen@webkit.org>
1582
1583         URLParser should correctly parse ports with leading 0's
1584         https://bugs.webkit.org/show_bug.cgi?id=162752
1585
1586         Reviewed by Tim Horton.
1587
1588         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1589         (TestWebKitAPI::TEST_F):
1590
1591 2016-09-29  Alex Christensen  <achristensen@webkit.org>
1592
1593         URLParser: make parsing invalid IPv4 addresses more robust and correct
1594         https://bugs.webkit.org/show_bug.cgi?id=162746
1595
1596         Reviewed by Tim Horton.
1597
1598         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1599         (TestWebKitAPI::TEST_F):
1600
1601 2016-09-29  Alex Christensen  <achristensen@webkit.org>
1602
1603         URLParser: IPv6 addresses followed by a colon are invalid
1604         https://bugs.webkit.org/show_bug.cgi?id=162747
1605
1606         Reviewed by Tim Horton.
1607
1608         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1609         (TestWebKitAPI::TEST_F):
1610
1611 2016-09-29  Alexey Proskuryakov  <ap@apple.com>
1612
1613         Make WKTR short timeout dynamic
1614         https://bugs.webkit.org/show_bug.cgi?id=162733
1615
1616         Reviewed by Alex Christensen.
1617
1618         WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
1619         which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
1620         fairly time consuming - e.g. launching Networking process on demand.
1621         These may take longer under load, especially with GuardMalloc.
1622
1623         * WebKitTestRunner/TestController.cpp:
1624         (WTR::TestController::resetStateToConsistentValues):
1625         (WTR::TestController::reattachPageToWebProcess):
1626         * WebKitTestRunner/TestController.h:
1627         * WebKitTestRunner/TestInvocation.cpp:
1628         (WTR::TestInvocation::shortTimeout):
1629         (WTR::TestInvocation::invoke):
1630         (WTR::TestInvocation::dumpResults):
1631
1632         * WebKitTestRunner/TestInvocation.h:
1633         (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
1634
1635 2016-09-29  Alex Christensen  <achristensen@webkit.org>
1636
1637         URLParser should fail to parse unclosed IPv6 addresses
1638         https://bugs.webkit.org/show_bug.cgi?id=162715
1639
1640         Reviewed by Tim Horton.
1641
1642         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1643         (TestWebKitAPI::TEST_F):
1644
1645 2016-09-29  Alex Christensen  <achristensen@webkit.org>
1646
1647         URLParser should ignore tabs at all possible locations
1648         https://bugs.webkit.org/show_bug.cgi?id=162711
1649
1650         Reviewed by Tim Horton.
1651
1652         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1653         (TestWebKitAPI::ExpectedParts::isInvalid):
1654         (TestWebKitAPI::checkURL):
1655         (TestWebKitAPI::TEST_F):
1656
1657 2016-09-29  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1658
1659         [EFL] Add search button to url bar in MiniBrowser
1660         https://bugs.webkit.org/show_bug.cgi?id=162716
1661
1662         Reviewed by Michael Catanzaro.
1663
1664         As a bug title, it would be good to add a search button to URL bar.
1665         Additionally this patch changes color of button to recognize the buttons.
1666
1667         * MiniBrowser/efl/main.c:
1668         (_search_button_clicked_cb):
1669         (_create_toolbar_button):
1670         (window_create):
1671         (create_toolbar_button): Deleted.
1672
1673 2016-09-28  Tim Horton  <timothy_horton@apple.com>
1674
1675         API test WebKit2.AutoLayoutIntegration is a flaky timeout
1676         https://bugs.webkit.org/show_bug.cgi?id=160284
1677
1678         Reviewed by Dan Bernstein.
1679
1680         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1681         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1682         (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
1683         (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
1684         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
1685         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
1686         (TEST):
1687         Make the autolayout tests a bit more flexible regarding the ordering of
1688         invalidateIntrinsicContentSize, to avoid a race between the load
1689         completing and the invalidation.
1690
1691         Also, move the newly added test to use its own WKWebView, since once in a
1692         while we get a first layout notification from the previous page, causing the test to fail.
1693
1694         Un-disable the tests, which now run without any flakes for me with quite a few iterations.
1695
1696 2016-09-28  Alex Christensen  <achristensen@webkit.org>
1697
1698         URLParser should properly handle unexpected periods and overflows in IPv4 addresses
1699         https://bugs.webkit.org/show_bug.cgi?id=162655
1700
1701         Reviewed by Geoffrey Garen.
1702
1703         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1704         (TestWebKitAPI::TEST_F):
1705
1706 2016-09-28  Ryan Haddad  <ryanhaddad@apple.com>
1707
1708         Disable flaky API test WebKit2.AutoLayoutIntegration.
1709         https://bugs.webkit.org/show_bug.cgi?id=160284
1710
1711         Unreviewed test gardening.
1712
1713         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1714         (TEST):
1715
1716 2016-09-28  Alex Christensen  <achristensen@webkit.org>
1717
1718         URLParser should ignore tabs in authority
1719         https://bugs.webkit.org/show_bug.cgi?id=162694
1720
1721         Reviewed by Geoffrey Garen.
1722
1723         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1724         (TestWebKitAPI::TEST_F):
1725
1726 2016-09-28  Alex Christensen  <achristensen@webkit.org>
1727
1728         URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
1729         https://bugs.webkit.org/show_bug.cgi?id=162690
1730
1731         Reviewed by Geoffrey Garen.
1732
1733         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1734         (TestWebKitAPI::TEST_F):
1735
1736 2016-09-28  Alex Christensen  <achristensen@webkit.org>
1737
1738         URLParser should correctly canonicalize uppercase IPv6 addresses
1739         https://bugs.webkit.org/show_bug.cgi?id=162680
1740
1741         Reviewed by Tim Horton.
1742
1743         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1744         (TestWebKitAPI::TEST_F):
1745
1746 2016-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1747
1748         Adopt MediaRemote SPI to achieve desired Now Playing behavior
1749         https://bugs.webkit.org/show_bug.cgi?id=162658
1750         <rdar://problem/28499358>
1751
1752         Reviewed by Jer Noble.
1753
1754         Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
1755         mocking key window status for TestWKWebViews.
1756
1757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1758         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
1759         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1760         (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
1761         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
1762         (TestWebKitAPI::TEST):
1763         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
1764         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1765         (-[TestWKWebViewHostWindow isKeyWindow]):
1766         (-[TestWKWebViewHostWindow makeKeyWindow]):
1767         (-[TestWKWebViewHostWindow resignKeyWindow]):
1768
1769 2016-09-28  Per Arne Vollan  <pvollan@apple.com>
1770
1771         [Win] Compile fix.
1772         https://bugs.webkit.org/show_bug.cgi?id=162670
1773
1774         Reviewed by Brent Fulgham.
1775
1776         Make sure we include JavaScriptCore files from the forwarding headers folder.
1777         Otherwise we might get multiple definitions if a JSC file is included both
1778         from the forwarding headers folder and the JSC source folder, since
1779         #pragma once is used in the header files.
1780
1781         * DumpRenderTree/TestRunner.cpp:
1782
1783 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1784
1785         [GTK] Add Chrome UA quirk
1786         https://bugs.webkit.org/show_bug.cgi?id=162617
1787
1788         Reviewed by Carlos Garcia Campos.
1789
1790         Update test. This portion of the commit was actually unreviewed.
1791
1792         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
1793         (TestWebKitAPI::TEST):
1794
1795 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1796
1797         [GTK] Adjust OS X UA quirks list
1798         https://bugs.webkit.org/show_bug.cgi?id=162616
1799
1800         "Reviewed" by Carlos Garcia Campos.
1801
1802         Update test. This portion of the commit was actually unreviewed.
1803
1804         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
1805         (TestWebKitAPI::TEST):
1806
1807 2016-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1808
1809         [GTK] Switch to use GMenu internally in the context menu implementation
1810         https://bugs.webkit.org/show_bug.cgi?id=162603
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         Remove smart separators test, since that's now done automatically by GTK+.
1815
1816         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1817         (beforeAll):
1818         (testContextMenuWebExtensionMenu): Deleted.
1819
1820 2016-09-27  Alex Christensen  <achristensen@webkit.org>
1821
1822         Correctly parse URLs with the first tab in the fragment
1823         https://bugs.webkit.org/show_bug.cgi?id=162650
1824
1825         Reviewed by Saam Barati.
1826
1827         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1828         (TestWebKitAPI::TEST_F):
1829
1830 2016-09-27  Alex Christensen  <achristensen@webkit.org>
1831
1832         URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
1833         https://bugs.webkit.org/show_bug.cgi?id=162646
1834
1835         Reviewed by Saam Barati.
1836
1837         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1838         (TestWebKitAPI::TEST_F):
1839
1840 2016-09-27  Alex Christensen  <achristensen@webkit.org>
1841
1842         URLs with @ in the user should only search for the last @ until the end of the authority and host
1843         https://bugs.webkit.org/show_bug.cgi?id=162635
1844
1845         Reviewed by Geoffrey Garen.
1846
1847         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1848         (TestWebKitAPI::TEST_F):
1849
1850 2016-09-27  JF Bastien  <jfbastien@apple.com>
1851
1852         Speed up Heap::isMarkedConcurrently
1853         https://bugs.webkit.org/show_bug.cgi?id=162095
1854
1855         Reviewed by Filip Pizlo.
1856
1857         * TestWebKitAPI/CMakeLists.txt:
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WTF/Consume.cpp: Added.
1860         (testConsume):
1861         (TestWebKitAPI::TEST):
1862
1863 2016-09-26  Alex Christensen  <achristensen@webkit.org>
1864
1865         Implement URLParser::syntaxViolation
1866         https://bugs.webkit.org/show_bug.cgi?id=162593
1867
1868         Reviewed by Geoffrey Garen.
1869
1870         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1871         (TestWebKitAPI::TEST_F):
1872
1873 2016-09-27  Anders Carlsson  <andersca@apple.com>
1874
1875         Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real.
1876
1877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1878         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1879         (TestWebKitAPI::TEST):
1880
1881 2016-09-27  Anders Carlsson  <andersca@apple.com>
1882
1883         Try to fix the GTK+ build.
1884
1885         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1886         (TestWebKitAPI::TEST):
1887
1888 2016-09-27  Dan Bernstein  <mitz@apple.com>
1889
1890         [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
1891         https://bugs.webkit.org/show_bug.cgi?id=162577
1892         <rdar://problem/28481984>
1893
1894         Reviewed by Simon Fraser.
1895
1896         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1897         (WTR::UIScriptController::selectionRangeViewRects): Returns null.
1898
1899         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new
1900           selectionRangeViewRects attribute.
1901
1902         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1903         (WTR::UIScriptContext::jsContext): Added this public accessor.
1904
1905         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1906         (WTR::selectionRangeViewRects): Generic implementation that returns null.
1907         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1908
1909         * WebKitTestRunner/TestController.cpp:
1910         (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity
1911           option.
1912
1913         * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option.
1914
1915         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1916         (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity
1917           property based on the new option.
1918
1919         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1920         (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values.
1921
1922         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1923         (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls
1924           the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame
1925           dictionaries.
1926
1927 2016-09-27  Daniel Bates  <dabates@apple.com>
1928
1929         Cannot run dump-class-layout; dies with "global name 'lldb' is not defined"
1930         https://bugs.webkit.org/show_bug.cgi?id=162585
1931
1932         Reviewed by Simon Fraser.
1933
1934         Import the lldb module into the global namespace.
1935
1936         Currently dump-class-layout imports the lldb Python module using the import statement
1937         from the helper function import_lldb. The import statement imports the names of the
1938         specified module into the scope of import_lldb(); => the names imported from this
1939         module cannot be accessed outside the scope of import_lldb(). Other functions in
1940         this script assume that the lldb module was imported into the global scope. We should
1941         import the module lldb into the global scope, if it exists, so that these functions
1942         can find it. Otherwise, we should emit a human readable error message that explains
1943         that we failed to import the lldb module.
1944
1945         Also remove some unnecessary semicolon characters.
1946
1947         * Scripts/dump-class-layout:
1948         (import_lldb):
1949
1950 2016-09-27  Jer Noble  <jer.noble@apple.com>
1951
1952         Remove deprecated ENCRYPTED_MEDIA implementation.
1953         https://bugs.webkit.org/show_bug.cgi?id=161010
1954
1955         Reviewed by Eric Carlson.
1956
1957         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1958
1959 2016-09-27  Chris Dumez  <cdumez@apple.com>
1960
1961         [WK2] Navigating to a Blob URL does not trigger a download
1962         https://bugs.webkit.org/show_bug.cgi?id=162574
1963
1964         Reviewed by Darin Adler.
1965
1966         Add API that tests navigating to a Blob URL and checks that that the load
1967         properly gets converted into a download.
1968
1969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1970         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1971         (-[BlobDownloadDelegate _downloadDidStart:]):
1972         (-[BlobDownloadDelegate _download:didReceiveResponse:]):
1973         (-[BlobDownloadDelegate _download:didReceiveData:]):
1974         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1975         (-[BlobDownloadDelegate _downloadDidFinish:]):
1976         (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1977         (TEST):
1978         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added.
1979
1980 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1981
1982         [GTK] Install binaries to pkglibexecdir rather than bindir
1983         https://bugs.webkit.org/show_bug.cgi?id=162602
1984
1985         Reviewed by Carlos Garcia Campos.
1986
1987         Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR.
1988
1989         * MiniBrowser/gtk/CMakeLists.txt:
1990
1991 2016-09-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1992
1993         [EFL] Locate color picker popup to center of window
1994         https://bugs.webkit.org/show_bug.cgi?id=162540
1995
1996         Reviewed by Michael Catanzaro.
1997
1998         Color picker popup hasn't located in a center of main window, because
1999         elm_win_center() function doesn't work correctly. It looks a bug.
2000
2001         To fix the problem, this patch uses evas_object_geometry_set() instead.
2002
2003         * MiniBrowser/efl/main.c:
2004         (_color_picker_request_cb):
2005
2006 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2007
2008         [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit
2009         https://bugs.webkit.org/show_bug.cgi?id=162600
2010
2011         Reviewed by Carlos Garcia Campos.
2012
2013         * Scripts/webkitperl/FeatureList.pm:
2014
2015 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2016
2017         PyGIWarnings printed by webkit-patch
2018         https://bugs.webkit.org/show_bug.cgi?id=152470
2019
2020         Reviewed by Carlos Garcia Campos.
2021
2022         Update to a newer version of the keyring module, since this bug has been fixed upstream for
2023         a while. But be careful not to update to the latest version, since it has some compatibility
2024         breaks and requires the SecretService python module on Linux, but I couldn't figure out how
2025         to autoinstall it successfully.
2026
2027         * Scripts/webkitpy/thirdparty/__init__.py:
2028         (AutoinstallImportHook._install_keyring):
2029
2030 2016-09-26  Ryan Haddad  <ryanhaddad@apple.com>
2031
2032         Add Sierra to the flakiness dashboard.
2033         https://bugs.webkit.org/show_bug.cgi?id=162509
2034
2035         Reviewed by Alexey Proskuryakov.
2036
2037         * TestResultServer/static-dashboards/builders.jsonp:
2038
2039 2016-09-26  Daniel Bates  <dabates@apple.com>
2040
2041         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2042         https://bugs.webkit.org/show_bug.cgi?id=162365
2043
2044         Reviewed by Simon Fraser.
2045
2046         * DumpRenderTree/TestRunner.h:
2047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2048
2049 2016-09-26  Tomas Popela  <tpopela@redhat.com>
2050
2051         [GTK] TestContextMenu is failing
2052         https://bugs.webkit.org/show_bug.cgi?id=162569
2053
2054         We cannot use the MP3 file in the TestContextMenu, as it will not work
2055         by default on most distributions (that don't have an MP3 codecs
2056         installed). Change the test to use OGG file instead.
2057
2058         Reviewed by Michael Catanzaro.
2059
2060         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2061         (testContextMenuDefaultMenu):
2062
2063 2016-09-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2064
2065         Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests
2066         https://bugs.webkit.org/show_bug.cgi?id=162537
2067
2068         Reviewed by Alex Christensen.
2069
2070         Some build bot (Linux ARM GTK port) fails since we cannot select
2071         the specific StringBuilder::append method for wchar_t.
2072
2073         wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2
2074         in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU
2075         uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other
2076         platforms.
2077
2078         StringBuilder::append is overloaded for UChar. In Windows, we can pass
2079         wchar_t since UChar is wchar_t. However, we cannot do that in other platforms.
2080
2081         Instead of using wchar_t, we use more platform portable UTF-16 literal for
2082         testing. Use char16_t and C++11 UTF-16 literal.
2083
2084         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2085         (TestWebKitAPI::utf16String):
2086         (TestWebKitAPI::TEST_F):
2087         (TestWebKitAPI::wideString): Deleted.
2088
2089 2016-09-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2090
2091         [EFL] Adjust EFL indentation to EFL MiniBrowser
2092         https://bugs.webkit.org/show_bug.cgi?id=162542
2093
2094         Unreviewed, EFL simple coding style fix.
2095
2096         Some functions wasn't applied EFL coding style in prefix fix.
2097
2098         * MiniBrowser/efl/main.c:
2099         (_key_down_cb):
2100         (view_focus_set):
2101         (_mouse_down_cb):
2102         (title_set):
2103         (_title_changed_cb):
2104         (_url_changed_cb):
2105         (_back_forward_list_changed_cb):
2106         (_progress_cb):
2107         (_error_cb):
2108         (_download_request_cb):
2109         (close_file_picker):
2110         (_filepicker_parent_deletion_cb):
2111         (_filepicker_deletion_cb):
2112         (_fileselector_done_cb):
2113         (_file_chooser_request_cb):
2114         (_download_finished_cb):
2115         (_download_failed_cb):
2116         (_color_changed_cb):
2117         (_color_item_selected_cb):
2118         (_color_picker_ok_clicked_cb):
2119         (_color_picker_cancel_clicked_cb):
2120         (_color_picker_dismiss_cb):
2121         (_color_picker_request_cb):
2122         (quit):
2123         (has_scheme):
2124         (url_from_user_input):
2125         (url_load_from_user_input):
2126         (_url_bar_activated_cb):
2127         (_url_bar_clicked_cb):
2128         (_search_field_aborted_cb):
2129         (_search_field_activated_cb):
2130         (_search_field_clicked_cb):
2131         (_back_button_clicked_cb):
2132         (_forward_button_clicked_cb):
2133         (_search_backward_button_clicked_cb):
2134         (_search_forward_button_clicked_cb):
2135         (_search_case_option_changed):
2136         (_search_word_start_option_changed_cb):
2137         (_search_close_button_clicked_cb):
2138         (_refresh_button_clicked_cb):
2139         (_stop_button_clicked_cb):
2140         (list_item_label_get):
2141         (_list_item_select_cb):
2142         (navigation_button_longpress_process):
2143         (_forward_button_longpress_cb):
2144         (_back_button_longpress_cb):
2145         (quit_event_loop):
2146         (_ok_clicked_cb):
2147         (_file_entry_dialog_show):
2148
2149 2016-09-24  Chris Dumez  <cdumez@apple.com>
2150
2151         [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path
2152         https://bugs.webkit.org/show_bug.cgi?id=162531
2153
2154         Reviewed by Darin Adler.
2155
2156         Update decideDestinationWithSuggestedFilename() to return a actual file path
2157         instead of nullptr. The NETWORK_SESSION code path cancels the download when
2158         decideDestinationWithSuggestedFilename() returns an empty file path, unlike
2159         the !NETWORK_SESSION code path that just continue downloading without
2160         explicitely setting a destination path. This lead to different test results
2161         for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid
2162         destination path makes more sense and leads to consistent results.
2163
2164         * WebKitTestRunner/TestController.cpp:
2165         (WTR::TestController::decideDestinationWithSuggestedFilename):
2166
2167 2016-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2168
2169         [mac-sierra] 2 WKWebViewCandidateTests API test failures
2170         https://bugs.webkit.org/show_bug.cgi?id=162470
2171
2172         Reviewed by Tim Horton.
2173
2174         VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
2175         tests with an SDK check to prevent 10.12.0 bots from building them.
2176
2177         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2178         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2179         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2180
2181 2016-09-23  Alex Christensen  <achristensen@webkit.org>
2182
2183         Refactor URLParser
2184         https://bugs.webkit.org/show_bug.cgi?id=162516
2185
2186         Reviewed by Brady Eidson.
2187
2188         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2189         (TestWebKitAPI::TEST_F):
2190
2191 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2192
2193         [JSC] Implement parsing of Async Functions
2194         https://bugs.webkit.org/show_bug.cgi?id=161409
2195
2196         Reviewed by Yusuke Suzuki.
2197
2198         * Scripts/build-jsc:
2199         (cMakeArgsFromFeatures):
2200         * Scripts/webkitperl/FeatureList.pm:
2201         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2202
2203 2016-09-23  Alex Christensen  <achristensen@webkit.org>
2204
2205         Refactor URLParser
2206         https://bugs.webkit.org/show_bug.cgi?id=162511
2207
2208         Reviewed by Brady Eidson.
2209
2210         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2211         (TestWebKitAPI::TEST_F):
2212         (TestWebKitAPI::checkURL):
2213
2214 2016-09-23  Alexey Proskuryakov  <ap@apple.com>
2215
2216         iOS playback user action tests fail on some machines
2217         https://bugs.webkit.org/show_bug.cgi?id=162504
2218         rdar://problem/28013994
2219
2220         Reviewed by Jer Noble.
2221
2222         Avoid the need to have a timeout.
2223
2224         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
2225         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2226         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
2227         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
2228
2229 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2230
2231         REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing
2232         https://bugs.webkit.org/show_bug.cgi?id=161607
2233
2234         Reviewed by Michael Catanzaro.
2235
2236         Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown
2237         in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there
2238         aren't exceptions, and that the error message is sent to the console.
2239
2240         * Scripts/run-gtk-tests:
2241         (TestRunner):
2242         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2243         (consoleMessageReceivedCallback):
2244         (testWebContextSecurityFileXHR):
2245
2246 2016-09-23  Ryan Haddad  <ryanhaddad@apple.com>
2247
2248         Use correct hardware for Sierra Debug WK2 testers.
2249         https://bugs.webkit.org/show_bug.cgi?id=162474
2250
2251         Reviewed by Alexey Proskuryakov.
2252
2253         * BuildSlaveSupport/build.webkit.org-config/config.json:
2254
2255 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2256
2257         [GTK] Make all WebView tests have a WebKitUserContentManager
2258         https://bugs.webkit.org/show_bug.cgi?id=162487
2259
2260         Reviewed by Michael Catanzaro.
2261
2262         It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest.
2263
2264         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2265         (ConsoleMessageTest::ConsoleMessageTest):
2266         (ConsoleMessageTest::~ConsoleMessageTest):
2267         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2268         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2269         (testUserContentManagerInjectedStyleSheet):
2270         (testUserContentManagerInjectedScript):
2271         (UserScriptMessageTest::UserScriptMessageTest):
2272         (beforeAll):
2273         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2274         (testWebViewIsPlayingAudio):
2275         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2276         (WebViewTest::WebViewTest):
2277         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2278
2279 2016-09-23  Antoine Quint  <graouts@apple.com>
2280
2281         Add a new runtime flag for work on modern media controls (off by default)
2282         https://bugs.webkit.org/show_bug.cgi?id=162420
2283         <rdar://problem/27989489>
2284
2285         Reviewed by Eric Carlson.
2286
2287         * DumpRenderTree/mac/DumpRenderTree.mm:
2288         (resetWebPreferencesToConsistentValues):
2289         * DumpRenderTree/win/DumpRenderTree.cpp:
2290         (resetWebPreferencesToConsistentValues):
2291         * Scripts/webkitperl/FeatureList.pm:
2292         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2293         (WTR::InjectedBundle::beginTesting):
2294         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2295         (WTR::TestRunner::setModernMediaControlsEnabled):
2296         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2297
2298 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2299
2300         REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
2301         https://bugs.webkit.org/show_bug.cgi?id=162139
2302
2303         Reviewed by Michael Catanzaro.
2304
2305         Add test cases to check the behavior when using the C locale and an invalid locale.
2306
2307         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2308         (testWebContextLanguages):
2309
2310 2016-09-22  Hunseop Jeong  <hs85.jeong@samsung.com>
2311
2312         [EFL] alert box is not displayed 
2313         https://bugs.webkit.org/show_bug.cgi?id=156395
2314
2315         Reviewed by Gyuyoung Kim.
2316
2317         Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
2318         the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
2319         to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
2320
2321         * MiniBrowser/efl/main.c:
2322         (_ok_clicked_cb):
2323         (_file_entry_dialog_show):
2324         (_javascript_alert_cb):
2325         (_javascript_confirm_cb):
2326         (_javascript_prompt_cb):
2327         (quit_event_loop): Deleted.
2328
2329 2016-09-22  Matthew Hanson  <matthew_hanson@apple.com>
2330
2331         Add an API for getting the branch identifier from a Git or SVN checkout.
2332         https://bugs.webkit.org/show_bug.cgi?id=151570
2333         rdar://problem/17959831
2334
2335         Reviewed by David Kilzer.
2336
2337         This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
2338         the name of the tag, or the name of the branch, as appropriate. This function is necessary for
2339         a VCSUtils client that is not checked in to the WebKit project.
2340
2341         This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
2342         - pathRelativeToSVNRepositoryRootForPath
2343         - svnInfoForPath
2344         - svnURLForPath
2345         - svnRepositoryRootForPath
2346
2347         This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
2348         allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
2349         of SCM.
2350
2351         * Scripts/VCSUtils.pm:
2352         (svnInfoForPath):
2353         Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
2354         Make code safe to use for a path, and not just for the CWD.
2355
2356         (svnURLForPath):
2357         Calls svnInfoForPath and extracts the URL.
2358
2359         (svnRepositoryRootForPath):
2360         Calls svnInfoForPath and extracts the Repository Root.
2361
2362         (svnIdentifierForPath):
2363         Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
2364
2365         (pathRelativeToSVNRepositoryRootForPath):
2366         Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
2367         determining both values.
2368
2369 2016-09-22  Megan Gardner  <megan_gardner@apple.com>
2370
2371         Add long press selection test
2372         https://bugs.webkit.org/show_bug.cgi?id=162367
2373
2374         Reviewed by Simon Fraser.
2375
2376         Add support to UIScriptController to synthesize long press events on iOS.
2377         This required adding long-press functionality to HIDEventGenerator.
2378
2379         HIDEventGenerator sends the touchDown, but must then send the touchUp with
2380         a dispatch_after (rather than sleeping, as we do for other events) in order
2381         for the gesture recognizers to correctly detect a long press.
2382
2383         Use the long press synthesis in a test that detects whether a long press
2384         gesture triggers text selection.
2385
2386         Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
2387         were nanoseconds and typedefed to long without regard to the type
2388         differences. Redid constants to be the right value, and converted upon use.
2389
2390         Cleaned up unused enum types.
2391
2392         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2393         (WTR::UIScriptController::longPressAtPoint):
2394         (WTR::UIScriptController::forcePressAtPoint):
2395         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
2396         * Scripts/webkitpy/common/config/contributors.json:
2397         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2398         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2399         (WTR::UIScriptController::longPressAtPoint):
2400         (WTR::UIScriptController::forcePressAtPoint):
2401         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
2402         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2403         * WebKitTestRunner/ios/HIDEventGenerator.h:
2404         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2405         (-[HIDEventGenerator _createIOHIDEventType:]):
2406         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2407         (-[HIDEventGenerator clearTap:]):
2408         (-[HIDEventGenerator longPressTimerCall:]):
2409         (-[HIDEventGenerator longPressFinish:completionBlock:]):
2410         (-[HIDEventGenerator longPress:completionBlock:]):
2411         (-[HIDEventGenerator forcePress:completionBlock:]):
2412         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2413         (WTR::UIScriptController::longPressAtPoint):
2414         (WTR::UIScriptController::forcePressAtPoint):
2415         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
2416
2417 2016-09-22  Jonathan Bedard  <jbedard@apple.com>
2418
2419         Automatic Text Replacement Testing in WebKit2
2420         https://bugs.webkit.org/show_bug.cgi?id=161919
2421
2422         Reviewed by Ryosuke Niwa.
2423
2424         Implemented test hooks for text replacement for WebKit2.
2425         Note that spell checking has not been implemented, so most tests which use text replacement still fail.
2426
2427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
2428         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
2429         (WTR::InjectedBundle::beginTesting): Ditto.
2430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
2431         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2432         * WebKitTestRunner/TestController.cpp:
2433         (WTR::TestController::runTest): Place TextChecker into testing mode.
2434
2435 2016-09-21  Dan Bernstein  <mitz@apple.com>
2436
2437         [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
2438         https://bugs.webkit.org/show_bug.cgi?id=162359
2439         <rdar://problem/27776454>
2440
2441         Reviewed by Tim Horton.
2442
2443         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2444         (TEST):
2445
2446 2016-09-21  Keith Miller  <keith_miller@apple.com>
2447
2448         Fix build for future versions of Clang.
2449         https://bugs.webkit.org/show_bug.cgi?id=162346
2450
2451         Reviewed by Filip Pizlo.
2452
2453         * TestWebKitAPI/Counters.cpp:
2454         * TestWebKitAPI/Counters.h:
2455         (DeleterCounter::deleterCount):
2456         (DeleterCounter::TestingScope::TestingScope):
2457         (DeleterCounter::operator()):
2458         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
2459         (TestWebKitAPI::TEST):
2460         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2461         (TestWebKitAPI::TEST):
2462
2463 2016-09-21  Commit Queue  <commit-queue@webkit.org>
2464
2465         Unreviewed, rolling out r206222 and r206227.
2466         https://bugs.webkit.org/show_bug.cgi?id=162361
2467
2468         "broke the windows build" (Requested by keith_mi_ on #webkit).
2469
2470         Reverted changesets:
2471
2472         "Fix build for future versions of Clang."
2473         https://bugs.webkit.org/show_bug.cgi?id=162346
2474         http://trac.webkit.org/changeset/206222
2475
2476         "Attempt to fix windows build after r206222."
2477         http://trac.webkit.org/changeset/206227
2478
2479 2016-09-21  Alex Christensen  <achristensen@webkit.org>
2480
2481         URLParser should match URL::parse when parsing data urls with slashes in them
2482         https://bugs.webkit.org/show_bug.cgi?id=162352
2483
2484         Reviewed by Darin Adler.
2485
2486         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2487         (TestWebKitAPI::TEST_F):
2488
2489 2016-09-21  Alex Christensen  <achristensen@webkit.org>
2490
2491         URLParser should fail when parsing invalid relative URLs with no schemes
2492         https://bugs.webkit.org/show_bug.cgi?id=162355
2493
2494         Reviewed by Tim Horton.
2495
2496         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2497         (TestWebKitAPI::TEST_F):
2498
2499 2016-09-21  Keith Miller  <keith_miller@apple.com>
2500
2501         Fix build for future versions of Clang.
2502         https://bugs.webkit.org/show_bug.cgi?id=162346
2503
2504         Reviewed by Filip Pizlo.
2505
2506         * TestWebKitAPI/Counters.cpp:
2507         * TestWebKitAPI/Counters.h:
2508         (DeleterCounter::deleterCount):
2509         (DeleterCounter::TestingScope::TestingScope):
2510         (DeleterCounter::operator()):
2511         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
2512         (TestWebKitAPI::TEST):
2513         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2514         (TestWebKitAPI::TEST):
2515
2516 2016-09-21  Alex Christensen  <achristensen@webkit.org>
2517
2518         Prepare API tests for enabling URLParser by default
2519         https://bugs.webkit.org/show_bug.cgi?id=162341
2520
2521         Reviewed by Tim Horton.
2522
2523         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2524         (TestWebKitAPI::checkURL):
2525         (TestWebKitAPI::checkRelativeURL):
2526         (TestWebKitAPI::checkURLDifferences):
2527         (TestWebKitAPI::checkRelativeURLDifferences):
2528         (TestWebKitAPI::shouldFail):
2529
2530 2016-09-21  Alex Christensen  <achristensen@webkit.org>
2531
2532         URLParser: Correctly parse URLs that are just nonspecialscheme:/
2533         https://bugs.webkit.org/show_bug.cgi?id=162340
2534
2535         Reviewed by Tim Horton.
2536
2537         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2538         (TestWebKitAPI::TEST_F):
2539
2540 2016-09-21  Alex Christensen  <achristensen@webkit.org>
2541
2542         URLParser: correctly parse relative URLs that are just one character
2543         https://bugs.webkit.org/show_bug.cgi?id=162344
2544
2545         Reviewed by Tim Horton.
2546
2547         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2548         (TestWebKitAPI::TEST_F):
2549
2550 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2551
2552         Optimize URLParser
2553         https://bugs.webkit.org/show_bug.cgi?id=162105
2554
2555         Reviewed by Geoffrey Garen.
2556
2557         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2558         (TestWebKitAPI::TEST_F):
2559
2560 2016-09-20  Aakash Jain  <aakash_jain@apple.com>
2561
2562         enable remote_api (for debugging) in flakiness dashboard app
2563         https://bugs.webkit.org/show_bug.cgi?id=162325
2564
2565         Reviewed by Alexey Proskuryakov.
2566
2567         * TestResultServer/app.yaml: enabled remote_api and datastore_admin.
2568
2569 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
2570
2571         Unreviewed, rolling out r206180.
2572
2573         Roll r206178 back in as the necessary changes have been made
2574         on the build master.
2575
2576         Reverted changeset:
2577
2578         "Unreviewed, rolling out r206178."
2579         https://bugs.webkit.org/show_bug.cgi?id=162249
2580         http://trac.webkit.org/changeset/206180
2581
2582 2016-09-20  Alexey Proskuryakov  <ap@apple.com>
2583
2584         Use a hardcoded patch for sRGB color profile
2585         https://bugs.webkit.org/show_bug.cgi?id=162320
2586         rdar://problem/28387318
2587
2588         Reviewed by Simon Fraser.
2589
2590         This is a workaround for rdar://problem/28392768
2591
2592         * DumpRenderTree/mac/LayoutTestHelper.m:
2593         (installLayoutTestColorProfile):
2594
2595 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
2596
2597         Unreviewed, rolling out r206178.
2598
2599         This change caused buildbot config issues.
2600
2601         Reverted changeset:
2602
2603         "Add Sierra bots to buildbot and dashboard."
2604         https://bugs.webkit.org/show_bug.cgi?id=162249
2605         http://trac.webkit.org/changeset/206178
2606
2607 2016-09-20  Dean Johnson  <dean_johnson@apple.com>
2608
2609         Add Sierra bots to buildbot and dashboard.
2610         https://bugs.webkit.org/show_bug.cgi?id=162249
2611
2612         Reviewed by Alexey Proskuryakov.
2613
2614         * BuildSlaveSupport/build.webkit.org-config/config.json:
2615         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2617         (WebKitBuildbot):
2618
2619 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2620
2621         Reduce allocations in URLParser
2622         https://bugs.webkit.org/show_bug.cgi?id=162241
2623
2624         Reviewed by Chris Dumez.
2625
2626         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2627         (TestWebKitAPI::TEST_F):
2628         (TestWebKitAPI::checkURL):
2629
2630 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2631
2632         Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
2633         https://bugs.webkit.org/show_bug.cgi?id=162251
2634
2635         Reviewed by Tim Horton.
2636
2637         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2638         (TestWebKitAPI::checkURL):
2639         (TestWebKitAPI::TEST_F):
2640         (TestWebKitAPI::checkRelativeURL):
2641         (TestWebKitAPI::checkURLDifferences):
2642         (TestWebKitAPI::checkRelativeURLDifferences):
2643
2644 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2645
2646         URLParser should allow '@' in user
2647         https://bugs.webkit.org/show_bug.cgi?id=162272
2648
2649         Reviewed by Tim Horton.
2650
2651         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2652         (TestWebKitAPI::TEST_F):
2653
2654 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2655
2656         URLParser: Fix parsing relative URLs with one slash after the scheme:
2657         https://bugs.webkit.org/show_bug.cgi?id=162294
2658
2659         Reviewed by Tim Horton.
2660
2661         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2662         (TestWebKitAPI::TEST_F):
2663
2664 2016-09-20  Alex Christensen  <achristensen@webkit.org>
2665
2666         Fix Windows file URL quirks in URLParser
2667         https://bugs.webkit.org/show_bug.cgi?id=162303
2668
2669         Reviewed by Tim Horton.
2670
2671         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2672         (TestWebKitAPI::TEST_F):
2673
2674 2016-09-20  Filip Pizlo  <fpizlo@apple.com>
2675
2676         Make MarkedBlock state tracking support overlapped allocation and marking state
2677         https://bugs.webkit.org/show_bug.cgi?id=161581
2678
2679         Reviewed by Geoffrey Garen.
2680         
2681         Remove the always-trigger-copy-phase configuration.
2682
2683         * Scripts/run-jsc-stress-tests:
2684
2685 2016-09-20  Don Olmstead  <don.olmstead@am.sony.com>
2686
2687         [WinCairo] Use find_package cairo in build
2688         https://bugs.webkit.org/show_bug.cgi?id=162239
2689
2690         Reviewed by Alex Christensen.
2691
2692         * DumpRenderTree/PlatformWin.cmake:
2693         * TestWebKitAPI/PlatformWin.cmake:
2694
2695 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2696
2697         Unreviewed build fix on 10.10 bots.
2698
2699         * TestWebKitAPI/mac/TestWKWebViewMac.h:
2700
2701 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2702
2703         VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
2704         https://bugs.webkit.org/show_bug.cgi?id=162255
2705
2706         Reviewed by Jer Noble.
2707
2708         This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test
2709         back-to-back would result in the second one failing). This suggests that even on the runloop after the video
2710         starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we
2711         can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and
2712         will probably address flakiness on the bots for this test.
2713
2714         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2715         (TestWebKitAPI::TEST):
2716         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2717
2718 2016-09-20  Per Arne Vollan  <pvollan@apple.com>
2719
2720         [Win] Run layout tests in parallel.
2721         https://bugs.webkit.org/show_bug.cgi?id=162145
2722
2723         Reviewed by Brent Fulgham.
2724
2725         To speed up layout tests, try running them in parallel.
2726
2727         * Scripts/webkitpy/port/win.py:
2728         (WinPort.default_child_processes): Deleted.
2729
2730 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2731
2732         Unreviewed build fix after r206135
2733
2734         NSEventMaskLeftMouseDown and friends are only available on 10.12.
2735
2736         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2737         (__simulated_forceClickAssociatedEventsMask):
2738
2739 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2740
2741         Add a unit test covering <https://trac.webkit.org/changeset/205983>
2742         https://bugs.webkit.org/show_bug.cgi?id=162112
2743
2744         Reviewed by Beth Dakin.
2745
2746         Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also
2747         further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both
2748         cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event
2749         at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as
2750         pressure-sensitive events that are needed for the new test.
2751
2752         Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests,
2753         checking whether or not to should be requesting candidates in password and non-password fields.
2754
2755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2756         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2757         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2758         (TestWebKitAPI::TEST):
2759         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2760         (-[CandidateTestWebView typeString:inputMessage:]):
2761         (+[CandidateTestWebView setUpWithFrame:testPage:]):
2762         * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added.
2763         * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added.
2764         * TestWebKitAPI/mac/TestWKWebViewMac.h:
2765         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2766         (__simulated_forceClickAssociatedEventsMask):
2767         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2768         (-[TestWKWebView initWithFrame:]):
2769         (-[TestWKWebView initWithFrame:configuration:]):
2770         (-[TestWKWebView _setUpTestWindow:]):
2771         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2772         (-[TestWKWebView typeCharacter:]):
2773         (-[TestWKWebView mouseDownAtPoint:]): Deleted.
2774
2775 2016-09-19  Alex Christensen  <achristensen@webkit.org>
2776
2777         URLParser can read memory out of bounds
2778         https://bugs.webkit.org/show_bug.cgi?id=162206
2779
2780         Reviewed by Geoff Garen.
2781
2782         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2783         (TestWebKitAPI::TEST_F):
2784
2785 2016-09-19  Daniel Bates  <dabates@apple.com>
2786
2787         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
2788         https://bugs.webkit.org/show_bug.cgi?id=162167
2789
2790         Reviewed by Simon Fraser.
2791
2792         * Scripts/webkitperl/FeatureList.pm:
2793         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2794
2795 2016-09-19  Nan Wang  <n_wang@apple.com>
2796
2797         AX: Add accessibility support for details element on iOS
2798         https://bugs.webkit.org/show_bug.cgi?id=162041
2799
2800         Reviewed by Chris Fleizach.
2801
2802         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2803         (AccessibilityUIElement::isExpanded):
2804         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2805         (WTR::AccessibilityUIElement::isExpanded):
2806
2807 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2808
2809         [EFL] Bump efl library to 1.18.1
2810         https://bugs.webkit.org/show_bug.cgi?id=162120
2811
2812         Reviewed by Michael Catanzaro.
2813
2814         * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18.
2815
2816 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2817
2818         [EFL] Adjust EFL coding style to EFL MiniBrowser
2819         https://bugs.webkit.org/show_bug.cgi?id=162119
2820
2821         Reviewed by Michael Catanzaro.
2822
2823         Apply EFL coding style to main.c for MiniBrowser.
2824           - Use _foo_cb instead of on_foo for callback function
2825           - Use 3 spaces and use 2 spaces in keywords.
2826
2827         - EFL coding style.
2828           https://phab.enlightenment.org/w/coding_convention/
2829
2830         Additionally this patch adds an exception rule that style checker doesn't
2831         check indentation rule in EFL MiniBrowser.
2832
2833         * MiniBrowser/efl/main.c:
2834         (miniBrowserViewSmartClass):
2835         (window_find_with_ewk_view):
2836         (_tooltip_show):
2837         (window_tooltip_hide):
2838         (window_tooltip_update):
2839         (_mouse_in_cb):
2840         (_mouse_move_cb):
2841         (_mouse_out_cb):
2842         (_mouse_wheel_cb):
2843         (_window_resize_cb):
2844         (update_view_favicon):
2845         (_icon_changed_cb):
2846         (window_free):
2847         (window_close):
2848         (search_icon_show):
2849         (search_box_show):
2850         (search_box_hide):
2851         (history_list_hide):
2852         (save_page_contents_callback):
2853         (script_execute_callback):
2854         (toggle_window_fullscreen):
2855         (_key_down_cb):
2856         (_mouse_down_cb):
2857         (_title_changed_cb):
2858         (_url_changed_cb):
2859         (_back_forward_list_changed_cb):
2860         (_progress_cb):
2861         (_error_cb):
2862         (_download_request_cb):
2863         (close_file_picker):
2864         (_filepicker_parent_deletion_cb):
2865         (_filepicker_deletion_cb):
2866         (_fileselector_done_cb):
2867         (_file_chooser_request_cb):
2868         (_download_finished_cb):
2869         (_download_failed_cb):
2870         (_color_changed_cb):
2871         (_color_item_selected_cb):
2872         (_color_picker_ok_clicked_cb):
2873         (_color_picker_cancel_clicked_cb):
2874         (_color_picker_dismiss_cb):
2875         (_color_picker_request_cb):
2876         (_url_bar_activated_cb):
2877         (_url_bar_clicked_cb):
2878         (_search_field_aborted_cb):
2879         (_search_field_activated_cb):
2880         (_search_field_clicked_cb):
2881         (_back_button_clicked_cb):
2882         (_forward_button_clicked_cb):
2883         (_search_backward_button_clicked_cb):
2884         (_search_forward_button_clicked_cb):
2885         (_search_case_option_changed):
2886         (_search_word_start_option_changed_cb):
2887         (_search_close_button_clicked_cb):
2888         (_refresh_button_clicked_cb):
2889         (_stop_button_clicked_cb):
2890         (_list_item_select_cb):
2891         (navigation_button_longpress_process):
2892         (_forward_button_longpress_cb):
2893         (_back_button_longpress_cb):
2894         (_ok_clicked_cb):
2895         (_file_entry_dialog_show):
2896         (_javascript_alert_cb):
2897         (_javascript_confirm_cb):
2898         (_javascript_prompt_cb):
2899         (_javascript_before_unload_confirm_cb):
2900         (_popup_menu_item_clicked_cb):
2901         (popup_menu_populate):
2902         (_popup_menu_show):
2903         (_popup_menu_hide):
2904         (_window_geometry_get):
2905         (_window_geometry_set):
2906         (_fullscreen_accept_cb):
2907         (_fullscreen_deny_cb):
2908         (_fullscreen_enter_cb):
2909         (_fullscreen_exit_cb):
2910         (_window_create_cb):
2911         (_window_close_cb):
2912         (_context_menu_item_selected_cb):
2913         (context_menu_populate):
2914         (_context_menu_show):
2915         (_context_menu_hide):
2916         (auth_popup_close):
2917         (_auth_cancel_cb):
2918         (_auth_ok_cb):
2919         (_authentication_request_cb):
2920         (_search_text_found_cb):
2921         (_tooltip_text_set):
2922         (_tooltip_text_unset):
2923         (_navigation_policy_decision_cb):
2924         (_home_button_clicked_cb):
2925         (_window_deletion_cb):
2926         (create_toolbar_button):
2927         (window_create):
2928         (configuration):
2929         (parse_cookies_policy):
2930         (parse_window_size):
2931         (elm_main):
2932         (on_tooltip_show): Deleted.
2933         (on_mouse_in): Deleted.
2934         (on_mouse_move): Deleted.
2935         (on_mouse_out): Deleted.
2936         (on_mouse_wheel): Deleted.
2937         (on_window_resize): Deleted.
2938         (on_icon_changed_cb): Deleted.
2939         (on_key_down): Deleted.
2940         (on_mouse_down): Deleted.
2941         (on_title_changed): Deleted.
2942         (on_url_changed): Deleted.
2943         (on_back_forward_list_changed): Deleted.
2944         (on_progress): Deleted.
2945         (on_error): Deleted.
2946         (on_download_request): Deleted.
2947         (on_filepicker_parent_deletion): Deleted.
2948         (on_filepicker_deletion): Deleted.
2949         (on_fileselector_done): Deleted.
2950         (on_file_chooser_request): Deleted.
2951         (on_download_finished): Deleted.
2952         (on_download_failed): Deleted.
2953         (on_color_changed): Deleted.
2954         (on_color_item_selected): Deleted.
2955         (on_color_picker_ok_clicked): Deleted.
2956         (on_color_picker_cancel_clicked): Deleted.
2957         (on_color_picker_dismiss): Deleted.
2958         (on_color_picker_request): Deleted.
2959         (on_url_bar_activated): Deleted.
2960         (on_url_bar_clicked): Deleted.
2961         (on_search_field_aborted): Deleted.
2962         (on_search_field_activated): Deleted.
2963         (on_search_field_clicked): Deleted.
2964         (on_back_button_clicked): Deleted.
2965         (on_forward_button_clicked): Deleted.
2966         (on_search_backward_button_clicked): Deleted.
2967         (on_search_forward_button_clicked): Deleted.
2968         (on_search_case_option_changed): Deleted.
2969         (on_search_word_start_option_changed): Deleted.
2970         (on_search_close_button_clicked): Deleted.
2971         (on_refresh_button_clicked): Deleted.
2972         (on_stop_button_clicked): Deleted.
2973         (on_list_item_select): Deleted.
2974         (on_forward_button_longpress): Deleted.
2975         (on_back_button_longpress): Deleted.
2976         (on_ok_clicked): Deleted.
2977         (show_file_entry_dialog): Deleted.
2978         (on_javascript_alert): Deleted.
2979         (on_javascript_confirm): Deleted.
2980         (on_javascript_prompt): Deleted.
2981         (on_javascript_before_unload_confirm): Deleted.
2982         (on_popup_menu_item_clicked): Deleted.
2983         (on_popup_menu_show): Deleted.
2984         (on_popup_menu_hide): Deleted.
2985         (on_window_geometry_get): Deleted.
2986         (on_window_geometry_set): Deleted.
2987         (on_fullscreen_accept): Deleted.
2988         (on_fullscreen_deny): Deleted.
2989         (on_fullscreen_enter): Deleted.
2990         (on_fullscreen_exit): Deleted.
2991         (on_window_create): Deleted.
2992         (on_window_close): Deleted.
2993         (context_menu_item_selected_cb): Deleted.
2994         (on_context_menu_show): Deleted.
2995         (on_context_menu_hide): Deleted.
2996         (on_auth_cancel): Deleted.
2997         (on_auth_ok): Deleted.
2998         (on_authentication_request): Deleted.
2999         (on_search_text_found): Deleted.
3000         (on_tooltip_text_set): Deleted.
3001         (on_tooltip_text_unset): Deleted.
3002         (on_navigation_policy_decision): Deleted.
3003         (on_home_button_clicked): Deleted.
3004         (on_window_deletion): Deleted.
3005         * Scripts/webkitpy/style/checker.py:
3006
3007 2016-09-16  Dave Hyatt  <hyatt@apple.com>
3008
3009         [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
3010         https://bugs.webkit.org/show_bug.cgi?id=162078
3011
3012         Reviewed by Dean Jackson.
3013
3014         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3015         (TestWebKitAPI::createTestValue):
3016         Convert to ValueRange.
3017
3018 2016-09-16  Alex Christensen  <achristensen@webkit.org>
3019
3020         Fix API tests after r206036
3021         https://bugs.webkit.org/show_bug.cgi?id=162049
3022
3023         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3024         (TestWebKitAPI::TEST_F):
3025         An emoji had been UTF-8 encoded in the patch that was applied.
3026         The test needed to check the encoding of the emoji, not the UTF-8 encoding of the emoji.
3027         Everything was correct except applying the patch before committing.
3028
3029 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3030
3031         RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
3032         https://bugs.webkit.org/show_bug.cgi?id=162080
3033
3034         Reviewed by Jer Noble.
3035
3036         I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
3037         RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
3038
3039         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3040         (RequiresUserActionForPlaybackTest::SetUp):
3041
3042 2016-09-16  Alex Christensen  <achristensen@webkit.org>
3043
3044         URLParser should percent encode the user and password according to spec
3045         https://bugs.webkit.org/show_bug.cgi?id=162049
3046
3047         Reviewed by Tim Horton.
3048
3049         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3050         (TestWebKitAPI::TEST_F):
3051
3052 2016-09-16  Alex Christensen  <achristensen@webkit.org>
3053
3054         Fix more edge cases in URLParser
3055         https://bugs.webkit.org/show_bug.cgi?id=162051
3056
3057         Reviewed by Tim Horton.
3058
3059         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3060         (TestWebKitAPI::TEST_F):
3061
3062 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3063
3064         Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker
3065         https://bugs.webkit.org/show_bug.cgi?id=162009
3066         <rdar://problem/28086237>
3067
3068         Reviewed by Tim Horton.
3069
3070         Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in
3071         WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new
3072         WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of
3073         simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and
3074         performing actions in response.
3075
3076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
3078         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
3079         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
3080         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3081         (TestWebKitAPI::TEST):
3082         (-[MessageHandler initWithMessage:handler:]): Deleted.
3083         (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
3084         (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted.
3085         (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted.
3086         (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted.
3087         (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted.
3088         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted.
3089         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added.
3090         (-[TestCandidate initWithReplacementString:inRange:]):
3091         (-[TestCandidate replacementString]):
3092         (-[TestCandidate resultType]):
3093         (-[TestCandidate range]):
3094         (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]):
3095         (-[CandidateTestWebView _didHandleAcceptedCandidate]):
3096         (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]):
3097         (-[CandidateTestWebView _didUpdateCandidateListVisibility:]):
3098         (TEST):
3099         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
3100         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html:
3101         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html:
3102         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html:
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added.
3104         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
3105         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html:
3106         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html:
3107         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
3108         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html:
3109         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html:
3110         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
3112         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
3113         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
3114         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
3115         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
3116         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
3117         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
3118         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html:
3119         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html:
3120         * TestWebKitAPI/mac/TestWKWebViewMac.h: Added.
3121         * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added.
3122         (-[TestMessageHandler initWithMessage:handler:]):
3123         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3124         (-[TestWKWebView mouseDownAtPoint:]):
3125         (-[TestWKWebView performAfterReceivingMessage:action:]):
3126         (-[TestWKWebView loadTestPageNamed:]):
3127         (-[TestWKWebView typeCharacter:]):
3128         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3129         (-[TestWKWebView waitForMessage:]):
3130         (-[TestWKWebView performAfterLoading:]):
3131
3132 2016-09-14  Jer Noble  <jer.noble@apple.com>
3133
3134         [media-source] fix imported/w3c/web-platform-tests/media-source/mediasource-duration.html
3135         https://bugs.webkit.org/show_bug.cgi?id=161999
3136
3137         Reviewed by Eric Carlson.
3138
3139         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3140         (TestWebKitAPI::TEST):
3141
3142 2016-09-16  Anders Carlsson  <andersca@apple.com>
3143
3144         Fix isValidEnum to work with older versions of GCC
3145         https://bugs.webkit.org/show_bug.cgi?id=162065
3146
3147         Reviewed by Michael Catanzaro.
3148
3149         Add EnumTraits.cpp to the CMake build.
3150
3151         * TestWebKitAPI/CMakeLists.txt:
3152
3153 2016-09-16  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
3154
3155         Unreviewed: Change my primary address for auto-complete in bugzilla.
3156
3157         * Scripts/webkitpy/common/config/contributors.json:
3158
3159 2016-09-15  Alex Christensen  <achristensen@webkit.org>
3160
3161         URLParser: Check for invalid characters in the host
3162         https://bugs.webkit.org/show_bug.cgi?id=162023
3163
3164         Reviewed by Tim Horton.
3165
3166         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3167         (TestWebKitAPI::TEST_F):
3168
3169 2016-09-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3170
3171         [CMake] Refactor GENERATE_BINDINGS
3172         https://bugs.webkit.org/show_bug.cgi?id=161854
3173
3174         Reviewed by Gyuyoung Kim.
3175
3176         * DumpRenderTree/CMakeLists.txt: Changed the arguments of
3177         GENERATE_BINDINGS to new style.
3178         * WebKitTestRunner/CMakeLists.txt: Ditto.
3179
3180 2016-09-15  Ryan Haddad  <ryanhaddad@apple.com>
3181
3182         Disable failing API WebKit2.DataDetectionReferenceDate until it can be investigated.
3183         https://bugs.webkit.org/show_bug.cgi?id=161967
3184
3185         Unreviewed test gardening.
3186
3187         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3188         (TEST):
3189
3190 2016-09-15  Per Arne Vollan  <pvollan@apple.com>
3191
3192         [Win] run-api-tests is failing.
3193         https://bugs.webkit.org/show_bug.cgi?id=162015
3194
3195         Reviewed by Brent Fulgham.
3196
3197         MSVC is not interpreting C++ string literals with unicode characters correctly when the source file
3198         doesn't contain encoding information. Save the file with utf8 encoding with signature.
3199
3200         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3201
3202 2016-09-15  Jonathan Bedard  <jbedard@apple.com>
3203
3204         Move --no-sample-on-timeout to config.json for each bot
3205         https://bugs.webkit.org/show_bug.cgi?id=161964
3206
3207         Reviewed by Daniel Bates.
3208
3209         Roll out changes from 205573 and move them into config.json.  At this time, only macOS and iOS simulator sample a process on timeout, —no-sample-on-timeout is unneeded for GTK, EFL and Windows.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/config.json: Each bot now independently defines if it will be running sample on timeout.
3212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3213         (RunWebKitTests.start): Rolled out changes from 205573.
3214
3215 2016-09-15  Csaba Osztrogonác  <ossy@webkit.org>
3216
3217         js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
3218         https://bugs.webkit.org/show_bug.cgi?id=159807
3219
3220         Reviewed by Saam Barati.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3223         (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.
3224         * Scripts/run-javascriptcore-tests:
3225         (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.
3226         * Scripts/run-jsc-stress-tests: Typo fix.
3227
3228 2016-09-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3229
3230         Media controls behave strangely when changing media sources
3231         https://bugs.webkit.org/show_bug.cgi?id=161914
3232         <rdar://problem/28227805>
3233
3234         Reviewed by Tim Horton.
3235
3236         Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also
3237         tweaks an existing test to account for new `ended` behavior.
3238
3239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3240         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3241         (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]):
3242         (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]):
3243         (TestWebKitAPI::TEST):
3244         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added.
3245         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added.
3246         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added.
3247
3248 2016-09-14  Jonathan Bedard  <jbedard@apple.com>
3249
3250         Fix mastercfg_unittest
3251         https://bugs.webkit.org/show_bug.cgi?id=161816
3252
3253         Reviewed by Daniel Bates.
3254
3255         (RunWebKitTests.start):
3256         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Fixed broken unit tests.
3257
3258 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
3259
3260         Landing optimized .png files, forgot to do it initially.
3261
3262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
3263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
3265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
3266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
3267
3268 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
3269
3270         Switch build.webkit.org to iOS 10
3271         https://bugs.webkit.org/show_bug.cgi?id=161930
3272
3273         Reviewed by Daniel Bates.
3274
3275         * BuildSlaveSupport/build.webkit.org-config/config.json:
3276         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3277         (RunWebKitTests.start):
3278         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: Added.
3280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: Added.
3281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: Added.
3282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png: Added.
3283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
3284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
3285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png: Added.
3286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png: Added.
3287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3291         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3292         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3293         * Scripts/webkitpy/port/ios.py:
3294         * TestResultServer/static-dashboards/builders.jsonp:
3295
3296 2016-09-13  Tim Horton  <timothy_horton@apple.com>
3297
3298         Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
3299         https://bugs.webkit.org/show_bug.cgi?id=161896
3300         <rdar://problem/28229827>
3301
3302         Reviewed by Simon Fraser.
3303
3304         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm:
3305         (TestWebKitAPI::TEST):
3306         Add a test for the new property.
3307         Also fix the old new test to run on arbitrary scale displays without failing.
3308
3309 2016-09-12  Brent Fulgham  <bfulgham@apple.com>
3310
3311         [Win][Direct2D] Provide Direct2D-based geometry and transform cast operations
3312         https://bugs.webkit.org/show_bug.cgi?id=161818
3313
3314         Reviewed by Dean Jackson.
3315
3316         Add several new test suites for the various geometric primitives in WebCore.
3317
3318         * TestWebKitAPI/PlatformWin.cmake: Add new files for test cases.
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3320         * TestWebKitAPI/Tests/WebCore/AffineTransform.cpp: Added.
3321         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: Added.
3322         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: Added.
3323         * TestWebKitAPI/Tests/WebCore/FloatSize.cpp: Added.
3324         * TestWebKitAPI/Tests/WebCore/IntPoint.cpp: Added.
3325         * TestWebKitAPI/Tests/WebCore/IntRect.cpp: Added.
3326         * TestWebKitAPI/Tests/WebCore/IntSize.cpp: Added.
3327         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Add some new
3328         Windows-focused test cases.
3329
3330 2016-09-12  Chris Dumez  <cdumez@apple.com>
3331
3332         Fix post-landing review comments after r205787
3333         https://bugs.webkit.org/show_bug.cgi?id=161885
3334
3335         Reviewed by Darin Adler.
3336
3337         Leverage new StringBuilder::append(CFStringRef) overload.
3338
3339         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3340         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3341
3342 2016-09-12  Alex Christensen  <achristensen@webkit.org>
3343
3344         URLParser: Correctly ignore spaces before relative URLs with no scheme
3345         https://bugs.webkit.org/show_bug.cgi?id=161889
3346
3347         Reviewed by Daniel Bates.
3348
3349         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3350         (TestWebKitAPI::TEST_F):
3351
3352 2016-09-12  Alex Christensen  <achristensen@webkit.org>
3353
3354         URLParser: Fix relative URLs containing only fragments
3355         https://bugs.webkit.org/show_bug.cgi?id=161882
3356
3357         Reviewed by Brady Eidson.
3358
3359         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3360         (TestWebKitAPI::TEST_F):
3361
3362 2016-09-12  Alex Christensen  <achristensen@webkit.org>
3363
3364         URLParser: Correctly handle relative URLs that are just a scheme and a colon
3365         https://bugs.webkit.org/show_bug.cgi?id=161876
3366
3367         Reviewed by Brady Eidson.
3368
3369         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3370         (TestWebKitAPI::TEST_F):
3371
3372 2016-09-12  DAN SAUNDERS  <dasau@microsoft.com>
3373
3374         AX: WKWebView for macOS does not allow configuration of tabsToLinks
3375         https://bugs.webkit.org/show_bug.cgi?id=161394
3376
3377         Reviewed by Anders Carlsson.
3378
3379         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3380         (TEST):
3381
3382 2016-09-12  Alex Christensen  <achristensen@webkit.org>
3383
3384         Remove trailing control characters and spaces before parsing a URL
3385         https://bugs.webkit.org/show_bug.cgi?id=161870
3386
3387         Reviewed by Tim Horton.
3388
3389         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3390         (TestWebKitAPI::TEST_F):
3391
3392 2016-09-12  Alex Christensen  <achristensen@webkit.org>
3393
3394         Fix more URLParser quirks
3395         https://bugs.webkit.org/show_bug.cgi?id=161834
3396
3397         Reviewed by Brady Eidson.
3398
3399         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3400         (TestWebKitAPI::TEST_F):
3401
3402 2016-09-10  Alex Christensen  <achristensen@webkit.org>
3403
3404         Optimize URLParser performance
3405         https://bugs.webkit.org/show_bug.cgi?id=161837
3406
3407         Reviewed by Brady Eidson.
3408
3409         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3410         (TestWebKitAPI::TEST_F):
3411         Added a test to verify the case insensitivity of the default port checks.
3412
3413 2016-09-10  Chris Dumez  <cdumez@apple.com>
3414
3415         parseHTMLInteger() should take a StringView in parameter
3416         https://bugs.webkit.org/show_bug.cgi?id=161669
3417
3418         Reviewed by Ryosuke Niwa.
3419
3420         Explicitly construct a String from the CFStringRef in order to call
3421         StringBuilder::append(). This is needed now that there is an append()
3422         overload taking an AtomicString in parameter.
3423
3424         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3425         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3426
3427 2016-09-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3428
3429         Apple.com keynote does not display media controls
3430         https://bugs.webkit.org/show_bug.cgi?id=161833
3431         <rdar://problem/28230123>
3432
3433         Reviewed by Tim Horton.
3434
3435         New unit test verifying that wide videos (~2 aspect ratio) still get media controls.
3436
3437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3438         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3439         (TestWebKitAPI::TEST):
3440         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added.
3441
3442 2016-09-09  Tim Horton  <timothy_horton@apple.com>
3443
3444         WKThumbnailView should expose a mode where it can be reparented without resnapshotting
3445         https://bugs.webkit.org/show_bug.cgi?id=161828
3446         <rdar://problem/28229756>
3447
3448         Reviewed by Alex Christensen.
3449
3450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3451         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added.
3452         (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]):
3453         (TestWebKitAPI::didFinishLoadForFrame):
3454         (TestWebKitAPI::setPageLoaderClient):
3455         (TestWebKitAPI::TEST):
3456         Add a test ensuring that this behaves correctly.
3457
3458 2016-09-09  Alex Christensen  <achristensen@webkit.org>
3459
3460         URLParser: Keep track of cannot-be-a-base-url according to spec
3461         https://bugs.webkit.org/show_bug.cgi?id=161830
3462
3463         Reviewed by Tim Horton.
3464
3465         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3466         (TestWebKitAPI::TEST_F):
3467
3468 2016-09-09  Alex Christensen  <achristensen@webkit.org>
3469
3470         Fix API tests after r205774.
3471         https://bugs.webkit.org/show_bug.cgi?id=161820
3472
3473         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3474         (TestWebKitAPI::TEST_F):
3475         I had committed the wrong expected path in one case. The functionality is correct.
3476
3477 2016-09-09  Michael Saboff  <msaboff@apple.com>
3478
3479         Unreviewed, rolling r205759 back in with a fix.
3480
3481         An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc,
3482         should be named "toString.baseline-jsc".  For systems with case-insensitive
3483         filesystems, the wrong name isn't an issue.  That rename is part of this
3484         fix.
3485
3486         * Scripts/run-javascriptcore-tests:
3487         (runJSCStressTests):
3488
3489 2016-09-09  Johan K. Jensen  <johan_jensen@apple.com>
3490
3491         Unreviewed. Added myself to the list of committers.
3492
3493         * Scripts/webkitpy/common/config/contributors.json:
3494
3495 2016-09-09  Alex Christensen  <achristensen@webkit.org>
3496
3497         URLParser should convert ASCII hosts to lowercase
3498         https://bugs.webkit.org/show_bug.cgi?id=161820
3499
3500         Reviewed by Geoffrey Garen.
3501
3502         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3503         (TestWebKitAPI::TEST_F):
3504
3505 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
3506
3507         Unreviewed, rolling out r205759.
3508
3509         This change broke all JSC tests
3510
3511         Reverted changeset:
3512
3513         "Add ChakraCore tests to run-javascriptcore-tests"
3514         https://bugs.webkit.org/show_bug.cgi?id=161808
3515         http://trac.webkit.org/changeset/205759
3516
3517 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
3518
3519         Revert r205770 because Ricky is already a committer.
3520
3521         Unreviewed.
3522
3523         * Scripts/webkitpy/common/config/contributors.json:
3524
3525 2016-09-09  Ricky Mondello  <rmondello@apple.com>
3526
3527         Unreviewed. Added myself to the list of committers.
3528
3529         * Scripts/webkitpy/common/config/contributors.json:
3530
3531 2016-09-09  Alex Christensen  <achristensen@webkit.org>
3532
3533         URLParser: Fix and optimize parsing file URLs ending with a host but no slash
3534         https://bugs.webkit.org/show_bug.cgi?id=161815
3535
3536         Reviewed by Geoffrey Garen.
3537
3538         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3539         (TestWebKitAPI::TEST_F):
3540
3541 2016-09-08  Dean Jackson  <dino@apple.com>
3542
3543         Expose Apple Pencil data to Touch events
3544         https://bugs.webkit.org/show_bug.cgi?id=161783
3545         <rdar://problem/28218898>
3546
3547         Reviewed by Beth Dakin.
3548
3549         The values that IOHID expects are different from their
3550         documentation, and from what UITouch interprets. Tweak
3551         incoming data so it will produce the output we expect.
3552
3553         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3554         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
3555         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
3556
3557 2016-09-09  JF Bastien  <jfbastien@apple.com>
3558
3559         Unreviewed. Added myself to the list of committers.
3560
3561         * Scripts/webkitpy/common/config/contributors.json:
3562
3563 2016-09-09  Michael Saboff  <msaboff@apple.com>
3564
3565         Add ChakraCore tests to run-javascriptcore-tests
3566         https://bugs.webkit.org/show_bug.cgi?id=161808
3567
3568         Reviewed by Saam Barati.
3569
3570         Added ChakraCore tests to the default list of tests to run.
3571
3572         * Scripts/run-javascriptcore-tests:
3573         (runJSCStressTests):
3574
3575 2016-09-09  Alex Christensen  <achristensen@webkit.org>
3576
3577         URLParser: Handle \ in path according to spec
3578         https://bugs.webkit.org/show_bug.cgi?id=161805
3579
3580         Reviewed by Andy Estes.
3581
3582         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3583         (TestWebKitAPI::TEST_F):
3584
3585 2016-09-09  Alex Christensen  <achristensen@webkit.org>
3586
3587         URLParser should parse URLs with non-special schemes
3588         https://bugs.webkit.org/show_bug.cgi?id=161786
3589
3590         Reviewed by Andy Estes.
3591
3592         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3593         (TestWebKitAPI::TEST_F):
3594
3595 2016-09-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3596
3597         [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
3598         https://bugs.webkit.org/show_bug.cgi?id=161763
3599
3600         Reviewed by Mark Lam.
3601
3602         Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
3603         that ASan crash does not occur with this patch.
3604
3605         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3606         (TestWebKitAPI::TEST):
3607         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3608         (TestWebKitAPI::TEST):
3609
3610 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3611
3612         URLParser: Handle \ in paths of special URLs according to spec
3613         https://bugs.webkit.org/show_bug.cgi?id=161781
3614
3615         Reviewed by Tim Horton.
3616
3617         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3618         (TestWebKitAPI::TEST_F):
3619
3620 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
3621
3622         Update the content-animation.plan file to run css-accelerated-animation.html
3623         and pull SVN revision r205680.
3624
3625         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
3626
3627 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
3628
3629         Add a content-animation test with accelerated CSS animations
3630         https://bugs.webkit.org/show_bug.cgi?id=161776
3631
3632         Reviewed by Dean Jackson.
3633
3634         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
3635
3636 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3637
3638         URLParser: Parsing empty URLs with a base URL should return the base URL
3639         https://bugs.webkit.org/show_bug.cgi?id=161777
3640
3641         Reviewed by Tim Horton.
3642
3643         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3644         (TestWebKitAPI::TEST_F):
3645
3646 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3647
3648         URLParser failures should preserve the original input string
3649         https://bugs.webkit.org/show_bug.cgi?id=161769
3650
3651         Reviewed by Tim Horton.
3652
3653         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3654         (TestWebKitAPI::TEST_F):
3655         (TestWebKitAPI::shouldFail):
3656
3657 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3658
3659         URLParser should parse URLs with a user but no password
3660         https://bugs.webkit.org/show_bug.cgi?id=161773
3661
3662         Reviewed by Brady Eidson.
3663
3664         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3665         (TestWebKitAPI::TEST_F):
3666
3667 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3668
3669         URLParser should parse ports after IPv4 and IPv6 hosts
3670         https://bugs.webkit.org/show_bug.cgi?id=161731
3671
3672         Reviewed by Brady Eidson.
3673
3674         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3675         (TestWebKitAPI::TEST_F):
3676
3677 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3678
3679         URLParser should correctly handle \ in path
3680         https://bugs.webkit.org/show_bug.cgi?id=161762
3681
3682         Reviewed by Brady Eidson.
3683
3684         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3685         (TestWebKitAPI::TEST_F):
3686
3687 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3688
3689         URLParser should handle URLs with empty authority
3690         https://bugs.webkit.org/show_bug.cgi?id=161711
3691
3692         Reviewed by Brady Eidson.
3693
3694         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3695         (TestWebKitAPI::TEST_F):
3696
3697 2016-09-08  Alex Christensen  <achristensen@webkit.org>
3698
3699         Re-land r205580 after r205649 fixed the test failures
3700         https://bugs.webkit.org/show_bug.cgi?id=161668
3701
3702         Re-landing changesets:
3703
3704         "Punycode encode non-ascii hosts in URLParser"
3705         https://bugs.webkit.org/show_bug.cgi?id=161655
3706         http://trac.webkit.org/changeset/205521
3707
3708         "Fix query-only and fragment-only relative URLs when using
3709         URLParser"
3710         https://bugs.webkit.org/show_bug.cgi?id=161657
3711         http://trac.webkit.org/changeset/205526
3712
3713         "URLParser should parse / as a relative URL"
3714         https://bugs.webkit.org/show_bug.cgi?id=161667
3715         http://trac.webkit.org/changeset/205532
3716
3717 2016-09-08  Dean Jackson  <dino@apple.com>
3718
3719         Expose Apple Pencil input to testing system
3720         https://bugs.webkit.org/show_bug.cgi?id=161670
3721         <rdar://problem/28183327>
3722
3723         I fixed the internal builds, now try to fix the public builds.
3724
3725         * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values.
3726
3727 2016-09-07  Dean Jackson  <dino@apple.com>
3728
3729         Expose Apple Pencil input to testing system
3730         https://bugs.webkit.org/show_bug.cgi?id=161670
3731         <rdar://problem/28183327>
3732
3733         Attempt to fix iOS 9 builds.
3734
3735         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3736         (-[HIDEventGenerator _createIOHIDEventType:]):
3737
3738 2016-09-07  Alex Christensen  <achristensen@webkit.org>
3739
3740         Roll out r205580 and r205582.
3741         https://bugs.webkit.org/show_bug.cgi?id=161668
3742
3743         I need to figure out why this is failing on the bots before landing any more URLParser progress.
3744
3745 2016-09-07  Alex Christensen  <achristensen@webkit.org>
3746
3747         Unreviewed, revert r205533.
3748         https://bugs.webkit.org/show_bug.cgi?id=161668
3749
3750         Re-landing changesets:
3751
3752         "Punycode encode non-ascii hosts in URLParser"
3753         https://bugs.webkit.org/show_bug.cgi?id=161655
3754         http://trac.webkit.org/changeset/205521
3755
3756         "Fix query-only and fragment-only relative URLs when using
3757         URLParser"
3758         https://bugs.webkit.org/show_bug.cgi?id=161657
3759         http://trac.webkit.org/changeset/205526
3760
3761         "URLParser should parse / as a relative URL"
3762         https://bugs.webkit.org/show_bug.cgi?id=161667
3763         http://trac.webkit.org/changeset/205532
3764
3765 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
3766
3767         Enable the <meter> element on iOS
3768         https://bugs.webkit.org/show_bug.cgi?id=161714
3769         rdar://problem/8978410
3770
3771         Reviewed by Tim Horton.
3772
3773         Define ENABLE_METER_ELEMENT unconditionally now.
3774
3775         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3776
3777 2016-09-07  Jonathan Bedard  <jbedard@apple.com>
3778
3779         Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests)
3780         https://bugs.webkit.org/show_bug.cgi?id=161699
3781
3782         Reviewed by Alexey Proskuryakov.
3783
3784         This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables.
3785
3786         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3787         (RunWebKitTests): Enable sample on timeout for everything.
3788         (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators.
3789
3790 2016-09-06  Dean Jackson  <dino@apple.com>
3791
3792         Expose Apple Pencil input to testing system
3793         https://bugs.webkit.org/show_bug.cgi?id=161670
3794         <rdar://problem/28183327>
3795
3796         Reviewed by Simon Fraser.
3797
3798         Add API to UIScriptController that allows a test to emulate
3799         stylus input, such as from the Apple Pencil.
3800
3801         The code is only implemented for WebKitTestRunner.
3802
3803         There are also four new tests that ensure an Apple Pencil
3804         operates similarly to a regular touch. The main difference
3805         is that you can't have multiple touches when using an Apple Pencil.
3806
3807         * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations.
3808         (WTR::UIScriptController::stylusDownAtPoint):
3809         (WTR::UIScriptController::stylusMoveToPoint):
3810         (WTR::UIScriptController::stylusUpAtPoint):
3811         (WTR::UIScriptController::stylusTapAtPoint):
3812         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods.
3813         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations.
3814         (WTR::UIScriptController::stylusDownAtPoint):
3815         (WTR::UIScriptController::stylusMoveToPoint):
3816         (WTR::UIScriptController::stylusUpAtPoint):
3817         (WTR::UIScriptController::stylusTapAtPoint):
3818         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3819
3820         * WebKitTestRunner/ios/HIDEventGenerator.h:
3821         * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties
3822         to SyntheticEventDigitizerInfo.
3823         (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types.
3824         (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info.
3825         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
3826         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
3827         (-[HIDEventGenerator stylusUpAtPoint:]):
3828         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3829         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3830         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3831         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3832         * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI.
3833         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API.
3834         (WTR::UIScriptController::stylusDownAtPoint):
3835         (WTR::UIScriptController::stylusMoveToPoint):
3836         (WTR::UIScriptController::stylusUpAtPoint):
3837         (WTR::UIScriptController::stylusTapAtPoint):
3838
3839 2016-09-07  Daniel Bates  <dabates@apple.com>
3840
3841         Update WebKitSystemInterface
3842
3843         Rubber-stamped by Dean Jackson.
3844
3845         Copy WebKitSystemInterface for iOS 10 to the built products directory.
3846
3847         * Scripts/copy-webkitlibraries-to-product-directory:
3848
3849 2016-09-07  Youenn Fablet  <youenn@apple.com>
3850
3851         [Streams API] Separate compile flag for ReadableStream and WritableStream
3852         https://bugs.webkit.org/show_bug.cgi?id=161044
3853
3854         Reviewed by Alex Christensen.
3855
3856         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
3857
3858         * Scripts/webkitperl/FeatureList.pm:
3859         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3860
3861 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3862
3863         [GTK] Move some GObject DOM unstable API to stable
3864         https://bugs.webkit.org/show_bug.cgi?id=161681
3865
3866         Reviewed by Žan Doberšek.
3867
3868         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
3869
3870         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3871         (testUserContentManagerScriptMessageFromDOMBindings):
3872         (serverCallback): Deleted.
3873         (beforeAll): Deleted.
3874         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3875         (documentLoadedCallback):
3876         (emitURIChanged): Deleted.
3877
3878 2016-09-07  Youenn Fablet  <youenn@apple.com>
3879
3880         Using tests-options.json to compute whether tests are slow
3881         https://bugs.webkit.org/show_bug.cgi?id=161626
3882
3883         Reviewed by Darin Adler.
3884
3885         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
3886         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3887         (Manager.__init__): Loading tests-options.json
3888         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
3889
3890 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
3891
3892         [EFL] Need the libosmesa to support the software backend drawing.
3893         https://bugs.webkit.org/show_bug.cgi?id=147065
3894
3895         Reviewed by Gyuyoung Kim.
3896
3897         Added the libosmesa to support the software backend drawing.
3898
3899         * efl/install-dependencies:
3900
3901 2016-09-06  Commit Queue  <commit-queue@webkit.org>
3902
3903         Unreviewed, rolling out r205521, r205526, and r205532.
3904         https://bugs.webkit.org/show_bug.cgi?id=161668
3905
3906         broke API tests (Requested by alexchristensen on #webkit).
3907
3908         Reverted changesets:
3909
3910         "Punycode encode non-ascii hosts in URLParser"
3911         https://bugs.webkit.org/show_bug.cgi?id=161655
3912         http://trac.webkit.org/changeset/205521
3913
3914         "Fix query-only and fragment-only relative URLs when using
3915         URLParser"
3916         https://bugs.webkit.org/show_bug.cgi?id=161657
3917         http://trac.webkit.org/changeset/205526
3918
3919         "URLParser should parse / as a relative URL"
3920         https://bugs.webkit.org/show_bug.cgi?id=161667
3921         http://trac.webkit.org/changeset/205532
3922
3923 2016-09-06  Alex Christensen  <achristensen@webkit.org>
3924
3925         URLParser should parse / as a relative URL
3926         https://bugs.webkit.org/show_bug.cgi?id=161667
3927
3928         Reviewed by Tim Horton.
3929
3930         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3931         (TestWebKitAPI::TEST_F):
3932
3933 2016-09-06  Daniel Bates  <dabates@apple.com>
3934
3935         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
3936         https://bugs.webkit.org/show_bug.cgi?id=161661
3937
3938         Reviewed by Darin Adler.
3939
3940         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
3941         command line tools for simulator with the iOS 10 beta SDK.
3942
3943         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3944         * WebKitTestRunner/Configurations/Base.xcconfig:
3945
3946 2016-09-06  Alex Christensen  <achristensen@webkit.org>
3947
3948         Fix query-only and fragment-only relative URLs when using URLParser
3949         https://bugs.webkit.org/show_bug.cgi?id=161657
3950
3951         Reviewed by Tim Horton.
3952
3953         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3954         (TestWebKitAPI::TEST_F):
3955
3956 2016-09-06  Alex Christensen  <achristensen@webkit.org>
3957
3958         Punycode encode non-ascii hosts in URLParser
3959         https://bugs.webkit.org/show_bug.cgi?id=161655
3960
3961         Reviewed by Tim Horton.
3962
3963         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3964         (TestWebKitAPI::wideString):
3965         (TestWebKitAPI::TEST_F):
3966
3967 2016-09-05  Alex Christensen  <achristensen@webkit.org>
3968
3969         Implement relative file urls and begin implementing character encoding in URLParser
3970         https://bugs.webkit.org/show_bug.cgi?id=161618
3971
3972         Reviewed by Tim Horton.
3973
3974         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3975         (TestWebKitAPI::TEST_F):
3976
3977 2016-09-06  Commit Queue  <commit-queue@webkit.org>
3978
3979         Unreviewed, rolling out r205480.
3980         https://bugs.webkit.org/show_bug.cgi?id=161630
3981
3982         tests-options.json is not known from knockout filesystem
3983         (Requested by youenn on #webkit).
3984
3985         Reverted changeset:
3986
3987         "Using tests-options.json to compute whether tests are slow"
3988         https://bugs.webkit.org/show_bug.cgi?id=161626
3989         http://trac.webkit.org/changeset/205480
3990
3991 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3992
3993         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
3994         https://bugs.webkit.org/show_bug.cgi?id=161606
3995
3996         Reviewed by Darin Adler.
3997
3998         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
3999         time.
4000
4001         * Scripts/prepare-ChangeLog:
4002         (statusDescription):
4003
4004 2016-09-06  Youenn Fablet  <youenn@apple.com>
4005
4006         Using tests-options.json to compute whether tests are slow
4007         https://bugs.webkit.org/show_bug.cgi?id=161626
4008
4009         Reviewed by Darin Adler.
4010
4011         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4012         (Manager.__init__): Loading tests-options.json
4013         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
4014
4015 2016-09-06  Commit Queue  <commit-queue@webkit.org>
4016
4017         Unreviewed, rolling out r205461.
4018         https://bugs.webkit.org/show_bug.cgi?id=161628
4019
4020         Introduced "Use of uninitialized value $original in sprintf"
4021         warning (Requested by mcatanzaro on #webkit).
4022
4023         Reverted changeset:
4024
4025         ""Redundant argument in sprintf" warning spam from prepare-
4026         ChangeLog"
4027         https://bugs.webkit.org/show_bug.cgi?id=161606
4028         http://trac.webkit.org/changeset/205461
4029
4030 2016-09-06  Youenn Fablet  <youenn@apple.com>
4031
4032         W3C test importer should be able to identify slow test
4033         https://bugs.webkit.org/show_bug.cgi?id=161601
4034
4035         Reviewed by Darin Adler.
4036
4037         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
4038         Test importer is updating test-options.json file according that information.
4039
4040         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
4041
4042         * Scripts/webkitpy/w3c/test_importer.py:
4043         (TestImporter.__init__):
4044         (TestImporter.find_importable_tests):
4045         (TestImporter.import_tests):
4046         (TestImporter.update_test_options):
4047         (TestImporter):
4048         (TestImporter.remove_slow_from_w3c_test_options):
4049         * Scripts/webkitpy/w3c/test_parser.py:
4050         (TestParser.analyze_test):
4051         (TestParser.is_slow_test):
4052         (TestParser.potential_ref_filename):
4053
4054 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
4055
4056         [Win] Crash logs have incorrect symbols.
4057         https://bugs.webkit.org/show_bug.cgi?id=161603
4058
4059         Reviewed by Darin Adler.
4060
4061         Add build path to _NT_SYMBOL_PATH environment variable.
4062
4063         * Scripts/webkitpy/port/win.py:
4064         (WinPort.setup_crash_log_saving):
4065
4066 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
4067
4068         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
4069         https://bugs.webkit.org/show_bug.cgi?id=160125
4070
4071         Reviewed by Geoffrey Garen and Keith Miller.
4072
4073         * DumpRenderTree/TestRunner.cpp:
4074         * DumpRenderTree/mac/DumpRenderTree.mm:
4075         (DumpRenderTreeMain):
4076         * Scripts/run-jsc-stress-tests:
4077         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4078         (TestWebKitAPI::TEST):
4079
4080 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
4081
4082         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
4083         https://bugs.webkit.org/show_bug.cgi?id=161606
4084
4085         Reviewed by Darin Adler.
4086
4087         Avoid extra arguments in call to sprintf.
4088
4089         * Scripts/prepare-ChangeLog:
4090         (statusDescription):
4091
4092 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
4093
4094         [GTK] Skip several failing API tests
4095
4096         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
4097         them after bugs are filed.
4098
4099         * Scripts/run-gtk-tests:
4100         (TestRunner):
4101
4102 2016-09-05  Youenn Fablet  <youenn@apple.com>
4103
4104         Fix W3C test importer unit tests after r205447
4105         https://bugs.webkit.org/show_bug.cgi?id=161604
4106
4107         Unreviewed.
4108
4109         * Scripts/webkitpy/w3c/test_importer.py:
4110         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
4111
4112 2016-09-05  Philippe Normand  <pnormand@igalia.com>
4113
4114         WebRTC: Several media stream tests crashing
4115         https://bugs.webkit.org/show_bug.cgi?id=161582
4116
4117         Reviewed by Alejandro G. Castro.
4118
4119         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
4120         glvideoflip GStreamer element.
4121
4122 2016-09-05  Youenn Fablet  <youenn@apple.com>
4123
4124         W3C test importer should generate the list of resource files
4125         https://bugs.webkit.org/show_bug.cgi?id=161578
4126
4127         Reviewed by Ryosuke Niwa.
4128
4129         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
4130
4131         * Scripts/webkitpy/w3c/test_importer.py:
4132         (TestImporter.__init__): Reading test resource files configuration file.
4133         (TestImporter.find_importable_tests):
4134         (TestImporter.import_tests): Update the test resource files based on test parsed files.
4135         (TestImporter):
4136         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
4137         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
4138
4139 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4140
4141         Media controls behave strangely when videos mute from within a playing handler
4142         https://bugs.webkit.org/show_bug.cgi?id=161559
4143         <rdar://problem/28018438>
4144
4145         Reviewed by Darin Adler.
4146
4147         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
4148         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
4149         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
4150         clicking or scrolling.
4151
4152         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4153         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
4154         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
4155         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
4156         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
4157         (TestWebKitAPI::TEST):
4158         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
4159         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
4160         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
4161         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
4162         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
4163         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
4164         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
4165         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
4166         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
4167         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
4168
4169 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4170
4171         Refactor the heuristic for showing media controls to take all media sessions into account
4172         https://bugs.webkit.org/show_bug.cgi?id=161503
4173         <rdar://problem/28033783>
4174
4175         Reviewed by Darin Adler.
4176
4177         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
4178         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
4179         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
4180         tests more readable.
4181
4182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4183         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4184         (-[MessageHandler initWithMessage:handler:]):
4185         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
4186         (-[VideoControlsManagerTestWebView performAfterLoading:]):
4187         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
4188         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
4189         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
4190         (-[VideoControlsManagerTestWebView controlledElementID]):
4191         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
4192         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
4193         (TestWebKitAPI::TEST):
4194         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
4195         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
4196         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
4197         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
4198         (-[WKWebView performAfterLoading:]): Deleted.
4199         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
4200         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
4201         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
4202         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
4203         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
4204         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
4205
4206 2016-09-03  Youenn Fablet  <youenn@apple.com>
4207
4208         run-webkit-tests should detect w3c test resource files
4209         https://bugs.webkit.org/show_bug.cgi?id=161307
4210
4211         Reviewed by Ryosuke Niwa.
4212
4213         * Scripts/webkitpy/port/base.py:
4214         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
4215         (Port.potential_test_names_from_expected_file):
4216         (Port._real_tests):
4217         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
4218         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
4219         (Port): Deleted.
4220         * Scripts/webkitpy/port/base_unittest.py:
4221         (PortTest.test_additional_platform_directory):
4222         (PortTest.test_find_no_paths_specified):
4223         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
4224         (PortTest.test_is_w3c_resource_file): Adding tests.
4225
4226 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4227
4228         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
4229
4230         * BuildSlaveSupport/built-product-archive:
4231         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
4232         that no longer exist.
4233
4234 2016-09-02  Alex Christensen  <achristensen@webkit.org>
4235
4236         URLParser should parse file URLs
4237         https://bugs.webkit.org/show_bug.cgi?id=161556
4238
4239         Reviewed by Tim Horton.
4240
4241         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4242         (TestWebKitAPI::TEST_F):
4243         (TestWebKitAPI::checkURLDifferences):
4244
4245 2016-09-01  Michael Saboff  <msaboff@apple.com>
4246
4247         Import Chakra tests to JSC
4248         https://bugs.webkit.org/show_bug.cgi?id=154697
4249
4250         Reviewed by Saam Barati.
4251
4252         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
4253         Chakra tests.
4254
4255         * Scripts/run-jsc-stress-tests:
4256
4257 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
4258
4259         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
4260         https://bugs.webkit.org/show_bug.cgi?id=42547
4261  
4262         Reviewed by Darin Adler.
4263
4264         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
4265         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
4266
4267         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
4268         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4269         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
4270         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4271         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
4272         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
4273         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
4274         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
4275         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
4276         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
4277         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
4278
4279 2016-09-02  Jer Noble  <jer.noble@apple.com>
4280
4281         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
4282
4283         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
4284         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
4285
4286 2016-09-02  Tim Horton  <timothy_horton@apple.com>
4287
4288         REGRESSION (r205329): Two API tests time out on iOS Simulator
4289         https://bugs.webkit.org/show_bug.cgi?id=161542
4290
4291         Reviewed by Brady Eidson.
4292
4293         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
4294         (createAnimatedResizeWebView):
4295         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
4296         (TEST):
4297         (animatedResizeWebView): Deleted.
4298         The navigation delegate was being stored in a local and went out of scope
4299         before the test was over. Keep it around, instead.
4300
4301 2016-08-31  Jer Noble  <jer.noble@apple.com>
4302
4303         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
4304         https://bugs.webkit.org/show_bug.cgi?id=161462
4305
4306         Reviewed by Eric Carlson.
4307
4308         XCTest targets need to be in the same project as the application which they're testing. To facilitate
4309         having external projects with XCTest targets, move the application's implementation into a framework
4310         that can be included with a bare-bones application shell for testing.
4311
4312         Simultaneously, add the ability to load files from within the new framework's bundle by using a
4313         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
4314         an external server for testing.
4315
4316         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4317         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
4318         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
4319         * MobileMiniBrowser/MobileMiniBrowser/main.m:
4320         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
4321         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
4322         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
4323             controller from the framework's bundle.
4324         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
4325         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
4326         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
4327         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
4328         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
4329         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
4330         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
4331         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
4332         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
4333         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
4334         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
4335             pointing to the framework's resources directory.
4336         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
4337         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
4338         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
4339
4340 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
4341
4342         Fix --no-sample-on-timeout command line argument
4343         https://bugs.webkit.org/show_bug.cgi?id=161507
4344
4345         Reviewed by Alexey Proskuryakov.
4346