2011-03-29 David Levin <levin@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-03-29  David Levin  <levin@chromium.org>
2
3         Reviewed by Shinichiro Hamaji.
4
5         check-webkit-style confused by two ChangeLog entries in a row from same user
6         https://bugs.webkit.org/show_bug.cgi?id=57250
7
8         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
9         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
10         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
11           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
12           checking more than that would be very messey.
13         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
14         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
15
16 2011-03-29  Kent Tamura  <tkent@chromium.org>
17
18         Reviewed by Dimitri Glazkov.
19
20         [Mac] Enable interactive-validation tests on Mac DRT
21         https://bugs.webkit.org/show_bug.cgi?id=57308
22
23         * DumpRenderTree/mac/DumpRenderTree.mm:
24         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
25
26 2011-03-29  Chang Shu  <cshu@webkit.org>
27
28         Reviewed by Kenneth Rohde Christiansen.
29
30         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
31         https://bugs.webkit.org/show_bug.cgi?id=42692
32
33         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
34         (WTR::InjectedBundle::beginTesting):
35         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
36         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
37         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
38
39 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
40
41         Reviewed by Xan Lopez.
42
43         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
44         https://bugs.webkit.org/show_bug.cgi?id=57067
45
46         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
47         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
48         update DRT and pixel results as hundreds of results will need to be updated.
49
50         * DumpRenderTree/gtk/DumpRenderTree.cpp:
51         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
52         by overriding the theme RC/CSS files.
53
54 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
55
56         Reviewed by Adam Roben.
57
58         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
59         https://bugs.webkit.org/show_bug.cgi?id=57394
60
61         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
62         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
63         the IDE. To avoid this, add a separate vsprops file for each project configuration that
64         contains the required inherited property sheets.
65
66         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
67         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
68         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
69         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
70         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
71         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
72         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
73         * DumpRenderTree/win/DumpRenderTree.vcproj:
74         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
75         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
76         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
77         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
78         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
79         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
80         * DumpRenderTree/win/ImageDiff.vcproj:
81         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
82         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
83         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
84         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
85         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
86         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
87         * FindSafari/FindSafari.vcproj:
88         * FindSafari/FindSafariDebug.vsprops: Added.
89         * FindSafari/FindSafariDebugAll.vsprops: Added.
90         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
91         * FindSafari/FindSafariRelease.vsprops: Added.
92         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
93         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
94         * FindSafari/FindSafariReleasePGO.vsprops: Added.
95         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
96         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
97         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
98         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
99         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
100         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
101         * MiniBrowser/MiniBrowser.vcproj:
102         * WebKitAPITest/WebKitAPITest.vcproj:
103         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
104         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
105         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
106         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
107         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
108         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
109         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
110         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
111         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
112         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
113         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
114         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
115         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
116         * WebKitTestRunner/win/InjectedBundle.vcproj:
117         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
118         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
119         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
120         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
121         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
122         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
123         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
124         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
125         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
126         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
127         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
128         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
129         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
130         * WinLauncher/WinLauncher.vcproj:
131         * WinLauncher/WinLauncherDebug.vsprops: Added.
132         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
133         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
134         * WinLauncher/WinLauncherRelease.vsprops: Added.
135         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
136         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
137         * record-memory-win/record-memory-win.vcproj:
138         * record-memory-win/record-memory-winDebug.vsprops: Added.
139         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
140         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
141         * record-memory-win/record-memory-winRelease.vsprops: Added.
142         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
143         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
144
145 2011-03-29  Adam Barth  <abarth@webkit.org>
146
147         Reviewed by Darin Adler.
148
149         test_runner2.py can crash due to undefined variable
150         https://bugs.webkit.org/show_bug.cgi?id=57356
151
152         Replace reference to undefined variable with a variable that's actually
153         defined.  AFAICT, there's no way to test this code.
154
155         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
156
157 2011-03-29  Tony Chang  <tony@chromium.org>
158
159         Reviewed by Eric Seidel.
160
161         cleanup rebaseline-chromium-webkit-tests
162         https://bugs.webkit.org/show_bug.cgi?id=57375
163
164         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
165             - Split _extract_and_add_new_baselines into 3 functions
166             - Reduce the amount of line wrapping (the file already has lines
167               over 80 col, so may as well try to make the file consistent)
168             - Remove unnecessary ()s
169
170 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
171
172         Reviewed by Adam Roben.
173
174         Make WinCairo a core builder.
175         https://bugs.webkit.org/show_bug.cgi?id=57373
176
177         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
178         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
179
180 2011-03-29  Timothy Hatcher  <timothy@apple.com>
181
182         Update update-webkit-localizable-strings to understand that WebKit and
183         WebKit2 strings go in WebCore.
184
185         Also make extract-localizable-strings optionally use an exclude file. No individual
186         warnings are produced about unlocalized strings when there is no exclude file. This
187         is needed for WebCore, since there are too many bare strings.
188
189         https://webkit.org/b/57354
190
191         Reviewed by Sam Weinig.
192
193         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
194         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
195
196 2011-03-29  Darin Adler  <darin@apple.com>
197
198         Reviewed by Adam Roben.
199
200         WebKit2 bundle page needs to offer generated file hooks
201         https://bugs.webkit.org/show_bug.cgi?id=57279
202
203         (Land missing part of the original patch after r82289.)
204
205         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
206         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
207
208 2011-03-29  Tony Chang  <tony@chromium.org>
209
210         Reviewed by Ojan Vafai.
211
212         [chromium] NRWT should be able to read checksums from png comments
213         https://bugs.webkit.org/show_bug.cgi?id=57280
214
215         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
216             from a file.
217         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
218         * Scripts/webkitpy/common/system/filesystem_mock.py:
219         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
220             if the -checksum.txt file doesn't exist, try looking in the png.
221         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
222         * Scripts/webkitpy/layout_tests/port/test.py:
223         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
224             2k for a png comment with the checksum
225         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
226
227 2011-03-29  Philippe Normand  <pnormand@igalia.com>
228
229         Rubber-stamped by Gustavo Noronha Silva.
230
231         [GTK] http/tests/uri/username-with-no-hostname.html fails
232         https://bugs.webkit.org/show_bug.cgi?id=57325
233
234         * DumpRenderTree/gtk/DumpRenderTree.cpp:
235         (willSendRequestCallback): URI host value check done case-insensitively.
236
237 2011-03-29  Philippe Normand  <pnormand@igalia.com>
238
239         Reviewed by Martin Robinson.
240
241         [GTK] http/tests/uri/username-with-no-hostname.html fails
242         https://bugs.webkit.org/show_bug.cgi?id=57325
243
244         * DumpRenderTree/gtk/DumpRenderTree.cpp:
245         (willSendRequestCallback): Check URI before submitting the request
246         to WebCore.
247
248 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
249
250         Reviewed by Ojan Vafai.
251
252         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
253         https://bugs.webkit.org/show_bug.cgi?id=57303
254
255         * DumpRenderTree/chromium/EventSender.cpp:
256         (EventSender::doDragDrop):
257         (EventSender::beginDragWithFiles):
258
259 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
260
261         Reviewed by Andreas Kling.
262
263         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
264         https://bugs.webkit.org/show_bug.cgi?id=57314
265
266         Provide possibility to print loaded urls to the standard output.
267
268         * MiniBrowser/qt/BrowserWindow.cpp:
269         (BrowserWindow::BrowserWindow):
270         (BrowserWindow::printURL):
271         * MiniBrowser/qt/BrowserWindow.h:
272         * MiniBrowser/qt/MiniBrowserApplication.cpp:
273         (MiniBrowserApplication::handleUserOptions):
274         * MiniBrowser/qt/MiniBrowserApplication.h:
275         (WindowOptions::WindowOptions):
276         * QtTestBrowser/launcherwindow.cpp:
277         (LauncherWindow::initializeView):
278         (LauncherWindow::printURL):
279         (LauncherWindow::cloneWindow):
280         * QtTestBrowser/launcherwindow.h:
281         (WindowOptions::WindowOptions):
282         * QtTestBrowser/main.cpp:
283         (LauncherApplication::handleUserOptions):
284
285 2011-03-29  Gabor Loki  <loki@webkit.org>
286
287         Rubber-stamped by Csaba Osztrogonác.
288
289         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
290         https://bugs.webkit.org/show_bug.cgi?id=56918
291
292         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
293
294 2011-03-28  Gabor Loki  <loki@webkit.org>
295
296         Reviewed by Csaba Osztrogonác.
297
298         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
299         https://bugs.webkit.org/show_bug.cgi?id=56918
300
301         * Scripts/build-jsc:
302         * Scripts/webkitdirs.pm:
303
304 2011-03-28  Andrew Foster  <andrewf@chromium.org>
305
306         Reviewed by Ojan Vafai.
307
308         webkit-patch should be more intelligent about whether a bug applies to a patch
309         Create a new function, parse_bug_id_from_changelog() which determines
310         that a bug is related to a patch by parsing the output generated from
311         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
312         the description of a patch.
313         https://bugs.webkit.org/show_bug.cgi?id=56989
314
315         * Scripts/webkitpy/common/checkout/api.py:
316         * Scripts/webkitpy/common/checkout/changelog.py:
317         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
318         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
319         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
320         * Scripts/webkitpy/style/checkers/changelog.py:
321         * Scripts/webkitpy/tool/commands/upload.py:
322
323 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
324
325         Revert accidentally commited change.
326
327         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
328         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
329
330 2011-03-28  Tony Chang  <tony@chromium.org>
331
332         Reviewed by Adam Barth.
333
334         [chromium] have DRT write the png checksum into a png comment
335         https://bugs.webkit.org/show_bug.cgi?id=57255
336
337         * DumpRenderTree/chromium/TestShell.cpp:
338         (TestShell::dumpImage):
339
340 2011-03-28  Adele Peterson  <adele@apple.com>
341
342         Removing Qt stub, since it doesn't use the same header as the others.
343
344         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
345
346 2011-03-28  Adele Peterson  <adele@apple.com>
347
348         Added a few more stubs.
349
350         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
351         (LayoutTestController::hasGrammarMarker):
352         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
353         (LayoutTestController::hasGrammarMarker):
354         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
355         (LayoutTestController::hasGrammarMarker):
356
357 2011-03-28  Adele Peterson  <adele@apple.com>
358
359         Build fix.
360
361         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
362         (LayoutTestController::hasGrammarMarker):
363
364 2011-03-28  Adele Peterson  <adele@apple.com>
365
366         Reviewed by Eric Seidel.
367
368         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
369         https://bugs.webkit.org/show_bug.cgi?id=57173
370
371         * DumpRenderTree/LayoutTestController.cpp:
372         (hasGrammarMarkerCallback): Added.
373         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
374         * DumpRenderTree/LayoutTestController.h:
375         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
376         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
377
378 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
379
380         Reviewed by Benjamin Poulain.
381
382         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
383         https://bugs.webkit.org/show_bug.cgi?id=57087
384
385         Trivial typo fix after r82082.
386
387         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
388         (WTR::activateFonts):
389
390 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
391
392         Reviewed by Andreas Kling.
393
394         Add myself to the committers list.
395
396         * Scripts/webkitpy/common/config/committers.py:
397
398 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
399
400         Reviewed by Sam Weinig.
401
402         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
403         to link against WebKit.framework for now.
404
405         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
406
407 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
408
409         Reviewed by Andreas Kling.
410
411         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
412         https://bugs.webkit.org/show_bug.cgi?id=57087
413
414         Disable QT_ASCII_CAST_WARNINGS for applications.
415
416         * DumpRenderTree/qt/DumpRenderTree.pro:
417         * DumpRenderTree/qt/ImageDiff.pro:
418         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
419         * MiniBrowser/qt/MiniBrowser.pro:
420         * QtTestBrowser/QtTestBrowser.pro:
421         * WebKitTestRunner/qt/WebKitTestRunner.pro:
422
423 2011-03-28  Andreas Kling  <kling@webkit.org>
424
425         Reviewed by Kenneth Rohde Christiansen.
426
427         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
428         https://bugs.webkit.org/show_bug.cgi?id=57224
429
430         * QtTestBrowser/mainwindow.cpp:
431         (MainWindow::buildUI):
432         (MainWindow::onTitleChanged):
433         * QtTestBrowser/mainwindow.h:
434
435 2011-03-27  Jer Noble  <jer.noble@apple.com>
436
437         Reviewed by Maciej Stachowiak.
438
439         Full Screen: disable keyboard access by default
440         https://bugs.webkit.org/show_bug.cgi?id=56684
441
442         Accept the withKeyboard parameter to supportsFullScreenForElement.
443
444         * DumpRenderTree/mac/UIDelegate.mm:
445         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
446
447 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
448
449         Reviewed by David Levin.
450
451         check-webkit-style should check ChangeLog for a valid bug number
452         https://bugs.webkit.org/show_bug.cgi?id=57184
453
454         * Scripts/webkitpy/style/checker.py:
455         * Scripts/webkitpy/style/checker_unittest.py:
456         * Scripts/webkitpy/style/checkers/changelog.py: Added.
457         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
458
459 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
460
461         Reviewed by Andreas Kling.
462
463         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
464         https://bugs.webkit.org/show_bug.cgi?id=57087
465
466         Use explicit conversion for string to avoid depending on the default codec
467         installed by the user code.
468
469         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
470         (WTR::activateFonts):
471
472 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
473
474         Revert inadvertantly committed changes.
475
476         * Scripts/old-run-webkit-tests:
477         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
478
479 2011-03-26  Andreas Kling  <kling@webkit.org>
480
481         Reviewed by Kenneth Rohde Christiansen.
482
483         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
484         https://bugs.webkit.org/show_bug.cgi?id=57162
485
486         * QtTestBrowser/QtTestBrowser.qrc:
487         * QtTestBrowser/favicon.png: Added.
488         * QtTestBrowser/locationedit.cpp:
489         (defaultPageIcon):
490         (LocationEdit::LocationEdit):
491         (LocationEdit::setPageIcon):
492         (LocationEdit::resizeEvent):
493         (LocationEdit::updateInternalGeometry):
494         * QtTestBrowser/locationedit.h:
495         * QtTestBrowser/mainwindow.cpp:
496         (MainWindow::buildUI):
497         (MainWindow::onIconChanged):
498         (MainWindow::onLoadStarted):
499         * QtTestBrowser/mainwindow.h:
500
501 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
502
503         Reviewed by Xan Lopez.
504
505         [GTK] Force DumpRenderTree to use 96 DPI
506         https://bugs.webkit.org/show_bug.cgi?id=56866
507
508         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
509         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
510
511         * DumpRenderTree/gtk/DumpRenderTree.cpp:
512         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
513         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
514         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
515
516 2011-03-25  Andy Estes  <aestes@apple.com>
517
518         Reviewed by Adele Peterson.
519
520         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
521         https://bugs.webkit.org/show_bug.cgi?id=49016
522
523         TestNetscapePlugIn needs to register support for an image MIME type so
524         we can test that the embed tag prefers plug-ins to render image MIME
525         types.
526
527         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
528         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
529         (NP_GetMIMEDescription): Ditto.
530         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
531
532 2011-03-25  Jessie Berlin  <jberlin@apple.com>
533
534         Reviewed by Sam Weinig.
535
536         WebKit2: Need to be able to set and get the Cookie Storage Policy.
537         https://bugs.webkit.org/show_bug.cgi?id=50780
538
539         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
540
541         The test is named "CookieManager" so that we can eventually exercise more of the
542         CookieManager functionality in the test.
543
544         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
545         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
546         Assert that the policy returned is equal to the policy set in
547         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
548         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
549         Set the policy to something different than the user's policy and get the policy again.
550         (TestWebKitAPI::didFinishLoadForFrame):
551         Get the user's policy so that it can be restored at the end of the test.
552         (TestWebKitAPI::TEST):
553         Load about:blank so that the Web Process gets instatiated (needed to get the
554         CookieManager).
555
556         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
557         Add CookieManager.cpp.
558
559 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
560
561         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
562
563         * wx/build/settings.py:
564
565 2011-03-24  Ilya Sherman  <isherman@chromium.org>
566
567         Reviewed by Adam Roben.
568
569         Implement layoutTestController.setAutoFilled in DRT on Windows
570         https://bugs.webkit.org/show_bug.cgi?id=56828
571
572         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
573         (LayoutTestController::setAutofilled): Implemented.
574
575 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
576
577         Unreviewed build correction.
578
579         Correct vsprops file for Debug variant of the CFLite build.
580         Disable a CFNETWORK-specific test when building for CFLite.
581
582         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
583         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
584
585 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
586
587         Reviewed by Adam Barth.
588
589         fix regressions introduced in 81908 - there were a couple of
590         code paths that only fired under python 2.5 that I missed.
591
592         Also change a couple of 'python' references to sys.executable
593         in order to handle runing test-webkitpy with a binary other than
594         something called 'python'.
595
596         https://bugs.webkit.org/show_bug.cgi?id=57063
597
598         * Scripts/webkitpy/layout_tests/port/mac.py:
599         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
600         * Scripts/webkitpy/test/cat.py:
601         * Scripts/webkitpy/test/echo.py:
602
603 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
604
605         Unreviewed build correction.
606
607         Add a stub implementation of the TestInvocation dumping logic.
608         Update project files to reflect new file.
609
610         * WebKitTestRunner/cairo: Added.
611         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
612         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
613         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
614
615 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
616
617         Reviewed by Tony Chang.
618
619         new-run-webkit-tests: clean up worker model defaults. This
620         changes the default behavior to 'threads' instead of
621         'old-threads', and clarifies that chromium-win-* and
622         chromium-mac-leopard are exceptions.
623
624         https://bugs.webkit.org/show_bug.cgi?id=56971
625
626         * Scripts/webkitpy/layout_tests/port/base.py:
627         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
628         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
629         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
630         * Scripts/webkitpy/layout_tests/port/test.py:
631         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
632
633 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
634
635         Reviewed by Darin Adler.
636
637         Media Stream API: fix the order of the options in build-webkit.
638         https://bugs.webkit.org/show_bug.cgi?id=56949
639
640         Fix the order of the options in build-webkit.
641
642         * Scripts/build-webkit:
643
644 2011-03-23  Adam Klein  <adamk@chromium.org>
645
646         Reviewed by Mihai Parparita.
647
648         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
649         https://bugs.webkit.org/show_bug.cgi?id=56884
650
651         This option will be utilized by Chromium's ui_tests to allow
652         referencing js-test-resources from a layout test over HTTP.
653
654         * Scripts/new-run-webkit-httpd:
655         Added --layout_tests_dir option.
656         * Scripts/webkitpy/layout_tests/port/http_server.py:
657         Plumbed through as layout_tests_dir param.
658
659 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
660
661         Reviewed by Mihai Parparita.
662
663         new-run-webkit-tests: run tests in ascending alphabetical order per
664         dir. This is a second attempt at the fix; the first attempt, in 
665         r81597, broke the behavior on the old-inline and old-threads
666         worker models.
667
668         https://bugs.webkit.org/show_bug.cgi?id=56760
669
670         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
671         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
672         * Scripts/webkitpy/layout_tests/port/test.py:
673         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
674
675 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
676
677         Reviewed by Martin Robinson.
678
679         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
680         https://bugs.webkit.org/show_bug.cgi?id=56953
681
682         Print the string for the detail of 'property-change' signal.
683
684         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
685         (axObjectEventListener): Print the detail string.
686
687 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
688
689         Reviewed by Pavel Feldman.
690
691         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
692         https://bugs.webkit.org/show_bug.cgi?id=56843
693
694         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
695         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
696
697 2011-03-22  Eric Seidel  <eric@webkit.org>
698
699         Reviewed by Adam Barth.
700
701         Teach update-webkit about gyp
702         https://bugs.webkit.org/show_bug.cgi?id=56881
703
704         This makes it possible for someone who builds from Xcode
705         to just run update-webkit --gyp and have the project files
706         generated after update automatically.
707
708         I also added a stand-alone "generate-project-files" script
709         wrapping Source/gyp/configure.  This makes running gyp simpler
710         since most people will not have gyp or Source/gyp in their path.
711
712         * Scripts/build-webkit:
713         * Scripts/generate-project-files: Added.
714         * Scripts/update-webkit:
715
716 2011-03-22  Anton D'Auria  <adauria@apple.com>
717
718         Reviewed by Alexey Proskuryakov.
719
720         Add +[WebApplicationCache getOriginsWithCache]
721         https://bugs.webkit.org/show_bug.cgi?id=56722
722
723         * DumpRenderTree/LayoutTestController.cpp:
724         (originsWithApplicationCacheCallback):
725         (LayoutTestController::staticFunctions):
726         * DumpRenderTree/LayoutTestController.h:
727         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
728         (LayoutTestController::originsWithApplicationCache):
729         * DumpRenderTree/chromium/LayoutTestController.h:
730         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
731         (LayoutTestController::originsWithApplicationCache):
732         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
733         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
734         (LayoutTestController::originsWithApplicationCache):
735         (LayoutTestController::originsWithLocalStorage):
736         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
737         (LayoutTestController::originsWithApplicationCache):
738         * DumpRenderTree/qt/LayoutTestControllerQt.h:
739         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
740         (LayoutTestController::originsWithApplicationCache):
741         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
742         (LayoutTestController::originsWithApplicationCache):
743
744 2011-03-22  Eric Seidel  <eric@webkit.org>
745
746         Reviewed by Adam Barth.
747
748         Add support to build-webkit for building with gyp-generated project files
749         https://bugs.webkit.org/show_bug.cgi?id=56877
750
751         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
752         Eventually we'll want to support gyp-generated projects in a more general manner.
753
754         * Scripts/build-webkit:
755
756 2011-03-22  David Kilzer  <ddkilzer@apple.com>
757
758         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
759
760         Reviewed by Joseph Pecoraro.
761
762         * Scripts/build-webkit: Updated usage statement to include
763         --dsym.
764         * Scripts/webkitdirs.pm: Added $generateDsym variable.
765         (generateDsym): Added. Call determineGenerateDsym() and
766         return $generateDsym.
767         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
768         $generateDsym.
769         (argumentsForXcode): Added.  Returns additional arguments for
770         xcodebuild based on command-line switches.
771         (XcodeOptions): Updated to include argumentsForXcode() in the
772         array returned.
773
774 2011-03-22  Adam Roben  <aroben@apple.com>
775
776         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
777
778         These bots are consistently green again.
779
780         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
781         core builders
782
783         Rubber-stamped by Antti Koivisto.
784
785         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
786         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
787
788         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
789         (BuildBotTest.test_builder_name_regexps): Updated expectations.
790
791 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
792
793         Unreviewed, rolling out r81597.
794         http://trac.webkit.org/changeset/81597
795         https://bugs.webkit.org/show_bug.cgi?id=56801
796
797         Change results in lots of unexpected flaky on the dashboard.
798         (Requested by pfeldman on #webkit).
799
800         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
801         * Scripts/webkitpy/layout_tests/port/test.py:
802         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
803
804 2011-03-21  Sam Weinig  <sam@webkit.org>
805
806         Fix failing tests on the WebKit2 bots.
807
808         * WebKitTestRunner/TestController.cpp:
809         (WTR::TestController::resetStateToConsistentValues):
810
811 2011-03-21  Daniel Sievers  <sievers@google.com>
812
813         Reviewed by Simon Fraser.
814
815         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
816         https://bugs.webkit.org/show_bug.cgi?id=56139
817
818         * DumpRenderTree/chromium/DumpRenderTree.cpp:
819         (main):
820         * DumpRenderTree/chromium/LayoutTestController.cpp:
821         (LayoutTestController::LayoutTestController):
822         (LayoutTestController::layerTreeAsText):
823         * DumpRenderTree/chromium/LayoutTestController.h:
824         (LayoutTestController::setShowDebugLayerTree):
825         * DumpRenderTree/chromium/TestShell.cpp:
826         (TestShell::runFileTest):
827         (TestShell::dump):
828         * DumpRenderTree/chromium/TestShell.h:
829         (TestParams::TestParams):
830
831 2011-03-21  Adam Roben  <aroben@apple.com>
832
833         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
834
835         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
836         output as plain text
837
838         Reviewed by David Kilzer.
839
840         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
841         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
842         to the master.
843         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
844         since we're running on the build master, not the slave. Instead, turn the raw source of
845         actual.html which the build slave uploaded into an HTML log.
846
847 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
848
849         Reviewed by Mihai Parparita.
850
851         new-run-webkit-tests: run tests in ascending alphabetical order per dir
852         https://bugs.webkit.org/show_bug.cgi?id=56760
853
854         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
855         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
856         * Scripts/webkitpy/layout_tests/port/test.py:
857
858 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
859
860         Reviewed by Steve Block.
861
862         Media Stream API patch 0: adding compilation guards.
863         https://bugs.webkit.org/show_bug.cgi?id=56458
864
865         Adding options to enable the media stream API feature in Chromium.
866
867         * Scripts/build-webkit:
868
869 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
870
871         Reviewed by Laszlo Gombos.
872
873         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
874         https://bugs.webkit.org/show_bug.cgi?id=56323
875
876         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
877         "--stdout" or "--stderr" option.
878
879         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
880         (WebCore::DumpRenderTree::~DumpRenderTree):
881         (WebCore::DumpRenderTree::processArgsLine):
882         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
883         * DumpRenderTree/qt/DumpRenderTreeQt.h:
884         (WebCore::DumpRenderTree::setRedirectOutputFileName):
885         (WebCore::DumpRenderTree::setRedirectErrorFileName):
886         * DumpRenderTree/qt/main.cpp:
887         (isOption):
888         (takeOptionValue):
889         (printUsage):
890         (main):
891
892 2011-03-21  Adam Roben  <aroben@apple.com>
893
894         Fix exceptions on the buildbot due to my last change
895
896         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
897         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
898
899 2011-03-21  Adam Roben  <aroben@apple.com>
900
901         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
902
903         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
904         output as plain text
905
906         Reviewed by Darin Adler.
907
908         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
909         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
910         logs.
911         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
912         the build master. This will correctly treat it as HTML.
913
914 2011-03-20  Bill Budge  <bbudge@chromium.org>
915
916         Reviewed by Adam Barth.
917
918         Rename ThreadSafeShared to ThreadSafeRefCounted
919         https://bugs.webkit.org/show_bug.cgi?id=56714
920
921         No new tests. Exposes no new functionality.
922
923         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
924         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
925         * Scripts/do-webcore-rename:
926
927 2011-03-19  Anton D'Auria  <adauria@apple.com>
928
929         Reviewed by Dan Bernstein.
930
931         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
932         https://bugs.webkit.org/show_bug.cgi?id=56719
933
934         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
935         (LayoutTestController::clearApplicationCacheForOrigin):
936
937 2011-03-19  Anton D'Auria  <adauria@apple.com>
938
939         Reviewed by Alexey Proskuryakov.
940
941         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
942         https://bugs.webkit.org/show_bug.cgi?id=56415
943
944         * DumpRenderTree/LayoutTestController.cpp:
945         (clearApplicationCacheForOriginCallback):
946         (LayoutTestController::staticFunctions):
947         * DumpRenderTree/LayoutTestController.h:
948         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
949         (LayoutTestController::LayoutTestController):
950         (LayoutTestController::clearAllApplicationCaches):
951         (LayoutTestController::clearApplicationCacheForOrigin): 
952         * DumpRenderTree/chromium/LayoutTestController.h:
953         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
954         (LayoutTestController::clearApplicationCacheForOrigin):
955         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
956         (LayoutTestController::clearApplicationCacheForOrigin):
957         * DumpRenderTree/qt/LayoutTestControllerQt.h:
958         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
959         (LayoutTestController::clearApplicationCacheForOrigin):
960         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
961         (LayoutTestController::clearApplicationCacheForOrigin):
962
963 2011-03-18  Dan Bernstein  <mitz@apple.com>
964
965         Revised build fix for r81135.
966
967         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
968         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
969
970 2011-03-18  Adam Roben  <aroben@apple.com>
971
972         Windows build fix
973
974         * WebKitTestRunner/config.h: Add a missing #endif.
975
976 2011-03-18  Andreas Kling  <kling@webkit.org>
977
978         Unbreak Qt build after r81494.
979
980         * WebKitTestRunner/qt/TestInvocationQt.cpp:
981         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
982
983 2011-03-18  Sam Weinig  <sam@webkit.org>
984
985         Fix windows build. This was really Adam Roben's fault. I swear!
986
987         * WebKitTestRunner/config.h:
988
989 2011-03-18  Sam Weinig  <sam@webkit.org>
990
991         Reviewed by Adam Roben.
992
993         Pixel tests don't work in WebKitTestRunner on Windows
994         https://bugs.webkit.org/show_bug.cgi?id=56630
995
996         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
997         built-in snapshotting instead of using the window server on the Mac.
998
999         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1000         (WTR::InjectedBundle::InjectedBundle):
1001         (WTR::InjectedBundle::didReceiveMessage):
1002         (WTR::InjectedBundle::beginTesting):
1003         (WTR::InjectedBundle::done):
1004         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1005         (WTR::InjectedBundle::setPixelResult):
1006         (WTR::InjectedBundle::shouldDumpPixels):
1007         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1008         (WTR::InjectedBundlePage::dump):
1009         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1010
1011         * WebKitTestRunner/TestInvocation.cpp:
1012         (WTR::TestInvocation::invoke):
1013         (WTR::TestInvocation::dump):
1014         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1015         * WebKitTestRunner/TestInvocation.h:
1016         * WebKitTestRunner/cg: Added.
1017         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1018         (WTR::createCGContextFromImage):
1019         (WTR::computeMD5HashStringForContext):
1020         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1021         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1022         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1023
1024         * WebKitTestRunner/win/TestInvocationWin.cpp:
1025         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1026         Keep stub for Cairo build.
1027
1028         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1029         Add CG configuration.
1030
1031         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1032         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1033         Add new files.
1034
1035 2011-03-18  Adam Roben  <aroben@apple.com>
1036
1037         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1038
1039         Rubber-stamped by Simon Fraser.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1042         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1043         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1044
1045 2011-03-18  Adam Roben  <aroben@apple.com>
1046
1047         Don't ellipsize long or indented function names in Leaks Viewer
1048
1049         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1050         scrollbar
1051
1052         Reviewed by Simon Fraser.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1055         (.data-grid .data-container):
1056         (.data-grid td > div, .data-grid th > div):
1057         Allow the contents to extend to the right.
1058
1059 2011-03-18  Adam Roben  <aroben@apple.com>
1060
1061         Fix some leaks in DRT seen on the leaks bot
1062
1063         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1064         setWillSendRequestClearHeaderCallback in DRT are leaky
1065
1066         Reviewed by Alexey Proskuryakov.
1067
1068         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1069
1070         * DumpRenderTree/LayoutTestController.cpp:
1071         (addURLToRedirectCallback):
1072         (setWillSendRequestClearHeaderCallback):
1073         Use OwnArrayPtr to cause the strings to be deleted.
1074
1075 2011-03-18  Adam Roben  <aroben@apple.com>
1076
1077         Fix a NSURLCredential leak seen on the leaks bot
1078
1079         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1080         connection:didReceiveAuthenticationChallenge:] is leaky
1081
1082         Reviewed by John Sullivan.
1083
1084         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1085         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1086         cause the NSURLCredential to be released.
1087
1088 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1089
1090         Unreviewed.
1091
1092         Remove unnecessary brackets around my email address.
1093
1094         * Scripts/webkitpy/common/config/committers.py:
1095
1096 2011-03-18  Adam Roben  <aroben@apple.com>
1097         
1098         Remove some files I accidentally added in r81454
1099
1100         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1101         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1102
1103 2011-03-18  Adam Roben  <aroben@apple.com>
1104
1105         Ignore an NSNumberFormatter leak on SnowLeopard
1106
1107         * Scripts/old-run-webkit-tests:
1108         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1109         getObjectValue:forString:errorDescription:].
1110
1111 2011-03-18  Adam Roben  <aroben@apple.com>
1112
1113         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1114
1115         Rubber-stamped by Mark Rowe.
1116
1117         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1118         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1119         released.
1120
1121 2011-03-17  Adam Roben  <aroben@apple.com>
1122
1123         Address a review comment I missed in r81445
1124
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1126         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1127         leaked bytes to speed up searching on long lines.
1128
1129 2011-03-17  Adam Roben  <aroben@apple.com>
1130
1131         Mark leaky builds orange, even if all regression tests passed
1132
1133         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1134         build.webkit.org when all tests pass even though there are still leaks
1135
1136         Reviewed by Dan Bernstein.
1137
1138         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1139         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1140         be marked orange if this build step generates warnings.
1141
1142 2011-03-17  Adam Roben  <aroben@apple.com>
1143
1144         Allow values in Leaks Viewer to be shown as percentages
1145
1146         Double-clicking on a column will toggle between showing percentages and showing real values.
1147
1148         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1149         number of leaked bytes in Leaks Viewer
1150
1151         Reviewed by Joe Pecoraro.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1154         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1155         node's totalTime, which is used in calculating percentages.
1156
1157         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1158         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1159         showing them as percentages.
1160
1161 2011-03-17  Adam Roben  <aroben@apple.com>
1162
1163         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1164
1165         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1166         the number of leaked allocations. And the new Average column shows the average number of
1167         leaked bytes per call.
1168
1169         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1170         just how many allocations
1171
1172         Reviewed by Joe Pecoraro.
1173
1174         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1175         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1176         line and store it with the leak stack.
1177         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1178         properties.
1179         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1180         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1181         .numberOfCalls now holds the number of leaked allocations.
1182
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1184         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1185         appear.
1186         (monkeyPatchInspectorObjects): Format the values as bytes.
1187
1188 2011-03-17  Adam Roben  <aroben@apple.com>
1189
1190         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1191
1192         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1193         regression tests
1194
1195         Reviewed by James Robinson.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1198         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1199         is always populated, even when all regression tests pass.
1200
1201 2011-03-10  Hayato Ito  <hayato@chromium.org>
1202
1203         Reviewed by Tony Chang.
1204
1205         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=56076
1208
1209         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1210
1211 2011-03-17  Adam Roben  <aroben@apple.com>
1212
1213         Skip a compositing-sensitive test when accelerated compositing is disabled
1214
1215         Reviewed by Sam Weinig.
1216
1217         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1218         accelerated compositing is disabled.
1219
1220 2011-03-17  Adam Roben  <aroben@apple.com>
1221
1222         Start using PlatformSpecificScheduler for the Mac builders
1223
1224         The current set of file/directory patterns should work for Mac builders. We may discover
1225         that there are more files and directories we can exclude from the Mac builds, but they can
1226         be added later.
1227
1228         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1229
1230         Reviewed by Mark Rowe.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1233         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1234
1235         * Scripts/webkitpy/common/config/build.py:
1236         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1237         cleaned up patterns a little bit.
1238
1239         * Scripts/webkitpy/common/config/build_unittest.py:
1240         (ShouldBuildTest): Fixed some expected results.
1241         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1242         platforms.
1243
1244 2011-03-17  Jeff Miller  <jeffm@apple.com>
1245
1246         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1247         
1248         *.mode*
1249         *.pbxuser
1250         *.perspective*
1251         project.xcworkspace
1252         xcuserdata
1253
1254         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1255         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1256         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1257         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1258         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1259
1260 2011-03-17  Adam Roben  <aroben@apple.com>
1261
1262         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1263
1264         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1265         mac-wk2
1266
1267         Reviewed by Anders Carlsson.
1268
1269         * Scripts/old-run-webkit-tests:
1270         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1271         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1272         we're running in WebKit2 mode.
1273
1274 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1275
1276         Reviewed by Yury Semikhatsky.
1277
1278         Web Inspector: Clean up Inspector strings.
1279         https://bugs.webkit.org/show_bug.cgi?id=56557
1280
1281         Modify the script to deal correctly with "\xNN" escapes, and to
1282         check strings in Chromium's DevTools.js.
1283
1284         * Scripts/check-inspector-strings:
1285
1286 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1287
1288         Reviewed by Benjamin Poulain.
1289
1290         Update autoinstall to install mechanize 0.2.4
1291         https://bugs.webkit.org/show_bug.cgi?id=56499
1292
1293         Newer versions of mechanize support HTTPS proxies, which is necessary
1294         for people using webkit-patch behind firewalls.
1295
1296         * Scripts/webkitpy/common/system/autoinstall.py:
1297         * Scripts/webkitpy/thirdparty/__init__.py:
1298
1299 2011-03-16  Sam Weinig  <sam@webkit.org>
1300
1301         Reviewed by Adam Roben.
1302
1303         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1304         https://bugs.webkit.org/show_bug.cgi?id=56541
1305
1306         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1307         (WTR::InjectedBundlePage::willSendRequestForFrame):
1308         Check for an empty host in addition to a null host.  This bug was introduced
1309         when porting off of the KURL code and onto the WKURLRef version.
1310
1311 2011-03-16  Sam Weinig  <sam@webkit.org>
1312
1313         Reviewed by Adam Roben.
1314
1315         Add Lucas Forschler to the list of WebKit committers.
1316
1317         * Scripts/webkitpy/common/config/committers.py:
1318
1319 2011-03-16  Sam Weinig  <sam@webkit.org>
1320
1321         Reviewed upon and dictated through Adam Roben.
1322
1323         Escape crashing function names in results.html. This fixes an issue
1324         when a crash involves a type with templates.
1325
1326         * Scripts/old-run-webkit-tests:
1327
1328 2011-03-16  Daniel Sievers  <sievers@google.com>
1329
1330         Reviewed by James Robinson.
1331
1332         Add setting to always force compositing mode
1333         https://bugs.webkit.org/show_bug.cgi?id=56156
1334
1335         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1336         (main):
1337         * DumpRenderTree/chromium/TestShell.cpp:
1338         (TestShell::TestShell):
1339         (TestShell::resetWebSettings):
1340         * DumpRenderTree/chromium/TestShell.h:
1341         (TestShell::setForceCompositingMode):
1342         * DumpRenderTree/chromium/WebPreferences.cpp:
1343         (WebPreferences::reset):
1344         (WebPreferences::applyTo):
1345         * DumpRenderTree/chromium/WebPreferences.h:
1346
1347 2011-03-15  Hayato Ito  <hayato@chromium.org>
1348
1349         Reviewed by Ojan Vafai.
1350
1351         Ignore files that will be used by reftests in old-run-webkit-tests.
1352
1353         https://bugs.webkit.org/show_bug.cgi?id=55936
1354
1355         * Scripts/old-run-webkit-tests:
1356
1357 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1358
1359         Reviewed by Adam Roben.
1360
1361         Function relativeScriptsDir doesn't return the correct relative
1362         Scripts directory.
1363
1364         * Scripts/webkitdirs.pm:
1365         (relativeScriptsDir): Ensure we use the directory that contains
1366         webkitdirs.pm, not the one that contains the original script that
1367         was invoked.
1368
1369 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1370
1371         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1372         fix to link against the Security framework after recent WebKitSystemInterface changes.
1373
1374         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1375         (LayoutTestController::originsWithLocalStorage):
1376         * wx/build/settings.py:
1377         * wx/build/waf_extensions.py:
1378
1379 2011-03-15  Sam Weinig  <sam@webkit.org>
1380
1381         Reviewed by Darin Adler.
1382
1383         Add script to convert a patch to a prettypatch and show in the default browser
1384         https://bugs.webkit.org/show_bug.cgi?id=56416
1385
1386         This can be used either like
1387             $ svn-create-patch | show-pretty-diff
1388         or
1389             $ show-pretty-diff patch.diff
1390
1391         * Scripts/show-pretty-diff: Added.
1392
1393 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1394
1395         Rubber-stamped by Adam Roben.
1396
1397         Adding myself as a reviewer.
1398
1399         * Scripts/webkitpy/common/config/committers.py:
1400
1401 2011-03-15  Anders Carlsson  <andersca@apple.com>
1402
1403         Try to fix the Windows build.
1404
1405         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1406         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1407
1408 2011-03-15  Anders Carlsson  <andersca@apple.com>
1409
1410         Reviewed by Sam Weinig.
1411
1412         Make sure that NP_Shutdown is always the last NPP function called
1413         https://bugs.webkit.org/show_bug.cgi?id=56391
1414
1415         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1416
1417         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1418         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1419         (PluginTest::PluginTest):
1420         (PluginTest::NP_Shutdown):
1421         (PluginTest::registerNPShutdownFunction):
1422         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1423         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1424         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1425         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1426         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1427         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1428         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1429         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1430         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1431         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1432         (NP_Shutdown):
1433         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1434         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1435         * GNUmakefile.am:
1436
1437 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1438
1439         Reviewed by Tony Chang.
1440
1441         Autofilled form elements are assigned fixed background color but not text color
1442         https://bugs.webkit.org/show_bug.cgi?id=48382
1443
1444         * DumpRenderTree/LayoutTestController.cpp:
1445         (setAutofilledCallback): Added.
1446         (LayoutTestController::staticFunctions):
1447         * DumpRenderTree/LayoutTestController.h:
1448         * DumpRenderTree/chromium/LayoutTestController.cpp:
1449         (LayoutTestController::LayoutTestController):
1450         (LayoutTestController::setAutofilled): Added.
1451         * DumpRenderTree/chromium/LayoutTestController.h:
1452         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1453         (LayoutTestController::setAutofilled): Added.
1454         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1455         (LayoutTestController::setAutofilled): Added.
1456         (LayoutTestController::setValueForUser): Style tweak.
1457         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1458         (LayoutTestController::setAutofilled): Added (stub).
1459         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1460         (LayoutTestController::setAutofilled): Added (stub).
1461
1462 2011-03-15  Dan Bernstein  <mitz@apple.com>
1463
1464         Build fix after r81135.
1465
1466         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1467
1468 2011-03-15  Dan Bernstein  <mitz@apple.com>
1469
1470         Build fix after r81135.
1471
1472         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1473         * WebKitTestRunner/mac/TestControllerMac.mm:
1474         * WebKitTestRunner/mac/TestInvocationMac.mm:
1475         * WebKitTestRunner/mac/main.mm:
1476
1477 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1478
1479         Reviewed by Adam Barth.
1480
1481         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1482         https://bugs.webkit.org/show_bug.cgi?id=56349
1483
1484         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1485         on platforms where we use it. Copied from DumpRenderTree.pro.
1486
1487 2011-03-15  Dan Bernstein  <mitz@apple.com>
1488
1489         Build fix after r81135.
1490
1491         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1492         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1493
1494 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1495
1496         Reviewed by Darin Adler.
1497
1498         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1499         info into the headers rather than in export symbol definition files, but disable it on 
1500         all platforms initially so we can deal with port build issues one port at a time.
1501         
1502         https://bugs.webkit.org/show_bug.cgi?id=27551
1503
1504         * DumpRenderTree/cg/ImageDiffCG.cpp:
1505         * DumpRenderTree/chromium/config.h:
1506         * DumpRenderTree/config.h:
1507         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1508         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1509         * WebKitAPITest/HostWindow.cpp:
1510         * WebKitAPITest/TestsController.cpp:
1511         * WebKitAPITest/config.h: Added.
1512         * WebKitAPITest/main.cpp:
1513         * WebKitAPITest/tests/WebViewDestruction.cpp:
1514         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1515         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1516         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1518         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1519         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1520         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1521         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1522         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1523         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1524         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1525         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1526         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1527         * WebKitTestRunner/TestController.cpp:
1528         * WebKitTestRunner/TestInvocation.cpp:
1529         * WebKitTestRunner/config.h: Added.
1530         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1531         * WebKitTestRunner/qt/TestControllerQt.cpp:
1532         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1533         * WebKitTestRunner/qt/main.cpp:
1534         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1535         * WebKitTestRunner/win/TestControllerWin.cpp:
1536         * WebKitTestRunner/win/TestInvocationWin.cpp:
1537         * WebKitTestRunner/win/main.cpp:
1538         * wx/build/settings.py:
1539
1540 2011-03-15  Hayato Ito  <hayato@chromium.org>
1541
1542         Reviewed by Shinichiro Hamaji.
1543
1544         [NRWT] Add support for reftests to new-run-webkit-tests.
1545
1546         https://bugs.webkit.org/show_bug.cgi?id=55457
1547
1548         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1549         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1550         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1551         * Scripts/webkitpy/layout_tests/port/base.py:
1552         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1553         * Scripts/webkitpy/layout_tests/port/test.py:
1554         * Scripts/webkitpy/layout_tests/port/test_files.py:
1555         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1556
1557 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1558
1559         Reviewed by Martin Robinson.
1560
1561         [GTK] Fix compilation warning after r80892
1562         https://bugs.webkit.org/show_bug.cgi?id=56302
1563
1564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1565         (LayoutTestController::originsWithLocalStorage):
1566
1567 2011-03-15  Robert Hogan  <robert@webkit.org>
1568
1569         Reviewed by Adam Barth.
1570
1571         Document the qmakearg argument, and hint how to build webkit2 on Qt
1572         https://bugs.webkit.org/show_bug.cgi?id=56326
1573
1574         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1575
1576 2011-03-15  Adam Roben  <aroben@apple.com>
1577
1578         Make Windows 7 Release (Tests) a core builder
1579
1580         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1581         give it a few more days of greenness first.
1582
1583         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1584
1585         Reviewed by Sam Weinig.
1586
1587         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1588         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1589
1590         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1591         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1592         Updated the core regexps to match the buildbot module. Updated the expected results to match
1593         the current set of core builders.
1594
1595 2011-03-14  Adam Roben  <aroben@apple.com>
1596
1597         Add forgotten file from r81116
1598
1599         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1600
1601 2011-03-14  Sam Weinig  <sam@webkit.org>
1602
1603         Reviewed by Adam Roben.
1604
1605         about:blank fake responses don't get serialized when sent the UIProcess
1606         <rdar://problem/9108119>
1607         https://bugs.webkit.org/show_bug.cgi?id=56357
1608
1609         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1610         (TestWebKitAPI::decidePolicyForResponse):
1611         (TestWebKitAPI::TEST):
1612         Add test that loads of about:blank have a response with a MIMEType of text/html.
1613
1614         * TestWebKitAPI/PlatformUtilities.h:
1615         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1616         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1617         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1618         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1619         Add helper to get the MIMEType from a WKURLResponse.
1620
1621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1622         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1623         Add new files.
1624
1625 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1626
1627         Reviewed by Kenneth Rohde Christiansen.
1628
1629         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1630         https://bugs.webkit.org/show_bug.cgi?id=56006
1631
1632         * QtTestBrowser/launcherwindow.cpp:
1633         (LauncherWindow::initializeView):
1634         * QtTestBrowser/main.cpp:
1635         (LauncherApplication::handleUserOptions):
1636
1637 2011-03-14  James Kozianski  <koz@chromium.org>
1638
1639         Reviewed by Ojan Vafai.
1640
1641         Add method to make BuildBot return test outputs
1642         https://bugs.webkit.org/show_bug.cgi?id=54374
1643
1644         The Builder.latest_cached_build will be used by the new rebaseline
1645         script to determine the build to use baselines from.
1646
1647         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1648         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1649
1650 2011-03-14  Adam Roben  <aroben@apple.com>
1651
1652         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1653
1654         Reviewed by Sam Weinig.
1655
1656         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1657         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1658         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1659         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1660         ensure the web process is initialized, then ask the bundle to run the test and assert that
1661         it succeeded.
1662
1663         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1664         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1665         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1666         handle a given URL.
1667         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1668         URL type cannot be handled).
1669         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1670         result.
1671
1672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1673         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1674         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1675         Added new files to the project.
1676
1677 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1678
1679         Unreviewed, rolling out r81094.
1680         http://trac.webkit.org/changeset/81094
1681         https://bugs.webkit.org/show_bug.cgi?id=56355
1682
1683         Broke the chromium DRT related build. (Requested by dave_levin
1684         on #webkit).
1685
1686         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1687         (main):
1688         * DumpRenderTree/chromium/LayoutTestController.cpp:
1689         (LayoutTestController::LayoutTestController):
1690         (LayoutTestController::layerTreeAsText):
1691         * DumpRenderTree/chromium/LayoutTestController.h:
1692         * DumpRenderTree/chromium/TestShell.cpp:
1693         (TestShell::runFileTest):
1694         (TestShell::dump):
1695         * DumpRenderTree/chromium/TestShell.h:
1696         (TestParams::TestParams):
1697
1698 2011-03-14  Daniel Sievers  <sievers@google.com>
1699
1700         Reviewed by Simon Fraser.
1701
1702         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1703         https://bugs.webkit.org/show_bug.cgi?id=56139
1704
1705         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1706         (main):
1707         * DumpRenderTree/chromium/LayoutTestController.cpp:
1708         (LayoutTestController::LayoutTestController):
1709         (LayoutTestController::layerTreeAsText):
1710         * DumpRenderTree/chromium/LayoutTestController.h:
1711         (LayoutTestController::setShowDebugLayerTree):
1712         * DumpRenderTree/chromium/TestShell.cpp:
1713         (TestShell::runFileTest):
1714         (TestShell::dump):
1715         * DumpRenderTree/chromium/TestShell.h:
1716         (TestParams::TestParams):
1717
1718 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1719
1720         Reviewed by Adam Roben.
1721
1722         [Qt][WK2]Unbreak InjectedBundle on Qt
1723         https://bugs.webkit.org/show_bug.cgi?id=54109
1724
1725         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1726         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1727         API's instead of KURL to analyze the URL.
1728         * WebKitTestRunner/StringFunctions.h:
1729         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1730         in the WebKitTestRunner project.
1731         (WTR::toWK): Use adoptWK.
1732         (WTR::operator<<): Added helper for printing a WKURL.
1733         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1734         against WebCore.
1735
1736 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1737
1738         Reviewed by Kenneth Rohde Christiansen.
1739
1740         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1741         https://bugs.webkit.org/show_bug.cgi?id=56321
1742
1743         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1744         to the list of exceptions for WebKit2 C API headers.
1745
1746 2011-03-14  Adam Roben  <aroben@apple.com>
1747
1748         Show the list of recent leaky builds in reverse chronological order
1749
1750         Previously they were being shown in a deterministic but surprising order based on
1751         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1752
1753         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1754
1755         Reviewed by Darin Adler.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1758         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1759         callback.
1760
1761 2011-03-14  Adam Roben  <aroben@apple.com>
1762
1763         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1764
1765         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1766         analyze
1767
1768         Reviewed by David Kilzer and Joe Pecoraro.
1769
1770         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1771         (#url-prompt): Made this a bit taller to make room for the list of builds.
1772
1773         (#recent-builds-loading-indicator):
1774         (#recent-builds-list):
1775         Added styles for the build list and loading indicator.
1776
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1778         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1779         it. This will unescape it.
1780         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1781         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1782         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1783         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1784         prompt UI.
1785         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1786         now also used when a recent build is clicked.
1787
1788         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1789         (RecentBuildsLoader): Store the callback.
1790         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1791         builder. Find the revision number, leak count, and results URL for each one. Pass the
1792         resulting info to our callback.
1793
1794         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1795         (range): Added this helper function to return an array containing the integers [0, n).
1796
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1798         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1799
1800 2011-03-14  Mark Rowe  <mrowe@apple.com>
1801
1802         Reviewed by Adam Roben.
1803
1804         Fix two memory leaks within LayoutTestController's storage support.
1805
1806         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1807         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1808         by JSStringCreateWithCFString.
1809         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1810         allocate.
1811
1812 2011-03-14  Mark Rowe  <mrowe@apple.com>
1813
1814         Reviewed by Oliver Hunt.
1815
1816         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1817
1818         * DumpRenderTree/LayoutTestController.cpp:
1819         (LayoutTestController::staticFunctions): Remove duplicate entries.
1820
1821 2011-03-14  Alice Liu  <alice.liu@apple.com>
1822
1823         Reviewed by Dan Bernstein.
1824
1825         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1826
1827         * DumpRenderTree/mac/PerlSupport/Makefile:
1828         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1829
1830 2011-03-14  Daniel Bates  <dbates@rim.com>
1831
1832         https://bugs.webkit.org/show_bug.cgi?id=55438
1833         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1834         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1835
1836         * Scripts/build-webkit:
1837
1838 2011-03-14  Daniel Bates  <dbates@rim.com>
1839
1840         Reviewed by David Kilzer.
1841
1842         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1843         https://bugs.webkit.org/show_bug.cgi?id=55438
1844
1845         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1846         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1847         CMake arguments for feature defines.
1848
1849         * Scripts/build-webkit:
1850           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1851           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1852           - Sorted forward declarations.
1853           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1854             Modified call sites as needed.
1855         * Scripts/webkitdirs.pm:
1856           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1857           - Added buildCMakeGeneratedProject() to build using generated build system.
1858           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1859           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1860             a CMake project.
1861           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1862
1863 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1864
1865         Reviewed by Steve Block.
1866
1867         Detach Geolocation from Frame when Page destroyed.
1868         https://bugs.webkit.org/show_bug.cgi?id=52877
1869
1870         Extend the layout test controller to expose the number of pending
1871         geolocation requests, so that we can test that the requests have
1872         been cancelled on page close.
1873
1874         * DumpRenderTree/LayoutTestController.cpp:
1875         (numberOfPendingGeolocationPermissionRequestsCallback):
1876         (LayoutTestController::staticFunctions):
1877         * DumpRenderTree/LayoutTestController.h:
1878         * DumpRenderTree/chromium/LayoutTestController.cpp:
1879         (LayoutTestController::LayoutTestController):
1880         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1881         * DumpRenderTree/chromium/LayoutTestController.h:
1882         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1883         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1884         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1885         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1886         * DumpRenderTree/mac/UIDelegate.h:
1887         * DumpRenderTree/mac/UIDelegate.mm:
1888         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1889         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1890         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1891         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1892         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1893         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1894         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1895         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1896
1897
1898 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1899
1900         Unreviewed. Modify my email address in committers.py.
1901
1902         * Scripts/webkitpy/common/config/committers.py:
1903
1904 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1905
1906         Reviewed by Kenneth Rohde Christiansen.
1907
1908         [Qt] QtLauncher does not load the same set of fonts as the DRT
1909         https://bugs.webkit.org/show_bug.cgi?id=34959
1910
1911         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1912         When this option is used the webkit fonts are loaded the same
1913         as they are in DumpRenderTree.  This option can be used on
1914         QtTestBrowser and run-launcher.  It can only be used
1915         on Linux systems with FcInit and is configured as such.
1916
1917         * QtTestBrowser/launcherwindow.h:
1918         (WindowOptions::WindowOptions):
1919         * QtTestBrowser/main.cpp:
1920         (initWebKitTestFonts):
1921         (launcherMain):
1922         (LauncherApplication::handleUserOptions):
1923
1924 2011-03-12  Dan Bernstein  <mitz@apple.com>
1925
1926         Reviewed by Mark Rowe.
1927
1928         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1929         DumpRenderTree is being built for.
1930
1931         * DumpRenderTree/mac/PerlSupport/Makefile:
1932
1933 2011-03-12  Dan Bernstein  <mitz@apple.com>
1934
1935         Suggested by Mark Rowe.
1936
1937         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1938         as they were before r80915.
1939
1940 2011-03-12  Anders Carlsson  <andersca@apple.com>
1941
1942         Reviewed by Sam Weinig.
1943
1944         Should be able to download a PDF to the Downloads folder
1945         https://bugs.webkit.org/show_bug.cgi?id=56256
1946
1947         * MiniBrowser/mac/BrowserWindowController.m:
1948         (-[BrowserWindowController awakeFromNib]):
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::createOtherPage):
1951         (WTR::TestController::initialize):
1952         Update for API changes.
1953
1954 2011-03-11  Anton D'Auria  <adauria@apple.com>
1955
1956         Reviewed and landed by Brady Eidson.
1957
1958         https://bugs.webkit.org/show_bug.cgi?id=51878
1959         Add WebKit1 API to view and delete local storage
1960
1961         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
1962
1963         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1964         * DumpRenderTree/LayoutTestController.cpp:
1965         (syncLocalStorageCallback):
1966         (observeStorageTrackerNotificationsCallback):
1967         (deleteAllLocalStorageCallback):
1968         (deleteLocalStorageForOriginCallback):
1969         (originsWithLocalStorageCallback):
1970         (LayoutTestController::staticFunctions):
1971         * DumpRenderTree/LayoutTestController.h:
1972         * DumpRenderTree/StorageTrackerDelegate.h: Added.
1973         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
1974         (-[StorageTrackerDelegate init]):
1975         (-[StorageTrackerDelegate logNotifications:controller:]):
1976         (-[StorageTrackerDelegate originModified:]):
1977         (-[StorageTrackerDelegate dealloc]):
1978         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
1979         * DumpRenderTree/chromium/LayoutTestController.cpp:
1980         (LayoutTestController::LayoutTestController):
1981         (LayoutTestController::deleteAllLocalStorage):
1982         (LayoutTestController::originsWithLocalStorage):
1983         (LayoutTestController::deleteLocalStorageForOrigin):
1984         (observeStorageTrackerNotifications):
1985         (syncLocalStorage):
1986         * DumpRenderTree/chromium/LayoutTestController.h:
1987         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1988         (LayoutTestController::originsWithLocalStorage):
1989         (LayoutTestController::deleteAllLocalStorage):
1990         (LayoutTestController::deleteLocalStorageForOrigin):
1991         (LayoutTestController::observeStorageTrackerNotifications):
1992         (LayoutTestController::syncLocalStorage):
1993         * DumpRenderTree/mac/DumpRenderTree.mm:
1994         (resetDefaultsToConsistentValues):
1995         (allocateGlobalControllers):
1996         (releaseGlobalControllers):
1997         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1998         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1999         (LayoutTestController::syncLocalStorage):
2000         (LayoutTestController::observeStorageTrackerNotifications):
2001         (LayoutTestController::deleteAllLocalStorage):
2002         (LayoutTestController::originsWithLocalStorage):
2003         (LayoutTestController::deleteLocalStorageForOrigin):
2004         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2005         (LayoutTestController::originsWithLocalStorage):
2006         (LayoutTestController::deleteAllLocalStorage):
2007         (LayoutTestController::deleteLocalStorageForOrigin):
2008         (LayoutTestController::observeStorageTrackerNotifications):
2009         (LayoutTestController::syncLocalStorage):
2010         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2011         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2012         (LayoutTestController::clearAllApplicationCaches):
2013         (LayoutTestController::syncLocalStorage):
2014         (LayoutTestController::observeStorageTrackerNotifications):
2015         (LayoutTestController::clearAllDatabases):
2016         (LayoutTestController::deleteAllLocalStorage):
2017         (LayoutTestController::originsWithLocalStorage):
2018         (LayoutTestController::deleteLocalStorageForOrigin):
2019         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2020         (LayoutTestController::syncLocalStorage):
2021         (LayoutTestController::observeStorageTrackerNotifications):
2022         (LayoutTestController::clearAllDatabases):
2023         (LayoutTestController::deleteAllLocalStorage):
2024         (LayoutTestController::originsWithLocalStorage):
2025         (LayoutTestController::deleteLocalStorageForOrigin):
2026
2027 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2028
2029         Reviewed by Adam Roben.
2030
2031         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2032         Process has finished launching.
2033         https://bugs.webkit.org/show_bug.cgi?id=56208
2034
2035         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2036         (TestWebKitAPI::TEST):
2037         Test that calling WKContextClearResourceCaches works with both options when called before
2038         the Web Process is valid.
2039
2040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2041         Add the new test.
2042         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2043         Ditto.
2044
2045 2011-03-11  Adam Roben  <aroben@apple.com>
2046
2047         Make it possible to view all leaks from a build at once in Leaks Viewer
2048
2049         You can now give Leaks Viewer the URL of a build results page (e.g.,
2050         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2051         will load all the leaks files from that build.
2052
2053         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2054         files from a particular build at once, rather than one at a time
2055
2056         Reviewed by David Kilzer.
2057
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2059         (LeaksLoader): Initialize our properties.
2060         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2061         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2062         from that page.
2063         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2064         so it can provide feedback. Then load each one and pass it to the client.
2065         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2066         it into a DOM, pull out all the links to leaks files, and load each one.
2067
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2069         (LeaksParser): Initialize our worker.
2070         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2071
2072         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2073         This code mostly came from Worker.js.
2074         (LeaksParserWorker): Initialize our profile.
2075         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2076         profile.
2077         (LeaksParserWorker.prototype._parseLeaks):
2078         (LeaksParserWorker.prototype._createNode):
2079         (LeaksParserWorker.prototype._incorporateLeaks):
2080         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2081         version of createProfile which adds to this.profile instead of making a new profile each
2082         time.
2083         (onmessage): Parse the file and send back the new profile.
2084
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2086         (#loading-indicator):
2087         (#spinner):
2088         (#loading-indicator-label):
2089         Tweaked styles to accomodate a longer label.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2092         (LeaksViewer.loaded): Set up a loader and parser.
2093
2094         (LeaksViewer.get filesLeftToParse):
2095         (LeaksViewer.set filesLeftToParse):
2096         Added these simple accessors.
2097
2098         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2099         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2100         the parser.
2101         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2102         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2103         _loadLeaksFromURL function).
2104         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2105         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2106         loading indicator, including the number of files being loaded.
2107         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2108         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2109         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2110         _loadingIndicatorText.
2111
2112         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2113         (getResource): Moved here from LeaksViewer.js.
2114
2115         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2116         LeaksParserWorker.js.
2117
2118         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2119         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2120
2121 2011-03-11  Adam Roben  <aroben@apple.com>
2122
2123         Don't trigger a build when build.webkit.org's HTML files are modified
2124
2125         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2126
2127         Reviewed by Dan Bernstein.
2128
2129         * Scripts/webkitpy/common/config/build.py:
2130         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2131         directories that shouldn't trigger builds. Re-sorted the list.
2132
2133         * Scripts/webkitpy/common/config/build_unittest.py:
2134         (ShouldBuildTest): Added a test to cover the above change.
2135
2136 2011-03-11  Adam Roben  <aroben@apple.com>
2137
2138         Roll out r80848
2139
2140         It was accidentally committed.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2143         (LeaksViewer._loadLeaksFromURL):
2144
2145 2011-03-11  Tony Chang  <tony@chromium.org>
2146
2147         Reviewed by Ojan Vafai.
2148
2149         kill hung lighttpd processes on the chromium win bot
2150         https://bugs.webkit.org/show_bug.cgi?id=56152
2151
2152         Sometimes this process doesn't exit and it holds on to
2153         a log file that we can't delete or copy, causing the tests
2154         to go red.
2155
2156         * BuildSlaveSupport/win/kill-old-processes:
2157
2158 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2159
2160         Reviewed by Kent Tamura.
2161
2162         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2163         https://bugs.webkit.org/show_bug.cgi?id=55854
2164
2165         * DumpRenderTree/chromium/LayoutTestController.cpp:
2166         (LayoutTestController::LayoutTestController):
2167         (LayoutTestController::setValueForUser): Added.
2168         * DumpRenderTree/chromium/LayoutTestController.h:
2169
2170 2011-03-10  Peter Kasting  <pkasting@google.com>
2171
2172         Reviewed by Dimitri Glazkov.
2173
2174         Clean up some gross code in TestShellWin.cpp.  No functional change.
2175         https://bugs.webkit.org/show_bug.cgi?id=56048
2176
2177         * DumpRenderTree/chromium/TestShellWin.cpp:
2178         (checkLayoutTestSystemDependencies):
2179
2180 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2181
2182         Reviewed by Laszlo Gombos.
2183
2184         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2185
2186         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2187         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2188
2189 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2190
2191         Reviewed by Kenneth Rohde Christiansen.
2192
2193         [EFL] Make single backing store the default for EWebLauncher
2194         https://bugs.webkit.org/show_bug.cgi?id=55753
2195
2196         Set single backing store the default for EWebLauncher.
2197
2198         * EWebLauncher/main.c:
2199         (main):
2200
2201 2011-03-10  Adam Roben  <aroben@apple.com>
2202
2203         Ignore errors from files being held open when creating a test result archive
2204
2205         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2206         fails to delete the results directory
2207
2208         Reviewed by Mark Rowe.
2209
2210         * BuildSlaveSupport/test-result-archive:
2211         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2212         thrown when a process is holding a file open.
2213
2214 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2215
2216         Unreviewed, rolling out r80701.
2217         http://trac.webkit.org/changeset/80701
2218         https://bugs.webkit.org/show_bug.cgi?id=56126
2219
2220         fast/dom/Geolocation/window-close-crash.html fails on Snow
2221         Leopard release builds (Requested by mihaip on #webkit).
2222
2223         * DumpRenderTree/LayoutTestController.cpp:
2224         (LayoutTestController::staticFunctions):
2225         * DumpRenderTree/LayoutTestController.h:
2226         * DumpRenderTree/chromium/LayoutTestController.cpp:
2227         (LayoutTestController::LayoutTestController):
2228         * DumpRenderTree/chromium/LayoutTestController.h:
2229         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2230         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2231         * DumpRenderTree/mac/UIDelegate.h:
2232         * DumpRenderTree/mac/UIDelegate.mm:
2233         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2234         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2235         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2236         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2237
2238 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2239
2240         Reviewed by Gustavo Noronha Silva.
2241
2242         [GTK] run-gtk-tests doesn't fail if a test crashes
2243         https://bugs.webkit.org/show_bug.cgi?id=56089
2244
2245         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2246         even if a test crashes. So run the tests individually and if a
2247         test fails remember its exit code so run-gtk-test fails too, if
2248         required.
2249
2250 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2251
2252         Reviewed by Dmitry Titov.
2253
2254         Detach Geolocation from Frame when Page destroyed.
2255         https://bugs.webkit.org/show_bug.cgi?id=52877
2256
2257         Extend the layout test controller to expose the number of pending
2258         geolocation requests, so that we can test that the requests have
2259         been cancelled on page close.
2260
2261         * DumpRenderTree/LayoutTestController.cpp:
2262         (numberOfPendingGeolocationPermissionRequestsCallback):
2263         (LayoutTestController::staticFunctions):
2264         * DumpRenderTree/LayoutTestController.h:
2265         * DumpRenderTree/chromium/LayoutTestController.cpp:
2266         (LayoutTestController::LayoutTestController):
2267         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2268         * DumpRenderTree/chromium/LayoutTestController.h:
2269         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2270         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2271         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2272         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2273         * DumpRenderTree/mac/UIDelegate.h:
2274         * DumpRenderTree/mac/UIDelegate.mm:
2275         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2276         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2277         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2278         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2279         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2280         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2281         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2282         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2283
2284
2285 2011-03-09  Adam Roben  <aroben@apple.com>
2286
2287         Hide Leaks Viewer's URL prompt by default
2288
2289         We will show it as needed. I think I left it visible by default by accident after doing some
2290         testing.
2291
2292         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2293         URL is passed as a query parameter, but does
2294
2295         Reviewed by Simon Fraser.
2296
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2298
2299 2011-03-09  Adam Roben  <aroben@apple.com>
2300
2301         Don't use Element.classList or box-shadow in Leaks Viewer
2302
2303         They aren't supported by Safari 5. Luckily we have substitutes for them!
2304
2305         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2306
2307         Reviewed by Simon Fraser.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2310         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2311
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2313         (LeaksViewer.urlPromptButtonClicked):
2314         (LeaksViewer._displayURLPrompt):
2315         (LeaksViewer._setLoadingIndicatorHidden):
2316         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2317
2318 2011-03-09  Adam Roben  <aroben@apple.com>
2319
2320         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2321
2322         Rubber-stamped by David Kilzer.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2325
2326 2011-03-09  Adam Roben  <aroben@apple.com>
2327
2328         Add a Leaks Viewer tool to build.webkit.org
2329
2330         This tool parses leaks from the files generated by the leaks bot and displays them in a
2331         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2332         code).
2333
2334         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2335         be passed to the tool via the "url" query parameter.
2336
2337         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2338         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2339         Inspector's Heavy profile view. But it's still pretty useful as-is.
2340
2341         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2342
2343         Reviewed by Darin Adler.
2344
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2346         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2347         (#url-prompt): This is the prompt itself.
2348
2349         (#loading-indicator):
2350         (#loading-indicator > img):
2351         These show a spinner in the bottom-right when we're loading a leaks file.
2352
2353         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2354         as percentages.
2355
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2357         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2358         URL if one wasn't given to us as a query parameter).
2359
2360         (LeaksViewer.get loading):
2361         (LeaksViewer.set loading):
2362         (LeaksViewer.get url):
2363         (LeaksViewer.set url):
2364         Pretty simple accessors.
2365
2366         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2367         prompt.
2368         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2369         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2370         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2371         the profile to the Web Inspector code once it's been created.
2372         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2373         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2374         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2375         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2376
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2378         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2379         (ProfilerAgent.getProfile): Store the callback.
2380         (ProfilerAgent.profileReady): Call the callback.
2381         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2382         count and total leak counts as real values, not percentages or milliseconds.
2383
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2385         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2386         (parseLeaks): Extract call stacks out of a leaks file.
2387         (createNode): Helper function to create a new empty profile node.
2388         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2389         WebInspector.ProfileView.
2390
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2392
2393 2011-03-09  Dan Bernstein  <mitz@apple.com>
2394
2395         Reviewed by Adam Roben.
2396
2397         Combine multiple --ignore-tests values
2398         https://bugs.webkit.org/show_bug.cgi?id=56016
2399
2400         * Scripts/old-run-webkit-tests:
2401
2402 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2403
2404         Reviewed by David Levin.
2405
2406         Adding myself to the committer file.
2407
2408         * Scripts/webkitpy/common/config/committers.py:
2409
2410 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2411
2412         Rubber-stamped by Adam Roben.
2413
2414         Fix two leaks I introduced into the API tests.
2415
2416         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2417         (TestWebKitAPI::TEST):
2418
2419 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2420
2421         Reviewed by Anders Carlsson.
2422
2423         Crash in CFNetwork visiting google.com
2424         https://bugs.webkit.org/show_bug.cgi?id=55958
2425
2426         Add a test for not trying to copy a null CFURLResponse.
2427
2428         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2429         (TestWebKitAPI::TEST):
2430         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2431
2432 2011-03-08  Hayato Ito  <hayato@chromium.org>
2433
2434         Reviewed by Ojan Vafai.
2435
2436         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2437
2438         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2439
2440         https://bugs.webkit.org/show_bug.cgi?id=55450
2441
2442         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2443
2444 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2445
2446         Reviewed by Martin Robinson.
2447
2448         [GTK] Add layoutTestController.setValueForUser() after r80412
2449         https://bugs.webkit.org/show_bug.cgi?id=55862
2450
2451         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2452         (LayoutTestController::setValueForUser): Implement setValueForUser()
2453
2454 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2455
2456         Reviewed by Adam Barth.
2457
2458         Add script_shell_command to WebKitPort
2459         https://bugs.webkit.org/show_bug.cgi?id=55925
2460
2461         Add a central place where we generate the shell command from the script name.
2462         This function will be used later to detect the correct script interpreter on Win32.
2463
2464         * Scripts/webkitpy/common/config/ports.py:
2465         * Scripts/webkitpy/layout_tests/port/base.py:
2466         * Scripts/webkitpy/tool/steps/abstractstep.py:
2467         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2468
2469 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2470
2471         Reviewed by Adam Barth.
2472
2473         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2474         https://bugs.webkit.org/show_bug.cgi?id=55749
2475
2476         * Scripts/webkitpy/tool/commands/upload.py:
2477         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2478         * Scripts/webkitpy/tool/steps/__init__.py:
2479         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2480         * Scripts/webkitpy/tool/steps/options.py:
2481
2482 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2483
2484         Reviewed by David Levin.
2485
2486         Add support for DataTransferItems
2487         https://bugs.webkit.org/show_bug.cgi?id=55115
2488
2489         Enable data transfer items in DRT.
2490
2491         * DumpRenderTree/chromium/TestShell.cpp:
2492         (TestShell::TestShell):
2493
2494 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2495
2496         Reviewed by Tony Chang.
2497
2498         [test dashboard] pull treemap files
2499         https://bugs.webkit.org/show_bug.cgi?id=55852
2500
2501         * TestResultServer/handlers/dashboardhandler.py:
2502
2503 2011-03-03  Hayato Ito  <hayato@chromium.org>
2504
2505         Reviewed by Mihai Parparita.
2506
2507         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2508         previous image should not be used in the ChromiumDriver.
2509
2510         Also make sure that output image from the ChromiumDriver should be ''
2511         (empty string) if a test crashes for consistency with the WebKitDriver
2512         implementation.
2513
2514         https://bugs.webkit.org/show_bug.cgi?id=55746
2515
2516         * Scripts/webkitpy/layout_tests/port/chromium.py:
2517
2518 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2519
2520         Reviewed by Martin Robinson.
2521
2522         [Gtk] fast/js/navigator-language.html fails locally
2523         https://bugs.webkit.org/show_bug.cgi?id=55880
2524
2525         Add LANG variable to the clean environment when running
2526         old-run-webkit-tests script.
2527
2528         * Scripts/old-run-webkit-tests:
2529
2530 2011-03-07  Tony Chang  <tony@chromium.org>
2531
2532         Reviewed by Mihai Parparita.
2533
2534         [Chromium] Find .checksum files without .pngs and vice-versa
2535         https://bugs.webkit.org/show_bug.cgi?id=55236
2536
2537         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2538             mismatched results.
2539
2540 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2541
2542         Reviewed by Beth Dakin.
2543
2544         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2545         https://bugs.webkit.org/show_bug.cgi?id=55706
2546
2547         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2548
2549         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2550         (AccessibilityController::focusedElement):
2551            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2552            because it could change at any time.
2553         (AccessibilityController::rootElement):
2554
2555 2011-03-07  Sam Weinig  <sam@webkit.org>
2556
2557         Reviewed by Anders Carlsson.
2558
2559         Add unableToImplementPolicy callback for WebKit2 policy client
2560         <rdar://problem/9071902>
2561         https://bugs.webkit.org/show_bug.cgi?id=55884
2562
2563         * MiniBrowser/mac/BrowserWindowController.m:
2564         (-[BrowserWindowController awakeFromNib]):
2565         Update policy client initialization struct for new member.
2566
2567 2011-03-07  Sam Weinig  <sam@webkit.org>
2568
2569         Reviewed by Anders Carlsson.
2570
2571         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2572         https://bugs.webkit.org/show_bug.cgi?id=55827
2573
2574         * MiniBrowser/mac/BrowserWindowController.m:
2575         (decidePolicyForResponse):
2576         (-[BrowserWindowController awakeFromNib]):
2577         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2578         (TestWebKitAPI::decidePolicyForResponse):
2579         (TestWebKitAPI::TEST):
2580         Update tools for new name.
2581
2582 2011-03-06  Daniel Bates  <dbates@rim.com>
2583
2584         Reviewed by Eric Seidel and David Kilzer.
2585
2586         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2587         https://bugs.webkit.org/show_bug.cgi?id=55503
2588
2589         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2590         in checkForJavaSDK().
2591
2592         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2593
2594         * Scripts/build-webkit:
2595
2596 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2597
2598         Reviewed by Sam Weinig.
2599
2600         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2601
2602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2603         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2604             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2605
2606 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2607
2608         Reviewed by Darin Adler.
2609
2610         HTMLInputElement::setValue() should schedule change event when the element is focused
2611         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2612         https://bugs.webkit.org/show_bug.cgi?id=53160
2613
2614         * DumpRenderTree/LayoutTestController.cpp:
2615         (setValueForUserCallback):
2616         (LayoutTestController::staticFunctions):
2617         * DumpRenderTree/LayoutTestController.h:
2618         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2619         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2621         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2622         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2623         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2624         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2625         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2626         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2627         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2628
2629 2011-03-04  Mark Rowe  <mrowe@apple.com>
2630
2631         Reviewed by Alexey Proskuryakov.
2632
2633         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2634
2635         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2636         
2637         * DumpRenderTree/mac/CheckedMalloc.cpp:
2638         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2639         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2640         and then restore the initial protection flags when we're done.
2641
2642 2011-03-04  Evan Martin  <evan@chromium.org>
2643
2644         Reviewed by Tony Chang.
2645
2646         [gdb] pretty-print KURL in gdb
2647         https://bugs.webkit.org/show_bug.cgi?id=55788
2648
2649         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2650         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2651         pretty-printing.
2652
2653 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2654
2655         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2656
2657         Reviewed by Darin Adler.
2658
2659         * TestWebKitAPI/JavaScriptTest.cpp:
2660         (TestWebKitAPI::javaScriptCallback):
2661         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2662         (TestWebKitAPI::didRunJavaScript):
2663         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2664         (TestWebKitAPI::nullJavaScriptCallback):
2665         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2666         (TestWebKitAPI::didRunJavaScript):
2667
2668 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2669
2670         Make run-api-tests show failed if a test fails.
2671
2672         https://webkit.org/b/55725
2673
2674         Reviewed by Sam Weinig.
2675
2676         * Scripts/run-api-tests:
2677         (runTest): Remove "my" from the nested $result assignment so the
2678         check outside the condition sees the real result.
2679
2680 2011-03-02  MORITA Hajime  <morrita@google.com>
2681
2682         Reviewed by Kent Tamura.
2683
2684         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2685         https://bugs.webkit.org/show_bug.cgi?id=55434
2686
2687         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2688         and passed the object webkit_support::PostDelayedTask directly.
2689
2690         Note that the change keeps postTask() as is because it has a
2691         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2692         the main thread.
2693
2694         * DumpRenderTree/chromium/Task.cpp:
2695         (postDelayedTask):
2696         * DumpRenderTree/chromium/Task.h:
2697         (WebTask::Run):
2698
2699 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2700
2701         Reviewed by Kenneth Rohde Christiansen.
2702
2703         [QT] Implement mock client-based geolocation for layout testing
2704         https://bugs.webkit.org/show_bug.cgi?id=54334
2705
2706         Implement testing for Client-Based geolocation for QtWebkit.
2707
2708         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2709         (WebCore::DumpRenderTree::DumpRenderTree):
2710         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2711         (LayoutTestController::reset):
2712         (LayoutTestController::setGeolocationPermission):
2713         (LayoutTestController::setMockGeolocationError):
2714         (LayoutTestController::setMockGeolocationPosition):
2715
2716 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2717
2718         Unreviewed, rolling out r80237.
2719         http://trac.webkit.org/changeset/80237
2720         https://bugs.webkit.org/show_bug.cgi?id=55714
2721
2722         Windows bots aren't ready to be core (Requested by aroben on
2723         #webkit).
2724
2725         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2726         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2727
2728 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2729
2730         Reviewed by Tony Chang.
2731
2732         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2733         https://bugs.webkit.org/show_bug.cgi?id=55694
2734         
2735         Fixes for interruptions in NRWT:
2736         - Make TestRunInterruptedException be pickleable correctly (the base
2737           Exception class defines a __reduce__ that does not include the reason)
2738         - Fix ordering of returned arguments from TestRunner2._run_tests
2739           (interrupted and keyboard_interrupted were reversed)
2740         - Fix cancel_workers callsites (was using old name).
2741         - In handle_exception re-raise actual exception instance that was thrown
2742
2743         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2744         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2745         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2746         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2747
2748 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2749
2750         Unreviewed.
2751
2752         Adding myself as a committer.
2753
2754         * Scripts/webkitpy/common/config/committers.py:
2755
2756 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2757
2758         Reviewed by Mihai Parparita.
2759
2760         Teach sheriffbot to answer whois commands
2761         https://bugs.webkit.org/show_bug.cgi?id=55687
2762
2763         * Scripts/webkitpy/tool/bot/irc_command.py:
2764         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2765         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2766
2767 2011-03-03  Victoria Kirst  <vrk@google.com>
2768
2769         Reviewed by Eric Carlson.
2770
2771         Enable media tests in chromium-gpu/test_expectations
2772         https://bugs.webkit.org/show_bug.cgi?id=53608
2773
2774         Add media folder to the list of GPU test paths.
2775
2776         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2777
2778 2011-03-03  Adam Roben  <aroben@apple.com>
2779
2780         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2781
2782         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2783         incorrect parsing of absolute Windows-style file: URLs
2784
2785         Reviewed by Tim Hatcher.
2786
2787         * WebKitTestRunner/TestInvocation.cpp:
2788         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2789         <http://webkit.org/b/55683>.
2790
2791 2011-03-03  Tony Chang  <tony@chromium.org>
2792
2793         Reviewed by Dimitri Glazkov.
2794
2795         [chromium] Run kill-old-processes on the chromium-win bot too
2796         https://bugs.webkit.org/show_bug.cgi?id=55630
2797
2798         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2799         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2800
2801 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2802
2803         Reviewed by Martin Robinson.
2804
2805         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2806         https://bugs.webkit.org/show_bug.cgi?id=53960
2807
2808         * DumpRenderTree/gtk/EventSender.cpp:
2809         (sendClick):
2810         (scheduleAsynchronousClickCallback):
2811
2812 2011-03-03  Adam Roben  <aroben@apple.com>
2813
2814         Look for Windows-style paths when checking whether a test is an Inspector test
2815
2816         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2817         out or crash on Windows 7 Release (WebKit2 Tests)
2818
2819         Reviewed by Darin Adler.
2820
2821         * WebKitTestRunner/TestInvocation.cpp:
2822         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2823         Windows.
2824
2825 2011-03-03  Adam Roben  <aroben@apple.com>
2826
2827         Make Windows 7 Release (Tests) a core builder
2828
2829         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2830         give it a few more days of greenness first.
2831
2832         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2833
2834         Reviewed by Andreas Kling.
2835
2836         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2837         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2838
2839         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2840         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2841         Updated the core regexps to match the buildbot module. Updated the expected results to match
2842         the current set of core builders.
2843
2844 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2845
2846         Reviewed by Andreas Kling.
2847
2848         Adding myself as a reviewer.
2849
2850         * Scripts/webkitpy/common/config/committers.py:
2851
2852 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2853
2854         Reviewed by Xan Lopez.
2855
2856         [GTK] Extended application cache database API and added unit tests file.
2857         https://bugs.webkit.org/show_bug.cgi?id=55335
2858
2859         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2860         of webkit_application_cache_set_maximum_size due to API exposal.
2861
2862 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2863
2864         Reviewed by Adam Barth.
2865
2866         make webkit-patch upload work for security bugs
2867         https://bugs.webkit.org/show_bug.cgi?id=55655
2868
2869         The problem is that we shell out to prepare-ChangeLog,
2870         which does not authenticate with bugzilla. All it needs from
2871         bugzilla is the bug title though. We just pass it through from
2872         webkit-patch instead.
2873
2874         * Scripts/prepare-ChangeLog:
2875         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2876         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2877
2878 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2879
2880         Reviewed by Tony Chang.
2881
2882         [test-dashboard] make gtest JSON match layout-tests JSON
2883         https://bugs.webkit.org/show_bug.cgi?id=55556
2884
2885         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2886         Make this code match.
2887
2888         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2889
2890 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2891
2892         Reviewed by Tony Chang.
2893
2894         NRWT - implement Linux Hardy 64-bit port support. This involves
2895         adding support for non-'x86' architectures and updating the
2896         "deduplicate_tests" script to correctly understand that
2897         port.name() is not always equal to basename(port.baseline_path()).
2898
2899         This change introduces two new port names: 'chromium-linux-x86'
2900         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2901         flag will cause the code to determine which one to use at
2902         runtime, just like we currently do with 'chromium-win'.
2903
2904         https://bugs.webkit.org/show_bug.cgi?id=55535
2905
2906         * Scripts/webkitpy/common/system/executive_mock.py:
2907           Handle 'return_stderr' keyword arg to run_command()
2908         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2909         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2910         * Scripts/webkitpy/layout_tests/port/base.py:
2911         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2912         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2913         * Scripts/webkitpy/layout_tests/port/factory.py:
2914         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2915
2916 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2917
2918         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2919         update symlinks accordingly.
2920
2921         * wx/packaging/build-mac-installer.py:
2922
2923 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2924
2925         Unreviewed, rolling out r80139.
2926         http://trac.webkit.org/changeset/80139
2927         https://bugs.webkit.org/show_bug.cgi?id=55620
2928
2929         failing and crashing tests on Snow Leopard bot (Requested by
2930         mihaip1 on #webkit).
2931
2932         * DumpRenderTree/LayoutTestController.cpp:
2933         (LayoutTestController::staticFunctions):
2934         * DumpRenderTree/LayoutTestController.h:
2935         * DumpRenderTree/chromium/LayoutTestController.cpp:
2936         (LayoutTestController::LayoutTestController):
2937         * DumpRenderTree/chromium/LayoutTestController.h:
2938         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2939         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2940         * DumpRenderTree/mac/UIDelegate.h:
2941         * DumpRenderTree/mac/UIDelegate.mm:
2942         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2943         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2944         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2945         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2946
2947 2011-03-02  Adam Roben  <aroben@apple.com>
2948
2949         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
2950
2951         This matches DumpRenderTree on Windows.
2952
2953         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
2954         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
2955         in WebKit2
2956
2957         Reviewed by Beth Dakin.
2958
2959         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2960         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
2961         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
2962
2963 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2964
2965         Reviewed by David Levin.
2966
2967         Add feature define for data transfer items
2968         https://bugs.webkit.org/show_bug.cgi?id=55510
2969
2970         * Scripts/build-webkit:
2971
2972 2011-03-02  Adam Roben  <aroben@apple.com>
2973
2974         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
2975
2976         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
2977         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
2978         the former location, but was getting lucky on some SnowLeopard machines because symlinks
2979         were being created there pointing into DiagnosticReports. For machines without these
2980         symlinks, crash logs were not getting captured.
2981
2982         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
2983         SnowLeopard machines
2984
2985         Reviewed by Eric Seidel.
2986
2987         * Scripts/old-run-webkit-tests:
2988         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
2989
2990 2011-03-02  Adam Roben  <aroben@apple.com>
2991
2992         Don't try to capture crash logs on platforms that haven't implemented that feature
2993
2994         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
2995         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
2996
2997         Reviewed by Joseph Pecoraro.
2998
2999         * Scripts/old-run-webkit-tests:
3000         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3001         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3002         strictly required to fix bug 55504, but seems worthwhile.
3003
3004 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3005
3006         Reviewed by Dmitry Titov.
3007
3008         Detach Geolocation from Frame when Page destroyed.
3009         https://bugs.webkit.org/show_bug.cgi?id=52877
3010
3011         Extend the layout test controller to expose the number of pending
3012         geolocation requests, so that we can test that the requests have
3013         been cancelled on page close.
3014
3015         * DumpRenderTree/LayoutTestController.cpp:
3016         (numberOfPendingGeolocationPermissionRequestsCallback):
3017         (LayoutTestController::staticFunctions):
3018         * DumpRenderTree/LayoutTestController.h:
3019         * DumpRenderTree/chromium/LayoutTestController.cpp:
3020         (LayoutTestController::LayoutTestController):
3021         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3022         * DumpRenderTree/chromium/LayoutTestController.h:
3023         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3024         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3025         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3026         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3027         * DumpRenderTree/mac/UIDelegate.h:
3028         * DumpRenderTree/mac/UIDelegate.mm:
3029         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3030         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3031         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3032         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3033         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3034         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3035         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3036         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3037
3038
3039 2011-03-01  Kent Tamura  <tkent@chromium.org>
3040
3041         Reviewed by Dimitri Glazkov.
3042
3043         Assertion fails when a form validation bubble appears
3044         https://bugs.webkit.org/show_bug.cgi?id=55550
3045
3046         Test: fast/forms/interactive-validation-attach-assertion.html
3047
3048         * DumpRenderTree/chromium/WebPreferences.cpp:
3049         (WebPreferences::applyTo): Enable the interactive validation feature by
3050           default. This matches to Chromium browser.
3051
3052 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3053
3054         Reviewed by Kent Tamura.
3055
3056         Remove efl port style exception of Webcore/JavaScriptCore
3057         https://bugs.webkit.org/show_bug.cgi?id=55549
3058
3059         WebCore and JavaScriptCore need to adhere WebKit coding style.
3060
3061         * Scripts/webkitpy/style/checker.py:
3062
3063 2011-03-01  Tony Chang  <tony@chromium.org>
3064
3065         Reviewed by Ojan Vafai.
3066
3067         [chromium] clean up temp files on chromium-mac builder too
3068         https://bugs.webkit.org/show_bug.cgi?id=55525
3069
3070         * BuildSlaveSupport/chromium/remove-crash-logs:
3071
3072 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3073
3074         Reviewed by Tony Chang.
3075
3076         wrap json in a function call to afford cross-domain loading
3077         https://bugs.webkit.org/show_bug.cgi?id=55353
3078
3079         Also delete the code that compacts the JSON. It turns out this
3080         breaks the rebaseline tool and is probably a premature optimization anyways.
3081
3082         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3083         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3085         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3086
3087 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3088
3089         Unreviewed, rolling out r80079.
3090         http://trac.webkit.org/changeset/80079
3091         https://bugs.webkit.org/show_bug.cgi?id=55547
3092
3093         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3094
3095         * Scripts/build-webkit:
3096
3097 2011-03-01  Mark Rowe  <mrowe@apple.com>
3098
3099         Reviewed by Sam Weinig.
3100
3101         Update verification scripts to handle WebKit2.
3102
3103         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3104         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3105         WebKit2.
3106
3107 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3108
3109         Reviewed by David Levin.
3110
3111         Add feature define for data transfer items
3112         https://bugs.webkit.org/show_bug.cgi?id=55510
3113
3114         * Scripts/build-webkit:
3115
3116 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3117
3118         Reviewed by Timothy Hatcher.
3119
3120         All Console Messages should be passed to ChromeClients.
3121         https://bugs.webkit.org/show_bug.cgi?id=54926
3122
3123         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3124
3125         * DumpRenderTree/mac/UIDelegate.mm:
3126         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3127
3128 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3129
3130         Reviewed by Adam Barth.
3131
3132         Tragically, we stopped running the python unit tests
3133         on Chromium Win just as I was getting them to be green.
3134         This patch turns them back on.
3135
3136         https://bugs.webkit.org/show_bug.cgi?id=55521
3137
3138         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3139
3140 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3141
3142         Reviewed by Adam Roben.
3143
3144         Disable
3145         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3146            test_kill_all fails on win until it can be properly triaged.
3147
3148         https://bugs.webkit.org/show_bug.cgi?id=54790
3149
3150         * Scripts/webkitpy/common/system/executive_unittest.py:
3151
3152     2011-03-01  Helder Correia  <helder@sencha.com>
3153
3154             Unreviewed. Add myself to committers.py.
3155
3156             * Scripts/webkitpy/common/config/committers.py:
3157
3158 2011-03-01  Adam Roben  <aroben@apple.com>
3159
3160         Give up if a crash log for the web process is taking too long to be saved on Windows
3161
3162         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3163         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3164
3165         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3166         to be saved for the web process
3167
3168         Reviewed by Steve Falkenburg.
3169
3170         * WebKitTestRunner/win/TestControllerWin.cpp:
3171         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3172         Generalized the code slightly to handle the optional object to wait on.
3173         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3174         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3175         prevent us from waiting forever.
3176
3177 2011-03-01  Adam Roben  <aroben@apple.com>
3178
3179         Give WebKitLauncherWin's PDB file a name different from WebKit's
3180
3181         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3182         fighting over the same PDB file, meaning that one of them was going to lose and not have
3183         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3184
3185         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3186         runs (due to missing symbols)
3187
3188         Reviewed by David Kilzer.
3189
3190         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3191         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3192
3193 2011-03-01  Adam Roben  <aroben@apple.com>
3194
3195         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3196
3197         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3198         --exit-after-n-crashes-or-timeouts limit
3199
3200         Reviewed by David Kilzer.
3201
3202         * Scripts/old-run-webkit-tests:
3203         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3204         the number of tests that caused the web process to crash when exiting early.
3205
3206 2011-03-01  Adam Roben  <aroben@apple.com>
3207
3208         Save a crash log when the web process crashes
3209
3210         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3211         until it has finished crashing, which guarantees that the crash log will have had time to be
3212         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3213         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3214
3215         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3216         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3217
3218         Reviewed by Sam Weinig.
3219
3220         * Scripts/old-run-webkit-tests:
3221         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3222         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3223         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3224         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3225         WebProces_*.crash files when the web process crashes.
3226
3227         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3228         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3229         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3230         along to platformInitialize.
3231
3232         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3233
3234         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3235         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3236
3237         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3238         (WTR::InjectedBundle::platformInitialize):
3239         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3240         (WTR::InjectedBundle::platformInitialize):
3241         Updated function signature.
3242
3243         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3244         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3245         webProcessCrashingEvent, then lets the crash continue as normal.
3246
3247         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3248         event we should use to tell the UI process we're crashing from the initializationUserData,
3249         and get a handle to that event.
3250
3251         * WebKitTestRunner/TestController.cpp:
3252         (WTR::TestController::TestController): Initialize new members.
3253         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3254         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3255         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3256         default.)
3257
3258         * WebKitTestRunner/TestController.h: Added new members.
3259
3260         * WebKitTestRunner/win/TestControllerWin.cpp:
3261         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3262         us it's crashing.
3263         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3264         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3265         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3266         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3267         so the test harness will know the web process has crashed and not try to kill us, then wait
3268         for the web process to finish crashing so a crash log will have time to be saved.
3269         (WTR::toWK): Simple hepler function.
3270         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3271         process should use to tell us it is crashing in the context's initialization user data.
3272
3273 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3274
3275         Reviewed by Tony Gentilcore.
3276
3277         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3278         https://bugs.webkit.org/show_bug.cgi?id=55476
3279
3280         Chromium Win uses BuildAndTestFactory, not TestFactory.
3281
3282         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3283
3284 2011-03-01  Adam Roben  <aroben@apple.com>
3285
3286         Test that the WebKit2 responsiveness timer doesn't fire too early
3287
3288         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3289         early on Windows
3290
3291         Reviewed by Anders Carlsson.
3292
3293         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3294
3295         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3296         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3297         (TestWebKitAPI::didFinishLoadForFrame):
3298         (TestWebKitAPI::processDidBecomeUnresponsive):
3299         (TestWebKitAPI::setInjectedBundleClient):
3300         (TestWebKitAPI::setPageLoaderClient):
3301         Simple helper functions.
3302
3303         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3304         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3305         the responsiveness timer to start, but the web process should unpause before it has a chance
3306         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3307
3308         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3309         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3310         Call up to the base class.
3311         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3312         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3313
3314         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3315         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3316         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3317         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3321         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3322         Added new files.
3323
3324 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3325
3326         Reviewed by Csaba Osztrogonác.
3327
3328         [Qt] Clean up the project files and move common options to WebKit.pri.
3329
3330         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3331
3332
3333 2011-03-01  Adam Roben  <aroben@apple.com>
3334
3335         Skip another multiprocessing test on Windows
3336
3337         It is sometimes failing (and may be leaving child Python processes around).
3338         <http://webkit.org/b/55087> tracks the failure.
3339
3340         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3341         (FuncitonTests.test_get__processes): Skip this test on Windows.
3342
3343 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3344
3345         Reviewed by Pavel Feldman.
3346
3347         Web Inspector: reduce inspector tests flakiness.
3348         https://bugs.webkit.org/show_bug.cgi?id=55401
3349
3350         * DumpRenderTree/chromium/TestShell.cpp:
3351         (TestShell::runFileTest):
3352         * DumpRenderTree/chromium/WebPreferences.cpp:
3353         (WebPreferences::reset):
3354
3355 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3356
3357         Reviewed by James Robinson.
3358
3359         NRWT should still upload results when it exits early due to too many failures
3360         https://bugs.webkit.org/show_bug.cgi?id=55432
3361         
3362         Only keyboard interrupts should prevent results from being uploaded.
3363
3364         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3365         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3366
3367 2011-02-28  Alice Liu  <alice.liu@apple.com>
3368
3369         Reviewed by Adam Roben and Gavin Barraclough.
3370
3371         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3372         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3373
3374         * TestWebKitAPI/InjectedBundleController.h:
3375         (TestWebKitAPI::InjectedBundleController::bundle):
3376         * TestWebKitAPI/PlatformWebView.h:
3377         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3378         (TestWebKitAPI::didFinishLoadForFrame):
3379         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3380         (TestWebKitAPI::setPageLoaderClient):
3381         (TestWebKitAPI::TEST):
3382         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3383         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3384         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3385         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3386         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3387         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3388         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3389         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3390         
3391         Added files to:
3392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3393         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3394         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3395
3396 2011-02-28  Adam Roben  <aroben@apple.com>
3397
3398         Start running InjectedBundle API tests on Windows
3399
3400         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3401
3402         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3403
3404         Reviewed by Darin Adler.
3405
3406         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3407         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3408         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3409         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3410         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3411         These are just extracted from TestWebKitAPI.vcproj.
3412
3413         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3414         up the DLL's filename.
3415
3416         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3417         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3418         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3419
3420         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3421         "all" configuration.
3422
3423         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3424         injected bundle tests. Let VS resort things.
3425
3426         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3427
3428 2011-02-28  Adam Roben  <aroben@apple.com>
3429
3430         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3431
3432         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3433         Large portions of pages with plugins paint black
3434
3435         Reviewed by Anders Carlsson.
3436
3437         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3438         (PluginTest::NPP_HandleEvent):
3439         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3440         Added NPP_HandleEvent. Just returns 0 at this level.
3441
3442         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3443         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3444         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3445         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3446         WM_PAINT has the expected coordinates.
3447
3448         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3449         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3450         else.
3451
3452         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3453         resort things.
3454
3455         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3456         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3457         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3458         webView:didFinishLoadForFrame:] in DumpRenderTree.
3459
3460         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3461         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3462         can start running.
3463
3464 2011-02-28  Adam Roben  <aroben@apple.com>
3465
3466         Tell MiniBrowser's WKViews that they're in a window
3467
3468         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3469
3470         Reviewed by Anders Carlsson.
3471
3472         * MiniBrowser/win/BrowserView.cpp:
3473         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3474
3475 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3476
3477         Reviewed by Csaba Osztrogonác.
3478
3479         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3480         load the proper plugin.
3481
3482         * Scripts/run-qtwebkit-tests:
3483
3484 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3485
3486         Unreviewed, fix spelling mistake.
3487
3488         hardware-accelated => hardware-accelerated.
3489
3490         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3491
3492 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3493
3494         Reviewed by Andreas Kling.
3495
3496         Made sure that the build-webkit --qmake argument is always respected.
3497
3498         Previously, it would be respected during the build, but not during
3499         the early feature detection. The build would also fail if qmake was
3500         not in your path, even if you specified --qmake with a valid qmake
3501         binary.
3502
3503         [Qt] WebKit patches required to work with a modularized version of Qt
3504         https://bugs.webkit.org/show_bug.cgi?id=53916
3505
3506         * Scripts/build-webkit:
3507         * Scripts/webkitdirs.pm:
3508
3509 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3510
3511         Fix failing tests from http://trac.webkit.org/changeset/79837.
3512
3513         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3514         This was just a mistake that would break if someone tried printing with this configuration.
3515         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3516         Method signature changed. Didn't notice that this method was being calling in a unittest.
3517
3518 2011-02-24  Hayato Ito  <hayato@chromium.org>
3519
3520         Reviewed by Eric Seidel.
3521
3522         [NRWT] Remove test_types/* classes.
3523
3524         This is the last patch in the series of efforts which tried to remove test_types classes.
3525         A single_test_runner module will take over responsibilities of test_type classes.
3526
3527         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3528
3529         https://bugs.webkit.org/show_bug.cgi?id=55123
3530
3531         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3532         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3533         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3534         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3535         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3536         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3537         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3538         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3539         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3540         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3541
3542 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3543
3544         Reviewed by Tony Chang.
3545
3546         Change results.json format to the one used by unexpected_results.json
3547         https://bugs.webkit.org/show_bug.cgi?id=52267
3548
3549         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3550         Named the file full_results.json to avoid conflicting with the results.json
3551         file the test-results server currently serves up.
3552
3553         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3554         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3555         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3556         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3557         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3558         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3559
3560 2011-02-27  Adam Roben  <aroben@apple.com>
3561
3562         Followup fix to r79827
3563
3564         * DumpRenderTree/win/UIDelegate.cpp:
3565         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3566         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3567
3568 2011-02-27  Dan Bernstein  <mitz@apple.com>
3569
3570         Reviewed by Adam Roben.
3571
3572         Make bisect-builds print a trac link for the regression range
3573         https://bugs.webkit.org/show_bug.cgi?id=55331
3574
3575         * Scripts/bisect-builds:
3576
3577 2011-02-27  Adam Roben  <aroben@apple.com>
3578
3579         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3580
3581         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3582         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3583         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3584
3585         Reviewed by Anders Carlsson.
3586
3587         * DumpRenderTree/win/EditingDelegate.cpp:
3588         (indexOfFirstWordCharacter):
3589         (wordLength):
3590         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3591
3592 2011-02-27  Adam Roben  <aroben@apple.com>
3593
3594         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3595
3596         This matches Mac. (In fact, the code was ported from Mac!)
3597
3598         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3599         match Mac
3600
3601         Reviewed by Anders Carlsson.
3602
3603         * DumpRenderTree/win/DumpRenderTree.cpp:
3604         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3605         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3606         _drt_descriptionSuitableForTestResult].
3607         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3608
3609         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3610
3611         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3612         DumpRenderTree.cpp.
3613
3614 2011-02-27  Adam Roben  <aroben@apple.com>
3615
3616         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3617
3618         This makes Bugzilla autocompletion work correctly.
3619
3620         * Scripts/webkitpy/common/config/committers.py:
3621
3622 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3623
3624         Reviewed by Andreas Kling.
3625
3626         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3627         https://bugs.webkit.org/show_bug.cgi?id=50911
3628
3629         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3630         (LayoutTestController::setUserStyleSheetLocation):
3631         Use QUrl::fromEncoded since the passed string is already encoded.
3632
3633 2011-02-27  Adam Roben  <aroben@apple.com>
3634
3635         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3636
3637         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3638         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3639         (which&n