Unreviewed, rolling out r190689
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Unreviewed, rolling out r190689
4         https://bugs.webkit.org/show_bug.cgi?id=149992
5
6         Fixed in other repository.
7
8         Reverted changesets:
9
10         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
11         https://bugs.webkit.org/show_bug.cgi?id=149897
12
13 2015-10-09  Brian Burg  <bburg@apple.com>
14
15         Teach webkitperl how to figure out IOS versions from the SDK
16         https://bugs.webkit.org/show_bug.cgi?id=149963
17
18         Reviewed by Daniel Bates.
19
20         It should be easier to check the major and minor version of IOS SDKs.
21
22         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
23         * Scripts/webkitdirs.pm:
24         (splitVersionString): Added.
25         (determineOSXVersion): Use splitVersionString.
26         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
27         (iosVersion): Added.
28
29 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
30
31         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
32         https://bugs.webkit.org/show_bug.cgi?id=149960
33
34         Reviewed by Tim Horton.
35         
36         Use adoptWK(), and null out some members (file is not using ARC).
37
38         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
39         (UIScriptContext::uiScriptComplete):
40         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
41         (-[TestRunnerWKWebView dealloc]):
42
43 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
44
45         Remove ENABLE_SUID_SANDBOX_LINUX cruft
46         https://bugs.webkit.org/show_bug.cgi?id=149954
47
48         Reviewed by Darin Adler.
49
50         * Scripts/webkitperl/FeatureList.pm:
51
52 2015-10-09  Daniel Bates  <dabates@apple.com>
53
54         Make iOS builders generate debug information in a separate dSYM file
55         https://bugs.webkit.org/show_bug.cgi?id=149696
56
57         Reviewed by Darin Adler.
58
59         Similar to the Mac builders, the iOS builders should write debug information
60         into a separate dSYM file instead of including such information in the binary
61         itself (default Xcode behavior)
62
63         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
64         (CompileWebKit.start):
65
66 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
67
68         Fix webkitpy tests after r190779
69         https://bugs.webkit.org/show_bug.cgi?id=149949
70
71         Reviewed by Ryosuke Niwa.
72
73         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
74         (BenchmarkResults.format):
75         (BenchmarkResults._format_values):
76
77 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
78
79         Extend run-benchmark script to support human-readable results conversion.
80         https://bugs.webkit.org/show_bug.cgi?id=149944
81
82         Reviewed by Ryosuke Niwa.
83
84         Add '--read-results-json' and '--no-adjust-unit' options.
85         '--read-results-json' option converts result file to human readable format.
86         '--no-adjust-unit' option skips scientific notation convertion.
87         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
88
89         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
90         (BenchmarkResults.format):
91         (BenchmarkResults._format_tests):
92         (BenchmarkResults._format_values):
93         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
94         (BenchmarkRunner.__init__):
95         (BenchmarkRunner._run_benchmark):
96         (BenchmarkRunner._dump):
97         (BenchmarkRunner.show_results):
98         (BenchmarkRunner._show_results): Deleted.
99         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
100         (parse_args):
101         (start):
102
103 2015-10-08  Daniel Bates  <dabates@apple.com>
104
105         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
106         https://bugs.webkit.org/show_bug.cgi?id=149945
107
108         Reviewed by Dan Bernstein.
109
110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
114         (WebKitBuildbot):
115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
116         (table.queue-grid tr.platform.ios-9 img.logo):
117
118 2015-10-08  Daniel Bates  <dabates@apple.com>
119
120         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
121         https://bugs.webkit.org/show_bug.cgi?id=149943
122
123         Reviewed by Dan Bernstein.
124
125         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
126         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
127
128         * Scripts/build-webkit:
129
130 2015-10-08  Daniel Bates  <dabates@apple.com>
131
132         Add LLVM binaries for iOS 9 device
133         https://bugs.webkit.org/show_bug.cgi?id=149913
134
135         Reviewed by Filip Pizlo.
136
137         Implement support for building LLVM for ARM64-based iOS devices.
138
139         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
140         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
141         an existing build earlier in the file such that remove previously built
142         libraries before building/copying new ones (if applicable).
143         (fileContains): Moved function outside of if-block.
144         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
145         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
146         added logic to build LLVM for ARM64-based iOS devices.
147         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
148         LLVM into the WebKitBuild directory.
149
150 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
151
152         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
153         https://bugs.webkit.org/show_bug.cgi?id=149848
154
155         Reviewed by Darin Adler.
156
157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
158
159 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
160
161         [Win] Support 64-bit Build and Testing
162         https://bugs.webkit.org/show_bug.cgi?id=149904
163
164         Reviewed by Daniel Bates.
165
166         Extend our existing scripts to support 64-bit build and test operations on
167         Windows.
168
169         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
170         Windows always builds the whole stack.
171         * Scripts/webkit-build-directory: Add an option to return the location of
172         the executable files produced by a specific configuration. This change is
173         actually useful for Gtk and EFL, too.
174         * Scripts/webkitdirs.pm:
175         (executableProductDir): Added. This function appends the proper binary
176         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
177         (jscProductDir): Use the new 'executableProductDir' method.
178         (setPathForRunningWebKitApp): Ditto.
179         (runSafari): Ditto.
180         (runMiniBrowser): Ditto.
181         * Scripts/webkitpy/port/factory.py:
182         (configuration_options): Add a 64-bit option, used on Windows to specify
183         which binary target should be used for testing.
184         * Scripts/webkitpy/port/win.py:
185         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
186         processes when needed.
187         (WinPort._build_path): Add the correct binary target path to _build_path.
188         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
189         64-bit paths for 64-bit tests.
190         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
191         NTSD debugger does not understand this argument.
192
193 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
194
195         Test font-variant-* and font-feature-settings with TrueType fonts
196         https://bugs.webkit.org/show_bug.cgi?id=149776
197
198         Reviewed by Simon Fraser.
199
200         This test extends our existing FontWithFeatures project to be able to generate a
201         TrueType font. This font is conceptually similar as the existing OpenType font,
202         except the feature -> character mapping is different.
203
204         The font itself only supports the following characters:
205         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
206         However, the shape of these letters are either an X or a check mark.
207         The letter "A" always is a check mark.
208         The letter "B" always is an X.
209         Each font feature has an letter associated with it. When the font feature is enabled,
210         that letter is shown as a check mark. For example, when
211         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
212         mark.
213
214         Here are the mappings of font features to letters:
215         kLigaturesType / kCommonLigaturesOnSelector: C
216         kLigaturesType / kContextualLigaturesOnSelector: D
217         kLigaturesType / kRareLigaturesOnSelector: G
218         kLigaturesType / kHistoricalLigaturesOnSelector: I
219         kContextualAlternatesType / kContextualAlternatesOnSelector: L
220         kVerticalPositionType / kInferiorsSelector: O
221         kVerticalPositionType / kSuperiorsSelector: P
222         kLowerCaseType / kLowerCaseSmallCapsSelector: S
223         kUpperCaseType / kUpperCaseSmallCapsSelector: V
224         kLowerCaseType / kLowerCasePetiteCapsSelector: T
225         kUpperCaseType / kUpperCasePetiteCapsSelector: W
226         kLetterCaseType / 14: Y
227         kStyleOptionsType / kTitlingCapsSelector: a
228         kNumberCaseType / kUpperCaseNumbersSelector: c
229         kNumberCaseType / kLowerCaseNumbersSelector: d
230         kNumberSpacingType / kProportionalNumbersSelector: f
231         kNumberSpacingType / kMonospacedNumbersSelector: g
232         kFractionsType / kDiagonalFractionsSelector: i
233         kFractionsType / kVerticalFractionsSelector: j
234         kVerticalPositionType / kOrdinalsSelector: Q
235         kTypographicExtrasType / kSlashedZeroOnSelector: k
236         kLigaturesType / kHistoricalLigaturesOnSelector: K
237         kCharacterShapeType / kJIS1978CharactersSelector: m
238         kCharacterShapeType / kJIS1983CharactersSelector: n
239         kCharacterShapeType / kJIS1990CharactersSelector: o
240         kCharacterShapeType / kJIS2004CharactersSelector: p
241         kCharacterShapeType / kSimplifiedCharactersSelector: q
242         kCharacterShapeType / kTraditionalCharactersSelector: r
243         kTextSpacingType / kMonospacedTextSelector: t
244         kTextSpacingType / kProportionalTextSelector: u
245         kRubyKanaType / kRubyKanaOnSelector: v
246
247         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
248         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
249         (CFFBuilder::moveTo):
250         (CFFBuilder::lineTo):
251         (GLYFBuilder::GLYFBuilder):
252         (GLYFBuilder::takeResult):
253         (GLYFBuilder::moveTo):
254         (GLYFBuilder::lineTo):
255         (GLYFBuilder::closePath):
256         (GLYFBuilder::writePoint):
257         (GLYFBuilder::append16):
258         (generateBoxCharString):
259         (generateCheckCharString):
260         (generateXCharString):
261         (itemForGlyph):
262         (Generator::generate):
263         (Generator::insertSelector):
264         (Generator::insertFeature):
265         (Generator::generateFeatureDescription):
266         (Generator::appendCFFTable):
267         (Generator::appendGLYFTable):
268         (Generator::appendLOCATable):
269         (Generator::appendFEATTable):
270         (Generator::appendMetamorphosisChain):
271         (Generator::appendMORXTable):
272         (Generator::appendHEADTable):
273         (Generator::appendHMTXTable):
274         (Generator::appendNameSubtable):
275         (Generator::append2ByteASCIIString):
276         (Generator::appendNAMETable):
277         (generateFont):
278         (CFFBuilder::curveToCubic): Deleted.
279         (charStringForGlyph): Deleted.
280         * FontWithFeatures/FontWithFeatures/FontCreator.h:
281         * FontWithFeatures/FontWithFeatures/main.cpp:
282         (constructFontWithTrueTypeFeature):
283         (constructFontWithOpenTypeFeature):
284         (drawText):
285         (main):
286         (drawTextWithFeature): Deleted.
287
288 2015-10-07  Commit Queue  <commit-queue@webkit.org>
289
290         Unreviewed, rolling out r190572, r190593, r190594, and
291         r190639.
292         https://bugs.webkit.org/show_bug.cgi?id=149897
293
294         Breaks Mavericks build (Requested by litherum on #webkit).
295
296         Reverted changesets:
297
298         "Allow WKRetainPtrs to be used as keys in hashing data
299         structures"
300         https://bugs.webkit.org/show_bug.cgi?id=149762
301         http://trac.webkit.org/changeset/190572
302
303         "REGRESSION(189668?): http/tests/notifications/events.html
304         flakily asserts or times out"
305         https://bugs.webkit.org/show_bug.cgi?id=149218
306         http://trac.webkit.org/changeset/190593
307
308         "Prospective Mavericks build fix."
309         http://trac.webkit.org/changeset/190594
310
311         "Post-review cleanup after r190572."
312         http://trac.webkit.org/changeset/190639
313
314 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
315
316         [GTK] Add autocleanups
317         https://bugs.webkit.org/show_bug.cgi?id=149588
318
319         Reviewed by Darin Adler.
320
321         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
322         (AutocleanupsTest::create):
323         (AutocleanupsTest::testWebProcessAutocleanups):
324         (registerTests):
325         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
326         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
327         (testUIProcessAutocleanups):
328         (testWebProcessAutocleanups):
329         (beforeAll):
330         (afterAll):
331
332 2015-10-06  Brian Burg  <bburg@apple.com>
333
334         Unreviewed, try to fix the iOS 8 build after r190368.
335
336         On older versions, IOHIDEventCreateForceEvent is not available.
337
338         * WebKitTestRunner/ios/HIDEventGenerator.mm:
339         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
340
341 2015-10-06  Keith Miller  <keith_miller@apple.com>
342
343         Add gmalloc option to run-javascriptcore-tests.
344         https://bugs.webkit.org/show_bug.cgi?id=149858
345
346         Reviewed by Geoffrey Garen.
347
348         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
349         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
350
351         * Scripts/run-javascriptcore-tests:
352
353 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
354
355         Post-review cleanup after r190572.
356
357         Unreviewed.
358
359         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
360
361 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
362
363         [Win] Unreviewed build correction.
364
365         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
366         are soft-linked at runtime.
367
368 2015-10-06  Keith Miller  <keith_miller@apple.com>
369
370         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
371         https://bugs.webkit.org/show_bug.cgi?id=149815
372
373         Reviewed by Filip Pizlo.
374
375         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
376         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
377         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
378         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
379         so should just use one test runner.
380
381         * Scripts/run-javascriptcore-tests:
382         (runJSCStressTests):
383         (runMozillaTests): Deleted.
384         (defaultJsDriverArgsForMozillaTests): Deleted.
385         * Scripts/run-jsc-stress-tests:
386
387 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
388
389         [GTK] Make update-webkitgtk-libs work behind firewall
390
391         update-webkitgtk-libs can work behind a firewall with changes to
392         a few packages.  Where outbound git and active FTP connections
393         fail, using http protocol succeeds.  Most packages are
394         already accessed using http.
395
396         https://bugs.webkit.org/show_bug.cgi?id=148941
397
398         Reviewed by Martin Robinson.
399
400         Tools
401         * gtk/jhbuild.modules:
402             Replace git URLs with http.  Remove no longer used ftp repositories.
403             Update argument for libxml2's autogen.sh script (--without-python
404             is ignored; --with-python=no is correct).
405         * jhbuild/jhbuild-wrapper:
406             Instead of connecting to git://git.gnome.org/jhbuild, connect to
407             http://git.gnome.org/browse/jhbuild.
408
409 2015-10-06  Daniel Bates  <dbates@webkit.org>
410
411         Enable XSLT when building WebKit for iOS using the public iOS SDK
412         https://bugs.webkit.org/show_bug.cgi?id=149827
413
414         Reviewed by Alexey Proskuryakov.
415
416         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
417         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
418         run this script before building WebKit for iOS or the build will fail because one or more XSLT
419         headers cannot be found.
420
421         * Scripts/configure-xcode-for-ios-development:
422         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
423
424 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
425
426         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
427         https://bugs.webkit.org/show_bug.cgi?id=149218
428
429         Reviewed by Alexey Proskuryakov.
430
431         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
432         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
433         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
434         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
435         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
436         WebNotificationProvider must be updated to appropriately handle multiple
437         WKNotificationManagerRefs in flight at the same time.
438
439         * WebKitTestRunner/WebNotificationProvider.cpp:
440         (WTR::WebNotificationProvider::~WebNotificationProvider):
441         (WTR::WebNotificationProvider::showWebNotification):
442         (WTR::WebNotificationProvider::closeWebNotification):
443         (WTR::WebNotificationProvider::addNotificationManager):
444         (WTR::WebNotificationProvider::removeNotificationManager):
445         (WTR::WebNotificationProvider::simulateWebNotificationClick):
446         (WTR::WebNotificationProvider::reset):
447         * WebKitTestRunner/WebNotificationProvider.h:
448
449 2015-10-05  Daniel Bates  <dabates@apple.com>
450
451         Disable Bitcode when building for iOS device
452         https://bugs.webkit.org/show_bug.cgi?id=149818
453
454         Reviewed by Alexey Proskuryakov.
455
456         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
457         when building for iOS device.
458
459         * Scripts/webkitdirs.pm:
460         (XcodeOptions):
461
462 2015-10-05  Daniel Bates  <dabates@apple.com>
463
464         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
465         https://bugs.webkit.org/show_bug.cgi?id=140828
466         <rdar://problem/19520599>
467
468         Reviewed by Alexey Proskuryakov.
469
470         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
471         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
472         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
473         to build-webkit.
474
475         * Scripts/webkitdirs.pm:
476         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
477         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
478         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
479         (hasIOSDevelopmentCertificate): Added.
480
481 2015-10-05  Daniel Bates  <dabates@apple.com>
482
483         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
484         https://bugs.webkit.org/show_bug.cgi?id=149766
485
486         Reviewed by Alexey Proskuryakov.
487
488         Create network storage testing session on iOS.
489
490         Currently we do not create a network storage testing session on iOS. A network storage testing session always
491         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
492         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
493         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
494         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
495         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
496         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
497         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
498         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
499
500         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
501         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
502         returns a non-null pointer to a cookie store.
503
504         * DumpRenderTree/mac/DumpRenderTree.mm:
505         (prepareConsistentTestingEnvironment):
506
507 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
508
509         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
510         available.
511
512         * WebKitTestRunner/ios/HIDEventGenerator.mm:
513         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
514
515 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
516
517         Allow WKRetainPtrs to be used as keys in hashing data structures
518         https://bugs.webkit.org/show_bug.cgi?id=149762
519
520         Reviewed by Anders Carlsson.
521
522         * TestWebKitAPI/PlatformGTK.cmake:
523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
524         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
525         (TestWebKitAPI::TEST):
526
527 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
528
529         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
530         available, and tidy up the #ifdefs in the UIKitSPI header.
531
532         * WebKitTestRunner/ios/HIDEventGenerator.mm:
533         (-[HIDEventGenerator _sendHIDEvent:]):
534         * WebKitTestRunner/ios/UIKitSPI.h:
535
536 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
537
538         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
539         https://bugs.webkit.org/show_bug.cgi?id=149792
540
541         Reviewed by Martin Robinson.
542
543         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
544         for WebKitTestRunner multiple times.
545
546 2015-10-04  Daniel Bates  <dabates@apple.com>
547
548         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
549         (https://bugs.webkit.org/show_bug.cgi?id=149753)
550
551         For now, support calling build-layouttestrelay without --ios-simulator so long
552         as we are building on a Mac.
553
554         * Scripts/build-layouttestrelay:
555
556 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
557
558         Support Trac 1.0.x XML timeline link format
559         https://bugs.webkit.org/show_bug.cgi?id=149786
560
561         Reviewed by Lucas Forschler.
562
563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
564         (Trac.prototype._convertCommitInfoElementToObject):
565
566 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
567
568         Fix some errors on bot watcher's dashboard
569         https://bugs.webkit.org/show_bug.cgi?id=149789
570
571         Reviewed by Lucas Forschler.
572
573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
574         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
575         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
576
577 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
578
579         Bot watcher's dashboard builders should turn yellow when svn fails
580         https://bugs.webkit.org/show_bug.cgi?id=149791
581
582         Reviewed by Lucas Forschler.
583
584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
585         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
586         (BuildbotBuilderQueueView.prototype.update):
587
588 2015-10-02  Daniel Bates  <dabates@apple.com>
589
590         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
591         https://bugs.webkit.org/show_bug.cgi?id=149769
592
593         Reviewed by Alexey Proskuryakov.
594
595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
599         (WebKitBuildbot):
600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
601         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
602
603 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
604
605         REGRESSION(r190370): Speedometer spits out an extra console message
606         https://bugs.webkit.org/show_bug.cgi?id=149720
607
608         Unreviewed. Temporarily ignore the console error message.
609
610         * Scripts/webkitpy/performance_tests/perftest.py:
611         (PerfTest._filter_output):
612
613 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
614
615         Provide "--no-ninja" option to avoid using Ninja
616         https://bugs.webkit.org/show_bug.cgi?id=149757
617
618         Reviewed by Alex Christensen.
619
620         Add a new command line argument understood by webkitdirs.pm so
621         that we can conditionally avoid using Ninja. This is an
622         'opt-out' argument, so no existing Ninja users should be affected.
623         
624         * Scripts/webkitdirs.pm:
625         (canUseNinja): Check for option and block ninja if present.
626
627 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
628
629         Flakiness dashboard should support OS X El Capitan
630         https://bugs.webkit.org/show_bug.cgi?id=149648
631
632         Reviewed by Alexey Proskuryakov.
633
634         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
635
636 2015-10-02  Daniel Bates  <dabates@apple.com>
637
638         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
639         (https://bugs.webkit.org/show_bug.cgi?id=149753)
640
641         For now, pass --ios-simulator.
642
643         * Scripts/webkitpy/port/ios.py:
644         (IOSSimulatorPort._build_relay):
645
646 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
647
648         Remove a "nullable" that breaks the iOS 8 build.
649
650         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
651         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
652
653 2015-10-02  Daniel Bates  <dabates@apple.com>
654
655         LayoutTestRelay is not built and archived when building for iOS Simulator
656         https://bugs.webkit.org/show_bug.cgi?id=149753
657
658         Reviewed by Alexey Proskuryakov and Andy Estes.
659
660         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
661         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
662         product archive when building for iOS Simulator, respectively.
663
664         * BuildSlaveSupport/built-product-archive:
665         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
666         differentiate between iOS device and iOS Simulator platforms.
667         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
668         from determineWebKitBuildDirectories() into this function so that it can be used by both
669         determineWebKitBuildDirectories() and archiveBuiltProduct().
670         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
671         webkitBuildDirectoryForConfigurationAndPlatform().
672         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
673         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
674         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
675         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
676         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
677         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
678         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
679         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
680         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
681         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
682         * Scripts/build-layouttestrelay:
683             - Remove unnecessary include of Perl module POSIX.
684             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
685         * Scripts/build-webkit:
686             - Invoke script build-layouttestrelay when building for iOS Simulator.
687
688 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
689
690         [Win] Unreviewed test fix.
691
692         You cannot run 'run-webkit-tests' from the command line because it does not know
693         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
694         because they explicitly set use the 'root' argument to provide the full path to
695         the test binaries.
696
697         * Scripts/webkitpy/port/win.py:
698         (WinPort._build_path): Added.
699
700 2015-10-02  Alex Christensen  <achristensen@webkit.org>
701
702         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
703         https://bugs.webkit.org/show_bug.cgi?id=149430
704         rdar://problem/22742222
705
706         Reviewed by Geoffrey Garen.
707
708         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
709         (WTR::TestController::cocoaResetStateToConsistentValues):
710         * WebKitTestRunner/mac/TestControllerMac.mm:
711         (WTR::TestController::platformConfigureViewForTest):
712         Test what happens when you disable content blockers from the SPI.
713
714 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
715
716         [Win] Unreviewed build fix for run-api-tests
717
718         * Scripts/run-api-tests:
719         (testToolPaths): Windows run needs to specify the binary path.
720
721 2015-10-01  Daniel Bates  <dabates@apple.com>
722
723         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
724         (https://bugs.webkit.org/show_bug.cgi?id=149695)
725
726         Following r190424 we can now rely on webkit-build-directory to return the path to
727         the correct configuration-specific build directory on Windows.
728
729         * BuildSlaveSupport/built-product-archive:
730         (archiveBuiltProduct):
731
732 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
733
734         [Win] Unreviewed build fix.
735
736         * Scripts/webkitdirs.pm:
737         (setupAppleWinEnv): Use 64-bit build tools if available
738
739 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
740
741         [Win] Fix TestWebKitAPI build under CMake.
742
743         Reviewed by Alex Christensen.
744
745         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
746         for Psapi.lib.
747
748 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
749
750         [Win] Fix behavior of webkit-build-directory script
751         https://bugs.webkit.org/show_bug.cgi?id=149718
752
753         Reviewed by Alex Christensen.
754
755         * Scripts/webkitdirs.pm:
756         (determineConfigurationProductDir): Do not include the binary
757         sub-directory in the configuration product directory output.
758         (jscProductDir): Append correct binary path for Windows build.
759         (setPathForRunningWebKitApp): Include properly binary subdirectories.
760         (runSafari): Update for revised productDir behavior.
761         (runMiniBrowser): Ditto.
762
763 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
764
765         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
766         use iOS SDK, like with all the others.
767
768         * Scripts/build-webkit:
769
770 2015-10-01  Daniel Bates  <dabates@apple.com>
771
772         Attempt to fix the iOS 9 Simulator testers
773
774         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
775         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
776         LayoutTestRelay when building for iOS Simulator.
777
778         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
779         * Scripts/build-webkit:
780
781 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
782
783         [GTK] Websites with invalid auth header keep loading forever
784         https://bugs.webkit.org/show_bug.cgi?id=149710
785
786         Reviewed by Martin Robinson.
787
788         Add test case to check that we can authenticate sites with an
789         empty realm.
790
791         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
792         (testWebViewAuthenticationEmptyRealm):
793         (serverCallback):
794         (beforeAll):
795
796 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
797
798         [Mac] Make run-api-tests work with System Integrity Protection
799         https://bugs.webkit.org/show_bug.cgi?id=149711
800         rdar://problem/22928202
801
802         Reviewed by Dan Bernstein.
803
804         * Scripts/run-api-tests:
805         (runTest):
806         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
807
808 2015-10-01  Daniel Bates  <dabates@apple.com>
809
810         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
811         (https://bugs.webkit.org/show_bug.cgi?id=149695)
812
813         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
814         For now, use the path to the top-level WebKit build directory instead of using the configuration-
815         specific build directory.
816
817         * BuildSlaveSupport/built-product-archive:
818         (archiveBuiltProduct):
819
820 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
821
822         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
823         https://bugs.webkit.org/show_bug.cgi?id=145837
824
825         Reviewed by Philippe Normand.
826
827         * efl/jhbuild.modules:
828         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
829         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
830
831 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
832
833         Unreviewed. Fix the iOS build after r190407.
834
835         * WebKitTestRunner/ios/IOKitSPI.h:
836
837 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
838
839         Implement keyboard event sending for iOS in WebKitTestRunner
840         https://bugs.webkit.org/show_bug.cgi?id=149676
841
842         Reviewed by Simon Fraser.
843
844         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
845         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
846         allows us to run code when the keyboard is shown or hidden.
847
848         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
849         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
850         (WTR::UIScriptController::setDidShowKeyboardCallback):
851         (WTR::UIScriptController::didShowKeyboardCallback):
852         (WTR::UIScriptController::setDidHideKeyboardCallback):
853         (WTR::UIScriptController::didHideKeyboardCallback):
854         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
855         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
856         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
857         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
858         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
859         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
860         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
861                 the notifications that the keyboard has been raised or lowered.
862         (-[TestRunnerWKWebView _keyboardDidShow:]):
863         (-[TestRunnerWKWebView _keyboardDidHide:]):
864         * WebKitTestRunner/ios/HIDEventGenerator.h:
865         * WebKitTestRunner/ios/HIDEventGenerator.m:
866         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
867         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
868         (hidUsageCodeForCharacter): Ditto.
869         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
870                 a keyDown event in WebKit.
871         * WebKitTestRunner/ios/IOKitSPI.h:
872         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
873
874 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
875
876         Unreviewed, rolling out r190399.
877
878         Tests are still failing even after r190362
879
880         Reverted changeset:
881
882         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
883         http://trac.webkit.org/changeset/190399
884
885 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
886
887         [jhbuild] switch to new upstream usrsctp library
888         https://bugs.webkit.org/show_bug.cgi?id=149494
889
890         Reviewed by Philippe Normand.
891
892         * efl/jhbuild.modules:
893         * gtk/jhbuild.modules:
894
895 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
896
897         Unreviewed. Unskip GTK+ user media unit tests after r190362.
898
899         They should pass now.
900
901         * Scripts/run-gtk-tests:
902         (TestRunner):
903
904 2015-09-30  Daniel Bates  <dabates@apple.com>
905
906         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
907         (https://bugs.webkit.org/show_bug.cgi?id=149695)
908
909         * BuildSlaveSupport/built-product-archive:
910         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
911         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
912
913 2015-09-30  Daniel Bates  <dabates@apple.com>
914
915         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
916         (https://bugs.webkit.org/show_bug.cgi?id=149695)
917
918         Actually, we need to pass --configuration to script webkit-build-directory to have
919         it return the path to the configuration-specific build directory.
920
921         * BuildSlaveSupport/built-product-archive:
922         (determineWebKitBuildDirectories):
923
924 2015-09-30  Daniel Bates  <dabates@apple.com>
925
926         built-product-archive archives incorrect build directory for iOS port
927         https://bugs.webkit.org/show_bug.cgi?id=149695
928
929         Reviewed by Darin Adler.
930
931         Fixes an issue where the script built-product-archive archives a non-existent
932         build directory for the iOS port. Without loss of generality, the script assumes
933         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
934         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
935
936         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
937         to determine the top-level build directory and computes the configuration-specific
938         build directory to be the concatenation of the the top-level build directory and
939         the configuration (e.g. Release). This is incorrect. Instead we should call
940         webkit-build-directory omitting the flag --top-level to compute the path to the
941         configuration-specific build directory.
942
943         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
944         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
945         its purpose and added global variable _configurationBuildDirectory to store the path
946         to the configuration-specific build directory. Ensure that we have a non-empty string
947         for both the top-level and configuration-specific build directories.
948         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
949         Compute the configuration-specific build directory and store it in the global variable
950         _configurationBuildDirectory.
951         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
952         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
953         as needed.
954         (determineWebKitBuildDirectory): Deleted.
955
956 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
957
958         [EFL] css3/device-adapt/* tests failed after r190335.
959         https://bugs.webkit.org/show_bug.cgi?id=149655
960
961         Reviewed by Simon Fraser.
962
963         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
964         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
965
966         * WebKitTestRunner/efl/TestControllerEfl.cpp:
967         (WTR::shouldUseFixedLayout):
968
969 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
970
971         Extend JetStream timeout for slow devices.
972
973         Reviewed by Chris Dumez.
974
975         Extend JetStream timeout to 20 minutes.
976
977         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
978
979 2015-09-30  Daniel Bates  <dabates@apple.com>
980
981         Rename iOS builders/testers to include version
982         https://bugs.webkit.org/show_bug.cgi?id=149685
983
984         Reviewed by Simon Fraser.
985
986         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
987         make it clear to a reader the version of iOS these builders/testers are using.
988
989         * BuildSlaveSupport/build.webkit.org-config/config.json:
990         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
991
992 2015-09-30  Daniel Bates  <dabates@apple.com>
993
994         Add iOS criterion for triggering a build
995         https://bugs.webkit.org/show_bug.cgi?id=149679
996
997         Rubber-stamped by Alexey Proskuryakov.
998
999         First pass at defining criterion for triggering an iOS build.
1000
1001         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1002         (_should_file_trigger_build):
1003         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1004         (ShouldBuildTest):
1005         (ShouldBuildTest.test_should_build):
1006
1007 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1008
1009         [iOS] Allow tests to generate user gestures for UI testing
1010         https://bugs.webkit.org/show_bug.cgi?id=149653
1011
1012         Reviewed by Tim Horton.
1013
1014         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1015         and to listen for completion of scrolling and zooming in the WKWebView.
1016         
1017         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1018         which hides the complexity of creating these events. Event dispatch is asynchronous.
1019         We detect when the last event has been handled by dispatching a vendor-specific event,
1020         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1021         
1022         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1023         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1024         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1025         single and double taps.
1026         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1027         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1028         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1029         (UIScriptContext::unregisterCallback):
1030         (UIScriptContext::callbackWithID):
1031         (UIScriptContext::fireCallback):
1032         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1033         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1034         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1035         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1036         (WTR::UIScriptController::setDidEndZoomingCallback):
1037         (WTR::UIScriptController::didEndZoomingCallback):
1038         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1039         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1040         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1041         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1042         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1043         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1044         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1045         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1046         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1047         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1048         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1049         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1050         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1051         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1052         (simpleDragCurve):
1053         (calculateNextLocation):
1054         (delayBetweenMove):
1055         (+[HIDEventGenerator sharedHIDEventGenerator]):
1056         (+[HIDEventGenerator nextEventCallbackID]):
1057         (-[HIDEventGenerator init]):
1058         (-[HIDEventGenerator _createIOHIDEventType:]):
1059         (-[HIDEventGenerator _sendHIDEvent:]):
1060         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1061         (-[HIDEventGenerator _updateTouchPoints:count:]):
1062         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1063         (-[HIDEventGenerator touchDown:touchCount:]):
1064         (-[HIDEventGenerator touchDown:]):
1065         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1066         (-[HIDEventGenerator liftUp:touchCount:]):
1067         (-[HIDEventGenerator liftUp:]):
1068         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1069         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1070         (-[HIDEventGenerator tap:completionBlock:]):
1071         (-[HIDEventGenerator doubleTap:completionBlock:]):
1072         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1073         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1074         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1075         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1076         (-[HIDEventGenerator markerEventReceived:]):
1077         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1078         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1079         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1080         (WTR::globalToContentCoordinates):
1081         (WTR::UIScriptController::singleTapAtPoint):
1082         (WTR::UIScriptController::doubleTapAtPoint):
1083         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1084         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1085         * WebKitTestRunner/ios/mainIOS.mm:
1086         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1087
1088 2015-09-30  Dana Burkart  <dburkart@apple.com>
1089
1090         git-add-reviewer should trim trailing spaces/newlines
1091         https://bugs.webkit.org/show_bug.cgi?id=149513
1092
1093         Reviewed by Darin Adler.
1094
1095         * Scripts/git-add-reviewer:
1096         (nonInteractive):
1097
1098 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1099
1100         REGRESSION(r190262): User media unit test failures after r190262
1101         https://bugs.webkit.org/show_bug.cgi?id=149580
1102
1103         Reviewed by Darin Adler.
1104
1105         * WebKitTestRunner/TestController.cpp:
1106         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1107           order to WKUserMediaPermissionRequestAllow.
1108
1109 2015-09-30  Daniel Bates  <dabates@apple.com>
1110
1111         Add iOS builders and testers
1112         https://bugs.webkit.org/show_bug.cgi?id=149549
1113
1114         Reviewed by Alexey Proskuryakov.
1115
1116         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1117         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1118
1119         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1120         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1121
1122 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1123
1124         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1125         https://bugs.webkit.org/show_bug.cgi?id=149674
1126
1127         Reviewed by Lucas Forschler.
1128
1129         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1130         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1131
1132 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1133
1134         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1135         have an associated trac instance.
1136         https://bugs.webkit.org/show_bug.cgi?id=149673
1137
1138         Reviewed by Alexey Proskuryakov.
1139
1140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1141         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1142         have an associated trac instance.
1143
1144 2015-09-30  Daniel Bates  <dabates@apple.com>
1145
1146         Prioritize testing latest build request on iOS test bots
1147         https://bugs.webkit.org/show_bug.cgi?id=149669
1148
1149         Reviewed by Darin Adler.
1150
1151         We should prioritize testing of the latest build request on the iOS test bots
1152         as we do for Mac and Windows test bots.
1153
1154         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1155         (loadBuilderConfig):
1156
1157 2015-09-30  Daniel Bates  <dabates@apple.com>
1158
1159         Add buildbot category for iOS builders and testers
1160         https://bugs.webkit.org/show_bug.cgi?id=149667
1161
1162         Reviewed by Darin Adler.
1163
1164         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1165         for iOS to the build.webkit.org home page.
1166
1167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1168         (loadBuilderConfig):
1169         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1170
1171 2015-09-30  Daniel Bates  <dabates@apple.com>
1172
1173         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1174         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1175
1176         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1177         in <http://trac.webkit.org/changeset/190351>.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1180         (CompileWebKit.start):
1181
1182 2015-09-30  Daniel Bates  <dabates@apple.com>
1183
1184         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1185         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1186
1187         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1188         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1191         (CompileWebKit.start):
1192
1193 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1194
1195         bot210 was configured for a queue instead of bot126.
1196         
1197         Unreviewed config.json fix.
1198         
1199         * BuildSlaveSupport/build.webkit.org-config/config.json:
1200
1201 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1202
1203         Bring El Capitan buildbot infrastructure online.
1204         https://bugs.webkit.org/show_bug.cgi?id=149605
1205         
1206         Reviewed by Darin Adler.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/config.json:
1209
1210 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1211
1212         [GTK] Deprecation warnings in DOMNodeTest
1213         https://bugs.webkit.org/show_bug.cgi?id=149663
1214
1215         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1216         need to update the tests to use webkit_dom_document_query_selector_all
1217         to avoid compilation warnings.
1218
1219         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1220         (the suggested replacement for the deprecated function).
1221
1222         Reviewed by Carlos Garcia Campos.
1223
1224         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1225         (WebKitDOMNodeTest::testTagNamesNodeList):
1226         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1227         (registerTests):
1228         (WebKitDOMNodeTest::testTagNames): Deleted.
1229         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1230         (prepareDOMForTagNamesTests):
1231         (testWebKitDOMNodeTagNamesNodeList):
1232         (testWebKitDOMNodeTagNamesHTMLCollection):
1233         (beforeAll):
1234         (testWebKitDOMNodeTagNames): Deleted.
1235
1236 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1237
1238         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1239         https://bugs.webkit.org/show_bug.cgi?id=149650
1240
1241         Reviewed by Tim Horton.
1242         
1243         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1244         looks at the file path, and not the custom options that come from file comments.
1245         
1246         Fix by computing TestOptions before making the TestInvocation, and setting them
1247         as const TestInvocation data. This meant changing various call sites to take
1248         the std::string pathOrURL, rather than the TestInvocation itself.
1249         
1250         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1251
1252         * WebKitTestRunner/CMakeLists.txt:
1253         * WebKitTestRunner/TestController.cpp:
1254         (WTR::TestController::ensureViewSupportsOptionsForTest):
1255         (WTR::testPath):
1256         (WTR::createTestURL):
1257         (WTR::updateTestOptionsFromTestHeader):
1258         (WTR::TestController::testOptionsForTest):
1259         (WTR::TestController::updateWebViewSizeForTest):
1260         (WTR::TestController::updateWindowScaleForTest):
1261         (WTR::TestController::runTest):
1262         * WebKitTestRunner/TestController.h:
1263         * WebKitTestRunner/TestInvocation.cpp:
1264         (WTR::TestInvocation::TestInvocation):
1265         (WTR::TestInvocation::invoke):
1266         (WTR::createWKURL): Deleted.
1267         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1268         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1269         * WebKitTestRunner/TestInvocation.h:
1270         (WTR::TestInvocation::options):
1271         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1272         (WTR::pathContains):
1273         (WTR::shouldMakeViewportFlexible):
1274         (WTR::shouldUseFixedLayout):
1275         (WTR::isSVGTestPath):
1276         (WTR::isHiDPITestPath):
1277         (WTR::TestOptions::TestOptions):
1278         * WebKitTestRunner/TestOptions.h:
1279         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1280         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1281         (WTR::pathContains):
1282         (WTR::shouldUseFixedLayout):
1283         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1284         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1285         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1286         * WebKitTestRunner/ios/TestControllerIOS.mm:
1287         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1288         * WebKitTestRunner/mac/TestControllerMac.mm:
1289         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1290
1291 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1292
1293         Flakiness dashboard should support OS X El Capitan
1294         https://bugs.webkit.org/show_bug.cgi?id=149648
1295
1296         Reviewed by Alexey Proskuryakov.
1297
1298         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
1299         difference between new appscale and old Google App Engine implementation.
1300         * TestResultServer/app.yaml: Same.
1301         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1302
1303 2015-09-29  Daniel Bates  <dabates@apple.com>
1304
1305         configure-xcode-for-ios-development does not work with Xcode 7
1306         https://bugs.webkit.org/show_bug.cgi?id=149640
1307
1308         Reviewed by Alexey Proskuryakov.
1309
1310         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1311         because it cannot find the Xcode specification files for iOS simulator and device. These
1312         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1313         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1314         new specification files with the added definitions (as we did in older versions of Xcode)
1315         in order for Xcode 7 to honor these definitions.
1316
1317         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1318         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1319         (updateXcode7SpecificationFile): Added.
1320         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1321         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1322         appropriate success message.
1323         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1324         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1325         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1326
1327 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1328
1329         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1330         https://bugs.webkit.org/show_bug.cgi?id=149639
1331
1332         Reviewed by Alex Christensen.
1333
1334         * Scripts/VCSUtils.pm:
1335         (exitStatus): Use 'isWindows()' method.
1336         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1337         an error. This method could probably just go away.
1338         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1339         always changing to Unix style. 
1340         (unixPath): Added. Needed so Windows can always show a Unix path in the
1341         ChangeLog file.
1342         (changeLogName): Work around the fact that 'getpwuid' is not available on
1343         a pure Windows build of Perl.
1344         * Scripts/prepare-ChangeLog:
1345         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1346         path on Windows.
1347         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1348         support using arrays for 'open' arguments.
1349         (resolveChangeLogsPath): Ditto.
1350         (resolveConflictedChangeLogs): Use new helper functions.
1351         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1352         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1353         quotes. Unix systems are happy either way.
1354         (statusCommand): Ditto.
1355         * Scripts/webkitdirs.pm:
1356         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1357
1358 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1359
1360         [Win] Unreviewed 64-bit build fix after switch to CMake.
1361
1362         * Scripts/webkitdirs.pm:
1363         (determineIsWin64FromArchitecture): Added.
1364
1365 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1366
1367         printing does not use minimum page zoom factor
1368         https://bugs.webkit.org/show_bug.cgi?id=108507
1369
1370         Reviewed by Darin Adler.
1371
1372         WebKitTestRunner always takes the snapshots from the UI process
1373         (expect for IOS), so in the case of printing, the layout in the
1374         web view is not the expected one. When printing, we need to take
1375         the snapshot in the web process and ensure it's rendered with a
1376         PrintContext.
1377
1378         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1379         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1380         kWKSnapshotOptionsPrinting option to
1381         WKBundlePageCreateSnapshotWithOptions() when printing.
1382
1383 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1384
1385         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1386         https://bugs.webkit.org/show_bug.cgi?id=149595
1387
1388         Reviewed by Tim Horton.
1389
1390         All ports except IOS implement
1391         PlatformWebView::windowSnapshotImage() to generate the snapshot
1392         for the pixel tests in the UI process. But we are still generating
1393         a snapshot for pixel tests in the Web process too, that is passed
1394         to the UI process but ignored.
1395         Whether a pixel result is needed or not, is only known by the web
1396         process depending on whether the test called dumpAsText with
1397         dumpPixels == true or not. Since the pixels are now dump in the UI
1398         process, we need to pass that information to the UI process when
1399         the test is done. For that we set a PixelResultIsPending bool
1400         parameter to the Done message, and we only add the PixelResult
1401         when UI process doesn't need to generate the pixels dump.
1402
1403         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1404         (WTR::InjectedBundle::didReceiveMessageToPage): Set
1405         m_pixelResultIsPending to false on reset.
1406         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
1407         Done message, and set the PixelResult if m_pixelResultIsPending is false.
1408         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1409         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
1410         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
1411         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1412         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
1413         port.
1414         * WebKitTestRunner/TestInvocation.cpp:
1415         (WTR::TestInvocation::dumpResults): Use either the pixel result
1416         from the web process or generate a pixel result from the web view
1417         if need it.
1418         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1419         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1420         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1421         is created by the caller now, but the CG implementation needs to
1422         know if it's a Web or UI process snapshot.
1423         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1424         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1425         cairo surface for the given image.
1426         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1427         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1428         CGContext for the given image.
1429
1430 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
1431
1432         Fix JS errors on dashboard metrics page
1433         https://bugs.webkit.org/show_bug.cgi?id=149608
1434
1435         Reviewed by Alexey Proskuryakov.
1436
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
1438         (initPlatformsByFamily): 
1439         (updateHiddenPlatforms):
1440         (parsePlatformFamily): Deleted.
1441         (updateToggleButtons): Deleted.
1442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1443         (updateHiddenPlatforms): Added to remove errors.
1444         (initPlatformsByFamily): Added to remove errors.
1445         (unhiddenQueues): Updated to use Settings.
1446         (documentReady): Added logic to add toggle buttons to the settings menu.
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1448         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
1449         MetricsMain.js to Settings.
1450         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
1451         MetricsMain.js to Settings.
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1453         (QueueView.prototype._updateHiddenState): Updated to use Settings.
1454
1455 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
1456
1457         Appscale query fails because of missing index
1458         https://bugs.webkit.org/show_bug.cgi?id=149609
1459
1460         Reviewed by Darin Adler.
1461
1462         * QueueStatusServer/index.yaml: Added the required index.
1463
1464 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1465
1466         [Win] Fix the 64-bit build after switch to cmake.
1467
1468         Reviewed by Alex Christensen.
1469
1470         * Scripts/webkitdirs.pm:
1471         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
1472         run a 64-bit build.
1473
1474 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1475
1476         [Win] Allow Windows to run test-webkitpy without Cygwin
1477         https://bugs.webkit.org/show_bug.cgi?id=149602
1478
1479         Reviewed by Alex Christensen.
1480
1481         These changes mostly shift from hard-coded paths using UNIX-style
1482         separators to Python's "os.path.join" syntax that uses the correct
1483         path separator for each platform.
1484         
1485         * Scripts/webkitpy/common/system/path.py:
1486         (cygpath): Don't pass paths through Cygpath on native Windows.
1487         * Scripts/webkitpy/port/win.py:
1488         (WinPort._path_to_apache): Use os.path.join.
1489         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
1490         in 64-bit environments).
1491         * Scripts/webkitpy/style/checker.py: Use os.path.join.
1492         * Scripts/webkitpy/style/checker_unittest.py:
1493         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
1494         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
1495         (GlobalVariablesTest): Ditto.
1496         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
1497         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
1498         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
1499         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
1500         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
1501         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
1502         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
1503         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
1504         (StyleProcessor_CodeCoverageTest): Ditto.
1505         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
1506         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
1507         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
1508         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
1509         manual string concatenation of paths.
1510
1511 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1512
1513         Add bugzilla addresses of committers to contributors.json
1514         https://bugs.webkit.org/show_bug.cgi?id=149520
1515
1516         Reviewed by Darin Adler.
1517
1518         * Scripts/webkitpy/common/config/contributors.json:
1519
1520 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1521
1522         validate-committer-lists -b shouldn't need edituser privileges
1523         https://bugs.webkit.org/show_bug.cgi?id=149519
1524
1525         Reviewed by Darin Adler.
1526
1527         * Scripts/validate-committer-lists:
1528         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
1529         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1530         (BugzillaQueries.is_invalid_bugzilla_email):
1531         (BugzillaQueries): Deleted.
1532         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
1533
1534 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1535
1536         Unreviewed. Gardening: skip media stream tests failing after r190262.
1537
1538         * Scripts/run-gtk-tests:
1539         (TestRunner):
1540
1541 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1542
1543         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
1544         https://bugs.webkit.org/show_bug.cgi?id=149571
1545
1546         Reviewed by Dan Bernstein.
1547
1548         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
1549
1550         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1551         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1552         * LayoutTestRelay/Configurations/Base.xcconfig:
1553         * MiniBrowser/Configurations/Base.xcconfig:
1554         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1555         * TestWebKitAPI/Configurations/Base.xcconfig:
1556         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1557         * WebEditingTester/Configurations/Base.xcconfig:
1558         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1559         * WebKitTestRunner/Configurations/Base.xcconfig:
1560         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1561         * WebKitTestRunner/iOS.xcconfig: Removed.
1562
1563 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
1564
1565         Clean up user media request internal API
1566         https://bugs.webkit.org/show_bug.cgi?id=149527
1567
1568         Reviewed by Tim Horton.
1569
1570         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1571         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1572
1573         * WebKitTestRunner/TestController.cpp:
1574         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1575
1576 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1577
1578         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1579         https://bugs.webkit.org/show_bug.cgi?id=149577
1580
1581         Reviewed by Tim Horton.
1582         
1583         When calling testRunner.runUIScript() from a page load event, the script could run
1584         in the UI process before the current remote layer tree transaction had been handled
1585         there. This meant that runUIScript() could query state which was about to change.
1586         
1587         Fix by delaying the execution of the UI script until a layer tree transaction has
1588         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1589
1590         * WebKitTestRunner/TestInvocation.cpp:
1591         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1592         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1593         * WebKitTestRunner/TestInvocation.h:
1594
1595 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1596
1597         [Mac] Media tests start to time out after a few days of bot uptime
1598         https://bugs.webkit.org/show_bug.cgi?id=149468
1599
1600         Reviewed by Darin Adler.
1601
1602         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1603         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1604         all temporary and cache files go to a custom location.
1605
1606         * Scripts/webkitpy/port/base.py:
1607         * Scripts/webkitpy/port/driver.py:
1608         * Scripts/webkitpy/port/mac.py:
1609         * Scripts/webkitpy/port/win.py:
1610         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1611
1612 2015-09-25  Dan Bernstein  <mitz@apple.com>
1613
1614         Removed MiniBrowser.entitlements.
1615
1616         Rubber-stamped by Anders Carlsson.
1617
1618         The entitlements weren’t used anyway.
1619
1620         * MiniBrowser/MiniBrowser.entitlements: Removed.
1621         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1622
1623 2015-09-24  Daniel Bates  <dabates@apple.com>
1624
1625         Add WebKitSystemInterface for iOS 9.0
1626         https://bugs.webkit.org/show_bug.cgi?id=149550
1627
1628         Rubber-stamped by Alexey Proskuryakov.
1629
1630         * Scripts/copy-webkitlibraries-to-product-directory:
1631
1632 2015-09-24  Daniel Bates  <dabates@apple.com>
1633
1634         Support building for arbitrary architectures
1635         https://bugs.webkit.org/show_bug.cgi?id=149539
1636
1637         Reviewed by Alexey Proskuryakov.
1638
1639         Teach buildbot to pass the architectures associated with the builder to build-webkit
1640         when building on OS X and iOS. As a side effect of this change we now support building
1641         universal binaries when multiples architectures are specified.
1642
1643         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1644         (CompileWebKit.start):
1645
1646 2015-09-24  Daniel Bates  <dabates@apple.com>
1647
1648         Fix the build after <http://trac.webkit.org/changeset/190212>
1649         (http://trac.webkit.org/changeset/190212)
1650
1651         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1652
1653         * BuildSlaveSupport/built-product-archive:
1654         (main):
1655
1656 2015-09-24  Daniel Bates  <dabates@apple.com>
1657
1658         Support running unit tests on iOS Simulator test bot
1659         https://bugs.webkit.org/show_bug.cgi?id=149536
1660
1661         Reviewed by Alexey Proskuryakov.
1662
1663         Implements support for running unit tests on a iOS test bot. At the time of writing,
1664         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1665
1666         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1667         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1668         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1669
1670 2015-09-24  Daniel Bates  <dabates@apple.com>
1671
1672         Add support infrastructure for OpenSource iOS builders and testers
1673         https://bugs.webkit.org/show_bug.cgi?id=149534
1674
1675         Reviewed by Darin Adler.
1676
1677         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1678         scripts about iOS.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1681         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1682         --ios-simulator or --device for a builder/tester whose full platform name begins with
1683         "ios-simulator" or "ios", respectively.
1684         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1685         * BuildSlaveSupport/built-product-archive:
1686         (main): Pass the full platform name to determineWebKitBuildDirectory().
1687         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1688         command line flag when building for iOS.
1689         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1690         parameter fullPlatform. This parameter was originally added in r125066 to support the
1691         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1692         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1693         * BuildSlaveSupport/clean-build:
1694         (main): Call script webkit-build-directory with the appropriate command line flag when
1695         building for iOS.
1696         * BuildSlaveSupport/delete-stale-build-files:
1697         (main): Use the same logic for iOS as we do for Mac.
1698         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1699         flag when building for iOS.
1700         * BuildSlaveSupport/test-result-archive:
1701         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1702
1703 2015-09-24  Daniel Bates  <dabates@apple.com>
1704
1705         Remove Chromium-specific changes to script built-product-archive
1706         https://bugs.webkit.org/show_bug.cgi?id=149530
1707
1708         Rubber-stamped by Csaba Osztrogonác.
1709
1710         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1711         Chromium code has long since been removed from the OpenSource WebKit Project.
1712
1713         * BuildSlaveSupport/built-product-archive:
1714         (createZipManually):
1715         (createZip):
1716         (archiveBuiltProduct):
1717
1718 2015-09-24  Dan Bernstein  <mitz@apple.com>
1719
1720         Build fix.
1721
1722         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1723
1724 2015-09-24  Mark Lam  <mark.lam@apple.com>
1725
1726         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1727
1728         * Scripts/webkitpy/common/config/contributors.json:
1729
1730 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1731
1732         Unreviewed. Fix GObject DOM API breaks after r190120.
1733
1734         Bring back code removed in r169931 to handle documentation of
1735         deleted classes.
1736
1737         * gtk/webkitdom.py:
1738         (WebKitDOMDocGenerator):
1739         (WebKitDOMDocGenerator.write_deleted_classes):
1740         (WebKitDOMDocGenerator.generate):
1741         (write_deleted_classes):
1742         (WebKitDOMDocGeneratorSections._deleted_class):
1743         (WebKitDOMDocGeneratorSections._deleted_class.in):
1744         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1745         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1746
1747 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1748
1749         [Cocoa] [Font Features] Implement font-variant-*
1750         https://bugs.webkit.org/show_bug.cgi?id=148413
1751
1752         Reviewed by Darin Adler.
1753
1754         Update test font to use "lnum" feature.
1755
1756         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1757         (Generator::appendGSUBTable):
1758
1759 2015-09-22  Andy Estes  <aestes@apple.com>
1760
1761         ContentFiltering.AllowDownloadAfterAddData is very flaky
1762         https://bugs.webkit.org/show_bug.cgi?id=148885
1763         <rdar://problem/22729563>
1764
1765         Reviewed by Alexey Proskuryakov.
1766
1767         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1768         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1769         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1770
1771         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1772         (downloadTest):
1773
1774 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1775
1776         Mavericks: Media tests start to time out after a few days of bot uptime
1777         https://bugs.webkit.org/show_bug.cgi?id=149468
1778
1779         Reviewed by Chris Dumez.
1780
1781         * Scripts/webkitpy/port/base.py:
1782         * Scripts/webkitpy/port/driver.py:
1783         * Scripts/webkitpy/port/mac.py:
1784
1785 2015-09-22  Nan Wang  <n_wang@apple.com>
1786
1787         Unreviewed, add myself to the committers list.
1788
1789         * Scripts/webkitpy/common/config/contributors.json:
1790
1791 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1792
1793         Remove 'nullable' to fix older iOS builds.
1794
1795         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1796         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1797
1798 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1799
1800         [Win] Show tiled drawing debug overlay on Windows
1801         https://bugs.webkit.org/show_bug.cgi?id=149426
1802
1803         Reviewed by Dean Jackson.
1804
1805         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1806         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1807         * MiniBrowser/win/Common.cpp:
1808         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1809         flag if needed.
1810         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1811
1812 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1813
1814         [Win] Use command-line argument to launch in regular or High DPI mode.
1815         https://bugs.webkit.org/show_bug.cgi?id=149417
1816
1817         Reviewed by Dean Jackson.
1818
1819         * MiniBrowser/win/Common.cpp:
1820         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1821         very start of execution, before the MiniBrowser.dll is loaded.
1822         * win/DLLLauncher/DLLLauncherMain.cpp:
1823         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1824         present. On WinCairo, always use High DPI.
1825
1826 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1827
1828         32-bit Mac build fix attempt after r190065.
1829
1830         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1831
1832 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1833
1834         [OS X] Update for Xcode 7.0 on Yosemite
1835         https://bugs.webkit.org/show_bug.cgi?id=149389
1836
1837         Reviewed by Dan Bernstein.
1838
1839         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1840         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1841         Removed unneeded declarations - conforming to a protocol is sufficient.
1842
1843         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1844         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1845         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1846         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1847
1848 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1849
1850         Add the ability for tests to run script in the UI process in WebKitTestRunner
1851         https://bugs.webkit.org/show_bug.cgi?id=149356
1852
1853         Reviewed by Tim Horton.
1854
1855         This change adds testRunner.runUIScript(script, callback), which allows a test
1856         to execute script in a JSContext which runs in the UI process. That context
1857         has bindings exposed through the UIScriptController interface; currently one test
1858         function, and some iOS-specific functions are included. UIScriptController can be
1859         async with a callback, and runUIScript() itself is asynchronous. When the UI 
1860         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1861         is a string passed back to the web process, and given to the runUIScript()
1862         callback function.
1863         
1864         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1865
1866         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1867         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1868         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1869         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1870         complete, call back into TestRunner.
1871         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1872         (WTR::nextUIScriptCallbackID):
1873         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1874         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1876         * WebKitTestRunner/PlatformWebView.h:
1877         * WebKitTestRunner/TestController.cpp:
1878         (WTR::updateTestOptionsFromTestHeader):
1879         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1880         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1881         * WebKitTestRunner/TestInvocation.cpp:
1882         (WTR::TestInvocation::shouldUseFixedLayout):
1883         (WTR::TestInvocation::shouldUseThreadedScrolling):
1884         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1885         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1886         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1887         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1888         * WebKitTestRunner/TestInvocation.h:
1889         * WebKitTestRunner/TestOptions.h:
1890         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1891         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1892         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1893         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1894         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1895         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1896         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1897         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1898         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1899         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1900         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1901         (WTR::UIScriptController::doAsyncTask):
1902         (WTR::UIScriptController::zoomToScale):
1903         (WTR::UIScriptController::zoomScale):
1904         (WTR::UIScriptController::minimumZoomScale):
1905         (WTR::UIScriptController::maximumZoomScale):
1906         (WTR::UIScriptController::contentVisibleRect):
1907         * WebKitTestRunner/mac/EventSenderProxy.mm:
1908         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1909         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1910         * WebKitTestRunner/mac/TestControllerMac.mm:
1911         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1912         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1913         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1914         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1915         (UIScriptContext::UIScriptContext):
1916         (UIScriptContext::~UIScriptContext):
1917         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1918         asynchronous, call the callback.
1919         (UIScriptContext::nextTaskCallbackID):
1920         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1921         that has a callback). Has to store the callbackID of the script, so code called from the completion
1922         callback knows which UI script invoked it.
1923         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1924         (UIScriptContext::uiScriptComplete):
1925         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1926         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1927         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1928         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1929         (WTR::UIScriptController::UIScriptController):
1930         (WTR::UIScriptController::makeWindowObject):
1931         (WTR::UIScriptController::wrapperClass):
1932         (WTR::UIScriptController::doAsyncTask):
1933         (WTR::UIScriptController::zoomToScale):
1934         (WTR::UIScriptController::zoomScale):
1935         (WTR::UIScriptController::minimumZoomScale):
1936         (WTR::UIScriptController::maximumZoomScale):
1937         (WTR::UIScriptController::contentVisibleRect):
1938         (WTR::UIScriptController::uiScriptComplete):
1939         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1940         (WTR::UIScriptController::create):
1941         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1942
1943 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1944
1945         Turn on threaded scrolling by default in the tests
1946         https://bugs.webkit.org/show_bug.cgi?id=149377
1947
1948         Reviewed by Simon Fraser.
1949
1950         * WebKitTestRunner/mac/TestControllerMac.mm:
1951         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1952         (WTR::shouldUseThreadedScrolling): Deleted.
1953         Turn on threaded scrolling by default.
1954
1955 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1956
1957         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1958         https://bugs.webkit.org/show_bug.cgi?id=149252
1959
1960         Reviewed by Darin Adler.
1961
1962         In case of glib tests the test runner notifies about tests
1963         crashing, but for google tests we don't get any feedback, which
1964         means that in case of a test crashing we get a list of **PASS**
1965         messages and at the summary we are notified that the test suite
1966         has failed, but it's impossible to know which test cases have failed.
1967
1968         * Scripts/run-gtk-tests:
1969         (TestRunner._run_google_test): Add a **CRASH** message if test
1970         case crashed.
1971
1972 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1973
1974         WebKitTestRunner can leak user content script results between tests
1975         https://bugs.webkit.org/show_bug.cgi?id=149391
1976
1977         Reviewed by Sam Weinig.
1978
1979         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1980         about:blank, and thus about:blank doesn't have unintended side effects.
1981
1982         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1983         (WTR::InjectedBundle::beginTesting):
1984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1985         (WTR::InjectedBundlePage::resetAfterTest):
1986
1987 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1988
1989         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1990         https://bugs.webkit.org/show_bug.cgi?id=149384
1991
1992         Reviewed by Chris Fleizach.
1993
1994         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1995         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1996         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1997         regardless of whether someone else holds a reference (we also call -stopListening in
1998         -dealloc).
1999
2000         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2001         (AccessibilityController::platformResetToConsistentState):
2002         (AccessibilityController::addNotificationListener):
2003         Ditto.
2004
2005 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2006
2007         Remove XHR_TIMEOUT compilation guard
2008         https://bugs.webkit.org/show_bug.cgi?id=149260
2009
2010         Reviewed by Benjamin Poulain.
2011
2012         * Scripts/webkitperl/FeatureList.pm:
2013
2014 2015-09-19  Dan Bernstein  <mitz@apple.com>
2015
2016         Attempted build fix.
2017
2018         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2019
2020 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2021
2022         Unreviewed, rolling out r189908.
2023         https://bugs.webkit.org/show_bug.cgi?id=149368
2024
2025         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2026
2027         Reverted changeset:
2028
2029         "printing does not use minimum page zoom factor"
2030         https://bugs.webkit.org/show_bug.cgi?id=108507
2031         http://trac.webkit.org/changeset/189908
2032
2033 2015-09-18  Andy Estes  <aestes@apple.com>
2034
2035         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2036         https://bugs.webkit.org/show_bug.cgi?id=149360
2037
2038         Reviewed by Tim Horton.
2039
2040         Added an API test.
2041
2042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2043         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2044         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2045         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2046         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2047         (TEST):
2048         * TestWebKitAPI/ios/pages.pages: Added.
2049
2050 2015-09-18  Nan Wang  <n_wang@apple.com>
2051
2052         AX: Implement ARIA 1.1 @aria-current on iOS
2053         https://bugs.webkit.org/show_bug.cgi?id=149297
2054
2055         Reviewed by Chris Fleizach.
2056
2057         Added support to test aria-current on iOS.
2058
2059         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2060         (AccessibilityUIElement::stringAttributeValue):
2061         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2062         (WTR::AccessibilityUIElement::stringAttributeValue):
2063
2064 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2065
2066         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2067         https://bugs.webkit.org/show_bug.cgi?id=149352
2068
2069         Reviewed by Simon Fraser.
2070
2071         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2072         m_context can be null. This may indicate a bug in webkitpy too, but
2073         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2074         wrong with opening and immediately closing it.
2075
2076 2015-09-18  Daniel Bates  <dabates@apple.com>
2077
2078         isGitSVNDirectory() returns true when Git is not installed
2079         https://bugs.webkit.org/show_bug.cgi?id=149351
2080
2081         Reviewed by Alexey Proskuryakov.
2082
2083         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2084         Git is not installed on the machine.
2085
2086         * Scripts/VCSUtils.pm:
2087         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2088         status code 0 (success).
2089
2090 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2091
2092         Prevent build-webkit from building four times on Windows 
2093         https://bugs.webkit.org/show_bug.cgi?id=149336
2094
2095         Reviewed by Brent Fulgham.
2096
2097         * Scripts/build-webkit:
2098         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2099         They're built all at once.
2100         * Scripts/webkitdirs.pm:
2101         (buildVisualStudioProject):
2102         (cmakeGeneratedBuildfile):
2103         Don't generate the Visual Studio solution if it already exists.
2104         It will run CMake again if necessary.
2105
2106 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2107
2108         [iOS WK2] WTR fails to set the key window in the UIKit sense
2109         https://bugs.webkit.org/show_bug.cgi?id=149325
2110
2111         Reviewed by Tim Horton.
2112
2113         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2114         This causes UIKit to bypass code that actually sets the key window, resulting in
2115         [UIAppliation sharedApplication].keyWindow always being nil.
2116
2117         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2118         -[WebKitTestRunnerWindow isKeyWindow] call super.
2119
2120         * WebKitTestRunner/PlatformWebView.h:
2121         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2122         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2123         (WTR::PlatformWebView::setWindowIsKey):
2124         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2125         (WTR::PlatformWebView::setWindowIsKey):
2126         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2127         (-[WebKitTestRunnerWindow isKeyWindow]):
2128         (WTR::PlatformWebView::PlatformWebView):
2129         (WTR::PlatformWebView::~PlatformWebView):
2130         (WTR::PlatformWebView::setWindowIsKey):
2131         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2132         (WTR::PlatformWebView::setWindowIsKey):
2133
2134 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2135
2136         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2137         https://bugs.webkit.org/show_bug.cgi?id=149321
2138
2139         Reviewed by Tim Horton.
2140         
2141         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
2142         enabled the "testing" viewport configuration, which disables page scaling.
2143         
2144         If we're running viewport tests, we want the normal web page configuration.
2145         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2146         based on whether the test is in a "viewport" directory.
2147
2148         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2149         (WTR::InjectedBundle::beginTesting):
2150         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2151         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2152         * WebKitTestRunner/TestInvocation.cpp:
2153         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2154         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2155         (WTR::TestInvocation::shouldMakeViewportFlexible):
2156         (WTR::TestInvocation::invoke):
2157         * WebKitTestRunner/TestInvocation.h:
2158         * WebKitTestRunner/ios/TestControllerIOS.mm:
2159         (WTR::TestController::platformConfigureViewForTest):
2160         (WTR::shouldMakeViewportFlexible): Deleted.
2161
2162 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2163
2164         Give iOS WebKitTestRunner a launch storyboard
2165         https://bugs.webkit.org/show_bug.cgi?id=149314
2166
2167         Reviewed by Dan Bates.
2168         
2169         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2170         that it's been built for specific device configurations, and puts the window
2171         at the top of the screen. This simplifies coordinate conversions in a future patch.
2172
2173         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2174         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2175         * WebKitTestRunner/ios/Launch.storyboard: Added.
2176
2177 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2178
2179         Update licence in r189890
2180         https://bugs.webkit.org/show_bug.cgi?id=149306
2181
2182         Reviewed by Dean Jackson.
2183
2184         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2185         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2186         * FontWithFeatures/FontWithFeatures/main.cpp:
2187
2188 2015-09-17  Mark Lam  <mark.lam@apple.com>
2189
2190         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2191         https://bugs.webkit.org/show_bug.cgi?id=149285
2192
2193         Reviewed by Saam Barati.
2194
2195         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2196
2197         * Scripts/run-javascriptcore-tests:
2198         (runJSCStressTests):
2199
2200 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2201
2202         Switch AppleWin build to use CMake
2203         https://bugs.webkit.org/show_bug.cgi?id=149163
2204
2205         Reviewed by Brent Fulgham.
2206
2207         * Scripts/build-webkit:
2208         * Scripts/run-api-tests:
2209         (runTest):
2210         (listAllTests):
2211         (prepareEnvironmentForRunningTestTool):
2212         (testToolPaths):
2213         (testToolPath): Deleted.
2214         Run the API tests as separate executables on Windows.
2215         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2216         * Scripts/webkitdirs.pm:
2217         (checkRequiredSystemConfig):
2218         (jhbuildWrapperPrefixIfNeeded):
2219         (generateBuildSystemFromCMakeProject):
2220         Fix configuration quirks.
2221
2222 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2223
2224         Added toggle options for hiding and showing certain platform families on the dashboard.
2225         https://bugs.webkit.org/show_bug.cgi?id=148403
2226
2227         Reviewed by David Kilzer.
2228
2229         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2230         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2231         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2232         in lieu of an "all" button in the toggle menu.
2233
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2235         (parsePlatformFamily): Helper function to parse out a platform family.
2236         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2237         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2238         (updateToggleButtons): Updates the status of the toggle buttons.
2239         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2240         (documentReady): Added creation of toggle buttons.
2241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2242         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2243         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2244         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
2245         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2247         (QueueView): Updated to use hiddenPlatformFamilies.
2248         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2250         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2251         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2252         (Settings.prototype.toggleHiddenPlatform): Deleted.
2253         (Settings.prototype.clearHiddenPlatforms): Deleted.
2254         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2256         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2257         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2258         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2259         (table.queue-grid tr.headers th):
2260         (div.settingsWrapper.hide):
2261         (div.settingsWrapper):
2262         (div.familyToggleWrapper):
2263         (div.platformFamilyToggleButton):
2264         (div.platformFamilyShowToggleButton:not(:last-child)):
2265         (div.familyShown):
2266         (div.accessibilityButton):
2267         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2268         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2269         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2270         platformFamilyToggleButton and settingsWrapper class.
2271         (.accessibilityButton): Deleted.
2272
2273 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2274
2275         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2276         https://bugs.webkit.org/show_bug.cgi?id=148904
2277
2278         Reviewed by Myles Maxfield.
2279
2280         * WebKitTestRunner/TestController.cpp:
2281         (WTR::parseBooleanTestHeaderValue):
2282         (WTR::updateViewOptionsFromTestHeader):
2283         Check for the key "useThreadedScrolling".
2284         Add some code to check for "true" and "false" for boolean options.
2285
2286         (WTR::TestController::viewOptionsForTest):
2287         Apply the test's overrides last, even after the platform's.
2288
2289 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2290
2291         printing does not use minimum page zoom factor
2292         https://bugs.webkit.org/show_bug.cgi?id=108507
2293
2294         Reviewed by Darin Adler.
2295
2296         WebKitTestRunner always takes the snapshots from the UI process
2297         (expect for IOS), so in the case of printing, the layout in the
2298         web view is not the expected one. When printing, we need to take
2299         the snapshot in the web process and ensure it's rendered with a
2300         PrintContext.
2301
2302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2303         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2304         kWKSnapshotOptionsPrinting option to
2305         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2306         printing, don't even create the snapshot, since it will be ignored
2307         by the UI process that always creates its own from the WebView (expect for IOS platform)
2308         * WebKitTestRunner/TestInvocation.cpp:
2309         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2310         received from the web process if any when comparing pixel
2311         results. Now we only receive a snapshot from the web process in
2312         case of printing, or when platform is IOS. Otherwhise, generate
2313         the snapshot from the WebView as usual.
2314         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2315         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2316         is created by the caller now, but the CG implementation needs to
2317         know if it's a Web or UI process snapshot.
2318         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2319         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2320         cairo surface for the given image.
2321         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2322         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2323         CGContext for the given image.
2324
2325 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2326
2327         Create a font which can be used for testing font features
2328         https://bugs.webkit.org/show_bug.cgi?id=149237
2329
2330         Reviewed by Simon Fraser.
2331
2332         This patch adds a new project in the Tools/ directory which generates a font which can
2333         be used for testing font features. This is a standalone project consisting of two files:
2334         1. A file which actually generates the byte vector representing the font. This file has
2335         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2336         specific, and only relies on the C++ STL.
2337         2. A file with a main() which calls generateFont() and writes out the font, as well as
2338         uses the font to render some demonstration text into a .png file. This file is platform
2339         specific.
2340
2341         The font itself only supports the following characters:
2342         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2343         However, the shape of these letters are either an X or a check mark.
2344
2345         The letter "A" always is a check mark.
2346         The letter "B" always is an X.
2347         Without any font features turned on, the rest of the letters are shown as X.
2348
2349         Each font feature has an letter associated with it. When the font feature is enabled,
2350         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2351         as a check mark.
2352
2353         Here are the mappings of font features to letters:
2354         liga: C
2355         clig: D
2356         dlig: E
2357         hlig: F
2358         calt: G
2359         subs: H
2360         sups: I
2361         smcp: J
2362         c2sc: K
2363         pcap: L
2364         c2pc: M
2365         unic: N
2366         titl: O
2367         onum: P
2368         pnum: Q
2369         tnum: R
2370         frac: S
2371         afrc: T
2372         ordn: U
2373         zero: V
2374         hist: W
2375         jp78: X
2376         jp83: Y
2377         jp90: Z
2378         jp04: a
2379         smpl: b
2380         trad: c
2381         fwid: d
2382         pwid: e
2383         ruby: f
2384
2385         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2386         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2387         (integralLog2):
2388         (roundDownToPowerOfTwo):
2389         (isFourByteAligned):
2390         (clampTo):
2391         (append32):
2392         (writeCFFEncodedNumber):
2393         (CFFBuilder::CFFBuilder):
2394         (CFFBuilder::takeResult):
2395         (CFFBuilder::moveTo):
2396         (CFFBuilder::lineTo):
2397         (CFFBuilder::curveToCubic):
2398         (CFFBuilder::closePath):
2399         (CFFBuilder::writePoint):
2400         (generateBoxCharString):
2401         (generateCheckCharString):
2402         (generateXCharString):
2403         (charStringForGlyph):
2404         (Generator::generate):
2405         (Generator::Placeholder::Placeholder):
2406         (Generator::Placeholder::populate):
2407         (Generator::Placeholder::~Placeholder):
2408         (Generator::placeholder):
2409         (Generator::append16):
2410         (Generator::append32):
2411         (Generator::append32BitCode):
2412         (Generator::overwrite16):
2413         (Generator::overwrite32):
2414         (Generator::appendCFFTable):
2415         (Generator::appendSubstitutionSubtable):
2416         (Generator::appendScriptSubtable):
2417         (Generator::appendGSUBTable):
2418         (Generator::appendOS2Table):
2419         (Generator::appendFormat12CMAPTable):
2420         (Generator::appendFormat4CMAPTable):
2421         (Generator::appendCMAPTable):
2422         (Generator::appendHEADTable):
2423         (Generator::appendHHEATable):
2424         (Generator::appendHMTXTable):
2425         (Generator::appendMAXPTable):
2426         (Generator::appendNAMETable):
2427         (Generator::appendPOSTTable):
2428         (Generator::calculateChecksum):
2429         (Generator::appendTable):
2430         (generateFont):
2431         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
2432         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
2433         (drawTextWithFeature):
2434         (main):
2435
2436 2015-09-16  Commit Queue  <commit-queue@webkit.org>
2437
2438         Unreviewed, rolling out r189875 and r189878.
2439         https://bugs.webkit.org/show_bug.cgi?id=149235
2440
2441         cygwin cmake build not ready yet (Requested by alexchristensen
2442         on #webkit).
2443
2444         Reverted changesets:
2445
2446         "Switch AppleWin build to use CMake"
2447         https://bugs.webkit.org/show_bug.cgi?id=149163
2448         http://trac.webkit.org/changeset/189875
2449
2450         "Cygwin build fix after r189875"
2451         http://trac.webkit.org/changeset/189878
2452
2453 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2454
2455         Cygwin build fix after r189875
2456
2457         * Scripts/build-webkit:
2458         * Scripts/webkitdirs.pm:
2459         (jhbuildWrapperPrefixIfNeeded):
2460         (generateBuildSystemFromCMakeProject):
2461         Make things work with cygwin and cmake.
2462
2463 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2464
2465         Switch AppleWin build to use CMake
2466         https://bugs.webkit.org/show_bug.cgi?id=149163
2467
2468         Reviewed by Brent Fulgham.
2469
2470         * Scripts/build-webkit:
2471         Build with CMake.
2472         * Scripts/run-api-tests:
2473         (runTest):
2474         (listAllTests):
2475         (prepareEnvironmentForRunningTestTool):
2476         (testToolPaths):
2477         (testToolPath): Deleted.
2478         Run the API tests as separate executables on Windows.
2479         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2480
2481 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
2482
2483         Add newer build.webkit.org pages to robots.txt
2484         https://bugs.webkit.org/show_bug.cgi?id=149219
2485
2486         Reviewed by Darin Adler.
2487
2488         Indexing bot watcher's dashboard can't be good.
2489
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
2491
2492 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2493
2494         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
2495
2496         * BuildSlaveSupport/built-product-archive:
2497         (unzipArchive):
2498
2499 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2500
2501         [EFL] Fix the help message of separated web process option of MiniBrowser
2502         https://bugs.webkit.org/show_bug.cgi?id=149212
2503
2504         Reviewed by Gyuyoung Kim.
2505
2506         * MiniBrowser/efl/main.c:
2507
2508 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2509
2510         Fix python syntax after r189851.
2511
2512         * BuildSlaveSupport/built-product-archive:
2513         (unzipArchive):
2514         For loops need a colon.
2515
2516 2015-09-15  Alex Christensen  <achristensen@webkit.org>
2517
2518         Fix Windows test bots after changing to non-cygwin build
2519         https://bugs.webkit.org/show_bug.cgi?id=149196
2520
2521         Reviewed by Daniel Bates.
2522
2523         * BuildSlaveSupport/built-product-archive:
2524         (unzipArchive):
2525         Using different versions of python makes what I think is https://bugs.python.org/issue15795
2526         prevent us from executing files from the archive on the test bots.
2527
2528 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
2529
2530         Add ShadowRoot interface and Element.prototype.attachShadow
2531         https://bugs.webkit.org/show_bug.cgi?id=149187
2532
2533         Reviewed by Antti Koivisto.
2534
2535         * Scripts/webkitperl/FeatureList.pm:
2536
2537 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
2538
2539         Appscale queue status json output lacks bots
2540         https://bugs.webkit.org/show_bug.cgi?id=149194
2541         <rdar://problem/22171089>
2542
2543         Reviewed by Alexey Proskuryakov.
2544
2545         * QueueStatusServer/handlers/queuestatusjson.py:
2546         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
2547         * QueueStatusServer/index.yaml: Index according to appscale requirements.
2548
2549 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
2550
2551         [Win] Provide a means for viewing the layer tree
2552         https://bugs.webkit.org/show_bug.cgi?id=149165
2553
2554         Reviewed by Simon Fraser.
2555
2556         Update MiniBrowser with a new Debug menu option that will
2557         dump the current layer tree to the debug console.
2558         
2559         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
2560         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
2561         * MiniBrowser/win/Common.cpp:
2562         (WndProc): Add handler for 'Print Layer Tree' menu option.
2563         * MiniBrowser/win/MiniBrowser.cpp:
2564         (MiniBrowser::printLayerTree): Added Handler.
2565         * MiniBrowser/win/MiniBrowser.h:
2566
2567 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2568
2569         WebKitTestRunner declarative language setting is broken for iOS
2570         https://bugs.webkit.org/show_bug.cgi?id=149119
2571
2572         Unreviewed.
2573
2574         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2575         lost in the final version which got committed. This simply implements the existing
2576         OS X behavior on iOS.
2577
2578         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2579         (WTR::InjectedBundle::platformInitialize):
2580
2581 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2582
2583         Unreviewed, add myself to committers list.
2584
2585         * Scripts/webkitpy/common/config/contributors.json:
2586
2587 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2588
2589         [Cocoa] Allow testing with the system language
2590         https://bugs.webkit.org/show_bug.cgi?id=148671
2591
2592         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2593
2594         React to tests marked with language=lang1,lang2,etc in their header.
2595         Once this information is parsed, pass it to
2596         WKContextConfigurationSetOverrideLanguages().
2597
2598         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2599         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2600         list.
2601         * WebKitTestRunner/TestController.cpp:
2602         (WTR::TestController::createWebViewWithOptions): Call
2603         WKContextConfigurationSetOverrideLanguages().
2604         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2605         * WebKitTestRunner/TestOptions.h:
2606         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2607         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2608         option to restart the web process.
2609         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2610         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2611
2612 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2613
2614         [WKTR] Allow changing the WKContextConfiguration between successive tests
2615         https://bugs.webkit.org/show_bug.cgi?id=148833
2616
2617         Reviewed by Tim Horton.
2618
2619         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2620         However, there are certain tests which require specifying options in this object. This patch makes
2621         our existing code for recreating the test runner web view also recreate the WKContext.
2622
2623         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2624         class.
2625
2626         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2627         * WebKitTestRunner/PlatformWebView.h:
2628         (WTR::PlatformWebView::options):
2629         * WebKitTestRunner/TestController.cpp:
2630         (WTR::TestController::initialize):
2631         (WTR::TestController::generateContextConfiguration):
2632         (WTR::TestController::generatePageConfiguration):
2633         (WTR::TestController::createWebViewWithOptions):
2634         (WTR::TestController::ensureViewSupportsOptionsForTest):
2635         (WTR::updateContextConfigurationOptionsFromTestHeader):
2636         (WTR::TestController::contextConfigurationOptionsForTest):
2637         (WTR::TestController::platformCreateWebView):
2638         (WTR::TestController::platformCreateOtherPage):
2639         (WTR::updateViewOptionsFromTestHeader): Deleted.
2640         (WTR::TestController::viewOptionsForTest): Deleted.
2641         * WebKitTestRunner/TestController.h:
2642         (WTR::TestController::injectedBundlePath):
2643         (WTR::TestController::testPluginDirectory):
2644         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2645         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2646         (WTR::TestController::platformCreateWebView):
2647         (WTR::TestController::platformCreateOtherPage):
2648         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2649         (WTR::PlatformWebView::PlatformWebView):
2650         (WTR::PlatformWebView::viewSupportsOptions):
2651         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2652         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2653         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2654         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2655         (WTR::PlatformWebView::PlatformWebView):
2656         (WTR::PlatformWebView::viewSupportsOptions):
2657         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2658         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2659         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2660         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2661         (WTR::PlatformWebView::PlatformWebView):
2662         (WTR::PlatformWebView::viewSupportsOptions):
2663         * WebKitTestRunner/ios/TestControllerIOS.mm:
2664         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2665         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2666         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2667         (WTR::PlatformWebView::PlatformWebView):
2668         (WTR::PlatformWebView::viewSupportsOptions):
2669         * WebKitTestRunner/mac/TestControllerMac.mm:
2670         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2671         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2672
2673 2015-09-11  Michael Saboff  <msaboff@apple.com>
2674
2675         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2676         https://bugs.webkit.org/show_bug.cgi?id=149083
2677
2678         Reviewed by Alexey Proskuryakov.
2679
2680         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2681
2682         * DumpRenderTree/mac/LayoutTestHelper.m:
2683         (colorProfileURLForDisplay):
2684
2685 2015-09-11  Saam barati  <sbarati@apple.com>
2686
2687         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2688         https://bugs.webkit.org/show_bug.cgi?id=149058
2689
2690         Reviewed by Geoffrey Garen.
2691
2692         * Scripts/run-jsc-stress-tests:
2693
2694 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2695
2696         Unreviewed, rolling out r189595.
2697         https://bugs.webkit.org/show_bug.cgi?id=149052
2698
2699         The tests still fail (Requested by ap on #webkit).
2700
2701         Reverted changeset:
2702
2703         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2704         error -1"
2705         https://bugs.webkit.org/show_bug.cgi?id=142929
2706         http://trac.webkit.org/changeset/189595
2707
2708 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2709
2710         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2711         https://bugs.webkit.org/show_bug.cgi?id=142929
2712
2713         Reviewed by Brent Fulgham.
2714
2715         Silence the logging. We'll track fixing the root cause in Radar.
2716
2717         * Scripts/webkitpy/port/mac.py:
2718         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2719
2720         * Scripts/webkitpy/port/win.py:
2721         (WinPort.logging_patterns_to_strip): Added.
2722
2723 2015-09-09  Andy Estes  <aestes@apple.com>
2724
2725         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2726         https://bugs.webkit.org/show_bug.cgi?id=149022
2727
2728         Reviewed by Daniel Bates.
2729
2730         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2731         did not account for this.
2732
2733         * Scripts/webkitpy/xcode/simulator.py:
2734         (Simulator): Optionally matched a revision at the end of a runtime version number.
2735         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2736
2737 2015-09-09  Andy Estes  <aestes@apple.com>
2738
2739         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2740         https://bugs.webkit.org/show_bug.cgi?id=149029
2741         <rdar://problem/22432624>
2742
2743         Reviewed by Daniel Bates.
2744
2745         * Scripts/webkitpy/xcode/simulator.py:
2746         (Simulator): Taught to parse tvOS runtimes.
2747         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2748
2749 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2750
2751         Fix bit rot on bot watcher's dashboard page
2752         https://bugs.webkit.org/show_bug.cgi?id=149012
2753
2754         Reviewed by Tim Horton.
2755
2756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2757         The code path used by the metrics page was trying to add properties to an undefined.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2760         Silence an expection that would occur when the step has no logs. This should never
2761         happen, but it did (perhaps buildbot was misconfigured for a while).
2762
2763 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2764
2765         Update LayoutTestRelay xcconfig file.
2766
2767         Rubber-stamped by Dan Bernstein.
2768
2769         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2770
2771 2015-09-09  Saam barati  <sbarati@apple.com>
2772
2773         DFG should have a debugging option that runs a phase that flushes all locals
2774         https://bugs.webkit.org/show_bug.cgi?id=148916
2775
2776         Reviewed by Filip Pizlo.
2777
2778         * Scripts/run-jsc-stress-tests:
2779
2780 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2781
2782         Unreviewed, rolling out r189530 and r189534.
2783         https://bugs.webkit.org/show_bug.cgi?id=148996
2784
2785         Caused assertion failures on Yosemite (Requested by litherum
2786         on #webkit).
2787
2788         Reverted changesets:
2789
2790         "[WKTR] Allow changing the WKContextConfiguration between
2791         successive tests"
2792         https://bugs.webkit.org/show_bug.cgi?id=148833
2793         http://trac.webkit.org/changeset/189530
2794
2795         "[Cocoa] Fix the tests after r189530"
2796         http://trac.webkit.org/changeset/189534
2797
2798 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2799
2800         [Cocoa] Fix the tests after r189530
2801
2802         Unreviewed.
2803
2804         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2805         (WTR::initializeWebViewConfiguration):
2806
2807 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2808
2809         [WKTR] Allow changing the WKContextConfiguration between successive tests
2810         https://bugs.webkit.org/show_bug.cgi?id=148833
2811
2812         Reviewed by Tim Horton.
2813
2814         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2815         However, there are certain tests which require specifying options in this object. This patch makes
2816         our existing code for recreating the test runner web view also recreate the WKContext.
2817
2818         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2819         class.
2820
2821         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2822         * WebKitTestRunner/PlatformWebView.h:
2823         (WTR::PlatformWebView::options):
2824         * WebKitTestRunner/TestController.cpp:
2825         (WTR::TestController::initialize):
2826         (WTR::TestController::generateContextConfiguration):
2827         (WTR::TestController::generatePageConfiguration):
2828         (WTR::TestController::createWebViewWithOptions):
2829         (WTR::TestController::ensureViewSupportsOptionsForTest):
2830         (WTR::updateContextConfigurationOptionsFromTestHeader):
2831         (WTR::TestController::contextConfigurationOptionsForTest):
2832         (WTR::TestController::platformCreateWebView):
2833         (WTR::TestController::platformCreateOtherPage):
2834         (WTR::updateViewOptionsFromTestHeader): Deleted.
2835         (WTR::TestController::viewOptionsForTest): Deleted.
2836         * WebKitTestRunner/TestController.h:
2837         (WTR::TestController::injectedBundlePath):
2838         (WTR::TestController::testPluginDirectory):
2839         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2840         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2841         (WTR::TestController::platformCreateWebView):
2842         (WTR::TestController::platformCreateOtherPage):
2843         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2844         (WTR::PlatformWebView::PlatformWebView):
2845         (WTR::PlatformWebView::viewSupportsOptions):
2846         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2847         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2848         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2849         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2850         (WTR::PlatformWebView::PlatformWebView):
2851         (WTR::PlatformWebView::viewSupportsOptions):
2852         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2853         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2854         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2855         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2856         (WTR::PlatformWebView::PlatformWebView):
2857         (WTR::PlatformWebView::viewSupportsOptions):
2858         * WebKitTestRunner/ios/TestControllerIOS.mm:
2859         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2860         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2861         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2862         (WTR::PlatformWebView::PlatformWebView):
2863         (WTR::PlatformWebView::viewSupportsOptions):
2864         * WebKitTestRunner/mac/TestControllerMac.mm:
2865         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2866         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2867
2868 2015-09-08  Daniel Bates  <dabates@apple.com>
2869
2870         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2871         https://bugs.webkit.org/show_bug.cgi?id=148980
2872
2873         Reviewed by Alexey Proskuryakov.
2874
2875         Add setting to enable/disable accelerated drawing so as to support testing
2876         this feature in MiniBrowser on Mac.
2877
2878         * MiniBrowser/mac/SettingsController.h:
2879         * MiniBrowser/mac/SettingsController.m:
2880         (-[SettingsController _populateMenu]): Add menu item.
2881         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2882         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2883         (-[SettingsController acceleratedDrawingEnabled]): Added.
2884         * MiniBrowser/mac/WK1BrowserWindowController.m:
2885         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2886         * MiniBrowser/mac/WK2BrowserWindowController.m:
2887         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2888
2889 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2890
2891         Unreviewed. Added myself as a commiter in contributors.json.
2892
2893         * Scripts/webkitpy/common/config/contributors.json:
2894
2895 2015-09-08  Keith Miller  <keith_miller@apple.com>
2896
2897         Unreviewed, added myself to the list of contributors.
2898
2899         * Scripts/webkitpy/common/config/contributors.json:
2900
2901 2015-09-08  Daniel Bates  <dabates@apple.com>
2902
2903         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2904         https://bugs.webkit.org/show_bug.cgi?id=148921
2905
2906         Reviewed by Alexey Proskuryakov.
2907
2908         The ring image is positioned above the platform icon in markup and we specify the CSS
2909         property z-index for the ring image so that it is painted on top of the platform icon
2910         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2911         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2912         property z-index to achieve a similar effect.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2915         (documentReady): Create the platform icon image element before the ring image such that
2916         the ring image is painted on top of the platform icon.
2917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2918         (table.queue-grid td.logo img.ring): Removed property z-index.
2919
2920 2015-09-08  Daniel Bates  <dabates@apple.com>
2921
2922         Dashboard: Remove duplicate gear icon data URLs
2923         https://bugs.webkit.org/show_bug.cgi?id=148920
2924
2925         Reviewed by Alexey Proskuryakov.
2926
2927         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2928         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2929         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2930         as a mask and make use of the CSS background-color to define the fill color for each of these three
2931         states.
2932
2933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2934         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
2935         (.settings:hover): Override CSS background-color for hover state.
2936         (.settings-visible .settings): Override CSS background-color for expanded state.
2937
2938 2015-09-07  Andy Estes  <aestes@apple.com>
2939
2940         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2941         https://bugs.webkit.org/show_bug.cgi?id=148946
2942         <rdar://problem/22603981>
2943
2944         Reviewed by Dan Bernstein.
2945
2946         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2947         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2948
2949 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2950
2951         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2952         https://bugs.webkit.org/show_bug.cgi?id=148927
2953
2954         Reviewed by Csaba Osztrogonác.
2955
2956         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2957         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2958
2959         * WebKitTestRunner/TestController.cpp:
2960         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2961         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2962         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2963
2964 2015-09-07  Andy Estes  <aestes@apple.com>
2965
2966         Fix the Production build after r189455.
2967
2968         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2969         In-App Purchase template instead of the Aggregate template. Whoops.
2970
2971 2015-09-06  Andy Estes  <aestes@apple.com>
2972
2973         WebKit.xcworkspace should be be able to build iOS platforms
2974         https://bugs.webkit.org/show_bug.cgi?id=148881
2975
2976         Reviewed by Daniel Bates.
2977
2978         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2979         for all supported platforms.
2980
2981         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2982         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2983         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2984         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2985
2986 2015-09-06  Andy Estes  <aestes@apple.com>
2987
2988         WebKitTestRunner should build for iOS using the default target
2989         https://bugs.webkit.org/show_bug.cgi?id=148918
2990
2991         Reviewed by Daniel Bates.
2992
2993         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2994         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2995         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2996
2997         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2998         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2999         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
3000         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
3001         WebKitTestRunner is skipped when installing on iOS.
3002
3003         The target dependency graph now looks like this:
3004
3005             All
3006                 WebKitTestRunnerApp
3007                     WebKitTestRunner (Library)
3008                         WebKitTestRunnerInjectedBundle
3009                             Derived Sources
3010                 WebKitTestRunner
3011                     WebKitTestRunner (Library)
3012                         WebKitTestRunnerInjectedBundle
3013                             Derived Sources
3014
3015         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
3016         * Scripts/build-webkittestrunner: Ditto.
3017         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
3018         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
3019         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
3020         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
3021         excluded iOS-only files, and skipped installing on iOS.
3022         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
3023         excluded Mac-only files, and skipped installing on Mac.
3024         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
3025         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
3026         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
3027         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
3028         new configuration files.
3029
3030 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
3031
3032         Web Inspector: Improve prepare-ChangeLog for multiple cases
3033         https://bugs.webkit.org/show_bug.cgi?id=148875
3034
3035         Reviewed by Timothy Hatcher.
3036
3037         * Scripts/prepare-ChangeLog:
3038         (get_function_line_ranges_for_javascript):
3039         - We were ignoring everything inside of an anonymous function expression,
3040           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
3041           Better handle this by inserting a few tweaks.
3042         - Allow method syntax outside of classes as long as they are at the global level.
3043         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
3044
3045         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3046         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3047         (Foo.prototype.method1):
3048         (Foo.prototype.method2):
3049         (Foo.prototype.method3.innerFunction):
3050         (Foo.prototype.method3):
3051         (insideGlobalAnonymousFunctionExpression):
3052         (foo.insideGlobalFunctionExpression):
3053         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
3054         (IssueWithMapGetAndSet.prototype.method1):
3055         (IssueWithMapGetAndSet.prototype.method2):
3056         (IssueWithMapGetAndSet.prototype.method3):
3057         (IssueWithMapGetAndSet):
3058
3059 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3060
3061         [ES6] Enable ES6 Module in JSC shell by default
3062         https://bugs.webkit.org/show_bug.cgi?id=148689
3063
3064         Reviewed by Geoffrey Garen.
3065
3066         * Scripts/run-javascriptcore-tests:
3067         (runJSCStressTests):
3068         * Scripts/run-jsc-stress-tests:
3069
3070 2015-09-04  Basile Clement  <basile_clement@apple.com>
3071
3072         Unreviewed, change my email address.
3073
3074         * Scripts/webkitpy/common/config/contributors.json:
3075
3076 2015-09-04  Beth Dakin  <bdakin@apple.com>
3077
3078         Should have a test to make sure links don't navigate after a cancelled force 
3079         click
3080         https://bugs.webkit.org/show_bug.cgi?id=148846
3081
3082         Reviewed by Tim Horton.
3083
3084         New EventSender function for a started then cancelled force click.
3085         * WebKitTestRunner/EventSenderProxy.h:
3086         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3087         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3088         (WTR::EventSendingController::mouseForceClick):
3089         (WTR::EventSendingController::startAndCancelMouseForceClick):
3090         (WTR::EventSendingController::mouseForceDown):
3091         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3092         * WebKitTestRunner/TestController.cpp:
3093         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3094         * WebKitTestRunner/mac/EventSenderProxy.mm:
3095         (WTR::EventSenderProxy::mouseForceClick):
3096         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3097         (WTR::EventSenderProxy::mouseForceDown):
3098         (WTR::EventSenderProxy::mouseMoveTo):
3099
3100 2015-09-04  Tim Horton  <timothy_horton@apple.com>
3101
3102         Add a test for r179736 (programmatic navigation during swipe causing a crash)
3103         https://bugs.webkit.org/show_bug.cgi?id=148830
3104
3105         Reviewed by Beth Dakin.
3106
3107         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3108         (WTR::InjectedBundle::beginTesting):
3109         Make sure that TestRunner callbacks don't leak between tests!
3110
3111 2015-09-04  Anders Carlsson  <andersca@apple.com>
3112
3113         It should be possible to pass relative HTTP test paths to DumpRenderTree
3114         https://bugs.webkit.org/show_bug.cgi?id=148825
3115         <rdar://problem/22583866>
3116
3117         Reviewed by Tim Horton.
3118
3119         Convert the path to an absolute path if needed.
3120
3121         * DumpRenderTree/mac/DumpRenderTree.mm:
3122         (computeTestURL):
3123
3124 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3125
3126         Fix Swift unit tests for prepare-ChangeLog.
3127         https://bugs.webkit.org/show_bug.cgi?id=148817
3128
3129         Reviewed by Alexey Proskuryakov.
3130
3131         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
3132         Swift unit tests for prepare-ChangeLog.
3133
3134 2015-09-04  Lucas Forschler  <lforschler@apple.com>
3135
3136         Modifications to the webkit-nightly logic.
3137         
3138         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3139         (updateAlertPanel):
3140         * WebKitLauncher/main.m:
3141         (displayErrorAndQuit):
3142
3143 2015-09-04  Beth Dakin  <bdakin@apple.com>
3144
3145         Speculative build fix.
3146
3147         * WebKitTestRunner/mac/EventSenderProxy.mm:
3148
3149 2015-09-04  Brian Burg  <bburg@apple.com>
3150
3151         Web Inspector: InspectorController should support multiple frontend channels
3152         https://bugs.webkit.org/show_bug.cgi?id=148538
3153
3154         Reviewed by Joseph Pecoraro.
3155
3156         InspectorClients must explicitly disconnect their frontend channel(s) from the
3157         inspected page's InspectorController.
3158
3159         To make this possible, DumpRenderTree should not destroy non-primary views until
3160         it has tried to close any abandoned Web Inspector instances. Performing teardown
3161         in the reverse order prevents disconnection of the frontend channel because that
3162         prematurely destroys the inspector frontend client.
3163
3164         * DumpRenderTree/mac/DumpRenderTree.mm:
3165         (runTest):
3166         * DumpRenderTree/win/DumpRenderTree.cpp:
3167         (runTest):
3168
3169 2015-09-04  Beth Dakin  <bdakin@apple.com>
3170
3171         Need to be able to test default behaviors on force click
3172         https://bugs.webkit.org/show_bug.cgi?id=148758
3173
3174         Reviewed by Tim Horton.
3175
3176         This patch adds a new eventSender method to do a full, completed force click, 
3177         and it re-works all of the existing force methods to dispatch their events in 
3178         such a way that they will trigger the NSImmediateAction gesture recognizer. 
3179         To do this, first we need to send the events to the app rather than straight 
3180         to the view, and also needed to tweak some state and send the events in a 
3181         delayed fashion.
3182
3183         New public function mouseForceClick() and private helper functions to make 
3184         NSEvents.
3185         * WebKitTestRunner/EventSenderProxy.h:
3186
3187         New public function mouseForceClick().
3188         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3189         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3190         (WTR::EventSendingController::mouseMoveTo):
3191         (WTR::EventSendingController::mouseForceClick):
3192         (WTR::EventSendingController::mouseForceDown):
3193         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3196
3197         initPressureEventAtLocation needs to take a stageTransition and a window.
3198         * WebKitTestRunner/mac/EventSenderProxy.mm:
3199         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3200         (-[EventSenderSyntheticEvent stageTransition]):
3201         (-[EventSenderSyntheticEvent timestamp]):
3202         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3203         (-[EventSenderSyntheticEvent window]):
3204
3205         In order to enter the gesture recognizer, we need to start with a mouse down 
3206         that has a NSEventMaskPressure modifier.
3207         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3208
3209         This ensures that the events queue properly for the force monitor in AppKit.
3210         (WTR::spinRunLoopForForce):
3211
3212          We need to start the pressure change events with a began.
3213         (WTR::EventSenderProxy::beginPressureEvent):
3214
3215         These functions can be used to create the NSEvent for a pressure change every 
3216         time we need one.
3217         (WTR::EventSenderProxy::pressureChangeEvent):
3218
3219         Send the right series of events to emulate a full, completed force click.
3220         (WTR::EventSenderProxy::mouseForceClick):
3221
3222         Use all of the new things for these existing functions.
3223         (WTR::EventSenderProxy::mouseForceDown):
3224         (WTR::EventSenderProxy::mouseForceUp):
3225         (WTR::EventSenderProxy::mouseForceChanged):
3226
3227         Set NSFakeForceTouchDevice to YES.
3228         * WebKitTestRunner/mac/main.mm:
3229         (setDefaultsToConsistentValuesForTesting):
3230
3231 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3232
3233         prepare-ChangeLog needs to know how to parse Swift files.
3234         https://bugs.webkit.org/show_bug.cgi?id=148784
3235         <rdar://problem/22510062>
3236
3237         Reviewed by Darin Adler.
3238
3239         * Scripts/prepare-ChangeLog:
3240         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
3241         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
3242         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
3243         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3244         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
3245         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
3246         (freeFunction): Ditto.
3247         (MyClass.function): Ditto.
3248         (MyClass.functionWithArgument(_:)): Ditto.
3249         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
3250         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
3251         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
3252         (MyClass.classFunction): Ditto.
3253         (MyClass.readWriteComputedVariable): Ditto.
3254         (MyClass.readOnlyComputedVariable): Ditto.
3255
3256 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
3257
3258         Import css/css-color-3
3259         https://bugs.webkit.org/show_bug.cgi?id=148803
3260
3261         Reviewed by Chris Dumez.
3262
3263         Fixed a bug that the imported reference files used the same extention as tests.
3264         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
3265
3266         * Scripts/webkitpy/w3c/test_importer.py:
3267         (TestImporter.find_importable_tests):
3268
3269 2015-09-03  Commit Queue  <commit-queue@webkit.org>
3270
3271         Unreviewed, rolling out r189338.
3272         https://bugs.webkit.org/show_bug.cgi?id=148785
3273
3274         Caused tons of crashes (Requested by cdumez on #webkit).
3275
3276         Reverted changeset:
3277
3278         "Web Inspector: InspectorController should support multiple
3279         frontend channels"
3280         https://bugs.webkit.org/show_bug.cgi?id=148538
3281         http://trac.webkit.org/changeset/189338
3282
3283 2015-09-03  Brian Burg  <bburg@apple.com>
3284
3285         Web Inspector: InspectorController should support multiple frontend channels
3286         https://bugs.webkit.org/show_bug.cgi?id=148538
3287
3288         Reviewed by Joseph Pecoraro.
3289
3290         InspectorClients must explicitly disconnect their frontend channel(s) from the
3291         inspected page's InspectorController.
3292
3293         To make this possible, DumpRenderTree should not destroy non-primary views until
3294         it has tried to close any abandoned Web Inspector instances. Performing teardown
3295         in the reverse order prevents disconnection of the frontend channel because that
3296         prematurely destroys the inspector frontend client.
3297
3298         * DumpRenderTree/mac/DumpRenderTree.mm:
3299         (runTest):
3300         * DumpRenderTree/win/DumpRenderTree.cpp:
3301         (runTest):
3302
3303 2015-09-03  Timothy Hatcher  <timothy@apple.com>
3304
3305         Update WebKit nightly icon to be more like Safari
3306         https://bugs.webkit.org/show_bug.cgi?id=148768
3307
3308         Reviewed by Joseph Pecoraro.
3309
3310         * WebKitLauncher/webkit.icns:
3311
3312 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
3313
3314         JavaScriptCore should have some ES6 conformance tests
3315         https://bugs.webkit.org/show_bug.cgi?id=148771
3316
3317         Reviewed by Chris Dumez.
3318
3319         * Scripts/run-javascriptcore-tests:
3320         (runJSCStressTests): Added es6 as a test suite.
3321
3322         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
3323
3324         Some of these tests currently fail, so I also added a way to expect
3325         failure for now. We'll migrate failing tests to expected passes as we
3326         fix them.
3327
3328 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3329
3330         Add a test for swipe-start hysteresis
3331         https://bugs.webkit.org/show_bug.cgi?id=148756
3332
3333         Reviewed by Anders Carlsson.
3334
3335         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3337         (WTR::cacheTestRunnerCallback):
3338         (WTR::TestRunner::clearTestRunnerCallbacks):
3339         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3340         Make sure that we log if a client tries to install a callback twice
3341         (since we use .add, the second call would not work).
3342
3343         Also, add clearTestRunnerCallbacks so tests can swap out installed
3344         callbacks.
3345
3346 2015-09-03  Anders Carlsson  <andersca@apple.com>
3347
3348         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
3349         https://bugs.webkit.org/show_bug.cgi?id=148746
3350         rdar://problem/22568073
3351
3352         Reviewed by Tim Horton.
3353
3354         * DumpRenderTree/mac/DumpRenderTree.mm:
3355         (computeTestURL):
3356         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
3357
3358         (runTest):
3359         Call computeTestURL.
3360
3361         (testPathFromURL):
3362         Get rid of this; computeTestURL does this for us now.
3363
3364         * Scripts/webkitpy/port/driver.py:
3365         (Driver._command_from_driver_input):
3366         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
3367
3368 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3369
3370         Swipe tests fail on Mavericks
3371         https://bugs.webkit.org/show_bug.cgi?id=148752
3372
3373         Reviewed by Beth Dakin.
3374
3375         * WebKitTestRunner/mac/EventSenderProxy.mm:
3376
3377 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3378
3379         Fix the 32-bit build
3380
3381         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3382         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3383
3384 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3385
3386         Remove some logging that wasn't meant to be in the tree
3387
3388         * WebKitTestRunner/mac/EventSenderProxy.mm:
3389         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3390
3391 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3392
3393         [Mac] Add support for testing swipes
3394         https://bugs.webkit.org/show_bug.cgi?id=148700
3395
3396         Reviewed by Beth Dakin.
3397
3398         * WebKitTestRunner/EventSenderProxy.h:
3399         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3400         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3401         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3402         (WTR::cgEventPhaseFromString):
3403         (WTR::cgEventMomentumPhaseFromString):
3404         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3405         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
3406         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3408         (WTR::InjectedBundle::didReceiveMessageToPage):
3409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3410         (WTR::TestRunner::installDidBeginSwipeCallback):
3411         (WTR::TestRunner::installWillEndSwipeCallback):
3412         (WTR::TestRunner::installDidEndSwipeCallback):
3413         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
3414         (WTR::TestRunner::callDidBeginSwipeCallback):
3415         (WTR::TestRunner::callWillEndSwipeCallback):
3416         (WTR::TestRunner::callDidEndSwipeCallback):
3417         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
3418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3419         * WebKitTestRunner/TestController.cpp:
3420         (WTR::TestController::createOtherPage):
3421         (WTR::TestController::createWebViewWithOptions):
3422         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3423         (WTR::TestController::didBeginNavigationGesture):
3424         (WTR::TestController::willEndNavigationGesture):
3425         (WTR::TestController::didEndNavigationGesture):
3426         (WTR::TestController::didRemoveNavigationGestureSnapshot):
3427         * WebKitTestRunner/TestController.h:
3428         * WebKitTestRunner/TestInvocation.cpp:
3429         (WTR::TestInvocation::didBeginSwipe):
3430         (WTR::TestInvocation::willEndSwipe):
3431         (WTR::TestInvocation::didEndSwipe):
3432         (WTR::TestInvocation::didRemoveSwipeSnapshot):
3433         * WebKitTestRunner/TestInvocation.h:
3434         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
3435         when the snapshot is removed.
3436
3437         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
3438         mouseScrollBy function.
3439
3440         * WebKitTestRunner/mac/EventSenderProxy.mm:
3441         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3442         (-[EventSenderSyntheticEvent type]):
3443         (-[EventSenderSyntheticEvent subtype]):
3444         (-[EventSenderSyntheticEvent locationInWindow]):
3445         (-[EventSenderSyntheticEvent location]):
3446         (-[EventSenderSyntheticEvent momentumPhase]):
3447         (-[EventSenderSyntheticEvent _isTouchesEnded]):
3448         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3449         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
3450         more adjustable values.
3451
3452         (WTR::EventSenderProxy::mouseForceDown):
3453         (WTR::EventSenderProxy::mouseForceUp):
3454         (WTR::EventSenderProxy::mouseForceChanged):
3455         Adopt EventSenderSyntheticEvent.
3456
3457         (WTR::nsEventPhaseFromCGEventPhase):
3458         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3459         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
3460
3461         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3462         (WTR::PlatformWebView::PlatformWebView):
3463         Enable swipe.
3464
3465 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
3466
3467         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
3468         https://bugs.webkit.org/show_bug.cgi?id=148723
3469
3470         Reviewed by Anders Carlsson.
3471
3472         * WebKitTestRunner/TestController.cpp:
3473         (WTR::testPath):
3474         (WTR::updateViewOptionsFromTestHeader):
3475         (WTR::TestController::viewOptionsForTest):
3476
3477 2015-09-03  Lucas Forschler  <lforschler@apple.com>
3478
3479         Test commit.
3480
3481 2015-09-02  Tim Horton  <timothy_horton@apple.com>
3482
3483         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
3484         https://bugs.webkit.org/show_bug.cgi?id=148693
3485
3486         Reviewed by Anders Carlsson.
3487
3488         * WebKitTestRunner/TestController.cpp:
3489         (WTR::TestController::createOtherPage):
3490         (WTR::TestController::createWebViewWithOptions):
3491
3492 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3493
3494         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
3495         https://bugs.webkit.org/show_bug.cgi?id=148529
3496
3497         Reviewed by Darin Adler.
3498
3499         When there are pending EventSender messages after a test finishes,
3500         they could be processed in the main loop started by the
3501         resetStateToConsistentValues(), but the old EventSender has been
3502         replaced by a new one at that point. The new Eventsender can crash
3503         when processing messages that were sent to the old one. To avoid
3504         this, we return early when receiving an EventSender message and
3505         the TestController state is not RunningTest.
3506
3507         * WebKitTestRunner/TestController.cpp:
3508         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3509         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3510
3511 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3512
3513         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
3514         https://bugs.webkit.org/show_bug.cgi?id=148528
3515
3516         Reviewed by Darin Adler.
3517
3518         Before r188548 resetStateToConsistentValues() was called in
3519         TestController::run(), before tests are run, but now it's called
3520         for every test in TestInvocation::invoke(), after m_status has
3521         changed to RunningTest.
3522
3523         * WebKitTestRunner/TestController.cpp:
3524         (WTR::TestController::resetStateToConsistentValues): Use
3525         TemporaryChange to reset m_state ot its previous value after reset
3526         is done.
3527
3528 2015-08-31  Jason Marcell  <jmarcell@apple.com>
3529
3530         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
3531         that are marked as requiring corresponding tests.
3532         https://bugs.webkit.org/show_bug.cgi?id=148498
3533         <rdar://problem/21555314>
3534
3535         Reviewed by Dan Bernstein and David Kilzer.
3536
3537         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
3538         simulate Git's attribute behevaior.
3539         (main): Added "requiresTests" array to contain files that require tests.
3540         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
3541         section in ChangeLog.
3542         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
3543         however, we check if the file or any containing folder has the given property set to "1" and
3544         return 1 if so; return 0 otherwise.
3545         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
3546         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
3547
3548 2015-08-26  Andy Estes  <aestes@apple.com>
3549
3550         [Content Filtering] Determine navigation and content policy before continuing to filter a load
3551         https://bugs.webkit.org/show_bug.cgi?id=148506
3552
3553         Reviewed by Brady Eidson.
3554
3555         Added download API tests covering every decision and decision point.
3556         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
3557
3558         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
3559         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
3560         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3561         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
3562         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
3563         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
3564         decision and decision point as a bundle parameter.
3565         (+[MockContentFilterEnabler supportsSecureCoding]):
3566         (-[MockContentFilterEnabler copyWithZone:]):
3567         (-[MockContentFilterEnabler initWithCoder:]):