2011-04-15 Shishir Agrawal <shishir@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
2
3         Reviewed by James Robinson.
4
5         Add a flag to guard Page Visibility API changes.
6         https://bugs.webkit.org/show_bug.cgi?id=58464
7
8         * Scripts/build-webkit:
9
10 2011-04-15  Chang Shu  <cshu@webkit.org>
11
12         Reviewed by Alexey Proskuryakov.
13
14         When a message with url embedded is added to console, the "file:" scheme
15         and path should be stripped.
16         https://bugs.webkit.org/show_bug.cgi?id=58665
17
18         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
19         (WTR::lastFileURLPathComponent):
20         (WTR::InjectedBundlePage::willAddMessageToConsole):
21
22 2011-04-15  Jeff Miller  <jeffm@apple.com>
23
24         Reviewed by Sam Weinig.
25
26         Add takeFocus callback to WKPageUIClient
27         https://bugs.webkit.org/show_bug.cgi?id=58686
28
29         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
30
31         * MiniBrowser/mac/BrowserWindowController.m:
32         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
33         * MiniBrowser/win/BrowserView.cpp:
34         (BrowserView::create): Added empty takeFocus entry.
35         * WebKitTestRunner/TestController.cpp:
36         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
37         (WTR::TestController::initialize): Added empty takeFocus entry.
38
39 2011-04-15  Ojan Vafai  <ojan@chromium.org>
40
41         Reviewed by Eric Seidel.
42
43         only show pretty-diff/wdiff if they were generated
44         https://bugs.webkit.org/show_bug.cgi?id=58682
45
46         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
47         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
48         * Scripts/webkitpy/layout_tests/port/base.py:
49
50 2011-04-15  Andreas Kling  <kling@webkit.org>
51
52         Reviewed by Antonio Gomes.
53
54         [Qt] DRT: Default custom policy delegate decision should be Ignore.
55
56         If layoutTestController.setCustomPolicyDelegate() is called with only
57         one argument, the second ("permissive") should default to false.
58
59         * DumpRenderTree/qt/LayoutTestControllerQt.h:
60
61 2011-04-15  Ojan Vafai  <ojan@chromium.org>
62
63         Reviewed by Eric Seidel.
64
65         fix path to layout test in new results file
66         https://bugs.webkit.org/show_bug.cgi?id=58618
67
68         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
69         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
70
71 2011-04-15  Ojan Vafai  <ojan@chromium.org>
72
73         Reviewed by Eric Seidel.
74
75         fix sorting in new results file
76         https://bugs.webkit.org/show_bug.cgi?id=58616
77
78         -Fix the custom sort to return -1, 0, 1 instead of true/false.
79         -Secondary sort by test name when sort values are equal.
80         -Sort by test name by default.
81
82         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
83
84 2011-04-15  Dmitry Lomov  <dslomov@google.com>
85
86         Reviewed by David Levin.
87
88         check-webkit-style shouldn't complain about not including a primary header file 
89         if none exists
90         https://bugs.webkit.org/show_bug.cgi?id=39514
91
92         * Scripts/webkitpy/style/checkers/cpp.py:
93         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
94
95 2011-04-15  Eric Seidel  <eric@webkit.org>
96
97         Reviewed by Mihai Parparita.
98
99         queues.webkit.org should display when a bot last rebooted
100         https://bugs.webkit.org/show_bug.cgi?id=58562
101
102         There is more repeated code here than I would like.  I fear
103         my django-fu isn't quite up to snuff.
104
105         * QueueStatusServer/handlers/queuestatus.py:
106         * QueueStatusServer/templates/queuestatus.html:
107
108 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
109
110         Reviewed by Adam Barth.
111
112         Remove dependency on chromium skia::PlatformCanvas
113         https://bugs.webkit.org/show_bug.cgi?id=57563
114         
115         Fixed compile error on Mac when using Core Graphics.
116
117         * DumpRenderTree/chromium/WebViewHost.cpp:
118         (WebViewHost::paintRect):
119
120 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
121
122         Reviewed by James Robinson.
123
124         Remove dependency on chromium skia::PlatformCanvas
125         https://bugs.webkit.org/show_bug.cgi?id=57563
126
127         * DumpRenderTree/chromium/TestShell.cpp:
128         (makeCanvasOpaque):
129         (TestShell::dumpImage):
130         * DumpRenderTree/chromium/TestShell.h:
131         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
132         (WebThemeControlDRTWin::WebThemeControlDRTWin):
133         (WebThemeControlDRTWin::draw):
134         (WebThemeControlDRTWin::drawTextField):
135         (WebThemeControlDRTWin::drawProgressBar):
136         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
137         * DumpRenderTree/chromium/WebViewHost.cpp:
138         (WebViewHost::canvas):
139         * DumpRenderTree/chromium/WebViewHost.h:
140
141 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
142
143         Reviewed by Laszlo Gombos.
144
145         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
146         https://bugs.webkit.org/show_bug.cgi?id=58007
147
148         Adds flag to start the test browsers maximized.
149         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
150         suit.
151         Also fixes some ToggleFullScreen issues so that prior window state is
152         restored.
153
154         * MiniBrowser/qt/BrowserWindow.cpp:
155         (BrowserWindow::BrowserWindow):
156         (BrowserWindow::toggleFullScreenMode):
157         * MiniBrowser/qt/MiniBrowserApplication.cpp:
158         (MiniBrowserApplication::handleUserOptions):
159         * MiniBrowser/qt/MiniBrowserApplication.h:
160         (WindowOptions::WindowOptions):
161         * QtTestBrowser/launcherwindow.cpp:
162         (LauncherWindow::init):
163         (LauncherWindow::toggleFullScreenMode):
164         * QtTestBrowser/launcherwindow.h:
165         (WindowOptions::WindowOptions):
166         * QtTestBrowser/main.cpp:
167         (LauncherApplication::handleUserOptions):
168
169 2011-04-14  Ojan Vafai  <ojan@chromium.org>
170
171         Reviewed by Eric Seidel.
172
173         add checkbox to only show unexpected results to new results file
174         https://bugs.webkit.org/show_bug.cgi?id=58606
175
176         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
177
178 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
179
180         Reviewed by Martin Robinson.
181
182         [WinCairo] Implement ImageDiff Logic.
183         http://bugs.webkit.org/show_bug.cgi?id=58486
184
185         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
186         (strtof):
187         (readFromData):
188         (createImageFromStdin):
189         (releaseMallocBuffer):
190         (createDifferenceImage):
191         (imageHasAlpha):
192         (writeToData):
193         (main):
194         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
195           ImageDiffCairo.cpp (excluding from Apple builds).
196         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
197           new ImageDiffWinCairoCommon.vsprops file.
198         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
199           new ImageDiffWinCairoCommon.vsprops file.
200         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
201         * Scripts/old-run-webkit-tests: Make sure proper executable
202           is built and executed for WinCairo port.
203
204 2011-04-14  Ojan Vafai  <ojan@chromium.org>
205
206         Reviewed by Eric Seidel.
207
208         only show expected failure type for ports that use an expectations file
209         https://bugs.webkit.org/show_bug.cgi?id=58588
210
211         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
212         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
213
214 2011-04-14  Eric Seidel  <eric@webkit.org>
215
216         Reviewed by Adam Barth.
217
218         commit-queue fails to catch IOError when results.html is missing
219         https://bugs.webkit.org/show_bug.cgi?id=58589
220
221         * Scripts/webkitpy/tool/commands/queues.py:
222         * Scripts/webkitpy/tool/commands/queues_unittest.py:
223
224 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
225
226         [wx] Unreviewed build fix for Mac installation script.
227
228         * wx/packaging/build-mac-installer.py:
229
230 2011-04-14  Ojan Vafai  <ojan@chromium.org>
231
232         Reviewed by Tony Chang.
233
234         sort columns in the new json_results.html file
235         https://bugs.webkit.org/show_bug.cgi?id=58581
236
237         Also fix padding on TDs and the path to layout tests.
238
239         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
240
241 2011-04-14  Eric Seidel  <eric@webkit.org>
242
243         Reviewed by Dimitri Glazkov.
244
245         queues.webkit.org should display when a bot last passed a patch
246         https://bugs.webkit.org/show_bug.cgi?id=58546
247
248         I am suspicious that some of our commit-queue instances are never
249         actually passing anything.
250
251         This will let us know if those bots are never passing patches.
252
253         * QueueStatusServer/handlers/queuestatus.py:
254         * QueueStatusServer/index.yaml:
255         * QueueStatusServer/templates/queuestatus.html:
256
257 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
258
259         Reviewed by Adam Roben.
260
261         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
262         https://bugs.webkit.org/show_bug.cgi?id=58545
263
264         Remove platform-specific overrides; the default behavior should
265         be working everywhere now, I think.
266
267         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
268         * Scripts/webkitpy/layout_tests/port/mac.py:
269
270 2011-04-14  Eric Seidel  <eric@webkit.org>
271
272         Reviewed by Adam Barth.
273
274         commit-queues are hitting an exception trying to land when the tree is red
275         https://bugs.webkit.org/show_bug.cgi?id=58558
276
277         Just an un-tested (and thus broken) code path from yesterday's changes.
278
279         * Scripts/webkitpy/common/net/layouttestresults.py:
280         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
281         * Scripts/webkitpy/tool/commands/queues.py:
282         * Scripts/webkitpy/tool/commands/queues_unittest.py:
283
284 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
285
286         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
287
288         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
289         (LayoutTestController::shadowRoot):
290         * wx/build/wxpresets.py:
291
292 2011-04-14  Victoria Kirst  <vrk@google.com>
293
294         Reviewed by James Robinson.
295
296         [chromium] Failing GPU video tests
297         https://bugs.webkit.org/show_bug.cgi?id=57926
298
299         Added/updated GPU directory names for rebaseline tool.
300
301         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
302
303 2011-04-13  Daniel Bates  <dbates@rim.com>
304
305         Reviewed by Adam Barth.
306
307         Perl unit test removeEOL.pl should print test case name on failure
308         https://bugs.webkit.org/show_bug.cgi?id=58513
309
310         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
311           second argument of Test::Simple::ok().
312
313 2011-04-13  Kent Tamura  <tkent@chromium.org>
314
315         Reviewed by Eric Seidel.
316
317         gdb-safari should pass arguments to safari.
318         https://bugs.webkit.org/show_bug.cgi?id=58439
319
320         We can do:
321           gdb-safari --debug LayoutTests/.../foo.html
322
323         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
324
325 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
326
327         Unreviewed, build fix.
328         https://bugs.webkit.org/show_bug.cgi?id=52763
329
330         r83799 broke test-webkitpy because it assumed we always have
331         access to a real filesystem (we don't during the unit tests).
332         Stubbing out the copy for now but we might need a better
333         solution at some point.
334
335         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
336
337 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
338
339         Reviewed by Tony Chang.
340
341         new-run-webkit-tests --run-singly option is busted
342         https://bugs.webkit.org/show_bug.cgi?id=55909
343
344         Python's broken lexical scoping strikes again :(.
345
346         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
347         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
348
349 2011-04-13  Ojan Vafai  <ojan@chromium.org>
350
351         Reviewed by Eric Seidel.
352
353         generated unexpected_results.html from unexpected_results.json
354         https://bugs.webkit.org/show_bug.cgi?id=52763
355
356         Eventually, we'll merge this with results.html and have a single richer results page.
357         For now, I just want to get something checked in that we can iterate on.
358
359         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
360         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
361
362 2011-04-13  Eric Seidel  <eric@webkit.org>
363
364         Reviewed by Adam Barth.
365
366         Up the failure limit to allow the commit-queue to actually land when the tree is red
367         https://bugs.webkit.org/show_bug.cgi?id=58499
368
369         This change increases the --exit-after-N-failures limit used by the commit-queue
370         from 1 to 10.  This will cause the code added in bug 58494 to actually get
371         exercised and the queues should start being able to land when the trees are red.
372
373         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
374         only unit test to actually detect this change!  Since we don't actually
375         run on leopard anymore, I removed the hack code and repurposed the test.
376
377         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
378         * Scripts/webkitpy/tool/steps/runtests.py:
379         * Scripts/webkitpy/tool/steps/steps_unittest.py:
380
381 2011-04-13  Eric Seidel  <eric@webkit.org>
382
383         Reviewed by Adam Barth.
384
385         commit-queue should be able to land when tree is red
386         https://bugs.webkit.org/show_bug.cgi?id=58494
387
388         There is some yak hair on my hands, I will admit.
389
390         This change is mostly about adding an ExpectedFailures
391         class to track when the bots are red and we should be
392         ignoring failures when landing from the commit-queue.
393
394         However, to make intelligent decisions about patches we
395         need to know whether the run hit the --exit-after-N-failures limit
396         or not.  Right now that information is not saved off in results.html
397         so we have to pull the information from RunTests.
398
399         I've plumbed the --exit-after-N-failures information into
400         LayoutTestResults for now to make the ExpectedFailures code cleaner.
401
402         As a result of adding all these additional calls to delegate.layout_test_results()
403         I broke some of our flaky test detection tests and had to re-write them
404         to not depend on the number of layout_test_results code.
405
406         At the same time I updated the commit-queue to use the newer filesystem
407         API (to allow us to use MockFileSystem) which required further changes
408         to the layout tests.  Changes were required in either case, since
409         we're now calling layout_test_results() in more cases, which previously
410         would try and hit the disk (until I moved it to use tool.filesystem).
411
412         I should note that *all* of this code is disabled for now, since our
413         --exit-after-N-failures limit is currently 1!  (Thus were always in the
414         case where we can't actually tell if the layout test results are legit.)
415         I will up that limit in a second patch (which may require a couple more unit test tweaks).
416
417         * Scripts/webkitpy/common/net/layouttestresults.py:
418         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
419         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
420         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
421         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
422         * Scripts/webkitpy/tool/commands/queues.py:
423         * Scripts/webkitpy/tool/commands/queues_unittest.py:
424         * Scripts/webkitpy/tool/commands/queuestest.py:
425         * Scripts/webkitpy/tool/steps/runtests.py:
426
427 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
428
429         Unreviewed build correction.
430
431         * TestWebKitAPI/PlatformWebView.h: Limit include of
432           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
433
434 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
435
436         Reviewed by Eric Seidel.
437
438         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
439         https://bugs.webkit.org/show_bug.cgi?id=58489
440         
441         r83743 added --additional-platform-directory to old-run-webkit-tests,
442         rename the equivalent flag in new-run-webkit-tests to be consistent.
443
444         * Scripts/webkitpy/layout_tests/port/base.py:
445         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
446         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
447         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
448
449 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
450
451         Reviewed by Eric Seidel.
452
453         Rebaseline queue server
454         https://bugs.webkit.org/show_bug.cgi?id=57891
455
456         Adds a simple rebaseline queue server (meant to run at
457         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
458         builders and their failing tests, and allows those tests to be added to
459         a per-builer rebaseline queue.
460
461         A subsequent change will add a mode to NRWT (and/or a wrapper script)
462         for pulling the tests to be rebaselined from the server and running them
463         with --reset-results (the initial use-case is for the GPU hardware bots,
464         which do not have checked-in baselines, therefore there is no need for a
465         check-in step yet).
466
467         * RebaselineQueueServer/app.yaml: Added.
468         * RebaselineQueueServer/handlers/__init__.py: Added.
469         * RebaselineQueueServer/handlers/builderqueue.py: Added.
470         * RebaselineQueueServer/handlers/pages.py: Added.
471         * RebaselineQueueServer/index.yaml: Added.
472         * RebaselineQueueServer/main.py: Added.
473         * RebaselineQueueServer/model/__init__.py: Added.
474         * RebaselineQueueServer/model/queueentry.py: Added.
475         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
476         * RebaselineQueueServer/static/styles.css: Added.
477         * RebaselineQueueServer/templates/builder-picker.html: Added.
478         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
479         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
480         * RebaselineQueueServer/templates/home.html: Added.
481
482 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
483
484         Reviewed by Mihai Parparita.
485
486         nrwt: enable multiple processes by default on Chromium Win.
487         https://bugs.webkit.org/show_bug.cgi?id=55163
488
489         Re-land r79268; it should be more stable now and will hopefully
490         work.
491
492         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
493         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
494
495 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
496
497         Reviewed by Ojan Vafai.
498
499         new-run-webkit-tests: configure logging in child processes properly
500         https://bugs.webkit.org/show_bug.cgi?id=58296
501
502         Logging propagated properly from manager to worker processes on
503         Unix but not on Windows; this fixes that.
504
505         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
506         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
507
508 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
509
510         Reviewed by Ojan Vafai.
511
512         new-run-webkit-tests: suppress extraneous pretty patch warnings
513         https://bugs.webkit.org/show_bug.cgi?id=58295
514
515         NRWT wasn't being careful about when it logged messages from
516         PrettyPatch not being available; it should only log during
517         check_build(), and be silent otherwise. This was causing us to
518         get multiple errors at runtime, which was confusing.
519
520         * Scripts/webkitpy/layout_tests/port/base.py:
521         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
522         * Scripts/webkitpy/layout_tests/port/chromium.py:
523
524 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
525
526         Reviewed by Jian Li.
527
528         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
529         https://bugs.webkit.org/show_bug.cgi?id=58461
530
531         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
532
533 2011-04-13  Tony Chang  <tony@chromium.org>
534
535         Unreviewed, fix NRWT.  Stack:
536
537             return super(ChromiumPort, self).results_directory(self)
538         TypeError: results_directory() takes exactly 1 argument (2 given)
539
540         * Scripts/webkitpy/layout_tests/port/chromium.py:
541
542 2011-04-13  Adam Roben  <aroben@apple.com>
543
544         Teach ORWT about extra platform-specific directories to be searched before the default ones
545
546         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
547         platform-specific results
548
549         Reviewed by Anders Carlsson.
550
551         * Scripts/old-run-webkit-tests:
552         (top-level): Added @additionalPlatformDirectories and hooked up
553         --additional-platform-directories to populate it.
554         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
555         list (after filtering out any of the additional directories that don't exist).
556
557 2011-04-13  Lucas Forschler  <lforschler@apple.com>
558
559         Reviewed by Adam Roben.
560
561         Add the /T command to taskkill.exe.
562         This will kill spawned child processes.
563         
564         * BuildSlaveSupport/win/kill-old-processes:
565
566 2011-04-13  Lucas Forschler  <lforschler@apple.com>
567
568         Reviewed by Adam Roben.
569
570         Sort kill list alphabeticaly.
571         Fixed capitalization on VcBuildHelper.  
572
573         * BuildSlaveSupport/win/kill-old-processes:
574
575 2011-04-13  Lucas Forschler  <lforschler@apple.com>
576
577         Reviewed by Adam Roben.
578
579         https://bugs.webkit.org/show_bug.cgi?id=58384
580         Update kill-old-processes to include a few new ones.
581         
582         * BuildSlaveSupport/win/kill-old-processes:
583
584 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
585
586         Reviewed by Martin Robinson.
587
588         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
589         https://bugs.webkit.org/show_bug.cgi?id=58297
590
591         Do not disable flash specifically when built with GTK+ 3 -
592         PluginPackage should do the right thing while loading plugins.
593
594         * GtkLauncher/main.c:
595         (main):
596
597 2011-04-12  Kent Tamura  <tkent@chromium.org>
598
599         Reviewed by Dimitri Glazkov.
600
601         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
602         https://bugs.webkit.org/show_bug.cgi?id=57426
603
604         * DumpRenderTree/chromium/WebPreferences.cpp:
605         (WebPreferences::applyTo): Disable the validation message timer.
606
607 2011-04-12  James Kozianski  <koz@chromium.org>
608
609         Unreviewed.
610
611         Adding myself to committers.py.
612
613         * Scripts/webkitpy/common/config/committers.py:
614
615 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
616
617         Unreviewed build correction for WinCairo bot after r83639.
618         https://bugs.webkit.org/show_bug.cgi?id=51790
619
620         Correct typo for the new "update-webkit-wincairo-libs" script.
621
622         * Scripts/build-webkit: Incorrectly calling the
623           update-webkit-cairo-libs which does not exist.
624
625 2011-04-12  Alice Liu  <alice.liu@apple.com>
626
627         Reviewed by Jon Honeycutt.
628
629         A change that should have been part of http://trac.webkit.org/changeset/83628
630
631         * DumpRenderTree/win/DumpRenderTree.cpp:
632         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
633
634 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
635
636         Reviewed by Tony Chang.
637
638         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
639         https://bugs.webkit.org/show_bug.cgi?id=58272
640
641         NRWT was interpreting the --results-directory cmd line arg as
642         relative to the build directory, not the current working
643         directory (ORWT uses the latter, which is much more intuitive).
644         
645         This patch fixes the base case, but includes an override for
646         Chromium that is needed until the bots can be updated.
647
648         * Scripts/webkitpy/layout_tests/port/base.py:
649         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
650         * Scripts/webkitpy/layout_tests/port/chromium.py:
651         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
652         * Scripts/webkitpy/layout_tests/port/test.py:
653         * Scripts/webkitpy/layout_tests/port/webkit.py:
654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
655         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
656
657 2011-04-12  Philippe Normand  <pnormand@igalia.com>
658
659         Unreviewed, roll out r83621 as it broke the GTK build.
660
661         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
662         https://bugs.webkit.org/show_bug.cgi?id=58333
663
664         * Scripts/build-jsc:
665         * Scripts/build-webkit:
666
667 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
668
669         Reviewed by Adam Roben.
670
671         Patch to download the WinCairo dependancies as part of build-webkit.
672         https://bugs.webkit.org/show_bug.cgi?id=51790
673
674         This patch downloads the dependancies from 
675             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
676         checking the modification timestamp etc. 
677
678         * Tools/Scripts/build-webkit
679         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
680           flag, and to update WinCairo dependencies when used.
681         * Tools/Scripts/update-webkit-cairo-libs: added
682         * Tools/Scripts/update-webkit-dependency: added
683         * Tools/Scripts/update-webkit-auxiliary-libs
684
685 2011-04-12  Jeff Miller  <jeffm@apple.com>
686
687         Reviewed by Adam Roben.
688
689         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
690         https://bugs.webkit.org/show_bug.cgi?id=56020
691
692         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
693         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
694         which would generate two characters for every keypress (for example).  I didn't bother doing this for
695         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
696         
697         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
698
699         * MiniBrowser/win/main.cpp:
700         (shouldTranslateMessage): Added.
701         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
702         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
703         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
704         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
705         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
706         (TestWebKitAPI::runAndWatchForWMChar): Added.
707         (TestWebKitAPI::TEST): Added.
708         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
709         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
710         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
711         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
712         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
713         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
714
715 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
716
717         Reviewed by Tony Chang.
718
719         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
720         https://bugs.webkit.org/show_bug.cgi?id=58290
721
722         This is some preliminary refactoring for bug 58272.
723
724         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
725         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
726         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
727         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
728         * Scripts/webkitpy/layout_tests/port/test.py:
729         * Scripts/webkitpy/layout_tests/port/chromium.py:
730         * Scripts/webkitpy/layout_tests/port/base.py:
731         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
732
733 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
734
735         Reviewed by Eric Seidel.
736
737         webkitpy: fix mock_filesystem abspath to handle relative paths
738         and add filesystem.chdir() and filesystem.getcwd() to be able
739         to test this and mock it out.
740
741         https://bugs.webkit.org/show_bug.cgi?id=58288
742
743         * Scripts/webkitpy/common/system/filesystem.py:
744         * Scripts/webkitpy/common/system/filesystem_mock.py:
745         * Scripts/webkitpy/common/system/filesystem_unittest.py:
746
747 2011-04-12  Alice Liu  <alice.liu@apple.com>
748
749         Reviewed by Sam Weinig.
750
751         https://bugs.webkit.org/show_bug.cgi?id=58292
752         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
753
754         * DumpRenderTree/mac/DumpRenderTree.mm:
755         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
756
757 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
758
759         Reviewed by Eric Seidel.
760
761         [Qt] Enable JIT build for SH4 platforms.
762         https://bugs.webkit.org/show_bug.cgi?id=58317
763
764
765         * DumpRenderTree/qt/DumpRenderTree.pro:
766         * QtTestBrowser/QtTestBrowser.pro:
767         * Scripts/webkitdirs.pm:
768
769 2011-04-12  Tony Chang  <tony@chromium.org>
770
771         Reviewed by Andreas Kling.
772
773         [Qt] embed checksums in PNGs written by Qt-DRT
774         https://bugs.webkit.org/show_bug.cgi?id=58173
775
776         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
777         (WebCore::DumpRenderTree::dump):
778
779 2011-04-12  Eric Seidel  <eric@webkit.org>
780
781         Reviewed by Adam Barth.
782
783         commit-queue should upload failure diffs when tests fail
784         https://bugs.webkit.org/show_bug.cgi?id=58348
785
786         This change was mostly just plumbing.  We were already saving
787         this information for flaky test reporting.  I just made it possible
788         for normal failures to report archives as well.
789
790         I did a little abstraction work to try and share some code between
791         flakytestreporter.py and this new code.  There is still more we could do.
792
793         In making this change I also went through and updated the various
794         places we have urls hard-coded in our python and pointed them at
795         common.config.urls.
796
797         * Scripts/webkitpy/common/checkout/scm.py:
798         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
799         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
800         * Scripts/webkitpy/common/net/statusserver.py:
801         * Scripts/webkitpy/layout_tests/port/base.py:
802         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
803         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
804         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
805         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
806         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
807         * Scripts/webkitpy/tool/commands/queues.py:
808
809 2011-04-12  Daniel Bates  <dbates@rim.com>
810
811         Rubber-stamped by Eric Seidel.
812
813         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
814         with Windows line endings
815         https://bugs.webkit.org/show_bug.cgi?id=53625
816
817         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
818         applied to an SCM checkout on a Windows file system and vice-versa.
819
820         This issue manifests itself due to custom SCM settings as well as differences in
821         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
822         into svn-apply/unapply to compensate for differences in line endings by converting
823         the line endings in a patch to match the line endings in the target file (if it exists).
824
825         * Scripts/VCSUtils.pm:
826           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
827             content read from the specified file handle. Obviously, this heuristic will not work
828             for files with mixed line endings, but I don't envision such files to be the norm. If
829             this turns out to be an issue then we can improve the heuristic.
830           - Added firstEOLInFile().
831           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
832             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
833             endings in the diff instead of the line endings in the target file.
834           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
835             re-used in parseDiff().
836         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
837           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
838           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
839         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
840         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
841
842 2011-04-12  Sam Weinig  <sam@webkit.org>
843
844         Reviewed by Adam Roben.
845
846         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
847         https://bugs.webkit.org/show_bug.cgi?id=58336
848
849         * WebKitTestRunner/TestController.cpp:
850         (WTR::TestController::resetStateToConsistentValues):
851         Remove cache clearing as that is causing tests to crash on Windows 7.
852
853 2011-04-11  Sam Weinig  <sam@webkit.org>
854
855         Reviewed by Anders Carlsson.
856
857         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
858         <rdar://problem/8981346>
859         https://bugs.webkit.org/show_bug.cgi?id=54159
860
861         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
862         (WTR::InjectedBundlePage::InjectedBundlePage):
863         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
864         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
865         (WTR::InjectedBundlePage::decidePolicyForResponse):
866         (WTR::InjectedBundlePage::unableToImplementPolicy):
867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
868         Add short-circuited policy client which matches WebKit1.
869
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::resetStateToConsistentValues):
872         Clear the cache between tests to ensure consistent results.
873
874 2011-04-11  George Guo  <George.Guo@nokia.com>
875
876         Reviewed by Eric Seidel.
877
878         prepare-ChangeLog support email input but -h did not show the option
879         https://bugs.webkit.org/show_bug.cgi?id=58164
880
881         Add email option to -h to improve the usability
882
883         * Scripts/prepare-ChangeLog:
884
885 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
886
887         Reviewed by Eric Carlson.
888
889         Rename MediaControls to MediaControlRootElement.
890         https://bugs.webkit.org/show_bug.cgi?id=58250
891
892         * Scripts/do-webcore-rename: Documented the renaming.
893
894 2011-04-11  Sam Weinig  <sam@webkit.org>
895
896         Fix Windows build.
897
898         * MiniBrowser/win/BrowserView.cpp:
899         (BrowserView::create):
900
901 2011-04-11  Sam Weinig  <sam@webkit.org>
902
903         Reviewed by Anders Carlsson.
904
905         Move focus management out of WebKit via  the UIClient
906         <rdar://problem/8784068>
907         https://bugs.webkit.org/show_bug.cgi?id=58278
908
909         * MiniBrowser/mac/BrowserWindowController.m:
910         (-[BrowserWindowController awakeFromNib]):
911         * WebKitTestRunner/TestController.cpp:
912         (WTR::TestController::createOtherPage):
913         (WTR::TestController::initialize):
914         Add stubs for new UIClient functions.
915
916 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
917
918         Reviewed by Eric Seidel.
919
920         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
921         https://bugs.webkit.org/show_bug.cgi?id=53605
922
923         Add an implementation of the PlainTextController for the GTK+ DRT.
924
925         * DumpRenderTree/gtk/DumpRenderTree.cpp:
926         (addControllerToWindow): Added this helper method.
927         (webViewWindowObjectCleared): Use the new helper to add EventSender
928         and the PlainTextController to the window object.
929         * GNUmakefile.am: Added PlainTextController source files.
930         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
931         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
932         until that functionality exists somewhere in the WebKitGTK+ stack.
933         * DumpRenderTree/gtk/PlainTextController.h: Added.
934
935 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
936
937         Unreviewed.
938
939         Adding my IRC nick.
940
941         * Scripts/webkitpy/common/config/committers.py:
942
943 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
944
945         Reviewed by Adam Roben.
946
947         new-run-webkit-tests: fix crash when running under windows cmd.exe
948         https://bugs.webkit.org/show_bug.cgi?id=58197
949
950         We would intermittently crash when running NRWT directly under
951         cmd.exe on windows because we were sharing the stdin file
952         descriptor between the python process and the http server.
953         cmd.exe really didn't like that, and there was no reason to
954         share the descriptor, so we now use a PIPE instead.
955
956         * Scripts/webkitpy/layout_tests/port/http_server.py:
957
958 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
959
960         Reviewed by Ojan Vafai.
961
962         new-run-webkit-tests: add unit tests for Port.diff_image()
963         https://bugs.webkit.org/show_bug.cgi?id=58196
964
965         Add the unit tests for the fix in bug 58195.
966
967         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
968         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
969         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
970
971 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
972
973         Reviewed by Tony Chang.
974
975         new-run-webkit-tests: implement support for audio, take two
976         https://bugs.webkit.org/show_bug.cgi?id=58195
977
978         Attempt to re-land the fix for bug 58101 (which was initially
979         landed in r83330, but rolled out). This is the same patch but
980         fixes crashes in Port.diff_image() caused by the change for
981         empty image files being None instead of ''.
982
983         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
984         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
985         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
986         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
987         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
988         * Scripts/webkitpy/layout_tests/port/base.py:
989         * Scripts/webkitpy/layout_tests/port/chromium.py:
990         * Scripts/webkitpy/layout_tests/port/dryrun.py:
991         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
992         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
993         * Scripts/webkitpy/layout_tests/port/test.py:
994         * Scripts/webkitpy/layout_tests/port/webkit.py:
995
996 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
997
998         Reviewed by Xan Lopez.
999
1000         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
1001         https://bugs.webkit.org/show_bug.cgi?id=57854
1002
1003         Implement missing features in GTK's DRT.
1004
1005         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1006         (indexRangeInTable): New helper function to get the range string
1007         for the current cell inside the parent table, either from the
1008         point of view of rows or columns.
1009         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
1010         the new helper function indexRangeInTable().
1011         (AccessibilityUIElement::columnIndexRange): Ditto.
1012
1013 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1014
1015         Reviewed by Chris Fleizach.
1016
1017         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
1018         https://bugs.webkit.org/show_bug.cgi?id=57826
1019
1020         Implement missing feature in GTK's DRT.
1021
1022         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1023         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
1024         relying on the analogous function from the AtkTable interface.
1025
1026 2011-04-05  Timothy Hatcher  <timothy@apple.com>
1027
1028         Fix the extract-localizable-strings script errors that started after
1029         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
1030
1031         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
1032
1033 2011-04-11  Tony Chang  <tony@chromium.org>
1034
1035         Reviewed by Eric Seidel.
1036
1037         fix crc computation on 64 bit machines
1038         https://bugs.webkit.org/show_bug.cgi?id=58243
1039
1040         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
1041
1042         * DumpRenderTree/CyclicRedundancyCheck.cpp:
1043         (makeCrcTable):
1044         (computeCrc):
1045         * DumpRenderTree/CyclicRedundancyCheck.h:
1046         * DumpRenderTree/PixelDumpSupport.cpp:
1047         (appendIntToVector):
1048         (convertChecksumToPNGComment):
1049
1050 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
1051
1052         Reviewed by Eric Seidel.
1053
1054         Require no undefined symbols during compilation.
1055
1056         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
1057         https://bugs.webkit.org/show_bug.cgi?id=54896
1058
1059         Add -Wl,--no-undefined to catch missing symbols early.
1060
1061         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1062         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1063
1064 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1065
1066         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
1067
1068         * wx/build/settings.py:
1069
1070 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1071
1072         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
1073
1074         * wx/build/settings.py:
1075
1076 2011-04-10  David Levin  <levin@chromium.org>
1077
1078         Reviewed by Dimitri Glazkov.
1079
1080         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
1081         https://bugs.webkit.org/show_bug.cgi?id=58201
1082
1083         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
1084         and filed bug 58202.
1085
1086 2011-04-09  David Levin  <levin@chromium.org>
1087
1088         Unreviewed, rolling out r83394.
1089         http://trac.webkit.org/changeset/83394
1090         https://bugs.webkit.org/show_bug.cgi?id=53625
1091
1092         Patch was incorrect as noted in the bug.
1093
1094         * Scripts/svn-apply:
1095
1096 2011-04-09  David Levin  <levin@chromium.org>
1097
1098         Reviewed by Adam Barth.
1099
1100         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
1101         https://bugs.webkit.org/show_bug.cgi?id=53625
1102
1103         * Scripts/svn-apply: Ensure that the portions of patches
1104         which are for vcproj/vsprops files has DOS line endings.
1105
1106 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
1107
1108         Reviewed by Tony Chang.
1109
1110         It looks like NRWT has not been stopping DRT/TestShell
1111         instances properly on windows, probably for a long time.
1112         This would go a long way to explaining why we often have
1113         processes lying around :)
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=57807
1116
1117         * Scripts/webkitpy/layout_tests/port/chromium.py:
1118         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1119
1120 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
1121
1122         Reviewed by Laszlo Gombos.
1123
1124         [Qt] Don't link against fontconfig or X11 if embedded
1125         https://bugs.webkit.org/show_bug.cgi?id=58104
1126
1127         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
1128         * QtTestBrowser/QtTestBrowser.pro: ditto
1129         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
1130         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
1131
1132 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
1133
1134         http/tests/loading/preload-append-scan.php is failing on Windows
1135         https://bugs.webkit.org/show_bug.cgi?id=58178
1136
1137         Reviewed by Brian Weinstein.
1138
1139         * DumpRenderTree/win/DumpRenderTree.cpp:
1140         (lastPathComponent):
1141         Use CFURL API to find the last path component, rather than
1142         PathFindFileName(), because the latter will include the query string.
1143
1144 2011-04-08  Jian Li  <jianli@chromium.org>
1145
1146         Unreviewed, rolling out r83327, r83330 since these patches are very
1147         likely to break chromium webkit mac10.6 builders.
1148
1149         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1150         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1151         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1152         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1153         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1154         * Scripts/webkitpy/layout_tests/port/base.py:
1155         * Scripts/webkitpy/layout_tests/port/chromium.py:
1156         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1157         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1158         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1159         * Scripts/webkitpy/layout_tests/port/test.py:
1160         * Scripts/webkitpy/layout_tests/port/webkit.py:
1161
1162 2011-04-08  Vincent Scheib  <scheib@chromium.org>
1163
1164         Reviewed by Eric Seidel.
1165
1166         add chromium-gpu-linux-x86_64 to the recognized list of ports
1167         https://bugs.webkit.org/show_bug.cgi?id=58099
1168
1169         Add chromium-gpu-linux-x86_64 to fix assert.
1170
1171         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1172
1173 2011-04-08  Alpha Lam  <hclam@chromium.org>
1174
1175         Unreviewed, rolling out r83335.
1176         http://trac.webkit.org/changeset/83335
1177         https://bugs.webkit.org/show_bug.cgi?id=53556
1178
1179         GTK and QT bots are broken
1180
1181         * Scripts/build-webkit:
1182
1183 2011-04-07  Anna Cavender  <annacc@chromium.org>
1184
1185         Reviewed by Eric Carlson.
1186
1187         Setup ENABLE(TRACK) feature define
1188         https://bugs.webkit.org/show_bug.cgi?id=53556
1189
1190         * Scripts/build-webkit:
1191
1192 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
1193
1194         Reviewed by Adam Roben.
1195
1196         new-run-webkit-tests: configure a NRWT test bot for Mac SL
1197         https://bugs.webkit.org/show_bug.cgi?id=58114
1198
1199         This change removes the old new-run-webkit-tests entry and
1200         updates it for a new test-only bot.
1201
1202         * BuildSlaveSupport/build.webkit.org-config/config.json:
1203
1204 2011-04-08  Dominic Cooney  <dominicc@google.com>
1205
1206         Reviewed by Adam Roben.
1207
1208         Make layoutTestController.shadowRoot return null, not undefined,
1209         when its argument is invalid.
1210         https://bugs.webkit.org/show_bug.cgi?id=58121
1211
1212         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1213         (LayoutTestController::shadowRoot):
1214         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1215         (WTR::LayoutTestController::shadowRoot):
1216
1217 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
1218
1219         Reviewed by Adam Roben.
1220
1221         Locate NSTD.EXE in 64-bit Windows
1222         https://bugs.webkit.org/show_bug.cgi?id=57847
1223
1224         * Scripts/old-run-webkit-tests:
1225
1226 2011-04-08  Adam Roben  <aroben@apple.com>
1227
1228         Qt build fix
1229
1230         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1231
1232 2011-04-07  Adam Roben  <aroben@apple.com>
1233
1234         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1235
1236         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1237         plugin
1238
1239         Reviewed by Anders Carlsson.
1240
1241         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1242         (pluginLogWithArguments): Moved code to format and log the message here...
1243         (pluginLog): ...from here.
1244
1245         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1246
1247         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1248         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1249
1250         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1251
1252         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1253         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1254         to begin.
1255         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1256         constructor.
1257         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1258         can be used to invoke our setWillBeDestroyed function.
1259         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1260         anything unexpected happens).
1261         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1262         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1263         NPP_SetWindow was *not* called during destruction.
1264         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
1265         method, setWillBeDestroyed.
1266         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
1267         object.
1268
1269         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1270         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1271         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1272         * GNUmakefile.am:
1273         Added new test.
1274
1275         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
1276         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
1277
1278 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1279
1280         Reviewed by Martin Robinson.
1281
1282         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1283         https://bugs.webkit.org/show_bug.cgi?id=58039
1284
1285         Implement missing functions in GTK's DRT.
1286
1287         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1288         (AccessibilityUIElement::increment): Implemented.
1289         (AccessibilityUIElement::decrement): Implemented.
1290
1291 2011-04-08  Dominic Cooney  <dominicc@google.com>
1292
1293         Reviewed by Kent Tamura.
1294
1295         Make WK2 layoutTestController.shadowRoot return undefined, not
1296         null, when its argument is not an element.
1297         https://bugs.webkit.org/show_bug.cgi?id=58121
1298
1299         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1300         (WTR::LayoutTestController::shadowRoot):
1301
1302 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
1303
1304         Reviewed by Mihai Parparita.
1305
1306         Change reference port for Mac GPU baselines from
1307         Leopard to SnowLeopard, XP to Win7, and Linux-x86
1308         to Linux x86-64.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=58099
1311
1312         * Scripts/webkitpy/layout_tests/port/chromium.py:
1313
1314 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1315
1316         Revert ENABLE_TRACK patch due to compile failures.
1317
1318         * Scripts/build-webkit:
1319
1320 2011-04-07  Tony Chang  <tony@chromium.org>
1321
1322         Reviewed by Eric Seidel.
1323
1324         update DRT to embed checksums in png files
1325         https://bugs.webkit.org/show_bug.cgi?id=57871
1326
1327         We insert the bytes for the comment in printPNG rather than at encode
1328         time because each platform does its own PNG encoding (either using CG
1329         or cairo).  Putting this in pringPNG avoids having to duplicate this
1330         code, although it's not as clean as doing it at encoding time.
1331
1332         We insert the comment right after the IHDR chunk of the PNG.
1333
1334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1335         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
1336         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1337         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1338         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
1339         * DumpRenderTree/PixelDumpSupport.cpp:
1340         (dumpWebViewAsPixelsAndCompareWithExpected):
1341         (convertChecksumToPNGComment): Generate the bytes to insert.
1342         (printPNG): Insert the png comment before the first IDAT section.
1343         * DumpRenderTree/PixelDumpSupport.h:
1344         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1345         (printPNG):
1346         (dumpBitmap):
1347         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1348         (printPNG):
1349         (dumpBitmap):
1350         * DumpRenderTree/win/DumpRenderTree.vcproj:
1351         * GNUmakefile.am:
1352
1353 2011-04-07  Jeff Miller  <jeffm@apple.com>
1354
1355         Reviewed by Adam Roben.
1356
1357         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
1358         https://bugs.webkit.org/show_bug.cgi?id=58058
1359
1360         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1361         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
1362
1363 2011-04-07  Chang Shu  <cshu@webkit.org>
1364
1365         Reviewed by Darin Adler.
1366
1367         WebKitTestRunner needs layoutTestController.isPageBoxVisible
1368         https://bugs.webkit.org/show_bug.cgi?id=42695
1369
1370         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1371         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1372         (WTR::LayoutTestController::isPageBoxVisible):
1373         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1374
1375 2011-04-07  Adam Roben  <aroben@apple.com>
1376
1377         Build fix
1378
1379         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
1380
1381 2011-04-07  Adam Roben  <aroben@apple.com>
1382
1383         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
1384
1385         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
1386         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
1387         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
1388         be overridden by subclasses to provide extra URLs before we call up to the base class (after
1389         which adding more URLs is no longer possible).
1390
1391         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
1392         bot results page
1393
1394         Reviewed by John Sullivan.
1395
1396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1397         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
1398         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
1399         method is never called for MasterShellCommands.
1400         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
1401         with this method (which is).
1402
1403 2011-04-07  Adam Roben  <aroben@apple.com>
1404
1405         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
1406
1407         This matches how most of our other build steps work, so is good just for improving
1408         consistency between build steps. It should also make it possible for
1409         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
1410         trying to do this in finished() after we had called up to the base class, but that was
1411         apparently too late to add more URLs.)
1412
1413         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
1414         results page
1415
1416         Reviewed by John Sullivan.
1417
1418         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1419         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
1420         call setText to get the right text to show up for this step. This matches how most of our
1421         other build steps work.
1422         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
1423         This is how most of our other build steps work.
1424         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
1425         function, to match the base class.
1426
1427 2011-04-07  Adam Barth  <abarth@webkit.org>
1428
1429         Reviewed by Maciej Stachowiak.
1430
1431         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
1432         https://bugs.webkit.org/show_bug.cgi?id=58022
1433
1434         Previously, we were ignoring the args variable!  This patch fixes the
1435         regression introduced in http://trac.webkit.org/changeset/82771.
1436
1437         * Scripts/webkitpy/tool/commands/download_unittest.py:
1438         * Scripts/webkitpy/tool/mocktool.py:
1439         * Scripts/webkitpy/tool/steps/checkstyle.py:
1440
1441 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
1442
1443         Reviewed by Adam Barth.
1444
1445         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
1446         https://bugs.webkit.org/show_bug.cgi?id=58017
1447
1448         * Scripts/webkitpy/common/checkout/scm.py:
1449         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1450
1451 2011-04-06  Chang Shu  <cshu@webkit.org>
1452
1453         Reviewed by Darin Adler.
1454
1455         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
1456         https://bugs.webkit.org/show_bug.cgi?id=57984
1457
1458         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1459         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1460         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
1461         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1462
1463 2011-04-06  Chris Rogers  <crogers@google.com>
1464
1465         Reviewed by Tony Chang.
1466
1467         Add web audio support to DumpRenderTree (mac port)
1468         https://bugs.webkit.org/show_bug.cgi?id=57969
1469
1470         * DumpRenderTree/LayoutTestController.cpp:
1471         (LayoutTestController::LayoutTestController):
1472         (setEncodedAudioDataCallback):
1473         (LayoutTestController::staticFunctions):
1474         * DumpRenderTree/LayoutTestController.h:
1475         (LayoutTestController::dumpAsAudio):
1476         (LayoutTestController::setDumpAsAudio):
1477         (LayoutTestController::encodedAudioData):
1478         (LayoutTestController::setEncodedAudioData):
1479         * DumpRenderTree/mac/DumpRenderTree.mm:
1480         (dumpAudio):
1481         (dump):
1482
1483 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
1484
1485         Reviewed by Kenneth Rohde Christiansen.
1486
1487         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1488         https://bugs.webkit.org/show_bug.cgi?id=56086
1489
1490         Add the missing method.
1491
1492         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1493         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
1494         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1495         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1496         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1497
1498 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1499
1500         Reviewed by David Levin.
1501
1502         Add QUOTA build flag for unified quota API
1503         https://bugs.webkit.org/show_bug.cgi?id=57918
1504
1505         * Scripts/build-webkit: Added QUOTA build flag
1506
1507 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
1508
1509         Reviewed by Tony Chang.
1510
1511         Adjust the apple webkit port's default timeout to match
1512         old-run-webkit-tests at 35 seconds.
1513
1514         https://bugs.webkit.org/show_bug.cgi?id=37738
1515
1516         * Scripts/webkitpy/layout_tests/port/mac.py:
1517
1518 2011-04-06  Scott Cameron  <sccameron@rim.com>
1519
1520         Reviewed by Eric Seidel.
1521
1522         Remove global variable $httpdPath and replace with the return value of
1523         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
1524         https://bugs.webkit.org/show_bug.cgi?id=53499
1525
1526         * Scripts/run-iexploder-tests:
1527         * Scripts/webkitperl/httpd.pm:
1528
1529 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
1530
1531         Reviewed by Darin Adler.
1532
1533         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
1534         
1535         https://bugs.webkit.org/show_bug.cgi?id=27551
1536         
1537         * DumpRenderTree/config.h:
1538         * WebKitAPITest/config.h:
1539         * WebKitTestRunner/config.h:
1540
1541 2011-04-06  Tony Chang  <tony@chromium.org>
1542
1543         Reviewed by Darin Adler.
1544
1545         teach run-webkit-tests to read checksums from png files
1546         https://bugs.webkit.org/show_bug.cgi?id=57993
1547
1548         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
1549           no .checksum and look for the checksum in there.
1550
1551 2011-04-06  David Dorwin  <ddorwin@chromium.org>
1552
1553         Reviewed by David Levin.
1554
1555         Enable fullscreen layout tests for Chromium
1556         https://bugs.webkit.org/show_bug.cgi?id=55726
1557
1558         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
1559
1560         * DumpRenderTree/chromium/WebPreferences.cpp:
1561         (WebPreferences::applyTo):
1562
1563 2011-04-06  Adam Roben  <aroben@apple.com>
1564
1565         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
1566
1567         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
1568
1569         Reviewed by David Kilzer.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1572         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
1573         build's results directory here...
1574         (ExtractTestResults.finished): ...from here.
1575         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1576         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1577         leaks" link to point to Leaks Viewer for this build.
1578         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1579         but it seemed good to add for consistency with BuildAndTestFactory.
1580         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1581         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1582         that we'll get a "view leaks" link.
1583
1584 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1585
1586         Reviewed by Eric Seidel.
1587
1588         [Gtk] plugins/set-status.html fails
1589         https://bugs.webkit.org/show_bug.cgi?id=57844
1590
1591         Allow an empty status text to be dumped.
1592
1593         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1594         (webViewStatusBarTextChanged):
1595
1596 2011-04-06  Chang Shu  <cshu@webkit.org>
1597
1598         Reviewed by Darin Adler.
1599
1600         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1601         https://bugs.webkit.org/show_bug.cgi?id=42329
1602
1603         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1604         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1605         (WTR::LayoutTestController::pageNumberForElementById):
1606         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1607
1608 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1609
1610         Reviewed by Martin Robinson.
1611
1612         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1613         https://bugs.webkit.org/show_bug.cgi?id=57932
1614
1615         Some Layout tests have invalid URIs that do not generate valid
1616         SoupURI instances. Do not try to free those NULL SoupURIs.
1617
1618         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1619         (willSendRequestCallback):
1620
1621 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1622
1623         Reviewed by Andreas Kling.
1624
1625         ORWT shouldn't generate diff files for tests without expected files
1626         https://bugs.webkit.org/show_bug.cgi?id=57846
1627
1628         * Scripts/old-run-webkit-tests:
1629
1630 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1631
1632         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1633         to deps.
1634
1635         * wx/install-unix-extras:
1636
1637 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1638
1639         Unreviewed, rolling out r82978, r82999, and r83001.
1640         http://trac.webkit.org/changeset/82978
1641         http://trac.webkit.org/changeset/82999
1642         http://trac.webkit.org/changeset/83001
1643         https://bugs.webkit.org/show_bug.cgi?id=57913
1644
1645         Does not work in Python 2.5 (Requested by abarth on #webkit).
1646
1647         * Scripts/webkitpy/common/system/executive.py:
1648         * Scripts/webkitpy/common/system/executive_unittest.py:
1649
1650 2011-04-05  Chang Shu  <cshu@webkit.org>
1651
1652         Reviewed by Darin Adler.
1653
1654         WebKitTestRunner needs layoutTestController.numberOfPages
1655         https://bugs.webkit.org/show_bug.cgi?id=42694
1656
1657         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1658         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1659         (WTR::LayoutTestController::numberOfPages):
1660         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1661
1662 2011-04-05  Tony Chang  <tony@chromium.org>
1663
1664         Reviewed by Mihai Parparita.
1665
1666         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1667         https://bugs.webkit.org/show_bug.cgi?id=57889
1668
1669         * Scripts/webkitpy/layout_tests/port/chromium.py:
1670         * Scripts/webkitpy/layout_tests/port/test.py:
1671         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1672
1673 2011-04-05  Adam Barth  <abarth@webkit.org>
1674
1675         Silly with statement, from the future!
1676
1677         * Scripts/webkitpy/common/system/executive.py:
1678
1679 2011-04-05  Adam Barth  <abarth@webkit.org>
1680
1681         Reviewed by Tony Chang.
1682
1683         Don't use Exception.message because it's deprecated
1684         https://bugs.webkit.org/show_bug.cgi?id=57892
1685
1686         Suppress the warning for now.  When we move to Python 3, we might need
1687         to something more dramatic.
1688
1689         * Scripts/webkitpy/common/system/executive.py:
1690
1691 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1692
1693         Reviewed by Ojan Vafai.
1694
1695         Add builders.js to dashboard file list
1696         https://bugs.webkit.org/show_bug.cgi?id=57899
1697
1698         Add file added by http://crrev.com/80538 to dashboard file list.
1699
1700         * TestResultServer/handlers/dashboardhandler.py:
1701
1702 2011-04-05  MORITA Hajime  <morrita@google.com>
1703
1704         Reviewed by Adam Barth.
1705
1706         webkit-patch should print git's stderr when git svn dcommit fail
1707         http://webkit.org/b/57861
1708
1709         * Scripts/webkitpy/common/checkout/scm.py:
1710
1711 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1712
1713         Reviewed by Tony Chang.
1714
1715         Add --baseline-search-path to NRWT
1716         https://bugs.webkit.org/show_bug.cgi?id=56233
1717         
1718         Add NRWT option to specify additional directories to look for baselines
1719         (will be used by hardware GPU bots which will have local per-bot
1720         expectations for some tests)
1721
1722         * Scripts/webkitpy/common/system/filesystem_mock.py:
1723         * Scripts/webkitpy/layout_tests/port/base.py:
1724         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1726
1727 2011-04-05  Adam Roben  <aroben@apple.com>
1728
1729         Strip off /results.html from results URLs before trying to load leaks files from them
1730
1731         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1732         files, rather than pointing to the directory that contains them. This is more convenient for
1733         people browsing build.webkit.org, but confused Leaks Viewer.
1734
1735         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1736         list don't work
1737
1738         Reviewed by Joseph Pecoraro.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1741         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1742
1743 2011-04-05  Carol Szabo  <carol@webkit.org>
1744
1745         Unreviewed.
1746
1747         Updated my info in committers.py
1748
1749         Scripts\webkitpy\common\config\committers.py 
1750
1751 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1752
1753         Reviewed by Laszlo Gombos.
1754
1755         [Qt] Make WebKitLibraries optional for building QtWebKit
1756         https://bugs.webkit.org/show_bug.cgi?id=57542
1757
1758         * Scripts/build-webkit:
1759
1760 2011-04-05  Chang Shu  <cshu@webkit.org>
1761
1762         Reviewed by Laszlo Gombos.
1763
1764         [Qt] MiniBrowser defaultUrl does not work
1765         https://bugs.webkit.org/show_bug.cgi?id=57021
1766
1767         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1768         * MiniBrowser/qt/main.cpp:
1769         (main):
1770
1771 2011-04-05  Jade Han  <jade.han@nokia.com>
1772
1773         Reviewed by Laszlo Gombos.
1774
1775         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1776         https://bugs.webkit.org/show_bug.cgi?id=54977
1777
1778         This change is a preparation to enable building webkit2 for Symbian.
1779         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1780
1781         * Tools.pro:
1782
1783 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1784
1785         Reviewed by Andreas Kling.
1786
1787         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1788         https://bugs.webkit.org/show_bug.cgi?id=57832
1789
1790         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1791
1792         * MiniBrowser/qt/UrlLoader.cpp:
1793         (UrlLoader::UrlLoader):
1794
1795 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1796
1797         [Qt] Linux Release minimal build fix after r82919.
1798
1799         * MiniBrowser/qt/BrowserWindow.cpp:
1800         (BrowserWindow::loadURLListFromFile):
1801         * QtTestBrowser/launcherwindow.cpp:
1802         (LauncherWindow::loadURLListFromFile):
1803
1804 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1805
1806         Reviewed by Andreas Kling.
1807
1808         [Qt] Make URL loader accessible from testbrowser's menus
1809         https://bugs.webkit.org/show_bug.cgi?id=57823
1810
1811         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
1812
1813         * MiniBrowser/qt/BrowserWindow.cpp:
1814         (BrowserWindow::BrowserWindow):
1815         (BrowserWindow::loadURLListFromFile):
1816         (BrowserWindow::~BrowserWindow):
1817         * MiniBrowser/qt/BrowserWindow.h:
1818         * QtTestBrowser/launcherwindow.cpp:
1819         (LauncherWindow::LauncherWindow):
1820         (LauncherWindow::~LauncherWindow):
1821         (LauncherWindow::createChrome):
1822         (LauncherWindow::loadURLListFromFile):
1823         * QtTestBrowser/launcherwindow.h:
1824
1825 2011-04-04  Sam Weinig  <sam@webkit.org>
1826
1827         Reviewed by Brian Weinstein.
1828
1829         Remove duplicate API from WKContext
1830         <rdar://problem/8727879>
1831         https://bugs.webkit.org/show_bug.cgi?id=57815
1832
1833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1834         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
1835         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1836         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
1837
1838 2011-04-04  Tony Chang  <tony@chromium.org>
1839
1840         Reviewed by Ojan Vafai.
1841
1842         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
1843         https://bugs.webkit.org/show_bug.cgi?id=57783
1844
1845         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1846         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1847
1848 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1849
1850         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
1851         from WebKitBuild.
1852
1853         * Scripts/webkitdirs.pm:
1854
1855 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1856
1857         Reviewed by Gustavo Noronha Silva.
1858
1859         [GTK] WebGL support
1860         https://bugs.webkit.org/show_bug.cgi?id=31517
1861
1862         Add support to the DRT for turning on WebGL when a layout tests requests it.
1863
1864         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1865         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
1866
1867 2011-04-04  Chang Shu  <cshu@webkit.org>
1868
1869         Reviewed by Darin Adler.
1870
1871         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
1872         https://bugs.webkit.org/show_bug.cgi?id=57572
1873
1874         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1875         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1876         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1877         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1878
1879 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
1880
1881         Reviewed by Csaba Osztrogonác.
1882
1883         [Qt] DumpRenderTree breaks compilation in some uClibc environments
1884         https://bugs.webkit.org/show_bug.cgi?id=57602
1885
1886         * DumpRenderTree/qt/main.cpp:
1887         (get_backtrace):
1888
1889 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1890
1891         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1892
1893         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1894         (LayoutTestController::shadowRoot):
1895
1896 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
1897
1898         Unreviewed, fix exception in rebaseline tool.
1899
1900         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1901
1902 2011-04-02  Beth Dakin  <bdakin@apple.com>
1903
1904         Rubber-stamped by Geoff Garen.
1905
1906         For Dan!
1907         * DumpRenderTree/mac/DumpRenderTree.mm:
1908         (resetWebViewToConsistentStateBeforeTesting):
1909
1910 2011-04-02  Beth Dakin  <bdakin@apple.com>
1911
1912         Rubber-stamped by Geoff Garen.
1913
1914         Need to reset the scale, much like zoom.
1915         * DumpRenderTree/mac/DumpRenderTree.mm:
1916         (resetWebViewToConsistentStateBeforeTesting):
1917
1918 2011-04-02  Sam Weinig  <sam@webkit.org>
1919
1920         Reviewed by Beth Dakin.
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=57605
1923         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1924         getClientRects()
1925         -and corresponding-
1926         <rdar://problem/9194541>
1927
1928         Add DRT support for the scaleWebView SPI.
1929         * DumpRenderTree/mac/EventSendingController.mm:
1930         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1931         (+[EventSendingController webScriptNameForSelector:]):
1932         (-[EventSendingController scalePageBy:atX:andY:]):
1933         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1934         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1935         (WTR::EventSendingController::scalePageBy):
1936         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1938         (WTR::InjectedBundlePage::reset):
1939
1940 2011-04-02  Dominic Cooney  <dominicc@google.com>
1941
1942         Reviewed by Martin Robinson.
1943
1944         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1945         https://bugs.webkit.org/show_bug.cgi?id=57551
1946
1947         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1948         (LayoutTestController::shadowRoot):
1949
1950 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1951
1952         Reviewed by Eric Seidel.
1953
1954         Remove AbstractStep._run_script and move script names to ports.py
1955         https://bugs.webkit.org/show_bug.cgi?id=57704
1956
1957         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1958
1959         * Scripts/webkitpy/common/config/ports.py:
1960         * Scripts/webkitpy/tool/commands/download_unittest.py:
1961         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1962         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1963         * Scripts/webkitpy/tool/steps/abstractstep.py:
1964         * Scripts/webkitpy/tool/steps/checkstyle.py:
1965         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1966         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1967         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1968
1969 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1970
1971         Reviewed by Eric Seidel.
1972
1973         Emulate shebang on Win32
1974         https://bugs.webkit.org/show_bug.cgi?id=55927
1975
1976         Scripts on Windows work only if they are called with the explicit interpreter.
1977         Read the first line of scripts to detect the correct executable.
1978
1979         * Scripts/webkitpy/common/config/ports.py:
1980         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1981         * Scripts/webkitpy/common/system/executive_unittest.py:
1982
1983 2011-04-01  Adam Barth  <abarth@webkit.org>
1984
1985         Reviewed by Eric Seidel.
1986
1987         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1988         https://bugs.webkit.org/show_bug.cgi?id=57692
1989
1990         Previously, we were using BeautifulSoup to process XML from
1991         bugs.webkit.org, but that's incorrect.  We should be using
1992         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1993         entity wrong because &apos; is an XML entity but not an HTML entity.
1994
1995         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1996         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1997
1998 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1999
2000         Unreviewed, rolling out r82721.
2001         http://trac.webkit.org/changeset/82721
2002         https://bugs.webkit.org/show_bug.cgi?id=57687
2003
2004         This patch introduced assertion failures on the GTK+ bots.
2005         (Requested by mrobinson on #webkit).
2006
2007         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2008         (LayoutTestController::shadowRoot):
2009
2010 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2011
2012         Unreviewed buildfix.
2013
2014         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2015         https://bugs.webkit.org/show_bug.cgi?id=55074
2016
2017         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
2018         (The isWK2() function removes it from @ARGV, but not from @options.)
2019
2020 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2021
2022         Reviewed by Csaba Osztrogonác.
2023
2024         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
2025         https://bugs.webkit.org/show_bug.cgi?id=57666
2026
2027         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
2028
2029 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2030
2031         Reviewed by Adam Barth.
2032
2033         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
2034
2035         We apparently never implemented the code to skip tests based on
2036         what was compiled into DRT. Also, change the logic used to skip
2037         platform directories to match what old-run-webkit-tests does: 
2038         skip every test not in a directory in the baseline search path.
2039
2040         https://bugs.webkit.org/show_bug.cgi?id=57662
2041
2042         * Scripts/webkitpy/layout_tests/port/mac.py:
2043         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2044         * Scripts/webkitpy/layout_tests/port/webkit.py:
2045
2046 2011-03-29  Mark Rowe  <mrowe@apple.com>
2047
2048         Reviewed by Jon Honeycutt.
2049
2050         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
2051
2052         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
2053
2054         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2055         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2056         * Scripts/webkitpy/layout_tests/port/mac.py:
2057         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2058
2059 2011-04-01  Chang Shu  <cshu@webkit.org>
2060
2061         Reviewed by Csaba Osztrogonác.
2062
2063         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2064         https://bugs.webkit.org/show_bug.cgi?id=55074
2065
2066         * Scripts/build-webkit:
2067
2068 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2069
2070         Reviewed by Tony Chang.
2071
2072         new-run-webkit-tests: remove spurious port version override in webkit.py
2073         base.py provides a default implementation so this is just
2074         breaking things.
2075
2076         https://bugs.webkit.org/show_bug.cgi?id=57667
2077
2078         * Scripts/webkitpy/layout_tests/port/webkit.py:
2079         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2080
2081 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2082
2083         Reviewed by Adam Roben.
2084
2085         Make view results on waterfall direct link to results.html
2086         https://bugs.webkit.org/show_bug.cgi?id=57671
2087
2088         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
2089         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
2090
2091 2011-04-01  Sam Weinig  <sam@webkit.org>
2092
2093         Fix windows build.
2094
2095         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2096         (TestWebKitAPI::TEST):
2097         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2098         (TestWebKitAPI::flushMessages):
2099
2100 2011-04-01  Sam Weinig  <sam@webkit.org>
2101
2102         Reviewed by Adam Roben.
2103
2104         Add adoptWK to WKRetainPtr.h
2105         https://bugs.webkit.org/show_bug.cgi?id=57670
2106
2107         * TestWebKitAPI/PlatformUtilities.h:
2108         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2109         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2110         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2111         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2112         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2113         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2114         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2115         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2116         (TestWebKitAPI::createSessionStateContainingFormData):
2117         * WebKitTestRunner/StringFunctions.h:
2118         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
2119
2120 2011-04-01  Sam Weinig  <sam@webkit.org>
2121
2122         Reviewed by Adam Roben.
2123
2124         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
2125
2126         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2127         (WTR::LayoutTestController::shadowRoot):
2128         Make judicious use of adoptWK().
2129
2130 2011-04-01  Sam Weinig  <sam@webkit.org>
2131
2132         Reviewed by Timothy Hatcher.
2133
2134         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
2135
2136         * Scripts/extract-localizable-strings:
2137
2138 2011-04-01  Anders Carlsson  <andersca@apple.com>
2139
2140         Reviewed by Sam Weinig.
2141
2142         Shockwave plug-in doesn't accept mouse events
2143         https://bugs.webkit.org/show_bug.cgi?id=57653
2144         <rdar://problem/8483273>
2145
2146         Add a plug-in test.
2147
2148         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2149         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2150         (PluginTest::indicateTestFailure):
2151         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
2152
2153         (PluginTest::NPN_ConvertPoint):
2154         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2155         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2156         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2157         Call indicateTestFailure.
2158
2159         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
2160         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
2161         (ConvertPoint::ConvertPoint):
2162         (ConvertPoint::testConvert):
2163         (ConvertPoint::NPP_New):
2164
2165 2011-04-01  Dominic Cooney  <dominicc@google.com>
2166
2167         Reviewed by Martin Robinson.
2168
2169         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2170         https://bugs.webkit.org/show_bug.cgi?id=57551
2171
2172         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2173         (LayoutTestController::shadowRoot):
2174
2175 2011-04-01  Sam Weinig  <sam@webkit.org>
2176
2177         Reviewed by Anders Carlsson.
2178
2179         WebKitTestRunner needs layoutTestController.shadowRoot
2180         https://bugs.webkit.org/show_bug.cgi?id=57661
2181
2182         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2183         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2184         (WTR::LayoutTestController::shadowRoot):
2185         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2186         Implement layoutTestController.shadowRoot for WebKit2.
2187
2188 2011-04-01  Chang Shu  <cshu@webkit.org>
2189
2190         Reviewed by Darin Adler.
2191
2192         WebKitTestRunner needs layoutTestController.setDatabaseQuota
2193         https://bugs.webkit.org/show_bug.cgi?id=57568
2194
2195         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2196         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2197         (WTR::LayoutTestController::setDatabaseQuota):
2198         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2199
2200 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2201
2202         Reviewed by Tony Chang.
2203
2204         This patch completes the cleanup of
2205         rebaseline-chromium-webkit-tests to work with all of the
2206         variants of a platform (we can now rebaseline gpu- and non-gpu
2207         files at the same time).
2208
2209         When the rebaselining is complete, any lines declared as
2210         REBASELINE in the expectations file that matches a test that was
2211         actually rebaselined will be deleted, even if only one of the
2212         variants was actually rebaselined. This may cause odd problems,
2213         but is better than where we're at today.
2214
2215         This change removes the -g flag and deprecates -w. The -g flag is gone
2216         because GPU baselines are handled just like any other variant.
2217         The -w flag is deprecated because this tool now only works
2218         against the canaries, since that's the only place we have a full
2219         set of bots. It will be trivial to change this to
2220         build.webkit.org if we decide that's where we want them to be.
2221
2222         Also, this patch deletes a lot of cruft that is no longer needed
2223         in the test_expectations code and the port-specific code.
2224
2225         https://bugs.webkit.org/show_bug.cgi?id=55191
2226
2227         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2228         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2229         * Scripts/webkitpy/layout_tests/port/base.py:
2230         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2231         * Scripts/webkitpy/layout_tests/port/chromium.py:
2232         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2233         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2234         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2235         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2236         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2237         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2238         * Scripts/webkitpy/layout_tests/port/mac.py:
2239         * Scripts/webkitpy/layout_tests/port/test.py:
2240         * Scripts/webkitpy/layout_tests/port/webkit.py:
2241         * Scripts/webkitpy/layout_tests/port/win.py:
2242         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2243         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2244
2245 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2246
2247         Reviewed by Adam Barth.
2248
2249         rebaseline-chromium-webkit-tests does not work correctly with
2250         version-specific baselines. This patch updates the tool to use
2251         all of the version-specific bots on the canaries, and will now
2252         attempt to rebaseline all of the versions by default, although
2253         it will not update both GPU and CPU versions.
2254         
2255         Also, it will no longer modify the test_expectations.txt file
2256         *at all*. You will have to manually delete the REBASELINE lines
2257         after running the tool and determining that it did what you
2258         wanted it to do. This should be fixed in a separate bug - see
2259         webkit bug #55191.
2260
2261         https://bugs.webkit.org/show_bug.cgi?id=55608
2262
2263         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2264         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2265         * Scripts/webkitpy/layout_tests/port/chromium.py:
2266         * Scripts/webkitpy/layout_tests/port/test.py:
2267         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2268         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2269
2270 2011-03-31  Tony Chang  <tony@chromium.org>
2271
2272         Reviewed by Ojan Vafai.
2273
2274         [chromium] update the rebaseline tool to know about pngs with checksums
2275         https://bugs.webkit.org/show_bug.cgi?id=57481
2276
2277         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
2278         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2279
2280 2011-04-01  Adam Roben  <aroben@apple.com>
2281
2282         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
2283
2284         Previously, we were getting the revision of the first revision that triggered a build.
2285         Choosing the last revision would have been more accurate. But got_revision is what is used
2286         everywhere else on build.webkit.org, and should work even when there were no changes that
2287         triggered a build (e.g., if someone clicked the Force Build button).
2288
2289         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
2290         recent builds list
2291
2292         Reviewed by Anders Carlsson.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2295         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
2296         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2299         (Array.prototype.first): Added this helper function to return the first element in an array
2300         that matches the given predicate, or null if no such element exists.
2301
2302 2011-03-31  Adam Roben  <aroben@apple.com>
2303
2304         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
2305
2306         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
2307
2308         Reviewed by Darin Adler.
2309
2310         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2311         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
2312         URL on its own line.
2313
2314         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2315         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
2316         progression, and added a new test that uses a short bug URL while I was at it.
2317
2318 2011-04-01  Adam Roben  <aroben@apple.com>
2319
2320         Mark .vcproj/.vsprops/.sln files as being Windows-only
2321
2322         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
2323
2324         Reviewed by Anders Carlsson.
2325
2326         * Scripts/webkitpy/common/config/build.py:
2327         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
2328         directories as Windows-only.
2329
2330         * Scripts/webkitpy/common/config/build_unittest.py:
2331         (ShoulBuildTest): Added test cases for the above.
2332
2333 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2334
2335         Reviewed by Laszlo Gombos.
2336
2337         [Qt] Build MiniBrowser for Symbian
2338         https://bugs.webkit.org/show_bug.cgi?id=56319
2339
2340         Have MiniBrowser reference it's own copy of useragentlist.txt instead
2341         of copying QtTestBrowser's.
2342         Remove Tools/MiniBrowser/DerivedSources.pro
2343         This reduces complexity in the Tools scripts due to Symbian limitations.
2344
2345         * DerivedSources.pro:
2346         * MiniBrowser/DerivedSources.pro: Removed.
2347         * MiniBrowser/MiniBrowser.qrc:
2348         * MiniBrowser/qt/MiniBrowser.pro:
2349         * Scripts/webkitdirs.pm:
2350
2351 2011-03-31  Chang Shu  <cshu@webkit.org>
2352
2353         Reviewed by Darin Adler.
2354
2355         WebKitTestRunner needs layoutTestController.clearAllDatabases
2356         https://bugs.webkit.org/show_bug.cgi?id=42540
2357
2358         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2359         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2360         (WTR::InjectedBundle::beginTesting):
2361         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2362         (WTR::LayoutTestController::clearAllDatabases):
2363         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2364
2365 2011-03-31  Chang Shu  <cshu@webkit.org>
2366
2367         Reviewed by Darin Adler.
2368
2369         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2370         https://bugs.webkit.org/show_bug.cgi?id=42692
2371
2372         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2373
2374 2011-03-31  Darin Adler  <darin@apple.com>
2375
2376         Reviewed by Sam Weinig.
2377
2378         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
2379         https://bugs.webkit.org/show_bug.cgi?id=57573
2380
2381         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2382         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
2383         Removed fake definitions of keyDown and contextClick.
2384
2385         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2386         (WTR::operator==): Added. So we can compare two WKPoint structs.
2387         (WTR::parseModifier): Added.
2388         (WTR::parseModifierArray): Added.
2389         (WTR::EventSendingController::EventSendingController): Initialize the
2390         new data members.
2391         (WTR::EventSendingController::mouseDown): Added. Calls
2392         WKBundlePageSimulateMouseDown.
2393         (WTR::EventSendingController::mouseUp): Added. Calls
2394         WKBundlePageSimulateMouseUp.
2395         (WTR::EventSendingController::mouseMoveTo): Added. Calls
2396         WKBundlePageSimulateMouseMotion.
2397         (WTR::EventSendingController::leapForward): Added.
2398         (WTR::EventSendingController::updateClickCount): Added. Used by the
2399         mouseDown/Up functions to create a click count.
2400
2401         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
2402         for the changes above.
2403
2404 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
2405
2406         Reviewed by Martin Robinson.
2407
2408         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
2409         https://bugs.webkit.org/show_bug.cgi?id=57362
2410
2411         Do not generate DRT output if willSendRequestReturnsNull is set.
2412
2413         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2414         (willSendRequestCallback):
2415
2416 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
2417
2418         Reviewed by Martin Robinson.
2419
2420         Implement MiniBrowser for Gtk port.
2421         https://bugs.webkit.org/show_bug.cgi?id=48512
2422
2423         Initial implementation of the Gtk MiniBrowser.
2424
2425         * MiniBrowser/gtk/GNUmakefile.am: Added.
2426         * MiniBrowser/gtk/main.c: Added.
2427         (activateUriEntryCallback):
2428         (destroyCallback):
2429         (goBackCallback):
2430         (goForwardCallback):
2431         (createToolbar):
2432         (createWebView):
2433         (createWindow):
2434         (argumentToURL):
2435         (main):
2436
2437 2011-03-30  Dominic Cooney  <dominicc@google.com>
2438
2439         Reviewed by Dimitri Glazkov.
2440
2441         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2442         https://bugs.webkit.org/show_bug.cgi?id=57415
2443
2444         * DumpRenderTree/LayoutTestController.cpp:
2445         (shadowRootCallback):
2446         (LayoutTestController::staticFunctions):
2447         * DumpRenderTree/LayoutTestController.h:
2448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2449         (LayoutTestController::shadowRoot):
2450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2451         (LayoutTestController::shadowRoot):
2452
2453 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
2454
2455         Reviewed by Chris Marrin.
2456
2457         Update fast/canvas tests to avoid dumping the render tree when possible
2458         https://bugs.webkit.org/show_bug.cgi?id=57493
2459
2460         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
2461           accelerated drawing and accelerated drawing for canvas
2462
2463 2011-03-30  Adam Roben  <aroben@apple.com>
2464
2465         Stop ignoring leaks in CGGradientCreateWithColorStops
2466
2467         Fixes <rdar://problem/7888547>.
2468
2469         Rubber-stamped by John Sullivan.
2470
2471         * Scripts/old-run-webkit-tests:
2472         (countAndPrintLeaks): Removed some code to ignore those leaks.
2473
2474 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
2475
2476         Reviewed by Alexey Proskuryakov.
2477
2478         Add some dynamic annotations to JavaScriptCore/wtf
2479         https://bugs.webkit.org/show_bug.cgi?id=53747
2480
2481         By using these annotations we can improve the precision of finding
2482         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
2483         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
2484
2485         These files don't add new functionality, so don't need extra tests.
2486
2487         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
2488
2489 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2490
2491         Reviewed by Adam Roben.
2492
2493         Share most vsprops between Release and Production builds in releaseproduction.vsprops
2494         https://bugs.webkit.org/show_bug.cgi?id=57508
2495
2496         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2497         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2498         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2499         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2500         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2501         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2502         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2503         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2504         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2505         * FindSafari/FindSafariProduction.vsprops:
2506         * FindSafari/FindSafariRelease.vsprops:
2507         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
2508         * FindSafari/FindSafariReleasePGO.vsprops:
2509         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2510         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2511         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2512         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2513         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2514         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2515         * WebKitAPITest/WebKitAPITestRelease.vsprops:
2516         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
2517         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2518         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2519         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2520         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2521         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2522         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2523         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2524         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2525         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2526         * WinLauncher/WinLauncherProduction.vsprops:
2527         * WinLauncher/WinLauncherRelease.vsprops:
2528         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2529         * record-memory-win/record-memory-winProduction.vsprops:
2530         * record-memory-win/record-memory-winRelease.vsprops:
2531         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2532
2533 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2534
2535         Reviewed by Adam Roben.
2536
2537         Update Windows production build logic for new production configurations
2538         https://bugs.webkit.org/show_bug.cgi?id=57494
2539
2540         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2541         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2542         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2543         * FindSafari/FindSafariProduction.vsprops:
2544         * FindSafari/FindSafariReleasePGO.vsprops:
2545         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2546         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2547         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2548         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2549         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2550         * WinLauncher/WinLauncherProduction.vsprops:
2551         * record-memory-win/record-memory-winProduction.vsprops:
2552
2553 2011-03-30  Robert Hogan  <robert@webkit.org>
2554
2555         Reviewed by Antonio Gomes.
2556
2557         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2558         Unskip http/tests/navigation/go-back-to-error-page.html
2559
2560         Also add the location of DumpRenderTreeSupportQt.h
2561         to DRT's include paths.
2562
2563         https://bugs.webkit.org/show_bug.cgi?id=52614
2564
2565         * DumpRenderTree/qt/DumpRenderTree.pro:
2566         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2567         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2568         * DumpRenderTree/qt/GCControllerQt.cpp:
2569         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2570         (LayoutTestController::queueLoadHTMLString):
2571         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2572         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2573         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2574         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2575         (LoadAlternateHTMLStringItem::invoke):
2576         * DumpRenderTree/qt/WorkQueueItemQt.h:
2577         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2578         * QtTestBrowser/QtTestBrowser.pro:
2579         * QtTestBrowser/launcherwindow.h:
2580
2581 2011-03-30  Adam Barth  <abarth@webkit.org>
2582
2583         Reviewed by Adam Roben.
2584
2585         SheriffBot rollouts take too long
2586         https://bugs.webkit.org/show_bug.cgi?id=57498
2587
2588         We used to build before landing rollouts via the commit-queue to
2589         prevent further breakage, but now that our individual commit-queue
2590         machines are slower, building takes too long.  I can't remember the
2591         last time a rollout broke compile.  It seems like just landing the
2592         patch is the better trade-off.
2593
2594         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2595         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2596
2597 2011-03-30  Adam Barth  <abarth@webkit.org>
2598
2599         Remove platform/chromium-mac-snowleopard
2600         https://bugs.webkit.org/show_bug.cgi?id=57486
2601
2602         This directory no longer exists, so we can remove it from the fallback
2603         chain.
2604
2605         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2606
2607 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2608
2609         Reviewed by Adam Roben.
2610
2611         Rename Windows configuration Release_LTCG to Production for clarity
2612         https://bugs.webkit.org/show_bug.cgi?id=57465
2613
2614         * DumpRenderTree/DumpRenderTree.sln:
2615         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2616         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2617         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2618         * DumpRenderTree/win/DumpRenderTree.vcproj:
2619         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2620         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2621         * DumpRenderTree/win/ImageDiff.vcproj:
2622         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2623         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2624         * FindSafari/FindSafari.vcproj:
2625         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2626         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2627         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2628         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2629         * MiniBrowser/MiniBrowser.vcproj:
2630         * Scripts/webkitdirs.pm:
2631         * TestWebKitAPI/win/TestWebKitAPI.sln:
2632         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2633         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2634         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2635         * WebKitAPITest/WebKitAPITest.vcproj:
2636         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2637         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2638         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2639         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2640         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2641         * WebKitTestRunner/WebKitTestRunner.sln:
2642         * WebKitTestRunner/win/InjectedBundle.vcproj:
2643         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2644         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2645         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2646         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2647         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2648         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2649         * WinLauncher/WinLauncher.vcproj:
2650         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2651         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2652         * record-memory-win/record-memory-win.vcproj:
2653         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2654         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2655
2656 2011-03-30  MORITA Hajime  <morrita@google.com>
2657
2658         Reviewed by Dimitri Glazkov.
2659
2660         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2661         https://bugs.webkit.org/show_bug.cgi?id=56573
2662
2663         Added LayoutTestController.shadowRoot() to Chromium DRT.
2664
2665         * DumpRenderTree/chromium/LayoutTestController.cpp:
2666         (LayoutTestController::LayoutTestController):
2667         (LayoutTestController::shadowRoot):
2668         * DumpRenderTree/chromium/LayoutTestController.h:
2669
2670 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2671
2672         Reviewed by Kent Tamura.
2673
2674         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2675         https://bugs.webkit.org/show_bug.cgi?id=57430
2676
2677         * DumpRenderTree/chromium/LayoutTestController.cpp:
2678         (LayoutTestController::LayoutTestController):
2679         (LayoutTestController::setPluginsEnabled):
2680         * DumpRenderTree/chromium/LayoutTestController.h:
2681
2682 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2683
2684         Reviewed by Adam Barth.
2685
2686         make webkit-patch upload respect -d
2687         https://bugs.webkit.org/show_bug.cgi?id=57425
2688
2689         * Scripts/webkitpy/common/checkout/scm.py:
2690         * Scripts/webkitpy/tool/steps/commit.py:
2691
2692 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2693
2694         Reviewed by Adam Barth.
2695
2696         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2697         https://bugs.webkit.org/show_bug.cgi?id=57429
2698
2699         * Scripts/webkitpy/common/checkout/scm.py:
2700
2701 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2702
2703         Unreviewed, rolling out r82383.
2704         http://trac.webkit.org/changeset/82383
2705         https://bugs.webkit.org/show_bug.cgi?id=57417
2706
2707         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2708         #webkit).
2709
2710         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2711         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2712         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2713
2714 2011-03-29  Kent Tamura  <tkent@chromium.org>
2715
2716         Reviewed by Dimitri Glazkov.
2717
2718         Make validation message bubble testable
2719         https://bugs.webkit.org/show_bug.cgi?id=57290
2720
2721         * DumpRenderTree/mac/DumpRenderTree.mm:
2722         (createWebViewAndOffscreenWindow): Change a setting so that validation
2723           bubbles isn't hidden automatically.
2724
2725 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2726
2727         Reviewed by Ojan Vafai.
2728
2729         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2730
2731         It's a bit unclear whether multiple threads or multiple
2732         processes will be a better model on windows. This change will
2733         test threads for now while we're still working out the bugs in
2734         multiple-processes.
2735
2736         https://bugs.webkit.org/show_bug.cgi?id=57410
2737
2738         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2739         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2740         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2741
2742 2011-03-29  David Levin  <levin@chromium.org>
2743
2744         Reviewed by Shinichiro Hamaji.
2745
2746         check-webkit-style confused by two ChangeLog entries in a row from same user
2747         https://bugs.webkit.org/show_bug.cgi?id=57250
2748
2749         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2750         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2751         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2752           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2753           checking more than that would be very messey.
2754         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2755         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2756
2757 2011-03-29  Kent Tamura  <tkent@chromium.org>
2758
2759         Reviewed by Dimitri Glazkov.
2760
2761         [Mac] Enable interactive-validation tests on Mac DRT
2762         https://bugs.webkit.org/show_bug.cgi?id=57308
2763
2764         * DumpRenderTree/mac/DumpRenderTree.mm:
2765         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2766
2767 2011-03-29  Chang Shu  <cshu@webkit.org>
2768
2769         Reviewed by Kenneth Rohde Christiansen.
2770
2771         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2772         https://bugs.webkit.org/show_bug.cgi?id=42692
2773
2774         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2775         (WTR::InjectedBundle::beginTesting):
2776         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2777         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2778         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2779
2780 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2781
2782         Reviewed by Xan Lopez.
2783
2784         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2785         https://bugs.webkit.org/show_bug.cgi?id=57067
2786
2787         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2788         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2789         update DRT and pixel results as hundreds of results will need to be updated.
2790
2791         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2792         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2793         by overriding the theme RC/CSS files.
2794
2795 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
2796
2797         Reviewed by Adam Roben.
2798
2799         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2800         https://bugs.webkit.org/show_bug.cgi?id=57394
2801
2802         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2803         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2804         the IDE. To avoid this, add a separate vsprops file for each project configuration that
2805         contains the required inherited property sheets.
2806
2807         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2808         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
2809         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
2810         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
2811         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
2812         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
2813         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
2814         * DumpRenderTree/win/DumpRenderTree.vcproj:
2815         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
2816         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
2817         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
2818         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
2819         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
2820         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
2821         * DumpRenderTree/win/ImageDiff.vcproj:
2822         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
2823         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
2824         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
2825         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
2826         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
2827         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
2828         * FindSafari/FindSafari.vcproj:
2829         * FindSafari/FindSafariDebug.vsprops: Added.
2830         * FindSafari/FindSafariDebugAll.vsprops: Added.
2831         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
2832         * FindSafari/FindSafariRelease.vsprops: Added.
2833         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
2834         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
2835         * FindSafari/FindSafariReleasePGO.vsprops: Added.
2836         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
2837         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
2838         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
2839         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
2840         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
2841         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
2842         * MiniBrowser/MiniBrowser.vcproj:
2843         * WebKitAPITest/WebKitAPITest.vcproj:
2844         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
2845         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
2846         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
2847         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
2848         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
2849         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
2850         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2851         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
2852         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
2853         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
2854         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
2855         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
2856         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
2857         * WebKitTestRunner/win/InjectedBundle.vcproj:
2858         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
2859         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
2860         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
2861         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
2862         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
2863         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
2864         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2865         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
2866         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
2867         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
2868         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
2869         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
2870         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
2871         * WinLauncher/WinLauncher.vcproj:
2872         * WinLauncher/WinLauncherDebug.vsprops: Added.
2873         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2874         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2875         * WinLauncher/WinLauncherRelease.vsprops: Added.
2876         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2877         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2878         * record-memory-win/record-memory-win.vcproj:
2879         * record-memory-win/record-memory-winDebug.vsprops: Added.
2880         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2881         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2882         * record-memory-win/record-memory-winRelease.vsprops: Added.
2883         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2884         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2885
2886 2011-03-29  Adam Barth  <abarth@webkit.org>
2887
2888         Reviewed by Darin Adler.
2889
2890         test_runner2.py can crash due to undefined variable
2891         https://bugs.webkit.org/show_bug.cgi?id=57356
2892
2893         Replace reference to undefined variable with a variable that's actually
2894         defined.  AFAICT, there's no way to test this code.
2895
2896         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2897
2898 2011-03-29  Tony Chang  <tony@chromium.org>
2899
2900         Reviewed by Eric Seidel.
2901
2902         cleanup rebaseline-chromium-webkit-tests
2903         https://bugs.webkit.org/show_bug.cgi?id=57375
2904
2905         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2906             - Split _extract_and_add_new_baselines into 3 functions
2907             - Reduce the amount of line wrapping (the file already has lines
2908               over 80 col, so may as well try to make the file consistent)
2909             - Remove unnecessary ()s
2910
2911 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
2912
2913         Reviewed by Adam Roben.
2914
2915         Make WinCairo a core builder.
2916         https://bugs.webkit.org/show_bug.cgi?id=57373
2917
2918         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2919         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2920
2921 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2922
2923         Update update-webkit-localizable-strings to understand that WebKit and
2924         WebKit2 strings go in WebCore.
2925
2926         Also make extract-localizable-strings optionally use an exclude file. No individual
2927         warnings are produced about unlocalized strings when there is no exclude file. This
2928         is needed for WebCore, since there are too many bare strings.
2929
2930         https://webkit.org/b/57354
2931
2932         Reviewed by Sam Weinig.
2933
2934         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2935         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2936
2937 2011-03-29  Darin Adler  <darin@apple.com>
2938
2939         Reviewed by Adam Roben.
2940
2941         WebKit2 bundle page needs to offer generated file hooks
2942         https://bugs.webkit.org/show_bug.cgi?id=57279
2943
2944         (Land missing part of the original patch after r82289.)
2945
2946         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2947         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2948
2949 2011-03-29  Tony Chang  <tony@chromium.org>
2950
2951         Reviewed by Ojan Vafai.
2952
2953         [chromium] NRWT should be able to read checksums from png comments
2954         https://bugs.webkit.org/show_bug.cgi?id=57280
2955
2956         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2957             from a file.
2958         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2959         * Scripts/webkitpy/common/system/filesystem_mock.py:
2960         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2961             if the -checksum.txt file doesn't exist, try looking in the png.
2962         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2963         * Scripts/webkitpy/layout_tests/port/test.py:
2964         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2965             2k for a png comment with the checksum
2966         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2967
2968 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2969
2970         Rubber-stamped by Gustavo Noronha Silva.
2971
2972         [GTK] http/tests/uri/username-with-no-hostname.html fails
2973         https://bugs.webkit.org/show_bug.cgi?id=57325
2974
2975         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2976         (willSendRequestCallback): URI host value check done case-insensitively.
2977
2978 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2979
2980         Reviewed by Martin Robinson.
2981
2982         [GTK] http/tests/uri/username-with-no-hostname.html fails
2983         https://bugs.webkit.org/show_bug.cgi?id=57325
2984
2985         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2986         (willSendRequestCallback): Check URI before submitting the request
2987         to WebCore.
2988
2989 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2990
2991         Reviewed by Ojan Vafai.
2992
2993         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2994         https://bugs.webkit.org/show_bug.cgi?id=57303
2995
2996         * DumpRenderTree/chromium/EventSender.cpp:
2997         (EventSender::doDragDrop):
2998         (EventSender::beginDragWithFiles):
2999
3000 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
3001
3002         Reviewed by Andreas Kling.
3003
3004         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
3005         https://bugs.webkit.org/show_bug.cgi?id=57314
3006
3007         Provide possibility to print loaded urls to the standard output.
3008
3009         * MiniBrowser/qt/BrowserWindow.cpp:
3010         (BrowserWindow::BrowserWindow):
3011         (BrowserWindow::printURL):
3012         * MiniBrowser/qt/BrowserWindow.h:
3013         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3014         (MiniBrowserApplication::handleUserOptions):
3015         * MiniBrowser/qt/MiniBrowserApplication.h:
3016         (WindowOptions::WindowOptions):
3017         * QtTestBrowser/launcherwindow.cpp:
3018         (LauncherWindow::initializeView):
3019         (LauncherWindow::printURL):
3020         (LauncherWindow::cloneWindow):
3021         * QtTestBrowser/launcherwindow.h:
3022         (WindowOptions::WindowOptions):
3023         * QtTestBrowser/main.cpp:
3024         (LauncherApplication::handleUserOptions):
3025
3026 2011-03-29  Gabor Loki  <loki@webkit.org>
3027
3028         Rubber-stamped by Csaba Osztrogonác.
3029
3030         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
3031         https://bugs.webkit.org/show_bug.cgi?id=56918
3032
3033         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
3034
3035 2011-03-28  Gabor Loki  <loki@webkit.org>
3036
3037         Reviewed by Csaba Osztrogonác.
3038
3039         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
3040         https://bugs.webkit.org/show_bug.cgi?id=56918
3041
3042         * Scripts/build-jsc:
3043         * Scripts/webkitdirs.pm:
3044
3045 2011-03-28  Andrew Foster  <andrewf@chromium.org>
3046
3047         Reviewed by Ojan Vafai.
3048
3049         webkit-patch should be more intelligent about whether a bug applies to a patch
3050         Create a new function, parse_bug_id_from_changelog() which determines
3051         that a bug is related to a patch by parsing the output generated from
3052         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
3053         the description of a patch.
3054         https://bugs.webkit.org/show_bug.cgi?id=56989
3055
3056         * Scripts/webkitpy/common/checkout/api.py:
3057         * Scripts/webkitpy/common/checkout/changelog.py:
3058         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3059         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3060         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3061         * Scripts/webkitpy/style/checkers/changelog.py:
3062         * Scripts/webkitpy/tool/commands/upload.py:
3063
3064 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
3065
3066         Revert accidentally commited change.
3067
3068         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3069         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3070
3071 2011-03-28  Tony Chang  <tony@chromium.org>
3072
3073         Reviewed by Adam Barth.
3074
3075         [chromium] have DRT write the png checksum into a png comment
3076         https://bugs.webkit.org/show_bug.cgi?id=57255
3077
3078         * DumpRenderTree/chromium/TestShell.cpp:
3079         (TestShell::dumpImage):
3080
3081 2011-03-28  Adele Peterson  <adele@apple.com>
3082
3083         Removing Qt stub, since it doesn't use the same header as the others.
3084
3085         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3086
3087 2011-03-28  Adele Peterson  <adele@apple.com>
3088
3089         Added a few more stubs.
3090
3091         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3092         (LayoutTestController::hasGrammarMarker):
3093         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3094         (LayoutTestController::hasGrammarMarker):
3095         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3096         (LayoutTestController::hasGrammarMarker):
3097
3098 2011-03-28  Adele Peterson  <adele@apple.com>
3099
3100         Build fix.
3101
3102         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3103         (LayoutTestController::hasGrammarMarker):
3104
3105 2011-03-28  Adele Peterson  <adele@apple.com>
3106
3107         Reviewed by Eric Seidel.
3108
3109         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
3110         https://bugs.webkit.org/show_bug.cgi?id=57173
3111
3112         * DumpRenderTree/LayoutTestController.cpp:
3113         (hasGrammarMarkerCallback): Added.
3114         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
3115         * DumpRenderTree/LayoutTestController.h:
3116         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
3117         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
3118
3119 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3120
3121         Reviewed by Benjamin Poulain.
3122
3123         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3124         https://bugs.webkit.org/show_bug.cgi?id=57087
3125
3126         Trivial typo fix after r82082.
3127
3128         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3129         (WTR::activateFonts):
3130
3131 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
3132
3133         Reviewed by Andreas Kling.
3134
3135         Add myself to the committers list.
3136
3137         * Scripts/webkitpy/common/config/committers.py:
3138
3139 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
3140
3141         Reviewed by Sam Weinig.
3142
3143         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
3144         to link against WebKit.framework for now.
3145
3146         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3147
3148 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
3149
3150         Reviewed by Andreas Kling.
3151
3152         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3153         https://bugs.webkit.org/show_bug.cgi?id=57087
3154
3155         Disable QT_ASCII_CAST_WARNINGS for applications.
3156
3157         * DumpRenderTree/qt/DumpRenderTree.pro:
3158         * DumpRenderTree/qt/ImageDiff.pro:
3159         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3160         * MiniBrowser/qt/MiniBrowser.pro:
3161         * QtTestBrowser/QtTestBrowser.pro:
3162         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3163
3164 2011-03-28  Andreas Kling  <kling@webkit.org>
3165
3166         Reviewed by Kenneth Rohde Christiansen.
3167
3168         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
3169         https://bugs.webkit.org/show_bug.cgi?id=57224
3170
3171         * QtTestBrowser/mainwindow.cpp:
3172         (MainWindow::buildUI):
3173         (MainWindow::onTitleChanged):
3174         * QtTestBrowser/mainwindow.h:
3175
3176 2011-03-27  Jer Noble  <jer.noble@apple.com>
3177
3178         Reviewed by Maciej Stachowiak.
3179
3180         Full Screen: disable keyboard access by default
3181         https://bugs.webkit.org/show_bug.cgi?id=56684
3182
3183         Accept the withKeyboard parameter to supportsFullScreenForElement.
3184
3185         * DumpRenderTree/mac/UIDelegate.mm:
3186         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
3187
3188 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
3189
3190         Reviewed by David Levin.
3191
3192         check-webkit-style should check ChangeLog for a valid bug number
3193         https://bugs.webkit.org/show_bug.cgi?id=57184
3194
3195         * Scripts/webkitpy/style/checker.py:
3196         * Scripts/webkitpy/style/checker_unittest.py:
3197         * Scripts/webkitpy/style/checkers/changelog.py: Added.
3198         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
3199
3200 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3201
3202         Reviewed by Andreas Kling.
3203
3204         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3205         https://bugs.webkit.org/show_bug.cgi?id=57087
3206
3207         Use explicit conversion for string to avoid depending on the default codec
3208         installed by the user code.
3209
3210         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3211         (WTR::activateFonts):
3212
3213 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
3214
3215         Revert inadvertantly committed changes.
3216
3217         * Scripts/old-run-webkit-tests:
3218         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3219
3220 2011-03-26  Andreas Kling  <kling@webkit.org>
3221
3222         Reviewed by Kenneth Rohde Christiansen.
3223
3224         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
3225         https://bugs.webkit.org/show_bug.cgi?id=57162
3226
3227         * QtTestBrowser/QtTestBrowser.qrc:
3228         * QtTestBrowser/favicon.png: Added.
3229         * QtTestBrowser/locationedit.cpp:
3230         (defaultPageIcon):
3231         (LocationEdit::LocationEdit):
3232         (LocationEdit::setPageIcon):
3233         (LocationEdit::resizeEvent):
3234         (LocationEdit::updateInternalGeometry):
3235         * QtTestBrowser/locationedit.h:
3236         * QtTestBrowser/mainwindow.cpp:
3237         (MainWindow::buildUI):
3238         (MainWindow::onIconChanged):
3239         (MainWindow::onLoadStarted):
3240         * QtTestBrowser/mainwindow.h:
3241
3242 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
3243
3244         Reviewed by Xan Lopez.
3245
3246         [GTK] Force DumpRenderTree to use 96 DPI
3247         https://bugs.webkit.org/show_bug.cgi?id=56866
3248
3249         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
3250         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
3251
3252         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3253         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
3254         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
3255         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
3256
3257 2011-03-25  Andy Estes  <aestes@apple.com>
3258
3259         Reviewed by Adele Peterson.
3260
3261         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3262         https://bugs.webkit.org/show_bug.cgi?id=49016
3263
3264         TestNetscapePlugIn needs to register support for an image MIME type so
3265         we can test that the embed tag prefers plug-ins to render image MIME
3266         types.
3267
3268         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
3269         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3270         (NP_GetMIMEDescription): Ditto.
3271         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
3272
3273 2011-03-25  Jessie Berlin  <jberlin@apple.com>
3274
3275         Reviewed by Sam Weinig.
3276
3277         WebKit2: Need to be able to set and get the Cookie Storage Policy.
3278         https://bugs.webkit.org/show_bug.cgi?id=50780
3279
3280         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
3281
3282         The test is named "CookieManager" so that we can eventually exercise more of the
3283         CookieManager functionality in the test.
3284
3285         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
3286         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3287         Assert that the policy returned is equal to the policy set in
3288         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
3289         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3290         Set the policy to something different than the user's policy and get the policy again.
3291         (TestWebKitAPI::didFinishLoadForFrame):
3292         Get the user's policy so that it can be restored at the end of the test.
3293         (TestWebKitAPI::TEST):
3294         Load about:blank so that the Web Process gets instatiated (needed to get the
3295         CookieManager).
3296
3297         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3298         Add CookieManager.cpp.
3299
3300 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
3301
3302         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
3303
3304         * wx/build/settings.py:
3305
3306 2011-03-24  Ilya Sherman  <isherman@chromium.org>
3307
3308         Reviewed by Adam Roben.
3309
3310         Implement layoutTestController.setAutoFilled in DRT on Windows
3311         https://bugs.webkit.org/show_bug.cgi?id=56828
3312
3313         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3314         (LayoutTestController::setAutofilled): Implemented.
3315
3316 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3317
3318         Unreviewed build correction.
3319
3320         Correct vsprops file for Debug variant of the CFLite build.
3321         Disable a CFNETWORK-specific test when building for CFLite.
3322
3323         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
3324         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3325
3326 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3327
3328         Reviewed by Adam Barth.
3329
3330         fix regressions introduced in 81908 - there were a couple of
3331         code paths that only fired under python 2.5 that I missed.
3332
3333         Also change a couple of 'python' references to sys.executable
3334         in order to handle runing test-webkitpy with a binary other than
3335         something called 'python'.
3336
3337         https://bugs.webkit.org/show_bug.cgi?id=57063
3338
3339         * Scripts/webkitpy/layout_tests/port/mac.py:
3340         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3341         * Scripts/webkitpy/test/cat.py:
3342         * Scripts/webkitpy/test/echo.py:
3343
3344 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3345
3346         Unreviewed build correction.
3347
3348         Add a stub implementation of the TestInvocation dumping logic.
3349         Update project files to reflect new file.
3350
3351         * WebKitTestRunner/cairo: Added.
3352         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
3353         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3354         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3355
3356 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3357
3358         Reviewed by Tony Chang.
3359
3360         new-run-webkit-tests: clean up worker model defaults. This
3361         changes the default behavior to 'threads' instead of
3362         'old-threads', and clarifies that chromium-win-* and
3363         chromium-mac-leopard are exceptions.
3364
3365         https://bugs.webkit.org/show_bug.cgi?id=56971
3366
3367         * Scripts/webkitpy/layout_tests/port/base.py:
3368         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3369         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3370         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3371         * Scripts/webkitpy/layout_tests/port/test.py:
3372         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3373
3374 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
3375
3376         Reviewed by Darin Adler.
3377
3378         Media Stream API: fix the order of the options in build-webkit.
3379         https://bugs.webkit.org/show_bug.cgi?id=56949
3380
3381         Fix the order of the options in build-webkit.
3382
3383         * Scripts/build-webkit:
3384
3385 2011-03-23  Adam Klein  <adamk@chromium.org>
3386
3387         Reviewed by Mihai Parparita.
3388
3389         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
3390         https://bugs.webkit.org/show_bug.cgi?id=56884
3391
3392         This option will be utilized by Chromium's ui_tests to allow
3393         referencing js-test-resources from a layout test over HTTP.
3394
3395         * Scripts/new-run-webkit-httpd:
3396         Added --layout_tests_dir option.
3397         * Scripts/webkitpy/layout_tests/port/http_server.py:
3398         Plumbed through as layout_tests_dir param.
3399
3400 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
3401
3402         Reviewed by Mihai Parparita.
3403
3404         new-run-webkit-tests: run tests in ascending alphabetical order per
3405         dir. This is a second attempt at the fix; the first attempt, in 
3406         r81597, broke the behavior on the old-inline and old-threads
3407         worker models.
3408
3409         https://bugs.webkit.org/show_bug.cgi?id=56760
3410
3411         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3412         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3413         * Scripts/webkitpy/layout_tests/port/test.py:
3414         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3415
3416 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
3417
3418         Reviewed by Martin Robinson.
3419
3420         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
3421         https://bugs.webkit.org/show_bug.cgi?id=56953
3422
3423         Print the string for the detail of 'property-change' signal.
3424
3425         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3426         (axObjectEventListener): Print the detail string.
3427
3428 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
3429
3430         Reviewed by Pavel Feldman.
3431
3432         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
3433         https://bugs.webkit.org/show_bug.cgi?id=56843
3434
3435         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3436         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3437
3438 2011-03-22  Eric Seidel  <eric@webkit.org>
3439
3440         Reviewed by Adam Barth.
3441
3442         Teach update-webkit about gyp
3443         https://bugs.webkit.org/show_bug.cgi?id=56881
3444
3445         This makes it possible for someone who builds from Xcode
3446         to just run update-webkit --gyp and have the project files
3447         generated after update automatically.
3448
3449         I also added a stand-alone "generate-project-files" script
3450         wrapping Source/gyp/configure.  This makes running gyp simpler
3451         since most people will not have gyp or Source/gyp in their path.
3452
3453         * Scripts/build-webkit:
3454         * Scripts/generate-project-files: Added.
3455         * Scripts/update-webkit:
3456
3457 2011-03-22  Anton D'Auria  <adauria@apple.com>
3458
3459         Reviewed by Alexey Proskuryakov.
3460
3461         Add +[WebApplicationCache getOriginsWithCache]
3462         https://bugs.webkit.org/show_bug.cgi?id=56722
3463
3464         * DumpRenderTree/LayoutTestController.cpp:
3465         (originsWithApplicationCacheCallback):
3466         (LayoutTestController::staticFunctions):
3467         * DumpRenderTree/LayoutTestController.h:
3468         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3469         (LayoutTestController::originsWithApplicationCache):
3470         * DumpRenderTree/chromium/LayoutTestController.h:
3471         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3472         (LayoutTestController::originsWithApplicationCache):
3473         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
3474         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
3475         (LayoutTestController::originsWithApplicationCache):
3476         (LayoutTestController::originsWithLocalStorage):
3477         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3478         (LayoutTestController::originsWithApplicationCache):
3479         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3480         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3481         (LayoutTestController::originsWithApplicationCache):
3482         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
3483         (LayoutTestController::originsWithApplicationCache):
3484
3485 2011-03-22  Eric Seidel  <eric@webkit.org>
3486
3487         Reviewed by Adam Barth.
3488
3489         Add support to build-webkit for building with gyp-generated project files
3490         https://bugs.webkit.org/show_bug.cgi?id=56877
3491
3492         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
3493         Eventually we'll want to support gyp-generated projects in a more general manner.
3494
3495         * Scripts/build-webkit:
3496
3497 2011-03-22  David Kilzer  <ddkilzer@apple.com>
3498
3499         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
3500
3501         Reviewed by Joseph Pecoraro.
3502
3503         * Scripts/build-webkit: Updated usage statement to include
3504         --dsym.
3505         * Scripts/webkitdirs.pm: Added $generateDsym variable.
3506         (generateDsym): Added. Call determineGenerateDsym() and
3507         return $generateDsym.
3508         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
3509         $generateDsym.
3510         (argumentsForXcode): Added.  Returns additional arguments for
3511         xcodebuild based on command-line switches.
3512         (XcodeOptions): Updated to include argumentsForXcode() in the
3513         array returned.
3514
3515 2011-03-22  Adam Roben  <aroben@apple.com>
3516
3517         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
3518
3519         These bots are consistently green again.
3520
3521         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
3522         core builders
3523
3524         Rubber-stamped by Antti Koivisto.
3525
3526         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3527         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
3528
3529         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3530         (BuildBotTest.test_builder_name_regexps): Updated expectations.
3531
3532 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3533
3534         Unreviewed, rolling out r81597.
3535         http://trac.webkit.org/changeset/81597
3536         https://bugs.webkit.org/show_bug.cgi?id=56801
3537
3538         Change results in lots of unexpected flaky on the dashboard.
3539         (Requested by pfeldman on #webkit).
3540
3541         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3542         * Scripts/webkitpy/layout_tests/port/test.py:
3543         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3544
3545 2011-03-21  Sam Weinig  <sam@webkit.org>
3546
3547         Fix failing tests on the WebKit2 bots.
3548
3549         * WebKitTestRunner/TestController.cpp:
3550         (WTR::TestController::resetStateToConsistentValues):
3551
3552 2011-03-21  Daniel Sievers  <sievers@google.com>
3553
3554         Reviewed by Simon Fraser.
3555
3556         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3557         https://bugs.webkit.org/show_bug.cgi?id=56139
3558
3559         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3560         (main):
3561         * DumpRenderTree/chromium/LayoutTestController.cpp:
3562         (LayoutTestController::LayoutTestController):
3563         (LayoutTestController::layerTreeAsText):
3564         * DumpRenderTree/chromium/LayoutTestController.h:
3565         (LayoutTestController::setShowDebugLayerTree):
3566         * DumpRenderTree/chromium/TestShell.cpp:
3567         (TestShell::runFileTest):
3568         (TestShell::dump):
3569         * DumpRenderTree/chromium/TestShell.h:
3570         (TestParams::TestParams):
3571
3572 2011-03-21  Adam Roben  <aroben@apple.com>
3573
3574         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
3575
3576         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3577         output as plain text
3578
3579         Reviewed by David Kilzer.
3580
3581         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3582         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3583         to the master.
3584         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3585         since we're running on the build master, not the slave. Instead, turn the raw source of
3586         actual.html which the build slave uploaded into an HTML log.
3587
3588 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
3589
3590         Reviewed by Mihai Parparita.
3591
3592         new-run-webkit-tests: run tests in ascending alphabetical order per dir
3593         https://bugs.webkit.org/show_bug.cgi?id=56760
3594
3595         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3596         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3597         * Scripts/webkitpy/layout_tests/port/test.py:
3598
3599 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3600
3601         Reviewed by Steve Block.
3602
3603         Media Stream API patch 0: adding compilation guards.
3604         https://bugs.webkit.org/show_bug.cgi?id=56458
3605
3606         Adding options to enable the media stream API feature in Chromium.
3607
3608         * Scripts/build-webkit:
3609
3610 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
3611
3612         Reviewed by Laszlo Gombos.
3613
3614         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3615         https://bugs.webkit.org/show_bug.cgi?id=56323
3616
3617         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
3618         "--stdout" or "--stderr" option.
3619
3620         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3621         (WebCore::DumpRenderTree::~DumpRenderTree):
3622         (WebCore::DumpRenderTree::processArgsLine):
3623         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3624         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3625         (WebCore::DumpRenderTree::setRedirectOutputFileName):
3626         (WebCore::DumpRenderTree::setRedirectErrorFileName):
3627         * DumpRenderTree/qt/main.cpp:
3628         (isOption):
3629         (takeOptionValue):
3630         (printUsage):
3631         (main):
3632
3633 2011-03-21  Adam Roben  <aroben@apple.com>
3634
3635         Fix exceptions on the buildbot due to my last change
3636
3637         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3638         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3639
3640 2011-03-21  Adam Roben  <aroben@apple.com>
3641
3642         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3643
3644         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3645         output as plain text
3646
3647         Reviewed by Darin Adler.
3648
3649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3650         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3651         logs.
3652         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3653         the build master. This will correctly treat it as HTML.
3654
3655 2011-03-20  Bill Budge  <bbudge@chromium.org>
3656
3657         Reviewed by Adam Barth.
3658
3659         Rename ThreadSafeShared to ThreadSafeRefCounted
3660         https://bugs.webkit.org/show_bug.cgi?id=56714
3661
3662         No new tests. Exposes no new functionality.
3663
3664         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3665         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3666         * Scripts/do-webcore-rename:
3667
3668 2011-03-19  Anton D'Auria  <adauria@apple.com>
3669
3670         Reviewed by Dan Bernstein.
3671
3672         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3673         https://bugs.webkit.org/show_bug.cgi?id=56719
3674
3675         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3676         (LayoutTestController::clearApplicationCacheForOrigin):
3677