Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2
3         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
4         https://bugs.webkit.org/show_bug.cgi?id=196948
5         <rdar://problem/49927131>
6
7         Reviewed by Tim Horton.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
10         (TEST):
11         The expected order of incoming events is
12         1. didInvalidateIntrinsicContentSize
13         2. didFirstLayout
14         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
15         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
16         (and remember, all we care about is ordering).
17
18 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
19
20         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
21         https://bugs.webkit.org/show_bug.cgi?id=197171
22         <rdar://problem/47454979>
23
24         Reviewed by Youenn Fablet.
25
26         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
28         (TestWebKitAPI::TEST):
29
30 2019-04-24  Brady Eidson  <beidson@apple.com>
31
32         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
33         https://bugs.webkit.org/show_bug.cgi?id=191362
34
35         Reviewed by Alex Christensen.
36
37         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
38           from an XHR to a custom protocol.
39
40 2019-04-24  John Wilander  <wilander@apple.com>
41
42         Age out unconverted Ad Click Attributions after one week.
43         https://bugs.webkit.org/show_bug.cgi?id=197238
44         <rdar://problem/50177349>
45
46         Reviewed by Chris Dumez.
47
48         This patch adds infrastructure to allow tests to expire all unconverted
49         attributions early.
50
51         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
52         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
53         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
54         * WebKitTestRunner/InjectedBundle/TestRunner.h:
55         * WebKitTestRunner/TestController.cpp:
56         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
57         * WebKitTestRunner/TestController.h:
58         * WebKitTestRunner/TestInvocation.cpp:
59         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
60
61 2019-04-24  Chris Dumez  <cdumez@apple.com>
62
63         Fix flaky crashes in a couple of PSON API tests
64         https://bugs.webkit.org/show_bug.cgi?id=197239
65
66         Reviewed by Tim Horton.
67
68         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
69
70         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
71
72 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
73
74         Make it possible to control the renderTreeAsText output by setting options on testRunner
75         https://bugs.webkit.org/show_bug.cgi?id=197133
76
77         Reviewed by Sam Weinig.
78
79         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
80         that make sense in testing (those that don't dump unstable data like addresses), and plumb
81         these flags through the various framework layers.
82
83         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
84
85         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
86         and hand-code DumpRenderTree bindings.
87
88         Some cleanup of the TestRunners, using member initializers.
89
90         * DumpRenderTree/TestRunner.cpp:
91         (TestRunner::TestRunner):
92         (setRenderTreeDumpOptionsCallback):
93         (TestRunner::staticFunctions):
94         (TestRunner::setRenderTreeDumpOptions):
95         * DumpRenderTree/TestRunner.h:
96         (TestRunner::renderTreeDumpOptions const):
97         * DumpRenderTree/mac/DumpRenderTree.mm:
98         (dump):
99         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
101         (WTR::InjectedBundlePage::dump):
102         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
103         (WTR::TestRunner::TestRunner):
104         (WTR::TestRunner::setRenderTreeDumpOptions):
105         * WebKitTestRunner/InjectedBundle/TestRunner.h:
106         (WTR::TestRunner::renderTreeDumpOptions const):
107
108 2019-04-24  Alex Christensen  <achristensen@webkit.org>
109
110         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
111         https://bugs.webkit.org/show_bug.cgi?id=197078
112         <rdar://problem/49564348>
113
114         Reviewed by Geoff Garen.
115
116         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
117         (TEST_F):
118         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
119         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
120         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
121
122 2019-04-24  Alex Christensen  <achristensen@webkit.org>
123
124         Add unit test for r239322
125         https://bugs.webkit.org/show_bug.cgi?id=197236
126
127         Reviewed by Chris Dumez.
128
129         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
130         May as well add the test infrastructure which was needed before and will be needed in the future.
131
132         * TestWebKitAPI/TCPServer.cpp:
133         (TestWebKitAPI::TCPServer::TCPServer):
134         * TestWebKitAPI/TCPServer.h:
135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
136         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
139         (TestWebKitAPI::downloadAtRate):
140         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
141         (TEST):
142         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
143         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
144         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
147         (TEST):
148
149 2019-04-24  Chris Dumez  <cdumez@apple.com>
150
151         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
152         https://bugs.webkit.org/show_bug.cgi?id=197214
153         <rdar://problem/49237544>
154
155         Reviewed by Alex Christensen.
156
157         Extend API test coverage.
158
159         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
160         (TEST):
161
162 2019-04-24  Philippe Normand  <pnormand@igalia.com>
163
164         [Build][GStreamer] Update to 1.16.0
165         https://bugs.webkit.org/show_bug.cgi?id=197157
166
167         Reviewed by Xabier Rodriguez-Calvar.
168
169         The upstreamed patches were removed and a new one was added for a
170         regression detected in the scaletempo GStreamer element. The GNOME
171         Flatpak was migrated to 3.32 and I switched a few modules to Meson
172         on the way, as it is the preferred build system now in GStreamer
173         1.16.
174
175         * flatpak/files/httpd-autogen.sh:
176         * flatpak/flatpakutils.py:
177         (FlatpakPackage.install):
178         (WebkitFlatpak.run_in_sandbox):
179         * flatpak/org.webkit.CommonModules.yaml:
180         * flatpak/org.webkit.WebKit.yaml:
181         * gstreamer/jhbuild.modules:
182         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
183         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
184         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
185         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
186         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
187         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
188         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
189         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
190         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
191         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
192         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
193         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
194         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
195         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
196         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
197         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
198         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
199         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
200         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
201         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
202         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
203         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
204
205 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
206
207         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
208         https://bugs.webkit.org/show_bug.cgi?id=197156
209
210         Reviewed by Michael Catanzaro.
211
212         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
213         support was added.
214
215         * MiniBrowser/gtk/BrowserTab.c:
216         (browser_tab_set_background_color): Set the passed in color as web view background color.
217         * MiniBrowser/gtk/BrowserTab.h:
218         * MiniBrowser/gtk/BrowserWindow.c:
219         (browser_window_init): Initialize backgroundColor.
220         (browser_window_append_view): Call browser_tab_set_background_color().
221         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
222         are added.
223         * MiniBrowser/gtk/main.c:
224         (main): Call browser_window_set_background_color() before creating the tabs.
225
226 2019-04-23  John Wilander  <wilander@apple.com>
227
228         Move Ad Click Attribution from internal feature to experimental feature
229         https://bugs.webkit.org/show_bug.cgi?id=197218
230         <rdar://problem/47651691>
231
232         Reviewed by Brent Fulgham.
233
234         * DumpRenderTree/TestOptions.cpp:
235         (TestOptions::TestOptions):
236
237 2019-04-23  Andy Estes  <aestes@apple.com>
238
239         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
240         https://bugs.webkit.org/show_bug.cgi?id=196749
241         <rdar://problem/35773454>
242
243         Reviewed by Daniel Bates.
244
245         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
248         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
249         (-[QuickLookDelegate webView:didFinishNavigation:]):
250         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
251         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
252         (runTest):
253         (runTestDecideBeforeLoading):
254         (runTestDecideAfterLoading):
255         (TEST):
256
257 2019-04-23  John Wilander  <wilander@apple.com>
258
259         Remove Ad Click Attribution data when removing website data
260         https://bugs.webkit.org/show_bug.cgi?id=197215
261         <rdar://problem/47668988>
262
263         Reviewed by Chris Dumez.
264
265         This patch adds test infrastructure to delete Ad Click Attribution data
266         through WebsiteDataStore::removeData().
267
268         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
270         (WTR::TestRunner::clearAdClickAttribution):
271         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
272         * WebKitTestRunner/InjectedBundle/TestRunner.h:
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
275         * WebKitTestRunner/TestController.h:
276         * WebKitTestRunner/TestInvocation.cpp:
277         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
278
279 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
280
281         webkitpy: Kill unresponsive worker processes
282         https://bugs.webkit.org/show_bug.cgi?id=197205
283         <rdar://problem/50104388>
284
285         Reviewed by Lucas Forschler.
286
287         * Scripts/webkitpy/common/message_pool.py:
288         (_MessagePool.__init__): Add close timeout.
289         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
290
291 2019-04-23  Alex Christensen  <achristensen@webkit.org>
292
293         Add unit tests for WKWebView.serverTrust
294         https://bugs.webkit.org/show_bug.cgi?id=197202
295
296         Reviewed by Youenn Fablet
297
298         * TestWebKitAPI/TCPServer.cpp:
299         (TestWebKitAPI::deleter<BIO>::operator()):
300         (TestWebKitAPI::deleter<SSL>::operator()):
301         (TestWebKitAPI::deleter<X509>::operator()):
302         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
303         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
304         (TestWebKitAPI::TCPServer::TCPServer):
305         (TestWebKitAPI::TCPServer::listenForConnections):
306         * TestWebKitAPI/TCPServer.h:
307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
309         (TestWebKitAPI::TEST):
310         (verifyCertificateAndPublicKey):
311         (-[ServerTrustDelegate webView:didFinishNavigation:]):
312         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
313         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
314         (TestWebKitAPI::downloadAtRate):
315         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
316         (TEST):
317         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
318         (TEST):
319
320 2019-04-23  Commit Queue  <commit-queue@webkit.org>
321
322         Unreviewed, rolling out r244556.
323         https://bugs.webkit.org/show_bug.cgi?id=197212
324
325         Causing build failures on multiple builders (Requested by
326         ShawnRoberts on #webkit).
327
328         Reverted changeset:
329
330         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
331         https://bugs.webkit.org/show_bug.cgi?id=197171
332         https://trac.webkit.org/changeset/244556
333
334 2019-04-23  Alex Christensen  <achristensen@webkit.org>
335
336         Fix iOS build.
337         https://bugs.webkit.org/show_bug.cgi?id=195537
338
339         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
340         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
341         AdoptWK constructor is private now.  Use adoptWK instead.
342
343 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
344
345         Accessibility text search and selection API enhancements.
346         https://bugs.webkit.org/show_bug.cgi?id=197095
347         <rdar://problem/48181791>
348
349         Reviewed by Chris Fleizach.
350
351         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
352
353         * DumpRenderTree/AccessibilityTextMarker.h:
354         * DumpRenderTree/AccessibilityUIElement.cpp:
355         (searchTextWithCriteriaCallback):
356         (AccessibilityUIElement::getJSClass):
357         * DumpRenderTree/AccessibilityUIElement.h:
358         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
359         (convertVectorToObjectArray):
360         (convertNSArrayToVector):
361         (searchTextParameterizedAttributeForCriteria):
362         (AccessibilityUIElement::getLinkedUIElements):
363         (AccessibilityUIElement::getDocumentLinks):
364         (AccessibilityUIElement::getChildren):
365         (AccessibilityUIElement::getChildrenWithRange):
366         (AccessibilityUIElement::rowHeaders const):
367         (AccessibilityUIElement::columnHeaders const):
368         (AccessibilityUIElement::uiElementArrayAttributeValue const):
369         (AccessibilityUIElement::searchTextWithCriteria):
370         (AccessibilityUIElement::attributesOfColumnHeaders):
371         (AccessibilityUIElement::attributesOfRowHeaders):
372         (AccessibilityUIElement::attributesOfColumns):
373         (AccessibilityUIElement::attributesOfRows):
374         (AccessibilityUIElement::attributesOfVisibleCells):
375         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
376         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
377         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
378         (WTR::convertVectorToObjectArray):
379         (WTR::convertNSArrayToVector):
380         (WTR::searchTextParameterizedAttributeForCriteria):
381         (WTR::AccessibilityUIElement::getLinkedUIElements):
382         (WTR::AccessibilityUIElement::getDocumentLinks):
383         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
384         (WTR::AccessibilityUIElement::getChildren):
385         (WTR::AccessibilityUIElement::getChildrenWithRange):
386         (WTR::AccessibilityUIElement::rowHeaders const):
387         (WTR::AccessibilityUIElement::columnHeaders const):
388         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
389         (WTR::AccessibilityUIElement::searchTextWithCriteria):
390         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
391         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
392         (WTR::AccessibilityUIElement::attributesOfColumns):
393         (WTR::AccessibilityUIElement::attributesOfRows):
394         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
395         (WTR::convertElementsToObjectArray): Deleted.
396
397 2019-04-23  Guy Lewin  <guy@lewin.co.il>
398
399         Multiple File Input Icon Set Regardless of File List
400         https://bugs.webkit.org/show_bug.cgi?id=195537
401
402         Reviewed by Alexey Proskuryakov.
403
404         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
405         display string in iOS file inputs
406
407         * DumpRenderTree/TestRunner.cpp:
408         (SetOpenPanelFilesMediaIconCallback):
409         (TestRunner::staticFunctions):
410         (TestRunner::setOpenPanelFilesMediaIcon):
411         * DumpRenderTree/TestRunner.h:
412         (TestRunner::openPanelFilesMediaIcon const):
413         * DumpRenderTree/mac/UIDelegate.mm:
414         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
415         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
416         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
417         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
419         * WebKitTestRunner/TestController.cpp:
420         (WTR::runOpenPanel):
421         (WTR::TestController::resetStateToConsistentValues):
422         * WebKitTestRunner/TestController.h:
423         (WTR::TestController::openPanelFileURLsMediaIcon const):
424         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
425         * WebKitTestRunner/TestInvocation.cpp:
426         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
427
428 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
429
430         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
431         https://bugs.webkit.org/show_bug.cgi?id=197171
432         <rdar://problem/47454979>
433
434         Reviewed by Youenn Fablet.
435
436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
437         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
438         (TestWebKitAPI::TEST):
439
440 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
441
442         [ews-build] Add unit tests for UnApplyPatchIfRequired
443         https://bugs.webkit.org/show_bug.cgi?id=197197
444
445         Reviewed by Lucas Forschler.
446
447         * BuildSlaveSupport/ews-build/steps_unittest.py:
448         (TestUnApplyPatchIfRequired):
449         (TestUnApplyPatchIfRequired.test_success):
450         (TestUnApplyPatchIfRequired.test_failure):
451         (TestUnApplyPatchIfRequired.test_skip):
452
453 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-build] Add unit tests for CleanWorkingDirectory
456         https://bugs.webkit.org/show_bug.cgi?id=197195
457
458         Reviewed by Lucas Forschler.
459
460         * BuildSlaveSupport/ews-build/steps_unittest.py:
461         (TestCleanWorkingDirectory):
462         (TestCleanWorkingDirectory.test_success):
463         (TestCleanWorkingDirectory.test_failure):
464
465 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
466
467         [ews-build] Use explicit imports instead of wildcard imports
468         https://bugs.webkit.org/show_bug.cgi?id=197194
469
470         Reviewed by Lucas Forschler.
471
472         * BuildSlaveSupport/ews-build/factories.py:
473         * BuildSlaveSupport/ews-build/loadConfig.py:
474         * BuildSlaveSupport/ews-build/steps_unittest.py:
475
476 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
477
478         [ews-build] Add unit tests for DownloadBuiltProduct
479         https://bugs.webkit.org/show_bug.cgi?id=197193
480
481         Reviewed by Lucas Forschler.
482
483         * BuildSlaveSupport/ews-build/steps_unittest.py:
484         (TestDownloadBuiltProduct):
485         (TestDownloadBuiltProduct.setUp):
486         (TestDownloadBuiltProduct.tearDown):
487         (TestDownloadBuiltProduct.test_success):
488         (TestDownloadBuiltProduct.test_failure):
489
490 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
491
492         [ews-app] Exception while loading status-bubble when no build step has started
493         https://bugs.webkit.org/show_bug.cgi?id=196676
494
495         Reviewed by Lucas Forschler.
496
497         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
498         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
499
500 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
501
502         [PlayStation] Support running of JSC tests on remote playstation devices
503         https://bugs.webkit.org/show_bug.cgi?id=197170
504
505         Reviewed by Ross Kirsling.
506
507         Script changes
508
509         * Scripts/run-javascriptcore-tests:
510         (runJSCStressTests): Pass arguments for playstation to
511         run-jsc-stress-tests
512         * Scripts/run-jsc-stress-tests:
513         Handle $hostOS=="playstation" for determineArchitecture, turning
514         off $isFTLPlatform and runProfiler and defaulting test writer.
515         * Scripts/webkitdirs.pm:
516         (jscPath): PlayStation WebKit executables have .elf extension
517         (executableProductDir): PlayStation builds on Windows hosts but
518         uses bin directory rather than bin64/bin32 for executable output
519         location.
520         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
521
522 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
523
524         [CMake][Win] Use target oriented design for WebKit
525         https://bugs.webkit.org/show_bug.cgi?id=197173
526
527         Reviewed by Alex Christensen.
528
529         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
530         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
531
532 2019-04-23  Chris Dumez  <cdumez@apple.com>
533
534         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
535         https://bugs.webkit.org/show_bug.cgi?id=197097
536         <rdar://problem/50048318>
537
538         Reviewed by Alex Christensen.
539
540         Add API test coverage.
541
542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
543         (-[PSONScheme webView:startURLSchemeTask:]):
544
545 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
546
547         [ATK] Implement AtkComponentIface scroll_to methods
548         https://bugs.webkit.org/show_bug.cgi?id=196856
549
550         Reviewed by Michael Catanzaro.
551
552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
553         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
554         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
555         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
556
557 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
558
559         [ews-build] Improve summary for UploadBuiltProduct step
560         https://bugs.webkit.org/show_bug.cgi?id=197182
561
562         Reviewed by Lucas Forschler.
563
564         * BuildSlaveSupport/ews-build/steps.py:
565         (UploadBuiltProduct): Added descriptionDone.
566         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
567         * BuildSlaveSupport/ews-build/steps_unittest.py:
568         (TestUploadBuiltProduct.test_success): Updated unit-test.
569         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
570
571 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
572
573         [ews-build] Trigger queues only after uploading the archive
574         https://bugs.webkit.org/show_bug.cgi?id=197180
575
576         Reviewed by Lucas Forschler.
577
578         * BuildSlaveSupport/ews-build/factories.py:
579         (Factory.__init__):
580         (BuildFactory.__init__): Remove trigger step from factories.
581         (BuildFactory.propertiesToPassToTriggers): Deleted.
582         * BuildSlaveSupport/ews-build/steps.py:
583         (ConfigureBuild.__init__): Confiure triggers property.
584         (Trigger): Step to trigger other queues.
585         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
586         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
587
588 2019-04-22  Alex Christensen  <achristensen@webkit.org>
589
590         Deprecate WKContextCreateWithInjectedBundlePath
591         https://bugs.webkit.org/show_bug.cgi?id=197169
592
593         Reviewed by Youenn Fablet.
594
595         * TestWebKitAPI/PlatformUtilities.cpp:
596         (TestWebKitAPI::Util::createContextWithInjectedBundle):
597         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
598
599 2019-04-22  Alex Christensen  <achristensen@webkit.org>
600
601         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
602         https://bugs.webkit.org/show_bug.cgi?id=197093
603         <rdar://problem/49708268>
604
605         Reviewed by Chris Dumez.
606
607         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
608         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
609         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
610         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
611         and one for loads without credentials, so there are two TCP connections to the same server in this test.
612
613         * TestWebKitAPI/TCPServer.cpp:
614         (TestWebKitAPI::TCPServer::TCPServer):
615         (TestWebKitAPI::TCPServer::~TCPServer):
616         (TestWebKitAPI::TCPServer::socketBindListen):
617         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
618         * TestWebKitAPI/TCPServer.h:
619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
620         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
621         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
622         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
623         (respondWithChallengeThenOK):
624         (TestWebKitAPI::TEST):
625         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
626         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
627         (TEST):
628
629 2019-04-22  Chris Dumez  <cdumez@apple.com>
630
631         Delayed WebProcessLaunch may break the _relatedWebView SPI
632         https://bugs.webkit.org/show_bug.cgi?id=197160
633
634         Reviewed by Alex Christensen.
635
636         Add API test coverage.
637
638         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
639
640 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
641
642         Use curl to download packages for webkitpy autoinstaller
643         https://bugs.webkit.org/show_bug.cgi?id=197164
644
645         Reviewed by Darin Adler.
646
647         * Scripts/webkitpy/common/system/autoinstall.py:
648         (AutoInstaller._download): Use curl(1) to download packages necessary for
649         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
650         errors which are not present when using curl(1).
651
652 2019-04-22  Chris Dumez  <cdumez@apple.com>
653
654         Unreviewed, rolling out r244502.
655
656         Caused crashes on the bots
657
658         Reverted changeset:
659
660         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
661         https://bugs.webkit.org/show_bug.cgi?id=197160
662         https://trac.webkit.org/changeset/244502
663
664 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
665
666         Unreviewed, rolling out r244437.
667
668         Still breaks internal tests.
669
670         Reverted changeset:
671
672         "InjectedBundle parameters often need initialization function
673         called before unarchiving"
674         https://bugs.webkit.org/show_bug.cgi?id=189709
675         https://trac.webkit.org/changeset/244437
676
677 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
678
679         [ews-build] Use singular verb in failure description in case of single api test failure
680         https://bugs.webkit.org/show_bug.cgi?id=197013
681
682         Reviewed by Lucas Forschler.
683
684         * BuildSlaveSupport/ews-build/steps.py:
685         (AnalyzeAPITestsResults.analyzeResults):
686
687 2019-04-22  Chris Dumez  <cdumez@apple.com>
688
689         Delayed WebProcessLaunch may break the _relatedWebView SPI
690         https://bugs.webkit.org/show_bug.cgi?id=197160
691
692         Reviewed by Alex Christensen.
693
694         Add API test coverage.
695
696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
697
698 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
699
700         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
701         https://bugs.webkit.org/show_bug.cgi?id=194630
702
703         Reviewed by Michael Catanzaro.
704
705         Return early from getAttributeSet() is passed in accessible is nullptr.
706
707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
708
709 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
710
711         Defer EditorState updates until the next layer tree flush in a few additional circumstances
712         https://bugs.webkit.org/show_bug.cgi?id=197145
713         <rdar://problem/50078170>
714
715         Reviewed by Darin Adler.
716
717         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
718         focus, or showing the font manager.
719
720         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
721         (TestWebKitAPI::TEST):
722         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
723         (TEST):
724         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
725         (TestWebKitAPI::TEST):
726
727 2019-04-21  Brian Burg  <bburg@apple.com>
728
729         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
730         https://bugs.webkit.org/show_bug.cgi?id=197125
731         <rdar://problem/50061468>
732
733         Reviewed by Darin Adler.
734
735         Sometimes I want to run wptserve independently of tests. Make it easier to script that
736         using this class rather than making our own ./wpt serve invocation.
737
738         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
739         (WebDriverW3CWebServer):
740         (WebDriverW3CWebServer.document_root): Expose this to clients.
741         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
742
743         (WebDriverW3CWebServer.__enter__):
744         (WebDriverW3CWebServer.__exit__):
745         Make it possible to use the web server with a 'with' statement.
746
747 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
748
749         [CMake][Win] Use target oriented design for WebKitLegacy
750         https://bugs.webkit.org/show_bug.cgi?id=197112
751
752         Reviewed by Konstantin Tokarev.
753
754         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
755
756         * DumpRenderTree/CMakeLists.txt:
757         * DumpRenderTree/PlatformWin.cmake:
758         * DumpRenderTree/win/EventSender.cpp:
759
760 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
761
762         Update text for old EWS submit button
763         https://bugs.webkit.org/show_bug.cgi?id=197140
764
765         Reviewed by Alexey Proskuryakov.
766
767         * QueueStatusServer/templates/statusbubble.html:
768
769 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
770
771         [ews-app] New EWS should poll bugzilla more frequently
772         https://bugs.webkit.org/show_bug.cgi?id=197138
773
774         Reviewed by Alexey Proskuryakov.
775
776         * BuildSlaveSupport/ews-app/ews/fetcher.py:
777         (FetchLoop.__init__):
778
779 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
780
781         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
782         https://bugs.webkit.org/show_bug.cgi?id=197139
783
784         Reviewed by Alexey Proskuryakov.
785
786         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
787         * QueueStatusServer/templates/statusbubble.html:
788
789 2019-04-20  Chris Dumez  <cdumez@apple.com>
790
791         Unreviewed, fix iOS build with recent SDKs.
792
793         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
794
795 2019-04-19  Keith Miller  <keith_miller@apple.com>
796
797         Add script to merge run_benchmark jsons
798         https://bugs.webkit.org/show_bug.cgi?id=197107
799
800         Reviewed by Michael Saboff.
801
802         The script basically recursively decends through all json objects until it gets
803         to an array or JSON primitive and concats or takes the first value, respectively.
804
805         This patch also adds +x bits to the compare-results script so it
806         can be run directly from the command line. I had to add a new line so that svn
807         will accept the change... yay svn!
808
809         * Scripts/compare-results:
810         * Scripts/merge-result-jsons: Added.
811         (readJSONFile):
812         (deepAppend):
813         (mergeJSONs):
814         (main):
815
816 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
817
818         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
819         https://bugs.webkit.org/show_bug.cgi?id=197079
820
821         Reviewed by Darin Adler.
822
823         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
824
825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
826         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
827
828 2019-04-18  Commit Queue  <commit-queue@webkit.org>
829
830         Unreviewed, rolling out r244434.
831         https://bugs.webkit.org/show_bug.cgi?id=197089
832
833         caused 1 API test failure (Requested by zalan on #webkit).
834
835         Reverted changeset:
836
837         "Regression (r244291): Broken API Test
838         AutoLayoutRenderingProgressRelativeOrdering"
839         https://bugs.webkit.org/show_bug.cgi?id=196948
840         https://trac.webkit.org/changeset/244434
841
842 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
843
844         Add new compatibility mode API on WKNavigation
845         https://bugs.webkit.org/show_bug.cgi?id=197069
846         <rdar://problem/50025800>
847
848         Reviewed by Tim Horton.
849
850         Add a block property for -didCommitNavigation to TestNavigationDelegate.
851
852         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
853         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
854         (-[TestNavigationDelegate webView:didCommitNavigation:]):
855
856 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
857
858         [CMake] Make WebCore headers copies
859         https://bugs.webkit.org/show_bug.cgi?id=182512
860         <rdar://problem/37510435>
861
862         Reviewed by Alex Christensen.
863
864         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
865         ports.
866
867         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
868         of WebCore headers using "*.h" were modified to <WebCore/*.h>
869
870         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
871         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
872         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
873         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
874         * TestWebKitAPI/CMakeLists.txt:
875         * TestWebKitAPI/PlatformWin.cmake:
876         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
877         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
878         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
879
880 2019-04-18  Jer Noble  <jer.noble@apple.com>
881
882         Add support for parsing FairPlayStreaming PSSH boxes.
883         https://bugs.webkit.org/show_bug.cgi?id=197064
884
885         Reviewed by Eric Carlson.
886
887         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
888         (TestWebKitAPI::TEST):
889
890 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
891
892         InjectedBundle parameters often need initialization function called before unarchiving
893         https://bugs.webkit.org/show_bug.cgi?id=189709
894         <rdar://problem/44573653>
895
896         Reviewed by Ryosuke Niwa.
897
898         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
899         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
900
901 2019-04-18  Zalan Bujtas  <zalan@apple.com>
902
903         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
904         https://bugs.webkit.org/show_bug.cgi?id=196948
905         <rdar://problem/49927131>
906
907         Reviewed by Tim Horton.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
910         (TEST): 
911         The expected order of incoming events is
912         1. didInvalidateIntrinsicContentSize
913         2. didFirstLayout
914         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
915         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
916         (and remember, all we care about is ordering).
917
918 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
919
920         Unreviewed, rolling out r244299.
921
922         Breaks internal tests.
923
924         Reverted changeset:
925
926         "InjectedBundle parameters often need initialization function
927         called before unarchiving"
928         https://bugs.webkit.org/show_bug.cgi?id=189709
929         https://trac.webkit.org/changeset/244299
930
931 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
932
933         [WTF] StringBuilder should set correct m_is8Bit flag when merging
934         https://bugs.webkit.org/show_bug.cgi?id=197053
935
936         Reviewed by Saam Barati.
937
938         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
939         (TestWebKitAPI::TEST):
940
941 2019-04-17  Tim Horton  <timothy_horton@apple.com>
942
943         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
944         https://bugs.webkit.org/show_bug.cgi?id=197028
945         <rdar://problem/49985290>
946
947         Reviewed by Wenson Hsieh.
948
949         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
950         (TEST):
951         Liberal application of waitForNextPresentationUpdate works around a race
952         where if the page rapidly changes its viewport arguments (or an API client
953         rapidly changes its viewport arguments), we'd get stuck thinking that the
954         user had intentionally zoomed the page, and stop resetting the initial scale.
955         This deserves a separate bug, but no need to keep the test failing while
956         we think about it.
957
958 2019-04-17  Tim Horton  <timothy_horton@apple.com>
959
960         REGRESSION (r241988): Switching tabs is slow
961         https://bugs.webkit.org/show_bug.cgi?id=197037
962         <rdar://problem/49951473>
963
964         Reviewed by Simon Fraser.
965
966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
967         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
968         (TEST):
969         * TestWebKitAPI/cocoa/TestWKWebView.h:
970         * TestWebKitAPI/cocoa/TestWKWebView.mm:
971         (-[TestWKWebView addToTestWindow]):
972         Add a test that hangs without this fix.
973
974 2019-04-17  Truitt Savell  <tsavell@apple.com>
975
976         Unreviewed, rolling out r244400.
977
978         Caused testing to exit early with assertionon Debug WK2
979
980         Reverted changeset:
981
982         "UI↔Web deadlock when printing with a JavaScript alert
983         visible"
984         https://bugs.webkit.org/show_bug.cgi?id=196839
985         https://trac.webkit.org/changeset/244400
986
987 2019-04-17  Brady Eidson  <beidson@apple.com>
988
989         Link clicks in PDFs shouldn't send referrer headers.
990         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
991
992         Reviewed by Tim Horton.
993
994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
995         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
996         (putPDFBytesCallback):
997         (emptyReleaseInfoCallback):
998         (createPDFWithLinkToURL):
999         (TEST):
1000
1001 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1002
1003         UI↔Web deadlock when printing with a JavaScript alert visible
1004         https://bugs.webkit.org/show_bug.cgi?id=196839
1005         <rdar://problem/49157642>
1006
1007         Reviewed by Andy Estes.
1008
1009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1010         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1011         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1012         (TEST):
1013
1014 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1015
1016         WKRetainPtr's adoption constructor should be private
1017         https://bugs.webkit.org/show_bug.cgi?id=197019
1018
1019         Reviewed by Tim Horton.
1020
1021         * DumpRenderTree/mac/DumpRenderTree.mm:
1022         (dumpFramesAsText):
1023         * TestWebKitAPI/InjectedBundleController.cpp:
1024         (TestWebKitAPI::InjectedBundleController::initialize):
1025         * TestWebKitAPI/PlatformUtilities.cpp:
1026         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1027         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1028         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1029         (TestWebKitAPI::Util::toWK):
1030         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1031         (TestWebKitAPI::TEST):
1032         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1033         (TestWebKitAPI::TEST):
1034         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1035         (TestWebKitAPI::TEST):
1036         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1037         (TestWebKitAPI::TEST):
1038         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1039         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1040         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1041         (TestWebKitAPI::TEST):
1042         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1043         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1044         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1045         (TestWebKitAPI::TEST):
1046         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1047         (TestWebKitAPI::TEST):
1048         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1049         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1050         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1051         (TestWebKitAPI::TEST):
1052         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1053         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1054         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1055         (TestWebKitAPI::TEST):
1056         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1057         (TestWebKitAPI::TEST):
1058         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1059         (TestWebKitAPI::TEST):
1060         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1061         (TestWebKitAPI::TEST):
1062         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1063         (TestWebKitAPI::TEST):
1064         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1065         (TestWebKitAPI::TEST):
1066         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1067         (TestWebKitAPI::TEST):
1068         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1069         (TestWebKitAPI::TEST):
1070         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1071         (TestWebKitAPI::TEST):
1072         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1073         (TestWebKitAPI::TEST):
1074         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1075         (TestWebKitAPI::TEST):
1076         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1077         (TestWebKitAPI::TEST):
1078         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1079         (TestWebKitAPI::TEST):
1080         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1081         (TestWebKitAPI::TEST):
1082         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1083         (TestWebKitAPI::TEST):
1084         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1085         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1086         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1089         (TestWebKitAPI::TEST):
1090         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1091         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1092         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1093         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1094         (TestWebKitAPI::TEST):
1095         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1096         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1097         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1098         (TestWebKitAPI::TEST):
1099         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1100         (TestWebKitAPI::TEST):
1101         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1102         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1103         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1104         (TestWebKitAPI::TEST):
1105         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1106         (TestWebKitAPI::loadAlternateHTMLString):
1107         (TestWebKitAPI::TEST):
1108         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1109         (TestWebKitAPI::TEST):
1110         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1111         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1112         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1113         (TestWebKitAPI::buildAndPerformTest):
1114         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1115         (TestWebKitAPI::TEST):
1116         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1117         (TestWebKitAPI::TEST):
1118         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1119         (TestWebKitAPI::TEST):
1120         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1121         (TestWebKitAPI::TEST):
1122         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1123         (TestWebKitAPI::TEST):
1124         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1125         (TestWebKitAPI::TEST):
1126         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1127         (TestWebKitAPI::TEST):
1128         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1129         (TestWebKitAPI::TEST):
1130         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1131         (TestWebKitAPI::TEST):
1132         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1133         (TestWebKitAPI::TEST):
1134         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1135         (TestWebKitAPI::TEST):
1136         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1137         (TestWebKitAPI::TEST):
1138         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1139         (TestWebKitAPI::TEST):
1140         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1141         (TestWebKitAPI::TEST):
1142         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1143         (TestWebKitAPI::TEST):
1144         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1145         (TestWebKitAPI::TEST):
1146         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1155         (TestWebKitAPI::TEST):
1156         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1159         (TestWebKitAPI::TEST):
1160         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1161         (TestWebKitAPI::TEST):
1162         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1163         (TestWebKitAPI::TEST):
1164         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1165         (TestWebKitAPI::TEST):
1166         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1167         (TestWebKitAPI::TEST):
1168         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1171         (TestWebKitAPI::TEST):
1172         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1173         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1174         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1175         (TestWebKitAPI::TEST):
1176         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1177         (TestWebKitAPI::TEST):
1178         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1179         (TestWebKitAPI::TEST):
1180         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1181         (TestWebKitAPI::TEST):
1182         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1183         (TestWebKitAPI::TEST):
1184         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1185         (TestWebKitAPI::TEST):
1186         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1187         (TestWebKitAPI::TEST):
1188         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1189         (TestWebKitAPI::TEST):
1190         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1191         (TestWebKitAPI::TEST):
1192         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1193         (TestWebKitAPI::TEST):
1194         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1196         (TEST):
1197         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1198         (TEST):
1199         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1200         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1201         (TEST):
1202         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1203         (TestWebKitAPI::TEST):
1204         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1205         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1206         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1207         (WTR::getMenuItemTitleCallback):
1208         (WTR::createMouseMessageBody):
1209         (WTR::EventSendingController::mouseDown):
1210         (WTR::EventSendingController::mouseUp):
1211         (WTR::EventSendingController::mouseMoveTo):
1212         (WTR::EventSendingController::mouseForceClick):
1213         (WTR::EventSendingController::startAndCancelMouseForceClick):
1214         (WTR::EventSendingController::mouseForceDown):
1215         (WTR::EventSendingController::mouseForceUp):
1216         (WTR::EventSendingController::mouseForceChanged):
1217         (WTR::EventSendingController::leapForward):
1218         (WTR::EventSendingController::scheduleAsynchronousClick):
1219         (WTR::createKeyDownMessageBody):
1220         (WTR::EventSendingController::keyDown):
1221         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1222         (WTR::EventSendingController::mouseScrollBy):
1223         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1224         (WTR::EventSendingController::continuousMouseScrollBy):
1225         (WTR::EventSendingController::addTouchPoint):
1226         (WTR::EventSendingController::updateTouchPoint):
1227         (WTR::EventSendingController::setTouchModifier):
1228         (WTR::EventSendingController::setTouchPointRadius):
1229         (WTR::EventSendingController::touchStart):
1230         (WTR::EventSendingController::touchMove):
1231         (WTR::EventSendingController::touchEnd):
1232         (WTR::EventSendingController::touchCancel):
1233         (WTR::EventSendingController::clearTouchPoints):
1234         (WTR::EventSendingController::releaseTouchPoint):
1235         (WTR::EventSendingController::cancelTouchPoint):
1236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1237         (WTR::InjectedBundle::didCreatePage):
1238         (WTR::InjectedBundle::didReceiveMessage):
1239         (WTR::InjectedBundle::didReceiveMessageToPage):
1240         (WTR::InjectedBundle::booleanForKey):
1241         (WTR::InjectedBundle::done):
1242         (WTR::InjectedBundle::dumpToStdErr):
1243         (WTR::InjectedBundle::outputText):
1244         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1245         (WTR::InjectedBundle::postAddChromeInputField):
1246         (WTR::InjectedBundle::postRemoveChromeInputField):
1247         (WTR::InjectedBundle::postFocusWebView):
1248         (WTR::InjectedBundle::postSetBackingScaleFactor):
1249         (WTR::InjectedBundle::postSetWindowIsKey):
1250         (WTR::InjectedBundle::postSetViewSize):
1251         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1252         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1253         (WTR::InjectedBundle::setGeolocationPermission):
1254         (WTR::InjectedBundle::setMockGeolocationPosition):
1255         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1256         (WTR::InjectedBundle::isGeolocationProviderActive const):
1257         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1258         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1259         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1260         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1261         (WTR::InjectedBundle::setCustomPolicyDelegate):
1262         (WTR::InjectedBundle::setHidden):
1263         (WTR::InjectedBundle::setCacheModel):
1264         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1265         (WTR::InjectedBundle::processWorkQueue):
1266         (WTR::InjectedBundle::queueBackNavigation):
1267         (WTR::InjectedBundle::queueForwardNavigation):
1268         (WTR::InjectedBundle::queueLoad):
1269         (WTR::InjectedBundle::queueLoadHTMLString):
1270         (WTR::InjectedBundle::queueReload):
1271         (WTR::InjectedBundle::queueLoadingScript):
1272         (WTR::InjectedBundle::queueNonLoadingScript):
1273         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1274         (WTR::frameToStr):
1275         (WTR::InjectedBundlePage::InjectedBundlePage):
1276         (WTR::dumpFrameDescriptionSuitableForTestResult):
1277         (WTR::dumpFrameScrollPosition):
1278         (WTR::dumpDescendantFrameScrollPositions):
1279         (WTR::dumpFrameText):
1280         (WTR::dumpDescendantFramesText):
1281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1282         (WTR::TestRunner::shouldDumpPixels const):
1283         (WTR::TestRunner::setDumpPixels):
1284         (WTR::TestRunner::whatToDump const):
1285         (WTR::TestRunner::setWhatToDump):
1286         (WTR::TestRunner::setWaitUntilDone):
1287         (WTR::TestRunner::shouldWaitUntilDone const):
1288         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1289         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1290         (WTR::TestRunner::clearAllDatabases):
1291         (WTR::TestRunner::setIDBPerOriginQuota):
1292         (WTR::TestRunner::originsWithApplicationCache):
1293         (WTR::TestRunner::setCanOpenWindows):
1294         (WTR::TestRunner::setXSSAuditorEnabled):
1295         (WTR::TestRunner::setMediaDevicesEnabled):
1296         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1297         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1298         (WTR::TestRunner::setCustomUserAgent):
1299         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1300         (WTR::TestRunner::setModernMediaControlsEnabled):
1301         (WTR::TestRunner::setWebGL2Enabled):
1302         (WTR::TestRunner::setWritableStreamAPIEnabled):
1303         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1304         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1305         (WTR::TestRunner::setAllowsAnySSLCertificate):
1306         (WTR::TestRunner::setPluginsEnabled):
1307         (WTR::TestRunner::setValueForUser):
1308         (WTR::TestRunner::setAudioResult):
1309         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1310         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1311         (WTR::TestRunner::setAlwaysAcceptCookies):
1312         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1313         (WTR::TestRunner::isDoingMediaCapture const):
1314         (WTR::TestRunner::queueLoad):
1315         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1316         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1317         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1318         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1319         (WTR::TestRunner::setAuthenticationUsername):
1320         (WTR::TestRunner::setAuthenticationPassword):
1321         (WTR::TestRunner::secureEventInputIsEnabled const):
1322         (WTR::TestRunner::setBlockAllPlugins):
1323         (WTR::TestRunner::setPluginSupportedMode):
1324         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1325         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1326         (WTR::TestRunner::setNavigationGesturesEnabled):
1327         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1328         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1329         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1330         (WTR::TestRunner::terminateNetworkProcess):
1331         (WTR::TestRunner::terminateServiceWorkerProcess):
1332         (WTR::TestRunner::runUIScript):
1333         (WTR::TestRunner::setStatisticsDebugMode):
1334         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1335         (WTR::TestRunner::setStatisticsLastSeen):
1336         (WTR::TestRunner::setStatisticsPrevalentResource):
1337         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1338         (WTR::TestRunner::dumpResourceLoadStatistics):
1339         (WTR::TestRunner::isStatisticsPrevalentResource):
1340         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1341         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1342         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1343         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1344         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1345         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1346         (WTR::TestRunner::setStatisticsGrandfathered):
1347         (WTR::TestRunner::isStatisticsGrandfathered):
1348         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1349         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1350         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1351         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1352         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1353         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1354         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1355         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1356         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1357         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1358         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1359         (WTR::TestRunner::statisticsSubmitTelemetry):
1360         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1361         (WTR::TestRunner::setStatisticsIsRunningTest):
1362         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1363         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1364         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1365         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1366         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1367         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1368         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1369         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1370         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1371         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1372         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1373         (WTR::TestRunner::statisticsResetToConsistentState):
1374         (WTR::TestRunner::setStorageAccessAPIEnabled):
1375         (WTR::TestRunner::getAllStorageAccessEntries):
1376         (WTR::TestRunner::addMockMediaDevice):
1377         (WTR::TestRunner::clearMockMediaDevices):
1378         (WTR::TestRunner::removeMockMediaDevice):
1379         (WTR::TestRunner::resetMockMediaDevices):
1380         (WTR::TestRunner::connectMockGamepad):
1381         (WTR::TestRunner::disconnectMockGamepad):
1382         (WTR::TestRunner::setMockGamepadDetails):
1383         (WTR::TestRunner::setMockGamepadAxisValue):
1384         (WTR::TestRunner::setMockGamepadButtonValue):
1385         (WTR::TestRunner::removeAllSessionCredentials):
1386         (WTR::TestRunner::clearDOMCache):
1387         (WTR::TestRunner::clearDOMCaches):
1388         (WTR::TestRunner::hasDOMCache):
1389         (WTR::TestRunner::domCacheSize):
1390         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1391         (WTR::TestRunner::getApplicationManifestThen):
1392         (WTR::TestRunner::injectUserScript):
1393         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1394         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1395         (WTR::TestRunner::addTestKeyToKeychain):
1396         (WTR::TestRunner::cleanUpKeychain):
1397         (WTR::TestRunner::keyExistsInKeychain):
1398         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1399         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1400         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1401         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1402         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1403         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1404         * WebKitTestRunner/TestController.cpp:
1405         (WTR::TestController::initialize):
1406         (WTR::parseStringTestHeaderValueAsRelativePath):
1407         (WTR::updateTestOptionsFromTestHeader):
1408         (WTR::TestController::runTest):
1409         (WTR::TestController::didReceiveLiveDocumentsList):
1410         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1411         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1412         (WTR::TestController::didFinishNavigation):
1413         (WTR::TestController::didReceiveAuthenticationChallenge):
1414         * WebKitTestRunner/TestInvocation.cpp:
1415         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1416         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1417         (WTR::TestInvocation::uiScriptDidComplete):
1418         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1419         * WebKitTestRunner/WebNotificationProvider.cpp:
1420         (WTR::WebNotificationProvider::closeWebNotification):
1421         * WebKitTestRunner/WorkQueueManager.cpp:
1422         (WTR::ScriptItem::ScriptItem):
1423         (WTR::WorkQueueManager::queueLoad):
1424         (WTR::WorkQueueManager::queueLoadHTMLString):
1425
1426 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1427
1428         Add a comment to make my test from r244139 less mysterious.
1429         https://bugs.webkit.org/show_bug.cgi?id=196744
1430
1431         As suggested by Darin Adler.
1432
1433         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1434         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1435
1436 2019-04-17  Chris Dumez  <cdumez@apple.com>
1437
1438         Remember device orientation permission for the duration of the browsing session
1439         https://bugs.webkit.org/show_bug.cgi?id=196992
1440         <rdar://problem/49946067>
1441
1442         Reviewed by Alex Christensen.
1443
1444         Add API test coverage.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1447         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1448         (TEST):
1449
1450 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1451
1452         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1453         https://bugs.webkit.org/show_bug.cgi?id=196675
1454
1455         Reviewed by Lucas Forschler.
1456
1457         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1458         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1459
1460 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1461
1462         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1463         https://bugs.webkit.org/show_bug.cgi?id=196919
1464         <rdar://problem/41630459>
1465
1466         Reviewed by Tim Horton.
1467
1468         Add iOS support for several new testing hooks. See below for more detail.
1469
1470         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1471         (WTR::UIScriptController::isDismissingMenu const):
1472
1473         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1474         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1475         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1476
1477         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1478         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1479         (WTR::UIScriptController::isDismissingMenu const):
1480         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1482         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1483         (WTR::InjectedBundle::didReceiveMessageToPage):
1484         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1485         (WTR::TestRunner::setAllowedMenuActions):
1486
1487         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1488         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1489         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1490         against the name of the custom action.
1491
1492         (WTR::TestRunner::installCustomMenuAction):
1493
1494         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1495         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1496         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1497         triggered.
1498
1499         (WTR::TestRunner::performCustomMenuAction):
1500
1501         Invoked when the custom menu action is triggered.
1502
1503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1504         * WebKitTestRunner/TestController.cpp:
1505         (WTR::TestController::installCustomMenuAction):
1506         (WTR::TestController::setAllowedMenuActions):
1507         * WebKitTestRunner/TestController.h:
1508         * WebKitTestRunner/TestInvocation.cpp:
1509         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1510         (WTR::TestInvocation::performCustomMenuAction):
1511
1512         Add plumbing to call back into the injected bundle when performing the custom action.
1513
1514         * WebKitTestRunner/TestInvocation.h:
1515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1516         (WTR::TestController::installCustomMenuAction):
1517         (WTR::TestController::setAllowedMenuActions):
1518         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1519         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1520         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1521         (-[TestRunnerWKWebView becomeFirstResponder]):
1522         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1523
1524         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1525         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1526         in the Mail app on iOS.
1527
1528         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1529         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1530         (-[TestRunnerWKWebView resetCustomMenuAction]):
1531         (-[TestRunnerWKWebView performCustomAction:]):
1532         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1533         (-[TestRunnerWKWebView _willHideMenu]):
1534         (-[TestRunnerWKWebView _didHideMenu]):
1535         * WebKitTestRunner/ios/TestControllerIOS.mm:
1536         (WTR::TestController::platformResetStateToConsistentValues):
1537
1538         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1539         if specified.
1540
1541         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1542         (WTR::UIScriptController::isDismissingMenu const):
1543
1544 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1545
1546         Allow sharing from imageSheet on an image document
1547         https://bugs.webkit.org/show_bug.cgi?id=196891
1548         <rdar://problem/25377386>
1549
1550         Reviewed by Tim Horton.
1551
1552         Test to make sure that the correct imageURL is extracted from an image element.
1553
1554         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1555         (TestWebKitAPI::TEST):
1556
1557 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1558
1559         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1560         https://bugs.webkit.org/show_bug.cgi?id=196995
1561
1562         Reviewed by Brady Eidson.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1565         (TEST):
1566
1567 2019-04-16  Chris Dumez  <cdumez@apple.com>
1568
1569         URL set by document.open() is not communicated to the UIProcess
1570         https://bugs.webkit.org/show_bug.cgi?id=196941
1571         <rdar://problem/49237544>
1572
1573         Reviewed by Geoff Garen.
1574
1575         Add API test coverage.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1579         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1580         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1581         (TEST):
1582
1583 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1584
1585         Unreviewed, rolling out r244321.
1586         https://bugs.webkit.org/show_bug.cgi?id=196968
1587
1588         Causing all WK2 Debug builds to exit early after Assertion
1589         failures. (Requested by ShawnRoberts on #webkit).
1590
1591         Reverted changeset:
1592
1593         "URL set by document.open() is not communicated to the
1594         UIProcess"
1595         https://bugs.webkit.org/show_bug.cgi?id=196941
1596         https://trac.webkit.org/changeset/244321
1597
1598 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1599
1600         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1601         https://bugs.webkit.org/show_bug.cgi?id=196948
1602
1603         Reviewed by Zalan Bujtas.
1604
1605         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1606         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1607
1608 2019-04-15  Chris Dumez  <cdumez@apple.com>
1609
1610         URL set by document.open() is not communicated to the UIProcess
1611         https://bugs.webkit.org/show_bug.cgi?id=196941
1612         <rdar://problem/49237544>
1613
1614         Reviewed by Geoffrey Garen.
1615
1616         Add API test coverage.
1617
1618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1619         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1620         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1621         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1622         (TEST):
1623
1624 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1625
1626         Using Tools/Scripts/clean-webkit should not install requests
1627         https://bugs.webkit.org/show_bug.cgi?id=196940
1628
1629         Reviewed by Lucas Forschler.
1630
1631         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1632         existing, depending on the path autoinstalled is run through.
1633         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1634         needed.
1635         (Port.configuration_for_upload):
1636         (Port.commits_for_upload):
1637
1638 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1639
1640         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1641         https://bugs.webkit.org/show_bug.cgi?id=196773
1642
1643         Reviewed by Jer Noble.
1644
1645         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1646         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1647         (TEST):
1648
1649 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1650
1651         ews-build should clearly indicate flaky test failures
1652         https://bugs.webkit.org/show_bug.cgi?id=196947
1653
1654         Reviewed by Lucas Forschler.
1655
1656         * BuildSlaveSupport/ews-build/steps.py:
1657         (AnalyzeAPITestsResults.analyzeResults):
1658
1659 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1660
1661         InjectedBundle parameters often need initialization function called before unarchiving
1662         https://bugs.webkit.org/show_bug.cgi?id=189709
1663         <rdar://problem/44573653>
1664
1665         Reviewed by Ryosuke Niwa.
1666
1667         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1668         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1669
1670 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1671
1672         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1673         https://bugs.webkit.org/show_bug.cgi?id=196681
1674
1675         Reviewed by Darin Adler.
1676
1677         Added tests.
1678
1679         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1680         (WTF_HashSet.RemoveIf):
1681         (WTF_HashSet.RemoveIfShrinkToBestSize):
1682
1683 2019-04-15  John Wilander  <wilander@apple.com>
1684
1685         Send delayed Ad Click Attribution conversion requests to the click source
1686         https://bugs.webkit.org/show_bug.cgi?id=196838
1687         <rdar://problem/47650157>
1688
1689         Reviewed by Chris Dumez and Youenn Fablet.
1690
1691         This patch adds test infrastructure to override the default behavior in
1692         WebKit::NetworkAdClickAttribution.
1693
1694         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1695         (TestWebKitAPI::TEST):
1696         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1697         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1698         (WTR::TestRunner::dumpAdClickAttribution):
1699         (WTR::TestRunner::clearAdClickAttribution):
1700         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1701         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1702         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1703         * WebKitTestRunner/TestController.cpp:
1704         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1705         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1706         * WebKitTestRunner/TestController.h:
1707         * WebKitTestRunner/TestInvocation.cpp:
1708         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1709
1710 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1711
1712         [ews-app] status-bubble should display position in queue
1713         https://bugs.webkit.org/show_bug.cgi?id=196607
1714
1715         Reviewed by Lucas Forschler.
1716
1717         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1718         (StatusBubble._build_bubble):
1719         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1720
1721 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1722
1723         [ews-build] Do not run clean build by default on EWS builders
1724         https://bugs.webkit.org/show_bug.cgi?id=196897
1725
1726         Reviewed by Lucas Forschler.
1727
1728         * BuildSlaveSupport/ews-build/steps.py:
1729         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1730         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1731         untracked directories like WebKitBuild).
1732         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1733         untracked files/directories (like WebKitBuild).
1734
1735 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1736
1737         TestRunner::notifyDone() should be safely reentrant
1738         https://bugs.webkit.org/show_bug.cgi?id=196898
1739
1740         Reviewed by Darin Adler.
1741
1742         It is currently possible that TestRunner::notifyDone() will call itself, since
1743         notifyDone() will force a repaint, which can start executing JavaScript, which
1744         may call notifyDone() again. This can lead to test failures and flakiness.
1745         Fix this by setting the m_waitToDump flag before calling the dump() method.
1746
1747         * DumpRenderTree/mac/TestRunnerMac.mm:
1748         (TestRunner::notifyDone):
1749         (TestRunner::forceImmediateCompletion):
1750         * DumpRenderTree/win/TestRunnerWin.cpp:
1751         (TestRunner::notifyDone):
1752         (TestRunner::forceImmediateCompletion):
1753
1754 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1755
1756         [GTK][WPE] Add enable-media websetting
1757         https://bugs.webkit.org/show_bug.cgi?id=196863
1758
1759         Reviewed by Michael Catanzaro.
1760
1761         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1762         (testWebKitSettings): Add test for the enable-media web-setting.
1763
1764 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1765
1766         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1767         https://bugs.webkit.org/show_bug.cgi?id=196905
1768         <rdar://problem/49886096>
1769
1770         Reviewed by Tim Horton.
1771
1772         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1773         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1774         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1775         delay timer, we end up with this sequence of events in the problematic (failure) case:
1776
1777         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1778             ...IPC from UI to web process...
1779         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1780             ...IPC from web to UI process...
1781         (c) [UI]    Invoke completion handler for script #1
1782         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1783             ...IPC from UI to web process...
1784         (e) [Web]   Evaluate script #2 in the web process
1785         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1786
1787         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1788         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1789         #2 is run in step (e).
1790
1791         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1792         the UI process by waiting on a script message posted by the web process, after attachment updates are
1793         dispatched.
1794
1795         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1796         (TestWebKitAPI::TEST):
1797
1798 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1799
1800         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1801         https://bugs.webkit.org/show_bug.cgi?id=196909
1802
1803         Reviewed by Wenson Hsieh.
1804
1805         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1806         (TestWebKitAPI::TEST):
1807
1808 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1809
1810         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1811         https://bugs.webkit.org/show_bug.cgi?id=196880
1812
1813         Reviewed by Yusuke Suzuki.
1814
1815         Add a new function for bytecode cache tests that does not forceDiskCache
1816         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1817         test added in this patch, since the code is invalid and therefore won't be
1818         cached. It should also be useful for tests that evaluate dynamically
1819         generated code.
1820
1821         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1822         * Scripts/run-jsc-stress-tests:
1823
1824 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1825
1826         Update AudioSession route sharing policy
1827         https://bugs.webkit.org/show_bug.cgi?id=196776
1828         <rdar://problem/46501611>
1829
1830         Reviewed by Jer Noble.
1831
1832         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1833         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1834         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1835         (TestWebKitAPI::TEST):
1836
1837 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1838
1839         [iOS] Software keyboard is shown too frequently on some websites
1840         https://bugs.webkit.org/show_bug.cgi?id=195856
1841         <rdar://problem/49191395>
1842
1843         Reviewed by Darin Adler.
1844
1845         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1846
1847         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1848         (WTR::UIScriptController::setHardwareKeyboardAttached):
1849         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1850         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1851         (WTR::UIScriptController::setHardwareKeyboardAttached):
1852         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1853         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1854
1855         Additionally link against GraphicsServices in WebKitTestRunner.
1856
1857         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1858         (WTR::TestController::platformResetStateToConsistentValues):
1859         (WTR::UIScriptController::setHardwareKeyboardAttached):
1860
1861 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1862
1863         [GTK][WPE] Fix pacman install-dependencies packages
1864         https://bugs.webkit.org/show_bug.cgi?id=196817
1865
1866         Reviewed by Žan Doberšek.
1867         
1868         python3-setuptools is called python-setuptools
1869         ruby-highline is only available on AUR
1870         libv4l-devel is incorporated in v4l-utils
1871
1872         * gtk/install-dependencies:
1873         * wpe/install-dependencies:
1874
1875 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1876
1877         [GTK] REGRESSION(r243860): Many tests failing
1878         https://bugs.webkit.org/show_bug.cgi?id=196791
1879
1880         Reviewed by Joanmarie Diggs.
1881
1882         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1883         multiple documents and check that accessibility hierarchy is updated after a navigation.
1884
1885         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1886         (loadChangedCallback):
1887         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1888         (AccessibilityTest::AccessibilityTest):
1889         (AccessibilityTest::~AccessibilityTest):
1890         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1891         (AccessibilityTest::findTestServerApplication):
1892         (AccessibilityTest::findDocumentWeb):
1893         (AccessibilityTest::findRootObject):
1894         (AccessibilityTest::waitUntilChildrenRemoved):
1895         (AccessibilityTest::ensureProxy):
1896         (testAtspiBasicHierarchy):
1897         (beforeAll):
1898         (afterAll):
1899
1900 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1901
1902         [ews-build] Handle bug titles with unicode characters
1903         https://bugs.webkit.org/show_bug.cgi?id=196802
1904
1905         Reviewed by Dewei Zhu.
1906
1907         * BuildSlaveSupport/ews-build/steps.py:
1908         (ValidatePatch._is_bug_closed):
1909
1910 2019-04-11  Michael Saboff  <msaboff@apple.com>
1911
1912         Improve the Inline Cache Stats code
1913         https://bugs.webkit.org/show_bug.cgi?id=196836
1914
1915         Reviewed by Saam Barati.
1916
1917         Added a new script to consolidate and arrange the output of --useICStats option.
1918
1919         This script merges the output from every group into one large table and sorts it from most common to
1920         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1921         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1922         Put together, this is useful to see what property accesses are not getting cached.
1923
1924         * Scripts/ic-stats.py: Added.
1925         (ICStats):
1926         (ICStats.__init__):
1927         (ICStats.parse):
1928         (ICStats.dumpStats):
1929         (usage):
1930
1931 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1932
1933         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1934         https://bugs.webkit.org/show_bug.cgi?id=196809
1935         <rdar://49800762>
1936
1937         Reviewed by Brady Eidson.
1938
1939         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1940         (TEST):
1941
1942 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1943
1944         requestAnimationFrame should execute before the next frame
1945         https://bugs.webkit.org/show_bug.cgi?id=177484
1946
1947         Reviewed by Simon Fraser.
1948
1949         Add trace points for the page RenderingUpdate.
1950
1951         * Tracing/SystemTracePoints.plist:
1952
1953 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1954
1955         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1956         https://bugs.webkit.org/show_bug.cgi?id=196760
1957
1958         Reviewed by Don Olmstead.
1959
1960         vswhere.exe has been bundled since Visual Studio 2017 version
1961         15.2. We shouldn't download vswhere.exe.
1962
1963         * Scripts/build-jsc: Do not call update-vswhere.py.
1964         * Scripts/build-webkit: Ditto.
1965         * Scripts/update-vswhere.py: Removed.
1966         * Scripts/webkitdirs.pm:
1967         (requireModulesForVSWhere): Deleted.
1968         (pickCurrentVisualStudioInstallation): Deleted.
1969         (visualStudioInstallDirVSWhere): Return the latest installed VS
1970         installation path by using the bundled vswhere.exe.
1971         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1972         (visualStudioInstallDirFallback): Removed.
1973
1974 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1975
1976         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1977         https://bugs.webkit.org/show_bug.cgi?id=196780
1978
1979         Reviewed by Alexey Proskuryakov.
1980
1981         * BuildSlaveSupport/ews-build/steps.py:
1982         * BuildSlaveSupport/ews-build/steps_unittest.py:
1983
1984 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1985
1986         Add SPI WKNavigationResponse._downloadAttribute
1987         https://bugs.webkit.org/show_bug.cgi?id=196755
1988         <rdar://49587365>
1989
1990         Reviewed by Brady Eidson.
1991
1992         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1993         (-[NavigationResponseTestDelegate navigationResponse]):
1994         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1995         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1996         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1997         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1998         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1999         (readRequest):
2000         (writeResponse):
2001         (TEST):
2002
2003 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2004
2005         Add modern API for overriding the page's specified viewport configuration
2006         https://bugs.webkit.org/show_bug.cgi?id=167734
2007         <rdar://problem/30331795>
2008
2009         Reviewed by Simon Fraser.
2010
2011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2012         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2013
2014 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2015
2016         Add support for incremental bytecode cache updates
2017         https://bugs.webkit.org/show_bug.cgi?id=195000
2018
2019         Reviewed by Filip Pizlo.
2020
2021         Exit when the initial run to generate bytecode fails.
2022
2023         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2024
2025 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2026
2027         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2028         https://bugs.webkit.org/show_bug.cgi?id=196744
2029         <rdar://49415309>
2030
2031         Reviewed by Chris Dumez.
2032
2033         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2034         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2035
2036 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2037
2038         Add a way to opt into modern compatibility mode in layout tests
2039         https://bugs.webkit.org/show_bug.cgi?id=196770
2040         <rdar://problem/49777550>
2041
2042         Reviewed by Antoine Quint.
2043
2044         Add a new test option to enable modern compatibility mode in layout tests.
2045
2046         * WebKitTestRunner/TestController.cpp:
2047         (WTR::updateTestOptionsFromTestHeader):
2048         * WebKitTestRunner/TestController.h:
2049         * WebKitTestRunner/TestOptions.h:
2050         (WTR::TestOptions::hasSameInitializationOptions const):
2051         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2052         (WTR::TestController::platformCreateWebView):
2053         (WTR::TestController::enableModernCompatibilityMode):
2054
2055 2019-04-10  Andy Estes  <aestes@apple.com>
2056
2057         Try to fix the 32-bit watchOS build.
2058
2059         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2060         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2061
2062 2019-04-10  Antoine Quint  <graouts@apple.com>
2063
2064         Enable Pointer Events on watchOS
2065         https://bugs.webkit.org/show_bug.cgi?id=196771
2066         <rdar://problem/49040909>
2067
2068         Reviewed by Dean Jackson.
2069
2070         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2071
2072 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2073
2074         Unreviewed. Fix WPE accessibility tests after r244059.
2075
2076         We are failing to load the injected bundle due to undefined symbol
2077         AccessibilityUIElement::replaceTextInRange().
2078
2079         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2080         (WTR::AccessibilityUIElement::replaceTextInRange):
2081
2082 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2083
2084         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2085         https://bugs.webkit.org/show_bug.cgi?id=196727
2086
2087         Reviewed by Fujii Hironori.
2088
2089         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2090         (WebKitBrowserWindow::create):
2091
2092 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2093
2094         [ews-build] Add unit tests for PrintConfiguration
2095         https://bugs.webkit.org/show_bug.cgi?id=196752
2096
2097         Reviewed by Dewei Zhu.
2098
2099         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2100
2101 2019-04-09  Keith Rollin  <krollin@apple.com>
2102
2103         Unreviewed build maintenance -- update .xcfilelists.
2104
2105         * DumpRenderTree/DerivedSources-input.xcfilelist:
2106         * DumpRenderTree/DerivedSources-output.xcfilelist:
2107
2108 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2109
2110         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2111         https://bugs.webkit.org/show_bug.cgi?id=196743
2112         <rdar://problem/43897551>
2113
2114         Reviewed by Tim Horton.
2115
2116         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2117         (TEST):
2118
2119 2019-04-09  Youenn Fablet  <youenn@apple.com>
2120
2121         Close service worker database on network process suspension
2122         https://bugs.webkit.org/show_bug.cgi?id=196623
2123         <rdar://problem/48930869>
2124
2125         Reviewed by Alex Christensen.
2126
2127         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2128
2129 2019-04-09  Daniel Bates  <dabates@apple.com>
2130
2131         [iPad] Should open popover when the spacebar is pressed
2132         https://bugs.webkit.org/show_bug.cgi?id=196360
2133         <rdar://problem/49389129>
2134
2135         Reviewed by Brent Fulgham.
2136
2137         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2138
2139         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2140         (WTR::UIScriptController::isShowingPopover const): Added.
2141         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2142         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2143         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2144         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2145         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2146         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2147         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2148         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2149         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2150         (WTR::UIScriptController::isShowingPopover const): Added.
2151         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2152         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2153         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2154         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2155         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2156         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2157         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2158         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2159         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2161         (WTR::UIScriptController::isShowingPopover const): Added.
2162         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2163         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2164
2165 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2166
2167         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2168         https://bugs.webkit.org/show_bug.cgi?id=196665
2169         <rdar://45115669>
2170
2171         Reviewed by Geoff Garen.
2172
2173         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2174         (goBack):
2175         (+[SimpleLookupContext sharedLookupContext]):
2176         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2177         (TEST):
2178         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2179         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2180
2181 2019-04-09  John Wilander  <wilander@apple.com>
2182
2183         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2184         https://bugs.webkit.org/show_bug.cgi?id=196558
2185         <rdar://problem/47650245>
2186
2187         Reviewed by Youenn Fablet.
2188
2189         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2190         (TestWebKitAPI::TEST):
2191             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2192
2193 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2194
2195         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2196         https://bugs.webkit.org/show_bug.cgi?id=196720
2197
2198         Reviewed by Konstantin Tokarev.
2199
2200         * TestWebKitAPI/PlatformMac.cmake:
2201
2202 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2203
2204         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2205         https://bugs.webkit.org/show_bug.cgi?id=196694
2206         <rdar://problem/48388734>
2207
2208         Rubber-stamped by Aakash Jain.
2209
2210         * Scripts/webkitpy/port/image_diff.py:
2211         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2212         * Scripts/webkitpy/port/server_process.py:
2213         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2214         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2215         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2216         * Scripts/webkitpy/port/server_process_mock.py:
2217         (MockServerProcess.has_available_stdout):
2218         * Scripts/webkitpy/port/server_process_unittest.py:
2219         (TestServerProcess.serial_test_basic):
2220
2221 2019-04-09  Jer Noble  <jer.noble@apple.com>
2222
2223         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2224         https://bugs.webkit.org/show_bug.cgi?id=196097
2225
2226         Reviewed by Eric Carlson.
2227
2228         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2229
2230         * DumpRenderTree/mac/DumpRenderTree.mm:
2231         (resetWebPreferencesToConsistentValues):
2232         * WebKitTestRunner/TestController.cpp:
2233         (WTR::TestController::resetPreferencesToConsistentValues):
2234
2235 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2236
2237         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2238         https://bugs.webkit.org/show_bug.cgi?id=196690
2239
2240         Reviewed by Michael Catanzaro.
2241
2242         * QueueStatusServer/config/queues.py:
2243         * Scripts/webkitpy/common/config/ews.json:
2244         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2245         (test_ews_name):
2246
2247 2019-04-09  Chris Dumez  <cdumez@apple.com>
2248
2249         Loads using loadHTMLString() cause flashing when process-swapping
2250         https://bugs.webkit.org/show_bug.cgi?id=196714
2251         <rdar://problem/49637354>
2252
2253         Reviewed by Antti Koivisto.
2254
2255         Add API test coverage.
2256
2257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2258
2259 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2260
2261         Unreviewed. Fix ATK accessibility tests after r244059.
2262
2263         We are failing to load the injected bundle due to undefined symbol
2264         AccessibilityUIElement::replaceTextInRange().
2265
2266         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2267         (WTR::AccessibilityUIElement::replaceTextInRange):
2268
2269 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2270
2271         AX: Support API: accessibilityReplaceRange:withText
2272         https://bugs.webkit.org/show_bug.cgi?id=196636
2273
2274         Unreviewed build fix for Windows port.
2275
2276         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2277         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2278
2279 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2280
2281         [CMake][WinCairo] Separate copied headers into different directories
2282         https://bugs.webkit.org/show_bug.cgi?id=196655
2283
2284         Reviewed by Michael Catanzaro.
2285
2286         * DumpRenderTree/CMakeLists.txt:
2287         * MiniBrowser/win/CMakeLists.txt:
2288         * TestWebKitAPI/CMakeLists.txt:
2289         * TestWebKitAPI/PlatformWin.cmake:
2290
2291 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2292
2293         Log stack-trace for run-webkit-tests when interrupted
2294         https://bugs.webkit.org/show_bug.cgi?id=176393
2295         <rdar://problem/34262310>
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2300         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2301         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2302         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2303         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2304         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2305         (main): Set handlers to log stack trace on interruption.
2306
2307 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2308
2309         AX: Support API: accessibilityReplaceRange:withText
2310         https://bugs.webkit.org/show_bug.cgi?id=196636
2311
2312         Unreviewed build fix for Windows port.
2313
2314         * DumpRenderTree/AccessibilityUIElement.cpp:
2315         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2316
2317 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [ews-build] Scripts using Buildbot API have CORS error
2320         https://bugs.webkit.org/show_bug.cgi?id=196709
2321
2322         Reviewed by Alexey Proskuryakov.
2323
2324         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2325
2326 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2327
2328         AX: Support API: accessibilityReplaceRange:withText
2329         https://bugs.webkit.org/show_bug.cgi?id=196636
2330
2331         Reviewed by Daniel Bates.
2332
2333         * DumpRenderTree/AccessibilityUIElement.cpp:
2334         (replaceTextInRangeCallback):
2335         (AccessibilityUIElement::replaceTextInRange):
2336         (AccessibilityUIElement::getJSClass):
2337         * DumpRenderTree/AccessibilityUIElement.h:
2338         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2339         (AccessibilityUIElement::replaceTextInRange):
2340         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2341         (AccessibilityUIElement::replaceTextInRange):
2342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2343         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2344         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2345         (WTR::AccessibilityUIElement::replaceTextInRange):
2346         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2347         (WTR::AccessibilityUIElement::replaceTextInRange):
2348
2349 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2350
2351         [iOS] Do not allow starting selection drags when selection views are not visible
2352         https://bugs.webkit.org/show_bug.cgi?id=196686
2353         <rdar://problem/49399192>
2354
2355         Reviewed by Tim Horton.
2356
2357         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2358         also add some new API tests to cover scenarios where the web view is not first responder.
2359
2360         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2361         (TestWebKitAPI::TEST):
2362         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2363
2364         Add a switch to optionally make the web view first responder when starting the simulated drag.
2365
2366         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2367         (-[DragAndDropSimulator initWithWebView:]):
2368         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2369
2370 2019-04-08  Justin Fan  <justin_fan@apple.com>
2371
2372         [Web GPU] Fix Web GPU experimental feature on iOS
2373         https://bugs.webkit.org/show_bug.cgi?id=196632
2374
2375         Reviewed by Myles C. Maxfield.
2376
2377         Properly make Web GPU available on iOS 11+.
2378
2379         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2380
2381 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2382
2383         [ews-build] Do not upload archive when Compile Fails
2384         https://bugs.webkit.org/show_bug.cgi?id=196674
2385
2386         Reviewed by Alexey Proskuryakov.
2387
2388         * BuildSlaveSupport/ews-build/factories.py:
2389         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2390         * BuildSlaveSupport/ews-build/steps.py:
2391         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2392         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2393         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2394
2395 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2396
2397         Enable DFG on MIPS
2398         https://bugs.webkit.org/show_bug.cgi?id=196689
2399
2400         Reviewed by Žan Doberšek.
2401
2402         Since the bytecode change, we enabled the baseline JIT on mips in
2403         r240432, but DFG is still missing. With this change, all tests are
2404         passing on a ci20 board.
2405
2406         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2407
2408 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2409
2410         [Flatpak] Second run update-webkitwpe-flatpak fails
2411         https://bugs.webkit.org/show_bug.cgi?id=192702
2412
2413         Reviewed by Carlos Garcia Campos.
2414
2415         * flatpak/flatpakutils.py:
2416         (FlatpakObject.flatpak): Fix typo.
2417         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2418         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2419
2420 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2421
2422         [GTK][WPE] outlook.live.com displays old-fashioned UI
2423         https://bugs.webkit.org/show_bug.cgi?id=196642
2424
2425         Reviewed by Carlos Garcia Campos.
2426
2427         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2428         (TestWebKitAPI::TEST): New Mac platform quirk test.
2429
2430 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2431
2432         Unreviewed, rolling out r243956.
2433         https://bugs.webkit.org/show_bug.cgi?id=196688
2434
2435         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2436         by aakashjain on #webkit).
2437
2438         Reverted changeset:
2439
2440         "Clicking "Go Back" from a safe browsing warning from an
2441         iframe should navigate the WKWebView back to the previous
2442         page"
2443         https://bugs.webkit.org/show_bug.cgi?id=196665
2444         https://trac.webkit.org/changeset/243956
2445
2446 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2447
2448         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2449         https://bugs.webkit.org/show_bug.cgi?id=196669
2450
2451         Reviewed by Geoffrey Garen.
2452
2453         Added three new unit tests for WeakHashSet.
2454
2455         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2456         (WTF_WeakPtr.WeakHashSetConstObjects):
2457         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2458         (WTF_WeakPtr.WeakHashSetComputeSize):
2459
2460 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2461
2462         Hide next and previous form control buttons when WKWebView is editable
2463         https://bugs.webkit.org/show_bug.cgi?id=196672
2464         <rdar://problem/35625321>
2465
2466         Reviewed by Tim Horton.
2467
2468         Add a new API test.
2469
2470         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2471         (-[TestWKWebView lastTrailingBarButtonGroup]):
2472         (TestWebKitAPI::TEST):
2473         * TestWebKitAPI/ios/UIKitSPI.h:
2474
2475 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2476
2477         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2478         https://bugs.webkit.org/show_bug.cgi?id=196077
2479         <rdar://problem/49108202>
2480
2481         Reviewed by Chris Dumez.
2482
2483         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2484         on new web view.
2485
2486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2487
2488 2019-04-05  Saam Barati  <sbarati@apple.com>
2489
2490         Make compare-results understand MotionMark
2491         https://bugs.webkit.org/show_bug.cgi?id=196666
2492
2493         Reviewed by Yusuke Suzuki.
2494
2495         * Scripts/compare-results:
2496         (PLT5Results):
2497         (detectMotionMark):
2498         (detectMotionMark1_1):
2499         (motionMarkResults):
2500         (motionMark1_1Results):
2501         (detectBenchmark):
2502         (biggerIsBetter):
2503         (main):
2504
2505 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2506
2507         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2508         https://bugs.webkit.org/show_bug.cgi?id=196665
2509         <rdar://45115669>
2510
2511         Reviewed by Geoff Garen.
2512
2513         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2514         (goBack):
2515         (+[SimpleLookupContext sharedLookupContext]):
2516         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2517         (TEST):
2518         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2519         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2520
2521 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2522
2523         [ews-build] Add configuration and architecture for windows builders
2524         https://bugs.webkit.org/show_bug.cgi?id=196660
2525
2526         Reviewed by Lucas Forschler.
2527
2528         * BuildSlaveSupport/ews-build/config.json:
2529
2530 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2531
2532         webkitpy: Don't run subsequent rounds if interrupted
2533         https://bugs.webkit.org/show_bug.cgi?id=196646
2534
2535         Reviewed by Aakash Jain.
2536
2537         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2538         (Manager.run): Bail out if interrupted.
2539
2540 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2541
2542         Test sessionStorage in PSON private browsing mode
2543         https://bugs.webkit.org/show_bug.cgi?id=196561
2544
2545         Reviewed by Alex Christensen.
2546
2547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2548
2549 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2550
2551         Unreviewed, rolling out r243833.
2552         https://bugs.webkit.org/show_bug.cgi?id=196645
2553
2554         This change breaks build of WPE and GTK ports (Requested by
2555         annulen on #webkit).
2556
2557         Reverted changeset:
2558
2559         "[CMake][WTF] Mirror XCode header directories"
2560         https://bugs.webkit.org/show_bug.cgi?id=191662
2561         https://trac.webkit.org/changeset/243833
2562
2563 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2564
2565         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2566         https://bugs.webkit.org/show_bug.cgi?id=196635
2567
2568         Reviewed by Antti Koivisto.
2569         
2570         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2571         for a test to enable async frame scrolling via:
2572             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2573         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2574         
2575         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2576
2577         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2578         (WTR::InjectedBundle::beginTesting):
2579         * WebKitTestRunner/TestController.cpp:
2580         (WTR::TestController::resetPreferencesToConsistentValues):
2581
2582 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2583
2584         Use a correct LC_RPATH when building with ASan
2585         https://bugs.webkit.org/show_bug.cgi?id=196576
2586
2587         Reviewed by David Kilzer.
2588
2589         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2590         so that ../Frameworks is checked. This is simpler and more reliable than updating
2591         each SPC service xcconfig.
2592
2593 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2594
2595         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2596         https://bugs.webkit.org/show_bug.cgi?id=196629
2597
2598         Reviewed by Lucas Forschler.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2601
2602 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2605         https://bugs.webkit.org/show_bug.cgi?id=196618
2606
2607         Reviewed by Lucas Forschler.
2608
2609         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2610         (StatusBubble): Added QUEUE_TRIGGERS.
2611         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2612         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2613         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2614         its parent(builder).
2615
2616 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2617
2618         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2619         https://bugs.webkit.org/show_bug.cgi?id=196625
2620
2621         Reviewed by Lucas Forschler.
2622
2623         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2624         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2625
2626 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2627
2628         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2629         https://bugs.webkit.org/show_bug.cgi?id=196630
2630
2631         Reviewed by Wenson Hsieh.
2632
2633         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2634
2635 2019-04-04  Youenn Fablet  <youenn@apple.com>
2636
2637         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2638         https://bugs.webkit.org/show_bug.cgi?id=196543
2639
2640         Reviewed by Alex Christensen.
2641
2642         * WebKitTestRunner/TestController.cpp:
2643         (WTR::TestController::generatePageConfiguration):
2644
2645 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2646
2647         [ews-app] Status bubble should not display skipped buildbot steps
2648         https://bugs.webkit.org/show_bug.cgi?id=196584
2649
2650         Reviewed by Lucas Forschler.
2651
2652         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2653
2654 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2655
2656         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2657         https://bugs.webkit.org/show_bug.cgi?id=196620
2658
2659         Reviewed by Lucas Forschler.
2660
2661         * BuildSlaveSupport/ews-app/ews/config.py:
2662
2663 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2664
2665         [Win] DumpRenderTreeWatchDog.py is not checked into source
2666         https://bugs.webkit.org/show_bug.cgi?id=196567
2667         <rdar://problem/49525901>
2668
2669         Reviewed by Lucas Forschler.
2670
2671         This script is used on Win EWS bots to terminate hanging DRT processes.
2672
2673         * EWSTools/dumprendertreewatchdog.py: Added.
2674
2675 2019-04-04  Chris Dumez  <cdumez@apple.com>
2676
2677         Unreviewed, roll out r243858 which made tests time out.
2678
2679         Disable new API tests on Windows instead.
2680
2681         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2682         (TestWebKitAPI::TEST):
2683
2684 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2685
2686         [ATK] Cleanup WebPageAccessibilityObjectAtk
2687         https://bugs.webkit.org/show_bug.cgi?id=196537
2688
2689         Reviewed by Michael Catanzaro.
2690
2691         Also consider files under atk directories as exceptions for GObject conventions.
2692
2693         * Scripts/webkitpy/style/checkers/cpp.py:
2694         (check_identifier_name_in_declaration):
2695
2696 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2697
2698         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2699         https://bugs.webkit.org/show_bug.cgi?id=196588
2700         <rdar://problem/49365787>
2701
2702         Unreviewed build fix for Windows port.
2703
2704         error C3861: 'kill': identifier not found
2705
2706         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2707         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2708
2709 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2710
2711         [ews-build] Cancel build and similar operations should have authentication
2712         https://bugs.webkit.org/show_bug.cgi?id=196520
2713
2714         Reviewed by Dewei Zhu.
2715
2716         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2717         environment variables.
2718
2719 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2720
2721         [ews-build] Do not trigger queues which are not in production yet
2722         https://bugs.webkit.org/show_bug.cgi?id=196581
2723
2724         Reviewed by Dewei Zhu.
2725
2726         * BuildSlaveSupport/ews-build/config.json:
2727
2728 2019-04-03  Chris Dumez  <cdumez@apple.com>
2729
2730         Unreviewed, fix typo in the name of API test added in r243848.
2731
2732         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2733         (TestWebKitAPI::TEST):
2734
2735 2019-04-03  Chris Dumez  <cdumez@apple.com>
2736
2737         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2738         https://bugs.webkit.org/show_bug.cgi?id=196588
2739         <rdar://problem/49365787>
2740
2741         Reviewed by Ryosuke Niwa.
2742
2743         Add API test coverage.
2744
2745         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2746         (TestWebKitAPI::nullJavaScriptCallback):
2747         (TestWebKitAPI::didCrashCheckFrames):
2748         (TestWebKitAPI::TEST):
2749
2750 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2751
2752         run-webkit-tests: Upload test results (new results database)
2753         https://bugs.webkit.org/show_bug.cgi?id=196577
2754         <rdar://problem/34841155>
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2759         (Manager.run): Upload results after each device shard, since the configuration will be
2760         different for each device.
2761         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2762         uploaded to a results database.
2763         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2764         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2765
2766 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2767
2768         -apple-trailing-word is needed for browser detection
2769         https://bugs.webkit.org/show_bug.cgi?id=196575
2770
2771         Unreviewed.
2772
2773         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2774
2775 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2776
2777         [CMake][WTF] Mirror XCode header directories
2778         https://bugs.webkit.org/show_bug.cgi?id=191662
2779
2780         Reviewed by Konstantin Tokarev.
2781
2782         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2783         builds.
2784
2785         * CMakeLists.txt:
2786         * DumpRenderTree/CMakeLists.txt:
2787         * DumpRenderTree/PlatformWin.cmake:
2788         * MiniBrowser/win/CMakeLists.txt:
2789         * TestWebKitAPI/CMakeLists.txt:
2790         * TestWebKitAPI/PlatformWin.cmake:
2791         * WebKitTestRunner/PlatformGTK.cmake:
2792         * WebKitTestRunner/PlatformWin.cmake:
2793
2794 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2795
2796         [ews-app] Status bubble should not display certain infrastructure status messages
2797         https://bugs.webkit.org/show_bug.cgi?id=196550
2798
2799         Reviewed by Lucas Forschler.
2800
2801         Do not display the steps which are un-needed for end-user. This information is still avaiable
2802         if the user click on the bubble and look at the Buildbot build.
2803         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2804         (StatusBubble._steps_messages):
2805         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2806
2807 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2808
2809         [ews-build] Use https for sending data to ews-app
2810         https://bugs.webkit.org/show_bug.cgi?id=196492
2811
2812         Reviewed by Lucas Forschler.
2813
2814         * BuildSlaveSupport/ews-build/events.py:
2815
2816 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2817
2818         Remove support for -apple-trailing-word
2819         https://bugs.webkit.org/show_bug.cgi?id=196525
2820
2821         Reviewed by Zalan Bujtas.
2822
2823         This CSS property is nonstandard and not used.
2824
2825         * Scripts/webkitperl/FeatureList.pm:
2826         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2827
2828 2019-04-03  Youenn Fablet  <youenn@apple.com>
2829
2830         Add a test for DOMCache on multiple browsing in case of private browsing
2831         https://bugs.webkit.org/show_bug.cgi?id=196524
2832
2833         Reviewed by Alex Christensen.
2834
2835         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2836         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2837
2838 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2839
2840         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2841         https://bugs.webkit.org/show_bug.cgi?id=196540
2842
2843         Reviewed by Aakash Jain.
2844
2845         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2846
2847 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2848
2849         Add plumbing for a compatibility mode preference in WebKit
2850         https://bugs.webkit.org/show_bug.cgi?id=196005
2851
2852         Reviewed by Tim Horton.
2853
2854         Add new API tests.
2855
2856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2857         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2858
2859 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2860
2861         [WPE][GTK] Update libsrtp dependency package for Debian
2862         https://bugs.webkit.org/show_bug.cgi?id=196528
2863
2864         Reviewed by Frédéric Wang.
2865
2866         * gtk/install-dependencies:
2867         * wpe/install-dependencies:
2868
2869 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2870
2871         [WK2] Add support for Window's beforeprint / afterprint events
2872         https://bugs.webkit.org/show_bug.cgi?id=196478
2873         <rdar://problem/49535124>
2874
2875         Unreviewed build fix for MSVC.
2876
2877         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2878
2879         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2880
2881         * WebKitTestRunner/TestController.cpp:
2882         (WTR::printFrame): Use int and float literals.
2883
2884 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2885
2886         [ews-build] Reassign bots to queues
2887
2888         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2889
2890 2019-04-02  Chris Dumez  <cdumez@apple.com>
2891
2892         [WK2] Add support for Window's beforeprint / afterprint events
2893         https://bugs.webkit.org/show_bug.cgi?id=196478
2894
2895         Reviewed by Alex Christensen.
2896
2897         Add minimal implementation for printFrame in WebKitTestRunner.
2898
2899         * WebKitTestRunner/TestController.cpp:
2900         (WTR::printFrame):
2901         (WTR::TestController::createOtherPage):
2902         (WTR::TestController::createWebViewWithOptions):
2903
2904 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2905
2906         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2907         https://bugs.webkit.org/show_bug.cgi?id=196491
2908
2909         Reviewed by Lucas Forschler.
2910
2911         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2912
2913 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2914
2915         [ews-build] Configure buildbot try credentials in environment variables
2916         https://bugs.webkit.org/show_bug.cgi?id=196501
2917
2918         Reviewed by Lucas Forschler.
2919
2920         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2921         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2922         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2923
2924 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2925
2926         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2927         https://bugs.webkit.org/show_bug.cgi?id=196496
2928         <rdar://problem/49521634>
2929
2930         Reviewed by Chris Dumez.
2931
2932         Add new API tests (see WebKit ChangeLog for more detail).
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2935         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2936         (TEST):
2937
2938 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2939
2940         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2941         <https://webkit.org/b/196499>
2942
2943         Reviewed by Alexey Proskuryakov.
2944
2945         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2946         ENABLE_ADDRESS_SANITIZER.
2947
2948 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2949
2950         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2951         https://bugs.webkit.org/show_bug.cgi?id=182757
2952
2953         Reviewed by Don Olmstead.
2954
2955         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2956         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2957
2958 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2959
2960         run-api-tests: Upload test results
2961         https://bugs.webkit.org/show_bug.cgi?id=196323
2962         <rdar://problem/49356714>
2963
2964         Reviewed by Lucas Forschler.
2965
2966         * Scripts/webkitpy/api_tests/manager.py:
2967         (Manager):
2968         (Manager.run): Upload results to a results database.
2969         * Scripts/webkitpy/api_tests/run_api_tests.py:
2970         (parse_args): Add upload arguments.
2971         * Scripts/webkitpy/port/base.py:
2972         (Port):
2973         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2974         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2975         with commits from any other associated repositories.
2976         * Scripts/webkitpy/port/device.py:
2977         (Device):
2978         (Device.build_version): Access build_versoin of underlying platform device.
2979         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2980         (IOSSimulatorTest):
2981         (IOSSimulatorTest.test_configuration_for_upload):
2982         * Scripts/webkitpy/port/device_port.py:
2983         (DevicePort):
2984         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2985         the same as the machine uploading results.
2986         * Scripts/webkitpy/port/mac.py:
2987         (MacPort):
2988         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2989         * Scripts/webkitpy/port/mac_unittest.py:
2990         (MacTest):
2991         (MacTest.test_configuration_for_upload):
2992         * Scripts/webkitpy/xcode/simulated_device.py:
2993         (SimulatedDeviceManager._create_device_with_runtime):
2994         (SimulatedDevice.__init__): Create simulated device with a build_version.
2995         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2996         (test_existing_simulator):
2997
2998 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2999
3000         Remove extra newline characters (Follow-up fix to r243707)
3001
3002         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3003
3004 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3005
3006         [ews-app] Use API_KEY to accept results data
3007         https://bugs.webkit.org/show_bug.cgi?id=196461
3008
3009         Reviewed by Dewei Zhu.
3010
3011         * BuildSlaveSupport/ews-app/ews/views/results.py:
3012         (Results.post): Validate EWS_API_KEY before accepting any data.
3013         * BuildSlaveSupport/ews-build/events.py:
3014         (Events.sendData): Send EWS_API_KEY if available along with event data.
3015
3016 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3017
3018         Unable to copy and paste a PDF from Notes into Mail compose body
3019         https://bugs.webkit.org/show_bug.cgi?id=196442
3020         <rdar://problem/48573098>
3021
3022         Reviewed by Tim Horton.
3023
3024         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3025         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3026         to be specified on the item providers.
3027
3028         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3029         (TestWebKitAPI::mapItemForTesting):
3030         (TestWebKitAPI::contactItemForTesting):
3031
3032 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3033
3034         Make UIWKDocumentContext rects per-character instead of per-word
3035         https://bugs.webkit.org/show_bug.cgi?id=196459
3036
3037         Reviewed by Wenson Hsieh.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3040         (TEST):
3041         Adjust test results due to switching to per-character rects.
3042
3043 2019-04-01  Chris Dumez  <cdumez@apple.com>
3044
3045         UIProcess crash when a prewarmed process is terminated
3046         https://bugs.webkit.org/show_bug.cgi?id=196451
3047         <rdar://problem/49245471>
3048
3049         Reviewed by Geoffrey Garen.
3050
3051         Add API test coverage.
3052
3053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3054         (TEST):
3055
3056 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3057
3058         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3059         https://bugs.webkit.org/show_bug.cgi?id=196449
3060
3061         Reviewed by Lucas Forschler.
3062
3063         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3064         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3065         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3066         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3067
3068 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3071         https://bugs.webkit.org/show_bug.cgi?id=196444
3072
3073         Reviewed by Lucas Forschler.
3074
3075         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3076
3077 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3078
3079         Add SPI to canonicalize NSURLs with WTF::URL
3080         https://bugs.webkit.org/show_bug.cgi?id=196415
3081         <rdar://problem/44980271>
3082
3083         Reviewed by Darin Adler.
3084
3085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3086         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3087         (TestWebKitAPI::TEST):
3088
3089 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3090
3091         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3092         https://bugs.webkit.org/show_bug.cgi?id=196441
3093
3094         Reviewed by Carlos Garcia Campos.
3095
3096         Don't cache the wpe_view_backend object that might not exist yet at the
3097         time of EventSenderProxy constructor invocation, but instead retrieve
3098         that object whenever it's required for event dispatching. This should
3099         avoid crashes in this constructor now that it's invoked before any
3100         PlatformWindow has been set up (as changed in r243496).
3101
3102         * WebKitTestRunner/EventSenderProxy.h:
3103         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3104         (WTR::viewBackend):
3105         (WTR::EventSenderProxy::EventSenderProxy):
3106         (WTR::EventSenderProxy::mouseDown):
3107         (WTR::EventSenderProxy::mouseUp):
3108         (WTR::EventSenderProxy::mouseMoveTo):
3109         (WTR::EventSenderProxy::mouseScrollBy):
3110         (WTR::EventSenderProxy::keyDown):
3111         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3112
3113 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3114
3115         [Win][WebKit] MiniBrowser should support high DPI display
3116         https://bugs.webkit.org/show_bug.cgi?id=196391
3117
3118         Reviewed by Alex Christensen.
3119
3120         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3121         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3122         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3123         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3124
3125 2019-03-31  Sam Weinig  <weinig@apple.com>
3126
3127         Remove more i386 specific configurations
3128         https://bugs.webkit.org/show_bug.cgi?id=196430
3129
3130         Reviewed by Alexey Proskuryakov.
3131
3132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3133         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3134
3135 2019-03-31  Andy Estes  <aestes@apple.com>
3136
3137         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3138         https://bugs.webkit.org/show_bug.cgi?id=196433
3139         <rdar://problem/49293305>
3140
3141         Reviewed by Tim Horton.
3142
3143         Enhanced API test coverage to include all navigation response policy decisions in both
3144         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3145
3146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3147         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3150         (readFile):
3151         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3152         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3153         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3154         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3155         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3156         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3157         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3158         (-[QuickLookDelegate _downloadDidStart:]):
3159         (-[QuickLookDelegate _download:didReceiveResponse:]):
3160         (-[QuickLookDelegate _download:didReceiveData:]):
3161         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3162         (-[QuickLookDelegate _downloadDidFinish:]):
3163         (-[QuickLookDelegate _download:didFailWithError:]):
3164         (-[QuickLookDelegate _downloadDidCancel:]):
3165         (-[QuickLookDelegate verifyDownload]):
3166         (runTest):
3167         (runTestDecideBeforeLoading):
3168         (runTestDecideAfterLoading):
3169         (TEST):
3170         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3171         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3172         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3173         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3174         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3175         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3176         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3177         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3178         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3179         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3180         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3181         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3182         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3183         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3184
3185 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3186
3187         [CMake] add testdfg as target with build-jsc
3188         https://bugs.webkit.org/show_bug.cgi?id=196393
3189
3190         Reviewed by Saam Barati.
3191
3192         Added testdfg as one of the targets to build when
3193         using CMake.
3194
3195         * Scripts/build-jsc:
3196
3197 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3198
3199         Delete WebMetal implementation in favor of WebGPU
3200         https://bugs.webkit.org/show_bug.cgi?id=195418
3201
3202         Reviewed by Dean Jackson.
3203
3204         * DumpRenderTree/mac/DumpRenderTree.mm:
3205         (enableExperimentalFeatures):
3206         (resetWebPreferencesToConsistentValues):
3207         * Scripts/webkitperl/FeatureList.pm:
3208         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3211         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3212         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3213         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3214         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3215         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3216         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3217         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3218         (WTR::InjectedBundle::beginTesting):
3219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3220         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3222
3223 2019-03-29  Chris Dumez  <cdumez@apple.com>
3224
3225         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3226         https://bugs.webkit.org/show_bug.cgi?id=196405
3227         <rdar://problem/49428130>
3228
3229         Reviewed by Wenson Hsieh.
3230
3231         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3232         the popover presentation methods to be no-ops. Use this in the new test added in
3233         r243523 so that we do not swizzle those methods for all tests. This is needed because
3234         those WatchOS tests rely on the popover getting presented and interactive.
3235
3236         * WebKitTestRunner/TestController.cpp:
3237         (WTR::updateTestOptionsFromTestHeader):
3238         * WebKitTestRunner/TestController.h:
3239         * WebKitTestRunner/TestOptions.h:
3240         (WTR::TestOptions::hasSameInitializationOptions const):
3241         * WebKitTestRunner/ios/TestControllerIOS.mm:
3242         (WTR::TestController::platformInitialize):
3243         (WTR::TestController::platformResetStateToConsistentValues):
3244
3245 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3246
3247         [Curl] Add Server Trust Evaluation Support.
3248         https://bugs.webkit.org/show_bug.cgi?id=191646
3249
3250         Reviewed by Fujii Hironori.
3251
3252         Implemented MiniBrowser UI for asking if user trusts the server.
3253
3254         * MiniBrowser/win/Common.cpp:
3255         (askServerTrustEvaluation):
3256         (replaceString):
3257         * MiniBrowser/win/Common.h:
3258         * MiniBrowser/win/MiniBrowserLib.rc:
3259         * MiniBrowser/win/MiniBrowserLibResource.h:
3260         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3261         (createPEMString):
3262         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3263         (WebKitBrowserWindow::canTrustServerCertificate):
3264         * MiniBrowser/win/WebKitBrowserWindow.h:
3265
3266 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3267
3268         Implement ResizeObserver.
3269         https://bugs.webkit.org/show_bug.cgi?id=157743
3270
3271         Reviewed by Simon Fraser.
3272
3273         Support resizeObserverEnabled webPreferences.
3274
3275         * DumpRenderTree/TestOptions.cpp:
3276         (TestOptions::TestOptions):
3277         * DumpRenderTree/TestOptions.h:
3278         * DumpRenderTree/mac/DumpRenderTree.mm:
3279         (setWebPreferencesForTestOptions):
3280         * DumpRenderTree/win/DumpRenderTree.cpp:
3281         (enableExperimentalFeatures):
3282         * Scripts/webkitperl/FeatureList.pm:
3283         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3284
3285 2019-03-28  John Wilander  <wilander@apple.com>
3286
3287         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3288         https://bugs.webkit.org/show_bug.cgi?id=196281
3289         <rdar://problem/48938748>
3290
3291         Reviewed by Alex Christensen.
3292
3293         This patch adds the function isStatisticsHasLocalStorage() to the
3294         TestRunner. With it, the page can query the WebsiteDataStore in the
3295         UI process to make sure that it sees LocalStorage.
3296
3297         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3299         (WTR::TestRunner::isStatisticsHasLocalStorage):
3300         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3301         * WebKitTestRunner/TestController.cpp:
3302         (WTR::TestController::isStatisticsHasLocalStorage):
3303         * WebKitTestRunner/TestController.h:
3304         * WebKitTestRunner/TestInvocation.cpp:
3305         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3306
3307 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3308
3309         API::Data::createWithoutCopying should do a null check before calling CFRelease
3310         https://bugs.webkit.org/show_bug.cgi?id=196276
3311         <rdar://problem/48059859>
3312
3313         Reviewed by Alex Christensen.
3314
3315         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3316
3317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3318         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3319         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3320         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3321         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3322         (TestWebKitAPI::TEST):
3323
3324 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3325
3326         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3327         https://bugs.webkit.org/show_bug.cgi?id=186276
3328
3329         Reviewed by Carlos Garcia Campos.
3330
3331         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3332         (webViewLoadChanged):
3333         (testWebResourceGetDataError):
3334         (testWebResourceGetDataEmpty):
3335         (beforeAll):
3336         (webViewloadChanged): Deleted.
3337
3338 2019-03-27  Andy Estes  <aestes@apple.com>
3339
3340         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3341         https://bugs.webkit.org/show_bug.cgi?id=196317
3342
3343         Reviewed by Dan Bernstein.
3344
3345         package-root copies built products into a staging directory using ditto(1), which does not
3346         follow symbolic links as it traverses a directory. Now that the files in
3347         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3348         itself, these become broken links when ditto'd into the staging directory.
3349
3350         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3351
3352         * Scripts/package-root:
3353
3354 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3355
3356         [ews-app] Update display text of Submit for ews analysis
3357         https://bugs.webkit.org/show_bug.cgi?id=196309
3358
3359         Reviewed by Dewei Zhu.
3360
3361         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3362
3363 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3364
3365         run-webkit-tests should check for leaks in WebKit processes
3366         <https://webkit.org/b/193772>
3367         <rdar://problem/46526680>
3368
3369         Reviewed by Ryosuke Niwa.
3370
3371         This works by doing the following:
3372         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3373           The list of child processes are returned one per line:
3374           process.name: pid
3375         - Run the "#LIST CHILD PROCESSES" command just before the
3376           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3377           processes on the ServerProcess object.
3378         - When the `--leaks` switch is handled, run check_for_leaks() on
3379           each child process after the main test harness.
3380
3381         * DumpRenderTree/mac/DumpRenderTree.mm:
3382         (handleControlCommand):
3383         - Use strncmp() instead of strcmp().
3384         - Add support for handling "#LIST CHILD PROCESSES" command.
3385
3386         * Scripts/webkitpy/port/base.py:
3387         (Port.check_for_leaks):
3388         * Scripts/webkitpy/port/darwin.py:
3389         (DarwinPort.check_for_leaks):
3390         - Rename redundant 'process_pid' argument to 'process_id'.
3391
3392         * Scripts/webkitpy/port/driver.py:
3393         (Driver.do_post_tests_work):
3394         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3395           longer the only command this sends to WebKitTestRunner.
3396         - If the `--leaks` switch is present, send the
3397           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3398           result using Port.set_webkit_processes().
3399         (Driver._parse_child_processes_output):
3400         - Add helper method to parse list of child process names and
3401           process IDs returned from WebKitTestRunner.
3402
3403         * Scripts/webkitpy/port/ios_device.py:
3404         (IOSDevicePort.check_for_leaks):
3405         - Rename redundant 'process_pid' argument to 'process_id'.
3406
3407         * Scripts/webkitpy/port/leakdetector.py:
3408         (LeakDetector._parse_leaks_output):
3409         - Return early if there is no leaks_output.
3410         (LeakDetector.check_for_leaks):
3411         - Rename redundant 'process_pid' argument to 'process_id'.
3412
3413         * Scripts/webkitpy/port/server_process.py:
3414         (ServerProcess.__init__):
3415         (ServerProcess.child_processes):
3416         (ServerProcess.set_child_processes):
3417         - Add instance variable to Port to store list of child process
3418           names and process IDs returned from WebKitTestRunner.
3419         (ServerProcess._start):
3420         - Clear self._child_processes.
3421         (ServerProcess.stop):
3422         - If self._child_processes is set, call
3423           self._port.check_for_leaks() for each child process.
3424
3425         * Scripts/webkitpy/port/server_process_unittest.py:
3426         (TrivialMockPort.check_for_leaks):
3427         - Rename redundant 'process_pid' argument to 'process_id'.
3428
3429         * Scripts/webkitpy/port/simulator_process.py:
3430         (SimulatorProcess.stop):
3431         - If self._child_processes is set, call
3432           self._port.check_for_leaks() for each child process.
3433
3434         * Scripts/webkitpy/port/watch_device.py:
3435         (WatchDevicePort.check_for_leaks):
3436         - Rename redundant 'process_pid' argument to 'process_id'.
3437
3438         * WebKitTestRunner/TestController.cpp:
3439         (WTR::TestController::dumpResponse):
3440         - Extract method from findAndDumpWorldLeaks() so that it may be
3441           reused by findAndDumpWebKitProcessIdentifiers().
3442         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3443         - Add method to output process name and process ID of both the
3444           WebContent and Networking processes.
3445         (WTR::TestController::findAndDumpWorldLeaks):
3446         - Fix missing newline in output when there were no abandoned
3447           documents.
3448         - Call dumpResponse() for extracted code.
3449         (WTR::TestController::handleControlCommand):
3450         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3451         - Use strncmp() instead of strcmp().
3452         - Call findAndDumpWebKitProcessIdentifiers() when
3453           "#LIST CHILD PROCESSES" command is sent.
3454         * WebKitTestRunner/TestController.h:
3455         (WTR::TestController::dumpResponse):
3456         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3457         - Declare methods.
3458
3459 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3460
3461         Unreviewed. Add GLib API test cases after r243434.
3462
3463         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3464         (testWebViewActiveURI):
3465         (serverCallback):
3466         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3467         (sendRequestCallback):
3468
3469 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3470
3471         Geolocation request not complete when watch request was started in a different web process
3472         https://bugs.webkit.org/show_bug.cgi?id=195996
3473
3474         Reviewed by Alex Christensen.
3475
3476         Add a test case.
3477
3478         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3479         (TestWebKitAPI::runJavaScriptAlert):
3480         (TestWebKitAPI::TEST):
3481
3482 2019-03-26  Keith Rollin  <krollin@apple.com>
3483
3484         Update the way generate-xcfilelists returns strings from functions
3485         https://bugs.webkit.org/show_bug.cgi?id=195975
3486         <rdar://problem/49040807>
3487
3488         Reviewed by Dean Jackson.
3489
3490         There are places where generate-xcfilelists executes assignments with
3491         statements like:
3492
3493             FOO=$(some_function)
3494
3495         where "some_function" return a string by echoing it. E.g.
3496
3497             some_function()
3498             {
3499                 echo "Hello, World"
3500             }
3501
3502         This is a common idiom, but it has a problem if "some_function" needs
3503         to call "exit" in an attempt to halt the entire script right then and
3504         there. Since "some_function" is called inside of $(), it's being
3505         executed in a sub-shell. Calling exit in that sub-shell simply exits
3506         that shell; it doesn't not exit the outer shell in which the main part
3507         of the script is still running. As such, the main script keeps
3508         executing when the intent was for the script to halt.
3509
3510         The solution to this is to use a different idiom for returning
3511         strings. The one we now is to pass in the name of the variable to
3512         receive the string result:
3513
3514             some_function()
3515             {
3516                 variable_name=$1
3517                 eval $variable_name ="Hello, World"
3518             }
3519
3520         The call site now looks like
3521
3522             some_function FOO
3523
3524         Because there's no invocation of a sub-shell, some_function can now
3525         call "exit" if it wants to, and the entire script will exit at that
3526         point.
3527
3528         * Scripts/generate-xcfilelists:
3529
3530 2019-03-26  Chris Dumez  <cdumez@apple.com>
3531
3532         Add basic layout test coverage for File Picker on iOS
3533         https://bugs.webkit.org/show_bug.cgi?id=196265
3534
3535         Reviewed by Wenson Hsieh.
3536
3537         Add layout test infrastructure to test the file picker on iOS.
3538
3539         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3540         (WTR::UIScriptController::dismissFilePicker):
3541         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3542         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3543         (WTR::UIScriptController::dismissFilePicker):
3544         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3545         * WebKitTestRunner/TestController.cpp:
3546         (WTR::TestController::createWebViewWithOptions):
3547         (WTR::updateTestOptionsFromTestHeader):
3548         * WebKitTestRunner/TestOptions.h:
3549         (WTR::TestOptions::hasSameInitializationOptions const):
3550         * WebKitTestRunner/ios/TestControllerIOS.mm:
3551         (overridePresentViewController):
3552         (WTR::TestController::platformInitialize):
3553         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3554         (WTR::UIScriptController::dismissFilePicker):
3555
3556 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3557
3558         Implement async paste method on UIWKInteractionViewProtocol
3559         https://bugs.webkit.org/show_bug.cgi?id=196267
3560         <rdar://problem/49236346>
3561
3562         Reviewed by Tim Horton.
3563
3564         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3565         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3566         are now a part of all iOS 12 internal SDKs.
3567
3568         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3569
3570         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3571         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3572
3573         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3574         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3575         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3576         * TestWebKitAPI/ios/UIKitSPI.h:
3577
3578 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3579
3580         [ews-build] Use PostgreSQL for ews.webkit.org database
3581         https://bugs.webkit.org/show_bug.cgi?id=196270
3582
3583         Reviewed by Lucas Forschler.
3584
3585         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3586
3587 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3588
3589         [ews] Reset simctl states on reboot
3590         https://bugs.webkit.org/show_bug.cgi?id=196260
3591
3592         Rubber-stamped by Aakash Jain.
3593
3594         * EWSTools/start-queue-mac.sh:
3595
3596 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3597
3598         [ews-build] Use PostgreSQL for ews-build database
3599         https://bugs.webkit.org/show_bug.cgi?id=196229
3600
3601         Reviewed by Lucas Forschler.
3602
3603         * BuildSlaveSupport/ews-build/master.cfg:
3604
3605 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3606
3607         [ews-build] Get master_hostname dynamically in master.cfg
3608         https://bugs.webkit.org/show_bug.cgi?id=196255
3609
3610         Reviewed by Lucas Forschler.
3611
3612         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3613         send events data in test mode.
3614
3615 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3616
3617         [ews-app] Set db_constraint to False for Foreign Keys
3618         https://bugs.webkit.org/show_bug.cgi?id=196252
3619
3620         Reviewed by Lucas Forschler.
3621
3622         * BuildSlaveSupport/ews-app/ews/models/build.py:
3623         * BuildSlaveSupport/ews-app/ews/models/step.py:
3624
3625 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-build] is_test_mode_enabled should default to True
3628         https://bugs.webkit.org/show_bug.cgi?id=196248
3629
3630         Reviewed by Lucas Forschler.
3631
3632         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3633
3634 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3635
3636         [ews-app] Add webkitperl to ENABLED_QUEUES
3637         https://bugs.webkit.org/show_bug.cgi?id=196253
3638
3639         Reviewed by Lucas Forschler.
3640
3641         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3642
3643 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3644
3645         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3646         https://bugs.webkit.org/show_bug.cgi?id=196211
3647         rdar://problem/49110552
3648