Fix leak-checking for iOS Simulators
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
2
3         Fix leak-checking for iOS Simulators
4         https://bugs.webkit.org/show_bug.cgi?id=175735
5
6         Reviewed by David Kilzer.
7
8         Follow-up fix to r220942. _proc may be undefined.
9
10         * Scripts/webkitpy/port/server_process.py:
11         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
12
13 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
14
15         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
16         https://bugs.webkit.org/show_bug.cgi?id=175822
17
18         Reviewed by Xabier Rodriguez-Calvar.
19
20         * gtk/install-dependencies: Add the bad plugins to the list.
21         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
22
23 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
24
25         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
26         https://bugs.webkit.org/show_bug.cgi?id=175787
27         <rdar://problem/33996612>
28
29         Reviewed by Wenson Hsieh.
30
31         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
32         (TestWebKitAPI::TEST):
33
34 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
35
36         Typo in "webkit-patch land"
37         https://bugs.webkit.org/show_bug.cgi?id=175788
38
39         Reviewed by Tim Horton.
40
41         * Scripts/webkitpy/tool/steps/commit.py:
42         (Commit._commit_warning):
43
44 2017-08-20  Sam Weinig  <sam@webkit.org>
45
46         StringView could use a function to strip leading/trailing characters without allocation
47         https://bugs.webkit.org/show_bug.cgi?id=175757
48
49         Reviewed by Darin Adler.
50
51         * TestWebKitAPI/Tests/WTF/StringView.cpp:
52         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
53
54 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
55
56         [PAL] Move spi/mac directory into PAL
57         https://bugs.webkit.org/show_bug.cgi?id=175649
58
59         Reviewed by Myles C. Maxfield.
60
61         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
62
63 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
64
65         [Win] DRT should only allow any https certificate for localhost.
66         https://bugs.webkit.org/show_bug.cgi?id=175147
67
68         Reviewed by Brent Fulgham.
69
70         Add check to make sure only localhost requests allow any https certificate.
71
72         * DumpRenderTree/win/DumpRenderTree.cpp:
73         (runTest):
74
75 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
76
77         Add WTFLogChannel level to allow runtime log filtering
78         https://bugs.webkit.org/show_bug.cgi?id=175731
79         <rdar://problem/33967234>
80
81         Unreviewed build fix.
82
83         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
84         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
85         fails on some of the bots.
86
87 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
88
89         Add WTFLogChannel level to allow runtime log filtering
90         https://bugs.webkit.org/show_bug.cgi?id=175731
91         <rdar://problem/33967234>
92
93         Reviewed by Jer Noble.
94
95         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
96         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
97         (TestWebKitAPI::LoggingTest::output):
98         (TestWebKitAPI::TEST_F):
99
100 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
101
102         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
103         https://bugs.webkit.org/show_bug.cgi?id=175509
104         <rdar://problem/33728169>
105
106         Reviewed by Ryosuke Niwa.
107
108         Removes ExternalSourceAttributedStringToContentEditable and adds
109         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
110         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
111         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
112         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
113         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
114         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
115
116         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
117
118         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
119         (TestWebKitAPI::TEST):
120
121 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
122
123         Unreviewed, rolling out r220938.
124
125         The API tests added with this change are failing.
126
127         Reverted changeset:
128
129         "Add WTFLogChannel level to allow runtime log filtering"
130         https://bugs.webkit.org/show_bug.cgi?id=175731
131         http://trac.webkit.org/changeset/220938
132
133 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
134
135         Unreviewed, change my email.
136
137         * Scripts/webkitpy/common/config/contributors.json:
138
139 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
140
141         Fix leak-checking for iOS Simulators
142         https://bugs.webkit.org/show_bug.cgi?id=175735
143
144         Reviewed by Darin Adler.
145
146         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
147         Simulator (or device) because the process will have already been killed by the time we
148         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
149
150         * Scripts/webkitpy/port/server_process.py:
151         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
152         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
153         and SimulatorProcess.
154         * Scripts/webkitpy/port/simulator_process.py:
155         (SimulatorProcess.stop): Before closing the process, check for leaks.
156
157 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
158
159         Add WTFLogChannel level to allow runtime log filtering
160         https://bugs.webkit.org/show_bug.cgi?id=175731
161         <rdar://problem/33967234>
162
163         Reviewed by Jer Noble.
164
165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
166         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
167         (TestWebKitAPI::LoggingTest::output):
168         (TestWebKitAPI::TEST_F):
169
170 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
171
172         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
173
174         * Scripts/webkitpy/common/config/contributors.json:
175
176 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
177
178         [Tools] Add script to download a GitHub release
179         https://bugs.webkit.org/show_bug.cgi?id=175279
180
181         Reviewed by Brent Fulgham.
182
183         * Scripts/download-latest-github-release.py: Added.
184
185 2017-08-18  Commit Queue  <commit-queue@webkit.org>
186
187         Unreviewed, rolling out r220854.
188         https://bugs.webkit.org/show_bug.cgi?id=175716
189
190         I'm not sure we really need this (Requested by KaL on
191         #webkit).
192
193         Reverted changeset:
194
195         "[GTK][WPE] Add NTLM authentication enabled API"
196         https://bugs.webkit.org/show_bug.cgi?id=122952
197         http://trac.webkit.org/changeset/220854
198
199 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
200
201         [GTK] Make TestContextMenu work on Fedora
202         https://bugs.webkit.org/show_bug.cgi?id=175708
203
204         Reviewed by Carlos Garcia Campos.
205
206         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
207         and my student last summer who was trying to work on a context menu API. It's trying to load
208         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
209         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
210         don't care to investigate. Let's switch it to WebM so I can move on.
211
212         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
213         (prepareContextMenuTestView):
214         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
215         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
216
217 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
218
219         check-webkit-style shouldn't check spacing in #elif preprocessor lines
220         https://bugs.webkit.org/show_bug.cgi?id=175652
221
222         Reviewed by Alex Christensen.
223
224         * Scripts/webkitpy/style/checkers/cpp.py:
225         (check_spacing):
226         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
227         (CppStyleTest.test_spacing_for_binary_ops):
228
229 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
230
231         Fix the build on other platforms after r220865
232         https://bugs.webkit.org/show_bug.cgi?id=175683
233
234         Reviewed by Tim Horton.
235
236         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
237         availability is determined by SDK version rather than deployment version.
238
239         * TestWebKitAPI/ios/UIKitSPI.h:
240
241 2017-08-17  Andreas Kling  <akling@apple.com>
242
243         Disable CSS regions at compile time
244         https://bugs.webkit.org/show_bug.cgi?id=175630
245
246         Reviewed by Antti Koivisto.
247
248         * Scripts/webkitperl/FeatureList.pm:
249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
250
251 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
252
253         Unreviewed, try to fix the internal iOS 10 build after r220865.
254
255         * TestWebKitAPI/ios/UIKitSPI.h:
256
257         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
258         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
259         this compiler guard.
260
261 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
262
263         [iOS] Respect type fidelities when copying image elements to the pasteboard
264         https://bugs.webkit.org/show_bug.cgi?id=175638
265         <rdar://problem/26556043>
266
267         Reviewed by Ryosuke Niwa.
268
269         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
270         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
271         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
272
273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
274         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
275         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
276         (TestWebKitAPI::TEST):
277         (TestWebKitAPI::presentActionSheetAndChooseAction):
278         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
279         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
280         (checkEstimatedSize):
281         (checkSuggestedNameAndEstimatedSize):
282
283         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
284
285         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
286         (TestWebKitAPI::TEST):
287         * TestWebKitAPI/ios/DataInteractionSimulator.h:
288         * TestWebKitAPI/ios/UIKitSPI.h: Added.
289
290 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
291
292         Recursively create resource load statistics folder for testing
293         https://bugs.webkit.org/show_bug.cgi?id=175676
294
295         Reviewed by Brady Eidson.
296
297         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
298         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
299
300 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
301
302         [GTK][WPE] Add NTLM authentication enabled API
303         https://bugs.webkit.org/show_bug.cgi?id=122952
304
305         Reviewed by Michael Catanzaro.
306
307         Add a test case to check we can enable/disable NTLM.
308
309         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
310         (testWebViewAuthenticationNTLM):
311         (beforeAll):
312
313 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
314
315         [PAL] Move spi/ios and spi/win directories into PAL
316         https://bugs.webkit.org/show_bug.cgi?id=175171
317
318         Reviewed by Antti Koivisto.
319
320         * DumpRenderTree/mac/EventSendingController.mm:
321
322 2017-08-16  Andy Estes  <aestes@apple.com>
323
324         [Payment Request] Add an ENABLE flag and an experimental feature preference
325         https://bugs.webkit.org/show_bug.cgi?id=175622
326
327         Reviewed by Tim Horton.
328
329         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
330         * WebKitTestRunner/TestController.cpp:
331         (WTR::TestController::resetPreferencesToConsistentValues):
332
333 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
334
335         undefined URL in PopoverTracker for failed step
336         https://bugs.webkit.org/show_bug.cgi?id=175593
337         <rdar://problem/33898769>
338
339         Reviewed by Daniel Bates.
340
341         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
342         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
343
344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
345         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
346         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
348         (BuildbotTestResults): Accept URL in constructor.
349
350 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
351
352         Remove Proximity Events and related code
353         https://bugs.webkit.org/show_bug.cgi?id=175545
354
355         Reviewed by Daniel Bates.
356
357         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
358         and other related code.
359
360         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
361
362 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
363
364         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
365         https://bugs.webkit.org/show_bug.cgi?id=175504
366
367         Reviewed by Sam Weinig.
368
369         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
370
371 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
372
373         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
374         https://bugs.webkit.org/show_bug.cgi?id=175557
375
376         Reviewed by Jon Lee.
377         
378         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
379
380         * DumpRenderTree/TestRunner.cpp:
381         (TestRunner::staticFunctions):
382         (setViewModeMediaFeatureCallback): Deleted.
383         * DumpRenderTree/TestRunner.h:
384         * DumpRenderTree/mac/TestRunnerMac.mm:
385         (TestRunner::setViewModeMediaFeature): Deleted.
386         * DumpRenderTree/win/TestRunnerWin.cpp:
387         (TestRunner::setViewModeMediaFeature): Deleted.
388         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
389
390 2017-08-14  Andy Estes  <aestes@apple.com>
391
392         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
393         https://bugs.webkit.org/show_bug.cgi?id=175548
394         <rdar://problem/33866206>
395
396         Reviewed by Brady Eidson.
397
398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
399         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
400         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
401
402 2017-08-14  Youenn Fablet  <youenn@apple.com>
403
404         WPT server should be able to do logging even if its output folder is not created at launch time
405         https://bugs.webkit.org/show_bug.cgi?id=175543
406
407         Reviewed by Alexey Proskuryakov.
408
409         Removing no longer used stdout/stderr member variables.
410         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
411
412         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
413         (WebPlatformTestServer.__init__):
414         (WebPlatformTestServer._prepare_config):
415         (WebPlatformTestServer._spawn_process):
416         (WebPlatformTestServer._stop_running_server):
417
418 2017-08-14  Daniel Bates  <dabates@apple.com>
419
420         webkit-patch: Passing --no-review should submit patch to EWS by default
421         https://bugs.webkit.org/show_bug.cgi?id=148899
422
423         Reviewed by David Kilzer.
424
425         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
426         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
427         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
428
429         Frequently I want to post a draft of a patch without review to have the EWS bots process
430         it to catch build and test breakage before I clean it up and post it for formal review.
431         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
432         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
433         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
434
435         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
436         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
437         parse the attachment id from the response page after adding an attachment to the bug.
438         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
439         HTTP response after uploading the patch.
440         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
441         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
442         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
443         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
444         * Scripts/webkitpy/tool/commands/upload.py:
445         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
446         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
447         this command.
448         (PostCommits.execute): Submit the patch to EWS, if applicable.
449         * Scripts/webkitpy/tool/commands/upload_unittest.py:
450         (test_upload): Set options.ews to False as the upload command expects this option
451         to be specified.
452         (test_upload_with_no_review_and_ews): Added.
453         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
454         * Scripts/webkitpy/tool/steps/options.py:
455         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
456         * Scripts/webkitpy/tool/steps/postdiff.py:
457         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
458         this command.
459         (PostDiff.run): Submit the patch to EWS, if applicable.
460         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
461         (SubmitToEWS):
462         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
463         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
464
465 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
466
467         Disable two flaky VideoControlsManager API tests.
468
469         Unreviewed test gardening.
470
471         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
472         (TestWebKitAPI::TEST):
473
474 2017-08-14  Tim Horton  <timothy_horton@apple.com>
475
476         Only create directory and sandbox extension handle for storage directories if they are set
477         https://bugs.webkit.org/show_bug.cgi?id=175522
478
479         Reviewed by Brady Eidson.
480
481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
482         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
483         (TEST):
484         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
485         doesn't log anything to stderr.
486
487 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
488
489         sub-categorize Sandbox violation logs
490         https://bugs.webkit.org/show_bug.cgi?id=175536
491         <rdar://problem/33834416>
492
493         Reviewed by David Kilzer.
494
495         * Scripts/webkitpy/common/system/crashlogs.py:
496         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
497         a Sandbox violation.
498         (CrashLogs._find_all_logs_darwin): Update comment.
499         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
500         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
501         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
502         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
503         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
504         * Scripts/webkitpy/port/darwin.py:
505         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
506
507 2017-08-14  Daniel Bates  <dabates@apple.com>
508
509         Add Automator service to copy permalink to Clipboard
510         https://bugs.webkit.org/show_bug.cgi?id=170978
511
512         Reviewed by Joseph Pecoraro.
513
514         It is helpful to reference using a hyperlink a particular line of code when having
515         a discussion on IRC or in a bug. You can get such a link by navigating to the file
516         in the Trac Browse Source viewer and selecting the line your are interested in.
517         I found myself doing this often enough that I wrote an Automator service to do it
518         for me.
519
520         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
521
522         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
523         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
524         * CopyPermalink/README: Added.
525
526 2017-08-14  Chris Dumez  <cdumez@apple.com>
527
528         Address flakiness related to download tests
529         https://bugs.webkit.org/show_bug.cgi?id=175338
530         <rdar://problem/33865119>
531
532         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
533         between tests.
534
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::resetStateToConsistentValues):
537
538 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
539
540         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
541         https://bugs.webkit.org/show_bug.cgi?id=175474
542         <rdar://problem/33844628>
543
544         Reviewed by Wenson Hsieh.
545
546         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
547
548         * DumpRenderTree/mac/DumpRenderTree.mm:
549         (resetWebPreferencesToConsistentValues):
550         * WebKitTestRunner/TestController.cpp:
551         (WTR::TestController::resetPreferencesToConsistentValues):
552
553 2017-08-12  Chris Dumez  <cdumez@apple.com>
554
555         Address flakiness related to download tests
556         https://bugs.webkit.org/show_bug.cgi?id=175338
557
558         Reviewed by Ryosuke Niwa.
559
560         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
561           is actually queried when a download completes. Previously, this would be
562           identical to a call to testRunner.waitUntilDone() because any download
563           completion would call testRunner.notifyDone().
564         - Disable logging of download callbacks by default and add a
565           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
566           enable such logging.
567
568         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
570         (WTR::InjectedBundle::didReceiveMessageToPage):
571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
572         (WTR::TestRunner::setShouldLogDownloadCallbacks):
573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::TestController::downloadDidStart):
576         (WTR::TestController::decideDestinationWithSuggestedFilename):
577         (WTR::TestController::downloadDidFinish):
578         (WTR::TestController::downloadDidFail):
579         (WTR::TestController::downloadDidCancel):
580         * WebKitTestRunner/TestController.h:
581         (WTR::TestController::setShouldLogDownloadCallbacks):
582         * WebKitTestRunner/TestInvocation.cpp:
583         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
584
585 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
586
587         Create mock ITP data in testing to prevent grandfathering
588         https://bugs.webkit.org/show_bug.cgi?id=174720
589
590         Unreviewed follow-up fix for r220604.
591
592         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
593         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
594
595 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
596
597         Create mock ITP data in testing to prevent grandfathering
598         https://bugs.webkit.org/show_bug.cgi?id=174720
599         <rdar://problem/33457779>
600
601         Reviewed by Brent Fulgham.
602
603         We don't need to be triggering grandfathering when each test runner starts. On Mac,
604         this may launch plugins which can cause layout tests to fail later if the test
605         runner does not shut-down before the plugins unload.
606
607         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
608         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
609         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
610         prevent grandfathering from being triggered.
611         * WebKitTestRunner/ios/TestControllerIOS.mm:
612         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
613         * WebKitTestRunner/mac/TestControllerMac.mm:
614         (WTR::TestController::platformInitialize): Ditto.
615
616 2017-08-11  Sam Weinig  <sam@webkit.org>
617
618         WTF::Function does not allow for reference / non-default constructible return types
619         https://bugs.webkit.org/show_bug.cgi?id=175244
620         <rdar://problem/33801582>
621
622         Reviewed by Chris Dumez.
623
624         * TestWebKitAPI/Tests/WTF/Function.cpp:
625         (TestWebKitAPI::TEST):
626
627 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
628
629         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
630         https://bugs.webkit.org/show_bug.cgi?id=175378
631
632         Reviewed by Sergio Villar Senin.
633
634         Add two test cases to check proxy authentication.
635
636         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
637         (Tunnel::Tunnel):
638         (Tunnel::~Tunnel):
639         (Tunnel::connect):
640         (Tunnel::connected):
641         (serverCallback):
642         (ProxyAuthenticationTest::ProxyAuthenticationTest):
643         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
644         (ProxyAuthenticationTest::proxyServerPortAsString):
645         (testWebViewAuthenticationProxy):
646         (testWebViewAuthenticationProxyHTTPS):
647         (beforeAll):
648
649 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
650
651         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
652         https://bugs.webkit.org/show_bug.cgi?id=175428
653
654         Both ports share the GStreamer code as multimedia backend and till
655         not so long they were using different versions. Now they do use
656         the same versions and it does not make any sense anymore (and
657         neither had sense before) to have differences in the modulesets.
658
659         In this patch I created a GStreamer moduleset and referenced it
660         from both GTK+'s and WPE's. GStreamer patches were also moved there.
661
662         Reviewed by Žan Doberšek.
663
664         * gstreamer/jhbuild.modules: Added.
665         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
666         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
667         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
668         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
669         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
670         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
671         * gtk/jhbuild.modules:
672         * wpe/jhbuild.modules:
673         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
674         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
675         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
676         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
677         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
678
679 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
680
681         Unreviewed, adding Ross Kirsling to contributors.json
682
683         * Scripts/webkitpy/common/config/contributors.json:
684
685 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
686
687         Unreviewed, attempt to fix build failure with VC2017
688
689         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
690         (TEST):
691
692 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
693
694         Unreviewed, suppress warnings on GCC
695
696         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
697         (TestWebKitAPI::CheckedArithmeticTester::run):
698
699 2017-08-10  Dan Bernstein  <mitz@apple.com>
700
701         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
702         https://bugs.webkit.org/show_bug.cgi?id=173223
703
704         Reviewed by Tim Horton.
705
706         The rebuilds were happening due to a difference in the compiler options that the IDE and
707         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
708         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
709         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
710         Advanced when a Custom Absolute path is selected.
711
712         * Scripts/webkitdirs.pm:
713         (determineBaseProductDir):
714
715 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
716
717         Run more WTF tests
718         https://bugs.webkit.org/show_bug.cgi?id=174970
719
720         Reviewed by Michael Catanzaro.
721
722         Some of WTF tests are not executed in non Apple ports while they are generic ones.
723         This patch adds these tests to non-Apple port TestWebKitAPI.
724         Currently, we do not add Signals.cpp since it depends on signal functionality.
725
726         * TestWebKitAPI/CMakeLists.txt:
727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
728         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
729         (isHigherPriority):
730         (TEST):
731         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
732         (TEST):
733         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
734         (TEST):
735
736 2017-08-10  obinna obike  <oobike@apple.com>
737
738         Remove obsolete link from webkit-queues status page
739         https://bugs.webkit.org/show_bug.cgi?id=175337
740
741         Reviewed by Aakash Jain.
742
743         * QueueStatusServer/templates/recentstatus.html:
744         Removed the link to the ews-watcher server.
745
746 2017-08-10  Brian Burg  <bburg@apple.com>
747
748         WKPreferences should conform to NSCopying
749         https://bugs.webkit.org/show_bug.cgi?id=175303
750         <rdar://problem/33764939>
751
752         Reviewed by Dan Bernstein.
753
754         Add unit test to make sure a WKPreference and its copy are
755         not aliased to each other or affect each other's properties.
756
757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
758         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
759         (TEST):
760
761 2017-08-10  Tim Horton  <timothy_horton@apple.com>
762
763         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
764         https://bugs.webkit.org/show_bug.cgi?id=175436
765         <rdar://problem/33667497>
766
767         Reviewed by Simon Fraser.
768
769         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
770         (TestWebKitAPI::TEST_F):
771
772 2017-08-10  Lucas Forschler  <lforschler@apple.com>
773
774         Fix duplicated code in r220534.
775
776         Unreviewed cleanup.
777
778         * Scripts/bisect-builds:
779
780 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
781
782         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
783         https://bugs.webkit.org/show_bug.cgi?id=175344
784         <rdar://problem/28507240>
785
786         Reviewed by Alexey Proskuryakov.
787
788         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
789         Finally enable the existing tests for iOS.
790
791         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
792         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
794         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
795
796 2017-08-10  Lucas Forschler  <lforschler@apple.com>
797
798         Write a tool to bisect WebKit builds
799         https://bugs.webkit.org/show_bug.cgi?id=174596
800
801         Reviewed by Dean Johnson and Kocsen Chung.
802
803         * Scripts/bisect-builds: Added.
804         (bisect_builds): main bisection algorithm
805         (download_archive):download an archive from S3 using existing tools
806         (extract_archive):extract an archive using existing tools
807         (find_le):Find rightmost value less than or equal to x
808         (find_ge):Find leftmost item greater than or equal to x
809         (get_api_url):generate url for the rest api/database
810         (get_indices_from_revisions):convert revisions to list indexes for bisection
811         (get_sorted_revisions):retrieve sorted revision list
812         (get_s3_location_for_revision):calculate the S3 archive storage location
813         (parse_args):parse command line arguments
814         (pick_next_build):compute the next build to bisect
815         (prompt_did_reproduce):prompt user for direction for bisection
816         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
817         (test_archive):Platform specific logic to test downloaded archive
818         (minified_platforms):return a list of minified platforms in the database
819         (unminified_platforms):return a list of full platforms in the database
820         (is_supported_platform):check if platform is supported
821         (validate_options):validate command line options
822         (main):
823
824 2017-08-10  Lucas Forschler  <lforschler@apple.com>
825
826         Remove bisect-builds script.
827         https://bugs.webkit.org/show_bug.cgi?id=175433
828         
829         Reviewed by Aakash Jain.
830
831         * Scripts/bisect-builds: Removed.
832
833 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
834
835         Remove ENABLE_GAMEPAD_DEPRECATED
836         https://bugs.webkit.org/show_bug.cgi?id=175361
837
838         Reviewed by Carlos Garcia Campos.
839
840         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
841
842 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
843
844         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
845         https://bugs.webkit.org/show_bug.cgi?id=175426
846
847         Reviewed by Carlos Garcia Campos.
848
849         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
850
851 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
852
853         Add Ms2ger as contributor.
854         https://bugs.webkit.org/show_bug.cgi?id=175325
855
856         Reviewed by Carlos Alberto Lopez Perez.
857
858         * Scripts/webkitpy/common/config/contributors.json:
859
860 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
861
862         Fix run-benchmark after r220483.
863         https://bugs.webkit.org/show_bug.cgi?id=175415
864         <rdar://problem/33803003>
865
866         Reviewed by Ryosuke Niwa.
867
868         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
869
870         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
871         (WebServerBenchmarkRunner._run_one_test):
872
873 2017-08-09  Chris Dumez  <cdumez@apple.com>
874
875         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
876         https://bugs.webkit.org/show_bug.cgi?id=175401
877
878         Reviewed by Brady Eidson.
879
880         * DumpRenderTree/mac/DumpRenderTree.mm:
881         (enableExperimentalFeatures):
882
883 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
884
885         [PAL] Move spi/cocoa and spi/cg directories into PAL
886         https://bugs.webkit.org/show_bug.cgi?id=175175
887
888         Reviewed by Myles C. Maxfield.
889
890         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
891         * DumpRenderTree/mac/DumpRenderTree.mm:
892         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
893         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
894
895         * Scripts/webkitpy/style/checker.py:
896         * Scripts/webkitpy/style/checker_unittest.py:
897         (GlobalVariablesTest.test_path_rules_specifier):
898
899         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
900
901         * Scripts/webkitpy/style/checkers/cpp.py:
902         (check_braces):
903         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
904         (WebKitStyleTest.test_braces.CF_OPTIONS):
905         (WebKitStyleTest.test_braces):
906
907         Prevent CF_OPTIONS() from being handled as funtion definition.
908
909 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
910
911         [WTF] Move TextStream into WTF
912         https://bugs.webkit.org/show_bug.cgi?id=175211
913
914         Reviewed by Myles C. Maxfield.
915
916         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
917
918 2017-08-09  Andy Estes  <aestes@apple.com>
919
920         Part 3 of: Rename DatabaseProcess to StorageProcess
921         https://bugs.webkit.org/show_bug.cgi?id=175034
922
923         Reviewed by Brady Eidson.
924
925         * WebKitTestRunner/TestController.cpp:
926         (WTR::TestController::databaseProcessName): Updated to return
927         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
928
929 2017-08-09  Commit Queue  <commit-queue@webkit.org>
930
931         Unreviewed, rolling out r220466, r220477, and r220487.
932         https://bugs.webkit.org/show_bug.cgi?id=175411
933
934         This change broke existing API tests and follow up fixes did
935         not resolve all the issues. (Requested by ryanhaddad on
936         #webkit).
937
938         Reverted changesets:
939
940         https://bugs.webkit.org/show_bug.cgi?id=175244
941         http://trac.webkit.org/changeset/220466
942
943         "WTF::Function does not allow for reference / non-default
944         constructible return types"
945         https://bugs.webkit.org/show_bug.cgi?id=175244
946         http://trac.webkit.org/changeset/220477
947
948         https://bugs.webkit.org/show_bug.cgi?id=175244
949         http://trac.webkit.org/changeset/220487
950
951 2017-08-09  Sam Weinig  <sam@webkit.org>
952
953         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
954
955         Remove one addition of null Function test.
956
957 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
958
959         Allow nested timeouts in webkitpy
960         https://bugs.webkit.org/show_bug.cgi?id=175390
961         <rdar://problem/33803003>
962
963         Reviewed by David Kilzer.
964
965         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
966         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
967         the executive to detect and recover from any issues connecting with devices.
968
969         * Scripts/webkitpy/benchmark_runner/utils.py:
970         (TimeoutError): Deleted.
971         (timeout): Deleted.
972         * Scripts/webkitpy/common/timeout_context.py: Added.
973         (Timeout): A timeout context designed to be nested.
974         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
975         (Timeout.TimeoutData.__init__):
976         (Timeout.default_handler): Timeout handler used if none is specified.
977         (Timeout.current): Access data about the most urgent timeout.
978         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
979         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
980         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
981         urgent timeout data.
982         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
983         most urgent timeout data, if such data exists.
984         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
985         (TimeoutContextTests):
986         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
987         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
988         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
989         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
990         over a less urgent outer timeout.
991         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
992         over a less urgent inner timeout.
993         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
994         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
995         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
996         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
997         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
998         * Scripts/webkitpy/port/simulator_process.py:
999         (SimulatorProcess._start): Use Timeout class.
1000         * Scripts/webkitpy/xcode/simulated_device.py:
1001         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
1002         (SimulatedDevice.launch_app): Ditto.
1003         (SimulatedDevice.launch_app._install_timeout): Deleted.
1004         * Scripts/webkitpy/xcode/simulator.py:
1005         (Simulator.wait_until_device_is_booted):Use Timeout class.
1006         (Simulator.wait_until_device_is_in_state): Ditto.
1007
1008 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1009
1010         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1011         https://bugs.webkit.org/show_bug.cgi?id=175392
1012         <rdar://problem/33783207>
1013
1014         Reviewed by Tim Horton and Megan Gardner.
1015
1016         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1017
1018         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1019
1020 2017-08-09  Sam Weinig  <sam@webkit.org>
1021
1022         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1023
1024         * TestWebKitAPI/Tests/WTF/Function.cpp:
1025         Remove tests of null Functions, as they are no longer supported.
1026
1027 2017-08-09  Daniel Bates  <dabates@apple.com>
1028
1029         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1030         https://bugs.webkit.org/show_bug.cgi?id=175247
1031         <rdar://problem/33679804>
1032
1033         Reviewed by Brady Eidson.
1034
1035         Add tests for redirects.
1036
1037         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1038         (TEST):
1039         * TestWebKitAPI/cocoa/TestProtocol.mm:
1040         (createRedirectURL):
1041         (-[TestProtocol startLoading]):
1042
1043 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1044
1045         Unreviewed, rolling out r220393.
1046
1047         This patch regresses the performance of WebPage::editorState.
1048
1049         Reverted changeset:
1050
1051         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1052         cmb+b,i,u inside a contenteditable div"
1053         https://bugs.webkit.org/show_bug.cgi?id=175116
1054         http://trac.webkit.org/changeset/220393
1055
1056 2017-08-08  obinna obike  <oobike@apple.com>
1057
1058         Created Individual EWS Pages
1059         https://bugs.webkit.org/show_bug.cgi?id=174477
1060
1061         Reviewed by Aakash Jain.
1062
1063         Created individual pages for each EWS. Changed the link within each status bubble
1064         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1065
1066         * QueueStatusServer/handlers/patch.py:
1067         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1068         * QueueStatusServer/handlers/statusbubble.py:
1069         (StatusBubble._build_bubble): Updated url for specific EWS.
1070         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1071         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1072         all ews queues.
1073         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1074         takes you directly to the individual ews page.
1075
1076 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1077
1078         Separate jsc stress test script writer from run-jsc-stress-tests
1079         https://bugs.webkit.org/show_bug.cgi?id=175216
1080
1081         Reviewed by Mark Lam.
1082
1083         * Scripts/run-jsc-stress-tests:
1084         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1085
1086 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1087
1088         Unreviewed, fix Ubuntu LTS build
1089         https://bugs.webkit.org/show_bug.cgi?id=174490
1090
1091         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1092
1093 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1094
1095         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1096         https://bugs.webkit.org/show_bug.cgi?id=175302
1097         <rdar://problem/33762116>
1098
1099         Reviewed by Tim Horton.
1100
1101         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1102         See WebKit ChangeLog for more details.
1103
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1105         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1106         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1107         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1108         (-[SlowTextInputContext handleEvent:completionHandler:]):
1109         (-[SlowInputWebView inputContext]):
1110         (-[SlowInputWebView _web_superInputContext]):
1111         (TEST):
1112
1113 2017-08-08  John Wilander  <wilander@apple.com>
1114
1115         Resource Load Statistics: Clear web processes' state on history removal
1116         https://bugs.webkit.org/show_bug.cgi?id=175271
1117         <rdar://problem/33756560>
1118
1119         Reviewed by Chris Dumez.
1120
1121         Test infrastructure for asynchronous tests of website data
1122         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1123
1124         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1125         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1126         (WTR::InjectedBundle::didReceiveMessageToPage):
1127         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1128         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1129         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1130         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1131         * WebKitTestRunner/TestController.cpp:
1132         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1133         * WebKitTestRunner/TestController.h:
1134         * WebKitTestRunner/TestInvocation.cpp:
1135         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1136         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1137         * WebKitTestRunner/TestInvocation.h:
1138         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1139         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1140
1141 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1142
1143         Add Alicia Boya García as contributor
1144         https://bugs.webkit.org/show_bug.cgi?id=175326
1145
1146         Reviewed by Michael Catanzaro.
1147
1148         * Scripts/webkitpy/common/config/contributors.json:
1149
1150 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1151
1152         [CMake] Properly test if compiler supports compiler flags
1153         https://bugs.webkit.org/show_bug.cgi?id=174490
1154
1155         Reviewed by Konstantin Tokarev.
1156
1157         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1158         * MiniBrowser/gtk/CMakeLists.txt:
1159         * TestRunnerShared/Bindings/JSWrapper.cpp:
1160         (WTR::JSWrapper::initialize):
1161         * TestWebKitAPI/CMakeLists.txt:
1162         * TestWebKitAPI/PlatformGTK.cmake:
1163         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1164         (TestWebKitAPI::CheckedArithmeticTester::run):
1165         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1166         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1167         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1168         (formControlsAssociatedCallback):
1169         * TestWebKitAPI/glib/CMakeLists.txt:
1170         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1171         (Test::getResourcesDir):
1172         * WebKitTestRunner/CMakeLists.txt:
1173         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1174         (WTR::menuItemClickCallback):
1175         (WTR::staticConvertMenuItemToType):
1176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1177         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1178         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1179         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1180         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1181         (WTR::AccessibilityUIElement::helpText const):
1182         (WTR::AccessibilityUIElement::attributedStringForRange):
1183         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1184         (WTR::EventSenderProxy::updateTouchPoint):
1185         (WTR::EventSenderProxy::releaseTouchPoint):
1186
1187 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1188
1189         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1190         https://bugs.webkit.org/show_bug.cgi?id=175116
1191         <rdar://problem/28279301>
1192
1193         Reviewed by Darin Adler and Ryosuke Niwa.
1194
1195         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1196         EditorStateTests run on both iOS and Mac.
1197
1198         * TestWebKitAPI/EditingTestHarness.h: Added.
1199         * TestWebKitAPI/EditingTestHarness.mm: Added.
1200
1201         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1202         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1203         the state of the latest observed EditorState.
1204
1205         (-[EditingTestHarness initWithWebView:]):
1206         (-[EditingTestHarness dealloc]):
1207         (-[EditingTestHarness webView]):
1208         (-[EditingTestHarness latestEditorState]):
1209         (-[EditingTestHarness editorStateHistory]):
1210         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1211         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1212         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1213         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1214         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1215         (-[EditingTestHarness toggleBold]):
1216         (-[EditingTestHarness toggleItalic]):
1217         (-[EditingTestHarness toggleUnderline]):
1218         (-[EditingTestHarness setForegroundColor:]):
1219         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1220         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1221         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1222         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1223         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1224         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1225         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1226
1227         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1228         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1229         keys and values.
1230
1231         (-[EditingTestHarness latestEditorStateContains:]):
1232         (-[EditingTestHarness _webView:editorStateDidChange:]):
1233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1234         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1235         (TestWebKitAPI::setUpEditorStateTestHarness):
1236         (TestWebKitAPI::TEST):
1237         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1238
1239 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1240
1241         Prevent domain from being set to a TLD
1242         https://bugs.webkit.org/show_bug.cgi?id=175226
1243         <rdar://problem/11079948>
1244
1245         Reviewed by Chris Dumez.
1246
1247         Extend the public suffix tests to include cases used by the
1248         Public Domain 'Public Suffix List'.
1249
1250         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1251         (TestWebKitAPI::TEST):
1252
1253 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1254
1255         [XCode] webkit-patch should run sort-Xcode-project-file
1256         https://bugs.webkit.org/show_bug.cgi?id=174036
1257         <rdar://problem/33732709>
1258
1259         Reviewed by Simon Fraser.
1260
1261         * Scripts/webkitpy/common/config/ports.py:
1262         * Scripts/webkitpy/tool/commands/download.py:
1263         * Scripts/webkitpy/tool/commands/download_unittest.py:
1264         * Scripts/webkitpy/tool/commands/upload.py:
1265         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1266         * Scripts/webkitpy/tool/steps/__init__.py:
1267         * Scripts/webkitpy/tool/steps/options.py:
1268         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1269
1270 2017-08-07  Devin Rousso  <drousso@apple.com>
1271
1272         Web Inspector: Preview Canvas path when viewing a recording
1273         https://bugs.webkit.org/show_bug.cgi?id=174967
1274
1275         Reviewed by Brian Burg.
1276
1277         * DumpRenderTree/TestOptions.h:
1278         * DumpRenderTree/TestOptions.mm:
1279         (TestOptions::TestOptions):
1280         * DumpRenderTree/mac/DumpRenderTree.mm:
1281         (setWebPreferencesForTestOptions):
1282         * WebKitTestRunner/TestController.cpp:
1283         (WTR::TestController::resetPreferencesToConsistentValues):
1284         (WTR::updateTestOptionsFromTestHeader):
1285         * WebKitTestRunner/TestOptions.h:
1286         (WTR::TestOptions::hasSameInitializationOptions const):
1287         Add plumbing for new InspectorAdditions runtime flag.
1288
1289 2017-08-07  obinna obike  <oobike@apple.com>
1290
1291         Sorted EWS Queues on Patch page
1292         https://bugs.webkit.org/show_bug.cgi?id=173667
1293
1294         Reviewed by Aakash Jain.
1295
1296         * QueueStatusServer/handlers/patch.py:
1297         (Patch.get): Sorted queue_status.
1298         * QueueStatusServer/templates/patch.html:
1299         Changed queue_status.items to queue_status because it's a list.
1300
1301 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1302
1303         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1304         https://bugs.webkit.org/show_bug.cgi?id=175286
1305
1306         Reviewed by Myles C. Maxfield.
1307
1308         * Scripts/webkitpy/style/checkers/cpp.py:
1309         (check_braces):
1310         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1311         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1312         (WebKitStyleTest.test_braces):
1313         (WebKitStyleTest.test_braces.NS_OPTIONS):
1314
1315 2017-08-07  Brian Burg  <bburg@apple.com>
1316
1317         Remove CANVAS_PATH compilation guard
1318         https://bugs.webkit.org/show_bug.cgi?id=175207
1319
1320         Reviewed by Sam Weinig.
1321
1322         * Scripts/webkitperl/FeatureList.pm:
1323         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1324
1325 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1326
1327         [Win] Use Visual Studio 2017 if installed.
1328         https://bugs.webkit.org/show_bug.cgi?id=175188
1329
1330         Reviewed by Sam Weinig.
1331
1332         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1333
1334         * Scripts/webkitdirs.pm:
1335         (visualStudioInstallDir):
1336         (msBuildInstallDir):
1337
1338 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1339
1340         [GTK][WPE] Add API to provide browser information required by automation
1341         https://bugs.webkit.org/show_bug.cgi?id=175130
1342
1343         Reviewed by Michael Catanzaro.
1344
1345         * MiniBrowser/gtk/main.c:
1346         (automationStartedCallback): Set browser information when a new automation session is started.
1347         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1348         (testAutomationSessionApplicationInfo):
1349         (beforeAll):
1350
1351 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1352
1353         Unreviewed, rolling out r220295.
1354
1355         This change introduced 4 errors in webkitpy tests.
1356
1357         Reverted changeset:
1358
1359         "[XCode] webkit-patch should run sort-Xcode-project-file"
1360         https://bugs.webkit.org/show_bug.cgi?id=174036
1361         http://trac.webkit.org/changeset/220295
1362
1363 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1364
1365         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1366
1367         Unreviewed test gardening.
1368
1369         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1370         (TestWebKitAPI::TEST):
1371
1372 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1373
1374         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1375         https://bugs.webkit.org/show_bug.cgi?id=175083
1376
1377         Reviewed by Oliver Hunt.
1378         
1379         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1380         to wait for VM destructions to finish before running the next test. This makes it easier to 
1381         understand leaks results from workers tests, and leads to fewer reported leaks.
1382
1383         * DumpRenderTree/mac/DumpRenderTree.mm:
1384         (runTest):
1385
1386 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1387
1388         check-webkit-style: fix path-specific rules for WebKit2 rename
1389         https://bugs.webkit.org/show_bug.cgi?id=175182
1390
1391         Reviewed by David Kilzer.
1392
1393         * Scripts/webkitpy/style/checker.py:
1394
1395 2017-08-04  Youenn Fablet  <youenn@apple.com>
1396
1397         [Cache API] Add Cache and CacheStorage IDL definitions
1398         https://bugs.webkit.org/show_bug.cgi?id=175201
1399
1400         Reviewed by Brady Eidson.
1401
1402         * DumpRenderTree/mac/DumpRenderTree.mm:
1403         (enableExperimentalFeatures):
1404         (resetWebPreferencesToConsistentValues):
1405         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1406         (WTR::InjectedBundle::beginTesting):
1407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1408         (WTR::TestRunner::setCacheAPIEnabled):
1409         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1410
1411 2017-08-04  John Wilander  <wilander@apple.com>
1412
1413         Resource Load Statistics: Report user interaction immediately, but only when needed
1414         https://bugs.webkit.org/show_bug.cgi?id=175090
1415         <rdar://problem/33685546>
1416
1417         Reviewed by Chris Dumez.
1418
1419         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1420         (WTR::InjectedBundle::beginTesting):
1421             Now calls WebCore::ResourceLoadObserver::clearState().
1422
1423 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1424
1425         Add an API test for r220286
1426         https://bugs.webkit.org/show_bug.cgi?id=175206
1427
1428         Reviewed by Simon Fraser.
1429
1430         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1431         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1432         (createAnimatedResizeWebView):
1433         (TEST):
1434         Add a test to ensure that we don't call
1435         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1436         animated resize.
1437
1438 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1439
1440         [XCode] webkit-patch should run sort-Xcode-project-file
1441         https://bugs.webkit.org/show_bug.cgi?id=174036
1442
1443         Reviewed by Simon Fraser.
1444
1445         * Scripts/webkitpy/common/config/ports.py:
1446         * Scripts/webkitpy/tool/commands/download.py:
1447         * Scripts/webkitpy/tool/commands/upload.py:
1448         * Scripts/webkitpy/tool/steps/__init__.py:
1449         * Scripts/webkitpy/tool/steps/options.py:
1450         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1451
1452 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1453
1454         REGRESSION(r219857): run-benchmark --allplans broken
1455         https://bugs.webkit.org/show_bug.cgi?id=175186
1456
1457         Reviewed by Saam Barati.
1458
1459         r219857 forgot to update also the calls to BenchmarkRunner() that
1460         is done when the script is run with --allplans.
1461
1462         To fix this (and avoid future issues like this), let's factorize
1463         the calls to the benchhmark runner in a run_benchmark_plan()
1464         function.
1465
1466         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1467         (run_benchmark_plan):
1468         (start):
1469
1470 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1471
1472         Dashboard bubbles sometimes show failure count instead of crash count
1473         https://bugs.webkit.org/show_bug.cgi?id=175157
1474         <rdar://problem/33709009>
1475
1476         Reviewed by Alexey Proskuryakov.
1477
1478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1479         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1480
1481 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1482
1483         Add tests for NeverDestroyed
1484         https://bugs.webkit.org/show_bug.cgi?id=175146
1485
1486         Reviewed by Darin Adler.
1487
1488         * CMakeLists.txt:
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         New files and sort.
1491
1492         * TestWebKitAPI/Tests/WTF/Logger.h:
1493         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1494         (TestWebKitAPI::log):
1495         (TestWebKitAPI::takeLogStr):
1496         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1497         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1498         (TestWebKitAPI::log): Deleted.
1499         (TestWebKitAPI::takeLogStr): Deleted.
1500         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1501
1502         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1503         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1504         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1505         (TestWebKitAPI::LifecycleLogger::operator=):
1506         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1507         (TestWebKitAPI::LifecycleLogger::setName):
1508         (TestWebKitAPI::TEST):
1509         Add a class that logs construction / assignment / modifications.
1510
1511         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1512         (TestWebKitAPI::TEST):
1513         (TestWebKitAPI::list):
1514         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1515
1516 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1517
1518         minification logic is not implemented for ios builds
1519         <rdar://problem/33726561>
1520
1521         Reviewed by Dean Johnson
1522
1523         * BuildSlaveSupport/built-product-archive:
1524         (minifyDirectory): refactor minifySource -> minifyDirectory
1525         (archiveBuiltProduct): add ios minification logic
1526         (minifySource): Deleted.
1527
1528 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1529
1530         Unreviewed, rolling out r220271.
1531
1532         Rolling out due to Layout Test failing on iOS Simulator.
1533
1534         Reverted changeset:
1535
1536         "Remove STREAMS_API compilation guard"
1537         https://bugs.webkit.org/show_bug.cgi?id=175165
1538         http://trac.webkit.org/changeset/220271
1539
1540 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1541
1542         Unreviewed, rolling out r220268.
1543
1544         This change caused assertion failures on macOS and iOS Debug
1545         WK2.
1546
1547         Reverted changeset:
1548
1549         "Resource Load Statistics: Report user interaction
1550         immediately, but only when needed"
1551         https://bugs.webkit.org/show_bug.cgi?id=175090
1552         http://trac.webkit.org/changeset/220268
1553
1554 2017-08-04  Youenn Fablet  <youenn@apple.com>
1555
1556         Remove STREAMS_API compilation guard
1557         https://bugs.webkit.org/show_bug.cgi?id=175165
1558
1559         Reviewed by Darin Adler.
1560
1561         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1562
1563 2017-08-04  John Wilander  <wilander@apple.com>
1564
1565         Resource Load Statistics: Report user interaction immediately, but only when needed
1566         https://bugs.webkit.org/show_bug.cgi?id=175090
1567         <rdar://problem/33685546>
1568
1569         Reviewed by Chris Dumez.
1570
1571         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1572         (WTR::InjectedBundle::beginTesting):
1573             Now calls WebCore::ResourceLoadObserver::clearState().
1574
1575 2017-08-03  Brian Burg  <bburg@apple.com>
1576
1577         Remove ENABLE(WEB_SOCKET) guards
1578         https://bugs.webkit.org/show_bug.cgi?id=167044
1579
1580         Reviewed by Joseph Pecoraro.
1581
1582         * Scripts/webkitperl/FeatureList.pm:
1583         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1584
1585 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1586
1587         REGRESSION(r219850): run-benchmark script broken on Linux
1588         https://bugs.webkit.org/show_bug.cgi?id=175126
1589
1590         Reviewed by Stephanie Lewis.
1591
1592         The run-benchmark script dynamically generates the list of supported
1593         browsers and platforms (currently Linux and OSX) by loading all
1594         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1595         and getting the browser_name and platform variables from the
1596         classes defined there.
1597
1598         This means that this classes should not raise an exception when
1599         loaded on other platforms or otherwise they will broke the whole
1600         script. Its fine if they raise an exception when executing any of
1601         the methods they implement, but not when just loading/importing
1602         the class.
1603
1604         Move the argument variable definitions that call on the platform
1605         specific OSXBrowserDriver._screen_size() function from beeing
1606         variables that are evaluated when loading the file, to be functions
1607         that are only evaluated when the actual functionality needs to be
1608         executed.
1609
1610         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1611         (OSXChromeDriver.launch_url):
1612         (OSXChromeCanaryDriver.launch_url):
1613         (create_args):
1614         (create_chrome_options):
1615         (create_window_size_arg):
1616         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1617         (OSXFirefoxDriver.launch_url):
1618         (OSXFirefoxNightlyDriver.launch_url):
1619         (OSXFirefoxNightlyDriver.launch_driver):
1620         (create_args):
1621
1622 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1623
1624         [PAL] Move spi/cf directory into PAL
1625         https://bugs.webkit.org/show_bug.cgi?id=175057
1626
1627         Reviewed by Antti Koivisto.
1628
1629         * Scripts/webkitpy/style/checker.py:
1630         * Scripts/webkitpy/style/checker_unittest.py:
1631         (GlobalVariablesTest.test_path_rules_specifier):
1632
1633         Ignore "readability/naming/underscores" style errors for sources
1634         under the WebCore/PAL/pal/spi directory.
1635
1636         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1637
1638 2017-08-03  Youenn Fablet  <youenn@apple.com>
1639
1640         Remove FETCH_API compilation guard
1641         https://bugs.webkit.org/show_bug.cgi?id=175154
1642
1643         Reviewed by Chris Dumez.
1644
1645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1646
1647 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1648
1649         Enable archive minification on iOS builds
1650         https://bugs.webkit.org/show_bug.cgi?id=174718
1651         
1652         Reviewed by Aakash Jain.
1653
1654         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1655         (BuildFactory.__init__):
1656
1657 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1658
1659         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1660         https://bugs.webkit.org/show_bug.cgi?id=175140
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         We are having lately issues with JSC tests causing problems on
1665         the GTK+ and WPE bots due to the high amount of memory some tests
1666         need to run.
1667
1668         The best thing we can do now is to workaround this by disabling
1669         all the tests marked as memoryLimited on the GTK and WPE bots.
1670         We may revise this on the future.
1671
1672         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1673         (RunJavaScriptCoreTests.start):
1674
1675 2017-08-03  Brady Eidson  <beidson@apple.com>
1676
1677         Add SW IDLs and stub out basic functionality.
1678         https://bugs.webkit.org/show_bug.cgi?id=175115
1679
1680         Reviewed by Chris Dumez.
1681
1682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1683
1684         * Scripts/webkitpy/bindings/main.py:
1685
1686 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1687
1688         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1689         https://bugs.webkit.org/show_bug.cgi?id=159510
1690
1691         Reviewed by Daniel Bates.
1692
1693         Allow any https certificate when running tests.
1694
1695         * DumpRenderTree/win/DumpRenderTree.cpp:
1696         (runTest):
1697
1698 2017-08-02  Youenn Fablet  <youenn@apple.com>
1699
1700         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1701         https://bugs.webkit.org/show_bug.cgi?id=175089
1702
1703         Reviewed by Chris Dumez.
1704
1705         * DumpRenderTree/TestOptions.mm:
1706         (TestOptions::TestOptions): Using absolutePath if available.
1707         * DumpRenderTree/mac/DumpRenderTree.mm:
1708         (computeTestURL): Removing http/tests/ specific URL computation.
1709         * Scripts/webkitpy/port/driver.py:
1710         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1711
1712 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1713
1714         download-built-product should allow for a proxy option
1715         https://bugs.webkit.org/show_bug.cgi?id=174875
1716
1717         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1718
1719         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1720         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1721         
1722
1723 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1724
1725         check-webkit-style: deleting lines in a file runs the linter on the whole file
1726         https://bugs.webkit.org/show_bug.cgi?id=175078
1727
1728         Reviewed by David Kilzer.
1729
1730         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1731         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1732
1733         * Scripts/webkitpy/style/checkers/test_expectations.py:
1734         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1735         * Scripts/webkitpy/style/main_unittest.py:
1736         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1737         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1738         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1739
1740 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1741
1742         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1743         https://bugs.webkit.org/show_bug.cgi?id=175075
1744
1745         Reviewed by David Kilzer.
1746
1747         We have no way of handling text files with illegal unicode characters. Allow the callers of
1748         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1749         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1750
1751         * Scripts/webkitpy/common/system/filesystem.py:
1752         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1753         (FileSystem.write_text_file): Ditto.
1754         * Scripts/webkitpy/common/system/filesystem_mock.py:
1755         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1756         (MockFileSystem.write_text_file): Ditto.
1757         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1758         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1759         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1760
1761 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1762
1763         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1764         https://bugs.webkit.org/show_bug.cgi?id=175072
1765
1766         Reviewed by Alexey Proskuryakov.
1767
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1769         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1770
1771 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1772
1773         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1774         https://bugs.webkit.org/show_bug.cgi?id=175019
1775
1776         Reviewed by Darin Adler.
1777
1778         * TestWebKitAPI/CMakeLists.txt:
1779
1780 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1781
1782         Enabling uploading archives to S3
1783         https://bugs.webkit.org/show_bug.cgi?id=174198
1784
1785         Unreviewed unit test fix after r219235.
1786
1787         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1788
1789 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1790
1791         Fix JSCOnly ARM buildbots after r220047
1792         https://bugs.webkit.org/show_bug.cgi?id=174993
1793
1794         Unreviewed fix after r220087.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1797         (BuildAndRemoteJSCTestsFactory.__init__):
1798
1799 2017-08-01  Chris Dumez  <cdumez@apple.com>
1800
1801         Add initial support for navigator.sendBeacon
1802         https://bugs.webkit.org/show_bug.cgi?id=175007
1803         <rdar://problem/33547728>
1804
1805         Reviewed by Sam Weinig.
1806
1807         Enable the Beacon API at runtime in the context of layout tests since the
1808         feature is currently disabled by default.
1809
1810         * DumpRenderTree/mac/DumpRenderTree.mm:
1811         (enableExperimentalFeatures):
1812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1813         (WTR::InjectedBundle::beginTesting):
1814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1815         (WTR::TestRunner::setModernMediaControlsEnabled):
1816         (WTR::TestRunner::setBeaconAPIEnabled):
1817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1818
1819 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1820
1821         Update Bot Watcher's Dashboard for Buildbot 0.9
1822         https://bugs.webkit.org/show_bug.cgi?id=174777
1823
1824         Reviewed by Daniel Bates.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1827         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1828         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1829         in a dictionary.
1830         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1831         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1832         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1833         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1834         (parseRevisionProperty): Ditto.
1835         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1836         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1837         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1838         have changed in Buildbot 0.9.
1839         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1840         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1841         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1842         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1843         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1844         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1845         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1846         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1847         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1848         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1850         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1851         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1852         (BuildbotQueue.prototype.get overviewURL): Ditto.
1853         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1854         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1855         Buildbot 0.8 or 0.9.
1856         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1857         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1858         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1859         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1860         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1861         Therefore we are fetching information for fixed number of build. 
1862         Also iterating the loop incrementally since the build data is already reverse sorted.
1863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1864         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1865         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1867         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1868
1869 2017-08-01  Devin Rousso  <drousso@apple.com>
1870
1871         Web Inspector: simplify WebInspector with WI
1872         https://bugs.webkit.org/show_bug.cgi?id=175058
1873
1874         Reviewed by Joseph Pecoraro.
1875
1876         * Scripts/check-inspector-strings:
1877         (extract_ui_strings):
1878         * Scripts/extract-localizable-js-strings:
1879
1880 2017-08-01  Youenn Fablet  <youenn@apple.com>
1881
1882         Layout tests with 'https' suffix should be run over HTTPS
1883         https://bugs.webkit.org/show_bug.cgi?id=174992
1884
1885         Reviewed by Chris Dumez.
1886
1887         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1888         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1889         Covered by corresponding unit tests.
1890
1891         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1892         (run_server):
1893         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1894         (base_http_url):
1895         (base_https_url):
1896         (base_url): Deleted.
1897         * Scripts/webkitpy/port/base.py:
1898         (Port.to.web_platform_test_server_base_http_url):
1899         (Port.to):
1900         (Port.to.web_platform_test_server_base_https_url):
1901         (Port.to.web_platform_test_server_base_url): Deleted.
1902         * Scripts/webkitpy/port/driver.py:
1903         (Driver.__init__):
1904         (Driver.wpt_test_path_to_uri):
1905         (Driver):
1906         (Driver.http_test_path_to_uri):
1907         (Driver.test_to_uri):
1908         (Driver.uri_to_test):
1909         * Scripts/webkitpy/port/driver_unittest.py:
1910         (DriverTest.test_test_to_uri):
1911         (DriverTest.test_uri_to_test):
1912
1913 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1914
1915         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1916         https://bugs.webkit.org/show_bug.cgi?id=173998
1917
1918         Reviewed by Darin Adler.
1919
1920         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1921         detect mistakes in backward compatibility in the future when we change it.
1922
1923         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1924         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1925         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1926         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1927         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1928         internal key data slot.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1932         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1933         (getNextMessage):
1934         (TEST):
1935         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1936         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1937         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1938         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1939         These are the pre-baked databases.
1940         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1941         This is the actual test that do all the reads and comparisons.
1942         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1943         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1944         IndexedDB new stuffs. Then it can be used to bake the database again.
1945
1946 2017-08-01  Brady Eidson  <beidson@apple.com>
1947
1948         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1949         https://bugs.webkit.org/show_bug.cgi?id=175030
1950
1951         Reviewed by Andy Estes.
1952
1953         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1954         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1955
1956 2017-08-01  Brady Eidson  <beidson@apple.com>
1957
1958         Part 2 of: Rename DatabaseProcess to StorageProcess.
1959         https://bugs.webkit.org/show_bug.cgi?id=174880
1960
1961         Reviewed by Andy Estes.
1962
1963         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1964         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1965         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1966         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1967         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1968         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1969         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1970         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1971
1972 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1973
1974         Fix JSCOnly ARM buildbots after r220047
1975         https://bugs.webkit.org/show_bug.cgi?id=174993
1976
1977         Reviewed by Saam Barati.
1978
1979         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1980         (BuildAndRemoteJSCTestsFactory.__init__):
1981
1982 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1983
1984         [WTF] Introduce Private Symbols
1985         https://bugs.webkit.org/show_bug.cgi?id=174935
1986
1987         Reviewed by Darin Adler.
1988
1989         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1990         (TestWebKitAPI::TEST):
1991
1992 2017-07-30  Darin Adler  <darin@apple.com>
1993
1994         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1995         https://bugs.webkit.org/show_bug.cgi?id=130653
1996
1997         Reviewed by Antti Koivisto.
1998
1999         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2000         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
2001         when calling frameDidChangeLocation.
2002         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
2003         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
2004         thus causing mysterious failures of a couple of tests. There are two remaining issues:
2005         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
2006         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
2007         same logic flaw that causes "top loading frame" to get set to one of the subframes in
2008         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
2009         loading, subframe starts loading. It would be good to clean that up some day, but for now
2010         this patch makes the two work identically rather than changing both.
2011         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2012
2013 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2014
2015         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2016         https://bugs.webkit.org/show_bug.cgi?id=174963
2017
2018         Reviewed by Darin Adler.
2019
2020         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2021         RetainPtr<>. This patch changes them to all use auto.
2022
2023         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2024         (TestWebKitAPI::TEST):
2025
2026 2017-07-30  Brady Eidson  <beidson@apple.com>
2027
2028         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2029         https://bugs.webkit.org/show_bug.cgi?id=174958
2030
2031         Reviewed by Darin Adler.
2032
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2034         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2035         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2036         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2037         (runUntilTasksInFlight):
2038         (TEST):
2039
2040 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2041
2042         Unreviewed, rolling out r219990.
2043         https://bugs.webkit.org/show_bug.cgi?id=174961
2044
2045         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2046         estes on #webkit).
2047
2048         Reverted changeset:
2049
2050         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2051         https://bugs.webkit.org/show_bug.cgi?id=174880
2052         http://trac.webkit.org/changeset/219990
2053
2054 2017-07-28  Brady Eidson  <beidson@apple.com>
2055
2056         API tests that use URLSchemeHandler are failing.
2057         https://bugs.webkit.org/show_bug.cgi?id=174950
2058
2059         Reviewed by Alex Christensen.
2060
2061         Fix the NoMIMEType test to be correct.
2062
2063         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2064         (-[SchemeHandler initWithData:mimeType:]):
2065         (-[SchemeHandler webView:startURLSchemeTask:]):
2066         (TEST):
2067
2068 2017-07-28  Daniel Bates  <dabates@apple.com>
2069
2070         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2071         https://bugs.webkit.org/show_bug.cgi?id=174876
2072
2073         Reviewed by Alex Christensen.
2074
2075         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2076         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2077         they provide a more direct way to test the platform abstraction.
2078
2079         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2080
2081         * Scripts/prepare-ChangeLog:
2082         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2083         of the current working directory.
2084
2085 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2086
2087         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2088         https://bugs.webkit.org/show_bug.cgi?id=174930
2089
2090         Unreviewed test fix.
2091
2092         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2093
2094         * Scripts/prepare-ChangeLog:
2095         (get_function_line_ranges_for_cpp):
2096
2097 2017-07-28  JF Bastien  <jfbastien@apple.com>
2098
2099         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2100         https://bugs.webkit.org/show_bug.cgi?id=174930
2101
2102         Reviewed by Daniel Bates.
2103
2104         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2105         here also teach it about const and volatile overloads. I didn't do
2106         reference and rvalue reference overloads because we don't really
2107         use them, and the current parser throws away those characters and
2108         it doesn't seem worth making it more complex.
2109
2110         * Scripts/prepare-ChangeLog:
2111         (get_function_line_ranges_for_cpp):
2112         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2113         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2114         (Foo::Arrow::arrow):
2115         (Foo::Arrow::otherArrow):
2116         (Foo::Arrow::otherArrow const):
2117         (Foo::Arrow::otherArrow volatile):
2118         (Foo::Arrow::otherArrow const volatile):
2119
2120 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2121
2122         [GTK] Building with ENABLE_VIDEO=OFF fails
2123         https://bugs.webkit.org/show_bug.cgi?id=174940
2124
2125         Reviewed by Alex Christensen.
2126
2127         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2128         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2129
2130         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2131         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2132
2133 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2134
2135         [WPE] Implement EventSenderProxy in WTR
2136         https://bugs.webkit.org/show_bug.cgi?id=173419
2137
2138         Reviewed by Žan Doberšek.
2139
2140         Add the implementation of EventSenderProxy to the WTR. This
2141         allows us to extend the coverage of the test suite in WKWPE.
2142
2143         * WebKitTestRunner/EventSenderProxy.h:
2144         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2145         libxkbcommon needed to deal with key events.
2146         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2147         (WTR::EventSenderProxy::EventSenderProxy):
2148         (WTR::senderButtonToWPEButton):
2149         (WTR::EventSenderProxy::mouseDown):
2150         (WTR::EventSenderProxy::mouseUp):
2151         (WTR::EventSenderProxy::mouseMoveTo):
2152         (WTR::EventSenderProxy::mouseScrollBy):
2153         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2154         (WTR::EventSenderProxy::leapForward):
2155         (WTR::wkEventModifiersToWPE):
2156         (WTR::getXKBKeySymForKeyRef):
2157         (WTR::EventSenderProxy::keyDown):
2158         (WTR::EventSenderProxy::addTouchPoint):
2159         (WTR::EventSenderProxy::updateTouchPoint):
2160         (WTR::EventSenderProxy::setTouchModifier):
2161         (WTR::EventSenderProxy::setTouchPointRadius):
2162         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2163         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2164         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2165         (WTR::EventSenderProxy::touchStart):
2166         (WTR::EventSenderProxy::touchMove):
2167         (WTR::EventSenderProxy::touchEnd):
2168         (WTR::EventSenderProxy::touchCancel):
2169         (WTR::EventSenderProxy::clearTouchPoints):
2170         (WTR::EventSenderProxy::releaseTouchPoint):
2171         (WTR::EventSenderProxy::cancelTouchPoint):
2172
2173 2017-07-27  Brady Eidson  <beidson@apple.com>
2174
2175         Part 2 of: Rename DatabaseProcess to StorageProcess.
2176         https://bugs.webkit.org/show_bug.cgi?id=174880
2177
2178         Reviewed by Andy Estes.
2179
2180         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2182         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2183         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2184         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2185         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2186         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2187         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2188
2189 2017-07-26  Mark Lam  <mark.lam@apple.com>
2190
2191         Add ability to only run specific tests in run-javascriptcore-tests.
2192         https://bugs.webkit.org/show_bug.cgi?id=174884
2193
2194         Reviewed by Saam Barati.
2195
2196         For example, if we only want to run testapi, we can do so as follows:
2197             $ run-javascriptcore-tests --testapi
2198
2199         Previously, specifying --testapi effectively does nothing because we run all tests
2200         by default.  Only --no-testapi had the effect of disabling the test set.  This
2201         old behavior for --testapi is not very useful or meaningful.  We're now changing
2202         it to mean that we will only run that test.
2203
2204         With this change, we can also run more than one set of tests.  For example, if we
2205         only want to run testmasm and testair, we can do so as follows:
2206             $ run-javascriptcore-tests --testmasm --testair
2207
2208         By default, if no specific test option is specified, run-javascriptcore-tests will
2209         run all tests.
2210
2211         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2212         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2213         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2214         the other set will not run.  For example, the following only runs the mozilla tests:
2215             $ run-javascriptcore-tests --mozilla-tests
2216
2217         Note also that --jit-stress-tests is not for choosing a different set of tests.
2218         Instead, it is used for determining whether we run JIT'ed test configurations
2219         on the jsc stress tests and mozilla tests.  As a result, specifying
2220         --jit-stress-tests will not omit other tests.  For example, the following still
2221         runs all tests:
2222             $ run-javascriptcore-tests --jit-stress-tests
2223
2224         * Scripts/run-javascriptcore-tests:
2225         (defaultStringForTestState):
2226         (enableTestOrNot):
2227         (runJSCStressTests):
2228
2229 2017-07-26  Mark Lam  <mark.lam@apple.com>
2230
2231         Make run-javascriptcore-test run testair, testb3, and testmasm.
2232         https://bugs.webkit.org/show_bug.cgi?id=174837
2233         <rdar://problem/33522927>
2234
2235         Reviewed by Saam Barati and Filip Pizlo.
2236
2237         1. Refactors code for running testapi so that we can use it to run other tests.
2238         2. Added running of testmasm, testair, testb3.
2239
2240         Note: the existing testapi invocation code does not support remote invocation of
2241         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2242         and testb3 also do not support remote invocation.  If we wish to add remote
2243         invocation support, we should do that in a separate patch.
2244
2245         * Scripts/run-javascriptcore-tests:
2246         (testPath):
2247         (runTest):
2248         (testapiPath): Deleted.
2249
2250 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2251
2252         Remove duplicate code from Buildbot.js in dashboard
2253         https://bugs.webkit.org/show_bug.cgi?id=174870
2254
2255         Reviewed by Daniel Bates.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2258         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2259         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2261         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2262
2263 2017-07-26  Brady Eidson  <beidson@apple.com>
2264
2265         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2266         https://bugs.webkit.org/show_bug.cgi?id=174851
2267
2268         Reviewed by Chris Dumez.
2269
2270         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2271         (TEST):
2272
2273 2017-07-26  Brian Burg  <bburg@apple.com>
2274
2275         Remove WEB_TIMING feature flag
2276         https://bugs.webkit.org/show_bug.cgi?id=174795
2277
2278         Reviewed by Alex Christensen.
2279
2280         * Scripts/webkitperl/FeatureList.pm:
2281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2282
2283 2017-07-26  Chris Dumez  <cdumez@apple.com>
2284
2285         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2286         https://bugs.webkit.org/show_bug.cgi?id=174864
2287         <rdar://problem/33009088>
2288
2289         Reviewed by Geoffrey Garen.
2290
2291         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2292         WKTR.
2293
2294         * DumpRenderTree/mac/EventSendingController.mm:
2295         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2296
2297 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2298
2299         Unreviewed, added Romain Bellessort to contributors.json.
2300
2301         * Scripts/webkitpy/common/config/contributors.json:
2302
2303 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2304
2305         [WPE] WebGL2 support
2306         https://bugs.webkit.org/show_bug.cgi?id=174249
2307
2308         Reviewed by Alex Christensen.
2309
2310         * Scripts/webkitperl/FeatureList.pm:
2311         Enable WebGL2 for WPE when building through build-webkit.
2312
2313 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         Unreviewed. Fix GTK distcheck.
2316
2317         * gtk/make-dist.py:
2318         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2319
2320 2017-07-25  Brady Eidson  <beidson@apple.com>
2321
2322         ResourceLoadStatistics grandfathering happens much too often.
2323         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2324
2325         Reviewed by Chris Dumez.
2326
2327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2328         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2329         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2330         (TEST):
2331
2332 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2333
2334         Fix autoinstaller failing on autoinstall_everything
2335         https://bugs.webkit.org/show_bug.cgi?id=174830
2336
2337         Reviewed by Joseph Pecoraro.
2338
2339         * Scripts/webkitpy/thirdparty/__init__.py:
2340         (AutoinstallImportHook.find_module):
2341         (AutoinstallImportHook.install_chromedriver):
2342         (AutoinstallImportHook.install_geckodriver):
2343         (AutoinstallImportHook._install_chromedriver): Deleted.
2344         (AutoinstallImportHook._install_geckodriver): Deleted.
2345
2346 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2347
2348         Replace --runtime with something for both ios-simulator and ios-device
2349         https://bugs.webkit.org/show_bug.cgi?id=173775
2350         <rdar://problem/32952164>
2351
2352         Reviewed by Aakash Jain.
2353
2354         Add --version flag for both iOS simulator and iOS device.
2355
2356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2357         (parse_args): Add --version flag and move --no-install.
2358         * Scripts/webkitpy/port/factory.py:
2359         (platform_options): Move --no-intall to run_webkit_tests.py.
2360         * Scripts/webkitpy/port/ios.py:
2361         (IOSPort):
2362         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2363         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2364         * Scripts/webkitpy/port/ios_device.py:
2365         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2366         devices for iOS version.
2367         * Scripts/webkitpy/port/ios_device_unittest.py:
2368         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2369         expectation paths without devices connected.
2370         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2371         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2372         (IOSDeviceTest.test_expectations_ordering): Deleted.
2373         * Scripts/webkitpy/port/ios_simulator.py:
2374         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2375         flag to specify a runtime.
2376         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2377         flag and then use the default runtime.
2378
2379 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2380
2381         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2382         https://bugs.webkit.org/show_bug.cgi?id=174815
2383
2384         Reviewed by Carlos Alberto Lopez Perez.
2385
2386         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2387         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2388         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2389         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2390         think), probably because of a newer CMake version.
2391
2392         * CMakeLists.txt:
2393         * TestWebKitAPI/CMakeLists.txt:
2394         * TestWebKitAPI/PlatformGTK.cmake:
2395
2396 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2397
2398         Fix BenchmarkRunner to only import selenium when needed
2399         https://bugs.webkit.org/show_bug.cgi?id=174808
2400
2401         Reviewed by Stephanie Lewis.
2402
2403         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2404         (LinuxChromeDriver.launch_driver):
2405         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2406         (LinuxFirefoxDriver.launch_driver):
2407         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2408         (OSXChromeDriver.launch_driver):
2409         (OSXChromeCanaryDriver.launch_driver):
2410         (create_chrome_options):
2411         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2412         (OSXFirefoxDriver.launch_driver):
2413         (OSXFirefoxNightlyDriver.launch_driver):
2414         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2415         (OSXSafariDriver.launch_driver):
2416         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2417         (WebDriverBenchmarkRunner._run_one_test):
2418
2419 2017-07-23  Darin Adler  <darin@apple.com>
2420
2421         More NeverDestroyed and related cleanup
2422         https://bugs.webkit.org/show_bug.cgi?id=174745
2423
2424         Reviewed by Alex Christensen.
2425
2426         * DumpRenderTree/JavaScriptThreading.cpp:
2427         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2428         DEPRECATED_DEFINE_STATIC_LOCAL.
2429         (javaScriptThreads): Ditto.
2430
2431 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2432
2433         Subclass Benchmark Runner script for WebDriver support
2434         https://bugs.webkit.org/show_bug.cgi?id=174390
2435
2436         Reviewed by Dewei Zhu, Stephanie Lewis.
2437
2438         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2439
2440         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2441         (BenchmarkBuilder.__init__):
2442         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2443         (BenchmarkRunner.__init__):
2444         (BenchmarkRunner._find_plan_file):
2445         (BenchmarkRunner._run_one_test.and):
2446         (BenchmarkRunner.execute):
2447         (BenchmarkRunner._get_result): Deleted.
2448         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2449         (parse_args):
2450         (start):
2451         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2452         (WebDriverBenchmarkRunner):
2453         (WebDriverBenchmarkRunner._get_result):
2454         (WebDriverBenchmarkRunner._run_one_test):
2455         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2456         (WebServerBenchmarkRunner):
2457         (WebServerBenchmarkRunner.__init__):
2458         (WebServerBenchmarkRunner._get_result):
2459         (WebServerBenchmarkRunner._run_one_test):
2460
2461 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2462
2463         Add BenchmarkRunner patches with WebDriver support for each testing plan
2464         https://bugs.webkit.org/show_bug.cgi?id=174443
2465
2466         Reviewed by Dewei Zhu, Stephanie Lewis.
2467
2468         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2469         (BenchmarkBuilder.__enter__):
2470         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2471         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2472         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2473         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2474         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2475         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2476         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2477         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2478         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2479         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2480         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2481         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2482         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2483         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2484         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2485         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2486         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2487         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2488         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2489         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2490         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2491         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2492         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2493         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2494         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2495         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2496         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2497         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2498         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2499         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2500         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2501         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2502         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2503
2504 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2505
2506         Add functions to autoinstaller needed for Benchmark Runner script
2507         https://bugs.webkit.org/show_bug.cgi?id=174331
2508
2509         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2510
2511         Adds autoinstaller functions to install selenium and webdriver binaries
2512         which will be used by the browser driver part of Benchmark Runner.
2513
2514         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2515         (BrowserDriver.restore_env):
2516         (BrowserDriver):
2517         (BrowserDriver.get_webdriver_binary_path):
2518         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2519         (LinuxChromeDriver.launch_driver):
2520         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2521         (LinuxFirefoxDriver.launch_driver):
2522         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2523         (OSXChromeDriver.launch_driver):
2524         (OSXChromeCanaryDriver.launch_driver):
2525         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2526         (OSXFirefoxDriver.launch_driver):
2527         (OSXFirefoxNightlyDriver.launch_driver):
2528         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2529         * Scripts/webkitpy/benchmark_runner/utils.py:
2530         (get_driver_binary_path):
2531         * Scripts/webkitpy/common/system/autoinstall.py:
2532         (AutoInstaller._unzip):
2533         * Scripts/webkitpy/thirdparty/__init__.py:
2534         (AutoinstallImportHook.find_module):
2535         (AutoinstallImportHook._install_selenium):
2536         (AutoinstallImportHook):
2537         (AutoinstallImportHook._install_chromedriver):
2538         (AutoinstallImportHook._install_geckodriver):
2539         (AutoinstallImportHook.get_latest_pypi_url):
2540         (AutoinstallImportHook.install_binary):
2541         (autoinstall_everything):
2542         (get_driver_filename):
2543         (get_os_info):
2544
2545 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2546
2547         Add WebDriver support in browser driver part of BenchmarkRunner
2548         https://bugs.webkit.org/show_bug.cgi?id=174445
2549
2550         Reviewed by Stephanie Lewis.
2551
2552         Adds a launch_driver function to each BrowserDriver subclass. This
2553         function sets up the arguments for the webdriver and launches the
2554         webdriver specific to that browser.
2555
2556         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2557         (BrowserDriver.launch_webdriver):
2558         (BrowserDriver):
2559         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2560         (LinuxBrowserDriver.launch_webdriver):
2561         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2562         (LinuxChromeDriver.launch_url):
2563         (LinuxChromeDriver):
2564         (LinuxChromeDriver.launch_driver):
2565         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2566         (EpiphanyBrowserDriver.launch_url):
2567         (EpiphanyBrowserDriver):
2568         (EpiphanyBrowserDriver.launch_driver):
2569         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2570         (LinuxFirefoxDriver):
2571         (LinuxFirefoxDriver.launch_url):
2572         (LinuxFirefoxDriver.launch_driver):
2573         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2574         (GTKMiniBrowserDriver.launch_url):
2575         (GTKMiniBrowserDriver):
2576         (GTKMiniBrowserDriver.launch_driver):
2577         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2578         (OSXBrowserDriver._launch_webdriver):
2579         (OSXBrowserDriver):
2580         (OSXBrowserDriver._screen_size):
2581         (OSXBrowserDriver._insert_url):
2582         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2583         (OSXChromeDriver):
2584         (OSXChromeDriver.launch_url):
2585         (OSXChromeDriver.launch_driver):
2586         (OSXChromeCanaryDriver):
2587         (OSXChromeCanaryDriver.launch_url):
2588         (OSXChromeCanaryDriver.launch_driver):
2589         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2590         (OSXFirefoxDriver):
2591         (OSXFirefoxDriver.launch_url):
2592         (OSXFirefoxDriver.launch_driver):
2593         (OSXFirefoxNightlyDriver):
2594         (OSXFirefoxNightlyDriver.launch_url):
2595         (OSXFirefoxNightlyDriver.launch_driver):
2596         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2597         (OSXSafariDriver.launch_driver):
2598
2599 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2600
2601         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2602         https://bugs.webkit.org/show_bug.cgi?id=174793
2603
2604         Reviewed by Tim Horton.
2605
2606         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2607         down. Without r219765, this test will dereference null and crash.
2608
2609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2610         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2611         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2612         (TEST):
2613
2614 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2615
2616         [Win] Implement Authentication dialog in MiniBrowser
2617         https://bugs.webkit.org/show_bug.cgi?id=174662
2618
2619         Reviewed by Alex Christensen.
2620
2621         * MiniBrowser/win/Common.cpp:
2622         (CustomUserAgent):
2623         (DisplayAuthDialog):
2624         (AuthDialogProc):
2625         * MiniBrowser/win/MiniBrowserLib.rc:
2626         * MiniBrowser/win/MiniBrowserLibResource.h:
2627         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2628         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2629
2630 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2631
2632         Handle case where line_numbers is None instead of an array of line numbers
2633         https://bugs.webkit.org/show_bug.cgi?id=174775
2634
2635         Reviewed by Aakash Jain.
2636
2637         Added files set line_numbers to None in process_file.
2638
2639         * Scripts/webkitpy/style/filereader.py:
2640         (TextFileReader.process_file): Handle case where line_number is set to None.
2641         * Scripts/webkitpy/style/main_unittest.py:
2642         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2643
2644 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2645
2646         [WPE] Add libepoxy to the Jhbuild moduleset
2647         https://bugs.webkit.org/show_bug.cgi?id=174711
2648
2649         Reviewed by Carlos Alberto Lopez Perez.
2650
2651         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2652
2653 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2654
2655         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2656         https://bugs.webkit.org/show_bug.cgi?id=174780
2657
2658         Reviewed by Carlos Garcia Campos.
2659
2660         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2661         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2662         in case the eglplatform.h header doesn't provide that macro. This replicates
2663         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2664
2665 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2666
2667         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2668         https://bugs.webkit.org/show_bug.cgi?id=174758
2669
2670         Reviewed by Dan Bernstein.
2671
2672         Migrate position-information-related unit tests from the PositionInformationTests suite to
2673         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2674
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2677         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2678         (TestWebKitAPI::TEST):
2679         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2680         * TestWebKitAPI/cocoa/TestWKWebView.h:
2681         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2682         (-[TestWKWebView activatedElementAtPosition:]):
2683
2684 2017-07-22  Chris Dumez  <cdumez@apple.com>
2685
2686         REGRESSION(r204565): WKObject is broken
2687         https://bugs.webkit.org/show_bug.cgi?id=174736
2688         <rdar://problem/33246169>
2689
2690         Reviewed by Dan Bernstein.
2691
2692         Add API test that used to crash.
2693
2694         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2695         (TestWebKitAPI::TEST):
2696
2697 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2698
2699         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2700         https://bugs.webkit.org/show_bug.cgi?id=174705
2701
2702         Reviewed by Mark Lam.
2703
2704         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2705         (TestWebKitAPI::testThreadGroup):
2706         (TestWebKitAPI::TEST):
2707
2708 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2709
2710         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2711         https://bugs.webkit.org/show_bug.cgi?id=174724
2712
2713         Reviewed by Aakash Jain.
2714
2715         * Scripts/webkitpy/port/ios_simulator.py:
2716         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2717         simulator. Errors here should be treated the same as no simulators found.
2718
2719 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2720
2721         [CMake] Add an option to stop build after generating project files
2722         https://bugs.webkit.org/show_bug.cgi?id=174664
2723
2724         Reviewed by Konstantin Tokarev.
2725
2726         Add "--generate-project-only" to stop build after generating project files.
2727
2728         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2729         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2730         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2731         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2732         (isGenerateProjectOnly): ditto
2733
2734 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2735
2736         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2737         https://bugs.webkit.org/show_bug.cgi?id=174501
2738
2739         Reviewed by Darin Adler.
2740
2741         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2742         (TestWebKitAPI::TEST):
2743
2744 2017-07-20  David Quesada  <david_quesada@apple.com>
2745
2746         Add SPI to notify WKNavigationDelegate about client redirects
2747         https://bugs.webkit.org/show_bug.cgi?id=174680
2748         rdar://problem/33184886
2749
2750         Reviewed by Brady Eidson.
2751
2752         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2753         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2754         (TEST):
2755         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2756
2757 2017-07-20  Brady Eidson  <beidson@apple.com>
2758
2759         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2760         https://bugs.webkit.org/show_bug.cgi?id=174685
2761
2762         Reviewed by Andy Estes.
2763
2764         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2765         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2766
2767 2017-07-20  Brady Eidson  <beidson@apple.com>
2768
2769         Deprecate WebIconDatabase in WebKitLegacy/mac.
2770         https://bugs.webkit.org/show_bug.cgi?id=174607
2771
2772         Reviewed by Alex Christensen.
2773
2774         * DumpRenderTree/mac/TestRunnerMac.mm:
2775
2776 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2777
2778         lint-test-expectations should be run during style checking
2779         https://bugs.webkit.org/show_bug.cgi?id=173559
2780         <rdar://problem/32854941>
2781
2782         Reviewed by Aakash Jain.
2783
2784         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2785         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2786         prevents identifying errors on specific lines in a file.
2787         * Scripts/webkitpy/style/main_unittest.py:
2788         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2789         case where a linter error is in the file modified, but the line modified is not related to
2790         the linter error.
2791
2792 2017-07-20  Brady Eidson  <beidson@apple.com>
2793
2794         Remove WebIconDatabase from WebKitLegacy/win.
2795         https://bugs.webkit.org/show_bug.cgi?id=174608
2796
2797         Reviewed by Alex Christensen.
2798
2799         * DumpRenderTree/win/DumpRenderTree.cpp:
2800         (main):
2801         * DumpRenderTree/win/TestRunnerWin.cpp:
2802         (TestRunner::setIconDatabaseEnabled):
2803
2804 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2805
2806         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2807         https://bugs.webkit.org/show_bug.cgi?id=174671
2808
2809         Reviewed by Carlos Garcia Campos.
2810
2811         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2812         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2813         priority for this source in order to have it dispatched on the same
2814         priority as the other WebKit-controlled GSource objects.
2815
2816 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2817
2818         lint-test-expectations should be run during style checking
2819         https://bugs.webkit.org/show_bug.cgi?id=173559
2820         <rdar://problem/32854941>
2821
2822         Reviewed by Daniel Bates.
2823
2824         Follow up fix addressing style and a few minor bugs.
2825
2826         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2827         (TestExpectationParser.__init__): Use lambda x: x instead of str
2828         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2829         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2830         reduce the calls of _shorten_filename, fix minor bug in appending the current
2831         expectation's line number instead of the previous ones, clarify treatment of None
2832         in file-to-line-number mapping.
2833         (TestExpectations._report_warnings): Collapse call.
2834         * Scripts/webkitpy/style/checkers/test_expectations.py:
2835         (TestExpectationsChecker.lint_test_expectations):
2836         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2837         (TextFileReader.process_file): Add comment explaining treatment of None in
2838         file-to-line-number mapping.
2839         (TextFileReader.delete_file): Collapse call.
2840
2841 2017-07-19  Chris Dumez  <cdumez@apple.com>
2842
2843         Unreviewed attempt to fix API test failure after r219663.
2844
2845         The test was hard-coding an exception string and the string has changed slightly
2846         in r219663.
2847
2848         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2849         (TEST):
2850
2851 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2852
2853         Don't write file URLs to iOS Pasteboard
2854         https://bugs.webkit.org/show_bug.cgi?id=174647
2855         <rdar://problem/33199730>
2856
2857         Reviewed by Wenson Hsieh.
2858
2859         Updating tests to reflect the lack of file URLs for images.
2860
2861         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2862         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2863         (checkEstimatedSize):
2864         (TestWebKitAPI::TEST):
2865
2866 2017-07-19  Brady Eidson  <beidson@apple.com>
2867
2868         iBooks sometimes crashes when closing a book.
2869         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2870
2871         Reviewed by Oliver Hunt.
2872
2873         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2874         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2875         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2876         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2877         (TestWebKitAPI::TEST):
2878
2879         Add a "spin the runloop X number of times" utility:
2880         * TestWebKitAPI/Utilities.h:
2881         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2882         (TestWebKitAPI::Util::spinRunLoop):
2883
2884 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2885
2886         lint-test-expectations should be run during style checking
2887         https://bugs.webkit.org/show_bug.cgi?id=173559
2888         <rdar://problem/32854941>
2889
2890         Reviewed by David Kilzer.
2891
2892         Running the test expectation linter requires reading both files and lines not in the
2893         patch because, for example, deletion of a test can cause a lint failure even though
2894         no test expectations where modified. This means that the linter will occasionally warn
2895         about lines which were not changed in a given patch but whose error is related to a
2896         change made in that patch.
2897
2898         * Scripts/webkitpy/common/system/filesystem_mock.py:
2899         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2900         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2901         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2902         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2903         content, description of the error and the name of the associated test.
2904         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2905         (TestExpectationParser.__init__): Pass shorten_filename function to
2906         TestExpectationsParser to add a deleted file to the related_files dictionary.
2907         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2908         missing path to the related_files dictionary.
2909         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2910         files and line numbers related to this test expectation line. This will allow
2911         tracking linter errors in the style checker occurring across multiple files.
2912         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2913         lines to related_files dictionary.
2914         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2915         (TestExpectations._report_warnings): Construct warning object instead of string
2916         when adding to warnings list.
2917         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2918         clean-up log.
2919         * Scripts/webkitpy/style/checker.py:
2920         (ProcessorBase.do_association_check): Add required function for processor classes.
2921         (StyleProcessor):
2922         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2923         checking for errors between associated files.
2924         * Scripts/webkitpy/style/checkers/test_expectations.py:
2925         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2926         (TestExpectationsChecker):
2927         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2928         of modified files, the current working directory and the host, determine if the linter
2929         warning is associated with the changes.
2930         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2931         style checker.
2932         * Scripts/webkitpy/style/filereader.py:
2933         (TextFileReader):
2934         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2935         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2936         (TextFileReader.process_file): Track both the number of files changed and which lines
2937         in those files were changed.
2938         (TextFileReader.do_association_check): Run the processor's association check on all
2939         modified or deleted files processed by TextFileReader.
2940         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2941         (TextFileReader.count_delete_only_file): Deleted.
2942         * Scripts/webkitpy/style/filereader_unittest.py:
2943         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2944         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2945         * Scripts/webkitpy/style/main.py:
2946         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2947         explicitly run the association check on the file reader.
2948         * Scripts/webkitpy/style/main_unittest.py:
2949         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2950         embedded in the style checker.
2951         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2952         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2953         construct the TextFileReader object with a StyleProcessor used to run style checks on
2954         specific files.
2955         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2956         testing the test expectation linter inside the style checker. This host must contain a
2957         mock file system with the basic structure of test expectations.
2958         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2959         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2960         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2961         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2962         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2963         * Scripts/webkitpy/style/patchreader.py:
2964         (PatchReader.check): Specify which file was deleted, run the association check.
2965         * Scripts/webkitpy/style/patchreader_unittest.py:
2966         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2967         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2968         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2969
2970 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2971
2972         [WTF] Implement WTF::ThreadGroup
2973         https://bugs.webkit.org/show_bug.cgi?id=174081
2974
2975         Reviewed by Mark Lam.
2976
2977         Add WTF::ThreadGroup tests.
2978
2979         * TestWebKitAPI/CMakeLists.txt:
2980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2981         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2982         (TestWebKitAPI::testThreadGroup):
2983         (TestWebKitAPI::TEST):
2984
2985 2017-07-18  Andy Estes  <aestes@apple.com>
2986
2987         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2988         https://bugs.webkit.org/show_bug.cgi?id=174631
2989
2990         Reviewed by Tim Horton.
2991
2992         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2993         * MiniBrowser/Configurations/Base.xcconfig:
2994         * MobileMiniBrowser/Configurations/Base.xcconfig:
2995         * TestWebKitAPI/Configurations/Base.xcconfig:
2996         * WebKitTestRunner/Configurations/Base.xcconfig:
2997
2998 2017-07-18  Andy Estes  <aestes@apple.com>
2999
3000         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3001         https://bugs.webkit.org/show_bug.cgi?id=174631
3002
3003         Reviewed by Sam Weinig.
3004
3005         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3006         * MiniBrowser/Configurations/Base.xcconfig:
3007         * MobileMiniBrowser/Configurations/Base.xcconfig:
3008         * TestWebKitAPI/Configurations/Base.xcconfig:
3009         * WebKitTestRunner/Configurations/Base.xcconfig:
3010
3011 2017-07-18  Daniel Bates  <dabates@apple.com>
3012
3013         lldb: Add type summary for StringView
3014         https://bugs.webkit.org/show_bug.cgi?id=174637
3015
3016         Reviewed by Sam Weinig.
3017
3018         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3019         StringView object will print output that has the form:
3020
3021             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3022               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3023               m_length = 2
3024               m_is8Bit = true
3025               m_underlyingString = 0x0000614000000a90
3026             }
3027
3028         * lldb/lldb_webkit.py:
3029         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3030         (WTFStringView_SummaryProvider):
3031         (WTFStringViewProvider):
3032         (WTFStringViewProvider.__init__):
3033         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3034         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3035         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3036         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3037
3038 2017-07-18  Andy Estes  <aestes@apple.com>
3039
3040         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3041         https://bugs.webkit.org/show_bug.cgi?id=174631
3042
3043         Reviewed by Dan Bernstein.
3044
3045         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3046         * MiniBrowser/Configurations/Base.xcconfig:
3047         * MobileMiniBrowser/Configurations/Base.xcconfig:
3048         * TestWebKitAPI/Configurations/Base.xcconfig:
3049         * WebKitTestRunner/Configurations/Base.xcconfig:
3050
3051 2017-07-18  Devin Rousso  <drousso@apple.com>
3052
3053         Web Inspector: Add memoryCost to Inspector Protocol objects
3054         https://bugs.webkit.org/show_bug.cgi?id=174478
3055
3056         Reviewed by Joseph Pecoraro.
3057
3058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3059         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3060         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3061         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3062         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3063         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3064         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3065         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3066         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3067         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3068         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3069         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3070         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3071         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3072         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3073         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3074         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3075
3076 2017-07-18  Andy Estes  <aestes@apple.com>
3077
3078         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3079         https://bugs.webkit.org/show_bug.cgi?id=174631
3080
3081         Reviewed by Darin Adler.
3082
3083         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3084         * MiniBrowser/Configurations/Base.xcconfig:
3085         * MobileMiniBrowser/Configurations/Base.xcconfig:
3086         * TestWebKitAPI/Configurations/Base.xcconfig:
3087         * WebKitTestRunner/Configurations/Base.xcconfig:
3088
3089 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3090
3091         Unreviewed, fix the iOS build.
3092
3093         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3094
3095         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3096         (TestWebKitAPI::TEST):
3097
3098 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3099
3100         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3101         https://bugs.webkit.org/show_bug.cgi?id=174585
3102         <rdar://problem/33302541>
3103
3104         Reviewed by Tim Horton.
3105
3106         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3107         being dragged when initiating a drag.
3108
3109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3110         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3111         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3112         (TestWebKitAPI::TEST):
3113         * TestWebKitAPI/cocoa/TestWKWebView.h:
3114
3115         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3116
3117         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3118         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3119
3120 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3121
3122         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3123         https://bugs.webkit.org/show_bug.cgi?id=174547
3124
3125         Reviewed by Alex Christensen.
3126
3127         * DumpRenderTree/PlatformWin.cmake:
3128         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3129
3130 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3131
3132         Update style checker to deal with "final"
3133         https://bugs.webkit.org/show_bug.cgi?id=174528
3134
3135         Reviewed by Alex Christensen.
3136         
3137         check-webkit-style shouldn't complain about an open brace to start a
3138         line after a function definition with "final" or "const final".
3139
3140         * Scripts/webkitpy/style/checkers/cpp.py:
3141         (check_braces):
3142         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3143         (CppStyleTest.test_brace_at_begin_of_line):
3144
3145 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3146
3147         Modernize content extension code
3148         https://bugs.webkit.org/show_bug.cgi?id=174588
3149
3150         Reviewed by Sam Weinig.
3151
3152         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3153         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3154         (TestWebKitAPI::testRequest):
3155         (TestWebKitAPI::makeBackend):
3156         (TestWebKitAPI::TEST_F):
3157
3158 2017-07-17  Brady Eidson  <beidson@apple.com>
3159
3160         WKHTTPCookieStore observing only works on the default cookie store.
3161         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3162
3163         Reviewed by Sam Weinig.
3164
3165         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3166         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3167           called for the default store, a non-persistent store, and a custom store.
3168         (TEST):
3169
3170 2017-07-16  Sam Weinig  <sam@webkit.org>
3171
3172         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3173         https://bugs.webkit.org/show_bug.cgi?id=174575
3174
3175         Reviewed by Brady Eidson.
3176
3177         * Scripts/svn-create-patch:
3178         (findModificationType):
3179         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3180         default value of "unknown".
3181
3182         (generateFileList):
3183         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3184         for untracked, which matches our old behavior.
3185
3186 2017-07-17  Charlie Turner  <cturner@igalia.com>
3187
3188         Add some missing build dependencies on Fedora
3189         https://bugs.webkit.org/show_bug.cgi?id=174578
3190
3191         Unreviewed dependency update.
3192
3193         * gtk/install-dependencies:
3194
3195 2017-07-16  Brady Eidson  <beidson@apple.com>
3196
3197         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3198         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3199
3200         Reviewed by Tim Horton.
3201
3202         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3203         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3204         (TEST):
3205
3206 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3207
3208         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3209         https://bugs.webkit.org/show_bug.cgi?id=174540
3210
3211         Reviewed by Michael Catanzaro.
3212
3213         * gtk/generate-inspector-gresource-manifest.py:
3214         (get_filenames): sort list of input files
3215
3216 2017-07-15  Brady Eidson  <beidson@apple.com>
3217
3218         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3219         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3220
3221         Reviewed by Tim Horton.
3222
3223         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3224         (TEST): Make this test more reliable by clearing everything beforehand.
3225
3226 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3227
3228         Make it possible to extend check-webkit-style with Apple-internal checkers
3229         <https://webkit.org/b/174464>
3230         <rdar://problem/25564402>
3231
3232         Reviewed by Darin Adler.
3233
3234         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3235         (_all_categories): Add categories from apple_additions() if it
3236         exists.
3237         (CheckerDispatcher._create_checker): Create python checker
3238         from apple_additions() if it exists.
3239
3240 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3241
3242         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3243         https://bugs.webkit.org/show_bug.cgi?id=174539
3244         <rdar://problem/33307395>
3245
3246         Reviewed by Darin Adler.
3247
3248         Adds a new unit test suite to cover action sheet popover presentation.
3249
3250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3251         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3252         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3253         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3254
3255         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3256
3257         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3258         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3259
3260         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3261
3262         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3263         (TestWebKitAPI::TEST):
3264
3265 2017-07-15  Sam Weinig  <sam@webkit.org>
3266
3267         [Scripts] Make svn-create-patch work better when called in sub directories
3268         https://bugs.webkit.org/show_bug.cgi?id=174551
3269
3270         Reviewed by Darin Adler.
3271
3272         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3273           by ensuring that the prefix is applied as is done in generateDiff.
3274         - Silence output of explanatory lines from svn stat (" > move to ...")
3275           that show up in STDERR when running svn-create-patch.
3276         - Add verbose logging that I found useful while debugging this issue.
3277
3278         * Scripts/svn-create-patch:
3279         (findBaseUrl):
3280         (findMimeType):
3281         (findSourceFileAndRevision):
3282         (generateDiff):
3283         (generateFileList):
3284         (manufacturePatchForAdditionWithHistory):
3285
3286 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3287
3288         Unreviewed build fix after r219537.
3289
3290         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3291
3292 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3293
3294         Add iOS 11 SPI
3295         https://bugs.webkit.org/show_bug.cgi?id=174430
3296         <rdar://problem/33269288>
3297
3298         Reviewed by Tim Horton.
3299
3300         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3301         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3302         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3303
3304 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3305
3306         Failing to install on iPad simulators
3307         https://bugs.webkit.org/show_bug.cgi?id=174532
3308         <rdar://problem/33328347>
3309
3310         Reviewed by Stephanie Lewis.
3311
3312         * Scripts/webkitpy/xcode/simulated_device.py:
3313         (SimulatedDevice.install_app): Place install command in retry try-except block.
3314
3315 2017-07-14  Jeff Miller  <jeffm@apple.com>
3316
3317         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3318         https://bugs.webkit.org/show_bug.cgi?id=174524
3319
3320         Reviewed by Sam Weinig.
3321
3322         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3323         (TEST):
3324         Renamed TestParameter to TestParameter1.
3325         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3326
3327         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3328         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3329         Observe changes for two bundle parameters.
3330
3331         (-[BundleParametersPlugIn dealloc]):
3332         Remove observers for two bundle parameters.
3333
3334 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3335
3336         Unreviewed, rolling out r219510.
3337         https://bugs.webkit.org/show_bug.cgi?id=174525
3338
3339         Need to revert length() == 0 check for null string (Requested
3340         by yusukesuzuki on #webkit).
3341
3342         Reverted changeset:
3343
3344         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3345         static string if StringImpl is static"
3346         https://bugs.webkit.org/show_bug.cgi?id=174501
3347         http://trac.webkit.org/changeset/219510
3348
3349 2017-07-14  Jer Noble  <jer.noble@apple.com>
3350
3351         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3352         https://bugs.webkit.org/show_bug.cgi?id=174514
3353
3354         Reviewed by Sam Weinig.
3355
3356         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3357         (TestWebKitAPI::TEST_F):
3358
3359 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3360
3361         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3362         https://bugs.webkit.org/show_bug.cgi?id=174501
3363
3364         Reviewed by Darin Adler.
3365
3366         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3367         (TestWebKitAPI::TEST):
3368
3369 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3370
3371         Bring mac expectations in-line with other platforms
3372         https://bugs.webkit.org/show_bug.cgi?id=174472
3373         <rdar://problem/33297388>
3374
3375         Reviewed by David Kilzer.
3376
3377         The override order for Mac test expectations does not conform to the pattern used by iOS,
3378         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3379
3380             platform/mac-wk2
3381             platform/wk2
3382             platform/mac-elcapitan
3383             platform/mac-sierra
3384             generic
3385
3386         After this change, El Capitan's baseline search path looks like this:
3387
3388             platform/mac-sierra-wk2
3389             platform/mac-sierra
3390             platform/mac-wk2
3391             platform/wk2
3392             generic
3393
3394         * Scripts/webkitpy/port/mac.py:
3395         (MacPort.__init__): If a specific version is specified in the port name, use that
3396         as the os version.
3397         (MacPort.default_baseline_search_path): Expectation search paths should work the
3398         same way they do on other ports. Port + version overrides port, port overrides generic
3399         and wk1/wk2 should override expectations for the two combined.
3400         * Scripts/webkitpy/port/mac_unittest.py:
3401         (MacTest.test_tests_for_other_platforms): Deleted.
3402         (MacTest._assert_search_path): Deleted.
3403         (MacTest.test_baseline_search_path): Deleted.
3404         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3405         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3406         (test_rebaseline_test_and_print_scm_changes): Ditto.
3407         (test_rebaseline_and_copy_test): Ditto.
3408         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3409         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3410         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3411
3412 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3413
3414         Fix style checker unit test
3415
3416         Unreviewed WebKit2 => WebKit fixup.
3417
3418         * Scripts/webkitpy/style/checker_unittest.py:
3419         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3420
3421 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3422
3423         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3424
3425         Unreviewed build fix.
3426
3427         r219492 missed one hunk from its partial revert of r219489.
3428         This patch reverts that hunk.
3429
3430         * TestWebKitAPI/CMakeLists.txt:
3431
3432 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3433
3434         Use the old WebKit/WebKit2 targets for CMake builds.
3435
3436         Unreviewed build fix.
3437
3438         We can update the target names to match the Framework names in a future patch.
3439         This is a partial revert of r219489.
3440
3441         * TestWebKitAPI/CMakeLists.txt:
3442         WebKitLegacy => WebKit
3443         WebKit => WebKit2
3444
3445 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3446
3447         Fix TestWebKit API.
3448         https://bugs.webkit.org/show_bug.cgi?id=174164
3449         rdar://problem/33137595
3450
3451         Reviewed by Dan Bernstein.
3452
3453         * TestWebKitAPI/CMakeLists.txt:
3454         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3455         * TestWebKitAPI/PlatformGTK.cmake:
3456
3457 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3458
3459         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3460         https://bugs.webkit.org/show_bug.cgi?id=174164
3461         rdar://problem/33137595
3462
3463         Reviewed by Dan Bernstein.
3464
3465         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3466         (ShouldBuildTest):
3467         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3468         * Scripts/build-webkit:
3469         * Scripts/do-file-rename:
3470         * Scripts/do-webcore-rename:
3471         * Scripts/update-webkit-localizable-strings:
3472         * Scripts/webkitpy/common/config/watchlist:
3473         * Scripts/webkitpy/style/checker.py:
3474         * Scripts/webkitpy/style/checkers/featuredefines.py:
3475         * gtk/make-dist.py:
3476         (ensure_version_if_possible):
3477         * gtk/manifest.txt.in:
3478
3479 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3480
3481         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3482         https://bugs.webkit.org/show_bug.cgi?id=174162
3483         rdar://problem/33137594
3484
3485         Reviewed by Dan Bernstein.
3486
3487         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3490         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3491         * EWSTools/configure-clang-linux.sh:
3492         * Scripts/build-webkit:
3493         * Scripts/do-file-rename:
3494         * Scripts/do-webcore-rename:
3495         * Scripts/update-webkit-localizable-strings:
3496         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3497         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3498         * Scripts/webkitpy/style/checkers/featuredefines.py:
3499         * gtk/manifest.txt.in:
3500
3501 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3502
3503         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3504         https://bugs.webkit.org/show_bug.cgi?id=174438
3505         <rdar://problem/33277112>
3506
3507         Reviewed by Aakash Jain.
3508
3509         Given a patch, this will convert the changes from the path to the new directory structure.
3510
3511         * Scripts/rebase-patch-after-webkit-move: Added.
3512         (append_source): Append 'Source' to the provided path.
3513         (is_editable_line): Return true if a line the script expects to modify.
3514         (needs_rebase): Return if a line needs to be rebased based on it's content.
3515         (rebase_line): Rebase the provided line.
3516         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3517         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3518         were provided.
3519
3520 2017-07-12  Nan Wang  <n_wang@apple.com>
3521
3522         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3523         https://bugs.webkit.org/show_bug.cgi?id=174393
3524         <rdar://problem/33248006>
3525
3526         Reviewed by Chris Fleizach.
3527
3528         * DumpRenderTree/AccessibilityUIElement.cpp:
3529         (textMarkerRangeMatchesTextNearMarkersCallback):
3530         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3531         (AccessibilityUIElement::getJSClass):
3532         * DumpRenderTree/AccessibilityUIElement.h:
3533         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3534         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3535         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3536         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3537         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3538         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3539         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3540         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3541
3542 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3543
3544         Unreviewed, rolling out r219409.
3545
3546         The revision caused the Windows builds to fail.
3547
3548         Reverted changeset:
3549
3550         "AX: [iOS] Implement a way to retrieve a text marker range
3551         with desired text that is closest to a position"
3552         https://bugs.webkit.org/show_bug.cgi?id=174393
3553         http://trac.webkit.org/changeset/219409
3554
3555 2017-07-12  Nan Wang  <n_wang@apple.com>
3556
3557         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3558         https://bugs.webkit.org/show_bug.cgi?id=174393
3559         <rdar://problem/33248006>
3560
3561         Reviewed by Chris Fleizach.
3562
3563         * DumpRenderTree/AccessibilityUIElement.cpp:
3564         (textMarkerRangeMatchesTextNearMarkersCallback):
3565         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3566         (AccessibilityUIElement::getJSClass):
3567         * DumpRenderTree/AccessibilityUIElement.h:
3568         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3569         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3570         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3571         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3572         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3573         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3574         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3575         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3576
3577 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3578
3579         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3580         https://bugs.webkit.org/show_bug.cgi?id=174197
3581
3582         Reviewed by Darin Adler.
3583
3584         This bit me the first time I tried to submit a patch to WebKit, and still I have
3585         to manually edit the ChangeLog every time I use the script.
3586
3587         This generates a more convenient and standard ChangeLog entry.
3588
3589         * Scripts/prepare-ChangeLog:
3590         (generateNewChangeLogs):
3591
3592 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3593
3594         Unreviewed, rolling out r219401.
3595
3596         This revision rolled out the previous patch, but after talking
3597         with reviewer, a rebaseline is what was needed.Rolling back in
3598         before rebaseline.
3599
3600         Reverted changeset:
3601
3602         "Unreviewed, rolling out r219379."
3603         https://bugs.webkit.org/show_bug.cgi?id=174400
3604         http://trac.webkit.org/changeset/219401
3605
3606 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3607
3608         Unreviewed, rolling out r219379.
3609
3610         This revision caused a consistent failure in the test