run-api-tests: Upload test results
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2
3         run-api-tests: Upload test results
4         https://bugs.webkit.org/show_bug.cgi?id=196323
5         <rdar://problem/49356714>
6
7         Reviewed by Lucas Forschler.
8
9         * Scripts/webkitpy/api_tests/manager.py:
10         (Manager):
11         (Manager.run): Upload results to a results database.
12         * Scripts/webkitpy/api_tests/run_api_tests.py:
13         (parse_args): Add upload arguments.
14         * Scripts/webkitpy/port/base.py:
15         (Port):
16         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
17         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
18         with commits from any other associated repositories.
19         * Scripts/webkitpy/port/device.py:
20         (Device):
21         (Device.build_version): Access build_versoin of underlying platform device.
22         * Scripts/webkitpy/port/ios_simulator_unittest.py:
23         (IOSSimulatorTest):
24         (IOSSimulatorTest.test_configuration_for_upload):
25         * Scripts/webkitpy/port/device_port.py:
26         (DevicePort):
27         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
28         the same as the machine uploading results.
29         * Scripts/webkitpy/port/mac.py:
30         (MacPort):
31         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
32         * Scripts/webkitpy/port/mac_unittest.py:
33         (MacTest):
34         (MacTest.test_configuration_for_upload):
35         * Scripts/webkitpy/xcode/simulated_device.py:
36         (SimulatedDeviceManager._create_device_with_runtime):
37         (SimulatedDevice.__init__): Create simulated device with a build_version.
38         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
39         (test_existing_simulator):
40
41 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
42
43         Remove extra newline characters (Follow-up fix to r243707)
44
45         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
46
47 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
48
49         [ews-app] Use API_KEY to accept results data
50         https://bugs.webkit.org/show_bug.cgi?id=196461
51
52         Reviewed by Dewei Zhu.
53
54         * BuildSlaveSupport/ews-app/ews/views/results.py:
55         (Results.post): Validate EWS_API_KEY before accepting any data.
56         * BuildSlaveSupport/ews-build/events.py:
57         (Events.sendData): Send EWS_API_KEY if available along with event data.
58
59 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
60
61         Unable to copy and paste a PDF from Notes into Mail compose body
62         https://bugs.webkit.org/show_bug.cgi?id=196442
63         <rdar://problem/48573098>
64
65         Reviewed by Tim Horton.
66
67         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
68         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
69         to be specified on the item providers.
70
71         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
72         (TestWebKitAPI::mapItemForTesting):
73         (TestWebKitAPI::contactItemForTesting):
74
75 2019-04-01  Tim Horton  <timothy_horton@apple.com>
76
77         Make UIWKDocumentContext rects per-character instead of per-word
78         https://bugs.webkit.org/show_bug.cgi?id=196459
79
80         Reviewed by Wenson Hsieh.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
83         (TEST):
84         Adjust test results due to switching to per-character rects.
85
86 2019-04-01  Chris Dumez  <cdumez@apple.com>
87
88         UIProcess crash when a prewarmed process is terminated
89         https://bugs.webkit.org/show_bug.cgi?id=196451
90         <rdar://problem/49245471>
91
92         Reviewed by Geoffrey Garen.
93
94         Add API test coverage.
95
96         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
97         (TEST):
98
99 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
100
101         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
102         https://bugs.webkit.org/show_bug.cgi?id=196449
103
104         Reviewed by Lucas Forschler.
105
106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
107         (StatusBubble.get_os_details): Method to get OS and Xcode details.
108         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
109         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
110
111 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
112
113         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
114         https://bugs.webkit.org/show_bug.cgi?id=196444
115
116         Reviewed by Lucas Forschler.
117
118         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
119
120 2019-04-01  Alex Christensen  <achristensen@webkit.org>
121
122         Add SPI to canonicalize NSURLs with WTF::URL
123         https://bugs.webkit.org/show_bug.cgi?id=196415
124         <rdar://problem/44980271>
125
126         Reviewed by Darin Adler.
127
128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
129         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
130         (TestWebKitAPI::TEST):
131
132 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
133
134         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
135         https://bugs.webkit.org/show_bug.cgi?id=196441
136
137         Reviewed by Carlos Garcia Campos.
138
139         Don't cache the wpe_view_backend object that might not exist yet at the
140         time of EventSenderProxy constructor invocation, but instead retrieve
141         that object whenever it's required for event dispatching. This should
142         avoid crashes in this constructor now that it's invoked before any
143         PlatformWindow has been set up (as changed in r243496).
144
145         * WebKitTestRunner/EventSenderProxy.h:
146         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
147         (WTR::viewBackend):
148         (WTR::EventSenderProxy::EventSenderProxy):
149         (WTR::EventSenderProxy::mouseDown):
150         (WTR::EventSenderProxy::mouseUp):
151         (WTR::EventSenderProxy::mouseMoveTo):
152         (WTR::EventSenderProxy::mouseScrollBy):
153         (WTR::EventSenderProxy::keyDown):
154         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
155
156 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
157
158         [Win][WebKit] MiniBrowser should support high DPI display
159         https://bugs.webkit.org/show_bug.cgi?id=196391
160
161         Reviewed by Alex Christensen.
162
163         * MiniBrowser/win/WebKitBrowserWindow.cpp:
164         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
165         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
166         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
167
168 2019-03-31  Sam Weinig  <weinig@apple.com>
169
170         Remove more i386 specific configurations
171         https://bugs.webkit.org/show_bug.cgi?id=196430
172
173         Reviewed by Alexey Proskuryakov.
174
175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
176         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
177
178 2019-03-31  Andy Estes  <aestes@apple.com>
179
180         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
181         https://bugs.webkit.org/show_bug.cgi?id=196433
182         <rdar://problem/49293305>
183
184         Reviewed by Tim Horton.
185
186         Enhanced API test coverage to include all navigation response policy decisions in both
187         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
188
189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
190         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
193         (readFile):
194         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
195         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
196         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
197         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
198         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
199         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
200         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
201         (-[QuickLookDelegate _downloadDidStart:]):
202         (-[QuickLookDelegate _download:didReceiveResponse:]):
203         (-[QuickLookDelegate _download:didReceiveData:]):
204         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
205         (-[QuickLookDelegate _downloadDidFinish:]):
206         (-[QuickLookDelegate _download:didFailWithError:]):
207         (-[QuickLookDelegate _downloadDidCancel:]):
208         (-[QuickLookDelegate verifyDownload]):
209         (runTest):
210         (runTestDecideBeforeLoading):
211         (runTestDecideAfterLoading):
212         (TEST):
213         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
214         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
215         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
216         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
217         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
218         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
219         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
220         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
221         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
222         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
223         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
224         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
225         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
226         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
227
228 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
229
230         [CMake] add testdfg as target with build-jsc
231         https://bugs.webkit.org/show_bug.cgi?id=196393
232
233         Reviewed by Saam Barati.
234
235         Added testdfg as one of the targets to build when
236         using CMake.
237
238         * Scripts/build-jsc:
239
240 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
241
242         Delete WebMetal implementation in favor of WebGPU
243         https://bugs.webkit.org/show_bug.cgi?id=195418
244
245         Reviewed by Dean Jackson.
246
247         * DumpRenderTree/mac/DumpRenderTree.mm:
248         (enableExperimentalFeatures):
249         (resetWebPreferencesToConsistentValues):
250         * Scripts/webkitperl/FeatureList.pm:
251         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
253         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
254         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
255         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
256         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
257         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
258         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
259         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
261         (WTR::InjectedBundle::beginTesting):
262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
263         (WTR::TestRunner::setWebMetalEnabled): Deleted.
264         * WebKitTestRunner/InjectedBundle/TestRunner.h:
265
266 2019-03-29  Chris Dumez  <cdumez@apple.com>
267
268         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
269         https://bugs.webkit.org/show_bug.cgi?id=196405
270         <rdar://problem/49428130>
271
272         Reviewed by Wenson Hsieh.
273
274         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
275         the popover presentation methods to be no-ops. Use this in the new test added in
276         r243523 so that we do not swizzle those methods for all tests. This is needed because
277         those WatchOS tests rely on the popover getting presented and interactive.
278
279         * WebKitTestRunner/TestController.cpp:
280         (WTR::updateTestOptionsFromTestHeader):
281         * WebKitTestRunner/TestController.h:
282         * WebKitTestRunner/TestOptions.h:
283         (WTR::TestOptions::hasSameInitializationOptions const):
284         * WebKitTestRunner/ios/TestControllerIOS.mm:
285         (WTR::TestController::platformInitialize):
286         (WTR::TestController::platformResetStateToConsistentValues):
287
288 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
289
290         [Curl] Add Server Trust Evaluation Support.
291         https://bugs.webkit.org/show_bug.cgi?id=191646
292
293         Reviewed by Fujii Hironori.
294
295         Implemented MiniBrowser UI for asking if user trusts the server.
296
297         * MiniBrowser/win/Common.cpp:
298         (askServerTrustEvaluation):
299         (replaceString):
300         * MiniBrowser/win/Common.h:
301         * MiniBrowser/win/MiniBrowserLib.rc:
302         * MiniBrowser/win/MiniBrowserLibResource.h:
303         * MiniBrowser/win/WebKitBrowserWindow.cpp:
304         (createPEMString):
305         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
306         (WebKitBrowserWindow::canTrustServerCertificate):
307         * MiniBrowser/win/WebKitBrowserWindow.h:
308
309 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
310
311         Implement ResizeObserver.
312         https://bugs.webkit.org/show_bug.cgi?id=157743
313
314         Reviewed by Simon Fraser.
315
316         Support resizeObserverEnabled webPreferences.
317
318         * DumpRenderTree/TestOptions.cpp:
319         (TestOptions::TestOptions):
320         * DumpRenderTree/TestOptions.h:
321         * DumpRenderTree/mac/DumpRenderTree.mm:
322         (setWebPreferencesForTestOptions):
323         * DumpRenderTree/win/DumpRenderTree.cpp:
324         (enableExperimentalFeatures):
325         * Scripts/webkitperl/FeatureList.pm:
326         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
327
328 2019-03-28  John Wilander  <wilander@apple.com>
329
330         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
331         https://bugs.webkit.org/show_bug.cgi?id=196281
332         <rdar://problem/48938748>
333
334         Reviewed by Alex Christensen.
335
336         This patch adds the function isStatisticsHasLocalStorage() to the
337         TestRunner. With it, the page can query the WebsiteDataStore in the
338         UI process to make sure that it sees LocalStorage.
339
340         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
342         (WTR::TestRunner::isStatisticsHasLocalStorage):
343         * WebKitTestRunner/InjectedBundle/TestRunner.h:
344         * WebKitTestRunner/TestController.cpp:
345         (WTR::TestController::isStatisticsHasLocalStorage):
346         * WebKitTestRunner/TestController.h:
347         * WebKitTestRunner/TestInvocation.cpp:
348         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
349
350 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
351
352         API::Data::createWithoutCopying should do a null check before calling CFRelease
353         https://bugs.webkit.org/show_bug.cgi?id=196276
354         <rdar://problem/48059859>
355
356         Reviewed by Alex Christensen.
357
358         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
359
360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
361         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
362         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
363         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
364         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
365         (TestWebKitAPI::TEST):
366
367 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
368
369         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
370         https://bugs.webkit.org/show_bug.cgi?id=186276
371
372         Reviewed by Carlos Garcia Campos.
373
374         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
375         (webViewLoadChanged):
376         (testWebResourceGetDataError):
377         (testWebResourceGetDataEmpty):
378         (beforeAll):
379         (webViewloadChanged): Deleted.
380
381 2019-03-27  Andy Estes  <aestes@apple.com>
382
383         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
384         https://bugs.webkit.org/show_bug.cgi?id=196317
385
386         Reviewed by Dan Bernstein.
387
388         package-root copies built products into a staging directory using ditto(1), which does not
389         follow symbolic links as it traverses a directory. Now that the files in
390         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
391         itself, these become broken links when ditto'd into the staging directory.
392
393         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
394
395         * Scripts/package-root:
396
397 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
398
399         [ews-app] Update display text of Submit for ews analysis
400         https://bugs.webkit.org/show_bug.cgi?id=196309
401
402         Reviewed by Dewei Zhu.
403
404         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
405
406 2019-03-27  David Kilzer  <ddkilzer@apple.com>
407
408         run-webkit-tests should check for leaks in WebKit processes
409         <https://webkit.org/b/193772>
410         <rdar://problem/46526680>
411
412         Reviewed by Ryosuke Niwa.
413
414         This works by doing the following:
415         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
416           The list of child processes are returned one per line:
417           process.name: pid
418         - Run the "#LIST CHILD PROCESSES" command just before the
419           "#CHECK FOR WORLD LEAKS" command, and store the list of child
420           processes on the ServerProcess object.
421         - When the `--leaks` switch is handled, run check_for_leaks() on
422           each child process after the main test harness.
423
424         * DumpRenderTree/mac/DumpRenderTree.mm:
425         (handleControlCommand):
426         - Use strncmp() instead of strcmp().
427         - Add support for handling "#LIST CHILD PROCESSES" command.
428
429         * Scripts/webkitpy/port/base.py:
430         (Port.check_for_leaks):
431         * Scripts/webkitpy/port/darwin.py:
432         (DarwinPort.check_for_leaks):
433         - Rename redundant 'process_pid' argument to 'process_id'.
434
435         * Scripts/webkitpy/port/driver.py:
436         (Driver.do_post_tests_work):
437         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
438           longer the only command this sends to WebKitTestRunner.
439         - If the `--leaks` switch is present, send the
440           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
441           result using Port.set_webkit_processes().
442         (Driver._parse_child_processes_output):
443         - Add helper method to parse list of child process names and
444           process IDs returned from WebKitTestRunner.
445
446         * Scripts/webkitpy/port/ios_device.py:
447         (IOSDevicePort.check_for_leaks):
448         - Rename redundant 'process_pid' argument to 'process_id'.
449
450         * Scripts/webkitpy/port/leakdetector.py:
451         (LeakDetector._parse_leaks_output):
452         - Return early if there is no leaks_output.
453         (LeakDetector.check_for_leaks):
454         - Rename redundant 'process_pid' argument to 'process_id'.
455
456         * Scripts/webkitpy/port/server_process.py:
457         (ServerProcess.__init__):
458         (ServerProcess.child_processes):
459         (ServerProcess.set_child_processes):
460         - Add instance variable to Port to store list of child process
461           names and process IDs returned from WebKitTestRunner.
462         (ServerProcess._start):
463         - Clear self._child_processes.
464         (ServerProcess.stop):
465         - If self._child_processes is set, call
466           self._port.check_for_leaks() for each child process.
467
468         * Scripts/webkitpy/port/server_process_unittest.py:
469         (TrivialMockPort.check_for_leaks):
470         - Rename redundant 'process_pid' argument to 'process_id'.
471
472         * Scripts/webkitpy/port/simulator_process.py:
473         (SimulatorProcess.stop):
474         - If self._child_processes is set, call
475           self._port.check_for_leaks() for each child process.
476
477         * Scripts/webkitpy/port/watch_device.py:
478         (WatchDevicePort.check_for_leaks):
479         - Rename redundant 'process_pid' argument to 'process_id'.
480
481         * WebKitTestRunner/TestController.cpp:
482         (WTR::TestController::dumpResponse):
483         - Extract method from findAndDumpWorldLeaks() so that it may be
484           reused by findAndDumpWebKitProcessIdentifiers().
485         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
486         - Add method to output process name and process ID of both the
487           WebContent and Networking processes.
488         (WTR::TestController::findAndDumpWorldLeaks):
489         - Fix missing newline in output when there were no abandoned
490           documents.
491         - Call dumpResponse() for extracted code.
492         (WTR::TestController::handleControlCommand):
493         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
494         - Use strncmp() instead of strcmp().
495         - Call findAndDumpWebKitProcessIdentifiers() when
496           "#LIST CHILD PROCESSES" command is sent.
497         * WebKitTestRunner/TestController.h:
498         (WTR::TestController::dumpResponse):
499         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
500         - Declare methods.
501
502 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
503
504         Unreviewed. Add GLib API test cases after r243434.
505
506         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
507         (testWebViewActiveURI):
508         (serverCallback):
509         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
510         (sendRequestCallback):
511
512 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
513
514         Geolocation request not complete when watch request was started in a different web process
515         https://bugs.webkit.org/show_bug.cgi?id=195996
516
517         Reviewed by Alex Christensen.
518
519         Add a test case.
520
521         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
522         (TestWebKitAPI::runJavaScriptAlert):
523         (TestWebKitAPI::TEST):
524
525 2019-03-26  Keith Rollin  <krollin@apple.com>
526
527         Update the way generate-xcfilelists returns strings from functions
528         https://bugs.webkit.org/show_bug.cgi?id=195975
529         <rdar://problem/49040807>
530
531         Reviewed by Dean Jackson.
532
533         There are places where generate-xcfilelists executes assignments with
534         statements like:
535
536             FOO=$(some_function)
537
538         where "some_function" return a string by echoing it. E.g.
539
540             some_function()
541             {
542                 echo "Hello, World"
543             }
544
545         This is a common idiom, but it has a problem if "some_function" needs
546         to call "exit" in an attempt to halt the entire script right then and
547         there. Since "some_function" is called inside of $(), it's being
548         executed in a sub-shell. Calling exit in that sub-shell simply exits
549         that shell; it doesn't not exit the outer shell in which the main part
550         of the script is still running. As such, the main script keeps
551         executing when the intent was for the script to halt.
552
553         The solution to this is to use a different idiom for returning
554         strings. The one we now is to pass in the name of the variable to
555         receive the string result:
556
557             some_function()
558             {
559                 variable_name=$1
560                 eval $variable_name ="Hello, World"
561             }
562
563         The call site now looks like
564
565             some_function FOO
566
567         Because there's no invocation of a sub-shell, some_function can now
568         call "exit" if it wants to, and the entire script will exit at that
569         point.
570
571         * Scripts/generate-xcfilelists:
572
573 2019-03-26  Chris Dumez  <cdumez@apple.com>
574
575         Add basic layout test coverage for File Picker on iOS
576         https://bugs.webkit.org/show_bug.cgi?id=196265
577
578         Reviewed by Wenson Hsieh.
579
580         Add layout test infrastructure to test the file picker on iOS.
581
582         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
583         (WTR::UIScriptController::dismissFilePicker):
584         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
585         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
586         (WTR::UIScriptController::dismissFilePicker):
587         * TestRunnerShared/UIScriptContext/UIScriptController.h:
588         * WebKitTestRunner/TestController.cpp:
589         (WTR::TestController::createWebViewWithOptions):
590         (WTR::updateTestOptionsFromTestHeader):
591         * WebKitTestRunner/TestOptions.h:
592         (WTR::TestOptions::hasSameInitializationOptions const):
593         * WebKitTestRunner/ios/TestControllerIOS.mm:
594         (overridePresentViewController):
595         (WTR::TestController::platformInitialize):
596         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
597         (WTR::UIScriptController::dismissFilePicker):
598
599 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
600
601         Implement async paste method on UIWKInteractionViewProtocol
602         https://bugs.webkit.org/show_bug.cgi?id=196267
603         <rdar://problem/49236346>
604
605         Reviewed by Tim Horton.
606
607         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
608         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
609         are now a part of all iOS 12 internal SDKs.
610
611         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
612
613         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
614         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
615
616         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
617         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
618         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
619         * TestWebKitAPI/ios/UIKitSPI.h:
620
621 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
622
623         [ews-build] Use PostgreSQL for ews.webkit.org database
624         https://bugs.webkit.org/show_bug.cgi?id=196270
625
626         Reviewed by Lucas Forschler.
627
628         * BuildSlaveSupport/ews-app/ews-app/settings.py:
629
630 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
631
632         [ews] Reset simctl states on reboot
633         https://bugs.webkit.org/show_bug.cgi?id=196260
634
635         Rubber-stamped by Aakash Jain.
636
637         * EWSTools/start-queue-mac.sh:
638
639 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
640
641         [ews-build] Use PostgreSQL for ews-build database
642         https://bugs.webkit.org/show_bug.cgi?id=196229
643
644         Reviewed by Lucas Forschler.
645
646         * BuildSlaveSupport/ews-build/master.cfg:
647
648 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews-build] Get master_hostname dynamically in master.cfg
651         https://bugs.webkit.org/show_bug.cgi?id=196255
652
653         Reviewed by Lucas Forschler.
654
655         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
656         send events data in test mode.
657
658 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
659
660         [ews-app] Set db_constraint to False for Foreign Keys
661         https://bugs.webkit.org/show_bug.cgi?id=196252
662
663         Reviewed by Lucas Forschler.
664
665         * BuildSlaveSupport/ews-app/ews/models/build.py:
666         * BuildSlaveSupport/ews-app/ews/models/step.py:
667
668 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
669
670         [ews-build] is_test_mode_enabled should default to True
671         https://bugs.webkit.org/show_bug.cgi?id=196248
672
673         Reviewed by Lucas Forschler.
674
675         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
676
677 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
678
679         [ews-app] Add webkitperl to ENABLED_QUEUES
680         https://bugs.webkit.org/show_bug.cgi?id=196253
681
682         Reviewed by Lucas Forschler.
683
684         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
685
686 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
687
688         Address NSWindow sometimes using WebKitTestRunnerEvent too early
689         https://bugs.webkit.org/show_bug.cgi?id=196211
690         rdar://problem/49110552
691
692         Reviewed by Tim Horton.
693
694         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
695         Make sure that EventSenderProxy always exists when running tests. We used to create
696         it when resetting before the first test, which is a bit too late.
697
698         * WebKitTestRunner/TestController.h:
699         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
700         (WTR::TestController::platformCreateWebView):
701         (WTR::TestController::platformCreateOtherPage):
702         (WTR::TestController::finishCreatingPlatformWebView):
703         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
704         (WTR::PlatformWebView::PlatformWebView):
705         Moved some code that made NSWindow use NSEvent during web view creation. We may
706         need to move more if some other case us found, but this is enough for now.
707
708 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
709
710         Unreviewed. Fix typo in GLib geolocation API after r243285.
711
712         gelocation -> geolocation.
713
714         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
715         (testGeolocationManagerWatchPosition):
716
717 2019-03-25  Alex Christensen  <achristensen@webkit.org>
718
719         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
720         https://bugs.webkit.org/show_bug.cgi?id=196213
721
722         Reviewed by Geoff Garen.
723
724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
725         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
726         (credentialWithIdentityAndKeychainPath):
727         (-[ChallengeDelegate webView:didFinishNavigation:]):
728         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
729         (TestWebKitAPI::TEST):
730
731 2019-03-25  Alex Christensen  <achristensen@webkit.org>
732
733         Expected shouldn't assume its contained types are copyable
734         https://bugs.webkit.org/show_bug.cgi?id=195986
735
736         Reviewed by JF Bastien.
737
738         * TestWebKitAPI/Tests/WTF/Expected.cpp:
739         (TestWebKitAPI::NonCopyable::operator== const):
740         (TestWebKitAPI::NonCopyable::operator!= const):
741         (TestWebKitAPI::TEST):
742
743 2019-03-25  Tim Horton  <timothy_horton@apple.com>
744
745         Remove some now-unnecessary dynamic class lookup
746         https://bugs.webkit.org/show_bug.cgi?id=196237
747
748         Reviewed by Simon Fraser.
749
750         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
751         (makeRequest):
752         (TEST):
753
754 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
755
756         Unreviewed, rolling out r243450.
757
758         AppleWin and WinCairo port builds get broken.
759
760         Reverted changeset:
761
762         "Add test for fix of #196095"
763         https://bugs.webkit.org/show_bug.cgi?id=196097
764         https://trac.webkit.org/changeset/243450
765
766 2019-03-25  Commit Queue  <commit-queue@webkit.org>
767
768         Unreviewed, rolling out r243465.
769         https://bugs.webkit.org/show_bug.cgi?id=196226
770
771         the test doesn't build (Requested by thorton on #webkit).
772
773         Reverted changeset:
774
775         "Do not terminate the NetworkProcess if a third party
776         application sends a NSCredential with a SecIdentityRef"
777         https://bugs.webkit.org/show_bug.cgi?id=196213
778         https://trac.webkit.org/changeset/243465
779
780 2019-03-25  Alex Christensen  <achristensen@webkit.org>
781
782         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
783         https://bugs.webkit.org/show_bug.cgi?id=196213
784
785         Reviewed by Geoff Garen.
786
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
789         (credentialWithIdentityAndKeychainPath):
790         (-[ChallengeDelegate webView:didFinishNavigation:]):
791         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
792         (TestWebKitAPI::TEST):
793
794 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
795
796         [ews-build] Gracefully handle missing patch_id in events
797         https://bugs.webkit.org/show_bug.cgi?id=196216
798
799         Reviewed by Lucas Forschler.
800
801         * BuildSlaveSupport/ews-build/events.py:
802
803 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
804
805         [ews-build] use lz4 compression for improving buildbot performance
806         https://bugs.webkit.org/show_bug.cgi?id=196155
807
808         Reviewed by Lucas Forschler.
809
810         * BuildSlaveSupport/ews-build/master.cfg:
811
812 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
813
814         Pull some API testing helper methods out of TestWKWebView
815         https://bugs.webkit.org/show_bug.cgi?id=196212
816
817         Reviewed by Tim Horton.
818
819         Refactor some more API testing utility methods, so that they can be used in
820         tests that do not use TestWKWebView.
821
822         * TestWebKitAPI/cocoa/TestWKWebView.h:
823         * TestWebKitAPI/cocoa/TestWKWebView.mm:
824         (-[WKWebView loadTestPageNamed:]):
825         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
826         (-[WKWebView synchronouslyLoadHTMLString:]):
827         (-[WKWebView synchronouslyLoadTestPageNamed:]):
828         (-[TestWKWebView loadTestPageNamed:]): Deleted.
829         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
830         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
831         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
832
833 2019-03-25  Jer Noble  <jer.noble@apple.com>
834
835         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
836         https://bugs.webkit.org/show_bug.cgi?id=196097
837
838         Reviewed by Eric Carlson.
839
840         Drive-by bug fix: allow tests to play audio without a user gesture by default.
841
842         * DumpRenderTree/mac/DumpRenderTree.mm:
843         (resetWebPreferencesToConsistentValues):
844         * WebKitTestRunner/TestController.cpp:
845         (WTR::TestController::resetPreferencesToConsistentValues):
846
847 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
848
849         Pull IPadUserInterfaceSwizzler out into a separate header file
850         https://bugs.webkit.org/show_bug.cgi?id=196193
851
852         Reviewed by Anders Carlsson.
853
854         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
855         be used in other API tests.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
859         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
860         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
861         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
862         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
863         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
864
865 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
866
867         Remove NavigatorContentUtils in WebCore/Modules
868         https://bugs.webkit.org/show_bug.cgi?id=196070
869
870         Reviewed by Alex Christensen.
871
872         NavigatorContentUtils was to support the custom scheme spec [1].
873         However, in WebKit side, no port has supported the feature in
874         WebKit layer after EFL port was removed. So there has been the
875         only IDL implementation of the NavigatorContentUtils in WebCore.
876         So we don't need to keep the implementation in WebCore anymore.
877
878         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
879
880         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
881
882 2019-03-24  Andy Estes  <aestes@apple.com>
883
884         [watchOS] Remove unused Proximity Networking code
885         https://bugs.webkit.org/show_bug.cgi?id=196188
886
887         Reviewed by Tim Horton.
888
889         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
890         (TEST):
891
892 2019-03-23  Keith Miller  <keith_miller@apple.com>
893
894         Refactor clz/ctz and fix getLSBSet.
895         https://bugs.webkit.org/show_bug.cgi?id=196162
896
897         Reviewed by Saam Barati.
898
899         Add tests for clz, ctz, getLSBSet, and getMSBSet.
900
901         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
902         (TestWebKitAPI::TEST):
903
904 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
905
906         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
907         https://bugs.webkit.org/show_bug.cgi?id=196143
908
909         Reviewed by Michael Catanzaro.
910
911         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
912         directories.
913
914         * Scripts/webkitpy/style/checkers/cpp.py:
915         (check_identifier_name_in_declaration):
916         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
917         (WebKitStyleTest.test_names):
918
919 2019-03-22  Philippe Normand  <pnormand@igalia.com>
920
921         [Flatpak] Manifest expanding fails for qt WPE extension
922         https://bugs.webkit.org/show_bug.cgi?id=196148
923
924         Reviewed by Alex Christensen.
925
926         * flatpak/flatpakutils.py:
927         (expand_submodules_recurse): The last recurse manifest expand
928         iteration might lead to a single module so take it into account
929         and don't try to recurse further.
930
931 2019-03-22  Chris Dumez  <cdumez@apple.com>
932
933         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
934         https://bugs.webkit.org/show_bug.cgi?id=195348
935         <rdar://problem/48622090>
936
937         Reviewed by Alex Christensen.
938
939         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
940         to NO when test.options().shouldIgnoreMetaViewport is false.
941
942         * WebKitTestRunner/ios/TestControllerIOS.mm:
943         (WTR::TestController::platformConfigureViewForTest):
944
945 2019-03-22  Chris Dumez  <cdumez@apple.com>
946
947         Prewarmed processes should be usable with any website data store
948         https://bugs.webkit.org/show_bug.cgi?id=196104
949
950         Reviewed by Alex Christensen.
951
952         Add API test coverage.
953
954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
955         (runInitialWarmedProcessUsedTest):
956         (TEST):
957
958 2019-03-22  David Kilzer  <ddkilzer@apple.com>
959
960         Back out local changes to Alex's Subversion working directory
961
962         They were accidentally committed.
963
964         * Scripts/webkitpy/common/system/abstractexecutive.py:
965         (AbstractExecutive.wait_newest):
966         * Scripts/webkitpy/common/system/executive.py:
967         (Executive.running_pids):
968         * Scripts/webkitpy/common/system/executive_mock.py:
969         (MockExecutive.running_pids):
970         * Scripts/webkitpy/common/system/executive_unittest.py:
971         (ExecutiveTest.serial_test_running_pids):
972         * Scripts/webkitpy/port/darwin.py:
973         (DarwinPort.check_for_leaks):
974         * Scripts/webkitpy/port/leakdetector.py:
975         (LeakDetector.check_for_leaks):
976         - This was the hack attached to Bug 193772.
977
978         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
979         (+[WebKitTestRunnerEvent mouseLocation]):
980         - This works around a crash on an internal build.
981
982 2019-03-22  Tim Horton  <timothy_horton@apple.com>
983
984         Fix the build after r243354
985         https://bugs.webkit.org/show_bug.cgi?id=196138
986         <rdar://problem/49145951>
987
988         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
989         (TEST):
990         * TestWebKitAPI/ios/UIKitSPI.h:
991
992 2019-03-21  Tim Horton  <timothy_horton@apple.com>
993
994         Adopt UIWKDocumentContext
995         https://bugs.webkit.org/show_bug.cgi?id=196040
996         <rdar://problem/48642440>
997
998         Reviewed by Ryosuke Niwa.
999
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1002         (makeRequest):
1003         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1004         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1005         (applyStyle):
1006         (TEST):
1007         Add tests for UIWKDocumentContext.
1008
1009         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1010         (TEST):
1011         (recursiveFindWKContentView): Deleted.
1012         * TestWebKitAPI/cocoa/TestWKWebView.h:
1013         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1014         (recursiveFindWKContentView):
1015         (-[TestWKWebView wkContentView]):
1016         * TestWebKitAPI/ios/UIKitSPI.h:
1017         Share the WKContentView finding code between tests.
1018
1019 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1020
1021         [iOS WK2] Turn on async overflow scrolling by default
1022         https://bugs.webkit.org/show_bug.cgi?id=196011
1023         rdar://problem/48453859
1024
1025         Reviewed by Antti Koivisto.
1026         
1027         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1028         since so many basic layout tests have different results when compositing is triggered for
1029         overflow.
1030         
1031         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1032
1033         * WebKitTestRunner/TestController.cpp:
1034         (WTR::TestController::resetPreferencesToConsistentValues):
1035
1036 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1037
1038         [ews-build] Retry API test in case of failures
1039         https://bugs.webkit.org/show_bug.cgi?id=196004
1040
1041         Reviewed by Lucas Forschler.
1042
1043         * BuildSlaveSupport/ews-build/steps.py:
1044         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1045         (CompileWebKitToT.doStepIf): Ditto.
1046         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1047         (ReRunAPITests): Re-run API tests.
1048         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1049         (RunAPITestsWithoutPatch): Run API tests without patch.
1050         (RunAPITestsWithoutPatch.doStepIf):
1051         (RunAPITestsWithoutPatch.hideStepIf):
1052         (RunAPITestsWithoutPatch.evaluateCommand):
1053         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1054         (AnalyzeAPITestsResults.start):
1055         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1056         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1057         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1058         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1059
1060 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1061
1062         [ews-build] Update queues configurations
1063         https://bugs.webkit.org/show_bug.cgi?id=196074
1064
1065         Reviewed by Dewei Zhu.
1066
1067         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1068         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1069
1070 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1071
1072         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1073         https://bugs.webkit.org/show_bug.cgi?id=195680
1074         <rdar://problem/48903534>
1075
1076         Unreviewed infrastructure fix.
1077
1078         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1079         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1080
1081 2019-03-21  Andy Estes  <aestes@apple.com>
1082
1083         [iOS] Apple Pay should be available in documents with no user agent scripts
1084         https://bugs.webkit.org/show_bug.cgi?id=196061
1085         <rdar://problem/48649391>
1086
1087         Reviewed by Brady Eidson.
1088
1089         Added API tests and related infrastructure.
1090
1091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1092         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1093         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1094         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1095         (TestWebKitAPI::TEST):
1096         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1097         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1098         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1099         * TestWebKitAPI/cocoa/TestProtocol.mm:
1100         (-[TestProtocol startLoading]):
1101         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1102         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1103         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1104         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1105
1106 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1107
1108         REGRESSSION (r243297): webkitpy tests broken
1109         https://bugs.webkit.org/show_bug.cgi?id=196108
1110
1111         Reviewed by Aakash Jain.
1112
1113         r243297 updated contributors.json, which broke a few unit tests.
1114
1115         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1116         (IRCCommandTest.test_whois):
1117         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1118
1119 2019-03-21  Chris Dumez  <cdumez@apple.com>
1120
1121         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1122         https://bugs.webkit.org/show_bug.cgi?id=196041
1123         <rdar://problem/49083230>
1124
1125         Reviewed by Alex Christensen.
1126
1127         Add API test coverage.
1128
1129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1130         (TEST):
1131
1132 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1133
1134         Add SPI to inform applications of WKContentRuleList actions
1135         https://bugs.webkit.org/show_bug.cgi?id=195965
1136         <rdar://problem/42664365>
1137
1138         Reviewed by Geoff Garen.
1139
1140         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1141         (TestWebKitAPI::allActionsForResourceLoad):
1142         (TestWebKitAPI::testRequest):
1143         (TestWebKitAPI::TEST_F):
1144         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1145         (Notification::description):
1146         (Notification::operator== const):
1147         (toVector):
1148         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1149         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1150         (makeContentRuleList):
1151         (TEST):
1152         (makeWarnContentRuleList): Deleted.
1153
1154 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1155
1156         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1157         https://bugs.webkit.org/show_bug.cgi?id=196088
1158
1159         Reviewed by Brian Burg.
1160
1161         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1162         Support checks when only one platform is specified. Also deprecate macosx() and
1163         force the use of macos() instead.
1164
1165         * Scripts/webkitpy/style/checkers/cpp.py:
1166         (check_min_versions_of_wk_api_available):
1167         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1168         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1169
1170 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1171
1172         Update status inactive committers' status to 'contributor'.
1173
1174         * Scripts/webkitpy/common/config/contributors.json:
1175
1176 2019-03-21  Xan Lopez  <xan@igalia.com>
1177
1178         [JSC][x86] Drop support for x87 floating point
1179         https://bugs.webkit.org/show_bug.cgi?id=194853
1180
1181         Reviewed by Don Olmstead.
1182
1183         Force SSE2 on x86/32bit builds.
1184
1185         * Scripts/webkitdirs.pm:
1186         (generateBuildSystemFromCMakeProject):
1187
1188 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1189
1190         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1191         https://bugs.webkit.org/show_bug.cgi?id=196073
1192
1193         Reviewed by Michael Catanzaro.
1194
1195         Add test cases to check functions and constructors with no arguments but receiving user data.
1196
1197         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1198         (checkUserData):
1199         (testJSCFunction):
1200         (fooCreateWithUserData):
1201         (testJSCClass):
1202
1203 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1204
1205         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1206
1207         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1208
1209         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1210
1211 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1212
1213         [GTK][WPE] Add API to provide geolocation information
1214         https://bugs.webkit.org/show_bug.cgi?id=195940
1215
1216         Reviewed by Michael Catanzaro.
1217
1218         Add a new test to check the new API.
1219
1220         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1221         (testGeolocationManagerCurrentPosition):
1222         (testGeolocationManagerWatchPosition):
1223         (beforeAll):
1224         (afterAll):
1225         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1226         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1227         (beforeAll): Ditto.
1228         * TestWebKitAPI/glib/CMakeLists.txt:
1229
1230 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1231
1232         [GLib] Returning G_TYPE_OBJECT from a method does not work
1233         https://bugs.webkit.org/show_bug.cgi?id=195574
1234
1235         Reviewed by Michael Catanzaro.
1236
1237         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1238
1239         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1240         (getGFile):
1241         (getParent):
1242         (createGString):
1243         (getGString):
1244         (getGStringCopyWillRaise):
1245         (getGStringCopy):
1246         (getGStringStr):
1247         (getGStringLen):
1248         (freeGString):
1249         (testJSCClass):
1250
1251 2019-03-20  Saam Barati  <sbarati@apple.com>
1252
1253         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1254         https://bugs.webkit.org/show_bug.cgi?id=195721
1255
1256         Reviewed by Filip Pizlo.
1257
1258         * Scripts/run-javascriptcore-tests:
1259
1260 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1261
1262         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1263         https://bugs.webkit.org/show_bug.cgi?id=196049
1264
1265         Reviewed by Tim Horton.
1266
1267         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1268         overflow scrolling in general, so rename it.
1269
1270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1271
1272 2019-03-20  Daniel Bates  <dabates@apple.com>
1273
1274         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1275         https://bugs.webkit.org/show_bug.cgi?id=196031
1276         <rdar://problem/49078172>
1277
1278         Reviewed by Tim Horton.
1279
1280         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1281         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1282         same code path used when the Done button is pressed to dismiss the <select> picker.
1283
1284         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1285         (TestWebKitAPI::TEST):
1286
1287 2019-03-20  Chris Dumez  <cdumez@apple.com>
1288
1289         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1290         https://bugs.webkit.org/show_bug.cgi?id=196029
1291         <rdar://problem/48954651>
1292
1293         Reviewed by Tim Horton.
1294
1295         Add API test coverage.
1296
1297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1298
1299 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews-build] Improve failure summary string for ApplyPatch step
1302         https://bugs.webkit.org/show_bug.cgi?id=195995
1303
1304         Reviewed by Alexey Proskuryakov.
1305
1306         * BuildSlaveSupport/ews-build/steps.py:
1307         (ApplyPatch.getResultSummary): Override getResultSummary.
1308
1309 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1310
1311         AX: Implement support for new meter ARIA role
1312         https://bugs.webkit.org/show_bug.cgi?id=195966
1313
1314         Reviewed by Chris Fleizach.
1315
1316         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1317         to AXLevelIndicator.
1318
1319         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1320
1321 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1322
1323         [WebAuthN] Implement FIDO AppID extension
1324         https://bugs.webkit.org/show_bug.cgi?id=143491
1325         <rdar://problem/48298273>
1326
1327         Reviewed by Brent Fulgham.
1328
1329         Add a test that covers the new flag of convertToU2fSignCommand.
1330
1331         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1332         (TestWebKitAPI::TEST):
1333         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1334         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1335         (TestWebKitAPI::TEST):
1336
1337 2019-03-19  Keith Rollin  <krollin@apple.com>
1338
1339         Add support for more platforms to generate-xcfilelists
1340         https://bugs.webkit.org/show_bug.cgi?id=195977
1341
1342         Reviewed by Alexey Proskuryakov.
1343
1344         generate-xcfilelists incorrectly complains when involved with building
1345         WebKit for iphonesimulator:
1346
1347             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1348             …
1349             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1350
1351         Address this by teaching generate-xcfilelists about more platforms.
1352
1353         * Scripts/generate-xcfilelists:
1354
1355 2019-03-19  John Wilander  <wilander@apple.com>
1356
1357         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1358         https://bugs.webkit.org/show_bug.cgi?id=195923
1359         <rdar://problem/49001272>
1360
1361         Reviewed by Alex Christensen.
1362
1363         This patch does the following to the TestRunner:
1364         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1365         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1366         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1367
1368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1370         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1372         * WebKitTestRunner/TestController.cpp:
1373         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1374         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1375         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1376         * WebKitTestRunner/TestController.h:
1377         * WebKitTestRunner/TestInvocation.cpp:
1378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1379
1380 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1381
1382         [CMake] Support more clang and gcc sanitizers
1383         https://bugs.webkit.org/show_bug.cgi?id=195956
1384
1385         Reviewed by Michael Catanzaro.
1386
1387         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1388
1389 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1390
1391         [ews-build] Improve summary for PrintConfiguration step
1392         https://bugs.webkit.org/show_bug.cgi?id=195945
1393
1394         Reviewed by Lucas Forschler.
1395
1396         * BuildSlaveSupport/ews-build/steps.py:
1397         (PrintConfiguration.getResultSummary): Override getResultSummary.
1398
1399 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1400
1401         [ews-build] Improve summary for CheckOutSource step
1402         https://bugs.webkit.org/show_bug.cgi?id=195963
1403
1404         Reviewed by Lucas Forschler.
1405
1406         * BuildSlaveSupport/ews-build/steps.py:
1407         (CheckOutSource.getResultSummary):
1408
1409 2019-03-19  Daniel Bates  <dabates@apple.com>
1410
1411         [iOS] Focus not preserved when switching between tabs
1412         https://bugs.webkit.org/show_bug.cgi?id=195820
1413         <rdar://problem/43614450>
1414
1415         Reviewed by Brent Fulgham.
1416
1417         Add tests to ensure that we restore focus when resigning and becoming first responder.
1418
1419         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1420         (TestWebKitAPI::TEST):
1421
1422 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1423
1424         Make WTFLogChannelState and WTFLogLevel enum classes
1425         https://bugs.webkit.org/show_bug.cgi?id=195904
1426
1427         Reviewed by Eric Carlson.
1428
1429         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1430         (TestWebKitAPI::TEST_F):
1431
1432 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1433
1434         [GStreamer][EME] Backported mssdemux protection data crash fix
1435         https://bugs.webkit.org/show_bug.cgi?id=195918
1436
1437         Reviewed by Philippe Normand.
1438
1439         * gstreamer/jhbuild.modules:
1440         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1441
1442 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1443
1444         Unreviewed, rolling out r243132.
1445
1446         Broke GTK build
1447
1448         Reverted changeset:
1449
1450         "Make WTFLogChannelState and WTFLogLevel enum classes"
1451         https://bugs.webkit.org/show_bug.cgi?id=195904
1452         https://trac.webkit.org/changeset/243132
1453
1454 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1455
1456         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1457
1458         * Scripts/webkitdirs.pm:
1459         (builtDylibPathForName): Adjust the shared library name that's changed
1460         with the API version bump in r243073.
1461
1462 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1463
1464         Make WTFLogChannelState and WTFLogLevel enum classes
1465         https://bugs.webkit.org/show_bug.cgi?id=195904
1466
1467         Reviewed by Eric Carlson.
1468
1469         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1470         (TestWebKitAPI::TEST_F):
1471
1472 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1473
1474         Disable flaky test added in r2431100
1475         https://webkit.org/b/195785
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1478         (TestWebKitAPI::TEST):
1479         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1480
1481 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1482
1483         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1484         https://bugs.webkit.org/show_bug.cgi?id=195916
1485
1486         Reviewed by Tim Horton.
1487
1488         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1489         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1490
1491 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1492
1493         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1494
1495         * Scripts/webkitpy/common/config/contributors.json:
1496
1497 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1498
1499         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1500         https://bugs.webkit.org/show_bug.cgi?id=195785
1501
1502         Reviewed by Geoffrey Garen.
1503
1504         * TestWebKitAPI/TCPServer.cpp: Added.
1505         (TestWebKitAPI::TCPServer::TCPServer):
1506         (TestWebKitAPI::TCPServer::~TCPServer):
1507         (TestWebKitAPI::TCPServer::socketBindListen):
1508         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1509         * TestWebKitAPI/TCPServer.h: Added.
1510         (TestWebKitAPI::TCPServer::port const):
1511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1512         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1513         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1514         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1515         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1516         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1517         (TestWebKitAPI::respondSlowly):
1518         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1519         (TestWebKitAPI::downloadAtRate):
1520         (TestWebKitAPI::TEST):
1521
1522 2019-03-18  Saam Barati  <sbarati@apple.com>
1523
1524         Add a plan file for JetStream 2
1525         https://bugs.webkit.org/show_bug.cgi?id=190734
1526
1527         Reviewed by Mark Lam.
1528
1529         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1530
1531 2019-03-18  Chris Dumez  <cdumez@apple.com>
1532
1533         Delay WebProcess launch until a load is triggered in a Web view
1534         https://bugs.webkit.org/show_bug.cgi?id=195758
1535         <rdar://problem/48126013>
1536
1537         Reviewed by Geoff Garen.
1538
1539         Add API test coverage. Also update some existing API tests to not expect
1540         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1541
1542         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1543         (TestWebKitAPI::TEST):
1544         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1545         (TestWebKitAPI::TEST):
1546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1547         (TEST):
1548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1549         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1550         (TEST):
1551         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1552         (TEST):
1553         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1554
1555 2019-03-18  Xan Lopez  <xan@igalia.com>
1556
1557         [CMake] Prevent potential warning when determining $architecture
1558         https://bugs.webkit.org/show_bug.cgi?id=195891
1559
1560         Reviewed by Michael Catanzaro.
1561
1562         It's possible for generateBuildSystemForCMakeProject to be called
1563         before determineArchitecture() is ever called. This will make the
1564         first eq check with $architecture to be bogus (and print a
1565         warning). Change that to an eq check with architecture(), which
1566         implicitly calls determineArchitecture() if needed, and change all
1567         the other similar cases in the method in the same way to prevent
1568         future bugs like this one.
1569
1570         * Scripts/webkitdirs.pm:
1571         (generateBuildSystemFromCMakeProject):
1572
1573 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1574
1575         [WPE] Tarballs generated with “make dist” cannot build documentation
1576         https://bugs.webkit.org/show_bug.cgi?id=195885
1577
1578         Reviewed by Carlos Garcia Campos.
1579
1580         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1581
1582 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1583
1584         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1585         https://bugs.webkit.org/show_bug.cgi?id=195883
1586
1587         Reviewed by Carlos Garcia Campos.
1588
1589         * gtkdoc/gtkdoc.py:
1590         (GTKDoc._run_command): When commands fail to run, include the full command line for
1591         the program invocation and the output it has generated on the standard error stream.
1592
1593 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1594
1595         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1596         https://bugs.webkit.org/show_bug.cgi?id=195786
1597
1598         Reviewed by Philippe Normand.
1599
1600         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1601         * wpe/jhbuild.modules: Ditto.
1602
1603 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1604
1605         [ews-build] Don't run clean builds on EWS builders
1606         https://bugs.webkit.org/show_bug.cgi?id=195851
1607
1608         Reviewed by Geoffrey Garen.
1609
1610         * BuildSlaveSupport/ews-build/factories.py:
1611
1612 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1613
1614         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1615         https://bugs.webkit.org/show_bug.cgi?id=195849
1616
1617         Reviewed by Chris Dumez.
1618
1619         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1620
1621         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1622         (runWebsiteDataStoreCustomPaths):
1623
1624 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1625
1626         webkitpy: Upload test results
1627         https://bugs.webkit.org/show_bug.cgi?id=195755
1628         <rdar://problem/48896182>
1629
1630         Reviewed by Aakash Jain.
1631
1632         Establish a new format for uploading results that is not tied to layout tests, apply
1633         that format to webkitpy tests.
1634
1635         * Scripts/webkitpy/common/checkout/scm/git.py:
1636         (Git.native_branch): Return what branch the current checkout is on.
1637         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1638         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1639         * Scripts/webkitpy/common/checkout/scm/svn.py:
1640         (SVN.native_branch): Ditto.
1641         * Scripts/webkitpy/common/system/platforminfo.py:
1642         (PlatformInfo.build_version): Return a build version for Mac.
1643         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1644         (MockPlatformInfo.__init__):
1645         (MockPlatformInfo.build_version):
1646         * Scripts/webkitpy/results: Added.
1647         * Scripts/webkitpy/results/__init__.py: Added.
1648         * Scripts/webkitpy/results/options.py: Added.
1649         (upload_options): OptParse list for upload options.
1650         * Scripts/webkitpy/results/upload.py: Added.
1651         (Upload): Class which enforces the upload format expected by the results server.
1652         (Upload.Expectations):
1653         (Upload.create_configuration):
1654         (Upload.create_commit):
1655         (Upload.create_details):
1656         (Upload.create_run_stats):
1657         (Upload.create_test_result):
1658         (Upload.__init__):
1659         (Upload.Encoder): Encode Upload object as json.
1660         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1661         * Scripts/webkitpy/results/upload_unittest.py: Added.
1662         * Scripts/webkitpy/test/main.py:
1663         (Tester._parse_args): Add upload arguments.
1664         (Tester._run_tests): Allow results to be uploaded.
1665         * Scripts/webkitpy/test/runner.py:
1666         (Runner.__init__): Record which tests were run, rather than just counting them.
1667         (Runner.handle):
1668         * Scripts/webkitpy/test/runner_unittest.py:
1669         (RunnerTest.test_run):
1670         * Scripts/webkitpy/thirdparty/__init__.py:
1671         (AutoinstallImportHook.find_module): Add requests auto-install.
1672         (AutoinstallImportHook._install_requests):
1673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1674         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1675
1676 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1677
1678         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1679         https://bugs.webkit.org/show_bug.cgi?id=195810
1680
1681         Reviewed by Tim Horton.
1682
1683         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1684         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1685         ending certain layout tests.
1686
1687         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1688         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1689         (-[TestRunnerWKWebView dealloc]):
1690         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1691
1692         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1693         helper method when destroying the web view, and when resetting state between tests.
1694
1695         * WebKitTestRunner/ios/TestControllerIOS.mm:
1696         (WTR::TestController::platformResetStateToConsistentValues):
1697
1698         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1699
1700 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1701
1702         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1703         https://bugs.webkit.org/show_bug.cgi?id=190350
1704         <rdar://problem/45089503>
1705
1706         Reviewed by Geoffrey Garen.
1707
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1710         (TEST):
1711         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1712         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1713         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1714         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1715         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1716         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1717         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1718         (runTest):
1719         (createDirectories):
1720         (TEST):
1721         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1722         (TEST):
1723         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1724         (TEST):
1725
1726 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1727
1728         Add support to WebPage for getting the contents as an attributed string.
1729         https://bugs.webkit.org/show_bug.cgi?id=195636
1730         rdar://problem/45055697
1731
1732         Reviewed by Tim Horton.
1733
1734         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1735         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1736
1737 2019-03-15  Chris Dumez  <cdumez@apple.com>
1738
1739         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1740         https://bugs.webkit.org/show_bug.cgi?id=195747
1741
1742         Reviewed by Geoff Garen.
1743
1744         Add API test coverage.
1745
1746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1747
1748 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1749
1750         Unreviewed, rolling out r242952.
1751
1752         Causing API failures on iOS Simulator
1753
1754         Reverted changeset:
1755
1756         "[PSON] Make sure the WebProcessCache is leverage when
1757         relaunching a process after termination"
1758         https://bugs.webkit.org/show_bug.cgi?id=195747
1759         https://trac.webkit.org/changeset/242952
1760
1761 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1762
1763         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1764         https://bugs.webkit.org/show_bug.cgi?id=195740
1765
1766         Reviewed by Ross Kirsling.
1767
1768         window.open doesn't work for WebKitBrowserWindow because it is not
1769         implemented yet.
1770
1771         1. Implemented createNewPage callback of WKPageUIClient.
1772         2. Changed MainWindow to take a BrowserWindow factory function
1773           instead of BrowserWindowType to be flexible to create
1774           BrowserWindow with extra settings.
1775         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1776           because it is not relevant with MainWindow anymore.
1777
1778         * MiniBrowser/win/Common.cpp:
1779         (parseCommandLine):
1780         * MiniBrowser/win/Common.h:
1781         (CommandLineOptions::CommandLineOptions):
1782         * MiniBrowser/win/MainWindow.cpp:
1783         (MainWindow::MainWindow):
1784         (MainWindow::create):
1785         (MainWindow::init):
1786         (MainWindow::WndProc):
1787         * MiniBrowser/win/MainWindow.h:
1788         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1789         (PrintWebUIDelegate::createWebViewWithRequest):
1790         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1791         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1792         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1793         (WebKitBrowserWindow::updateProxySettings):
1794         (WebKitBrowserWindow::createNewPage):
1795         * MiniBrowser/win/WebKitBrowserWindow.h:
1796         * MiniBrowser/win/WinMain.cpp:
1797         (wWinMain):
1798
1799 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1800
1801         Make it possible to test scrolling tree layer manipulation more easily
1802         https://bugs.webkit.org/show_bug.cgi?id=195780
1803
1804         Reviewed by Tim Horton.
1805         
1806         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1807         cuts off communication of scrolling tree scrolls back to the web process
1808         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1809         allows tests to trigger scrolls which run the scrolling tree layer positioning
1810         logic, but never get another commit from the web process that might mask
1811         scrolling tree bugs.
1812         
1813         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1814         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1815         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1816
1817         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1818         (WTR::UIScriptController::scrollUpdatesDisabled const):
1819         (WTR::UIScriptController::setScrollUpdatesDisabled):
1820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1821         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1822         (WTR::UIScriptController::scrollUpdatesDisabled const):
1823         (WTR::UIScriptController::setScrollUpdatesDisabled):
1824         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1825         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1826         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1827         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1828         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1829         * WebKitTestRunner/ios/TestControllerIOS.mm:
1830         (WTR::TestController::platformResetStateToConsistentValues):
1831         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1832         (WTR::UIScriptController::scrollUpdatesDisabled const):
1833         (WTR::UIScriptController::setScrollUpdatesDisabled):
1834
1835 2019-03-14  Youenn Fablet  <youenn@apple.com>
1836
1837         Move IDB storage in private browsing mode to NetworkProcess
1838         https://bugs.webkit.org/show_bug.cgi?id=195602
1839
1840         Reviewed by Brady Eidson.
1841
1842         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1843         (TEST):
1844
1845 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1846
1847         [ews-build] Make descriptionDone messages more readable
1848         https://bugs.webkit.org/show_bug.cgi?id=195760
1849
1850         Reviewed by Lucas Forschler.
1851
1852         * BuildSlaveSupport/ews-build/steps.py:
1853         * BuildSlaveSupport/ews-build/steps_unittest.py:
1854
1855 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1856
1857         [ews-build] Generate status-bubble hover-over messages
1858         https://bugs.webkit.org/show_bug.cgi?id=195680
1859
1860         Reviewed by Lucas Forschler.
1861
1862         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1863         (StatusBubble):
1864         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1865         on hover-over.
1866         (StatusBubble._iso_time):
1867         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1868         hover-over message.
1869         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1870
1871 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1872
1873         [ews-app] Gracefully handle the case when state_string is None
1874         https://bugs.webkit.org/show_bug.cgi?id=195753
1875
1876         Reviewed by Lucas Forschler.
1877
1878         * BuildSlaveSupport/ews-app/ews/models/build.py:
1879         * BuildSlaveSupport/ews-app/ews/models/step.py:
1880
1881 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1882
1883         [ews-app] Status bubble display pending for currently running build step
1884         https://bugs.webkit.org/show_bug.cgi?id=195744
1885
1886         Reviewed by Lucas Forschler.
1887
1888         * BuildSlaveSupport/ews-build/events.py:
1889         (Events.stepStarted): If state_string is pending, replace it with step name.
1890
1891 2019-03-14  Chris Dumez  <cdumez@apple.com>
1892
1893         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1894         https://bugs.webkit.org/show_bug.cgi?id=195750
1895
1896         Reviewed by Geoffrey Garen.
1897
1898         Add API test coverage.
1899
1900         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1901         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1902         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1903         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1904
1905 2019-03-14  Chris Dumez  <cdumez@apple.com>
1906
1907         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1908         https://bugs.webkit.org/show_bug.cgi?id=195747
1909
1910         Reviewed by Geoff Garen.
1911
1912         Add API test coverage.
1913
1914         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1915
1916 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1917
1918         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1919         https://bugs.webkit.org/show_bug.cgi?id=195725
1920         <rdar://problem/48545062>
1921
1922         Reviewed by Tim Horton.
1923
1924         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1925         handler is nil.
1926
1927         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1928         (TestWebKitAPI::TEST):
1929
1930 2019-03-13  Sam Weinig  <sam@webkit.org>
1931
1932         Add utility function to allow easy reverse range-based iteration of a container
1933         https://bugs.webkit.org/show_bug.cgi?id=195542
1934
1935         Reviewed by Antti Koivisto.
1936
1937         * TestWebKitAPI/CMakeLists.txt:
1938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1939         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1940         (TestWebKitAPI::TEST):
1941         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1942
1943 2019-03-13  Chris Dumez  <cdumez@apple.com>
1944
1945         Use a ServiceWorker process per registrable domain
1946         https://bugs.webkit.org/show_bug.cgi?id=195649
1947
1948         Reviewed by Youenn Fablet.
1949
1950         Update API test coverage.
1951
1952         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1953
1954 2019-03-13  Chris Dumez  <cdumez@apple.com>
1955
1956         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1957         https://bugs.webkit.org/show_bug.cgi?id=195684
1958         <rdar://problem/48294714>
1959
1960         Reviewed by Antti Koivisto.
1961
1962         Add API test coverage.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1965
1966 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1967
1968         [ews-app] Remove unused patch view
1969         https://bugs.webkit.org/show_bug.cgi?id=195669
1970
1971         Reviewed by Lucas Forschler.
1972
1973         * BuildSlaveSupport/ews-app/ews/urls.py:
1974         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1975
1976 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1977
1978         [ews-app] Use Buildbot result code variables
1979         https://bugs.webkit.org/show_bug.cgi?id=195668
1980
1981         Reviewed by Alexey Proskuryakov.
1982
1983         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1984         (Buildbot): Added Buildbot result code variables.
1985         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1986         (StatusBubble._build_bubble): Used Buildbot result code variables.
1987
1988 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1989
1990         [Flatpak] Expand submodule recursively
1991         https://bugs.webkit.org/show_bug.cgi?id=195672
1992
1993         Building WPE with flatpak was impossible without that as it was raising an exception.
1994         Also update wpebackend-fdo to match what is built in jhbuild
1995
1996         Reviewed by Philippe Normand.
1997
1998         * flatpak/flatpakutils.py:
1999         (expand_submodules_recurse):
2000         (expand_manifest):
2001         * flatpak/org.webkit.WPEModules.yaml:
2002
2003 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2004
2005         [ews-app] status bubble should be hidden for certain builds
2006         https://bugs.webkit.org/show_bug.cgi?id=194597
2007
2008         Reviewed by Dewei Zhu.
2009
2010         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2011         (StatusBubble._build_bubble):
2012         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2013         because the patch didn't have relevant changes.
2014         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2015         in production yet.
2016
2017 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2018
2019         [Win] Fix a slew of simple clang-cl warnings.
2020         https://bugs.webkit.org/show_bug.cgi?id=195652
2021
2022         Reviewed by Don Olmstead.
2023
2024         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2025         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2026
2027 2019-03-12  Justin Fan  <justin_fan@apple.com>
2028
2029         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2030         https://bugs.webkit.org/show_bug.cgi?id=195518
2031         <rdar://problem/46322356>
2032
2033         Reviewed by Myles C. Maxfield.
2034
2035         * DumpRenderTree/DerivedSources-input.xcfilelist:
2036         * DumpRenderTree/DerivedSources-output.xcfilelist:
2037
2038 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2039
2040         Unreviewed, rolling out r242825.
2041         https://bugs.webkit.org/show_bug.cgi?id=195648
2042
2043         "Broke webkitpy tests with my change to
2044         lldb_dump_class_layout.py" (Requested by rmorisset on
2045         #webkit).
2046
2047         Reverted changeset:
2048
2049         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2050         classes with suspicious padding"
2051         https://bugs.webkit.org/show_bug.cgi?id=195573
2052         https://trac.webkit.org/changeset/242825
2053
2054 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2055
2056         [ews-build] Show status bubbles while the patch is waiting in queue
2057         https://bugs.webkit.org/show_bug.cgi?id=195618
2058
2059         Reviewed by Lucas Forschler.
2060
2061         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2062         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2063         enabled in initial deployment.
2064         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2065         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2066         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2067         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2068         (StatusBubble._build_bubbles_for_patch):
2069
2070 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2071
2072         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2073         https://bugs.webkit.org/show_bug.cgi?id=195573
2074
2075         Reviewed by Simon Fraser.
2076
2077         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2078
2079         * Scripts/dump-class-layout:
2080         (main):
2081         * lldb/lldb_dump_class_layout.py:
2082         (ClassLayout.__init__):
2083         (ClassLayout._compute_padding_recursive):
2084         (LLDBDebuggerInstance.dump_layout_for_classname):
2085         (LLDBDebuggerInstance):
2086         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2087         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2088
2089 2019-03-12  Chris Dumez  <cdumez@apple.com>
2090
2091         Device Orientation access permission should be denied unless explicitly granted by the client
2092         https://bugs.webkit.org/show_bug.cgi?id=195625
2093
2094         Reviewed by Youenn Fablet.
2095
2096         add API test coverage.
2097
2098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2100         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2101         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2102         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2103         (runDeviceOrientationTest):
2104         (TEST):
2105         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2106         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2107
2108 2019-03-12  Jer Noble  <jer.noble@apple.com>
2109
2110         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2111         https://bugs.webkit.org/show_bug.cgi?id=195137
2112         <rdar://problem/48810307>
2113
2114         Reviewed by Eric Carlson.
2115
2116         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2117         (TestWebKitAPI::TEST):
2118
2119 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2120
2121         [ews-build] Change urls from uat to production
2122         https://bugs.webkit.org/show_bug.cgi?id=195566
2123
2124         Reviewed by Lucas Forschler.
2125
2126         * BuildSlaveSupport/ews-app/ews/config.py:
2127         * BuildSlaveSupport/ews-build/events.py:
2128         * BuildSlaveSupport/ews-build/steps.py:
2129
2130 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2131
2132         [ews-build] change max_builds for local-worker to 1
2133         https://bugs.webkit.org/show_bug.cgi?id=195568
2134
2135         Reviewed by Lucas Forschler.
2136
2137         * BuildSlaveSupport/ews-build/loadConfig.py:
2138
2139 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2140
2141         Fix the build
2142
2143         * TestRunnerShared/spi/PencilKitTestSPI.h:
2144         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2145
2146 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2147
2148         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2149         https://bugs.webkit.org/show_bug.cgi?id=194131
2150
2151         Reviewed by Michael Catanzaro.
2152
2153         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2154         (uriChanged):
2155         (testUnfinishedSubresourceLoad):
2156         (serverCallback):
2157         (beforeAll):
2158
2159 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2160
2161         WTF::Expected should use std::addressof instead of operator&
2162         https://bugs.webkit.org/show_bug.cgi?id=195604
2163
2164         Reviewed by Myles Maxfield.
2165
2166         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2167         (TestWebKitAPI::Unique::Unique):
2168         (TestWebKitAPI::Unique::operator&):
2169         (TestWebKitAPI::TEST):
2170
2171 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2172
2173         Add Optional to Forward.h.
2174         https://bugs.webkit.org/show_bug.cgi?id=195586
2175
2176         Reviewed by Darin Adler.
2177
2178         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2179         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2180         Remove unnecessary includes from headers.
2181
2182 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2183
2184         Add testing API to hit-test and scroll overflow scrollers
2185         https://bugs.webkit.org/show_bug.cgi?id=195278
2186
2187         Reviewed by Antti Koivisto.
2188         
2189         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2190         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2191         
2192         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2193
2194         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2195         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2196         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2197         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2198         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2199         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2200         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2201         (WTR::enclosingScrollViewIncludingSelf):
2202         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2203
2204 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2205
2206         API test WebKit.RequestTextInputContext fails on iOS
2207         https://bugs.webkit.org/show_bug.cgi?id=195585
2208
2209         Reviewed by Wenson Hsieh and Simon Fraser.
2210
2211         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2212         (applyStyle):
2213         (TEST):
2214         Add a viewport, so that the coordinates match up on iOS.
2215         Scroll by moving the UIScrollView's contentOffset.
2216
2217 2019-03-11  Chris Dumez  <cdumez@apple.com>
2218
2219         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2220         https://bugs.webkit.org/show_bug.cgi?id=195506
2221         <rdar://problem/48733477>
2222
2223         Reviewed by Alex Christensen.
2224
2225         Add API test coverage.
2226
2227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2228
2229 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2230
2231         Adding myself to contributors.json
2232
2233         Unreviewed, addming myself to contributors.json .
2234
2235         * Scripts/webkitpy/common/config/contributors.json:
2236
2237 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2238
2239         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2240         https://bugs.webkit.org/show_bug.cgi?id=195511
2241         <rdar://problem/44873269>
2242
2243         Reviewed by Darin Adler.
2244
2245         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2246         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2247         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2248         (TEST_F):
2249
2250 2019-03-11  Chris Dumez  <cdumez@apple.com>
2251
2252         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2253         https://bugs.webkit.org/show_bug.cgi?id=195561
2254
2255         Reviewed by Youenn Fablet.
2256
2257         Make sure the JS in the test requests for permission to receive device orientation events.
2258
2259         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2260
2261 2019-03-11  Youenn Fablet  <youenn@apple.com>
2262
2263         Allow storage quota increase by default in WTR
2264         https://bugs.webkit.org/show_bug.cgi?id=195541
2265
2266         Reviewed by Geoffrey Garen.
2267
2268         Allow storage quota increase by default in WTR.
2269         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2270         Use this for tests that explicitly need cache increase.
2271
2272         Instead of increasing quota by 2, make sure the next request is
2273         granted by adding all given parameters.
2274
2275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2277         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2278         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2280         * WebKitTestRunner/TestController.cpp:
2281         (WTR::TestController::setAllowStorageQuotaIncrease):
2282         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2283         * WebKitTestRunner/TestController.h:
2284         * WebKitTestRunner/TestInvocation.cpp:
2285         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2286         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2287         (WTR::TestController::cocoaResetStateToConsistentValues):
2288         (WTR::TestController::setAllowStorageQuotaIncrease):
2289         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2290         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2291         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2292
2293 2019-03-11  Xan Lopez  <xan@igalia.com>
2294
2295         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2296         https://bugs.webkit.org/show_bug.cgi?id=194147
2297
2298         Reviewed by Michael Saboff.
2299
2300         To make --32-bit work correctly on Linux/64bit we need to:
2301
2302         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2303         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2304         unfortunately CMake only allows us to do this during
2305         crosscompilation, which is overkill here.
2306         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2307         pkg-config detection module uses the x86 .pc files instead of the
2308         x86_64 ones.
2309         - Set the -m32 flags for the compiler.
2310
2311         * Scripts/webkitdirs.pm:
2312         (generateBuildSystemFromCMakeProject):
2313
2314 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2315
2316         Add MotionMark-1.1 plan file for run-benchmark script.
2317         https://bugs.webkit.org/show_bug.cgi?id=195481
2318
2319         Rubber-stamped by Darin Adler.
2320
2321         Run-benchmark script should support MontionMark-1.1.
2322
2323         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2324
2325 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2326
2327         [ews-app] Add support for submit-to-ews url
2328         https://bugs.webkit.org/show_bug.cgi?id=195477
2329
2330         Reviewed by Lucas Forschler.
2331
2332         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2333         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2334         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2335         * BuildSlaveSupport/ews-app/ews/urls.py:
2336         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2337
2338 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2339
2340         Unreviewed, rolling out r242688, r242643, r242624.
2341
2342         Caused multiple layout test failures and crashes on iOS and macOS.
2343
2344         Reverted changeset:
2345
2346         "requestAnimationFrame should execute before the next frame"
2347         https://bugs.webkit.org/show_bug.cgi?id=177484
2348         https://trac.webkit.org/changeset/242624/webkit
2349
2350         * Tracing/SystemTracePoints.plist:
2351
2352 2019-03-11  John Wilander  <wilander@apple.com>
2353
2354         Resource Load Statistics: Make it possible exclude localhost from classification
2355         https://bugs.webkit.org/show_bug.cgi?id=195474
2356         <rdar://problem/47520577>
2357
2358         Reviewed by Brent Fulgham.
2359
2360         This patch allows for localhost to be excluded from classification and
2361         treatment as a prevalent resource.
2362
2363         The WebKit Tools change adds a new function called
2364         testRunner.setStatisticsIsRunningTest() which can be used to control this
2365         behavior.
2366
2367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2369         (WTR::TestRunner::setStatisticsIsRunningTest):
2370         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2371         * WebKitTestRunner/TestController.cpp:
2372         (WTR::TestController::setStatisticsIsRunningTest):
2373         * WebKitTestRunner/TestController.h:
2374         * WebKitTestRunner/TestInvocation.cpp:
2375         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2376
2377 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2378
2379         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2380         https://bugs.webkit.org/show_bug.cgi?id=195560
2381
2382         Reviewed by Lucas Forschler.
2383
2384         * BuildSlaveSupport/ews-build/master.cfg:
2385
2386 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2387
2388         Unreviewed, rolling out r242698.
2389
2390         API test crashes on bots.
2391
2392         Reverted changeset:
2393
2394         "Add a WKContentRuleList variant that uses copied memory
2395         instead of mmap'd shared memory for class A containerized
2396         apps"
2397         https://bugs.webkit.org/show_bug.cgi?id=195511
2398         https://trac.webkit.org/changeset/242698
2399
2400 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2401
2402         [WPE] Enable web process sandbox
2403         https://bugs.webkit.org/show_bug.cgi?id=195169
2404
2405         Reviewed by Daniel Bates.
2406
2407         * wpe/install-dependencies:
2408         * wpe/jhbuild.modules:
2409
2410 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2411
2412         [ews-app] Use port 17000 for worker communication
2413         https://bugs.webkit.org/show_bug.cgi?id=195558
2414
2415         Reviewed by Lucas Forschler.
2416
2417         * BuildSlaveSupport/ews-build/master.cfg:
2418
2419 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2420
2421         [ews-build] unit-tests fail when passwords.json is missing
2422         https://bugs.webkit.org/show_bug.cgi?id=195557
2423
2424         Reviewed by Lucas Forschler.
2425
2426         * BuildSlaveSupport/ews-build/loadConfig.py:
2427         (loadBuilderConfig):
2428         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2429         (ConfigDotJSONTest.test_configuration):
2430         * BuildSlaveSupport/ews-build/master.cfg:
2431
2432 2019-03-11  Truitt Savell  <tsavell@apple.com>
2433
2434         Unreviewed, rolling out r242702.
2435
2436         Broke High Sierra builders.
2437
2438         Reverted changeset:
2439
2440         "Add utility function to allow easy reverse range-based
2441         iteration of a container"
2442         https://bugs.webkit.org/show_bug.cgi?id=195542
2443         https://trac.webkit.org/changeset/242702
2444
2445 2019-03-11  Sam Weinig  <sam@webkit.org>
2446
2447         Add utility function to allow easy reverse range-based iteration of a container
2448         https://bugs.webkit.org/show_bug.cgi?id=195542
2449
2450         Reviewed by Antti Koivisto.
2451
2452         * TestWebKitAPI/CMakeLists.txt:
2453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2454         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2455         (TestWebKitAPI::TEST):
2456         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2457
2458 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2459
2460         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2461         https://bugs.webkit.org/show_bug.cgi?id=195511
2462         <rdar://problem/44873269>
2463
2464         Reviewed by Darin Adler.
2465
2466         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2467         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2468         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2469         (TEST_F):
2470
2471 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2472
2473         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2474         https://bugs.webkit.org/show_bug.cgi?id=195499
2475
2476         Reviewed by Darin Adler.
2477
2478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2479         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2480         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2481         (-[WKWebView synchronouslyFocusTextInputContext:]):
2482         (applyStyle):
2483         (applyIframe):
2484         (TEST):
2485         Add some tests for this SPI.
2486
2487 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2488
2489         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2490         https://bugs.webkit.org/show_bug.cgi?id=181151
2491
2492         Reviewed by Don Olmstead.
2493
2494         * TestWebKitAPI/CMakeLists.txt:
2495         * TestWebKitAPI/PlatformWin.cmake:
2496         Enable TestWTF RunLoop tests in all platforms.
2497
2498         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2499         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2500         (TestWebKitAPI::DerivedOneShotTimer::fired):
2501         (TestWebKitAPI::TEST):
2502         Only a few platforms support nested RunLoop.
2503
2504         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2505         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2506
2507 2019-03-10  David Quesada  <david_quesada@apple.com>
2508
2509         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2510         https://bugs.webkit.org/show_bug.cgi?id=152480
2511
2512         Reviewed by Chris Dumez.
2513
2514         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2515         there are no additional references to the process pool besides the one held by
2516         the download, waits for the download to finish (in the sense that the
2517         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2518         measure, also check that the process pool has been deallocated at the end of the
2519         test. The test wouldn't be meaningful if the process pool were still alive.
2520
2521         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2522         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2523         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2524             The download will be canceled because the delegate does not implement the
2525             method to decide the download's destination, so this is where we know the
2526             DownloadProxyMap is done with the DownloadProxy.
2527         (TEST):
2528
2529 2019-03-08  Chris Dumez  <cdumez@apple.com>
2530
2531         Add support for Device Orientation / Motion permission API
2532         https://bugs.webkit.org/show_bug.cgi?id=195329
2533         <rdar://problem/47645367>
2534
2535         Reviewed by Geoffrey Garen.
2536
2537         Add test infrastructure to help test the Device Orientation / Motion permission API.
2538
2539         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2540         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2541         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2542         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2543         * WebKitTestRunner/TestController.cpp:
2544         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2545         (WTR::TestController::createWebViewWithOptions):
2546         (WTR::TestController::resetStateToConsistentValues):
2547         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2548         * WebKitTestRunner/TestController.h:
2549         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2550         * WebKitTestRunner/TestInvocation.cpp:
2551         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2552
2553 2019-03-08  Saam barati  <sbarati@apple.com>
2554
2555         Add a compare-results script to compare benchmark results
2556         https://bugs.webkit.org/show_bug.cgi?id=195486
2557         <rdar://problem/48723397>
2558
2559         Reviewed by Geoffrey Garen.
2560
2561         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2562         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2563         to extend it to learn about our other benchmarks.
2564
2565         * Scripts/compare-results: Added.
2566         (readJSONFile):
2567         (detectJetStream2):
2568         (JetStream2Results):
2569         (detectSpeedometer2):
2570         (Speedometer2Results):
2571         (detectPLT5):
2572         (PLT5Results):
2573         (detectBenchmark):
2574         (biggerIsBetter):
2575         (ttest):
2576         (getOptions):
2577         (main):
2578
2579 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2580
2581         Ensure old tab state is cleared between iterations of run-benchmark
2582         https://bugs.webkit.org/show_bug.cgi?id=195393
2583         <rdar://problem/46885583>
2584
2585         Reviewed by Dewei Zhu.
2586
2587         a) ensure the default to restore state is not set
2588         b) terminate Safari correctly
2589         c) Set the system default to ignore Persistent State in Safari
2590
2591         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2592         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2593         (OSXBrowserDriver.prepare_env): 
2594         (OSXBrowserDriver.restore_env):
2595         (OSXBrowserDriver.close_browsers):
2596         (OSXBrowserDriver._terminate_processes):
2597         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2598         (OSXChromeDriver):
2599         (OSXChromeCanaryDriver):
2600         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2601         (OSXFirefoxDriver):
2602         (OSXFirefoxNightlyDriver):
2603         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2604         (OSXSafariDriver):
2605         (OSXSafariDriver.prepare_env):
2606
2607 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2608
2609         [GTK] Several InputMethodFilter tests are failing
2610         https://bugs.webkit.org/show_bug.cgi?id=195408
2611
2612         Reviewed by Carlos Garcia Campos.
2613
2614         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2615         Regressed in r241751.
2616         Hexadecimal values of keycodes are expressed now in upper letters.
2617         Composited characters should be cast to UTF8 strings.
2618
2619         (TestWebKitAPI::TEST):
2620
2621 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2622
2623         [GTK] Make Tools/gtkdoc python3 compatible
2624         https://bugs.webkit.org/show_bug.cgi?id=195359
2625
2626         Reviewed by Carlos Garcia Campos.
2627
2628         * gtkdoc/generate-gtkdoc:
2629         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2630         work with Python 2 and 3.
2631         (get_gtkdoc_module_paths):
2632         The iteritems() was removed in Python 3, so let's use items() that's
2633         available in Python 2 and 3.
2634         (get_generator_for_config):
2635         * gtkdoc/gtkdoc.py:
2636         (GTKDoc._run_command):
2637         The sys.stdout.write() is expecting str in Python 3 and not bytes
2638         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2639         for passing the bytes there.
2640
2641 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2642
2643         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2644         https://bugs.webkit.org/show_bug.cgi?id=195346
2645         <rdar://problem/48667048>
2646
2647         Unreviewed build fix for clang-cl.
2648
2649         * DumpRenderTree/win/DumpRenderTree.cpp:
2650         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2651
2652 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2653
2654         requestAnimationFrame should execute before the next frame
2655         https://bugs.webkit.org/show_bug.cgi?id=177484
2656
2657         Reviewed by Simon Fraser.
2658
2659         Add trace points for the page RenderingUpdate.
2660
2661         * Tracing/SystemTracePoints.plist:
2662
2663 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2664
2665         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2666         https://bugs.webkit.org/show_bug.cgi?id=195353
2667         <rdar://problem/48626394>
2668
2669         Reviewed by Simon Fraser.
2670
2671         * WebKitTestRunner/ios/TestControllerIOS.mm:
2672         (WTR::TestController::platformResetPreferencesToConsistentValues):
2673
2674 2019-03-07  John Wilander  <wilander@apple.com>
2675
2676         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2677         https://bugs.webkit.org/show_bug.cgi?id=195383
2678         <rdar://problem/48570136>
2679
2680         Reviewed by Brent Fulgham.
2681
2682         This patch adds test infrastructure to purge only script-accessible cookies,
2683         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2684
2685         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2686         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2687         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2689         * WebKitTestRunner/TestController.cpp:
2690         (WTR::TestController::statisticsDeleteCookiesForHost):
2691         * WebKitTestRunner/TestController.h:
2692         * WebKitTestRunner/TestInvocation.cpp:
2693         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2694
2695 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2696
2697         Unreviewed, rolling out r242354.
2698         https://bugs.webkit.org/show_bug.cgi?id=195402
2699
2700         breaks layout tests in all configurations (Requested by
2701         zdobersek on #webkit).
2702
2703         Reverted changeset:
2704
2705         "[WPE] Enable web process sandbox"
2706         https://bugs.webkit.org/show_bug.cgi?id=195169
2707         https://trac.webkit.org/changeset/242354
2708
2709 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2710
2711         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2712         https://bugs.webkit.org/show_bug.cgi?id=195346
2713
2714         Reviewed by Fujii Hironori.
2715
2716         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2717         (TestWebKitAPI::TEST):
2718         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2719
2720         * DumpRenderTree/win/DumpRenderTree.cpp:
2721         (findFontFallback):
2722         (addFontFallbackIfPresent):
2723         (removeFontFallbackIfPresent):
2724         (main):
2725         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2726         (TestWebKitAPI::Util::moduleDirectory):
2727         (TestWebKitAPI::Util::createInjectedBundlePath):
2728         Use wchar helpers as needed.
2729
2730 2019-03-06  Rob Buis  <rbuis@igalia.com>
2731
2732         Consider supporting the `referrerpolicy` attribute.
2733         https://bugs.webkit.org/show_bug.cgi?id=179053
2734
2735         Reviewed by Darin Adler.
2736
2737         Add a runtime flag for referrerpolicy attribute.
2738
2739         * DumpRenderTree/mac/DumpRenderTree.mm:
2740         (enableExperimentalFeatures):
2741
2742 2019-03-05  Daniel Bates  <dabates@apple.com>
2743
2744         Update expected API test result following r242379
2745         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2746
2747         Update expected x-coordinate of selection rect now that the left padding of
2748         a textarea is sized in ems (so dependent on the font size) just like the left
2749         padding of a text field.
2750
2751         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2752         (TestWebKitAPI::TEST):
2753
2754 2019-03-05  David Quesada  <david_quesada@apple.com>
2755
2756         [WK2] It should be possible to follow links with 'download' attributes
2757         https://bugs.webkit.org/show_bug.cgi?id=195145
2758         rdar://problem/48462642
2759
2760         Reviewed by Alex Christensen.
2761
2762         Add a unit test to verify that activating links with 'download' attributes now
2763         navigates to the linked resource, rather than starts downloading it. Add another
2764         to verify that it is still possible to explicitly download the link via the
2765         'Download' navigation action policy.
2766
2767         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2768         (-[DownloadAttributeTestDelegate init]):
2769         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2770         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2771         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2772         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2773         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2774         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2775         (TEST):
2776         * WebKitTestRunner/TestController.cpp:
2777         (WTR::TestController::decidePolicyForNavigationAction):
2778         * WebKitTestRunner/TestController.h:
2779
2780 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2781
2782         [Curl] Implement Cookie Accept Policy.
2783         https://bugs.webkit.org/show_bug.cgi?id=191645
2784
2785         Reviewed by Fujii Hironori.
2786
2787         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2788         (TestWebKitAPI::Curl::TEST_F):
2789
2790 2019-03-05  Youenn Fablet  <youenn@apple.com>
2791
2792         Rename requestCacheStorageSpace to requestStorageSpace
2793         https://bugs.webkit.org/show_bug.cgi?id=195282
2794
2795         Reviewed by Chris Dumez.
2796
2797         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2798         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2799         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2800
2801 2019-03-05  Brady Eidson  <beidson@apple.com>
2802
2803         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2804         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2805
2806         Reviewed by Tim Horton.
2807
2808         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2809         different directory into that same WKWebView should work.
2810
2811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2812         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2813
2814 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2815
2816         Add WeakHashSet
2817         https://bugs.webkit.org/show_bug.cgi?id=195152
2818
2819         Reviewed by Antti Koivisto.
2820
2821         Added tests for WeakHashSet.
2822
2823         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2824         (TestWebKitAPI::Base::Base): Moved.
2825         (TestWebKitAPI::Derived::foo): Moved.
2826         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2827         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2828         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2829         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2830
2831 2019-03-04  Chris Dumez  <cdumez@apple.com>
2832
2833         Do not share WebProcesses between private and regular sessions
2834         https://bugs.webkit.org/show_bug.cgi?id=195189
2835         <rdar://problem/48421064>
2836
2837         Reviewed by Alex Christensen.
2838
2839         Add API test coverage.
2840
2841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2842         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2843
2844 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2845
2846         [WPE] Enable web process sandbox
2847         https://bugs.webkit.org/show_bug.cgi?id=195169
2848
2849         Reviewed by Daniel Bates.
2850
2851         * wpe/install-dependencies:
2852         * wpe/jhbuild.modules:
2853
2854 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2855
2856         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2857         https://bugs.webkit.org/show_bug.cgi?id=195206
2858
2859         Reviewed by Žan Doberšek.
2860
2861         Add a new test case.
2862
2863         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2864         (testJSCClass):
2865
2866 2019-03-04  Charlie Turner  <cturner@igalia.com>
2867
2868         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2869         https://bugs.webkit.org/show_bug.cgi?id=194898
2870
2871         Reviewed by Žan Doberšek.
2872
2873         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2874         a GCC extension that permits arithmetic on void* pointer. Inline
2875         the macro until this issue is fixed upstream.
2876
2877 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2878
2879         Rid the world of WK_API_ENABLED
2880         https://bugs.webkit.org/show_bug.cgi?id=195263
2881
2882         Reviewed by Dan Bernstein.
2883
2884         List of changed files elided because it's useless.
2885
2886 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2887
2888         Unreviewed follow-up to r242292.
2889
2890         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2891
2892         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2893         (TestWebKitAPI::testStrip): Renamed from strip.
2894         (TestWebKitAPI::TEST):
2895
2896 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2897
2898         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2899
2900         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2901         and bug #194272 for details.
2902
2903         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2904
2905 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2906
2907         Remove some more unused 32-bit code
2908         https://bugs.webkit.org/show_bug.cgi?id=195255
2909
2910         Reviewed by Darin Adler.
2911
2912         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2913         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2914         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2915         (NPP_New):
2916         (NPP_HandleEvent):
2917         (handleEventCarbon): Deleted.
2918
2919 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2920
2921         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2922
2923         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2924         (TestWebKitAPI::TEST):
2925
2926 2019-03-01  Darin Adler  <darin@apple.com>
2927
2928         Finish removing String::format
2929         https://bugs.webkit.org/show_bug.cgi?id=194893
2930
2931         Reviewed by Daniel Bates.
2932 '
2933         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2934
2935 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2936
2937         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2938         https://bugs.webkit.org/show_bug.cgi?id=195229
2939         <rdar://problem/48520362>
2940
2941         Reviewed by Chris Dumez.
2942
2943         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2944         (TEST):
2945
2946 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2947
2948         Add a system trace scope for event region building
2949         https://bugs.webkit.org/show_bug.cgi?id=195226
2950
2951         Reviewed by Jon Lee.
2952
2953         This trace scope measures the time spend converting element rects into Region objects,
2954         which can be large on some pages.
2955
2956         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2957
2958         * Tracing/SystemTracePoints.plist:
2959
2960 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2961
2962         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2963         https://bugs.webkit.org/show_bug.cgi?id=194612
2964
2965         Reviewed by Alex Christensen.
2966
2967         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2968         Just test the new string-processing function and don't touch the actual environment.
2969         (Test cases are all as before, but based on operator== instead of strcmp.)
2970
2971 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2972
2973         [ews-app] Update primary keys for handling multiple Buildbot instances
2974         https://bugs.webkit.org/show_bug.cgi?id=195120
2975
2976         Reviewed by Stephanie Lewis.
2977
2978         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2979         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2980         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2981
2982         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2983         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2984         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2985         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2986         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2987         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2988
2989 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2990
2991         [WinCairo] Enable service worker
2992         https://bugs.webkit.org/show_bug.cgi?id=188318
2993
2994         Reviewed by Youenn Fablet.
2995
2996         * DumpRenderTree/DumpRenderTreePrefix.h:
2997         * TestWebKitAPI/PlatformWin.cmake:
2998         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2999         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3000         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3001
3002 2019-03-01  Justin Fan  <justin_fan@apple.com>
3003
3004         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3005         https://bugs.webkit.org/show_bug.cgi?id=195191
3006
3007         Rubber-stamped by Dean Jackson.
3008
3009         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3010
3011         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3012
3013 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3014
3015         Unreviewed, fix lldb webkitpy tests
3016         https://bugs.webkit.org/show_bug.cgi?id=194375
3017
3018         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3019
3020         * lldb/lldb_webkit.py:
3021         (WTFStringImplProvider.is_8bit):
3022
3023 2019-02-28  David Quesada  <david_quesada@apple.com>
3024
3025         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3026         https://bugs.webkit.org/show_bug.cgi?id=195121
3027         rdar://problem/48450302
3028
3029         Reviewed by Alex Christensen.
3030
3031         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3032         configurations where the 'download' attribute is absent, blank, or populated
3033         with a filename, and where the anchor element is same-origin or cross-origin
3034         (meaning the 'download' attribute shouldn't be honored).
3035
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3037         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3038         (-[NavigationActionTestDelegate init]):
3039         (-[NavigationActionTestDelegate navigationAction]):
3040         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3041         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3042         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3043         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3044         (TEST):
3045
3046 2019-02-28  Antoine Quint  <graouts@apple.com>
3047
3048         Enable the Pointer Events runtime flag by default
3049         https://bugs.webkit.org/show_bug.cgi?id=195156
3050
3051         Reviewed by Dean Jackson.
3052
3053         * DumpRenderTree/mac/DumpRenderTree.mm:
3054         (enableExperimentalFeatures):
3055
3056 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3057
3058         Several PasteImage API tests are flaky
3059         https://bugs.webkit.org/show_bug.cgi?id=195160
3060
3061         Reviewed by Tim Horton.
3062
3063         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3064         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3065         listening for a "load" event after image load is already complete.
3066
3067         To address this, make these tests first register a "load" event handler, then run script to insert an image
3068         element into the document, and finally wait until the load event is observed before checking image size.
3069
3070         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3071
3072 2019-02-28  Chris Dumez  <cdumez@apple.com>
3073
3074         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3075         https://bugs.webkit.org/show_bug.cgi?id=195107
3076
3077         Reviewed by Alex Christensen.
3078
3079         Give some time for the zoom level to get restored.
3080
3081         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3082
3083 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3084
3085         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3086         https://bugs.webkit.org/show_bug.cgi?id=194958
3087
3088         Reviewed by Geoffrey Garen.
3089
3090         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3091         (TEST):
3092
3093 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3094
3095         [ews-app] Update method to save build to handle builder_display_name
3096         https://bugs.webkit.org/show_bug.cgi?id=195047
3097
3098         Reviewed by Dewei Zhu.
3099
3100         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3101         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3102
3103 2019-02-28  Justin Fan  <justin_fan@apple.com>
3104
3105         [Web GPU] Enable Web GPU only on 64-bit
3106         https://bugs.webkit.org/show_bug.cgi?id=195139
3107
3108         Because Metal is only supported on 64 bit apps.
3109
3110         Unreviewed build fix.
3111
3112         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3113
3114 2019-02-27  Youenn Fablet  <youenn@apple.com>
3115
3116         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3117         https://bugs.webkit.org/show_bug.cgi?id=194959
3118
3119         Reviewed by Chris Dumez.
3120
3121         Spin loop until getting the condition to remove flakiness.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3124
3125 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3126
3127         [ews-build] Buildbot should include builder_display_name in the build events
3128         https://bugs.webkit.org/show_bug.cgi?id=195045
3129
3130         Reviewed by Dewei Zhu.
3131
3132         * BuildSlaveSupport/ews-build/events.py:
3133         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3134         buildername to builder_name to be consistent in naming style.
3135         (Events.buildFinished): Ditto.
3136
3137 2019-02-27  Chris Dumez  <cdumez@apple.com>
3138
3139         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3140         https://bugs.webkit.org/show_bug.cgi?id=194480
3141
3142         Reviewed by Brady Eidson.
3143
3144         Update existing API test to make it more likely to reproduce the issue.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3147
3148 2019-02-27  Brady Eidson  <beidson@apple.com>
3149
3150         Universal links from Google search results pages don't open the app.
3151         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3152
3153         Reviewed by Geoffrey Garen.
3154
3155         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3156         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3157         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3158         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3159
3160 2019-02-27  Chris Dumez  <cdumez@apple.com>
3161
3162         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3163         https://bugs.webkit.org/show_bug.cgi?id=195102
3164
3165         Reviewed by Geoffrey Garen.
3166
3167         If the number of processes is not yet what we expect, wait a bit and check again to give
3168         processes some time to exit.
3169
3170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3171
3172 2019-02-27  Chris Dumez  <cdumez@apple.com>
3173
3174         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3175         https://bugs.webkit.org/show_bug.cgi?id=194545
3176
3177         Reviewed by Brady Eidson.
3178
3179         Make sure the test navigates forward and then back only once. Previously, navigating
3180         back would trigger a navigation again in a timer.
3181
3182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3183
3184 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3185
3186         High Sierra Debug JSC test queue should use faster hardware
3187         https://bugs.webkit.org/show_bug.cgi?id=194603
3188
3189         Rubber-stamped by Alexey Proskuryakov.
3190
3191         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3192
3193         * BuildSlaveSupport/build.webkit.org-config/config.json:
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3195         (BubbleQueueServer):
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3197         (WebKitBuildbot):
3198         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3199         * QueueStatusServer/config/queues.py:
3200         * Scripts/webkitpy/common/config/ews.json:
3201         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3202         (test_ews_name):
3203
3204 2019-02-27  John Wilander  <wilander@apple.com>
3205
3206         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3207         https://bugs.webkit.org/show_bug.cgi?id=195071
3208         <rdar://problem/48417690>
3209
3210         Reviewed by Alex Christensen and Brent Fulgham.
3211
3212         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3213         (TestWebKitAPI::createURL):
3214             Convenience function.
3215         (TestWebKitAPI::TEST):
3216             WebCore::AdClickAttribution now takes a URL when creating Source and
3217             Destination.
3218         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3219         (TestWebKitAPI::TEST):
3220             WebCore::AdClickAttribution now takes a URL when creating Source and
3221             Destination.
3222
3223 2019-02-27  Antoine Quint  <graouts@apple.com>
3224
3225         Support Pointer Events on macOS
3226         https://bugs.webkit.org/show_bug.cgi?id=195008
3227         <rdar://problem/47454419>
3228
3229         Reviewed by Dean Jackson.
3230
3231         * DumpRenderTree/mac/DumpRenderTree.mm:
3232         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3233         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3234
3235 2019-02-26  Mark Lam  <mark.lam@apple.com>
3236
3237         Remove remaining poisoning code.
3238         https://bugs.webkit.org/show_bug.cgi?id=194138
3239
3240         Reviewed by Saam Barati.
3241
3242         * TestWebKitAPI/CMakeLists.txt:
3243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3244         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3245         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3246         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3247         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3248         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3249         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3250
3251 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3252
3253         Move ephemeral local storage from WebProcess to UIProcess
3254         https://bugs.webkit.org/show_bug.cgi?id=195074
3255         <rdar://problem/47937975>
3256
3257         Reviewed by Geoff Garen.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3260
3261 2019-02-20  Jer Noble  <jer.noble@apple.com>
3262
3263         [Cocoa] Media elements will restart network buffering just before suspending
3264         https://bugs.webkit.org/show_bug.cgi?id=193691
3265
3266         Reviewed by Eric Carlson.
3267
3268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3270         (TEST):
3271
3272 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3273
3274         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3275         https://bugs.webkit.org/show_bug.cgi?id=191652
3276
3277         Reviewed by Alex Christensen.
3278
3279         Fix WinCairo MiniBrowser behavior of authentication dialog.
3280
3281         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3282         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3283
3284 2019-02-26  Youenn Fablet  <youenn@apple.com>
3285
3286         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3287         https://bugs.webkit.org/show_bug.cgi?id=195028
3288         <rdar://problem/48243733>
3289
3290         Reviewed by Eric Carlson.
3291
3292         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3293
3294 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3295
3296         [WPE] Add API for webview background color configuration
3297         https://bugs.webkit.org/show_bug.cgi?id=192305
3298
3299         Reviewed by Michael Catanzaro.
3300
3301         * MiniBrowser/wpe/main.cpp:
3302         (main): Add a new option to configure the webview background
3303         color. Example: --bg-color=transparent.
3304         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3305         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3306         (beforeAll): Ditto.
3307
3308 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3309
3310         scalableNativeWebpageParameters() is not preserved on new page navigation.
3311         https://bugs.webkit.org/show_bug.cgi?id=194892
3312         <rdar://problem/47538280>
3313
3314         Reviewed by Wenson Hsieh.
3315         
3316         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3317
3318         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3319         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3320         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3321         (WTR::UIScriptController::allowsViewportShrinkToFit):
3322         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3323         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3324         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3325         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3326         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3327         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3328
3329 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-app] Add model for handling multiple Buildbot instances
3332         https://bugs.webkit.org/show_bug.cgi?id=194863
3333
3334         Reviewed by Stephanie Lewis.
3335
3336         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3337
3338 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3339
3340         [ews-app] Remove BuilderMapping table
3341         https://bugs.webkit.org/show_bug.cgi?id=194961
3342
3343         Reviewed by Stephanie Lewis.
3344
3345         Store builder name directly in build table, instead of having a separate
3346         table for it.
3347
3348         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3349         * BuildSlaveSupport/ews-app/ews/models/build.py:
3350         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3351         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3352
3353 2019-02-25  John Wilander  <wilander@apple.com>
3354
3355         Introduce and adopt new class RegistrableDomain for eTLD+1
3356         https://bugs.webkit.org/show_bug.cgi?id=194791
3357         <rdar://problem/48179240>
3358
3359         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3360
3361         This patch adds an API test and replaces two instances of
3362         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3363
3364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3366         (TestWebKitAPI::TEST):
3367             Changed two strings to make sure the registrable domains are still considered
3368             invalid and pass the test.
3369         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3370         (TestWebKitAPI::TEST):
3371         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3372         (WTR::InjectedBundle::didReceiveMessageToPage):
3373
3374 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3375
3376         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3377         https://bugs.webkit.org/show_bug.cgi?id=195001
3378
3379         Reviewed by Carlos Garcia Campos.
3380
3381         API version 1.0 always includes the functionality previously guarded with
3382         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3383         unconditionally.
3384
3385         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3386         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3387         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3388         (WebViewTest::showInWindow): Ditto.
3389         (WebViewTest::hideView): Ditto.
3390         * wpe/backends/HeadlessViewBackend.cpp:
3391         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3392         * wpe/backends/ViewBackend.cpp:
3393         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3394         * wpe/backends/WindowViewBackend.cpp:
3395         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3396         WPE_BACKEND_CHECK_VERSION().
3397         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3398
3399 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3400
3401         [Flatpak] Add support for flatpak > 1.1.2
3402         https://bugs.webkit.org/show_bug.cgi?id=194088
3403
3404         Flatpak 1.2 is now out so we need to support that
3405         version now.
3406
3407         Reviewed by Michael Catanzaro.
3408
3409         * flatpak/flatpakutils.py:
3410         (check_flatpak):
3411         (FlatpakPackages.__init__):
3412         (FlatpakPackages.__detect_packages):
3413         (FlatpakPackages.__detect_packages.in):
3414         (FlatpakRepos.update):
3415
3416 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3417
3418         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3419         https://bugs.webkit.org/show_bug.cgi?id=194998
3420
3421         Reviewed by Carlos Garcia Campos.
3422
3423         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3424         to a Git checkout and using the latest commit containing various fixes
3425         and improvements.
3426
3427 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3428
3429         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3430         https://bugs.webkit.org/show_bug.cgi?id=194981
3431
3432         Reviewed by Žan Doberšek.
3433
3434         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3435         (TestWebKitAPI::TEST):
3436
3437 2019-02-23  Keith Miller  <keith_miller@apple.com>
3438
3439         Add new mac target numbers
3440         https://bugs.webkit.org/show_bug.cgi?id=194955
3441
3442         Reviewed by Tim Horton.
3443
3444         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3445         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3446         * MiniBrowser/Configurations/Base.xcconfig:
3447         * TestWebKitAPI/Configurations/Base.xcconfig:
3448         * WebKitTestRunner/Configurations/Base.xcconfig:
3449
3450 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3451
3452         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3453         https://bugs.webkit.org/show_bug.cgi?id=194846
3454
3455         Reviewed by Don Olmstead.
3456
3457         Added _search_paths() and _port_specific_expectations_files() for
3458         WinCairoPort.
3459
3460         * Scripts/webkitpy/port/win.py:
3461         (WinCairoPort.default_baseline_search_path):
3462         (WinCairoPort):
3463         (WinCairoPort._port_specific_expectations_files):
3464         (WinCairoPort._search_paths):
3465
3466 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3467
3468         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3469         https://bugs.webkit.org/show_bug.cgi?id=194963
3470
3471         Reviewed by Dean Jackson.
3472
3473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3474         Do a `contains` check instead of `equals`, because in debug builds we
3475         put the GraphicsLayer pointer in a prefix.
3476
3477 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3478
3479         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3480         https://bugs.webkit.org/show_bug.cgi?id=194873
3481         <rdar://problem/46701974>
3482
3483         Reviewed by Tim Horton.
3484
3485         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3486
3487         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3488         (WTR::UIScriptController::menuRect const):
3489         (WTR::UIScriptController::isShowingMenu const):
3490         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3491         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3492         (WTR::UIScriptController::menuRect const):
3493
3494         Add a function to query the bounds of the callout menu in content coordinates.
3495
3496         (WTR::UIScriptController::isShowingMenu const):
3497
3498         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3499
3500         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3501         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3502         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3503         (WTR::UIScriptController::rectForMenuAction const):
3504         (WTR::UIScriptController::menuRect const):
3505         (WTR::UIScriptController::isShowingMenu const):
3506         (WTR::findViewInHierarchyOfType): Deleted.
3507
3508 2019-02-22  Chris Dumez  <cdumez@apple.com>
3509
3510         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3511         https://bugs.webkit.org/show_bug.cgi?id=194954
3512         <rdar://problem/48127957>
3513
3514         Reviewed by Alex Christensen.
3515
3516         Add API test coverage.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3519         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3520         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3521         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3522
3523 2019-02-22  Chris Dumez  <cdumez@apple.com>
3524
3525         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3526         https://bugs.webkit.org/show_bug.cgi?id=194924
3527         <rdar://problem/48216125>
3528
3529         Reviewed by Geoffrey Garen.
3530
3531         Add API test coverage.
3532
3533         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3534
3535 2019-02-22  Chris Dumez  <cdumez@apple.com>
3536
3537         Unreviewed, disable API test added in r241928 on iOS.
3538
3539         The cache is not enabled on devices with less than 3GB of RAM.
3540
3541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3542
3543 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3544
3545         Hardcode Visual Viewports on everywhere except iOS WK1
3546         https://bugs.webkit.org/show_bug.cgi?id=194928
3547
3548         Reviewed by Zalan Bujtas.
3549
3550         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3551         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3552         set it to false. The setting has shipped for several years and there's no need to turn
3553         it off now.
3554
3555         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3556         Visual Viewports are not enabled.
3557         
3558         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3559         that only runs in WK2
3560
3561         * MiniBrowser/mac/SettingsController.h:
3562         * MiniBrowser/mac/SettingsController.m:
3563         (-[SettingsController init]):
3564         (-[SettingsController _populateMenu]):
3565         (-[SettingsController validateMenuItem:]):
3566         (-[SettingsController visualViewportEnabled]): Deleted.
3567         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3568         * MiniBrowser/mac/WK1BrowserWindowController.m:
3569         (-[WK1BrowserWindowController didChangeSettings]):
3570         * MiniBrowser/mac/WK2BrowserWindowController.m:
3571         (-[WK2BrowserWindowController didChangeSettings]):
3572
3573 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3574
3575         Discard cached processes when clearing website data store
3576         https://bugs.webkit.org/show_bug.cgi?id=194894
3577
3578         Reviewed by Chris Dumez.
3579
3580         Added a test case.
3581
3582         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3583         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3584
3585 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3586
3587         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3588         https://bugs.webkit.org/show_bug.cgi?id=194914
3589         <rdar://problem/47586889>
3590
3591         Reviewed by Geoffrey Garen.
3592
3593         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3594         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3595         (TEST):
3596         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3597
3598 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3599
3600         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3601         <https://webkit.org/b/194761>
3602
3603         Reviewed by Myles Maxfield.
3604
3605         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3606         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3607         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3608         to use ARC-compliant cast.
3609         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3610         ARC-compliant cast.
3611         (WTR::installFakeHelvetica): Log `error` to console if
3612         CTFontManagerRegisterFontsForURL() fails, but only on supported
3613         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3614         Call CFRelease() on `error` to fix the leak.  Update to use
3615         ARC-compliant cast.
3616         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3617         cast.
3618
3619 2019-02-21  Chris Dumez  <cdumez@apple.com>
3620
3621         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3622         https://bugs.webkit.org/show_bug.cgi?id=194481
3623
3624         Reviewed by Alex Christensen.
3625
3626         Give the processes a chance to shutdown and wait until we reached the expected number
3627         of processes.
3628
3629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3630
3631 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3632
3633         Fix the macOS build
3634
3635         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3636
3637 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3638
3639         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3640
3641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3642         I am a backwards.
3643
3644 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3645
3646         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3647
3648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3649         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3650         We could force on UI-side compositing, but I feel like the test might be more
3651         valuable exercising the normal path on each platform (though the original
3652         bug was also UI-side specific). Though we can't validate that the overlay
3653         layer was installed successfully, there are layout tests that do that.
3654
3655 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3656
3657         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3658         https://bugs.webkit.org/show_bug.cgi?id=194845
3659         <rdar://problem/47944579>
3660
3661         Reviewed by Antti Koivisto.
3662
3663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3665
3666 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3667
3668         [LFC][Floats] Add support for placing formatting roots in-between floats.
3669         https://bugs.webkit.org/show_bug.cgi?id=194902
3670
3671         Reviewed by Antti Koivisto.
3672
3673         * LayoutReloaded/misc/LFC-passing-tests.txt:
3674
3675 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3676
3677         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3678         https://bugs.webkit.org/show_bug.cgi?id=194901
3679
3680         Unreviewed build fix.
3681
3682         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3683         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3684         WPEBackend-fdo-0.1 as library name.
3685
3686 2019-02-21  Rob Buis  <rbuis@igalia.com>
3687
3688         Update MIME type parser
3689         https://bugs.webkit.org/show_bug.cgi?id=180526
3690