[CMake] Autogenerate cmakeconfig.h.cmake
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
2
3         [CMake] Autogenerate cmakeconfig.h.cmake
4         https://bugs.webkit.org/show_bug.cgi?id=143997
5
6         Reviewed by Csaba Osztrogonác.
7
8         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
9         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
10
11 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
12
13         REGRESSION(r182879): Images and video can no longer be downloaded
14         https://bugs.webkit.org/show_bug.cgi?id=144267
15         <rdar://problem/20702844>
16
17         Reviewed by Simon Fraser.
18
19         Revise tests to check for proper download menu state.
20         1. Downloading a loal image should be disabled.
21         2. Downloading a local media file should be disabled.
22         3. Downloading non-downloadable media should be disabled.
23
24         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
25         (TestWebKitAPI::TEST):
26
27 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
28
29         Merge run-launcher into run-minibrowser
30         https://bugs.webkit.org/show_bug.cgi?id=141928
31
32         Reviewed by Darin Adler.
33
34         * Scripts/run-iexploder-tests:
35         (runSafariWithIExploder):
36         * Scripts/run-launcher: Removed.
37         * Scripts/run-minibrowser:
38         * Scripts/webkitdirs.pm:
39         (launcherPath):
40         * Scripts/webkitpy/port/efl.py:
41         (EflPort.show_results_html_file):
42         * Scripts/webkitpy/port/efl_unittest.py:
43         (EflPortTest.test_show_results_html_file):
44         * Scripts/webkitpy/port/gtk.py:
45         (GtkPort.print_leaks_summary):
46         (GtkPort.show_results_html_file):
47         (GtkPort): Deleted.
48         * Scripts/webkitpy/port/gtk_unittest.py:
49         (GtkPortTest.test_show_results_html_file):
50
51 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
52
53         [buildbot] Fix the output of perf-test buildstep on timeout
54         https://bugs.webkit.org/show_bug.cgi?id=144097
55
56         Reviewed by Ryosuke Niwa.
57
58         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
59         (RunAndUploadPerfTests.getText2):
60         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
61         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
62         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
63
64 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
65
66         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
67         https://bugs.webkit.org/show_bug.cgi?id=143874
68
69         Reviewed by Gyuyoung Kim.
70
71         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
72
73 2015-04-24  Philippe Normand  <pnormand@igalia.com>
74
75         [JHBuild] Move to upstream OpenWebRTC
76         https://bugs.webkit.org/show_bug.cgi?id=144145
77
78         Reviewed by Carlos Garcia Campos.
79
80         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
81         and add a new simple patch to gst-plugins-base, required for
82         OpenWebRTC build.
83         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
84         * gtk/jhbuild.modules: Ditto.
85         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
86
87 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
88
89         [ES6] Implement ES6 template literals
90         https://bugs.webkit.org/show_bug.cgi?id=142691
91
92         Reviewed by Darin Adler.
93
94         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
95
96         * Scripts/webkitperl/FeatureList.pm:
97
98 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
99
100         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
101         https://bugs.webkit.org/show_bug.cgi?id=144217
102
103         Reviewed by Darin Adler.
104
105         * WebKitTestRunner/PlatformEfl.cmake:
106
107 2015-04-26  Doug Russell  <d_russell@apple.com>
108
109         AX: richer text change notifications (142719)
110         https://bugs.webkit.org/show_bug.cgi?id=142719
111
112         Reviewed by Darin Adler.
113
114         Richer accessibility value change notifications. Introduce AXTextEditType,
115         postTextStateChangeNotification and postTextReplacementNotification to give assistive
116         tech apps more reliable context for responding to changes in web content. Also implement
117         a mechanism to post value changes in password form fields in coalesced ticks to thwart
118         analyzing the cadence of changes.
119
120         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
121         and an overload of postTextReplacementNotification to give assistive tech apps more
122         reliable context for responding to changes in web content selection. Also block posting
123         selection changes on password fields.
124
125         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
126         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
127         (-[AccessibilityNotificationHandler stopObserving]):
128         (-[AccessibilityNotificationHandler _notificationReceived:]):
129         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
130         (AccessibilityUIElement::removeNotificationListener):
131         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
132         (-[AccessibilityNotificationHandler _notificationReceived:]):
133         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
134         (WTR::AccessibilityUIElement::removeNotificationListener):
135
136 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
137
138         Add myself to contributors.json
139         https://bugs.webkit.org/show_bug.cgi?id=144204
140
141         Reviewed by Darin Adler.
142
143         * Scripts/webkitpy/common/config/contributors.json:
144
145 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
146
147         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
148         https://bugs.webkit.org/show_bug.cgi?id=144182
149
150         Reviewed by Simon Fraser.
151
152         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
153
154 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
155
156         https://bugs.webkit.org/show_bug.cgi?id=144038
157
158         Reviewed by Ryosuke Niwa
159
160         Add a script to run Speedometer and JetStream on a browser.
161
162         * Scripts/run-benchmark: Wrapper script to run benchmark.
163         (main):
164         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
165         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
166         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
167         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
168         (BenchmarkBuilderFactory):
169         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
170         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
171         (GenericBenchmarkBuilder):
172         (GenericBenchmarkBuilder.prepare):
173         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
174         (GenericBenchmarkBuilder._applyPatch):
175         (GenericBenchmarkBuilder.clean):
176         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
177         (JetStreamBenchmarkBuilder):
178         (JetStreamBenchmarkBuilder.prepare):
179         (JetStreamBenchmarkBuilder._runCreateScript):
180         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
181         (BenchmarkRunner):
182         (BenchmarkRunner.__init__):
183         (BenchmarkRunner.execute):
184         (BenchmarkRunner.dump):
185         (BenchmarkRunner.wrap):
186         (BenchmarkRunner.merge):
187         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
188         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
189         (BrowserDriver):
190         (BrowserDriver.prepareEnv):
191         (BrowserDriver.launchUrl):
192         (BrowserDriver.closeBrowser):
193         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
194         (BrowserDriverFactory):
195         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
196         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
197         (OSXChromeDriver):
198         (OSXChromeDriver.prepareEnv):
199         (OSXChromeDriver.launchUrl):
200         (OSXChromeDriver.closeBrowsers):
201         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
202         (OSXSafariDriver):
203         (OSXSafariDriver.prepareEnv):
204         (OSXSafariDriver.launchUrl):
205         (OSXSafariDriver.closeBrowsers):
206         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
207         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
208         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
209         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
210         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
211         (GenericFactory):
212         (GenericFactory.iterateGetItem):
213         (GenericFactory.create):
214         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
215         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
216         (ServerControl):
217         (ServerControl.render_GET):
218         (ServerControl.render_POST):
219         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
220         (HTTPServerDriver):
221         (HTTPServerDriver.serve):
222         (HTTPServerDriver.fetchResult):
223         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
224         (HTTPServerDriverFactory):
225         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
226         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
227         (SimpleHTTPServerDriver):
228         (SimpleHTTPServerDriver.depends):
229         (SimpleHTTPServerDriver.__init__):
230         (SimpleHTTPServerDriver.serve):
231         (SimpleHTTPServerDriver.baseUrl):
232         (SimpleHTTPServerDriver.fetchResult):
233         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
234         (ModuleNotFoundError):
235         (loadModule):
236         (getPathFromProjectRoot):
237         (loadJSONFromFile):
238         (TimeoutError):
239         (timeout):
240         (timeout.__init__):
241         (timeout.handle_timeout):
242         (timeout.__enter__):
243         (timeout.__exit__):
244
245 2015-04-24  Commit Queue  <commit-queue@webkit.org>
246
247         Unreviewed, rolling out r183303.
248         https://bugs.webkit.org/show_bug.cgi?id=144181
249
250         Change was incorrect, broke builds (Requested by smfr on
251         #webkit).
252
253         Reverted changeset:
254
255         "Fix the build."
256         http://trac.webkit.org/changeset/183303
257
258 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
259
260         Fix the build.
261
262         * MiniBrowser/mac/WK2BrowserWindowController.m:
263         (-[WK2BrowserWindowController initWithConfiguration:]):
264
265 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
266
267         Disable ActionMenusPDFTest due to timeout on test bot
268
269         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
270         (TestWebKitAPI::TEST):
271
272 2015-04-24  Commit Queue  <commit-queue@webkit.org>
273
274         Unreviewed, rolling out r183266.
275         https://bugs.webkit.org/show_bug.cgi?id=144164
276
277         Broke 32-bit build and a test. (Requested by ap on #webkit).
278
279         Reverted changeset:
280
281         "AX: richer text change notifications (142719)"
282         https://bugs.webkit.org/show_bug.cgi?id=142719
283         http://trac.webkit.org/changeset/183266
284
285 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
286
287         REGRESSION: WebKit2.ActionMenusTest API test fails
288         https://bugs.webkit.org/show_bug.cgi?id=144149
289         <rdar://problem/20677770>
290
291         Reviewed by Tim Horton.
292
293         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
294         as the 'ActionMenusPDFTest'.
295         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
296         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
297         to match the hit test on the 'action-menu-target.pdf' test file.
298
299 2015-04-24  Daniel Bates  <dabates@apple.com>
300
301         Cleanup: Use @memoized for property IOSSimulator.testing_device
302         https://bugs.webkit.org/show_bug.cgi?id=141715
303
304         Reviewed by Darin Adler.
305
306         Simplify the caching of the result of IOSSimulator.testing_device
307         and make the code more readable by making use of the @memoized declarator
308         instead of explicitly managing a private instance variable,
309         IOSSimulator._testing_device, for the cached result.
310
311         * Scripts/webkitpy/port/ios.py:
312         (IOSPort.determine_full_port_name):
313         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
314         (IOSSimulatorPort):
315         (IOSSimulatorPort.testing_device): No need to cache the created device object in
316         IOSSimulatorPort._testing_device since we are marking this function @memoized.
317         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
318         of caching in local variable since we only make use of this value exactly once in this function.
319         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
320         been used since being added in r178622. So, we can remove this constructor since
321         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
322
323 2015-04-24  Anders Carlsson  <andersca@apple.com>
324
325         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
326         https://bugs.webkit.org/show_bug.cgi?id=144158
327
328         Reviewed by Beth Dakin.
329
330         * MiniBrowser/mac/WK2BrowserWindowController.m:
331         (-[WK2BrowserWindowController initWithConfiguration:]):
332
333 2015-04-24  Doug Russell  <d_russell@apple.com>
334
335         AX: richer text change notifications (142719)
336         https://bugs.webkit.org/show_bug.cgi?id=142719
337
338         Reviewed by Darin Adler.
339
340         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
341
342         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
343
344         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
345         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
346         (-[AccessibilityNotificationHandler stopObserving]):
347         (-[AccessibilityNotificationHandler _notificationReceived:]):
348         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
349         (AccessibilityUIElement::removeNotificationListener):
350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
351         (-[AccessibilityNotificationHandler _notificationReceived:]):
352         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
353         (WTR::AccessibilityUIElement::removeNotificationListener):
354
355 2015-04-24  Darin Adler  <darin@apple.com>
356
357         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
358         https://bugs.webkit.org/show_bug.cgi?id=128007
359
360         Reviewed by Anders Carlsson.
361
362         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
363         * DumpRenderTree/win/UIDelegate.h: Ditto.
364
365         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
366         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
367
368         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
369
370         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
371         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
372         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
373         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
374         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
375         (WebKitDOMDOMWindowTest::create): Ditto.
376         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
377         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
378         of smart pointers to DelayedSIgnal objects.
379         (uriChangedCallback): Ditto.
380
381 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
382
383         [Mac] Unreviewed test fix.
384         https://bugs.webkit.org/show_bug.cgi?id=144149
385
386         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
387         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
388         test.
389
390 2015-04-23  Darin Adler  <darin@apple.com>
391
392         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
393         https://bugs.webkit.org/show_bug.cgi?id=144090
394
395         Reviewed by Anders Carlsson.
396
397         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
398
399 2015-04-23  Michael Saboff  <msaboff@apple.com>
400
401         lldb macro btjs sometimes can't get a frame description
402         https://bugs.webkit.org/show_bug.cgi?id=144130
403
404         Reviewed by Filip Pizlo.
405
406         We look to execute ExecState::describeFrame().  It appears that in some contexts the
407         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
408         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
409
410         * lldb/lldb_webkit.py:
411         (btjs):
412
413 2015-04-23  Alex Christensen  <achristensen@webkit.org>
414
415         Use less memory when compiling content extensions.
416         https://bugs.webkit.org/show_bug.cgi?id=144051
417
418         Reviewed by Darin Adler and Benjamin Poulain.
419
420         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
421         (TestWebKitAPI::TEST_F):
422         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
423         (TestWebKitAPI::countLiveNodes):
424
425 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
426
427         [CMake] Clean up JSC JIT options
428         https://bugs.webkit.org/show_bug.cgi?id=143998
429
430         Reviewed by Filip Pizlo.
431
432         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
433         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
434
435 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
436
437         [Mac] Extend action menus to support PDF
438         https://bugs.webkit.org/show_bug.cgi?id=143895
439         <rdar://problem/19003333>
440
441         Reviewed by Tim Horton.
442
443         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
444         of PDF content works.
445
446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
447         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
448         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
449         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
450         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
451         Update to support PDF tests.
452         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
453         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
454
455 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
456
457         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
458
459         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
460         (beforeAll):
461         (testWebViewAudioOnlyUserMediaPermissionRequests):
462
463 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
464
465         Add myself to watchlist
466         https://bugs.webkit.org/show_bug.cgi?id=144041
467
468         Reviewed by Alex Christensen.
469
470         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
471
472         * Scripts/webkitpy/common/config/watchlist:
473
474 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
475
476         [GTK] MiniBrowser should use NetworkProcess by default
477         https://bugs.webkit.org/show_bug.cgi?id=143948
478
479         Reviewed by Sergio Villar Senin.
480
481         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
482         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
483
484         * MiniBrowser/gtk/main.c:
485         (main):
486
487 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
488
489         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
490
491         Unreviewed build fix.
492
493         * Scripts/prepare-ChangeLog:
494         (get_function_line_ranges_for_cpp):
495         Use grep instead of any to determine if a string is an element of an array.
496
497 2015-04-21  Anders Carlsson  <andersca@apple.com>
498
499         Fix block signatures
500         https://bugs.webkit.org/show_bug.cgi?id=144002
501
502         Reviewed by Andreas Kling.
503
504         * MiniBrowser/mac/WK2BrowserWindowController.m:
505         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
506
507 2015-04-21  Philippe Normand  <pnormand@igalia.com>
508
509         [GTK] jhbuild should not use a branch for openwebrtc
510         https://bugs.webkit.org/show_bug.cgi?id=143981
511
512         Reviewed by Carlos Garcia Campos.
513
514         * gtk/jhbuild.modules:
515
516 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
517
518         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
519
520         Unreviewed build fix.
521
522         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
523         However, it has been exposed by List::MoreUtils since its inception. This patch uses
524         the any function exposed by List::MoreUtils for greater compatibility.
525
526         * Scripts/prepare-ChangeLog:
527         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
528         the any function in all of versions of Perl used by our infrastructure.
529
530 2015-04-20  Alex Christensen  <achristensen@webkit.org>
531
532         Remove unnecessary logs when resetting tests.
533
534         * WebKitTestRunner/mac/TestControllerMac.mm:
535         (WTR::TestController::platformResetPreferencesToConsistentValues):
536         In r183020 I added some logs when compiling or removing content extensions fails.
537         We often try to remove a content extension that does not exist, and that is not a problem.
538
539 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
540
541         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
542         https://bugs.webkit.org/show_bug.cgi?id=143897
543
544         Reviewed by David Kilzer.
545
546         This is a speculative fix that addresses two issues:
547
548         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
549         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
550
551         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
552         Before: (723, 729)
553         After: (721, 720)
554
555         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
556         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
557
558         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
559         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
560
561         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
562
563         2. Creating git diffs from HEAD and not origin/master by default.
564
565         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
566         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
567
568         * Scripts/prepare-ChangeLog:
569         (originalFile):
570         Use HEAD instead of origin/master in default Git case.
571
572         (generateFunctionLists):
573         Ensure that the end line is not less than the start line.
574
575         (extractLineRangeAfterChange):
576         Set the end line to the start line if the end line is less than the start line.
577
578         (extractLineRangeBeforeChange):
579         Ditto.
580
581 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
582
583         Suppress warning in prepare-ChangeLog.
584         https://bugs.webkit.org/show_bug.cgi?id=143882
585
586         Reviewed by David Kilzer.
587
588         Prune noisy prepare-ChangeLog output by using the List::Util::any function
589         instead of the deprecated smartmatch operator.
590
591         * Scripts/prepare-ChangeLog:
592         Import the List::Util::any function.
593
594         (get_function_line_ranges_for_cpp):
595         Use the any function instead of smartmatch.
596
597 2015-04-20  Anders Carlsson  <andersca@apple.com>
598
599         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
600         https://bugs.webkit.org/show_bug.cgi?id=143966
601
602         Reviewed by Dan Bernstein.
603
604         * MiniBrowser/mac/WK2BrowserWindowController.m:
605         (dataTypes):
606         (-[WK2BrowserWindowController fetchWebsiteData:]):
607         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
608         (-[WK2BrowserWindowController clearWebsiteData:]):
609
610 2015-04-20  Alex Christensen  <achristensen@webkit.org>
611
612         Fix content extension test flakiness.
613         https://bugs.webkit.org/show_bug.cgi?id=143950
614
615         Reviewed by Brady Eidson.
616
617         * WebKitTestRunner/mac/TestControllerMac.mm:
618         (WTR::TestController::platformResetPreferencesToConsistentValues):
619         Remove the TestContentExtensions if it exists.
620         (WTR::TestController::platformConfigureViewForTest):
621         Log errors in case there are any.
622
623 2015-04-20  Alex Christensen  <achristensen@webkit.org>
624
625         Properly report errors from _WKUserContentExtensionStore.
626         https://bugs.webkit.org/show_bug.cgi?id=143808
627
628         Reviewed by Darin Adler.
629
630         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
631         (TEST_F):
632
633 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
634
635         Add a rule for NetworkCache to watchlist file
636         https://bugs.webkit.org/show_bug.cgi?id=143945
637
638         Reviewed by Sergio Villar Senin.
639
640         And add myself to the list of watchers.
641
642         * Scripts/webkitpy/common/config/watchlist:
643
644 2015-04-19  Darin Adler  <darin@apple.com>
645
646         Update RefPtr documentation and deprecation
647         https://bugs.webkit.org/show_bug.cgi?id=143936
648
649         Reviewed by Andreas Kling.
650
651         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
652
653 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
654
655         Introduce bytecode intrinsics
656         https://bugs.webkit.org/show_bug.cgi?id=143926
657
658         Reviewed by Filip Pizlo.
659
660         Change cpplint to accept emit_intrinsic_XXX.
661
662         * Scripts/webkitpy/style/checkers/cpp.py:
663         (check_identifier_name_in_declaration):
664
665 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
666
667         Fix lldb_webkit.py to show StringImpls correctly
668         https://bugs.webkit.org/show_bug.cgi?id=143920
669
670         Reviewed by Andreas Kling.
671         
672         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
673
674         * lldb/lldb_webkit.py:
675         (WTFStringImplProvider.is_8bit):
676
677 2015-04-17  Daniel Bates  <dabates@apple.com>
678
679         Not able to build WebKit against iOS Simulator 8.3 SDK
680         https://bugs.webkit.org/show_bug.cgi?id=143883
681
682         Reviewed by David Kilzer.
683
684         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
685         so that Xcode uses them.
686
687         * Scripts/copy-webkitlibraries-to-product-directory:
688
689 2015-04-17  Beth Dakin  <bdakin@apple.com>
690
691         Force mouse events should go through normal mouse event handling code paths
692         https://bugs.webkit.org/show_bug.cgi?id=143749
693         -and corresponding-
694         rdar://problem/20472895
695
696         Reviewed by Dean Jackson.
697
698         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
699         Since there is not a way to create an NSEventTypePressure from scratch, we 
700         subclass NSEvent and override all of the critical methods.
701
702         * WebKitTestRunner/EventSenderProxy.h:
703         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
704         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
705         (WTR::EventSendingController::mouseForceDown):
706         (WTR::EventSendingController::mouseForceUp):
707         (WTR::EventSendingController::mouseForceChanged):
708         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
709         * WebKitTestRunner/TestController.cpp:
710         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
711         * WebKitTestRunner/mac/EventSenderProxy.mm:
712         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
713         (-[EventSenderPressureEvent timestamp]):
714         (-[EventSenderPressureEvent type]):
715         (-[EventSenderPressureEvent locationInWindow]):
716         (-[EventSenderPressureEvent location]):
717         (-[EventSenderPressureEvent stage]):
718         (-[EventSenderPressureEvent pressure]):
719         (-[EventSenderPressureEvent phase]):
720         (-[EventSenderPressureEvent eventNumber]):
721         (WTR::EventSenderProxy::mouseForceDown):
722         (WTR::EventSenderProxy::mouseForceUp):
723         (WTR::EventSenderProxy::mouseForceChanged):
724
725 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
726
727         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
728         https://bugs.webkit.org/show_bug.cgi?id=143885
729
730         Reviewed by Tim Horton.
731
732         Fixed a case where we have two builds with the same revision(s). An in order build
733         is one for which the revision is strictly higher.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
736         (BuildbotQueue.prototype._checkForInOrderResult):
737         (BuildbotQueue.prototype.compareIterationsByRevisions):
738
739 2015-04-17  Commit Queue  <commit-queue@webkit.org>
740
741         Unreviewed, rolling out r182912 and r182920.
742         https://bugs.webkit.org/show_bug.cgi?id=143881
743
744         Build breakage in some configurations (Requested by ap on
745         #webkit).
746
747         Reverted changesets:
748
749         "Force mouse events should go through normal mouse event
750         handling code paths"
751         https://bugs.webkit.org/show_bug.cgi?id=143749
752         http://trac.webkit.org/changeset/182912
753
754         http://trac.webkit.org/changeset/182920
755
756 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
757
758         [GTK] One more unreviewed fix after r182882.
759
760         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
761
762 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
763
764         [GTK] Unreviewed speculative clean build fix after r182882.
765
766         TestWebKitAPI's forwarding header generator depended on WeKit2's
767         which generated SOUP related forwarding headers too.
768
769         This dependency isn't necessary and was removed by r182882 to make
770         forwarding header generators parallelizable. But in this case
771         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
772         should generate SOUP related forwarding headers too similar to EFL.
773
774         * TestWebKitAPI/PlatformGTK.cmake:
775         * WebKitTestRunner/PlatformGTK.cmake:
776
777 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
778
779         [SOUP] Redirect to non HTTP destination is broken
780         https://bugs.webkit.org/show_bug.cgi?id=143866
781
782         Reviewed by Sergio Villar Senin.
783
784         Add a unit test to check that redirect to a data URI works.
785
786         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
787         (testRedirectToDataURI):
788         (serverCallback):
789         (beforeAll):
790
791 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
792
793         Changes method of quitting iOS Simulator to be more correct.
794         https://bugs.webkit.org/show_bug.cgi?id=143847
795         <rdar://problem/20530344>
796
797         Reviewed by Darin Adler.
798
799         Fixes by addressing the app by ID rather than by name.
800
801         * Scripts/webkitdirs.pm:
802         (quitIOSSimulator):
803         * Scripts/webkitpy/port/ios.py:
804         (IOSSimulatorPort.check_sys_deps):
805
806 2015-04-16  Anders Carlsson  <andersca@apple.com>
807
808         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
809         https://bugs.webkit.org/show_bug.cgi?id=143844
810
811         Reviewed by Dan Bernstein.
812
813         * MiniBrowser/mac/AppDelegate.m:
814         (-[BrowserAppDelegate newPrivateWindow:]):
815         * MiniBrowser/mac/WK2BrowserWindowController.m:
816         (-[WK2BrowserWindowController initWithConfiguration:]):
817         (-[WK2BrowserWindowController fetchWebsiteData:]):
818         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
819         (-[WK2BrowserWindowController clearWebsiteData:]):
820
821 2015-04-16  Alex Christensen  <achristensen@webkit.org>
822
823         32-bit build fix.
824
825         * WebKitTestRunner/mac/TestControllerMac.mm:
826         (WTR::TestController::platformResetPreferencesToConsistentValues):
827         (WTR::TestController::platformConfigureViewForTest):
828         Added WK_API_ENABLED.
829
830 2015-04-16  Alex Christensen  <achristensen@webkit.org>
831
832         Removed unused WKUserContentFilterRef.
833         https://bugs.webkit.org/show_bug.cgi?id=143852
834
835         Reviewed by Sam Weinig.
836
837         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
838         * WebKitTestRunner/mac/TestControllerMac.mm:
839         (WTR::TestController::platformResetPreferencesToConsistentValues):
840         (WTR::TestController::platformConfigureViewForTest):
841
842 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
843
844         Unreviewed. Adding myself as a commiter in contributers.json.
845
846         * Scripts/webkitpy/common/config/contributors.json:
847
848 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
849
850         It is very hard to attach a debugger to WebProcess to debug tests
851         https://bugs.webkit.org/show_bug.cgi?id=143837
852
853         Reviewed by Chris Dumez.
854
855         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
856         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
857
858         Now it disables all timeouts in tools, as is best for debugging tests.
859
860         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
861         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
862
863         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
864         now has the same functionality.
865
866 2015-04-16  Beth Dakin  <bdakin@apple.com>
867
868         Force mouse events should go through normal mouse event handling code paths
869         https://bugs.webkit.org/show_bug.cgi?id=143749
870         -and corresponding-
871         rdar://problem/20472895
872
873         Reviewed by Dean Jackson.
874
875         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
876         Since there is not a way to create an NSEventTypePressure from scratch, we 
877         subclass NSEvent and override all of the critical methods.
878
879         * WebKitTestRunner/EventSenderProxy.h:
880         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
881         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
882         (WTR::EventSendingController::mouseForceDown):
883         (WTR::EventSendingController::mouseForceUp):
884         (WTR::EventSendingController::mouseForceChanged):
885         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
886         * WebKitTestRunner/TestController.cpp:
887         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
888         * WebKitTestRunner/mac/EventSenderProxy.mm:
889         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
890         (-[EventSenderPressureEvent timestamp]):
891         (-[EventSenderPressureEvent type]):
892         (-[EventSenderPressureEvent locationInWindow]):
893         (-[EventSenderPressureEvent location]):
894         (-[EventSenderPressureEvent stage]):
895         (-[EventSenderPressureEvent pressure]):
896         (-[EventSenderPressureEvent phase]):
897         (-[EventSenderPressureEvent eventNumber]):
898         (WTR::EventSenderProxy::mouseForceDown):
899         (WTR::EventSenderProxy::mouseForceUp):
900         (WTR::EventSenderProxy::mouseForceChanged):
901
902 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
903
904         [EFL] Bump LLVM to version 3.6.0 on X86_64
905         https://bugs.webkit.org/show_bug.cgi?id=143604
906
907         Reviewed by Gyuyoung Kim.
908
909         * efl/jhbuild.modules:
910         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
911         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
912         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
913         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
914
915 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
916
917         [EFL] Remove an unnecessary workaround from jhbuildrc
918         https://bugs.webkit.org/show_bug.cgi?id=143823
919
920         Reviewed by Gyuyoung Kim.
921
922         * efl/jhbuildrc:
923
924 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
925
926         [GTK] Run forwarding headers generator unconditionally
927         https://bugs.webkit.org/show_bug.cgi?id=143819
928
929         Reviewed by Carlos Garcia Campos.
930
931         * TestWebKitAPI/PlatformGTK.cmake:
932         * WebKitTestRunner/PlatformGTK.cmake:
933
934 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
935
936         [EFL] Add gnutls to jhbuild.module
937         https://bugs.webkit.org/show_bug.cgi?id=143777
938
939         Reviewed by Csaba Osztrogonác.
940
941         EFL port has required at least 3.0.0 version of gnutls since r176712.
942         However some old linux distributions don't support 3.0.0 version. Besides
943         other projects sometimes need to use lower version of gnutls.
944
945         This patch supports to download gnutls through jhbuild, and use it.
946
947         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
948         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
949
950 2015-04-15  Mark Lam  <mark.lam@apple.com>
951
952         Remove obsolete VMInspector debugging tool.
953         https://bugs.webkit.org/show_bug.cgi?id=143798
954
955         Reviewed by Michael Saboff.
956
957         * TestWebKitAPI/CMakeLists.txt:
958         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
959         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
961         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
962
963 2015-04-15  Jer Noble  <jer.noble@apple.com>
964
965         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
966
967         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
968
969 2015-04-15  Jer Noble  <jer.noble@apple.com>
970
971         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
972
973         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
974         (TestWebKitAPI::TEST_F):
975
976 2015-04-15  Chris Dumez  <cdumez@apple.com>
977
978         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
979         https://bugs.webkit.org/show_bug.cgi?id=143779
980
981         Reviewed by Brent Fulgham.
982
983         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
984         similarly to what is done on Mac / WK1. Without this, PageCache could
985         stay enabled after page cache tests and cause weird behaviors.
986
987         * DumpRenderTree/win/DumpRenderTree.cpp:
988         (resetWebPreferencesToConsistentValues):
989
990 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
991
992         Re-enable custom dilation for antialiased fonts
993         https://bugs.webkit.org/show_bug.cgi?id=143738
994
995         Reviewed by Tim Horton.
996         
997         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
998         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
999         a private WebKit pref. This pref defaults to YES, enabling the feature by default
1000         in WK1 as we do for WK2.
1001
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (resetWebPreferencesToConsistentValues):
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::TestController::resetPreferencesToConsistentValues):
1006
1007 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
1008
1009         Correct layering violation in DumpRenderTree Build
1010         https://bugs.webkit.org/show_bug.cgi?id=143732
1011
1012         Reviewed by Simon Fraser.
1013
1014         Correct a layering violation in DumpRenderTree by calling functions on the
1015         WebCoreTestSupport library, rather than attempting to work with WebCore
1016         types directly.
1017
1018         * DumpRenderTree/mac/EventSendingController.mm:
1019         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1020         than WebCore itself.,
1021         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1022
1023 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
1024
1025         Add a conservative DFA minimizer for the content extension matcher
1026         https://bugs.webkit.org/show_bug.cgi?id=143501
1027
1028         Reviewed by Alex Christensen.
1029
1030         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1031         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1032
1033 2015-04-14  Daniel Bates  <dabates@apple.com>
1034
1035         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1036         https://bugs.webkit.org/show_bug.cgi?id=143693
1037         <rdar://problem/20530316>
1038
1039         Reviewed by Tim Horton.
1040
1041         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1042         to use the fixed layout code on iOS at this time.
1043
1044         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1045
1046 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1047
1048         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1049         https://bugs.webkit.org/show_bug.cgi?id=143705
1050
1051         Unreviewed change to watchlist file.
1052
1053         * Scripts/webkitpy/common/config/watchlist:
1054
1055 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
1056
1057         [EFL] favicon wasn't updated for google.com sometimes.
1058         https://bugs.webkit.org/show_bug.cgi?id=141940
1059
1060         Reviewed by Gyuyoung Kim.
1061
1062         As elm_entry_utf8_to_markup can include additional characters, parameter for the
1063         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1064
1065         * MiniBrowser/efl/main.c:
1066         (on_url_changed):
1067
1068 2015-04-13  Tim Horton  <timothy_horton@apple.com>
1069
1070         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1071         https://bugs.webkit.org/show_bug.cgi?id=143560
1072         <rdar://problem/16302047>
1073
1074         Reviewed by Darin Adler.
1075
1076         * MiniBrowser/mac/BrowserWindowController.h:
1077         * MiniBrowser/mac/MainMenu.xib:
1078         * MiniBrowser/mac/WK1BrowserWindowController.m:
1079         (-[WK1BrowserWindowController setScale:]):
1080         * MiniBrowser/mac/WK2BrowserWindowController.m:
1081         (viewScaleForMenuItemTag):
1082         (-[WK2BrowserWindowController setScale:]):
1083         (-[WK2BrowserWindowController validateMenuItem:]):
1084         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1085         When in use, we resize the window so that the view fits correctly, and
1086         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
1087         layout size will not change when scaling down (but will update appropriately
1088         when the view is resized).
1089
1090 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1091
1092         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
1093         https://bugs.webkit.org/show_bug.cgi?id=138630
1094
1095         Reviewed by Tim Horton.
1096
1097         Make sure that we always load at least one in order productive iteration.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1100         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1101         is done loading at least one iteration that wasn't an out of order build.
1102         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1103         when that's needed to check for out of order builds.
1104         (BuildbotQueue.prototype.update): Ditto.
1105         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1106         result, and if it does not, load more iterations.
1107         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1108         an in order iteration loaded too.
1109         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1110         corrected to always sort loaded iterations before unloaded ones.
1111
1112 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
1113
1114         Expand test infrastructure to support scrolling tests
1115         https://bugs.webkit.org/show_bug.cgi?id=143286
1116         <rdar://problem/20375516>
1117
1118         Reviewed by Simon Fraser.
1119
1120         Extend the WK1 and WK2 test programs to support two new EventSender commands:
1121         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1122         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1123         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1124         relevant rubberband, scroll, and scroll-snap animations are finished.
1125
1126         * DumpRenderTree/mac/EventSendingController.mm:
1127         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1128         and 'monitorWheelEvents'.
1129         (+[EventSendingController webScriptNameForSelector:]): Ditto.
1130         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1131         debugging test failures.
1132         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1133         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1134         function, then passes it to WebCore to be called once the test deferrals have been cleared.
1135         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1136         'callAfterScrollingCompletes' method.
1137         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1138         and 'monitorWheelEvents'.
1139         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1140         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1141         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1142         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1143         'callAfterScrollingComplates' method.
1144         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1145
1146 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1147
1148         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1149         https://bugs.webkit.org/show_bug.cgi?id=143656
1150
1151         Reviewed by Darin Adler.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1154         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1155
1156 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
1157
1158         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1159         https://bugs.webkit.org/show_bug.cgi?id=142387
1160
1161         Reviewed by Carlos Garcia Campos.
1162
1163         Running mixed content is blocked by default since r181134. Updated
1164         the test case to reflect the new default settings.
1165
1166         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1167         (testInsecureContent):
1168
1169 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1170
1171         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1172         https://bugs.webkit.org/show_bug.cgi?id=143667
1173
1174         Reviewed by Csaba Osztrogonác.
1175
1176         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1177         since r169017. Added $hardwareConcurrencySupport for it.
1178
1179         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1180
1181         * Scripts/webkitperl/FeatureList.pm:
1182
1183 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
1184
1185         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1186         https://bugs.webkit.org/show_bug.cgi?id=143664
1187
1188         Reviewed by Gyuyoung Kim.
1189
1190         * Scripts/webkitperl/FeatureList.pm:
1191
1192 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1193
1194         [EFL] Enable Media Source
1195         https://bugs.webkit.org/show_bug.cgi?id=143635
1196
1197         Reviewed by Csaba Osztrogonác.
1198
1199         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1200
1201 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
1202
1203         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1204         https://bugs.webkit.org/show_bug.cgi?id=143646
1205
1206         Reviewed by David Kilzer.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1209         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1210
1211 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
1212
1213         Use en_US spell checker for tests on Mac instead of Multilingual
1214         https://bugs.webkit.org/show_bug.cgi?id=143641
1215
1216         Reviewed by Dan Bernstein.
1217
1218         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1219         While at it, override NSUserDictionaryReplacementItems, so that user replacements
1220         cannot affect tests.
1221
1222         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1223         Made this more like WebKit1 version.
1224
1225 2015-04-10  Tim Horton  <timothy_horton@apple.com>
1226
1227         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1228         https://bugs.webkit.org/show_bug.cgi?id=143576
1229
1230         Reviewed by Simon Fraser.
1231
1232         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1233         (TEST):
1234         Adopt.
1235
1236 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1237
1238         Update my email address and expertise.
1239         https://bugs.webkit.org/show_bug.cgi?id=143586
1240
1241         Unreviewed, just update my info.
1242
1243         * Scripts/webkitpy/common/config/contributors.json:
1244
1245 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
1246
1247         Flakiness Dashboard not loading insecure content if loaded with https URL
1248         https://bugs.webkit.org/show_bug.cgi?id=143570
1249
1250         Reviewed by Alexey Proskuryakov.
1251
1252         * TestResultServer/app.yaml:
1253         * TestResultServer/static-dashboards/loader.js:
1254         Switch to https scheme.
1255
1256 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
1257
1258         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1259         https://bugs.webkit.org/show_bug.cgi?id=142907
1260
1261         Reviewed by Carlos Garcia Campos.
1262
1263         * TestWebKitAPI/PlatformEfl.cmake:
1264         * TestWebKitAPI/PlatformGTK.cmake:
1265         * WebKitTestRunner/PlatformEfl.cmake:
1266         * WebKitTestRunner/PlatformGTK.cmake:
1267
1268 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1269
1270         [Mac] Unreviewed test fix after r182584
1271         https://bugs.webkit.org/show_bug.cgi?id=143452
1272
1273         Put both of these tests back to their original state now that the underlying
1274         problem is fixed.
1275
1276         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1277         (TestWebKitAPI::TEST):
1278         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1279         (TestWebKitAPI::TEST):
1280
1281 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
1282
1283         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1284         https://bugs.webkit.org/show_bug.cgi?id=143553
1285
1286         Reviewed by Ryosuke Niwa.
1287         
1288         Remove the spurious printVMs left over from an earlier change.
1289
1290         * Scripts/run-jsc-benchmarks:
1291
1292 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1293
1294         [Mac] Unreviewed test fix after r182581
1295
1296         The behavior of control-left-click is controlled by a system preference.
1297         Our test bots have this turned off.
1298
1299         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1300         (TestWebKitAPI::TEST):
1301         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1302         (TestWebKitAPI::TEST):
1303
1304 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1305
1306         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1307         https://bugs.webkit.org/show_bug.cgi?id=143452
1308         <rdar://problem/20437483>
1309
1310         Reviewed by Tim Horton.
1311
1312         Add a new API test to confirm that Cocoa mouse button press events are properly
1313         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1314
1315         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1316         some registered event handlers that the expected button press and context menu
1317         events are received.
1318
1319         The WK1 unit test creates an NSEvent with the desired button press state, and then
1320         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1321         We check the resulting PlatformMouseEvent for proper state.
1322
1323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1324         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1325         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1326         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1327         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1328         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1329         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1330         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1331         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1332         mouse down events.
1333         * TestWebKitAPI/mac/PlatformWebViewMac.h:
1334
1335 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1336
1337         [GTK] Add pango to jhbuild-optional.modules
1338         https://bugs.webkit.org/show_bug.cgi?id=143537
1339
1340         Reviewed by Martin Robinson.
1341
1342         * gtk/jhbuild-optional.modules: Add pango.
1343
1344 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1345
1346         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1347         https://bugs.webkit.org/show_bug.cgi?id=143530
1348
1349         Reviewed by Žan Doberšek.
1350
1351         Assume that the default value for display (:0) is reserved and start checking on :1
1352         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1353         and for X server named Xorg.bin (previous bug 1376599)
1354
1355         * Scripts/webkitpy/port/xvfbdriver.py:
1356         (XvfbDriver._next_free_display)
1357         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1358         (XvfbDriverTest.test_start_no_pixel_tests):
1359         (XvfbDriverTest.test_start_pixel_tests):
1360         (XvfbDriverTest.test_start_arbitrary_worker_number):
1361         (XvfbDriverTest.test_next_free_display):
1362         (XvfbDriverTest.test_start_next_worker):
1363 2015-04-08  Alex Christensen  <achristensen@webkit.org>
1364
1365         Block popups from content extensions.
1366         https://bugs.webkit.org/show_bug.cgi?id=143497
1367
1368         Reviewed by Brady Eidson.
1369
1370         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1371         (TestWebKitAPI::TEST_F):
1372         Added popup test.
1373
1374 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
1375
1376         Add CMake build system for WinCairo port.
1377         https://bugs.webkit.org/show_bug.cgi?id=115944
1378
1379         Reviewed by Chris Dumez.
1380
1381         * CMakeLists.txt:
1382         * WinLauncher/CMakeLists.txt: Added.
1383
1384 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
1387         https://bugs.webkit.org/show_bug.cgi?id=143521
1388
1389         Reviewed by Martin Robinson.
1390
1391         Add a way to detect unexpected web process crashes to WebViewTest,
1392         and a test case to testDOMCache to trigger the crash.
1393
1394         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1395         (WebKitDOMNodeTest::testDOMCache):
1396         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1397         (testWebKitWebViewProcessCrashed):
1398         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1399         (WebViewTest::WebViewTest):
1400         (WebViewTest::webProcessCrashed):
1401         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1402
1403 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
1404
1405         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
1406         rdar://problem/20461342
1407
1408         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1409
1410 2015-04-07  Commit Queue  <commit-queue@webkit.org>
1411
1412         Unreviewed, rolling out r182511.
1413         https://bugs.webkit.org/show_bug.cgi?id=143507
1414
1415         caused debug test failures (Requested by alexchristensen on
1416         #webkit).
1417
1418         Reverted changeset:
1419
1420         "Block popups from content extensions."
1421         https://bugs.webkit.org/show_bug.cgi?id=143497
1422         http://trac.webkit.org/changeset/182511
1423
1424 2015-04-07  Alex Christensen  <achristensen@webkit.org>
1425
1426         Block popups from content extensions.
1427         https://bugs.webkit.org/show_bug.cgi?id=143497
1428
1429         Reviewed by Brady Eidson.
1430
1431         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1432         (TestWebKitAPI::TEST_F):
1433         Added popup test.
1434
1435 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
1436
1437         Get the features.json files ready for open contributions
1438         https://bugs.webkit.org/show_bug.cgi?id=143436
1439
1440         Reviewed by Darin Adler.
1441
1442         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1443         (JSONFeaturesChecker.check):
1444         Extend the syntax checking a bit, but leave everything non-mandatory
1445         very loose until we figure what fields are important.
1446
1447 2015-04-07  Tim Horton  <timothy_horton@apple.com>
1448
1449         Expose and test fixedLayoutSize via modern WebKit SPI
1450         https://bugs.webkit.org/show_bug.cgi?id=143500
1451
1452         Reviewed by Simon Fraser.
1453
1454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1455         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
1456         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
1457         (TEST):
1458         Add a test that verifies that fixedLayoutSize works at all, that
1459         it persists through a navigation, and that turning it back off reverts to
1460         laying out at the size of the view.
1461
1462 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1463
1464         Unreviewed. Add myself as a committer.
1465
1466         * Scripts/webkitpy/common/config/contributors.json:
1467
1468 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
1469
1470         [Win] Bots complain about missing /etc/catalog
1471         https://bugs.webkit.org/show_bug.cgi?id=143484
1472
1473         Reviewed by Chris Dumez.
1474
1475         The libxml2 build on Mac, iOS, and Windows does not provide the set
1476         of default catalog files. We do not actually need these for our
1477         purposes, but we get warnings and some bot flakiness because they
1478         are not present.
1479
1480         We can avoid both problems the same way the Mac and iOS ports do,
1481         by setting the XML_CATALOG_FILES environment variable to 'empty string',
1482         which avoid the warnings and bot problems.
1483
1484         * Scripts/webkitpy/port/win.py:
1485         (WinPort.setup_environ_for_server): Added.
1486
1487 2015-04-06  Sam Weinig  <sam@webkit.org>
1488
1489         Use content extensions in MiniBrowser.
1490         https://bugs.webkit.org/show_bug.cgi?id=143446
1491
1492         Reviewed by Alex Christensen.
1493
1494         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1495         * MiniBrowser/mac/AppDelegate.h:
1496         * MiniBrowser/mac/AppDelegate.m:
1497         (-[BrowserAppDelegate init]):
1498         (-[BrowserAppDelegate showExtensionsManager:]):
1499         (-[BrowserAppDelegate userContentContoller]):
1500         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1501         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1502         (-[ExtensionManagerWindowController init]):
1503         (-[ExtensionManagerWindowController windowDidLoad]):
1504         (-[ExtensionManagerWindowController add:]):
1505         (-[ExtensionManagerWindowController remove:]):
1506         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1507         * MiniBrowser/mac/MainMenu.xib:
1508
1509 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1510
1511         web-platform-tests server should retrieve the modules file relatively to its docroot path
1512         https://bugs.webkit.org/show_bug.cgi?id=142742
1513
1514         Reviewed by Darin Adler.
1515
1516         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1517         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1518
1519 2015-04-06  Commit Queue  <commit-queue@webkit.org>
1520
1521         Unreviewed, rolling out r182445.
1522         https://bugs.webkit.org/show_bug.cgi?id=143459
1523
1524         broke 32 bit build (Requested by alexchristensen on #webkit).
1525
1526         Reverted changeset:
1527
1528         "Use content extensions in MiniBrowser."
1529         https://bugs.webkit.org/show_bug.cgi?id=143446
1530         http://trac.webkit.org/changeset/182445
1531
1532 2015-04-06  Sam Weinig  <sam@webkit.org>
1533
1534         Use content extensions in MiniBrowser.
1535         https://bugs.webkit.org/show_bug.cgi?id=143446
1536
1537         Reviewed by Alex Christensen.
1538
1539         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1540         * MiniBrowser/mac/AppDelegate.h:
1541         * MiniBrowser/mac/AppDelegate.m:
1542         (-[BrowserAppDelegate init]):
1543         (-[BrowserAppDelegate showExtensionsManager:]):
1544         (-[BrowserAppDelegate userContentContoller]):
1545         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1546         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1547         (-[ExtensionManagerWindowController init]):
1548         (-[ExtensionManagerWindowController windowDidLoad]):
1549         (-[ExtensionManagerWindowController add:]):
1550         (-[ExtensionManagerWindowController remove:]):
1551         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1552         * MiniBrowser/mac/MainMenu.xib:
1553
1554 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1555
1556         [GTK] install-dependencies should prefer dnf to yum
1557         https://bugs.webkit.org/show_bug.cgi?id=143441
1558
1559         Reviewed by Martin Robinson.
1560
1561         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1562
1563         * gtk/install-dependencies:
1564
1565 2015-04-06  Andy Estes  <aestes@apple.com>
1566
1567         [iOS] 'make clean' fails in Tools/WebKitTestRunner
1568         https://bugs.webkit.org/show_bug.cgi?id=143455
1569
1570         Reviewed by Dan Bernstein.
1571
1572         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1573         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
1574
1575         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
1576
1577 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
1578
1579         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
1580         https://bugs.webkit.org/show_bug.cgi?id=143450
1581
1582         Reviewed by Anders Carlsson.
1583
1584         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
1585         Make sure that the view is actually closed, regardless of anything else that happens beneath.
1586         Also, removed unnecessary get() calls.
1587
1588 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
1589
1590         Reduce the dependency on Flash in regression tests
1591         https://bugs.webkit.org/show_bug.cgi?id=143391
1592
1593         Reviewed by Anders Carlsson.
1594
1595         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
1596         Only allow QuickTime and the test plug-in.
1597
1598 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1599
1600         W3C test importer should generate the modules installed dynamically to run wpt tests
1601         https://bugs.webkit.org/show_bug.cgi?id=142738
1602
1603         Reviewed by Ryosuke Niwa.
1604
1605         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
1606         The implementation is done within TestDownloader and it is activated for the WPT repository.
1607         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
1608
1609         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1610         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
1611         * Scripts/webkitpy/w3c/test_downloader.py:
1612         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
1613         (TestDownloader):
1614         (TestDownloader._git_submodules_description): Computes submodule description.
1615         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
1616         * Scripts/webkitpy/w3c/test_importer.py:
1617         (TestImporter.do_import): Added the possibility to post process the tests.
1618         (TestImporter):
1619         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
1620         (TestImporter.should_convert_test_harness_links): Updated according new options format.
1621         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1622         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
1623         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
1624         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
1625         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
1626         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
1627
1628 2015-04-05  Antti Koivisto  <antti@apple.com>
1629
1630         Bloom filter should support longer hashes
1631         https://bugs.webkit.org/show_bug.cgi?id=143419
1632
1633         Reviewed by Dan Bernstein.
1634
1635         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
1636         (TestWebKitAPI::generateRandomDigests):
1637         (TestWebKitAPI::TEST):
1638
1639 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1640
1641         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
1642         https://bugs.webkit.org/show_bug.cgi?id=143372
1643
1644         Reviewed by Darin Adler.
1645
1646         * Scripts/run-jsc-stress-tests:
1647
1648 2015-04-03  Antti Koivisto  <antti@apple.com>
1649
1650         Add non-counting bloom filter class
1651         https://bugs.webkit.org/show_bug.cgi?id=143366
1652
1653         Reviewed by Sam Weinig.
1654
1655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1656         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
1657         (TestWebKitAPI::generateRandomHashes):
1658         (TestWebKitAPI::TEST):
1659
1660 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1661
1662         FTL JIT tests should fail if LLVM library isn't available
1663         https://bugs.webkit.org/show_bug.cgi?id=143374
1664
1665         Reviewed by Mark Lam.
1666
1667         * Scripts/run-jsc-stress-tests:
1668
1669 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1670
1671         [EFL] Speedup jhbuild with disable running autogen.sh
1672         https://bugs.webkit.org/show_bug.cgi?id=143369
1673
1674         Reviewed by Gyuyoung Kim.
1675
1676         * efl/jhbuild.modules:
1677
1678 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1679
1680         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
1681         https://bugs.webkit.org/show_bug.cgi?id=143282
1682
1683         Reviewed by Daniel Bates.
1684
1685         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
1686
1687 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1688
1689         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
1690         https://bugs.webkit.org/show_bug.cgi?id=143240
1691         rdar://problem/19990425
1692
1693         Reviewed by Tim Horton.
1694
1695         * DumpRenderTree/mac/LayoutTestHelper.m:
1696         (colorProfileURLForDisplay):
1697         (saveDisplayColorProfiles):
1698         Gracefully handle it when the current profile cannot be retrieved, fixing at
1699         least one case when LayoutTestHelper couldn't start.
1700
1701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1702         (Manager._set_up_run):
1703         (Manager._force_pixel_tests_if_needed):
1704         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
1705         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
1706         Return and check an error from start_helper().
1707
1708 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
1709
1710         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
1711         https://bugs.webkit.org/show_bug.cgi?id=143321
1712
1713         Reviewed by Alexey Proskuryakov.
1714
1715         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
1716
1717 2015-04-01  Enrica Casucci  <enrica@apple.com>
1718
1719         Injected bundle messages should be at the page level.
1720         https://bugs.webkit.org/show_bug.cgi?id=143283
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         Updating WebKitTestRunner to use the new page level messaging.
1725         The author of this patch is Tim Horton, I just finished it.
1726
1727         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1728         (WTR::EventSendingController::mouseDown):
1729         (WTR::EventSendingController::mouseUp):
1730         (WTR::EventSendingController::mouseMoveTo):
1731         (WTR::EventSendingController::leapForward):
1732         (WTR::EventSendingController::scheduleAsynchronousClick):
1733         (WTR::EventSendingController::keyDown):
1734         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1735         (WTR::EventSendingController::mouseScrollBy):
1736         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1737         (WTR::EventSendingController::continuousMouseScrollBy):
1738         (WTR::EventSendingController::addTouchPoint):
1739         (WTR::EventSendingController::updateTouchPoint):
1740         (WTR::EventSendingController::setTouchModifier):
1741         (WTR::EventSendingController::setTouchPointRadius):
1742         (WTR::EventSendingController::touchStart):
1743         (WTR::EventSendingController::touchMove):
1744         (WTR::EventSendingController::touchEnd):
1745         (WTR::EventSendingController::touchCancel):
1746         (WTR::EventSendingController::clearTouchPoints):
1747         (WTR::EventSendingController::releaseTouchPoint):
1748         (WTR::EventSendingController::cancelTouchPoint):
1749         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1750         (WTR::InjectedBundle::didReceiveMessage):
1751         (WTR::InjectedBundle::didReceiveMessageToPage):
1752         (WTR::InjectedBundle::done):
1753         (WTR::InjectedBundle::outputText):
1754         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1755         (WTR::InjectedBundle::postAddChromeInputField):
1756         (WTR::InjectedBundle::postRemoveChromeInputField):
1757         (WTR::InjectedBundle::postFocusWebView):
1758         (WTR::InjectedBundle::postSetBackingScaleFactor):
1759         (WTR::InjectedBundle::postSetWindowIsKey):
1760         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1761         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1762         (WTR::InjectedBundle::setGeolocationPermission):
1763         (WTR::InjectedBundle::setMockGeolocationPosition):
1764         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1765         (WTR::InjectedBundle::setUserMediaPermission):
1766         (WTR::InjectedBundle::setCustomPolicyDelegate):
1767         (WTR::InjectedBundle::setHidden):
1768         (WTR::InjectedBundle::setCacheModel):
1769         (WTR::InjectedBundle::shouldProcessWorkQueue):
1770         (WTR::InjectedBundle::processWorkQueue):
1771         (WTR::InjectedBundle::queueBackNavigation):
1772         (WTR::InjectedBundle::queueForwardNavigation):
1773         (WTR::InjectedBundle::queueLoad):
1774         (WTR::InjectedBundle::queueLoadHTMLString):
1775         (WTR::InjectedBundle::queueReload):
1776         (WTR::InjectedBundle::queueLoadingScript):
1777         (WTR::InjectedBundle::queueNonLoadingScript):
1778         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1779         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1780         (WTR::TestRunner::setAuthenticationUsername):
1781         (WTR::TestRunner::setAuthenticationPassword):
1782         (WTR::TestRunner::secureEventInputIsEnabled):
1783         (WTR::TestRunner::setBlockAllPlugins):
1784         * WebKitTestRunner/TestController.cpp:
1785         (WTR::TestController::createWebViewWithOptions):
1786         (WTR::TestController::resetStateToConsistentValues):
1787         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
1788         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
1789         * WebKitTestRunner/TestController.h:
1790         * WebKitTestRunner/TestInvocation.cpp:
1791         (WTR::TestInvocation::invoke):
1792         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1793
1794 2015-04-01  Commit Queue  <commit-queue@webkit.org>
1795
1796         Unreviewed, rolling out r182174 and r182177.
1797         https://bugs.webkit.org/show_bug.cgi?id=143314
1798
1799         Try to correct EWS failures (Requested by bfulgham on
1800         #webkit).
1801
1802         Reverted changesets:
1803
1804         "Python SCM should be able to retrieve untracked files"
1805         https://bugs.webkit.org/show_bug.cgi?id=143135
1806         http://trac.webkit.org/changeset/182174
1807
1808         "[buildbot] clean-build script should remove untracked files
1809         and revert local changes too"
1810         https://bugs.webkit.org/show_bug.cgi?id=142400
1811         http://trac.webkit.org/changeset/182177
1812
1813 2015-04-01  Alex Christensen  <achristensen@webkit.org>
1814
1815         [Content Extensions] Properly handle regexes that match everything.
1816         https://bugs.webkit.org/show_bug.cgi?id=143281
1817
1818         Reviewed by Benjamin Poulain.
1819
1820         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1821         (TestWebKitAPI::testRequest):
1822         (TestWebKitAPI::makeBackend):
1823         (TestWebKitAPI::TEST_F):
1824         Removed duplicate code and added test.
1825
1826 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
1827
1828         Content Extensions: split the state machines to minimize prefix states
1829         https://bugs.webkit.org/show_bug.cgi?id=143253
1830
1831         Reviewed by Alex Christensen.
1832
1833         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1834         (TestWebKitAPI::TEST_F):
1835         (TestWebKitAPI::testPatternStatus):
1836
1837 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1838
1839         Clean up Identifier factories to clarify the meaning of StringImpl*
1840         https://bugs.webkit.org/show_bug.cgi?id=143146
1841
1842         Reviewed by Filip Pizlo.
1843
1844         Simple API tests for StringImpl are added.
1845
1846         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1847         (TestWebKitAPI::TEST):
1848
1849 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
1850
1851         [EFL] Add AArch64 builder and tester bot to build.webkit.org
1852         https://bugs.webkit.org/show_bug.cgi?id=143092
1853
1854         Reviewed by Gyuyoung Kim.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/config.json:
1857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1858         (Factory.__init__):
1859         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1860
1861 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1862
1863         [buildbot] clean-build script should remove untracked files and revert local changes too
1864         https://bugs.webkit.org/show_bug.cgi?id=142400
1865
1866         Reviewed by Ryosuke Niwa.
1867
1868         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1869         A helper routine SCM.discard_untracked_files is added for that purpose.
1870
1871         * BuildSlaveSupport/clean-build:
1872         (main): Making call to Scripts/clean-webkit
1873         * Scripts/clean-webkit: Added.
1874         (main): Revert changes and delete untracked files.
1875         * Scripts/webkitpy/common/checkout/scm/scm.py:
1876         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1877         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1878         (SCMTest._shared_test_discard_untracked_files):
1879         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1880
1881 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1882
1883         Python SCM should be able to retrieve untracked files
1884         https://bugs.webkit.org/show_bug.cgi?id=143135
1885
1886         Reviewed by Ryosuke Niwa.
1887
1888         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1889         Ignored files may be included or not in this list according boolean passed to the function.
1890
1891         * Scripts/webkitpy/common/checkout/scm/git.py:
1892         (Git.untracked_files):
1893         * Scripts/webkitpy/common/checkout/scm/scm.py:
1894         (SCM.untracked_files):
1895         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1896         (SCMTest._shared_test_untracked_files):
1897         (test_untracked_files):
1898         (GitSVNTest.test_untracked_files):
1899         * Scripts/webkitpy/common/checkout/scm/svn.py:
1900         (SVN.untracked_files):
1901
1902 2015-03-30  Alex Christensen  <achristensen@webkit.org>
1903
1904         [Content Extensions] Correctly handle regular expressions matching everything
1905         https://bugs.webkit.org/show_bug.cgi?id=143235
1906
1907         Reviewed by Benjamin Poulain.
1908
1909         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1910         (TestWebKitAPI::checkCompilerError):
1911         (TestWebKitAPI::TEST_F):
1912         Test ContentExtensionErrors.
1913
1914 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
1915
1916         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1917         https://bugs.webkit.org/show_bug.cgi?id=143241
1918         rdar://problem/20351297
1919
1920         Reviewed by Mark Lam.
1921
1922         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1923
1924 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1925
1926         [CMake][EFL] Remove redundant library link and include path
1927         https://bugs.webkit.org/show_bug.cgi?id=143221
1928
1929         Reviewed by Csaba Osztrogonác.
1930
1931         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1932
1933 2015-03-30  Sam Weinig  <sam@webkit.org>
1934
1935         [Content Extensions] Flesh out the UserContentExtensionStore
1936         https://bugs.webkit.org/show_bug.cgi?id=143123
1937
1938         Reviewed by Benjamin Poulain.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1942         Add tests for _WKUserContentExtensionStore.
1943
1944 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1945
1946         Update install-dependencies Fedora packages after r181624
1947         https://bugs.webkit.org/show_bug.cgi?id=143215
1948
1949         Add json-glib, libv4l, openssl and pulseaudio development packages to
1950         the Fedora list providing we need them to build WebKit dependencies
1951         for this distribution.
1952
1953         Reviewed by Philippe Normand.
1954
1955         * gtk/install-dependencies:
1956
1957 2015-03-30  Commit Queue  <commit-queue@webkit.org>
1958
1959         Unreviewed, rolling out r182119.
1960         https://bugs.webkit.org/show_bug.cgi?id=143196
1961
1962         problem with syntax (Requested by youenn on #webkit).
1963
1964         Reverted changeset:
1965
1966         "[buildbot] clean-build script should remove untracked files
1967         and revert local changes too"
1968         https://bugs.webkit.org/show_bug.cgi?id=142400
1969         http://trac.webkit.org/changeset/182119
1970
1971 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
1972
1973         Start the features.json files
1974         https://bugs.webkit.org/show_bug.cgi?id=143207
1975
1976         Reviewed by Darin Adler.
1977
1978         I kept the style checking light. We'll have to figure
1979         what is the best format for each field.
1980
1981         * Scripts/webkitpy/style/checker.py:
1982         (CheckerDispatcher._create_checker):
1983         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1984         (JSONContributorsChecker.check):
1985         (JSONFeaturesChecker):
1986         (JSONFeaturesChecker.check):
1987
1988 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1989
1990         [buildbot] clean-build script should remove untracked files and revert local changes too
1991         https://bugs.webkit.org/show_bug.cgi?id=142400
1992
1993         Reviewed by Ryosuke Niwa.
1994
1995         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1996
1997         * BuildSlaveSupport/clean-build:
1998         (main): Adding call to Tools/Scripts/clean-webkit.
1999         * Scripts/clean-webkit: Added.
2000         (main): Removes untracked and changed files.
2001         * Scripts/webkitpy/common/checkout/scm/git.py:
2002         (Git.untracked_files): Retrieves GIT untracked files.
2003         * Scripts/webkitpy/common/checkout/scm/scm.py:
2004         (SCM.untracked_files): Retrieves SVN untracked files.
2005         (SCM):
2006         (SCM.discard_untracked_files): Deletes untracked files/folders.
2007         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2008         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2009         (test_untracked_files):
2010         (GitSVNTest.test_untracked_files):
2011         * Scripts/webkitpy/common/checkout/scm/svn.py:
2012         (SVN.untracked_files):
2013
2014 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2015
2016         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
2017         https://bugs.webkit.org/show_bug.cgi?id=143138
2018
2019         Reviewed by Csaba Osztrogonác.
2020
2021         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2022         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2023
2024         * ImageDiff/CMakeLists.txt:
2025         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2026         * WebKitTestRunner/CMakeLists.txt: ditto.
2027
2028 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
2029
2030         Support building WTF on Windows without Cygwin
2031         https://bugs.webkit.org/show_bug.cgi?id=143084
2032
2033         Reviewed by Brent Fulgham.
2034
2035         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2036         This patch also migrates to using File::Spec->catfile() for directory separators.
2037
2038         * Scripts/update-webkit-dependency:
2039         (wanted):
2040         * Scripts/update-webkit-support-libs:
2041         (wanted):
2042         (downloadExpectedVersionNumber):
2043         (zipFileVersion):
2044         (toUnixPath): Deleted.
2045         * Scripts/webkitdirs.pm:
2046         (determineSourceDir):
2047         (windowsSourceSourceDir):
2048         (windowsLibrariesDir):
2049         (windowsOutputDir):
2050         (checkInstalledTools):
2051         (buildVisualStudioProject):
2052
2053 2015-03-27  Alex Christensen  <achristensen@webkit.org>
2054
2055         Fix WinCairo bot.
2056         https://bugs.webkit.org/show_bug.cgi?id=143086
2057
2058         Reviewed by Brent Fulgham.
2059
2060         * Scripts/webkitdirs.pm:
2061         (buildVisualStudioProject):
2062         (runSvnUpdateAndResolveChangeLogs):
2063         Use ActivePerl-friendly perl.
2064
2065 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2066
2067         URTBF after r182059 to fix the EFL build.
2068
2069         * TestWebKitAPI/CMakeLists.txt:
2070
2071 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
2072
2073         Layout test results URL loads in WK1 but not WK2 minibrowser
2074         https://bugs.webkit.org/show_bug.cgi?id=143117
2075
2076         Reviewed by Tim Horton.
2077
2078         * MiniBrowser/mac/WK2BrowserWindowController.m:
2079         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2080         everything.
2081         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2082
2083 2015-03-26  Jer Noble  <jer.noble@apple.com>
2084
2085         Add --allowed-host support to run-webkit-tests
2086         https://bugs.webkit.org/show_bug.cgi?id=142938
2087
2088         Reviewed by Brent Fulgham.
2089
2090         Accept --allowed-host arguments from run-webkit-tests and pass them through to
2091         DumpRenderTree and WebKitTestRunner.
2092
2093         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
2094         are placed in the wrong location. The argument is compared with each tests's path, and if a
2095         relative path or a path with '..' was used, results are placed alongside the test. Take the
2096         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2097
2098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2099         (parse_args):
2100         * Scripts/webkitpy/port/base.py:
2101         (Port.__init__):
2102         (Port.allowed_hosts):
2103         * Scripts/webkitpy/port/driver.py:
2104         (Driver.cmd_line):
2105
2106 2015-03-26  Jer Noble  <jer.noble@apple.com>
2107
2108         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2109         https://bugs.webkit.org/show_bug.cgi?id=142931
2110
2111         Reviewed by Brent Fulgham.
2112
2113         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2114         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2115         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2116         runtime.
2117
2118         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2119         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2120
2121         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2122         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2123         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2124         the top loading frame from the page, as we do elsewhere in this class.
2125
2126         * DumpRenderTree/TestRunner.h:
2127         (TestRunner::allowedHosts):
2128         (TestRunner::setAllowedHosts):
2129         * DumpRenderTree/mac/DumpRenderTree.mm:
2130         (initializeGlobalsFromCommandLineOptions):
2131         (runTest):
2132         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2133         (isAllowedHost):
2134         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2135         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2136         (WTR::InjectedBundle::didReceiveMessage):
2137         (WTR::InjectedBundle::isAllowedHost):
2138         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2139         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2140         (WTR::isAllowedHost):
2141         (WTR::InjectedBundlePage::willSendRequestForFrame):
2142         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2143         * WebKitTestRunner/Options.cpp:
2144         (WTR::handleOptionAllowedHost):
2145         (WTR::OptionsHandler::OptionsHandler):
2146         * WebKitTestRunner/Options.h:
2147         * WebKitTestRunner/TestController.cpp:
2148         (WTR::TestController::initialize):
2149         (WTR::TestController::resetStateToConsistentValues):
2150         * WebKitTestRunner/TestController.h:
2151
2152 2015-03-26  Brady Eidson  <beidson@apple.com>
2153
2154         Apply ContentExtension actions after redirects.
2155         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2156
2157         Reviewed by Alex Christensen.
2158
2159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2160         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2161           which is specifically interesting to a new test.
2162
2163 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2164
2165         [EFL] Disable building libseccomp on AArch64
2166         https://bugs.webkit.org/show_bug.cgi?id=143094
2167
2168         Reviewed by Gyuyoung Kim.
2169
2170         * efl/jhbuildrc:
2171
2172 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2173
2174         [jhbuild] git should use only 1 thread for cloning jhbuild
2175         https://bugs.webkit.org/show_bug.cgi?id=143095
2176
2177         Reviewed by Gyuyoung Kim.
2178
2179         * jhbuild/jhbuild-wrapper:
2180         (clone_jhbuild):
2181
2182 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2183
2184         Update prepare-ChangeLog to work with ES6 Class syntax
2185         https://bugs.webkit.org/show_bug.cgi?id=143069
2186
2187         Reviewed by Timothy Hatcher.
2188
2189         * Scripts/prepare-ChangeLog:
2190         (get_function_line_ranges_for_javascript):
2191         Better handle ES6 Class syntax.
2192
2193         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2194         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2195         (BaseClass):
2196         (DerivedClass):
2197         (DerivedClass.staticMethod):
2198         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2199         (DerivedClass.prototype.method):
2200         (DerivedClass.prototype.get getter):
2201         (namespace.MyClass):
2202         (namespace.MyClass.staticMethod):
2203         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2204         (namespace.MyClass.prototype.method):
2205         (namespace.MyClass.prototype.get getter):
2206         Proof!
2207
2208 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
2209
2210         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2211         https://bugs.webkit.org/show_bug.cgi?id=142993
2212
2213         Reviewed by Mark Lam.
2214         
2215         Bunch of support for testing executable allocation failure.
2216
2217         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2218         (fail):
2219         * Scripts/run-javascriptcore-tests:
2220         (runJSCStressTests):
2221         * Scripts/run-jsc-stress-tests:
2222
2223 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2224
2225         Fix Windows build from r181977.
2226
2227         Unreviewed.
2228
2229         * Scripts/update-webkit-dependency:
2230
2231 2015-03-25  Sam Weinig  <sam@webkit.org>
2232
2233         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2234
2235         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2236         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2237
2238 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2239
2240         Migrate update-webkit for Windows to not require Cygwin
2241         https://bugs.webkit.org/show_bug.cgi?id=143040
2242
2243         Reviewed by Brent Fulgham.
2244
2245         * Scripts/update-webkit-dependency:
2246         (wanted):
2247         (toUnixPath): Deleted.
2248         * Scripts/webkitdirs.pm:
2249         (fontExists):
2250         (checkInstalledTools):
2251         (setupAppleWinEnv):
2252
2253 2015-03-25  Sam Weinig  <sam@webkit.org>
2254
2255         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2256         https://bugs.webkit.org/show_bug.cgi?id=143059
2257
2258         Reviewed by Alex Christensen.
2259
2260         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2261         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2262         Update for new interface of compileRuleList().
2263
2264 2015-03-25  Alex Christensen  <achristensen@webkit.org>
2265
2266         [Content Extensions] Add multi-DFA compiling and interpreting.
2267         https://bugs.webkit.org/show_bug.cgi?id=143010
2268
2269         Reviewed by Benjamin Poulain.
2270
2271         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2272         (TestWebKitAPI::testRequest):
2273         (TestWebKitAPI::TEST_F):
2274         Add some tests for ignore-previous-rules and large rulesets.
2275
2276 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
2277
2278         Mavericks WK1 still runs JSC tests
2279         https://bugs.webkit.org/show_bug.cgi?id=143035
2280
2281         Reviewed by Csaba Osztrogonác.
2282
2283         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2284         with other bots.
2285
2286         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2287         accordingly.
2288
2289 2015-03-25  Commit Queue  <commit-queue@webkit.org>
2290
2291         Unreviewed, rolling out r181932.
2292         https://bugs.webkit.org/show_bug.cgi?id=143041
2293
2294         The test fails most of the time on bots (Requested by ap on
2295         #webkit).
2296
2297         Reverted changeset:
2298
2299         "[Content Extensions] Add multi-DFA compiling and
2300         interpreting."
2301         https://bugs.webkit.org/show_bug.cgi?id=143010
2302         http://trac.webkit.org/changeset/181932
2303
2304 2015-03-24  Alex Christensen  <achristensen@webkit.org>
2305
2306         [Content Extensions] Add multi-DFA compiling and interpreting.
2307         https://bugs.webkit.org/show_bug.cgi?id=143010
2308
2309         Reviewed by Benjamin Poulain.
2310
2311         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2312         (TestWebKitAPI::testRequest):
2313         (TestWebKitAPI::TEST_F):
2314         Add some tests for ignore-previous-rules and large rulesets.
2315
2316 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
2317
2318         Make URL filter patterns matching consistent and add a simple canonicalization step
2319         https://bugs.webkit.org/show_bug.cgi?id=142998
2320
2321         Reviewed by Alex Christensen.
2322
2323         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2324
2325 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
2326
2327         [EFL] Add OpenWebRTC in jhbuild
2328         https://bugs.webkit.org/show_bug.cgi?id=142778
2329
2330         Reviewed by Gyuyoung Kim.
2331
2332         Original patch by Philippe Normand <pnormand@igalia.com>
2333
2334         * efl/install-dependencies: Dependencies for OpenWebRTC.
2335         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2336         the openwebrtc gst plugins.
2337
2338 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
2339
2340         Regression(r181257): WTF_WorkQueue.Simple is flaky
2341         https://bugs.webkit.org/show_bug.cgi?id=142560
2342
2343         Remove the check that the refCount has returned to one after the
2344         individual tasks have completed. It's too nondeterministic when
2345         the reference count will be reduced.
2346
2347         Reviewed by Alexey Proskuryakov
2348
2349         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2350         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2351
2352 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2353
2354         [CMake][EFL] Put failure API test excutables into failure directory
2355         https://bugs.webkit.org/show_bug.cgi?id=142965
2356
2357         Reviewed by Csaba Osztrogonác.
2358
2359         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2360
2361         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2362         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2363
2364 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
2365
2366         CSS Selectors: fix attribute case-insensitive matching of Contain and List
2367         https://bugs.webkit.org/show_bug.cgi?id=142932
2368
2369         Reviewed by Darin Adler.
2370
2371         Add tests for the new features and fix some existing tests using the 
2372         stringFromUTF8() utility recently added by Dhi.
2373
2374         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2375         (TestWebKitAPI::stringFromUTF8):
2376         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2377
2378 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2379
2380         [GTK] install-dependencies should install orc
2381         https://bugs.webkit.org/show_bug.cgi?id=142955
2382
2383         Reviewed by Martin Robinson.
2384
2385         Install orc, needed by openwebrtc
2386
2387         * gtk/install-dependencies:
2388
2389 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
2390
2391         Detect when url filter pattern with groups match the empty string
2392         https://bugs.webkit.org/show_bug.cgi?id=142930
2393
2394         Reviewed by Sam Weinig.
2395
2396         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2397
2398 2015-03-22  Anders Carlsson  <andersca@apple.com>
2399
2400         _WKWebsiteDataStore should clear WebSQL databases
2401         https://bugs.webkit.org/show_bug.cgi?id=142947
2402
2403         Reviewed by Sam Weinig.
2404
2405         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
2406
2407         * MiniBrowser/mac/WK2BrowserWindowController.m:
2408         (-[WK2BrowserWindowController fetchWebsiteData:]):
2409         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2410         (-[WK2BrowserWindowController clearWebsiteData:]):
2411
2412 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
2413
2414         GCTimer should know keep track of nested GC phases
2415         https://bugs.webkit.org/show_bug.cgi?id=142675
2416
2417         Reviewed by Darin Adler.
2418
2419         Adds a tool to aid in parsing the GC phase timing output into a
2420         tree-like structure based on the parent-child relationships
2421         of nested GC phases.
2422
2423         * Scripts/parse-gc-phase-timings: Added.
2424         (Timing):
2425         (Timing.__init__):
2426         (Timing.__unicode__):
2427         (Timing.__str__):
2428         (Timing.__repr__):
2429         (parse_input):
2430         (print_timing_node):
2431         (print_timing_tree):
2432         (link_parents):
2433         (main):
2434
2435 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
2436
2437         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
2438
2439         * Scripts/webkitpy/common/config/ews.json:
2440
2441 2015-03-20  Philippe Normand  <pnormand@igalia.com>
2442
2443         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
2444         https://bugs.webkit.org/show_bug.cgi?id=142867
2445
2446         Rubber-stamped by Csaba Osztrogon.
2447
2448         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
2449         a fixed revision for the openwebrtc-gst-plugins.
2450
2451 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2452
2453         Unreviewed build fix. Don't try to report stats for all benchmarks.
2454         Just report the geometric mean of preferred means.
2455
2456         * Scripts/run-jsc-benchmarks:
2457
2458 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2459
2460         run-jsc-benchmarks should only report preferred mean
2461         https://bugs.webkit.org/show_bug.cgi?id=142874
2462
2463         Reviewed by Geoffrey Garen.
2464
2465         Just collect statistics for the preferred mean.
2466
2467         * Scripts/run-jsc-benchmarks:
2468
2469 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2470
2471         [Content Extensions] Test regular expression parse failures.
2472         https://bugs.webkit.org/show_bug.cgi?id=142872
2473
2474         Reviewed by Benjamin Poulain.
2475
2476         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2477         (TestWebKitAPI::testPatternStatus):
2478         (TestWebKitAPI::TEST_F):
2479         Added tests for each parsing status.
2480
2481 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2482
2483         Fix API tests after r181754.
2484
2485         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2486         (TestWebKitAPI::testRequest):
2487
2488 2015-03-19  Brady Eidson  <beidson@apple.com>
2489
2490         Part of content extensions should apply css selectors
2491         https://bugs.webkit.org/show_bug.cgi?id=142604
2492
2493         Reviewed by Alex Christensen.
2494
2495         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2496         (WebCore::ContentExtensions::operator<<):
2497
2498 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
2499
2500         [Win] Activate tests on EWS
2501         https://bugs.webkit.org/show_bug.cgi?id=142850
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         * Scripts/webkitpy/common/config/ews.json: Add me as
2506         the EWS bot watcher, and activate tests.
2507
2508 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
2509
2510         [GTK] Fix inspector userinterface related incremental build issue
2511         https://bugs.webkit.org/show_bug.cgi?id=142849
2512
2513         Reviewed by Carlos Garcia Campos.
2514
2515         * Scripts/webkitdirs.pm:
2516         (shouldRemoveCMakeCache):
2517
2518 2015-03-18  Alex Christensen  <achristensen@webkit.org>
2519
2520         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2521         https://bugs.webkit.org/show_bug.cgi?id=142799
2522
2523         Reviewed by Brady Eidson.
2524
2525         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2526         (TestWebKitAPI::testPattern):
2527         (TestWebKitAPI::TEST_F):
2528         Start testing regex failures.
2529
2530 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
2531
2532         Fix StringView typos after r181525 and r181558
2533         https://bugs.webkit.org/show_bug.cgi?id=142772
2534
2535         Reviewed by Darin Adler.
2536
2537         Add some tests in [1] to cover the StringView::startsWith, 
2538         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
2539         StringView::endsWithIgnoringASCIICase implementations.
2540
2541         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2542         (TestWebKitAPI::TEST):
2543
2544 2015-03-18  Dana Burkart  <dburkart@apple.com>
2545
2546         Remove extraneous import to fix the build.
2547
2548         Unreviewed.
2549
2550         * Scripts/webkitpy/port/driver.py:
2551
2552 2015-03-18  Dana Burkart  <dburkart@apple.com>
2553
2554         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
2555         https://bugs.webkit.org/show_bug.cgi?id=142547
2556
2557         Reviewed by Alexey Proskuryakov.
2558
2559         * Scripts/webkitpy/port/driver.py:
2560         (Driver._setup_environ_for_driver):
2561
2562 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
2563
2564         Tweak how AppleSystemFontOSSubversion default is added
2565         https://bugs.webkit.org/show_bug.cgi?id=142835
2566
2567         Reviewed by Dan Bernstein.
2568
2569         * DumpRenderTree/mac/DumpRenderTree.mm:
2570         (setDefaultsToConsistentValuesForTesting):
2571
2572 2015-03-18  Dan Bernstein  <mitz@apple.com>
2573
2574         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
2575         https://bugs.webkit.org/show_bug.cgi?id=142815
2576
2577         Reviewed by Darin Adler.
2578
2579         * Scripts/prepare-ChangeLog:
2580         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
2581         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
2582         keep consuming the quoted text until the matching quotation mark is reached. Emit the
2583         warning only if a line ends without a backslash before the matching quotation mark was found.
2584
2585 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2586
2587         Remove unused "preprocessor" parameter to sub-CodeGenerators
2588         https://bugs.webkit.org/show_bug.cgi?id=142793
2589
2590         Reviewed by Darin Adler.
2591
2592         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2593         (new):
2594
2595 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
2596
2597         [EFL] Bump gstreamer version to 1.4.4
2598         https://bugs.webkit.org/show_bug.cgi?id=142782
2599
2600         Reviewed by Philippe Normand.
2601
2602         * efl/jhbuild.modules:
2603         * efl/patches/gst-libav.patch:
2604         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2605         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2606
2607 2015-03-17  Tim Horton  <timothy_horton@apple.com>
2608
2609         Fix the iOS build.
2610
2611         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2612         (WTR::InjectedBundle::platformInitialize):
2613
2614 2015-03-17  Dean Jackson  <dino@apple.com>
2615
2616         check-webkit-style should allow "bool a : 1"
2617         https://bugs.webkit.org/show_bug.cgi?id=142794
2618
2619         Reviewed by Brent Fulgham.
2620
2621         We should allow member bitfields of the form:
2622
2623         bool m_var : 1;
2624
2625         It seems that Visual Studio 8 was the last compiler that
2626         wasn't happy about not using unsigned here. We already have
2627         about 500 cases (in WebCore) where people were ignoring this rule.
2628
2629         * Scripts/webkitpy/style/checkers/cpp.py:
2630         (check_language): Allow "bool".
2631         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
2632         (CppStyleTest.test_enum_bitfields):
2633         (CppStyleTest.test_plain_integral_bitfields):
2634
2635 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
2636
2637         Compile character ranges targeting the same state as range check in the bytecode
2638         https://bugs.webkit.org/show_bug.cgi?id=142759
2639
2640         Reviewed by Alex Christensen.
2641
2642         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2643         (TestWebKitAPI::TEST_F):
2644
2645 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2646
2647         W3C test parser and converter should use test importer host
2648         https://bugs.webkit.org/show_bug.cgi?id=142729
2649
2650         Reviewed by Bem Jones-Bey.
2651
2652         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
2653         This enables adding more TestImporter unit testing.
2654         This patch also ensures that the git object instantiated by TestDownloader is using the
2655         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
2656
2657         * Scripts/webkitpy/common/system/filesystem_mock.py:
2658         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
2659         * Scripts/webkitpy/w3c/test_downloader.py:
2660         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
2661         (TestDownloader.checkout_test_repository): Making use of the new git function.
2662         * Scripts/webkitpy/w3c/test_importer.py:
2663         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
2664         (TestImporter.import_tests): Adding host as parameter to the converter.
2665         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2666         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
2667         (TestImporterTest):
2668         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
2669         * Scripts/webkitpy/w3c/test_parser.py:
2670         (TestParser.__init__): Adding host as parameter constructor.
2671
2672 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2673
2674         [GTK] WebKitDOM objects leaking
2675         https://bugs.webkit.org/show_bug.cgi?id=118788
2676
2677         Reviewed by Darin Adler and Sergio Villar Senin.
2678
2679         Update DOMObjectCache unit test to check that DOM objects are also
2680         released when new contents are loaded in the web view, and the old
2681         document is detached from the frame.
2682
2683         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2684         (testWebKitDOMObjectCache):
2685         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2686         (runTest):
2687
2688 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2689
2690         W3C test importer default import folder should be LayoutTests/imported/w3c
2691         https://bugs.webkit.org/show_bug.cgi?id=142728
2692
2693         Reviewed by Bem Jones-Bey.
2694
2695         * Scripts/webkitpy/w3c/test_importer.py:
2696         (parse_args): Updating the default destination option value to 'imported/w3c'.
2697
2698 2015-03-17  Philippe Normand  <pnormand@igalia.com>
2699
2700         [GTK] basic OpenWebRTC build support
2701         https://bugs.webkit.org/show_bug.cgi?id=142393
2702
2703         Reviewed by Carlos Garcia Campos.
2704
2705         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
2706         is not the upstream OpenWebRTC repository. This temporary fork
2707         contains a few patches needed by WebKit for audio/video rendering.
2708
2709 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2710
2711         [CMake][EFL] Build test tools only for developer mode
2712         https://bugs.webkit.org/show_bug.cgi?id=142761
2713
2714         Reviewed by Csaba Osztrogonác.
2715
2716         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
2717
2718         * CMakeLists.txt:
2719
2720 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
2721
2722         Remove never used "useLayerOnTop" bindings generator argument
2723         https://bugs.webkit.org/show_bug.cgi?id=142773
2724
2725         Reviewed by Darin Adler.
2726
2727         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2728         (new):
2729
2730 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
2731
2732         Enable ES6 classes by default
2733         https://bugs.webkit.org/show_bug.cgi?id=142774
2734
2735         Reviewed by Gavin Barraclough.
2736
2737         * Scripts/webkitperl/FeatureList.pm:
2738
2739 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2740
2741         Fix webkitpy tests after r181585.
2742
2743         Looks like "me" cannot be anyone's email, it's a special case.
2744
2745         * Scripts/webkitpy/common/config/contributors.json:
2746
2747 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2748
2749         Add tolerance to WebAudio tests
2750         https://bugs.webkit.org/show_bug.cgi?id=142676
2751
2752         Reviewed by Tim Horton.
2753
2754         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
2755
2756         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2757         (TestResultWriter.create_audio_diff_and_write_result):
2758         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2759         (FailureAudio.write_failure):
2760         * Scripts/webkitpy/port/base.py:
2761         (Port.do_audio_results_differ):
2762         Diff audio failures.
2763
2764         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
2765         tests to use real parseable WAV data, and got rid of base64, which there didn't
2766         seem to have been any reason for.
2767
2768 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2769
2770         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
2771         https://bugs.webkit.org/show_bug.cgi?id=142720
2772
2773         Reviewed by Myles C. Maxfield.
2774
2775         Activate system copies of Microsoft fonts for the current process, thus overriding
2776         any other ones that could be preferred by the system otherwise.
2777
2778         * DumpRenderTree/mac/DumpRenderTree.mm:
2779         (activateSystemCoreWebFonts):
2780         (adjustFonts):
2781         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2782         (WTR::activateSystemCoreWebFonts):
2783         (WTR::activateFonts):
2784
2785 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2786
2787         Created Streams API watchlist
2788         https://bugs.webkit.org/show_bug.cgi?id=142684
2789
2790         Reviewed by Benjamin Poulain.
2791
2792         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
2793         watchlist and added Benjamin, Youenn and me to it.
2794
2795 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
2796
2797         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
2798         https://bugs.webkit.org/show_bug.cgi?id=142715
2799
2800         Reviewed by Brent Fulgham.
2801
2802         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2803         (TestWebKitAPI::TEST):
2804
2805 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
2806
2807         Change the exact attribute matching to be ASCII case-insensitive
2808         https://bugs.webkit.org/show_bug.cgi?id=142609
2809
2810         Reviewed by Darin Adler.
2811
2812         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2813         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2814
2815 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2816
2817         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
2818         https://bugs.webkit.org/show_bug.cgi?id=134764
2819
2820         Reviewed by Ryosuke Niwa.
2821
2822         TestDownloader is introduced to download W3C tests from the official
2823         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
2824         and https://github.com/w3c/csswg-test.git).
2825         TestDownloader clones the repositories and checkouts revisions of the tests
2826         defined in LayoutTests/imported/w3c/resources/TestRepositories.
2827
2828         Similarly to https://codereview.chromium.org/148173016,
2829         TestDownloader copies part of the files based on the rules
2830         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
2831
2832         TestDownloader is used by TestImporter when no source directory is provided.
2833
2834         * Scripts/webkitpy/w3c/test_downloader.py: Added.
2835         (TestDownloader):
2836         (TestDownloader.default_options):
2837         (TestDownloader.load_test_repositories):
2838         (TestDownloader.__init__):
2839         (TestDownloader.checkout_test_repository):
2840         (TestDownloader._init_paths_from_expectations):
2841         (TestDownloader._add_test_suite_paths):
2842         (TestDownloader._empty_directory):
2843         (TestDownloader.copy_tests):
2844         (TestDownloader.download_tests):
2845         * Scripts/webkitpy/w3c/test_importer.py:
2846         (main):
2847         (parse_args):
2848         (TestImporter.__init__):
2849         (TestImporter.do_import):
2850         (TestImporter.test_downloader):
2851         (TestImporter.find_importable_tests.should_keep_subdir):
2852         (TestImporter.should_convert_test_harness_links):
2853         (TestImporter.import_tests):
2854         (TestImporter.write_import_log):
2855
2856 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2857
2858         [Mavericks] Test snapshots are 1600x1200 on Retina devices
2859         https://bugs.webkit.org/show_bug.cgi?id=142630
2860
2861         Reviewed by Tim Horton.
2862
2863         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2864         Removed an ifdef that disabled the fix on Mavericks.
2865
2866 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2867
2868         Remove isWK2 cruft from webkitdirs.pm after r170426
2869         https://bugs.webkit.org/show_bug.cgi?id=142618
2870
2871         Reviewed by Daniel Bates.
2872
2873         * Scripts/webkitdirs.pm:
2874         (isWK2): Deleted.
2875
2876 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2877
2878         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2879         https://bugs.webkit.org/show_bug.cgi?id=138687
2880
2881         Reviewed by Carlos Garcia Campos.
2882
2883         Always change cookie policy from UI process, as changing it from WebProcess doesn't
2884         affect other processes.
2885
2886         The implementation is imperfect, because the change happens asynchronously, but I
2887         don't expect it to be a problem in practice.
2888
2889         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2890         (WTR::InjectedBundle::beginTesting):
2891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2892         (WTR::TestRunner::setAlwaysAcceptCookies):
2893         * WebKitTestRunner/TestInvocation.cpp:
2894         (WTR::TestInvocation::invoke):
2895         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2896
2897 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2898
2899         [EFL] Enable building EFL 1.13 with NEON support
2900         https://bugs.webkit.org/show_bug.cgi?id=142619
2901
2902         Reviewed by Gyuyoung Kim.
2903
2904         * efl/jhbuild.modules:
2905
2906 2015-03-11  Alex Christensen  <achristensen@webkit.org>
2907
2908         [Content Extensions] Add resource type and load type triggers.
2909         https://bugs.webkit.org/show_bug.cgi?id=142422
2910
2911         Reviewed by Benjamin Poulain.
2912
2913         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2914         (TestWebKitAPI::testRequest):
2915         (TestWebKitAPI::mainDocumentRequest):
2916         (TestWebKitAPI::TEST_F):
2917         (TestWebKitAPI::testURL): Deleted.
2918
2919 2015-03-10  Sam Weinig  <sam@webkit.org>
2920
2921         Allow adding a button in input elements for auto fill related functionality
2922         <rdar://problem/19782066>
2923         https://bugs.webkit.org/show_bug.cgi?id=142564
2924
2925         Reviewed by Anders Carlsson.
2926
2927         * WebKitTestRunner/TestController.cpp:
2928         (WTR::TestController::createOtherPage):
2929         (WTR::TestController::createWebViewWithOptions):
2930         Update for new callback.
2931
2932 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
2933
2934         Add basic support for BOL and EOL assertions to the URL Filter parser
2935         https://bugs.webkit.org/show_bug.cgi?id=142568
2936
2937         Reviewed by Alex Christensen.
2938
2939         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2940         (TestWebKitAPI::TEST_F):
2941
2942 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2943
2944         [GTK] Add support for handling TLS errors to MiniBrowser
2945         https://bugs.webkit.org/show_bug.cgi?id=142576
2946
2947         Reviewed by Sergio Villar Senin.
2948
2949         It's useful for testing TLS errors handling itself, but also to
2950         allow ignoring TLS errors when testing.
2951
2952         * MiniBrowser/gtk/BrowserWindow.c:
2953         (webViewLoadFailedWithTLSerrors):
2954         (browserWindowConstructed):
2955
2956 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2957
2958         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2959         https://bugs.webkit.org/show_bug.cgi?id=142569
2960
2961         Reviewed by David Hyatt.
2962
2963         Test Optional::valueOrCompute().
2964
2965         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2966         (TestWebKitAPI::TEST):
2967
2968 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2969
2970         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2971         https://bugs.webkit.org/show_bug.cgi?id=126688
2972
2973         Reviewed by Gustavo Noronha Silva.
2974
2975         * CMakeLists.txt: Build testing tools only for developer builds,
2976         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2977         * MiniBrowser/gtk/CMakeLists.txt: Only add
2978         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2979         and add a rule to install the MiniBrowser.
2980         * MiniBrowser/gtk/main.c:
2981         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2982         builds.
2983
2984 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
2985
2986         Add some DateMath tests to TestWebKitAPI
2987         https://bugs.webkit.org/show_bug.cgi?id=142565
2988
2989         Reviewed by Alexey Proskuryakov.
2990
2991         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2992         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2993         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2995         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2996
2997 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
2998
2999         Regression(r181257): WTF_WorkQueue.Simple is flaky
3000         https://bugs.webkit.org/show_bug.cgi?id=142560
3001
3002         Unreviewed attempt to improve test stability.
3003
3004         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
3005         the WorkQueue a little later to redue flakiness.
3006
3007 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3008
3009         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
3010         https://bugs.webkit.org/show_bug.cgi?id=142555
3011
3012         Reviewed by Simon Fraser.
3013
3014         * DumpRenderTree/mac/DumpRenderTree.mm:
3015         (setDefaultsToConsistentValuesForTesting):
3016         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3017         (WTR::InjectedBundle::platformInitialize):
3018
3019 2015-03-10  Alex Christensen  <achristensen@webkit.org>
3020
3021         Use unsigned for HashSet size.
3022         https://bugs.webkit.org/show_bug.cgi?id=142518
3023
3024         Reviewed by Benjamin Poulain.
3025
3026         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3029         (TestWebKitAPI::testInitialCapacity):
3030         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3031         (TestWebKitAPI::TEST):
3032
3033 2015-03-10  Daniel Bates  <dabates@apple.com>
3034
3035         [iOS] Add WebKitSystemInterface for iOS 8.2
3036         https://bugs.webkit.org/show_bug.cgi?id=142505
3037
3038         Rubber-stamped by Anders Carlsson.
3039
3040         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
3041         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
3042         copy-webkitlibraries-to-product-directory in r181286.
3043
3044         * Scripts/copy-webkitlibraries-to-product-directory:
3045
3046 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
3047
3048         Extend URL filter's Term definition to support groups/subpatterns
3049         https://bugs.webkit.org/show_bug.cgi?id=142519
3050
3051         Reviewed by Alex Christensen.
3052
3053         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3054         (TestWebKitAPI::testURL):
3055
3056 2015-03-06  Jer Noble  <jer.noble@apple.com>
3057
3058         Add an option to run-webkit-tests to override the LayoutTests/ directory
3059         https://bugs.webkit.org/show_bug.cgi?id=142418
3060
3061         Reviewed by David Kilzer.
3062
3063         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
3064         directory. The base port will parse the options during initialization and store the override
3065         location if present. layout_tests_dir() will return this overridden location if set.
3066
3067         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3068         (parse_args):
3069         * Scripts/webkitpy/port/base.py:
3070         (Port.__init__):
3071         (Port.layout_tests_dir):
3072
3073 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
3074
3075         [CMake] Enable WorkQueue tests for CMake ports
3076         https://bugs.webkit.org/show_bug.cgi?id=142473
3077
3078         Reviewed by Darin Adler.
3079
3080         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
3081         the list of source files.
3082         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
3083         to the list of include directories for EFL.
3084
3085 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3086
3087         Attempt to fix timeouts on iOS Simulator layout tests
3088
3089         * Scripts/webkitpy/port/ios.py:
3090         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
3091         Simulator end after the first 50 tests time out.  Some analysis
3092         this past weekend shows that the 'Booted' status in the output
3093         of `xcrun simctl list` is not sufficient (and watching the test
3094         run shows that SpringBoard hasn't fully started to the point
3095         where it's displaying icons on the home screen).  The workaround
3096         until we have a better fix is to add an arbitrary timeout to let
3097         SpringBoard finish launching.  In practice, 15 seconds is
3098         probably enough, but 30 seconds should nearly always work.
3099
3100 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
3101
3102         Unreviewed. Add myself as a committer.
3103
3104         * Scripts/webkitpy/common/config/contributors.json:
3105
3106 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3107
3108         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3109
3110         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3111         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3112         an expectation that will fail if we hit the race condition.
3113         This test is inherently racy and will deadlock if the first job
3114         for queue2 takes the mutex lock before the second job for
3115         queue1.
3116
3117 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3118
3119         [Win] WTF::WorkQueue does not balance ref/deref properly
3120         https://bugs.webkit.org/show_bug.cgi?id=142471
3121
3122         Reviewed by Antti Koivisto.
3123
3124         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3125         (TestWebKitAPI::TEST): Check that the refcount is correct.
3126
3127 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3128
3129         Do not show passing test result on output of EFL layout test
3130         https://bugs.webkit.org/show_bug.cgi?id=142380
3131
3132         Reviewed by Darin Adler.
3133
3134         To show passing tests has caused inconvenience when we detect problem tests
3135         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3136         in order not to show passing tests in the output of EFL layout test.
3137
3138         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3139         (RunWebKitTests.start):
3140
3141 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3142
3143         Unreviewed build fix.
3144
3145         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3146         (TestWebKitAPI::TEST): Remove two unused variables.
3147
3148 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3149
3150         Add some WorkQueue tests to TestWebKitAPI
3151         https://bugs.webkit.org/show_bug.cgi?id=142447
3152
3153         Reviewed by Sam Weinig.
3154
3155         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3156         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3158         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3159         (TestWebKitAPI::simpleTest):
3160         (TestWebKitAPI::longTest):
3161         (TestWebKitAPI::thirdTest):
3162         (TestWebKitAPI::finishedTests):
3163         (TestWebKitAPI::TEST):
3164         (TestWebKitAPI::longTest2):
3165
3166 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3167
3168         Remove willDestroyFrame in WKBundlePageLoaderClient
3169         https://bugs.webkit.org/show_bug.cgi?id=142389
3170
3171         Reviewed by Anders Carlsson.
3172
3173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3174         (WTR::InjectedBundlePage::InjectedBundlePage):
3175
3176 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
3177
3178         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3179         https://bugs.webkit.org/show_bug.cgi?id=142433
3180
3181         Reviewed by Darin Adler.
3182
3183         Include more TestWebKitAPI tests when building for Windows. Also
3184         fix a build error in MetaAllocator.cpp caused by one of the
3185         Microsoft headers #defining 'small'.
3186
3187         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3188         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3189         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3190
3191 2015-03-06  Sam Weinig  <sam@webkit.org>
3192
3193         [Content Extensions] Move compiling of content extensions to the UIProcess
3194         https://bugs.webkit.org/show_bug.cgi?id=142402
3195
3196         Reviewed by Benjamin Poulain.
3197
3198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3199         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3200         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3201         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3202         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3203         (TestWebKitAPI::TEST_F):
3204         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3205         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3206         is now abstract).
3207
3208 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
3209
3210         [Win] Correct Windows build.
3211
3212         Rubberstamped by Michael Saboff
3213
3214         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3215         in the GOTO labels.
3216
3217 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3218
3219         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3220         https://bugs.webkit.org/show_bug.cgi?id=142385
3221
3222         Reviewed by Sergio Villar Senin.
3223
3224         Use stack allocated GMainLoopSources to make sure they are
3225         cancelled automatically if the test finishes before they have
3226         been processed.
3227
3228         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3229         (testWebViewSyncRequestOnMaxConns):
3230
3231 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3232
3233         Remove Mountain Lion libraries since ML isn't supported
3234         https://bugs.webkit.org/show_bug.cgi?id=142332
3235
3236         Reviewed by Darin Adler.
3237
3238         * Scripts/copy-webkitlibraries-to-product-directory:
3239
3240 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
3241
3242         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3243         https://bugs.webkit.org/show_bug.cgi?id=142083
3244
3245         Reviewed by Simon Fraser.
3246
3247         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3248
3249         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3250         (WebPlatformTestServer._copy_webkit_test_files):
3251
3252 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3253
3254         setup-git-clone fails due to the failure to download python-irclib-0.4.8
3255         https://bugs.webkit.org/show_bug.cgi?id=141946
3256
3257         Reviewed by Ryosuke Niwa.
3258
3259         Check in ircbot.py and irclib.py to avoid network problems in the future.
3260
3261         * Scripts/webkitpy/common/net/irc/ircbot.py:
3262         * Scripts/webkitpy/thirdparty/__init__.py:
3263         (AutoinstallImportHook.find_module):
3264         (AutoinstallImportHook._install_irc): Deleted.
3265         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3266         (ThirdpartyTest.test_imports):
3267         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
3268         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
3269         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
3270
3271 2015-03-06  David Kilzer  <ddkilzer@apple.com>
3272
3273         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
3274
3275         See also fix to config.json in r181097.
3276
3277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3278         (WebKitBuildbot): Add missing "WK2" to the names of the perf
3279         bots.
3280
3281 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3282
3283         run-jsc-stress-tests should determine the architecture from ELF binaries
3284         https://bugs.webkit.org/show_bug.cgi?id=142335
3285
3286         Reviewed by Darin Adler.
3287
3288         * Scripts/run-jsc-stress-tests:
3289
3290 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3291
3292         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
3293         <http://webkit.org/b/142226>
3294
3295         Reviewed by Darin Adler.
3296
3297         * Scripts/webkitpy/port/ios.py:
3298         (IOSSimulatorPort.default_baseline_search_path): Switch the
3299         TestExpectations order of ios-simulator-wk2 from this:
3300           ios-simulator-wk2, wk2, ios-simulator
3301         To this:
3302           ios-simulator-wk2, ios-simualtor, wk2
3303
3304 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3305
3306         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
3307         https://bugs.webkit.org/show_bug.cgi?id=142370
3308
3309         Reviewed by Dean Jackson.
3310
3311         * Scripts/webkitdirs.pm:
3312         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
3313         logs, one for warnings, the other for errors.
3314         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
3315         into the standard BuildOutput.htm document.
3316
3317 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3318
3319         Dashboard has trouble parsing iOS test output
3320         <http://webkit.org/b/142364>
3321
3322         Reviewed by Alex Christensen.
3323
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3325         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3326         Add fallback path to build a regex using 'matchString' so that
3327         it matches anywhere in the line.  In practice, 'matchString' is
3328         a prefix for the label following the number.
3329
3330 2015-03-05  Alex Christensen  <achristensen@webkit.org>
3331
3332         Fix linker warnings in TestWebKitAPI.
3333         https://bugs.webkit.org/show_bug.cgi?id=141912
3334
3335         Reviewed by David Kilzer.
3336
3337         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3338         Do not export TearDownTestCase or SetUpTestCase symbols.
3339
3340 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3341
3342         [Win] Unreviewed EWS fix.
3343
3344         * Scripts/webkitdirs.pm:
3345         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
3346         the EWS output more usable.
3347
3348 2015-03-05  Chris Dumez  <cdumez@apple.com>
3349
3350         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
3351         https://bugs.webkit.org/show_bug.cgi?id=142350
3352
3353         Reviewed by Michael Saboff and Benjamin Poulain.
3354
3355         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
3356         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
3357
3358         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3359         (TestWebKitAPI::TEST):
3360
3361 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3362
3363         [Win] Ensure build target directory exists when launching MSBuild
3364         https://bugs.webkit.org/show_bug.cgi?id=142360
3365
3366         Reviewed by Dean Jackson.
3367
3368         Create the build output directory (if it doesn't exist) before
3369         launching MSBuild so that it can immediately begin writing logs.
3370
3371         * Scripts/webkitdirs.pm:
3372         (buildVisualStudioProject):
3373
3374 2015-03-05  Chris Dumez  <cdumez@apple.com>
3375
3376         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
3377         https://bugs.webkit.org/show_bug.cgi?id=142325
3378
3379         Reviewed by Csaba Osztrogonác.
3380
3381         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
3382         As a result, "--webkit-test-runner / -2" parameters are replaced by
3383         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
3384         than WebKitTestRunner.
3385
3386         * BuildSlaveSupport/build.webkit.org-config/config.json:
3387         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3388         (RunWebKit1Tests):
3389         (RunWebKit1Tests.start):
3390         (RunWebKit1LeakTests):
3391         (RunWebKit1LeakTests.start):
3392         (RunAndUploadPerfTestsWebKit1):
3393         (RunAndUploadPerfTestsWebKit1.start):
3394         (TestFactory):
3395         (TestWebKit1LeaksFactory):
3396         (TestWebKit1LeaksFactory.__init__):
3397         (TestWebKit1Factory):
3398         (TestWebKit1AllButJSCFactory):
3399         (TestAllButJSCFactory):
3400         (BuildAndPerfTestWebKit1Factory):
3401         (BuildAndPerfTestWebKit1Factory.__init__):
3402         (BuildAndPerfTestFactory):
3403         (BuildAndPerfTestFactory.__init__):
3404         (DownloadAndPerfTestWebKit1Factory):
3405         (DownloadAndPerfTestWebKit1Factory.__init__):
3406         (DownloadAndPerfTestFactory):
3407         (DownloadAndPerfTestFactory.__init__):
3408         (RunWebKitLeakTests): Deleted.
3409         (RunWebKitLeakTests.start): Deleted.
3410         (RunWebKit2Tests): Deleted.
3411         (RunWebKit2Tests.start): Deleted.
3412         (RunAndUploadPerfTestsWebKit2): Deleted.
3413         (RunAndUploadPerfTestsWebKit2.start): Deleted.
3414         (TestLeaksFactory): Deleted.
3415         (TestLeaksFactory.__init__): Deleted.
3416         (TestWebKit2Factory): Deleted.
3417         (TestWebKit2AndJSCFactory): Deleted.
3418         (BuildAndPerfTestWebKit2Factory): Deleted.
3419         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
3420         (DownloadAndPerfTestWebKit2Factory): Deleted.
3421         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
3422         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3423         (parse_args):
3424         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3425         (PerfTestsRunner._parse_args):
3426         * Scripts/webkitpy/port/port_testcase.py:
3427         (PortTestCase.test_build_driver):
3428
3429 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3430
3431         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
3432         https://bugs.webkit.org/show_bug.cgi?id=140845
3433
3434         Reviewed by David Kilzer.
3435
3436         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
3437         and generate suitable build commands to drive a full build from our
3438         existing solution files.
3439
3440         * Scripts/webkitdirs.pm:
3441         (msBuildInstallDir): Added.
3442         (determineConfigurationForVisualStudio): Revise to use MSBuild command
3443         line arguments to drive the build.
3444         (setupCygwinEnv): Warn user if MSBuild cannot be located.
3445         (buildVisualStudioProject): Revise to use MSBuild command line arguments
3446         to specify build architecture.
3447         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
3448         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
3449         bother looking for CoreUI or SafariTheme build logs.
3450
3451 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3452
3453         [buildbot] mastercfg_unittest.py should be runnable easily
3454         https://bugs.webkit.org/show_bug.cgi?id=142219
3455
3456         Reviewed by Chris Dumez.
3457
3458         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
3459         the last Twisted version works together with this buildbot version.
3460
3461         * Scripts/webkitpy/common/system/autoinstall.py:
3462         (AutoInstaller): Added prepend_to_search_path argument to be able
3463         to prefer autoinstalled package to system package.
3464         (AutoInstaller.__init__):
3465         (AutoInstaller._set_up_target_dir):
3466         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
3467         (AutoInstaller._prepare_package):
3468         (AutoInstaller._extract_targz): Renamed to _extract_tar.
3469         * Scripts/webkitpy/thirdparty/__init__.py:
3470         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
3471
3472 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
3473
3474         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
3475         https://bugs.webkit.org/show_bug.cgi?id=131162
3476
3477         Reviewed by Gyuyoung Kim.
3478
3479         * MiniBrowser/efl/main.c:
3480         (on_download_request):
3481         (on_download_finished):
3482         (on_download_failed):
3483         (window_create):
3484         Adapt download callbacks to new callback mechanism
3485
3486 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3487
3488         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
3489
3490         In r180927 we updated the libsoup version used by the jhbuild. In
3491         this new version the sniffer uses image/x-icon instead of
3492         image/vnd.microsoft.icon for blank.ico resource.
3493
3494         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3495         (testWebResourceMimeType):
3496
3497 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3498
3499         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
3500         https://bugs.webkit.org/show_bug.cgi?id=142244
3501
3502         Reviewed by Sergio Villar Senin.
3503
3504         Check that the SSL server doesn't process any request in case of
3505         TLS errors when the policy is set to FAIL.
3506
3507         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3508         (testTLSErrorsPolicy):
3509         (testTLSErrorsRedirect):
3510         (testTLSErrorsHTTPAuth):
3511         (testLoadFailedWithTLSErrors):
3512         (testSubresourceLoadFailedWithTLSErrors):
3513         (httpsServerCallback):
3514
3515 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
3516
3517         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
3518         https://bugs.webkit.org/show_bug.cgi?id=141154
3519
3520         Reviewed by Jer Noble.
3521
3522         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
3523
3524         For the sake of completeness WebKitTestRunner should specify temporary
3525         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
3526
3527         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
3528         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3529         to get data storage paths. Only Mac port has an actual implementation of it.
3530         However, WebKitTestRunner overrides them in favour of unique temporary dir
3531         which is taken from libraryPathForTesting().
3532
3533         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3534         is not implemented for EFL and GTK ports it returns an empty string.
3535         All default data folders besides MediaKeys are overridden in TestRunner
3536         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
3537         env variable.
3538
3539         GTK port does not enable encrypted keys by default so
3540         WebMediaKeyStorageManager::initialize() code path is never triggered.
3541
3542         * WebKitTestRunner/TestController.cpp:
3543         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
3544         WebKit ports.
3545
3546 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3547
3548         [buildbot] Add regression test to check which builder runs which tests
3549         https://bugs.webkit.org/show_bug.cgi?id=142166
3550
3551         Reviewed by Alexey Proskuryakov.
3552
3553         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3554         (BuildStepsConstructorTest.createTest):
3555         (BuildStepsTest):
3556         (BuildStepsTest.generateTests):
3557         (BuildStepsTest.createTest):
3558         (BuildStepsTest.createTest.doTest):
3559         (BuildStepsTest.test_unnecessary_expected_results):
3560
3561 2015-03-04  Commit Queue  <commit-queue@webkit.org>
3562
3563         Unreviewed, rolling out r181054.
3564         https://bugs.webkit.org/show_bug.cgi?id=142320
3565
3566         Broke the api tests (Requested by sundiamonde on #webkit).
3567
3568         Reverted changeset:
3569
3570         "Fix linker warnings in TestWebKitAPI."
3571         https://bugs.webkit.org/show_bug.cgi?id=141912
3572         http://trac.webkit.org/changeset/181054
3573
3574 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3575
3576         Fix linker warnings in TestWebKitAPI.
3577         https://bugs.webkit.org/show_bug.cgi?id=141912
3578
3579         Reviewed by David Kilzer.
3580
3581         * TestWebKitAPI/Configurations/Base.xcconfig:
3582         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
3583
3584 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
3585
3586         [Mac] Set SystemUIFontSelect in DRT and WKTR
3587         https://bugs.webkit.org/show_bug.cgi?id=142303
3588
3589         Reviewed by Myles C. Maxfield.
3590
3591         * DumpRenderTree/mac/DumpRenderTree.mm:
3592         (setDefaultsToConsistentValuesForTesting):
3593         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3594         (WTR::InjectedBundle::platformInitialize):
3595
3596 2015-03-04  Chris Dumez  <cdumez@apple.com>
3597
3598         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3599         https://bugs.webkit.org/show_bug.cgi?id=142314
3600         <rdar://problem/20046835>
3601
3602         Reviewed by Ryosuke Niwa.
3603
3604         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3605         to get WK2 code coverage.
3606
3607         * BuildSlaveSupport/build.webkit.org-config/config.json:
3608
3609 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3610
3611         Move content extensions test to properly named directory.
3612         https://bugs.webkit.org/show_bug.cgi?id=142299
3613
3614         Reviewed by Tim Horton.
3615
3616         * WebKitTestRunner/mac/TestControllerMac.mm:
3617         (WTR::TestController::platformConfigureViewForTest):
3618
3619 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3620
3621         W3C test importer should use filesystem instead of os.walk
3622         https://bugs.webkit.org/show_bug.cgi?id=142085
3623
3624         Reviewed by Bem Jones-Bey.
3625
3626         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
3627         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
3628         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
3629
3630         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
3631         Added a unit test to check that test importer is now black-box testable using a Mock system.
3632
3633         * Scripts/webkitpy/common/system/filesystem.py:
3634         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
3635         (FileSystem.dirs_under.filter_all):
3636         * Scripts/webkitpy/common/system/filesystem_mock.py:
3637         (MockFileSystem.dirs_under):
3638         (MockFileSystem.dirs_under.filter_all):
3639         (MockFileSystem.getsize):
3640         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3641         (MockFileSystemTest.test_dirs_under):
3642         (MockFileSystemTest.test_dirs_under.filter_dir):
3643         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3644         (RealFileSystemTest.test_sep):
3645         (RealFileSystemTest):
3646         (RealFileSystemTest.test_dirs_under):
3647         (RealFileSystemTest.test_dirs_under.filter_this_dir):
3648         * Scripts/webkitpy/w3c/test_importer.py:
3649         (TestImporter.do_import):
3650         (TestImporter.find_importable_tests.should_keep_subdir):
3651         (TestImporter.find_importable_tests):
3652         (TestImporter.should_keep_subdir): Deleted.
3653         (TestImporter.should_skip_file): Deleted.
3654         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3655         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
3656
3657 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
3658
3659         [WebEditingTester] Add support for the find and replace bar
3660         https://bugs.webkit.org/show_bug.cgi?id=142247
3661
3662         Reviewed by Enrica Casucci.
3663
3664         While it's not hooked up yet in WKWebView, adding support for the
3665         find bar to WebEditingTester will help us implement that functionality.
3666
3667         * WebEditingTester/AppDelegate.h:
3668         * WebEditingTester/AppDelegate.m:
3669         (-[WebEditingAppDelegate performTextFinderAction:]):
3670         * WebEditingTester/MainMenu.xib:
3671         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
3672
3673         * WebEditingTester/WK2WebDocumentController.m:
3674         (-[WK2WebDocumentController awakeFromNib]):
3675         (-[WK2WebDocumentController performTextFinderAction:]):
3676         (-[WK2WebDocumentController findBarView]):
3677         (-[WK2WebDocumentController setFindBarView:]):
3678         (-[WK2WebDocumentController isFindBarVisible]):
3679         (-[WK2WebDocumentController setFindBarVisible:]):
3680         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
3681         (-[WK2WebDocumentController layout]):
3682         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
3683         pointing at the WKWebView (currently nothing will work, but the bar will
3684         show up). Install and uninstall the bar as needed.
3685
3686         * WebEditingTester/WebDocument.xib: