40a60b502837efb3b0b6ea60ebf362d4c5cf61d9
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-14  Andy Estes  <aestes@apple.com>
2
3         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
4         https://bugs.webkit.org/show_bug.cgi?id=197751
5         <rdar://problem/50631563>
6
7         Reviewed by Alex Christensen.
8
9         Added new API tests.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
12         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
13         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
14         (TestWebKitAPI::TEST):
15         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
16         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
17
18 2019-05-14  Youenn Fablet  <youenn@apple.com>
19
20         A service worker process should app nap when all its clients app nap
21         https://bugs.webkit.org/show_bug.cgi?id=185626
22         <rdar://problem/46785908>
23
24         Reviewed by Alex Christensen.
25
26         Allow to enable app nap through test header.
27
28         * WebKitTestRunner/TestController.cpp:
29         (WTR::TestController::resetPreferencesToConsistentValues):
30         (WTR::updateTestOptionsFromTestHeader):
31         * WebKitTestRunner/TestOptions.h:
32         (WTR::TestOptions::hasSameInitializationOptions const):
33
34 2019-05-14  Commit Queue  <commit-queue@webkit.org>
35
36         Unreviewed, rolling out r245281.
37         https://bugs.webkit.org/show_bug.cgi?id=197887
38
39         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
40         (Requested by aakashjain on #webkit).
41
42         Reverted changeset:
43
44         "Add a unit test for client certificate authentication"
45         https://bugs.webkit.org/show_bug.cgi?id=197800
46         https://trac.webkit.org/changeset/245281
47
48 2019-05-14  Youenn Fablet  <youenn@apple.com>
49
50         Add support for webkit-test-runner options to WPT importer
51         https://bugs.webkit.org/show_bug.cgi?id=197826
52
53         Reviewed by Alex Christensen.
54
55         In case of overwriting an existing test, check if the existing test
56         contains a <!-- webkit-test-runner --> comment and insert it back if
57         needed in the new test.
58
59         For exporter, forbid creating a WPT PR if there are changes containing
60         the webkit-test-runner string.
61
62         * Scripts/webkitpy/w3c/test_converter.py:
63         (convert_for_webkit):
64         (_W3CTestConverter.__init__):
65         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
66         (_W3CTestConverter.handle_starttag):
67         (_W3CTestConverter.handle_comment):
68         (_W3CTestConverter.handle_decl):
69         (_W3CTestConverter.handle_pi):
70         * Scripts/webkitpy/w3c/test_exporter.py:
71         (WebPlatformTestExporter.write_git_patch_file):
72         (WebPlatformTestExporter.make_pull_request):
73         * Scripts/webkitpy/w3c/test_importer.py:
74         (TestImporter.webkit_test_runner_options):
75         (TestImporter):
76         (TestImporter.add_webkit_test_runner_options_to_content):
77         (TestImporter.copy_html_file):
78         (TestImporter.write_html_template):
79         (TestImporter.write_html_files_for_templated_js_tests):
80         (TestImporter.import_tests):
81         * Scripts/webkitpy/w3c/test_importer_unittest.py:
82         (test_manual_slow_test):
83         (test_webkit_test_runner_options):
84
85 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
86
87         [ews-app] Status bubble should turn orange when any build step fails
88         https://bugs.webkit.org/show_bug.cgi?id=197812
89
90         Reviewed by Jonathan Bedard.
91
92         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
93         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
94         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
95
96 2019-05-14  Alex Christensen  <achristensen@webkit.org>
97
98         Add a unit test for client certificate authentication
99         https://bugs.webkit.org/show_bug.cgi?id=197800
100
101         Reviewed by Youenn Fablet.
102
103         Make better abstractions for reading and writing from/to TCPServer.
104         Add a unit test that causes a client certificate authentication challenge to happen.
105
106         * TestWebKitAPI/TCPServer.cpp:
107         (TestWebKitAPI::TCPServer::TCPServer):
108         (TestWebKitAPI::TCPServer::read):
109         (TestWebKitAPI::TCPServer::write):
110         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
111         (TestWebKitAPI::TCPServer::respondWithOK):
112         * TestWebKitAPI/TCPServer.h:
113         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
114         (credentialWithIdentity):
115         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
116         (TEST):
117         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
118         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
119         (-[ClientCertificateDelegate challengeCount]):
120         (TestWebKitAPI::TEST):
121         (respondWithChallengeThenOK): Deleted.
122         (credentialWithIdentityAndKeychainPath): Deleted.
123         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
124         (TEST):
125         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
126         (TestWebKitAPI::TEST):
127         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
128         (TEST):
129         (readRequest): Deleted.
130         (writeResponse): Deleted.
131         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
132         (TestWebKitAPI::TEST):
133         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
134
135 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
136
137         [CG] Adding support for HEIF-sequence ('public.heics') images
138         https://bugs.webkit.org/show_bug.cgi?id=197384
139
140         Reviewed by Simon Fraser.
141
142         * DumpRenderTree/TestOptions.cpp:
143         (TestOptions::TestOptions):
144         * DumpRenderTree/TestOptions.h:
145         * DumpRenderTree/mac/DumpRenderTree.mm:
146         (resetWebViewToConsistentStateBeforeTesting):
147         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
148         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
149         the test.
150
151         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
152         (WTR::InjectedBundle::stringForKey):
153         (WTR::InjectedBundle::beginTesting):
154         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
155         * WebKitTestRunner/TestController.cpp:
156         (WTR::TestController::resetStateToConsistentValues):
157         (WTR::updateTestOptionsFromTestHeader):
158         * WebKitTestRunner/TestInvocation.cpp:
159         (WTR::TestInvocation::createTestSettingsDictionary):
160         * WebKitTestRunner/TestOptions.h:
161         (WTR::TestOptions::hasSameInitializationOptions const):
162         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
163         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
164         the test.
165
166 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
167
168         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
169         https://bugs.webkit.org/show_bug.cgi?id=197730
170
171         Reviewed by Filip Pizlo.
172
173         * TestWebKitAPI/CMakeLists.txt:
174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
175         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
178         (TestWebKitAPI::TEST):
179
180 2019-05-10  Chris Dumez  <cdumez@apple.com>
181
182         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
183
184         It became flaky after r245198.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
187
188 2019-05-10  Youenn Fablet  <youenn@apple.com>
189
190         A service worker instance should be terminated when its SWServer is destroyed
191         https://bugs.webkit.org/show_bug.cgi?id=197801
192         <rdar://problem/50587270>
193
194         Reviewed by Chris Dumez.
195
196         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
197
198 2019-05-10  Chris Dumez  <cdumez@apple.com>
199
200         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
201         https://bugs.webkit.org/show_bug.cgi?id=197750
202
203         Reviewed by Geoffrey Garen.
204
205         Add API test coverage.
206
207         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
208         (TEST):
209
210 2019-05-10  Keith Miller  <keith_miller@apple.com>
211
212         Remove legacy test262 import script
213         https://bugs.webkit.org/show_bug.cgi?id=197788
214
215         Reviewed by Yusuke Suzuki.
216
217         import-test262-tests doesn't work anymore. We should be using test262-import instead.
218
219         * Scripts/import-test262-tests: Removed.
220
221 2019-05-10  Charlie Turner  <cturner@igalia.com>
222
223         [WPE] Forward libepoxy cflags
224         https://bugs.webkit.org/show_bug.cgi?id=197784
225
226         Reviewed by Žan Doberšek.
227
228         Patch by Zan Dobersek.
229
230         * wpe/backends/CMakeLists.txt: This is required to keep
231         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
232         up trying to include X11 headers even when they're not present in the
233         environment.
234
235 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
236
237         Fix a bunch of compiler warnings
238         https://bugs.webkit.org/show_bug.cgi?id=197785
239
240         Reviewed by Don Olmstead.
241
242         Add preprocessor guards to avoid -Wunused-function warnings.
243
244         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
245         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
246         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
247
248 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
249
250         [WPE][GTK] Add webkit_frame_get_id() API
251         https://bugs.webkit.org/show_bug.cgi?id=197270
252
253         Reviewed by Carlos Garcia Campos.
254
255         This was hard, but I added a test to verify that two different WebKitFrames of the same
256         WebKitWebPage return two different frame IDs.
257
258         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
259         (WebKitFrameTest::willSubmitFormCallback):
260         (WebKitFrameTest::testSubframe):
261         (registerTests):
262         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
263         (testWebKitFrameSubframe):
264         (beforeAll):
265         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
266         (willSubmitFormCallback):
267         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
268         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
269
270 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
271
272         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
273         https://bugs.webkit.org/show_bug.cgi?id=197271
274
275         Reviewed by Youenn Fablet.
276
277         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
278         (formControlsAssociatedForFrameCallback):
279         (pageCreatedCallback):
280         (formControlsAssociatedCallback): Deleted.
281
282 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
283
284         [Flatpak] Use the safe PyYAML loader if available
285         https://bugs.webkit.org/show_bug.cgi?id=197771
286
287         Reviewed by Philippe Normand.
288
289         * flatpak/flatpakutils.py:
290         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
291         still used as fallback when the former is not provided by the module.
292
293 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
294
295         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
296         https://bugs.webkit.org/show_bug.cgi?id=197734
297
298         Reviewed by Don Olmstead.
299
300         * Scripts/webkitpy/port/win.py:
301         (WinCairoPort._search_paths): Add 'wk2' and
302         additional_platform_directory to paths as well as other ports do.
303
304 2019-05-09  Daniel Bates  <dabates@apple.com>
305
306         [iOS] Numpad comma key has incorrect keyIdentifier property
307         https://bugs.webkit.org/show_bug.cgi?id=197753
308         <rdar://problem/50636274>
309
310         Reviewed by Brent Fulgham.
311
312         Recognize "numpadComma" and return the appropriate HID usage code.
313
314         * WebKitTestRunner/ios/HIDEventGenerator.mm:
315         (hidUsageCodeForCharacter):
316
317 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
318
319         Refine AudioSession route sharing policy
320         https://bugs.webkit.org/show_bug.cgi?id=197742
321         <rdar://problem/50590818>
322
323         Reviewed by Darin Adler.
324
325         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
326         (TestWebKitAPI::TEST):
327
328 2019-05-09  Alex Christensen  <achristensen@webkit.org>
329
330         Remove unnecessary test SPI after r244883
331         https://bugs.webkit.org/show_bug.cgi?id=197575
332
333         Reviewed by Tim Horton.
334
335         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
336         (TEST):
337         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
338         (TestWebKitAPI::TEST):
339
340 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
341
342         [ews-app] Add migrations file to repository
343         https://bugs.webkit.org/show_bug.cgi?id=197729
344
345         Reviewed by Jonathan Bedard.
346
347         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
348
349 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
350
351         [ews-build] Fix formatting issues and typos
352         https://bugs.webkit.org/show_bug.cgi?id=197737
353
354         Reviewed by Jonathan Bedard.
355
356         * BuildSlaveSupport/ews-build/steps.py:
357         (CompileWebKit.evaluateCommand): Removed extra empty line.
358         * BuildSlaveSupport/ews-build/steps_unittest.py:
359         (TestRunWebKitPerlTests): Fixed typo.
360         * BuildSlaveSupport/ews-app/ews/models/step.py:
361         (Step.save_step): Changed log level to info so that it is logged in production.
362
363 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
364
365         [ews-app] Production and Development env should configure DEBUG appropriately
366         https://bugs.webkit.org/show_bug.cgi?id=197700
367
368         Reviewed by Jonathan Bedard.
369
370         * BuildSlaveSupport/ews-app/ews-app/settings.py:
371
372 2019-05-09  Xan López  <xan@igalia.com>
373
374         [CMake] Detect SSE2 at compile time
375         https://bugs.webkit.org/show_bug.cgi?id=196488
376
377         Reviewed by Carlos Garcia Campos.
378
379         * Scripts/webkitdirs.pm:
380         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
381         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
382
383 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
384
385         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
386         https://bugs.webkit.org/show_bug.cgi?id=197697
387
388         Reviewed by Žan Doberšek.
389
390         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
391         * wpe/jhbuild.modules: Ditto.
392
393 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
394
395         Update ANGLE
396         https://bugs.webkit.org/show_bug.cgi?id=197676
397
398         Reviewed by Alex Christensen.
399
400         * TestWebKitAPI/PlatformWin.cmake:
401         Remove unnecessary library linkage.
402
403 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
404
405         [Win] build-webkit should be ready for Visual Studio 2019
406         https://bugs.webkit.org/show_bug.cgi?id=196622
407
408         Reviewed by Ross Kirsling.
409
410         1. Accommodated to the new msbuild.exe location of VS 2019.
411         2. Removed the hard coded "Visual Studio 15" generator.
412
413         build-webkit is going to choose a Visual Studio generator version
414         matching with the latest installed VS. If you invoke vcvars.bat
415         before build-webkit, it chooses the corresponding Visual Studio
416         generator version by cheking 'VisualStudioVersion' env var which
417         is set by vcvars.bat.
418
419         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
420         (msBuildPath): When looking for MSBuild, look in
421         "MSBuild\Current\bin" (the new expected location) and fallback
422         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
423         first location.
424         (msBuildInstallDir): Renamed to msBuildPath.
425         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
426         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
427
428 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
429
430         [PlayStation] Update port options
431         https://bugs.webkit.org/show_bug.cgi?id=197723
432
433         Reviewed by Ross Kirsling.
434
435         ICU headers were missing from TestWTF.
436
437         * TestWebKitAPI/PlatformPlayStation.cmake:
438
439 2019-05-08  Alex Christensen  <achristensen@webkit.org>
440
441         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
442         https://bugs.webkit.org/show_bug.cgi?id=197712
443         <rdar://problem/50429770>
444
445         Reviewed by Tim Horton.
446
447         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
448         (TestWebKitAPI::TEST):
449
450 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
451
452         Change my status to be a WebKit reviewer.
453
454         * Scripts/webkitpy/common/config/contributors.json:
455
456 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
457
458         Unreviewed, rolling out r244952.
459
460         Caused inspector to appear blank.
461
462         Reverted changeset:
463
464         "Web Inspector: Provide UIString descriptions to improve
465         localizations"
466         https://bugs.webkit.org/show_bug.cgi?id=195132
467         https://trac.webkit.org/changeset/244952
468
469 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
470
471         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
472         https://bugs.webkit.org/show_bug.cgi?id=197685
473
474         Reviewed by Alex Christensen.
475
476         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
477         completion. See LayoutTests/ChangeLog for more details.
478
479         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
480         (WTR::UIScriptController::platformClearAllCallbacks):
481
482 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
483
484         Unreviewed. Add myself as a committer.
485
486         * Scripts/webkitpy/common/config/contributors.json:
487
488 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
489
490         Unreviewed, rolling out r245038.
491
492         Breaks internal builds.
493
494         Reverted changeset:
495
496         "Add SPI to set a list of hosts to which to send custom header
497         fields cross-origin"
498         https://bugs.webkit.org/show_bug.cgi?id=197397
499         https://trac.webkit.org/changeset/245038
500
501 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
502
503         Unreviewed. Add myself as a committer.
504
505         * Scripts/webkitpy/common/config/contributors.json:
506
507 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
508
509         Define media buffering policy
510         https://bugs.webkit.org/show_bug.cgi?id=196979
511         <rdar://problem/28383861>
512
513         Reviewed by Jer Noble.
514
515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
516         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
517         (waitUntilBufferingPolicyIsEqualTo):
518         (TEST):
519
520 2019-05-07  Alex Christensen  <achristensen@webkit.org>
521
522         Add SPI to set a list of hosts to which to send custom header fields cross-origin
523         https://bugs.webkit.org/show_bug.cgi?id=197397
524
525         Reviewed by Geoff Garen.
526
527         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
528         (TEST):
529         (expectLegacyHeaders):
530         (expectHeaders):
531         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
532         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
533         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
534
535 2019-05-07  Keith Rollin  <krollin@apple.com>
536
537         Add option to build-webkit to control whether or not XCBuild is used
538         https://bugs.webkit.org/show_bug.cgi?id=197668
539         <rdar://problem/50549728>
540
541         Reviewed by Tim Horton.
542
543         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
544         Also update build-webkit and the makefiles with the foundation for
545         automatically using XCBuild when the conditions allow it. This latter
546         facility is currently turned off until Xcode fully supports building
547         WebKit with XCBuild.
548
549         * Scripts/build-webkit:
550         * Scripts/webkitdirs.pm:
551         (XcodeOptions):
552         (canUseXCBuild):
553
554 2019-05-07  Andy Estes  <aestes@apple.com>
555
556         run-bindings-tests should test global scope constructor generation
557         https://bugs.webkit.org/show_bug.cgi?id=197669
558
559         Reviewed by Alex Christensen.
560
561         * Scripts/webkitpy/bindings/main.py:
562         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
563         invoking preprocess-idls.pl.
564
565 2019-05-07  Youenn Fablet  <youenn@apple.com>
566
567         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
568         https://bugs.webkit.org/show_bug.cgi?id=195997
569         <rdar://problem/50509884>
570
571         Reviewed by Chris Dumez.
572
573         Spin test until successful.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
576
577 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
578
579         [Flatpak] webkit-build fails due to missing GTK2 in build environment
580         https://bugs.webkit.org/show_bug.cgi?id=197352
581
582         Reviewed by Philippe Normand.
583
584         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
585         to build it ourselves on top in order to be able to build the GTK 2.x plugin
586         process.
587
588         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
589
590 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
591
592         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
593         https://bugs.webkit.org/show_bug.cgi?id=197644
594         <rdar://problem/50526364>
595
596         Reviewed by Tim Horton.
597
598         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
601         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
602         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
603         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
604
605 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
606
607         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
608         https://bugs.webkit.org/show_bug.cgi?id=197651
609
610         Reviewed by Žan Doberšek.
611
612         This is required since the process creation was delayed until something is loaded in the view.
613
614         * MiniBrowser/gtk/BrowserWindow.c:
615         (browser_window_get_or_create_web_view_for_automation):
616         * MiniBrowser/wpe/main.cpp:
617         (main):
618
619 2019-05-06  Tim Horton  <timothy_horton@apple.com>
620
621         _overrideViewportWithArguments does not work when called before loading
622         https://bugs.webkit.org/show_bug.cgi?id=197638
623         <rdar://problem/50505111>
624
625         Reviewed by Wenson Hsieh.
626
627         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
628         (TEST):
629
630 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
631
632         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
633         https://bugs.webkit.org/show_bug.cgi?id=197510
634
635         Reviewed by Alex Christensen.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
638         (TestWebKitAPI::TEST):
639
640 2019-05-06  Keith Rollin  <krollin@apple.com>
641
642         Temporarily disable generate-xcfilelists
643         https://bugs.webkit.org/show_bug.cgi?id=197619
644         <rdar://problem/50507392>
645
646         Reviewed by Alex Christensen.
647
648         We need to perform a significant update to the generate-xcfilelist
649         scripts. This work involves coordinated work with another facility. If
650         the work does not occur in tandem, the build will be broken. To avoid
651         this, disable the invoking of the scripts during the transition. The
652         checking will be restored once the new scripts are in place.
653
654         * DumpRenderTree/Scripts/check-xcfilelists.sh:
655         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
656
657 2019-05-04  Alex Christensen  <achristensen@webkit.org>
658
659         Revert r244953 and r244954 because they broke internal builds.
660         https://bugs.webkit.org/show_bug.cgi?id=197534
661
662         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
663         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
664         * DumpRenderTree/mac/DumpRenderTree.mm:
665         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
666         * DumpRenderTree/mac/TestRunnerMac.mm:
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
668         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
669         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
670         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
671         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
672         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
673         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
674         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
675         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
676         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
677         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
678         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
679         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
680         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
681         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
682         * TestWebKitAPI/cocoa/TestWKWebView.mm:
683         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
684         * TestWebKitAPI/ios/UIKitSPI.h: Added.
685         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
686         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
687         * WebKitTestRunner/ios/HIDEventGenerator.h:
688         * WebKitTestRunner/ios/HIDEventGenerator.mm:
689         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
690         * WebKitTestRunner/ios/TestControllerIOS.mm:
691         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
692         * WebKitTestRunner/ios/mainIOS.mm:
693
694 2019-05-04  Alex Christensen  <achristensen@webkit.org>
695
696         Merge the three UIKitSPI.h files into a single one in PAL
697         https://bugs.webkit.org/show_bug.cgi?id=197534
698
699         Reviewed by Darin Adler.
700
701         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
702         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
703         * DumpRenderTree/mac/DumpRenderTree.mm:
704         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
705         * DumpRenderTree/mac/TestRunnerMac.mm:
706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
707         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
708         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
709         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
710         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
711         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
712         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
713         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
714         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
715         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
716         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
717         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
718         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
719         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
720         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
721         * TestWebKitAPI/cocoa/TestWKWebView.mm:
722         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
723         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
724         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
725         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
726         * WebKitTestRunner/ios/HIDEventGenerator.h:
727         * WebKitTestRunner/ios/HIDEventGenerator.mm:
728         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
729         * WebKitTestRunner/ios/TestControllerIOS.mm:
730         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
731         * WebKitTestRunner/ios/mainIOS.mm:
732
733 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
734
735         Web Inspector: Provide UIString descriptions to improve localizations
736         https://bugs.webkit.org/show_bug.cgi?id=195132
737         <rdar://problem/48457817>
738
739         Reviewed by Devin Rousso.
740
741         Allow WI.UIString to take:
742         - WI.UIString(string, key, comment)
743         - WI.UIString(string, comment)
744         - WI.UIString(string)
745
746         * Scripts/extract-localizable-js-strings:
747
748 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
749
750         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
751         https://bugs.webkit.org/show_bug.cgi?id=197579
752
753         Reviewed by Tim Horton.
754
755         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
756         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
757         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
758         ensure that the the focused element has been blurred.
759
760         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
761
762 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
763
764         Add a tool to block spammer accounts
765         https://bugs.webkit.org/show_bug.cgi?id=197537
766
767         Reviewed by Darin Adler.
768
769         Usage: block-spammers email1 email2 ...
770
771         The tool finds and hides all bugs and comments from this account. Before any work
772         is done, these bugs and comments are displayed for confirmation.
773
774         * Scripts/block-spammers: Added.
775         (get_bugzilla_token):
776         (invalidate_bugzilla_token):
777         (get_user_info):
778         (get_user_info_self):
779         (can_use_this_tool):
780         (disable_user):
781         (get_bugs_created_by_user):
782         (get_bugs_commented_on_by_user):
783         (get_comments):
784         (hide_bug):
785         (hide_comments):
786         (ask_yes_no):
787         (sanitized_string):
788         (main):
789
790 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
791
792         run-apit-tests: Add --iterations and --repeat-each
793         https://bugs.webkit.org/show_bug.cgi?id=197563
794
795         Reviewed by Aakash Jain.
796
797         * Scripts/webkitpy/api_tests/manager.py:
798         (Manager.run): Add --iterations and --repeat-each/
799         * Scripts/webkitpy/api_tests/run_api_tests.py:
800         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
801
802 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
803
804         New EWS: Clicking on white bubble navigates to page with only bubbles
805         https://bugs.webkit.org/show_bug.cgi?id=197520
806
807         Reviewed by Lucas Forschler.
808
809         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
810
811 2019-05-03  Daniel Bates  <dabates@apple.com>
812
813         [lldb-webkit] Support adding pretty-printing for qualified types
814         https://bugs.webkit.org/show_bug.cgi?id=197518
815
816         Reviewed by Darin Adler.
817
818         Remove all "::"s from the name of the specified type when computing the name for the Python classes
819         that will provide summary and synthetic details as LLDB is not happy about registering such classes
820         when they contain :: in their name.
821
822         * lldb/lldb_webkit.py:
823         (addSummaryAndSyntheticFormattersForRawBitmaskType):
824
825 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
826
827         New EWS: patches on recently added queues listed as #1 for older bugs
828         https://bugs.webkit.org/show_bug.cgi?id=197496
829
830         Reviewed by Lucas Forschler.
831
832         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
833         (StatusBubble._build_bubble):
834         (StatusBubble._queue_position):
835
836 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
837
838         webkit-patch --no-review upload does not submit patch to New EWS
839         https://bugs.webkit.org/show_bug.cgi?id=197519
840         <rdar://problem/50424887>
841
842         Reviewed by Lucas Forschler.
843
844         * Scripts/webkitpy/tool/steps/submittoews.py:
845         (SubmitToEWS.run): Submit to both old and new EWS.
846         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
847         * Scripts/webkitpy/common/net/ewsserver.py: Added.
848         (EWSServer._server_url): Method to return server url.
849         (EWSServer._post_patch_to_ews): Method to post patch to ews.
850         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
851         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
852         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
853         * Scripts/webkitpy/common/net/statusserver_mock.py:
854         (MockStatusServer.submit_to_ews): Updated the log text.
855         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
856         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
857         * Scripts/webkitpy/tool/main.py:
858         (WebKitPatch.__init__): Initialize ews_server. 
859         * Scripts/webkitpy/tool/mocktool.py:
860         (MockTool.__init__): Ditto.
861
862 2019-05-03  Chris Dumez  <cdumez@apple.com>
863
864         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
865         https://bugs.webkit.org/show_bug.cgi?id=197574
866         <rdar://problem/50453181>
867
868         Reviewed by Tim Horton.
869
870         Add API test coverage.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
873         (TEST):
874
875 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
876
877         [JSC] Generator CodeBlock generation should be idempotent
878         https://bugs.webkit.org/show_bug.cgi?id=197552
879
880         Reviewed by Keith Miller.
881
882         * Scripts/run-javascriptcore-tests:
883         (runJSCStressTests):
884         * Scripts/run-jsc-stress-tests:
885
886 2019-05-03  Commit Queue  <commit-queue@webkit.org>
887
888         Unreviewed, rolling out r244881.
889         https://bugs.webkit.org/show_bug.cgi?id=197559
890
891         Breaks compilation of jsconly on linux, breaking compilation
892         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
893         guijemont on #webkit).
894
895         Reverted changeset:
896
897         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
898         WEBKIT_COPY_FILES"
899         https://bugs.webkit.org/show_bug.cgi?id=197174
900         https://trac.webkit.org/changeset/244881
901
902 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
903
904         Unreviewed WPE build fix after r244898.
905
906         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
907         (WTR::TestController::abortModal): Add the missing (no-op) definition.
908
909 2019-05-02  Alex Christensen  <achristensen@webkit.org>
910
911         Mark U+01C0 as a homograph of U+006C
912         https://bugs.webkit.org/show_bug.cgi?id=197526
913         <rdar://problem/50301904>
914
915         Reviewed by Tim Horton.
916
917         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
918         (TestWebKitAPI::TEST):
919
920 2019-05-02  Chris Dumez  <cdumez@apple.com>
921
922         Add test coverage for <rdar://problem/49731231>
923         https://bugs.webkit.org/show_bug.cgi?id=196730
924         <rdar://problem/49731231>
925
926         Reviewed by Ryosuke Niwa.
927
928         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
929         to match DumpRenderTree.
930
931         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
932         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
933         (WTR::TestRunner::abortModal):
934         * WebKitTestRunner/InjectedBundle/TestRunner.h:
935         * WebKitTestRunner/TestController.cpp:
936         (WTR::TestController::runModal):
937         * WebKitTestRunner/TestController.h:
938         * WebKitTestRunner/TestInvocation.cpp:
939         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
940         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
941         (WTR::TestController::abortModal):
942         * WebKitTestRunner/ios/TestControllerIOS.mm:
943         (WTR::TestController::abortModal):
944         * WebKitTestRunner/mac/TestControllerMac.mm:
945         (WTR::TestController::abortModal):
946         * WebKitTestRunner/win/TestControllerWin.cpp:
947         (WTR::TestController::abortModal):
948
949 2019-05-02  Christopher Reid  <chris.reid@sony.com>
950
951         [CMake] Add support for LTO builds
952         https://bugs.webkit.org/show_bug.cgi?id=188986
953
954         Reviewed by Don Olmstead.
955
956         Add support to configure --lto-mode with cmake builds.
957
958         * Scripts/build-webkit:
959         * Scripts/webkitdirs.pm:
960         (generateBuildSystemFromCMakeProject):
961
962 2019-05-02  John Wilander  <wilander@apple.com>
963
964         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
965         https://bugs.webkit.org/show_bug.cgi?id=197521
966         <rdar://problem/49651503>
967
968         Reviewed by Brent Fulgham.
969
970         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
971         (TestWebKitAPI::TEST):
972            Added a test for host strings with leading dots since they are
973            often used for the domain attribute in cookies.
974
975 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
976
977         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
978         https://bugs.webkit.org/show_bug.cgi?id=197510
979
980         Reviewed by Alex Christensen.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
983         (TestWebKitAPI::TEST):
984
985 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
986
987         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
988         https://bugs.webkit.org/show_bug.cgi?id=197174
989
990         Reviewed by Alex Christensen.
991
992         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
993
994         * TestWebKitAPI/PlatformGTK.cmake:
995         * TestWebKitAPI/PlatformWPE.cmake:
996
997 2019-05-02  Alex Christensen  <achristensen@webkit.org>
998
999         Build fix for internal branch.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1002         RetainPtr.h was not explicitly included.
1003
1004 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1005
1006         webkitpy: Ignore errors when shutting down an already shutdown simulator
1007         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1008         <rdar://problem/50390247>
1009
1010         Reviewed by Lucas Forschler.
1011
1012         * Scripts/webkitpy/xcode/simulated_device.py:
1013         (SimulatedDevice._shut_down):
1014
1015 2019-05-02  Frederic Wang  <fwang@igalia.com>
1016
1017         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1018         https://bugs.webkit.org/show_bug.cgi?id=196142
1019
1020         This patch introduces some experimental runtime flag to let users
1021         disable MathML features that are removed from MathML Core [1]. For now,
1022         these features are only disabled on GTK and WPE ports.
1023
1024         [1] https://mathml-refresh.github.io/mathml-core/
1025
1026         Reviewed by Rob Buis.
1027
1028         * DumpRenderTree/TestOptions.cpp:
1029         (TestOptions::TestOptions):
1030         * DumpRenderTree/TestOptions.h:
1031         * DumpRenderTree/mac/DumpRenderTree.mm:
1032         (setWebPreferencesForTestOptions):
1033
1034 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1035
1036         TestWebKitAPI config.h should be aware of what suite is being built
1037         https://bugs.webkit.org/show_bug.cgi?id=196583
1038
1039         Reviewed by Konstantin Tokarev.
1040
1041         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1042         benefit the macro defines BUILDING_* for the executable which allows the includes
1043         of the config.h to be tailored to the test suite being built. Because of that the
1044         dependencies of the Test* executable are specific to the test suite which may
1045         speed up the build.
1046
1047         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1048         when "Utilities.h" is what was needed.
1049
1050         * TestWebKitAPI/CMakeLists.txt:
1051         * TestWebKitAPI/PlatformGTK.cmake:
1052         * TestWebKitAPI/PlatformJSCOnly.cmake:
1053         * TestWebKitAPI/PlatformMac.cmake:
1054         * TestWebKitAPI/PlatformPlayStation.cmake:
1055         * TestWebKitAPI/PlatformUtilities.h:
1056         * TestWebKitAPI/PlatformWPE.cmake:
1057         * TestWebKitAPI/PlatformWin.cmake:
1058         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1059         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1060         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1061         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1062         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1063         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1064         * TestWebKitAPI/config.h:
1065
1066 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1067
1068         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1069         https://bugs.webkit.org/show_bug.cgi?id=181950
1070         <rdar://problem/43357371>
1071
1072         Reviewed by Brent Fulgham.
1073
1074         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1075         (TestWebKitAPI::TEST_F):
1076
1077 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1078
1079         Remove webkitpy and bindings EWS queues from dashboard
1080         https://bugs.webkit.org/show_bug.cgi?id=197475
1081
1082         Reviewed by Alexey Proskuryakov.
1083
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1085
1086 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1087
1088         Remove webkitpy and bindings test queues from old EWS
1089         https://bugs.webkit.org/show_bug.cgi?id=197468
1090
1091         Reviewed by Alexey Proskuryakov.
1092
1093         * QueueStatusServer/config/queues.py:
1094
1095 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1096
1097         Fix the WebKitTestRunner build
1098         https://bugs.webkit.org/show_bug.cgi?id=197449
1099         <rdar://problem/50334169>
1100
1101         Reviewed by Alexey Proskuryakov.
1102
1103         * WebKitTestRunner/mac/EventSenderProxy.mm:
1104         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1105         (WTR::EventSenderProxy::mouseForceChanged):
1106         Use some SPI instead of IPI.
1107
1108 2019-04-30  Chris Dumez  <cdumez@apple.com>
1109
1110         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1111         https://bugs.webkit.org/show_bug.cgi?id=197426
1112         <rdar://problem/50256169>
1113
1114         Reviewed by Brady Eidson.
1115
1116         Add API test coverage.
1117
1118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1119         (-[PSONScheme setShouldRespondAsynchronously:]):
1120         (-[PSONScheme webView:startURLSchemeTask:]):
1121         (-[PSONScheme webView:stopURLSchemeTask:]):
1122
1123 2019-04-30  Chris Dumez  <cdumez@apple.com>
1124
1125         Unreviewed, rolling out r244802.
1126
1127         Caused an API test failure
1128
1129         Reverted changeset:
1130
1131         "Regression(PSON) URL scheme handlers can no longer respond
1132         asynchronously"
1133         https://bugs.webkit.org/show_bug.cgi?id=197426
1134         https://trac.webkit.org/changeset/244802
1135
1136 2019-04-30  Chris Dumez  <cdumez@apple.com>
1137
1138         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1139         https://bugs.webkit.org/show_bug.cgi?id=197426
1140         <rdar://problem/50256169>
1141
1142         Reviewed by Brady Eidson.
1143
1144         Add API test coverage.
1145
1146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1147         (-[PSONScheme setShouldRespondAsynchronously:]):
1148         (-[PSONScheme webView:startURLSchemeTask:]):
1149         (-[PSONScheme webView:stopURLSchemeTask:]):
1150
1151 2019-04-30  Chris Dumez  <cdumez@apple.com>
1152
1153         Only use a related page's process if that page has not been closed yet
1154         https://bugs.webkit.org/show_bug.cgi?id=197393
1155         <rdar://problem/50302423>
1156
1157         Reviewed by Tim Horton.
1158
1159         Add API test coverage.
1160
1161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1162
1163 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1164
1165         [ews-build] Enable Bindings tests queue on new EWS
1166         https://bugs.webkit.org/show_bug.cgi?id=197424
1167
1168         Reviewed by Lucas Forschler.
1169
1170         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1171         (StatusBubble):
1172         * BuildSlaveSupport/ews-build/config.json:
1173
1174 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1175
1176         [ews-build] Configure ews151 for running various tests
1177         https://bugs.webkit.org/show_bug.cgi?id=197419
1178
1179         Reviewed by Lucas Forschler.
1180
1181         * BuildSlaveSupport/ews-build/config.json:
1182
1183 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1184
1185         [ews-build] Parse and display bindings test failures
1186         https://bugs.webkit.org/show_bug.cgi?id=197423
1187
1188         Reviewed by Lucas Forschler.
1189
1190         * BuildSlaveSupport/ews-build/steps.py:
1191         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1192         (RunBindingsTests.start): Initialize log_observer for json output.
1193         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1194         (RunBindingsTests._addToLog): Method to add message to log.
1195         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1196
1197 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1198
1199         Unreviewed. Add myself as a committer.
1200
1201         * Scripts/webkitpy/common/config/contributors.json:
1202
1203 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1204
1205         [ews-build] Enable webkitpy queue on new EWS
1206         https://bugs.webkit.org/show_bug.cgi?id=197396
1207
1208         Reviewed by Lucas Forschler.
1209
1210         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1211         (StatusBubble):
1212         * BuildSlaveSupport/ews-build/config.json:
1213
1214 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1215
1216         [ews-build] Parse and display webkitpy failures
1217         https://bugs.webkit.org/show_bug.cgi?id=197395
1218
1219         Reviewed by Lucas Forschler.
1220
1221         * BuildSlaveSupport/ews-build/steps.py:
1222         (RunWebKitPyTests.start): Initialize log_observer for json output.
1223         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1224         (RunWebKitPyTests._addToLog): Method to add message to log.
1225         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1226
1227 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1228
1229         <rdar://problem/50299396> Fix internal High Sierra build
1230         https://bugs.webkit.org/show_bug.cgi?id=197388
1231
1232         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1233         * MiniBrowser/Configurations/Base.xcconfig:
1234         * MobileMiniBrowser/Configurations/Base.xcconfig:
1235         * TestWebKitAPI/Configurations/Base.xcconfig:
1236         * WebKitTestRunner/Configurations/Base.xcconfig:
1237
1238 2019-04-29  Youenn Fablet  <youenn@apple.com>
1239
1240         Remove spurious GVA printf logging
1241         https://bugs.webkit.org/show_bug.cgi?id=197368
1242         <rdar://problem/35975256>
1243
1244         Reviewed by Alexey Proskuryakov.
1245
1246         * Scripts/webkitpy/port/mac.py:
1247         (MacPort.logging_patterns_to_strip):
1248
1249 2019-04-29  Youenn Fablet  <youenn@apple.com>
1250
1251         getDisplayMedia should be called on user gesture
1252         https://bugs.webkit.org/show_bug.cgi?id=197356
1253         <rdar://problem/50296074>
1254
1255         Reviewed by Eric Carlson.
1256
1257         Update test configuration to inject internals
1258         so that we can use it to simulate a user click to call getDisplayMedia.
1259
1260         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1261         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1262         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1263
1264 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1265
1266         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1267         https://bugs.webkit.org/show_bug.cgi?id=197339
1268
1269         Reviewed by Dewei Zhu.
1270
1271         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1272         test run for setup steps that are too expensive to do every iteration.
1273
1274         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1275         (BenchmarkRunner._run_benchmark):
1276         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1277         (BrowserDriver):
1278         (BrowserDriver.prepare_initial_env):
1279         (BrowserDriver.restore_env_after_all_testing):
1280         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1281         (LinuxBrowserDriver.prepare_initial_env):
1282         (LinuxBrowserDriver.restore_env_after_all_testing):
1283         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1284         (OSXBrowserDriver.prepare_initial_env):
1285         (OSXBrowserDriver.restore_env_after_all_testing):
1286
1287 2019-04-28  Andy Estes  <aestes@apple.com>
1288
1289         Fix the watchOS engineering build.
1290
1291         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1292         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1293
1294 2019-04-27  Chris Dumez  <cdumez@apple.com>
1295
1296         [WKTR] Move test timeout handling to the UIProcess
1297         https://bugs.webkit.org/show_bug.cgi?id=197333
1298
1299         Reviewed by Darin Adler.
1300
1301         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1302         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1303         every WebContent process in the case of swapping.
1304
1305         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1306         would lead to crashes when firing the timer.
1307
1308         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1309         (WTR::InjectedBundle::didReceiveMessageToPage):
1310         (WTR::InjectedBundle::done):
1311         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1312         (WTR::InjectedBundle::shouldDumpPixels const):
1313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1314         (WTR::TestRunner::TestRunner):
1315         (WTR::TestRunner::waitUntilDone):
1316         (WTR::TestRunner::setWaitUntilDone):
1317         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1318         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1319         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1320         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1321         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1322         * WebKitTestRunner/TestInvocation.cpp:
1323         (WTR::TestInvocation::TestInvocation):
1324         (WTR::TestInvocation::createTestSettingsDictionary):
1325         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1326         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1327         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1328         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1329         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1330         (WTR::TestInvocation::setWaitUntilDone):
1331         (WTR::TestInvocation::done):
1332         * WebKitTestRunner/TestInvocation.h:
1333
1334 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1335
1336         [JSC] linkPolymorphicCall now does GC
1337         https://bugs.webkit.org/show_bug.cgi?id=197306
1338
1339         Reviewed by Saam Barati.
1340
1341         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1342         To add this test, we add `runWithoutBaseOption`.
1343
1344         * Scripts/run-jsc-stress-tests:
1345
1346 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1347
1348         Update inactive reviewers' status to 'contributor'.
1349
1350         Accidentally skipped one at first.
1351
1352         * Scripts/webkitpy/common/config/contributors.json:
1353
1354 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1355
1356         Update inactive reviewers' status to 'contributor'.
1357
1358         * Scripts/webkitpy/common/config/contributors.json: The change.
1359
1360         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1361         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1362         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1363         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1364         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1365         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1366         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1367         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1368         Sadly, regression tests operate on a crazy mix of mock and live data for
1369         contributors.json. It would be a substantial project to mock all code paths,
1370         so changing the tests instead.
1371
1372 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1373
1374         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1375         https://bugs.webkit.org/show_bug.cgi?id=197171
1376         <rdar://problem/47454979>
1377
1378         Reviewed by Youenn Fablet.
1379
1380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1381         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1382         (TestWebKitAPI::TEST):
1383
1384 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1385
1386         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1387         <https://webkit.org/b/197314>
1388         <rdar://problem/50245252>
1389
1390         Reviewed by Simon Fraser.
1391
1392         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1393         (WTR::UIScriptController::lastUndoLabel const):
1394         (WTR::UIScriptController::firstRedoLabel const):
1395         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1396
1397         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1398         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1399         - Call -autorelease to fix leak of NSDictionary.
1400
1401         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1402         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1403         (WTR::UIScriptController::selectFormPopoverTitle const):
1404         (WTR::UIScriptController::textContentType const):
1405         (WTR::UIScriptController::formInputLabel const):
1406         (WTR::UIScriptController::scrollingTreeAsText const):
1407         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1408
1409 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1410
1411         webkitpy: Running a single test will always use the default device
1412         https://bugs.webkit.org/show_bug.cgi?id=195472
1413         <rdar://problem/48724825>
1414
1415         Reviewed by Lucas Forschler.
1416
1417         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1418         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1419         requested will be run regardless of what shard they are in.
1420
1421         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1422         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1423         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1424         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1425         on the default device type.
1426         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1427         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1428         (RunTest.test_run_part): Ditto.
1429
1430 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1431
1432         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1433         https://bugs.webkit.org/show_bug.cgi?id=197165
1434
1435         Reviewed by Youenn Fablet.
1436
1437         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1438
1439 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1440
1441         Replace iOS build queue hardware
1442         https://bugs.webkit.org/show_bug.cgi?id=197312
1443
1444         Reviewed by Aakash Jain.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/config.json:
1447         Use newer hardware that supports macOS Mojave.
1448
1449 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1450
1451         check-webkit-style complains the first block in while loop.
1452         https://bugs.webkit.org/show_bug.cgi?id=197307
1453
1454         The style checker shouldn't complain about an open brace on
1455         its own line if the last non-whitespace character on the previous
1456         non-blank line is another open brace, because it's likely to
1457         indicate the begining of a nested code block.
1458
1459         Reviewed by Alex Christensen.
1460
1461         * Scripts/webkitpy/style/checkers/cpp.py:
1462         (check_braces):
1463         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1464         (WebKitStyleTest.test_braces):
1465
1466 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1467
1468         Stop IDB transactions to release locked database files when network process is ready to suspend
1469         https://bugs.webkit.org/show_bug.cgi?id=196372
1470         <rdar://problem/48930116>
1471
1472         Reviewed by Brady Eidson.
1473
1474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1475         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1476         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1477         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1478         (runTestAndCheckResult):
1479         (keepNetworkProcessActive):
1480         (TEST):
1481
1482 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1483
1484         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1485         https://bugs.webkit.org/show_bug.cgi?id=188357
1486         <rdar://problem/42986633>
1487
1488         Reviewed by Dean Jackson.
1489
1490         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1491         tests would fall into low memory mode and have different behavior.
1492         
1493         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1494         to Internals, so it's shared by DRT and WTR.
1495         
1496         We no longer need the WK2 C SPI glue.
1497
1498         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1499         (WTR::InjectedBundlePage::prepare):
1500
1501 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1502
1503         webkitpy: Including skipped tests in the final count
1504         https://bugs.webkit.org/show_bug.cgi?id=197298
1505         <rdar://problem/49705424>
1506
1507         Reviewed by Lucas Forschler.
1508
1509         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1510         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1511
1512 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1513
1514         Disable date and time inputs on iOSMac.
1515         https://bugs.webkit.org/show_bug.cgi?id=197287
1516         rdar://problem/46794376
1517
1518         Reviewed by Wenson Hsieh.
1519
1520         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1521
1522 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1523
1524         Fix test-webkitpy after r244653
1525         https://bugs.webkit.org/show_bug.cgi?id=197131
1526
1527         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1528         Also use C++17.
1529
1530 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1531
1532         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1533         https://bugs.webkit.org/show_bug.cgi?id=196991
1534         <rdar://problem/45507423>
1535
1536         Reviewed by Alex Christensen.
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1539         (-[NavigationTestDelegate init]):
1540         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1541         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1542         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1543         (TestWebKitAPI::TEST):
1544         (TEST): Deleted.
1545
1546 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1547
1548         Revert some code accidentally committed with r244653
1549         https://bugs.webkit.org/show_bug.cgi?id=197131
1550
1551         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1552         (TestWebKitAPI::TEST):
1553
1554 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1555
1556         Start using C++17
1557         https://bugs.webkit.org/show_bug.cgi?id=197131
1558
1559         Reviewed by Darin Adler.
1560
1561         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1562         * MiniBrowser/Configurations/Base.xcconfig:
1563         * MobileMiniBrowser/Configurations/Base.xcconfig:
1564         * TestWebKitAPI/Configurations/Base.xcconfig:
1565         * WebKitTestRunner/Configurations/Base.xcconfig:
1566
1567 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1568
1569         Unreviewed, rolling out r244627.
1570         https://bugs.webkit.org/show_bug.cgi?id=197282
1571
1572         Causing internal build failures (Requested by ShawnRoberts on
1573         #webkit).
1574
1575         Reverted changeset:
1576
1577         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1578         https://bugs.webkit.org/show_bug.cgi?id=197171
1579         https://trac.webkit.org/changeset/244627
1580
1581 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1582
1583         [GTK] Hardcoded text color in input fields
1584         https://bugs.webkit.org/show_bug.cgi?id=126907
1585
1586         Reviewed by Michael Catanzaro.
1587
1588         Add dark-mode command line option to MiniBrowser.
1589
1590         * MiniBrowser/gtk/main.c:
1591         (main):
1592
1593 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1594
1595         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1596         https://bugs.webkit.org/show_bug.cgi?id=196948
1597         <rdar://problem/49927131>
1598
1599         Reviewed by Tim Horton.
1600
1601         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1602         (TEST):
1603         The expected order of incoming events is
1604         1. didInvalidateIntrinsicContentSize
1605         2. didFirstLayout
1606         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1607         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1608         (and remember, all we care about is ordering).
1609
1610 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1611
1612         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1613         https://bugs.webkit.org/show_bug.cgi?id=197171
1614         <rdar://problem/47454979>
1615
1616         Reviewed by Youenn Fablet.
1617
1618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1619         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1620         (TestWebKitAPI::TEST):
1621
1622 2019-04-24  Brady Eidson  <beidson@apple.com>
1623
1624         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1625         https://bugs.webkit.org/show_bug.cgi?id=191362
1626
1627         Reviewed by Alex Christensen.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1630           from an XHR to a custom protocol.
1631
1632 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1633
1634         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1635         https://bugs.webkit.org/show_bug.cgi?id=197273
1636
1637         Reviewed by Dean Jackson.
1638
1639         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1640         so that WebCoreTestSupport::resetInternalsObject() is always run.
1641
1642         * DumpRenderTree/mac/DumpRenderTree.mm:
1643         (resetWebViewToConsistentStateBeforeTesting):
1644         (runTest):
1645
1646 2019-04-24  John Wilander  <wilander@apple.com>
1647
1648         Age out unconverted Ad Click Attributions after one week.
1649         https://bugs.webkit.org/show_bug.cgi?id=197238
1650         <rdar://problem/50177349>
1651
1652         Reviewed by Chris Dumez.
1653
1654         This patch adds infrastructure to allow tests to expire all unconverted
1655         attributions early.
1656
1657         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1658         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1659         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1660         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1661         * WebKitTestRunner/TestController.cpp:
1662         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1663         * WebKitTestRunner/TestController.h:
1664         * WebKitTestRunner/TestInvocation.cpp:
1665         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1666
1667 2019-04-24  Chris Dumez  <cdumez@apple.com>
1668
1669         Fix flaky crashes in a couple of PSON API tests
1670         https://bugs.webkit.org/show_bug.cgi?id=197239
1671
1672         Reviewed by Tim Horton.
1673
1674         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1675
1676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1677
1678 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1679
1680         Make it possible to control the renderTreeAsText output by setting options on testRunner
1681         https://bugs.webkit.org/show_bug.cgi?id=197133
1682
1683         Reviewed by Sam Weinig.
1684
1685         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1686         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1687         these flags through the various framework layers.
1688
1689         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1690
1691         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1692         and hand-code DumpRenderTree bindings.
1693
1694         Some cleanup of the TestRunners, using member initializers.
1695
1696         * DumpRenderTree/TestRunner.cpp:
1697         (TestRunner::TestRunner):
1698         (setRenderTreeDumpOptionsCallback):
1699         (TestRunner::staticFunctions):
1700         (TestRunner::setRenderTreeDumpOptions):
1701         * DumpRenderTree/TestRunner.h:
1702         (TestRunner::renderTreeDumpOptions const):
1703         * DumpRenderTree/mac/DumpRenderTree.mm:
1704         (dump):
1705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1706         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1707         (WTR::InjectedBundlePage::dump):
1708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1709         (WTR::TestRunner::TestRunner):
1710         (WTR::TestRunner::setRenderTreeDumpOptions):
1711         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1712         (WTR::TestRunner::renderTreeDumpOptions const):
1713
1714 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1715
1716         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1717         https://bugs.webkit.org/show_bug.cgi?id=197078
1718         <rdar://problem/49564348>
1719
1720         Reviewed by Geoff Garen.
1721
1722         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1723         (TEST_F):
1724         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1725         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1726         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1727
1728 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1729
1730         Add unit test for r239322
1731         https://bugs.webkit.org/show_bug.cgi?id=197236
1732
1733         Reviewed by Chris Dumez.
1734
1735         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1736         May as well add the test infrastructure which was needed before and will be needed in the future.
1737
1738         * TestWebKitAPI/TCPServer.cpp:
1739         (TestWebKitAPI::TCPServer::TCPServer):
1740         * TestWebKitAPI/TCPServer.h:
1741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1742         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1743         (TestWebKitAPI::TEST):
1744         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1745         (TestWebKitAPI::downloadAtRate):
1746         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1747         (TEST):
1748         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1749         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1750         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1751         (TestWebKitAPI::TEST):
1752         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1753         (TEST):
1754
1755 2019-04-24  Chris Dumez  <cdumez@apple.com>
1756
1757         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1758         https://bugs.webkit.org/show_bug.cgi?id=197214
1759         <rdar://problem/49237544>
1760
1761         Reviewed by Alex Christensen.
1762
1763         Extend API test coverage.
1764
1765         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1766         (TEST):
1767
1768 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1769
1770         [Build][GStreamer] Update to 1.16.0
1771         https://bugs.webkit.org/show_bug.cgi?id=197157
1772
1773         Reviewed by Xabier Rodriguez-Calvar.
1774
1775         The upstreamed patches were removed and a new one was added for a
1776         regression detected in the scaletempo GStreamer element. The GNOME
1777         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1778         on the way, as it is the preferred build system now in GStreamer
1779         1.16.
1780
1781         * flatpak/files/httpd-autogen.sh:
1782         * flatpak/flatpakutils.py:
1783         (FlatpakPackage.install):
1784         (WebkitFlatpak.run_in_sandbox):
1785         * flatpak/org.webkit.CommonModules.yaml:
1786         * flatpak/org.webkit.WebKit.yaml:
1787         * gstreamer/jhbuild.modules:
1788         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1789         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1790         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1791         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1792         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1793         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1794         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1795         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1796         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1797         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1798         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1799         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1800         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1801         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1802         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1803         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1804         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1805         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1806         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1807         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1808         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1809         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1810
1811 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1814         https://bugs.webkit.org/show_bug.cgi?id=197156
1815
1816         Reviewed by Michael Catanzaro.
1817
1818         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1819         support was added.
1820
1821         * MiniBrowser/gtk/BrowserTab.c:
1822         (browser_tab_set_background_color): Set the passed in color as web view background color.
1823         * MiniBrowser/gtk/BrowserTab.h:
1824         * MiniBrowser/gtk/BrowserWindow.c:
1825         (browser_window_init): Initialize backgroundColor.
1826         (browser_window_append_view): Call browser_tab_set_background_color().
1827         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1828         are added.
1829         * MiniBrowser/gtk/main.c:
1830         (main): Call browser_window_set_background_color() before creating the tabs.
1831
1832 2019-04-23  John Wilander  <wilander@apple.com>
1833
1834         Move Ad Click Attribution from internal feature to experimental feature
1835         https://bugs.webkit.org/show_bug.cgi?id=197218
1836         <rdar://problem/47651691>
1837
1838         Reviewed by Brent Fulgham.
1839
1840         * DumpRenderTree/TestOptions.cpp:
1841         (TestOptions::TestOptions):
1842
1843 2019-04-23  Andy Estes  <aestes@apple.com>
1844
1845         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1846         https://bugs.webkit.org/show_bug.cgi?id=196749
1847         <rdar://problem/35773454>
1848
1849         Reviewed by Daniel Bates.
1850
1851         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1852
1853         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1854         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1855         (-[QuickLookDelegate webView:didFinishNavigation:]):
1856         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1857         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1858         (runTest):
1859         (runTestDecideBeforeLoading):
1860         (runTestDecideAfterLoading):
1861         (TEST):
1862
1863 2019-04-23  John Wilander  <wilander@apple.com>
1864
1865         Remove Ad Click Attribution data when removing website data
1866         https://bugs.webkit.org/show_bug.cgi?id=197215
1867         <rdar://problem/47668988>
1868
1869         Reviewed by Chris Dumez.
1870
1871         This patch adds test infrastructure to delete Ad Click Attribution data
1872         through WebsiteDataStore::removeData().
1873
1874         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1875         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1876         (WTR::TestRunner::clearAdClickAttribution):
1877         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1878         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1879         * WebKitTestRunner/TestController.cpp:
1880         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1881         * WebKitTestRunner/TestController.h:
1882         * WebKitTestRunner/TestInvocation.cpp:
1883         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1884
1885 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1886
1887         webkitpy: Kill unresponsive worker processes
1888         https://bugs.webkit.org/show_bug.cgi?id=197205
1889         <rdar://problem/50104388>
1890
1891         Reviewed by Lucas Forschler.
1892
1893         * Scripts/webkitpy/common/message_pool.py:
1894         (_MessagePool.__init__): Add close timeout.
1895         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1896
1897 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1898
1899         Add unit tests for WKWebView.serverTrust
1900         https://bugs.webkit.org/show_bug.cgi?id=197202
1901
1902         Reviewed by Youenn Fablet
1903
1904         * TestWebKitAPI/TCPServer.cpp:
1905         (TestWebKitAPI::deleter<BIO>::operator()):
1906         (TestWebKitAPI::deleter<SSL>::operator()):
1907         (TestWebKitAPI::deleter<X509>::operator()):
1908         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1909         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1910         (TestWebKitAPI::TCPServer::TCPServer):
1911         (TestWebKitAPI::TCPServer::listenForConnections):
1912         * TestWebKitAPI/TCPServer.h:
1913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1914         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1915         (TestWebKitAPI::TEST):
1916         (verifyCertificateAndPublicKey):
1917         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1918         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1919         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1920         (TestWebKitAPI::downloadAtRate):
1921         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1922         (TEST):
1923         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1924         (TEST):
1925
1926 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1927
1928         Unreviewed, rolling out r244556.
1929         https://bugs.webkit.org/show_bug.cgi?id=197212
1930
1931         Causing build failures on multiple builders (Requested by
1932         ShawnRoberts on #webkit).
1933
1934         Reverted changeset:
1935
1936         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1937         https://bugs.webkit.org/show_bug.cgi?id=197171
1938         https://trac.webkit.org/changeset/244556
1939
1940 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1941
1942         Fix iOS build.
1943         https://bugs.webkit.org/show_bug.cgi?id=195537
1944
1945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1946         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1947         AdoptWK constructor is private now.  Use adoptWK instead.
1948
1949 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1950
1951         Accessibility text search and selection API enhancements.
1952         https://bugs.webkit.org/show_bug.cgi?id=197095
1953         <rdar://problem/48181791>
1954
1955         Reviewed by Chris Fleizach.
1956
1957         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1958
1959         * DumpRenderTree/AccessibilityTextMarker.h:
1960         * DumpRenderTree/AccessibilityUIElement.cpp:
1961         (searchTextWithCriteriaCallback):
1962         (AccessibilityUIElement::getJSClass):
1963         * DumpRenderTree/AccessibilityUIElement.h:
1964         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1965         (convertVectorToObjectArray):
1966         (convertNSArrayToVector):
1967         (searchTextParameterizedAttributeForCriteria):
1968         (AccessibilityUIElement::getLinkedUIElements):
1969         (AccessibilityUIElement::getDocumentLinks):
1970         (AccessibilityUIElement::getChildren):
1971         (AccessibilityUIElement::getChildrenWithRange):
1972         (AccessibilityUIElement::rowHeaders const):
1973         (AccessibilityUIElement::columnHeaders const):
1974         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1975         (AccessibilityUIElement::searchTextWithCriteria):
1976         (AccessibilityUIElement::attributesOfColumnHeaders):
1977         (AccessibilityUIElement::attributesOfRowHeaders):
1978         (AccessibilityUIElement::attributesOfColumns):
1979         (AccessibilityUIElement::attributesOfRows):
1980         (AccessibilityUIElement::attributesOfVisibleCells):
1981         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1982         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1983         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1984         (WTR::convertVectorToObjectArray):
1985         (WTR::convertNSArrayToVector):
1986         (WTR::searchTextParameterizedAttributeForCriteria):
1987         (WTR::AccessibilityUIElement::getLinkedUIElements):
1988         (WTR::AccessibilityUIElement::getDocumentLinks):
1989         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1990         (WTR::AccessibilityUIElement::getChildren):
1991         (WTR::AccessibilityUIElement::getChildrenWithRange):
1992         (WTR::AccessibilityUIElement::rowHeaders const):
1993         (WTR::AccessibilityUIElement::columnHeaders const):
1994         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1995         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1996         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1997         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1998         (WTR::AccessibilityUIElement::attributesOfColumns):
1999         (WTR::AccessibilityUIElement::attributesOfRows):
2000         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2001         (WTR::convertElementsToObjectArray): Deleted.
2002
2003 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2004
2005         Multiple File Input Icon Set Regardless of File List
2006         https://bugs.webkit.org/show_bug.cgi?id=195537
2007
2008         Reviewed by Alexey Proskuryakov.
2009
2010         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2011         display string in iOS file inputs
2012
2013         * DumpRenderTree/TestRunner.cpp:
2014         (SetOpenPanelFilesMediaIconCallback):
2015         (TestRunner::staticFunctions):
2016         (TestRunner::setOpenPanelFilesMediaIcon):
2017         * DumpRenderTree/TestRunner.h:
2018         (TestRunner::openPanelFilesMediaIcon const):
2019         * DumpRenderTree/mac/UIDelegate.mm:
2020         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2021         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2022         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2023         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2024         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2025         * WebKitTestRunner/TestController.cpp:
2026         (WTR::runOpenPanel):
2027         (WTR::TestController::resetStateToConsistentValues):
2028         * WebKitTestRunner/TestController.h:
2029         (WTR::TestController::openPanelFileURLsMediaIcon const):
2030         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2031         * WebKitTestRunner/TestInvocation.cpp:
2032         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2033
2034 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2035
2036         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2037         https://bugs.webkit.org/show_bug.cgi?id=197171
2038         <rdar://problem/47454979>
2039
2040         Reviewed by Youenn Fablet.
2041
2042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2043         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2044         (TestWebKitAPI::TEST):
2045
2046 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2047
2048         [ews-build] Add unit tests for UnApplyPatchIfRequired
2049         https://bugs.webkit.org/show_bug.cgi?id=197197
2050
2051         Reviewed by Lucas Forschler.
2052
2053         * BuildSlaveSupport/ews-build/steps_unittest.py:
2054         (TestUnApplyPatchIfRequired):
2055         (TestUnApplyPatchIfRequired.test_success):
2056         (TestUnApplyPatchIfRequired.test_failure):
2057         (TestUnApplyPatchIfRequired.test_skip):
2058
2059 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2060
2061         [ews-build] Add unit tests for CleanWorkingDirectory
2062         https://bugs.webkit.org/show_bug.cgi?id=197195
2063
2064         Reviewed by Lucas Forschler.
2065
2066         * BuildSlaveSupport/ews-build/steps_unittest.py:
2067         (TestCleanWorkingDirectory):
2068         (TestCleanWorkingDirectory.test_success):
2069         (TestCleanWorkingDirectory.test_failure):
2070
2071 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2072
2073         [ews-build] Use explicit imports instead of wildcard imports
2074         https://bugs.webkit.org/show_bug.cgi?id=197194
2075
2076         Reviewed by Lucas Forschler.
2077
2078         * BuildSlaveSupport/ews-build/factories.py:
2079         * BuildSlaveSupport/ews-build/loadConfig.py:
2080         * BuildSlaveSupport/ews-build/steps_unittest.py:
2081
2082 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2083
2084         [ews-build] Add unit tests for DownloadBuiltProduct
2085         https://bugs.webkit.org/show_bug.cgi?id=197193
2086
2087         Reviewed by Lucas Forschler.
2088
2089         * BuildSlaveSupport/ews-build/steps_unittest.py:
2090         (TestDownloadBuiltProduct):
2091         (TestDownloadBuiltProduct.setUp):
2092         (TestDownloadBuiltProduct.tearDown):
2093         (TestDownloadBuiltProduct.test_success):
2094         (TestDownloadBuiltProduct.test_failure):
2095
2096 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2097
2098         [ews-app] Exception while loading status-bubble when no build step has started
2099         https://bugs.webkit.org/show_bug.cgi?id=196676
2100
2101         Reviewed by Lucas Forschler.
2102
2103         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2104         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2105
2106 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2107
2108         [PlayStation] Support running of JSC tests on remote playstation devices
2109         https://bugs.webkit.org/show_bug.cgi?id=197170
2110
2111         Reviewed by Ross Kirsling.
2112
2113         Script changes
2114
2115         * Scripts/run-javascriptcore-tests:
2116         (runJSCStressTests): Pass arguments for playstation to
2117         run-jsc-stress-tests
2118         * Scripts/run-jsc-stress-tests:
2119         Handle $hostOS=="playstation" for determineArchitecture, turning
2120         off $isFTLPlatform and runProfiler and defaulting test writer.
2121         * Scripts/webkitdirs.pm:
2122         (jscPath): PlayStation WebKit executables have .elf extension
2123         (executableProductDir): PlayStation builds on Windows hosts but
2124         uses bin directory rather than bin64/bin32 for executable output
2125         location.
2126         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2127
2128 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2129
2130         [CMake][Win] Use target oriented design for WebKit
2131         https://bugs.webkit.org/show_bug.cgi?id=197173
2132
2133         Reviewed by Alex Christensen.
2134
2135         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2136         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2137
2138 2019-04-23  Chris Dumez  <cdumez@apple.com>
2139
2140         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2141         https://bugs.webkit.org/show_bug.cgi?id=197097
2142         <rdar://problem/50048318>
2143
2144         Reviewed by Alex Christensen.
2145
2146         Add API test coverage.
2147
2148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2149         (-[PSONScheme webView:startURLSchemeTask:]):
2150
2151 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2152
2153         [ATK] Implement AtkComponentIface scroll_to methods
2154         https://bugs.webkit.org/show_bug.cgi?id=196856
2155
2156         Reviewed by Michael Catanzaro.
2157
2158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2159         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2160         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2161         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2162
2163 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2164
2165         [ews-build] Improve summary for UploadBuiltProduct step
2166         https://bugs.webkit.org/show_bug.cgi?id=197182
2167
2168         Reviewed by Lucas Forschler.
2169
2170         * BuildSlaveSupport/ews-build/steps.py:
2171         (UploadBuiltProduct): Added descriptionDone.
2172         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2173         * BuildSlaveSupport/ews-build/steps_unittest.py:
2174         (TestUploadBuiltProduct.test_success): Updated unit-test.
2175         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2176
2177 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2178
2179         [ews-build] Trigger queues only after uploading the archive
2180         https://bugs.webkit.org/show_bug.cgi?id=197180
2181
2182         Reviewed by Lucas Forschler.
2183
2184         * BuildSlaveSupport/ews-build/factories.py:
2185         (Factory.__init__):
2186         (BuildFactory.__init__): Remove trigger step from factories.
2187         (BuildFactory.propertiesToPassToTriggers): Deleted.
2188         * BuildSlaveSupport/ews-build/steps.py:
2189         (ConfigureBuild.__init__): Confiure triggers property.
2190         (Trigger): Step to trigger other queues.
2191         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2192         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2193
2194 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2195
2196         Deprecate WKContextCreateWithInjectedBundlePath
2197         https://bugs.webkit.org/show_bug.cgi?id=197169
2198
2199         Reviewed by Youenn Fablet.
2200
2201         * TestWebKitAPI/PlatformUtilities.cpp:
2202         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2203         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2204
2205 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2206
2207         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2208         https://bugs.webkit.org/show_bug.cgi?id=197093
2209         <rdar://problem/49708268>
2210
2211         Reviewed by Chris Dumez.
2212
2213         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2214         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2215         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2216         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2217         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2218
2219         * TestWebKitAPI/TCPServer.cpp:
2220         (TestWebKitAPI::TCPServer::TCPServer):
2221         (TestWebKitAPI::TCPServer::~TCPServer):
2222         (TestWebKitAPI::TCPServer::socketBindListen):
2223         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2224         * TestWebKitAPI/TCPServer.h:
2225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2226         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2227         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2228         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2229         (respondWithChallengeThenOK):
2230         (TestWebKitAPI::TEST):
2231         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2232         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2233         (TEST):
2234
2235 2019-04-22  Chris Dumez  <cdumez@apple.com>
2236
2237         Delayed WebProcessLaunch may break the _relatedWebView SPI
2238         https://bugs.webkit.org/show_bug.cgi?id=197160
2239
2240         Reviewed by Alex Christensen.
2241
2242         Add API test coverage.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2245
2246 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2247
2248         Use curl to download packages for webkitpy autoinstaller
2249         https://bugs.webkit.org/show_bug.cgi?id=197164
2250
2251         Reviewed by Darin Adler.
2252
2253         * Scripts/webkitpy/common/system/autoinstall.py:
2254         (AutoInstaller._download): Use curl(1) to download packages necessary for
2255         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2256         errors which are not present when using curl(1).
2257
2258 2019-04-22  Chris Dumez  <cdumez@apple.com>
2259
2260         Unreviewed, rolling out r244502.
2261
2262         Caused crashes on the bots
2263
2264         Reverted changeset:
2265
2266         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2267         https://bugs.webkit.org/show_bug.cgi?id=197160
2268         https://trac.webkit.org/changeset/244502
2269
2270 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2271
2272         Unreviewed, rolling out r244437.
2273
2274         Still breaks internal tests.
2275
2276         Reverted changeset:
2277
2278         "InjectedBundle parameters often need initialization function
2279         called before unarchiving"
2280         https://bugs.webkit.org/show_bug.cgi?id=189709
2281         https://trac.webkit.org/changeset/244437
2282
2283 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2284
2285         [ews-build] Use singular verb in failure description in case of single api test failure
2286         https://bugs.webkit.org/show_bug.cgi?id=197013
2287
2288         Reviewed by Lucas Forschler.
2289
2290         * BuildSlaveSupport/ews-build/steps.py:
2291         (AnalyzeAPITestsResults.analyzeResults):
2292
2293 2019-04-22  Chris Dumez  <cdumez@apple.com>
2294
2295         Delayed WebProcessLaunch may break the _relatedWebView SPI
2296         https://bugs.webkit.org/show_bug.cgi?id=197160
2297
2298         Reviewed by Alex Christensen.
2299
2300         Add API test coverage.
2301
2302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2303
2304 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2305
2306         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2307         https://bugs.webkit.org/show_bug.cgi?id=194630
2308
2309         Reviewed by Michael Catanzaro.
2310
2311         Return early from getAttributeSet() is passed in accessible is nullptr.
2312
2313         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2314
2315 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2316
2317         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2318         https://bugs.webkit.org/show_bug.cgi?id=197145
2319         <rdar://problem/50078170>
2320
2321         Reviewed by Darin Adler.
2322
2323         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2324         focus, or showing the font manager.
2325
2326         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2327         (TestWebKitAPI::TEST):
2328         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2329         (TEST):
2330         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2331         (TestWebKitAPI::TEST):
2332
2333 2019-04-21  Brian Burg  <bburg@apple.com>
2334
2335         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2336         https://bugs.webkit.org/show_bug.cgi?id=197125
2337         <rdar://problem/50061468>
2338
2339         Reviewed by Darin Adler.
2340
2341         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2342         using this class rather than making our own ./wpt serve invocation.
2343
2344         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2345         (WebDriverW3CWebServer):
2346         (WebDriverW3CWebServer.document_root): Expose this to clients.
2347         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2348
2349         (WebDriverW3CWebServer.__enter__):
2350         (WebDriverW3CWebServer.__exit__):
2351         Make it possible to use the web server with a 'with' statement.
2352
2353 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2354
2355         [CMake][Win] Use target oriented design for WebKitLegacy
2356         https://bugs.webkit.org/show_bug.cgi?id=197112
2357
2358         Reviewed by Konstantin Tokarev.
2359
2360         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2361
2362         * DumpRenderTree/CMakeLists.txt:
2363         * DumpRenderTree/PlatformWin.cmake:
2364         * DumpRenderTree/win/EventSender.cpp:
2365
2366 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2367
2368         Update text for old EWS submit button
2369         https://bugs.webkit.org/show_bug.cgi?id=197140
2370
2371         Reviewed by Alexey Proskuryakov.
2372
2373         * QueueStatusServer/templates/statusbubble.html:
2374
2375 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2376
2377         [ews-app] New EWS should poll bugzilla more frequently
2378         https://bugs.webkit.org/show_bug.cgi?id=197138
2379
2380         Reviewed by Alexey Proskuryakov.
2381
2382         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2383         (FetchLoop.__init__):
2384
2385 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2386
2387         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2388         https://bugs.webkit.org/show_bug.cgi?id=197139
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2393         * QueueStatusServer/templates/statusbubble.html:
2394
2395 2019-04-20  Chris Dumez  <cdumez@apple.com>
2396
2397         Unreviewed, fix iOS build with recent SDKs.
2398
2399         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2400
2401 2019-04-19  Keith Miller  <keith_miller@apple.com>
2402
2403         Add script to merge run_benchmark jsons
2404         https://bugs.webkit.org/show_bug.cgi?id=197107
2405
2406         Reviewed by Michael Saboff.
2407
2408         The script basically recursively decends through all json objects until it gets
2409         to an array or JSON primitive and concats or takes the first value, respectively.
2410
2411         This patch also adds +x bits to the compare-results script so it
2412         can be run directly from the command line. I had to add a new line so that svn
2413         will accept the change... yay svn!
2414
2415         * Scripts/compare-results:
2416         * Scripts/merge-result-jsons: Added.
2417         (readJSONFile):
2418         (deepAppend):
2419         (mergeJSONs):
2420         (main):
2421
2422 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2423
2424         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2425         https://bugs.webkit.org/show_bug.cgi?id=197079
2426
2427         Reviewed by Darin Adler.
2428
2429         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2433
2434 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2435
2436         Unreviewed, rolling out r244434.
2437         https://bugs.webkit.org/show_bug.cgi?id=197089
2438
2439         caused 1 API test failure (Requested by zalan on #webkit).
2440
2441         Reverted changeset:
2442
2443         "Regression (r244291): Broken API Test
2444         AutoLayoutRenderingProgressRelativeOrdering"
2445         https://bugs.webkit.org/show_bug.cgi?id=196948
2446         https://trac.webkit.org/changeset/244434
2447
2448 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2449
2450         Add new compatibility mode API on WKNavigation
2451         https://bugs.webkit.org/show_bug.cgi?id=197069
2452         <rdar://problem/50025800>
2453
2454         Reviewed by Tim Horton.
2455
2456         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2457
2458         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2459         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2460         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2461
2462 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2463
2464         [CMake] Make WebCore headers copies
2465         https://bugs.webkit.org/show_bug.cgi?id=182512
2466         <rdar://problem/37510435>
2467
2468         Reviewed by Alex Christensen.
2469
2470         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2471         ports.
2472
2473         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2474         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2475
2476         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2477         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2478         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2479         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2480         * TestWebKitAPI/CMakeLists.txt:
2481         * TestWebKitAPI/PlatformWin.cmake:
2482         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2483         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2484         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2485
2486 2019-04-18  Jer Noble  <jer.noble@apple.com>
2487
2488         Add support for parsing FairPlayStreaming PSSH boxes.
2489         https://bugs.webkit.org/show_bug.cgi?id=197064
2490
2491         Reviewed by Eric Carlson.
2492
2493         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2494         (TestWebKitAPI::TEST):
2495
2496 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2497
2498         InjectedBundle parameters often need initialization function called before unarchiving
2499         https://bugs.webkit.org/show_bug.cgi?id=189709
2500         <rdar://problem/44573653>
2501
2502         Reviewed by Ryosuke Niwa.
2503
2504         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2505         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2506
2507 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2508
2509         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2510         https://bugs.webkit.org/show_bug.cgi?id=196948
2511         <rdar://problem/49927131>
2512
2513         Reviewed by Tim Horton.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2516         (TEST): 
2517         The expected order of incoming events is
2518         1. didInvalidateIntrinsicContentSize
2519         2. didFirstLayout
2520         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2521         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2522         (and remember, all we care about is ordering).
2523
2524 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2525
2526         Unreviewed, rolling out r244299.
2527
2528         Breaks internal tests.
2529
2530         Reverted changeset:
2531
2532         "InjectedBundle parameters often need initialization function
2533         called before unarchiving"
2534         https://bugs.webkit.org/show_bug.cgi?id=189709
2535         https://trac.webkit.org/changeset/244299
2536
2537 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2538
2539         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2540         https://bugs.webkit.org/show_bug.cgi?id=197053
2541
2542         Reviewed by Saam Barati.
2543
2544         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2545         (TestWebKitAPI::TEST):
2546
2547 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2548
2549         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2550         https://bugs.webkit.org/show_bug.cgi?id=197028
2551         <rdar://problem/49985290>
2552
2553         Reviewed by Wenson Hsieh.
2554
2555         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2556         (TEST):
2557         Liberal application of waitForNextPresentationUpdate works around a race
2558         where if the page rapidly changes its viewport arguments (or an API client
2559         rapidly changes its viewport arguments), we'd get stuck thinking that the
2560         user had intentionally zoomed the page, and stop resetting the initial scale.
2561         This deserves a separate bug, but no need to keep the test failing while
2562         we think about it.
2563
2564 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2565
2566         REGRESSION (r241988): Switching tabs is slow
2567         https://bugs.webkit.org/show_bug.cgi?id=197037
2568         <rdar://problem/49951473>
2569
2570         Reviewed by Simon Fraser.
2571
2572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2573         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2574         (TEST):
2575         * TestWebKitAPI/cocoa/TestWKWebView.h:
2576         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2577         (-[TestWKWebView addToTestWindow]):
2578         Add a test that hangs without this fix.
2579
2580 2019-04-17  Truitt Savell  <tsavell@apple.com>
2581
2582         Unreviewed, rolling out r244400.
2583
2584         Caused testing to exit early with assertionon Debug WK2
2585
2586         Reverted changeset:
2587
2588         "UI↔Web deadlock when printing with a JavaScript alert
2589         visible"
2590         https://bugs.webkit.org/show_bug.cgi?id=196839
2591         https://trac.webkit.org/changeset/244400
2592
2593 2019-04-17  Brady Eidson  <beidson@apple.com>
2594
2595         Link clicks in PDFs shouldn't send referrer headers.
2596         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2597
2598         Reviewed by Tim Horton.
2599
2600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2601         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2602         (putPDFBytesCallback):
2603         (emptyReleaseInfoCallback):
2604         (createPDFWithLinkToURL):
2605         (TEST):
2606
2607 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2608
2609         UI↔Web deadlock when printing with a JavaScript alert visible
2610         https://bugs.webkit.org/show_bug.cgi?id=196839
2611         <rdar://problem/49157642>
2612
2613         Reviewed by Andy Estes.
2614
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2617         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2618         (TEST):
2619
2620 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2621
2622         WKRetainPtr's adoption constructor should be private
2623         https://bugs.webkit.org/show_bug.cgi?id=197019
2624
2625         Reviewed by Tim Horton.
2626
2627         * DumpRenderTree/mac/DumpRenderTree.mm:
2628         (dumpFramesAsText):
2629         * TestWebKitAPI/InjectedBundleController.cpp:
2630         (TestWebKitAPI::InjectedBundleController::initialize):
2631         * TestWebKitAPI/PlatformUtilities.cpp:
2632         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2633         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2634         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2635         (TestWebKitAPI::Util::toWK):
2636         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2637         (TestWebKitAPI::TEST):
2638         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2639         (TestWebKitAPI::TEST):
2640         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2641         (TestWebKitAPI::TEST):
2642         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2643         (TestWebKitAPI::TEST):
2644         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2645         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2646         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2647         (TestWebKitAPI::TEST):
2648         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2649         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2650         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2651         (TestWebKitAPI::TEST):
2652         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2653         (TestWebKitAPI::TEST):
2654         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2655         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2656         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2657         (TestWebKitAPI::TEST):
2658         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2659         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2660         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2661         (TestWebKitAPI::TEST):
2662         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2663         (TestWebKitAPI::TEST):
2664         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2665         (TestWebKitAPI::TEST):
2666         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2667         (TestWebKitAPI::TEST):
2668         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2669         (TestWebKitAPI::TEST):
2670         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2671         (TestWebKitAPI::TEST):
2672         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2673         (TestWebKitAPI::TEST):
2674         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2675         (TestWebKitAPI::TEST):
2676         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2677         (TestWebKitAPI::TEST):
2678         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2679         (TestWebKitAPI::TEST):
2680         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2681         (TestWebKitAPI::TEST):
2682         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2683         (TestWebKitAPI::TEST):
2684         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2685         (TestWebKitAPI::TEST):
2686         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2687         (TestWebKitAPI::TEST):
2688         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2689         (TestWebKitAPI::TEST):
2690         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2691         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2692         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2693         (TestWebKitAPI::TEST):
2694         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2697         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2698         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2699         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2700         (TestWebKitAPI::TEST):
2701         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2702         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2703         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2704         (TestWebKitAPI::TEST):
2705         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2706         (TestWebKitAPI::TEST):
2707         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2708         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2709         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2710         (TestWebKitAPI::TEST):
2711         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2712         (TestWebKitAPI::loadAlternateHTMLString):
2713         (TestWebKitAPI::TEST):
2714         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2715         (TestWebKitAPI::TEST):
2716         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2717         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2718         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2719         (TestWebKitAPI::buildAndPerformTest):
2720         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2721         (TestWebKitAPI::TEST):
2722         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2723         (TestWebKitAPI::TEST):
2724         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2725         (TestWebKitAPI::TEST):
2726         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2727         (TestWebKitAPI::TEST):
2728         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2729         (TestWebKitAPI::TEST):
2730         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2731         (TestWebKitAPI::TEST):
2732         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2735         (TestWebKitAPI::TEST):
2736         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2737         (TestWebKitAPI::TEST):
2738         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2739         (TestWebKitAPI::TEST):
2740         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2741         (TestWebKitAPI::TEST):
2742         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2743         (TestWebKitAPI::TEST):
2744         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2747         (TestWebKitAPI::TEST):
2748         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2749         (TestWebKitAPI::TEST):
2750         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2751         (TestWebKitAPI::TEST):
2752         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2753         (TestWebKitAPI::TEST):
2754         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2755         (TestWebKitAPI::TEST):
2756         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2757         (TestWebKitAPI::TEST):
2758         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2759         (TestWebKitAPI::TEST):
2760         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2761         (TestWebKitAPI::TEST):
2762         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2763         (TestWebKitAPI::TEST):
2764         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2765         (TestWebKitAPI::TEST):
2766         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2767         (TestWebKitAPI::TEST):
2768         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2769         (TestWebKitAPI::TEST):
2770         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2771         (TestWebKitAPI::TEST):
2772         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2773         (TestWebKitAPI::TEST):
2774         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2775         (TestWebKitAPI::TEST):
2776         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2777         (TestWebKitAPI::TEST):
2778         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2779         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2780         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2781         (TestWebKitAPI::TEST):
2782         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2783         (TestWebKitAPI::TEST):
2784         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2785         (TestWebKitAPI::TEST):
2786         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2789         (TestWebKitAPI::TEST):
2790         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2791         (TestWebKitAPI::TEST):
2792         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2793         (TestWebKitAPI::TEST):
2794         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2795         (TestWebKitAPI::TEST):
2796         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2797         (TestWebKitAPI::TEST):
2798         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2799         (TestWebKitAPI::TEST):
2800         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2801         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2802         (TEST):
2803         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2804         (TEST):
2805         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2806         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2807         (TEST):
2808         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2809         (TestWebKitAPI::TEST):
2810         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2811         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2812         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2813         (WTR::getMenuItemTitleCallback):
2814         (WTR::createMouseMessageBody):
2815         (WTR::EventSendingController::mouseDown):
2816         (WTR::EventSendingController::mouseUp):
2817         (WTR::EventSendingController::mouseMoveTo):
2818         (WTR::EventSendingController::mouseForceClick):
2819         (WTR::EventSendingController::startAndCancelMouseForceClick):
2820         (WTR::EventSendingController::mouseForceDown):
2821         (WTR::EventSendingController::mouseForceUp):
2822         (WTR::EventSendingController::mouseForceChanged):
2823         (WTR::EventSendingController::leapForward):
2824         (WTR::EventSendingController::scheduleAsynchronousClick):
2825         (WTR::createKeyDownMessageBody):
2826         (WTR::EventSendingController::keyDown):
2827         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2828         (WTR::EventSendingController::mouseScrollBy):
2829         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2830         (WTR::EventSendingController::continuousMouseScrollBy):
2831         (WTR::EventSendingController::addTouchPoint):
2832         (WTR::EventSendingController::updateTouchPoint):
2833         (WTR::EventSendingController::setTouchModifier):
2834         (WTR::EventSendingController::setTouchPointRadius):
2835         (WTR::EventSendingController::touchStart):
2836         (WTR::EventSendingController::touchMove):
2837         (WTR::EventSendingController::touchEnd):
2838         (WTR::EventSendingController::touchCancel):
2839         (WTR::EventSendingController::clearTouchPoints):
2840         (WTR::EventSendingController::releaseTouchPoint):
2841         (WTR::EventSendingController::cancelTouchPoint):
2842         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2843         (WTR::InjectedBundle::didCreatePage):
2844         (WTR::InjectedBundle::didReceiveMessage):
2845         (WTR::InjectedBundle::didReceiveMessageToPage):
2846         (WTR::InjectedBundle::booleanForKey):
2847         (WTR::InjectedBundle::done):
2848         (WTR::InjectedBundle::dumpToStdErr):
2849         (WTR::InjectedBundle::outputText):
2850         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2851         (WTR::InjectedBundle::postAddChromeInputField):
2852         (WTR::InjectedBundle::postRemoveChromeInputField):
2853         (WTR::InjectedBundle::postFocusWebView):
2854         (WTR::InjectedBundle::postSetBackingScaleFactor):
2855         (WTR::InjectedBundle::postSetWindowIsKey):
2856         (WTR::InjectedBundle::postSetViewSize):
2857         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2858         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2859         (WTR::InjectedBundle::setGeolocationPermission):
2860         (WTR::InjectedBundle::setMockGeolocationPosition):
2861         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2862         (WTR::InjectedBundle::isGeolocationProviderActive const):
2863         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2864         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2865         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2866         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2867         (WTR::InjectedBundle::setCustomPolicyDelegate):
2868         (WTR::InjectedBundle::setHidden):
2869         (WTR::InjectedBundle::setCacheModel):
2870         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2871         (WTR::InjectedBundle::processWorkQueue):
2872         (WTR::InjectedBundle::queueBackNavigation):
2873         (WTR::InjectedBundle::queueForwardNavigation):
2874         (WTR::InjectedBundle::queueLoad):
2875         (WTR::InjectedBundle::queueLoadHTMLString):
2876         (WTR::InjectedBundle::queueReload):
2877         (WTR::InjectedBundle::queueLoadingScript):
2878         (WTR::InjectedBundle::queueNonLoadingScript):
2879         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2880         (WTR::frameToStr):
2881         (WTR::InjectedBundlePage::InjectedBundlePage):
2882         (WTR::dumpFrameDescriptionSuitableForTestResult):
2883         (WTR::dumpFrameScrollPosition):
2884         (WTR::dumpDescendantFrameScrollPositions):
2885         (WTR::dumpFrameText):
2886         (WTR::dumpDescendantFramesText):
2887         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2888         (WTR::TestRunner::shouldDumpPixels const):
2889         (WTR::TestRunner::setDumpPixels):
2890         (WTR::TestRunner::whatToDump const):
2891         (WTR::TestRunner::setWhatToDump):
2892         (WTR::TestRunner::setWaitUntilDone):
2893         (WTR::TestRunner::shouldWaitUntilDone const):
2894         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2895         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2896         (WTR::TestRunner::clearAllDatabases):
2897         (WTR::TestRunner::setIDBPerOriginQuota):
2898         (WTR::TestRunner::originsWithApplicationCache):
2899         (WTR::TestRunner::setCanOpenWindows):
2900         (WTR::TestRunner::setXSSAuditorEnabled):
2901         (WTR::TestRunner::setMediaDevicesEnabled):
2902         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2903         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2904         (WTR::TestRunner::setCustomUserAgent):
2905         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2906         (WTR::TestRunner::setModernMediaControlsEnabled):
2907         (WTR::TestRunner::setWebGL2Enabled):
2908         (WTR::TestRunner::setWritableStreamAPIEnabled):
2909         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2910         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2911         (WTR::TestRunner::setAllowsAnySSLCertificate):
2912         (WTR::TestRunner::setPluginsEnabled):
2913         (WTR::TestRunner::setValueForUser):
2914         (WTR::TestRunner::setAudioResult):
2915         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2916         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2917         (WTR::TestRunner::setAlwaysAcceptCookies):
2918         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2919         (WTR::TestRunner::isDoingMediaCapture const):
2920         (WTR::TestRunner::queueLoad):
2921         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2922         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2923         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2924         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2925         (WTR::TestRunner::setAuthenticationUsername):
2926         (WTR::TestRunner::setAuthenticationPassword):
2927         (WTR::TestRunner::secureEventInputIsEnabled const):
2928         (WTR::TestRunner::setBlockAllPlugins):
2929         (WTR::TestRunner::setPluginSupportedMode):
2930         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2931         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2932         (WTR::TestRunner::setNavigationGesturesEnabled):
2933         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2934         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2935         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2936         (WTR::TestRunner::terminateNetworkProcess):
2937         (WTR::TestRunner::terminateServiceWorkerProcess):
2938         (WTR::TestRunner::runUIScript):
2939         (WTR::TestRunner::setStatisticsDebugMode):
2940         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2941         (WTR::TestRunner::setStatisticsLastSeen):
2942         (WTR::TestRunner::setStatisticsPrevalentResource):
2943         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2944         (WTR::TestRunner::dumpResourceLoadStatistics):
2945         (WTR::TestRunner::isStatisticsPrevalentResource):
2946         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2947         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2948         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2949         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2950         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2951         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2952         (WTR::TestRunner::setStatisticsGrandfathered):
2953         (WTR::TestRunner::isStatisticsGrandfathered):
2954         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2955         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2956         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2957         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2958         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2959         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2960         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2961         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2962         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2963         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2964         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2965         (WTR::TestRunner::statisticsSubmitTelemetry):
2966         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2967         (WTR::TestRunner::setStatisticsIsRunningTest):
2968         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2969         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2970         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2971         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2972         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2973         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2974         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2975         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2976         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2977         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2978         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2979         (WTR::TestRunner::statisticsResetToConsistentState):
2980         (WTR::TestRunner::setStorageAccessAPIEnabled):
2981         (WTR::TestRunner::getAllStorageAccessEntries):
2982         (WTR::TestRunner::addMockMediaDevice):
2983         (WTR::TestRunner::clearMockMediaDevices):
2984         (WTR::TestRunner::removeMockMediaDevice):
2985         (WTR::TestRunner::resetMockMediaDevices):
2986         (WTR::TestRunner::connectMockGamepad):
2987         (WTR::TestRunner::disconnectMockGamepad):
2988         (WTR::TestRunner::setMockGamepadDetails):
2989         (WTR::TestRunner::setMockGamepadAxisValue):
2990         (WTR::TestRunner::setMockGamepadButtonValue):
2991         (WTR::TestRunner::removeAllSessionCredentials):
2992         (WTR::TestRunner::clearDOMCache):
2993         (WTR::TestRunner::clearDOMCaches):
2994         (WTR::TestRunner::hasDOMCache):
2995         (WTR::TestRunner::domCacheSize):
2996         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2997         (WTR::TestRunner::getApplicationManifestThen):
2998         (WTR::TestRunner::injectUserScript):
2999         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3000         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3001         (WTR::TestRunner::addTestKeyToKeychain):
3002         (WTR::TestRunner::cleanUpKeychain):
3003         (WTR::TestRunner::keyExistsInKeychain):
3004         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3005         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3006         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3007         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3008         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3009         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3010         * WebKitTestRunner/TestController.cpp:
3011         (WTR::TestController::initialize):
3012         (WTR::parseStringTestHeaderValueAsRelativePath):
3013         (WTR::updateTestOptionsFromTestHeader):
3014         (WTR::TestController::runTest):
3015         (WTR::TestController::didReceiveLiveDocumentsList):
3016         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3017         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3018         (WTR::TestController::didFinishNavigation):
3019         (WTR::TestController::didReceiveAuthenticationChallenge):
3020         * WebKitTestRunner/TestInvocation.cpp:
3021         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3022         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3023         (WTR::TestInvocation::uiScriptDidComplete):
3024         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3025         * WebKitTestRunner/WebNotificationProvider.cpp:
3026         (WTR::WebNotificationProvider::closeWebNotification):
3027         * WebKitTestRunner/WorkQueueManager.cpp:
3028         (WTR::ScriptItem::ScriptItem):
3029         (WTR::WorkQueueManager::queueLoad):
3030         (WTR::WorkQueueManager::queueLoadHTMLString):
3031
3032 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3033
3034         Add a comment to make my test from r244139 less mysterious.
3035         https://bugs.webkit.org/show_bug.cgi?id=196744
3036
3037         As suggested by Darin Adler.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3040         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3041
3042 2019-04-17  Chris Dumez  <cdumez@apple.com>
3043
3044         Remember device orientation permission for the duration of the browsing session
3045         https://bugs.webkit.org/show_bug.cgi?id=196992
3046         <rdar://problem/49946067>
3047
3048         Reviewed by Alex Christensen.
3049
3050         Add API test coverage.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3053         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3054         (TEST):
3055
3056 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3057
3058         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3059         https://bugs.webkit.org/show_bug.cgi?id=196675
3060
3061         Reviewed by Lucas Forschler.
3062
3063         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3064         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3065
3066 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3067
3068         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3069         https://bugs.webkit.org/show_bug.cgi?id=196919
3070         <rdar://problem/41630459>
3071
3072         Reviewed by Tim Horton.
3073
3074         Add iOS support for several new testing hooks. See below for more detail.
3075
3076         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3077         (WTR::UIScriptController::isDismissingMenu const):
3078
3079         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3080         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3081         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3082
3083         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3084         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3085         (WTR::UIScriptController::isDismissingMenu const):
3086         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3087         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3088         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3089         (WTR::InjectedBundle::didReceiveMessageToPage):
3090         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3091         (WTR::TestRunner::setAllowedMenuActions):
3092
3093         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3094         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3095         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3096         against the name of the custom action.
3097
3098         (WTR::TestRunner::installCustomMenuAction):
3099
3100         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3101         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3102         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3103         triggered.
3104
3105         (WTR::TestRunner::performCustomMenuAction):
3106
3107         Invoked when the custom menu action is triggered.
3108
3109         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::TestController::installCustomMenuAction):
3112         (WTR::TestController::setAllowedMenuActions):
3113         * WebKitTestRunner/TestController.h:
3114         * WebKitTestRunner/TestInvocation.cpp:
3115         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3116         (WTR::TestInvocation::performCustomMenuAction):
3117
3118         Add plumbing to call back into the injected bundle when performing the custom action.
3119
3120         * WebKitTestRunner/TestInvocation.h:
3121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3122         (WTR::TestController::installCustomMenuAction):
3123         (WTR::TestController::setAllowedMenuActions):
3124         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3125         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3126         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3127         (-[TestRunnerWKWebView becomeFirstResponder]):
3128         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3129
3130         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3131         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3132         in the Mail app on iOS.
3133
3134         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3135         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3136         (-[TestRunnerWKWebView resetCustomMenuAction]):
3137         (-[TestRunnerWKWebView performCustomAction:]):
3138         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3139         (-[TestRunnerWKWebView _willHideMenu]):
3140         (-[TestRunnerWKWebView _didHideMenu]):
3141         * WebKitTestRunner/ios/TestControllerIOS.mm:
3142         (WTR::TestController::platformResetStateToConsistentValues):
3143
3144         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3145         if specified.
3146
3147         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3148         (WTR::UIScriptController::isDismissingMenu const):
3149
3150 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3151
3152         Allow sharing from imageSheet on an image document
3153         https://bugs.webkit.org/show_bug.cgi?id=196891
3154         <rdar://problem/25377386>
3155
3156         Reviewed by Tim Horton.
3157
3158         Test to make sure that the correct imageURL is extracted from an image element.
3159
3160         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3161         (TestWebKitAPI::TEST):
3162
3163 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3164
3165         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3166         https://bugs.webkit.org/show_bug.cgi?id=196995
3167
3168         Reviewed by Brady Eidson.
3169
3170         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3171         (TEST):
3172
3173 2019-04-16  Chris Dumez  <cdumez@apple.com>
3174
3175         URL set by document.open() is not communicated to the UIProcess
3176         https://bugs.webkit.org/show_bug.cgi?id=196941
3177         <rdar://problem/49237544>
3178
3179         Reviewed by Geoff Garen.
3180
3181         Add API test coverage.
3182
3183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3184         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3185         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3186         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3187         (TEST):
3188
3189 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3190
3191         Unreviewed, rolling out r244321.
3192         https://bugs.webkit.org/show_bug.cgi?id=196968
3193
3194         Causing all WK2 Debug builds to exit early after Assertion
3195         failures. (Requested by ShawnRoberts on #webkit).
3196
3197         Reverted changeset:
3198
3199         "URL set by document.open() is not communicated to the
3200         UIProcess"
3201         https://bugs.webkit.org/show_bug.cgi?id=196941
3202         https://trac.webkit.org/changeset/244321
3203
3204 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3205
3206         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3207         https://bugs.webkit.org/show_bug.cgi?id=196948
3208
3209         Reviewed by Zalan Bujtas.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3212         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3213
3214 2019-04-15  Chris Dumez  <cdumez@apple.com>
3215
3216         URL set by document.open() is not communicated to the UIProcess
3217         https://bugs.webkit.org/show_bug.cgi?id=196941
3218         <rdar://problem/49237544>
3219
3220         Reviewed by Geoffrey Garen.
3221
3222         Add API test coverage.
3223
3224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3225         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3226         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3227         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3228         (TEST):
3229
3230 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3231
3232         Using Tools/Scripts/clean-webkit should not install requests
3233         https://bugs.webkit.org/show_bug.cgi?id=196940
3234
3235         Reviewed by Lucas Forschler.
3236
3237         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3238         existing, depending on the path autoinstalled is run through.
3239         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3240         needed.
3241         (Port.configuration_for_upload):
3242         (Port.commits_for_upload):
3243
3244 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3245
3246         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3247         https://bugs.webkit.org/show_bug.cgi?id=196773
3248
3249         Reviewed by Jer Noble.
3250
3251         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3252         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3253         (TEST):
3254
3255 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3256
3257         ews-build should clearly indicate flaky test failures
3258         https://bugs.webkit.org/show_bug.cgi?id=196947
3259
3260         Reviewed by Lucas Forschler.
3261
3262         * BuildSlaveSupport/ews-build/steps.py:
3263         (AnalyzeAPITestsResults.analyzeResults):
3264
3265 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3266
3267         InjectedBundle parameters often need initialization function called before unarchiving
3268         https://bugs.webkit.org/show_bug.cgi?id=189709
3269         <rdar://problem/44573653>
3270
3271         Reviewed by Ryosuke Niwa.
3272
3273         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3274         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3275
3276 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3277
3278         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3279         https://bugs.webkit.org/show_bug.cgi?id=196681
3280
3281         Reviewed by Darin Adler.
3282
3283         Added tests.
3284
3285         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3286         (WTF_HashSet.RemoveIf):
3287         (WTF_HashSet.RemoveIfShrinkToBestSize):
3288
3289 2019-04-15  John Wilander  <wilander@apple.com>
3290
3291         Send delayed Ad Click Attribution conversion requests to the click source
3292         https://bugs.webkit.org/show_bug.cgi?id=196838
3293         <rdar://problem/47650157>
3294
3295         Reviewed by Chris Dumez and Youenn Fablet.
3296
3297         This patch adds test infrastructure to override the default behavior in
3298         WebKit::NetworkAdClickAttribution.
3299
3300         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3301         (TestWebKitAPI::TEST):
3302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3304         (WTR::TestRunner::dumpAdClickAttribution):
3305         (WTR::TestRunner::clearAdClickAttribution):
3306         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3307         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3308         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3309         * WebKitTestRunner/TestController.cpp:
3310         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3311         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3312         * WebKitTestRunner/TestController.h:
3313         * WebKitTestRunner/TestInvocation.cpp:
3314         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3315
3316 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3317
3318         [ews-app] status-bubble should display position in queue
3319         https://bugs.webkit.org/show_bug.cgi?id=196607
3320
3321         Reviewed by Lucas Forschler.
3322
3323         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3324         (StatusBubble._build_bubble):
3325         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3326
3327 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3328
3329         [ews-build] Do not run clean build by default on EWS builders
3330         https://bugs.webkit.org/show_bug.cgi?id=196897
3331
3332         Reviewed by Lucas Forschler.
3333
3334         * BuildSlaveSupport/ews-build/steps.py:
3335         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3336         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3337         untracked directories like WebKitBuild).
3338         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3339         untracked files/directories (like WebKitBuild).
3340
3341 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3342
3343         TestRunner::notifyDone() should be safely reentrant
3344         https://bugs.webkit.org/show_bug.cgi?id=196898
3345
3346         Reviewed by Darin Adler.
3347
3348         It is currently possible that TestRunner::notifyDone() will call itself, since
3349         notifyDone() will force a repaint, which can start executing JavaScript, which
3350         may call notifyDone() again. This can lead to test failures and flakiness.
3351         Fix this by setting the m_waitToDump flag before calling the dump() method.
3352
3353         * DumpRenderTree/mac/TestRunnerMac.mm:
3354         (TestRunner::notifyDone):
3355         (TestRunner::forceImmediateCompletion):
3356         * DumpRenderTree/win/TestRunnerWin.cpp:
3357         (TestRunner::notifyDone):
3358         (TestRunner::forceImmediateCompletion):
3359
3360 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3361
3362         [GTK][WPE] Add enable-media websetting
3363         https://bugs.webkit.org/show_bug.cgi?id=196863
3364
3365         Reviewed by Michael Catanzaro.
3366
3367         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3368         (testWebKitSettings): Add test for the enable-media web-setting.
3369
3370 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3371
3372         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3373         https://bugs.webkit.org/show_bug.cgi?id=196905
3374         <rdar://problem/49886096>
3375
3376         Reviewed by Tim Horton.
3377
3378         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3379         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3380         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3381         delay timer, we end up with this sequence of events in the problematic (failure) case:
3382
3383         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3384             ...IPC from UI to web process...
3385         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3386             ...IPC from web to UI process...
3387         (c) [UI]    Invoke completion handler for script #1
3388         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3389             ...IPC from UI to web process...
3390         (e) [Web]   Evaluate script #2 in the web process
3391         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3392
3393         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3394         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3395         #2 is run in step (e).
3396
3397         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3398         the UI process by waiting on a script message posted by the web process, after attachment updates are
3399         dispatched.
3400
3401         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3402         (TestWebKitAPI::TEST):
3403
3404 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3405
3406         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3407         https://bugs.webkit.org/show_bug.cgi?id=196909
3408
3409         Reviewed by Wenson Hsieh.
3410
3411         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3412         (TestWebKitAPI::TEST):
3413
3414 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3415
3416         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3417         https://bugs.webkit.org/show_bug.cgi?id=196880
3418
3419         Reviewed by Yusuke Suzuki.
3420
3421         Add a new function for bytecode cache tests that does not forceDiskCache
3422         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3423         test added in this patch, since the code is invalid and therefore won't be
3424         cached. It should also be useful for tests that evaluate dynamically
3425         generated code.
3426
3427         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3428         * Scripts/run-jsc-stress-tests:
3429
3430 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3431
3432         Update AudioSession route sharing policy
3433         https://bugs.webkit.org/show_bug.cgi?id=196776
3434         <rdar://problem/46501611>
3435
3436         Reviewed by Jer Noble.
3437
3438         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3439         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3440         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3441         (TestWebKitAPI::TEST):
3442
3443 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3444
3445         [iOS] Software keyboard is shown too frequently on some websites
3446         https://bugs.webkit.org/show_bug.cgi?id=195856
3447         <rdar://problem/49191395>
3448
3449         Reviewed by Darin Adler.
3450
3451         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3452
3453         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3454         (WTR::UIScriptController::setHardwareKeyboardAttached):
3455         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3456         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3457         (WTR::UIScriptController::setHardwareKeyboardAttached):
3458         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3459         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3460
3461         Additionally link against GraphicsServices in WebKitTestRunner.
3462
3463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3464         (WTR::TestController::platformResetStateToConsistentValues):
3465         (WTR::UIScriptController::setHardwareKeyboardAttached):
3466
3467 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3468
3469         [GTK][WPE] Fix pacman install-dependencies packages
3470         https://bugs.webkit.org/show_bug.cgi?id=196817
3471
3472         Reviewed by Žan Doberšek.
3473         
3474         python3-setuptools is called python-setuptools
3475         ruby-highline is only available on AUR
3476         libv4l-devel is incorporated in v4l-utils
3477
3478         * gtk/install-dependencies:
3479         * wpe/install-dependencies:
3480
3481 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3482
3483         [GTK] REGRESSION(r243860): Many tests failing
3484         https://bugs.webkit.org/show_bug.cgi?id=196791
3485
3486         Reviewed by Joanmarie Diggs.
3487
3488         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3489         multiple documents and check that accessibility hierarchy is updated after a navigation.
3490
3491         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3492         (loadChangedCallback):
3493         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3494         (AccessibilityTest::AccessibilityTest):
3495         (AccessibilityTest::~AccessibilityTest):
3496         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3497         (AccessibilityTest::findTestServerApplication):
3498         (AccessibilityTest::findDocumentWeb):
3499         (AccessibilityTest::findRootObject):
3500         (AccessibilityTest::waitUntilChildrenRemoved):
3501         (AccessibilityTest::ensureProxy):
3502         (testAtspiBasicHierarchy):
3503         (beforeAll):
3504         (afterAll):
3505
3506 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3507
3508         [ews-build] Handle bug titles with unicode characters
3509         https://bugs.webkit.org/show_bug.cgi?id=196802
3510
3511         Reviewed by Dewei Zhu.
3512
3513         * BuildSlaveSupport/ews-build/steps.py:
3514         (ValidatePatch._is_bug_closed):
3515
3516 2019-04-11  Michael Saboff  <msaboff@apple.com>
3517
3518         Improve the Inline Cache Stats code
3519         https://bugs.webkit.org/show_bug.cgi?id=196836
3520
3521         Reviewed by Saam Barati.
3522
3523         Added a new script to consolidate and arrange the output of --useICStats option.
3524
3525         This script merges the output from every group into one large table and sorts it from most common to
3526         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3527         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3528         Put together, this is useful to see what property accesses are not getting cached.
3529
3530         * Scripts/ic-stats.py: Added.
3531         (ICStats):
3532         (ICStats.__init__):
3533         (ICStats.parse):
3534         (ICStats.dumpStats):
3535         (usage):
3536
3537 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3538
3539         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3540         https://bugs.webkit.org/show_bug.cgi?id=196809
3541         <rdar://49800762>
3542
3543         Reviewed by Brady Eidson.
3544
3545         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3546         (TEST):
3547
3548 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3549
3550         requestAnimationFrame should execute before the next frame
3551         https://bugs.webkit.org/show_bug.cgi?id=177484
3552
3553         Reviewed by Simon Fraser.
3554
3555         Add trace points for the page RenderingUpdate.
3556
3557         * Tracing/SystemTracePoints.plist:
3558
3559 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3560
3561         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3562         https://bugs.webkit.org/show_bug.cgi?id=196760
3563
3564         Reviewed by Don Olmstead.
3565
3566         vswhere.exe has been bundled since Visual Studio 2017 version
3567         15.2. We shouldn't download vswhere.exe.
3568
3569         * Scripts/build-jsc: Do not call update-vswhere.py.
3570         * Scripts/build-webkit: Ditto.
3571         * Scripts/update-vswhere.py: Removed.
3572         * Scripts/webkitdirs.pm:
3573         (requireModulesForVSWhere): Deleted.
3574         (pickCurrentVisualStudioInstallation): Deleted.
3575         (visualStudioInstallDirVSWhere): Return the latest installed VS
3576         installation path by using the bundled vswhere.exe.
3577         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3578         (visualStudioInstallDirFallback): Removed.
3579
3580 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3581
3582         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3583         https://bugs.webkit.org/show_bug.cgi?id=196780
3584
3585         Reviewed by Alexey Proskuryakov.
3586
3587         * BuildSlaveSupport/ews-build/steps.py:
3588         * BuildSlaveSupport/ews-build/steps_unittest.py:
3589
3590 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3591
3592         Add SPI WKNavigationResponse._downloadAttribute
3593         https://bugs.webkit.org/show_bug.cgi?id=196755
3594         <rdar://49587365>
3595
3596         Reviewed by Brady Eidson.
3597
3598         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3599         (-[NavigationResponseTestDelegate navigationResponse]):
3600         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3601         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3602         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3603         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3604         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3605         (readRequest):
3606         (writeResponse):
3607         (TEST):
3608
3609 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3610
3611         Add modern API for overriding the page's specified viewport configuration
3612         https://bugs.webkit.org/show_bug.cgi?id=167734
3613         <rdar://problem/30331795>
3614
3615         Reviewed by Simon Fraser.
3616
3617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3618         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3619
3620 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3621
3622         Add support for incremental bytecode cache updates
3623         https://bugs.webkit.org/show_bug.cgi?id=195000
3624
3625         Reviewed by Filip Pizlo.
3626
3627         Exit when the initial run to generate bytecode fails.
3628
3629         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3630
3631 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3632
3633         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3634         https://bugs.webkit.org/show_bug.cgi?id=196744
3635         <rdar://49415309>
3636
3637         Reviewed by Chris Dumez.
3638
3639         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3640         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3641
3642 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3643
3644         Add a way to opt into modern compatibility mode in layout tests
3645         https://bugs.webkit.org/show_bug.cgi?id=196770
3646         <rdar://problem/49777550>
3647
3648         Reviewed by Antoine Quint.
3649
3650         Add a new test option to enable modern compatibility mode in layout tests.
3651
3652         * WebKitTestRunner/TestController.cpp:
3653         (WTR::updateTestOptionsFromTestHeader):
3654         * WebKitTestRunner/TestController.h:
3655         * WebKitTestRunner/TestOptions.h:
3656         (WTR::TestOptions::hasSameInitializationOptions const):
3657         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3658         (WTR::TestController::platformCreateWebView):
3659         (WTR::TestController::enableModernCompatibilityMode):
3660
3661 2019-04-10  Andy Estes  <aestes@apple.com>
3662
3663         Try to fix the 32-bit watchOS build.
3664
3665         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3666         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3667
3668 2019-04-10  Antoine Quint  <graouts@apple.com>
3669
3670         Enable Pointer Events on watchOS
3671         https://bugs.webkit.org/show_bug.cgi?id=196771
3672         <rdar://problem/49040909>
3673
3674         Reviewed by Dean Jackson.
3675
3676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3677
3678 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3679
3680         Unreviewed. Fix WPE accessibility tests after r244059.
3681
3682         We are failing to load the injected bundle due to undefined symbol
3683         AccessibilityUIElement::replaceTextInRange().
3684
3685         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3686         (WTR::AccessibilityUIElement::replaceTextInRange):
3687
3688 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3689
3690         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3691         https://bugs.webkit.org/show_bug.cgi?id=196727
3692
3693         Reviewed by Fujii Hironori.
3694
3695         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3696         (WebKitBrowserWindow::create):
3697
3698 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3699
3700         [ews-build] Add unit tests for PrintConfiguration
3701         https://bugs.webkit.org/show_bug.cgi?id=196752
3702
3703         Reviewed by Dewei Zhu.
3704
3705         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3706
3707 2019-04-09  Keith Rollin  <krollin@apple.com>
3708
3709         Unreviewed build maintenance -- update .xcfilelists.
3710
3711         * DumpRenderTree/DerivedSources-input.xcfilelist:
3712         * DumpRenderTree/DerivedSources-output.xcfilelist:
3713
3714 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3715
3716         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3717         https://bugs.webkit.org/show_bug.cgi?id=196743
3718         <rdar://problem/43897551>
3719
3720         Reviewed by Tim Horton.
3721
3722         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3723         (TEST):
3724
3725 2019-04-09  Youenn Fablet  <youenn@apple.com>
3726
3727         Close service worker database on network process suspension
3728         https://bugs.webkit.org/show_bug.cgi?id=196623
3729         <rdar://problem/48930869>
3730
3731         Reviewed by Alex Christensen.
3732
3733         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3734
3735 2019-04-09  Daniel Bates  <dabates@apple.com>
3736
3737         [iPad] Should open popover when the spacebar is pressed
3738         https://bugs.webkit.org/show_bug.cgi?id=196360
3739         <rdar://problem/49389129>
3740
3741         Reviewed by Brent Fulgham.
3742
3743         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3744
3745         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3746         (WTR::UIScriptController::isShowingPopover const): Added.
3747         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3748         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3749         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3750         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3751         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3752         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3753         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3754         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3755         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3756         (WTR::UIScriptController::isShowingPopover const): Added.
3757         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3758         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3759         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3760         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3761         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3762         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3763         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3764         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3765         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3766         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3767         (WTR::UIScriptController::isShowingPopover const): Added.
3768         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3769         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3770
3771 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3772
3773         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3774         https://bugs.webkit.org/show_bug.cgi?id=196665
3775         <rdar://45115669>
3776
3777         Reviewed by Geoff Garen.
3778
3779         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3780         (goBack):
3781         (+[SimpleLookupContext sharedLookupContext]):
3782         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3783         (TEST):
3784         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3785         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3786
3787 2019-04-09  John Wilander  <wilander@apple.com>
3788
3789         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3790         https://bugs.webkit.org/show_bug.cgi?id=196558
3791         <rdar://problem/47650245>
3792
3793         Reviewed by Youenn Fablet.
3794
3795         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3796         (TestWebKitAPI::TEST):
3797             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3798
3799 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3800
3801         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3802         https://bugs.webkit.org/show_bug.cgi?id=196720
3803
3804         Reviewed by Konstantin Tokarev.
3805
3806         * TestWebKitAPI/PlatformMac.cmake:
3807
3808 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3809
3810         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3811         https://bugs.webkit.org/show_bug.cgi?id=196694
3812         <rdar://problem/48388734>
3813
3814         Rubber-stamped by Aakash Jain.
3815
3816         * Scripts/webkitpy/port/image_diff.py:
3817         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3818         * Scripts/webkitpy/port/server_process.py:
3819         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3820         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3821         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3822         * Scripts/webkitpy/port/server_process_mock.py:
3823         (MockServerProcess.has_available_stdout):
3824         * Scripts/webkitpy/port/server_process_unittest.py:
3825         (TestServerProcess.serial_test_basic):
3826
3827 2019-04-09  Jer Noble  <jer.noble@apple.com>
3828
3829         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3830         https://bugs.webkit.org/show_bug.cgi?id=196097
3831
3832         Reviewed by Eric Carlson.
3833
3834         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3835
3836         * DumpRenderTree/mac/DumpRenderTree.mm:
3837         (resetWebPreferencesToConsistentValues):
3838         * WebKitTestRunner/TestController.cpp:
3839         (WTR::TestController::resetPreferencesToConsistentValues):
3840
3841 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3842
3843         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3844         https://bugs.webkit.org/show_bug.cgi?id=196690
3845
3846         Reviewed by Michael Catanzaro.
3847
3848         * QueueStatusServer/config/queues.py:
3849         * Scripts/webkitpy/common/config/ews.json:
3850         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3851         (test_ews_name):
3852
3853 2019-04-09  Chris Dumez  <cdumez@apple.com>
3854
3855         Loads using loadHTMLString() cause flashing when process-swapping
3856         https://bugs.webkit.org/show_bug.cgi?id=196714
3857         <rdar://problem/49637354>
3858
3859         Reviewed by Antti Koivisto.
3860
3861         Add API test coverage.
3862
3863         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3864
3865 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3866
3867         Unreviewed. Fix ATK accessibility tests after r244059.
3868
3869         We are failing to load the injected bundle due to undefined symbol
3870         AccessibilityUIElement::replaceTextInRange().
3871
3872         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3873         (WTR::AccessibilityUIElement::replaceTextInRange):
3874
3875 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3876
3877         AX: Support API: accessibilityReplaceRange:withText
3878         https://bugs.webkit.org/show_bug.cgi?id=196636
3879
3880         Unreviewed build fix for Windows port.
3881
3882         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3883         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3884
3885 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3886
3887         [CMake][WinCairo] Separate copied headers into different directories
3888         https://bugs.webkit.org/show_bug.cgi?id=196655
3889
3890         Reviewed by Michael Catanzaro.
3891
3892         * DumpRenderTree/CMakeLists.txt:
3893         * MiniBrowser/win/CMakeLists.txt:
3894         * TestWebKitAPI/CMakeLists.txt:
3895         * TestWebKitAPI/PlatformWin.cmake:
3896
3897 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3898
3899         Log stack-trace for run-webkit-tests when interrupted
3900         https://bugs.webkit.org/show_bug.cgi?id=176393
3901         <rdar://problem/34262310>
3902
3903         Reviewed by Lucas Forschler.
3904
3905         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3906         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3907         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3908         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3909         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3910         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3911         (main): Set handlers to log stack trace on interruption.
3912
3913 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3914
3915         AX: Support API: accessibilityReplaceRange:withText
3916         https://bugs.webkit.org/show_bug.cgi?id=196636
3917
3918         Unreviewed build fix for Windows port.
3919
3920         * DumpRenderTree/AccessibilityUIElement.cpp:
3921         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3922
3923 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3924
3925         [ews-build] Scripts using Buildbot API have CORS error
3926         https://bugs.webkit.org/show_bug.cgi?id=196709
3927
3928         Reviewed by Alexey Proskuryakov.
3929
3930         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3931
3932 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3933
3934         AX: Support API: accessibilityReplaceRange:withText
3935         https://bugs.webkit.org/show_bug.cgi?id=196636
3936
3937         Reviewed by Daniel Bates.
3938
3939         * DumpRenderTree/AccessibilityUIElement.cpp:
3940         (replaceTextInRangeCallback):
3941         (AccessibilityUIElement::replaceTextInRange):
3942         (AccessibilityUIElement::getJSClass):
3943         * DumpRenderTree/AccessibilityUIElement.h:
3944         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3945         (AccessibilityUIElement::replaceTextInRange):
3946         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3947         (AccessibilityUIElement::replaceTextInRange):
3948         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3949         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3950         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3951         (WTR::AccessibilityUIElement::replaceTextInRange):
3952         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3953         (WTR::AccessibilityUIElement::replaceTextInRange):
3954
3955 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3956
3957         [iOS] Do not allow starting selection drags when selection views are not visible
3958         https://bugs.webkit.org/show_bug.cgi?id=196686
3959         <rdar://problem/49399192>
3960
3961         Reviewed by Tim Horton.
3962
3963         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3964         also add some new API tests to cover scenarios where the web view is not first responder.
3965
3966         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3967         (TestWebKitAPI::TEST):
3968         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3969
3970         Add a switch to optionally make the web view first responder when starting the simulated drag.
3971
3972         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3973         (-[DragAndDropSimulator initWithWebView:]):
3974         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3975
3976 2019-04-08  Justin Fan  <justin_fan@apple.com>
3977
3978         [Web GPU] Fix Web GPU experimental feature on iOS
3979         https://bugs.webkit.org/show_bug.cgi?id=196632
3980
3981         Reviewed by Myles C. Maxfield.
3982
3983         Properly make Web GPU available on iOS 11+.
3984
3985         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3986
3987 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3988
3989         [ews-build] Do not upload archive when Compile Fails
3990         https://bugs.webkit.org/show_bug.cgi?id=196674
3991
3992         Reviewed by Alexey Proskuryakov.
3993
3994         * BuildSlaveSupport/ews-build/factories.py:
3995         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3996         * BuildSlaveSupport/ews-build/steps.py:
3997         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3998         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3999         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
4000
4001 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
4002
4003         Enable DFG on MIPS
4004         https://bugs.webkit.org/show_bug.cgi?id=196689
4005
4006         Reviewed by Žan Doberšek.
4007
4008         Since the bytecode change, we enabled the baseline JIT on mips in
4009         r240432, but DFG is still missing. With this change, all tests are
4010         passing on a ci20 board.
4011
4012         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
4013
4014 2019-04-08  Philippe Normand  <pnormand@igalia.com>
4015
4016         [Flatpak] Second run update-webkitwpe-flatpak fails
4017         https://bugs.webkit.org/show_bug.cgi?id=192702
4018
4019         Reviewed by Carlos Garcia Campos.
4020
4021         * flatpak/flatpakutils.py:
4022         (FlatpakObject.flatpak): Fix typo.
4023         (FlatpakPackage.install): When installing, also update to the configured remote commit.
4024         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
4025
4026 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
4027
4028         [GTK][WPE] outlook.live.com displays old-fashioned UI
4029         https://bugs.webkit.org/show_bug.cgi?id=196642
4030
4031         Reviewed by Carlos Garcia Campos.
4032
4033         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4034         (TestWebKitAPI::TEST): New Mac platform quirk test.
4035
4036 2019-04-07  Commit Queue  <commit-queue@webkit.org>
4037
4038         Unreviewed, rolling out r243956.
4039         https://bugs.webkit.org/show_bug.cgi?id=196688
4040
4041         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
4042         by aakashjain on #webkit).
4043
4044         Reverted changeset:
4045
4046         "Clicking "Go Back" from a safe browsing warning from an
4047         iframe should navigate the WKWebView back to the previous
4048         page"
4049         https://bugs.webkit.org/show_bug.cgi?id=196665
4050         https://trac.webkit.org/changeset/243956
4051
4052 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
4053
4054         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
4055         https://bugs.webkit.org/show_bug.cgi?id=196669
4056
4057         Reviewed by Geoffrey Garen.
4058
4059         Added three new unit tests for WeakHashSet.
4060
4061         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4062         (WTF_WeakPtr.WeakHashSetConstObjects):
4063         (WTF_WeakPtr.WeakHashSetComputesEmpty):
4064         (WTF_WeakPtr.WeakHashSetComputeSize):
4065
4066 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
4067
4068         Hide next and previous form control buttons when WKWebView is editable
4069         https://bugs.webkit.org/show_bug.cgi?id=196672
4070         <rdar://problem/35625321>
4071
4072         Reviewed by Tim Horton.
4073
4074         Add a new API test.
4075
4076         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4077         (-[TestWKWebView lastTrailingBarButtonGroup]):
4078         (TestWebKitAPI::TEST):
4079         * TestWebKitAPI/ios/UIKitSPI.h:
4080
4081 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
4082
4083         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
4084         https://bugs.webkit.org/show_bug.cgi?id=196077
4085         <rdar://problem/49108202>
4086
4087         Reviewed by Chris Dumez.
4088
4089         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
4090         on new web view.
4091
4092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4093
4094 2019-04-05  Saam Barati  <sbarati@apple.com>
4095
4096         Make compare-results understand MotionMark
4097         https://bugs.webkit.org/show_bug.cgi?id=196666
4098
4099         Reviewed by Yusuke Suzuki.
4100
4101         * Scripts/compare-results:
4102         (PLT5Results):
4103         (detectMotionMark):
4104         (detectMotionMark1_1):
4105         (motionMarkResults):
4106         (motionMark1_1Results):
4107         (detectBenchmark):
4108         (biggerIsBetter):
4109         (main):
4110
4111 2019-04-05  Alex Christensen  <achristensen@webkit.org>
4112
4113         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
4114         https://bugs.webkit.org/show_bug.cgi?id=196665
4115         <rdar://45115669>
4116
4117         Reviewed by Geoff Garen.
4118
4119         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4120         (goBack):
4121         (+[SimpleLookupContext sharedLookupContext]):
4122         (-[SimpleLookupContext lookUpURL:completionHandler:]):
4123         (TEST):
4124         (+[Simple3LookupContext sharedLookupContext]): Deleted.
4125         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
4126
4127 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
4128
4129         [ews-build] Add configuration and architecture for windows builders
4130         https://bugs.webkit.org/show_bug.cgi?id=196660
4131
4132         Reviewed by Lucas Forschler.
4133
4134         * BuildSlaveSupport/ews-build/config.json:
4135
4136 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
4137
4138         webkitpy: Don't run subsequent rounds if interrupted
4139         https://bugs.webkit.org/show_bug.cgi?id=196646
4140
4141         Reviewed by Aakash Jain.
4142
4143         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4144         (Manager.run): Bail out if interrupted.
4145
4146 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
4147
4148         Test sessionStorage in PSON private browsing mode
4149         https://bugs.webkit.org/show_bug.cgi?id=196561
4150
4151         Reviewed by Alex Christensen.
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4154
4155 2019-04-05  Commit Queue  <commit-queue@webkit.org>
4156
4157         Unreviewed, rolling out r243833.
4158         https://bugs.webkit.org/show_bug.cgi?id=196645
4159
4160         This change breaks build of WPE and GTK ports (Requested by
4161         annulen on #webkit).
4162
4163         Reverted changeset:
4164
4165         "[CMake][WTF] Mirror XCode header directories"
4166         https://bugs.webkit.org/show_bug.cgi?id=191662
4167         https://trac.webkit.org/changeset/243833
4168
4169 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
4170
4171         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
4172         https://bugs.webkit.org/show_bug.cgi?id=196635
4173
4174         Reviewed by Antti Koivisto.
4175         
4176         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
4177         for a test to enable async frame scrolling via:
4178             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
4179         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
4180         
4181         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
4182
4183         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4184         (WTR::InjectedBundle::beginTesting):
4185         * WebKitTestRunner/TestController.cpp:
4186         (WTR::TestController::resetPreferencesToConsistentValues):
4187
4188 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
4189
4190         Use a correct LC_RPATH when building with ASan
4191         https://bugs.webkit.org/show_bug.cgi?id=196576
4192
4193         Reviewed by David Kilzer.
4194
4195         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
4196         so that ../Frameworks is checked. This is simpler and more reliable than updating
4197         each SPC service xcconfig.
4198
4199 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4200
4201         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
4202         https://bugs.webkit.org/show_bug.cgi?id=196629
4203
4204         Reviewed by Lucas Forschler.
4205
4206         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4207
4208 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4209
4210         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
4211         https://bugs.webkit.org/show_bug.cgi?id=196618
4212
4213         Reviewed by Lucas Forschler.
4214
4215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4216         (StatusBubble): Added QUEUE_TRIGGERS.
4217         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
4218         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
4219         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
4220         its parent(builder).
4221
4222 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4223
4224         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4225         https://bugs.webkit.org/show_bug.cgi?id=196625
4226
4227         Reviewed by Lucas Forschler.
4228
4229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4230         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
4231
4232 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4233
4234         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4235         https://bugs.webkit.org/show_bug.cgi?id=196630
4236
4237         Reviewed by Wenson Hsieh.
4238
4239         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4240
4241 2019-04-04  Youenn Fablet  <youenn@apple.com>
4242
4243         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
4244         https://bugs.webkit.org/show_bug.cgi?id=196543
4245
4246         Reviewed by Alex Christensen.
4247
4248         * WebKitTestRunner/TestController.cpp:
4249         (WTR::TestController::generatePageConfiguration):
4250
4251 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4252
4253         [ews-app] Status bubble should not display skipped buildbot steps
4254         https://bugs.webkit.org/show_bug.cgi?id=196584
4255
4256         Reviewed by Lucas Forschler.
4257
4258         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4259
4260 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4261
4262         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
4263         https://bugs.webkit.org/show_bug.cgi?id=196620
4264
4265         Reviewed by Lucas Forschler.
4266
4267         * BuildSlaveSupport/ews-app/ews/config.py:
4268
4269 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
4270
4271         [Win] DumpRenderTreeWatchDog.py is not checked into source
4272         https://bugs.webkit.org/show_bug.cgi?id=196567
4273         <rdar://problem/49525901>
4274
4275         Reviewed by Lucas Forschler.
4276
4277         This script is used on Win EWS bots to terminate hanging DRT processes.
4278
4279         * EWSTools/dumprendertreewatchdog.py: Added.
4280
4281 2019-04-04  Chris Dumez  <cdumez@apple.com>
4282
4283         Unreviewed, roll out r243858 which made tests time out.
4284
4285         Disable new API tests on Windows instead.
4286
4287         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4288         (TestWebKitAPI::TEST):
4289
4290 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4291
4292         [ATK] Cleanup WebPageAccessibilityObjectAtk
4293         https://bugs.webkit.org/show_bug.cgi?id=196537
4294
4295         Reviewed by Michael Catanzaro.
4296
4297         Also consider files under atk directories as exceptions for GObject conventions.
4298
4299         * Scripts/webkitpy/style/checkers/cpp.py:
4300         (check_identifier_name_in_declaration):
4301
4302 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
4303
4304         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4305         https://bugs.webkit.org/show_bug.cgi?id=196588
4306         <rdar://problem/49365787>
4307
4308         Unreviewed build fix for Windows port.
4309
4310         error C3861: 'kill': identifier not found
4311
4312         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4313         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
4314
4315 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4316
4317         [ews-build] Cancel build and similar operations should have authentication
4318         https://bugs.webkit.org/show_bug.cgi?id=196520
4319
4320         Reviewed by Dewei Zhu.
4321
4322         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
4323         environment variables.
4324
4325 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4326
4327         [ews-build] Do not trigger queues which are not in production yet
4328         https://bugs.webkit.org/show_bug.cgi?id=196581
4329
4330         Reviewed by Dewei Zhu.
4331
4332         * BuildSlaveSupport/ews-build/config.json:
4333
4334 2019-04-03  Chris Dumez  <cdumez@apple.com>
4335
4336         Unreviewed, fix typo in the name of API test added in r243848.
4337
4338         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4339         (TestWebKitAPI::TEST):
4340
4341 2019-04-03  Chris Dumez  <cdumez@apple.com>
4342
4343         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4344         https://bugs.webkit.org/show_bug.cgi?id=196588
4345         <rdar://problem/49365787>
4346
4347         Reviewed by Ryosuke Niwa.