Deprecate WKContextCreateWithInjectedBundlePath
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2
3         Deprecate WKContextCreateWithInjectedBundlePath
4         https://bugs.webkit.org/show_bug.cgi?id=197169
5
6         Reviewed by Youenn Fablet.
7
8         * TestWebKitAPI/PlatformUtilities.cpp:
9         (TestWebKitAPI::Util::createContextWithInjectedBundle):
10         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
11
12 2019-04-22  Alex Christensen  <achristensen@webkit.org>
13
14         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
15         https://bugs.webkit.org/show_bug.cgi?id=197093
16         <rdar://problem/49708268>
17
18         Reviewed by Chris Dumez.
19
20         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
21         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
22         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
23         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
24         and one for loads without credentials, so there are two TCP connections to the same server in this test.
25
26         * TestWebKitAPI/TCPServer.cpp:
27         (TestWebKitAPI::TCPServer::TCPServer):
28         (TestWebKitAPI::TCPServer::~TCPServer):
29         (TestWebKitAPI::TCPServer::socketBindListen):
30         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
31         * TestWebKitAPI/TCPServer.h:
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
34         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
35         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
36         (respondWithChallengeThenOK):
37         (TestWebKitAPI::TEST):
38         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
39         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
40         (TEST):
41
42 2019-04-22  Chris Dumez  <cdumez@apple.com>
43
44         Delayed WebProcessLaunch may break the _relatedWebView SPI
45         https://bugs.webkit.org/show_bug.cgi?id=197160
46
47         Reviewed by Alex Christensen.
48
49         Add API test coverage.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
52
53 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
54
55         Use curl to download packages for webkitpy autoinstaller
56         https://bugs.webkit.org/show_bug.cgi?id=197164
57
58         Reviewed by Darin Adler.
59
60         * Scripts/webkitpy/common/system/autoinstall.py:
61         (AutoInstaller._download): Use curl(1) to download packages necessary for
62         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
63         errors which are not present when using curl(1).
64
65 2019-04-22  Chris Dumez  <cdumez@apple.com>
66
67         Unreviewed, rolling out r244502.
68
69         Caused crashes on the bots
70
71         Reverted changeset:
72
73         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
74         https://bugs.webkit.org/show_bug.cgi?id=197160
75         https://trac.webkit.org/changeset/244502
76
77 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
78
79         Unreviewed, rolling out r244437.
80
81         Still breaks internal tests.
82
83         Reverted changeset:
84
85         "InjectedBundle parameters often need initialization function
86         called before unarchiving"
87         https://bugs.webkit.org/show_bug.cgi?id=189709
88         https://trac.webkit.org/changeset/244437
89
90 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
91
92         [ews-build] Use singular verb in failure description in case of single api test failure
93         https://bugs.webkit.org/show_bug.cgi?id=197013
94
95         Reviewed by Lucas Forschler.
96
97         * BuildSlaveSupport/ews-build/steps.py:
98         (AnalyzeAPITestsResults.analyzeResults):
99
100 2019-04-22  Chris Dumez  <cdumez@apple.com>
101
102         Delayed WebProcessLaunch may break the _relatedWebView SPI
103         https://bugs.webkit.org/show_bug.cgi?id=197160
104
105         Reviewed by Alex Christensen.
106
107         Add API test coverage.
108
109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
110
111 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
114         https://bugs.webkit.org/show_bug.cgi?id=194630
115
116         Reviewed by Michael Catanzaro.
117
118         Return early from getAttributeSet() is passed in accessible is nullptr.
119
120         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
121
122 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
123
124         Defer EditorState updates until the next layer tree flush in a few additional circumstances
125         https://bugs.webkit.org/show_bug.cgi?id=197145
126         <rdar://problem/50078170>
127
128         Reviewed by Darin Adler.
129
130         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
131         focus, or showing the font manager.
132
133         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
134         (TestWebKitAPI::TEST):
135         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
136         (TEST):
137         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
138         (TestWebKitAPI::TEST):
139
140 2019-04-21  Brian Burg  <bburg@apple.com>
141
142         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
143         https://bugs.webkit.org/show_bug.cgi?id=197125
144         <rdar://problem/50061468>
145
146         Reviewed by Darin Adler.
147
148         Sometimes I want to run wptserve independently of tests. Make it easier to script that
149         using this class rather than making our own ./wpt serve invocation.
150
151         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
152         (WebDriverW3CWebServer):
153         (WebDriverW3CWebServer.document_root): Expose this to clients.
154         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
155
156         (WebDriverW3CWebServer.__enter__):
157         (WebDriverW3CWebServer.__exit__):
158         Make it possible to use the web server with a 'with' statement.
159
160 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
161
162         [CMake][Win] Use target oriented design for WebKitLegacy
163         https://bugs.webkit.org/show_bug.cgi?id=197112
164
165         Reviewed by Konstantin Tokarev.
166
167         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
168
169         * DumpRenderTree/CMakeLists.txt:
170         * DumpRenderTree/PlatformWin.cmake:
171         * DumpRenderTree/win/EventSender.cpp:
172
173 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
174
175         Update text for old EWS submit button
176         https://bugs.webkit.org/show_bug.cgi?id=197140
177
178         Reviewed by Alexey Proskuryakov.
179
180         * QueueStatusServer/templates/statusbubble.html:
181
182 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
183
184         [ews-app] New EWS should poll bugzilla more frequently
185         https://bugs.webkit.org/show_bug.cgi?id=197138
186
187         Reviewed by Alexey Proskuryakov.
188
189         * BuildSlaveSupport/ews-app/ews/fetcher.py:
190         (FetchLoop.__init__):
191
192 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
193
194         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
195         https://bugs.webkit.org/show_bug.cgi?id=197139
196
197         Reviewed by Alexey Proskuryakov.
198
199         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
200         * QueueStatusServer/templates/statusbubble.html:
201
202 2019-04-20  Chris Dumez  <cdumez@apple.com>
203
204         Unreviewed, fix iOS build with recent SDKs.
205
206         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
207
208 2019-04-19  Keith Miller  <keith_miller@apple.com>
209
210         Add script to merge run_benchmark jsons
211         https://bugs.webkit.org/show_bug.cgi?id=197107
212
213         Reviewed by Michael Saboff.
214
215         The script basically recursively decends through all json objects until it gets
216         to an array or JSON primitive and concats or takes the first value, respectively.
217
218         This patch also adds +x bits to the compare-results script so it
219         can be run directly from the command line. I had to add a new line so that svn
220         will accept the change... yay svn!
221
222         * Scripts/compare-results:
223         * Scripts/merge-result-jsons: Added.
224         (readJSONFile):
225         (deepAppend):
226         (mergeJSONs):
227         (main):
228
229 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
230
231         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
232         https://bugs.webkit.org/show_bug.cgi?id=197079
233
234         Reviewed by Darin Adler.
235
236         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
237
238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
239         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
240
241 2019-04-18  Commit Queue  <commit-queue@webkit.org>
242
243         Unreviewed, rolling out r244434.
244         https://bugs.webkit.org/show_bug.cgi?id=197089
245
246         caused 1 API test failure (Requested by zalan on #webkit).
247
248         Reverted changeset:
249
250         "Regression (r244291): Broken API Test
251         AutoLayoutRenderingProgressRelativeOrdering"
252         https://bugs.webkit.org/show_bug.cgi?id=196948
253         https://trac.webkit.org/changeset/244434
254
255 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
256
257         Add new compatibility mode API on WKNavigation
258         https://bugs.webkit.org/show_bug.cgi?id=197069
259         <rdar://problem/50025800>
260
261         Reviewed by Tim Horton.
262
263         Add a block property for -didCommitNavigation to TestNavigationDelegate.
264
265         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
266         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
267         (-[TestNavigationDelegate webView:didCommitNavigation:]):
268
269 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
270
271         [CMake] Make WebCore headers copies
272         https://bugs.webkit.org/show_bug.cgi?id=182512
273         <rdar://problem/37510435>
274
275         Reviewed by Alex Christensen.
276
277         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
278         ports.
279
280         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
281         of WebCore headers using "*.h" were modified to <WebCore/*.h>
282
283         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
284         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
285         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
286         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
287         * TestWebKitAPI/CMakeLists.txt:
288         * TestWebKitAPI/PlatformWin.cmake:
289         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
290         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
291         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
292
293 2019-04-18  Jer Noble  <jer.noble@apple.com>
294
295         Add support for parsing FairPlayStreaming PSSH boxes.
296         https://bugs.webkit.org/show_bug.cgi?id=197064
297
298         Reviewed by Eric Carlson.
299
300         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
301         (TestWebKitAPI::TEST):
302
303 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
304
305         InjectedBundle parameters often need initialization function called before unarchiving
306         https://bugs.webkit.org/show_bug.cgi?id=189709
307         <rdar://problem/44573653>
308
309         Reviewed by Ryosuke Niwa.
310
311         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
312         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
313
314 2019-04-18  Zalan Bujtas  <zalan@apple.com>
315
316         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
317         https://bugs.webkit.org/show_bug.cgi?id=196948
318         <rdar://problem/49927131>
319
320         Reviewed by Tim Horton.
321
322         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
323         (TEST): 
324         The expected order of incoming events is
325         1. didInvalidateIntrinsicContentSize
326         2. didFirstLayout
327         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
328         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
329         (and remember, all we care about is ordering).
330
331 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
332
333         Unreviewed, rolling out r244299.
334
335         Breaks internal tests.
336
337         Reverted changeset:
338
339         "InjectedBundle parameters often need initialization function
340         called before unarchiving"
341         https://bugs.webkit.org/show_bug.cgi?id=189709
342         https://trac.webkit.org/changeset/244299
343
344 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
345
346         [WTF] StringBuilder should set correct m_is8Bit flag when merging
347         https://bugs.webkit.org/show_bug.cgi?id=197053
348
349         Reviewed by Saam Barati.
350
351         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
352         (TestWebKitAPI::TEST):
353
354 2019-04-17  Tim Horton  <timothy_horton@apple.com>
355
356         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
357         https://bugs.webkit.org/show_bug.cgi?id=197028
358         <rdar://problem/49985290>
359
360         Reviewed by Wenson Hsieh.
361
362         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
363         (TEST):
364         Liberal application of waitForNextPresentationUpdate works around a race
365         where if the page rapidly changes its viewport arguments (or an API client
366         rapidly changes its viewport arguments), we'd get stuck thinking that the
367         user had intentionally zoomed the page, and stop resetting the initial scale.
368         This deserves a separate bug, but no need to keep the test failing while
369         we think about it.
370
371 2019-04-17  Tim Horton  <timothy_horton@apple.com>
372
373         REGRESSION (r241988): Switching tabs is slow
374         https://bugs.webkit.org/show_bug.cgi?id=197037
375         <rdar://problem/49951473>
376
377         Reviewed by Simon Fraser.
378
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
381         (TEST):
382         * TestWebKitAPI/cocoa/TestWKWebView.h:
383         * TestWebKitAPI/cocoa/TestWKWebView.mm:
384         (-[TestWKWebView addToTestWindow]):
385         Add a test that hangs without this fix.
386
387 2019-04-17  Truitt Savell  <tsavell@apple.com>
388
389         Unreviewed, rolling out r244400.
390
391         Caused testing to exit early with assertionon Debug WK2
392
393         Reverted changeset:
394
395         "UI↔Web deadlock when printing with a JavaScript alert
396         visible"
397         https://bugs.webkit.org/show_bug.cgi?id=196839
398         https://trac.webkit.org/changeset/244400
399
400 2019-04-17  Brady Eidson  <beidson@apple.com>
401
402         Link clicks in PDFs shouldn't send referrer headers.
403         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
404
405         Reviewed by Tim Horton.
406
407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
408         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
409         (putPDFBytesCallback):
410         (emptyReleaseInfoCallback):
411         (createPDFWithLinkToURL):
412         (TEST):
413
414 2019-04-17  Tim Horton  <timothy_horton@apple.com>
415
416         UI↔Web deadlock when printing with a JavaScript alert visible
417         https://bugs.webkit.org/show_bug.cgi?id=196839
418         <rdar://problem/49157642>
419
420         Reviewed by Andy Estes.
421
422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
423         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
424         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
425         (TEST):
426
427 2019-04-17  Alex Christensen  <achristensen@webkit.org>
428
429         WKRetainPtr's adoption constructor should be private
430         https://bugs.webkit.org/show_bug.cgi?id=197019
431
432         Reviewed by Tim Horton.
433
434         * DumpRenderTree/mac/DumpRenderTree.mm:
435         (dumpFramesAsText):
436         * TestWebKitAPI/InjectedBundleController.cpp:
437         (TestWebKitAPI::InjectedBundleController::initialize):
438         * TestWebKitAPI/PlatformUtilities.cpp:
439         (TestWebKitAPI::Util::createContextWithInjectedBundle):
440         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
441         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
442         (TestWebKitAPI::Util::toWK):
443         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
444         (TestWebKitAPI::TEST):
445         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
446         (TestWebKitAPI::TEST):
447         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
448         (TestWebKitAPI::TEST):
449         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
450         (TestWebKitAPI::TEST):
451         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
452         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
453         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
454         (TestWebKitAPI::TEST):
455         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
456         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
457         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
458         (TestWebKitAPI::TEST):
459         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
460         (TestWebKitAPI::TEST):
461         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
462         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
463         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
464         (TestWebKitAPI::TEST):
465         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
466         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
467         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
468         (TestWebKitAPI::TEST):
469         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
476         (TestWebKitAPI::TEST):
477         * TestWebKitAPI/Tests/WebKit/Find.cpp:
478         (TestWebKitAPI::TEST):
479         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
480         (TestWebKitAPI::TEST):
481         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
482         (TestWebKitAPI::TEST):
483         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
484         (TestWebKitAPI::TEST):
485         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
488         (TestWebKitAPI::TEST):
489         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
490         (TestWebKitAPI::TEST):
491         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
492         (TestWebKitAPI::TEST):
493         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
494         (TestWebKitAPI::TEST):
495         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
496         (TestWebKitAPI::TEST):
497         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
498         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
499         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
500         (TestWebKitAPI::TEST):
501         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
502         (TestWebKitAPI::TEST):
503         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
504         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
505         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
506         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
509         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
510         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
511         (TestWebKitAPI::TEST):
512         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
513         (TestWebKitAPI::TEST):
514         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
515         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
516         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
517         (TestWebKitAPI::TEST):
518         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
519         (TestWebKitAPI::loadAlternateHTMLString):
520         (TestWebKitAPI::TEST):
521         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
522         (TestWebKitAPI::TEST):
523         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
524         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
525         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
526         (TestWebKitAPI::buildAndPerformTest):
527         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
528         (TestWebKitAPI::TEST):
529         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
530         (TestWebKitAPI::TEST):
531         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
532         (TestWebKitAPI::TEST):
533         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
534         (TestWebKitAPI::TEST):
535         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
536         (TestWebKitAPI::TEST):
537         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
538         (TestWebKitAPI::TEST):
539         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
540         (TestWebKitAPI::TEST):
541         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
542         (TestWebKitAPI::TEST):
543         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
544         (TestWebKitAPI::TEST):
545         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
546         (TestWebKitAPI::TEST):
547         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
548         (TestWebKitAPI::TEST):
549         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
550         (TestWebKitAPI::TEST):
551         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
552         (TestWebKitAPI::TEST):
553         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
554         (TestWebKitAPI::TEST):
555         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
556         (TestWebKitAPI::TEST):
557         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
558         (TestWebKitAPI::TEST):
559         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
560         (TestWebKitAPI::TEST):
561         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
562         (TestWebKitAPI::TEST):
563         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
564         (TestWebKitAPI::TEST):
565         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
566         (TestWebKitAPI::TEST):
567         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
568         (TestWebKitAPI::TEST):
569         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
570         (TestWebKitAPI::TEST):
571         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
572         (TestWebKitAPI::TEST):
573         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
574         (TestWebKitAPI::TEST):
575         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
576         (TestWebKitAPI::TEST):
577         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
578         (TestWebKitAPI::TEST):
579         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
580         (TestWebKitAPI::TEST):
581         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
582         (TestWebKitAPI::TEST):
583         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
584         (TestWebKitAPI::TEST):
585         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
586         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
587         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
588         (TestWebKitAPI::TEST):
589         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
590         (TestWebKitAPI::TEST):
591         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
592         (TestWebKitAPI::TEST):
593         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
594         (TestWebKitAPI::TEST):
595         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
596         (TestWebKitAPI::TEST):
597         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
598         (TestWebKitAPI::TEST):
599         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
600         (TestWebKitAPI::TEST):
601         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
602         (TestWebKitAPI::TEST):
603         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
604         (TestWebKitAPI::TEST):
605         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
606         (TestWebKitAPI::TEST):
607         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
608         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
609         (TEST):
610         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
611         (TEST):
612         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
613         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
614         (TEST):
615         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
616         (TestWebKitAPI::TEST):
617         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
618         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
619         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
620         (WTR::getMenuItemTitleCallback):
621         (WTR::createMouseMessageBody):
622         (WTR::EventSendingController::mouseDown):
623         (WTR::EventSendingController::mouseUp):
624         (WTR::EventSendingController::mouseMoveTo):
625         (WTR::EventSendingController::mouseForceClick):
626         (WTR::EventSendingController::startAndCancelMouseForceClick):
627         (WTR::EventSendingController::mouseForceDown):
628         (WTR::EventSendingController::mouseForceUp):
629         (WTR::EventSendingController::mouseForceChanged):
630         (WTR::EventSendingController::leapForward):
631         (WTR::EventSendingController::scheduleAsynchronousClick):
632         (WTR::createKeyDownMessageBody):
633         (WTR::EventSendingController::keyDown):
634         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
635         (WTR::EventSendingController::mouseScrollBy):
636         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
637         (WTR::EventSendingController::continuousMouseScrollBy):
638         (WTR::EventSendingController::addTouchPoint):
639         (WTR::EventSendingController::updateTouchPoint):
640         (WTR::EventSendingController::setTouchModifier):
641         (WTR::EventSendingController::setTouchPointRadius):
642         (WTR::EventSendingController::touchStart):
643         (WTR::EventSendingController::touchMove):
644         (WTR::EventSendingController::touchEnd):
645         (WTR::EventSendingController::touchCancel):
646         (WTR::EventSendingController::clearTouchPoints):
647         (WTR::EventSendingController::releaseTouchPoint):
648         (WTR::EventSendingController::cancelTouchPoint):
649         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
650         (WTR::InjectedBundle::didCreatePage):
651         (WTR::InjectedBundle::didReceiveMessage):
652         (WTR::InjectedBundle::didReceiveMessageToPage):
653         (WTR::InjectedBundle::booleanForKey):
654         (WTR::InjectedBundle::done):
655         (WTR::InjectedBundle::dumpToStdErr):
656         (WTR::InjectedBundle::outputText):
657         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
658         (WTR::InjectedBundle::postAddChromeInputField):
659         (WTR::InjectedBundle::postRemoveChromeInputField):
660         (WTR::InjectedBundle::postFocusWebView):
661         (WTR::InjectedBundle::postSetBackingScaleFactor):
662         (WTR::InjectedBundle::postSetWindowIsKey):
663         (WTR::InjectedBundle::postSetViewSize):
664         (WTR::InjectedBundle::postSimulateWebNotificationClick):
665         (WTR::InjectedBundle::postSetAddsVisitedLinks):
666         (WTR::InjectedBundle::setGeolocationPermission):
667         (WTR::InjectedBundle::setMockGeolocationPosition):
668         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
669         (WTR::InjectedBundle::isGeolocationProviderActive const):
670         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
671         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
672         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
673         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
674         (WTR::InjectedBundle::setCustomPolicyDelegate):
675         (WTR::InjectedBundle::setHidden):
676         (WTR::InjectedBundle::setCacheModel):
677         (WTR::InjectedBundle::shouldProcessWorkQueue const):
678         (WTR::InjectedBundle::processWorkQueue):
679         (WTR::InjectedBundle::queueBackNavigation):
680         (WTR::InjectedBundle::queueForwardNavigation):
681         (WTR::InjectedBundle::queueLoad):
682         (WTR::InjectedBundle::queueLoadHTMLString):
683         (WTR::InjectedBundle::queueReload):
684         (WTR::InjectedBundle::queueLoadingScript):
685         (WTR::InjectedBundle::queueNonLoadingScript):
686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
687         (WTR::frameToStr):
688         (WTR::InjectedBundlePage::InjectedBundlePage):
689         (WTR::dumpFrameDescriptionSuitableForTestResult):
690         (WTR::dumpFrameScrollPosition):
691         (WTR::dumpDescendantFrameScrollPositions):
692         (WTR::dumpFrameText):
693         (WTR::dumpDescendantFramesText):
694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
695         (WTR::TestRunner::shouldDumpPixels const):
696         (WTR::TestRunner::setDumpPixels):
697         (WTR::TestRunner::whatToDump const):
698         (WTR::TestRunner::setWhatToDump):
699         (WTR::TestRunner::setWaitUntilDone):
700         (WTR::TestRunner::shouldWaitUntilDone const):
701         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
702         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
703         (WTR::TestRunner::clearAllDatabases):
704         (WTR::TestRunner::setIDBPerOriginQuota):
705         (WTR::TestRunner::originsWithApplicationCache):
706         (WTR::TestRunner::setCanOpenWindows):
707         (WTR::TestRunner::setXSSAuditorEnabled):
708         (WTR::TestRunner::setMediaDevicesEnabled):
709         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
710         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
711         (WTR::TestRunner::setCustomUserAgent):
712         (WTR::TestRunner::setWebAPIStatisticsEnabled):
713         (WTR::TestRunner::setModernMediaControlsEnabled):
714         (WTR::TestRunner::setWebGL2Enabled):
715         (WTR::TestRunner::setWritableStreamAPIEnabled):
716         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
717         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
718         (WTR::TestRunner::setAllowsAnySSLCertificate):
719         (WTR::TestRunner::setPluginsEnabled):
720         (WTR::TestRunner::setValueForUser):
721         (WTR::TestRunner::setAudioResult):
722         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
723         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
724         (WTR::TestRunner::setAlwaysAcceptCookies):
725         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
726         (WTR::TestRunner::isDoingMediaCapture const):
727         (WTR::TestRunner::queueLoad):
728         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
729         (WTR::TestRunner::setHandlesAuthenticationChallenges):
730         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
731         (WTR::TestRunner::setShouldLogDownloadCallbacks):
732         (WTR::TestRunner::setAuthenticationUsername):
733         (WTR::TestRunner::setAuthenticationPassword):
734         (WTR::TestRunner::secureEventInputIsEnabled const):
735         (WTR::TestRunner::setBlockAllPlugins):
736         (WTR::TestRunner::setPluginSupportedMode):
737         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
738         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
739         (WTR::TestRunner::setNavigationGesturesEnabled):
740         (WTR::TestRunner::setIgnoresViewportScaleLimits):
741         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
742         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
743         (WTR::TestRunner::terminateNetworkProcess):
744         (WTR::TestRunner::terminateServiceWorkerProcess):
745         (WTR::TestRunner::runUIScript):
746         (WTR::TestRunner::setStatisticsDebugMode):
747         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
748         (WTR::TestRunner::setStatisticsLastSeen):
749         (WTR::TestRunner::setStatisticsPrevalentResource):
750         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
751         (WTR::TestRunner::dumpResourceLoadStatistics):
752         (WTR::TestRunner::isStatisticsPrevalentResource):
753         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
754         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
755         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
756         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
757         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
758         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
759         (WTR::TestRunner::setStatisticsGrandfathered):
760         (WTR::TestRunner::isStatisticsGrandfathered):
761         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
762         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
763         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
764         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
765         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
766         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
767         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
768         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
769         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
770         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
771         (WTR::TestRunner::statisticsUpdateCookieBlocking):
772         (WTR::TestRunner::statisticsSubmitTelemetry):
773         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
774         (WTR::TestRunner::setStatisticsIsRunningTest):
775         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
776         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
777         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
778         (WTR::TestRunner::setStatisticsGrandfatheringTime):
779         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
780         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
781         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
782         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
783         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
784         (WTR::TestRunner::statisticsDeleteCookiesForHost):
785         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
786         (WTR::TestRunner::statisticsResetToConsistentState):
787         (WTR::TestRunner::setStorageAccessAPIEnabled):
788         (WTR::TestRunner::getAllStorageAccessEntries):
789         (WTR::TestRunner::addMockMediaDevice):
790         (WTR::TestRunner::clearMockMediaDevices):
791         (WTR::TestRunner::removeMockMediaDevice):
792         (WTR::TestRunner::resetMockMediaDevices):
793         (WTR::TestRunner::connectMockGamepad):
794         (WTR::TestRunner::disconnectMockGamepad):
795         (WTR::TestRunner::setMockGamepadDetails):
796         (WTR::TestRunner::setMockGamepadAxisValue):
797         (WTR::TestRunner::setMockGamepadButtonValue):
798         (WTR::TestRunner::removeAllSessionCredentials):
799         (WTR::TestRunner::clearDOMCache):
800         (WTR::TestRunner::clearDOMCaches):
801         (WTR::TestRunner::hasDOMCache):
802         (WTR::TestRunner::domCacheSize):
803         (WTR::TestRunner::setAllowStorageQuotaIncrease):
804         (WTR::TestRunner::getApplicationManifestThen):
805         (WTR::TestRunner::injectUserScript):
806         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
807         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
808         (WTR::TestRunner::addTestKeyToKeychain):
809         (WTR::TestRunner::cleanUpKeychain):
810         (WTR::TestRunner::keyExistsInKeychain):
811         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
812         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
813         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
814         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
815         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
816         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
817         * WebKitTestRunner/TestController.cpp:
818         (WTR::TestController::initialize):
819         (WTR::parseStringTestHeaderValueAsRelativePath):
820         (WTR::updateTestOptionsFromTestHeader):
821         (WTR::TestController::runTest):
822         (WTR::TestController::didReceiveLiveDocumentsList):
823         (WTR::TestController::didReceiveMessageFromInjectedBundle):
824         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
825         (WTR::TestController::didFinishNavigation):
826         (WTR::TestController::didReceiveAuthenticationChallenge):
827         * WebKitTestRunner/TestInvocation.cpp:
828         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
829         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
830         (WTR::TestInvocation::uiScriptDidComplete):
831         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
832         * WebKitTestRunner/WebNotificationProvider.cpp:
833         (WTR::WebNotificationProvider::closeWebNotification):
834         * WebKitTestRunner/WorkQueueManager.cpp:
835         (WTR::ScriptItem::ScriptItem):
836         (WTR::WorkQueueManager::queueLoad):
837         (WTR::WorkQueueManager::queueLoadHTMLString):
838
839 2019-04-17  Alex Christensen  <achristensen@webkit.org>
840
841         Add a comment to make my test from r244139 less mysterious.
842         https://bugs.webkit.org/show_bug.cgi?id=196744
843
844         As suggested by Darin Adler.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
847         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
848
849 2019-04-17  Chris Dumez  <cdumez@apple.com>
850
851         Remember device orientation permission for the duration of the browsing session
852         https://bugs.webkit.org/show_bug.cgi?id=196992
853         <rdar://problem/49946067>
854
855         Reviewed by Alex Christensen.
856
857         Add API test coverage.
858
859         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
860         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
861         (TEST):
862
863 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
864
865         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
866         https://bugs.webkit.org/show_bug.cgi?id=196675
867
868         Reviewed by Lucas Forschler.
869
870         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
871         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
872
873 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
874
875         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
876         https://bugs.webkit.org/show_bug.cgi?id=196919
877         <rdar://problem/41630459>
878
879         Reviewed by Tim Horton.
880
881         Add iOS support for several new testing hooks. See below for more detail.
882
883         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
884         (WTR::UIScriptController::isDismissingMenu const):
885
886         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
887         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
888         by UIKit when dismissing the callout bar (i.e. UIMenuController).
889
890         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
891         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
892         (WTR::UIScriptController::isDismissingMenu const):
893         * TestRunnerShared/UIScriptContext/UIScriptController.h:
894         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
895         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
896         (WTR::InjectedBundle::didReceiveMessageToPage):
897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
898         (WTR::TestRunner::setAllowedMenuActions):
899
900         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
901         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
902         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
903         against the name of the custom action.
904
905         (WTR::TestRunner::installCustomMenuAction):
906
907         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
908         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
909         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
910         triggered.
911
912         (WTR::TestRunner::performCustomMenuAction):
913
914         Invoked when the custom menu action is triggered.
915
916         * WebKitTestRunner/InjectedBundle/TestRunner.h:
917         * WebKitTestRunner/TestController.cpp:
918         (WTR::TestController::installCustomMenuAction):
919         (WTR::TestController::setAllowedMenuActions):
920         * WebKitTestRunner/TestController.h:
921         * WebKitTestRunner/TestInvocation.cpp:
922         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
923         (WTR::TestInvocation::performCustomMenuAction):
924
925         Add plumbing to call back into the injected bundle when performing the custom action.
926
927         * WebKitTestRunner/TestInvocation.h:
928         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
929         (WTR::TestController::installCustomMenuAction):
930         (WTR::TestController::setAllowedMenuActions):
931         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
932         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
933         (-[TestRunnerWKWebView initWithFrame:configuration:]):
934         (-[TestRunnerWKWebView becomeFirstResponder]):
935         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
936
937         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
938         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
939         in the Mail app on iOS.
940
941         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
942         (-[TestRunnerWKWebView setAllowedMenuActions:]):
943         (-[TestRunnerWKWebView resetCustomMenuAction]):
944         (-[TestRunnerWKWebView performCustomAction:]):
945         (-[TestRunnerWKWebView canPerformAction:withSender:]):
946         (-[TestRunnerWKWebView _willHideMenu]):
947         (-[TestRunnerWKWebView _didHideMenu]):
948         * WebKitTestRunner/ios/TestControllerIOS.mm:
949         (WTR::TestController::platformResetStateToConsistentValues):
950
951         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
952         if specified.
953
954         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
955         (WTR::UIScriptController::isDismissingMenu const):
956
957 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
958
959         Allow sharing from imageSheet on an image document
960         https://bugs.webkit.org/show_bug.cgi?id=196891
961         <rdar://problem/25377386>
962
963         Reviewed by Tim Horton.
964
965         Test to make sure that the correct imageURL is extracted from an image element.
966
967         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
968         (TestWebKitAPI::TEST):
969
970 2019-04-16  Alex Christensen  <achristensen@webkit.org>
971
972         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
973         https://bugs.webkit.org/show_bug.cgi?id=196995
974
975         Reviewed by Brady Eidson.
976
977         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
978         (TEST):
979
980 2019-04-16  Chris Dumez  <cdumez@apple.com>
981
982         URL set by document.open() is not communicated to the UIProcess
983         https://bugs.webkit.org/show_bug.cgi?id=196941
984         <rdar://problem/49237544>
985
986         Reviewed by Geoff Garen.
987
988         Add API test coverage.
989
990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
991         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
992         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
993         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
994         (TEST):
995
996 2019-04-16  Commit Queue  <commit-queue@webkit.org>
997
998         Unreviewed, rolling out r244321.
999         https://bugs.webkit.org/show_bug.cgi?id=196968
1000
1001         Causing all WK2 Debug builds to exit early after Assertion
1002         failures. (Requested by ShawnRoberts on #webkit).
1003
1004         Reverted changeset:
1005
1006         "URL set by document.open() is not communicated to the
1007         UIProcess"
1008         https://bugs.webkit.org/show_bug.cgi?id=196941
1009         https://trac.webkit.org/changeset/244321
1010
1011 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1012
1013         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1014         https://bugs.webkit.org/show_bug.cgi?id=196948
1015
1016         Reviewed by Zalan Bujtas.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1019         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1020
1021 2019-04-15  Chris Dumez  <cdumez@apple.com>
1022
1023         URL set by document.open() is not communicated to the UIProcess
1024         https://bugs.webkit.org/show_bug.cgi?id=196941
1025         <rdar://problem/49237544>
1026
1027         Reviewed by Geoffrey Garen.
1028
1029         Add API test coverage.
1030
1031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1032         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1033         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1034         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1035         (TEST):
1036
1037 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1038
1039         Using Tools/Scripts/clean-webkit should not install requests
1040         https://bugs.webkit.org/show_bug.cgi?id=196940
1041
1042         Reviewed by Lucas Forschler.
1043
1044         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1045         existing, depending on the path autoinstalled is run through.
1046         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1047         needed.
1048         (Port.configuration_for_upload):
1049         (Port.commits_for_upload):
1050
1051 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1052
1053         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1054         https://bugs.webkit.org/show_bug.cgi?id=196773
1055
1056         Reviewed by Jer Noble.
1057
1058         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1059         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1060         (TEST):
1061
1062 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1063
1064         ews-build should clearly indicate flaky test failures
1065         https://bugs.webkit.org/show_bug.cgi?id=196947
1066
1067         Reviewed by Lucas Forschler.
1068
1069         * BuildSlaveSupport/ews-build/steps.py:
1070         (AnalyzeAPITestsResults.analyzeResults):
1071
1072 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1073
1074         InjectedBundle parameters often need initialization function called before unarchiving
1075         https://bugs.webkit.org/show_bug.cgi?id=189709
1076         <rdar://problem/44573653>
1077
1078         Reviewed by Ryosuke Niwa.
1079
1080         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1081         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1082
1083 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1084
1085         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1086         https://bugs.webkit.org/show_bug.cgi?id=196681
1087
1088         Reviewed by Darin Adler.
1089
1090         Added tests.
1091
1092         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1093         (WTF_HashSet.RemoveIf):
1094         (WTF_HashSet.RemoveIfShrinkToBestSize):
1095
1096 2019-04-15  John Wilander  <wilander@apple.com>
1097
1098         Send delayed Ad Click Attribution conversion requests to the click source
1099         https://bugs.webkit.org/show_bug.cgi?id=196838
1100         <rdar://problem/47650157>
1101
1102         Reviewed by Chris Dumez and Youenn Fablet.
1103
1104         This patch adds test infrastructure to override the default behavior in
1105         WebKit::NetworkAdClickAttribution.
1106
1107         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1108         (TestWebKitAPI::TEST):
1109         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1111         (WTR::TestRunner::dumpAdClickAttribution):
1112         (WTR::TestRunner::clearAdClickAttribution):
1113         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1114         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1115         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1116         * WebKitTestRunner/TestController.cpp:
1117         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1118         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1119         * WebKitTestRunner/TestController.h:
1120         * WebKitTestRunner/TestInvocation.cpp:
1121         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1122
1123 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1124
1125         [ews-app] status-bubble should display position in queue
1126         https://bugs.webkit.org/show_bug.cgi?id=196607
1127
1128         Reviewed by Lucas Forschler.
1129
1130         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1131         (StatusBubble._build_bubble):
1132         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1133
1134 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1135
1136         [ews-build] Do not run clean build by default on EWS builders
1137         https://bugs.webkit.org/show_bug.cgi?id=196897
1138
1139         Reviewed by Lucas Forschler.
1140
1141         * BuildSlaveSupport/ews-build/steps.py:
1142         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1143         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1144         untracked directories like WebKitBuild).
1145         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1146         untracked files/directories (like WebKitBuild).
1147
1148 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1149
1150         TestRunner::notifyDone() should be safely reentrant
1151         https://bugs.webkit.org/show_bug.cgi?id=196898
1152
1153         Reviewed by Darin Adler.
1154
1155         It is currently possible that TestRunner::notifyDone() will call itself, since
1156         notifyDone() will force a repaint, which can start executing JavaScript, which
1157         may call notifyDone() again. This can lead to test failures and flakiness.
1158         Fix this by setting the m_waitToDump flag before calling the dump() method.
1159
1160         * DumpRenderTree/mac/TestRunnerMac.mm:
1161         (TestRunner::notifyDone):
1162         (TestRunner::forceImmediateCompletion):
1163         * DumpRenderTree/win/TestRunnerWin.cpp:
1164         (TestRunner::notifyDone):
1165         (TestRunner::forceImmediateCompletion):
1166
1167 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1168
1169         [GTK][WPE] Add enable-media websetting
1170         https://bugs.webkit.org/show_bug.cgi?id=196863
1171
1172         Reviewed by Michael Catanzaro.
1173
1174         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1175         (testWebKitSettings): Add test for the enable-media web-setting.
1176
1177 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1178
1179         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1180         https://bugs.webkit.org/show_bug.cgi?id=196905
1181         <rdar://problem/49886096>
1182
1183         Reviewed by Tim Horton.
1184
1185         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1186         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1187         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1188         delay timer, we end up with this sequence of events in the problematic (failure) case:
1189
1190         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1191             ...IPC from UI to web process...
1192         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1193             ...IPC from web to UI process...
1194         (c) [UI]    Invoke completion handler for script #1
1195         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1196             ...IPC from UI to web process...
1197         (e) [Web]   Evaluate script #2 in the web process
1198         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1199
1200         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1201         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1202         #2 is run in step (e).
1203
1204         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1205         the UI process by waiting on a script message posted by the web process, after attachment updates are
1206         dispatched.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1209         (TestWebKitAPI::TEST):
1210
1211 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1212
1213         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1214         https://bugs.webkit.org/show_bug.cgi?id=196909
1215
1216         Reviewed by Wenson Hsieh.
1217
1218         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1219         (TestWebKitAPI::TEST):
1220
1221 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1222
1223         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1224         https://bugs.webkit.org/show_bug.cgi?id=196880
1225
1226         Reviewed by Yusuke Suzuki.
1227
1228         Add a new function for bytecode cache tests that does not forceDiskCache
1229         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1230         test added in this patch, since the code is invalid and therefore won't be
1231         cached. It should also be useful for tests that evaluate dynamically
1232         generated code.
1233
1234         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1235         * Scripts/run-jsc-stress-tests:
1236
1237 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1238
1239         Update AudioSession route sharing policy
1240         https://bugs.webkit.org/show_bug.cgi?id=196776
1241         <rdar://problem/46501611>
1242
1243         Reviewed by Jer Noble.
1244
1245         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1246         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1247         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1248         (TestWebKitAPI::TEST):
1249
1250 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1251
1252         [iOS] Software keyboard is shown too frequently on some websites
1253         https://bugs.webkit.org/show_bug.cgi?id=195856
1254         <rdar://problem/49191395>
1255
1256         Reviewed by Darin Adler.
1257
1258         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1259
1260         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1261         (WTR::UIScriptController::setHardwareKeyboardAttached):
1262         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1263         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1264         (WTR::UIScriptController::setHardwareKeyboardAttached):
1265         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1266         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1267
1268         Additionally link against GraphicsServices in WebKitTestRunner.
1269
1270         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1271         (WTR::TestController::platformResetStateToConsistentValues):
1272         (WTR::UIScriptController::setHardwareKeyboardAttached):
1273
1274 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1275
1276         [GTK][WPE] Fix pacman install-dependencies packages
1277         https://bugs.webkit.org/show_bug.cgi?id=196817
1278
1279         Reviewed by Žan Doberšek.
1280         
1281         python3-setuptools is called python-setuptools
1282         ruby-highline is only available on AUR
1283         libv4l-devel is incorporated in v4l-utils
1284
1285         * gtk/install-dependencies:
1286         * wpe/install-dependencies:
1287
1288 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1289
1290         [GTK] REGRESSION(r243860): Many tests failing
1291         https://bugs.webkit.org/show_bug.cgi?id=196791
1292
1293         Reviewed by Joanmarie Diggs.
1294
1295         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1296         multiple documents and check that accessibility hierarchy is updated after a navigation.
1297
1298         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1299         (loadChangedCallback):
1300         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1301         (AccessibilityTest::AccessibilityTest):
1302         (AccessibilityTest::~AccessibilityTest):
1303         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1304         (AccessibilityTest::findTestServerApplication):
1305         (AccessibilityTest::findDocumentWeb):
1306         (AccessibilityTest::findRootObject):
1307         (AccessibilityTest::waitUntilChildrenRemoved):
1308         (AccessibilityTest::ensureProxy):
1309         (testAtspiBasicHierarchy):
1310         (beforeAll):
1311         (afterAll):
1312
1313 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1314
1315         [ews-build] Handle bug titles with unicode characters
1316         https://bugs.webkit.org/show_bug.cgi?id=196802
1317
1318         Reviewed by Dewei Zhu.
1319
1320         * BuildSlaveSupport/ews-build/steps.py:
1321         (ValidatePatch._is_bug_closed):
1322
1323 2019-04-11  Michael Saboff  <msaboff@apple.com>
1324
1325         Improve the Inline Cache Stats code
1326         https://bugs.webkit.org/show_bug.cgi?id=196836
1327
1328         Reviewed by Saam Barati.
1329
1330         Added a new script to consolidate and arrange the output of --useICStats option.
1331
1332         This script merges the output from every group into one large table and sorts it from most common to
1333         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1334         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1335         Put together, this is useful to see what property accesses are not getting cached.
1336
1337         * Scripts/ic-stats.py: Added.
1338         (ICStats):
1339         (ICStats.__init__):
1340         (ICStats.parse):
1341         (ICStats.dumpStats):
1342         (usage):
1343
1344 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1345
1346         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1347         https://bugs.webkit.org/show_bug.cgi?id=196809
1348         <rdar://49800762>
1349
1350         Reviewed by Brady Eidson.
1351
1352         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1353         (TEST):
1354
1355 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1356
1357         requestAnimationFrame should execute before the next frame
1358         https://bugs.webkit.org/show_bug.cgi?id=177484
1359
1360         Reviewed by Simon Fraser.
1361
1362         Add trace points for the page RenderingUpdate.
1363
1364         * Tracing/SystemTracePoints.plist:
1365
1366 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1367
1368         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1369         https://bugs.webkit.org/show_bug.cgi?id=196760
1370
1371         Reviewed by Don Olmstead.
1372
1373         vswhere.exe has been bundled since Visual Studio 2017 version
1374         15.2. We shouldn't download vswhere.exe.
1375
1376         * Scripts/build-jsc: Do not call update-vswhere.py.
1377         * Scripts/build-webkit: Ditto.
1378         * Scripts/update-vswhere.py: Removed.
1379         * Scripts/webkitdirs.pm:
1380         (requireModulesForVSWhere): Deleted.
1381         (pickCurrentVisualStudioInstallation): Deleted.
1382         (visualStudioInstallDirVSWhere): Return the latest installed VS
1383         installation path by using the bundled vswhere.exe.
1384         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1385         (visualStudioInstallDirFallback): Removed.
1386
1387 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1388
1389         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1390         https://bugs.webkit.org/show_bug.cgi?id=196780
1391
1392         Reviewed by Alexey Proskuryakov.
1393
1394         * BuildSlaveSupport/ews-build/steps.py:
1395         * BuildSlaveSupport/ews-build/steps_unittest.py:
1396
1397 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1398
1399         Add SPI WKNavigationResponse._downloadAttribute
1400         https://bugs.webkit.org/show_bug.cgi?id=196755
1401         <rdar://49587365>
1402
1403         Reviewed by Brady Eidson.
1404
1405         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1406         (-[NavigationResponseTestDelegate navigationResponse]):
1407         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1408         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1409         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1410         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1411         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1412         (readRequest):
1413         (writeResponse):
1414         (TEST):
1415
1416 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1417
1418         Add modern API for overriding the page's specified viewport configuration
1419         https://bugs.webkit.org/show_bug.cgi?id=167734
1420         <rdar://problem/30331795>
1421
1422         Reviewed by Simon Fraser.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1426
1427 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1428
1429         Add support for incremental bytecode cache updates
1430         https://bugs.webkit.org/show_bug.cgi?id=195000
1431
1432         Reviewed by Filip Pizlo.
1433
1434         Exit when the initial run to generate bytecode fails.
1435
1436         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1437
1438 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1439
1440         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1441         https://bugs.webkit.org/show_bug.cgi?id=196744
1442         <rdar://49415309>
1443
1444         Reviewed by Chris Dumez.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1447         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1448
1449 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1450
1451         Add a way to opt into modern compatibility mode in layout tests
1452         https://bugs.webkit.org/show_bug.cgi?id=196770
1453         <rdar://problem/49777550>
1454
1455         Reviewed by Antoine Quint.
1456
1457         Add a new test option to enable modern compatibility mode in layout tests.
1458
1459         * WebKitTestRunner/TestController.cpp:
1460         (WTR::updateTestOptionsFromTestHeader):
1461         * WebKitTestRunner/TestController.h:
1462         * WebKitTestRunner/TestOptions.h:
1463         (WTR::TestOptions::hasSameInitializationOptions const):
1464         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1465         (WTR::TestController::platformCreateWebView):
1466         (WTR::TestController::enableModernCompatibilityMode):
1467
1468 2019-04-10  Andy Estes  <aestes@apple.com>
1469
1470         Try to fix the 32-bit watchOS build.
1471
1472         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1473         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1474
1475 2019-04-10  Antoine Quint  <graouts@apple.com>
1476
1477         Enable Pointer Events on watchOS
1478         https://bugs.webkit.org/show_bug.cgi?id=196771
1479         <rdar://problem/49040909>
1480
1481         Reviewed by Dean Jackson.
1482
1483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1484
1485 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1486
1487         Unreviewed. Fix WPE accessibility tests after r244059.
1488
1489         We are failing to load the injected bundle due to undefined symbol
1490         AccessibilityUIElement::replaceTextInRange().
1491
1492         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1493         (WTR::AccessibilityUIElement::replaceTextInRange):
1494
1495 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1496
1497         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1498         https://bugs.webkit.org/show_bug.cgi?id=196727
1499
1500         Reviewed by Fujii Hironori.
1501
1502         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1503         (WebKitBrowserWindow::create):
1504
1505 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1506
1507         [ews-build] Add unit tests for PrintConfiguration
1508         https://bugs.webkit.org/show_bug.cgi?id=196752
1509
1510         Reviewed by Dewei Zhu.
1511
1512         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1513
1514 2019-04-09  Keith Rollin  <krollin@apple.com>
1515
1516         Unreviewed build maintenance -- update .xcfilelists.
1517
1518         * DumpRenderTree/DerivedSources-input.xcfilelist:
1519         * DumpRenderTree/DerivedSources-output.xcfilelist:
1520
1521 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1522
1523         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1524         https://bugs.webkit.org/show_bug.cgi?id=196743
1525         <rdar://problem/43897551>
1526
1527         Reviewed by Tim Horton.
1528
1529         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1530         (TEST):
1531
1532 2019-04-09  Youenn Fablet  <youenn@apple.com>
1533
1534         Close service worker database on network process suspension
1535         https://bugs.webkit.org/show_bug.cgi?id=196623
1536         <rdar://problem/48930869>
1537
1538         Reviewed by Alex Christensen.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1541
1542 2019-04-09  Daniel Bates  <dabates@apple.com>
1543
1544         [iPad] Should open popover when the spacebar is pressed
1545         https://bugs.webkit.org/show_bug.cgi?id=196360
1546         <rdar://problem/49389129>
1547
1548         Reviewed by Brent Fulgham.
1549
1550         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1551
1552         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1553         (WTR::UIScriptController::isShowingPopover const): Added.
1554         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1555         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1556         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1557         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1558         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1559         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1560         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1561         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1562         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1563         (WTR::UIScriptController::isShowingPopover const): Added.
1564         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1565         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1566         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1567         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1568         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1569         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1570         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1571         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1572         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1573         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1574         (WTR::UIScriptController::isShowingPopover const): Added.
1575         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1576         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1577
1578 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1579
1580         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1581         https://bugs.webkit.org/show_bug.cgi?id=196665
1582         <rdar://45115669>
1583
1584         Reviewed by Geoff Garen.
1585
1586         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1587         (goBack):
1588         (+[SimpleLookupContext sharedLookupContext]):
1589         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1590         (TEST):
1591         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1592         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1593
1594 2019-04-09  John Wilander  <wilander@apple.com>
1595
1596         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1597         https://bugs.webkit.org/show_bug.cgi?id=196558
1598         <rdar://problem/47650245>
1599
1600         Reviewed by Youenn Fablet.
1601
1602         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1603         (TestWebKitAPI::TEST):
1604             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1605
1606 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1607
1608         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1609         https://bugs.webkit.org/show_bug.cgi?id=196720
1610
1611         Reviewed by Konstantin Tokarev.
1612
1613         * TestWebKitAPI/PlatformMac.cmake:
1614
1615 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1616
1617         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1618         https://bugs.webkit.org/show_bug.cgi?id=196694
1619         <rdar://problem/48388734>
1620
1621         Rubber-stamped by Aakash Jain.
1622
1623         * Scripts/webkitpy/port/image_diff.py:
1624         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1625         * Scripts/webkitpy/port/server_process.py:
1626         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1627         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1628         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1629         * Scripts/webkitpy/port/server_process_mock.py:
1630         (MockServerProcess.has_available_stdout):
1631         * Scripts/webkitpy/port/server_process_unittest.py:
1632         (TestServerProcess.serial_test_basic):
1633
1634 2019-04-09  Jer Noble  <jer.noble@apple.com>
1635
1636         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1637         https://bugs.webkit.org/show_bug.cgi?id=196097
1638
1639         Reviewed by Eric Carlson.
1640
1641         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1642
1643         * DumpRenderTree/mac/DumpRenderTree.mm:
1644         (resetWebPreferencesToConsistentValues):
1645         * WebKitTestRunner/TestController.cpp:
1646         (WTR::TestController::resetPreferencesToConsistentValues):
1647
1648 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1649
1650         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1651         https://bugs.webkit.org/show_bug.cgi?id=196690
1652
1653         Reviewed by Michael Catanzaro.
1654
1655         * QueueStatusServer/config/queues.py:
1656         * Scripts/webkitpy/common/config/ews.json:
1657         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1658         (test_ews_name):
1659
1660 2019-04-09  Chris Dumez  <cdumez@apple.com>
1661
1662         Loads using loadHTMLString() cause flashing when process-swapping
1663         https://bugs.webkit.org/show_bug.cgi?id=196714
1664         <rdar://problem/49637354>
1665
1666         Reviewed by Antti Koivisto.
1667
1668         Add API test coverage.
1669
1670         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1671
1672 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1673
1674         Unreviewed. Fix ATK accessibility tests after r244059.
1675
1676         We are failing to load the injected bundle due to undefined symbol
1677         AccessibilityUIElement::replaceTextInRange().
1678
1679         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1680         (WTR::AccessibilityUIElement::replaceTextInRange):
1681
1682 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1683
1684         AX: Support API: accessibilityReplaceRange:withText
1685         https://bugs.webkit.org/show_bug.cgi?id=196636
1686
1687         Unreviewed build fix for Windows port.
1688
1689         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1690         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1691
1692 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1693
1694         [CMake][WinCairo] Separate copied headers into different directories
1695         https://bugs.webkit.org/show_bug.cgi?id=196655
1696
1697         Reviewed by Michael Catanzaro.
1698
1699         * DumpRenderTree/CMakeLists.txt:
1700         * MiniBrowser/win/CMakeLists.txt:
1701         * TestWebKitAPI/CMakeLists.txt:
1702         * TestWebKitAPI/PlatformWin.cmake:
1703
1704 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1705
1706         Log stack-trace for run-webkit-tests when interrupted
1707         https://bugs.webkit.org/show_bug.cgi?id=176393
1708         <rdar://problem/34262310>
1709
1710         Reviewed by Lucas Forschler.
1711
1712         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1713         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1714         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1715         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1716         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1717         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1718         (main): Set handlers to log stack trace on interruption.
1719
1720 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1721
1722         AX: Support API: accessibilityReplaceRange:withText
1723         https://bugs.webkit.org/show_bug.cgi?id=196636
1724
1725         Unreviewed build fix for Windows port.
1726
1727         * DumpRenderTree/AccessibilityUIElement.cpp:
1728         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1729
1730 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1731
1732         [ews-build] Scripts using Buildbot API have CORS error
1733         https://bugs.webkit.org/show_bug.cgi?id=196709
1734
1735         Reviewed by Alexey Proskuryakov.
1736
1737         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1738
1739 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1740
1741         AX: Support API: accessibilityReplaceRange:withText
1742         https://bugs.webkit.org/show_bug.cgi?id=196636
1743
1744         Reviewed by Daniel Bates.
1745
1746         * DumpRenderTree/AccessibilityUIElement.cpp:
1747         (replaceTextInRangeCallback):
1748         (AccessibilityUIElement::replaceTextInRange):
1749         (AccessibilityUIElement::getJSClass):
1750         * DumpRenderTree/AccessibilityUIElement.h:
1751         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1752         (AccessibilityUIElement::replaceTextInRange):
1753         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1754         (AccessibilityUIElement::replaceTextInRange):
1755         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1756         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1757         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1758         (WTR::AccessibilityUIElement::replaceTextInRange):
1759         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1760         (WTR::AccessibilityUIElement::replaceTextInRange):
1761
1762 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1763
1764         [iOS] Do not allow starting selection drags when selection views are not visible
1765         https://bugs.webkit.org/show_bug.cgi?id=196686
1766         <rdar://problem/49399192>
1767
1768         Reviewed by Tim Horton.
1769
1770         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1771         also add some new API tests to cover scenarios where the web view is not first responder.
1772
1773         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1774         (TestWebKitAPI::TEST):
1775         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1776
1777         Add a switch to optionally make the web view first responder when starting the simulated drag.
1778
1779         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1780         (-[DragAndDropSimulator initWithWebView:]):
1781         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1782
1783 2019-04-08  Justin Fan  <justin_fan@apple.com>
1784
1785         [Web GPU] Fix Web GPU experimental feature on iOS
1786         https://bugs.webkit.org/show_bug.cgi?id=196632
1787
1788         Reviewed by Myles C. Maxfield.
1789
1790         Properly make Web GPU available on iOS 11+.
1791
1792         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1793
1794 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1795
1796         [ews-build] Do not upload archive when Compile Fails
1797         https://bugs.webkit.org/show_bug.cgi?id=196674
1798
1799         Reviewed by Alexey Proskuryakov.
1800
1801         * BuildSlaveSupport/ews-build/factories.py:
1802         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1803         * BuildSlaveSupport/ews-build/steps.py:
1804         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1805         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1806         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1807
1808 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1809
1810         Enable DFG on MIPS
1811         https://bugs.webkit.org/show_bug.cgi?id=196689
1812
1813         Reviewed by Žan Doberšek.
1814
1815         Since the bytecode change, we enabled the baseline JIT on mips in
1816         r240432, but DFG is still missing. With this change, all tests are
1817         passing on a ci20 board.
1818
1819         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1820
1821 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1822
1823         [Flatpak] Second run update-webkitwpe-flatpak fails
1824         https://bugs.webkit.org/show_bug.cgi?id=192702
1825
1826         Reviewed by Carlos Garcia Campos.
1827
1828         * flatpak/flatpakutils.py:
1829         (FlatpakObject.flatpak): Fix typo.
1830         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1831         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1832
1833 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1834
1835         [GTK][WPE] outlook.live.com displays old-fashioned UI
1836         https://bugs.webkit.org/show_bug.cgi?id=196642
1837
1838         Reviewed by Carlos Garcia Campos.
1839
1840         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1841         (TestWebKitAPI::TEST): New Mac platform quirk test.
1842
1843 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1844
1845         Unreviewed, rolling out r243956.
1846         https://bugs.webkit.org/show_bug.cgi?id=196688
1847
1848         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1849         by aakashjain on #webkit).
1850
1851         Reverted changeset:
1852
1853         "Clicking "Go Back" from a safe browsing warning from an
1854         iframe should navigate the WKWebView back to the previous
1855         page"
1856         https://bugs.webkit.org/show_bug.cgi?id=196665
1857         https://trac.webkit.org/changeset/243956
1858
1859 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1860
1861         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1862         https://bugs.webkit.org/show_bug.cgi?id=196669
1863
1864         Reviewed by Geoffrey Garen.
1865
1866         Added three new unit tests for WeakHashSet.
1867
1868         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1869         (WTF_WeakPtr.WeakHashSetConstObjects):
1870         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1871         (WTF_WeakPtr.WeakHashSetComputeSize):
1872
1873 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1874
1875         Hide next and previous form control buttons when WKWebView is editable
1876         https://bugs.webkit.org/show_bug.cgi?id=196672
1877         <rdar://problem/35625321>
1878
1879         Reviewed by Tim Horton.
1880
1881         Add a new API test.
1882
1883         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1884         (-[TestWKWebView lastTrailingBarButtonGroup]):
1885         (TestWebKitAPI::TEST):
1886         * TestWebKitAPI/ios/UIKitSPI.h:
1887
1888 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1889
1890         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1891         https://bugs.webkit.org/show_bug.cgi?id=196077
1892         <rdar://problem/49108202>
1893
1894         Reviewed by Chris Dumez.
1895
1896         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1897         on new web view.
1898
1899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1900
1901 2019-04-05  Saam Barati  <sbarati@apple.com>
1902
1903         Make compare-results understand MotionMark
1904         https://bugs.webkit.org/show_bug.cgi?id=196666
1905
1906         Reviewed by Yusuke Suzuki.
1907
1908         * Scripts/compare-results:
1909         (PLT5Results):
1910         (detectMotionMark):
1911         (detectMotionMark1_1):
1912         (motionMarkResults):
1913         (motionMark1_1Results):
1914         (detectBenchmark):
1915         (biggerIsBetter):
1916         (main):
1917
1918 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1919
1920         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1921         https://bugs.webkit.org/show_bug.cgi?id=196665
1922         <rdar://45115669>
1923
1924         Reviewed by Geoff Garen.
1925
1926         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1927         (goBack):
1928         (+[SimpleLookupContext sharedLookupContext]):
1929         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1930         (TEST):
1931         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1932         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1933
1934 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1935
1936         [ews-build] Add configuration and architecture for windows builders
1937         https://bugs.webkit.org/show_bug.cgi?id=196660
1938
1939         Reviewed by Lucas Forschler.
1940
1941         * BuildSlaveSupport/ews-build/config.json:
1942
1943 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1944
1945         webkitpy: Don't run subsequent rounds if interrupted
1946         https://bugs.webkit.org/show_bug.cgi?id=196646
1947
1948         Reviewed by Aakash Jain.
1949
1950         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1951         (Manager.run): Bail out if interrupted.
1952
1953 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1954
1955         Test sessionStorage in PSON private browsing mode
1956         https://bugs.webkit.org/show_bug.cgi?id=196561
1957
1958         Reviewed by Alex Christensen.
1959
1960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1961
1962 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1963
1964         Unreviewed, rolling out r243833.
1965         https://bugs.webkit.org/show_bug.cgi?id=196645
1966
1967         This change breaks build of WPE and GTK ports (Requested by
1968         annulen on #webkit).
1969
1970         Reverted changeset:
1971
1972         "[CMake][WTF] Mirror XCode header directories"
1973         https://bugs.webkit.org/show_bug.cgi?id=191662
1974         https://trac.webkit.org/changeset/243833
1975
1976 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1977
1978         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1979         https://bugs.webkit.org/show_bug.cgi?id=196635
1980
1981         Reviewed by Antti Koivisto.
1982         
1983         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1984         for a test to enable async frame scrolling via:
1985             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1986         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1987         
1988         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1989
1990         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1991         (WTR::InjectedBundle::beginTesting):
1992         * WebKitTestRunner/TestController.cpp:
1993         (WTR::TestController::resetPreferencesToConsistentValues):
1994
1995 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1996
1997         Use a correct LC_RPATH when building with ASan
1998         https://bugs.webkit.org/show_bug.cgi?id=196576
1999
2000         Reviewed by David Kilzer.
2001
2002         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2003         so that ../Frameworks is checked. This is simpler and more reliable than updating
2004         each SPC service xcconfig.
2005
2006 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2007
2008         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2009         https://bugs.webkit.org/show_bug.cgi?id=196629
2010
2011         Reviewed by Lucas Forschler.
2012
2013         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2014
2015 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2016
2017         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2018         https://bugs.webkit.org/show_bug.cgi?id=196618
2019
2020         Reviewed by Lucas Forschler.
2021
2022         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2023         (StatusBubble): Added QUEUE_TRIGGERS.
2024         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2025         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2026         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2027         its parent(builder).
2028
2029 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2030
2031         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2032         https://bugs.webkit.org/show_bug.cgi?id=196625
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2037         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2038
2039 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2040
2041         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2042         https://bugs.webkit.org/show_bug.cgi?id=196630
2043
2044         Reviewed by Wenson Hsieh.
2045
2046         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2047
2048 2019-04-04  Youenn Fablet  <youenn@apple.com>
2049
2050         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2051         https://bugs.webkit.org/show_bug.cgi?id=196543
2052
2053         Reviewed by Alex Christensen.
2054
2055         * WebKitTestRunner/TestController.cpp:
2056         (WTR::TestController::generatePageConfiguration):
2057
2058 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2059
2060         [ews-app] Status bubble should not display skipped buildbot steps
2061         https://bugs.webkit.org/show_bug.cgi?id=196584
2062
2063         Reviewed by Lucas Forschler.
2064
2065         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2066
2067 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2068
2069         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2070         https://bugs.webkit.org/show_bug.cgi?id=196620
2071
2072         Reviewed by Lucas Forschler.
2073
2074         * BuildSlaveSupport/ews-app/ews/config.py:
2075
2076 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2077
2078         [Win] DumpRenderTreeWatchDog.py is not checked into source
2079         https://bugs.webkit.org/show_bug.cgi?id=196567
2080         <rdar://problem/49525901>
2081
2082         Reviewed by Lucas Forschler.
2083
2084         This script is used on Win EWS bots to terminate hanging DRT processes.
2085
2086         * EWSTools/dumprendertreewatchdog.py: Added.
2087
2088 2019-04-04  Chris Dumez  <cdumez@apple.com>
2089
2090         Unreviewed, roll out r243858 which made tests time out.
2091
2092         Disable new API tests on Windows instead.
2093
2094         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2095         (TestWebKitAPI::TEST):
2096
2097 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2098
2099         [ATK] Cleanup WebPageAccessibilityObjectAtk
2100         https://bugs.webkit.org/show_bug.cgi?id=196537
2101
2102         Reviewed by Michael Catanzaro.
2103
2104         Also consider files under atk directories as exceptions for GObject conventions.
2105
2106         * Scripts/webkitpy/style/checkers/cpp.py:
2107         (check_identifier_name_in_declaration):
2108
2109 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2110
2111         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2112         https://bugs.webkit.org/show_bug.cgi?id=196588
2113         <rdar://problem/49365787>
2114
2115         Unreviewed build fix for Windows port.
2116
2117         error C3861: 'kill': identifier not found
2118
2119         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2120         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2121
2122 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2123
2124         [ews-build] Cancel build and similar operations should have authentication
2125         https://bugs.webkit.org/show_bug.cgi?id=196520
2126
2127         Reviewed by Dewei Zhu.
2128
2129         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2130         environment variables.
2131
2132 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2133
2134         [ews-build] Do not trigger queues which are not in production yet
2135         https://bugs.webkit.org/show_bug.cgi?id=196581
2136
2137         Reviewed by Dewei Zhu.
2138
2139         * BuildSlaveSupport/ews-build/config.json:
2140
2141 2019-04-03  Chris Dumez  <cdumez@apple.com>
2142
2143         Unreviewed, fix typo in the name of API test added in r243848.
2144
2145         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2146         (TestWebKitAPI::TEST):
2147
2148 2019-04-03  Chris Dumez  <cdumez@apple.com>
2149
2150         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2151         https://bugs.webkit.org/show_bug.cgi?id=196588
2152         <rdar://problem/49365787>
2153
2154         Reviewed by Ryosuke Niwa.
2155
2156         Add API test coverage.
2157
2158         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2159         (TestWebKitAPI::nullJavaScriptCallback):
2160         (TestWebKitAPI::didCrashCheckFrames):
2161         (TestWebKitAPI::TEST):
2162
2163 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2164
2165         run-webkit-tests: Upload test results (new results database)
2166         https://bugs.webkit.org/show_bug.cgi?id=196577
2167         <rdar://problem/34841155>
2168
2169         Reviewed by Lucas Forschler.
2170
2171         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2172         (Manager.run): Upload results after each device shard, since the configuration will be
2173         different for each device.
2174         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2175         uploaded to a results database.
2176         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2177         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2178
2179 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2180
2181         -apple-trailing-word is needed for browser detection
2182         https://bugs.webkit.org/show_bug.cgi?id=196575
2183
2184         Unreviewed.
2185
2186         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2187
2188 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2189
2190         [CMake][WTF] Mirror XCode header directories
2191         https://bugs.webkit.org/show_bug.cgi?id=191662
2192
2193         Reviewed by Konstantin Tokarev.
2194
2195         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2196         builds.
2197
2198         * CMakeLists.txt:
2199         * DumpRenderTree/CMakeLists.txt:
2200         * DumpRenderTree/PlatformWin.cmake:
2201         * MiniBrowser/win/CMakeLists.txt:
2202         * TestWebKitAPI/CMakeLists.txt:
2203         * TestWebKitAPI/PlatformWin.cmake:
2204         * WebKitTestRunner/PlatformGTK.cmake:
2205         * WebKitTestRunner/PlatformWin.cmake:
2206
2207 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2208
2209         [ews-app] Status bubble should not display certain infrastructure status messages
2210         https://bugs.webkit.org/show_bug.cgi?id=196550
2211
2212         Reviewed by Lucas Forschler.
2213
2214         Do not display the steps which are un-needed for end-user. This information is still avaiable
2215         if the user click on the bubble and look at the Buildbot build.
2216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2217         (StatusBubble._steps_messages):
2218         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2219
2220 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-build] Use https for sending data to ews-app
2223         https://bugs.webkit.org/show_bug.cgi?id=196492
2224
2225         Reviewed by Lucas Forschler.
2226
2227         * BuildSlaveSupport/ews-build/events.py:
2228
2229 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2230
2231         Remove support for -apple-trailing-word
2232         https://bugs.webkit.org/show_bug.cgi?id=196525
2233
2234         Reviewed by Zalan Bujtas.
2235
2236         This CSS property is nonstandard and not used.
2237
2238         * Scripts/webkitperl/FeatureList.pm:
2239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2240
2241 2019-04-03  Youenn Fablet  <youenn@apple.com>
2242
2243         Add a test for DOMCache on multiple browsing in case of private browsing
2244         https://bugs.webkit.org/show_bug.cgi?id=196524
2245
2246         Reviewed by Alex Christensen.
2247
2248         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2249         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2250
2251 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2252
2253         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2254         https://bugs.webkit.org/show_bug.cgi?id=196540
2255
2256         Reviewed by Aakash Jain.
2257
2258         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2259
2260 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2261
2262         Add plumbing for a compatibility mode preference in WebKit
2263         https://bugs.webkit.org/show_bug.cgi?id=196005
2264
2265         Reviewed by Tim Horton.
2266
2267         Add new API tests.
2268
2269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2271
2272 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2273
2274         [WPE][GTK] Update libsrtp dependency package for Debian
2275         https://bugs.webkit.org/show_bug.cgi?id=196528
2276
2277         Reviewed by Frédéric Wang.
2278
2279         * gtk/install-dependencies:
2280         * wpe/install-dependencies:
2281
2282 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2283
2284         [WK2] Add support for Window's beforeprint / afterprint events
2285         https://bugs.webkit.org/show_bug.cgi?id=196478
2286         <rdar://problem/49535124>
2287
2288         Unreviewed build fix for MSVC.
2289
2290         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2291
2292         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2293
2294         * WebKitTestRunner/TestController.cpp:
2295         (WTR::printFrame): Use int and float literals.
2296
2297 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2298
2299         [ews-build] Reassign bots to queues
2300
2301         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2302
2303 2019-04-02  Chris Dumez  <cdumez@apple.com>
2304
2305         [WK2] Add support for Window's beforeprint / afterprint events
2306         https://bugs.webkit.org/show_bug.cgi?id=196478
2307
2308         Reviewed by Alex Christensen.
2309
2310         Add minimal implementation for printFrame in WebKitTestRunner.
2311
2312         * WebKitTestRunner/TestController.cpp:
2313         (WTR::printFrame):
2314         (WTR::TestController::createOtherPage):
2315         (WTR::TestController::createWebViewWithOptions):
2316
2317 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2320         https://bugs.webkit.org/show_bug.cgi?id=196491
2321
2322         Reviewed by Lucas Forschler.
2323
2324         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2325
2326 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-build] Configure buildbot try credentials in environment variables
2329         https://bugs.webkit.org/show_bug.cgi?id=196501
2330
2331         Reviewed by Lucas Forschler.
2332
2333         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2334         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2335         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2336
2337 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2338
2339         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2340         https://bugs.webkit.org/show_bug.cgi?id=196496
2341         <rdar://problem/49521634>
2342
2343         Reviewed by Chris Dumez.
2344
2345         Add new API tests (see WebKit ChangeLog for more detail).
2346
2347         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2348         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2349         (TEST):
2350
2351 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2352
2353         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2354         <https://webkit.org/b/196499>
2355
2356         Reviewed by Alexey Proskuryakov.
2357
2358         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2359         ENABLE_ADDRESS_SANITIZER.
2360
2361 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2362
2363         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2364         https://bugs.webkit.org/show_bug.cgi?id=182757
2365
2366         Reviewed by Don Olmstead.
2367
2368         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2369         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2370
2371 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2372
2373         run-api-tests: Upload test results
2374         https://bugs.webkit.org/show_bug.cgi?id=196323
2375         <rdar://problem/49356714>
2376
2377         Reviewed by Lucas Forschler.
2378
2379         * Scripts/webkitpy/api_tests/manager.py:
2380         (Manager):
2381         (Manager.run): Upload results to a results database.
2382         * Scripts/webkitpy/api_tests/run_api_tests.py:
2383         (parse_args): Add upload arguments.
2384         * Scripts/webkitpy/port/base.py:
2385         (Port):
2386         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2387         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2388         with commits from any other associated repositories.
2389         * Scripts/webkitpy/port/device.py:
2390         (Device):
2391         (Device.build_version): Access build_versoin of underlying platform device.
2392         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2393         (IOSSimulatorTest):
2394         (IOSSimulatorTest.test_configuration_for_upload):
2395         * Scripts/webkitpy/port/device_port.py:
2396         (DevicePort):
2397         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2398         the same as the machine uploading results.
2399         * Scripts/webkitpy/port/mac.py:
2400         (MacPort):
2401         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2402         * Scripts/webkitpy/port/mac_unittest.py:
2403         (MacTest):
2404         (MacTest.test_configuration_for_upload):
2405         * Scripts/webkitpy/xcode/simulated_device.py:
2406         (SimulatedDeviceManager._create_device_with_runtime):
2407         (SimulatedDevice.__init__): Create simulated device with a build_version.
2408         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2409         (test_existing_simulator):
2410
2411 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2412
2413         Remove extra newline characters (Follow-up fix to r243707)
2414
2415         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2416
2417 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2418
2419         [ews-app] Use API_KEY to accept results data
2420         https://bugs.webkit.org/show_bug.cgi?id=196461
2421
2422         Reviewed by Dewei Zhu.
2423
2424         * BuildSlaveSupport/ews-app/ews/views/results.py:
2425         (Results.post): Validate EWS_API_KEY before accepting any data.
2426         * BuildSlaveSupport/ews-build/events.py:
2427         (Events.sendData): Send EWS_API_KEY if available along with event data.
2428
2429 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2430
2431         Unable to copy and paste a PDF from Notes into Mail compose body
2432         https://bugs.webkit.org/show_bug.cgi?id=196442
2433         <rdar://problem/48573098>
2434
2435         Reviewed by Tim Horton.
2436
2437         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2438         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2439         to be specified on the item providers.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2442         (TestWebKitAPI::mapItemForTesting):
2443         (TestWebKitAPI::contactItemForTesting):
2444
2445 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2446
2447         Make UIWKDocumentContext rects per-character instead of per-word
2448         https://bugs.webkit.org/show_bug.cgi?id=196459
2449
2450         Reviewed by Wenson Hsieh.
2451
2452         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2453         (TEST):
2454         Adjust test results due to switching to per-character rects.
2455
2456 2019-04-01  Chris Dumez  <cdumez@apple.com>
2457
2458         UIProcess crash when a prewarmed process is terminated
2459         https://bugs.webkit.org/show_bug.cgi?id=196451
2460         <rdar://problem/49245471>
2461
2462         Reviewed by Geoffrey Garen.
2463
2464         Add API test coverage.
2465
2466         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2467         (TEST):
2468
2469 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2470
2471         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2472         https://bugs.webkit.org/show_bug.cgi?id=196449
2473
2474         Reviewed by Lucas Forschler.
2475
2476         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2477         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2478         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2479         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2480
2481 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2482
2483         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2484         https://bugs.webkit.org/show_bug.cgi?id=196444
2485
2486         Reviewed by Lucas Forschler.
2487
2488         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2489
2490 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2491
2492         Add SPI to canonicalize NSURLs with WTF::URL
2493         https://bugs.webkit.org/show_bug.cgi?id=196415
2494         <rdar://problem/44980271>
2495
2496         Reviewed by Darin Adler.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2500         (TestWebKitAPI::TEST):
2501
2502 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2503
2504         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2505         https://bugs.webkit.org/show_bug.cgi?id=196441
2506
2507         Reviewed by Carlos Garcia Campos.
2508
2509         Don't cache the wpe_view_backend object that might not exist yet at the
2510         time of EventSenderProxy constructor invocation, but instead retrieve
2511         that object whenever it's required for event dispatching. This should
2512         avoid crashes in this constructor now that it's invoked before any
2513         PlatformWindow has been set up (as changed in r243496).
2514
2515         * WebKitTestRunner/EventSenderProxy.h:
2516         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2517         (WTR::viewBackend):
2518         (WTR::EventSenderProxy::EventSenderProxy):
2519         (WTR::EventSenderProxy::mouseDown):
2520         (WTR::EventSenderProxy::mouseUp):
2521         (WTR::EventSenderProxy::mouseMoveTo):
2522         (WTR::EventSenderProxy::mouseScrollBy):
2523         (WTR::EventSenderProxy::keyDown):
2524         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2525
2526 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2527
2528         [Win][WebKit] MiniBrowser should support high DPI display
2529         https://bugs.webkit.org/show_bug.cgi?id=196391
2530
2531         Reviewed by Alex Christensen.
2532
2533         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2534         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2535         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2536         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2537
2538 2019-03-31  Sam Weinig  <weinig@apple.com>
2539
2540         Remove more i386 specific configurations
2541         https://bugs.webkit.org/show_bug.cgi?id=196430
2542
2543         Reviewed by Alexey Proskuryakov.
2544
2545         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2546         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2547
2548 2019-03-31  Andy Estes  <aestes@apple.com>
2549
2550         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2551         https://bugs.webkit.org/show_bug.cgi?id=196433
2552         <rdar://problem/49293305>
2553
2554         Reviewed by Tim Horton.
2555
2556         Enhanced API test coverage to include all navigation response policy decisions in both
2557         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2558
2559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2560         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2561         (TestWebKitAPI::TEST):
2562         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2563         (readFile):
2564         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2565         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2566         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2567         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2568         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2569         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2570         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2571         (-[QuickLookDelegate _downloadDidStart:]):
2572         (-[QuickLookDelegate _download:didReceiveResponse:]):
2573         (-[QuickLookDelegate _download:didReceiveData:]):
2574         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2575         (-[QuickLookDelegate _downloadDidFinish:]):
2576         (-[QuickLookDelegate _download:didFailWithError:]):
2577         (-[QuickLookDelegate _downloadDidCancel:]):
2578         (-[QuickLookDelegate verifyDownload]):
2579         (runTest):
2580         (runTestDecideBeforeLoading):
2581         (runTestDecideAfterLoading):
2582         (TEST):
2583         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2584         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2585         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2586         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2587         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2588         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2589         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2590         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2591         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2592         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2593         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2594         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2595         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2596         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2597
2598 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2599
2600         [CMake] add testdfg as target with build-jsc
2601         https://bugs.webkit.org/show_bug.cgi?id=196393
2602
2603         Reviewed by Saam Barati.
2604
2605         Added testdfg as one of the targets to build when
2606         using CMake.
2607
2608         * Scripts/build-jsc:
2609
2610 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2611
2612         Delete WebMetal implementation in favor of WebGPU
2613         https://bugs.webkit.org/show_bug.cgi?id=195418
2614
2615         Reviewed by Dean Jackson.
2616
2617         * DumpRenderTree/mac/DumpRenderTree.mm:
2618         (enableExperimentalFeatures):
2619         (resetWebPreferencesToConsistentValues):
2620         * Scripts/webkitperl/FeatureList.pm:
2621         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2623         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2624         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2625         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2626         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2627         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2628         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2629         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2631         (WTR::InjectedBundle::beginTesting):
2632         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2633         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2634         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2635
2636 2019-03-29  Chris Dumez  <cdumez@apple.com>
2637
2638         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2639         https://bugs.webkit.org/show_bug.cgi?id=196405
2640         <rdar://problem/49428130>
2641
2642         Reviewed by Wenson Hsieh.
2643
2644         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2645         the popover presentation methods to be no-ops. Use this in the new test added in
2646         r243523 so that we do not swizzle those methods for all tests. This is needed because
2647         those WatchOS tests rely on the popover getting presented and interactive.
2648
2649         * WebKitTestRunner/TestController.cpp:
2650         (WTR::updateTestOptionsFromTestHeader):
2651         * WebKitTestRunner/TestController.h:
2652         * WebKitTestRunner/TestOptions.h:
2653         (WTR::TestOptions::hasSameInitializationOptions const):
2654         * WebKitTestRunner/ios/TestControllerIOS.mm:
2655         (WTR::TestController::platformInitialize):
2656         (WTR::TestController::platformResetStateToConsistentValues):
2657
2658 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2659
2660         [Curl] Add Server Trust Evaluation Support.
2661         https://bugs.webkit.org/show_bug.cgi?id=191646
2662
2663         Reviewed by Fujii Hironori.
2664
2665         Implemented MiniBrowser UI for asking if user trusts the server.
2666
2667         * MiniBrowser/win/Common.cpp:
2668         (askServerTrustEvaluation):
2669         (replaceString):
2670         * MiniBrowser/win/Common.h:
2671         * MiniBrowser/win/MiniBrowserLib.rc:
2672         * MiniBrowser/win/MiniBrowserLibResource.h:
2673         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2674         (createPEMString):
2675         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2676         (WebKitBrowserWindow::canTrustServerCertificate):
2677         * MiniBrowser/win/WebKitBrowserWindow.h:
2678
2679 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2680
2681         Implement ResizeObserver.
2682         https://bugs.webkit.org/show_bug.cgi?id=157743
2683
2684         Reviewed by Simon Fraser.
2685
2686         Support resizeObserverEnabled webPreferences.
2687
2688         * DumpRenderTree/TestOptions.cpp:
2689         (TestOptions::TestOptions):
2690         * DumpRenderTree/TestOptions.h:
2691         * DumpRenderTree/mac/DumpRenderTree.mm:
2692         (setWebPreferencesForTestOptions):
2693         * DumpRenderTree/win/DumpRenderTree.cpp:
2694         (enableExperimentalFeatures):
2695         * Scripts/webkitperl/FeatureList.pm:
2696         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2697
2698 2019-03-28  John Wilander  <wilander@apple.com>
2699
2700         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2701         https://bugs.webkit.org/show_bug.cgi?id=196281
2702         <rdar://problem/48938748>
2703
2704         Reviewed by Alex Christensen.
2705
2706         This patch adds the function isStatisticsHasLocalStorage() to the
2707         TestRunner. With it, the page can query the WebsiteDataStore in the
2708         UI process to make sure that it sees LocalStorage.
2709
2710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2712         (WTR::TestRunner::isStatisticsHasLocalStorage):
2713         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2714         * WebKitTestRunner/TestController.cpp:
2715         (WTR::TestController::isStatisticsHasLocalStorage):
2716         * WebKitTestRunner/TestController.h:
2717         * WebKitTestRunner/TestInvocation.cpp:
2718         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2719
2720 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2721
2722         API::Data::createWithoutCopying should do a null check before calling CFRelease
2723         https://bugs.webkit.org/show_bug.cgi?id=196276
2724         <rdar://problem/48059859>
2725
2726         Reviewed by Alex Christensen.
2727
2728         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2729
2730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2731         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2732         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2733         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2734         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2735         (TestWebKitAPI::TEST):
2736
2737 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2738
2739         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2740         https://bugs.webkit.org/show_bug.cgi?id=186276
2741
2742         Reviewed by Carlos Garcia Campos.
2743
2744         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2745         (webViewLoadChanged):
2746         (testWebResourceGetDataError):
2747         (testWebResourceGetDataEmpty):
2748         (beforeAll):
2749         (webViewloadChanged): Deleted.
2750
2751 2019-03-27  Andy Estes  <aestes@apple.com>
2752
2753         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2754         https://bugs.webkit.org/show_bug.cgi?id=196317
2755
2756         Reviewed by Dan Bernstein.
2757
2758         package-root copies built products into a staging directory using ditto(1), which does not
2759         follow symbolic links as it traverses a directory. Now that the files in
2760         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2761         itself, these become broken links when ditto'd into the staging directory.
2762
2763         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2764
2765         * Scripts/package-root:
2766
2767 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2768
2769         [ews-app] Update display text of Submit for ews analysis
2770         https://bugs.webkit.org/show_bug.cgi?id=196309
2771
2772         Reviewed by Dewei Zhu.
2773
2774         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2775
2776 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2777
2778         run-webkit-tests should check for leaks in WebKit processes
2779         <https://webkit.org/b/193772>
2780         <rdar://problem/46526680>
2781
2782         Reviewed by Ryosuke Niwa.
2783
2784         This works by doing the following:
2785         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2786           The list of child processes are returned one per line:
2787           process.name: pid
2788         - Run the "#LIST CHILD PROCESSES" command just before the
2789           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2790           processes on the ServerProcess object.
2791         - When the `--leaks` switch is handled, run check_for_leaks() on
2792           each child process after the main test harness.
2793
2794         * DumpRenderTree/mac/DumpRenderTree.mm:
2795         (handleControlCommand):
2796         - Use strncmp() instead of strcmp().
2797         - Add support for handling "#LIST CHILD PROCESSES" command.
2798
2799         * Scripts/webkitpy/port/base.py:
2800         (Port.check_for_leaks):
2801         * Scripts/webkitpy/port/darwin.py:
2802         (DarwinPort.check_for_leaks):
2803         - Rename redundant 'process_pid' argument to 'process_id'.
2804
2805         * Scripts/webkitpy/port/driver.py:
2806         (Driver.do_post_tests_work):
2807         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2808           longer the only command this sends to WebKitTestRunner.
2809         - If the `--leaks` switch is present, send the
2810           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2811           result using Port.set_webkit_processes().
2812         (Driver._parse_child_processes_output):
2813         - Add helper method to parse list of child process names and
2814           process IDs returned from WebKitTestRunner.
2815
2816         * Scripts/webkitpy/port/ios_device.py:
2817         (IOSDevicePort.check_for_leaks):
2818         - Rename redundant 'process_pid' argument to 'process_id'.
2819
2820         * Scripts/webkitpy/port/leakdetector.py:
2821         (LeakDetector._parse_leaks_output):
2822         - Return early if there is no leaks_output.
2823         (LeakDetector.check_for_leaks):
2824         - Rename redundant 'process_pid' argument to 'process_id'.
2825
2826         * Scripts/webkitpy/port/server_process.py:
2827         (ServerProcess.__init__):
2828         (ServerProcess.child_processes):
2829         (ServerProcess.set_child_processes):
2830         - Add instance variable to Port to store list of child process
2831           names and process IDs returned from WebKitTestRunner.
2832         (ServerProcess._start):
2833         - Clear self._child_processes.
2834         (ServerProcess.stop):
2835         - If self._child_processes is set, call
2836           self._port.check_for_leaks() for each child process.
2837
2838         * Scripts/webkitpy/port/server_process_unittest.py:
2839         (TrivialMockPort.check_for_leaks):
2840         - Rename redundant 'process_pid' argument to 'process_id'.
2841
2842         * Scripts/webkitpy/port/simulator_process.py:
2843         (SimulatorProcess.stop):
2844         - If self._child_processes is set, call
2845           self._port.check_for_leaks() for each child process.
2846
2847         * Scripts/webkitpy/port/watch_device.py:
2848         (WatchDevicePort.check_for_leaks):
2849         - Rename redundant 'process_pid' argument to 'process_id'.
2850
2851         * WebKitTestRunner/TestController.cpp:
2852         (WTR::TestController::dumpResponse):
2853         - Extract method from findAndDumpWorldLeaks() so that it may be
2854           reused by findAndDumpWebKitProcessIdentifiers().
2855         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2856         - Add method to output process name and process ID of both the
2857           WebContent and Networking processes.
2858         (WTR::TestController::findAndDumpWorldLeaks):
2859         - Fix missing newline in output when there were no abandoned
2860           documents.
2861         - Call dumpResponse() for extracted code.
2862         (WTR::TestController::handleControlCommand):
2863         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2864         - Use strncmp() instead of strcmp().
2865         - Call findAndDumpWebKitProcessIdentifiers() when
2866           "#LIST CHILD PROCESSES" command is sent.
2867         * WebKitTestRunner/TestController.h:
2868         (WTR::TestController::dumpResponse):
2869         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2870         - Declare methods.
2871
2872 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2873
2874         Unreviewed. Add GLib API test cases after r243434.
2875
2876         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2877         (testWebViewActiveURI):
2878         (serverCallback):
2879         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2880         (sendRequestCallback):
2881
2882 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2883
2884         Geolocation request not complete when watch request was started in a different web process
2885         https://bugs.webkit.org/show_bug.cgi?id=195996
2886
2887         Reviewed by Alex Christensen.
2888
2889         Add a test case.
2890
2891         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2892         (TestWebKitAPI::runJavaScriptAlert):
2893         (TestWebKitAPI::TEST):
2894
2895 2019-03-26  Keith Rollin  <krollin@apple.com>
2896
2897         Update the way generate-xcfilelists returns strings from functions
2898         https://bugs.webkit.org/show_bug.cgi?id=195975
2899         <rdar://problem/49040807>
2900
2901         Reviewed by Dean Jackson.
2902
2903         There are places where generate-xcfilelists executes assignments with
2904         statements like:
2905
2906             FOO=$(some_function)
2907
2908         where "some_function" return a string by echoing it. E.g.
2909
2910             some_function()
2911             {
2912                 echo "Hello, World"
2913             }
2914
2915         This is a common idiom, but it has a problem if "some_function" needs
2916         to call "exit" in an attempt to halt the entire script right then and
2917         there. Since "some_function" is called inside of $(), it's being
2918         executed in a sub-shell. Calling exit in that sub-shell simply exits
2919         that shell; it doesn't not exit the outer shell in which the main part
2920         of the script is still running. As such, the main script keeps
2921         executing when the intent was for the script to halt.
2922
2923         The solution to this is to use a different idiom for returning
2924         strings. The one we now is to pass in the name of the variable to
2925         receive the string result:
2926
2927             some_function()
2928             {
2929                 variable_name=$1
2930                 eval $variable_name ="Hello, World"
2931             }
2932
2933         The call site now looks like
2934
2935             some_function FOO
2936
2937         Because there's no invocation of a sub-shell, some_function can now
2938         call "exit" if it wants to, and the entire script will exit at that
2939         point.
2940
2941         * Scripts/generate-xcfilelists:
2942
2943 2019-03-26  Chris Dumez  <cdumez@apple.com>
2944
2945         Add basic layout test coverage for File Picker on iOS
2946         https://bugs.webkit.org/show_bug.cgi?id=196265
2947
2948         Reviewed by Wenson Hsieh.
2949
2950         Add layout test infrastructure to test the file picker on iOS.
2951
2952         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2953         (WTR::UIScriptController::dismissFilePicker):
2954         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2955         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2956         (WTR::UIScriptController::dismissFilePicker):
2957         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR::TestController::createWebViewWithOptions):
2960         (WTR::updateTestOptionsFromTestHeader):
2961         * WebKitTestRunner/TestOptions.h:
2962         (WTR::TestOptions::hasSameInitializationOptions const):
2963         * WebKitTestRunner/ios/TestControllerIOS.mm:
2964         (overridePresentViewController):
2965         (WTR::TestController::platformInitialize):
2966         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2967         (WTR::UIScriptController::dismissFilePicker):
2968
2969 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2970
2971         Implement async paste method on UIWKInteractionViewProtocol
2972         https://bugs.webkit.org/show_bug.cgi?id=196267
2973         <rdar://problem/49236346>
2974
2975         Reviewed by Tim Horton.
2976
2977         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2978         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2979         are now a part of all iOS 12 internal SDKs.
2980
2981         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2982
2983         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2984         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2985
2986         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2987         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2988         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2989         * TestWebKitAPI/ios/UIKitSPI.h:
2990
2991 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2992
2993         [ews-build] Use PostgreSQL for ews.webkit.org database
2994         https://bugs.webkit.org/show_bug.cgi?id=196270
2995
2996         Reviewed by Lucas Forschler.
2997
2998         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2999
3000 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3001
3002         [ews] Reset simctl states on reboot
3003         https://bugs.webkit.org/show_bug.cgi?id=196260
3004
3005         Rubber-stamped by Aakash Jain.
3006
3007         * EWSTools/start-queue-mac.sh:
3008
3009 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3010
3011         [ews-build] Use PostgreSQL for ews-build database
3012         https://bugs.webkit.org/show_bug.cgi?id=196229
3013
3014         Reviewed by Lucas Forschler.
3015
3016         * BuildSlaveSupport/ews-build/master.cfg:
3017
3018 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3019
3020         [ews-build] Get master_hostname dynamically in master.cfg
3021         https://bugs.webkit.org/show_bug.cgi?id=196255
3022
3023         Reviewed by Lucas Forschler.
3024
3025         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3026         send events data in test mode.
3027
3028 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-app] Set db_constraint to False for Foreign Keys
3031         https://bugs.webkit.org/show_bug.cgi?id=196252
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-app/ews/models/build.py:
3036         * BuildSlaveSupport/ews-app/ews/models/step.py:
3037
3038 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3039
3040         [ews-build] is_test_mode_enabled should default to True
3041         https://bugs.webkit.org/show_bug.cgi?id=196248
3042
3043         Reviewed by Lucas Forschler.
3044
3045         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3046
3047 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3048
3049         [ews-app] Add webkitperl to ENABLED_QUEUES
3050         https://bugs.webkit.org/show_bug.cgi?id=196253
3051
3052         Reviewed by Lucas Forschler.
3053
3054         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3055
3056 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3057
3058         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3059         https://bugs.webkit.org/show_bug.cgi?id=196211
3060         rdar://problem/49110552
3061
3062         Reviewed by Tim Horton.
3063
3064         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3065         Make sure that EventSenderProxy always exists when running tests. We used to create
3066         it when resetting before the first test, which is a bit too late.
3067
3068         * WebKitTestRunner/TestController.h:
3069         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3070         (WTR::TestController::platformCreateWebView):
3071         (WTR::TestController::platformCreateOtherPage):
3072         (WTR::TestController::finishCreatingPlatformWebView):
3073         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3074         (WTR::PlatformWebView::PlatformWebView):
3075         Moved some code that made NSWindow use NSEvent during web view creation. We may
3076         need to move more if some other case us found, but this is enough for now.
3077
3078 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3079
3080         Unreviewed. Fix typo in GLib geolocation API after r243285.
3081
3082         gelocation -> geolocation.
3083
3084         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3085         (testGeolocationManagerWatchPosition):
3086
3087 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3088
3089         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3090         https://bugs.webkit.org/show_bug.cgi?id=196213
3091
3092         Reviewed by Geoff Garen.
3093
3094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3095         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3096         (credentialWithIdentityAndKeychainPath):
3097         (-[ChallengeDelegate webView:didFinishNavigation:]):
3098         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3099         (TestWebKitAPI::TEST):
3100
3101 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3102
3103         Expected shouldn't assume its contained types are copyable
3104         https://bugs.webkit.org/show_bug.cgi?id=195986
3105
3106         Reviewed by JF Bastien.
3107
3108         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3109         (TestWebKitAPI::NonCopyable::operator== const):
3110         (TestWebKitAPI::NonCopyable::operator!= const):
3111         (TestWebKitAPI::TEST):
3112
3113 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3114
3115         Remove some now-unnecessary dynamic class lookup
3116         https://bugs.webkit.org/show_bug.cgi?id=196237
3117
3118         Reviewed by Simon Fraser.
3119
3120         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3121         (makeRequest):
3122         (TEST):
3123
3124 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3125
3126         Unreviewed, rolling out r243450.
3127
3128         AppleWin and WinCairo port builds get broken.
3129
3130         Reverted changeset:
3131
3132         "Add test for fix of #196095"
3133         https://bugs.webkit.org/show_bug.cgi?id=196097
3134         https://trac.webkit.org/changeset/243450
3135
3136 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3137
3138         Unreviewed, rolling out r243465.
3139         https://bugs.webkit.org/show_bug.cgi?id=196226
3140
3141         the test doesn't build (Requested by thorton on #webkit).
3142
3143         Reverted changeset:
3144
3145         "Do not terminate the NetworkProcess if a third party
3146         application sends a NSCredential with a SecIdentityRef"
3147         https://bugs.webkit.org/show_bug.cgi?id=196213
3148         https://trac.webkit.org/changeset/243465
3149
3150 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3151
3152         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3153         https://bugs.webkit.org/show_bug.cgi?id=196213
3154
3155         Reviewed by Geoff Garen.
3156
3157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3158         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3159         (credentialWithIdentityAndKeychainPath):
3160         (-[ChallengeDelegate webView:didFinishNavigation:]):
3161         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3162         (TestWebKitAPI::TEST):
3163
3164 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3165
3166         [ews-build] Gracefully handle missing patch_id in events
3167         https://bugs.webkit.org/show_bug.cgi?id=196216
3168
3169         Reviewed by Lucas Forschler.
3170
3171         * BuildSlaveSupport/ews-build/events.py:
3172
3173 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3174
3175         [ews-build] use lz4 compression for improving buildbot performance
3176         https://bugs.webkit.org/show_bug.cgi?id=196155
3177
3178         Reviewed by Lucas Forschler.
3179
3180         * BuildSlaveSupport/ews-build/master.cfg:
3181
3182 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3183
3184         Pull some API testing helper methods out of TestWKWebView
3185         https://bugs.webkit.org/show_bug.cgi?id=196212
3186
3187         Reviewed by Tim Horton.
3188
3189         Refactor some more API testing utility methods, so that they can be used in
3190         tests that do not use TestWKWebView.
3191
3192         * TestWebKitAPI/cocoa/TestWKWebView.h:
3193         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3194         (-[WKWebView loadTestPageNamed:]):
3195         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3196         (-[WKWebView synchronouslyLoadHTMLString:]):
3197         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3198         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3199         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3200         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3201         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3202
3203 2019-03-25  Jer Noble  <jer.noble@apple.com>
3204
3205         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3206         https://bugs.webkit.org/show_bug.cgi?id=196097
3207
3208         Reviewed by Eric Carlson.
3209
3210         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3211
3212         * DumpRenderTree/mac/DumpRenderTree.mm:
3213         (resetWebPreferencesToConsistentValues):
3214         * WebKitTestRunner/TestController.cpp:
3215         (WTR::TestController::resetPreferencesToConsistentValues):
3216
3217 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3218
3219         Pull IPadUserInterfaceSwizzler out into a separate header file
3220         https://bugs.webkit.org/show_bug.cgi?id=196193
3221
3222         Reviewed by Anders Carlsson.
3223
3224         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3225         be used in other API tests.
3226
3227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3228         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3229         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3230         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3231         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3232         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3233         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3234
3235 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3236
3237         Remove NavigatorContentUtils in WebCore/Modules
3238         https://bugs.webkit.org/show_bug.cgi?id=196070
3239
3240         Reviewed by Alex Christensen.
3241
3242         NavigatorContentUtils was to support the custom scheme spec [1].
3243         However, in WebKit side, no port has supported the feature in
3244         WebKit layer after EFL port was removed. So there has been the
3245         only IDL implementation of the NavigatorContentUtils in WebCore.
3246         So we don't need to keep the implementation in WebCore anymore.
3247
3248         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3249
3250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3251
3252 2019-03-24  Andy Estes  <aestes@apple.com>
3253
3254         [watchOS] Remove unused Proximity Networking code
3255         https://bugs.webkit.org/show_bug.cgi?id=196188
3256
3257         Reviewed by Tim Horton.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3260         (TEST):
3261
3262 2019-03-23  Keith Miller  <keith_miller@apple.com>
3263
3264         Refactor clz/ctz and fix getLSBSet.
3265         https://bugs.webkit.org/show_bug.cgi?id=196162
3266
3267         Reviewed by Saam Barati.
3268
3269         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3270
3271         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3272         (TestWebKitAPI::TEST):
3273
3274 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3275
3276         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3277         https://bugs.webkit.org/show_bug.cgi?id=196143
3278
3279         Reviewed by Michael Catanzaro.
3280
3281         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3282         directories.
3283
3284         * Scripts/webkitpy/style/checkers/cpp.py:
3285         (check_identifier_name_in_declaration):
3286         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3287         (WebKitStyleTest.test_names):
3288
3289 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3290
3291         [Flatpak] Manifest expanding fails for qt WPE extension
3292         https://bugs.webkit.org/show_bug.cgi?id=196148
3293
3294         Reviewed by Alex Christensen.
3295
3296         * flatpak/flatpakutils.py:
3297         (expand_submodules_recurse): The last recurse manifest expand
3298         iteration might lead to a single module so take it into account
3299         and don't try to recurse further.
3300
3301 2019-03-22  Chris Dumez  <cdumez@apple.com>
3302
3303         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3304         https://bugs.webkit.org/show_bug.cgi?id=195348
3305         <rdar://problem/48622090>
3306
3307         Reviewed by Alex Christensen.
3308
3309         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3310         to NO when test.options().shouldIgnoreMetaViewport is false.
3311
3312         * WebKitTestRunner/ios/TestControllerIOS.mm:
3313         (WTR::TestController::platformConfigureViewForTest):
3314
3315 2019-03-22  Chris Dumez  <cdumez@apple.com>
3316
3317         Prewarmed processes should be usable with any website data store
3318         https://bugs.webkit.org/show_bug.cgi?id=196104
3319
3320         Reviewed by Alex Christensen.
3321
3322         Add API test coverage.
3323
3324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3325         (runInitialWarmedProcessUsedTest):
3326         (TEST):
3327
3328 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3329
3330         Back out local changes to Alex's Subversion working directory
3331
3332         They were accidentally committed.
3333
3334         * Scripts/webkitpy/common/system/abstractexecutive.py:
3335         (AbstractExecutive.wait_newest):
3336         * Scripts/webkitpy/common/system/executive.py:
3337         (Executive.running_pids):
3338         * Scripts/webkitpy/common/system/executive_mock.py:
3339         (MockExecutive.running_pids):
3340         * Scripts/webkitpy/common/system/executive_unittest.py:
3341         (ExecutiveTest.serial_test_running_pids):
3342         * Scripts/webkitpy/port/darwin.py:
3343         (DarwinPort.check_for_leaks):
3344         * Scripts/webkitpy/port/leakdetector.py:
3345         (LeakDetector.check_for_leaks):
3346         - This was the hack attached to Bug 193772.
3347
3348         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3349         (+[WebKitTestRunnerEvent mouseLocation]):
3350         - This works around a crash on an internal build.
3351
3352 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3353
3354         Fix the build after r243354
3355         https://bugs.webkit.org/show_bug.cgi?id=196138
3356         <rdar://problem/49145951>
3357
3358         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3359         (TEST):
3360         * TestWebKitAPI/ios/UIKitSPI.h:
3361
3362 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3363
3364         Adopt UIWKDocumentContext
3365         https://bugs.webkit.org/show_bug.cgi?id=196040
3366         <rdar://problem/48642440>
3367
3368         Reviewed by Ryosuke Niwa.
3369
3370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3371         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3372         (makeRequest):
3373         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3374         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3375         (applyStyle):
3376         (TEST):
3377         Add tests for UIWKDocumentContext.
3378
3379         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3380         (TEST):
3381         (recursiveFindWKContentView): Deleted.
3382         * TestWebKitAPI/cocoa/TestWKWebView.h:
3383         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3384         (recursiveFindWKContentView):
3385         (-[TestWKWebView wkContentView]):
3386         * TestWebKitAPI/ios/UIKitSPI.h:
3387         Share the WKContentView finding code between tests.
3388
3389 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3390
3391         [iOS WK2] Turn on async overflow scrolling by default
3392         https://bugs.webkit.org/show_bug.cgi?id=196011
3393         rdar://problem/48453859
3394
3395         Reviewed by Antti Koivisto.
3396         
3397         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3398         since so many basic layout tests have different results when compositing is triggered for
3399         overflow.
3400         
3401         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3402
3403         * WebKitTestRunner/TestController.cpp:
3404         (WTR::TestController::resetPreferencesToConsistentValues):
3405
3406 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3407
3408         [ews-build] Retry API test in case of failures
3409         https://bugs.webkit.org/show_bug.cgi?id=196004
3410
3411         Reviewed by Lucas Forschler.
3412
3413         * BuildSlaveSupport/ews-build/steps.py:
3414         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3415         (CompileWebKitToT.doStepIf): Ditto.
3416         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3417         (ReRunAPITests): Re-run API tests.
3418         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3419         (RunAPITestsWithoutPatch): Run API tests without patch.
3420         (RunAPITestsWithoutPatch.doStepIf):
3421         (RunAPITestsWithoutPatch.hideStepIf):
3422         (RunAPITestsWithoutPatch.evaluateCommand):
3423         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3424         (AnalyzeAPITestsResults.start):
3425         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3426         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3427         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3428         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3429
3430 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3431
3432         [ews-build] Update queues configurations
3433         https://bugs.webkit.org/show_bug.cgi?id=196074
3434
3435         Reviewed by Dewei Zhu.
3436
3437         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3438         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3439
3440 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3441
3442         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3443         https://bugs.webkit.org/show_bug.cgi?id=195680
3444         <rdar://problem/48903534>
3445
3446         Unreviewed infrastructure fix.
3447
3448         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3449         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3450
3451 2019-03-21  Andy Estes  <aestes@apple.com>
3452
3453         [iOS] Apple Pay should be available in documents with no user agent scripts
3454         https://bugs.webkit.org/show_bug.cgi?id=196061
3455         <rdar://problem/48649391>
3456
3457         Reviewed by Brady Eidson.
3458
3459         Added API tests and related infrastructure.
3460
3461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3462         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3463         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3464         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3465         (TestWebKitAPI::TEST):
3466         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3467         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3468         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3469         * TestWebKitAPI/cocoa/TestProtocol.mm:
3470         (-[TestProtocol startLoading]):
3471         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3472         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3473         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3474         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3475
3476 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3477
3478         REGRESSSION (r243297): webkitpy tests broken
3479         https://bugs.webkit.org/show_bug.cgi?id=196108
3480
3481         Reviewed by Aakash Jain.
3482
3483         r243297 updated contributors.json, which broke a few unit tests.
3484
3485         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3486         (IRCCommandTest.test_whois):
3487         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3488
3489 2019-03-21  Chris Dumez  <cdumez@apple.com>
3490
3491         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3492         https://bugs.webkit.org/show_bug.cgi?id=196041
3493         <rdar://problem/49083230>
3494
3495         Reviewed by Alex Christensen.
3496
3497         Add API test coverage.
3498
3499         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3500         (TEST):
3501
3502 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3503
3504         Add SPI to inform applications of WKContentRuleList actions
3505         https://bugs.webkit.org/show_bug.cgi?id=195965
3506         <rdar://problem/42664365>
3507
3508         Reviewed by Geoff Garen.
3509
3510         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3511         (TestWebKitAPI::allActionsForResourceLoad):
3512         (TestWebKitAPI::testRequest):
3513         (TestWebKitAPI::TEST_F):
3514         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3515         (Notification::description):
3516         (Notification::operator== const):
3517         (toVector):
3518         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3519         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3520         (makeContentRuleList):
3521         (TEST):
3522         (makeWarnContentRuleList): Deleted.
3523
3524 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3525
3526         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3527         https://bugs.webkit.org/show_bug.cgi?id=196088
3528
3529         Reviewed by Brian Burg.
3530
3531         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3532         Support checks when only one platform is specified. Also deprecate macosx() and
3533         force the use of macos() instead.
3534
3535         * Scripts/webkitpy/style/checkers/cpp.py:
3536         (check_min_versions_of_wk_api_available):
3537         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3538         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3539
3540 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3541
3542         Update status inactive committers' status to 'contributor'.
3543
3544         * Scripts/webkitpy/common/config/contributors.json:
3545
3546 2019-03-21  Xan Lopez  <xan@igalia.com>
3547
3548         [JSC][x86] Drop support for x87 floating point
3549         https://bugs.webkit.org/show_bug.cgi?id=194853
3550
3551         Reviewed by Don Olmstead.
3552
3553         Force SSE2 on x86/32bit builds.
3554
3555         * Scripts/webkitdirs.pm:
3556         (generateBuildSystemFromCMakeProject):
3557
3558 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3561         https://bugs.webkit.org/show_bug.cgi?id=196073
3562
3563         Reviewed by Michael Catanzaro.
3564
3565         Add test cases to check functions and constructors with no arguments but receiving user data.
3566
3567         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3568         (checkUserData):
3569         (testJSCFunction):
3570         (fooCreateWithUserData):
3571         (testJSCClass):
3572
3573 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3574
3575         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3576
3577         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3578
3579         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3580
3581 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3582
3583         [GTK][WPE] Add API to provide geolocation information
3584         https://bugs.webkit.org/show_bug.cgi?id=195940
3585
3586         Reviewed by Michael Catanzaro.
3587
3588         Add a new test to check the new API.
3589
3590         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3591         (testGeolocationManagerCurrentPosition):
3592         (testGeolocationManagerWatchPosition):
3593         (beforeAll):
3594         (afterAll):
3595         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3596         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3597         (beforeAll): Ditto.
3598         * TestWebKitAPI/glib/CMakeLists.txt:
3599
3600 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3601
3602         [GLib] Returning G_TYPE_OBJECT from a method does not work
3603         https://bugs.webkit.org/show_bug.cgi?id=195574
3604
3605         Reviewed by Michael Catanzaro.
3606
3607         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3608
3609         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3610         (getGFile):
3611         (getParent):
3612         (createGString):
3613         (getGString):
3614         (getGStringCopyWillRaise):
3615         (getGStringCopy):
3616         (getGStringStr):
3617         (getGStringLen):
3618         (freeGString):
3619         (testJSCClass):
3620
3621 2019-03-20  Saam Barati  <sbarati@apple.com>
3622
3623         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3624         https://bugs.webkit.org/show_bug.cgi?id=195721
3625
3626         Reviewed by Filip Pizlo.
3627
3628         * Scripts/run-javascriptcore-tests:
3629
3630 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3631
3632         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3633         https://bugs.webkit.org/show_bug.cgi?id=196049
3634
3635         Reviewed by Tim Horton.
3636
3637         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3638         overflow scrolling in general, so rename it.
3639
3640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3641
3642 2019-03-20  Daniel Bates  <dabates@apple.com>
3643
3644         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3645         https://bugs.webkit.org/show_bug.cgi?id=196031
3646         <rdar://problem/49078172>
3647
3648         Reviewed by Tim Horton.
3649
3650         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3651         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3652         same code path used when the Done button is pressed to dismiss the <select> picker.
3653
3654         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3655         (TestWebKitAPI::TEST):
3656
3657 2019-03-20  Chris Dumez  <cdumez@apple.com>
3658
3659         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3660         https://bugs.webkit.org/show_bug.cgi?id=196029
3661         <rdar://problem/48954651>
3662
3663         Reviewed by Tim Horton.