Tools/ChangeLog

   1 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
   2
   3         [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
   4         https://bugs.webkit.org/show_bug.cgi?id=98231
   5
   6         Reviewed by Gyuyoung Kim.
   7
   8         Enable use of X11 in DumpRenderTree / WebKitTestRunner.
   9         Call ecore_evas_new() instead of ecore_evas_buffer_new()
  10         in EFL's DumpRenderTree and WebKitTestRunner.
  11         It is safe to do this now that we are using XvfbDriver
  12         for the layout tests.
  13
  14         * DumpRenderTree/efl/DumpRenderTree.cpp:
  15         (parseCommandLineOptions):
  16         (initEcoreEvas):
  17         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  18         (WTR::initEcoreEvas):
  19         * WebKitTestRunner/efl/main.cpp:
  20         (main):
  21
  22 2012-10-03  Dirk Pranke  <dpranke@chromium.org>
  23
  24         run-webkit-tests tests on win32 after r127302
  25         https://bugs.webkit.org/show_bug.cgi?id=98323
  26
  27         Reviewed by Eric Seidel.
  28
  29         run-webkit-tests tests on win32 after r127302
  30         https://bugs.webkit.org/show_bug.cgi?id=98323
  31
  32         Reviewed by Eric Seidel.
  33
  34         Looks like when we converted the json-building logic to use scm
  35         to try and get the svn revision, we missed a win32-ism and
  36         didn't check to make sure had initialized the scm subsystem.
  37
  38         This change fixes that and renames _initialize_scm to be a public method.
  39
  40         * Scripts/webkitpy/common/host.py:
  41         (Host.initialize_scm):
  42         * Scripts/webkitpy/common/host_mock.py:
  43         (MockHost.__init__):
  44         (MockHost.initialize_scm):
  45         * Scripts/webkitpy/layout_tests/controllers/manager.py:
  46         (summarize_results):
  47         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  48         (JSONResultsGeneratorBase.get_json):
  49         (JSONResultsGeneratorBase._get_result_char):
  50         (JSONResultsGeneratorBase._get_svn_revision):
  51         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  52         (PerfTestsRunner.__init__):
  53         * Scripts/webkitpy/style/checkers/test_expectations.py:
  54         (TestExpectationsChecker.__init__):
  55         * Scripts/webkitpy/style/main.py:
  56         (CheckWebKitStyle.main):
  57         * Scripts/webkitpy/tool/main.py:
  58         (WebKitPatch.handle_global_options):
  59         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  60         (get_test_baselines):
  61
  62 2012-10-03  Adrian Perez de Castro  <aperez@igalia.com>
  63
  64         [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
  65         https://bugs.webkit.org/show_bug.cgi?id=98310
  66
  67         Reviewed by Martin Robinson.
  68
  69         Make MiniBrowser/GtkLauncher define the path to the inspector
  70         resources by setting the WEBKIT_INSPECTOR_PATH environment
  71         variable pointing to the copy of the inspector resources in
  72         the build directory. If the environment variable is already
  73         defined, its value is not overwritten. The path is derived
  74         from the WEBKIT_EXEC_PATH macro defined in the makefiles.
  75
  76         * GNUmakefile.am:
  77         * GtkLauncher/main.c:
  78         (main):
  79         * MiniBrowser/gtk/main.c:
  80         (main):
  81
  82 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
  83
  84         Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
  85         https://bugs.webkit.org/show_bug.cgi?id=97608
  86
  87         Reviewed by Sam Weinig.
  88
  89         The test fast/dom/Geolocation/window-close-crash.html was crashing because
  90         handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
  91         the page was created, the void* clientInfo can either be a PlatformWebView or
  92         a TestController.
  93
  94         Using the global TestController fixes the issue.
  95
  96         * WebKitTestRunner/GeolocationProviderMock.cpp:
  97         (WTR::GeolocationProviderMock::setPosition):
  98         (WTR::GeolocationProviderMock::setPositionUnavailableError):
  99         To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
 100         to clear the error and vice versa.
 101         This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
 102
 103         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
 104         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
 105         Some tests expect the position/error cant be sent multiple time,
 106         just keep the position after sending.
 107
 108         * WebKitTestRunner/TestController.cpp:
 109         (WTR::decidePolicyForGeolocationPermissionRequest):
 110         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
 111         * WebKitTestRunner/TestController.h:
 112         Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
 113         client would have to do.
 114
 115 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
 116
 117         [BlackBerry] Implementing the NetworkInfo API for BB port
 118         https://bugs.webkit.org/show_bug.cgi?id=98273
 119
 120         Reviewed by Rob Buis.
 121
 122         Enabling NetworkInfo API for the BlackBerry port.
 123
 124         * Scripts/webkitperl/FeatureList.pm:
 125
 126 2012-10-03  Anders Carlsson  <andersca@apple.com>
 127
 128         Exception thrown when running accessibility/container-node-delete-causes-crash.html test
 129         https://bugs.webkit.org/show_bug.cgi?id=98291
 130
 131         Reviewed by Andreas Kling.
 132
 133         The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
 134         to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
 135         when trying to access the children of an element that didn't have any children. Fix this by adding
 136         BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
 137
 138         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
 139         (findAccessibleObjectById):
 140
 141 2012-10-03  Ojan Vafai  <ojan@chromium.org>
 142
 143         Make partytime work when loading garden-o-matic from trac.webkit.org
 144         https://bugs.webkit.org/show_bug.cgi?id=98283
 145
 146         Reviewed by Adam Barth.
 147
 148         CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
 149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
 150
 151 2012-10-03  Roger Fong  <roger_fong@apple.com>
 152
 153         Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
 154         https://bugs.webkit.org/show_bug.cgi?id=98288
 155
 156         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
 157         (ChromiumAndroidDriverTest.test_command_from_driver_input):
 158
 159 2012-10-03  Ojan Vafai  <ojan@chromium.org>
 160
 161         Get rid of warning about non-existant platform name when loading garden-o-matic
 162         https://bugs.webkit.org/show_bug.cgi?id=98282
 163
 164         Reviewed by Adam Barth.
 165
 166         If you loaded without a platform query parameter we'd return "null" as the platform name
 167         instead of null.
 168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
 169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
 170
 171 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>
 172
 173         [Qt] Enable mock scrollbars
 174         https://bugs.webkit.org/show_bug.cgi?id=98011
 175
 176         Reviewed by Csaba Osztrogonác.
 177
 178         Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
 179
 180         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 181         (WebCore::DumpRenderTree::DumpRenderTree):
 182         * WebKitTestRunner/TestController.cpp:
 183         (WTR::TestController::resetStateToConsistentValues):
 184
 185 2012-10-03  Alberto Garcia  <agarcia@igalia.com>
 186
 187         [GTK] [WK2] Add favicon support to the MiniBrowser
 188         https://bugs.webkit.org/show_bug.cgi?id=98063
 189
 190         Reviewed by Carlos Garcia Campos.
 191
 192         Set the icon in the URI text entry using the favicon property of
 193         the WebKitWebView.
 194
 195         * MiniBrowser/gtk/BrowserWindow.c:
 196         (_BrowserWindow):
 197         (updateUriEntryIcon):
 198         (uriEntryTextChanged):
 199         (faviconChanged):
 200         (browserWindowFinalize):
 201         (browser_window_init):
 202         (browserWindowConstructed):
 203
 204 2012-10-03  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 205
 206         [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
 207         https://bugs.webkit.org/show_bug.cgi?id=98200
 208
 209         Reviewed by Csaba Osztrogonác.
 210
 211         * DumpRenderTree/qt/TestRunnerQt.cpp:
 212         (TestRunner::overridePreference):
 213
 214 2012-10-03  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
 215
 216         [Qt][WRT] Fix build error with MSVC on Windows.
 217         https://bugs.webkit.org/show_bug.cgi?id=97697
 218
 219         Reviewed by Simon Hausmann.
 220
 221         WTR build is failing when WebKit directory is located on a longer path.
 222         This seems to caused by source files that has the same name in
 223         WTR and DRT directories. The solution is removing referencies
 224         from Target.pri to DRT directory and adding an alternate version of
 225         the required files to WTR. Those files simply include the real ones from DRT.
 226
 227         * WebKitTestRunner/InjectedBundle/Target.pri:
 228         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
 229         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
 230
 231 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
 232
 233         [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
 234         https://bugs.webkit.org/show_bug.cgi?id=98238
 235
 236         Reviewed by Csaba Osztrogonác.
 237
 238         Reset AlwaysAcceptCookies setting between tests to avoid
 239         flakiness due to TestRunner.setAlwaysAcceptCookies().
 240
 241         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 242         (WTR::InjectedBundle::beginTesting):
 243
 244 2012-10-03  Harald Alvestrand  <hta@google.com>
 245
 246         Add data passing to the GetStats interface of RTCPeerConnection
 247         https://bugs.webkit.org/show_bug.cgi?id=98003
 248
 249         Reviewed by Adam Barth.
 250
 251         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
 252         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
 253         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
 254         (MockWebRTCPeerConnectionHandler::addStream):
 255         (MockWebRTCPeerConnectionHandler::removeStream):
 256         (MockWebRTCPeerConnectionHandler::getStats):
 257         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
 258         (MockWebRTCPeerConnectionHandler):
 259
 260 == Rolled over to ChangeLog-2012-10-02 ==