run-api-tests: dumpAllTests() should not use global variables
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-22  David Kilzer  <ddkilzer@apple.com>
2
3         run-api-tests: dumpAllTests() should not use global variables
4
5         Reviewed by Adam Roben.
6
7         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
8
9         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
10         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
11         global data as an argument.  Sort suite names and test names
12         alphabetically to match output when running tests.
13
14 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
15
16         [BlackBerry] Enable blob for the BlackBerry porting
17         https://bugs.webkit.org/show_bug.cgi?id=75074
18
19         Reviewed by George Staikos.
20
21         * Scripts/build-webkit:
22
23 2011-12-22  Kentaro Hara  <haraken@chromium.org>
24
25         Add unittests for the Perl parser of prepare-ChangeLog
26         https://bugs.webkit.org/show_bug.cgi?id=74994
27
28         Reviewed by David Kilzer.
29
30         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
31
32         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
33
34         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
35         Runs unittests specified in @testFiles.
36         You can reset expected results by specifying a --reset-results option.
37         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
38         Contains simple methods.
39         (func1):
40         (func2):
41         (func3):
42         (func4):
43         (func5):
44         (func6):
45         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
46         This test result is generated by the --reset-results option.
47
48 2011-12-21  Eric Seidel  <eric@webkit.org>
49
50         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
51         so that they appear in the bugzilla autocomplete CC list.
52         I also removed the "radar" irc nick (which I believe does not exist)
53         and removed the uneeded [] around the radar bugzilla email.
54
55         Unreviewed.
56
57         * Scripts/webkitpy/common/config/committers.py:
58
59 2011-12-21  Daniel Bates  <dbates@rim.com>
60
61         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
62         https://bugs.webkit.org/show_bug.cgi?id=74985
63
64         Reviewed by Eric Seidel.
65
66         * Scripts/build-jsc:
67         * Scripts/webkitdirs.pm:
68         (cmakeBasedPortName): Added.
69
70 2011-12-21  Daniel Bates  <dbates@rim.com>
71
72         Extract BlackBerry CMake arguments from build-webkit into separate function
73         https://bugs.webkit.org/show_bug.cgi?id=74981
74
75         Reviewed by Rob Buis.
76
77         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
78         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
79         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
80         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
81         that we can pass them to the CMake build system when building JavaScriptCore.
82
83         * Scripts/build-webkit: Move construction of CMake argument list from here to
84         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
85         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
86         call it from build-webkit.
87         * Scripts/webkitdirs.pm:
88         (blackberryCMakeArguments): Added.
89         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
90         BlackBerry port.
91
92 2011-12-21  Daniel Bates  <dbates@webkit.org>
93
94         Extract WinCE CMake arguments from build-webkit into separate function
95         https://bugs.webkit.org/show_bug.cgi?id=74983
96
97         Reviewed by Rob Buis.
98
99         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
100         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
101         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
102         that we can pass it to the CMake build system when building JavaScriptCore.
103
104         * Scripts/build-webkit:
105         * Scripts/webkitdirs.pm:
106         (cmakeBasedPortArguments): Added.
107
108 2011-12-21  Kentaro Hara  <haraken@chromium.org>
109
110         In prepare-ChangeLog, replace constant global variables with "use constant"
111         https://bugs.webkit.org/show_bug.cgi?id=74992
112
113         Reviewed by Ryosuke Niwa.
114
115         This patch replaces the following constant global variables with "use constant"s.
116             - $changeLogTimeZone
117             - $SVN
118             - $GIT
119             - %supportedTestExtensions
120
121         * Scripts/prepare-ChangeLog:
122         (changeLogNameFromArgs):
123         (changeLogEmailAddressFromArgs):
124         (resolveConflictedChangeLogs):
125         (generateNewChangeLogs):
126         (diffCommand):
127         (statusCommand):
128         (createPatchCommand):
129         (findOriginalFileFromSvn):
130         (determinePropertyChanges):
131         (generateFileList):
132         (reviewerAndDescriptionForGitCommit):
133
134 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
135
136         nrwt: rename field references from _fs to _filesystem
137         https://bugs.webkit.org/show_bug.cgi?id=74898
138
139         Reviewed by Adam Barth.
140
141         This is a simple cleanup; most of the code uses
142         self._filesystem, but some used self._fs; this change renames
143         the latter to the former to be more consistent.
144
145         * Scripts/webkitpy/layout_tests/controllers/manager.py:
146         (Manager.__init__):
147         (Manager.collect_tests):
148         (Manager._strip_test_dir_prefix):
149         (Manager._split_into_chunks_if_necessary):
150         (Manager.results_directory):
151         (Manager._clobber_old_results):
152         (Manager._upload_json_files):
153         (Manager.print_config):
154         (Manager._copy_results_html_file):
155         (Manager._show_results_html_file):
156         (Manager._log_worker_stack):
157         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
158         (JSONLayoutResultsGenerator._normalize_results_json):
159         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
160         (JSONResultsGeneratorBase.__init__):
161         (JSONResultsGeneratorBase.generate_json_output):
162         (JSONResultsGeneratorBase.generate_times_ms_file):
163         (JSONResultsGeneratorBase.upload_json_files):
164         (JSONResultsGeneratorBase._get_svn_revision):
165         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
166         (Base.__init__):
167
168 2011-12-20  Kentaro Hara  <haraken@chromium.org>
169
170         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
171         https://bugs.webkit.org/show_bug.cgi?id=74836
172
173         Reviewed by David Kilzer.
174
175         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
176         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
177         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
178         of prepare-ChangeLog.
179
180         Using LoadAsModule.pm, you can load a Perl script as follows.
181         The first argument is the arbitrary package name you want to use, and the second argument
182         is the name of the Perl script you want to load.
183
184             use LoadAsModule qw(RunLeaks run-leaks);
185             RunLeaks::someFunctionDefinedInRunLeaks(...);
186
187         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
188                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
189                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
190
191         * Scripts/webkitperl/LoadAsModule.pm: Added.
192         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
193         (import):
194         (readFile):
195         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
196         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
197         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
198
199 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
200
201         [Qt] WK2 Debugging quirks need some improvement
202         https://bugs.webkit.org/show_bug.cgi?id=74859
203
204         Reviewed by Simon Hausmann.
205
206         Improvements added to make debugging WebKit2 more
207         confortable and efficient:
208         1. Unify debugging quirks. From now all of them are controlled
209         by the QT_WEBKIT2_DEBUG environment variable.
210         2. Disable crash handlers for WebKitTestRunner if debugging quirks
211         are used to make it possible to use postmortem debugging via core dumps
212         which is extremely useful for debugging bugs triggered by layout tests.
213         3. Disable test timeout for WebKitTestRunner if debugging quirks
214         are used because that makes debugging impossible.
215
216         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
217         (WTR::InjectedBundle::platformInitialize):
218         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
219         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
220         * WebKitTestRunner/qt/TestControllerQt.cpp:
221         (WTR::TestController::platformRunUntil):
222
223 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
224
225         [Qt][WK2] Implement favicon support
226         https://bugs.webkit.org/show_bug.cgi?id=71082
227
228         Reviewed by Simon Hausmann.
229
230         A favorite icon was added on MiniBrowser's url bar as example.
231         We display a default icon when the page doesn't have an icon ready.
232
233         * MiniBrowser/qt/MiniBrowser.qrc:
234         * MiniBrowser/qt/icons/favicon.png: Added.
235         * MiniBrowser/qt/qml/BrowserWindow.qml:
236
237 2011-12-19  Sam Weinig  <sam@webkit.org>
238
239         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
240         https://bugs.webkit.org/show_bug.cgi?id=74907
241
242         Reviewed by Dan Bernstein.
243
244         Add ScrollByLineCommands API test.
245
246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
247         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
248         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
249
250 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
251
252         webkitpy: remove port.executive, port.filesystem, port.user properties
253         https://bugs.webkit.org/show_bug.cgi?id=74896
254
255         Reviewed by Eric Seidel.
256
257         Following on the refactoring of the port and host objects, this
258         removes the public executive, filesystem, and user properties
259         from the Port interface (protected versions of executive and
260         filesystem still exist). There is still some more clean up to
261         make the code more consistent and rearrange some other files to
262         talk to Hosts directly instead of getting them off of the Port
263         class.
264
265         * Scripts/webkitpy/layout_tests/controllers/manager.py:
266         (Manager.__init__):
267         (Manager.results_directory):
268         (Manager._log_worker_stack):
269         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
270         (ManagerTest.test_fallback_path_in_config):
271         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
272         (_InlineManager.start_worker):
273         (_InlineWorkerConnection.__init__):
274         * Scripts/webkitpy/layout_tests/controllers/worker.py:
275         (Worker.safe_init):
276         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
277         (TestConfiguration.from_port):
278         * Scripts/webkitpy/layout_tests/port/base.py:
279         (Port.__init__):
280         (Port.tests):
281         (Port.show_results_html_file):
282         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
283         (PortTest.test_layout_tests_skipping):
284         (PortTest.test_test_dirs):
285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
286         (_set_up_derived_options):
287         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
288         (PerfTestsRunner.__init__):
289         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
290         (HtmlGenerator.__init__):
291         (HtmlGenerator.show_html):
292         (real_main):
293         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
294         (TestHtmlGenerator.make_generator):
295
296 2011-12-19  Daniel Bates  <dbates@webkit.org>
297
298         Pass command line arguments to GDB when debugging a Mac WebKit application
299         https://bugs.webkit.org/show_bug.cgi?id=72829
300
301         Reviewed by David Kilzer.
302
303         Pass through any command line arguments given to debug-{safari, minibrowser}
304         to GDB so that they may influence the application instance launched by GDB.
305
306         * Scripts/webkitdirs.pm:
307         (execMacWebKitAppForDebugging):
308
309 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
310
311         webkitpy: remove executive,filesystem,user parameters from Port constructor
312         https://bugs.webkit.org/show_bug.cgi?id=74878
313
314         Reviewed by Eric Seidel.
315
316         This change concludes the refactoring that makes Host a required
317         parameter for Port and ensures that all access to filesystem,
318         executives, etc. is going through the Host.
319
320         * Scripts/webkitpy/layout_tests/port/base.py:
321         (Port.__init__):
322
323 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
324
325         webkitpy: finish refactoring port classes to make a host mandatory
326         https://bugs.webkit.org/show_bug.cgi?id=74566
327
328         Reviewed by Eric Seidel.
329
330         This change makes all Port objects take a required (System)Host
331         parameter, and updates the TestPort object to no longer create a
332         mock filesystem or add files to the existing filesystem by
333         default.
334
335         * Scripts/webkitpy/layout_tests/port/base.py:
336         (Port.__init__):
337         * Scripts/webkitpy/layout_tests/port/factory.py:
338         (PortFactory.__init__):
339         (PortFactory._get_kwargs):
340         * Scripts/webkitpy/layout_tests/port/test.py:
341         (TestInstance.__init__):
342         (TestPort.__init__):
343         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
344         (passing_run):
345         (logging_run):
346         (get_tests_run):
347         (MainTest.test_single_file):
348         (MainTest.test_stderr_is_saved):
349         (MainTest.test_test_list):
350         (MainTest.test_test_list_with_prefix):
351         (MainTest.test_missing_and_unexpected_results):
352         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
353         (MainTest.test_crash_with_stderr):
354         (MainTest.test_no_image_failure_with_image_diff):
355         (MainTest.test_crash_log):
356         (MainTest.test_web_process_crash_log):
357         (MainTest.test_exit_after_n_failures_upload):
358         (MainTest.test_results_directory_absolute):
359         (MainTest.test_results_directory_relative):
360         (MainTest.test_retries_directory):
361         (MainTest.test_tolerance.get_port_for_run):
362         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
363         (EndToEndTest.test_end_to_end):
364         (EndToEndTest.test_reftest_with_two_notrefs):
365         (RebaselineTest.test_reset_results):
366         (RebaselineTest.test_missing_results):
367         (RebaselineTest.test_new_baseline):
368         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
369         (Rebaseliner.__init__):
370         (main):
371         (real_main):
372         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
373         (test_host_port_and_filesystem):
374         (TestRebaseliner.make_rebaseliner):
375         (TestRealMain.test_all_platforms):
376         (TestHtmlGenerator.make_generator):
377
378 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
379
380         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
381         https://bugs.webkit.org/show_bug.cgi?id=74562
382
383         Reviewed by Eric Seidel.
384
385         Apart from a minor change to style/checkers/test_expectations.py
386         to take a host as a parameter to a TestExpectationsChecker(),
387         there are only refactoring changes to unit tests here.
388
389         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
390         (TestResultWriterTest.test_reftest_diff_image):
391         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
392         (JSONGeneratorTest._test_json_generation):
393         (JSONGeneratorTest.test_test_timings_trie):
394         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
395         (Base.__init__):
396         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
397         (PortTest.make_port):
398         (PortTest.test_layout_tests_skipping):
399         (PortTest.test_test_dirs):
400         (PortTest.test_additional_platform_directory):
401         (PortTest.test_uses_test_expectations_file):
402         (PortTest.test_find_no_paths_specified):
403         (PortTest.test_find_one_test):
404         (PortTest.test_find_glob):
405         (PortTest.test_find_with_skipped_directories):
406         (PortTest.test_find_with_skipped_directories_2):
407         (PortTest.test_parse_reftest_list):
408         * Scripts/webkitpy/layout_tests/port/dryrun.py:
409         (DryRunPort.__init__):
410         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
411         (FactoryTest.setUp):
412         (FactoryTest.tearDown):
413         (FactoryTest.assert_port):
414         (FactoryTest.assert_platform_port):
415         (FactoryTest.test_unknown_specified):
416         (FactoryTest.test_unknown_default):
417         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
418         (GetGoogleChromePortTest._verify_expectations_overrides):
419         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
420         (MockDRTPortTest.make_port):
421         (MockDRTTest.assertTest):
422         (MockDRTTest.test_main):
423         (MockChromiumDRTTest.test_pixeltest__fails):
424         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
425         (QtPortTest._assert_search_path):
426         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
427         (TestWebKitPort.__init__):
428         (WebKitPortTest.test_skipped_directories_for_symbols):
429         (test_skipped_directories_for_features):
430         (test_skipped_layout_tests):
431         (test_skipped_file_search_paths):
432         (test_root_option):
433         (test_test_expectations):
434         (test_build_driver):
435         (test_linux_distro_detection):
436         (test_apache_config_file_name_for_platform):
437         (test_path_to_apache_config_file):
438         (WebKitDriverTest.test_read_block):
439         * Scripts/webkitpy/style/checkers/test_expectations.py:
440         (TestExpectationsChecker.__init__):
441         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
442         (TestExpectationsTestCase._expect_port_for_expectations_path):
443         (TestExpectationsTestCase.assert_lines_lint):
444         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
445         (get_test_config.TestMacPort):
446
447 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
448
449         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
450         https://bugs.webkit.org/show_bug.cgi?id=74854
451
452         Reviewed by Csaba Osztrogonác.
453
454         Since r101052, libewebkit.so is built in a different location, so we
455         need to adjust the path returned by builtDylibPathForName.
456
457         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
458         port also respects Release/Debug configurations.
459
460         These changes should make run-launcher finally work correctly with
461         webkit-efl.
462
463         * Scripts/webkitdirs.pm:
464         (usesPerConfigurationBuildDirectory):
465         (builtDylibPathForName):
466
467 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
468
469         [Qt][WK2] Add support for modal event loop processing for WTR
470         https://bugs.webkit.org/show_bug.cgi?id=74852
471
472         Reviewed by Kenneth Rohde Christiansen.
473
474         Rewrote event loop processing: Instead of terminating the event loop
475         in notifyDone() - something no other platform does - we now respect the
476         "bool& condition" parameter passed to platformRunUntil. This ensures
477         proper termination even when the condition is changed from within a
478         nested event loop, because only when we _exit_ from the nested event
479         loop we will check the condition and terminate the test properly.
480
481         In addition this patch implements TestController::runModal by means of
482         a nested event loop, which is passed to the platform webview that is
483         supposed to be modal. It is that view's responsibility to exit the
484         loop, upon destruction. I believe that's similar to how it works on the Mac,
485         where it doesn't seem that NSApp's runModalForWindow is terminate via
486         abort/stopModal but simply because the window is closed.
487
488         * WebKitTestRunner/PlatformWebView.h:
489         (WTR::PlatformWebView::setModalEventLoop):
490         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
491         (WTR::PlatformWebView::PlatformWebView):
492         (WTR::PlatformWebView::~PlatformWebView):
493         * WebKitTestRunner/qt/TestControllerQt.cpp:
494         (WTR::TestController::notifyDone):
495         (WTR::TestController::platformRunUntil):
496         (WTR::TestController::runModal):
497
498 2011-12-18  Kentaro Hara  <haraken@chromium.org>
499
500         REGRESSION(r103149): prepare-ChangeLog outputs a warning
501         https://bugs.webkit.org/show_bug.cgi?id=74808
502
503         Reviewed by David Kilzer.
504
505         Added the prototype declaration of main() to avoid warning messages.
506         Sorted subroutine declarations in the alphabetical order.
507
508         * Scripts/prepare-ChangeLog:
509
510 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
511
512         [Qt] Fix QtTestBrowser compilation with QtWidgets module
513         https://bugs.webkit.org/show_bug.cgi?id=74791
514
515         Reviewed by Andreas Kling.
516
517         * QtTestBrowser/QtTestBrowser.pro:
518
519 2011-12-17  Kentaro Hara  <haraken@chromium.org>
520
521         Remove top-level code completely from prepare-ChangeLog
522         https://bugs.webkit.org/show_bug.cgi?id=74698
523
524         Reviewed by Darin Adler.
525
526         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
527         This patch just moves all top-level code into main().
528
529         * Scripts/prepare-ChangeLog:
530         (main):
531
532 2011-12-16  Dean Jackson  <dino@apple.com>
533
534         Move webkit-bug-importer to Contributor. It won't
535         autocomplete as an Account.
536         See https://bugs.webkit.org/show_bug.cgi?id=74739
537         for some discussion.
538
539         Unreviewed.
540
541         * Scripts/webkitpy/common/config/committers.py:
542
543 2011-12-16  Dean Jackson  <dino@apple.com>
544
545         Add webkit-bug-importer@group.apple.com to accounts
546         so that it autocompletes in bugzilla.
547
548         Unreviewed.
549
550         * Scripts/webkitpy/common/config/committers.py:
551
552 2011-12-16  Philippe Normand  <pnormand@igalia.com>
553
554         Unreviewed, skipping 3 failing GTK API tests.
555
556         * Scripts/run-gtk-tests:
557
558 2011-12-16  Philippe Normand  <pnormand@igalia.com>
559
560         Unreviewed, GTK API tests build fix attempt.
561
562         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
563
564 2011-12-16  Philippe Normand  <pnormand@igalia.com>
565
566         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
567
568         * Scripts/run-gtk-tests:
569
570 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
571
572         [Qt] Fix the build for newer Qt5
573         https://bugs.webkit.org/show_bug.cgi?id=74703
574
575         Reviewed by Csaba Osztrogonác.
576
577         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
578         * DumpRenderTree/qt/EventSenderQt.cpp:
579         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
580         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
581         (WTR::EventSenderProxy::sendTouchEvent):
582         * MiniBrowser/qt/MiniBrowserApplication.cpp:
583         (MiniBrowserApplication::sendTouchEvent): Ditto.
584         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
585
586 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
587
588         [Qt] Detect and force clean build when feature defines are added
589
590         Reviewed by Ossy.
591
592         https://bugs.webkit.org/show_bug.cgi?id=74689
593
594         * Scripts/webkitdirs.pm:
595
596 2011-12-16  Kentaro Hara  <haraken@chromium.org>
597
598         [Refactoring] Remove all global variables from prepare-ChangeLog
599         https://bugs.webkit.org/show_bug.cgi?id=74681
600
601         Reviewed by Ryosuke Niwa.
602
603         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
604         manner. This bug is one of the incremental refactorings to remove all top-level
605         code and global variables from prepare-ChangeLog. In this patch,
606         we make the following global variables be used only through parameter passing.
607         This patch removes all global variables from prepare-ChangeLog.
608             - $mergeBase
609             - $gitCommit
610             - $gitIndex
611
612         * Scripts/prepare-ChangeLog:
613         (generateFunctionLists):
614         (changeLogNameFromArgs):
615         (changeLogEmailAddressFromArgs):
616         (generateNewChangeLogs):
617         (printDiff):
618         (diffFromToString):
619         (diffCommand):
620         (statusCommand):
621         (createPatchCommand):
622         (generateFileList):
623         (isConflictStatus):
624
625 2011-12-15  Philippe Normand  <pnormand@igalia.com>
626
627         [GTK] Rounding errors on 32-bit machines causes tests to fail
628         https://bugs.webkit.org/show_bug.cgi?id=72254
629
630         Initial patch by vanuan@gmail.com.
631         Reviewed by Martin Robinson.
632
633         * Scripts/webkitdirs.pm:
634         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
635         CXXFLAGS to autogen in an attempt to harmonize floating point
636         values between 32-bit and 64-bit architectures.
637
638 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
639
640         [GTK] Make distcheck fails during the install
641         https://bugs.webkit.org/show_bug.cgi?id=74274
642
643         No review, since this is a build fix.
644
645         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
646         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
647         always runs. This means that the gtkdoc step was always running when make was
648         invoked. Generating gtkdoc during 'make install' was triggering a race condition
649         with the library file. Later we can fix generate-forwarding-headers and unbreak
650         'make docs,' but this bandaid is sufficient to let us release.
651
652 2011-12-15  Eric Seidel  <eric@webkit.org>
653
654         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
655         https://bugs.webkit.org/show_bug.cgi?id=74650
656
657         Reviewed by Adam Barth.
658
659         * Scripts/webkitpy/common/system/platforminfo.py:
660         (PlatformInfo._compute_bytes_from_vm_stat_output):
661         * Scripts/webkitpy/layout_tests/port/base.py:
662         (Port.default_child_processes):
663         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
664         (PortTest.test_default_child_processes):
665
666 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
667
668         bencher script should support remote benchmarking on platforms that don't have ruby
669         https://bugs.webkit.org/show_bug.cgi?id=74659
670
671         Rubber-stamped by Sam Weinig.
672         
673         Added the ability to have bencher generate a benchmarking playload that consists of
674         copies of all of the benchmarks, optionally copies of all of the frameworks and
675         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
676         order, which then spits out a raw results file that bencher can parse.
677         
678         In normal operating mode, you never see this, as it just generates the payload and
679         script internally, runs it, parses the results, and spits them out.
680         
681         The --remote mode has been changed to use this style, so any remote host that has
682         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
683         a sh-compatible shell can be used for remote benchmarking.
684         
685         The feature to include VMs in the benchmarking payload is by default only activated
686         when using --remote, but it can also be activated when doing local benchmarking; the
687         benefit is that you remove any pathname-related performance pathologies. All VMs
688         become equal because they are all located in
689         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
690         (usually 0 or 1).
691         
692         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
693         through DumpRenderTree. This is only a bit slower than running in jsc.
694
695         * Scripts/bencher:
696
697 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
698
699         webkitpy: clean up TestPort to (mostly) not create a new filesystem
700         https://bugs.webkit.org/show_bug.cgi?id=74556
701
702         This change modifies the TestPort to be ready to add tests to an
703         existing filesystem instead of creating a new filesystem; we
704         leave unit_test_filesystem() in for now for compatibility.
705
706         * Scripts/webkitpy/common/host_mock.py:
707         (MockHost.__init__):
708           - call add_unit_tests_to_mock_filesystem by default to make
709             the MockHost more generally useful for layout_test unit tests.
710         * Scripts/webkitpy/layout_tests/port/test.py:
711         (TestInstance.__init__):
712         (add_unit_tests_to_mock_filesystem):
713         (add_file):
714         (unit_test_filesystem):
715         (TestPort.__init__):
716         (TestPort._set_default_overriding_none):
717
718 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
719
720         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
721         https://bugs.webkit.org/show_bug.cgi?id=74551
722
723         This is some minor cleanup prior to making all of the host/port
724         changes described in bug 74138.
725
726         * Scripts/webkitpy/common/host_mock.py:
727         (MockHost.__init__):
728           - make sure the scm object is initialized with the same mock
729             executive and filesystem objects.
730
731         * Scripts/webkitpy/common/system/filesystem_mock.py:
732         (MockFileSystem.clear_written_files):
733           - add a routine that will be useful in testing.
734         (MockFileSystem.maybe_make_directory):
735         (MockFileSystem.write_binary_file):
736           - fix bugs to make sure directories are created properly.
737         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
738         (_Process.run):
739           - add clarifying comments.
740         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
741         (MockDRTPort.__init__):
742         (MockDRT.__init__):
743           - add clarifying comments.
744
745 2011-12-15  Anders Carlsson  <andersca@apple.com>
746
747         Regression (r102866): Navigating away from or closing a page with a plugin crashes
748         https://bugs.webkit.org/show_bug.cgi?id=74655
749
750         Reviewed by Sam Weinig.
751
752         Add a bunch of tests.
753
754         * TestWebKitAPI/Tests/WTF/Functional.cpp:
755
756 2011-12-15  Stephanie Lewis  <slewis@apple.com>
757
758         https://bugs.webkit.org/show_bug.cgi?id=74469
759         Escape paths to svn commands so our tools can handle filenames with @ symbols.
760
761         Reviewed by Adam Roben.
762
763         * Scripts/VCSUtils.pm:
764         (scmMoveOrRenameFile):
765         (scmAddExecutableBit):
766         (scmRemoveExecutableBit):
767         (determineSVNRoot):
768         (svnRevisionForDirectory):
769         (pathRelativeToSVNRepositoryRootForPath):
770         (svnStatus):
771         (escapeSubversionPath):
772         * Scripts/parse-malloc-history:
773         (main):
774         * Scripts/prepare-ChangeLog:
775         (diffCommand):
776         (statusCommand):
777         (findOriginalFileFromSvn):
778         (determinePropertyChanges):
779         * Scripts/resolve-ChangeLogs:
780         (conflictFiles):
781         (resolveConflict):
782         (showStatus):
783         * Scripts/svn-apply:
784         (patch):
785         (scmCopy):
786         (scmAdd):
787         (scmRemove):
788         * Scripts/svn-create-patch:
789         (findBaseUrl):
790         (findMimeType):
791         (findSourceFileAndRevision):
792         (generateDiff):
793         (generateFileList):
794         (manufacturePatchForAdditionWithHistory):
795         * Scripts/svn-unapply:
796         (patch):
797         (revertDirectories):
798
799 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
800
801         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
802         https://bugs.webkit.org/show_bug.cgi?id=74617
803
804         Reviewed by Kenneth Rohde Christiansen.
805
806         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
807         for viewport info button, adjusted height and added rounded corners.
808
809 2011-12-15  Andy Estes  <aestes@apple.com>
810
811         TestFailures: store the name of the buildbot results directory in a property
812         https://bugs.webkit.org/show_bug.cgi?id=74663
813
814         Reviewed by Adam Barth.
815         
816         Store the name of the results directory as a property on Buildbot's
817         prototype. This allows subclasses of Buildbot to customize the results
818         directory.
819
820         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
821         (Buildbot.prototype.resultsDirectoryURL):
822
823 2011-12-15  Tony Chang  <tony@chromium.org>
824
825         [chromium] pass --delete_unversioned_trees to gclient on the bots
826         https://bugs.webkit.org/show_bug.cgi?id=74565
827
828         Reviewed by Kenneth Russell.
829
830         It was temporarily removed in r102891 to keep the bots green.  Now
831         that the bots have cycled, we can add it back.
832
833         * Scripts/update-webkit-chromium:
834
835 2011-12-15  Kentaro Hara  <haraken@chromium.org>
836
837         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
838         https://bugs.webkit.org/show_bug.cgi?id=74497
839
840         Reviewed by Ryosuke Niwa.
841
842         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
843         manner. This bug is one of the incremental refactorings to remove all top-level
844         code and global variables from prepare-ChangeLog. In this patch,
845         we make the following global variables be used only through parameter passing.
846             - $bugDescription
847             - $bugNumber
848             - $name
849             - $emailAddress
850             - $gitReviewer
851             - $writeChangeLogs
852
853         * Scripts/prepare-ChangeLog:
854         (fetchBugDescriptionFromURL):
855         (generateNewChangeLogs):
856         (reviewerAndDescriptionForGitCommit):
857
858 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
859
860         [EFL] Add a few more web database functions to ewk_settings.
861         https://bugs.webkit.org/show_bug.cgi?id=72148
862
863         Reviewed by Antonio Gomes.
864
865         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
866         (LayoutTestController::clearAllDatabases):
867         (LayoutTestController::setDatabaseQuota):
868
869 2011-12-15  Martin Kosiba  <mkosiba@google.com>
870
871         Fix find on web pages with -webkit-user-select: none for Chromium
872         https://bugs.webkit.org/show_bug.cgi?id=72281
873
874         Reviewed by Ryosuke Niwa.
875
876         Provided a partial findString implementation. This doesn't support
877         all of the FindOptions since they're not exposed via WebFindOptions.
878
879         * DumpRenderTree/chromium/LayoutTestController.cpp:
880         (LayoutTestController::LayoutTestController):
881         (LayoutTestController::findString):
882         * DumpRenderTree/chromium/LayoutTestController.h:
883
884 2011-12-15  Kenneth Russell  <kbr@google.com>
885
886         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
887         https://bugs.webkit.org/show_bug.cgi?id=74581
888
889         Reviewed by Darin Fisher.
890
891         * DumpRenderTree/chromium/LayoutTestController.cpp:
892         (LayoutTestController::overridePreference):
893         * DumpRenderTree/chromium/WebPreferences.cpp:
894         (WebPreferences::reset):
895         (WebPreferences::applyTo):
896         * DumpRenderTree/chromium/WebPreferences.h:
897
898 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
899
900         [Qt] Improve the look of the viewport info overlay
901
902         Reviewed by Tor Arne Vestbø.
903
904         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
905
906 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
907
908         [Qt] Support requestAnimationFrame API
909         https://bugs.webkit.org/show_bug.cgi?id=74528
910
911         Add build-option for requestAnimationFrame feature.
912
913         Reviewed by Kenneth Rohde Christiansen.
914
915         * qmake/mkspecs/features/features.prf:
916
917 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
918
919         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
920
921         Reviewed by Simon Hausmann.
922
923         * qmake/mkspecs/features/webcore.prf:
924
925 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
926
927         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
928         https://bugs.webkit.org/show_bug.cgi?id=72893
929
930         Reviewed by Kenneth Rohde Christiansen.
931
932         This patch extends QQuickWebViewExperimental by a property named
933         viewportInfo, which contains the viewport scalability and
934         layout and contents size information. This property is exposed to
935         QML through the experimental extension for QQuickWebView.
936
937         * MiniBrowser/qt/MiniBrowser.pro:
938         * MiniBrowser/qt/MiniBrowser.qrc:
939         * MiniBrowser/qt/icons/info.png: Added.
940         * MiniBrowser/qt/qml/BrowserWindow.qml:
941         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
942
943 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
944
945         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
946         https://bugs.webkit.org/show_bug.cgi?id=74586
947
948         Reviewed by Hajime Morita.
949
950         No new tests. Covered by existing tests.
951
952         * DumpRenderTree/chromium/WebViewHost.cpp:
953         (WebViewHost::requestCheckingOfText):
954           Returns immediately if text is empty.
955
956 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
957
958         [Qt] QtWebKit fails to build on Mac OS X after r102776
959         https://bugs.webkit.org/show_bug.cgi?id=74593
960
961         Reviewed by Simon Hausmann.
962
963         CONFIG =+ link_pkgconfig is needed such that the correct parameters
964         are passed to the compiler.
965
966         * DumpRenderTree/qt/DumpRenderTree.pro:
967
968 2011-12-14  Tony Chang  <tony@chromium.org>
969
970         [chromium] Remove redundant third_party entries from chromium DEPS
971         https://bugs.webkit.org/show_bug.cgi?id=74472
972
973         Reviewed by Kenneth Russell.
974
975         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
976
977 2011-12-14  Kentaro Hara  <haraken@chromium.org>
978
979         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
980         VCSUtils::isGit() and VCSUtils::isSVN().
981         https://bugs.webkit.org/show_bug.cgi?id=74485
982
983         Reviewed by David Kilzer.
984
985         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
986         manner. This bug is one of the incremental refactorings to remove all top-level
987         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
988         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
989         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
990         just by looking at the current working directory.
991
992         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
993         (diffFromToString):
994         (diffCommand):
995         (statusCommand):
996         (createPatchCommand):
997         (diffHeaderFormat):
998         (generateFileList):
999         (isAddedStatus):
1000         (isConflictStatus):
1001         (statusDescription):
1002         (extractLineRange):
1003
1004 2011-12-14  Sam Weinig  <weinig@apple.com>
1005
1006         Remove whitespace from InheritedPropertySheets attributes in
1007         vsprops files to appease the Visual Studio project migrator.
1008
1009         Reviewed by Adam Roben.
1010
1011         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
1012         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1013         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1014         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1015         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1016         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1017         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1018         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1019         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1020         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1021         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1022         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1023         * DumpRenderTree/win/ImageDiffDebug.vsprops:
1024         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1025         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1026         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1027         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1028         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1029         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1030         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1031         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1032         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1033         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1034         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1035         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1036         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1037         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1038         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1039         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1040         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1041         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1042         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1043         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1044         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1045         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1046         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1047         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1048         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1049         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1050         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1051         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1052         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1053         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1054         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1055         * WinLauncher/WinLauncherDebug.vsprops:
1056         * WinLauncher/WinLauncherDebugAll.vsprops:
1057         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1058         * WinLauncher/WinLauncherProduction.vsprops:
1059         * WinLauncher/WinLauncherRelease.vsprops:
1060         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1061         * record-memory-win/record-memory-winDebug.vsprops:
1062         * record-memory-win/record-memory-winDebugAll.vsprops:
1063         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1064         * record-memory-win/record-memory-winProduction.vsprops:
1065         * record-memory-win/record-memory-winRelease.vsprops:
1066         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1067
1068 2011-12-14  Anders Carlsson  <andersca@apple.com>
1069
1070         Windows build fix.
1071
1072         Move CHECKs out of the destructor.
1073
1074         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1075         (TestWebKitAPI::B::~B):
1076         (TestWebKitAPI::TEST):
1077
1078 2011-12-14  Anders Carlsson  <andersca@apple.com>
1079
1080         binding a member function should ref/deref the object pointer if needed
1081         https://bugs.webkit.org/show_bug.cgi?id=74552
1082
1083         Reviewed by Sam Weinig.
1084
1085         Add new tests.
1086
1087         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1088         (TestWebKitAPI::B::B):
1089         (TestWebKitAPI::B::~B):
1090         (TestWebKitAPI::B::ref):
1091         (TestWebKitAPI::B::deref):
1092         (TestWebKitAPI::B::f):
1093         (TestWebKitAPI::B::g):
1094         (TestWebKitAPI::TEST):
1095
1096 2011-12-14  Hajime Morrita  <morrita@chromium.org>
1097
1098         JS_INLINE and WTF_INLINE should be visible from WebCore
1099         https://bugs.webkit.org/show_bug.cgi?id=73191
1100
1101         Reviewed by Kevin Ollivier.
1102
1103         Removed macro definitions which is now provided by Platform.h
1104
1105         * DumpRenderTree/chromium/config.h:
1106         * DumpRenderTree/config.h:
1107         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1108         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1109         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1110         * TestWebKitAPI/config.h:
1111         * WebKitTestRunner/config.h:
1112
1113 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1114
1115         Unreviewed, rolling out r102761.
1116         http://trac.webkit.org/changeset/102761
1117         https://bugs.webkit.org/show_bug.cgi?id=74485
1118
1119         we came up with a better fix than this (see comments in bug
1120         74485)
1121
1122         * Scripts/prepare-ChangeLog:
1123         (generateFunctionLists):
1124         (printDiff):
1125         (diffCommand):
1126         (statusCommand):
1127         (createPatchCommand):
1128         (generateFileList):
1129         (isAddedStatus):
1130         (isConflictStatus):
1131         (statusDescription):
1132         (extractLineRange):
1133
1134 2011-12-14  Anders Carlsson  <andersca@apple.com>
1135
1136         Work around a bug in the MSVC2005 compiler
1137         https://bugs.webkit.org/show_bug.cgi?id=74550
1138
1139         Reviewed by Sam Weinig.
1140
1141         Re-enable tests.
1142
1143         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1144
1145 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1146
1147         [Qt] Test fonts are not used with Qt5
1148         https://bugs.webkit.org/show_bug.cgi?id=72513
1149
1150         My last unreviewed buildfix for this crazy bug.
1151
1152         * qmake/mkspecs/features/features.prf:
1153
1154 2011-12-14  Anders Carlsson  <andersca@apple.com>
1155
1156         Another attempt at fixing the Windows build.
1157
1158         Disable all the tests until I can figure out what's going on here.
1159
1160         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1161
1162 2011-12-14  Anders Carlsson  <andersca@apple.com>
1163
1164         Fix the Windows build.
1165
1166         Disable some of the tests for now.
1167
1168         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1169
1170 2011-12-14  Anders Carlsson  <andersca@apple.com>
1171
1172         bind should handle member functions
1173         https://bugs.webkit.org/show_bug.cgi?id=74529
1174
1175         Reviewed by Sam Weinig.
1176
1177         Add tests.
1178
1179         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1180         (TestWebKitAPI::A::A):
1181         (TestWebKitAPI::A::f):
1182         (TestWebKitAPI::A::addF):
1183         (TestWebKitAPI::TEST):
1184
1185 2011-12-14  Anders Carlsson  <andersca@apple.com>
1186
1187         Add unary and binary bind overloads
1188         https://bugs.webkit.org/show_bug.cgi?id=74524
1189
1190         Reviewed by Sam Weinig.
1191
1192         Add tests.
1193
1194         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1195         (TestWebKitAPI::TEST):
1196         (TestWebKitAPI::multiplyByTwo):
1197         (TestWebKitAPI::multiplyByOneAndAHalf):
1198         (TestWebKitAPI::multiply):
1199         (TestWebKitAPI::subtract):
1200
1201 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1202
1203         [Qt] Test fonts are not used with Qt5
1204         https://bugs.webkit.org/show_bug.cgi?id=72513
1205
1206         MIPS and SH4 buildfix after r102776 and r102795.
1207
1208         Reviewed by Csaba Osztrogonác.
1209
1210         * qmake/mkspecs/features/features.prf:
1211
1212 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1213
1214         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1215
1216         * qmake/mkspecs/features/features.prf:
1217
1218 2011-12-14  Andreas Kling  <kling@webkit.org>
1219
1220         Make my e-mail address a little more awesome.
1221
1222         * Scripts/webkitpy/common/config/committers.py:
1223
1224 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1225
1226         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1227
1228         * qmake/mkspecs/features/webcore.prf:
1229
1230 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
1231
1232         [Qt] Test fonts are not used with Qt5
1233         https://bugs.webkit.org/show_bug.cgi?id=72513
1234
1235         Reviewed by Simon Hausmann.
1236
1237         Don't depend on Q_WS_X11 anymore since it's not the Qt5
1238         way to detect the platform. Make the guards depend
1239         on our own configtest for fontconfig. For Qt4 we can still
1240         use the preassumption that we have it on Linux.
1241
1242         * DumpRenderTree/qt/DumpRenderTree.pro:
1243         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1244         (WebCore::DumpRenderTree::open):
1245         (WebCore::DumpRenderTree::initializeFonts):
1246         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1247         * DumpRenderTree/qt/main.cpp:
1248         (main): Additionally remove a nonsense piece of code that was
1249         trying to reset the font settings - which is not necessary -
1250         after we have already returned from main.
1251         * WebKitTestRunner/InjectedBundle/Target.pri:
1252         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1253         (WTR::activateFonts):
1254         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1255         from WTR. It is not needed. We set up the fonts via the injected bundle.
1256         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1257         (main):
1258         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1259         * qmake/mkspecs/features/features.prf:
1260         * qmake/sync.profile:
1261
1262 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1263
1264         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1265
1266         Followup to r102679
1267
1268         https://bugs.webkit.org/show_bug.cgi?id=74413
1269
1270         Reviewed by Simon Hausmann.
1271
1272         * qmake/mkspecs/features/webcore.prf:
1273
1274 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
1275
1276         [Qt] Mobile theme could use a little refresh
1277         https://bugs.webkit.org/show_bug.cgi?id=74293
1278
1279         Have MiniBrowser use the mobile theme when not
1280         passed --desktop.
1281
1282         Reviewed by Kenneth Rohde Christiansen.
1283
1284         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1285         (MiniBrowserApplication::handleUserOptions):
1286
1287 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
1288
1289         [Qt] [Gardening] Remove qt-4.7 layout tests dir
1290         https://bugs.webkit.org/show_bug.cgi?id=74426
1291
1292         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1293         on the tree.
1294
1295         Reviewed by Csaba Osztrogonác.
1296
1297         * Scripts/webkitpy/layout_tests/port/qt.py:
1298         (QtPort.qt_version):
1299         (QtPort.baseline_search_path):
1300         (QtPort._skipped_file_search_paths):
1301         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1302         (QtPortTest._assert_search_path):
1303
1304 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1305
1306         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1307         through parameter passing
1308         https://bugs.webkit.org/show_bug.cgi?id=74485
1309
1310         Reviewed by Ryosuke Niwa.
1311
1312         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1313         manner. This bug is one of the incremental refactorings to remove all top-level
1314         code and global variables from prepare-ChangeLog. In this patch,
1315         we make the following global variables be used only through parameter passing.
1316             - $isGit
1317             - $isSVN
1318
1319         * Scripts/prepare-ChangeLog:
1320         (generateFunctionLists):
1321         (printDiff):
1322         (diffFromToString):
1323         (diffCommand):
1324         (statusCommand):
1325         (createPatchCommand):
1326         (diffHeaderFormat):
1327         (generateFileList):
1328         (isAddedStatus):
1329         (isConflictStatus):
1330         (statusDescription):
1331         (extractLineRange):
1332
1333 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1334
1335         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1336         https://bugs.webkit.org/show_bug.cgi?id=74417
1337
1338         Reviewed by Simon Hausmann.
1339
1340         Based on original patch by Kenneth Christiansen.
1341
1342         Already covered by current tests.
1343
1344         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1345         (WebCore::DumpRenderTree::DumpRenderTree):
1346         (WebCore::DumpRenderTree::~DumpRenderTree):
1347         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1348         (LayoutTestController::setMockDeviceOrientation):
1349
1350 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1351
1352         [GTK] Bad text rendering since r101343
1353         https://bugs.webkit.org/show_bug.cgi?id=73744
1354
1355         Reviewed by Martin Robinson.
1356
1357         Turn cairo hint metrics off for better font metrics reporting in
1358         the tests. This is especially important for SVG.
1359
1360         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1361         (initializeGtkFontSettings):
1362         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1363         (WTR::initializeGtkSettings):
1364
1365 2011-12-13  Kentaro Hara  <haraken@chromium.org>
1366
1367         [Refactoring] Remove several global variables from prepare-ChangeLog
1368         https://bugs.webkit.org/show_bug.cgi?id=74389
1369
1370         Reviewed by David Kilzer.
1371
1372         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1373         manner. This bug is one of the incremental refactorings to remove all top-level
1374         code and global variables from prepare-ChangeLog. In this patch,
1375         we make the following global variables being used only through parameter passing.
1376             - %paths
1377             - $changedFiles
1378             - $conflictFiles
1379             - $functionLists
1380             - $bugURL
1381
1382         * Scripts/prepare-ChangeLog:
1383         (findChangeLogs):
1384         (generateNewChangeLogs):
1385         (processPaths):
1386         (generateFileList):
1387         (firstDirectoryOrCwd):
1388
1389 2011-12-13  Anders Carlsson  <andersca@apple.com>
1390
1391         Add a very bare-bones implementation of bind and Function to WTF
1392         https://bugs.webkit.org/show_bug.cgi?id=74462
1393
1394         Reviewed by Sam Weinig.
1395
1396         Add basic tests for WTF::Function and WTF::bind.
1397
1398         * TestWebKitAPI/TestWebKitAPI.gypi:
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400         * TestWebKitAPI/Tests/Functional.cpp: Added.
1401         (TestWebKitAPI::returnFortyTwo):
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1404
1405 2011-12-13  Robin Dunn  <robin@alldunn.com>
1406
1407         [wx] Add a URL argument to wxWebView constructor.
1408         https://bugs.webkit.org/show_bug.cgi?id=74316
1409         
1410         Reviewed by Kevin Ollivier.
1411
1412         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1413         (MyApp::OnInit):
1414         * wx/browser/browser.cpp:
1415         (MyApp::OnInit):
1416
1417 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1418
1419         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1420         https://bugs.webkit.org/show_bug.cgi?id=74430
1421
1422         Reviewed by David Levin.
1423
1424         * Scripts/webkitpy/common/config/watchlist:
1425
1426 2011-12-13  Peter Beverloo  <peter@chromium.org>
1427
1428         [Chromium] Pull in FreeType and decrease check-out complexity for Android
1429         https://bugs.webkit.org/show_bug.cgi?id=74401
1430
1431         Decrease the check-out complexity by removing the need to first run
1432         "update-webkit-chromium --chromium" prior to running it with
1433         "--chromium-android", which was caused by an unversioned third_party/
1434         directory being created. This moves the Android NDK to Source/WebKit/
1435         chromium/, coming from third_party/ in that directory.
1436
1437         Reviewed by Adam Barth.
1438
1439         * Scripts/update-webkit-chromium:
1440         * Scripts/webkitdirs.pm:
1441         (buildChromiumMakefile):
1442
1443 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1444
1445         build-jsc passing incorrect args to buildGtkProject
1446         https://bugs.webkit.org/show_bug.cgi?id=74308
1447
1448         Reviewed by Gustavo Noronha Silva.
1449
1450         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1451         another argument about webkit2, unshift a --disable-webkit2
1452         argument onto the buildArgs.
1453         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1454         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1455         and build-jsc are run one after the other.
1456
1457 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1458
1459         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1460         https://bugs.webkit.org/show_bug.cgi?id=74413
1461
1462         Unreviewed buildfix.
1463
1464         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1465
1466 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1467
1468         [Qt] Unreviewed speculativ debug buildfix after r102679.
1469
1470         * QtTestBrowser/QtTestBrowser.pro:
1471         * QtTestBrowser/main.cpp:
1472
1473 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1474
1475         [Qt] Get rid of layering violations in includes
1476
1477         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1478         in the webcore.prf, but rather in each target that specificly needs
1479         headers in these location. We used to include them directly in webcore
1480         since we had layering violations between WebCore and WebKit, but now
1481         that they are gone there's no reason to do that.
1482
1483         Reviewed by Simon Hausmann.
1484
1485         * DumpRenderTree/qt/DumpRenderTree.pro:
1486         * QtTestBrowser/launcherwindow.h:
1487         * WebKitTestRunner/InjectedBundle/Target.pri:
1488         * qmake/mkspecs/features/webcore.prf:
1489         * qmake/mkspecs/features/webkit2.prf:
1490
1491 2011-12-13  János Badics  <dicska@gmail.com>
1492
1493         [NRWT] It crashes intermittently when there are WebProcess crashes
1494         https://bugs.webkit.org/show_bug.cgi?id=73451
1495
1496         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1497
1498         Reviewed by Kenneth Rohde Christiansen.
1499
1500         * Scripts/webkitpy/layout_tests/port/server_process.py:
1501         (ServerProcess._check_for_crash):
1502
1503 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1504
1505         Unreviewed. Fix GTK+ API docs build.
1506
1507         * gtk/generate-gtkdoc:
1508         (get_webkit2_options): Ignore WebKitUIClient since it's private
1509         API.
1510
1511 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1512
1513         Reviewed, removed one of my email addresses to use the apprpriate one.
1514
1515         * Scripts/webkitpy/common/config/committers.py:
1516
1517 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1518
1519         [Qt] Fix skip list search path and expected file search path in ORWT
1520         https://bugs.webkit.org/show_bug.cgi?id=74281
1521
1522         Expected file search path fixed.
1523
1524         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1525
1526         Reviewed by Csaba Osztrogonác.
1527
1528         * Scripts/old-run-webkit-tests:
1529         (buildPlatformResultHierarchy):
1530         (buildPlatformTestHierarchy):
1531         (readSkippedFiles):
1532
1533 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1534
1535         [Qt] Missing layoutTestController.dumpWillCacheResponse
1536         https://bugs.webkit.org/show_bug.cgi?id=74287
1537
1538         Reviewed by Csaba Osztrogonác.
1539
1540         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1541         (LayoutTestController::reset):
1542         (LayoutTestController::dumpWillCacheResponse):
1543         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1544
1545 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1546
1547         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1548         https://bugs.webkit.org/show_bug.cgi?id=73771
1549
1550         Reviewed by Gustavo Noronha Silva.
1551
1552         When using a fallback font during testing, always use DejaVu Sans. This prevents
1553         falling back to DejaVu Serif on some systems.
1554
1555         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1556
1557 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1558
1559         Add myself as a committer
1560
1561         * Scripts/webkitpy/common/config/committers.py:
1562
1563 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1564
1565         [Qt] [WK2] Support customizing popup menus with QML
1566         https://bugs.webkit.org/show_bug.cgi?id=73560
1567
1568         Reviewed by Tor Arne Vestbø.
1569
1570         Add an Item Selector to our WebView using the experimental API.
1571
1572         * MiniBrowser/qt/MiniBrowser.pro:
1573         * MiniBrowser/qt/MiniBrowser.qrc:
1574         * MiniBrowser/qt/qml/BrowserWindow.qml:
1575         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1576
1577 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1578
1579         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1580         https://bugs.webkit.org/show_bug.cgi?id=74283
1581
1582         Reviewed by Simon Hausmann.
1583
1584         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1585         (MiniBrowserApplication::sendTouchEvent):
1586
1587 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1588
1589         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1590         to show ChangeLogs diff and open ChangeLogs in an editor
1591         https://bugs.webkit.org/show_bug.cgi?id=74266
1592
1593         Reviewed by Ryosuke Niwa.
1594
1595         We are planning to write unit-tests for prepare-ChangeLog
1596         in a run-leaks_unittest manner. This patch is one of the incremental
1597         refactorings to remove all top-level code and global variables from
1598         prepare-ChangeLog.
1599
1600         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1601         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1602         Renamed @changed_files to @changedFiles.
1603         Renamed %conflict_files to %conflictFiles.
1604         (generateFunctionLists):
1605         (printDiff):
1606         (openChangeLogs):
1607
1608 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1609
1610         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1611         https://bugs.webkit.org/show_bug.cgi?id=74257
1612
1613         Reviewed by Ryosuke Niwa.
1614
1615         We are planning to write unit-tests for prepare-ChangeLog
1616         in a run-leaks_unittest/ manner. This patch is one of the incremental
1617         refactorings to remove all top-level code and global variables from
1618         prepare-ChangeLog.
1619
1620         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1621         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1622         into resolveConflictedChangeLogs().
1623         (getLatestChangeLogs):
1624         (resolveConflictedChangeLogs):
1625
1626 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1627
1628         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1629         https://bugs.webkit.org/show_bug.cgi?id=74253
1630
1631         Reviewed by David Kilzer.
1632
1633         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1634         which requires to remove top-level code and global variables. This patch is one of
1635         the incremental refactorings for that.
1636
1637         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1638         (generateFunctionLists):
1639         (findChangeLogs):
1640         (generateNewChangeLogs):
1641         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1642
1643 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1644
1645         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1646         https://bugs.webkit.org/show_bug.cgi?id=74175
1647
1648         Reviewed by Ryosuke Niwa.
1649
1650         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1651         This requires to remove top-level code. This patch is one of the incremental refactorings
1652         for that.
1653
1654         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1655         (findChangeLogs):
1656
1657 2011-12-10  Andreas Kling  <kling@webkit.org>
1658
1659         Add my Apple e-mail to committers.py.
1660
1661         * Scripts/webkitpy/common/config/committers.py:
1662
1663 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1664
1665         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1666         https://bugs.webkit.org/show_bug.cgi?id=74225
1667
1668         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1669         the "All.gyp" solution doesn't work on windows.
1670
1671         * Scripts/webkitdirs.pm:
1672         (buildChromium):
1673
1674 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1675
1676         [Qt] Click's count is limited to three continuous clicks.
1677         https://bugs.webkit.org/show_bug.cgi?id=45666
1678
1679         Reviewed by Kenneth Rohde Christiansen.
1680
1681         Update m_time at every call to leapForward, so double clicks
1682         event are correctly sent by EventSender.
1683
1684         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1685         (WTR::EventSenderProxy::updateClickCountForButton):
1686         (WTR::EventSenderProxy::leapForward):
1687
1688 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1689
1690         [Refactoring] Reduce top-level code in prepare-ChangeLog
1691         https://bugs.webkit.org/show_bug.cgi?id=74172
1692
1693         Reviewed by Ryosuke Niwa.
1694
1695         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1696         This requires to remove top-level code. This patch is one of the incremental refactorings
1697         for that.
1698
1699         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1700         (generateFunctionLists):
1701
1702 2011-12-09  Sam Weinig  <sam@webkit.org>
1703
1704         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1705         https://bugs.webkit.org/show_bug.cgi?id=74218
1706
1707         Reviewed by Anders Carlsson.
1708
1709         Add a test of the WKConnectionRef API.
1710
1711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1712         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1713         (TestWebKitAPI::didCreateConnection):
1714         (TestWebKitAPI::connectionDidReceiveMessage):
1715         (TestWebKitAPI::connectionDidClose):
1716         (TestWebKitAPI::TEST):
1717         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1718         (TestWebKitAPI::connectionDidReceiveMessage):
1719         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1720         (TestWebKitAPI::WKConnectionTest::initialize):
1721
1722 2011-12-09  David Levin  <levin@chromium.org>
1723
1724         Hash* iterators should allow comparison between const and const versions.
1725         https://bugs.webkit.org/show_bug.cgi?id=73370
1726
1727         Reviewed by Darin Adler.
1728
1729         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1731         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1732         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1733         (TestWebKitAPI::TEST): Add a test for the new functionality.
1734
1735 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1736
1737         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1738         https://bugs.webkit.org/show_bug.cgi?id=74212
1739
1740         Reviewed by Tony Chang.
1741
1742         The change introduced in r102201 to split the executables out of
1743         WebKit.gyp apparently doesn't work right on Windows, since
1744         WebKit.gyp and Tools.gyp refer to dependent projects by
1745         different relative paths (it appears gyp doesn't normalize the
1746         paths). This change moves Tools.gyp to be in the same directory
1747         as WebKit.gyp (and All.gyp), which should fix this and
1748         conveniently will also solve the problem of how to add Tools.gyp
1749         to the chromium DEPS file.
1750
1751         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1752
1753 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1754
1755         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1756         https://bugs.webkit.org/show_bug.cgi?id=74173
1757
1758         Reviewed by Ryosuke Niwa.
1759
1760         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1761         This requires to remove top-level code. This patch is one of the incremental refactorings
1762         for that.
1763
1764         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1765         (fetchBugDescriptionFromURL):
1766
1767 2011-12-09  Tony Chang  <tony@chromium.org>
1768
1769         Switch the chromium mac bots to using skia test results
1770         https://bugs.webkit.org/show_bug.cgi?id=74201
1771
1772         Reviewed by Ryosuke Niwa.
1773
1774         This is reverting http://trac.webkit.org/changeset/97781 and changing
1775         the name in master.cfg to no longer have cg in the name.
1776
1777         * BuildSlaveSupport/build.webkit.org-config/config.json:
1778         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1779         (appendCustomBuildFlags):
1780         (RunWebKitTests.start):
1781
1782 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1783
1784         [Qt] Remove a wrongly placed ASSERT.
1785
1786         Reviewed by Tor Arne Vestbø.
1787
1788         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1789         (MiniBrowserApplication::notify):
1790
1791 2011-12-09  Cary Clark  <caryclark@google.com>
1792
1793         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1794         https://bugs.webkit.org/show_bug.cgi?id=74118
1795
1796         Reviewed by Adam Barth.
1797
1798         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1799         (get):
1800         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1801         (ChromiumMacPort.__init__):
1802         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1803         (ChromiumMacPortTest.test_versions):
1804         (ChromiumMacPortTest.test_graphics_type):
1805
1806 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1807
1808         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1809
1810         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1811         this failed when moving files in the source tree, as the .d file would contain
1812         stale dependencies on the old source file location. By keeping the object files
1813         (and hence the depdendency files) in a proper tree structure inside the objects
1814         directory we can prevent this failure.
1815
1816         A side benefit is that we can also have objects with the same name inside the
1817         same project.
1818
1819         Reviewed by Simon Hausmann.
1820
1821         * qmake/mkspecs/features/unix/default_pre.prf:
1822
1823 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1824
1825         Unreviewed. Update unit test after r102412.
1826
1827         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1828         (IRCCommandTest.test_whois):
1829
1830 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1831
1832         REGRESSION(r102105): run-bindings-tests should output full diff results
1833         https://bugs.webkit.org/show_bug.cgi?id=74166
1834
1835         Reviewed by Adam Barth.
1836
1837         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1838         run-bindings-tests should output full diff results.
1839
1840         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1841         (BindingsTests.generate_from_idl):
1842         (BindingsTests.generate_supplemental_dependency):
1843         (BindingsTests.detect_changes):
1844
1845 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
1846
1847         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1848         https://bugs.webkit.org/show_bug.cgi?id=73990
1849
1850         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1851
1852         Fix QtQuick includes after move from QtDeclarative to QtQuick.
1853
1854         * MiniBrowser/qt/BrowserWindow.h:
1855         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1856
1857 2011-12-08  Adam Klein  <adamk@chromium.org>
1858
1859         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1860         https://bugs.webkit.org/show_bug.cgi?id=73492
1861
1862         Reviewed by Adam Barth.
1863
1864         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1865         keypress event without any script on the stack.
1866
1867         * DumpRenderTree/chromium/EventSender.cpp:
1868         (EventSender::EventSender):
1869         (EventSender::keyDown):
1870         (KeyDownTask::KeyDownTask):
1871         (KeyDownTask::runIfValid):
1872         (EventSender::scheduleAsynchronousKeyDown):
1873         * DumpRenderTree/chromium/EventSender.h:
1874
1875 2011-12-08  Hayato Ito  <hayato@chromium.org>
1876
1877         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1878         https://bugs.webkit.org/show_bug.cgi?id=73980
1879
1880         Reviewed by Tony Chang.
1881
1882         * gdb/webkit.py:
1883         (guess_string_length):
1884         (ustring_to_string):
1885         (lstring_to_string):
1886         (LCharStringPrinter):
1887         (LCharStringPrinter.to_string):
1888         (WTFStringImplPrinter.get_length):
1889         (WTFStringImplPrinter.to_string):
1890         (WTFStringImplPrinter.is_8bit):
1891         (WTFStringPrinter.stringimpl_ptr):
1892         (WTFStringPrinter.get_length):
1893         (WTFStringPrinter.to_string):
1894         (add_pretty_printers.lookup_function):
1895
1896 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1897
1898         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1899         https://bugs.webkit.org/show_bug.cgi?id=73916
1900
1901         Reviewed by Kent Tamura.
1902
1903         * qmake/mkspecs/features/features.prf:
1904
1905 2011-12-08  Adrienne Walker  <enne@google.com>
1906
1907         Unreviewed contributor additions to committers.py.
1908
1909         * Scripts/webkitpy/common/config/committers.py:
1910
1911 2011-12-08  David Reveman  <reveman@chromium.org>
1912
1913         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1914         https://bugs.webkit.org/show_bug.cgi?id=74017
1915
1916         Reviewed by James Robinson.
1917         
1918         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1919
1920         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1921         (main):
1922         * DumpRenderTree/chromium/TestShell.cpp:
1923         (TestShell::TestShell):
1924         (TestShell::resetWebSettings):
1925         * DumpRenderTree/chromium/TestShell.h:
1926         (TestShell::setAcceleratedPaintingEnabled):
1927         (TestShell::setPerTilePaintingEnabled):
1928         * DumpRenderTree/chromium/WebPreferences.cpp:
1929         (WebPreferences::reset):
1930         (WebPreferences::applyTo):
1931         * DumpRenderTree/chromium/WebPreferences.h:
1932         * Scripts/webkitpy/layout_tests/port/chromium.py:
1933         (ChromiumDriver._wrapper_options):
1934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1935         (parse_args):
1936
1937 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1938
1939         create a "SystemHost" object for webkitpy to slim down the Host object
1940         https://bugs.webkit.org/show_bug.cgi?id=72680
1941
1942         Reviewed by Eric Siedel.
1943
1944         This creates a SystemHost object that other objects that should
1945         only have dependencies on functionality in webkitpy.common.system
1946         can use; this will allow them to not require a full Host.
1947
1948         * Scripts/webkitpy/common/host.py:
1949         * Scripts/webkitpy/common/host_mock.py:
1950         * Scripts/webkitpy/common/system/systemhost.py: Added.
1951         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
1952
1953 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
1954
1955         AX: platform/mac/accessibility/search-with-frames.html crashes
1956         https://bugs.webkit.org/show_bug.cgi?id=74093
1957
1958         Reviewed by Darin Adler.
1959
1960         Take care of the case when an incoming element is null.
1961
1962         * DumpRenderTree/AccessibilityUIElement.cpp:
1963         (uiElementForSearchPredicateCallback):
1964         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1965         (AccessibilityUIElement::uiElementForSearchPredicate):
1966         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1967         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1968
1969 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
1970
1971         [Qt] Visualize mock point ID's in the MiniBrowser
1972         https://bugs.webkit.org/show_bug.cgi?id=74098
1973
1974         Reviewed by Tor Arne Vestbø.
1975
1976         * MiniBrowser/qt/BrowserWindow.cpp:
1977         (BrowserWindow::updateVisualMockTouchPoints):
1978         * MiniBrowser/qt/qml/MockTouchPoint.qml:
1979
1980 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
1981
1982         Accessibility: AccessibilityController should support listening to notifications on all elements.
1983         https://bugs.webkit.org/show_bug.cgi?id=72866
1984
1985         Adds addNotificationListener and removeNotificationListener methods
1986         to AccessibilityController, to listen to notifications on any element
1987         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
1988         implementations are all contained in this change.
1989
1990         On Mac, refactors AccessibilityNotificationHandler into its own
1991         source file that can be used by both AccessibilityController and
1992         AccessibilityUIElement. (Both DRT and WKTR.)
1993
1994         Reviewed by Chris Fleizach.
1995
1996         * DumpRenderTree/AccessibilityController.cpp:
1997         (addNotificationListenerCallback):
1998         (removeNotificationListenerCallback):
1999         (AccessibilityController::getJSClass):
2000         * DumpRenderTree/AccessibilityController.h:
2001         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2002         * DumpRenderTree/chromium/AccessibilityController.cpp:
2003         (AccessibilityController::AccessibilityController):
2004         (AccessibilityController::notificationReceived):
2005         (AccessibilityController::addNotificationListenerCallback):
2006         (AccessibilityController::removeNotificationListenerCallback):
2007         * DumpRenderTree/chromium/AccessibilityController.h:
2008         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2009         (AccessibilityController::addNotificationListener):
2010         (AccessibilityController::removeNotificationListener):
2011         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2012         (AccessibilityController::~AccessibilityController):
2013         (AccessibilityController::addNotificationListener):
2014         (AccessibilityController::removeNotificationListener):
2015         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2016         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2017         (-[NSString createJSStringRef]):
2018         (-[AccessibilityNotificationHandler init]):
2019         (-[AccessibilityNotificationHandler setPlatformElement:]):
2020         (-[AccessibilityNotificationHandler dealloc]):
2021         (-[AccessibilityNotificationHandler setCallback:]):
2022         (-[AccessibilityNotificationHandler startObserving]):
2023         (-[AccessibilityNotificationHandler _notificationReceived:]):
2024         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2025         (AccessibilityUIElement::addNotificationListener):
2026         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2027         (notificationListenerProc):
2028         (AccessibilityController::addNotificationListener):
2029         (AccessibilityController::removeNotificationListener):
2030         (AccessibilityController::winNotificationReceived):
2031         (AccessibilityController::winAddNotificationListener):
2032         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2033         (AccessibilityUIElement::addNotificationListener):
2034         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2035         (WTR::AccessibilityController::addNotificationListener):
2036         (WTR::AccessibilityController::removeNotificationListener):
2037         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2038         (WTR::AccessibilityController::logAccessibilityEvents):
2039         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2040         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2041         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2042         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2043         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2044         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2045         (WTR::AccessibilityController::addNotificationListener):
2046         (WTR::AccessibilityController::removeNotificationListener):
2047         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2048         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2049         (-[NSString createJSStringRef]):
2050         (-[AccessibilityNotificationHandler init]):
2051         (-[AccessibilityNotificationHandler setPlatformElement:]):
2052         (-[AccessibilityNotificationHandler dealloc]):
2053         (-[AccessibilityNotificationHandler setCallback:]):
2054         (-[AccessibilityNotificationHandler startObserving]):
2055         (-[AccessibilityNotificationHandler _notificationReceived:]):
2056         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2057         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2058         (WTR::AccessibilityUIElement::verticalScrollbar):
2059         (WTR::AccessibilityUIElement::addNotificationListener):
2060         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2061
2062 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2063
2064         [Qt][WK2] Unreviewed buildfix after r102352.
2065
2066         * qmake/mkspecs/features/webkit2.prf:
2067
2068 2011-12-08  Adam Roben  <aroben@apple.com>
2069
2070         Make finding crash logs by PID work on Snow Leopard
2071
2072         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2073         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2074         read the first line of the crash log and pull the PID out of there.
2075
2076         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2077         Snow Leopard
2078
2079         Reviewed by Darin Adler.
2080
2081         * Scripts/webkitpy/common/system/crashlogs.py:
2082         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2083         name and PID for the log, rather than checking the Lion-only app_description extended
2084         attribute. We now also reject the log if the process name doesn't match what we expect.
2085
2086         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2087         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2088         PID.
2089         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2090         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2091         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2092         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2093         read, files that actually contain a crash log for some other process, and files that are
2094         misformatted.
2095
2096         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2097         unused.
2098
2099         * Scripts/webkitpy/common/system/filesystem_mock.py:
2100         (MockFileSystem.__init__): Removed xattr support, which is now unused.
2101         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2102         ReadableTextFileObject. This function was completely broken before!
2103         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2104         bugs like the above.
2105         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2106         things like readline() and seek().
2107
2108         (ReadableTextFileObject.close):
2109         (ReadableTextFileObject.read):
2110         Added. We override the superclass implementation to account for using a StringIO object.
2111
2112         (ReadableTextFileObject.readline):
2113         (ReadableTextFileObject.seek):
2114         Added. These just call through to StringIO.
2115
2116         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2117         (MainTest.test_crash_log):
2118         (MainTest.test_web_process_crash_log):
2119         Changed to use make_mock_crash_report_darwin.
2120
2121 2011-12-06  Jon Lee  <jonlee@apple.com>
2122
2123         [WK2] Add permissions support (73960)
2124         https://bugs.webkit.org/show_bug.cgi?id=73960
2125         <rdar://problem/10357008>
2126
2127         Reviewed by Darin Adler.
2128
2129         Add null function item to comply with added callback to WKPageUIClient.
2130
2131         * MiniBrowser/mac/BrowserWindowController.m:
2132         (-[BrowserWindowController awakeFromNib]):
2133         * WebKitTestRunner/TestController.cpp:
2134         (WTR::TestController::createOtherPage):
2135         (WTR::TestController::initialize):
2136
2137 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
2138
2139         [Qt] Visualize mock points in the Qt MiniBrowser
2140         https://bugs.webkit.org/show_bug.cgi?id=74074
2141
2142         Reviewed by Tor Arne Vestbø.
2143
2144         * MiniBrowser/qt/BrowserWindow.cpp:
2145         (BrowserWindow::updateVisualMockTouchPoints):
2146         * MiniBrowser/qt/BrowserWindow.h:
2147         * MiniBrowser/qt/MiniBrowser.qrc:
2148         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2149         (MiniBrowserApplication::notify):
2150         (MiniBrowserApplication::sendTouchEvent):
2151         * MiniBrowser/qt/MiniBrowserApplication.h:
2152         * MiniBrowser/qt/icons/touchpoint.png: Added.
2153         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2154
2155 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
2156
2157         [Qt] WebKitTestRunner crashes with debug builds
2158         https://bugs.webkit.org/show_bug.cgi?id=74090
2159
2160         Reviewed by Tor Arne Vestbø.
2161
2162         * WebKitTestRunner/qt/TestControllerQt.cpp:
2163         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2164         to ensure WTF/JSC threading is initialized.
2165
2166 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2167
2168         fix build-webkit --chromium after breakage in r102201
2169         https://bugs.webkit.org/show_bug.cgi?id=74031
2170
2171         Reviewed by Tony Chang.
2172
2173         * Scripts/webkitdirs.pm:
2174         (buildChromium):
2175
2176 2011-12-08  Kentaro Hara  <haraken@chromium.org>
2177
2178         Unreviewed, rolling out r102280.
2179         http://trac.webkit.org/changeset/102280
2180         https://bugs.webkit.org/show_bug.cgi?id=74031
2181
2182         Chromium/Windows build is broken
2183
2184         * Scripts/webkitdirs.pm:
2185         (buildChromium):
2186
2187 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
2188
2189         Adding myself to committers list.
2190
2191         Unreviewed.
2192
2193         * Scripts/webkitpy/common/config/committers.py:
2194
2195 2011-12-07  Michael Saboff  <msaboff@apple.com>
2196
2197         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2198         https://bugs.webkit.org/show_bug.cgi?id=73995
2199
2200         Reenabled failing tests that the code part of the patch fixes.
2201
2202         Reviewed by Geoffrey Garen.
2203
2204         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2205         (TestWebKitAPI::TEST):
2206
2207 2011-12-07  MORITA Hajime  <morrita@google.com>
2208
2209         [filter-build-webkit] should not emit reset color when --no-color is given
2210         https://bugs.webkit.org/show_bug.cgi?id=73992
2211
2212         Reviewed by Daniel Bates.
2213
2214         Stop printing control sequences when --no-color is given.
2215         After this change, the filter runs nicely even on environments
2216         like Emacs compilation-mode which cannot understand the control sequence.
2217
2218         * Scripts/filter-build-webkit:
2219         (printLine):
2220
2221 2011-12-07  Eric Seidel  <eric@webkit.org>
2222
2223         Use free memory to determine if we have space for DRT instances instead of total memory
2224         https://bugs.webkit.org/show_bug.cgi?id=74021
2225
2226         Reviewed by Adam Barth.
2227
2228         This will hopefully make the Mac buildbots behave better.
2229
2230         I also reduced the expected memory needed per DRT now that
2231         we're properly accounting for the system memory in our calculations.
2232
2233         * Scripts/webkitpy/common/system/platforminfo.py:
2234         (PlatformInfo.total_bytes_memory):
2235         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2236         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2237         (MockPlatformInfo.total_bytes_memory):
2238         * Scripts/webkitpy/layout_tests/port/base.py:
2239         (Port.default_child_processes):
2240         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2241         (PortTest.test_default_child_processes):
2242
2243 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
2244
2245         fix build-webkit --chromium after breakage in r102201
2246         https://bugs.webkit.org/show_bug.cgi?id=74031
2247
2248         Reviewed by Tony Chang.
2249
2250         r102201 introduced a change to the chromium build that splits
2251         the executables out of WebKit.gyp into other gyp files, and adds
2252         a new "All.gyp" that builds everything. However, I forgot to
2253         update the build script to use All.gyp.
2254
2255         * Scripts/webkitdirs.pm:
2256         (buildChromium):
2257
2258 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
2259
2260         Moved myself to the committers list.
2261
2262         * Scripts/webkitpy/common/config/committers.py:
2263
2264 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2265
2266         [Qt] Fix debug shlib build with V8.
2267
2268         Reviewed by Tor Arne Vestbø.
2269
2270         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2271         v8 builds.
2272
2273 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2274
2275         [Qt] V8 build fixes.
2276
2277         Reviewed by Tor Arne Vestbø.
2278
2279         * qmake/mkspecs/features/javascriptcore.prf: Don't add
2280         Source/Thirdparty to the include search path here.
2281         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2282         used when building WebCore as well as using it, because header files like
2283         GraphicsContext3D.h include stuff from ThirdParty.
2284
2285 2011-12-07  Peter Beverloo  <peter@chromium.org>
2286
2287         [Chromium] Fix project file generation for the Android bot after r102201
2288         https://bugs.webkit.org/show_bug.cgi?id=73996
2289
2290         The gyp refactoring in r102201 was didn't explicitly exclude
2291         the Android operating system in Tools/Tools.gyp, which broke
2292         as gcc_version is not defined for that configuration.
2293
2294         Reviewed by Andreas Kling.
2295
2296         * Tools.gyp:
2297
2298 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
2299
2300         Unreviewed. Disabled failing tests on chromium.
2301
2302         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2303         (TestWebKitAPI::TEST):
2304
2305 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
2306
2307         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2308         https://bugs.webkit.org/show_bug.cgi?id=73382
2309
2310         Reviewed by Tony Chang.
2311
2312         XCode (and hence GYP) can't handle circular dependencies between
2313         files (and projects). Accordingly, although the binaries in
2314         WebKit.gyp depend on webkit_support and webkit_support depends
2315         on webkit, we don't mention the latter dependency in the file.
2316         To fix this, this change moves the binaries like DRT into a new
2317         GYP file, and modifies gyp_webkit to build from that file
2318         instead of WebKit.gyp.
2319
2320         * Tools.gyp: Added.
2321
2322 2011-12-06  Adam Roben  <aroben@apple.com>
2323
2324         Add a pid parameter to CrashLogs.find_newest_log
2325
2326         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2327         considered.
2328
2329         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2330         process whose crash log you want to find
2331
2332         Reviewed by Dirk Pranke.
2333
2334         * Scripts/webkitpy/common/system/crashlogs.py:
2335         (CrashLogs.find_newest_log): Added an optional pid parameter.
2336         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2337         candidate log's app_description extended attribute to see if that log corresponds to a
2338         crashed process with the specified PID.
2339
2340         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2341         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2342         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2343         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2344
2345         * Scripts/webkitpy/common/system/filesystem.py:
2346         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2347         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2348         present.
2349
2350         * Scripts/webkitpy/common/system/filesystem_mock.py:
2351         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2352         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2353         dictionary.
2354
2355         * Scripts/webkitpy/tool/commands/queries.py:
2356         (CrashLog): Added help text. Added an optional PID parameter.
2357         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2358
2359 2011-12-06  Adam Roben  <aroben@apple.com>
2360
2361         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2362
2363         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2364         alive beyond the normal timeout limit. In cases where the crashed process was able to die
2365         faster, NRWT would assume that Crash Reporter had finished even though it often was still
2366         running, which would lead to an incorrect crash log being picked up.
2367
2368         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2369
2370         Reviewed by Dirk Pranke.
2371
2372         * Scripts/webkitpy/layout_tests/port/server_process.py:
2373         (ServerProcess._reset):
2374         (ServerProcess.write):
2375         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2376         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2377         set_crashed.
2378
2379         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2380         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2381         we bail out of handling the failure as a timeout if we find out that the process in fact
2382         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2383         so.
2384         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2385         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2386         disk.
2387
2388         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2389         (TrivialMockPort.is_crash_reporter): Added.
2390
2391         * Scripts/webkitpy/layout_tests/port/webkit.py:
2392         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2393         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2394
2395 2011-12-06  Adam Barth  <abarth@webkit.org>
2396
2397         NRWT fails on unreleased versions of Mac OS X
2398         https://bugs.webkit.org/show_bug.cgi?id=72748
2399
2400         Reviewed by Dirk Pranke.
2401
2402         Hopefully this patch will make NRWT work on future versions on Mac OS X.
2403         Most of the infrastructure was already in place, but there were some
2404         asserts that failed.  I've tested this patch by haxoring the version
2405         detection logic to simulate an unknown version.  We might need to
2406         iterate based on feedback from folks with a real future version.
2407
2408         * Scripts/webkitpy/layout_tests/port/apple.py:
2409         (ApplePort.__init__):
2410             - mac-future is an allowed port_name that's used internally by
2411               webkitpy to represent future versions of Mac OS X.
2412         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2413         (test_versions):
2414             - Test that we don't throw exceptions when dealing with future
2415               versions of Mac OS X.
2416         * Scripts/webkitpy/layout_tests/port/webkit.py:
2417         (WebKitPort._expectations_from_skipped_files):
2418             - Demote this logging message to "debug".  It's expected that
2419               mac-future doesn't have a Skipped file.
2420         * Scripts/webkitpy/layout_tests/port/mac.py:
2421         (MacPort.__init__):
2422         * Scripts/webkitpy/layout_tests/port/win.py:
2423         (WinPort.__init__):
2424             - Re-order some code in these constructors so that
2425               self._operating_system is available to the ApplePort constructor.
2426
2427 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
2428
2429         Added myself as a committer.
2430
2431         * Scripts/webkitpy/common/config/committers.py:
2432
2433 2011-12-06  Peter Beverloo  <peter@chromium.org>
2434
2435         Added myself as a committer.
2436
2437         * Scripts/webkitpy/common/config/committers.py:
2438
2439 2011-12-06  Kentaro Hara  <haraken@chromium.org>
2440
2441         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2442         https://bugs.webkit.org/show_bug.cgi?id=73637
2443
2444         Reviewed by Adam Barth.
2445
2446         This patch replaces subprocess.Popen() with Executive, similar to other
2447         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2448         works well for cases where no exception is raised, no exception is raised
2449         but diff is found, and ScriptError is raised.
2450
2451         * Scripts/run-bindings-tests:
2452         (main):
2453         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2454         (BindingsTests.__init__):
2455         (BindingsTests.generate_from_idl):
2456         (BindingsTests.generate_supplemental_dependency):
2457         (BindingsTests.detect_changes):
2458
2459 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2460
2461         [Qt] MiniBrowser should default to touch behavior
2462         https://bugs.webkit.org/show_bug.cgi?id=73863
2463
2464         Reviewed by Chang Shu.
2465
2466         MiniBrowser currently defaults to the traditional desktop behaviour
2467         instead of touch behaviour which is prefered.
2468
2469         * MiniBrowser/qt/BrowserWindow.cpp:
2470         (BrowserWindow::BrowserWindow):
2471         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2472         (printHelp):
2473         (MiniBrowserApplication::handleUserOptions):
2474         * MiniBrowser/qt/MiniBrowserApplication.h:
2475         (WindowOptions::WindowOptions):
2476         (WindowOptions::setUseTraditionalDesktopBehavior):
2477         (WindowOptions::useTraditionalDesktopBehavior):
2478
2479 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2480
2481         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2482         https://bugs.webkit.org/show_bug.cgi?id=73878
2483
2484         Reviewed by Tony Chang.
2485
2486         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2487         r98785 made webkit.py always use m_data16, which does not work when
2488         the string is an 8-bit string (such as KURL::string()).
2489
2490         I was not able to directly call StringImpl::is8Bit() in the Python
2491         code, so I just reproduced the implementation there.
2492
2493         * gdb/webkit.py:
2494         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2495         (WTFStringPrinter.to_string):
2496         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2497         (JSCUStringPrinter.to_string):
2498
2499 2011-12-05  Eric Seidel  <eric@webkit.org>
2500
2501         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2502         in hopes of making the Snow Leopard bot stop timing out.
2503
2504         Unreviewed.
2505
2506         * Scripts/webkitpy/layout_tests/port/base.py:
2507         (Port.default_child_processes):
2508         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2509         (PortTest.test_default_child_processes):
2510
2511 2011-12-05  Eric Seidel  <eric@webkit.org>
2512
2513         NRWT creates too many workers on RAM-limited machines
2514         https://bugs.webkit.org/show_bug.cgi?id=73847
2515
2516         Reviewed by Dirk Pranke.
2517
2518         Make NRWT restrict its number of workers when there isn't enough
2519         RAM to support them.
2520         Also re-enable parallel testing on the Mac bots which were
2521         failing due to not enough ram.
2522
2523         * Scripts/run-webkit-tests:
2524         (platformIsReadyForParallelTesting):
2525         * Scripts/webkitpy/common/host.py:
2526         (Host.__init__):
2527         * Scripts/webkitpy/common/system/executive_mock.py:
2528         (MockExecutive.cpu_count):
2529         * Scripts/webkitpy/common/system/platforminfo.py:
2530         (PlatformInfo.__init__):
2531         (PlatformInfo.display_name):
2532         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2533         (MockPlatformInfo.display_name):
2534         * Scripts/webkitpy/layout_tests/port/base.py:
2535         (Port.default_child_processes):
2536         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2537         (PortTest.test_default_child_processes):
2538         (PortTest.test_pretty_patch_os_error):
2539
2540 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2541
2542         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2543         https://bugs.webkit.org/show_bug.cgi?id=73366
2544
2545         Reviewed by Kenneth Rohde Christiansen.
2546
2547         Empty the entire event queue when requested besides using
2548         sendEvent instead of postEvent to make sure all events were
2549         delivered.
2550
2551         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2552         (WTR::EventSenderProxy::EventSenderProxy):
2553         (WTR::EventSenderProxy::sendOrQueueEvent):
2554         (WTR::EventSenderProxy::replaySavedEvents):
2555
2556 2011-12-05  Adam Barth  <abarth@webkit.org>
2557
2558         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2559         https://bugs.webkit.org/show_bug.cgi?id=73845
2560
2561         Reviewed by Darin Fisher.
2562
2563         Update includes to point to the new header locations.
2564
2565         * DumpRenderTree/chromium/AccessibilityController.cpp:
2566         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2567         * DumpRenderTree/chromium/CppBoundClass.cpp:
2568         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2569         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2570         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2571         * DumpRenderTree/chromium/EventSender.cpp:
2572         * DumpRenderTree/chromium/EventSender.h:
2573         * DumpRenderTree/chromium/GamepadController.h:
2574         * DumpRenderTree/chromium/LayoutTestController.cpp:
2575         * DumpRenderTree/chromium/LayoutTestController.h:
2576         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2577         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2578         * DumpRenderTree/chromium/PlainTextController.cpp:
2579         * DumpRenderTree/chromium/Task.cpp:
2580         * DumpRenderTree/chromium/TestNavigationController.h:
2581         * DumpRenderTree/chromium/TestShell.cpp:
2582         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2583         * DumpRenderTree/chromium/TestWebPlugin.h:
2584         * DumpRenderTree/chromium/TextInputController.cpp:
2585         * DumpRenderTree/chromium/WebPermissions.cpp:
2586         * DumpRenderTree/chromium/WebPreferences.h:
2587         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2588         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2589         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2590         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2591         * DumpRenderTree/chromium/WebViewHost.cpp:
2592
2593 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2594
2595         Add Aharon Lanin to the contributors list.
2596
2597         * Scripts/webkitpy/common/config/committers.py:
2598
2599 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2600
2601         Moving myself from contributors to committers.
2602
2603         * Scripts/webkitpy/common/config/committers.py:
2604
2605 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2606
2607         Add myself as a committer.
2608
2609         * Scripts/webkitpy/common/config/committers.py:
2610
2611 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2612
2613         [Qt] Rename QQuickWebView::canStop property to just loading 
2614         https://bugs.webkit.org/show_bug.cgi?id=73813
2615
2616         Reviewed by Kenneth Rohde Christiansen.
2617
2618         Replaced references to WebView.canStop with WebView.loading.
2619
2620         * MiniBrowser/qt/qml/BrowserWindow.qml:
2621
2622 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2623
2624         run-webkit-tests: limit --child-processes properly on apple mac
2625         https://bugs.webkit.org/show_bug.cgi?id=73856
2626
2627         Reviewed by Adam Roben.
2628
2629         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2630         the apple mac bots temporarily.
2631
2632         * Scripts/run-webkit-tests:
2633         (platformIsReadyForParallelTesting):
2634
2635 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2636
2637         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2638         https://bugs.webkit.org/show_bug.cgi?id=73840
2639
2640         Reviewed by Simon Fraser.
2641
2642         Temporarily go back to single process mode on Mac.
2643
2644         * Scripts/run-webkit-tests:
2645         (platformIsReadyForParallelTesting):
2646
2647 2011-12-05  Adam Roben  <aroben@apple.com>
2648
2649         Redeploy apple-macpro-7 and apple-xserve-1
2650
2651         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2652
2653         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2654         sitting idle
2655
2656         Reviewed by Sam Weinig.
2657
2658         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2659         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2660         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2661         (WebKit2 Tests)".
2662
2663 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2664
2665         [Qt] Make the UI of the MiniBrowser slightly nicer
2666
2667         Rubberstamped by Simon Hausmann.
2668
2669         - Add proper padding
2670         - Show feedback when pressing on the toolbar icons
2671         - Make the text entry better looking
2672
2673         * MiniBrowser/qt/qml/BrowserWindow.qml:
2674
2675 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2676
2677         NRWT should handle duplicated expectations
2678         https://bugs.webkit.org/show_bug.cgi?id=69750
2679
2680         Reviewed by Dirk Pranke.
2681
2682         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2683         (TestExpectations.__init__):
2684         (TestExpectations._report_errors):
2685         (TestExpectations._add_expectations):
2686         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2687         (test_add_skipped_tests):
2688         * Scripts/webkitpy/layout_tests/port/base.py:
2689         (Port.skipped_tests):
2690         * Scripts/webkitpy/layout_tests/port/webkit.py:
2691         (WebKitPort.test_expectations):
2692         (WebKitPort.skipped_tests):
2693         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2694         (test_test_expectations):
2695
2696 2011-12-04  Eric Seidel  <eric@webkit.org>
2697
2698         After success with Mac, Win and Gtk, turning on parallel testing
2699         by default for all platforms (except Qt).
2700
2701         We'll add more platforms to the blacklist if we see problems.
2702
2703         Unreviewed.
2704
2705         * Scripts/run-webkit-tests:
2706         (platformIsReadyForParallelTesting):
2707
2708 2011-12-04  Sam Weinig  <sam@webkit.org>
2709
2710         Add tests for RetainPtr::adoptNS/adoptCF
2711         https://bugs.webkit.org/show_bug.cgi?id=73470
2712
2713         Reviewed by Adam Roben and Darin Adler.
2714
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2716         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2717         (TestWebKitAPI::TEST):
2718         Test that adopting using adoptCF creates a RetainPtr with a
2719         value whose retain count is 1.
2720
2721         * TestWebKitAPI/Tests/WTF/ns: Added.
2722         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2723         (TestWebKitAPI::TEST):
2724         Test that adopting using adoptNS creates a RetainPtr with a
2725         value whose retain count is 1.
2726
2727 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2728
2729         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2730         https://bugs.webkit.org/show_bug.cgi?id=73748
2731
2732         Reviewed by Gustavo Noronha Silva.
2733
2734         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2735
2736 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2737
2738         Another GTK build fix after r101922.
2739
2740         Rubber-stamped by Martin Robinson.
2741
2742         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2743         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2744
2745 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2746
2747         Fix compiler warning in LayoutTestController
2748
2749         Reviewed by Philippe Normand.
2750
2751         * DumpRenderTree/LayoutTestController.cpp:
2752         (LayoutTestController::LayoutTestController): fix warning.
2753
2754 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2755
2756         Add missing methods used by fast/notifications tests to LayoutTestController
2757         https://bugs.webkit.org/show_bug.cgi?id=63616
2758
2759         Reviewed by Martin Robinson.
2760
2761         Add missing simulateDesktopNotificationClick method used by
2762         fast/notifications. Provide a default implementation for
2763         areDesktopNotificationPermissionRequestsIgnored and
2764         ignoreDesktopNotificationPermissionRequests.
2765
2766         * DumpRenderTree/LayoutTestController.cpp:
2767         (LayoutTestController::LayoutTestController): call into the port implementation.
2768         (simulateDesktopNotificationClickCallback): ditto.
2769         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2770         (LayoutTestController::staticFunctions): declare new methods.
2771         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2772         * DumpRenderTree/LayoutTestController.h:
2773         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2774         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2775         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2776         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2777         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2778         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2779         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2780         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2781         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2782         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2783         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2784
2785 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2786
2787         [GTK] Don't log document events in DRT
2788         https://bugs.webkit.org/show_bug.cgi?id=73746
2789
2790         Reviewed by Martin Robinson.
2791
2792         Stop connecting globally to document-related events.
2793
2794         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2795         (connectAccessibilityCallbacks): Removed connections.
2796         (disconnectAccessibilityCallbacks): Removed disconnections.
2797
2798 2011-12-03  Dan Bernstein  <mitz@apple.com>
2799
2800         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2801
2802         Reviewed by Darin Adler.
2803
2804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2805         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2806         (TestWebKitAPI::TEST):
2807
2808 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2809
2810         Another GTK build fix after r101922.
2811
2812         Rubber-stamped by Martin James Robinson.
2813
2814         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2815         (LayoutTestController::pathToLocalResource): return value needs to
2816         be a URI.
2817
2818 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2819
2820         Small fix for my previous patch. Do not try to delete a member
2821         of a dictionary that does not exist.
2822
2823         Reviewed by Gustavo Noronha Silva.
2824
2825         * gtk/run-with-jhbuild:
2826         (install_and_run_jhbuild):
2827
2828 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2829
2830         Fix jhbuild installation for people who have unusual MAKE environment
2831         variables such as 'make -j4' as the jhbuild build does not handle it.
2832
2833         Reviewed by Gustavo Noronha Silva.
2834
2835         * gtk/run-with-jhbuild:
2836         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2837
2838 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2839
2840         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2841         when run for the first time.
2842
2843         Reviewed by Gustavo Noronha Silva.
2844
2845         * Scripts/update-webkitgtk-libs: Fix first run.
2846
2847 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2848
2849         Unreviewed, GTK build fix after r101922.
2850
2851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2852         (LayoutTestController::pathToLocalResource): Added sentinel in
2853         g_build_filename call.
2854
2855 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2856
2857         GTK API tests build fix. Run the tests inside jhbuild.
2858
2859         Rubber-stamped by Gustavo Noronha Silva.
2860
2861         * Scripts/run-gtk-tests:
2862         (TestRunner.__init__):
2863         (TestRunner.run._error_handler):
2864         (TestRunner):
2865         (TestRunner.run):
2866
2867 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2868
2869         Small build fix. Properly specify the path to the locally installed jhbuild.
2870
2871         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2872
2873 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2874
2875         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2876         https://bugs.webkit.org/show_bug.cgi?id=67256
2877
2878         Reviewed by Philippe Normand.
2879
2880         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
2881         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2882         which points to the more generic top-level path of the WebKit checkout. This code is
2883         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2884         share code here.
2885
2886         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2887         location. This will cause the fallback to fail if you build into a non-typical location
2888         or even fake it with a symlink. In this case it's important to use the environment variable.
2889
2890         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2891         (getTopLevelPath): Added.
2892         (initializeFonts): Use the new helper to get the font path.
2893         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2894         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2895         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2896         test paths.
2897         * Scripts/webkitpy/layout_tests/port/gtk.py:
2898         (GtkPort.setup_environ_for_server):Pass the top-level path of the
2899         checkout instead of passing the font path.
2900         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2901         (WTR::getTopLevelPath): Added this helper.
2902         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2903
2904 2011-12-02  David Levin  <levin@chromium.org>
2905
2906         Rename WTF class from TemporarilyChange to TemporaryChange.
2907         https://bugs.webkit.org/show_bug.cgi?id=73479
2908
2909         Reviewed by Eric Seidel.
2910
2911         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2912         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2913         * TestWebKitAPI/TestWebKitAPI.gypi:
2914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2915         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2916         (TestWebKitAPI::TEST):
2917         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2918
2919 2011-12-02  Tony Chang  <tony@chromium.org>
2920
2921         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2922         https://bugs.webkit.org/show_bug.cgi?id=73453
2923
2924         Reviewed by Ryosuke Niwa.
2925
2926         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2927         The verbose output will include the failure reason.
2928
2929         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2930         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2931         (write_test_result):
2932         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2933         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2934         (determine_result_type):
2935         (FailureReftestNoImagesGenerated.__init__):
2936         (FailureReftestNoImagesGenerated):
2937         (FailureReftestNoImagesGenerated.message):
2938         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2939         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2940         (MainTest.test_run_singly_actually_runs_tests):
2941         (MainTest.test_unexpected_failures):
2942         (EndToEndTest.test_end_to_end):
2943
2944 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2945
2946         ChangeLog should be able to parse annotated changelogs
2947         https://bugs.webkit.org/show_bug.cgi?id=72703
2948
2949         Reviewed by Eric Seidel.
2950
2951         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
2952         and extract the revision number for each entry.
2953
2954         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
2955
2956         * Scripts/webkitpy/common/checkout/changelog.py:
2957         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2958         * Scripts/webkitpy/common/checkout/scm/git.py:
2959         * Scripts/webkitpy/common/checkout/scm/scm.py:
2960         * Scripts/webkitpy/common/checkout/scm/svn.py:
2961
2962 2011-12-02  Eric Seidel  <eric@webkit.org>
2963
2964         Enable parallel testing for Win and Gtk bots
2965         after confirming with Lucas and Martin the bots should be OK.
2966
2967         Unreviewed. (I ran the idea by Lucas and Martin.)
2968
2969         * Scripts/run-webkit-tests:
2970         (platformIsReadyForParallelTesting):
2971
2972 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2973
2974         Try to fix the GTK+ build.
2975
2976         * gtk/jhbuild.modules: Properly specify the glib-networking
2977         dependency for soup.
2978
2979 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2980
2981         Fix a syntax error in the committers.py file.
2982
2983         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
2984
2985 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2986
2987         Add Alan Stearns and Peter Linss to the contributors list.
2988
2989         * Scripts/webkitpy/common/config/committers.py:
2990
2991 2011-12-02  Kent Tamura  <tkent@chromium.org>
2992
2993         [Chromium] Fix compilation warnings for ASSERT()
2994         https://bugs.webkit.org/show_bug.cgi?id=73623
2995
2996         Reviewed by Tony Chang.
2997
2998         * DumpRenderTree/chromium/ImageDiff.cpp:
2999          - Fix fprintf format: %s -> %d for __LINE__
3000          - Do nothing for ASSERT() if NDEBUG.
3001
3002 2011-12-02  Eric Seidel  <eric@webkit.org>
3003
3004         Enable parallel testing for all Mac bots.
3005
3006         Unreviewed.
3007
3008         * Scripts/run-webkit-tests:
3009         (platformIsReadyForParallelTesting):
3010
3011 2011-12-02  Eric Seidel  <eric@webkit.org>
3012
3013         Enable parallel testing for run-webkit-tests on Mac Lion.
3014         I plan to move all the machines to parallel testing shortly
3015         but we're starting with Lion.
3016
3017         Unreviewed.
3018
3019         * Scripts/run-webkit-tests:
3020         (platformIsReadyForParallelTesting):
3021
3022 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3023
3024         Added helper method to identify whether the page has custom page size style.
3025         https://bugs.webkit.org/show_bug.cgi?id=73585
3026
3027         Reviewed by Darin Fisher.
3028
3029         * DumpRenderTree/chromium/LayoutTestController.cpp:
3030         (LayoutTestController::LayoutTestController):
3031         (LayoutTestController::hasCustomPageSizeStyle):
3032         * DumpRenderTree/chromium/LayoutTestController.h:
3033
3034 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3035
3036         [NRWT] reftest should support having multiple references per test
3037         https://bugs.webkit.org/show_bug.cgi?id=73613
3038
3039         Reviewed by Dirk Pranke.
3040
3041         Add a support for having multiple reference files for a single test.
3042
3043         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3044         at least one of expected mismatches, we compare expected mismatches first in order to minimize
3045         the number of reference files to open on DRT.
3046
3047         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3048         (interpret_test_failures): Remove checks no longer applicable.
3049         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3050         (ResultSummaryTest.test_interpret_test_failures): Ditto.
3051         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3052         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3053         (SingleTestRunner._driver_input):
3054         (SingleTestRunner.run):
3055         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3056         * Scripts/webkitpy/layout_tests/models/test_input.py:
3057         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3058         * Scripts/webkitpy/layout_tests/port/base.py:
3059         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3060         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3061         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3062         (PortTest.test_parse_reftest_list):
3063         * Scripts/webkitpy/layout_tests/port/test.py:
3064         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3065         (MainTest.test_unexpected_failures):
3066         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3067         (EndToEndTest.test_end_to_end):
3068         (EndToEndTest.test_reftest_with_two_notrefs): Added.
3069
3070 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3071
3072         Build libsoup without gnome dependencies (like keyring).
3073
3074         * gtk/jhbuild.modules:
3075
3076 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3077
3078         Also build gcrypt and p11-kit, and make them dependencies of
3079         gnutls.
3080
3081         * gtk/jhbuild.modules:
3082
3083 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
3084
3085         [wx] Unreviewed build fixes for Windows build.
3086
3087         * waf/build/wxpresets.py:
3088
3089 2011-12-01  Eric Seidel  <eric@webkit.org>
3090
3091         Reviewed by Adam Barth.
3092
3093         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3094         https://bugs.webkit.org/show_bug.cgi?id=32006
3095
3096         I decided not to make it warn, and just have it re-open the bug.
3097         That's not that different from today's behavior which will
3098         just silently attach the patch.
3099
3100         This patch makes behavior between upload and land-safely consistent
3101         (previously one would assign patches and the other would not)
3102         as well as adds the ability for both to ensure that the bug is open.
3103
3104         To test this I had to add a few more methods to MockBugzilla which
3105         (positively) affected a few other test results.
3106
3107         I also made AbstractStep keep a cached copy of the Bug object
3108         and used the cached copy where appropriate (including for 'bug_title').
3109         This should reduce the number of bug fetches we perform.
3110
3111         * Scripts/webkitpy/tool/commands/download_unittest.py:
3112         * Scripts/webkitpy/tool/commands/upload.py:
3113         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3114         * Scripts/webkitpy/tool/mocktool.py:
3115         * Scripts/webkitpy/tool/steps/__init__.py:
3116         * Scripts/webkitpy/tool/steps/abstractstep.py:
3117         * Scripts/webkitpy/tool/steps/closebug.py:
3118         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3119         * Scripts/webkitpy/tool/steps/postdiff.py:
3120         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3121         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3122         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3123         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3124
3125 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3126
3127         Also pass --no-interact to jhbuild when updating dependencies.
3128
3129         * Scripts/update-webkitgtk-libs:
3130
3131 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
3132
3133         Make _build_path check more thoroughly that build paths exist.
3134         https://bugs.webkit.org/show_bug.cgi?id=73601
3135
3136         Reviewed by Ojan Vafai.
3137
3138         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3139         (ChromiumMacPort._build_path):
3140
3141 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3142
3143         Add libffi to the jhbuild modules list as a glib dependency.
3144
3145         Rubber-stamped by Martin Robinson.
3146
3147         * gtk/jhbuild.modules:
3148
3149 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3150
3151         Build fix. Use internal pcre on glib, make gnutls a dependency of
3152         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3153         in non-interactive mode.
3154
3155         * Scripts/update-webkitgtk-libs:
3156         * gtk/jhbuild.modules:
3157         * gtk/run-with-jhbuild:
3158
3159 2011-12-02  Adam Roben  <aroben@apple.com>
3160
3161         Fix for Python 2.6
3162
3163         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3164         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3165         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3166         searching for "Tests that timed out:" etc. This makes our check less strict, but it
3167         shouldn't matter given the kinds of content we parse.
3168
3169 2011-12-02  Adam Roben  <aroben@apple.com>
3170
3171         Fix names of failed/timed out tests in run-api-tests output
3172
3173         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3174         out tests
3175
3176         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3177
3178         Reviewed by Simon Fraser.
3179
3180         * Scripts/run-api-tests:
3181         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3182         of this function.
3183
3184 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3185
3186         [GTK] generate-gtkdoc should respect build type
3187         https://bugs.webkit.org/show_bug.cgi?id=73296
3188
3189         Reviewed by Philippe Normand.
3190
3191         * Scripts/webkitdirs.pm:
3192         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3193         * gtk/common.py: If --build is passed give preference to the Debug build directory.
3194
3195 2011-12-02  Tony Chang  <tony@chromium.org>
3196
3197         [nrwt] fix wdiff output
3198         https://bugs.webkit.org/show_bug.cgi?id=73604
3199
3200         Reviewed by Adam Barth.
3201
3202         * Scripts/webkitpy/layout_tests/port/base.py:
3203         (Port.wdiff_text):
3204         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3205         (PortTest.test_wdiff_text):
3206
3207 2011-12-02  Adam Roben  <aroben@apple.com>
3208
3209         Teach build.webkit.org to display how many unit tests failed or timed out
3210
3211         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3212         build.webkit.org
3213
3214         We now display something like "5 unit tests failed or timed out". Eventually we might want
3215         to split out how many failure vs. timeouts there were.
3216
3217         Reviewed by Darin Adler.
3218
3219         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3220         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3221         classes that may want to subclass it.
3222         (RunUnitTests): Changed to inherit from TestWithFailureCount.
3223         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3224         timed out:" and "Tests that failed:" lines, if present.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3227         (StubStdio):
3228         (StubRemoteCommand):
3229         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3230
3231         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3232         the test run correctly.
3233
3234         (RunUnitTestsTest.test_no_failures_or_timeouts):
3235         (RunUnitTestsTest.test_one_failure):
3236         (RunUnitTestsTest.test_multiple_failures):
3237         (RunUnitTestsTest.test_one_timeout):
3238         (RunUnitTestsTest.test_multiple_timeouts):
3239         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3240         Test various cases.
3241
3242 2011-12-02  Adam Roben  <aroben@apple.com>
3243
3244         Teach prepare-ChangeLog to treat master.cfg as a Python file
3245
3246         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3247         in buildbot's master.cfg
3248
3249         Reviewed by Darin Adler.
3250
3251         * Scripts/prepare-ChangeLog:
3252         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3253         master.cfg.
3254
3255 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3256
3257         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3258         https://bugs.webkit.org/show_bug.cgi?id=73669
3259
3260         Reviewed by Gustavo Noronha Silva.
3261
3262         Add a wrapper script that knows how to install jhbuild and also to wrap commands
3263         in the jhbuild shell.
3264
3265         * Scripts/webkitdirs.pm:
3266         (runAutogenForAutotoolsProject): Use the new wrapper script.
3267         (mustReRunAutogen): Ditto.
3268         (buildAutotoolsProject): Ditto.
3269         * Scripts/webkitpy/layout_tests/port/gtk.py:
3270         (GtkDriver.cmd_line): Ditto.
3271         * gtk/run-with-jhbuild: Added.
3272
3273 2011-12-01  Adam Roben  <aroben@apple.com>
3274
3275         Teach check-webkit-style how to check the syntax of JSON files
3276
3277         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3278
3279         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3280         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3281         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3282         been removed, since its output differs by platform.
3283
3284         Reviewed by Darin Adler.
3285
3286         * Scripts/webkitpy/style/checker.py:
3287         (_all_categories): Added JSONChecker's categories to the set of all categories.
3288         (FileType): Added a JSON type. Incremented other types.
3289         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3290         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3291
3292         * Scripts/webkitpy/style/checker_unittest.py:
3293         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3294         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3295
3296         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3297         which would have matched our other checkers, because I couldn't figure out how to call
3298         "json.loads" without hitting namespace conflicts.)
3299         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3300         just the modified lines from a patch.
3301         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3302         exception.
3303         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3304         try to extract a line number.
3305
3306         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3307         (MockErrorHandler.__init__):
3308         (MockErrorHandler.turn_off_line_filtering):
3309         (MockErrorHandler.__call__):
3310         Helper class. Copied from xml_unittest.py.
3311
3312         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3313         line_number_from_json_exception helper method.
3314
3315         (JSONCheckerTest.assert_no_error):
3316         (JSONCheckerTest.assert_error):
3317         Helper methods to assert that we did or didn't get an error.
3318
3319         (JSONCheckerTest.mock_handle_style_error): Helper method.
3320
3321         (JSONCheckerTest.test_conflict_marker):
3322         (JSONCheckerTest.test_single_quote):
3323         (JSONCheckerTest.test_init):
3324         (JSONCheckerTest.test_no_error):
3325         Test various cases.
3326
3327 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3328
3329         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3330         https://bugs.webkit.org/show_bug.cgi?id=73664
3331
3332         Reviewed by Martin Robinson.
3333
3334         This patch adds our HTTP library and its main dependencies; this
3335         should not affect layout or rendering.
3336
3337         * gtk/jhbuild.modules:
3338
3339 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3340
3341         [GTK] Also run DumpRenderTree under jhbuild
3342         https://bugs.webkit.org/show_bug.cgi?id=73646
3343
3344         Reviewed by Martin Robinson.
3345
3346         * Scripts/webkitpy/layout_tests/port/gtk.py:
3347         (GtkDriver.cmd_line):
3348
3349 2011-12-02  Hajime Morrita  <morrita@chromium.org>
3350
3351         Unreviewed, rolling out r101751 and r101775.
3352         http://trac.webkit.org/changeset/101751
3353         http://trac.webkit.org/changeset/101775
3354         https://bugs.webkit.org/show_bug.cgi?id=73191
3355
3356         breaks Windows build
3357
3358         * DumpRenderTree/chromium/config.h:
3359         * DumpRenderTree/config.h:
3360         * TestWebKitAPI/config.h:
3361         * WebKitTestRunner/config.h:
3362
3363 2011-12-02  Kentaro Hara  <haraken@chromium.org>
3364
3365         Move run-bindings-tests implementation to webkitpy/bindings/main.py
3366         https://bugs.webkit.org/show_bug.cgi?id=73619
3367
3368         Reviewed by Adam Barth.
3369
3370         As run-bindings-tests has been growing, this patch just moves its implementation
3371         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3372
3373         No change in behavior.
3374
3375         * Scripts/run-bindings-tests:
3376         (main):
3377         * Scripts/webkitpy/bindings/__init__.py: Added.
3378         * Scripts/webkitpy/bindings/main.py: Added.
3379         (BindingsTests.__init__):
3380         (BindingsTests.generate_from_idl):
3381         (BindingsTests.generate_supplemental_dependency):
3382         (BindingsTests.detect_changes):
3383         (BindingsTests.run_tests):
3384
3385 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
3386
3387         Tools/Scripts: eliminate find_test_files from Port class.
3388         https://bugs.webkit.org/show_bug.cgi?id=73553
3389
3390         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3391         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3392         Also I'll move _is_test_file() and related functions close to Port.tests().
3393
3394         Reviewed by Dirk Pranke.
3395
3396         * Scripts/webkitpy/layout_tests/port/base.py:
3397         (Port.tests):
3398         (Port.is_reference_html_file):
3399         (Port._has_supported_extension):
3400         (Port._is_test_file):
3401         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3402         (PortTest.test_find_no_paths_specified):
3403         (PortTest.test_find_one_test):
3404         (PortTest.test_find_glob):
3405         (PortTest.test_find_with_skipped_directories):
3406         (PortTest.test_find_with_skipped_directories_2):
3407         (PortTest.test_is_test_file):
3408         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3409         (_default_tests_paths):
3410         (ChromiumGpuLinuxPort.tests):
3411         (ChromiumGpuCgMacPort.tests):
3412         (ChromiumGpuMacPort.tests):
3413         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3414         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3415         (ChromiumGpuTest.test_default_tests_paths):
3416         (ChromiumGpuTest.test_test_files.test_paths):
3417         (ChromiumGpuTest):
3418         (ChromiumGpuTest.test_test_files):
3419         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3420         (get_tests_run.RecordingTestDriver.run_test):
3421         * Scripts/webkitpy/tool/commands/rebaseline.py:
3422         (OptimizeBaselines._optimize_baseline):
3423         (OptimizeBaselines.execute):
3424         (AnalyzeBaselines._analyze_baseline):
3425         (AnalyzeBaselines.execute):
3426
3427 2011-12-01  Hajime Morrita  <morrita@chromium.org>
3428
3429         JS_INLINE and WTF_INLINE should be visible from WebCore
3430         https://bugs.webkit.org/show_bug.cgi?id=73191
3431
3432         Reviewed by Kevin Ollivier.
3433
3434         Removed macro definitions which is now provided by Platform.h
3435
3436         * DumpRenderTree/chromium/config.h:
3437         * DumpRenderTree/config.h:
3438         * TestWebKitAPI/config.h:
3439         * WebKitTestRunner/config.h:
3440
3441 2011-12-01  Hayato Ito  <hayato@chromium.org>
3442
3443         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3444         https://bugs.webkit.org/show_bug.cgi?id=73406
3445
3446         Reviewed by Ryosuke Niwa.
3447
3448         WebKitPort's image_diff uses tolerance='0.1' in default.
3449         When reftests fail, we should use tolerace=0 when diff-ing images.
3450
3451         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3452         this change doesn't affect chromium port's behavior.
3453
3454         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3455         (write_test_result):
3456         * Scripts/webkitpy/layout_tests/port/base.py:
3457         (Port.diff_image):
3458         * Scripts/webkitpy/layout_tests/port/chromium.py:
3459         (ChromiumPort.diff_image):
3460         * Scripts/webkitpy/layout_tests/port/test.py:
3461         (TestPort.diff_image):
3462         * Scripts/webkitpy/layout_tests/port/webkit.py:
3463         (WebKitPort.diff_image):
3464         (WebKitPort._start_image_diff_process):
3465         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3466         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3467
3468 2011-12-01  Adam Klein  <adamk@chromium.org>
3469
3470         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3471         https://bugs.webkit.org/show_bug.cgi?id=73599
3472
3473         Reviewed by Ojan Vafai.
3474
3475         * TestResultServer/static-dashboards/builders.js:
3476         * TestResultServer/static-dashboards/dashboard_base.js:
3477         ():
3478         (htmlForTestTypeSwitcher):
3479         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3480         (testHtmlForTestTypeSwitcherGroup):
3481
3482 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3483
3484         Parse reftest.list and extract types of ref tests
3485         https://bugs.webkit.org/show_bug.cgi?id=66837
3486
3487         Reviewed by Dirk Pranke.
3488
3489         Add support for reftest.list to base port.
3490
3491         * Scripts/webkitpy/common/find_files.py:
3492         (find):
3493         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3494         (SingleTestRunner.__init__):
3495         * Scripts/webkitpy/layout_tests/port/base.py:
3496         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3497         to a dictionary of {test path: ("==" or "!=", reference file path)}
3498         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3499         (Port._reference_file_for): Added; obtains the reference file name given a test name.
3500         (Port.is_reftest): Added; Calls _reference_file_for.
3501         (Port.reftest_expected_filename): Calls _reference_file_for.
3502         (Port.reftest_expected_mismatch_filename): Ditto.
3503         (Port.find_test_files):
3504         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3505         -expected, -expected-mismach, -ref, or -notref as a reference file.
3506         (_is_test_file):
3507         (_parse_reftest_list): Added.
3508         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3509         (PortTest.test_is_test_file):
3510         (PortTest.test_parse_reftest_list):
3511         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3512         (DryrunDriver.run_test):
3513         * Scripts/webkitpy/layout_tests/port/test.py:
3514         (unit_test_filesystem.add_test_file):
3515         (unit_test_filesystem.add_file):
3516         (unit_test_filesystem):
3517         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3518         (get_tests_run.RecordingTestDriver.run_test):
3519         (MainTest.test_unexpected_failures):
3520         (MainTest.test_missing_and_unexpected_results):
3521         (EndToEndTest.test_end_to_end):
3522         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3523         (Rebaseliner._compile_rebaselining_tests):
3524
3525 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3526
3527         Unreviewed, rolling out r101711.
3528         http://trac.webkit.org/changeset/101711
3529         https://bugs.webkit.org/show_bug.cgi?id=73605
3530
3531         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3532
3533         * Scripts/webkitpy/style/checker.py:
3534         (_all_categories):
3535         (FileType):
3536         (CheckerDispatcher._file_type):
3537         (CheckerDispatcher._create_checker):
3538         * Scripts/webkitpy/style/checker_unittest.py:
3539         (CheckerDispatcherDispatchTest.assert_checker_cpp):
3540         (CheckerDispatcherDispatchTest.test_cpp_paths):
3541         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3542         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3543
3544 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3545
3546         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3547
3548         * Scripts/webkitpy/common/config/watchlist:
3549
3550 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3551
3552         [GTK] Read fonts from the jhbuild root
3553         https://bugs.webkit.org/show_bug.cgi?id=73487
3554
3555         Reviewed by Gustavo Noronha Silva.
3556
3557         Read fonts from the jhbuild root instead of from the system. This will ensure
3558         that all testers use the same fonts instead of leaving this up to luck.
3559
3560         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3561         (initializeFonts): Load fonts from jhbuild root.
3562         * Scripts/webkitpy/layout_tests/port/gtk.py:
3563         (GtkPort.setup_environ_for_server): Pass an environment variable containing
3564         the path to the jhbuild root.
3565         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3566         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3567
3568 2011-12-01  Adam Roben  <aroben@apple.com>
3569
3570         Teach check-webkit-style how to check the syntax of JSON files
3571
3572         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3573
3574         Reviewed by Darin Adler.
3575
3576         * Scripts/webkitpy/style/checker.py:
3577         (_all_categories): Added JSONChecker's categories to the set of all categories.
3578         (FileType): Added a JSON type. Incremented other types.
3579         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3580         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3581
3582         * Scripts/webkitpy/style/checker_unittest.py:
3583         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3584         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3585
3586         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3587         which would have matched our other checkers, because I couldn't figure out how to call
3588         "json.loads" without hitting namespace conflicts.)
3589         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3590         just the modified lines from a patch.
3591         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3592         exception.
3593         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3594         try to extract a line number.
3595
3596         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3597         (MockErrorHandler.__init__):
3598         (MockErrorHandler.turn_off_line_filtering):
3599         (MockErrorHandler.__call__):
3600         Helper class. Copied from xml_unittest.py.
3601
3602         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3603         line_number_from_json_exception helper method.
3604
3605         (JSONCheckerTest.assert_no_error):
3606         (JSONCheckerTest.assert_error):
3607         Helper methods to assert that we did or didn't get an error.
3608
3609         (JSONCheckerTest.mock_handle_style_error): Helper method.
3610
3611         (JSONCheckerTest.test_conflict_marker):
3612         (JSONCheckerTest.test_single_quote):
3613         (JSONCheckerTest.test_init):
3614         (JSONCheckerTest.test_missing_closing_brace):
3615         (JSONCheckerTest.test_no_error):
3616         Test various cases.
3617
3618 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3619
3620         [GTK] Add a helper function to find the current executable's path
3621         https://bugs.webkit.org/show_bug.cgi?id=73473
3622
3623         Reviewed by Gustavo Noronha Silva.
3624
3625         Update MiniBrowser to not pass the binary directory as an environment variable.
3626         This means that you can move the binaries around without it breaking.
3627
3628         * MiniBrowser/gtk/main.c:
3629         (main): No longer set the environment variable.
3630         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
3631         * WebKitTestRunner/gtk/main.cpp:  Ditto.
3632
3633 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3634
3635         Unreviewed. Fix bad file =(.
3636
3637         * gtk/jhbuild.modules:
3638         * Scripts/webkitdirs.pm:
3639         (runAutogenForAutotoolsProject):
3640
3641 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3642
3643         [GTK] Add freetype to our jhbuild setup
3644         https://bugs.webkit.org/show_bug.cgi?id=73488
3645
3646         Reviewed by Martin Robinson.
3647
3648         This adds the first library to our jhbuild setup, and makes sure
3649         build-webkit calls autogen.sh and make with jhbuild, so that the
3650         environment is properly set.
3651
3652         * Scripts/webkitdirs.pm:
3653         (saveSum):