3f07f0720bd1ad12200020a093479c0d3d7bbf88
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-26  Xianzhu Wang  <wangxianzhu@chromium.org>
2
3         Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
4
5         Not reviewed.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
10
11         [GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
12         https://bugs.webkit.org/show_bug.cgi?id=84957
13
14         Reviewed by Martin Robinson.
15
16         * Scripts/run-gtk-tests:
17         (TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
18         TestNewFirstVisuallyNonEmptyLayoutForImages.
19         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
20         (TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
21         toplevel window containing the web view to make sure events are
22         received.
23
24 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
25
26         Unreviewed. Add bug numbers to skipped tests.
27
28         * Scripts/run-gtk-tests:
29         (TestRunner):
30
31 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
32
33         [GTK] Build and run TestWebKitAPI WebKit2 unit tests
34         https://bugs.webkit.org/show_bug.cgi?id=84446
35
36         Reviewed by Philippe Normand.
37
38         * Scripts/run-gtk-tests:
39         (TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
40         containing tests. Unskip FunctionalTest.RefCountedStorage, since
41         we are now using a custom main that initializes WTF threading.
42         (TestRunner._setup_testing_environment): Set environment variables
43         required to run WebKit2 tests.
44         * TestWebKitAPI/GNUmakefile.am:
45         * TestWebKitAPI/JavaScriptTest.cpp: Use
46         JavaScriptCore/JSContextRef.h instead of
47         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
48         unconditionally.
49         * TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
50         PlatformWindow for GTK.
51         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
52         unneded header that breaks the build of GTK port.
53         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
54         JavaScriptCore/JSContextRef.h instead of
55         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
56         unconditionally.
57         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
58         (TestWebKitAPI::TEST): Add expected values for GTK+ port.
59         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
60         (TestWebKitAPI):
61         (TestWebKitAPI::InjectedBundleController::platformInitialize):
62         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
63         (TestWebKitAPI::Util::checkTestFinished):
64         (TestWebKitAPI::Util::run):
65         (TestWebKitAPI::Util::sleep):
66         (TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
67         (TestWebKitAPI::Util::createInjectedBundlePath):
68         (TestWebKitAPI::Util::createURLForResource):
69         (TestWebKitAPI::Util::URLForNonExistentResource):
70         (TestWebKitAPI::Util::isKeyDown):
71         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
72         (TestWebKitAPI::PlatformWebView::PlatformWebView):
73         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
74         (TestWebKitAPI::PlatformWebView::page):
75         (TestWebKitAPI::PlatformWebView::resizeTo):
76         (TestWebKitAPI::doKeyStroke):
77         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
78         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
79         (TestWebKitAPI::doMouseButtonEvent):
80         (TestWebKitAPI::PlatformWebView::simulateRightClick):
81         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
82         * TestWebKitAPI/gtk/main.cpp:
83         (main):
84
85 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
86
87         [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
88         https://bugs.webkit.org/show_bug.cgi?id=84695
89
90         Reviewed by Philippe Normand.
91
92         It also adds a command line option to be able to pass a custom
93         timeout value, instead of hard-coding it. The default timeout is 10
94         seconds if no other value is passed to the script.
95
96         * Scripts/run-gtk-tests:
97         (TestTimeout): Exception raised when a test times out.
98         (TestRunner._get_child_pid_from_test_output): Helper function to
99         get the pid of the running test from gtester output.
100         (TestRunner._kill_process): Helper funtion ot kill a process
101         ignoring exceptions if the process is already died.
102         (TestRunner._run_test_command): Run the test command raising
103         TestTimeout exception if the test doesn't finish before the given
104         timeout in seconds.
105         (TestRunner._run_test_command.alarm_handler): Alarm handler that
106         raises TestTimeout exception.
107         (TestRunner._run_test_glib): Use _run_test_command() to run the test.
108         (TestRunner._run_test_google): Ditto.
109         (TestRunner.run_tests): Add current test to the list of timed out
110         test if TestTimeout exception is raised. Show the list of timed
111         out test at the end.
112
113 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
114
115         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
116         https://bugs.webkit.org/show_bug.cgi?id=83880
117
118         Reviewed by Antonio Gomes.
119
120         Add missing implementation addOriginAccessWhitelistEntry and
121         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
122         in order to unskip tests which rely on this.
123
124         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
125         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
126         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
127         (LayoutTestController::addOriginAccessWhitelistEntry):
128         (LayoutTestController::removeOriginAccessWhitelistEntry):
129
130 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
131
132         [GTK] Add downloads support to MiniBrowser
133         https://bugs.webkit.org/show_bug.cgi?id=73662
134
135         Reviewed by Philippe Normand.
136
137         * MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
138         (browserDownloadsBarChildRemoved): Close the downloads bar if
139         there aren't active downloads.
140         (browserDownloadsBarResponse): Destroy the downloads bar when
141         closed.
142         (browser_downloads_bar_init):
143         (browser_downloads_bar_class_init):
144         (browser_downloads_bar_new): Create a new downloads bar.
145         (actionButtonClicked): Cancel the download if cancel button was
146         clicked, or open the downloaded file if the download finished.
147         (browserDownloadFinalize):
148         (browser_download_init):
149         (browser_download_class_init):
150         (downloadReceivedResponse): Update download message using the
151         response URI.
152         (remainingTime): Helper function to get human readable remaining
153         time.
154         (downloadProgress): Update downloads progress.
155         (downloadReceivedData):
156         (downloadFinished): Update download message and turn download
157         button into open.
158         (downloadFailed): Show error message or destroy the download UI if
159         it was cancelled.
160         (browserDownloadNew): Create a new download widget for the given
161         WebKitDownload.
162         (browser_downloads_bar_add_download): Add download widget to the
163         downloads bar.
164         * MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
165         * MiniBrowser/gtk/BrowserWindow.c:
166         (downloadStarted): Create a download widget and add it to the
167         downloads bar when a new download is started.
168         (browserWindowConstructed): Connect to
169         WebKitWebContext::download-started signal.
170         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
171
172 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
173
174         Unreviewed. Skip unit test failing in debug bot.
175
176         * Scripts/run-gtk-tests:
177         (TestRunner):
178
179 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
180
181         [EFL][DRT] "resource,request,willsend" signal needs to provide more information
182         https://bugs.webkit.org/show_bug.cgi?id=84670
183
184         Reviewed by Andreas Kling.
185
186         Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
187         passed with the "resource,request,willsend" signal and dump
188         information about the network request and the possible network
189         response if LayoutTestController's dumpResourceLoadCallbacks() returns
190         true.
191
192         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
193         (pathSuitableForTestResult):
194         (urlSuitableForTestResult):
195         (descriptionSuitableForTestResult):
196         (DumpRenderTreeChrome::onWillSendRequest):
197
198 2012-04-25  Csaba Osztrogonác  <ossy@webkit.org>
199
200         [Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
201         http://trac.webkit.org/changeset/113703
202         https://bugs.webkit.org/show_bug.cgi?id=83024
203
204         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
205         * Tools.pro:
206         * qmake/mkspecs/features/features.prf:
207         * qmake/mkspecs/features/functions.prf:
208
209 2012-04-25  Maciej Stachowiak  <mjs@apple.com>
210
211         Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
212         https://bugs.webkit.org/show_bug.cgi?id=84931
213
214         Reviewed by Filip Pizlo.
215
216         * DumpRenderTree/mac/LayoutTestHelper.m:
217         (installLayoutTestColorProfile): Account for the possibility of the default
218         profile being a factory profile.
219
220 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
221
222         Unreviewed, rolling out r115240.
223         http://trac.webkit.org/changeset/115240
224         https://bugs.webkit.org/show_bug.cgi?id=84928
225
226         It broke everything (Requested by Ossy_HOME on #webkit).
227
228         * Scripts/webkitpy/layout_tests/port/gtk.py:
229         (GtkDriver):
230         (GtkDriver._start):
231         (GtkDriver._start.x_filter):
232         (GtkDriver.stop):
233         (GtkPort._driver_class):
234         * Scripts/webkitpy/layout_tests/port/qt.py:
235         (QtPort._build_driver):
236         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
237
238 2012-04-25  Dirk Pranke  <dpranke@chromium.org>
239
240         [chromium] change DRT's "DRT" output to match the other ports
241         https://bugs.webkit.org/show_bug.cgi?id=84904
242
243         Reviewed by Kent Tamura.
244
245         Since we run Chromium's DRT in --test-shell mode, the
246         non-test-shell output has never been really beaten on to make
247         sure it's right. This fixes a few issues and will be tested
248         with upcoming NRWT changes that'll land in a separate patch.
249         In particular we should never output framing text like "\n"
250         or "#EOF" outside of something outside of TestEventPrinter,
251         and we weren't handling audio output properly at all.
252
253         * DumpRenderTree/chromium/TestEventPrinter.cpp:
254         (DRTPrinter):
255         (TestShellPrinter):
256         (DRTPrinter::handleTextFooter):
257         (DRTPrinter::handleAudioFooter):
258         (DRTPrinter::handleTestFooter):
259         (TestShellPrinter::handleAudioFooter):
260         * DumpRenderTree/chromium/TestEventPrinter.h:
261         (TestEventPrinter):
262         * DumpRenderTree/chromium/TestShell.cpp:
263         (TestShell::TestShell):
264         (TestShell::dump):
265
266 2012-04-25  Joshua Bell  <jsbell@chromium.org>
267
268         Unreviewed: Adding Alec Flett as a contributor (non-committer).
269
270         * Scripts/webkitpy/common/config/committers.py:
271
272 2012-04-25  Abhishek Arya  <inferno@chromium.org>
273
274         Mark myself as a reviewer.
275         https://bugs.webkit.org/show_bug.cgi?id=84902
276
277         Reviewed by Dimitri Glazkov.
278
279         * Scripts/webkitpy/common/config/committers.py:
280
281 2012-04-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
282
283         [Qt][NRWT] Run each DRT in it's own xvfb
284         https://bugs.webkit.org/show_bug.cgi?id=77335
285
286         Reviewed by Dirk Pranke.
287
288         * Scripts/webkitpy/layout_tests/port/gtk.py:
289         (GtkPort._driver_class):
290         * Scripts/webkitpy/layout_tests/port/qt.py:
291         (QtPort._driver_class):
292         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
293         (XvfbDriver):
294         (XvfbDriver._start):
295         (XvfbDriver._start.x_filter):
296         (XvfbDriver.stop):
297
298 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
299
300         Unreviewed, rolling out r115222.
301         http://trac.webkit.org/changeset/115222
302         https://bugs.webkit.org/show_bug.cgi?id=84874
303
304         Caused test regressions on the EFL build (Requested by rakuco
305         on #webkit).
306
307         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
308         (LayoutTestController::addOriginAccessWhitelistEntry):
309         (LayoutTestController::removeOriginAccessWhitelistEntry):
310
311 2012-04-25  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
312
313         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
314         https://bugs.webkit.org/show_bug.cgi?id=83880
315
316         Reviewed by Antonio Gomes.
317
318         Add missing implementation addOriginAccessWhitelistEntry and
319         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
320         in order to unskip tests which rely on this.
321
322         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
323         (LayoutTestController::addOriginAccessWhitelistEntry):
324         (LayoutTestController::removeOriginAccessWhitelistEntry):
325
326 2012-04-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
327
328         [EFL] [DRT] Reset text zoom factor before running a test
329         https://bugs.webkit.org/show_bug.cgi?id=84861
330
331         Reviewed by Antonio Gomes.
332
333         This fix eliminates most of the current flakiness on EFL build
334         bots, although some CSS tests will now need rebasiling.
335
336         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
337         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
338
339 2012-04-25  Milian Wolff  <milian.wolff@kdab.com>
340
341         [Qt] add LayoutTestController::setPrinting support to Qt unit tests
342         https://bugs.webkit.org/show_bug.cgi?id=84246
343
344         Reviewed by Simon Hausmann.
345
346         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
347         (WebCore::DumpRenderTree::dump):
348
349 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
350
351         [Qt] Make the web view's url property follow the active url
352
353         https://bugs.webkit.org/show_bug.cgi?id=77554
354
355         Update  the location bar in the minibrowser to behave
356         a bit more like normal browsers in terms of when the url will change
357         and how active focus is handled.
358
359         Reviewed by Simon Hausmann.
360
361         * MiniBrowser/qt/qml/BrowserWindow.qml:
362
363 2012-04-25  Philippe Normand  <pnormand@igalia.com>
364
365         Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
366         https://bugs.webkit.org/show_bug.cgi?id=81913
367
368         Reviewed by Tor Arne Vestbø.
369
370         * qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
371         and gstreamer-plugins-base >= 0.10.30 just like the GTK port
372         does. 0.10.27 is unfortunately not recent enough to get the media
373         player working reliably.
374
375
376 2012-04-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
377
378         [BlackBerry] Run tests in '/http/tests/local' with local URI
379         https://bugs.webkit.org/show_bug.cgi?id=84820
380
381         Reviewed by Nikolas Zimmermann.
382
383         Currently we run all tests under folder "/http/tests/" as HTTP
384         tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
385         'http/tests/local' are run with local path (like '/developer/LayoutTests
386         /http/tests/local/absolute-url-strip-whitespace.html').
387         With this patch we can keep the same behaviour as other portings.
388
389         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
390         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
391
392 2012-04-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
393
394         [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
395         https://bugs.webkit.org/show_bug.cgi?id=84709
396
397         Reviewed by Eric Seidel.
398
399         Not all the settings that can be changed by layout testcases through a JS API were 
400         reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
401
402         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
403         (defaultEditingBehavior): returns editing behavior depending on current platform.
404         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
405
406 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
407
408         nrwt: add ASAN handling to chromium crash logs
409         https://bugs.webkit.org/show_bug.cgi?id=84664
410
411         Reviewed by Ojan Vafai.
412
413         * Scripts/webkitpy/layout_tests/port/chromium.py:
414         (ChromiumPort._get_crash_log):
415
416 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
417
418         webkit-patch rebaseline-test is retrieving stale expectations
419         https://bugs.webkit.org/show_bug.cgi?id=84762
420
421         Reviewed by Ojan Vafai.
422
423         webkit-patch rebaseline-expectations is fetching files directly
424         from the layout-test-results directory on the buildbots, rather
425         than fetching them from the archive. This is problematic because
426         we don't clobber the directory after each run and so you can end
427         up fetching stale failing results.
428
429         This change temporarily changes the code to fetch the zip file
430         instead -- making things much slower -- until I can confer w/
431         abarth and ojan over the best way to fix this for the long-term.
432
433         * Scripts/webkitpy/tool/commands/rebaseline.py:
434         (RebaselineTest.__init__):
435         (RebaselineTest._zip_file_set):
436         (RebaselineTest):
437         (RebaselineTest._fetch_baseline):
438         (RebaselineTest._rebaseline_test):
439         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
440         (TestRebaseline.stub_rebaseline_test_command_and_tool):
441         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
442         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
443         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
444         (test_rebaseline_updates_expectations_file):
445         (test_rebaseline_test):
446         (test_rebaseline_and_copy_test):
447         (test_rebaseline_and_copy_test_no_existing_result):
448         (test_rebaseline_and_copy_test_with_lion_result):
449         (test_rebaseline_and_copy_no_overwrite_test):
450
451 2012-04-24  Ojan Vafai  <ojan@chromium.org>
452
453         Improve code for embedding flakiness dashboard as an iframe
454         https://bugs.webkit.org/show_bug.cgi?id=84782
455
456         Reviewed by Dirk Pranke.
457
458         -Include the horizontal scrollbar height in the measured height of the page.
459         -Post a message everytime the height changes instead of in response to a queryContentHeight message.
460         This way, the embedder doesn't need to poll.
461
462         No new tests. This is hard to test because it involves postMessage and iframes.
463         Once we switch the dashboard tests over to qunit, we should be able to write an
464         asyncTest for this.
465
466         * TestResultServer/static-dashboards/flakiness_dashboard.js:
467         (generatePage):
468         (appendHTML):
469         (appendExpectations):
470         (postHeightChangedMessage):
471         (generatePageForIndividualTests.if):
472         (generatePageForIndividualTests):
473         * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
474
475 2012-04-16  Ojan Vafai  <ojan@chromium.org>
476
477         Replace garden-o-matic accordion UI with a panel UI
478         https://bugs.webkit.org/show_bug.cgi?id=84081
479
480         Reviewed by Dimitri Glazkov.
481
482         This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
483         since we can reuse the same iframe without moving it in the DOM.
484
485         Also, excise unnecessary jquery-isms.
486
487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
490
491 2012-04-24  Peter Beverloo  <peter@chromium.org>
492
493         [Chromium] DumpRenderTree should depend on base.gyp:test_support_base
494         https://bugs.webkit.org/show_bug.cgi?id=84729
495
496         Reviewed by Dirk Pranke.
497
498         This dependency is necessary for Android since it'll soon be
499         calling InitAndroidOSPathStub() in it's platform support. The
500         TestWebKitAPI and webkit_unit_tests already have this dependency.
501
502         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
503
504 2012-04-24  Ojan Vafai  <ojan@chromium.org>
505
506         Replace vague informative statement with the list of builders where the test isn't listed
507         https://bugs.webkit.org/show_bug.cgi?id=84779
508
509         Reviewed by Dirk Pranke.
510
511         This is more informative and more likely to be noticed. With the old UI, people never
512         read the line and if they did, they didn't really understand what it meant. Hopefully
513         have the list of builders will be more clear.
514
515         * TestResultServer/static-dashboards/flakiness_dashboard.js:
516         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
517         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
518
519 2012-04-24  Tommy Widenflycht  <tommyw@google.com>
520
521         MediaStream API: Create a new flag for PeerConnection
522         https://bugs.webkit.org/show_bug.cgi?id=84723
523
524         Reviewed by Dimitri Glazkov.
525
526         To allow Chrome to make the GetUserMedia functionality available by default we
527         need another flag for the PeerConnection related parts. This new flag is in
528         addition to the general media stream flag, and both need to be enabled for
529         PeerConnection object creation.
530
531         * DumpRenderTree/chromium/TestShell.cpp:
532         (TestShell::TestShell):
533
534 2012-04-24  Joe Mason  <jmason@rim.com>
535
536         [BlackBerry] Revert broken changes to authentication dialog
537         https://bugs.webkit.org/show_bug.cgi?id=80135
538
539         Reviewed by Antonio Gomes.
540
541         The previous patches from this bug caused an infinite loop when using digest auth;
542         apparently they were only tested with basic.
543
544         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
545         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
546         (WebCore):
547
548 2012-04-24  Zan Dobersek  <zandobersek@gmail.com>
549
550         [TestResultsServer] Add a unit test for changes in r114868
551         https://bugs.webkit.org/show_bug.cgi?id=84713
552
553         Reviewed by Ojan Vafai.
554
555         Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
556         that is created for either DEPS or ToT builder groups. The unit test covers changes
557         made in r114868.
558
559         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
560         (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
561         (testBuilderGroupIsToTWebKitAttribute.assertEquals):
562
563 2012-04-24  Brady Eidson  <beidson@apple.com>
564
565         <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
566          Need DOMWindow mechanism to supplement UserScripts for page cache notifications
567
568         Reviewed by Sam Weinig.
569
570         Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
571
572         It makes sure new extensions can be added at the right times, and that all of the expected
573         callbacks are made.
574
575         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
576         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
577         (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
578            bundle to a set of known expected messages.
579
580         Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
581         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
582         (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
583         (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
584         (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
585         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
586         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
587         (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
588         (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
589         (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
590         (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
591         (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
592         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
593         (TestWebKitAPI::didFinishLoadForFrameCallback):
594         (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
595         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
596         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
597         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
598
599         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
600         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
601
602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
603
604 2012-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
605
606         [GTK] Build and run TestWebKitAPI unit tests
607         https://bugs.webkit.org/show_bug.cgi?id=84325
608
609         Reviewed by Philippe Normand.
610
611         We only build WTF unit tests for now. WebKit2 tests will be
612         enabled in a follow up patch.
613
614         * Scripts/run-gtk-tests:
615         (TestRunner): Add TestWebKitAPI/WTF to the list of directories
616         containing unit tests.
617         (TestRunner._run_test_glib): Run glib tests using gtester.
618         (TestRunner._run_test_google): Run google tests.
619         (TestRunner._run_test): Use _run_test_glib or _run_test_google
620         depending on whether given test is glib or google test
621         * TestWebKitAPI/GNUmakefile.am: Added.
622         * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
623         warning with -Wundef. Include WebKit2 headers only when building
624         WebKit2.
625
626 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
627
628         [Qt][WK2] Convert touch-point area
629         https://bugs.webkit.org/show_bug.cgi?id=84434
630
631         Reviewed by Kenneth Rohde Christiansen.
632
633         Fix failing test after r114917 by also adding the new EventSender API
634         to WebKitTestRunner.
635
636         * WebKitTestRunner/EventSenderProxy.h:
637         (EventSenderProxy):
638         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
639         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
640         (WTR::EventSendingController::setTouchPointRadius):
641         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
642         (EventSendingController):
643         * WebKitTestRunner/TestController.cpp:
644         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
645         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
646         (WTR::EventSenderProxy::addTouchPoint):
647         (WTR::EventSenderProxy::updateTouchPoint):
648         (WTR::EventSenderProxy::setTouchPointRadius):
649         (WTR::EventSenderProxy::clearTouchPoints):
650
651 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
652
653         [Chromium] Unreviewed test expectations update.
654         https://bugs.webkit.org/show_bug.cgi?id=84726
655
656         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
657
658         * Scripts/webkitpy/test/test_finder.py:
659         (TestFinder._default_names):
660
661 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
662
663         [EFL] Enable Web Timing
664         https://bugs.webkit.org/show_bug.cgi?id=84705
665
666         Reviewed by Tony Gentilcore.
667
668         Enable web timing by default whenever build-webkit is used.
669
670         * Scripts/build-webkit:
671
672 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
673
674         Return value from executed script in Chromium.
675         https://bugs.webkit.org/show_bug.cgi?id=79851
676
677         Reviewed by Adam Barth.
678
679         Adding a function to LayoutTestController that evaluates a script in
680         an isolated wold an returns the result of the evaluation.
681
682         * DumpRenderTree/LayoutTestController.cpp:
683         (evaluateScriptInIsolatedWorldAndReturnValue):
684         (LayoutTestController::staticFunctions):
685         * DumpRenderTree/LayoutTestController.h:
686         (LayoutTestController):
687         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
688         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
689         * DumpRenderTree/chromium/LayoutTestController.cpp:
690         (LayoutTestController::LayoutTestController):
691         (LayoutTestController::setXSSAuditorEnabled):
692         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
693         * DumpRenderTree/chromium/LayoutTestController.h:
694         (LayoutTestController):
695         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
696         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
697         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
698         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
699         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
700         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
701         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
702         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
703         * DumpRenderTree/qt/LayoutTestControllerQt.h:
704         (LayoutTestController):
705         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
706         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
707         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
708         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
709
710 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
711
712         run-perf-tests fail intermittently with an exception
713         https://bugs.webkit.org/show_bug.cgi?id=83532
714
715         Reviewed by Ryosuke Niwa.
716
717         This bulletproofs port.get_option('child_processes')
718         against the case where the option wasn't set.
719
720         * Scripts/webkitpy/layout_tests/port/mac.py:
721         (MacPort._get_crash_log):
722         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
723         (test_get_crash_log):
724         (test_get_crash_log.fake_time_cb):
725
726 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
727
728         [Qt] Add desktop zooming support for QQuickWebView
729         https://bugs.webkit.org/show_bug.cgi?id=82337
730
731         Unreviewed typo fix after r114900.
732
733         * MiniBrowser/qt/BrowserWindow.cpp:
734         (BrowserWindow::BrowserWindow): Fix the mistyped
735         value of a zoom level.
736
737 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
738
739         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
740         https://bugs.webkit.org/show_bug.cgi?id=84580
741
742         Reviewed by Ojan Vafai.
743
744         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
745         Take the opportunity to get rid of the trick.
746
747         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
748         (ChromiumAndroidPort.start_helper):
749         (ChromiumAndroidPort._push_fonts):
750
751 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
752
753         test-webkitpy is failing
754         https://bugs.webkit.org/show_bug.cgi?id=84617
755
756         Reviewed by Eric Seidel.
757
758         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
759         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
760
761 2012-04-23  Ojan Vafai  <ojan@chromium.org>
762
763         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
764         of making the code more maintainable (e.g. being able to use qunit for testing).
765
766         * TestResultServer/static-dashboards/dashboard_base.js:
767         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
768         * TestResultServer/static-dashboards/flakiness_dashboard.html:
769         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
770         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
771         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
772
773 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
774
775         [Qt][WK2] Convert touch-point area.
776         https://bugs.webkit.org/show_bug.cgi?id=84434
777
778         Reviewed by Kenneth Rohde Christiansen.
779
780         Add feature to set touch-point radius for emitted touch-events.
781
782         * DumpRenderTree/qt/EventSenderQt.cpp:
783         (EventSender::addTouchPoint):
784         (EventSender::updateTouchPoint):
785         (EventSender::setTouchPointRadius):
786         (EventSender::clearTouchPoints):
787         * DumpRenderTree/qt/EventSenderQt.h:
788         (EventSender):
789
790 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
791
792         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
793         https://bugs.webkit.org/show_bug.cgi?id=84425
794
795         Reviewed by Antonio Gomes.
796
797         Use the new helper in DumpRenderTreeSupportEfl to properly
798         test whether an element performs autocompletion.
799
800         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
801         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
802
803 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
804
805         master.cfg cleanup, remove dead codes after r92792.
806         https://bugs.webkit.org/show_bug.cgi?id=84433
807
808         Relanding r114881 after typo fix in UploadBuiltProduct.
809
810         Reviewed by Ryosuke Niwa.
811
812         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
813
814 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
815
816         [EFL][DRT] Need to support requestAnimationFrame
817         https://bugs.webkit.org/show_bug.cgi?id=84585
818
819         Reviewed by Martin Robinson.
820
821         Making requestAnimationFrame() support a default on the EFL build.
822
823         * Scripts/build-webkit:
824
825 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
826
827         [Qt] Add desktop zooming support for QQuickWebView
828         https://bugs.webkit.org/show_bug.cgi?id=82337
829
830         Reviewed by Simon Hausmann.
831
832         Add zooming support for MiniBrowser to
833         test the new API.
834
835         * MiniBrowser/qt/BrowserWindow.cpp:
836         (BrowserWindow::BrowserWindow):
837         (BrowserWindow::zoomIn):
838         (BrowserWindow::zoomOut):
839         (BrowserWindow::keyPressEvent):
840         (BrowserWindow::wheelEvent):
841         * MiniBrowser/qt/BrowserWindow.h:
842         (BrowserWindow):
843
844 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
845
846         Unreviewed rolling out r114881, because it broke upload buildstep.
847
848         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
849         (ConfigureBuild.__init__):
850         (ConfigureBuild.start):
851         (CompileWebKit.start):
852         (UploadBuiltProduct):
853         (UploadBuiltProduct.determineExtraFeatures):
854         (Factory.__init__):
855         (BuildFactory.__init__):
856         (TestFactory.__init__):
857         (loadBuilderConfig):
858
859 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
860
861         master.cfg cleanup, remove dead codes after r92792.
862         https://bugs.webkit.org/show_bug.cgi?id=84433
863
864         Reviewed by Ryosuke Niwa.
865
866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
867
868 2012-04-23  Milian Wolff  <mail@milianw.de>
869
870         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
871         https://bugs.webkit.org/show_bug.cgi?id=84327
872
873         Reviewed by Csaba Osztrogonác.
874
875         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
876         (WebCore::DumpRenderTree::dump):
877
878 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
879
880         [Gtk] Added MOZ_X11 build flag for TARGET_X11
881         https://bugs.webkit.org/show_bug.cgi?id=40785
882
883         Reviewed by Anders Carlsson.
884
885         * GNUmakefile.am:
886
887 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
888
889         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
890         https://bugs.webkit.org/show_bug.cgi?id=84544
891
892         Reviewed by Ryosuke Niwa.
893
894         Use the groupEnum parameter that is passed through to the onBuilderListLoad
895         function rather than an undefined attribute of the BuilderGroup object. This
896         makes it again possible to inspect builds on non-Chromium builders in the
897         test results server by not trying to always add Chromium revision links.
898
899         * TestResultServer/static-dashboards/builders.js:
900
901 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
902
903         [GTK] Revert changes that disabled Cairo fonts metrics hinting
904         https://bugs.webkit.org/show_bug.cgi?id=84502
905
906         Reviewed by Daniel Bates.
907
908         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
909         reference and pixel test results. This makes our font metrics a bit different
910         than the Mac port's, but it's a decent price to pay for consistent results.
911
912         * DumpRenderTree/gtk/DumpRenderTree.cpp:
913         (initializeGtkFontSettings):
914         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
915         (WTR::initializeGtkSettings):
916
917 2012-04-04  Jer Noble  <jer.noble@apple.com>
918
919         apple.com top navigation bar appears inside video during full screen exit animation
920         https://bugs.webkit.org/show_bug.cgi?id=83095
921
922         Reviewed by Eric Carlson.
923
924         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
925         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
926         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
927         from within LayoutTests.
928
929         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
930         * DumpRenderTree/LayoutTestController.cpp:
931         (setHasCustomFullScreenBehaviorCallback):
932         (LayoutTestController::staticFunctions):
933         * DumpRenderTree/LayoutTestController.h:
934         (LayoutTestController::setHasCustomFullScreenBehavior):
935         (LayoutTestController::hasCustomFullScreenBehavior):
936         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
937         (WTR::InjectedBundlePage::enterFullScreenForElement):
938         (WTR::InjectedBundlePage::exitFullScreenForElement):
939         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
940         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
941         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
942         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
943         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
944         * DumpRenderTree/chromium/LayoutTestController.cpp:
945         (LayoutTestController::LayoutTestController):
946         (LayoutTestController::reset):
947         * DumpRenderTree/chromium/LayoutTestController.h:
948         (LayoutTestController::setHasCustomFullScreenBehavior):
949         (LayoutTestController::hasCustomFullScreenBehavior):
950
951         Query the new methods before calling will/did/Enter/ExitFullScreen:
952         * DumpRenderTree/chromium/WebViewHost.cpp:
953         (WebViewHost::enterFullScreenNow):
954         (WebViewHost::exitFullScreenNow):
955         * DumpRenderTree/mac/UIDelegate.mm:
956         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
957         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
958
959 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
960
961         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
962         https://bugs.webkit.org/show_bug.cgi?id=72841
963
964         Reviewed by Dirk Pranke
965
966         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
967         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
968         and 'reference_files' fields to the TestInput objects, and use those flags
969         to select the right driver to use in the DriverProxy.
970
971         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
972         (SingleTestRunner.__init__):
973         (SingleTestRunner._driver_input):
974         (SingleTestRunner._run_reftest):
975         * Scripts/webkitpy/layout_tests/controllers/worker.py:
976         (Worker.handle_test_list):
977         (Worker._update_test_input):
978         * Scripts/webkitpy/layout_tests/models/test_input.py:
979         (TestInput):
980         (TestInput.__init__):
981         (TestInput.__repr__):
982         * Scripts/webkitpy/layout_tests/port/chromium.py:
983         (ChromiumDriver._wrapper_options):
984         (ChromiumDriver.run_test):
985         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
986         (ChromiumDriverTest.test_crash_log):
987         * Scripts/webkitpy/layout_tests/port/driver.py:
988         (DriverInput.__init__):
989         (Driver.__init__):
990         (DriverProxy.__init__):
991         (DriverProxy.run_test):
992         (DriverProxy.start):
993         (DriverProxy.cmd_line):
994         * Scripts/webkitpy/layout_tests/port/gtk.py:
995         (GtkDriver._start):
996         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
997         (MockDRT.run):
998         (MockDRT.input_from_line):
999         (MockDRT.output_for_test):
1000         (MockDRT.write_test_output):
1001         (MockChromiumDRT.input_from_line):
1002         (MockChromiumDRT.output_for_test):
1003         (MockChromiumDRT.write_test_output):
1004         * Scripts/webkitpy/layout_tests/port/webkit.py:
1005         (WebKitDriver.cmd_line):
1006         (WebKitDriver.run_test):
1007         * WebKitTestRunner/TestController.cpp:
1008         (WTR::TestController::TestController):
1009         (WTR::TestController::initialize):
1010         (WTR::TestController::runTest):
1011         * WebKitTestRunner/TestController.h:
1012         (TestController):
1013         * WebKitTestRunner/TestInvocation.cpp:
1014         (WTR::TestInvocation::TestInvocation):
1015         (WTR::TestInvocation::setIsPixelTest):
1016         * WebKitTestRunner/TestInvocation.h:
1017         (TestInvocation):
1018
1019 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1020
1021         [EFL] Make it possible to define offline storage quota per origin
1022         https://bugs.webkit.org/show_bug.cgi?id=84170
1023
1024         Improved LayoutTestController::setDatabaseQuota to set quota based on
1025         origin which was causing some tests to fail. Also align the default
1026         quota for testing (5MB) with others ports.
1027
1028         When dumpDatabaseCallbacks is set to true by, also dump some database
1029         information when quota is exceed, which is also required by some tests.
1030
1031         Reviewed by Antonio Gomes.
1032
1033         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1034         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1035         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1036         (onExceededDatabaseQuota):
1037         (drtViewAdd):
1038         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1039         (LayoutTestController::setDatabaseQuota):
1040
1041 2012-04-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1042
1043         [EFL] [DRT] Send double click event from EventSender
1044         https://bugs.webkit.org/show_bug.cgi?id=82867
1045
1046         Reviewed by Daniel Bates.
1047
1048         Add support for EFL DumpRenderTree EventSender to send
1049         double click events.
1050
1051         * DumpRenderTree/efl/EventSender.cpp:
1052         (sendMouseEvent):
1053
1054 2012-04-20  Sergio Villar Senin  <svillar@igalia.com>
1055
1056         [GTK] Enable Web Timing
1057         https://bugs.webkit.org/show_bug.cgi?id=42432
1058
1059         Reviewed by Gustavo Noronha Silva.
1060
1061         Build web timing by default whenever build-webkit is used.
1062
1063         * Scripts/build-webkit:
1064
1065 2012-04-20  Kamil Blank  <k.blank@samsung.com>
1066
1067         [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
1068         https://bugs.webkit.org/show_bug.cgi?id=84430
1069
1070         Reviewed by Daniel Bates.
1071
1072         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1073         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1074
1075 2012-04-20  Ryosuke Niwa  <rniwa@webkit.org>
1076
1077         REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
1078         https://bugs.webkit.org/show_bug.cgi?id=84424
1079
1080         Reviewed by Mark Rowe.
1081
1082         Let Windows and Chromium have their own list of files to copy.
1083
1084         * BuildSlaveSupport/built-product-archive:
1085         (removeDirectoryIfExists):
1086         (copyBuildFiles):
1087         (archiveBuiltProduct):
1088
1089 2012-04-20  Kamil Blank  <k.blank@samsung.com>
1090
1091         [EFL] Add setting API for author and user styles.
1092         https://bugs.webkit.org/show_bug.cgi?id=82860
1093
1094         Reviewed by Daniel Bates.
1095
1096         Implementation of setAuthorAndUserStylesEnabled.
1097
1098         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1099         (LayoutTestController::setAuthorAndUserStylesEnabled):
1100
1101 2012-04-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1102
1103         [EFL] Missing keycode translation for space key
1104         https://bugs.webkit.org/show_bug.cgi?id=84153
1105
1106         Reviewed by Antonio Gomes.
1107
1108         Set keyname for space key before dispatching event.
1109
1110         * DumpRenderTree/efl/EventSender.cpp:
1111         (keyNameFromJSValue):
1112
1113 2012-04-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1114
1115         [GTK] Allow to use WebInspector in GtkLauncher
1116         https://bugs.webkit.org/show_bug.cgi?id=84143
1117
1118         Reviewed by Martin Robinson.
1119
1120         * GNUmakefile.am: Add new files to compilation.
1121         * GtkLauncher/LauncherInspectorWindow.c: Added.
1122         (launcherInspectorWindowFinalize):
1123         (launcher_inspector_window_init):
1124         (launcher_inspector_window_class_init):
1125         (inspectedURIChanged): Update the window title based on current
1126         inspected URI.
1127         (showInspectorWindow): Show inspector window.
1128         (closeInspectorWindow): Hide inspector window.
1129         (launcherInspectorWindowNew): Create an inspector window.
1130         (launcherInspectorWindowGetWebView): Return the inspected web view.
1131         * GtkLauncher/LauncherInspectorWindow.h: Added.
1132         * GtkLauncher/main.c:
1133         (inspectorInspectWebViewCb): Create an inspector window.
1134         (createBrowser): Connect to inspect-web-view signal of the view
1135         inspector.
1136
1137 2012-04-19  Jeremy Mao  <yujie.mao@intel.com>
1138
1139         Media Stream API: Piece of code cleanup for the chromium port
1140         https://bugs.webkit.org/show_bug.cgi?id=84328
1141
1142         Reviewed by Kent Tamura.
1143
1144         WebUserMediaClientMock use an old requestUserMedia interface and
1145         Replace it with the new interface.
1146
1147         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1148         (WebKit::WebUserMediaClientMock::requestUserMedia):
1149         Remove the old requestUserMedia and replace it with the new.
1150         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1151         (WebUserMediaClientMock):
1152
1153 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
1154
1155         [EFL] DRT console messages should contain only the file name part of local URIs
1156         https://bugs.webkit.org/show_bug.cgi?id=84236
1157
1158         Reviewed by Kentaro Hara.
1159
1160         Process console messages before printing them in EFL's DumpRenderTree
1161         them so that they contain only the file name part of local URIs. This
1162         is what is expected by test cases.
1163
1164         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1165         (urlSuitableForTestResult):
1166         (onConsoleMessage):
1167
1168 2012-04-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1169
1170         [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
1171         https://bugs.webkit.org/show_bug.cgi?id=84169
1172
1173         All databases were being created inside ~/.webkit which was causing
1174         flaky tests when running multiple tests in parallel, specially timeouts
1175         due to concurrency.
1176
1177         Reviewed by Eric Seidel.
1178
1179         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1180         (DumpRenderTreeChrome::initialize):
1181
1182 2012-04-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1183
1184         [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
1185         https://bugs.webkit.org/show_bug.cgi?id=82484
1186
1187         Reviewed by Martin Robinson.
1188
1189         Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
1190
1191         * efl/jhbuild.modules:
1192         * gtk/jhbuild.modules:
1193
1194 2012-04-19  Lucas Forschler  <lforschler@apple.com>
1195
1196         Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
1197         
1198         * BuildSlaveSupport/build.webkit.org-config/config.json:
1199
1200 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
1201
1202         [EFL] dispatchDidCancelClientRedirect needs implementation
1203         https://bugs.webkit.org/show_bug.cgi?id=83669
1204
1205         Reviewed by Antonio Gomes.
1206
1207         Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
1208         and print out information that is expected by several test cases if
1209         LayoutTestController's dumpFrameLoadCallback() returns true.
1210
1211         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1212         (DumpRenderTreeChrome::createView):
1213         (DumpRenderTreeChrome::onFrameCreated):
1214         (DumpRenderTreeChrome::onFrameRedirectCancelled):
1215         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1216         (DumpRenderTreeChrome):
1217
1218 2012-04-18  Hironori Bono  <hbono@chromium.org>
1219
1220         Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
1221         https://bugs.webkit.org/show_bug.cgi?id=83748
1222
1223         Reviewed by Ryosuke Niwa.
1224
1225         This change replaces a call for SpellChecker::didCheck() with one for
1226         SpellChecker::didCheckCenceled() because didCheck() has been split into
1227         didCheckSucceeded() and didCheckCanceled().
1228
1229         * DumpRenderTree/chromium/WebViewHost.cpp:
1230         (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
1231
1232 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
1233
1234         Fix failure in test-webkitpy after r114583.
1235
1236         Unreviewed, build fix.
1237
1238         Updating the call site in r114583 w/o updating the test caused
1239         the test to fail. Somehow I forgot to run the unit tests :(.
1240
1241         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1242         (ChromiumDriverTest.test_crash_log):
1243
1244 2012-04-18  Filip Pizlo  <fpizlo@apple.com>
1245
1246         JSC testing should have complete coverage over typed array types
1247         https://bugs.webkit.org/show_bug.cgi?id=84302
1248
1249         Reviewed by Geoff Garen.
1250         
1251         Made run-fast-jsc print something and a newline if jsc threw an exception or
1252         otherwise returned with an error code, but did not crash.
1253
1254         * Scripts/run-fast-jsc:
1255
1256 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
1257
1258         Fix crash in chromium.py after r114877.
1259
1260         Unreviewed, build fix.
1261
1262         Missed updating one call site for get_crash_log() :(.
1263
1264         * Scripts/webkitpy/layout_tests/port/chromium.py:
1265         (ChromiumDriver.run_test):
1266
1267 2012-04-18  Philippe Normand  <pnormand@igalia.com>
1268
1269         [GTK] NRWT bails out if more than one X server runs on the machine
1270         https://bugs.webkit.org/show_bug.cgi?id=84276
1271
1272         Reviewed by Dirk Pranke.
1273
1274         Set up GTK driver's Xvfb display number based on Xorg servers
1275         currently running.
1276
1277         * Scripts/webkitpy/layout_tests/port/gtk.py:
1278         (GtkDriver._start):
1279         (GtkDriver._start.x_filter):
1280
1281 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
1282
1283         run-webkit-tests picked up an old crash log
1284         https://bugs.webkit.org/show_bug.cgi?id=84196
1285
1286         Reviewed by Ryosuke Niwa.
1287
1288         Modify the crash log-finding code so that we can
1289         limit our search to logs newer than X - this prevents
1290         us from finding old crash logs for a given process/pid
1291         combination even when the PIDs might've wrapped.
1292  
1293         Also fix a bug in filesystem_mock where files_under() would
1294         return paths that didn't exist.
1295
1296         * Scripts/webkitpy/common/system/crashlogs.py:
1297         (CrashLogs.find_newest_log):
1298         (CrashLogs._find_newest_log_darwin):
1299         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1300         (CrashLogsTest.test_find_log_darwin):
1301         (CrashLogsTest.test_find_log_darwin.bad_read):
1302         (CrashLogsTest):
1303         * Scripts/webkitpy/common/system/filesystem_mock.py:
1304         (MockFileSystem.files_under):
1305         * Scripts/webkitpy/layout_tests/port/base.py:
1306         (Port._get_crash_log):
1307         * Scripts/webkitpy/layout_tests/port/gtk.py:
1308         (GtkPort._get_crash_log):
1309         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1310         * Scripts/webkitpy/layout_tests/port/mac.py:
1311         (MacPort._get_crash_log):
1312         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1313         (PortTestCase.test_get_crash_log):
1314         * Scripts/webkitpy/layout_tests/port/webkit.py:
1315         (WebKitDriver.run_test):
1316
1317 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
1318
1319         nrwt: support additional test expectations files
1320         https://bugs.webkit.org/show_bug.cgi?id=84222
1321
1322         Reviewed by Ojan Vafai.
1323
1324         This patch adds an --additional-expectations flag that can be
1325         used to point to more files that will override the default set
1326         of expectations. This will allow us to remove the
1327         'google_chrome' ports and eventually help to clean up override
1328         handling in the chromium ports and unify expectations files and
1329         Skipped files; this can also be used to specify overrides for
1330         tests that run differently on a given machine.
1331
1332         * Scripts/webkitpy/layout_tests/port/base.py:
1333         (Port.test_expectations_overrides):
1334         * Scripts/webkitpy/layout_tests/port/chromium.py:
1335         (ChromiumPort.test_expectations_overrides):
1336         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1337         (parse_args):
1338         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1339         (MainTest.test_additional_expectations):
1340
1341 2012-04-18  Jer Noble  <jer.noble@apple.com>
1342
1343         Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
1344         https://bugs.webkit.org/show_bug.cgi?id=84177
1345
1346         Reviewed by Dirk Pranke.
1347
1348         Try to delete the pid file left by Apache in the case it was killed forcefully.
1349
1350         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1351         (LayoutTestApacheHttpd._stop_running_server):
1352
1353 2012-04-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1354
1355         Clean-up WheelEvent Conversion.
1356         https://bugs.webkit.org/show_bug.cgi?id=84243
1357
1358         Reviewed by Simon Hausmann.
1359         
1360         Calculate proper wheel-delta from pixel-delta given.
1361
1362         * DumpRenderTree/qt/EventSenderQt.cpp:
1363         (EventSender::EventSender):
1364         (EventSender::mouseScrollBy):
1365         (EventSender::continuousMouseScrollBy):
1366
1367 2012-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1368
1369         Unreviewed, rolling out r114506.
1370         http://trac.webkit.org/changeset/114506
1371         https://bugs.webkit.org/show_bug.cgi?id=84254
1372
1373         Seems to be making gtk's DumpRenderTree crash occasionally
1374         (Requested by tomz on #webkit).
1375
1376         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1377         (resetDefaultsToConsistentValues):
1378
1379 2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1380
1381         [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
1382         https://bugs.webkit.org/show_bug.cgi?id=84229
1383
1384         CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
1385         subsequent builds, stopping WebCore from being built ever again.
1386
1387         Instead of trying to emulate a build target using command line options,
1388         just build the existing jsc target directly.
1389
1390         Reviewed by Rob Buis.
1391
1392         * Scripts/build-jsc:
1393
1394 2012-04-18  Simon Pena  <spena@igalia.com>
1395
1396         [GTK] r114021 triggered media flakyness
1397         https://bugs.webkit.org/show_bug.cgi?id=83874
1398
1399         Reviewed by Philippe Normand.
1400
1401         Now that there is gtk API to update the
1402         MediaPlaybackRequiresUserGesture property, set it to false from the
1403         DumpRenderTree tool when resetting defaults to consistent values.
1404
1405         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1406         (resetDefaultsToConsistentValues):
1407
1408 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
1409
1410         Web Inspector: Disabling Inspector causes build failure on Windows
1411         https://bugs.webkit.org/show_bug.cgi?id=83557
1412
1413         Reviewed by Pavel Feldman.
1414
1415         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1416         This change brings all such API calls under the guard.
1417
1418         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1419         (WTR::LayoutTestController::showWebInspector):
1420         (WTR::LayoutTestController::closeWebInspector):
1421         (WTR::LayoutTestController::evaluateInWebInspector):
1422         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1423         * WebKitTestRunner/TestInvocation.cpp:
1424         (WTR::TestInvocation::invoke):
1425
1426 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
1427
1428         [GTK] atk/textChangedNotifications API test fails
1429         https://bugs.webkit.org/show_bug.cgi?id=84010
1430
1431         Unreviewed, unskipping test after bug being fixed by r114311.
1432
1433         * Scripts/run-gtk-tests:
1434         (TestRunner): Unskip now passing test.
1435
1436 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
1437
1438         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
1439         https://bugs.webkit.org/show_bug.cgi?id=84199
1440
1441         Reviewed by George Staikos.
1442
1443         Revert a part of the change master_32/SHA:fa0f8ee9 and use
1444         WebPage::setUserScalable instead.
1445
1446         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1447         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1448
1449 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
1450
1451         build-webkit: make ninja work with chromium linux
1452         https://bugs.webkit.org/show_bug.cgi?id=84213
1453
1454         Reviewed by Eric Seidel.
1455
1456         Fix typos so that build-webkit will use ninja to
1457         build chromium if a build.ninja file exists and is up-to-date.
1458
1459         * Scripts/webkitdirs.pm:
1460         (determineIsChromiumNinja):
1461
1462 2012-04-17  Ojan Vafai  <ojan@chromium.org>
1463
1464         Add caching to the flakiness dashboard json files
1465         https://bugs.webkit.org/show_bug.cgi?id=84198
1466
1467         Reviewed by Dirk Pranke.
1468
1469         * TestResultServer/handlers/testfilehandler.py:
1470         (GetFile._get_file_list):
1471         (GetFile._get_file_content):
1472         (GetFile._get_file_content_from_key):
1473         (GetFile._get_test_list_json):
1474         (GetFile._serve_json):
1475         Add a Last-Modified header and handle If-Modified-Since headers.
1476         (GetFile.get):
1477
1478 2012-04-17  Anders Carlsson  <andersca@apple.com>
1479
1480         Need a client callback for when the user tries to interact with an already unresponsive page
1481         https://bugs.webkit.org/show_bug.cgi?id=84201
1482         <rdar://problem/11140862>
1483
1484         Reviewed by Andreas Kling.
1485
1486         Add new client functions.
1487
1488         * MiniBrowser/mac/BrowserWindowController.m:
1489         (-[BrowserWindowController awakeFromNib]):
1490         * WebKitTestRunner/TestController.cpp:
1491         (WTR::TestController::initialize):
1492
1493 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
1494
1495         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
1496         https://bugs.webkit.org/show_bug.cgi?id=84190
1497
1498         Reviewed by Ojan Vafai.
1499
1500         LayoutTestHelper would exit when the user typed ctrl-c, but we
1501         would attempt to write to it to shut it down, generating an
1502         IOError.
1503
1504         * Scripts/webkitpy/layout_tests/port/chromium.py:
1505         (ChromiumPort.stop_helper):
1506
1507 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
1508
1509         rename --experimental-fully-parallel
1510         https://bugs.webkit.org/show_bug.cgi?id=84188
1511
1512         Reviewed by Ojan Vafai.
1513
1514         I thought this was done long ago; rename
1515         --experimental-fully-parallel to just --fully-parallel and
1516         remove the --no- switch that AFAIK no one uses.
1517
1518         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1519         (Manager._run_tests):
1520         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1521         (parse_args):
1522
1523 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
1524
1525         EFL's LayoutTestController does not implement callShouldCloseOnWebView
1526         https://bugs.webkit.org/show_bug.cgi?id=82301
1527
1528         Reviewed by Martin Robinson.
1529
1530         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
1531         calling shouldClose() on the FrameLoader, allowing the related test
1532         to be removed from the skip list.
1533
1534         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1535         (LayoutTestController::callShouldCloseOnWebView):
1536
1537 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1538
1539         [EFL] Add setting API to enable/disable XSSAuditor
1540         https://bugs.webkit.org/show_bug.cgi?id=83281
1541
1542         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
1543         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
1544         'xss,detected' in DRT to enable a test, which is expecting a line containing
1545         'didDetectXSS' in the output when reflected XSS is encountered in the page.
1546
1547         Reviewed by Antonio Gomes.
1548
1549         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1550         (DumpRenderTreeChrome::createView):
1551         (DumpRenderTreeChrome::onFrameCreated):
1552         (DumpRenderTreeChrome::onDidDetectXSS):
1553         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1554         (DumpRenderTreeChrome):
1555         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1556         (LayoutTestController::setXSSAuditorEnabled):
1557
1558 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
1559
1560         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
1561         https://bugs.webkit.org/show_bug.cgi?id=77533
1562
1563         Reviewed by Simon Hausmann.
1564
1565         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
1566         the corresponding parameter to the buildQMakeProjects function.
1567
1568         * Scripts/build-jsc:
1569
1570 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
1571
1572         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
1573         https://bugs.webkit.org/show_bug.cgi?id=83030
1574
1575         Reviewed by Antonio Gomes.
1576
1577         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
1578         in EFL's DumpRenderTree. Make use of the new frame argument passed to
1579         the "load,started" and "load,finished" signals.
1580
1581         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1582         (DumpRenderTreeChrome::createView):
1583         (DumpRenderTreeChrome::onLoadStarted):
1584         (DumpRenderTreeChrome::processWork):
1585         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
1586         (DumpRenderTreeChrome::onWebViewOnloadEvent):
1587         (DumpRenderTreeChrome::onInsecureContentRun):
1588         (DumpRenderTreeChrome::onInsecureContentDisplayed):
1589         (DumpRenderTreeChrome::onFrameCreated):
1590         (DumpRenderTreeChrome::onFrameProvisionalLoad):
1591         (DumpRenderTreeChrome::onFrameLoadCommitted):
1592         (DumpRenderTreeChrome::onFrameLoadFinished):
1593         (DumpRenderTreeChrome::onFrameLoadError):
1594         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1595         (DumpRenderTreeChrome):
1596
1597 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1598
1599         Unreviewed, rolling out r114376.
1600         http://trac.webkit.org/changeset/114376
1601         https://bugs.webkit.org/show_bug.cgi?id=84155
1602
1603         Wrong patch version committed, asked by the patch author.
1604         (Requested by rakuco on #webkit).
1605
1606         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1607         (DumpRenderTreeChrome::createView):
1608         (DumpRenderTreeChrome::processWork):
1609         (DumpRenderTreeChrome::onLoadFinished):
1610         (DumpRenderTreeChrome::onWillSendRequest):
1611         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1612         (DumpRenderTreeChrome):
1613
1614 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
1615
1616         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
1617         https://bugs.webkit.org/show_bug.cgi?id=83030
1618
1619         Reviewed by Antonio Gomes.
1620
1621         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
1622         in EFL's DumpRenderTree.
1623
1624         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1625         (DumpRenderTreeChrome::createView):
1626         (DumpRenderTreeChrome::processWork):
1627         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
1628         (DumpRenderTreeChrome::onWebViewOnloadEvent):
1629         (DumpRenderTreeChrome::onInsecureContentRun):
1630         (DumpRenderTreeChrome::onInsecureContentDisplayed):
1631         (DumpRenderTreeChrome::onFrameCreated):
1632         (DumpRenderTreeChrome::onFrameProvisionalLoad):
1633         (DumpRenderTreeChrome::onFrameLoadCommitted):
1634         (DumpRenderTreeChrome::onFrameLoadFinished):
1635         (DumpRenderTreeChrome::onFrameLoadError):
1636         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1637         (DumpRenderTreeChrome):
1638
1639 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
1640
1641         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
1642         https://bugs.webkit.org/show_bug.cgi?id=83035
1643
1644         Reviewed by Simon Hausmann.
1645
1646         The force_static_libs_as_shared feature for the Qt port will remove
1647         hide_symbols from Qt's CONFIG in order to make them visible to other
1648         libraries again.
1649
1650         Due to an evaluation order problem in qmake, the flags for the C++ compiler
1651         that are set by adding hide_symbols to the CONFIG variables get applied
1652         to qmake's C++ compiler flags directly and hence trying to remove these
1653         later will not work and cause build failures when using the force_static_libs_as_shared
1654         feature of the Qt port.
1655
1656         This is fixed by removing the flags that hide the exports from the compiler flags directly.
1657
1658         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1659
1660 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
1661
1662         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
1663         https://bugs.webkit.org/show_bug.cgi?id=84068
1664
1665         Reviewed by Eric Seidel.
1666
1667         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
1668         automatically creates the build directory if needed.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1671         (DownloadAndPerfTestFactory.__init__):
1672         (DownloadAndPerfTestWebKit2Factory.__init__):
1673
1674 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1675
1676         [GTK] Use configure instead of autogen.sh for gtk+
1677         https://bugs.webkit.org/show_bug.cgi?id=84112
1678
1679         Rubber-stamped by Martin Robinson.
1680
1681         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
1682         we don't want to depend on that for now, so run configure instead - we
1683         can, since we are using a tarball
1684
1685 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1686
1687         Unreviewed, rolling out r114322.
1688         http://trac.webkit.org/changeset/114322
1689         https://bugs.webkit.org/show_bug.cgi?id=84096
1690
1691         Didn't make the debug bot happy, so back out
1692
1693         * gtk/jhbuild.modules:
1694
1695 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1696
1697         [GTK] Try to fix debug bot by adding gobject-introspection to the build
1698         https://bugs.webkit.org/show_bug.cgi?id=84096
1699
1700         Unreviewed speculative build fix.
1701
1702         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
1703         an up-to-date introspection m4 for running autogen.
1704
1705 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1706
1707         [GTK] Add pango to jhbuild
1708         https://bugs.webkit.org/show_bug.cgi?id=84086
1709
1710         Unreviewed build fix.
1711
1712         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
1713         jhbuild environment. It's required for latest stable GTK+ and some
1714         systems may lack it.
1715
1716 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1717
1718         [GTK] fonts jhbuild module needs an empty clean target
1719         https://bugs.webkit.org/show_bug.cgi?id=84085
1720
1721         Rubber-stamped by Martin Robinson.
1722
1723         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
1724         includes a phony clean target that should make warnings and errors go
1725         away.
1726
1727 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1728
1729         [GTK] Bump dependency on GTK+ 3.x to match reality
1730         https://bugs.webkit.org/show_bug.cgi?id=84060
1731
1732         Rubber-stamped by Martin Robinson.
1733
1734         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
1735         to their GNOME 3.4 versions.
1736         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
1737         is applied upstream.
1738
1739 2012-04-16  Vincent Scheib  <scheib@chromium.org>
1740
1741         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
1742
1743         Unreviewed.
1744
1745         * Scripts/webkitpy/common/config/committers.py:
1746
1747 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1748
1749         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
1750         https://bugs.webkit.org/show_bug.cgi?id=84031
1751
1752         Reviewed by Rob Buis.
1753
1754         Implemented interface function didReceiveAuthenticationChallenge in class
1755         DumpRenderTree.
1756
1757         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1758         (drtCredentialDescription):
1759         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1760         (WebKit):
1761         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1762         (WebCore):
1763         (DumpRenderTree):
1764
1765 2012-04-16  Philippe Normand  <pnormand@igalia.com>
1766
1767         build-webkit --gtk --no-webkit2 builds WK2
1768         https://bugs.webkit.org/show_bug.cgi?id=83977
1769
1770         Reviewed by Martin Robinson.
1771
1772         * Scripts/build-webkit: Fixup ./configure option to disable
1773         WebKit2 build.
1774
1775 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1776
1777         [EFL] [DRT] Feeding key events with invalid keyName
1778         https://bugs.webkit.org/show_bug.cgi?id=83797
1779
1780         Keep the keyName valid within scope of KeyEventInfo to avoid
1781         feeding key events with invalid keyName.
1782
1783         Reviewed by Philippe Normand.
1784
1785         * DumpRenderTree/efl/EventSender.cpp:
1786         (KeyEventInfo::KeyEventInfo):
1787         (KeyEventInfo):
1788         (keyPadNameFromJSValue):
1789         (keyNameFromJSValue):
1790         (createKeyEventInfo):
1791         (sendKeyDown):
1792
1793 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
1794
1795         [Qt] Replace QtXmlPatterns usage with libxslt dependency
1796         <https://bugs.webkit.org/show_bug.cgi?id=76820>
1797
1798         Reviewed by Simon Hausmann.
1799
1800         The features.prf file was modified, in order to use libxml and libxslt by default.
1801         This modification only work at Qt5.
1802
1803         * qmake/config.tests/libxml2/libxml2.cpp: Added.
1804         (main):
1805         * qmake/config.tests/libxml2/libxml2.pro: Added.
1806         * qmake/config.tests/libxslt/libxslt.cpp: Added.
1807         (main):
1808         * qmake/config.tests/libxslt/libxslt.pro: Added.
1809         * qmake/mkspecs/features/features.prf:
1810         * qmake/sync.profile:
1811
1812 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
1813
1814         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
1815         https://bugs.webkit.org/show_bug.cgi?id=83862
1816
1817         Reviewed by Kenneth Rohde Christiansen.
1818
1819         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
1820         It doesn't work properly because of wrong parameter order in function call.
1821
1822         * EWebLauncher/main.c:
1823
1824 2012-04-16  Philippe Normand  <pnormand@igalia.com>
1825
1826         Unreviewed, GTK gardening.
1827
1828         * Scripts/run-gtk-tests:
1829         (TestRunner): Skip /webkit/atk/textChangedNotifications.
1830
1831 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1832
1833         Chromium perf bots should not build
1834         https://bugs.webkit.org/show_bug.cgi?id=83641
1835
1836         Reviewed by Eric Seidel.
1837
1838         Don't build on perf bots to improve the cycle time.
1839
1840         * BuildSlaveSupport/build.webkit.org-config/config.json:
1841
1842 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
1843
1844         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
1845         https://bugs.webkit.org/show_bug.cgi?id=81945
1846
1847         Reviewed by Dan Bernstein.
1848
1849         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
1850         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
1851         PageCache to be functional.
1852
1853         * WebKitTestRunner/TestController.cpp:
1854         (WTR::TestController::resetStateToConsistentValues):
1855
1856 2012-04-11  James Robinson  <jamesr@chromium.org>
1857
1858         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
1859         https://bugs.webkit.org/show_bug.cgi?id=83733
1860
1861         Reviewed by Adrienne Walker.
1862
1863         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
1864
1865         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1866         (main):
1867         * DumpRenderTree/chromium/TestShell.cpp:
1868         (TestShell::TestShell):
1869         (TestShell::resetWebSettings):
1870         * DumpRenderTree/chromium/TestShell.h:
1871         (TestShell):
1872         * DumpRenderTree/chromium/WebPreferences.cpp:
1873         (WebPreferences::reset):
1874         (WebPreferences::applyTo):
1875         * DumpRenderTree/chromium/WebPreferences.h:
1876         (WebPreferences):
1877
1878 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1879
1880         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
1881         and also rebaseline the test results since we ignore the first run now.
1882
1883         * Scripts/webkitpy/performance_tests/perftest.py:
1884         (PageLoadingPerfTest.run):
1885         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1886         (TestPageLoadingPerfTest.test_run):
1887
1888 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1889
1890         Enable SVG page loading performance tests
1891         https://bugs.webkit.org/show_bug.cgi?id=83861
1892
1893         Reviewed by Adam Barth.
1894
1895         Add support for page loading tests. These are tests without any test running harnesses, and we use
1896         DriverOutput's test_timeout to measure the loading time.
1897
1898         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
1899
1900         * Scripts/webkitpy/performance_tests/perftest.py:
1901         (PerfTest.run):
1902         (PerfTest):
1903         (PerfTest.run_failed):
1904         (PerfTest.parse_output):
1905         (PerfTest.output_statistics):
1906         (ChromiumStylePerfTest.parse_output):
1907         (PageLoadingPerfTest): Added.
1908         (PageLoadingPerfTest.__init__):
1909         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
1910         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
1911         (MockPrinter):
1912         (MockPrinter.__init__):
1913         (MockPrinter.write):
1914         (MainTest):
1915         (MainTest.test_parse_output):
1916         (MainTest.test_parse_output_with_failing_line):
1917         (TestPageLoadingPerfTest):
1918         (TestPageLoadingPerfTest.assertWritten):
1919         (TestPageLoadingPerfTest.MockDriver):
1920         (TestPageLoadingPerfTest.MockDriver.__init__):
1921         (TestPageLoadingPerfTest.MockDriver.run_test):
1922         (TestPageLoadingPerfTest.test_run):
1923         (TestPageLoadingPerfTest.test_run_with_bad_output):
1924         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1925         (PerfTestsRunner):
1926         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
1927         (PerfTestsRunner._collect_tests):
1928         (PerfTestsRunner._run_tests_set):
1929         (PerfTestsRunner._run_single_test):
1930         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1931         (test_collect_tests_with_page_load_svg):
1932         (test_collect_tests_with_page_load_svg.add_file):
1933
1934 2012-04-10  Brady Eidson  <beidson@apple.com>
1935
1936         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
1937         Need WebKit2 API to notify whether history loads are in the page cache
1938
1939         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
1940         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
1941
1942         Reviewed by Darin Adler.
1943
1944         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
1945         (TestWebKitAPI::didFinishLoadForFrame):
1946         (TestWebKitAPI::willGoToBackForwardListItem):
1947         (TestWebKitAPI::setPageLoaderClient):
1948         (TestWebKitAPI::TEST):
1949         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
1950         (ShouldGoToBackForwardListItemTest):
1951         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
1952         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
1953         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1955
1956         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1957         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
1958
1959 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1960
1961         Group EFL bots into a category on the buildbot master
1962         https://bugs.webkit.org/show_bug.cgi?id=82712
1963
1964         Reviewed by Adam Roben.
1965
1966         Creating a new category definition on the buildbot frontend.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1969         (loadBuilderConfig): Determine category for EFL bots
1970         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
1971
1972 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1973
1974         Unreviewed, rolling out r113714.
1975         http://trac.webkit.org/changeset/113714
1976         https://bugs.webkit.org/show_bug.cgi?id=83887
1977
1978         It is behaving strange on the bots and needs more
1979         investigation. (Requested by jeez_ on #webkit).
1980
1981         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1982         (WTR::PlatformWebView::PlatformWebView):
1983
1984 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1985
1986         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
1987         https://bugs.webkit.org/show_bug.cgi?id=83690
1988
1989         Reviewed by Tor Arne Vestbø.
1990
1991         Typing part of an email and pressing <TAB> will bash-complete it using the list in
1992         Tools/Scripts/webkitpy/common/config/committers.py
1993
1994         * Scripts/webkit-tools-completion.sh:
1995
1996 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1997
1998         [EFL] Add API for color chooser
1999         https://bugs.webkit.org/show_bug.cgi?id=83692
2000
2001         Enables INPUT_TYPE_COLOR by default on the EFL port.
2002
2003         Reviewed by Kenneth Rohde Christiansen.
2004
2005         * Scripts/build-webkit:
2006
2007 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2008
2009         Extract PerfTest class from PerfTestRunner
2010         https://bugs.webkit.org/show_bug.cgi?id=83847
2011
2012         Reviewed by Hajime Morita.
2013
2014         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
2015         that was previously represented by a tuple.
2016
2017         Also moved the logic to determine whether a given test is chromium style or not from run() to
2018         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
2019         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
2020         add new types of tests more easily.
2021
2022         * Scripts/webkitpy/performance_tests/perftest.py: Added.
2023         (PerfTest):
2024         (PerfTest.__init__):
2025         (PerfTest.test_name):
2026         (PerfTest.dirname):
2027         (PerfTest.path_or_url):
2028         (PerfTest._should_ignore_line_in_parser_test_result):
2029         (PerfTest.parse_output):
2030         (ChromiumStylePerfTest):
2031         (ChromiumStylePerfTest.__init__):
2032         (ChromiumStylePerfTest.parse_output):
2033         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2034         (PerfTestsRunner._collect_tests):
2035         (PerfTestsRunner.run):
2036         (PerfTestsRunner._run_tests_set):
2037         (PerfTestsRunner._run_single_test):
2038         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2039         (run_test):
2040         (_tests_for_runner):
2041         (test_run_test_set_with_json_output):
2042         (test_run_test_set_with_json_source):
2043         (test_run_test_set_with_multiple_repositories):
2044         (_collect_tests_and_sort_test_name):
2045         (test_collect_tests):
2046         (test_collect_tests_with_skipped_list):
2047
2048 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
2049
2050         [Qt] Fix WebKit1 build with V8
2051         https://bugs.webkit.org/show_bug.cgi?id=83322
2052
2053         Reviewed by Adam Barth.
2054
2055         * DumpRenderTree/qt/DumpRenderTree.pro:
2056         * qmake/mkspecs/features/default_post.prf:
2057         * qmake/mkspecs/features/default_pre.prf:
2058         * qmake/mkspecs/features/features.prf:
2059
2060 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
2061
2062         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
2063         https://bugs.webkit.org/show_bug.cgi?id=83583
2064
2065         Reviewed by Philippe Normand
2066
2067         Updated the unit test to ignore the hours and minutes of the
2068         localtime for time(0), since we can't easily guarantee which
2069         timezone we're in or what timezone rules were in effect on
2070         1/1/1970; this should be mostly fine since we can trust that
2071         time.localtime() will work, although there is the possibility
2072         that we'll screw up the time formatting of which field is the
2073         hours and which is the minutes.
2074
2075         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2076         (VerboseTest):
2077         (VerboseTest.test_basic):
2078         (VerboseTest.test_log_after_update):
2079
2080 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
2081
2082         Add an EFL Debug Buildbot to the master configuration
2083         https://bugs.webkit.org/show_bug.cgi?id=82711
2084
2085         Forgot to add EFL Linux Debug to scheduler.
2086
2087         Reviewed by Philippe Normand.
2088
2089         * BuildSlaveSupport/build.webkit.org-config/config.json:
2090
2091 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2092
2093         Add an EFL Debug Buildbot to the master configuration
2094         https://bugs.webkit.org/show_bug.cgi?id=82711
2095
2096         Reviewed by Philippe Normand.
2097
2098         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
2101
2102 2012-04-12  George Staikos  <staikos@webkit.org>
2103
2104         Enable the fullscreen API for BlackBerry.
2105         https://bugs.webkit.org/show_bug.cgi?id=83757
2106
2107         Reviewed by Antonio Gomes.
2108
2109         * Scripts/build-webkit:
2110
2111 2012-04-12  Simon Pena  <spena@igalia.com>
2112
2113         [GTK] Test runner crashes without recent versions of pulseaudio-utils
2114         https://bugs.webkit.org/show_bug.cgi?id=83774
2115
2116         Reviewed by Philippe Normand.
2117
2118         Besides checking that pactl is available, check also that its output
2119         is the expected one, and handle gracefully when it isn't, when
2120         trying to unload pulseaudio modules.
2121
2122         * Scripts/webkitpy/layout_tests/port/gtk.py:
2123         (GtkPort._unload_pulseaudio_module):
2124         (GtkPort._restore_pulseaudio_module):
2125
2126 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
2127
2128         [Qt] Use QRawFont when building with Qt 5
2129         https://bugs.webkit.org/show_bug.cgi?id=78001
2130
2131         Flip the QRawFont switch for Qt 5.
2132
2133         Reviewed by Simon Hausmann.
2134
2135         * qmake/mkspecs/features/features.prf:
2136
2137 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
2138
2139         Web Inspector: Disabling Inspector causes build failure on Windows
2140         https://bugs.webkit.org/show_bug.cgi?id=83557
2141
2142         Reviewed by Pavel Feldman.
2143
2144         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
2145         This change brings all such API calls under the guard.
2146
2147         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2148         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2149         (WTR):
2150         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2151         (LayoutTestController):
2152         * WebKitTestRunner/TestInvocation.cpp:
2153         (WTR::TestInvocation::invoke):
2154
2155 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
2156
2157         Fix regression introduced in r113927.
2158
2159         Unreviewed, build fix.
2160
2161         I failed to rename skipped_tests() to skipped_layout_tests()
2162         everywhere it needed to be renamed. The unit tests didn't catch
2163         this because the TestPort was one of the places that didn't get
2164         renamed :(.
2165
2166         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2167         (Manager.parse_expectations):
2168         * Scripts/webkitpy/layout_tests/port/test.py:
2169         (TestPort.skipped_layout_tests):
2170         * Scripts/webkitpy/tool/commands/queries.py:
2171         (PrintExpectations._model):
2172
2173 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
2174
2175         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
2176         https://bugs.webkit.org/show_bug.cgi?id=47528
2177
2178         Reviewed by Adam Barth.
2179
2180         The skipped-ports command has been replaced by 'webkit-patch
2181         print-expectations', which offers the equivalent functionality
2182         via 'webkit-patch print-expectations --platform \* -t skip'
2183         (and other features, of course).
2184         
2185         This also allows me to fix a nasty layering violation where the
2186         chromium port had to know about the TestExpectations objects in
2187         order to implement the command properly.
2188
2189         Lastly, this allows me to rename skipped_tests() to
2190         skipped_layout_tests() to more consistent with
2191         skipped_perf_tests().
2192         
2193         This patch removes skips_layout_test() from the Port interface,
2194         because that can't be implemented without the port knowing about
2195         Expectations objects (and skipped-ports was the only thing using it).
2196
2197         * Scripts/webkitpy/layout_tests/port/base.py:
2198         (Port.skipped_layout_tests):
2199         (Port.skipped_perf_tests):
2200         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2201         (PortTest.test_default_configuration_notfound):
2202         * Scripts/webkitpy/layout_tests/port/chromium.py:
2203         (ChromiumPort.test_expectations_overrides):
2204         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2205         (ChromiumPortTest.test_path_to_image_diff):
2206         * Scripts/webkitpy/layout_tests/port/webkit.py:
2207         (WebKitPort.skipped_layout_tests):
2208         * Scripts/webkitpy/tool/commands/queries.py:
2209         (execute):
2210         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2211         (QueryCommandsTest.test_tree_status):
2212
2213 2012-04-11  Mark Rowe  <mrowe@apple.com>
2214
2215         Remove a fprintf from LayoutTestController.
2216
2217         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
2218         It was added for no apparent reason by Ryosuke in r113651.
2219
2220         * DumpRenderTree/LayoutTestController.cpp:
2221         (LayoutTestController::redirectionDestinationForURL):
2222
2223 2012-04-11  Nico Weber  <thakis@chromium.org>
2224
2225         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
2226         https://bugs.webkit.org/show_bug.cgi?id=83709
2227
2228         Reviewed by Anders Carlsson.
2229
2230         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2231         (handleEventCarbon):
2232
2233 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
2234
2235         Adding myself to committers.py
2236         https://bugs.webkit.org/show_bug.cgi?id=83711
2237
2238         Unreviewed update to committers.py.
2239
2240         * Scripts/webkitpy/common/config/committers.py:
2241
2242 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2243
2244         [EFL] LayoutTestController needs implementation of pageProperty
2245         https://bugs.webkit.org/show_bug.cgi?id=82449
2246
2247         Add missing implementation pageProperty to EFL's LayoutTestController
2248         in order to unskip printing/page-rule-selection.html
2249
2250         Reviewed by Antonio Gomes.
2251
2252         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2253         (LayoutTestController::pageProperty):
2254
2255 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2256
2257         Unreviewed, rolling out r113836.
2258         http://trac.webkit.org/changeset/113836
2259         https://bugs.webkit.org/show_bug.cgi?id=83705
2260
2261         Broke all the WebKit2 inspector tests (Requested by andersca
2262         on #webkit).
2263
2264         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2265         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2266         (WTR::LayoutTestController::showWebInspector):
2267         (WTR::LayoutTestController::closeWebInspector):
2268         (WTR::LayoutTestController::evaluateInWebInspector):
2269         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
2270         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2271         (LayoutTestController):
2272         * WebKitTestRunner/TestInvocation.cpp:
2273         (WTR::TestInvocation::invoke):
2274
2275 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
2276
2277         Web Inspector: Disabling Inspector causes build failure on Windows
2278         https://bugs.webkit.org/show_bug.cgi?id=83557
2279
2280         Reviewed by Pavel Feldman.
2281
2282         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
2283         This change brings all such API calls under the guard.
2284
2285         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2286         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2287         (WTR):
2288         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2289         (LayoutTestController):
2290         * WebKitTestRunner/TestInvocation.cpp:
2291         (WTR::TestInvocation::invoke):
2292
2293 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
2294
2295         [Qt][WK2] Manage graphics buffers in the web process
2296         https://bugs.webkit.org/show_bug.cgi?id=78675
2297  
2298         Make graphics surface available only for Qt 5, attempting to fix
2299         the Qt-mac build.
2300
2301         Unreviewed build fix.
2302
2303         * qmake/mkspecs/features/features.prf:
2304
2305 2012-04-11  Philippe Normand  <pnormand@igalia.com>
2306
2307         Unreviewed, GTK NRWT follow-up fix after r113849.
2308
2309         * Scripts/webkitpy/layout_tests/port/gtk.py:
2310         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
2311
2312 2012-04-11  Simon Pena  <spena@igalia.com>
2313
2314         [GTK] media/event-attributes.html fails
2315         https://bugs.webkit.org/show_bug.cgi?id=71662
2316
2317         Reviewed by Philippe Normand.
2318
2319         PulseAudio's module "module-stream-restore" allows saving the volume
2320         of a stream, restoring it the next time it runs.
2321         This affects the tests, since DumpRenderTree's volume settings are
2322         saved between test runs, and tests relying on specific volume values
2323         would miss some volumeChange events (or get additional ones).
2324
2325         This patch hooks on the existing GtkPort setup_test_run method and
2326         creates a new clean_up_test_run method, so PulseAudio's module is
2327         unloaded (if found) before running the tests, and restored (if it
2328         was there previously) after they finished, ensuring the tests run in
2329         the right environment.
2330
2331         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2332         (Manager._clean_up_run): Invoke the port implementation of
2333         clean_up_test_run.
2334         * Scripts/webkitpy/layout_tests/port/base.py:
2335         (Port.clean_up_test_run): Add an empty implementation of
2336         clean_up_test_run.
2337         * Scripts/webkitpy/layout_tests/port/gtk.py:
2338         (GtkPort._unload_pulseaudio_module): Unloads the offending
2339         pulseaudio module, if found.
2340         (GtkPort):
2341         (GtkPort._restore_pulseaudio_module): Restores the offending
2342         pulseaudio module, if it was there previously.
2343         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
2344         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
2345
2346 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
2347
2348         Fix the build with gcc 4.7.0
2349         https://bugs.webkit.org/show_bug.cgi?id=83584
2350
2351         Reviewed by Alexey Proskuryakov.
2352
2353         * qmake/mkspecs/features/unix/default_post.prf:
2354         The -fuse-ld=gold option is not supported with upstream gcc.
2355
2356 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
2357
2358         Refactor PerfTestRunner to include file extensions in test names
2359         https://bugs.webkit.org/show_bug.cgi?id=83677
2360
2361         Reviewed by Hajime Morita.
2362
2363         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
2364
2365         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2366         (PerfTestsRunner._collect_tests):
2367         (PerfTestsRunner._run_tests_set):
2368         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
2369         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
2370         (PerfTestsRunner._run_single_test):
2371         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2372         (run_test):
2373         (_tests_for_runner):
2374         (test_run_test_set):
2375         (test_run_test_set_kills_drt_per_run):
2376         (test_run_test_pause_before_testing):
2377         (test_run_test_set_for_parser_tests):
2378         (test_collect_tests):
2379         (test_collect_tests_with_skipped_list):
2380
2381 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
2382
2383         Web Inspector: Disabling Inspector causes build failure on Windows
2384         https://bugs.webkit.org/show_bug.cgi?id=83557
2385
2386         Reviewed by Pavel Feldman.
2387
2388         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
2389         This change brings all such API calls under the guard.
2390
2391         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2392         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2393         (WTR):
2394         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2395         (LayoutTestController):
2396         * WebKitTestRunner/TestInvocation.cpp:
2397         (WTR::TestInvocation::invoke):
2398
2399 2012-04-10  Kent Tamura  <tkent@chromium.org>
2400
2401         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
2402
2403         * Scripts/webkitpy/common/config/watchlist:
2404         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
2405
2406 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
2407
2408         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
2409         https://bugs.webkit.org/show_bug.cgi?id=82799
2410
2411         Reviewed by Ojan Vafai.
2412
2413         The tests we were skipping in _mark_interrupted_tests_as_skipped
2414         had incorrectly-constructed TestResults, and so they were not
2415         being treated as failures. The JSON generator doesn't record
2416         tests that are passed or skiped in incremental_results, so you
2417         couldn't tell these tests were being skipped at all.
2418
2419         This change changes _mark_interrupted_tests_as_skipped() to
2420         treat the skipped tests as failures; this is arguably still
2421         incorrect but is minimally invasive for now. We probably need to
2422         revisit how we are uploading information about tests that are
2423         skipped and passed altogether in a separate change.
2424
2425         This change also cleans up a couple of other nits that were
2426         unnecessary or broken in this same code path.
2427
2428         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2429         (Manager._mark_interrupted_tests_as_skipped):
2430         (Manager._upload_json_files): Deletes the check for
2431         chromium-mac-leopard (as it is no longer necessary).
2432         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2433         (JSONLayoutResultsGenerator.__init__): Here we were
2434         recalculating the failure type unnecessarily.
2435         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2436         (determine_result_type):
2437         (FailureEarlyExit): Adds a new failure type so we can tell what
2438         happened.
2439         (FailureEarlyExit.message):
2440         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2441         (MainTest.test_exit_after_n_failures_upload): Add more checks to
2442         ensure that we are recording the SKIP correctly; this is less
2443         than ideal, because we can't actually test the contents of
2444         incremental_results.json. We should fix that at some point.
2445
2446 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
2447
2448         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
2449         https://bugs.webkit.org/show_bug.cgi?id=83401
2450
2451         Reviewed by Adam Barth.
2452
2453         Last patch in the series - no longer look in mac-leopard,
2454         mac-snowleopard, or mac-lion.
2455
2456         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2457         (ChromiumMacPort):
2458         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2459
2460 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
2461
2462         webkit-patch: add a print-expectations command
2463         https://bugs.webkit.org/show_bug.cgi?id=83347
2464
2465         Reviewed by Adam Barth.
2466
2467         This command will print the expected results for a given set of
2468         tests on a given set of ports matching a given set of keywords.
2469
2470         Example output (printing all the tests not expected to pass, and their
2471         expected results, on a Mac):
2472
2473         $ webkit-patch print-expectations -x pass fast/html
2474         // For mac-snowleopard
2475         fast/html/details-open4.html = TEXT
2476         fast/html/details-open2.html = TEXT
2477         fast/html/details-no-summary4.html = TEXT
2478         fast/html/details-open-javascript.html = TEXT
2479         $
2480
2481         You can also print full test-expectatons.txt lines using --full and a
2482         CSV-style report (which can be useful for post-processing) using --csv.
2483
2484         It will replace the 'skipped-files' command (which will be
2485         removed in a subsequent patch) and is a more general (and
2486         cleaner and properly layered) solution.
2487
2488         Also add an update() command to MockOptions() to make overriding keywords easier.
2489
2490         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2491         (TestExpectationSerializer.to_string):
2492         (TestExpectationSerializer):
2493         (TestExpectationSerializer.to_csv):
2494         (TestExpectationSerializer._format_result):
2495         (TestExpectationLine.create_passing_expectation):
2496         (TestExpectationsModel.get_test_set_for_keyword):
2497         (TestExpectationsModel.has_keyword):
2498         (TestExpectations.model):
2499         * Scripts/webkitpy/tool/commands/queries.py:
2500         (execute):
2501         (PrintExpectations):
2502         (PrintExpectations.__init__):
2503         (PrintExpectations.execute):
2504         (PrintExpectations._filter_tests):
2505         (PrintExpectations._format_lines):
2506         (PrintExpectations._model):
2507         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2508         (TestPrintExpectations): Added.
2509         * Scripts/webkitpy/tool/mocktool.py:
2510         (MockOptions):
2511         (MockOptions.__init__):
2512         (MockOptions.update): Added.
2513
2514 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
2515
2516         webkitpy: refactor handling of --platform and related options
2517         https://bugs.webkit.org/show_bug.cgi?id=83525
2518
2519         Reviewed by Adam Barth.
2520
2521         This change moves to centralize handling of --platform, --debug,
2522         --gtk, and other similar flags into a central place next to the
2523         code that actually uses those flags in PortFactory to get the
2524         right Port object.
2525
2526         * Scripts/webkitpy/layout_tests/port/__init__.py:
2527         * Scripts/webkitpy/layout_tests/port/factory.py:
2528         (port_options):
2529         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2530         (parse_args):
2531         * Scripts/webkitpy/tool/commands/queries.py:
2532         (PrintBaselines.__init__):
2533
2534 2012-04-10  Ojan Vafai  <ojan@chromium.org>
2535
2536         Add a chromeless view to the individual tests view
2537         https://bugs.webkit.org/show_bug.cgi?id=83541
2538
2539         Reviewed by Daniel Bates.
2540
2541         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
2542
2543         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2544         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2545         (testHtmlForIndividualTestOnAllBuilders):
2546         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
2547         (testHtmlForIndividualTestOnAllBuildersWithChrome):
2548         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
2549         (testHtmlForIndividualTests):
2550         (htmlEscape):
2551         (runTests):
2552
2553 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
2554
2555         remove 'win' from chromium-win, chromium-linux fallback paths
2556         https://bugs.webkit.org/show_bug.cgi?id=83613
2557
2558         Reviewed by Ojan Vafai.
2559
2560         The chromium ports no longer need to look at the apple 'win'
2561         directory for baseline results.
2562
2563         Also remove the old '-gpu-' entries from the flakiness dashboard
2564         map since I'm touching lines nearby.
2565
2566         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2567         (ChromiumLinuxPort):
2568         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2569         (ChromiumWinPort):
2570         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2571
2572 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2573
2574         [Qt][WK2] Manage graphics buffers in the web process
2575         https://bugs.webkit.org/show_bug.cgi?id=78675
2576
2577         Enable graphics surfaces on Mac for Qt.
2578
2579         Reviewed by Kenneth Rohde Christiansen.
2580
2581         * qmake/mkspecs/features/features.prf:
2582
2583 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
2584
2585         [CMake] Enable USE_FOLDERS property
2586         https://bugs.webkit.org/show_bug.cgi?id=83571
2587
2588         Reviewed by Daniel Bates.
2589
2590         Setting the FOLDER property on targets gives more structure
2591         to the generated Visual Studio solutions.
2592         This does not affect other CMake generators.
2593
2594         * DumpRenderTree/efl/CMakeLists.txt:
2595         * EWebLauncher/CMakeLists.txt:
2596         * WinCELauncher/CMakeLists.txt:
2597
2598 2012-04-10  David Dorwin  <ddorwin@chromium.org>
2599
2600         Add Encrypted Media Extensions methods to HTMLMediaElement
2601         https://bugs.webkit.org/show_bug.cgi?id=82971
2602
2603         Reviewed by Adam Barth.
2604
2605         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
2606         Implementation is based on v0.1 of the draft proposal at
2607         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
2608
2609         * DumpRenderTree/chromium/TestShell.cpp:
2610         (TestShell::TestShell):
2611
2612 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
2613
2614         [EFL][DRT] Catch the "title,changed" signal
2615         https://bugs.webkit.org/show_bug.cgi?id=82174
2616
2617         Reviewed by Gustavo Noronha Silva.
2618
2619         EFL's DumpRenderTree now catches the "title,changed" signal, and
2620         prints out the needed information.
2621
2622         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2623         (DumpRenderTreeChrome::onTitleChanged):
2624
2625 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
2626
2627         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
2628         https://bugs.webkit.org/show_bug.cgi?id=82443
2629
2630         Reviewed by Philippe Normand.
2631
2632         EFL's DRT needs to support LayoutTestController's
2633         willSendRequestReturnsNull() and return NULL when expected. This
2634         allows for several tests to be removed from the skip list.
2635
2636         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2637         (DumpRenderTreeChrome::onWillSendRequest):
2638
2639 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2640
2641         [EFL] LayoutTestController needs implementation of addUserStyleSheet
2642         https://bugs.webkit.org/show_bug.cgi?id=82446
2643
2644         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
2645         so that we can unskip related tests from the skip list. 
2646
2647         Reviewed by Antonio Gomes.
2648
2649         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2650         (LayoutTestController::addUserStyleSheet): Implemented.
2651
2652 2012-04-10  Philip Rogers  <pdr@google.com>
2653
2654         Adding myself to committers.py!
2655
2656         Unreviewed update to committers.py.
2657
2658         * Scripts/webkitpy/common/config/committers.py:
2659
2660 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
2661
2662         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
2663         https://bugs.webkit.org/show_bug.cgi?id=82483
2664
2665         Reviewed by Kenneth Rohde Christiansen.
2666
2667         Set window title to default if there is no page title.
2668
2669         * MiniBrowser/qt/BrowserWindow.cpp:
2670         (BrowserWindow::BrowserWindow):
2671         (BrowserWindow::onTitleChanged):
2672         * MiniBrowser/qt/BrowserWindow.h:
2673         (BrowserWindow):
2674
2675 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2676
2677         [Qt][WK2] Implement PageClient::isViewWindowActive()
2678         https://bugs.webkit.org/show_bug.cgi?id=81143
2679
2680         Reviewed by Kenneth Rohde Christiansen.
2681
2682         Fix the WrapperWindow from our PlatformWebView
2683         so it correctly creates the platform related
2684         stuff for QWindow, which is not created unless
2685         QWindow::setVisible() or QWindow::show() are called.
2686
2687         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2688         (WTR::PlatformWebView::PlatformWebView):
2689
2690 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
2691
2692         [Qt][WK2] TestNetscapePlugin is broken
2693         https://bugs.webkit.org/show_bug.cgi?id=83024
2694
2695         Reviewed by Csaba Osztrogonác.
2696
2697         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2698         Fix X11 availability check. embedded is always true with QPA.
2699         * Tools.pro:
2700         Build the test plugin if plugins are enabled for WebKit2.
2701         * qmake/mkspecs/features/features.prf:
2702         * qmake/mkspecs/features/functions.prf:
2703         Added a convenience function to determine availability
2704         of X11 libraries.
2705
2706 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
2707
2708         [WIN] Fix build without precompiled header.
2709
2710         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
2711
2712 2012-04-10  Arko Saha  <arko@motorola.com>
2713
2714         Unreviewed: adding myself to committers.py.
2715
2716         * Scripts/webkitpy/common/config/committers.py:
2717
2718 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2719
2720         Unreviewed: adding myself to committers.py.
2721
2722         * Scripts/webkitpy/common/config/committers.py:
2723
2724 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2725
2726         Unreviewed, rolling out r113656.
2727         http://trac.webkit.org/changeset/113656
2728         https://bugs.webkit.org/show_bug.cgi?id=83542
2729
2730         test is broken on chromium-win (Requested by simonjam on
2731         #webkit).
2732
2733         * DumpRenderTree/chromium/WebViewHost.cpp:
2734         (WebViewHost::dispatchIntent):
2735
2736 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
2737
2738         Update pywebsocket to 0.7.4.
2739         https://bugs.webkit.org/show_bug.cgi?id=83461
2740
2741         Reviewed by Kent Tamura.
2742
2743         This version supports TLS by using ssl in addition to pyOpenSSL.
2744         Other functional difrerences from 0.7.2 are:
2745          - strict Sec-WebSocket-Key validation conforming RFC 4648
2746          - compression ratio logging in debug
2747
2748         * Scripts/webkitpy/thirdparty/__init__.py:
2749         (AutoinstallImportHook._install_pywebsocket):
2750
2751 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2752
2753         add a webkit-patch print-baselines command
2754         https://bugs.webkit.org/show_bug.cgi?id=83348
2755
2756         Reviewed by Adam Barth.
2757
2758         This adds a simple 'print-baselines' command to webkit-patch
2759         that can be used in one of two forms: to print where the
2760         baselines for a given test (or set of tests) on a single port
2761         will be found, or to generate a report for multiple ports.
2762
2763         Example of the former:
2764
2765         $ webkit-patch print-baselines fast/html/keygen.html
2766         // For mac-snowleopard
2767         platform/mac/fast/html/keygen-expected.txt
2768         platform/mac/fast/html/keygen-expected.png
2769         $
2770
2771         The latter is most useful for finding out which fallback dirs are
2772         used by which ports for which tests, for example,
2773         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
2774         No example output is given because the reports are pretty wordy :).
2775
2776         * Scripts/webkitpy/layout_tests/port/base.py:
2777         (Port.baseline_extensions): Added.
2778         (Port.expected_baseline_dict): Added.
2779         * Scripts/webkitpy/tool/commands/queries.py:
2780         (PrintBaselines):
2781         (PrintBaselines.__init__):
2782         (PrintBaselines.execute):
2783         (PrintBaselines._print_baselines):
2784         (PrintBaselines._platform_for_path):
2785
2786 2012-04-09  Florin Malita  <fmalita@chromium.org>
2787
2788         Unreviewed: adding myself to committers.py.
2789
2790         * Scripts/webkitpy/common/config/committers.py:
2791
2792 2012-04-09  Ming Xie  <mxie@rim.com>
2793
2794         [BlackBerry] Allow simulator to use GLES2 acceleration
2795         https://bugs.webkit.org/show_bug.cgi?id=81672
2796
2797         Reviewed by Rob Buis.
2798
2799         * Scripts/webkitdirs.pm:
2800         (blackberryCMakeArguments):
2801
2802 2012-04-09  Dana Jansens  <danakj@chromium.org>
2803
2804         Mark myself as a committer
2805         https://bugs.webkit.org/show_bug.cgi?id=83510
2806
2807         Reviewed by Adrienne Walker.
2808
2809         * Scripts/webkitpy/common/config/committers.py:
2810
2811 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2812
2813         nrwt is failing to upload test results on the chromium-mac-leopard bots
2814         https://bugs.webkit.org/show_bug.cgi?id=83230
2815
2816         Unreviewed, build fix.
2817
2818         It looks like the change in r113399 to use the per-request
2819         timeout variable didn't actually work, so I am removing the
2820         timeout code altogether and counting on the idea that upload
2821         just isn't likely to take that long and the timeouts and
2822         retransmits are largely unused and largely unnecessary. We'll
2823         see if this breaks anywhere else.
2824
2825         * Scripts/webkitpy/common/net/file_uploader.py:
2826         (FileUploader.__init__):
2827         (FileUploader._upload_data.callback):
2828         (FileUploader):
2829
2830 2012-04-09  Rob Buis  <rbuis@rim.com>
2831
2832         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
2833         https://bugs.webkit.org/show_bug.cgi?id=83469
2834
2835         Reviewed by Dirk Schulze.
2836
2837         Remove WTF:: prefixes and fix a warning with the length variable.
2838
2839         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2840         (jsStringRefToWebCoreString):
2841         (LayoutTestController::execCommand):
2842         (LayoutTestController::isCommandEnabled):
2843         (LayoutTestController::setUserStyleSheetLocation):
2844         (LayoutTestController::counterValueForElementById):
2845         (LayoutTestController::overridePreference):
2846         (LayoutTestController::setMockGeolocationError):
2847         (LayoutTestController::findString):
2848
2849 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
2850
2851         Build fix for WinCE after r113570.
2852
2853         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
2854
2855 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
2856
2857         Subscribe eric.carlson@apple.com to Media-related changes
2858         https://bugs.webkit.org/show_bug.cgi?id=83421
2859
2860         Reviewed by Dan Bernstein.
2861
2862         * Scripts/webkitpy/common/config/watchlist:
2863
2864 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
2865
2866         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
2867         https://bugs.webkit.org/show_bug.cgi?id=83412
2868
2869         Reviewed by David Levin.
2870
2871         Accept NULL as an argument for gtk_style_context_get_style, because it's
2872         used as a sentinel in a variable argument list. 
2873
2874         * Scripts/webkitpy/style/checkers/cpp.py:
2875         (check_for_null): Add an exception.
2876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2877         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
2878
2879 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2880
2881         webkitpy: use the filesystem object properly in fileuploader
2882         https://bugs.webkit.org/show_bug.cgi?id=83326
2883
2884         Reviewed by Adam Barth.
2885
2886         We should be using the filesystem object rather than the codecs
2887         object.
2888
2889         * Scripts/webkitpy/common/net/file_uploader.py:
2890         (FileUploader.upload_as_multipart_form_data):
2891
2892 2012-04-09  Eric Seidel  <eric@webkit.org>
2893
2894         Enable webkit_unit_tests for commit queue and EWS while tracking failures
2895         https://bugs.webkit.org/show_bug.cgi?id=83329
2896
2897         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
2898
2899         line 62, in _create_unit_test_results
2900          return UnitTestResults.results_from_string(results_xml)
2901          NameError: global name 'UnitTestResults' is not defined
2902
2903         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2904         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2905         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2906
2907 2012-04-08  Adam Barth  <abarth@webkit.org>
2908
2909         The port object is missing unit_tests_results_path
2910         https://bugs.webkit.org/show_bug.cgi?id=83448
2911
2912         Unreviewed.
2913
2914         This is causing the cr-linux-ews to throw an exception.
2915
2916         * Scripts/webkitpy/common/config/ports.py:
2917         (DeprecatedPort.unit_tests_results_path):
2918
2919 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
2920
2921         [CMake] Cleanup WTF include directories
2922         https://bugs.webkit.org/show_bug.cgi?id=82716
2923
2924         Reviewed by Eric Seidel.
2925
2926         * DumpRenderTree/efl/CMakeLists.txt:
2927         * WinCELauncher/CMakeLists.txt:
2928
2929 2012-04-07  Rob Buis  <rbuis@rim.com>
2930
2931         [BlackBerry] Add Battery Status API support
2932         https://bugs.webkit.org/show_bug.cgi?id=82615
2933
2934         Reviewed by George Staikos.
2935
2936         Enable BATTERY_STATUS.
2937
2938         * Scripts/build-webkit:
2939
2940 2012-04-06  Ami Fischman  <fischman@chromium.org>
2941
2942         Subscribe feature-media-reviews@c.o to Media-related changes.
2943         https://bugs.webkit.org/show_bug.cgi?id=83397
2944
2945         Reviewed by David Levin.
2946
2947         * Scripts/webkitpy/common/config/committers.py:
2948         * Scripts/webkitpy/common/config/watchlist:
2949
2950 2012-04-06  Adrienne Walker  <enne@google.com>
2951
2952         [chromium] Add virtual test suite for threaded compositing
2953         https://bugs.webkit.org/show_bug.cgi?id=82263
2954
2955         Reviewed by James Robinson.
2956
2957         Add compositing/visibility as a virtual test suites to test threaded
2958         compositing with. This is a reasonable smoke test of 9 tests, none of
2959         which have any expectations in the non-threaded case.
2960
2961         To fix many of the remaining tests in this virtual test suite, there
2962         will need to be some serious refactoring to merge the conflict between
2963         the way CCScheduler wants to draw frames and the way DRT also wants to
2964         control things. So, in the short term, enable a few simple tests that
2965         are known to be passing.
2966
2967         * Scripts/webkitpy/layout_tests/port/chromium.py:
2968         (ChromiumPort.virtual_test_suites):
2969
2970 2012-04-06  Enrica Casucci  <enrica@apple.com>
2971
2972         Provide Obj-C private API to simplify markup.
2973         https://bugs.webkit.org/show_bug.cgi?id=83334
2974         <rdar://problem/11033861>
2975
2976         Reviewed by Sam Weinig.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
2980         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
2981         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
2982
2983 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
2984
2985         new-run-webkit-tests: fix bugs in 'mock' drt implementation
2986         https://bugs.webkit.org/show_bug.cgi?id=83341
2987
2988         Reviewed by Eric Seidel.
2989
2990         The current implementation crashed in some circumstances for
2991         reference tests and files that were missing expected results.
2992         This patch fixes those cases and adds more unit tests; it is a
2993         precursor to adding unit tests each port that actually uses this
2994         code, in order to get better coverage of the port/*
2995         implementations.
2996
2997         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2998         (parse_options):
2999         (MockDRT.input_from_line):
3000         (MockDRT.output_for_test):
3001         (MockDRT.run_one_test):
3002         (MockChromiumDRT.input_from_line):
3003         (MockChromiumDRT.output_for_test):
3004         (MockChromiumDRT.run_one_test):
3005         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3006         (MockDRTTest.make_input_output):
3007         (MockDRTTest.expected_output):
3008         (MockDRTTest):
3009         (MockDRTTest.assertTest):
3010         (MockDRTTest.test_missing_image):
3011         (MockDRTTest.test_missing_text):
3012         (MockDRTTest.test_reftest_match):
3013         (MockDRTTest.test_reftest_mismatch):
3014         (MockChromiumDRTTest.expected_output):
3015
3016 2012-04-06  James Robinson  <jamesr@chromium.org>
3017
3018         Enable webkit_unit_tests for commit queue and EWS while tracking failures
3019         https://bugs.webkit.org/show_bug.cgi?id=83329
3020
3021         Reviewed by Adam Barth.
3022
3023         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
3024         the commit queue and EWS can reject patches that cause regressions.
3025
3026         * Scripts/webkitpy/common/config/ports.py:
3027         (ChromiumPort.run_webkit_unit_tests_command):
3028         * Scripts/webkitpy/common/config/ports_mock.py:
3029         (MockPort.unit_tests_results_path):
3030         * Scripts/webkitpy/common/net/layouttestresults.py:
3031         (LayoutTestResults.__init__):
3032         (LayoutTestResults.failing_tests):
3033         (LayoutTestResults):
3034         (LayoutTestResults.add_unit_test_failures):
3035         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
3036         (UnitTestResults):
3037         (UnitTestResults.results_from_string):
3038         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
3039         (UnitTestResultsTest):
3040         (UnitTestResultsTest.test_nostring):
3041         (UnitTestResultsTest.test_emptystring):
3042         (UnitTestResultsTest.test_nofailures):
3043         (test_onefailure):
3044         (test_multiple_failures_per_test):
3045         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3046         (MockCommitQueue.test_results):
3047         (MockCommitQueue.archive_last_test_results):
3048         (FailingTestCommitQueue.test_results):
3049         (test_flaky_test_failure):
3050         (test_failed_archive):
3051         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3052         (LayoutTestResultsReader._create_unit_test_results):
3053         (LayoutTestResultsReader.results):
3054         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3055         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3056         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3057         (PatchAnalysisTaskDelegate.test_results):
3058         (PatchAnalysisTaskDelegate.archive_last_test_results):
3059         (PatchAnalysisTask._test):
3060         (PatchAnalysisTask._build_and_test_without_patch):
3061         (PatchAnalysisTask._test_patch):
3062         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3063         (AbstractEarlyWarningSystem.test_results):
3064         (AbstractEarlyWarningSystem.archive_last_test_results):
3065         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3066         (EarlyWarningSytemTest._test_testing_ews):
3067         * Scripts/webkitpy/tool/commands/queues.py:
3068         (CommitQueue.test_results):
3069         (CommitQueue.archive_last_test_results):
3070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3071         (CommitQueueTest.test_commit_queue):
3072         (test_rollout):
3073         (test_manual_reject_during_processing):
3074         * Scripts/webkitpy/tool/steps/runtests.py:
3075         (RunTests.run):
3076         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3077         (RunTestsTest.test_webkit_run_unit_tests):
3078
3079 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
3080
3081         Enable MediaSource feature for DumpRenderTree so
3082         MediaSource LayoutTests will pass for Chromium.
3083         https://bugs.webkit.org/show_bug.cgi?id=83053
3084
3085         Reviewed by Dimitri Glazkov.
3086
3087         * DumpRenderTree/chromium/TestShell.cpp:
3088         (TestShell::TestShell):
3089
3090 2012-04-06  George Staikos  <staikos@webkit.org>
3091
3092         Turn on vibration support for BlackBerry.
3093
3094         Reviewed by Rob Buis.
3095
3096         * Scripts/build-webkit:
3097
3098 2012-04-06  Dan Bernstein  <mitz@apple.com>
3099
3100         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
3101
3102         Reviewed by Sam Weinig.
3103
3104         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
3105
3106 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
3107
3108         nrwt is failing to upload test results on the chromium-mac-leopard bots
3109         https://bugs.webkit.org/show_bug.cgi?id=83230
3110
3111         Reviewed by Ojan Vafai.
3112
3113         This should fix things properly; FileUploader() was setting the
3114         socket default timeout value, and apparently that doesn't work
3115         properly with urllib. Also, the class had a bad try/finally
3116         block that was causing the exceptions to be swallowed :(.
3117
3118         * Scripts/webkitpy/common/net/file_uploader.py:
3119         (FileUploader.__init__):
3120         (FileUploader._upload_data.callback):
3121         (FileUploader):
3122         (FileUploader._upload_data):
3123         * Scripts/webkitpy/common/net/networktransaction.py:
3124         (NetworkTimeout.__str__):
3125         (NetworkTransaction.run):
3126         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3127         (JSONResultsGeneratorBase.upload_json_files):
3128
3129 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
3130
3131         [Qt] Correct <wtf/*.h> include paths.
3132         https://bugs.webkit.org/show_bug.cgi?id=83270
3133
3134         Reviewed by Eric Seidel.
3135
3136         Modify the #include declerations so that the
3137         wtf types are included using the full path.
3138
3139         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3140
3141 2012-04-05  Philippe Normand  <pnormand@igalia.com>
3142
3143         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
3144         https://bugs.webkit.org/show_bug.cgi?id=83176
3145
3146         Reviewed by Tony Chang.
3147
3148         Refactored the test to use os.path.join() to specify the
3149         core_pattern value of the empty crash log mock.
3150
3151         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3152         (GtkPortTest):
3153         (GtkPortTest.assertLinesEqual):
3154         (GtkPortTest.test_get_crash_log):
3155         (_mock_gdb_output):
3156
3157 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
3158
3159         [Qt] Fix includes after QtDeclarative -> QtQML renaming
3160         https://bugs.webkit.org/show_bug.cgi?id=82195
3161
3162         Relanding r112651, because Qt5 is updated everywhere.
3163
3164         * MiniBrowser/qt/BrowserWindow.cpp:
3165         (BrowserWindow::updateVisualMockTouchPoints):
3166         * MiniBrowser/qt/main.cpp:
3167         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3168         (WTR::WrapperWindow::handleStatusChanged):
3169         * qmake/mkspecs/features/unix/default_post.prf:
3170
3171 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
3172
3173         [Qt] WK1/WK2 layout test results are diverging
3174         https://bugs.webkit.org/show_bug.cgi?id=82720
3175
3176         The resolving of default font families was altered in Qt5.
3177         This directly affects the font picked by DRT for layout
3178         tests. Since we want to keep the Qt4 and Qt5 results in line,
3179         we can trick DRT in picking the same font as before for now.
3180
3181         Reviewed by Csaba Osztrogonác.
3182
3183         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3184         (WebKit::initializeTestFonts):
3185
3186 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
3187
3188         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
3189         https://bugs.webkit.org/show_bug.cgi?id=82592
3190
3191         Reviewed by David Levin.
3192
3193         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
3194
3195         * DumpRenderTree/chromium/EventSender.cpp:
3196         (EventSender::beginDragWithFiles):
3197
3198 2012-04-04  Tim Horton  <timothy_horton@apple.com>
3199
3200         [mac] WKTR should always keep its windows offscreen
3201         https://bugs.webkit.org/show_bug.cgi?id=83244
3202         <rdar://problem/11188764>
3203
3204         Reviewed by Simon Fraser.
3205
3206         We don't want to allow windows onto the main display; intercept attempts to
3207         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
3208
3209         Also keep around and respond with a new "fake" origin, in case someone is
3210         expecting it to change (I couldn't find any tests that expected this, however).
3211
3212         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3213         (-[WebKitTestRunnerWindow setFrameOrigin:]):
3214         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
3215         (-[WebKitTestRunnerWindow setFrame:display:]):
3216         (-[WebKitTestRunnerWindow frame]):
3217
3218 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
3219
3220         Fix typo introduced in r113271.
3221
3222         Unreviewed, build fix.
3223
3224         * Scripts/webkitpy/common/net/file_uploader.py:
3225         (FileUploader._upload_data.callback):
3226         (FileUploader):
3227
3228 2012-04-04  Scott Graham  <scottmg@google.com>
3229
3230         [Chromium, DRT] Bounds check indices on gamepadController
3231         https://bugs.webkit.org/show_bug.cgi?id=83192
3232
3233         Invalid test data would cause bad array accesses. Add simple checks to
3234         ignore such invalid data.
3235
3236         Reviewed by Kent Tamura.
3237
3238         * DumpRenderTree/chromium/GamepadController.cpp:
3239         (GamepadController::connect):
3240         (GamepadController::disconnect):
3241         (GamepadController::setId):
3242         (GamepadController::setButtonCount):
3243         (GamepadController::setButtonData):
3244         (GamepadController::setAxisCount):
3245         (GamepadController::setAxisData):
3246
3247 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
3248
3249         nrwt is failing to upload test results on the chromium-mac-leopard bots
3250         https://bugs.webkit.org/show_bug.cgi?id=83230
3251
3252         Reviewed by Ojan Vafai.
3253
3254         More debugging info and a possible fix - stop messing with the
3255         default network timeout, and don't swallow URLErrors.
3256
3257         * Scripts/webkitpy/common/net/file_uploader.py:
3258         (FileUploader._upload_data):
3259         * Scripts/webkitpy/common/net/networktransaction.py:
3260         (NetworkTransaction.run):
3261         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3262         (JSONResultsGeneratorBase.upload_json_files):
3263
3264 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
3265
3266         nrwt is failing to upload test results on the chromium-mac-leopard bots
3267         https://bugs.webkit.org/show_bug.cgi?id=83230
3268
3269         Reviewed by Ojan Vafai.
3270
3271         * Scripts/webkitpy/common/net/file_uploader.py:
3272         (FileUploader.__init__):
3273         (FileUploader._upload_data.callback):
3274         (FileUploader):
3275         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3276         (Manager._upload_json_files):
3277         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3278         (JSONResultsGeneratorBase.upload_json_files):
3279
3280 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3281
3282         WKTR needs to implement layoutTestController.setPageVisibility()
3283         https://bugs.webkit.org/show_bug.cgi?id=69554
3284
3285         Reviewed by Simon Fraser.
3286
3287         This patch implements the layoutTestController.setPageVisibility
3288         so WKTR supports the Page Visibility API implementation by using InjectedBundle
3289         to set the visibility state directly to Page.
3290
3291         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3292         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3293         (WTR::LayoutTestController::setPageVisibility):
3294         (WTR):
3295         (WTR::LayoutTestController::resetPageVisibility):
3296         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3297         (LayoutTestController):
3298
3299 2012-04-04  Adam Barth  <abarth@webkit.org>
3300
3301         [Chromium] TestWebKitAPI links in WebCore twice
3302         https://bugs.webkit.org/show_bug.cgi?id=83177
3303
3304         Reviewed by Dimitri Glazkov.
3305
3306         This is causing link errors in the Windows component build. This patch
3307         moves the dependencies a bit lower down in the dependency diagram in
3308         the hopes of removing the duplicate symbols.
3309
3310         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3311
3312 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
3313
3314         [EFL][DRT] Catch the "resource,request,willsend" signal
3315         https://bugs.webkit.org/show_bug.cgi?id=82192
3316
3317         Reviewed by Gustavo Noronha Silva.
3318
3319         EFL's DumpRenderTree now catches the "resource,request,willsend"
3320         signal in order to implement the "Blocked access to external URL"
3321         behavior and avoid potential network-related timeouts in the tests.
3322
3323         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3324         (DumpRenderTreeChrome::createView):
3325         (DumpRenderTreeChrome::onWillSendRequest):
3326         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3327         (DumpRenderTreeChrome):
3328
3329 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
3330
3331         [EFL][DRT] Correct <wtf/*.h> include paths.
3332         https://bugs.webkit.org/show_bug.cgi?id=83168
3333
3334         Reviewed by Eric Seidel.
3335
3336         Modify the #include declarations so that the 
3337         wtf types are included using the full path.
3338
3339         * DumpRenderTree/efl/DumpRenderTree.cpp:
3340
3341 2012-04-04  Philippe Normand  <pnormand@igalia.com>
3342
3343         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
3344         https://bugs.webkit.org/show_bug.cgi?id=83176
3345
3346         Reviewed by Tony Chang.
3347
3348         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3349         (test_get_crash_log): Skip the test on non-linux platforms.
3350
3351 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3352
3353         [EFL] DRT support for computedStyleIncludingVisitedInfo
3354         https://bugs.webkit.org/show_bug.cgi?id=82190
3355
3356         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
3357         LayoutTestController so that we can unskip related tests from the skip list.
3358
3359         Reviewed by Antonio Gomes.
3360
3361         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3362         (LayoutTestController::computedStyleIncludingVisitedInfo):
3363
3364 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
3365
3366         Unreviewed; update my email address once again in the committers
3367         and watch list.
3368
3369         * Scripts/webkitpy/common/config/committers.py: Prefer my
3370         webkit.org email over my FreeBSD.org one.
3371         * Scripts/webkitpy/common/config/watchlist: Ditto.
3372
3373 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3374
3375         [Qt][WK2] QtWebKit2 should support Page Visibility API
3376         https://bugs.webkit.org/show_bug.cgi?id=81164
3377
3378         Reviewed by Kenneth Rohde Christiansen.
3379
3380         Enabling Page Visiblity API for Qt WebKit2.
3381
3382         * qmake/mkspecs/features/features.prf:
3383
3384 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
3385
3386         [Qt][WK2] Make the WebView a subclass of Flickable
3387         https://bugs.webkit.org/show_bug.cgi?id=83033
3388
3389         Reviewed by Kenneth Rohde Christiansen.
3390
3391         Remove workaround in MiniBrowser and the ScrollIndicator
3392         now that the WebView is a Flickable.
3393
3394         * MiniBrowser/qt/MiniBrowser.pro:
3395         * MiniBrowser/qt/qml/BrowserWindow.qml:
3396         * MiniBrowser/qt/qml/ScrollIndicator.qml:
3397         * WebKitTestRunner/Target.pri:
3398
3399 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
3400
3401         REGRESSION(r113144): It made run-webkit-tests always fail
3402         https://bugs.webkit.org/show_bug.cgi?id=83142
3403
3404         Unreviewed trivial fix after r113144.
3405
3406         * Scripts/run-webkit-tests:
3407
3408 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3409
3410         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
3411         double quotations on Windows. Use system instead.
3412
3413         Hopefully, this won't break anything.
3414
3415         * Scripts/run-webkit-tests:
3416
3417 2012-04-03  Keishi Hattori  <keishi@webkit.org>
3418
3419         Disable ENABLE_DATALIST for now
3420         https://bugs.webkit.org/show_bug.cgi?id=82871
3421
3422         Reviewed by Kent Tamura.
3423
3424         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
3425
3426 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3427
3428         Sigh... this isn't going well. I can't even reproduce this issue locally.
3429         Another speculative fix.
3430
3431         * Scripts/run-webkit-tests:
3432
3433 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3434
3435         I don't know why I'm so sloppy today. Another build fix.
3436
3437         * Scripts/run-webkit-tests:
3438
3439 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3440
3441         Hopefully the last build fix for Chromium Windows.
3442
3443         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
3444
3445         * Scripts/run-webkit-tests:
3446
3447 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
3448
3449         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
3450         https://bugs.webkit.org/show_bug.cgi?id=83076
3451
3452         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
3453
3454         Add logic to the apple mac and chromium mac code to not use
3455         too many workers; it looks like the xserves (and possibly mac
3456         pros) count hyperthreaded cores when they really shouldn't and
3457         we end up using too many workers at a time; this leads to tests
3458         thrashing and timing out.
3459
3460         This change is a temporary fix to make the bots happy while I
3461         look into more profiling and other fixes.
3462
3463         * Scripts/webkitpy/layout_tests/port/mac.py:
3464         (ChromiumMacPort.default_child_processes):
3465
3466         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3467         (ChromiumMacPort.default_child_processes):
3468
3469 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
3470
3471         WebKitTestRunner's EventSender is leaky
3472         https://bugs.webkit.org/show_bug.cgi?id=83099
3473
3474         Reviewed by Beth Dakin.
3475         
3476         Fix leaks of WKNumbers by using the adoptWK idiom, and make
3477         all the code consistent.
3478
3479         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3480         (WTR::EventSendingController::mouseDown):
3481         (WTR::EventSendingController::mouseUp):
3482         (WTR::EventSendingController::mouseMoveTo):
3483         (WTR::EventSendingController::leapForward):
3484         (WTR::EventSendingController::keyDown):
3485         (WTR::EventSendingController::mouseScrollBy):
3486         (WTR::EventSendingController::addTouchPoint):
3487         (WTR::EventSendingController::updateTouchPoint):
3488         (WTR::EventSendingController::setTouchModifier):
3489         (WTR::EventSendingController::releaseTouchPoint):
3490         (WTR::EventSendingController::cancelTouchPoint):
3491
3492 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3493
3494         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
3495
3496         * Scripts/run-webkit-tests:
3497         (useNewRunWebKitTests):
3498
3499 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3500
3501         kill-old-processes should kill apache2 and httpd
3502         https://bugs.webkit.org/show_bug.cgi?id=83065
3503
3504         Reviewed by Tony Chang.
3505
3506         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
3507
3508         * BuildSlaveSupport/kill-old-processes:
3509
3510 2012-04-03  Tony Chang  <tony@chromium.org>
3511
3512         run the same test steps on test only bots as on build-and-test bots
3513         https://bugs.webkit.org/show_bug.cgi?id=83090
3514
3515         Reviewed by Ryosuke Niwa.
3516
3517         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3518         (TestFactory.__init__):
3519
3520 2012-04-03  Ami Fischman  <fischman@chromium.org>
3521
3522         Add a Media watchlist.
3523         https://bugs.webkit.org/show_bug.cgi?id=83071
3524
3525         Reviewed by David Levin.
3526
3527         * Scripts/webkitpy/common/config/watchlist:
3528
3529 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
3530
3531         Fix large leak in WebKitTestRunner
3532         https://bugs.webkit.org/show_bug.cgi?id=83084
3533
3534         Reviewed by Beth Dakin.
3535         
3536         Fix a leak of the bimap backing store created when doing pixel and
3537         ref tests. This leak was causing serious thrash on the test bots.
3538         
3539         We don't need to allocate memory for CGBitmapContextCreate(); if we
3540         pass NULL, it will allocate and manage its own backing store.
3541
3542         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3543         (WTR::createCGContextFromImage):
3544
3545 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3546
3547         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
3548
3549         * BuildSlaveSupport/built-product-archive:
3550         (unzipArchive):
3551
3552 2012-04-03  Ojan Vafai  <ojan@chromium.org>
3553
3554         Give more human friendly error message when builders fail to load or have stale data.
3555         https://bugs.webkit.org/show_bug.cgi?id=83058
3556
3557         Reviewed by Eric Seidel.
3558
3559         * TestResultServer/static-dashboards/dashboard_base.js:
3560         (addError):
3561         (addBuilderLoadErrors):
3562         (handleLocationChange):
3563         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3564
3565 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3566
3567         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
3568
3569         * BuildSlaveSupport/built-product-archive:
3570         (extractBuiltProduct):
3571
3572 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3573
3574         Yet another build fix after r113067. Don't trigger Chromium testers right away
3575         since they're now triggered by builders.
3576
3577         * BuildSlaveSupport/build.webkit.org-config/config.json:
3578
3579 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3580
3581         Another build fix after r113067 for Mac port.
3582         It turned out that archiving the entire build directory doesn't work.
3583
3584         * BuildSlaveSupport/built-product-archive:
3585         (createZipManually):
3586         (createZip):
3587         (archiveBuiltProduct):
3588
3589 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
3590
3591         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
3592         https://bugs.webkit.org/show_bug.cgi?id=82643
3593
3594         Update LayoutTestController to accomodate the new find API.
3595         It now provides caseSensitive functionality to DRT.
3596
3597         Internal Review by Andy Chen.
3598
3599         Reviewed by Rob Buis.
3600
3601         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3602         (LayoutTestController::findString):
3603
3604 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3605
3606         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
3607         because download-built-product creates the build directory as needed.
3608
3609         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3612         (TestFactory.__init__):
3613
3614 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3615
3616         Build fix after r113067. Don't delete the build directory.
3617
3618         * BuildSlaveSupport/built-product-archive:
3619         (extractBuiltProduct):
3620
3621 2012-04-02  Ojan Vafai  <ojan@chromium.org>
3622
3623         Load all builder lists from the buildbot json
3624         https://bugs.webkit.org/show_bug.cgi?id=82998
3625
3626         Reviewed by Adam Barth.
3627
3628         Also, remove an unnecessary list of test types. Now we don't hard-code
3629         builder names anywhere and we only have a single hard-coded list of
3630         test types.
3631
3632         * TestResultServer/static-dashboards/builders.js:
3633         (BuilderMaster.prototype.logPath):
3634         (BuilderMaster.prototype.builderJsonPath):
3635         (requestBuilderList.xhr.onload):
3636         (requestBuilderList.xhr.onerror):
3637         (isChromiumDepsFyiGpuTestRunner):
3638         (isChromiumTipOfTreeGpuTestRunner):
3639         (isChromiumDepsGTestRunner):
3640         (isChromiumDepsCrosGTestRunner):
3641         (isChromiumTipOfTreeGTestRunner):
3642         (onBuilderListLoad):
3643         (loadBuildersList):
3644         * TestResultServer/static-dashboards/dashboard_base.js:
3645         (parseCrossDashboardParameters):
3646         (currentBuilderGroupCategory):
3647         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3648         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3649         (testHtmlForTestsWithExpectationsButNoFailures):
3650         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
3651         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
3652         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
3653         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
3654         * TestResultServer/static-dashboards/timeline_explorer.html:
3655
3656 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
3657
3658         Chromium testers should extract builds instead of building on their own
3659         https://bugs.webkit.org/show_bug.cgi?id=82996
3660
3661         Reviewed by Tony Chang.
3662
3663         Make Chromium builders triggger Chromium testers and make testers download and extract builds
3664         from the buildbot master instead of building binaries on their own.
3665
3666         Add download-built-product to wrap curl used in the download-built-product step since Windows
3667         does not provide "curl" natively.
3668
3669         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
3670         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
3671         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3672         (DownloadBuiltProduct): Call download-built-product instead of curl.
3673         * BuildSlaveSupport/built-product-archive:
3674         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
3675         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
3676         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
3677         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
3678         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
3679         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
3680
3681 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
3682
3683         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
3684         https://bugs.webkit.org/show_bug.cgi?id=82473
3685
3686         Reviewed by Philippe Normand.
3687
3688         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
3689         was ever run.
3690
3691         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
3692         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
3693
3694 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3695
3696 &nb