3df9ec9b93e44e7b5ac9b6011b75ca0ed48197ed
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-02  Jer Noble  <jer.noble@apple.com>
2
3         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
4         https://bugs.webkit.org/show_bug.cgi?id=199381
5         <rdar://problem/52483103>
6
7         Reviewed by Eric Carlson.
8
9         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
10
11 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-build] Update bot configuration for WPE and GTK
14         https://bugs.webkit.org/show_bug.cgi?id=199238
15
16         Reviewed by Michael Catanzaro.
17
18         * BuildSlaveSupport/ews-build/config.json:
19
20 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
21
22         [ews-build] Make PrintConfiguration platform aware
23         https://bugs.webkit.org/show_bug.cgi?id=196657
24
25         Reviewed by Lucas Forschler.
26
27         * BuildSlaveSupport/ews-build/steps.py:
28         (PrintConfiguration): Specified platform-specific command lists.
29         (PrintConfiguration.run): Override run method and specify platform specific commands.
30         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
31
32 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
33
34         [Wasm-References] Disable references by default
35         https://bugs.webkit.org/show_bug.cgi?id=199390
36
37         Reviewed by Saam Barati.
38
39         * Scripts/run-jsc-stress-tests:
40
41 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
42
43         Unreviewed. Revert r246965 to fix build break
44         since r247019 reverted its related changes.
45
46         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
47         (WTR::AccessibilityUIElement::popupValue const): Deleted.
48
49 2019-07-01  Alex Christensen  <achristensen@webkit.org>
50
51         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
52         https://bugs.webkit.org/show_bug.cgi?id=199371
53         <rdar://problem/52352905>
54
55         Reviewed by Tim Horton.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
58         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
59         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
60         (-[NavigationActionSPIDelegate spiCalled]):
61         (TEST):
62
63 2019-07-01  Alex Christensen  <achristensen@webkit.org>
64
65         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
66         https://bugs.webkit.org/show_bug.cgi?id=199296
67         <rdar://problem/51041960>
68
69         Reviewed by Darin Adler.
70
71         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
72         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
73
74 2019-07-01  Truitt Savell  <tsavell@apple.com>
75
76         Unreviewed, rolling out r246958.
77
78         Broke inspector/dom/getAccessibilityPropertiesForNode.html
79
80         Reverted changeset:
81
82         "Enhance support of aria-haspopup per ARIA 1.1 specification."
83         https://bugs.webkit.org/show_bug.cgi?id=199216
84         https://trac.webkit.org/changeset/246958
85
86 2019-07-01  Philippe Normand  <pnormand@igalia.com>
87
88         Unreviewed, GTK a11y tests fix after r246958
89
90         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
91         (WTR::AccessibilityUIElement::popupValue const):
92
93 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
94
95         Enhance support of aria-haspopup per ARIA 1.1 specification.
96         https://bugs.webkit.org/show_bug.cgi?id=199216
97         <rdar://problem/46221342>
98
99         Reviewed by Chris Fleizach.
100
101         * DumpRenderTree/AccessibilityUIElement.cpp:
102         (getPopupValueCallback):
103         (AccessibilityUIElement::getJSClass):
104         * DumpRenderTree/AccessibilityUIElement.h:
105         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
106         (AccessibilityUIElement::popupValue const):
107         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
108         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
109         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
110         (WTR::AccessibilityUIElement::popupValue const):
111         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
112         (WTR::AccessibilityUIElement::popupValue const):
113
114 2019-06-28  Robin Morisset  <rmorisset@apple.com>
115
116         Adding myself as a reviewer to contributors.json.
117
118         Unreviewed.
119
120         * Scripts/webkitpy/common/config/contributors.json:
121
122 2019-06-28  Jer Noble  <jer.noble@apple.com>
123
124         Add new -[WKWebView _closeAllMediaPresentations] SPI
125         https://bugs.webkit.org/show_bug.cgi?id=199294
126         <rdar://problem/51965958>
127
128         Reviewed by Alex Christensen.
129
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
131         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
132         (TEST):
133
134 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
135
136         Add a regression test for change r246901
137         https://bugs.webkit.org/show_bug.cgi?id=199290
138
139         Reviewed by Geoffrey Garen.
140
141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
142         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
143         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
144         (TEST):
145         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
146
147 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
148
149         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
150         https://bugs.webkit.org/show_bug.cgi?id=199317
151
152         Reviewed by Michael Catanzaro.
153
154         While IconDatabase and all code using it was removed,
155         ENABLE_ICONDATABASE still exists as build option and C++ macro.
156
157         * Scripts/webkitperl/FeatureList.pm:
158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
159         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
160         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
161
162 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
163
164         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
165         https://bugs.webkit.org/show_bug.cgi?id=199310
166         <rdar://problem/52292137>
167
168         Reviewed by Megan Gardner.
169
170         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
171         _elementDidFocus.
172
173         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
174         (TestWebKitAPI::TEST):
175         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
176         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
177         (-[TestInputDelegate setDidStartInputSessionHandler:]):
178         (-[TestInputDelegate didStartInputSessionHandler]):
179
180         Add plumbing for a handler block in TestInputDelegate.
181
182         (-[TestInputDelegate setWillStartInputSessionHandler:]):
183
184         Drive-by style fixes to add a space between id and < for Objective-C protocols.
185
186         (-[TestInputDelegate willStartInputSessionHandler]):
187         (-[TestInputDelegate _webView:willStartInputSession:]):
188         (-[TestInputDelegate _webView:didStartInputSession:]):
189         * TestWebKitAPI/cocoa/TestWKWebView.h:
190         * TestWebKitAPI/ios/UIKitSPI.h:
191
192         Add a declaration for _selectionClipRects.
193
194 2019-06-27  Zalan Bujtas  <zalan@apple.com>
195
196         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
197         https://bugs.webkit.org/show_bug.cgi?id=199303
198         <rdar://problem/51340927>
199
200         Reviewed by Tim Horton.
201
202         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
203         (TEST):
204
205 2019-06-27  Beth Dakin  <bdakin@apple.com>
206
207         Upstream use of MACCATALYST
208         https://bugs.webkit.org/show_bug.cgi?id=199245
209         rdar://problem/51687723
210
211         Reviewed by Tim Horton.
212
213         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
214         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
215         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
216         * MiniBrowser/Configurations/SDKVariant.xcconfig:
217         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
218         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
219         (JavaScriptCoreGenerator):
220         (WebCoreGenerator):
221         (WebKitGenerator):
222         * TestWebKitAPI/Configurations/Base.xcconfig:
223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
224         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
225         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
226         * WebEditingTester/Configurations/SDKVariant.xcconfig:
227         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
228         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
229         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
230
231 2019-06-27  Saam Barati  <sbarati@apple.com>
232
233         Make WEBGPU enabled only on Mojave and later.
234
235         Rubber-stamped by Myles C. Maxfield.
236
237         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
238
239 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
240
241         [ews-build] Do not print worker environment variables in each build step
242         https://bugs.webkit.org/show_bug.cgi?id=197319
243
244         Reviewed by Lucas Forschler.
245
246         * BuildSlaveSupport/ews-build/steps.py:
247         (CheckOutSource.__init__): Disabled logging of environment variables.
248         (ApplyPatch.__init__): Ditto.
249         (KillOldProcesses.__init__): Ditto.
250         (ArchiveBuiltProduct.__init__): Ditto.
251         (DownloadBuiltProduct.__init__): Ditto.
252         (ExtractBuiltProduct.__init__): Ditto.
253         (RunAPITests.__init__): Ditto.
254         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
255
256 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
257
258         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
259         https://bugs.webkit.org/show_bug.cgi?id=199232
260         <rdar://problem/51718328>
261
262         Reviewed by Youenn Fablet.
263
264         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
265         (TestWebKitAPI::TEST):
266         Add a test that utilizes TCPServer as local files always omit referrer.
267
268 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
269
270         [ews-build] Add configuration and architecture for WPE and GTK builders
271         https://bugs.webkit.org/show_bug.cgi?id=199249
272
273         Reviewed by Jonathan Bedard.
274
275         * BuildSlaveSupport/ews-build/config.json:
276
277 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
278
279         [ews-build] Add check for duplicate workers in config.json
280         https://bugs.webkit.org/show_bug.cgi?id=199240
281
282         Reviewed by Jonathan Bedard.
283
284         * BuildSlaveSupport/ews-build/loadConfig.py:
285         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
286         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
287         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
288
289 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
290
291         [Win] MiniBrowser should make better font choices
292         https://bugs.webkit.org/show_bug.cgi?id=199244
293
294         Reviewed by Brent Fulgham.
295
296         * MiniBrowser/win/MainWindow.cpp:
297         (MainWindow::updateDeviceScaleFactor):
298         * MiniBrowser/win/MiniBrowserLib.rc:
299
300 2019-06-26  Alex Christensen  <achristensen@webkit.org>
301
302         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
303         https://bugs.webkit.org/show_bug.cgi?id=199230
304         <rdar://51757107>
305
306         Reviewed by Andy Estes.
307
308         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
309         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
310         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
311         * WebKitTestRunner/TestController.cpp:
312         (WTR::TestController::generatePageConfiguration):
313         (WTR::TestController::createWebViewWithOptions):
314         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
315         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
316         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
317         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
318         * WebKitTestRunner/TestController.h:
319         * WebKitTestRunner/TestInvocation.cpp:
320         (WTR::TestInvocation::invoke):
321         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
322
323 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
324
325         [Win][MiniBrowser] Remove obsolete code after r246814.
326         https://bugs.webkit.org/show_bug.cgi?id=199233
327
328         Reviewed by Fujii Hironori.
329
330         * MiniBrowser/win/MiniBrowserWebHost.cpp:
331         (MiniBrowserWebHost::didFinishLoadForFrame):
332         (SimpleEventListener::SimpleEventListener): Deleted.
333         (SimpleEventListener::handleEvent): Deleted.
334
335 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
336
337         Implement a new SPI to inform clients about AppSSO
338         https://bugs.webkit.org/show_bug.cgi?id=199085
339         <rdar://problem/50028246>
340
341         Reviewed by Geoffrey Garen.
342
343         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
344         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
345         (-[TestSOAuthorizationNavigationDelegate init]):
346         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
347         (TestWebKitAPI::TEST):
348
349 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
350
351         [ews-build] Retry Layout test in case of failures
352         https://bugs.webkit.org/show_bug.cgi?id=199194
353
354         Reviewed by Jonathan Bedard.
355
356         * BuildSlaveSupport/ews-build/steps.py:
357         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
358         (ReRunWebKitTests): Build step to re-run layout tests.
359         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
360         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
361         (RunWebKitTestsWithoutPatch.evaluateCommand):
362
363 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
364
365         [ews-build] Combine various patchFailed*Tests properties
366         https://bugs.webkit.org/show_bug.cgi?id=199193
367
368         Reviewed by Jonathan Bedard.
369
370         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
371         can also be used for layout-tests later on.
372         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
373
374 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
375
376         [Win] MiniBrowser should default to webkit.org
377         https://bugs.webkit.org/show_bug.cgi?id=199201
378
379         Reviewed by Don Olmstead.
380
381         * MiniBrowser/win/BrowserWindow.h:
382         * MiniBrowser/win/MiniBrowserReplace.h:
383         * MiniBrowser/win/WebKitBrowserWindow.cpp:
384         (WebKitBrowserWindow::loadHTMLString): Deleted.
385         * MiniBrowser/win/WebKitBrowserWindow.h:
386         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
387         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
388         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
389         * MiniBrowser/win/WinMain.cpp:
390         (wWinMain):
391
392 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
393
394         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
395         https://bugs.webkit.org/show_bug.cgi?id=199192
396         <rdar://problem/51554509>
397
398         Reviewed by Tim Horton.
399
400         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
401         verify that we gracefully handle web process termination and web view unparenting mid-drag.
402
403         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
404         (TestWebKitAPI::TEST):
405         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
406         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
407         (-[DragAndDropSimulator _resetSimulatedState]):
408         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
409         (-[DragAndDropSimulator _advanceProgress]):
410         (-[DragAndDropSimulator liftPreviews]):
411         (-[DragAndDropSimulator cancellationPreviews]):
412         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
413         (-[DragAndDropSimulator sessionWillBeginBlock]):
414         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
415
416 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
417
418         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
419         https://bugs.webkit.org/show_bug.cgi?id=199178
420
421         Reviewed by Jonathan Bedard.
422
423         * BuildSlaveSupport/ews-build/steps.py:
424         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
425         (ExtractTestResults.__init__): Ditto.
426         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
427
428 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
429
430         Add user agent quirk for bankofamerica.com
431         https://bugs.webkit.org/show_bug.cgi?id=199154
432
433         Reviewed by Carlos Garcia Campos.
434
435         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
436         (TestWebKitAPI::TEST):
437
438 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
439
440         Fully rename WebKitGTK+ -> WebKitGTK everywhere
441         https://bugs.webkit.org/show_bug.cgi?id=199159
442
443         Reviewed by Carlos Garcia Campos.
444
445         * BuildSlaveSupport/gtk/README:
446         * MiniBrowser/gtk/BrowserWindow.c:
447         * MiniBrowser/gtk/main.c:
448         (aboutURISchemeRequestCallback):
449         * Scripts/webkitpy/common/config/contributionareas.py:
450         * Scripts/webkitpy/common/config/contributors.json:
451         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
452         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
453         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
454         (testWebViewResources):
455         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
456         (testWebViewMouseTarget):
457         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
458         (testWebExtensionGetTitle):
459         (testDocumentLoadedSignal):
460         (testWebExtensionFormControlsAssociated):
461         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
462         (testWebKitSettingsUserAgent):
463         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
464         (testWebViewRunJavaScript):
465         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
466         (main):
467         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
468         (prepareContextMenuTestView):
469         (testContextMenuPopulateMenu):
470         (testContextMenuCustomMenu):
471         (testContextMenuDisableMenu):
472         (testContextMenuSubMenu):
473         (testContextMenuDismissed):
474         (testContextMenuWebExtensionMenu):
475         (testContextMenuWebExtensionNode):
476         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
477         (testInspectorDefault):
478         (testInspectorManualAttachDetach):
479         (testInspectorCustomContainerDestroyed):
480         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
481         (testWebViewPrint):
482         (testPrintOperationPrint):
483         (testPrintOperationErrors):
484         * gtk/install-dependencies:
485         * gtk/jhbuild.modules:
486         * gtkdoc/generate-gtkdoc:
487         * wpe/install-dependencies:
488
489 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
490
491         contributors.json not canonicalized since r243297
492         https://bugs.webkit.org/show_bug.cgi?id=199161
493
494         Reviewed by Alexey Proskuryakov.
495
496         Canonicalize it using 'validate-committer-lists --canonicalize'
497
498         * Scripts/webkitpy/common/config/contributors.json:
499
500 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
501
502         webkitpy: Build style should be lower-case
503         https://bugs.webkit.org/show_bug.cgi?id=199158
504
505         Reviewed by Aakash Jain.
506
507         * Scripts/webkitpy/test/main.py:
508         (Tester._run_tests): Make all styles lower-case.
509
510 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
511
512         [ews-build] Remove iOS queue from old EWS and dashboard
513         https://bugs.webkit.org/show_bug.cgi?id=199150
514
515         Reviewed by Jonathan Bedard.
516
517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
518         * QueueStatusServer/config/queues.py:
519
520 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
521
522         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
523         https://bugs.webkit.org/show_bug.cgi?id=198795
524
525         Unreviewed test gardening.
526
527         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
528         (TestWebKitAPI::TEST): Disable flaky test.
529
530 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
531
532         [ews-build] Enable iOS-12-Build queue on new EWS
533         https://bugs.webkit.org/show_bug.cgi?id=199149
534
535         Reviewed by Jonathan Bedard.
536
537         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
538         this queue.
539         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
540         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
541         will keep the builders to the left and testers to the right.
542
543 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
544
545         [ews-build] Upload test results after running layout-tests
546         https://bugs.webkit.org/show_bug.cgi?id=199120
547
548         Reviewed by Jonathan Bedard.
549
550         * BuildSlaveSupport/ews-build/steps.py:
551         (RunWebKitTests.evaluateCommand):
552         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
553
554 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-build] EWS should provide option to download layout test results zip file
557         https://bugs.webkit.org/show_bug.cgi?id=199121
558
559         Reviewed by Jonathan Bedard.
560
561         * BuildSlaveSupport/ews-build/steps.py:
562         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
563         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
564
565 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
566
567         Add user agent quirk for Google Drive
568         https://bugs.webkit.org/show_bug.cgi?id=199153
569
570         Reviewed by Carlos Garcia Campos.
571
572         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
573         (TestWebKitAPI::TEST):
574
575 2019-06-22  Zalan Bujtas  <zalan@apple.com>
576
577         [LFC] Expand tests coverage (328 new tests -> 2652).
578
579         * LayoutReloaded/misc/LFC-passing-tests.txt:
580
581 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
582
583         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
584         https://bugs.webkit.org/show_bug.cgi?id=199107
585         <rdar://problem/43663611>
586
587         Reviewed by Chris Fleizach.
588
589         iOS implementation for AccessibilityUIElement::hasPopup.
590         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
591         (WTR::AccessibilityUIElement::hasPopup const):
592
593 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
594
595         Unreviewed, add myself to CMake watchlist
596
597         * Scripts/webkitpy/common/config/watchlist:
598
599 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
600
601         openDatabase should return an empty object when WebSQL is disabled
602         https://bugs.webkit.org/show_bug.cgi?id=198805
603
604         Reviewed by Geoffrey Garen.
605
606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
607         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
608         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
609         (TEST):
610         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
611
612 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
613
614         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
615         https://bugs.webkit.org/show_bug.cgi?id=199114
616         <rdar://problem/51671674>
617
618         Reviewed by Youenn Fablet.
619
620         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
621         (-[TestSOAuthorizationNavigationDelegate init]):
622         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
623         (configureSOAuthorizationWebView):
624         (TestWebKitAPI::TEST):
625
626 2019-06-21  Youenn Fablet  <youenn@apple.com>
627
628         WebPageProxy should use the right path for sandbox extension
629         https://bugs.webkit.org/show_bug.cgi?id=198902
630         <rdar://problem/50772810>
631
632         Reviewed by Geoffrey Garen.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
635         (TEST):
636         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
637
638 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
639
640         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
641         https://bugs.webkit.org/show_bug.cgi?id=199094
642
643         Reviewed by Carlos Garcia Campos.
644
645         * MiniBrowser/gtk/BrowserTab.c:
646         (runColorChooserCallback):
647         (browserTabConstructed):
648         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
649         (testWebViewSyncRequestOnMaxConns):
650         (beforeAll):
651         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
652         (testWebSocketTLSErrors):
653         (beforeAll):
654         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
655         (WebKitTestServer::~WebKitTestServer):
656         (WebKitTestServer::getWebSocketURIForPath const):
657         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
658         (WTR::AccessibilityUIElement::rowHeaders const):
659         (WTR::AccessibilityUIElement::columnHeaders const):
660         (WTR::AccessibilityUIElement::isAttributeSettable):
661         (WTR::AccessibilityUIElement::x):
662         (WTR::AccessibilityUIElement::y):
663         (WTR::AccessibilityUIElement::width):
664         (WTR::AccessibilityUIElement::height):
665         (WTR::AccessibilityUIElement::clickPointX):
666         (WTR::AccessibilityUIElement::clickPointY):
667         (WTR::AccessibilityUIElement::intValue const):
668         (WTR::AccessibilityUIElement::minValue):
669         (WTR::AccessibilityUIElement::maxValue):
670         (WTR::stringAtOffset):
671
672 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
673
674         test-webkitpy is broken on macOS Catalina
675         https://bugs.webkit.org/show_bug.cgi?id=199078
676
677         Reviewed by Jonathan Bedard.
678
679         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
680         to the runner.
681         (main): 
682         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
683
684 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
685
686         Change status to "committer" in contributors.json
687
688         Unreviewed.
689
690         * Scripts/webkitpy/common/config/contributors.json:
691
692 2019-06-20  Alex Christensen  <achristensen@webkit.org>
693
694         Add unit test for UIContextMenuConfiguration API
695         https://bugs.webkit.org/show_bug.cgi?id=199043
696
697         Reviewed by Wenson Hsieh.
698
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
701         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
702         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
703         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
704         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
705         (TEST):
706         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
707         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
708         (-[TestContextMenuDriver delegate]):
709         (-[TestContextMenuDriver setDelegate:]):
710         (-[TestContextMenuDriver view]):
711         (-[TestContextMenuDriver setView:]):
712         (-[TestContextMenuDriver allowableMovement]):
713         (-[TestContextMenuDriver setAllowableMovement:]):
714         (-[TestContextMenuDriver primaryGestureRecognizer]):
715         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
716         (-[TestContextMenuDriver touchDuration]):
717         (-[TestContextMenuDriver setTouchDuration:]):
718         (-[TestContextMenuDriver locationInCoordinateSpace:]):
719         (-[TestContextMenuDriver cancelInteraction]):
720         (-[TestContextMenuDriver begin:]):
721         (-[TestContextMenuDriver clickDown]):
722         (-[TestContextMenuDriver clickUp]):
723         (-[TestContextMenuDriver end]):
724         * TestWebKitAPI/ios/UIKitSPI.h:
725
726 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-app] Status bubble should not turn orange when any build step is skipped
729         https://bugs.webkit.org/show_bug.cgi?id=199079
730
731         Reviewed by Jonathan Bedard.
732
733         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
734
735 2019-06-20  Alex Christensen  <achristensen@webkit.org>
736
737         Fix an internal engineering build after r246605
738        ​https://bugs.webkit.org/show_bug.cgi?id=197800
739
740         * TestWebKitAPI/TCPServer.cpp:
741
742 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-build] Triggered builds should use same revision as parent build
745         https://bugs.webkit.org/show_bug.cgi?id=198289
746
747         Reviewed by Jonathan Bedard.
748
749         * BuildSlaveSupport/ews-build/steps.py:
750         (CheckOutSpecificRevision): Build step to checkout specific revision.
751         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
752         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
753         (CheckOutSpecificRevision.start): Run appropriate git command.
754         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
755         builds use same revision as parent build.
756         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
757         * BuildSlaveSupport/ews-build/factories.py:
758         (Factory.__init__): Added CheckOutSpecificRevision step.
759
760 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
761
762         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
763         https://bugs.webkit.org/show_bug.cgi?id=199073
764
765         Reviewed by Jonathan Bedard.
766
767         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
768
769 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
770
771         [GTK] Enable navigation swipe layout tests
772         https://bugs.webkit.org/show_bug.cgi?id=198995
773
774         Reviewed by Michael Catanzaro.
775
776         Add a way for tests to enable and then control swipe gesture on GTK.
777
778         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
779         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
780         * WebKitTestRunner/PlatformGTK.cmake:
781         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
782         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
783         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
784         (WTR::UIScriptController::beginBackSwipe):
785         (WTR::UIScriptController::completeBackSwipe):
786
787 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
788
789         [GTK] HTTP layout tests don't run in flatpak
790         https://bugs.webkit.org/show_bug.cgi?id=199067
791
792         Reviewed by Michael Catanzaro.
793
794         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
795         check that path. Instead, add /app/lib/perl to Apache config directly.
796
797         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
798         /.flatpak-info instead.
799
800         * Scripts/webkitpy/port/base.py:
801         (Port._is_flatpak):
802         (Port._in_flatpak_sandbox):
803         * flatpak/flatpakutils.py:
804         (WebkitFlatpak.run_in_sandbox):
805         (is_sandboxed):
806
807 2019-06-18  Darin Adler  <darin@apple.com>
808
809         Tidy up the remaining bits of the AtomicString to AtomString rename
810         https://bugs.webkit.org/show_bug.cgi?id=198990
811
812         Reviewed by Michael Catanzaro.
813
814         * Scripts/do-webcore-rename: Removed already-done renames.
815         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
816
817 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
818
819         [GTK] Remove support for GTK2 plugins
820         https://bugs.webkit.org/show_bug.cgi?id=199065
821
822         Reviewed by Sergio Villar Senin.
823
824         * EWSTools/ubuntu-ews-packages:
825         * TestWebKitAPI/PlatformGTK.cmake:
826         * WebKitTestRunner/PlatformGTK.cmake:
827         * flatpak/org.webkit.GTK.yaml:
828         * gtk/install-dependencies:
829
830 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
831
832         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
833         https://bugs.webkit.org/show_bug.cgi?id=199053
834
835         Reviewed by Saam Barati.
836
837         Added a test stressing IsoHeap with multiple threads.
838
839         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
840         (assertHasObjects):
841         (assertHasOnlyObjects):
842         (assertClean):
843         (TEST):
844
845 2019-06-19  Zalan Bujtas  <zalan@apple.com>
846
847         [LFC] Expand tests coverage (1126 new tests -> 2324).
848
849         * LayoutReloaded/misc/LFC-passing-tests.txt:
850
851 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
852
853         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
854         https://bugs.webkit.org/show_bug.cgi?id=198957
855
856         Reviewed by Alex Christensen.
857
858         * TestWebKitAPI/CMakeLists.txt:
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
860         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
861
862 2019-06-19  Keith Rollin  <krollin@apple.com>
863
864         Relocate some test tools in non-mac builds
865         https://bugs.webkit.org/show_bug.cgi?id=198984
866         <rdar://problem/51873261>
867
868         Reviewed by Andy Estes.
869
870         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
871         TestNetscapePlugin get created in
872         WebKit.framework/Versions/A/Resources on non-mac builds. This is
873         incorrect, as those bundles are shallow bundles that don't use the
874         Versions hierarchy. Instead, store these files directly in
875         WebKit.framework.
876
877         Note that getting rid of just the "Versions/A" path components and
878         putting the files in WebKit.framework/Resources doesn't work as
879         `codesign` treats the result as an invalid layout.
880
881         The work in this patch involves changing the definition of the custom
882         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
883         variable INSTALL_PATH is defined in terms of this variable. In order
884         to increase visiblity into this relationship, move both of these
885         variables into .xcconfig files if they weren't already. This
886         refactoring was done in a way to be the least disruptive and most
887         compatible with the previous definitions, even at the cost of being
888         repetitive.
889
890         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
891         * DumpRenderTree/mac/Configurations/Base.xcconfig:
892         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
893         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
894         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
895         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
896
897 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
898
899         [ews-build] Patch link should open the pretty patch
900         https://bugs.webkit.org/show_bug.cgi?id=199031
901
902         Reviewed by Jonathan Bedard.
903
904         * BuildSlaveSupport/ews-build/steps.py:
905         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
906
907 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
908
909         [ews-build] Add step to analyze Compile WebKit failures
910         https://bugs.webkit.org/show_bug.cgi?id=199025
911
912         Reviewed by Jonathan Bedard.
913
914         * BuildSlaveSupport/ews-build/steps.py:
915         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
916         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
917         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
918         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
919         this step is run only when compile-webkit failed.
920
921 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
922
923         [ews-build] Send email notifications for failures
924         https://bugs.webkit.org/show_bug.cgi?id=198919
925
926         Reviewed by Jonathan Bedard.
927
928         * BuildSlaveSupport/ews-build/master.cfg:
929
930 2019-06-19  Alex Christensen  <achristensen@webkit.org>
931
932         Add a unit test for client certificate authentication
933         https://bugs.webkit.org/show_bug.cgi?id=197800
934
935         Reviewed by Youenn Fablet.
936
937         Make better abstractions for reading and writing from/to TCPServer.
938         Add a unit test that causes a client certificate authentication challenge to happen.
939
940         * TestWebKitAPI/TCPServer.cpp:
941         (TestWebKitAPI::TCPServer::TCPServer):
942         (TestWebKitAPI::TCPServer::read):
943         (TestWebKitAPI::TCPServer::write):
944         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
945         (TestWebKitAPI::TCPServer::respondWithOK):
946         * TestWebKitAPI/TCPServer.h:
947         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
948         (credentialWithIdentity):
949         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
950         (TEST):
951         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
952         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
953         (-[ClientCertificateDelegate challengeCount]):
954         (TestWebKitAPI::TEST):
955         (respondWithChallengeThenOK): Deleted.
956         (credentialWithIdentityAndKeychainPath): Deleted.
957         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
958         (TEST):
959         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
960         (TestWebKitAPI::TEST):
961         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
962         (TEST):
963         (readRequest): Deleted.
964         (writeResponse): Deleted.
965         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
966         (TestWebKitAPI::TEST):
967         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
968
969 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
970
971         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
972
973         System headers are being included without SYSTEM again here.
974
975         * TestWebKitAPI/PlatformGTK.cmake:
976
977 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
978
979         [JSC] JSLock should be WebThread aware
980         https://bugs.webkit.org/show_bug.cgi?id=198911
981
982         Reviewed by Geoffrey Garen.
983
984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
985         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
986         (TestWebKitAPI::TEST):
987
988 2019-06-18  Keith Miller  <keith_miller@apple.com>
989
990         webkit-patch should allow for a bugzilla url not just bugzilla id
991         https://bugs.webkit.org/show_bug.cgi?id=198972
992
993         Reviewed by Dewei Zhu.
994
995         When prompting for a bugzilla id or a new title we should also
996         allow for a bugzilla url.
997
998         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
999         (PromptForBugOrTitle.run):
1000
1001 2019-06-18  David Quesada  <david_quesada@apple.com>
1002
1003         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
1004         https://bugs.webkit.org/show_bug.cgi?id=198954
1005         rdar://problem/51711556
1006
1007         Reviewed by Alex Christensen.
1008
1009         For these tests, kill the web process after the download starts. This makes the deallocation
1010         of the download-originating web views, which these tests depend on, more reliable.
1011
1012         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1013         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1014         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1015
1016 2019-06-18  Dan Bernstein  <mitz@apple.com>
1017
1018         Revert workaround for bug 198904 from run-webkit-archive
1019         https://bugs.webkit.org/show_bug.cgi?id=198931
1020
1021         Reviewed by Alexey Proskuryakov.
1022
1023         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
1024         pick up the built frameworks.
1025
1026         * WebKitArchiveSupport/run-webkit-archive:
1027         (set_dyld_framework_path):
1028
1029 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
1030
1031         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1032         https://bugs.webkit.org/show_bug.cgi?id=198854
1033         <rdar://problem/51386058>
1034
1035         Reviewed by Geoffrey Garen.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1038         (TestWebKitAPI::TEST):
1039
1040 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
1041
1042         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
1043         https://bugs.webkit.org/show_bug.cgi?id=198831
1044
1045         Reviewed by Žan Doberšek.
1046
1047         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
1048         * wpe/jhbuild.modules: Ditto.
1049         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1050         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1051
1052 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
1053
1054         Move SOAuthorization from WebKitAdditions to WebKit
1055         https://bugs.webkit.org/show_bug.cgi?id=198874
1056         <rdar://problem/47573431>
1057
1058         Reviewed by Brent Fulgham.
1059
1060         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
1061
1062         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1064         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
1065         (-[TestSOAuthorizationNavigationDelegate init]):
1066         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
1067         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1068         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1069         (-[TestSOAuthorizationViewController viewDidAppear]):
1070         (-[TestSOAuthorizationViewController viewDidDisappear]):
1071         (overrideCanPerformAuthorizationWithURL):
1072         (overrideSetDelegate):
1073         (overrideBeginAuthorizationWithURL):
1074         (overrideCancelAuthorization):
1075         (overrideAddObserverForName):
1076         (overrideIsURLFromAppleOwnedDomain):
1077         (resetState):
1078         (configureSOAuthorizationWebView):
1079         (generateHtml):
1080         (checkAuthorizationOptions):
1081         (TestWebKitAPI::TEST):
1082
1083 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
1084
1085         Ensure ITP state is relayed to Network Process on restart
1086         https://bugs.webkit.org/show_bug.cgi?id=198797
1087         <rdar://problem/51646944>
1088
1089         Reviewed by Youenn Fablet.
1090
1091         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1092         (cleanupITPDatabase): Added.
1093         (TEST:EnableDisableITP): Update to use cleanup method.
1094         (TEST:NetworkProcessRestart): Added.
1095
1096 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
1097
1098         New EWS can't process patches larger than 640kb
1099         https://bugs.webkit.org/show_bug.cgi?id=198851
1100
1101         Reviewed by Jonathan Bedard.
1102
1103         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
1104
1105 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
1106
1107         webkitpy: Add macOS Catalina, iOS 13
1108         https://bugs.webkit.org/show_bug.cgi?id=198492
1109
1110         Reviewed by Alexey Proskuryakov.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
1114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1120         * BuildSlaveSupport/ews-build/steps.py:
1121         * Scripts/webkitpy/common/version_name_map.py:
1122         * Scripts/webkitpy/common/version_name_map_unittest.py:
1123         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1124         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1125
1126 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
1129
1130         * gtk/jhbuild.modules:
1131         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1132         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1133
1134 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1135
1136         [LFC] Expand tests coverage (325 new tests -> 1198).
1137
1138         * LayoutReloaded/misc/LFC-passing-tests.txt:
1139
1140 2019-06-16  Darin Adler  <darin@apple.com>
1141
1142         Rename AtomicString to AtomString
1143         https://bugs.webkit.org/show_bug.cgi?id=195276
1144
1145         Reviewed by Michael Catanzaro.
1146
1147         * many files: Let do-webcore-rename do the renaming.
1148
1149         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
1150         that mention "atomic string" and changed them to instead say "atom string".
1151
1152 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1153
1154         [LFC] Unreviewed test gardening.
1155
1156         Unsupported alignments.
1157
1158         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
1159         fast/borders/empty-outline-border-assert.html -vertical-align: super
1160         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
1161
1162         * LayoutReloaded/misc/LFC-passing-tests.txt:
1163
1164 2019-06-15  Youenn Fablet  <youenn@apple.com>
1165
1166         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
1167         https://bugs.webkit.org/show_bug.cgi?id=198780
1168
1169         Reviewed by Jonathan Bedard.
1170
1171         * Scripts/webkitpy/w3c/test_importer.py:
1172         (TestImporter._webkit_test_runner_options):
1173         In case the test file cannot be read as text, consider that there is no WTR option.
1174
1175 2019-06-14  Youenn Fablet  <youenn@apple.com>
1176
1177         WebResourceLoadStatisticsStore should not use its network session if invalidated
1178         https://bugs.webkit.org/show_bug.cgi?id=198814
1179
1180         Reviewed by Geoffrey Garen.
1181
1182         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1183         (TEST):
1184
1185 2019-06-14  Youenn Fablet  <youenn@apple.com>
1186
1187         import-w3c-tests should respect WEBKIT_OUTPUTDIR
1188         https://bugs.webkit.org/show_bug.cgi?id=198682
1189         <rdar://problem/51536931>
1190
1191         Reviewed by Jonathan Bedard.
1192
1193         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
1194         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
1195
1196         * Scripts/webkitpy/common/webkit_finder.py:
1197         (WebKitFinder.path_from_webkit_outputdir):
1198         * Scripts/webkitpy/w3c/common.py:
1199         (WPTPaths):
1200         (WPTPaths.checkout_directory):
1201         (WPTPaths.wpt_checkout_path):
1202         * Scripts/webkitpy/w3c/test_importer.py:
1203         (TestImporter.__init__):
1204         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1205         (test_checkout_directory):
1206
1207 2019-06-13  Antoine Quint  <graouts@apple.com>
1208
1209         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1210         https://bugs.webkit.org/show_bug.cgi?id=198800
1211         <rdar://problem/51679634>
1212
1213         Reviewed by Tim Horton.
1214
1215         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
1216         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
1217
1218         * DumpRenderTree/mac/EventSendingController.mm:
1219         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1220         (-[EventSendingController mouseDown:withModifiers:]):
1221         (-[EventSendingController mouseUp:withModifiers:]):
1222         (-[EventSendingController mouseMoveToX:Y:]):
1223
1224 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1225
1226         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
1227         https://bugs.webkit.org/show_bug.cgi?id=198820
1228
1229         Reviewed by Ross Kirsling.
1230
1231         WebView window paints nothing because it is moved out of the
1232         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
1233         as DumpRenderTree does.
1234
1235         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1236         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
1237
1238 2019-06-13  Tim Horton  <timothy_horton@apple.com>
1239
1240         Make it possible for validate-committer-lists to dump a mailmap file
1241         https://bugs.webkit.org/show_bug.cgi?id=198517
1242
1243         Reviewed by Simon Fraser.
1244
1245         Mailmaps wildly improve the output of various Git tools, including
1246         `git shortlog -sne`, mapping committers to our canonical name/email pair.
1247
1248         * Scripts/validate-committer-lists:
1249         (CommitterListFromGit):
1250         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
1251         Add some missing legacy username mappings.
1252
1253         (dump_mailmap):
1254         (dump_mailmap.format_email):
1255         (dump_mailmap.format_email_with_gitsvn_uuid):
1256         (dump_mailmap.map_emails_to_legacy_username):
1257         (main):
1258         Add `validate-committer-lists --dump-mailmap`, which generates
1259         one given committers.json and the existing mapping of legacy username
1260         to email addresses that exists in validate-committer-lists.
1261
1262 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
1263
1264         Replace double-quotes with single quotes in loadConfig.py
1265         https://bugs.webkit.org/show_bug.cgi?id=198792
1266
1267         Reviewed by Jonathan Bedard.
1268
1269         * BuildSlaveSupport/ews-build/loadConfig.py:
1270         * BuildSlaveSupport/ews-build/steps_unittest.py:
1271
1272 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
1273
1274         Add mechanism and test case to check if ITP is active
1275         https://bugs.webkit.org/show_bug.cgi?id=198694
1276         <rdar://problem/51557704>
1277
1278         Reviewed by Youenn Fablet.
1279
1280         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1281         (TEST):
1282
1283 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1284
1285         [WPE][GTK] Deprecate WebSQL APIs
1286         https://bugs.webkit.org/show_bug.cgi?id=195011
1287
1288         Reviewed by Carlos Garcia Campos.
1289
1290         * MiniBrowser/gtk/main.c:
1291         (gotWebsiteDataCallback):
1292         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1293         (testWebsiteDataConfiguration):
1294         (testWebsiteDataEphemeral):
1295         (testWebsiteDataDatabases):
1296
1297 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1298
1299         [WPE][GTK] Enable hyperlink auditing
1300         https://bugs.webkit.org/show_bug.cgi?id=197845
1301
1302         Reviewed by Carlos Garcia Campos.
1303
1304         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1305         (testWebKitSettings):
1306
1307 2019-06-11  Keith Rollin  <krollin@apple.com>
1308
1309         Open up xcfilelist processing to more platforms
1310         https://bugs.webkit.org/show_bug.cgi?id=198675
1311         <rdar://problem/51533238>
1312
1313         Reviewed by Jonathan Bedard.
1314
1315         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
1316         platforms on which to perform xcfilelist generation/updating.
1317
1318         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1319         (JavaScriptCoreGenerator):
1320         (WebCoreGenerator):
1321         (WebKitGenerator):
1322
1323 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
1324
1325         webkitpy: Fix device ASan reporting, add testing for report configurations
1326         https://bugs.webkit.org/show_bug.cgi?id=198756
1327
1328         Reviewed by Aakash Jain.
1329
1330         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
1331         configuration thoroughly in webkitpy.
1332
1333         * Scripts/webkitpy/port/config.py:
1334         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
1335         * Scripts/webkitpy/port/device_port.py:
1336         (DevicePort.configuration_for_upload): Add ASan as style.
1337         * Scripts/webkitpy/port/ios_device_unittest.py:
1338         (IOSDeviceTest):
1339         (IOSDeviceTest.test_default_upload_configuration):
1340         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1341         (IOSSimulatorTest.test_default_upload_configuration):
1342         * Scripts/webkitpy/port/mock_drt_unittest.py:
1343         (MockDRTPortTest.test_asan_upload_configuration):
1344         * Scripts/webkitpy/port/port_testcase.py:
1345         (test_default_upload_configuration):
1346         (test_debug_upload_configuration):
1347         (test_asan_upload_configuration):
1348         (test_guard_malloc_configuration):
1349         * Scripts/webkitpy/port/watch_simulator_unittest.py:
1350         (WatchSimulatorTest):
1351         (WatchSimulatorTest.test_default_upload_configuration):
1352
1353 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1354
1355         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
1356         https://bugs.webkit.org/show_bug.cgi?id=198749
1357
1358         Reviewed by Carlos Garcia Campos.
1359
1360         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1361         (TestWebKitAPI::TEST):
1362
1363 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1364
1365         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
1366         https://bugs.webkit.org/show_bug.cgi?id=198735
1367         <rdar://problem/51557159>
1368
1369         Reviewed by Megan Gardner.
1370
1371         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
1372         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
1373
1374         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1375         (TestWebKitAPI::TEST):
1376
1377 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1378
1379         Unreviewed, add myself to the JavaScriptCore watchlist.
1380
1381         * Scripts/webkitpy/common/config/watchlist:
1382
1383 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1384
1385         Unreviewed, change my status to be a WebKit reviewer
1386
1387         * Scripts/webkitpy/common/config/contributors.json:
1388
1389 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1390
1391         [WPE] Use new exported image API from fdo backend
1392         https://bugs.webkit.org/show_bug.cgi?id=198558
1393
1394         Reviewed by Philippe Normand.
1395
1396         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
1397         WPEToolingBackends that already depends on fdo backend and libxkb
1398         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
1399         * wpe/backends/HeadlessViewBackend.cpp:
1400         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1401         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1402         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1403         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1404         * wpe/backends/HeadlessViewBackend.h:
1405         * wpe/backends/ViewBackend.cpp:
1406         (WPEToolingBackends::ViewBackend::initialize):
1407         * wpe/backends/ViewBackend.h:
1408         * wpe/backends/WindowViewBackend.cpp:
1409         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1410         * wpe/backends/WindowViewBackend.h:
1411
1412 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
1413
1414         Extend run-benchmark to allow diagnosing before closing browser on test failure.
1415         https://bugs.webkit.org/show_bug.cgi?id=198729
1416
1417         Reviewed by Ryosuke Niwa.
1418
1419         Add '--diagnose-directory' option to store diagnose information when test failed.
1420
1421         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1422         (BenchmarkRunner.__init__):
1423         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1424         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
1425         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
1426         (parse_args):
1427         (run_benchmark_plan):
1428         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1429         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1430         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1431         (WebServerBenchmarkRunner.__init__):
1432         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1433
1434 2019-06-10  Sam Weinig  <weinig@apple.com>
1435
1436         Remove Dashboard support
1437         https://bugs.webkit.org/show_bug.cgi?id=198615
1438
1439         Reviewed by Ryosuke Niwa.
1440
1441         * DumpRenderTree/TestRunner.cpp:
1442         (TestRunner::staticFunctions):
1443         (setUseDashboardCompatibilityModeCallback): Deleted.
1444         * DumpRenderTree/TestRunner.h:
1445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1446         * DumpRenderTree/mac/DumpRenderTree.mm:
1447         (resetWebViewToConsistentStateBeforeTesting):
1448         * DumpRenderTree/mac/TestRunnerMac.mm:
1449         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
1450         * ImageDiff/cg/Configurations/Base.xcconfig:
1451         * Scripts/webkitperl/FeatureList.pm:
1452         * TestWebKitAPI/Configurations/Base.xcconfig:
1453         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1455         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
1456         * WebKitTestRunner/Configurations/Base.xcconfig:
1457         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1458         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1459         (WTR::InjectedBundle::beginTesting):
1460         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1461         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
1462         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1463
1464 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
1465
1466         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
1467         https://bugs.webkit.org/show_bug.cgi?id=198616
1468         rdar://problem/36386573
1469
1470         Reviewed by David Kilzer.
1471
1472         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
1473
1474         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1475         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1476         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1477         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
1478         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
1479         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
1480         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
1481         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1482         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1483         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1484
1485 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1486
1487         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
1488         https://bugs.webkit.org/show_bug.cgi?id=198699
1489         <rdar://problem/50501718>
1490
1491         Reviewed by Simon Fraser.
1492
1493         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
1494         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
1495         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
1496         viewport parameters are used.
1497
1498         * WebKitTestRunner/ios/TestControllerIOS.mm:
1499         (WTR::TestController::platformResetPreferencesToConsistentValues):
1500         (WTR::TestController::platformConfigureViewForTest):
1501
1502 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
1503
1504         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
1505         https://bugs.webkit.org/show_bug.cgi?id=198023
1506
1507         Reviewed by Saam Barati.
1508
1509         * Scripts/run-jsc-stress-tests:
1510
1511 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1512
1513         Integrate dark mode support for iOS.
1514         https://bugs.webkit.org/show_bug.cgi?id=198687
1515         rdar://problem/51545643
1516
1517         Reviewed by Tim Horton.
1518
1519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1520
1521 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
1522
1523         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
1524         https://bugs.webkit.org/show_bug.cgi?id=198723
1525
1526         Reviewed by Aakash Jain.
1527
1528         * Scripts/webkitpy/xcode/simulated_device.py:
1529         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
1530
1531 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
1532
1533         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
1534         https://bugs.webkit.org/show_bug.cgi?id=198635
1535         <rdar://problem/46010232>
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1540         (areCookiesEqual):
1541         (TEST):
1542
1543 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1544
1545         [JHBuild] Bump shared-mime-info to version ≥ 1.6
1546         https://bugs.webkit.org/show_bug.cgi?id=198714
1547
1548         Reviewed by Carlos Garcia Campos.
1549
1550         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
1551         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
1552         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
1553
1554 2019-06-10  Philippe Normand  <pnormand@igalia.com>
1555
1556         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
1557         https://bugs.webkit.org/show_bug.cgi?id=198713
1558
1559         Reviewed by Carlos Garcia Campos.
1560
1561         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
1562         patches currently used in JHBuild.
1563
1564 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1565
1566         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
1567         https://bugs.webkit.org/show_bug.cgi?id=198711
1568
1569         Reviewed by Philippe Normand.
1570
1571         * flatpak/org.webkit.GTK.yaml: Also include modules from
1572         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
1573
1574 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
1575
1576         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
1577         avoids double-free condition that's causing bots to exit early.
1578
1579         * gtk/jhbuild.modules:
1580         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1581         * wpe/jhbuild.modules:
1582         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1583
1584 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1585
1586         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
1587         https://bugs.webkit.org/show_bug.cgi?id=198655
1588
1589         Reviewed by Ross Kirsling.
1590
1591         MediaCapabilities is enabled by default for WK2, but WinCairo
1592         doesn't implemented yet. Disable it in MiniBrowser.
1593
1594         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1595         (WebKitBrowserWindow::create):
1596
1597 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1598
1599         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
1600         https://bugs.webkit.org/show_bug.cgi?id=198693
1601         <rdar://problem/51555371>
1602
1603         Reviewed by Tim Horton.
1604
1605         Augment an existing API test to exercise three additional scenarios:
1606             -   The web view configuration's application name is never set; the default should not include
1607                 "Mobile/15E148" in desktop mode.
1608             -   The application name is explicitly set to nil; the default application name should still not include
1609                 "Mobile/15E148".
1610             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
1611                 this when generating the user agent, even in desktop mode.
1612
1613         * TestWebKitAPI/ios/PreferredContentMode.mm:
1614         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
1615         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
1616         (TestWebKitAPI::TEST):
1617
1618 2019-06-08  Zalan Bujtas  <zalan@apple.com>
1619
1620         [LFC] Unreviewed test gardening.
1621
1622         Remove rtl tests. They were mistakenly marked as pass.
1623
1624         * LayoutReloaded/misc/LFC-passing-tests.txt:
1625
1626 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1627
1628         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1629         https://bugs.webkit.org/show_bug.cgi?id=198664
1630
1631         Reviewed by Simon Fraser.
1632
1633         Delete repeated entries which were submitted by mistake.
1634
1635         * Tracing/SystemTracePoints.plist:
1636
1637 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1638
1639         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
1640         https://bugs.webkit.org/show_bug.cgi?id=198631
1641         <rdar://problem/51505431>
1642
1643         Reviewed by Tim Horton.
1644
1645         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
1646
1647         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1648         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
1649         (-[CustomInputWebView inputView]):
1650         (-[CustomInputWebView inputAccessoryView]):
1651         (TestWebKitAPI::TEST):
1652
1653 2019-06-07  Daniel Bates  <dabates@apple.com>
1654
1655         [lldb-webkit] Pretty-print all kinds of Documents
1656         https://bugs.webkit.org/show_bug.cgi?id=198620
1657
1658         Reviewed by Simon Fraser.
1659
1660         Register formatters for all classes derived from WebCore::Document so we get nice summaries
1661         without having to drill down in Xcode- or casting- to the base class, Document.
1662
1663         Older LLDB versions use to do this automatically, but this functionality was removed in newer
1664         versions:
1665             [[
1666                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
1667                 chains, but also through inheritance chains. This feature has been removed since it
1668                 significantly degrades performance. You need to set up your formatters for every type in
1669                 inheritance chains to which you want the formatter to apply.
1670             ]]
1671             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
1672
1673         * lldb/lldb_webkit.py:
1674         (__lldb_init_module):
1675
1676 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
1677
1678         webkitpy: Support reporting results for uncommon test configurations
1679         https://bugs.webkit.org/show_bug.cgi?id=198662
1680         <rdar://problem/51524128>
1681
1682         Reviewed by Aakash Jain.
1683
1684         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1685         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
1686         * Scripts/webkitpy/port/base.py:
1687         (Port.configuration_for_upload): Set flavor based on options.
1688         * Scripts/webkitpy/results/options.py:
1689         (upload_options): Add result-report-flavor option.
1690         * Scripts/webkitpy/test/main.py:
1691         (Tester._run_tests): Set flavor based on options.
1692
1693 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1694
1695         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
1696         https://bugs.webkit.org/show_bug.cgi?id=198641
1697         <rdar://problem/51266310>
1698
1699         Reviewed by Tim Horton.
1700
1701         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
1702         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
1703         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
1704         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
1705         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
1706         reproduces on iOS simulator.
1707
1708         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
1709         representation is actually ignored by most clients anyways (including WebKit), in favor of using
1710         "com.apple.flat-rtfd".
1711
1712         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1713         (TestWebKitAPI::TEST):
1714         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1715         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1716         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1717
1718 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1719
1720         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
1721         https://bugs.webkit.org/show_bug.cgi?id=198607
1722
1723         Reviewed by Michael Catanzaro.
1724
1725         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
1726         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
1727         determine the type of the tests.
1728
1729         * Scripts/run-gtk-tests:
1730         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1731         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
1732         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1733         (GtkTestRunner.is_google_test): Ditto.
1734         * Scripts/run-wpe-tests:
1735         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1736         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1737         (WPETestRunner.is_google_test): Ditto.
1738         * glib/api_test_runner.py:
1739         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
1740         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
1741
1742 2019-06-06  Keith Rollin  <krollin@apple.com>
1743
1744         Remove SSL-based tests from TestWebKitAPI on some configurations
1745         https://bugs.webkit.org/show_bug.cgi?id=198551
1746         <rdar://problem/51424996>
1747
1748         Reviewed by Jonathan Bedard.
1749
1750         Not all platforms have SSL handy, so don't include SSL-based tests on
1751         those platforms.
1752
1753         * TestWebKitAPI/TCPServer.cpp:
1754         * TestWebKitAPI/TCPServer.h:
1755         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1756         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1757         * TestWebKitAPI/config.h:
1758
1759 2019-06-06  Daniel Bates  <dabates@apple.com>
1760
1761         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
1762         non-default port number
1763         https://bugs.webkit.org/show_bug.cgi?id=198618
1764
1765         Reviewed by Brent Fulgham.
1766
1767         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
1768         a string before we concatenate it with another string when building the string representation
1769         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
1770         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
1771
1772         * lldb/lldb_webkit.py:
1773         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
1774
1775 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1776
1777         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
1778         https://bugs.webkit.org/show_bug.cgi?id=198613
1779
1780         Reviewed by Alexey Proskuryakov.
1781
1782         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
1783
1784 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1785
1786         webkitpluginhost: Support ASan as a style
1787         https://bugs.webkit.org/show_bug.cgi?id=198586
1788         <rdar://problem/51459088>
1789
1790         Reviewed by Alexey Proskuryakov.
1791
1792         * Scripts/webkitpy/port/base.py:
1793         (Port.configuration_for_upload): Add ASan as a style.
1794         * Scripts/webkitpy/port/config.py:
1795         (Config._read_configuration):
1796         (Config):
1797         (Config.asan): Add property to check if the ASan configuration is active.
1798         * Scripts/webkitpy/port/config_unittest.py:
1799         (ConfigTest.test_default_configuration__scripterror):
1800         (ConfigTest):
1801         (ConfigTest.test_asan):
1802         * Scripts/webkitpy/test/main.py:
1803         (Tester._run_tests): Add Asan as a style.
1804
1805 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
1806
1807         block-spammers tool doesn't block e-mail
1808         https://bugs.webkit.org/show_bug.cgi?id=198570
1809
1810         Reviewed by Jonathan Bedard.
1811
1812         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
1813         recognize "false" here. Also, request body is unnecessary.
1814
1815 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1816
1817         [GTK][WPE] Enable PSON
1818         https://bugs.webkit.org/show_bug.cgi?id=194979
1819
1820         Reviewed by Žan Doberšek.
1821
1822         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
1823
1824         * gtk/jhbuild.modules:
1825         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1826         * wpe/jhbuild.modules:
1827         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1828
1829 2019-06-05  Andy Estes  <aestes@apple.com>
1830
1831         [macOS] Stop calling -[NSDraggingItem setItem:]
1832         https://bugs.webkit.org/show_bug.cgi?id=198588
1833         <rdar://problem/48297453>
1834
1835         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
1836
1837         Reviewed by Wenson Hsieh.
1838
1839         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
1840         TestRunnerShared group.
1841
1842         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1843         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1844         Changed to call -[NSDraggingItem _initWithItem:] when available.
1845
1846         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
1847         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
1848         declarations here from DumpRenderTree.
1849
1850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1851         Added TestRunnerShared/spi/AppKitTestSPI.h.
1852
1853         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1854         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1855         Changed to call -[NSDraggingItem _initWithItem:] when available.
1856
1857 2019-06-05  Jer Noble  <jer.noble@apple.com>
1858
1859         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
1860         https://bugs.webkit.org/show_bug.cgi?id=198585
1861
1862         Reviewed by Chris Dumez.
1863
1864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1866         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
1867         (TEST):
1868         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
1869
1870 2019-06-05  Alex Christensen  <achristensen@webkit.org>
1871
1872         Re-enable safe browsing in WKWebView
1873         https://bugs.webkit.org/show_bug.cgi?id=196161
1874         <rdar://problem/49171413>
1875
1876         Reviewed by Ryosuke Niwa.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1879         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1880         (TEST):
1881         (safeBrowsingView):
1882
1883 == Rolled over to ChangeLog-2019-06-05 ==