3dd105e33fc1971237c6445eb114901c2151f007
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
2
3         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
4         https://bugs.webkit.org/show_bug.cgi?id=139005
5
6         Reviewed by Chris Fleizach.
7
8         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9         Add mapping for ATK_ROLE_CAPTION to roleToString
10
11 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
12
13         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
14         https://bugs.webkit.org/show_bug.cgi?id=139149
15
16         Reviewed by Anders Carlsson.
17
18         WebKit2 already cleared application caches between runs (although it wasn't entirely
19         effective without WebCore changes in this patch).
20
21         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
22
23         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
24         function is not implemented on Windows, see below).
25
26         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
27         Ameded a FIXME.
28
29 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
30
31         Generalize PageActivityAssertionToken
32         https://bugs.webkit.org/show_bug.cgi?id=139106
33
34         Reviewed by Sam Weinig.
35
36         Add an API test for WTF::RefCounter.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
40         (TestWebKitAPI::TEST):
41             - added RefCounter test.
42
43 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
44
45         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
46         https://bugs.webkit.org/show_bug.cgi?id=139174
47
48         Reviewed by Simon Fraser.
49
50         * DumpRenderTree/TestRunner.cpp:
51         * DumpRenderTree/TestRunner.h:
52         Renamed testPathOrURL to testURL, because this variable always contains a URL.
53
54         * DumpRenderTree/mac/DumpRenderTree.mm:
55         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
56         (testPathFromURL): Moved from FrameLoadDelegate.mm.
57         (runTest): Set crash reporter information here, as we know the exact test URL.
58
59         * DumpRenderTree/mac/FrameLoadDelegate.mm:
60         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
61         reporter information here.
62
63         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
64         * DumpRenderTree/mac/TestRunnerMac.mm:
65         Updated for testPathOrURL renaming.
66
67         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
68         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
69         test URL until load starts, so save it into TestRunner now. A new TestRunner object
70         is created for each test.
71
72         * WebKitTestRunner/InjectedBundle/TestRunner.h:
73         (WTR::TestRunner::testURL):
74         (WTR::TestRunner::setTestURL):
75         Make TestRunner know the test name. For now, it's good enough to have it once load
76         starts, but if we ever need it earlier, we can send it with BeginTest message.
77
78         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
79         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
80         Use test URL, not currently loading URL for CrashReporter.
81
82         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
83         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
84         (WebKit1 already had it right).
85
86         * DumpRenderTree/win/DumpRenderTree.cpp:
87         (sizeWebViewForCurrentTest):
88         (runTest):
89         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
90         (ResourceLoadDelegate::willSendRequest):
91         Changed Windows DumpRenderTree to also use URL in TestRunner.
92
93 2014-12-02  Daniel Bates  <dabates@apple.com>
94
95         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
96         https://bugs.webkit.org/show_bug.cgi?id=139143
97
98         Reviewed by David Kilzer.
99
100         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
101         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
102         crashes. Run-webkit-tests will record as crashing the test associated with the
103         DumpRenderTree instance that wrote that string.
104
105         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
106         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
107         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
108         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
109         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
110         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
111         about a crash.
112
113         Additionally, update the crash message format written to standard error when LayoutTestRelay
114         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
115         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
116         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
117         when they crash in their test machinery logic/UI process code.
118
119         * DumpRenderTree/mac/DumpRenderTree.mm:
120         (writeCrashedMessageOnFatalError): Added.
121         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
122         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
123         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
124         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
125         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
126         the crash logs for WebKitTestRunner/DumpRenderTree.app.
127         * Scripts/webkitpy/port/driver.py:
128         (Driver.__init__): Update comment.
129         (Driver._check_for_driver_crash): Ditto.
130         * Scripts/webkitpy/port/ios.py:
131         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
132         regular expression. This constant is used as an optimization to avoid compiling the same
133         regular expression across invocations of _get_crash_log().
134         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
135         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
136         closer to where they are used.
137
138 2014-12-01  Anders Carlsson  <andersca@apple.com>
139
140         Remove WKBundleRemoveAllVisitedLinks
141         https://bugs.webkit.org/show_bug.cgi?id=139163
142
143         Reviewed by Sam Weinig.
144
145         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
146
147         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
148         (WTR::InjectedBundle::beginTesting):
149         * WebKitTestRunner/TestInvocation.cpp:
150         (WTR::TestInvocation::invoke):
151
152 2014-12-02  Anders Carlsson  <andersca@apple.com>
153
154         Fix Windows build.
155
156         * DumpRenderTree/win/DumpRenderTree.cpp:
157         (setAlwaysAcceptCookies):
158
159 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
160
161         [EFL] Remove edbus dependency from jhbuild
162         https://bugs.webkit.org/show_bug.cgi?id=139130
163
164         Reviewed by Gyuyoung Kim.
165
166         After http://trac.webkit.org/changeset/176555 we
167         don't need it anymore.
168
169         * efl/jhbuild.modules:
170
171 2014-12-02  Philippe Normand  <pnormand@igalia.com>
172
173         [jhbuild] wrong Dependencies path
174         https://bugs.webkit.org/show_bug.cgi?id=139176
175
176         Reviewed by Martin Robinson.
177
178         * Scripts/webkitpy/port/base.py:
179         (Port._should_use_jhbuild):
180
181 2014-12-02  Philippe Normand  <pnormand@igalia.com>
182
183         [GStreamer] Bump internal jhbuild versions to 1.4.4
184         https://bugs.webkit.org/show_bug.cgi?id=138866
185
186         Reviewed by Carlos Garcia Campos.
187
188         * gtk/jhbuild.modules:
189         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
190         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
191         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
192
193 2014-12-01  Commit Queue  <commit-queue@webkit.org>
194
195         Unreviewed, rolling out r176566.
196         https://bugs.webkit.org/show_bug.cgi?id=139124
197
198         It broke the GTK performance tests. (Requested by clopez on
199         #webkit).
200
201         Reverted changeset:
202
203         "[GTK] Use GMainLoopSource in WebKitTestRunner"
204         https://bugs.webkit.org/show_bug.cgi?id=138831
205         http://trac.webkit.org/changeset/176566
206
207 2014-11-29  Anders Carlsson  <andersca@apple.com>
208
209         Crash when calling WKPageClose on the originated page from within createNewPage callback
210         https://bugs.webkit.org/show_bug.cgi?id=139099
211         <rdar://problem/19052564>
212
213         Reviewed by Sam Weinig.
214
215         Add a test.
216
217         * TestWebKitAPI/PlatformWebView.h:
218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
219         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
220         (TestWebKitAPI::runJavaScriptAlert):
221         (TestWebKitAPI::createNewPage):
222         (TestWebKitAPI::TEST):
223         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
224         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
225         (TestWebKitAPI::PlatformWebView::PlatformWebView):
226
227 2014-11-28  Commit Queue  <commit-queue@webkit.org>
228
229         Unreviewed, rolling out r176564.
230         https://bugs.webkit.org/show_bug.cgi?id=139093
231
232         massive failures on release test bot (Requested by philn on
233         #webkit).
234
235         Reverted changeset:
236
237         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
238         https://bugs.webkit.org/show_bug.cgi?id=138866
239         http://trac.webkit.org/changeset/176564
240
241 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
242
243         [GTK] Use GMainLoopSource in WebKitTestRunner
244         https://bugs.webkit.org/show_bug.cgi?id=138831
245
246         Reviewed by Sergio Villar Senin.
247
248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
249         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
250         (WTR::TestRunner::platformInitialize):
251         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
252         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
253         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
254         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
255         (WTR::TestController::notifyDone):
256         (WTR::TestController::platformRunUntil):
257         (WTR::cancelTimeout): Deleted.
258
259 2014-11-24  Philippe Normand  <pnormand@igalia.com>
260
261         [GStreamer] Bump internal jhbuild versions to 1.4.4
262         https://bugs.webkit.org/show_bug.cgi?id=138866
263
264         Reviewed by Carlos Garcia Campos.
265
266         * gtk/jhbuild.modules:
267         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
268         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
269         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
270
271 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
272
273         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
274         https://bugs.webkit.org/show_bug.cgi?id=138834
275
276         Reviewed by Sergio Villar Senin.
277
278         It makes everyting simpler and the tests run faster too, since we
279         don't need to spawn the private bus and wait until the DBus name
280         is registered. The web extension registers a new JavaSCript class
281         with a status method to run the tests, similar to the DBus
282         method. In the UI process side, tests use webkit_web_view_run_java_script()
283         instead of sending a DBus message.
284
285         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
286         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
287         (WebKitDOMNodeFilterTest::create):
288         (WebKitDOMNodeFilterTest::testTreeWalker):
289         (WebKitDOMNodeFilterTest::testNodeIterator):
290         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
291         (WebKitDOMNodeFilterTest::runTest): Deleted.
292         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
293         (WebKitDOMNodeTest::create):
294         (WebKitDOMNodeTest::testHierarchyNavigation):
295         (WebKitDOMNodeTest::testInsertion):
296         (WebKitDOMNodeTest::testTagNames):
297         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
298         (WebKitDOMNodeTest::runTest): Deleted.
299         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
300         (WebKitDOMXPathNSResolverTest::create):
301         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
302         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
303         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
304         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
305         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
306         (WebKitFrameTest::create):
307         (WebKitFrameTest::testMainFrame):
308         (WebKitFrameTest::testURI):
309         (WebKitFrameTest::testJavaScriptContext):
310         (WebKitFrameTest::webPageFromArgs): Deleted.
311         (WebKitFrameTest::runTest): Deleted.
312         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
313         (testWebKitDOMNodeHierarchyNavigation):
314         (testWebKitDOMNodeInsertion):
315         (testWebKitDOMNodeTagNames):
316         (beforeAll):
317         (afterAll):
318         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
319         (runTest):
320         (beforeAll):
321         (afterAll):
322         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
323         (testWebKitDOMXPathNSResolverNative):
324         (testWebKitDOMXPathNSResolverCustom):
325         (beforeAll):
326         (afterAll):
327         (runTest): Deleted.
328         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
329         (webkitFrameTestRun):
330         (beforeAll):
331         (afterAll):
332         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
333         (testsMap):
334         (WebProcessTest::add):
335         (WebProcessTest::create):
336         (runTest):
337         (windowObjectClearedCallback):
338         (webkit_web_extension_initialize):
339         (methodCallCallback): Deleted.
340         (webkit_web_extension_initialize_with_user_data): Deleted.
341         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
342         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
343         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
344         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
345         (WebViewTest::runWebProcessTest):
346         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
347
348 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
349
350         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
351         https://bugs.webkit.org/show_bug.cgi?id=139086
352
353         Reviewed by Gyuyoung Kim.
354
355         * efl/jhbuild.modules:
356         * efl/patches/libseccomp-pick-up-CC.patch: Added.
357
358 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
359
360         [EFL] Add warning if CMake version is too old for building with ninja.
361         https://bugs.webkit.org/show_bug.cgi?id=139055
362
363         Reviewed by Gyuyoung Kim.
364
365         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
366         that version in their repositories.
367
368         * efl/install-dependencies:
369
370 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
371
372         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
373         https://bugs.webkit.org/show_bug.cgi?id=139044
374
375         Reviewed by Chris Fleizach.
376
377         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
378         The proposed solution will enable the use of this method for the object table.
379         Existing test shows the result.
380
381         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
382         (WTR::AccessibilityUIElement::columnHeaders):
383
384 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
385
386         [EFL] Remove E_Dbus dependency
387         https://bugs.webkit.org/show_bug.cgi?id=136355
388
389         Reviewed by Gyuyoung Kim.
390
391         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
392
393 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
394
395         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
396         https://bugs.webkit.org/show_bug.cgi?id=139047
397
398         Reviewed by Carlos Garcia Campos.
399
400         * efl/jhbuild.modules:
401         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
402         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
403         * gtk/jhbuild-optional.modules:
404         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
405         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
406
407 2014-11-25  Tanay C  <tanay.c@samsung.com>
408
409         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
410         https://bugs.webkit.org/show_bug.cgi?id=138090
411
412         Reviewed by Carlos Garcia Campos.
413
414         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
415         (browserWindowZoomIn): Added.
416         (browserWindowZoomOut): Added.
417         (scrollEventCallback): Added.
418         (zoomInCallback): Modified.
419         (zoomOutCallback): Modified.
420         (browserWindowConstructed): Modified.
421
422 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
423
424         [EFL] REGRESSION(r176514): It made performance tests fail
425         https://bugs.webkit.org/show_bug.cgi?id=139037
426
427         Reviewed by Gyuyoung Kim.
428
429         * Scripts/webkitpy/port/efl.py:
430         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
431         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
432         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
433
434 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
435
436         [GTK] update-webkitgtk-libs fails to build fontconfig
437         https://bugs.webkit.org/show_bug.cgi?id=139032
438
439         Reviewed by Martin Robinson.
440
441         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
442         fontconfig will try to generate documentation and fail.
443
444         * gtk/install-dependencies:
445
446 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
447
448         Unreviewed. Fix GTK+ make distcheck.
449
450         * gtk/manifest.txt: Remove deleted files.
451
452 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
453
454         [EFL] Utilize Eail library to support accessibility in EFL
455         https://bugs.webkit.org/show_bug.cgi?id=137742
456
457         Reviewed by Gyuyoung Kim.
458
459         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
460
461         * efl/jhbuild-optional.modules: Added.
462         * efl/jhbuild.modules:
463
464 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
465
466         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
467         https://bugs.webkit.org/show_bug.cgi?id=139023
468
469         Reviewed by Sergio Villar Senin.
470
471         Rename WebKitWebView/default-context as WebKitWebView/web-context
472         and check we are always using the right context for new web views.
473
474         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
475         (testWebViewWebContext):
476         (beforeAll):
477         (testWebViewDefaultContext): Deleted.
478
479 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
480
481         [GTK] Add API to override the default local storage directory
482         https://bugs.webkit.org/show_bug.cgi?id=138828
483
484         Reviewed by Gustavo Noronha Silva.
485
486         Add test to check that the local storage directory is created at
487         the path given on construction.
488
489         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
490         (testWebContextConfiguration):
491         (beforeAll):
492         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
493         (Test::Test):
494         (Test::~Test): Deleted.
495
496 2014-11-21  Zalan Bujtas  <zalan@apple.com>
497
498         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
499         https://bugs.webkit.org/show_bug.cgi?id=138981
500
501         Reviewed by Simon Fraser.
502
503         * MiniBrowser/mac/SettingsController.h:
504         * MiniBrowser/mac/SettingsController.m:
505         (-[SettingsController _populateMenu]):
506         (-[SettingsController validateMenuItem:]):
507         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
508         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
509         * MiniBrowser/mac/WK1BrowserWindowController.m:
510         (-[WK1BrowserWindowController didChangeSettings]):
511         * MiniBrowser/mac/WK2BrowserWindowController.m:
512         (-[WK2BrowserWindowController didChangeSettings]):
513
514 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
515
516         Remove http lock code from webkitperl
517         https://bugs.webkit.org/show_bug.cgi?id=138959
518
519         Reviewed by Alexey Proskuryakov.
520
521         * Scripts/webkitperl/httpd.pm:
522         (cleanUp):
523         (extractLockNumber): Deleted.
524         (getLockFiles): Deleted.
525         (getNextAvailableLockNumber): Deleted.
526         (getLockNumberForCurrentRunning): Deleted.
527         (waitForHTTPDLock): Deleted.
528         (scheduleHttpTesting): Deleted.
529         (getWaitTime): Deleted.
530
531 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
532
533         [EFL] The option value of fixed layout is false in MiniBrowser
534         https://bugs.webkit.org/show_bug.cgi?id=138830
535
536         Reviewed by Gyuyoung Kim.
537
538         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
539
540         * MiniBrowser/efl/main.c:
541
542 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
543
544         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
545         https://bugs.webkit.org/show_bug.cgi?id=138871
546
547         Reviewed by Carlos Garcia Campos.
548
549         Add a test case for the convenience API for posting user messages
550         added to the DOM bindings.
551
552         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
553         (testUserContentManagerMessageFromConvenienceDOMBindings):
554         (beforeAll):
555         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
556         (documentLoadedCallback):
557
558 2014-11-19  Dana Burkart  <dburkart@apple.com>
559
560         Work around the fact that different masters may have different names for their codebases.
561         https://bugs.webkit.org/show_bug.cgi?id=138878
562
563         Reviewed by Mark Rowe.
564
565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
566         (parseRevisionProperty): Changed.
567         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
568         opensource / internal codebase naming convention.
569
570 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
571
572         AX: Screen braille input doesn't work on forms.
573         https://bugs.webkit.org/show_bug.cgi?id=138804
574
575         Unreviewed build fix.
576
577         * DumpRenderTree/AccessibilityUIElement.cpp:
578         (AccessibilityUIElement::setValue):
579
580 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
581
582         AX: Screen braille input doesn't work on forms.
583         https://bugs.webkit.org/show_bug.cgi?id=138804
584
585         Reviewed by Mario Sanchez Prada.
586
587         Add a method to setValue through the AX API in DRT.
588
589         * DumpRenderTree/AccessibilityUIElement.cpp:
590         (setValueCallback):
591         (AccessibilityUIElement::getJSClass):
592         * DumpRenderTree/AccessibilityUIElement.h:
593         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
594         (AccessibilityUIElement::setValue):
595         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
596         (AccessibilityUIElement::setValue):
597
598 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
599
600         Remove the WinCairo buildbot
601         https://bugs.webkit.org/show_bug.cgi?id=138805
602
603         Reviewed by Alex Christensen.
604
605         * BuildSlaveSupport/build.webkit.org-config/config.json:
606         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
607         (appendCustomBuildFlags):
608         * BuildSlaveSupport/test-result-archive:
609         (archiveTestResults):
610
611 2014-11-18  Daniel Bates  <dabates@apple.com>
612
613         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
614         SPI are not available in public SDK
615         https://bugs.webkit.org/show_bug.cgi?id=138802
616
617         Reviewed by David Kilzer.
618
619         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
620
621         * DumpRenderTree/mac/CheckedMalloc.cpp:
622
623 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
624
625         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
626
627         Forgot to fix this test before landing.
628
629         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
630         (testWebViewDefaultContext):
631
632 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
633
634         [GTK] Add API to create a WebKitWebContext
635         https://bugs.webkit.org/show_bug.cgi?id=138826
636
637         Reviewed by Gustavo Noronha Silva.
638
639         Use a different WebKitWebContext for every test to ensure test
640         cases are independent to each other. Tests using DBus to
641         communicate with the injected bundle extension now use a unique
642         name for the well known DBus name.
643
644         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
645         (beforeAll): Remove comment about the order of the tests and
646         move the success test before the failed one now that tests don't
647         depend on each others.
648         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
649         (beforeAll): Remove call to set the web extensions directory,
650         since this is now done for all test in the Test constructor.
651         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
652         (beforeAll): Do not create a temporary directory, a temporary data
653         directory is now created for all tests.
654         (afterAll):
655         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
656         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
657         to the web process test runner.
658         (testWebKitDOMNodeInsertion): Ditto.
659         (testWebKitDOMNodeTagNames): Ditto.
660         (beforeAll): Remove call to set the web extensions directory.
661         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
662         (runTest): Pass the web extension ID to the web process test runner.
663         (beforeAll): Remove call to set the web extensions directory.
664         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
665         (runTest): Pass the web extension ID to the web process test runner.
666         (beforeAll): Remove call to set the web extensions directory.
667         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
668         (createFileAtDestination): Use Test::dataDirectory() as base dir
669         for temporary files.
670         (beforeAll): Do not create a temporary directory.
671         (afterAll):
672         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
673         (webkitFrameTestRun): Pass the web extension ID to the web process
674         test runner.
675         (beforeAll): Remove call to set the web extensions directory.
676         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
677         (beforeAll): Remove call to set the web extensions directory.
678         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
679         (testProcessPerWebView): Use local member instead of global variable.
680         (testMultiprocessWebViewCreateReadyClose): Ditto.
681         (beforeAll): Do not connect to initialize-web-extensions, Test now
682         connects to the signal for all tests and calls a virtual method
683         that test can override.
684         (afterAll):
685         (initializeWebExtensions): Deleted.
686         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
687         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
688         for temporary files.
689         (beforeAll): Do not create a temporary directory.
690         (afterAll):
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
692         (beforeAll): Remove call to set the web extensions directory.
693         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
694         (beforeAll): Remove comment about the tests order.
695         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
696         (testWebExtensionGetTitle): Build the DBus service name using the
697         web extension ID.
698         (testDocumentLoadedSignal): Ditto.
699         (testWebKitWebViewProcessCrashed): Ditto.
700         (testWebExtensionIsolatedWorld): Ditto.
701         (beforeAll): Remove initialization-user-data test, since now all
702         tests are passing user data to the web extension.
703         (testWebExtensionInitializationUserData): Deleted.
704         (initializeWebExtensions): Deleted.
705         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
706         (testSetDirectory): Use the web context member inherited from Test.
707         (testClearDatabase): Ditto.
708         (testGetFaviconURI): Ditto.
709         (beforeAll): Do not create a temporary directory.
710         (afterAll):
711         (webkitFaviconDatabaseFinalizedCallback): Deleted.
712         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
713         (UserContentManagerTest::UserContentManagerTest):
714         (beforeAll): Remove call to set the web extensions directory.
715         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
716         (testWebContextDefault): Check also that a newly create web
717         context is not the default web context.
718         (testWebContextSpellChecker): Use the web context member inherited
719         from Test.
720         (testWebContextLanguages): Ditto.
721         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
722         (methodCallCallback): Remove GetInitializationUserData method.
723         (webkit_web_extension_initialize_with_user_data): Always create
724         the DBus name using the user data provided.
725         (makeBusName): Deleted.
726         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
727         (webkit_web_extension_initialize_with_user_data): Create the DBus
728         name using the user data provided.
729         (webkit_web_extension_initialize): Deleted.
730         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
731         (Test::dataDirectory): Return the temporary data directory.
732         (removeNonEmptyDirectory): Also remove directories recursively.
733         (main): Remove the disk cache directory initialization, since this
734         is now done in the Test constructor.
735         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
736         (Test::initializeWebExtensionsCallback): Call the virtual method
737         initializeWebExtensions()
738         (Test::Test): Create a new WebKitWebContext and initialize it.
739         (Test::~Test): Disconnect initialize-web-extensions signal.
740         (Test::initializeWebExtensions): Set the web extensions directory
741         and user data.
742         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
743         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
744         (WebProcessTestRunner::runTest): Build the DBus proxy using a
745         unique name created with the Test web extension ID.
746         (WebProcessTestRunner::proxy): Deleted.
747         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
748         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
749         (WebViewTest::WebViewTest): Create the web view with the Test web
750         context.
751         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
752         content manager parameter to the constructor.
753
754 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
755
756         [GTK] Mesa build fails over llvm-3.5
757         https://bugs.webkit.org/show_bug.cgi?id=138825
758
759         Reviewed by Gustavo Noronha Silva.
760
761         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
762
763         * gtk/jhbuild.modules:
764         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
765
766 2014-11-17  Daniel Bates  <dabates@apple.com>
767
768         Unreviewed, rolling out r176232.
769
770         Broke the Mac build. Will investigate offline.
771
772         Reverted changeset:
773
774         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
775         MobileGestalt"
776         https://bugs.webkit.org/show_bug.cgi?id=138802
777         http://trac.webkit.org/changeset/176232
778
779 2014-11-17  Daniel Bates  <dabates@apple.com>
780
781         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
782         SPI are not available in public SDK
783         https://bugs.webkit.org/show_bug.cgi?id=138802
784
785         Reviewed by David Kilzer.
786
787         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
788
789         * DumpRenderTree/mac/CheckedMalloc.cpp:
790
791 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
792
793         Having 30+ flaky failures breaks EWS
794         https://bugs.webkit.org/show_bug.cgi?id=138743
795
796         Reviewed by Alexey Proskuryakov.
797
798         Adds tests to ensure that the problem has been solved.
799         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
800         (test_first_failure_limit):
801         (test_first_failure_limit_with_some_tree_redness):
802         (test_second_failure_limit):
803         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
804         (test_first_and_second_failure_limit):
805         (test_first_and_clean_failure_limit):
806         (test_first_second_and_clean_failure_limit):
807         (test_very_red_tree_retry): Deleted.
808         Really this was renamed to test_first_second_and_clean_failure_limit.
809         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
810         Makes the appropriate changes to PatchAnalysisTask to make sure that
811         even when the first test run hits the failure limit, it will still try
812         a second run.
813         (PatchAnalysisTask._results_failed_different_tests):
814         (PatchAnalysisTask._test_patch):
815         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
816
817 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
818
819         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
820         https://bugs.webkit.org/show_bug.cgi?id=136018
821
822         Reviewed by Carlos Garcia Campos.
823
824         It is possible that the order of -L arguments in the output of
825         pkg-config is wrong, which causes the linker to find the wrong
826         version (usually older version) of libraries when running
827         gtkdoc-scangobj.
828
829         * gtk/gtkdoc.py:
830         (GTKDoc._run_gtkdoc_scangobj):
831
832 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
833
834         Bump EFL version to 1.12.0
835         https://bugs.webkit.org/show_bug.cgi?id=138733
836
837         Reviewed by Gyuyoung Kim.
838
839         * efl/jhbuild.modules:
840
841 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
842
843         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
844         https://bugs.webkit.org/show_bug.cgi?id=138771
845
846         Reviewed by Chris Fleizach.
847
848         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
849
850         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
851
852 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
853
854         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
855         https://bugs.webkit.org/show_bug.cgi?id=138767
856
857         Reviewed by Chris Fleizach.
858
859         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
860
861         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
862
863 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
864
865         Add shortcut macros to Mac TestExpectations
866         https://bugs.webkit.org/show_bug.cgi?id=138729
867
868         Reviewed by Simon Fraser.
869
870         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
871         Add version macros for current OS versions.
872
873 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
874
875         https://bugs.webkit.org/show_bug.cgi?id=138628
876         A patch that doesn't apply is stuck in commit queue
877
878         Rubber-stamped by David Kilzer.
879
880         This also hopefully fixes other issues:
881         - a patch that has cq+ flag set by a non-committer kills commit queue;
882         - EWS never reports failing tests, and keeps spinning instead.
883
884         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
885         (Bugzilla.set_flag_on_attachment):
886         (Bugzilla.obsolete_attachment):
887         Apply the fix from r174797 to more places.
888
889 2014-11-13  Dan Bernstein  <mitz@apple.com>
890
891         Policy client not called for navigations through the page cache
892         https://bugs.webkit.org/show_bug.cgi?id=138703
893
894         Reviewed by Alexey Proskuryakov.
895
896         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
897         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
898         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
899
900 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
901
902         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
903         https://bugs.webkit.org/show_bug.cgi?id=137867
904
905         Reviewed by Chris Fleizach.
906
907         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
908         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
909         able to test for the presence of ATK_ROLE_INVALID.
910
911         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
912         (WTR::AccessibilityUIElement::role):
913
914 2014-11-13  Juergen Ributzka  <juergen@apple.com>
915
916         Update the "combineModules" script to handel more LLVM metadata.
917         https://bugs.webkit.org/show_bug.cgi?id=138514
918
919         Reviewed by Filip Pizlo.
920
921         * ReducedFTL/combineModules.rb:
922
923 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
924
925         Allow constructing a base PassRef with a derived Ref
926         https://bugs.webkit.org/show_bug.cgi?id=138701
927
928         Reviewed by Andreas Kling
929
930         * TestWebKitAPI/Tests/WTF/Ref.cpp:
931         (TestWebKitAPI::passWithPassRef):
932         (TestWebKitAPI::passWithPassRefPtr):
933         (TestWebKitAPI::TEST):
934
935 2014-11-05  Ada Chan  <adachan@apple.com>
936
937         Implement new plug-in API for muting plug-ins
938         https://bugs.webkit.org/show_bug.cgi?id=138105
939
940         Reviewed by Anders Carlsson.
941
942         Add a new plug-in test for the mute API.
943
944         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
945         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
946         (SetMuted::SetMuted):
947         (SetMuted::isMuted):
948         (SetMuted::cachedIsMuted):
949         (SetMuted::ScriptableObject::hasProperty):
950         (SetMuted::ScriptableObject::getProperty):
951         (SetMuted::ScriptableObject::pluginTest):
952         (SetMuted::NPP_New):
953         (SetMuted::NPP_GetValue):
954         (SetMuted::NPP_SetValue):
955
956 2014-11-12  Philippe Normand  <pnormand@igalia.com>
957
958         Unreviewed, GTK gardening.
959
960         * Scripts/run-gtk-tests:
961         (TestRunner): Skip the UserMediaBasic test because it depends on
962         constraints validation which is going to be fixed in bug #136449.
963
964 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
965
966         [GTK] Expose user script messages to GObject DOM bindings
967         https://bugs.webkit.org/show_bug.cgi?id=138411
968
969         Reviewed by Philippe Normand.
970
971         Add a test case to check that user script messages sent using the
972         DOM bindings API are also received in the UI process.
973
974         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
975         (UserScriptMessageTest::waitUntilMessageReceived):
976         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
977         (testUserContentManagerScriptMessageFromDOMBindings):
978         (beforeAll):
979         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
980         (documentLoadedCallback):
981
982 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
983
984         Unreviewed. Fix GTK+ clean build after r175930.
985
986         Partial rollout of r175930 to not build the new unit test that
987         broke clean builds in GTK+ port.
988
989         * TestWebKitAPI/PlatformGTK.cmake:
990
991 2014-09-01  Philippe Normand  <pnormand@igalia.com>
992
993         [WK2] UserMediaClient support
994         https://bugs.webkit.org/show_bug.cgi?id=123158
995
996         Reviewed by Benjamin Poulain.
997
998         Simple API test for the UserMedia permission request API. The
999         required test infrastructure is also added, inspired by the
1000         Geolocation infrastructure.
1001
1002         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1003         Permission request.
1004         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1005         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1006         (TestWebKitAPI::TEST):
1007         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1009         helper method to set the permission request result without user interaction.
1010         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1011         (WTR::InjectedBundle::setUserMediaPermission):
1012         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1013         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1014         (WTR::TestRunner::setUserMediaPermission):
1015         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1018         request handler.
1019         (WTR::TestController::createOtherPage): Enable the new UserMedia
1020         permission request handler.
1021         (WTR::TestController::createWebViewWithOptions): Ditto.
1022         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1023         MediaStream support, this is needed for getUserMedia.
1024         (WTR::TestController::resetStateToConsistentValues): clear
1025         UserMedia permissions list and flags.
1026         (WTR::TestController::setUserMediaPermission): Set permission
1027         request result and distpatch it.
1028         (WTR::TestController::handleUserMediaPermissionRequest): Save
1029         request and dispatch it.
1030         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1031         Dispatch cached permission requests.
1032         * WebKitTestRunner/TestController.h:
1033         * WebKitTestRunner/TestInvocation.cpp:
1034         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1035
1036 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1037
1038         webkit-patch --suggest-reviewers is broken with newer versions of git
1039         <http://webkit.org/b/138627>
1040
1041         Reviewed by Michael Saboff with feedback from Daniel Bates.
1042
1043         * Scripts/webkitpy/common/checkout/scm/git.py:
1044         (Git._changes_files_for_commit): Strip blank lines instead of
1045         assuming there is always a blank line at the beginning of the
1046         list.
1047
1048 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1049
1050         DRT and WKTR touch disk cache
1051         https://bugs.webkit.org/show_bug.cgi?id=138622
1052
1053         Reviewed by Geoffrey Garen.
1054
1055         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1056         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1057         because this function uses the shared cache.
1058
1059         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1060         Create an empty shared cache to prevent a default one from being created on disk.
1061
1062 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1063
1064         [CSS Grid Layout] Limit the size of explicit/implicit grid
1065         https://bugs.webkit.org/show_bug.cgi?id=136217
1066
1067         Reviewed by Andreas Kling.
1068
1069         Added a new unit test for the CSS parser. Right now it only checks
1070         that we properly clamp the maximum number of tracks on a grid to a
1071         maximum of 1 million.
1072
1073         * TestWebKitAPI/CMakeLists.txt:
1074         * TestWebKitAPI/PlatformEfl.cmake:
1075         * TestWebKitAPI/PlatformGTK.cmake:
1076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1077         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1078         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1079         (TestWebKitAPI::TEST): Added a
1080         CSSPropertyParserTest.GridTrackLimits test case.
1081
1082 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1083
1084         webkitpy test fix after r175867
1085         https://bugs.webkit.org/show_bug.cgi?id=138607
1086
1087         Reviewed by Philippe Normand.
1088
1089         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1090         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1091
1092 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1093
1094         webkitpy: demangle C++ symbols from crash log stderr
1095         https://bugs.webkit.org/show_bug.cgi?id=138565
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         * Scripts/webkitpy/port/linux_get_crash_log.py:
1100         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1101         with c++filt.
1102
1103 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1104
1105         [GTK] fix up the GDB backtrace report tool
1106         https://bugs.webkit.org/show_bug.cgi?id=138564
1107
1108         Reviewed by Carlos Garcia Campos.
1109
1110         * Scripts/webkitpy/port/gtk.py:
1111         (GtkPort._get_crash_log): Match the process name reported by the
1112         driver with the GTK port WebProcess executable filename.
1113         * Scripts/webkitpy/port/linux_get_crash_log.py:
1114         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1115         program.
1116         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1117         pattern to workaround the 16 characters size limit of %e.
1118
1119 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1120
1121         Unreviewed, moved myself to the list of committers.
1122
1123         * Scripts/webkitpy/common/config/contributors.json:
1124
1125 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1126
1127         [EFL] Fix the test font path after r175555.
1128
1129         Reviewed by Csaba Osztrogonác.
1130
1131         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1132
1133 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1134
1135         Fix the exception fuzz helper to generate targets in the correct range
1136         https://bugs.webkit.org/show_bug.cgi?id=138544
1137
1138         Reviewed by Filip Pizlo.
1139
1140         Currently, the script generates exception fuzz targets in the range of
1141         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1142         always outside of the outermost try block of the tests, which therefore
1143         prints unexpected output and results in false failures when fired at.
1144         Additionally, target $checkCount is never generated.
1145
1146         This patch fixes the script to generate targets in the range of
1147         2..$checkCount.
1148
1149         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1150
1151 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1152
1153         make-passwords-json.py should generarate everything needed for testing
1154         https://bugs.webkit.org/show_bug.cgi?id=138503
1155
1156         Reviewed by Ryosuke Niwa.
1157
1158         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1159         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1160         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1161         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1162         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1163         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1164         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1165
1166 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1167
1168         [GTK] generate-gtkdoc should ignore invalid files
1169         https://bugs.webkit.org/show_bug.cgi?id=138542
1170
1171         Reviewed by Darin Adler.
1172
1173         * gtk/generate-gtkdoc:
1174         (files_to_ignore.file_should_be_ignored): Return True to ignore
1175         invalid files.
1176
1177 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1178
1179         Delete cookies between tests
1180         https://bugs.webkit.org/show_bug.cgi?id=138528
1181
1182         Reviewed by Sam Weinig.
1183
1184         * DumpRenderTree/mac/DumpRenderTree.mm:
1185         (resetWebPreferencesToConsistentValues):
1186         * WebKitTestRunner/TestController.cpp:
1187         (WTR::TestController::resetPreferencesToConsistentValues):
1188         Do it.
1189
1190         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1191         (WTR::InjectedBundle::beginTesting):
1192         Added a FIXME.
1193
1194 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1195
1196         [GTK] Run layout tests using the network process
1197         https://bugs.webkit.org/show_bug.cgi?id=138428
1198
1199         Reviewed by Martin Robinson.
1200
1201         Shared secondary process is the default in the GTK+ port, but we
1202         should run the tests using the network process to ensure
1203         everything works with the network process. In the future, the
1204         shared secondary process model might be a special case of multiple
1205         processes with 1 as maximum number of processes, but always using
1206         the network process.
1207
1208         * WebKitTestRunner/TestController.cpp:
1209         (WTR::TestController::initialize):
1210
1211 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1212
1213         [GTK] Allow to create a view with a related page in WTR
1214         https://bugs.webkit.org/show_bug.cgi?id=138501
1215
1216         Reviewed by Martin Robinson.
1217
1218         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1219         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1220         related page to WKViewCreate.
1221         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1222         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1223         page to WKViewCreate.
1224
1225 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1226
1227         WTR crashes after running a test when NetworkProcess enabled
1228         https://bugs.webkit.org/show_bug.cgi?id=138500
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         WebNotificationProvider destructor is calling
1233         WKNotificationManagerSetProvider, but m_notificationManager is
1234         null because removeNotificationManager was already called.
1235
1236         * WebKitTestRunner/WebNotificationProvider.cpp:
1237         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1238         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1239
1240 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1241
1242         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1243         regarding incorrect call to PatchAnalysisTask.report_failure
1244         https://bugs.webkit.org/show_bug.cgi?id=138229
1245
1246         Reviewed by Daniel Bates.
1247
1248         * Scripts/webkitpy/common/net/layouttestresults.py:
1249         Makes sure test_results returns a list.
1250         (LayoutTestResults.test_results):
1251         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1252         Makes unit tests also check to make sure
1253         task.results_from_patch_test_run() and
1254         task.results_from_test_run_without_patch return instances of
1255         LayoutTestResults.
1256         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1257         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1258         Condenses duplicate code into _should_defer_patch_or_throw, and
1259         removes the now-unused _clean_tree_results member.
1260         (PatchAnalysisTask.__init__):
1261         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1262         (PatchAnalysisTask._should_defer_patch_or_throw):
1263         (PatchAnalysisTask._test_patch):
1264         (PatchAnalysisTask.results_from_patch_test_run):
1265         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1266         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1267         Removes needless call to results_from_test_run_without_patch
1268         (AbstractEarlyWarningSystem._failing_tests_message):
1269         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1270         Changes order of test failure messages to be in the order that they
1271         appear.
1272         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1273         * Scripts/webkitpy/tool/commands/queues.py:
1274         Removes needless call to results_from_test_run_without_patch.
1275         (CommitQueue._failing_tests_message):
1276         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1277         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1278
1279 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1280
1281         Unreviewed. Reorder my e-mail addresses in contributors.json
1282
1283         * Scripts/webkitpy/common/config/contributors.json:
1284
1285 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1286
1287         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1288         https://bugs.webkit.org/show_bug.cgi?id=138475
1289
1290         Reviewed by Ryosuke Niwa.
1291
1292         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1293         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1294         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1295         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1296
1297         * Scripts/webkitpy/common/checkout/scm/git.py:
1298         (Git._run_git_svn_find_rev):
1299         Add comment mentioning that svn_revisions need to begin with 'r'.
1300         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1301         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1302         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1303
1304 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1305
1306         [GTK] Add context menu API to Web Process Extensions
1307         https://bugs.webkit.org/show_bug.cgi?id=138311
1308
1309         Reviewed by Gustavo Noronha Silva.
1310
1311         Add tests cases for WebKitWebPage::context-menu signal.
1312
1313         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1314         (testContextMenuWebExtensionMenu):
1315         (testContextMenuWebExtensionNode):
1316         (beforeAll):
1317         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1318         (serializeContextMenu):
1319         (serializeNode):
1320         (contextMenuCallback):
1321         (pageCreatedCallback):
1322
1323 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1324
1325         Unreviewed, rolling out r175690.
1326         https://bugs.webkit.org/show_bug.cgi?id=138460
1327
1328         We are not ready to run layout tests using the network process
1329         yet (Requested by KaL on #webkit).
1330
1331         Reverted changeset:
1332
1333         "[GTK] Run layout tests using the network process"
1334         https://bugs.webkit.org/show_bug.cgi?id=138428
1335         http://trac.webkit.org/changeset/175690
1336
1337 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1338
1339         [GTK] Run layout tests using the network process
1340         https://bugs.webkit.org/show_bug.cgi?id=138428
1341
1342         Reviewed by Martin Robinson.
1343
1344         Shared secondary process is the default in the GTK+ port, but we
1345         should run the tests using the network process to ensure
1346         everything works with the network process. In the future, the
1347         shared secondary process model might be a special case of multiple
1348         processes with 1 as maximum number of processes, but always using
1349         the network process.
1350
1351         * WebKitTestRunner/TestController.cpp:
1352         (WTR::TestController::initialize):
1353
1354 2014-11-05  Dan Bernstein  <mitz@apple.com>
1355
1356         Remove the unused deletion UI feature
1357         https://bugs.webkit.org/show_bug.cgi?id=138442
1358
1359         Rubber-stamped by Alexey Proskuryakov.
1360
1361         * DumpRenderTree/mac/EditingDelegate.mm:
1362         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1363         delegate method that’s been removed.
1364
1365 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1366
1367         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1368         https://bugs.webkit.org/show_bug.cgi?id=138334
1369
1370         Reviewed by Anders Carlsson.
1371
1372         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1373         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1374         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1375         it also needs to reset internal focus explicitly.
1376
1377         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1378         WebKit behavior appears wrong, but it matches Firefox.
1379
1380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1381         (WTR::InjectedBundlePage::resetAfterTest):
1382
1383 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1384
1385         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1386         https://bugs.webkit.org/show_bug.cgi?id=137862
1387
1388         Reviewed by Gustavo Noronha Silva.
1389
1390         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1391         is emitted when a subresource load fails due to TLS errors.
1392
1393         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1394         (TLSSubresourceTest::resourceLoadStartedCallback):
1395         (TLSSubresourceTest::TLSSubresourceTest):
1396         (TLSSubresourceTest::subresourceFailedCallback):
1397         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1398         (TLSSubresourceTest::subresourceLoadStarted):
1399         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1400         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1401         (testSubresourceLoadFailedWithTLSErrors):
1402         (httpsServerCallback):
1403         (httpServerCallback):
1404         (beforeAll):
1405
1406 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1407
1408         Build fix for some compiler versions.
1409
1410         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1411         unhappy because this is a getter, and these shouldn't have side effects.
1412
1413 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1414
1415         Add a method for performing cherrypick-merges.
1416         https://bugs.webkit.org/show_bug.cgi?id=138375
1417
1418         Reviewed by Ryosuke Niwa.
1419
1420         Adds support for cherrypick-merges.
1421
1422         * Scripts/webkitpy/common/checkout/scm/git.py:
1423         (Git.cherrypick_merge): Added.
1424
1425 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1426
1427         Add a way to ascertain the SVN URL associated with a Git branch.
1428         https://bugs.webkit.org/show_bug.cgi?id=138374
1429
1430         Reviewed by Ryosuke Niwa.
1431
1432         The svn_url method returns the SVN URL associated with the current Git branch.
1433
1434         * Scripts/webkitpy/common/checkout/scm/git.py:
1435         (Git.svn_url): Added.
1436
1437 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1438
1439         Add the ability to search for modifications that are staged for commit.
1440         https://bugs.webkit.org/show_bug.cgi?id=138373
1441
1442         Reviewed by Ryosuke Niwa and Daniel Bates.
1443
1444         This makes is easy to do identify files that require merge post-processing,
1445         in addition to stand-alone utility.
1446
1447         * Scripts/webkitpy/common/checkout/scm/git.py:
1448         (Git.modifications_staged_for_commit): Added.
1449
1450 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1451
1452         Add a branch keyword argument to _run_git_svn_find_rev.
1453         https://bugs.webkit.org/show_bug.cgi?id=138372
1454
1455         Reviewed by Ryosuke Niwa.
1456
1457         The addition of this keyword argument allows clients to determine the Git hash
1458         of commits made on an SVN branch, provided that branch has been fetched locally.
1459
1460         * Scripts/webkitpy/common/checkout/scm/git.py:
1461         (Git._run_git_svn_find_rev):
1462         Add a branch keyword argument that is added to the end of the command, if present.
1463
1464 2014-11-04  Chris Dumez  <cdumez@apple.com>
1465
1466         Add ptr() method to Ref class
1467         https://bugs.webkit.org/show_bug.cgi?id=138361
1468
1469         Reviewed by Darin Adler.
1470
1471         Use the new Ref::ptr() method.
1472
1473         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1474         (TestWebKitAPI::TEST):
1475
1476 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1477
1478         [jhbuild] Make it possible to build GTK/EFL in same repository
1479         https://bugs.webkit.org/show_bug.cgi?id=137448
1480
1481         Reviewed by Martin Robinson.
1482
1483         * Scripts/webkitdirs.pm:
1484         (getJhbuildPath):
1485         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1486         (getPlatformFontsPath):
1487         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1488         (WTR::getFontsPath):
1489         * jhbuild/jhbuild-wrapper:
1490         (determine_platform):
1491         (install_jhbuild):
1492         * jhbuild/jhbuildrc_common.py:
1493         (init):
1494
1495 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1496
1497         [EFL] Bump LLVM to version 3.5.0
1498         https://bugs.webkit.org/show_bug.cgi?id=138312
1499
1500         Reviewed by Csaba Osztrogonác.
1501
1502         * efl/jhbuild.modules:
1503         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1504         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1505
1506 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1507
1508         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1509         https://bugs.webkit.org/show_bug.cgi?id=138257
1510
1511         Reviewed by Tim Horton.
1512         
1513         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1514         the user to toggle region page overlays on and off. Two overlays are available,
1515         for the non-fast scrollable region, and the region of element with wheel
1516         event handlers.
1517
1518         * MiniBrowser/mac/SettingsController.h:
1519         * MiniBrowser/mac/SettingsController.m:
1520         (-[SettingsController _populateMenu]):
1521         (-[SettingsController validateMenuItem:]):
1522         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1523         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1524         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1525         (-[SettingsController toggleDebugOverlay:]):
1526         (-[SettingsController debugOverlayVisible:]):
1527         * MiniBrowser/mac/WK2BrowserWindowController.m:
1528         (-[WK2BrowserWindowController didChangeSettings]):
1529
1530 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1531
1532         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1533         https://bugs.webkit.org/show_bug.cgi?id=138323
1534
1535         Reviewed by Zalan Bujtas.
1536
1537         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1538
1539 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1540
1541         [ninja] Don't remove response files for verbose builds
1542         https://bugs.webkit.org/show_bug.cgi?id=137816
1543
1544         Reviewed by Csaba Osztrogonác.
1545
1546         * Scripts/webkitdirs.pm:
1547         (determineNinjaVersion):
1548         (buildCMakeGeneratedProject):
1549
1550 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1551
1552         [GTK] Fix the build of FTL JIT
1553         https://bugs.webkit.org/show_bug.cgi?id=138298
1554
1555         Reviewed by Carlos Garcia Campos.
1556
1557         * gtk/jhbuild-optional.modules:
1558         Bump up LLVM version to 3.5.0 release and apply patches.
1559         * gtk/patches/llvm-elf-add-stackmaps.patch:
1560         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1561         trunk.
1562         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1563         Added. Ensures that PC-relative relocations in EH frames are not
1564         truncated to 32 bits on x86_64.
1565
1566 2014-10-31  Michael Saboff  <msaboff@apple.com>
1567
1568         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1569         https://bugs.webkit.org/show_bug.cgi?id=138268
1570
1571         Reviewed by Andreas Kling.
1572
1573         Added a --arch and --os option to set or override the values that are
1574         normally computed based on examining the JavaScriptCore we want to test.
1575
1576         * Scripts/run-jsc-stress-tests:
1577
1578 2014-10-31  Dan Bernstein  <mitz@apple.com>
1579
1580         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1581         https://bugs.webkit.org/show_bug.cgi?id=138259
1582
1583         Reviewed by Geoff Garen.
1584
1585         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1586         going to be empty to silence the warning.
1587
1588 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1589
1590         [GTK] Support script message handlers WebKitUserContentManager
1591         https://bugs.webkit.org/show_bug.cgi?id=133730
1592
1593         Reviewed by Carlos Garcia Campos.
1594
1595         Support user script message handlers in WebKitUserContentManager.
1596         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1597         an option is added to the CMake build files. The option is disabled
1598         globally by default, and the WebKitGTK port enables it. On the API
1599         level, two new methods to register and unregister names are provided
1600         in the "window.webkit" namespace, and on message reception the
1601         "WebKitUserContentManager::script-message-received" signal is
1602         emitted, using the registered names as signal detail.
1603
1604         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1605         Add test case for user script message handlers.
1606         (scriptMessageReceived):
1607         (testUserContentManagerScriptMessageReceived):
1608         (beforeAll):
1609
1610 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1611
1612         bisect-builds should support WebKit clients other than Safari
1613         https://bugs.webkit.org/show_bug.cgi?id=138225
1614
1615         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1616
1617         The -a / --application optional argument allows the user to specify which application (or application bundle)
1618         should be run against the WebKit nightly builds.
1619
1620         Reviewed by David Kilzer.
1621
1622         * Scripts/bisect-builds:
1623         Swap out $safariPath for the more general $applicationPath
1624         Leave --safari-path as a commandline option for backwards compatibility
1625         (mountAndRunNightly):
1626         Use File::Spec->cat correctly (one directory per argument)
1627         Use open --wait-apps instead of running the target application directly
1628
1629 2014-10-30  Dana Burkart  <dburkart@apple.com>
1630
1631         <rdar://problem/18821260> Perpare for the mysterious future
1632
1633         Reviewed by Lucas Forschler.
1634
1635         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1636         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1637         * LayoutTestRelay/Configurations/Base.xcconfig:
1638         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1639         * MiniBrowser/Configurations/Base.xcconfig:
1640         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1641         * TestWebKitAPI/Configurations/Base.xcconfig:
1642         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1643         * WebKitLauncher/Configurations/Base.xcconfig:
1644         * WebKitTestRunner/Configurations/Base.xcconfig:
1645         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1646
1647 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1648
1649         Update safariVersion to safariVersionString
1650         https://bugs.webkit.org/show_bug.cgi?id=138193
1651
1652         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1653         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1654
1655         Rubber-stamped by David Kilzer.
1656
1657         * Scripts/bisect-builds:
1658         (makeNightlyList):
1659         Compare safariVersionString to a string literal, instead of safariVersion.
1660
1661 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1662
1663         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1664         https://bugs.webkit.org/show_bug.cgi?id=137775
1665
1666         Reviewed by Carlos Garcia Campos.
1667
1668         * MiniBrowser/gtk/BrowserWindow.c:
1669         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1670         (browser_window_init):
1671
1672 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1673
1674         CommitQueue and EWS should reject any patches that result in consistent test
1675         failures that aren't present on the tree.
1676         https://bugs.webkit.org/show_bug.cgi?id=138184
1677
1678         Reviewed by Alexey Proskuryakov.
1679
1680         * Scripts/webkitpy/layout_tests/models/test_results.py:
1681         Adds a simple hashing function to allow for set operations to handle
1682         TestResult objects properly.
1683         (TestResult.__hash__):
1684         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1685         Adds one unit test, and modifies others to agree with the notion that
1686         patches that introduce new test failures (but also have flakyness)
1687         should be rejected rather than spin.
1688         (MockCommitQueue.report_flaky_tests):
1689         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1690         (test_double_flaky_test_failure):
1691         (test_two_flaky_tests):
1692         (test_very_flaky_patch):
1693         (test_very_flaky_patch_with_some_tree_redness):
1694         (test_different_test_failures):
1695         (test_different_test_failures_with_some_tree_redness):
1696         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1697         (test_mildly_flaky_patch):
1698         (test_mildly_flaky_patch_with_some_tree_redness):
1699         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1700         Makes PatchAnalysisTask reject said patches.
1701         (PatchAnalysisTask._test_patch):
1702
1703 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1704
1705         WinCairoRequirements.zip cannot be downloaded from dropbox
1706         https://bugs.webkit.org/show_bug.cgi?id=138113
1707
1708         Reviewed by Alexey Proskuryakov.
1709
1710         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1711
1712 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
1713
1714         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1715         https://bugs.webkit.org/show_bug.cgi?id=138193
1716
1717         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1718         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1719
1720         It also does a bit of refactoring, including distinguishing between versions and version strings and
1721         saving versions to local variables instead of using eval in each conditional.
1722
1723         Reviewed by David Kilzer.
1724
1725         * Scripts/bisect-builds:
1726         (makeNightlyList):
1727         Restrict the set of nightlies to r174650 and above when running Yosemite.
1728         Restrict the set of nightlies to r157846 and above when running Mavericks.
1729         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1730
1731 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1732
1733         [EFL] build-webkit should try harder to avoid re-running cmake
1734         https://bugs.webkit.org/show_bug.cgi?id=137949
1735
1736         Reviewed by Martin Robinson.
1737
1738         * Scripts/webkitdirs.pm:
1739         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1740         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1741
1742 2014-10-28  Daniel Bates  <dabates@apple.com>
1743
1744         Unify logic in RunTests.run() to run the Python unit tests
1745         https://bugs.webkit.org/show_bug.cgi?id=138160
1746
1747         Reviewed by Martin Robinson.
1748
1749         Unify the interactive and non-interactive code path for running the Python unit tests
1750         in step RunTests so as to remove duplicate code to compute the the path to the script
1751         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1752
1753         No new tests since no functionality was changed.
1754
1755         * Scripts/webkitpy/port/base.py:
1756         (Port.python_unittest_results_directory):
1757         * Scripts/webkitpy/tool/steps/runtests.py:
1758         (RunTests.run):
1759
1760 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
1761
1762         Make runtest.py call test-webkitpy with the --json flag when in
1763         non-interactive mode.
1764         https://bugs.webkit.org/show_bug.cgi?id=137667
1765
1766         Reviewed by Daniel Bates.
1767
1768         * Scripts/webkitpy/port/base.py:
1769         Adds the python_unittest_results_directory method.
1770         (Port.python_unittest_results_directory):
1771         * Scripts/webkitpy/tool/steps/runtests.py:
1772         Changes RunTests to call test-webkitpy with the --json flag if the
1773         --non-interactive flag is set.
1774         (RunTests):
1775         (RunTests.run):
1776
1777 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
1778
1779         import-w3c-tests should use re.escape() wherever it's handling file paths
1780         https://bugs.webkit.org/show_bug.cgi?id=137934
1781
1782         This patch adds re.escape() to a few places where we're doing string
1783         conversions. This prevents errors when attribute values coincidentally
1784         have character sequences that can be interpreted as regular expressions.
1785
1786         Reviewed by Bem Jones-Bey.
1787
1788         * Scripts/webkitpy/w3c/test_converter.py:
1789         (_W3CTestConverter.convert_attributes_if_needed):
1790
1791 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1792
1793         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1794         https://bugs.webkit.org/show_bug.cgi?id=138130
1795
1796         Reviewed by Csaba Osztrogonác.
1797
1798         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1799
1800 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
1801
1802         Fix link to Arch Linux Wiki
1803         https://bugs.webkit.org/show_bug.cgi?id=138010
1804
1805         Reviewed by Benjamin Poulain.
1806
1807         * gtk/install-dependencies:
1808
1809 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
1810
1811         Test regressions are not detected when image result is missing
1812         https://bugs.webkit.org/show_bug.cgi?id=138070
1813
1814         Reviewed by Simon Fraser.
1815
1816         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1817         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1818         Count these as regressions, not as flaky tests.
1819
1820         * Scripts/webkitpy/port/test.py:
1821         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1822         Test it.
1823
1824 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
1825
1826         Add Conrad Shultz to the contributors list.
1827
1828         * Scripts/webkitpy/common/config/contributors.json:
1829
1830 2014-10-24  Dan Bernstein  <mitz@apple.com>
1831
1832         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
1833         https://bugs.webkit.org/show_bug.cgi?id=138046
1834
1835         Reviewed by Alexey Proskuryakov.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1838         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
1839         401. Otherwise, we’ll retry normally in 45 seconds.
1840
1841 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1842
1843         [GTK] Implement is_selected method on WebKitHitTestResult
1844         https://bugs.webkit.org/show_bug.cgi?id=137110
1845
1846         Reviewed by Tim Horton.
1847
1848         Add tests for new context SELECTION on WebKitHitTestResult.
1849
1850         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1851         (testContextMenuDefaultMenu):
1852         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1853         (testWebViewMouseTarget):
1854
1855 2014-10-23  Roger Fong  <roger_fong@apple.com>
1856
1857         [Win] Skip failing JSC tests following r175078
1858         https://bugs.webkit.org/show_bug.cgi?id=130967.
1859
1860         * Scripts/run-javascriptcore-tests:
1861
1862 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1863
1864         commitqueuetask_unittest.py should be made more concise.
1865         https://bugs.webkit.org/show_bug.cgi?id=137985
1866
1867         Reviewed by Alexey Proskuryakov.
1868
1869         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1870         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
1871         (MockCommitQueue.__init__):
1872         (MockCommitQueue.report_flaky_tests):
1873         (MockCommitQueue):
1874         (MockCommitQueue.get_reported_flaky_tests):
1875         (MockSimpleTestPlanCommitQueue.__init__):
1876         (MockSimpleTestPlanCommitQueue.run_command):
1877         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
1878         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1879         (test_land_failure):
1880         (test_failed_archive):
1881         (test_double_flaky_test_failure):
1882         (test_test_failure):
1883         (test_red_test_failure):
1884         (test_very_red_tree_retry):
1885         (test_red_tree_patch_rejection):
1886         (test_one_flaky_test):
1887         (test_tree_more_red_than_patch):
1888         (MockCommitQueue.test_results): Deleted.
1889         (test_simple_flaky_test_failure): Deleted.
1890         (_expect_validate): Deleted.
1891         (_expect_validate.MockDelegate): Deleted.
1892         (_expect_validate.MockDelegate.refetch_patch): Deleted.
1893         (_expect_validate.MockDelegate.expected_failures): Deleted.
1894         (_mock_patch): Deleted.
1895         (test_validate): Deleted.
1896         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1897         Fixes a bug that slipped through the cracks prior to this change.
1898         (PatchAnalysisTask._test_patch):
1899
1900 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
1901
1902         Flakiness dashboard should support OS X Yosemite
1903         https://bugs.webkit.org/show_bug.cgi?id=137986
1904
1905         Reviewed by Ryosuke Niwa.
1906
1907         * TestResultServer/app.yaml:
1908         * TestResultServer/static-dashboards/builders.jsonp:
1909         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1910
1911 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1912
1913         commitqueuetask should include more tests to ensure that the behavior
1914         of PatchAnalysisTask._test_patch() is well defined
1915         https://bugs.webkit.org/show_bug.cgi?id=137977
1916
1917         Reviewed by Alexey Proskuryakov.
1918
1919         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1920         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1921         and more readable to define tests that are meant to test the behaviour
1922         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1923         (FailingTestCommitQueue.test_results):
1924         (PatchAnalysisResult):
1925         (MockSimpleTestPlanCommitQueue):
1926         (MockSimpleTestPlanCommitQueue.__init__):
1927         (MockSimpleTestPlanCommitQueue.run_command):
1928         (MockSimpleTestPlanCommitQueue._mock_test_result):
1929         (MockSimpleTestPlanCommitQueue.test_results):
1930         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1931         (test_flaky_test_failure):
1932         (test_failed_archive):
1933         (test_two_flaky_tests):
1934         (test_one_flaky_test):
1935         (test_very_flaky_patch):
1936         (test_very_flaky_patch_with_some_tree_redness):
1937         (test_different_test_failures):
1938         (test_different_test_failures_with_some_tree_redness):
1939         (test_mildly_flaky_patch):
1940         (test_mildly_flaky_patch_with_some_tree_redness):
1941         (test_tree_more_red_than_patch):
1942
1943 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1944
1945         PatchAnalysisTask._test_patch() needs refactoring
1946         https://bugs.webkit.org/show_bug.cgi?id=137904
1947
1948         Reviewed by Alexey Proskuryakov.
1949
1950         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1951         Fixes several small bugs, and makes minor changes to accomodate the
1952         changes in PatchAnalysisTask.
1953         (MockCommitQueue.refetch_patch):
1954         (MockCommitQueue.test_results):
1955         (test_flaky_test_failure):
1956         (test_failed_archive):
1957         (test_very_red_tree_retry):
1958         (_expect_validate.MockDelegate.refetch_patch):
1959         (MockCommitQueue.expected_failures): Deleted.
1960         (_expect_validate.MockDelegate.expected_failures): Deleted.
1961         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1962         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1963         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1964         Removes the unexpected_failures member, adds the _clean_tree_results
1965         member, adds a helper function for _test_patch, and refactors
1966         _test_patch to be more readable.
1967         (PatchAnalysisTask.__init__):
1968         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1969         (PatchAnalysisTask._test_patch):
1970         (PatchAnalysisTask.results_from_test_run_without_patch):
1971         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1972         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1973         (AbstractEarlyWarningSystem.begin_work_queue):
1974         (AbstractEarlyWarningSystem._failing_tests_message):
1975         (AbstractEarlyWarningSystem.command_failed):
1976         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1977         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1978         Makes changes to accomodate the changes made to PatchAnalysisTask.
1979         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1980         * Scripts/webkitpy/tool/commands/perfalizer.py:
1981         Removes Perfalizer's dependancy on ExpectedFailures. 
1982         (PerfalizerTask.refetch_patch):
1983         (PerfalizerTask.expected_failures): Deleted.
1984         * Scripts/webkitpy/tool/commands/queues.py:
1985         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1986         initializer to allow for mock injection.
1987         (CommitQueue.__init__):
1988         (CommitQueue.begin_work_queue):
1989         (CommitQueue.process_work_item):
1990         (CommitQueue._failing_tests_message):
1991         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1992         Removes dependancy on ExpectedFailures, and instead uses mock
1993         injection.
1994         (MockCommitQueueTask):
1995         (MockCommitQueueTask.results_from_patch_test_run):
1996         (MockCommitQueueTask.results_from_test_run_without_patch):
1997         (mock_run_webkit_patch):
1998
1999 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2000
2001         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2002         https://bugs.webkit.org/show_bug.cgi?id=136736
2003
2004         Reviewed by Gyuyoung Kim.
2005
2006         * MiniBrowser/efl/main.c:
2007         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2008         (window_create):
2009
2010 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2011
2012         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2013         https://bugs.webkit.org/show_bug.cgi?id=137884
2014
2015         Reviewed by Gustavo Noronha Silva.
2016
2017         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2018         and adapt it to use the new InputMethodFilter WebKit class. Instead
2019         of having virtual methods just for testing, it has a testing mode
2020         that logs the events.
2021
2022         * TestWebKitAPI/PlatformGTK.cmake:
2023         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2024         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2025         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2026         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2027         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2028         (TestWebKitAPI::TEST):
2029         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2030         (TestWebKitAPI::temporaryResetOverride):
2031         (TestWebKitAPI::verifyCanceledComposition):
2032
2033 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2034
2035         build.webkit.org/dashboard: Cannot click on green tester bubbles
2036         https://bugs.webkit.org/show_bug.cgi?id=137909
2037
2038         Reviewed by Darin Adler.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2041         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2042
2043 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2044
2045         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2046         https://bugs.webkit.org/show_bug.cgi?id=137932
2047
2048         Reviewed by Simon Fraser.
2049
2050         This is the first step in moving over to native Windows rendering for our layout tests.
2051         Once this change lands, approximately 300 tests will start failing on Windows. I will
2052         rebaseline these changes against our test hardware and update this bug with the
2053         commits related to that work.
2054
2055         * DumpRenderTree/win/DumpRenderTree.cpp:
2056         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2057         we use native Windows drawing style.
2058
2059 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2060
2061         Fix FTL Native Inlining for EFL
2062         https://bugs.webkit.org/show_bug.cgi?id=137774
2063
2064         Reviewed by Michael Saboff.
2065
2066         Added Clang as an optional module to jhbuild.
2067
2068         * efl/jhbuild.modules:
2069
2070 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2071
2072         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2073         https://bugs.webkit.org/show_bug.cgi?id=137832
2074
2075         Reviewed by Carlos Garcia Campos.
2076
2077         Ensure each test sets the TLS errors policy that it really needs.
2078         Have each test except testTLSErrorsPolicy stash and restore the original
2079         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2080         default policy.
2081
2082         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2083         (testSSL):
2084         (testInsecureContent):
2085         (testTLSErrorsPolicy):
2086         (testTLSErrorsRedirect):
2087         (testTLSErrorsHTTPAuth):
2088         (testLoadFailedWithTLSErrors):
2089         (beforeAll):
2090
2091 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2092
2093         Unreviewed. Unskip inspector server unit tests.
2094
2095         They should pass now.
2096
2097         * Scripts/run-gtk-tests:
2098         (TestRunner):
2099
2100 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2101
2102         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2103         https://bugs.webkit.org/show_bug.cgi?id=132044
2104
2105         Reviewed by Brian Burg.
2106
2107         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2108         (openRemoteDebuggingSession): Remove trailing slash when
2109         concatenating base inspector URL with the page, because the
2110         inspector returns the relative paths with a leading slash.
2111
2112 2014-10-20  Tanay C  <tanay.c@samsung.com>
2113
2114         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2115         https://bugs.webkit.org/show_bug.cgi?id=137023
2116
2117         Reviewed by Gyuyoung Kim.
2118
2119         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2120         (search_box_show): Modified.
2121         (search_box_hide): Modified.
2122         (on_search_field_activated): Modified.
2123         (on_search_backward_button_clicked): Modified.
2124         (on_search_forward_button_clicked): Modified.
2125         (on_search_case_option_changed): Added.
2126         (on_search_word_start_option_changed): Added.
2127         (window_create): Modified.
2128
2129 2014-10-20  Tanay C  <tanay.c@samsung.com>
2130
2131         [GTK][Minibrowser] Escape key does not hide the search box
2132         https://bugs.webkit.org/show_bug.cgi?id=137734
2133
2134         Reviewed by Philippe Normand.
2135
2136         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2137         (stopPageLoad): Modified.
2138
2139 2014-10-18  Antti Koivisto  <antti@apple.com>
2140
2141         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2142         https://bugs.webkit.org/show_bug.cgi?id=137855
2143
2144         Reviewed by Dan Bernstein.
2145
2146         Test and warn if the dumped response mime type differs from the platform response mime type.
2147
2148         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2149         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2150         (WTR::InjectedBundlePage::platformResponseMimeType):
2151         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2152         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2153         (WTR::InjectedBundlePage::platformResponseMimeType):
2154
2155 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2156
2157         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2158         https://bugs.webkit.org/show_bug.cgi?id=137835
2159
2160         Reviewed by Andreas Kling.
2161
2162         * Scripts/run-inspector-perf-tests.py: Removed.
2163         This script is stale, as PerformanceTests/inspector no longer exists.
2164
2165 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2166
2167         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2168
2169         * Scripts/webkitpy/port/ios.py:
2170         (IOSSimulatorPort.default_baseline_search_path):
2171
2172 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2173
2174         [iOS] Simplify test fallback paths for iOS Simulator testing
2175         https://bugs.webkit.org/show_bug.cgi?id=137830
2176
2177         Reviewed by Zalan Bujtas.
2178         
2179         Make the fallback paths be:
2180             ios-simulator -> generic
2181             ios-simulator-wk2->ios-simulator -> generic
2182         
2183         so don't include mac in the fallback path. Also remove the
2184         version handling for simplicity.
2185
2186         * Scripts/webkitpy/port/ios.py:
2187         (IOSSimulatorPort):
2188         (IOSSimulatorPort.default_baseline_search_path):
2189
2190 2014-10-17  Dana Burkart  <dburkart@apple.com>
2191
2192         Fix typos in the dashboard config file.
2193
2194         Unreviewed.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2197         (WebKitBuildbot):
2198
2199 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2200
2201         [Win] Allow WinLauncher to specify Custom User Agent strings
2202         https://bugs.webkit.org/show_bug.cgi?id=137828
2203
2204         Reviewed by Dean Jackson.
2205
2206         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2207         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2208         and set the user agent strings.
2209         * WinLauncher/WinLauncher.h:
2210         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2211         resources and dialog for setting custom User Agent strings.
2212         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2213
2214 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2215
2216         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2217         https://bugs.webkit.org/show_bug.cgi?id=137806
2218
2219         Reviewed by Sam Weinig.
2220
2221         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2222         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2223         to disable font autosizing.
2224         
2225         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2226         test controller to set platform-specific prefs.
2227
2228         * WebKitTestRunner/TestController.cpp:
2229         (WTR::TestController::resetPreferencesToConsistentValues):
2230         (WTR::TestController::platformResetPreferencesToConsistentValues):
2231         * WebKitTestRunner/TestController.h:
2232         * WebKitTestRunner/ios/TestControllerIOS.mm:
2233         (WTR::TestController::platformResetPreferencesToConsistentValues):
2234         * WebKitTestRunner/mac/TestControllerMac.mm:
2235         (WTR::TestController::platformResetPreferencesToConsistentValues):
2236
2237 2014-10-16  Dan Bernstein  <mitz@apple.com>
2238
2239         OSObjectPtr is missing leakRef()
2240         https://bugs.webkit.org/show_bug.cgi?id=137798
2241
2242         Reviewed by Sam Weinig.
2243
2244         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2245         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2246
2247 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2248
2249         Update target platform to remove Leopard, Snow Leopard, Lion.
2250         Add Yosemite. 
2251         
2252         Unreviewed.
2253
2254         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2255         (_should_file_trigger_build):
2256
2257 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2258
2259         commit-queue: fails to replace OO-PS! with reviewer name
2260         <http://webkit.org/b/137795>
2261
2262         Reviewed by Alexey Proskuryakov.
2263
2264         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2265         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2266         email addresses to unauthenticated page loads, so we must always
2267         authenticate before getting bug data so we get full email
2268         addresses.
2269
2270 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2271
2272         commit-queue: fails to close bugs after successfully landing patches
2273         <http://webkit.org/b/137794>
2274
2275         Reviewed by Alexey Proskuryakov.
2276
2277         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2278         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2279         tell Mechanize to use the second <textarea> on the page with
2280         name="comment".
2281
2282 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2283
2284         [Win] Update DRT to match Mac Logic
2285         https://bugs.webkit.org/show_bug.cgi?id=137787
2286
2287         Reviewed by Dean Jackson.
2288
2289         * DumpRenderTree/win/DumpRenderTree.cpp:
2290         (initialize): 0 -> nullptr
2291         (runTest): Initialize MSG structure before using.
2292         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2293         Also, cleanly shut down COM when exiting.
2294         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2295         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2296         header and add printf to match Mac.
2297         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2298         * DumpRenderTree/win/FrameLoadDelegate.h:
2299         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2300         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2301         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2302         (isLocalhost): Added.
2303         (hostIsUsedBySomeTestsToGenerateError): Added.
2304         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2305         of certain error and redirect host names.
2306         * DumpRenderTree/win/UIDelegate.cpp:
2307         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2308         anything should be output to the console. This modifies behavior to match the Mac.
2309         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2310         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2311         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2312         (UIDelegate::webViewAddMessageToConsole): Ditto.
2313         * WinLauncher/PageLoadTestClient.cpp:
2314         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2315         added last week.
2316
2317 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2318
2319         Unreviewed, rolling out r174754.
2320         https://bugs.webkit.org/show_bug.cgi?id=137789
2321
2322         Speculative fix for Windows test was ineffective. (Requested
2323         by rfong on #webkit).
2324
2325         Reverted changeset:
2326
2327         "[Windows] Add some more logging to debug Windows test
2328         issues."
2329         http://trac.webkit.org/changeset/174754
2330
2331 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2332
2333         Unreviewed, add myself to CoordinatedGraphics watchers.
2334
2335         * Scripts/webkitpy/common/config/watchlist:
2336
2337 2014-10-15  Roger Fong  <roger_fong@apple.com>
2338
2339         [Windows] Speculative Windows test fix.
2340
2341         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2342
2343 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2344
2345         import-w3c-test rewrites relative src paths in ref files incorrectly
2346         https://bugs.webkit.org/show_bug.cgi?id=137586
2347
2348         This patch fixes a bug in test_converter.py where src paths were getting 
2349         rewritten as ../../some-path instead of <script src="../../some-path>". 
2350         It also adds support for rewriting src paths in style  elements, which was 
2351         missing before and it adds tests for this case.
2352
2353         Reviewed by Bem Jones-Bey.
2354
2355         * Scripts/webkitpy/w3c/test_converter.py:
2356         (_W3CTestConverter.convert_attributes_if_needed):
2357         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2358         (test_convert_attributes_if_needed):
2359         (verify_reference_relative_paths):
2360
2361 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2362
2363         Add --json flag to test-webkitpy to emit JSON formatted test results
2364         to stdout
2365         https://bugs.webkit.org/show_bug.cgi?id=137353
2366
2367         Reviewed by Daniel Bates.
2368
2369         * Scripts/webkitpy/port/server_process_unittest.py:
2370         Adds the read method to MockFile to allow the stdout of test_webkitpy
2371         to be redirected without causing erroneous test failures.
2372         In particular,
2373         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2374         and
2375         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2376         because when redirecting to a file, the
2377         _wait_for_data_and_update_buffers_using_select method in 
2378         server_process.py will find that there is a read file descriptor in
2379         its call to select.select, which eventually leads to it calling read()
2380         on the MockFile object.
2381         (MockFile.read):
2382         * Scripts/webkitpy/test/main.py:
2383         Adds the _print_results_as_json method and the --json flag which
2384         determines whether _print_results_as_json will get called.
2385         (Tester._parse_args):
2386         (Tester._print_results_as_json):
2387         (Tester._print_results_as_json.result_dict_from_tuple):
2388         (Tester._run_tests):
2389
2390 2014-10-13  David Farler  <dfarler@apple.com>
2391
2392         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2393         https://bugs.webkit.org/show_bug.cgi?id=137662
2394
2395         Reviewed by Darin Adler.
2396
2397         The layout test harness can close LayoutTestRelay's subprocess
2398         stdout and stderr in the case of a timeout or if a run is
2399         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2400         finds that no one is listening to its stdout/stderr (broken
2401         pipe), then just exit(1), there is nothing to report.
2402
2403         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2404         (-[LTRelayController didReceiveStdoutData:]):
2405         Add @try/@catch for NSFileHandleOperationException.
2406         (-[LTRelayController didReceiveStderrData:]):
2407         Add @try/@catch for NSFileHandleOperationException.
2408
2409 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2410
2411         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2412         https://bugs.webkit.org/show_bug.cgi?id=137060
2413
2414         Reviewed by Philippe Normand.
2415
2416         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2417
2418         * MiniBrowser/gtk/BrowserWindow.c:
2419         (zoomInCallback):
2420         (zoomOutCallback):
2421         (defaultZoomCallback): Callback for default zoom keyboard support.
2422         (browser_window_init):
2423
2424 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2425
2426         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2427
2428         Reviewed by Alexey Proskuryakov.
2429         
2430         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2431         logging to stderr to get associated with the next test.
2432         
2433         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2434
2435         * DumpRenderTree/mac/DumpRenderTree.mm:
2436         (dumpTestResults):
2437         (runTest):
2438
2439 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2440
2441         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2442
2443         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2444
2445 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2446
2447         [cmake] Fix the make build after r174683
2448         https://bugs.webkit.org/show_bug.cgi?id=137703
2449
2450         Reviewed by Martin Robinson.
2451
2452         * Scripts/webkitdirs.pm:
2453         (buildCMakeGeneratedProject):
2454
2455 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2456
2457         Adding myself to the watchlist to CachedFont
2458
2459         Unreviewed.
2460
2461         * Scripts/webkitpy/common/config/watchlist:
2462
2463 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2464
2465         [EFL][GTK] Make it possible to get verbose output with ninja
2466         https://bugs.webkit.org/show_bug.cgi?id=137606
2467
2468         Reviewed by Csaba Osztrogonác.
2469
2470         * Scripts/webkitdirs.pm:
2471         (buildCMakeGeneratedProject):
2472
2473 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2474
2475         [EFL] Make it possible to use ninja for EFL build too
2476         https://bugs.webkit.org/show_bug.cgi?id=137605
2477
2478         Reviewed by Csaba Osztrogonác.
2479
2480         * Scripts/webkitdirs.pm:
2481         (generateBuildSystemFromCMakeProject):
2482         * efl/install-dependencies:
2483
2484 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2485
2486         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2487         https://bugs.webkit.org/show_bug.cgi?id=137486
2488
2489         Reviewed by Philippe Normand.
2490
2491         * MiniBrowser/gtk/BrowserWindow.c:
2492         (loadHomePage): Callback for home page load.
2493         (browser_window_init):
2494         * MiniBrowser/gtk/BrowserWindow.h:
2495         * MiniBrowser/gtk/main.c:
2496         (main):
2497
2498 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2499
2500         import-w3c-tests doesn't prefix property values
2501         https://bugs.webkit.org/show_bug.cgi?id=137600
2502
2503         Reviewed by Bem Jones-Bey.
2504
2505         Some property values are prefixed in WebKit. Modified the W3C import
2506         script in order to prefix property values and not only properties.
2507         The patch re-uses most of the already existent logic to prefix
2508         properties.
2509
2510         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2511         from CSSValueKeywords.in and adapt converter to modify both properties
2512         and property values.
2513         (convert_for_webkit):
2514         (_W3CTestConverter.__init__):
2515         (_W3CTestConverter.output):
2516         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2517         (_W3CTestConverter):
2518         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2519         (_W3CTestConverter.add_webkit_prefix_following_regex):
2520         (_W3CTestConverter.convert_reference_relpaths):
2521         (_W3CTestConverter.convert_style_data):
2522         (_W3CTestConverter.convert_attributes_if_needed):
2523         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2524         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2525         include checks for property values too.
2526         (W3CTestConverterTest.test_read_prefixed_property_list):
2527         (verify_no_conversion_happened):
2528         (verify_prefixed_properties):
2529         (verify_prefixed_property_values):
2530         (generate_test_content_properties_and_values):
2531         (generate_test_content):
2532         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2533         prefixed property values and inform about them.
2534         (TestImporter.import_tests):
2535         (TestImporter.write_import_log):
2536
2537 2014-10-13  Jer Noble  <jer.noble@apple.com>
2538
2539         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2540         https://bugs.webkit.org/show_bug.cgi?id=137533
2541
2542         Reviewed by Andy Estes.
2543
2544         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2545
2546         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2547         (TestWebKitAPI::isMSEEnabledCallback):
2548         (TestWebKitAPI::TEST):
2549
2550 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2551
2552         [Win] Implement a page load profiling tool
2553         https://bugs.webkit.org/show_bug.cgi?id=137673
2554
2555         Reviewed by Dean Jackson.
2556
2557         Add a tool to capture and summarize page load statistics.
2558
2559         * WinLauncher/Common.cpp:
2560         (parseCommandLine): Move from WinMain.cpp so that it can
2561         be shared with internal tools.
2562         * WinLauncher/PageLoadTestClient.cpp: Added.
2563         (PageLoadTestClient::PageLoadTestClient):
2564         (PageLoadTestClient::pageLoadStartedAtTime):
2565         (PageLoadTestClient::didStartProvisionalLoad):
2566         (PageLoadTestClient::didCommitLoad):
2567         (PageLoadTestClient::didFirstLayoutForMainFrame):
2568         (PageLoadTestClient::didHandleOnLoadEvents):
2569         (PageLoadTestClient::didFinishLoad):
2570         (PageLoadTestClient::didFailLoad):
2571         (PageLoadTestClient::didInitiateResourceLoad):
2572         (PageLoadTestClient::didEndResourceLoad):
2573         (PageLoadTestClient::pageLoadEndedAtTime):
2574         (PageLoadTestClient::endPageLoad):
2575         (PageLoadTestClient::clearPageLoadState):
2576         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2577         (PageLoadTestClient::maybeEndPageLoadSoon):
2578         (PageLoadTestClient::setPageURL):
2579         (PageLoadTestClient::dumpRunStatistics):
2580         * WinLauncher/PrintWebUIDelegate.cpp:
2581         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2582         nullptr URL properly.
2583         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2584         (ResourceLoadDelegate::QueryInterface):
2585         (ResourceLoadDelegate::AddRef):
2586         (ResourceLoadDelegate::Release):
2587         (ResourceLoadDelegate::identifierForInitialRequest):
2588         (ResourceLoadDelegate::willSendRequest):
2589         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2590         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2591         (ResourceLoadDelegate::didReceiveResponse):
2592         (ResourceLoadDelegate::didReceiveContentLength):
2593         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2594         (ResourceLoadDelegate::didFailLoadingWithError):
2595         (ResourceLoadDelegate::plugInFailedWithError):
2596         * WinLauncher/ResourceLoadDelegate.h: Added.
2597         (ResourceLoadDelegate::ResourceLoadDelegate):
2598         * WinLauncher/WinLauncher.cpp:
2599         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2600         page loading statistics.
2601         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2602         and set private load delegate state.
2603         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2604         that sets the view's resource load delegate.
2605         (WinLauncher::loadURL): If no URL is passed, load the test document.
2606         * WinLauncher/WinLauncher.h:
2607         (WinLauncher::pageLoadTestClient):
2608         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2609         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2610         * WinLauncher/WinLauncherWebHost.cpp:
2611         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2612         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2613         it could be used from other source files.
2614         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2615         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2616         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2617         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2618         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2619         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2620         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2621         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2622         * WinLauncher/WinLauncherWebHost.h:
2623         * WinLauncher/WinMain.cpp:
2624         (wWinMain): Create and use new delegates for gathering page load data.
2625         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2626
2627 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2628
2629         Improve the test image diffs page
2630         https://bugs.webkit.org/show_bug.cgi?id=137674
2631
2632         Reviewed by Alexey Proskuryakov.
2633         
2634         Don't treat the input file as a format string, otherwise we have to escape special
2635         characters. Just do a couple of replaces.
2636
2637         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2638         (TestResultWriter.write_image_diff_files):
2639
2640 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2641
2642         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2643         https://bugs.webkit.org/show_bug.cgi?id=137659
2644
2645         Reviewed by Martin Robinson.
2646
2647         * Scripts/webkitpy/port/xvfbdriver.py:
2648         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2649
2650 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2651
2652         Add more detailed wait time information to EWS metrics
2653         https://bugs.webkit.org/show_bug.cgi?id=137649
2654
2655         Reviewed by Daniel Bates.
2656
2657         Added average and worst time (we used to only have median), and also a percentage
2658         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2659
2660         There is always some wait due to the polling nature of the queues, which is well understood
2661         and doesn't need to be measured. What needs to be measured is whether there is enough
2662         bot machines to process patches as soon as they are submitted.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2665         (Analyzer.prototype._analyzeBubblePerformance):
2666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2667         (MetricsBubbleView.prototype._update):
2668
2669 2014-10-11  Jer Noble  <jer.noble@apple.com>
2670
2671         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2672         https://bugs.webkit.org/show_bug.cgi?id=137533
2673
2674         Reviewed by Darin Adler.
2675
2676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2677         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2678         (TestWebKitAPI::TEST):
2679         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2680         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2681
2682 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2683
2684         iOS DRT snapshots are limited to the page visible area
2685         https://bugs.webkit.org/show_bug.cgi?id=137650
2686
2687         Reviewed by Daniel Bates.
2688         
2689         LegacyTileCache drawing was limited to the window's visible area, found by
2690         crawling up the layer hierarchy to the root layer. This caused test snapshots to
2691         be missing non-composited content outside the iPhone visible area, which hinders
2692         testing.
2693         
2694         Fix by adding a test-only mode where the window visible area is the entire window.
2695         
2696         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2697         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2698         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2699         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2700         for the DRT window.
2701         
2702
2703 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
2704
2705         Page not fully rendered in iOS DRT snapshots
2706         https://bugs.webkit.org/show_bug.cgi?id=137638
2707
2708         Reviewed by Tim Horton.
2709         
2710         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2711         to ensure that the page has laid out and is rendered by the time we take
2712         the snapshot.
2713
2714         * DumpRenderTree/mac/DumpRenderTree.mm:
2715         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2716         (-[DumpRenderTree _webThreadInvoked]): Moved.
2717         (-[DumpRenderTree _waitForWebThreadThenDump]):
2718         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2719         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2720         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2721         relies on dispatch_async too, and the inner block won't complete until the outer block
2722         has completed.
2723         (dumpTestResults): Move the guts of dump() here.
2724         (runTest): Whitespace.
2725
2726 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
2727
2728         Adding svn:ignore so that .pyc files don't show up as new.
2729
2730         * Scripts/webkitpy/xcode: Added property svn:ignore.
2731
2732 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
2733
2734         [EFL] Introduce EWebKit_Extension
2735         https://bugs.webkit.org/show_bug.cgi?id=134921
2736
2737         Reviewed by Gyuyoung Kim.
2738
2739         * MiniBrowser/efl/main.c: Added x option to test extension path.
2740         (window_create):
2741         (elm_main):
2742         * Scripts/webkitpy/common/config/watchlist:
2743         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2744         * Scripts/webkitpy/style/checker.py:
2745         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2746
2747 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
2748
2749         After r174628 we send the test process a SIGTERM before the SIGKILL.
2750
2751         * Scripts/webkitpy/common/system/executive_unittest.py:
2752         (ExecutiveTest.serial_test_kill_process):
2753
2754 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
2755
2756         [EFL] Enable WebP support.
2757         https://bugs.webkit.org/show_bug.cgi?id=136156
2758
2759         Reviewed by Gyuyoung Kim.
2760
2761         Include libwebp-dev package to support WebP for WK2 Efl.
2762
2763         * efl/install-dependencies:
2764
2765 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2766
2767         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2768         https://bugs.webkit.org/show_bug.cgi?id=137485
2769
2770         Reviewed by Sergio Villar Senin.
2771
2772         Update GMainLoopSource tests. Most of the tests are now run twice,
2773         first with a GMainLoopSource and then with a
2774         GThreadSafeMainLoopSource, since both should have the same
2775         behaviour. The threading test uses GThreadSafeMainLoopSource and
2776         the delete on destroy test uses GMainLoopSource. The tests
2777         themselves haven't changed, since there's no change in behaviour.
2778
2779         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2780         (TestWebKitAPI::GMainLoopSourceTest::source):
2781         (TestWebKitAPI::basicRescheduling):
2782         (TestWebKitAPI::TEST):
2783         (TestWebKitAPI::reentrantRescheduling):
2784         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2785         (TestWebKitAPI::basicDestroyCallbacks):
2786         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2787         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2788
2789 2014-10-10  Dana Burkart  <dburkart@apple.com>
2790
2791         Fix fat-fingered function name in git-add-reviewer.
2792
2793         Unreviewed.
2794
2795         * Scripts/git-add-reviewer:
2796         (getConfigValue):
2797
2798 2014-10-10  David Farler  <dfarler@apple.com>
2799
2800         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2801         https://bugs.webkit.org/show_bug.cgi?id=137528
2802
2803         Reviewed by Simon Fraser.
2804
2805         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2806         and SIGKILL the paired simulator app before exiting cleanly.
2807
2808         webkitpy only uses SIGKILL to kill processes which you cannot
2809         catch. Send SIGTERM to the process and give it chance to do
2810         its thing before sending SIGKILL. Sending a SIGKILL to an already
2811         dead PID is safe.
2812
2813         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2814         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2815         (-[LTRelayController finish]):
2816         * LayoutTestRelay/LayoutTestRelay/main.m:
2817         (receivedSignal):
2818         (main):
2819
2820 2014-10-10  David Farler  <dfarler@apple.com>
2821
2822         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
2823         https://bugs.webkit.org/show_bug.cgi?id=137527
2824
2825         Reviewed by Simon Fraser.
2826
2827         NSFileHandle doesn't notify of EOF in its readability handler.
2828         Use a dispatch_source_t and an event handler that is called when reading is possible.
2829         In the handler block, do a run-of-the-mill read(2) from standard input and
2830         detect EOF in the usual way by checking that zero bytes were read.
2831
2832         Once an EOF is received, the FIFOs are disconnected, the simulator app
2833         is killed, and the relay exits with status 0.
2834
2835         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2836         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2837         (-[LTRelayController didDisconnect]):
2838         (-[LTRelayController didConnect]):
2839         (-[LTRelayController launchApp]):
2840         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
2841         confusion with this new dispatch source, called "standardInputDispatchSource".
2842         (-[LTRelayController finish]): Added.
2843         (-[LTRelayController readFileHandle:]): Deleted.
2844
2845 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2846
2847         [EFL] Crash on facebook.com
2848         https://bugs.webkit.org/show_bug.cgi?id=137562
2849
2850         Reviewed by Chris Dumez.
2851
2852         Crash occurs on the facebook.com when the webview is resized
2853         after the <select> item is clicked but no item is chosen.
2854         This crash is just caused by the reference of invalidated variable.
2855         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
2856         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
2857         on MiniBrowser is called.
2858         As a result, just set ewk_menu to NULL in order to prevent crash condition.
2859
2860         * MiniBrowser/efl/main.c:
2861         (on_popup_menu_hide):
2862
2863 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2864
2865         A small wording change for clarity.
2866
2867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2868         (MetricsBubbleView.prototype._update):
2869
2870 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2871
2872         Dashboard metrics page should have EWS statistics
2873         https://bugs.webkit.org/show_bug.cgi?id=137626
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2878         (BubbleQueue): Put shortName in the object, so that it's actually useful.
2879
2880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2881         (BubbleQueueServer): Re-ordered queues to match bubble order.
2882         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
2883         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
2884
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2886         Added analysis for bubble queues.
2887
2888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
2889
2890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2891         (buildBubbleQueuesTable): Build the UI.
2892
2893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2894         Added JS sources to load.
2895
2896         * QueueStatusServer/app.yaml: To update app version.
2897
2898         * QueueStatusServer/handlers/processingtimesjson.py: Added.
2899
2900         * QueueStatusServer/main.py: Added a handler for processing-times-json.
2901
2902 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2903
2904         REGRESSION: Commit queue doesn't process rollouts
2905         https://bugs.webkit.org/show_bug.cgi?id=137623
2906
2907         Reviewed by Tim Horton.
2908
2909         * QueueStatusServer/app.yaml:
2910         * QueueStatusServer/handlers/updateworkitems.py:
2911         (UpdateWorkItems._work_items_from_request):
2912
2913 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
2914
2915         Fix syntax error after r174601.
2916
2917         * Scripts/run-javascriptcore-tests:
2918
2919 2014-10-10  Michael Saboff  <msaboff@apple.com>
2920
2921         Add ability to select tarfile name in run-jsc-stress-tests
2922         https://bugs.webkit.org/show_bug.cgi?id=137614
2923
2924         Reviewed by Mark Hahnenberg.
2925
2926         Added optional file name argument to the --tarball option.  
2927
2928         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2929         extra test given after the options wont be used for the optional tarball file name.
2930         * Scripts/run-jsc-stress-tests:
2931
2932 2014-10-10  Chris Dumez  <cdumez@apple.com>
2933
2934         Unreviewed, update my information in contributors.json
2935
2936         Use my preferred first name and update my expertise areas.
2937
2938         * Scripts/webkitpy/common/config/contributors.json:
2939
2940 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2941
2942         Fix perl scripts to run with env on Linux
2943         https://bugs.webkit.org/show_bug.cgi?id=137601
2944
2945         Reviewed by Csaba Osztrogonác.
2946
2947         Use of arguments in #! is nonstandard and does not behave the same on
2948         different systems. Linux would look for an executable named "perl -w" 
2949         "use warnings;" does the same things in a more portable way.
2950
2951         * Scripts/commit-log-editor:
2952         * Scripts/num-cpus:
2953         * Scripts/prepare-ChangeLog:
2954         * Scripts/run-launcher:
2955         * Scripts/svn-create-patch:
2956
2957 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2958
2959         [jhbuild] We should be able to disable wiping on configuration change
2960         https://bugs.webkit.org/show_bug.cgi?id=137446
2961
2962         Reviewed by Csaba Osztrogonác.
2963
2964         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2965         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2966         or passing --no-wipe-on-change command line option.
2967
2968         * Scripts/update-webkit-libs-jhbuild:
2969
2970 2014-10-09  Andy Estes  <aestes@apple.com>
2971
2972         Teach webkitpy about OS X Yosemite
2973         https://bugs.webkit.org/show_bug.cgi?id=137585
2974
2975         Reviewed by Simon Fraser.
2976
2977         * Scripts/webkitpy/common/system/platforminfo.py:
2978         (PlatformInfo._determine_mac_version):
2979         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2980         (TestPlatformInfo.test_os_version):
2981         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2982         (TestExpectationParser):
2983         * Scripts/webkitpy/port/builders.py:
2984         * Scripts/webkitpy/port/mac.py:
2985         (MacPort):
2986         * Scripts/webkitpy/port/mac_unittest.py:
2987         (test_versions):
2988         (test_baseline_search_path):
2989         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2990         (TestRebaselineTest.test_baseline_directory):
2991         (TestRebaselineExpectations.test_rebaseline_expectations):
2992
2993 2014-10-09  Dana Burkart  <dburkart@apple.com>
2994
2995         Add Mac OS Yosemite dashboard support.
2996
2997         Rubber-stamped by Lucas Forschler.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3004
3005 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
3006
3007         Add Babak to contributors.json and add historical email addresses for some contributors
3008         https://bugs.webkit.org/show_bug.cgi?id=137546
3009
3010         Reviewed by Christophe Dumez.
3011
3012         contributors.json is used to analyze historical commit data and change logs.
3013
3014         Add back historical email addresses for some contributors and also add Babak (Shafiei).
3015
3016         * Scripts/webkitpy/common/config/contributors.json:
3017
3018 2014-10-09  Lucas Forschler  <lforschler@apple.com>
3019
3020         Add Mac OS Yosemite webkit build infrastructure.
3021         
3022         This patch adds 15 bots to our build.webkit.org configuration.
3023         We are matching the current Mavericks machines 1:1.
3024         
3025         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
3026         
3027         Reviewed by Matt Hanson.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/config.json:
3030
3031 2014-10-09  Dana Burkart  <dburkart@apple.com>
3032
3033         Don't use backticks when running commands, as we run into sh-related
3034         interpolation issues. Also, fix our usage of system() to properly
3035         retrieve the status code.
3036         https://bugs.webkit.org/show_bug.cgi?id=137541
3037
3038         Reviewed by Darin Adler.
3039
3040         * Scripts/git-add-reviewer:
3041         (interactive):
3042         (nonInteractive):
3043         (requireCleanWorkTree):
3044         (cherryPick):
3045         (commit):
3046         (addReviewerToFile):
3047         (head):
3048         (isAncestor):
3049         (toCommit):
3050         (changeLogsForCommit):
3051         (resetToCommit):
3052         (getConfigValue):
3053         (runCommandWithOutput):
3054
3055 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3056
3057         Add a WebKit1 preference for selection services
3058         https://bugs.webkit.org/show_bug.cgi?id=137498
3059         <rdar://problem/18572699>
3060
3061         Reviewed by Simon Fraser.
3062
3063         * MiniBrowser/mac/WK1BrowserWindowController.m:
3064         (-[WK1BrowserWindowController awakeFromNib]):
3065         Turn on image and selection services in the Legacy WebKit MiniBrowser.
3066
3067 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
3068
3069         Get the patch scripts running on Haiku
3070         https://bugs.webkit.org/show_bug.cgi?id=137559
3071
3072         Reviewed by Benjamin Poulain.
3073
3074         Use /usr/bin/env instead of hardcoding path to perl.
3075         Declare haiku platform in platforminfo.py to avoid check-webkit-style
3076         failure.
3077
3078         * Scripts/commit-log-editor:
3079         * Scripts/num-cpus:
3080         * Scripts/prepare-ChangeLog:
3081         * Scripts/run-launcher:
3082         * Scripts/svn-create-patch:
3083         * Scripts/webkitpy/common/system/platforminfo.py:
3084         (PlatformInfo._determine_os_name):
3085
3086 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
3087
3088         StyleQueue should throw a PatchIsNotValid exception to achieve
3089         consistency with CommitQueue and EWS
3090         https://bugs.webkit.org/show_bug.cgi?id=137500
3091
3092         Reviewed by Alexey Proskuryakov.
3093
3094         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3095         Adds a call to validate() in run().
3096         (StyleQueueTask.run):
3097         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3098         Adds a return False in the patch is not valid exception statement.
3099         (AbstractEarlyWarningSystem.review_patch):
3100         * Scripts/webkitpy/tool/commands/queues.py:
3101         Adds a return False in the patch is not valid exception statement in
3102         commit queue, and adds an except statement to catch PatchIsNotValid
3103         exceptions in style queue.
3104         (CommitQueue.process_work_item):
3105         (StyleQueue.review_patch):
3106
3107 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3108
3109         Race condition with WebKitWebView:is-loading after starting page load
3110         https://bugs.webkit.org/show_bug.cgi?id=136692
3111
3112         Reviewed by Gustavo Noronha Silva.
3113
3114         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3115         (loadChangedCallback): Only check is-loading is false when load
3116         has finished if the load didn't fail due to a cancellation.
3117         (loadFailedCallback): Only check is-loading is false if the load
3118         didn't fail due to a cancellation.
3119         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3120         (WebViewTest::loadURI): Check is-loading is true and active URI is
3121         the requested one rigth after requesting the load.
3122         (WebViewTest::loadHtml): Ditto.
3123         (WebViewTest::loadPlainText): Ditto.
3124         (WebViewTest::loadBytes): Ditto.
3125         (WebViewTest::loadRequest): Ditto.
3126         (WebViewTest::loadAlternateHTML): Ditto.
3127         (WebViewTest::goBack): Ditto.
3128         (WebViewTest::goForward): Ditto.
3129         (WebViewTest::goToBackForwardListItem): Ditto.
3130
3131 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
3132
3133         [Win] Resolve various static analyzer warnings in Tools.
3134         https://bugs.webkit.org/show_bug.cgi?id=137534
3135
3136         Reviewed by Dean Jackson.
3137
3138         * DumpRenderTree/cg/ImageDiffCG.cpp:
3139         (main): User proper printf specifiers.
3140         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3141         (AccessibilityUIElement::childrenCount): Handle possibility that
3142         gcc_accChildCount returns with an error.
3143         (accessibilityState): Ditto for gcc_accState.
3144         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3145         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
3146         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
3147         be treated as such.
3148         * DumpRenderTree/win/DumpRenderTree.cpp:
3149         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
3150         by comparing an unsigned value as being greater-than zero.
3151         * DumpRenderTree/win/EditingDelegate.cpp:
3152         (dump): Pass proper character pointer type to printf.
3153         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
3154         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3155         (EditingDelegate::shouldInsertNode): Ditto.
3156         (EditingDelegate::shouldInsertText): Ditto.
3157         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3158         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3159         (EditingDelegate::shouldApplyStyle): Ditto.
3160         * DumpRenderTree/win/EventSender.cpp:
3161         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
3162         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
3163         system headers.
3164         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
3165         from CreateDIBSection.
3166         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
3167         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
3168         older versions of MSVC we no longer support.
3169         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3170         for 64-bit builds.
3171         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3172         * TestWebKitAPI/TestsController.h: Ditto.
3173         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3174         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3175         performing bitwise | before the comparison is done.
3176
3177 2014-10-08  Ada Chan  <adachan@apple.com>
3178
3179         Add a test for WKPageIsPlayingAudio().
3180         https://bugs.webkit.org/show_bug.cgi?id=137048
3181
3182         Reviewed by Darin Adler.
3183
3184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3185         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3186         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3187         (TestWebKitAPI::nullJavaScriptCallback):
3188         (TestWebKitAPI::didFinishLoadForFrame):
3189         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3190         (TestWebKitAPI::setUpClients):
3191         (TestWebKitAPI::TEST):
3192         This test loads a page with a video in it. When the page is loaded, we first check that
3193         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3194         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3195         now returns true for the page.
3196         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3197         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3198         This is a video copied from LayoutTests/media/content.
3199
3200 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3201
3202         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3203         https://bugs.webkit.org/show_bug.cgi?id=137516
3204
3205         Reviewed by Alexey Proskuryakov.
3206
3207         * Scripts/webkitpy/thirdparty/__init__.py:
3208         (AutoinstallImportHook._install_irc):
3209
3210 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3211
3212         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3213         https://bugs.webkit.org/show_bug.cgi?id=137520
3214
3215         Reviewed by Philippe Normand.
3216
3217         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3218         For other distributions, we are already installing libjpeg-turbo.
3219         So, do the same for Debian and derivatives.
3220
3221         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3222
3223 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3224
3225         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3226         https://bugs.webkit.org/show_bug.cgi?id=137519
3227
3228         Reviewed by Csaba Osztrogonác.
3229
3230         It was removed by <http://trac.webkit.org/changeset/174266>,
3231         because the comment stated it is a workaround for buggy python
3232         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3233         is still valid with python 2.7 shipped on the latest Ubuntu
3234         (12.04 and 14.04) and OS X 10.9.
3235
3236         * Scripts/webkitpy/common/system/autoinstall.py:
3237         (AutoInstaller):
3238         (AutoInstaller._extract_all):
3239         (AutoInstaller._unzip):
3240
3241 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3242
3243         Unreviewed, rolling out r174335.
3244         https://bugs.webkit.org/show_bug.cgi?id=137515
3245
3246         It broke EFL layout test totally (Requested by gyuyoung on
3247         #webkit).
3248
3249         Reverted changeset:
3250
3251         "[EFL] Introduce EWebKit_Extension"
3252         https://bugs.webkit.org/show_bug.cgi?id=134921
3253         http://trac.webkit.org/changeset/174335
3254
3255 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3256
3257         [GTK] Make forwarding headers generation depend on source code
3258         https://bugs.webkit.org/show_bug.cgi?id=137394
3259
3260         Reviewed by Philippe Normand.
3261
3262         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3263         * TestWebKitAPI/PlatformGTK.cmake: Only run
3264         generate-forwarding-headers.pl when source code changes.
3265         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3266
3267 2014-10-07  Tanay C  <tanay.c@samsung.com>
3268
3269         Remove build warnings in Hashmap API tests
3270         https://bugs.webkit.org/show_bug.cgi?id=137484
3271
3272         Reviewed by Darin Adler.
3273
3274         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3275         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3276
3277 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3278
3279         Commit queue doesn't drop obsolete patches sometimes
3280         https://bugs.webkit.org/show_bug.cgi?id=137460
3281
3282         Reviewed by Alexey Proskuryakov.
3283
3284         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3285         Adds another test patch for use in queues_unittest.py.
3286         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3287         (MockBugzilla):
3288         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3289         Raises a PatchIsNotValid exception in the case of validate() returning
3290         false.
3291         (CommitQueueTask.run):
3292         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3293         Raises a PatchIsNotValid exception in the case of validate() returning
3294         false.
3295         (EarlyWarningSystemTask.run):
3296         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3297         Defines PatchIsNotValid exception. 
3298         (PatchIsNotValid):
3299         (PatchIsNotValid.__init__):
3300         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3301         Remove call to validate() and instead catches the PatchIsNotValid
3302         exception.
3303         (AbstractEarlyWarningSystem.review_patch):
3304         * Scripts/webkitpy/tool/commands/queues.py:
3305         Adds logic to catch the PatchIsNotValid exception.
3306         (CommitQueue.process_work_item):
3307         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3308         Adds the test_non_valid_patch test to ensure that invalid patches are
3309         handled properly, and don't just result in indefinite spinning.
3310         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3311         (test_non_valid_patch):
3312
3313 2014-10-07  Daniel Bates  <dabates@apple.com>
3314
3315         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3316         https://bugs.webkit.org/show_bug.cgi?id=137499
3317
3318         Reviewed by Simon Fraser.
3319
3320         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3321         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3322         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3323         bit simulator builds of iOS WebKit.
3324
3325         * Scripts/webkitpy/port/ios.py:
3326         (IOSSimulatorPort._generate_all_test_configurations):
3327
3328 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3329
3330         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3331         https://bugs.webkit.org/show_bug.cgi?id=137482
3332
3333         Reviewed by Martin Robinson.
3334
3335         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3336
3337 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3338
3339         [SOUP] TLS errors should take precedence over HTTP authentication
3340         https://bugs.webkit.org/show_bug.cgi?id=137300
3341
3342         Reviewed by Sergio Villar Senin.
3343
3344         Add a test case to check that authenticate signal is not emitted
3345         in case of TLS errors, and the load fails instead.
3346
3347         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3348         (webViewAuthenticationCallback):
3349         (testTLSErrorsHTTPAuth):
3350         (httpsServerCallback):
3351         (beforeAll):
3352
3353 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3354
3355         Make webkit-patch find-users useful
3356         https://bugs.webkit.org/show_bug.cgi?id=137475
3357
3358         Reviewed by Alexey Proskuryakov.
3359
3360         Make find-users use the CommitterList instead of accessing Bugzilla.
3361
3362         This essentially exposes the same functionality as webkitbot's whois command.
3363
3364         * Scripts/webkitpy/tool/commands/findusers.py:
3365         (FindUsers.execute):
3366
3367 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3368
3369         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3370         https://bugs.webkit.org/show_bug.cgi?id=137289
3371
3372         Unreviewed build fix.
3373
3374         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3375         (AccessibilityUIElement::getChildrenWithRange):
3376
3377 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3378
3379         build.webkit.org/dashboard: Add commit queue
3380         https://bugs.webkit.org/show_bug.cgi?id=137462
3381
3382         Reviewed by Tim Horton.
3383
3384         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3385         Style queue is still invisible, as it doesn't have an associated platform, and also
3386         we never have problems with it anyway, so it's not worth watching.
3387
3388         The UI now allows for adding more bots to the Other column (such as leaks bot).
3389         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3390         sources of data in a cell.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3393         (BubbleQueue):
3394         (BubbleQueue.prototype.get statusPageURL):
3395         (BubbleQueue.prototype.update):
3396         (BubbleQueue.prototype.loadDetailedStatus):
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3398         (BubbleQueueServer):
3399         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3400         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3401         (BubbleQueueServer.prototype.queueStatusURL):
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3403         (BubbleQueueView):
3404         (BubbleQueueView.prototype.update.appendQueue):
3405         (BubbleQueueView.prototype.update):
3406         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3407         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3408         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3415         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3416         (.bubble-server-popover .latest-status-no-link):
3417         (.bubble-server-popover .bot-status-description):
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3419
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3421         (buildAggregateTable):
3422         (buildQueuesTable):
3423         Removed dysfunctional support for EWS for now. It will be different.
3424
3425 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3426
3427         One more case of incorrect comparison in recordpatchevent.py
3428         https://bugs.webkit.org/show_bug.cgi?id=137459
3429
3430         Reviewed by Tim Horton.
3431
3432         * QueueStatusServer/app.yaml:
3433         * QueueStatusServer/loggers/recordpatchevent.py:
3434         (RecordPatchEvent.started):
3435
3436 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3437
3438         webkit-queues PatchLog is incorrect for patches that took less than a second
3439         https://bugs.webkit.org/show_bug.cgi?id=137453
3440
3441         Reviewed by Tim Horton.
3442
3443         * QueueStatusServer/app.yaml: Updated app version.
3444
3445         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3446         Don't bail out for patches that took 0 seconds to process (as frequently happens
3447         when a patch is obsolete).
3448
3449 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
3450
3451         EWS bubble hover shows wrong timestamps
3452         https://bugs.webkit.org/show_bug.cgi?id=137252
3453
3454         Reviewed by Alexey Proskuryakov.
3455
3456         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3457
3458         * QueueStatusServer/handlers/queuestatusjson.py:
3459         (QueueStatusJSON.get):
3460         * QueueStatusServer/handlers/statusbubble.py:
3461         (StatusBubble._iso_time):
3462
3463 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
3464
3465         Unreviewed, updated list of email addresses in contributors.json
3466
3467         * Scripts/webkitpy/common/config/contributors.json: Added my former
3468         email address in Igalia, for the sake of completeness.
3469
3470 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3471
3472         Unreviewed, moved myself to the list of committers.
3473
3474         * Scripts/webkitpy/common/config/contributors.json:
3475
3476 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
3477
3478         [EFL] Introduce EWebKit_Extension
3479         https://bugs.webkit.org/show_bug.cgi?id=134921
3480
3481         Reviewed by Gyuyoung Kim.
3482
3483         * MiniBrowser/efl/main.c: Added x option to test extension path.
3484         (window_create):
3485         (elm_main):
3486         * Scripts/webkitpy/common/config/watchlist:
3487         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3488         * Scripts/webkitpy/style/checker.py:
3489         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3490
3491 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
3492
3493         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3494         https://bugs.webkit.org/show_bug.cgi?id=137390
3495
3496         Reviewed by Carlos Garcia Campos.
3497
3498         * Scripts/update-webkit-libs-jhbuild:
3499
3500 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3501
3502         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3503         https://bugs.webkit.org/show_bug.cgi?id=137391
3504
3505         Reviewed by Martin Robinson.
3506
3507         Add a custom command to only re-generate
3508         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3509
3510         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3511
3512 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3513
3514         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3515         https://bugs.webkit.org/show_bug.cgi?id=135502
3516
3517         Reviewed by Martin Robinson.
3518
3519         When writing to stdout/stderr fails due to a UnicodeDecodeError
3520         exception, try again without encoding the output.
3521
3522         * gtk/gtkdoc.py:
3523         (GTKDoc._run_command):
3524
3525 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3526
3527         Bugzilla status bubble displays an exception showing attachment 175738
3528         https://bugs.webkit.org/show_bug.cgi?id=137410
3529
3530         Reviewed by Tim Horton.
3531
3532         * QueueStatusServer/app.yaml: Update version.
3533
3534         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3535         Don't fail even if expected status message is missing.
3536
3537         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3538         the field in the same way it's defined in QueueStatus table.
3539
3540 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3541
3542         Record latest message in PatchLog for quick access
3543         https://bugs.webkit.org/show_bug.cgi?id=137405
3544
3545         Fixing a typo.
3546
3547         * QueueStatusServer/app.yaml:
3548         * QueueStatusServer/handlers/releasepatch.py:
3549
3550 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3551
3552         Record latest message in PatchLog for quick access
3553         https://bugs.webkit.org/show_bug.cgi?id=137405
3554
3555         Reviewed by Ryosuke Niwa.
3556
3557         It's no SQL...
3558
3559         * QueueStatusServer/handlers/releasepatch.py:
3560         * QueueStatusServer/handlers/updatestatus.py:
3561         * QueueStatusServer/loggers/recordpatchevent.py:
3562         * QueueStatusServer/model/patchlog.py:
3563
3564 2014-10-02  David Farler  <dfarler@apple.com>
3565
3566         -asan-blacklist option also renamed to generic -fsanitize-blacklist
3567         https://bugs.webkit.org/show_bug.cgi?id=137377
3568
3569         Reviewed by Daniel Bates.
3570
3571         * asan/asan.xcconfig:
3572         -asan-blacklist -> -fsanitize-blacklist
3573
3574         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3575
3576 2014-10-03  Roger Fong  <roger_fong@apple.com>
3577
3578         [Windows] Include batch size argument to layout tests on Windows.
3579
3580         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3581         (RunWebKitTests.start): 
3582         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3583         These crashes seem to happen on random tests though generally in a spread out fashion.
3584         It seems possible that the DRT instance is being clobbered somehow after running too many
3585         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3586
3587 2014-10-03  Roger Fong  <roger_fong@apple.com>
3588
3589         [Windows] Settle for 2 chid processes running NRWT on Windows.
3590
3591         * Scripts/webkitpy/port/win.py:
3592         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3593
3594 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
3595
3596         [GTK] Bump up and patch dependencies to allow building for aarch64
3597         https://bugs.webkit.org/show_bug.cgi?id=137147
3598
3599         Reviewed by Martin Robinson.
3600
3601         The currently used versions of pixman, libffi, librsvg, glib,
3602         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3603         and/or build for aarch64, so they are bumped up and patched where
3604         necessary. Wherever possible, the same versions and patches were used as
3605         for the EFL port bump-up
3606         (https://bugs.webkit.org/show_bug.cgi?id=135885).
3607
3608         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3609         regression by crashing http/tests/media/video-redirect.html . A patch
3610         already in upstream fixes that bug.
3611
3612         This change does not touch xserver, which also needs bumping up, but 
3613         will be dealt with later.
3614
3615         * gtk/jhbuild.modules:
3616         Specified versions and patches necessary to correctly build for aarch64.
3617         * gtk/patches/gst-events-arent-gstobjects.patch:
3618         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3619         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3620         Added. Patches gst-plugins-base to configure correctly for aarch64.
3621         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3622         Added. Bumps up config.guess and config.sub in librsvg to recognize
3623         aarch64.
3624         * gtk/patches/libxml2-2.9.0-dtd.patch:
3625         Removed. Not necessary for libxml2 v2.9.1 anymore.
3626
3627 2014-09-28  Sam Weinig  <sam@webkit.org>
3628
3629         Remove RefPtrHashMap
3630         https://bugs.webkit.org/show_bug.cgi?id=137200
3631
3632         Reviewed by Darin Adler.
3633
3634         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3635         (TestWebKitAPI::TEST):
3636         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3637         a minimum of refcount churn occurs.
3638
3639 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3640
3641         Remove workarounds for versions of Python before 2.7
3642         https://bugs.webkit.org/show_bug.cgi?id=137338
3643
3644         Reviewed by Csaba Osztrogonác.
3645
3646         * Scripts/webkitpy/common/system/autoinstall.py:
3647         (AutoInstaller._extract_targz):
3648         (AutoInstaller._unzip):
3649         (AutoInstaller): Deleted.
3650         (AutoInstaller._extract_all): Deleted.
3651         * Scripts/webkitpy/common/webkitunittest.py:
3652         (TestCase.setUp): Deleted.
3653         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3654         (TestConfigurationConverter.collapse_macros):
3655         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3656         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3657         (TestConfigurationConverter):
3658         (TestConfigurationConverter.combinations): Deleted.
3659         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3660         * Scripts/webkitpy/port/base.py:
3661
3662 2014-10-03  Commit Queue  <commit-queue@webkit.org>
3663
3664         Unreviewed, rolling out r174264.
3665         https://bugs.webkit.org/show_bug.cgi?id=137392
3666
3667         It broke run-webkit-tests (Requested by ebalazsfalvi on
3668         #webkit).
3669
3670         Reverted changeset:
3671
3672         "Remove workarounds for versions of Python before 2.7"
3673         https://bugs.webkit.org/show_bug.cgi?id=137338
3674         http://trac.webkit.org/changeset/174264
3675
3676 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3677
3678         Remove workarounds for versions of Python before 2.7
3679         https://bugs.webkit.org/show_bug.cgi?id=137338
3680
3681         Reviewed by Csaba Osztrogonác.
3682
3683         * Scripts/webkitpy/common/system/autoinstall.py:
3684         (AutoInstaller._extract_targz):
3685         (AutoInstaller._unzip):
3686         (AutoInstaller): Deleted.
3687         (AutoInstaller._extract_all): Deleted.
3688         * Scripts/webkitpy/common/webkitunittest.py:
3689         (TestCase.setUp): Deleted.
3690         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3691         (TestConfigurationConverter.collapse_macros):
3692         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3693         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3694         (TestConfigurationConverter):
3695         (TestConfigurationConverter.combinations): Deleted.
3696         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3697         * Scripts/webkitpy/port/base.py:
3698         * Scripts/webkitpy/port/driver.py:
3699         (ContentBlock.__init__):
3700         * Scripts/webkitpy/port/server_process.py:
3701         (ServerProcess._reset):
3702
3703 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3704
3705         Remove autoinstaller workaround for python 2.6
3706         https://bugs.webkit.org/show_bug.cgi?id=137343
3707
3708         Reviewed by Daniel Bates.
3709
3710         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
3711         2.6, nor Snow Leopard is supported anymore, so the workaround is not
3712         needed anymore.
3713
3714         * Scripts/webkitpy/common/system/autoinstall.py:
3715         (AutoInstaller.install):
3716         * Scripts/webkitpy/test/main.py:
3717         (Tester._run_tests):
3718         * Scripts/webkitpy/thirdparty/__init__.py:
3719         (AutoinstallImportHook._install_mechanize):
3720         (AutoinstallImportHook._install_pep8):
3721         (AutoinstallImportHook._install_pylint):
3722         (AutoinstallImportHook._install_buildbot):
3723         (AutoinstallImportHook._install_coverage):
3724         (AutoinstallImportHook._install_eliza):
3725         (AutoinstallImportHook._install_irc):
3726         (AutoinstallImportHook._install):
3727         (autoinstall_everything):
3728
3729 2014-10-02  Daniel Bates  <dabates@apple.com>
3730
3731         Use version number 101000 instead of 10100 for OS X Yosemite
3732         https://bugs.webkit.org/show_bug.cgi?id=137372
3733
3734         Reviewed by Mark Rowe.
3735
3736         The version number for OS X Yosemite is 101000.
3737
3738         * DumpRenderTree/mac/TextInputController.m:
3739
3740 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
3741
3742         update-work-items should never delete items
3743         https://bugs.webkit.org/show_bug.cgi?id=137366
3744
3745         Reviewed by Ryosuke Niwa.
3746
3747         As we don't just replace the whole list any more, indicate which items are high
3748         priority, and which are not. Hight priority ones will be prepended to the queue,
3749         others will be appended.
3750
3751         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
3752         But hopefully we will never have many rollouts competing like that.
3753
3754         * QueueStatusServer/app.yaml: Update version.
3755
3756         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
3757         priority and regular items separately. Removed some error handling that used to
3758         end up in returning status 500 - an uncaught exception does that automatically.
3759
3760         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
3761
3762         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
3763
3764         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
3765         priority items.
3766
3767         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3768         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
3769         line that complicated testing.
3770
3771         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
3772
3773         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
3774         priority items into separate lists.
3775
3776         * Scripts/webkitpy/common/net/statusserver_mock.py:
3777         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3778         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3779         Updated tests.
3780
3781 2014-10-02  Brendan Long  <b.long@cablelabs.com>
3782
3783         Annoying build warnings in WTFString API tests
3784         https://bugs.webkit.org/show_bug.cgi?id=137360
3785
3786         Reviewed by Darin Adler.
3787
3788         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3789         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
3790
3791 2014-10-02  Roger Fong  <roger_fong@apple.com>
3792
3793         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
3794
3795         * Scripts/webkitpy/port/win.py:
3796         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
3797
3798 2014-10-02  David Farler  <dfarler@apple.com>
3799
3800         Move ASan arguments from LLVM (-mllvm) to the frontend
3801         https://bugs.webkit.org/show_bug.cgi?id=137365
3802
3803         Reviewed by David Kilzer.
3804
3805         * asan/asan.xcconfig:
3806         Remove the -mllvm prefix to the asan-blacklist argument, moving it
3807         to the clang frontend.
3808
3809         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3810
3811 2014-10-02  Commit Queue  <commit-queue@webkit.org>
3812
3813         Unreviewed, rolling out r174120.
3814         https://bugs.webkit.org/show_bug.cgi?id=137350
3815
3816         While number of failures is reasonable with 2 processes, test
3817         results seem to be inconsistent between runs (Requested by
3818         rfong on #webkit).
3819
3820         Reverted changeset:
3821
3822         "[Windows] Back to 2 child processes for NRWT on Windows."
3823         http://trac.webkit.org/changeset/174120
3824
3825 2014-10-02  Jeff Miller  <jeffm@apple.com>
3826
3827         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
3828         https://bugs.webkit.org/show_bug.cgi?id=137347
3829
3830         Reviewed by Dan Bernstein.
3831
3832         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3833         Use WebKitSystemInterfaceYosemite on OS X 10.10.
3834
3835         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3836         Ditto.
3837
3838 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3839
3840         [GTK] [JHBuild] Switch sourceware.org mirror to http.
3841
3842         Unreviewed.
3843
3844         The ftp access is recently failing to work as expected, and the
3845         bots fail to download the file.
3846         The same mirror is available via http and seems to work better.
3847
3848         * gtk/jhbuild.modules:
3849
3850 2014-10-01  Commit Queue  <commit-queue@webkit.org>
3851
3852         Unreviewed, rolling out r174185.
3853         https://bugs.webkit.org/show_bug.cgi?id=137334
3854
3855         Patch that adds logging causes webkitpy failures (Requested by
3856         rfong on #webkit).
3857
3858         Reverted changeset:
3859
3860         "commitqueuetasks_unittest references a non-existent member
3861         variable"
3862         https://bugs.webkit.org/show_bug.cgi?id=137303
3863         http://trac.webkit.org/changeset/174185
3864
3865 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3866
3867         EWS and Commit Queue should know better than to spew 500 failed
3868         results in the case of extremely red patches.
3869         https://bugs.webkit.org/show_bug.cgi?id=137324
3870
3871         Reviewed by Alexey Proskuryakov.
3872
3873         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3874         Adds a check for did_exceed_test_failure_limit.
3875         (AbstractEarlyWarningSystem._failing_tests_message):
3876         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3877         Alters the task mock to respond properly to
3878         results_from_patch_test_run(patch)
3879         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3880         * Scripts/webkitpy/tool/commands/queues.py:
3881         Adds a check for did_exceed_test_failure_limit.
3882         (CommitQueue._failing_tests_message):
3883
3884 2014-10-01  Daniel Bates  <dabates@apple.com>
3885
3886         Unreviewed, rolling out r174192.
3887
3888         Revert the unit test fix in r174192 since we reverted r174187
3889         in r174194 due to correctness issues. See
3890         <http://webkit.org/b/137329> for more details.
3891
3892         Reverted changeset:
3893
3894         "Test fix after r174187"
3895         http://trac.webkit.org/changeset/174192
3896
3897 2014-10-01  Mark Rowe  <mrowe@apple.com>
3898
3899         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3900
3901         Reviewed by Dan Bernstein.
3902
3903         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
3904         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
3905         for the LLVM components when on Yosemite.
3906
3907 2014-10-01  Commit Queue  <commit-queue@webkit.org>
3908
3909         Unreviewed, rolling out r174187.
3910         https://bugs.webkit.org/show_bug.cgi?id=137329
3911
3912         webkitpy failures, and thorton says the patch is wrong
3913         (Requested by dethbakin on #webkit).
3914
3915         Reverted changeset:
3916
3917         "[Windows] Increase layout test timeout for Windows following
3918         r174162."
3919         http://trac.webkit.org/changeset/174187
3920
3921 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
3922
3923         Test fix after r174187
3924
3925         * Scripts/webkitpy/port/win_unittest.py:
3926         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
3927
3928 2014-10-01  Roger Fong  <roger_fong@apple.com>
3929
3930         [Windows] Increase layout test timeout for Windows following r174162.
3931
3932         * Scripts/webkitpy/port/win.py:
3933         (WinPort.default_timeout_ms):
3934
3935 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3936
3937         commitqueuetasks_unittest references a non-existent member variable
3938         when mock-reporting flaky tests.
3939         https://bugs.webkit.org/show_bug.cgi?id=137303
3940
3941         Reviewed by Daniel Bates.
3942
3943         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3944         (MockCommitQueue.report_flaky_tests):
3945         Makes the appropriate name change.
3946         (test_simple_flaky_test_failure):
3947         Adds a unit test to make sure that the code is excercised.
3948
3949 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3950
3951         EWS is inconclusively spinning forever on a patch that breaks 500+
3952         tests
3953         https://bugs.webkit.org/show_bug.cgi?id=137223
3954
3955         Reviewed by Tim Horton.
3956
3957         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3958         Checks to see whether the tests have exceeded the failure limit, and
3959         only spins off another test if they have not exceeded the limit.
3960         (PatchAnalysisTask._test_patch):
3961
3962 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
3963
3964         Unreviewed, add Katie Madonna as a contributor.
3965
3966         * Scripts/webkitpy/common/config/contributors.json:
3967
3968 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3969
3970         commitqueuetasks_unittest does not construct FailingTestCommitQueue
3971         objects properly in its test cases.
3972         https://bugs.webkit.org/show_bug.cgi?id=137281
3973
3974         Reviewed by Daniel Bates.
3975
3976         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3977         (FailingTestCommitQueue.test_results):
3978         Adds an assert to make FailingTestCommitQueue harder to mis-use.
3979         (test_double_flaky_test_failure):
3980         Nests the intended test failure strings into one-length lists.
3981         (test_red_test_failure):
3982         Nests the intended test failure strings into one-length lists.
3983
3984 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3985
3986         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
3987         https://bugs.webkit.org/show_bug.cgi?id=136987
3988
3989         Reviewed by Daniel Bates.
3990
3991         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3992         Specify the default encoding for all WebKit developers to get consistent results.
3993
3994 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3995
3996         EWS is too eager to say that a patch does not apply to trunk of repository
3997         https://bugs.webkit.org/show_bug.cgi?id=137290
3998
3999         Reviewed by Ryosuke Niwa.
4000
4001         * QueueStatusServer/app.yaml: Updated app version.
4002
4003         * QueueStatusServer/handlers/statusbubble.py:
4004         (StatusBubble._build_bubble):
4005         (StatusBubble._build_bubbles_for_attachment):
4006         Rewrote to make more sense.
4007
4008 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4009
4010         Remove thirdparty/unittest2 from webkitpy
4011         https://bugs.webkit.org/show_bug.cgi?id=137251
4012
4013         Reviewed by Brent Fulgham.
4014
4015         Additionally ordered imports in related webkitpy files and
4016         removed unnecessary shebangs from unittest files.
4017
4018         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
4019         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4020         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4021         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4022         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
4023         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
4024         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4025         * Scripts/webkitpy/common/config/committers_unittest.py:
4026         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
4027         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
4028         * Scripts/webkitpy/common/config/ports_unittest.py:
4029         * Scripts/webkitpy/common/config/urls_unittest.py:
4030         * Scripts/webkitpy/common/editdistance_unittest.py:
4031         * Scripts/webkitpy/common/find_files_unittest.py:
4032         * Scripts/webkitpy/common/lru_cache_unittest.py:
4033         * Scripts/webkitpy/common/memoized_unittest.py:
4034         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
4035         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4036         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4037         * Scripts/webkitpy/common/net/credentials_unittest.py:
4038         * Scripts/webkitpy/common/net/failuremap_unittest.py:
4039         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
4040         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4041         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4042         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
4043         * Scripts/webkitpy/common/net/statusserver_unittest.py:
4044         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
4045         * Scripts/webkitpy/common/newstringio_unittest.py:
4046         * Scripts/webkitpy/common/prettypatch_unittest.py:
4047         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
4048         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4049         * Scripts/webkitpy/common/system/environment_unittest.py:
4050         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
4051         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
4052         * Scripts/webkitpy/common/system/executive_unittest.py:
4053         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
4054         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
4055         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4056         * Scripts/webkitpy/common/system/logtesting.py:
4057         * Scripts/webkitpy/common/system/logutils_unittest.py:
4058         * Scripts/webkitpy/common/system/outputcapture.py:
4059         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
4060         * Scripts/webkitpy/common/system/outputtee_unittest.py:
4061         * Scripts/webkitpy/common/system/path_unittest.py:
4062         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
4063         * Scripts/webkitpy/common/system/profiler_unittest.py:
4064         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
4065         * Scripts/webkitpy/common/system/user_unittest.py:
4066         * Scripts/webkitpy/common/system/workspace_unittest.py:
4067         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
4068         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
4069         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
4070         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
4071         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
4072         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
4073         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
4074         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
4075         * Scripts/webkitpy/common/webkitunittest.py:
4076         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
4077         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4078         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
4079         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4080         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4081         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
4082         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4083         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
4084         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
4085         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
4086         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4087         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
4088         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
4089         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
4090         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4091         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
4092         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4093         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4094         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4095         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4096         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4097         * Scripts/webkitpy/port/base_unittest.py:
4098         * Scripts/webkitpy/port/builders_unittest.py:
4099         * Scripts/webkitpy/port/config_unittest.py:
4100         * Scripts/webkitpy/port/driver_unittest.py:
4101         * Scripts/webkitpy/port/efl_unittest.py:
4102         * Scripts/webkitpy/port/factory_unittest.py:
4103         * Scripts/webkitpy/port/gtk_unittest.py:
4104         * Scripts/webkitpy/port/http_lock_unittest.py:
4105         * Scripts/webkitpy/port/image_diff_unittest.py:
4106         * Scripts/webkitpy/port/leakdetector_unittest.py:
4107         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
4108         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
4109         * Scripts/webkitpy/port/mock_drt_unittest.py:
4110         * Scripts/webkitpy/port/port_testcase.py:
4111         * Scripts/webkitpy/port/server_process_unittest.py:
4112         * Scripts/webkitpy/port/westondriver_unittest.py:
4113         * Scripts/webkitpy/port/win_unittest.py:
4114         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
4115         * Scripts/webkitpy/style/checker_unittest.py:
4116         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
4117         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
4118         * Scripts/webkitpy/style/checkers/common_unittest.py:
4119         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4120         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
4121         * Scripts/webkitpy/style/checkers/js_unittest.py:
4122         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
4123         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
4124         * Scripts/webkitpy/style/checkers/png_unittest.py:
4125         * Scripts/webkitpy/style/checkers/python_unittest.py:
4126         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4127         * Scripts/webkitpy/style/checkers/text_unittest.py:
4128         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
4129         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
4130         * Scripts/webkitpy/style/checkers/xml_unittest.py:
4131         * Scripts/webkitpy/style/error_handlers_unittest.py:
4132         * Scripts/webkitpy/style/filereader_unittest.py:
4133         * Scripts/webkitpy/style/filter_unittest.py:
4134         * Scripts/webkitpy/style/main_unittest.py:
4135         * Scripts/webkitpy/style/optparser_unittest.py:
4136         * Scripts/webkitpy/style/patchreader_unittest.py:
4137         * Scripts/webkitpy/test/finder_unittest.py:
4138         * Scripts/webkitpy/test/main.py: Ordered imports.
4139         * Scripts/webkitpy/test/main_unittest.py:
4140         * Scripts/webkitpy/test/printer.py: Ordered imports.
4141         (Printer.configure):
4142         * Scripts/webkitpy/test/runner_unittest.py:
4143         * Scripts/webkitpy/test/skip_unittest.py:
4144         * Scripts/webkitpy/thirdparty/__init__.py:
4145         (AutoinstallImportHook._install_irc):
4146         (AutoinstallImportHook._install_unittest2): Deleted.
4147         * Scripts/webkitpy/thirdparty/__init___unittest.py:
4148         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
4149         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
4150         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
4151         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4152         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
4153         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
4154         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4155         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4156         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4157         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4158         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4159         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
4160         * Scripts/webkitpy/tool/commands/download_unittest.py:
4161         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
4162         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
4163         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4164         * Scripts/webkitpy/tool/commands/queuestest.py:
4165         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4166         * Scripts/webkitpy/tool/grammar_unittest.py:
4167         * Scripts/webkitpy/tool/mocktool_unittest.py:
4168         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4169         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4170         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4171         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
4172         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
4173         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
4174         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
4175         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4176         * Scripts/webkitpy/tool/steps/commit_unittest.py:
4177         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
4178         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
4179         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4180         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
4181         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4182         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4183         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
4184         * Scripts/webkitpy/tool/steps/update_unittest.py:
4185         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4186         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
4187         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4188         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4189         * Scripts/webkitpy/w3c/test_parser_unittest.py:
4190
4191 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
4192
4193         LayoutTestResults and ExpectedFailures should know about the
4194         interrupted flag from the json results file
4195         https://bugs.webkit.org/show_bug.cgi?id=137229
4196
4197         Reviewed by Daniel Bates.
4198
4199         Changes LayoutTestResults to use the interrupted flag instead of
4200         counting failures.
4201
4202         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4203         (BuilderTest._install_fetch_build._mock_fetch_build):
4204         (BuilderTest.test_latest_layout_test_results):
4205         * Scripts/webkitpy/common/net/layouttestresults.py:
4206         Removes notion of failure_limit_count, and adds
4207         did_exceed_test_failure_limit.
4208
4209         (LayoutTestResults.results_from_string):
4210         (LayoutTestResults.__init__):
4211         (LayoutTestResults.did_exceed_test_failure_limit):
4212         (LayoutTestResults): Deleted.
4213         (LayoutTestResults.set_failure_limit_count): Deleted.
4214         (LayoutTestResults.failure_limit_count): Deleted.
4215         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4216         Removes unit test for failure_limit_count logic.
4217
4218         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
4219         * Scripts/webkitpy/common/net/resultsjsonparser.py:
4220         Instead of providing a class method that returns a list of
4221         TestResults objects, resultsjsonparser now provides a class
4222         ParsedJSONResults that serves as an interface between the results.json
4223         file and the rest of webkitpy.
4224
4225         (ParsedJSONResults):
4226         (ParsedJSONResults.__init__):
4227         (ParsedJSONResults.did_exceed_test_failure_limit):
4228         (ParsedJSONResults.test_results):
4229         (ResultsJSONParser): Deleted.
4230         (ResultsJSONParser.parse_results_json): Deleted.
4231         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
4232         Updates the unit test so that it can test the new ResultsJSONParser
4233         class.
4234
4235         (ParsedJSONResultsTest):
4236         (test_basic):
4237         (ResultsJSONParserTest): Deleted.
4238         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4239         Updates the unit test to instantiate ResultsJSONParser objects rather
4240         than simple lists of TestResult objects.
4241
4242         (MockCommitQueue.test_results):
4243         (FailingTestCommitQueue.test_results):
4244         (test_flaky_test_failure):
4245         (test_failed_archive):
4246         * Scripts/webkitpy/tool/bot/expectedfailures.py:
4247         Updates ExpectedFailures to use the did_exceed_test_failure_limit
4248         method rather than counting the number of failed tests.
4249
4250         (ExpectedFailures._should_trust):
4251         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
4252         Updates MockResults to more closely resemble the updated
4253         LayoutTestResults class.
4254
4255         (MockResults.__init__):
4256         (MockResults.did_exceed_test_failure_limit):
4257         (ExpectedFailuresTest.test_can_trust_results):
4258         (ExpectedFailuresTest.test_unexpected_failures_observed):
4259         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
4260         (MockResults.failure_limit_count): Deleted.
4261         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
4262         Removes a FIXME regarding the use of the
4263         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
4264
4265         (LayoutTestResultsReader.results):
4266         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4267         Updates test to not check the now-nonexistant failure_count_limit
4268         method.
4269
4270         (test_missing_unit_test_results_path):
4271         (test_layout_test_results):
4272         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4273         Accounts for name change: ResultsJSONParserTest ->
4274         ParsedJSONParserTest.
4275
4276         (RebaselineTestTest.test_gather_baselines):
4277
4278 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4279
4280         [EFL] Rename TEST_THEME_DIR macro
4281         https://bugs.webkit.org/show_bug.cgi?id=137244
4282
4283         Reviewed by Csaba Osztrogonác.
4284