Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
[WebKit-https.git] / Tools / ChangeLog
1 2018-09-19  Chris Dumez  <cdumez@apple.com>
2
3         Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
4         https://bugs.webkit.org/show_bug.cgi?id=189721
5         <rdar://problem/44359788>
6
7         Reviewed by Geoffrey Garen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12
13 2018-09-19  Thomas Denney  <tdenney@apple.com>
14
15         [WHLSL] Improve test suite type safety
16         https://bugs.webkit.org/show_bug.cgi?id=189502
17
18         Reviewed by Myles C. Maxfield.
19
20         Each of the 'makeT' functions now call the relevant cast function on the
21         value before hand. The checkNumber function has also been removed and
22         its uses have been replaced with functions that also check the type.
23         Some of the arithmetic checks have been updated to reflect that the
24         casts happen outside of WHLSL evaluation. Other tests have also been
25         updated to reflect that some values cannot be precisely expressed in
26         32-bit floating point.
27
28         * WebGPUShadingLanguageRI/Casts.js:
29         (castToBool): Added.
30         (castAndCheckValue): Added.
31         (isBitwiseEquivalent): Moved from Intrinsics.js.
32         * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
33         * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
34         * WebGPUShadingLanguageRI/Test.html: Ditto.
35         * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
36         and check the result. Some tests were also updated to reflect the change
37         in the behavior of these functions.
38         * WebGPUShadingLanguageRI/index.html: Update dependencies.
39
40 2018-09-19  John Wilander  <wilander@apple.com>
41
42         Resource Load Statistics: Add optional cap on partitioned cache max age
43         https://bugs.webkit.org/show_bug.cgi?id=189711
44         <rdar://problem/39246837>
45
46         Reviewed by Antti Koivisto and Chris Dumez.
47
48         This change adds infrastructure for layout tests of capped cache max age.
49
50         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
51         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
52         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
53         * WebKitTestRunner/InjectedBundle/TestRunner.h:
54         * WebKitTestRunner/TestController.cpp:
55         (WTR::TestController::setStatisticsCacheMaxAgeCap):
56         * WebKitTestRunner/TestController.h:
57         * WebKitTestRunner/TestInvocation.cpp:
58         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
59
60 2018-09-19  Dawei Fenton  <realdawei@apple.com>
61
62        Unreviewed. Update my email and alias in list of contributors.
63
64         * Scripts/webkitpy/common/config/contributors.json:
65
66 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
67
68         [WPE][GTK] Unreviewed, try #3 to fix a typo
69
70         I feel like Charlie Brown, how hard this has been for me....
71
72         * Scripts/run-minibrowser:
73         * Scripts/webkitdirs.pm:
74         (runInFlatpakIfAvailable):
75         (runInFlatpakIfAvailible): Deleted.
76
77 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
78
79         [WPE][GTK] Unreviewed, fix that typo in more places
80
81         It got copied into webkitdirs.pm!
82
83         * Scripts/webkitdirs.pm:
84         (runInFlatpakIfAvailible):
85         (runInFlatpakIfAvalaible): Deleted.
86
87 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
88
89         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
90
91         * flatpak/flatpakutils.py:
92         (WebkitFlatpak.load_from_args):
93         (WebkitFlatpak.__init__):
94         (WebkitFlatpak.run):
95
96 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
97
98         [WPE][GTK] Unreviewed, update to latest GNOME SDK
99
100         * flatpak/org.webkit.WebKit.yaml:
101
102 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
103
104         Unreviewed, rolling out r235500.
105
106         Time to switch back to master runtime
107
108         Reverted changeset:
109
110         "Unreviewed, rolling out r235114."
111         https://bugs.webkit.org/show_bug.cgi?id=188731
112         https://trac.webkit.org/changeset/235500
113
114 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
115
116         Unreviewed. Add Pablo Saavedra to the list of contributors.
117
118         * Scripts/webkitpy/common/config/contributors.json:
119
120 2018-09-19  Philippe Normand  <pnormand@igalia.com>
121
122         [GStreamer] Add support for AV1 decoding
123         https://bugs.webkit.org/show_bug.cgi?id=189647
124
125         Reviewed by Žan Doberšek.
126
127         Add patches required for AV1 decoding support. They're all
128         upstream already and will be shipped in GStreamer 1.16. The aom
129         GStreamer plugin depends on the aom library for which there's no
130         official release yet.
131
132         * gstreamer/jhbuild.modules:
133         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
134         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
135         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
136         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
137         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
138         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
139
140 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
141
142         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
143         https://bugs.webkit.org/show_bug.cgi?id=189702
144         <rdar://problem/44541704>
145
146         Reviewed by Aakash Jain.
147
148         * Scripts/webkitpy/layout_tests/controllers/manager.py:
149         (Manager._set_up_run): Move build check and clobbering to run, since set up is
150         run multiple times for iOS simulator.
151         (Manager.run):
152
153 2018-09-18  Chris Dumez  <cdumez@apple.com>
154
155         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
156         https://bugs.webkit.org/show_bug.cgi?id=189681
157         <rdar://problem/44526171>
158
159         Reviewed by Alex Christensen and Zalan Bujtas.
160
161         Add API test coverage.
162
163         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
164         (TestWebKitAPI::didFinishNavigation):
165         (TestWebKitAPI::TEST):
166
167 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
168
169         [WPE] Implement mouse event modifiers
170         https://bugs.webkit.org/show_bug.cgi?id=189697
171
172         Reviewed by Carlos Garcia Campos.
173
174         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
175         (WTR::wkEventModifiersToWPE):
176         (WTR::EventSenderProxy::mouseDown):
177         (WTR::EventSenderProxy::mouseUp):
178
179 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
180
181         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
182         https://bugs.webkit.org/show_bug.cgi?id=185339
183
184         Reviewed by Mark Lam.
185
186         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
187         (TestWebKitAPI::ToUpperConverter::stopProducing):
188         (TestWebKitAPI::ToUpperConverter::stopConsuming):
189
190 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
191
192         Many modern media control tests leak documents in testing
193         https://bugs.webkit.org/show_bug.cgi?id=189437
194
195         Reviewed by Darin Adler.
196         
197         In order to accurately detect leaks in media controls tests which use lots of
198         SVGImages, we have to:
199         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
200           to clear references to elements.
201         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
202           to drop the last handle to the CachedResource for an SVGImage.
203         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
204           to run again after that timer has fired.
205         
206         This should fix most of the spurious leak reports involving SVGImage documents.
207
208         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
209         (WTR::InjectedBundle::reportLiveDocuments):
210         (WTR::InjectedBundle::didReceiveMessageToPage):
211
212 2018-09-17  Chris Dumez  <cdumez@apple.com>
213
214         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
215         https://bugs.webkit.org/show_bug.cgi?id=189602
216         <rdar://problem/44430549>
217
218         Reviewed by Geoff Garen.
219
220         Add API test coverage.
221
222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
223
224 2018-09-17  Philippe Normand  <pnormand@igalia.com>
225
226         [JHBuild] Update to GStreamer 1.14.3
227         https://bugs.webkit.org/show_bug.cgi?id=189450
228
229         Reviewed by Xabier Rodriguez-Calvar.
230
231         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
232
233 2018-09-17  Philippe Normand  <pnormand@igalia.com>
234
235         [JHBuild] Doesn't check sha256 sums
236         https://bugs.webkit.org/show_bug.cgi?id=189646
237
238         Reviewed by Michael Catanzaro.
239
240         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
241
242 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
243
244         Move IndexedDB to Network Process
245         https://bugs.webkit.org/show_bug.cgi?id=189415
246         <rdar://problem/44396973>
247
248         Reviewed by Chris Dumez.
249
250         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
251         (TEST):
252         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
253         (TEST):
254         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
255         (TEST):
256         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
257         (TEST):
258         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
259         (TEST):
260
261 2018-09-08  Darin Adler  <darin@apple.com>
262
263         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
264         https://bugs.webkit.org/show_bug.cgi?id=189455
265
266         Reviewed by Keith Miller.
267
268         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
269         testing and even for macOS vs. iOS vs. Windows platform-specific code.
270         For now, this patch just makes corresponding changes to the copied code.
271         Later we might get better results by merging more code instead of having
272         all these separate copies.
273
274         * DumpRenderTree/AccessibilityController.cpp:
275         (AccessibilityController::makeWindowObject): Use the adopt function
276         instead of the special Adopt constructor of JSRetainPtr.
277
278         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
279
280         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
281         (allAttributesCallback): Don't adopt at this level; changed the
282         underlying function to return a JSRetainPtr so the adopt is right next
283         to the call to the create or copy function.
284         (attributesOfLinkedUIElementsCallback): Ditto.
285         (attributesOfDocumentLinksCallback): Ditto.
286         (attributesOfChildrenCallback): Ditto.
287         (parameterizedAttributeNamesCallback): Ditto.
288         (attributesOfColumnHeadersCallback): Ditto.
289         (attributesOfRowHeadersCallback): Ditto.
290         (attributesOfColumnsCallback): Ditto.
291         (attributesOfRowsCallback): Ditto.
292         (attributesOfVisibleCellsCallback): Ditto.
293         (attributesOfHeaderCallback): Ditto.
294         (rowIndexRangeCallback): Ditto.
295         (columnIndexRangeCallback): Ditto.
296         (rangeForLineCallback): Ditto.
297         (boundsForRangeCallback): Ditto.
298         (rangeForPositionCallback): Ditto.
299         (stringForRangeCallback): Ditto.
300         (attributedStringForRangeCallback): Ditto.
301         (uiElementCountForSearchPredicateCallback): Use the free adopt
302         function instead of the adopt member function.
303         (uiElementForSearchPredicateCallback): Ditto.
304         (selectTextWithCriteriaCallback): Don't adopt at this level.
305         (attributedStringForElementCallback): Ditto.
306         (setValueCallback): Use free adopt.
307         (stringAttributeValueCallback): Don't adopt at this level.
308         (uiElementArrayAttributeValueCallback): Ditto.
309         (uiElementAttributeValueCallback): Ditto.
310         (stringForTextMarkerRangeCallback): Ditto.
311         (attributedStringForTextMarkerRangeCallback): Ditto.
312         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
313         (getARIADropEffectsCallback): Ditto.
314         (getClassListCallback): Ditto.
315         (getRoleCallback): Ditto.
316         (getSubroleCallback): Ditto.
317         (getRoleDescriptionCallback): Ditto.
318         (getComputedRoleStringCallback): Ditto.
319         (getTitleCallback): Ditto.
320         (getDescriptionCallback): Ditto.
321         (getStringValueCallback): Ditto.
322         (getLanguageCallback): Ditto.
323         (getHelpTextCallback): Ditto.
324         (getOrientationCallback): Ditto.
325         (getPathDescriptionCallback): Ditto.
326         (getSelectedTextRangeCallback): Ditto.
327         (speakAsCallback): Ditto.
328         (getValueDescriptionCallback): Ditto.
329         (getAccessibilityValueCallback): Ditto.
330         (getDocumentEncodingCallback): Ditto.
331         (getDocumentURICallback): Ditto.
332         (getURLCallback): Ditto.
333         (characterAtOffsetCallback): Ditto.
334         (wordAtOffsetCallback): Ditto.
335         (lineAtOffsetCallback): Ditto.
336         (sentenceAtOffsetCallback): Ditto.
337         (stringForSelectionCallback): Ditto.
338         (getIdentifierCallback): Ditto.
339         (getTraitsCallback): Ditto.
340         (supportedActionsCallback): Ditto.
341         (mathPostscriptsDescriptionCallback): Ditto.
342         (mathPrescriptsDescriptionCallback): Ditto.
343         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
344         (AccessibilityUIElement::rangeForPosition): Ditto.
345         (AccessibilityUIElement::speakAs): Ditto.
346         (AccessibilityUIElement::pathDescription const): Ditto.
347         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
348         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
349         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
350
351         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
352         raw pointers for the results of the functions that create strings.
353         The old way was difficult to get right; the functions didn't even follow
354         the create/copy naming rule.
355
356         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
357         (_platformTypeConstructor): Use the adopt function instead of the
358         JSRetainPtr adopt constructor. Also nullptr instead of 0.
359
360         * DumpRenderTree/GCController.cpp:
361         (GCController::makeWindowObject): Use adopt function instead of constructor.
362
363         * DumpRenderTree/TestRunner.cpp:
364         (pathToLocalResourceCallback): Use adopt function instead of constructor.
365         (addDisallowedURLCallback): Ditto.
366         (addURLToRedirectCallback): Ditto.
367         (clearApplicationCacheForOriginCallback): Ditto.
368         (applicationCacheDiskUsageForOriginCallback): Ditto.
369         (decodeHostNameCallback): Don't adopt at this level.
370         (encodeHostNameCallback): Ditto.
371         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
372         (findStringCallback): Use adopt function instead of constructor.
373         (isCommandEnabledCallback): Ditto.
374         (overridePreferenceCallback): Ditto.
375         (queueLoadCallback): Ditto.
376         (queueLoadHTMLStringCallback): Ditto.
377         (queueLoadingScriptCallback): Ditto.
378         (queueNonLoadingScriptCallback): Ditto.
379         (setAuthenticationPasswordCallback): Ditto.
380         (setAuthenticationUsernameCallback): Ditto.
381         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
382         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
383         (setPOSIXLocaleCallback): Ditto.
384         (setPersistentUserStyleSheetLocationCallback): Ditto.
385         (setUserStyleSheetLocationCallback): Ditto.
386         (setValueForUserCallback): Ditto.
387         (setWillSendRequestClearHeaderCallback): Ditto.
388         (setPageVisibilityCallback): Ditto.
389         (evaluateInWebInspectorCallback): Ditto.
390         (evaluateScriptInIsolatedWorldCallback): Ditto.
391         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
392         (addOriginAccessWhitelistEntryCallback): Ditto.
393         (removeOriginAccessWhitelistEntryCallback): Ditto.
394         (setScrollbarPolicyCallback): Ditto.
395         (addUserScriptCallback): Ditto.
396         (addUserStyleSheetCallback): Ditto.
397         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
398         (authenticateSessionCallback): Ditto.
399         (getTitleTextDirectionCallback): Ditto.
400         (getInspectorTestStubURLCallback): Ditto.
401         (simulateLegacyWebNotificationClickCallback): Ditto.
402         (setTextDirectionCallback): Ditto.
403         (grantWebNotificationPermissionCallback): Ditto.
404         (denyWebNotificationPermissionCallback): Ditto.
405         (accummulateLogsForChannel): Ditto.
406         (runUIScriptCallback): Ditto.
407         (TestRunner::makeWindowObject): Ditto.
408         (TestRunner::uiScriptDidComplete): Ditto.
409         (TestRunner::setOpenPanelFiles): Ditto.
410
411         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
412         raw pointers for the results of the functions that create strings.
413
414         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
415         (AccessibilityController::platformName const): Use the adopt
416         function instead of the adopt constructor.
417
418         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
419         (createEmptyJSString): Added. This helper function makes reduces the
420         repetitive code to create empty strings.
421         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
422         (AccessibilityUIElement::identifier): Ditto.
423         (AccessibilityUIElement::traits): Ditto.
424         (AccessibilityUIElement::url): Ditto.
425         (AccessibilityUIElement::speakAs): Ditto.
426         (AccessibilityUIElement::stringForSelection): Ditto.
427         (AccessibilityUIElement::stringForRange): Ditto.
428         (AccessibilityUIElement::attributedStringForRange): Ditto.
429         (AccessibilityUIElement::attributedStringForElement): Ditto.
430         (AccessibilityUIElement::pathDescription const): Ditto.
431         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
432         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
433         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
434         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
435         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
436         (AccessibilityUIElement::attributesOfChildren): Ditto.
437         (AccessibilityUIElement::allAttributes): Ditto.
438         (AccessibilityUIElement::stringAttributeValue): Ditto.
439         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
440         (AccessibilityUIElement::role): Ditto.
441         (AccessibilityUIElement::subrole): Ditto.
442         (AccessibilityUIElement::roleDescription): Ditto.
443         (AccessibilityUIElement::computedRoleString): Ditto.
444         (AccessibilityUIElement::title): Ditto.
445         (AccessibilityUIElement::description): Ditto.
446         (AccessibilityUIElement::orientation const): Ditto.
447         (AccessibilityUIElement::stringValue): Ditto.
448         (AccessibilityUIElement::language): Ditto.
449         (AccessibilityUIElement::helpText const): Ditto.
450         (AccessibilityUIElement::valueDescription): Ditto.
451         (AccessibilityUIElement::ariaDropEffects const): Ditto.
452         (AccessibilityUIElement::boundsForRange): Ditto.
453         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
454         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
455         (AccessibilityUIElement::attributesOfColumns): Ditto.
456         (AccessibilityUIElement::attributesOfRows): Ditto.
457         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
458         (AccessibilityUIElement::attributesOfHeader): Ditto.
459         (AccessibilityUIElement::rowIndexRange): Ditto.
460         (AccessibilityUIElement::columnIndexRange): Ditto.
461         (AccessibilityUIElement::selectedTextRange): Ditto.
462         (AccessibilityUIElement::accessibilityValue const): Ditto.
463         (AccessibilityUIElement::documentEncoding): Ditto.
464         (AccessibilityUIElement::documentURI): Ditto.
465         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
466         (AccessibilityUIElement::classList const): Ditto.
467
468         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
469         createJSStringRef method to return a JSRetainPtr.
470         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
471         (-[NSString createJSStringRef]): Ditto.
472         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
473         adopt function instead of the adopt constructor.
474         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
475         (AccessibilityController::platformName const): Ditto.
476
477         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
478         (-[NSString createJSStringRef]): Return a JSRetainPtr.
479         (makeValueRefForValue): Updated for the above, no adopt needed here now.
480         (makeObjectRefForDictionary): Ditto.
481         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
482
483         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
484         (createEmptyJSString): Added. This helper function makes reduces the
485         repetitive code to create empty strings.
486         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
487         (descriptionOfElements): Ditto.
488         (selectTextParameterizedAttributeForCriteria): Ditto.
489         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
490         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
491         (AccessibilityUIElement::attributesOfChildren): Ditto.
492         (AccessibilityUIElement::allAttributes): Ditto.
493         (AccessibilityUIElement::stringAttributeValue): Ditto.
494         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
495         (AccessibilityUIElement::role): Ditto.
496         (AccessibilityUIElement::subrole): Ditto.
497         (AccessibilityUIElement::roleDescription): Ditto.
498         (AccessibilityUIElement::computedRoleString): Ditto.
499         (AccessibilityUIElement::title): Ditto.
500         (AccessibilityUIElement::description): Ditto.
501         (AccessibilityUIElement::orientation const): Ditto.
502         (AccessibilityUIElement::stringValue): Ditto.
503         (AccessibilityUIElement::language): Ditto.
504         (AccessibilityUIElement::helpText const): Ditto.
505         (AccessibilityUIElement::valueDescription): Ditto.
506         (AccessibilityUIElement::speakAs): Ditto.
507         (AccessibilityUIElement::classList const): Ditto.
508         (AccessibilityUIElement::ariaDropEffects const): Ditto.
509         (AccessibilityUIElement::rangeForLine): Ditto.
510         (AccessibilityUIElement::rangeForPosition): Ditto.
511         (AccessibilityUIElement::boundsForRange): Ditto.
512         (AccessibilityUIElement::stringForRange): Ditto.
513         (AccessibilityUIElement::attributedStringForRange): Ditto.
514         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
515         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
516         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
517         (AccessibilityUIElement::attributesOfColumns): Ditto.
518         (AccessibilityUIElement::attributesOfRows): Ditto.
519         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
520         (AccessibilityUIElement::attributesOfHeader): Ditto.
521         (AccessibilityUIElement::rowIndexRange): Ditto.
522         (AccessibilityUIElement::columnIndexRange): Ditto.
523         (AccessibilityUIElement::pathDescription const): Ditto.
524         (AccessibilityUIElement::selectedTextRange): Ditto.
525         (AccessibilityUIElement::accessibilityValue const): Ditto.
526         (AccessibilityUIElement::documentEncoding): Ditto.
527         (AccessibilityUIElement::documentURI): Ditto.
528         (AccessibilityUIElement::url): Ditto.
529         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
530         (createJSStringRef): Ditto.
531         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
532         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
533         (AccessibilityUIElement::supportedActions): Ditto.
534         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
535         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
536
537         * DumpRenderTree/mac/FrameLoadDelegate.mm:
538         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
539         Use the adopt function instead of the adopt constructor.
540         * DumpRenderTree/mac/TestRunnerMac.mm:
541         (originsArrayToJS): Ditto.
542         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
543         (TestRunner::copyEncodedHostName): Ditto.
544         (TestRunner::pathToLocalResource): Ditto.
545         (TestRunner::queueLoad): Use adopt function instead of constructor.
546         (TestRunner::findString): Ditto.
547         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
548
549         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
550         (AccessibilityController::winNotificationReceived): Use adopt function
551         instead of adopt constructor.
552         (AccessibilityController::platformName const): Ditto.
553
554         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
555         (createEmptyJSString): Added. This helper function makes reduces the
556         repetitive code to create empty strings.
557         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
558         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
559         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
560         (AccessibilityUIElement::attributesOfChildren): Ditto.
561         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
562         (AccessibilityUIElement::role): Ditto.
563         (AccessibilityUIElement::subrole): Ditto.
564         (AccessibilityUIElement::roleDescription): Ditto.
565         (AccessibilityUIElement::computedRoleString): Ditto.
566         (AccessibilityUIElement::title): Ditto.
567         (AccessibilityUIElement::description): Ditto.
568         (AccessibilityUIElement::stringValue): Ditto.
569         (AccessibilityUIElement::language): Ditto.
570         (AccessibilityUIElement::helpText const): Ditto.
571         (AccessibilityUIElement::valueDescription): Ditto.
572         (AccessibilityUIElement::ariaDropEffects const): Ditto.
573         (AccessibilityUIElement::orientation const): Ditto.
574         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
575         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
576         (AccessibilityUIElement::attributesOfColumns): Ditto.
577         (AccessibilityUIElement::attributesOfRows): Ditto.
578         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
579         (AccessibilityUIElement::attributesOfHeader): Ditto.
580         (AccessibilityUIElement::rowIndexRange): Ditto.
581         (AccessibilityUIElement::columnIndexRange): Ditto.
582         (AccessibilityUIElement::boundsForRange): Ditto.
583         (AccessibilityUIElement::stringForRange): Ditto.
584         (AccessibilityUIElement::attributedStringForRange): Ditto.
585         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
586         (AccessibilityUIElement::selectedTextRange): Ditto.
587         (AccessibilityUIElement::stringAttributeValue): Ditto.
588         (AccessibilityUIElement::accessibilityValue const): Ditto.
589         (AccessibilityUIElement::documentEncoding): Ditto.
590         (AccessibilityUIElement::documentURI): Ditto.
591         (AccessibilityUIElement::url): Ditto.
592         (AccessibilityUIElement::classList const): Ditto.
593
594         * DumpRenderTree/win/TestRunnerWin.cpp:
595         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
596         (TestRunner::copyEncodedHostName): Ditto.
597         (TestRunner::pathToLocalResource): Ditto.
598         (TestRunner::queueLoad): Ditto.
599         (TestRunner::findString): Ditto.
600         (TestRunner::inspectorTestStubURL): Ditto.
601
602         * TestRunnerShared/Bindings/JSWrapper.h:
603         (WTR::setProperty): Use adopt function instead of constructor.
604         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
605         (UIScriptContext::UIScriptContext): Ditto.
606         (UIScriptContext::runUIScript): Ditto.
607         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
608         (WTR::toDeviceOrientation): Ditto.
609
610         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
611         (nsTextCheckingType): Changed this function to not take an rvalue
612         reference to a JSRetainPtr since it doesn't take ownership.
613         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
614         for the above change.
615
616         * TestWebKitAPI/JavaScriptTest.cpp:
617         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
618         adopt member function.
619
620         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
621         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
622         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
623         adopt constructor.
624         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
625
626         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
627         Removed unneeded includes.
628         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
629         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
630         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
631
632         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
633         (_platformTypeConstructor): Use the adopt function instead of the
634         JSRetainPtr adopt constructor. Also nullptr instead of 0.
635
636         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
637         (WTR::arrayLength): Use adopt function instead of constructor.
638         (WTR::parseModifierArray): Ditto.
639         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
640         (WTR::propertyValue): Ditto.
641         (WTR::dumpPath): Ditto.
642         (WTR::toJS): Ditto.
643         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
644         (WTR::TestRunner::findString): Ditto.
645         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
646         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
647         (WTR::TestRunner::setOpenPanelFiles): Ditto.
648         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
649         (WTR::AccessibilityController::platformName): Ditto.
650
651         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
652         (-[NSString createJSStringRef]): Return a JSRetainPtr.
653         This fixes storage leaks in many functions below, which were using
654         the create function and putting the value right into a JSRetainPtr
655         without adoption.
656         (WTR::createEmptyJSString): Added. This helper function reduces the
657         repetitive code to create empty strings.
658         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
659         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
660         Use createEmptyJSString, fixing a storage leak due to missing adoption.
661         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
662         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
663         (WTR::AccessibilityUIElement::allAttributes): Ditto.
664         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
665         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
666         (WTR::AccessibilityUIElement::role): Ditto.
667         (WTR::AccessibilityUIElement::subrole): Ditto.
668         (WTR::AccessibilityUIElement::roleDescription): Ditto.
669         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
670         (WTR::AccessibilityUIElement::title): Ditto.
671         (WTR::AccessibilityUIElement::orientation const): Ditto.
672         (WTR::AccessibilityUIElement::language): Ditto.
673         (WTR::AccessibilityUIElement::valueDescription): Ditto.
674         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
675         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
676         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
677         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
678         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
679         Use createEmptyJSString, fixing a storage leak due to missing adoption.
680         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
681         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
682         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
683         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
684         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
685         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
686         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
687         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
688         (WTR::AccessibilityUIElement::documentURI): Ditto.
689         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
690         null check.
691         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
692         Use createEmptyJSString, fixing a storage leak due to missing adoption.
693
694         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
695         Use JSRetainPtr for the return value of createJSStringRef.
696         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
697         (-[NSString createJSStringRef]): Ditto.
698         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
699         adopt function instead of the adopt constructor.
700         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
701         (WTR::AccessibilityController::platformName): Ditto
702
703         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
704         (-[NSString createJSStringRef]): Return a JSRetainPtr.
705         (makeValueRefForValue): Updated for above by removing adopt.
706         (makeObjectRefForDictionary): Ditto.
707         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
708
709         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
710         (WTR::createEmptyJSString): Added. This helper function makes reduces the
711         repetitive code to create empty strings.
712         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
713         (WTR::descriptionOfElements): Ditto.
714         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
715         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
716         fixing a storage leak due to missing adoption.
717         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
718         (WTR::AccessibilityUIElement::documentURI): Ditto.
719         (WTR::createJSStringRef): Return a JSRetainPtr.
720
721         * WebKitTestRunner/StringFunctions.h:
722         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
723         (WTR::toJS): Use the adopt function instead of the constructor.
724
725 2018-09-14  Dean Jackson  <dino@grorg.org>
726
727         Add Justin Michaud.
728
729         * Scripts/webkitpy/common/config/contributors.json:
730
731 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
732
733         bots should pass --clobber-old-results to run-webkit-tests
734         https://bugs.webkit.org/show_bug.cgi?id=189623
735
736         Reviewed by Aakash Jain.
737
738         In order to ensure that bots to not produce confusing results due to transient execptions,
739         or run out of space if they continually hit an exception, old layout test results should be clobbered.
740
741         * BuildSlaveSupport/build.webkit.org-config/steps.py:
742         (RunWebKitTests):
743
744 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
745
746         Unreviewed, rolling out r235954.
747
748         Breaks the watchOS build.
749
750         Reverted changeset:
751
752         "Move IndexedDB to Network Process"
753         https://bugs.webkit.org/show_bug.cgi?id=189415
754         https://trac.webkit.org/changeset/235954
755
756 2018-09-13  Daniel Bates  <dabates@apple.com>
757
758         Add Copy WebKit Permalink plugin for Sublime Text
759         https://bugs.webkit.org/show_bug.cgi?id=189589
760
761         Rubber-stamped by Joseph Pecoraro.
762
763         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
764         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
765         active document with or without blame annotations.
766
767         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
768         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
769         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
770         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
771         and Command + Shift + Control + Option + C, respectively.
772
773         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
774         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
775         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
776         * CopyPermalink/Sublime Text/INSTALL: Added.
777         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
778         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
779         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
780
781 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
782
783         Unreviewed. Fix WebDriver tests after r235225.
784
785         Use wpt serve command to run the http server.
786
787         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
788         (WebDriverW3CWebServer.__init__):
789         (WebDriverW3CWebServer.start):
790         (WebDriverW3CWebServer.stop):
791
792 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
793
794         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
795         https://bugs.webkit.org/show_bug.cgi?id=189544
796
797         Reviewed by Michael Catanzaro.
798
799         Add test cases for the new API.
800
801         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
802         (testWebViewJavaScriptDialogs):
803
804 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
805
806         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
807         https://bugs.webkit.org/show_bug.cgi?id=189496
808         <rdar://problem/44370981>
809
810         Unreviewed warning fix.
811
812         r235929 has introduced a new compilation warning:
813         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
814
815         * ImageDiff/cairo/PlatformImageCairo.cpp:
816         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
817
818 2018-09-12  Dan Bernstein  <mitz@apple.com>
819
820         [Cocoa] Complete support for Paste as Quotation
821         https://bugs.webkit.org/show_bug.cgi?id=189504
822
823         Reviewed by Wenson Hsieh.
824
825         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
826
827 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
828
829         Move IndexedDB to Network Process
830         https://bugs.webkit.org/show_bug.cgi?id=189415
831
832         Reviewed by Geoffrey Garen.
833
834         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
835         (TEST):
836         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
837         (TEST):
838         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
839         (TEST):
840         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
841         (TEST):
842         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
843         (TEST):
844
845 2018-09-12  Chris Dumez  <cdumez@apple.com>
846
847         PSON: No process swap on back navigation after URL bar navigation
848         https://bugs.webkit.org/show_bug.cgi?id=189557
849         <rdar://problem/44353108>
850
851         Reviewed by Alex Christensen.
852
853         Add API test coverage.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
856
857 2018-09-11  Dean Jackson  <dino@apple.com>
858
859         Header parsing for experimental and internal debug features
860         https://bugs.webkit.org/show_bug.cgi?id=189486
861         <rdar://problem/44320618>
862
863         Reviewed by Tim Horton.
864
865         Keep track of experimental and internal debug features in TestOptions, and
866         allow webkit-test-runner headers to toggle them by name.
867
868         * DumpRenderTree/TestOptions.cpp:
869         (TestOptions::TestOptions):
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::resetPreferencesToConsistentValues):
872         (WTR::updateTestOptionsFromTestHeader):
873         * WebKitTestRunner/TestOptions.h:
874         (WTR::TestOptions::hasSameInitializationOptions const):
875
876 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
877
878         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
879         https://bugs.webkit.org/show_bug.cgi?id=189492
880
881         Reviewed by Alex Christensen.
882
883         0 and nullptr can't be implicitly converted to
884         AccessibilityUIElement because only Windows port typedefs
885         PlatformUIElement as COMPtr<IAccessible> not a pointer.
886
887         Replaced "return 0" and "return nullptr" with "return { nullptr }".
888
889         * DumpRenderTree/AccessibilityUIElement.cpp:
890         (AccessibilityUIElement::horizontalScrollbar const):
891         (AccessibilityUIElement::verticalScrollbar const):
892         (AccessibilityUIElement::uiElementAttributeValue const):
893         (AccessibilityUIElement::accessibilityElementForTextMarker):
894         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
895         (AccessibilityController::elementAtPoint):
896         (AccessibilityController::accessibleElementById):
897         (AccessibilityController::focusedElement):
898         (AccessibilityController::rootElement):
899         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
900         (AccessibilityUIElement::elementAtPoint):
901         (AccessibilityUIElement::linkedUIElementAtIndex):
902         (AccessibilityUIElement::getChildAtIndex):
903         (AccessibilityUIElement::titleUIElement):
904         (AccessibilityUIElement::parentElement):
905         (AccessibilityUIElement::uiElementForSearchPredicate):
906         (AccessibilityUIElement::cellForColumnAndRow):
907         (AccessibilityUIElement::disclosedRowAtIndex):
908         (AccessibilityUIElement::ariaOwnsElementAtIndex):
909         (AccessibilityUIElement::ariaFlowToElementAtIndex):
910         (AccessibilityUIElement::ariaControlsElementAtIndex):
911         (AccessibilityUIElement::selectedRowAtIndex):
912         (AccessibilityUIElement::rowAtIndex):
913         (AccessibilityUIElement::disclosedByRow):
914         (AccessibilityUIElement::selectedChildAtIndex const):
915
916 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
917
918         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
919         https://bugs.webkit.org/show_bug.cgi?id=189382
920
921         Reviewed by Ryosuke Niwa.
922
923         Fix the test by specifying colors in RGB colorspace.
924
925         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
926         (TestWebKitAPI::TEST):
927
928 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
929
930         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
931         https://bugs.webkit.org/show_bug.cgi?id=189496
932
933         Reviewed by Alex Christensen.
934
935         * ImageDiff/cairo/PlatformImageCairo.cpp:
936         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
937         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
938
939 2018-09-07  Dean Jackson  <dino@apple.com>
940
941         Add and expose Internal features from WebKit
942         https://bugs.webkit.org/show_bug.cgi?id=189442
943         <rdar://problem/44243404>
944
945         Reviewed by Simon Fraser.
946
947         Update MiniBrowser to expose an Internal feature menu.
948
949         * MiniBrowser/mac/AppDelegate.m:
950         (defaultConfiguration):
951         * MiniBrowser/mac/SettingsController.m:
952         (-[SettingsController _populateMenu]):
953         (-[SettingsController validateMenuItem:]):
954         (-[SettingsController toggleExperimentalFeature:]):
955         (-[SettingsController toggleInternalDebugFeature:]):
956
957 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
958
959         [macOS] [WK2] Support changing foreground colors via color panel
960         https://bugs.webkit.org/show_bug.cgi?id=189382
961         <rdar://problem/44227311>
962
963         Reviewed by Ryosuke Niwa.
964
965         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
966         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
967         colors, as well as making different parts of a word different colors.
968
969         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
970         (-[TestWKWebView collapseToEnd]):
971         (webViewForFontManagerTesting):
972         (TestWebKitAPI::TEST):
973         * TestWebKitAPI/cocoa/TestWKWebView.h:
974
975 == Rolled over to ChangeLog-2018-09-11 ==