Tools/ChangeLog

   1 2015-06-28  Dan Bernstein  <mitz@apple.com>
   2
   3         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
   4         https://bugs.webkit.org/show_bug.cgi?id=146396
   5
   6         Reviewed by Anders Carlsson.
   7
   8         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
   9         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
  10         (TestWebKitAPI::TEST): Updated for renames.
  11         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
  12         (runJavaScriptAlert): Removed suffix.
  13         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
  14         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
  15         (runJavaScriptAlert): Removed suffix.
  16         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
  17
  18 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
  19
  20         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
  21         https://bugs.webkit.org/show_bug.cgi?id=146318
  22
  23         Reviewed by Sergio Villar Senin.
  24
  25         Copy mac PublicSuffix test to the common directory and add it to
  26         the GTK+ build.
  27
  28         * TestWebKitAPI/PlatformGTK.cmake:
  29         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
  30         (TestWebKitAPI::TEST_F):
  31
  32 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
  33
  34         WinLauncher fails to download files.
  35         https://bugs.webkit.org/show_bug.cgi?id=146242
  36
  37         Reviewed by Alex Christensen.
  38
  39         Added WinLauncher download delegate.
  40
  41         * WinLauncher/Common.cpp:
  42         * WinLauncher/WebDownloadDelegate.cpp: Added.
  43         (WebDownloadDelegate::WebDownloadDelegate):
  44         (WebDownloadDelegate::~WebDownloadDelegate):
  45         (WebDownloadDelegate::QueryInterface):
  46         (WebDownloadDelegate::AddRef):
  47         (WebDownloadDelegate::Release):
  48         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
  49         (WebDownloadDelegate::didCancelAuthenticationChallenge):
  50         (WebDownloadDelegate::didCreateDestination):
  51         (WebDownloadDelegate::didFailWithError):
  52         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
  53         (WebDownloadDelegate::didReceiveDataOfLength):
  54         (WebDownloadDelegate::didReceiveResponse):
  55         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
  56         (WebDownloadDelegate::willResumeWithResponse):
  57         (WebDownloadDelegate::willSendRequest):
  58         (WebDownloadDelegate::didBegin):
  59         (WebDownloadDelegate::didFinish):
  60         * WinLauncher/WebDownloadDelegate.h: Added.
  61         * WinLauncher/WinLauncher.cpp:
  62         (WinLauncher::setAccessibilityDelegate):
  63         (WinLauncher::setResourceLoadDelegate):
  64         (WinLauncher::setDownloadDelegate):
  65         (WinLauncher::mainFrame):
  66         * WinLauncher/WinLauncher.h:
  67         (WinLauncher::standardPreferences):
  68         (WinLauncher::privatePreferences):
  69         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
  70         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
  71         * WinLauncher/WinMain.cpp:
  72         (wWinMain):
  73
  74 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
  75
  76         [EFL] Bump libseccomp version to 2.2.1
  77         https://bugs.webkit.org/show_bug.cgi?id=146341
  78
  79         Reviewed by Gyuyoung Kim.
  80
  81         * efl/jhbuild.modules:
  82         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
  83         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
  84
  85 2015-06-25  Alex Christensen  <achristensen@webkit.org>
  86
  87         [Content Extensions] Add a way to match a domain but not subdomains
  88         https://bugs.webkit.org/show_bug.cgi?id=146241
  89         rdar://problem/21557754
  90
  91         Reviewed by Darin Adler.
  92
  93         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
  94         (TestWebKitAPI::TEST_F):
  95         Update subdomain test because of changed behavior and add test for new '*' functionality.
  96
  97 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
  98
  99         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
 100         https://bugs.webkit.org/show_bug.cgi?id=146308
 101
 102         Reviewed by Csaba Osztrogonác.
 103
 104         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
 105
 106         * Scripts/webkitperl/FeatureList.pm:
 107
 108 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
 109
 110         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
 111         https://bugs.webkit.org/show_bug.cgi?id=146149
 112
 113         Reviewed by Sergio Villar Senin.
 114
 115         Update unit tests to use WebKitWebsiteDataManager.
 116
 117         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
 118         (testWebContextConfiguration):
 119         (serverCallback):
 120         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
 121         (Test::Test): Use WebKitWebsiteDataManager and set all possible
 122         values to ensure unit tests don't write outside the temporary directory.
 123         (Test::~Test): Explicitly reset the web context to ensure its
 124         objects are released before the leaks check.
 125         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
 126         (WebViewTest::wait): Fix the GSource used, since we are receiving
 127         a double in seconds, but using g_timeout_add_seconds() that
 128         expects an unsigned in seconds. Use GMainLoopSource to correctly
 129         handle the value and simplify the code.
 130
 131 2015-06-24  Jason Marcell  <jmarcell@apple.com>
 132
 133         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
 134         https://bugs.webkit.org/show_bug.cgi?id=146126
 135         <rdar://problem/18226291>
 136
 137         Reviewed by Alexey Proskuryakov.
 138
 139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
 140         (documentReady): Using combined queues to display iOS projects
 141
 142 2015-06-24  Doug Russell  <d_russell@apple.com>
 143
 144         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject
 145         when posting a selection notification when on the border between two accessibilityObjects
 146         https://bugs.webkit.org/show_bug.cgi?id=146177
 147
 148         Reviewed by Darin Adler.
 149
 150         Add support for mapping WebCore Accessibility types into JSValueRef types
 151         so they can be used in tests.
 152
 153         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
 154         (webAccessibilityObjectWrapperClass):
 155         (-[AccessibilityNotificationHandler startObserving]):
 156         (makeValueRefForValue):
 157         (makeArrayRefForArray):
 158         (makeObjectRefForDictionary):
 159         (-[AccessibilityNotificationHandler _notificationReceived:]):
 160         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
 161         (webAccessibilityObjectWrapperClass):
 162         (-[AccessibilityNotificationHandler startObserving]):
 163         (makeValueRefForValue):
 164         (makeArrayRefForArray):
 165         (makeObjectRefForDictionary):
 166         (-[AccessibilityNotificationHandler _notificationReceived:]):
 167
 168 2015-06-24  Zalan Bujtas  <zalan@apple.com>
 169
 170         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
 171         https://bugs.webkit.org/show_bug.cgi?id=146273
 172         rdar://problem/18509840
 173
 174         Reviewed by Simon Fraser.
 175
 176         Due to the floating point approximate representation, we can't always produce
 177         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
 178         and by changing the rounding in roundToDevicePixel() from float to double.
 179
 180         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
 181         (TestWebKitAPI::TEST):
 182
 183 2015-06-24  Brady Eidson  <beidson@apple.com>
 184
 185         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
 186         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
 187
 188         Reviewed by Alex Christensen.
 189
 190         - Update WKTR to the new client structure.
 191         - Update existing TestWebKitAPI tests to either use the new client structure or
 192           assign the old function signature to the updated variable name.
 193         - Include a new test.
 194
 195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 196
 197         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
 198         (TestWebKitAPI::runJavaScriptAlert):
 199
 200         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 201         (TestWebKitAPI::TEST):
 202
 203         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
 204         (TestWebKitAPI::analyzeDialogArguments):
 205         (TestWebKitAPI::runJavaScriptAlert):
 206         (TestWebKitAPI::runJavaScriptConfirm):
 207         (TestWebKitAPI::runJavaScriptPrompt):
 208         (TestWebKitAPI::createNewPage):
 209         (TestWebKitAPI::TEST):
 210
 211         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
 212         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
 213
 214         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 215         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
 216
 217         * WebKitTestRunner/TestController.cpp:
 218         (WTR::TestController::createOtherPage):
 219         (WTR::TestController::createWebViewWithOptions):
 220
 221 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
 222
 223         Refactoring benchmark runner script to follow pep8 code style.
 224         https://bugs.webkit.org/show_bug.cgi?id=146264
 225
 226         Reviewed by Ryosuke Niwa.
 227
 228         Refactor benchmark runner script to follow pep8 code style.
 229
 230         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
 231         (GenericBenchmarkBuilder.prepare):
 232         (GenericBenchmarkBuilder._run_create_script):
 233         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
 234         (GenericBenchmarkBuilder._fetch_remote_archive):
 235         (GenericBenchmarkBuilder):
 236         (GenericBenchmarkBuilder._checkout_with_subversion):
 237         (GenericBenchmarkBuilder._apply_patch):
 238         (GenericBenchmarkBuilder.clean):
 239         (GenericBenchmarkBuilder._runCreateScript): Deleted.
 240         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
 241         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
 242         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
 243         (GenericBenchmarkBuilder._applyPatch): Deleted.
 244         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 245         (BenchmarkRunner.__init__):
 246         (BenchmarkRunner._find_plan_file):
 247         (BenchmarkRunner.execute):
 248         (BenchmarkRunner._cleanup):
 249         (BenchmarkRunner._dump):
 250         (BenchmarkRunner._wrap):
 251         (BenchmarkRunner._merge):
 252         (BenchmarkRunner._show_results):
 253         (BenchmarkRunner._findPlanFile): Deleted.
 254         (BenchmarkRunner.cleanup): Deleted.
 255         (BenchmarkRunner.dump): Deleted.
 256         (BenchmarkRunner.wrap): Deleted.
 257         (BenchmarkRunner.merge): Deleted.
 258         (BenchmarkRunner.show_results): Deleted.
 259         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 260         (BrowserDriver.prepare_env):
 261         (BrowserDriver.launch_url):
 262         (BrowserDriver.close_browsers):
 263         (BrowserDriver.prepareEnv): Deleted.
 264         (BrowserDriver.launchUrl): Deleted.
 265         (BrowserDriver.closeBrowser): Deleted.
 266         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 267         (OSXBrowserDriver):
 268         (OSXBrowserDriver.prepare_env):
 269         (OSXBrowserDriver.close_browsers):
 270         (OSXBrowserDriver._launch_process):
 271         (OSXBrowserDriver._terminiate_processes):
 272         (OSXBrowserDriver._launch_process_with_caffinate):
 273         (OSXBrowserDriver._screen_size):
 274         (OSXBrowserDriver.prepareEnv): Deleted.
 275         (OSXBrowserDriver.closeBrowsers): Deleted.
 276         (OSXBrowserDriver.launchProcess): Deleted.
 277         (OSXBrowserDriver.terminateProcesses): Deleted.
 278         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
 279         (OSXBrowserDriver.screenSize): Deleted.
 280         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 281         (OSXChromeDriver):
 282         (OSXChromeDriver.launch_url):
 283         (OSXChromeCanaryDriver):
 284         (OSXChromeCanaryDriver.launch_url):
 285         (OSXChromeDriver.launchUrl): Deleted.
 286         (OSXChromeCanaryDriver.launchUrl): Deleted.
 287         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 288         (OSXFirefoxDriver):
 289         (OSXFirefoxDriver.launch_url):
 290         (OSXFirefoxNightlyDriver):
 291         (OSXFirefoxNightlyDriver.launch_url):
 292         (OSXFirefoxDriver.launchUrl): Deleted.
 293         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
 294         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 295         (OSXSafariDriver):
 296         (OSXSafariDriver.prepare_env):
 297         (OSXSafariDriver.launch_url):
 298         (OSXSafariDriver.close_browsers):
 299         (OSXSafariDriver._maximize_window):
 300         (OSXSafariDriver.prepareEnv): Deleted.
 301         (OSXSafariDriver.launchUrl): Deleted.
 302         (OSXSafariDriver.closeBrowsers): Deleted.
 303         (OSXSafariDriver.maximizeWindow): Deleted.
 304         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 305         (HTTPServerDriver.fetch_result):
 306         (HTTPServerDriver.kill_server):
 307         (HTTPServerDriver.get_return_code):
 308         (HTTPServerDriver.set_device_id):
 309         (HTTPServerDriver.fetchResult): Deleted.
 310         (HTTPServerDriver.killServer): Deleted.
 311         (HTTPServerDriver.getReturnCode): Deleted.
 312         (HTTPServerDriver.setDeviceID): Deleted.
 313         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
 314         (SimpleHTTPServerDriver.serve):
 315         (SimpleHTTPServerDriver.base_url):
 316         (SimpleHTTPServerDriver.fetch_result):
 317         (SimpleHTTPServerDriver.kill_server):
 318         (SimpleHTTPServerDriver.get_return_code):
 319         (SimpleHTTPServerDriver): Deleted.
 320         (SimpleHTTPServerDriver.baseUrl): Deleted.
 321         (SimpleHTTPServerDriver.fetchResult): Deleted.
 322         (SimpleHTTPServerDriver.killServer): Deleted.
 323         (SimpleHTTPServerDriver.getReturnCode): Deleted.
 324         * Scripts/webkitpy/benchmark_runner/utils.py:
 325         (get_path_from_project_root):
 326         (force_remove):
 327         (getPathFromProjectRoot): Deleted.
 328         (forceRemove): Deleted.
 329
 330 2015-06-23  Anders Carlsson  <andersca@apple.com>
 331
 332         Add operator! and copy/move constructors to WeakObjCPtr
 333         https://bugs.webkit.org/show_bug.cgi?id=146255
 334
 335         Reviewed by Andreas Kling.
 336
 337         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
 338         (TEST):
 339
 340 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
 341
 342         Expose some more rendering progress events, and have MiniBrowser log for each of them
 343         https://bugs.webkit.org/show_bug.cgi?id=146227
 344
 345         Reviewed by Darin Adler.
 346
 347         Register for layout milestones/rendering progress events in the WK1 and WK2
 348         browser window controllers, and, if logging is turned on, log when they are
 349         reached.
 350
 351         * MiniBrowser/mac/WK1BrowserWindowController.m:
 352         (-[WK1BrowserWindowController awakeFromNib]):
 353         (-[WK1BrowserWindowController webView:didLayout:]):
 354         * MiniBrowser/mac/WK2BrowserWindowController.m:
 355         (-[WK2BrowserWindowController awakeFromNib]):
 356         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
 357
 358 2015-06-23  Brady Eidson  <beidson@apple.com>
 359
 360         WKFrameInfo should have an accessor for the Frame's current security origin.
 361         https://bugs.webkit.org/show_bug.cgi?id=146162
 362
 363         Reviewed by Dan Bernstein.
 364
 365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 366         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
 367         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
 368         (sawDialog):
 369         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
 370         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
 371         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
 372         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
 373         (TEST):
 374
 375 2015-06-23  Tanay C  <tanay.c@samsung.com>
 376
 377         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
 378         https://bugs.webkit.org/show_bug.cgi?id=146007
 379
 380         Reviewed by Darin Adler.
 381
 382         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 383         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
 384         (pluginLogWithWindowObject):
 385         (pluginLogWithArguments):
 386         (pluginLog):
 387         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
 388         (PluginTest::executeScript):
 389         (PluginTest::log):
 390
 391 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
 392
 393         [EFL] Add libhyphen-dev as dependency after r185862
 394         https://bugs.webkit.org/show_bug.cgi?id=146230
 395
 396         Reviewed by Gyuyoung Kim.
 397
 398         * efl/install-dependencies:
 399
 400 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
 401
 402         [EFL] Hyphenation is not supported
 403         https://bugs.webkit.org/show_bug.cgi?id=89830
 404
 405         Reviewed by Gyuyoung Kim.
 406
 407         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
 408
 409 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
 410
 411         Get rid of factory json files in benchmark_runner
 412         https://bugs.webkit.org/show_bug.cgi?id=146175
 413
 414         Reviewed by Ryosuke Niwa.
 415
 416         Get rid of factory json files in benchmark_runner and refactoring the code.
 417
 418         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
 419         (benchmark_builder_loader):
 420         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
 421         (BenchmarkBuilderFactory):
 422         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
 423         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
 424         (GenericBenchmarkBuilder):
 425         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 426         (BenchmarkRunner.__init__):
 427         (BenchmarkRunner.execute):
 428         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
 429         (browser_driver_loader):
 430         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 431         (BrowserDriver):
 432         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
 433         (BrowserDriverFactory):
 434         (BrowserDriverFactory.available_platforms):
 435         (BrowserDriverFactory.available_browsers):
 436         (BrowserDriverFactory.add_browser_driver):
 437         (BrowserDriverFactory.create):
 438         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
 439         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 440         (OSXBrowserDriver):
 441         (OSXBrowserDriver.prepareEnv):
 442         (OSXBrowserDriver.terminateProcesses):
 443         (OSXBrowserDriver.screenSize):
 444         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 445         (OSXChromeDriver):
 446         (OSXChromeCanaryDriver):
 447         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 448         (OSXFirefoxDriver):
 449         (OSXFirefoxNightlyDriver):
 450         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 451         (OSXSafariDriver):
 452         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
 453         (GenericFactory.create):
 454         (GenericFactory.add):
 455         (GenericFactory.iterateGetItem): Deleted.
 456         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
 457         (http_server_driver_loader):
 458         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 459         (HTTPServerDriver):
 460         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
 461         (HTTPServerDriverFactory):
 462         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
 463         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
 464         (SimpleHTTPServerDriver):
 465         * Scripts/webkitpy/benchmark_runner/utils.py:
 466         (is_subclass):
 467         (load_subclasses):
 468         (ModuleNotFoundError): Deleted.
 469         (loadModule): Deleted.
 470         (loadJSONFromFile): Deleted.
 471
 472 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
 473
 474         Make it possible to enable incremental rendering suppression in MiniBrowser
 475         https://bugs.webkit.org/show_bug.cgi?id=146223
 476
 477         Reviewed by Tim Horton.
 478
 479         Add a menu item to enable incremental rendering suppression to MiniBrowser.
 480
 481         For WK1, this just toggles a pref, and takes effect immediately.
 482
 483         For WK2, this is a WKConfiguration property, so only affects new web views.
 484
 485         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
 486         logging on launch.
 487
 488         * MiniBrowser/mac/AppDelegate.m:
 489         (defaultConfiguration):
 490         * MiniBrowser/mac/BrowserWindow.xib:
 491         * MiniBrowser/mac/SettingsController.h:
 492         * MiniBrowser/mac/SettingsController.m:
 493         (-[SettingsController _populateMenu]):
 494         (-[SettingsController validateMenuItem:]):
 495         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
 496         (-[SettingsController incrementalRenderingSuppressed]):
 497         * MiniBrowser/mac/WK1BrowserWindowController.m:
 498         (-[WK1BrowserWindowController didChangeSettings]):
 499
 500 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
 501
 502         Run CDjs as part of JSC stress testing
 503         https://bugs.webkit.org/show_bug.cgi?id=146174
 504
 505         Reviewed by Geoffrey Garen.
 506
 507         * Scripts/run-javascriptcore-tests:
 508         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
 509         * Scripts/run-jsc-stress-tests:
 510         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
 511         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
 512         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
 513
 514 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
 515
 516         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
 517         https://bugs.webkit.org/show_bug.cgi?id=146121
 518         rdar://problem/21395180
 519
 520         Reviewed by Darin Adler.
 521
 522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 523         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
 524         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
 525         (TestWebKitAPI::overrideAppleLanguages):
 526         (TestWebKitAPI::languageForSystemLanguage):
 527         (TestWebKitAPI::TEST):
 528
 529 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 530
 531         [CMake] Ignore warnings from system headers when compiling Tools
 532         https://bugs.webkit.org/show_bug.cgi?id=146185
 533
 534         Reviewed by Martin Robinson.
 535
 536         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
 537         from system headers that we don't control.
 538
 539         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 540         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
 541         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
 542         * ImageDiff/PlatformGTK.cmake:
 543         * MiniBrowser/efl/CMakeLists.txt:
 544         * MiniBrowser/gtk/CMakeLists.txt:
 545         * TestWebKitAPI/PlatformEfl.cmake:
 546         * TestWebKitAPI/PlatformGTK.cmake:
 547         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
 548         * WebKitTestRunner/CMakeLists.txt:
 549         * WebKitTestRunner/PlatformEfl.cmake:
 550         * WebKitTestRunner/PlatformGTK.cmake:
 551
 552 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
 553
 554         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
 555         https://bugs.webkit.org/show_bug.cgi?id=146186
 556
 557         Reviewed by Martin Robinson.
 558
 559         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
 560         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
 561
 562         * MiniBrowser/gtk/CMakeLists.txt:
 563
 564 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
 565
 566         Build fix after r146125.
 567
 568         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 569         (OSXSafariDriver):
 570         (OSXSafariDriver.prepareEnv):
 571
 572 2015-06-19  Brady Eidson  <beidson@apple.com>
 573
 574         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
 575         https://bugs.webkit.org/show_bug.cgi?id=146152
 576
 577         Reviewed by Dan Bernstein.
 578
 579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 580         * WebKitTestRunner/WebNotificationProvider.cpp:
 581
 582 2015-06-19  Mark Lam  <mark.lam@apple.com>
 583
 584         CheckedArithmetic's operator bool() and operator==() is broken.
 585         https://bugs.webkit.org/show_bug.cgi?id=146129
 586
 587         Reviewed by Geoffrey Garen and Oliver Hunt.
 588
 589         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
 590         and overflow scenarios in usage of the Checked arithmetic class.
 591
 592         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 593         (TestWebKitAPI::OverflowCrashLogger::overflowed):
 594         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
 595         (TestWebKitAPI::OverflowCrashLogger::crash):
 596         (TestWebKitAPI::OverflowCrashLogger::reset):
 597         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
 598         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
 599         (TestWebKitAPI::OverflowCrashLogger::didCrash):
 600         - crash logger for verifying that a crash occurs when expected.
 601
 602         (TestWebKitAPI::resetOverflow):
 603         - convenience function for resetting a test value to an initial overflowed state
 604           before a crash.  We will use this value in the overflow testing.
 605
 606         (TestWebKitAPI::CheckedArithmeticTester::run):
 607         - Added new tests for all the comparison operators.
 608
 609 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
 610
 611         Fix the Windows build after r185721
 612         https://bugs.webkit.org/show_bug.cgi?id=146146
 613
 614         Reviewed by Csaba Osztrogonác.
 615
 616         Speculative buildfix.
 617
 618         * DumpRenderTree/win/UIDelegate.h:
 619         (UIDelegate::unused4): Added.
 620         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
 621
 622 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
 623
 624         Unreviewed. Add myself as a committer.
 625
 626         * Scripts/webkitpy/common/config/contributors.json:
 627
 628 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
 629
 630         Remove unnecessary svn:executable flags
 631         https://bugs.webkit.org/show_bug.cgi?id=146107
 632
 633         Reviewed by Alexey Proskuryakov.
 634
 635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
 636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
 637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
 638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
 639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
 640         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
 641         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
 642         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
 643         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
 644         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
 645         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
 646         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
 647         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
 648         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
 649
 650 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
 651
 652         Disable tests on the WinCairo buildbot
 653         https://bugs.webkit.org/show_bug.cgi?id=146106
 654
 655         Reviewed by Alexey Proskuryakov.
 656
 657         * BuildSlaveSupport/build.webkit.org-config/config.json:
 658         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 659
 660 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
 661
 662         [EFL] Fix the minibrowser after r185725
 663         https://bugs.webkit.org/show_bug.cgi?id=146135
 664
 665         Reviewed by Gyuyoung Kim.
 666
 667         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
 668         for the elm_config_accel_preference_set() to set the config of acceleration preference.
 669
 670         * MiniBrowser/efl/main.c:
 671         (elm_main): Deleted the HAVE_ECORE_X guard.
 672
 673 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
 674
 675         Extend capability of run-benchmark script to support mobile device
 676         https://bugs.webkit.org/show_bug.cgi?id=146125
 677
 678         Reviewed by Ryosuke Niwa.
 679
 680         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
 681         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
 682
 683         * Scripts/run-benchmark:
 684         (main): Deleted.
 685         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 686         (BenchmarkRunner.__init__):
 687         (BenchmarkRunner.execute):
 688         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 689         (BrowserDriver.prepareEnv):
 690         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 691         (OSXBrowserDriver.prepareEnv):
 692         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 693         (OSXSafariDriver.prepareEnv):
 694         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 695         (HTTPServerDriver.getReturnCode):
 696         (HTTPServerDriver):
 697         (HTTPServerDriver.setDeviceID):
 698         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
 699         (parse_args):
 700         (start):
 701         (main):
 702         * Scripts/webkitpy/benchmark_runner/utils.py:
 703         (getPathFromProjectRoot):
 704
 705 2015-06-18  Jon Lee  <jonlee@apple.com>
 706
 707         Unreviewed. Add Matt Daiter as a contributor.
 708
 709         * Scripts/webkitpy/common/config/contributors.json:
 710
 711 2015-06-18  Mark Lam  <mark.lam@apple.com>
 712
 713         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
 714         https://bugs.webkit.org/show_bug.cgi?id=146103
 715
 716         Not reviewed.
 717
 718         Follow up to fix some typos not caught before original patch was landed.
 719
 720         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 721         (TestWebKitAPI::CheckedArithmeticTester::run):
 722         (TestWebKitAPI::AllowMixedSignednessTest::run):
 723         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
 724
 725 2015-06-18  Daniel Bates  <dabates@apple.com>
 726
 727         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
 728         https://bugs.webkit.org/show_bug.cgi?id=146082
 729
 730         Reviewed by Darin Adler.
 731
 732         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
 733         working directory after being invoked in a different Git checkout. In particular,
 734         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
 735         a pure Git checkout g will fail to update g.
 736
 737         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
 738         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
 739         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
 740         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
 741         different than the current working directory). Instead runGitUpdate() should check
 742         whether the current working directory is a Git SVN checkout on each invocation.
 743
 744         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
 745         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
 746         SVN directory from isGitSVN().
 747         (isGitSVN): Implemented in terms of isGitSVNDirectory().
 748         * Scripts/webkitdirs.pm:
 749         (runGitUpdate): Modified to use isGitSVNDirectory().
 750
 751 2015-06-18  Mark Lam  <mark.lam@apple.com>
 752
 753         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
 754         https://bugs.webkit.org/show_bug.cgi?id=146103
 755
 756         Reviewed by Anders Carlsson.
 757
 758         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
 759         part of a large macro.  This makes them harder to:
 760
 761         1. write: no editor help with indentations, have to add trailing '\'s,
 762            inconvenient to add line breaks and comments.
 763
 764         2. read: no chroma coding / syntax highlighting.
 765
 766         3. debug: compile time errors are reported as being on the single line where
 767            the macro is used.
 768
 769         Refactoring the tests to use C++ templates solves all these issues.
 770
 771         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 772         (TestWebKitAPI::CheckedArithmeticTester::run):
 773         (TestWebKitAPI::AllowMixedSignednessTest::run):
 774         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
 775         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
 776         (TestWebKitAPI::CoerceLiteralNop::coerce):
 777
 778 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 779
 780         [EFL][WK2] Use Web Browser cache model in MiniBrowser
 781         https://bugs.webkit.org/show_bug.cgi?id=112273
 782
 783         Reviewed by Laszlo Gombos.
 784
 785         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
 786         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
 787         This way we have a decent cache capacity and the page cache actually works.
 788
 789         * MiniBrowser/efl/main.c:
 790         (elm_main):
 791
 792 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 793
 794         Remove redundant Chromium bug keyword
 795         https://bugs.webkit.org/show_bug.cgi?id=146097
 796
 797         Reviewed by Csaba Osztrogonác.
 798
 799         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 800         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
 801         (TestExpectationLine._format_line): Deleted.
 802
 803 2015-06-17  Daniel Bates  <dabates@apple.com>
 804
 805         Client may receive began editing callback for already focused text field
 806         https://bugs.webkit.org/show_bug.cgi?id=146074
 807         <rdar://problem/21293562>
 808
 809         Reviewed by Darin Adler.
 810
 811         Add a unit test to ensure that a client receives exactly one began editing
 812         callback when a text field is newly focused. In particular, dispatching
 813         a DOM focus event at an already focused text field does not dispatch a
 814         began editing callback to the client.
 815
 816         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
 817         (TestWebKitAPI::TEST_F):
 818
 819 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
 820
 821         [Win]Implement layoutTestController.dispatchPendingLoadRequests.
 822         https://bugs.webkit.org/show_bug.cgi?id=26481
 823
 824         Reviewed by Darin Adler.
 825
 826         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
 827
 828         * DumpRenderTree/win/TestRunnerWin.cpp:
 829         (TestRunner::dispatchPendingLoadRequests):
 830         (TestRunner::overridePreference):
 831
 832 2015-06-17  Alex Christensen  <achristensen@webkit.org>
 833
 834         [Content Extensions] Fail to parse invalid arrays
 835         https://bugs.webkit.org/show_bug.cgi?id=146079
 836         rdar://problem/21422649
 837
 838         Reviewed by Benjamin Poulain.
 839
 840         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 841         (TestWebKitAPI::TEST_F):
 842         Correct and add parsing tests with invalid arrays.
 843
 844 2015-06-17  Matt Rajca  <mrajca@apple.com>
 845
 846         Unreviewed. Added myself as a committer.
 847
 848         * Scripts/webkitpy/common/config/contributors.json:
 849
 850 2015-06-17  Daniel Bates  <dabates@apple.com>
 851
 852         Export VCSUtils::gitTreeDirectory()
 853         <rdar://problem/21248901>
 854
 855         Rubber-stamped by Alexey Proskuryakov.
 856
 857         * Scripts/VCSUtils.pm:
 858
 859 2015-06-17  Tim Horton  <timothy_horton@apple.com>
 860
 861         Safari tabs still have shrunken content after coming out of fullscreen
 862         https://bugs.webkit.org/show_bug.cgi?id=146037
 863         <rdar://problem/21105960>
 864
 865         Reviewed by Simon Fraser and Darin Adler.
 866
 867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 868         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
 869         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
 870         (TEST):
 871         Add a test that ensures that disabling scale-to-fit mode correctly updates
 872         the page's layout.
 873
 874 2015-06-17  Dan Bernstein  <mitz@apple.com>
 875
 876         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
 877         https://bugs.webkit.org/show_bug.cgi?id=145957
 878
 879         Reviewed by Darin Adler.
 880
 881         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
 882         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
 883
 884 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
 885
 886         AX:  iOS accessibility tests are not running because we need WKTR support
 887         https://bugs.webkit.org/show_bug.cgi?id=145991
 888
 889         Reviewed by Daniel Bates.
 890
 891         Add support for WKTR iOS accessibility.
 892         Utilize the notification handling mechanisms that Mac already uses.
 893         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
 894
 895         * DumpRenderTree/AccessibilityUIElement.cpp:
 896         (stringForSelectionCallback):
 897         (getIdentifierCallback):
 898         (getTraitsCallback):
 899         (getElementTextPositionCallback):
 900         (getElementTextLengthCallback):
 901         (AccessibilityUIElement::getJSClass):
 902         (getIPhoneLabelCallback): Deleted.
 903         (getIPhoneHintCallback): Deleted.
 904         (getIPhoneValueCallback): Deleted.
 905         (getIPhoneIdentifierCallback): Deleted.
 906         (getIPhoneTraitsCallback): Deleted.
 907         (getIPhoneIsElementCallback): Deleted.
 908         (getIPhoneElementTextPositionCallback): Deleted.
 909         (getIPhoneElementTextLengthCallback): Deleted.
 910         * DumpRenderTree/AccessibilityUIElement.h:
 911         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 912         (AccessibilityUIElement::identifier):
 913         (AccessibilityUIElement::traits):
 914         (AccessibilityUIElement::elementTextPosition):
 915         (AccessibilityUIElement::elementTextLength):
 916         (AccessibilityUIElement::description):
 917         (AccessibilityUIElement::orientation):
 918         (AccessibilityUIElement::stringValue):
 919         (AccessibilityUIElement::language):
 920         (AccessibilityUIElement::helpText):
 921         (AccessibilityUIElement::intValue):
 922         (AccessibilityUIElement::isSelected):
 923         (AccessibilityUIElement::isExpanded):
 924         (AccessibilityUIElement::documentURI):
 925         (AccessibilityUIElement::addNotificationListener):
 926         (AccessibilityUIElement::removeNotificationListener):
 927         (AccessibilityUIElement::isFocusable):
 928         (AccessibilityUIElement::isIgnored):
 929         (AccessibilityUIElement::hasPopup):
 930         (AccessibilityUIElement::iphoneLabel): Deleted.
 931         (AccessibilityUIElement::iphoneHint): Deleted.
 932         (AccessibilityUIElement::iphoneValue): Deleted.
 933         (AccessibilityUIElement::iphoneIdentifier): Deleted.
 934         (AccessibilityUIElement::iphoneTraits): Deleted.
 935         (AccessibilityUIElement::iphoneIsElement): Deleted.
 936         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
 937         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
 938         (_accessibilityNotificationCallback): Deleted.
 939         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 940         (WTR::AccessibilityUIElement::isValid):
 941         (WTR::AccessibilityUIElement::identifier):
 942         (WTR::AccessibilityUIElement::traits):
 943         (WTR::AccessibilityUIElement::elementTextPosition):
 944         (WTR::AccessibilityUIElement::elementTextLength):
 945         (WTR::AccessibilityUIElement::stringForSelection):
 946         (WTR::AccessibilityUIElement::elementsForRange):
 947         (WTR::AccessibilityUIElement::increaseTextSelection):
 948         (WTR::AccessibilityUIElement::decreaseTextSelection):
 949         (WTR::AccessibilityUIElement::linkedElement):
 950         (WTR::AccessibilityUIElement::headerElementAtIndex):
 951         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
 952         (WTR::AccessibilityUIElement::characterAtOffset):
 953         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 954         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 955         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
 956         (WTR::findAccessibleObjectById):
 957         (WTR::AccessibilityController::accessibleElementById):
 958         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 959         (+[NSString stringWithJSStringRef:]):
 960         (-[NSString createJSStringRef]):
 961         (WTR::convertNSArrayToVector):
 962         (WTR::concatenateAttributeAndValue):
 963         (WTR::AccessibilityUIElement::AccessibilityUIElement):
 964         (WTR::AccessibilityUIElement::isEqual):
 965         (WTR::AccessibilityUIElement::headerElementAtIndex):
 966         (WTR::AccessibilityUIElement::linkedElement):
 967         (WTR::AccessibilityUIElement::getLinkedUIElements):
 968         (WTR::AccessibilityUIElement::elementAtPoint):
 969         (WTR::convertElementsToObjectArray):
 970         (WTR::AccessibilityUIElement::elementsForRange):
 971         (WTR::AccessibilityUIElement::indexOfChild):
 972         (WTR::AccessibilityUIElement::stringAttributeValue):
 973         (WTR::AccessibilityUIElement::description):
 974         (WTR::AccessibilityUIElement::orientation):
 975         (WTR::AccessibilityUIElement::stringValue):
 976         (WTR::AccessibilityUIElement::language):
 977         (WTR::AccessibilityUIElement::helpText):
 978         (WTR::AccessibilityUIElement::x):
 979         (WTR::AccessibilityUIElement::clickPointX):
 980         (WTR::AccessibilityUIElement::clickPointY):
 981         (WTR::AccessibilityUIElement::intValue):
 982         (WTR::AccessibilityUIElement::minValue):
 983         (WTR::AccessibilityUIElement::maxValue):
 984         (WTR::AccessibilityUIElement::valueDescription):
 985         (WTR::AccessibilityUIElement::isSelected):
 986         (WTR::AccessibilityUIElement::isSelectedOptionActive):
 987         (WTR::AccessibilityUIElement::stringForRange):
 988         (WTR::AccessibilityUIElement::attributedStringForRange):
 989         (WTR::AccessibilityUIElement::attributesOfHeader):
 990         (WTR::AccessibilityUIElement::traits):
 991         (WTR::AccessibilityUIElement::identifier):
 992         (WTR::AccessibilityUIElement::rowCount):
 993         (WTR::AccessibilityUIElement::rowIndexRange):
 994         (WTR::AccessibilityUIElement::columnIndexRange):
 995         (WTR::AccessibilityUIElement::cellForColumnAndRow):
 996         (WTR::AccessibilityUIElement::horizontalScrollbar):
 997         (WTR::AccessibilityUIElement::documentURI):
 998         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
 999         (WTR::AccessibilityUIElement::increaseTextSelection):
1000         (WTR::AccessibilityUIElement::decreaseTextSelection):
1001         (WTR::AccessibilityUIElement::stringForSelection):
1002         (WTR::AccessibilityUIElement::elementTextPosition):
1003         (WTR::AccessibilityUIElement::elementTextLength):
1004         (WTR::AccessibilityUIElement::url):
1005         (WTR::AccessibilityUIElement::addNotificationListener):
1006         (WTR::AccessibilityUIElement::removeNotificationListener):
1007         (WTR::AccessibilityUIElement::isFocusable):
1008         (WTR::AccessibilityUIElement::isIgnored):
1009         (WTR::AccessibilityUIElement::hasPopup):
1010         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1011         (WTR::_CGPathEnumerationIteration):
1012         (WTR::AccessibilityUIElement::pathDescription):
1013         (WTR::AccessibilityUIElement::supportedActions):
1014
1015 2015-06-16  Mark Lam  <mark.lam@apple.com>
1016
1017         Use NakedPtr<Exception>& to return exception results.
1018         https://bugs.webkit.org/show_bug.cgi?id=145870
1019
1020         Reviewed by Anders Carlsson and Filip Pizlo.
1021
1022         * TestWebKitAPI/CMakeLists.txt:
1023         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1024         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1026         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
1027         (TestWebKitAPI::TEST):
1028         (TestWebKitAPI::nakedPtrFoo):
1029
1030 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
1031
1032         Unreviewed. Adding myself as a committer.
1033
1034         * Scripts/webkitpy/common/config/contributors.json:
1035
1036 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
1037
1038         Add test expectations for El Capitan
1039         https://bugs.webkit.org/show_bug.cgi?id=146005
1040
1041         Rubber-stamped by Dan Bernstein.
1042
1043         Add appropriate tools code.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
1046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
1047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1049         Added dashboard support.
1050
1051         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1052         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1053         Trigger the right build queues on check-in.
1054
1055         * Scripts/webkitpy/common/system/platforminfo.py:
1056         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1057         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1058         * Scripts/webkitpy/port/mac.py:
1059         * Scripts/webkitpy/port/mac_unittest.py:
1060         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1061         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1062         Added cases for El Capitan, and updated tests for new baseline search paths.
1063
1064 2015-06-15  Alex Christensen  <achristensen@webkit.org>
1065
1066         [Content Extensions] Make max NFA size and max rule count user defaults.
1067         https://bugs.webkit.org/show_bug.cgi?id=145663
1068
1069         Reviewed by Benjamin Poulain.
1070
1071         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1072         (TestWebKitAPI::TEST_F):
1073
1074 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1075
1076         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
1077         https://bugs.webkit.org/show_bug.cgi?id=145900
1078
1079         Reviewed by Sam Weinig.
1080
1081         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1082         (TEST): Added tests.
1083
1084 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1085
1086         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
1087         https://bugs.webkit.org/show_bug.cgi?id=145969
1088
1089         Reviewed by Sergio Villar Senin.
1090
1091         Add a test case to the custom URI schemes unit test.
1092
1093         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1094         (testWebContextURIScheme):
1095
1096 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1097
1098         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
1099         https://bugs.webkit.org/show_bug.cgi?id=145922
1100
1101         Reviewed by Carlos Garcia Campos.
1102
1103         * gtk/jhbuild.modules:
1104         * gtk/patches/glib-warning-fix.patch: Added.
1105
1106 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1107
1108         Update springLoadingHighlight type
1109         https://bugs.webkit.org/show_bug.cgi?id=145939
1110         rdar://problem/20880213
1111
1112         Reviewed by Darin Adler.
1113
1114         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1115         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1116         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1117         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1118
1119 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
1120
1121         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
1122         https://bugs.webkit.org/show_bug.cgi?id=145945
1123
1124         Reviewed by Stephanie Lewis.
1125
1126         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1127         (OSXBrowserDriver.prepareEnv):
1128         (OSXBrowserDriver.moveCursor): Deleted.
1129         (OSXBrowserDriver): Deleted.
1130         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1131         (OSXSafariDriver.prepareEnv):
1132
1133 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
1134
1135         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
1136         https://bugs.webkit.org/show_bug.cgi?id=145938
1137
1138         Reviewed by Alexey Proskuryakov.
1139
1140         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1141         LWP::UserAgent to get access to more robust HTTPS support.
1142
1143 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1144
1145         [GTK] Fix return type warning in WebViewTest.cpp
1146         https://bugs.webkit.org/show_bug.cgi?id=145914
1147
1148         Reviewed by Darin Adler.
1149
1150         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1151         (WebViewTest::isEditable):
1152
1153 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1154
1155         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1156         https://bugs.webkit.org/show_bug.cgi?id=145799
1157
1158         Reviewed by Carlos Garcia Campos.
1159
1160         Update header inclusions for headers that have been moved
1161         to Source/WTF/wtf/glib/.
1162
1163         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1164         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1165
1166         * TestWebKitAPI/PlatformGTK.cmake:
1167         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1168         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1169         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1170         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1171         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1172         (TestWebKitAPI::GMainLoopSourceTest::finish):
1173         (TestWebKitAPI::GMainLoopSourceTest::source):
1174         (TestWebKitAPI::basicRescheduling):
1175         (TestWebKitAPI::TEST):
1176         (TestWebKitAPI::reentrantRescheduling):
1177         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1178         (TestWebKitAPI::basicDestroyCallbacks):
1179         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1180         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1181         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1182         (log):
1183         (takeLogStr):
1184         (TestWebKitAPI::TEST):
1185         (TestWebKitAPI::returnOutChar):
1186         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1187         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1188         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1189         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1190         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1191         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1192         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1193         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1194         (TestWebKitAPI::basicRescheduling): Deleted.
1195         (TestWebKitAPI::TEST): Deleted.
1196         (TestWebKitAPI::reentrantRescheduling): Deleted.
1197         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1198         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1199         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1200         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1201         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1202         (log): Deleted.
1203         (takeLogStr): Deleted.
1204         (TestWebKitAPI::TEST): Deleted.
1205         (TestWebKitAPI::returnOutChar): Deleted.
1206         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1207         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1208         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1209         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1210         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1211         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1212         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1213         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1214         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1215         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1216         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1217         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1218         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1219         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1220         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1221         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1222         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1223         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1224         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1225         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1226         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1227         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1228         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1229         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1230         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1231         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1232         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1233         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1234         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1235         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1236         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1237         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1238         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1239         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1240         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1242         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1243         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1244         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1245         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1246         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1247         * WebKitTestRunner/PlatformGTK.cmake:
1248         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1249         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1250
1251 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1252
1253         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1254         https://bugs.webkit.org/show_bug.cgi?id=145913
1255
1256         Reviewed by Gyuyoung Kim.
1257
1258         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1259         (TestWebKitAPI::setupGeolocationProvider):
1260         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1261         (TestWebKitAPI::setPageLoaderClient):
1262         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1263         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1264         * WebKitTestRunner/GeolocationProviderMock.cpp:
1265         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1266         * WebKitTestRunner/WebNotificationProvider.cpp:
1267         (WTR::WebNotificationProvider::provider):
1268
1269 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1270
1271         Fix the libusrsctp build with clang
1272         https://bugs.webkit.org/show_bug.cgi?id=145128
1273
1274         Reviewed by Gyuyoung Kim.
1275
1276         * efl/jhbuild.modules:
1277         * gtk/jhbuild.modules:
1278
1279 2015-06-11  Mark Lam  <mark.lam@apple.com>
1280
1281         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1282         https://bugs.webkit.org/show_bug.cgi?id=145872
1283
1284         Reviewed by Michael Saboff.
1285
1286         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1287         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1288         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1289           exception will be returned as a JSValue instead of an Exception object.  We
1290           will use this JSValue to test WebCore::reportException() to confirm that it is
1291           able to handle an exception value which is not an Exception object.
1292
1293 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1294
1295         Move cursor to corner and fix safari window size before running benchmark
1296         https://bugs.webkit.org/show_bug.cgi?id=145858
1297
1298         Reviewed by Ryosuke Niwa
1299
1300         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1301         (OSXBrowserDriver.prepareEnv):
1302         (OSXBrowserDriver):
1303         (OSXBrowserDriver.moveCursor):
1304         (OSXBrowserDriver.getScreenSize):
1305         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1306         (OSXChromeDriver.launchUrl):
1307         (OSXChromeCanaryDriver.launchUrl):
1308         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1309         (OSXFirefoxDriver.launchUrl):
1310         (OSXFirefoxNightlyDriver.launchUrl):
1311         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1312         (OSXSafariDriver.prepareEnv):
1313         (OSXSafariDriver):
1314         (OSXSafariDriver.maximizeWindow):
1315
1316 2015-06-11  Daniel Bates  <dabates@apple.com>
1317
1318         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1319         https://bugs.webkit.org/show_bug.cgi?id=145319
1320
1321         Reviewed by David Kilzer.
1322
1323         Add SPI wrapper header for CoreSimulator and update the source files to reference
1324         it instead of directly referencing the CoreSimulator header.
1325
1326         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1327         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1328         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1329         * LayoutTestRelay/LayoutTestRelay/main.m:
1330
1331 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1332
1333         [EFL] dimmed area for popup does not cover the fullscreen mode.
1334         https://bugs.webkit.org/show_bug.cgi?id=145133
1335
1336         Reviewed by Gyuyoung Kim.
1337
1338         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1339         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1340
1341         * MiniBrowser/efl/main.c:
1342         (on_fullscreen_accept):
1343         (on_fullscreen_deny):
1344         (on_fullscreen_enter):
1345
1346 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1347
1348         Unreviewed, rolling out r185442.
1349         https://bugs.webkit.org/show_bug.cgi?id=145871
1350
1351         seems to have broken WTF.StringOperators test (Requested by
1352         alexchristensen on #webkit).
1353
1354         Reverted changeset:
1355
1356         "[Content Extensions] Limit number of rules."
1357         https://bugs.webkit.org/show_bug.cgi?id=145663
1358         http://trac.webkit.org/changeset/185442
1359
1360 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1361
1362         [Content Extensions] Make max NFA size and max rule count user defaults.
1363         https://bugs.webkit.org/show_bug.cgi?id=145663
1364         rdar://problem/21242407
1365
1366         Reviewed by Benjamin Poulain.
1367
1368         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1369         (TestWebKitAPI::TEST_F):
1370
1371 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1372
1373         [EFL] Execute Javascript method in mini browser address bar.
1374         https://bugs.webkit.org/show_bug.cgi?id=145725
1375
1376         Reviewed by Gyuyoung Kim.
1377
1378         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1379
1380         * MiniBrowser/efl/main.c:
1381         (url_from_user_input):
1382         (url_load_from_user_input):
1383         (on_url_bar_activated):
1384         (elm_main):
1385
1386 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1387
1388         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1389         https://bugs.webkit.org/show_bug.cgi?id=66773
1390
1391         Reviewed by Darin Adler.
1392
1393         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1394         * DumpRenderTree/win/FrameLoadDelegate.h:
1395
1396 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1397
1398         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1399         https://bugs.webkit.org/show_bug.cgi?id=145764
1400
1401         Reviewed by Darin Adler.
1402
1403         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1404         JetStream and SunSpider.
1405
1406         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1407         (GenericBenchmarkBuilder):
1408         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1409         the whole JSON as the input.
1410         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1411         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1412         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1413         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1414         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1415         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1416         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1417
1418 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1419
1420         Remove ewstool scripts used by chromium port
1421         https://bugs.webkit.org/show_bug.cgi?id=145789
1422
1423         Reviewed by Csaba Osztrogonác.
1424
1425         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1426         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1427         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1428         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1429         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1430
1431 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1432
1433         Unreviewed, updated my list of email addresses.
1434
1435         * Scripts/webkitpy/common/config/contributors.json:
1436
1437 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1438
1439         [cmake] Fix the style issues in cmake project files
1440         https://bugs.webkit.org/show_bug.cgi?id=145755
1441
1442         Reviewed by Darin Adler.
1443
1444         * TestWebKitAPI/CMakeLists.txt:
1445         * TestWebKitAPI/PlatformEfl.cmake:
1446
1447 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1448
1449         Fix a typo in r185345.
1450
1451         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1452         (OSXSafariDriver.closeBrowsers):
1453
1454 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1455
1456         Yet another unreviewed build fix :(
1457
1458         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1459         (OSXSafariDriver):
1460         (OSXSafariDriver.launchUrl):
1461         (OSXSafariDriver.closeBrowsers):
1462
1463 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1464
1465         Unreviewed build fix. Initialize result in the case things blow up below.
1466
1467         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1468         (BenchmarkRunner.execute):
1469
1470 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1471
1472         Partially revert and fix after r185243.
1473
1474         * Scripts/benchmark_runner/benchmark_runner.py:
1475         * Scripts/run-benchmark:
1476
1477 2015-06-08  Daniel Bates  <dabates@apple.com>
1478
1479         Many LayoutTests/http tests time out in DumpRenderTree
1480         https://bugs.webkit.org/show_bug.cgi?id=145770
1481         <rdar://problem/19593910>
1482
1483         Reviewed by Alexey Proskuryakov.
1484
1485         * DumpRenderTree/ios/Info.plist: Add ATS key.
1486         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1487         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1488         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1489         that make use of testRunner.pathToLocalResource().
1490
1491 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1492
1493         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1494         https://bugs.webkit.org/show_bug.cgi?id=145759
1495
1496         Reviewed by Carlos Garcia Campos.
1497
1498         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1499         (testWebViewSave):
1500
1501 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1502
1503         [GTK] Add editor mode to MiniBrowser
1504         https://bugs.webkit.org/show_bug.cgi?id=145595
1505
1506         Reviewed by Sergio Villar Senin.
1507
1508         It loads an empty editable web view with an edit toolbar. It makes
1509         easier to test the editor, editing commands and input methods.
1510
1511         * MiniBrowser/gtk/BrowserWindow.c:
1512         (editingCommandCallback):
1513         (browserWindowSetupEditorToolbar):
1514         (browserWindowConstructed):
1515         * MiniBrowser/gtk/main.c:
1516         (createBrowserWindow):
1517
1518 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1519
1520         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1521
1522         Reviewed by Dan Bernstein.
1523
1524         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1525         (TestWebKitAPI::TEST):
1526
1527 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1528
1529         [EFL] API test has been broken since r184357
1530         https://bugs.webkit.org/show_bug.cgi?id=145635
1531
1532         Reviewed by Darin Adler.
1533
1534         r184357 suppress cmake build warning using TARGET_FILE property. However
1535         many EFL API test cases have been broken after applying it.
1536
1537         * TestWebKitAPI/CMakeLists.txt:
1538
1539 2015-06-05  Anders Carlsson  <andersca@apple.com>
1540
1541         Make the network cache directory part of WKContextConfigurationRef
1542         https://bugs.webkit.org/show_bug.cgi?id=145711
1543
1544         Reviewed by Antti Koivisto.
1545
1546         * WebKitTestRunner/TestController.cpp:
1547         (WTR::TestController::initialize):
1548
1549 2015-06-05  Anders Carlsson  <andersca@apple.com>
1550
1551         Make the application cache directory part of WKContextConfigurationRef
1552         https://bugs.webkit.org/show_bug.cgi?id=145704
1553
1554         Reviewed by Geoffrey Garen.
1555
1556         * WebKitTestRunner/TestController.cpp:
1557         (WTR::TestController::initialize):
1558
1559 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1560
1561         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1562         https://bugs.webkit.org/show_bug.cgi?id=145680
1563
1564         Reviewed by Brent Fulgham.
1565
1566         * Scripts/webkitpy/style/checkers/cpp.py:
1567         (check_for_null):
1568         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1569         (WebKitStyleTest.test_null_false_zero):
1570
1571 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1572
1573         Make the web server more robust to timing issues..
1574
1575         Reviewed by Ryosuke Niwa.
1576
1577         Cleaned up exception handling.
1578         Test server is actually serving pages before returning.
1579         Clean up some style issues.
1580
1581         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1582         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1583         (SimpleHTTPServerDriver.__init__):
1584         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1585         (SimpleHTTPServerDriver.baseUrl):
1586         (SimpleHTTPServerDriver.fetchResult):
1587         (SimpleHTTPServerDriver.killServer):
1588         (SimpleHTTPServerDriver.getReturnCode):
1589
1590 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1591
1592
1593         Add errors to run-benchmark exception handling.
1594
1595         Reviewed by Ryosuke Niwa.
1596
1597         * Scripts/run-benchmark:
1598         (main):
1599         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1600         (GenericBenchmarkBuilder.prepare):
1601         (GenericBenchmarkBuilder._runCreateScript):
1602         (GenericBenchmarkBuilder._applyPatch):
1603         (GenericBenchmarkBuilder.clean):
1604         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1605         (BenchmarkRunner.__init__):
1606         (BenchmarkRunner.execute):
1607         (BenchmarkRunner):
1608         (BenchmarkRunner.cleanup):
1609         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1610         (GenericFactory.iterateGetItem):
1611         (GenericFactory.create):
1612         * Scripts/webkitpy/benchmark_runner/utils.py:
1613         (loadModule):
1614         (loadJSONFromFile):
1615         (forceRemove):
1616
1617 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1618
1619         Streamline run-benchmark browser
1620
1621         Reviewed by Ryosuke Niwa.
1622
1623         Add Caffeinate so computer won't sleep while running.
1624         Remove calls to collect output since we were just dumping to stdout anyway.
1625         Add xpc dyld_path.
1626         Default to system safari.
1627
1628         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1629         (OSXBrowserDriver.launchProcess):
1630         (OSXBrowserDriver.terminateProcesses):
1631         (OSXBrowserDriver):
1632         (OSXBrowserDriver.launchCaffeinateForProcess):
1633         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1634         (OSXSafariDriver.launchUrl):
1635         (OSXSafariDriver.closeBrowsers):
1636
1637 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1638
1639         Combine tiny DFAs into slightly larger ones
1640         https://bugs.webkit.org/show_bug.cgi?id=145572
1641
1642         Reviewed by Alex Christensen.
1643
1644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1645         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1646         (TestWebKitAPI::DFACombinerTest::SetUp):
1647         (TestWebKitAPI::combine):
1648         (TestWebKitAPI::TEST_F):
1649         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1650         (TestWebKitAPI::countLiveNodes):
1651         (TestWebKitAPI::createNFAs):
1652         (TestWebKitAPI::buildDFAFromPatterns):
1653         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1654         (TestWebKitAPI::countLiveNodes): Deleted.
1655         (TestWebKitAPI::createNFAs): Deleted.
1656         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1657
1658 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1659
1660         WebKitTestRunner leaks strings in generateWhitelist()
1661         https://bugs.webkit.org/show_bug.cgi?id=145665
1662
1663         Reviewed by Myles C. Maxfield.
1664
1665         * WebKitTestRunner/mac/TestControllerMac.mm:
1666         (WTR::generateWhitelist):
1667
1668 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1669
1670         Fix options in build-jsc for CMake builds
1671         https://bugs.webkit.org/show_bug.cgi?id=145636
1672
1673         Reviewed by Gyuyoung Kim.
1674
1675         CMake only accepts -DXXX=YYY style options.
1676         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1677
1678         * Scripts/build-jsc:
1679
1680 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1681
1682         Added a patch so that the colors displayed on the page could be toggled
1683         in case people need accessibility colors displayed in their browser.
1684         https://bugs.webkit.org/show_bug.cgi?id=145570
1685         <rdar://problem/20994468>
1686
1687         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1688         the page could be rendered in a specific way for accessibility needs if needed.
1689
1690         Reviewed by Alexey Proskuryakov.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1693         (updateHiddenPlatforms):
1694         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1695         (toggleAccessibilityColors): Toggle colors on and off
1696         (documentReady): Needed to make changes to the initialization
1697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1698         (a:hover):
1699         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1700         (div.cellButton.hide, div.accessibilityButton.hide):
1701         (div.cellButton.unhide, div.accessibilityButton.unhide):
1702         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1703         (.popover-tracking:hover):
1704         (.accessibilityButton):
1705         (div.cellButton): Deleted.
1706         (div.cellButton.hide): Deleted.
1707         (div.cellButton.unhide): Deleted.
1708         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1709         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1710         (.status-line.neutral .bubble):
1711         (.status-line.unauthorized .bubble):
1712         (.status-line.danger .bubble.pictogram):
1713         (.status-line.bad .bubble.pictogram):
1714         (.status-line.no-bubble .message):
1715         (.status-line.bad .bubble):
1716         (.status-line.good .bubble):
1717         (.status-line.good .message):
1718         (.status-line.bad .message):
1719         (body.accessibility-colors .status-line.good .bubble):
1720         (body.accessibility-colors .status-line.bad .bubble):
1721         (body.accessibility-colors .status-line.good .message):
1722         (body.accessibility-colors .status-line.bad .message):
1723         (.status-line.danger .message):
1724         (.status-line.unauthorized .message):
1725
1726 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1727
1728         Unreviewed build fix for Dromaeo.
1729
1730         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1731         (BenchmarkResults._aggregate_results_for_test):
1732
1733 2015-06-03  Anders Carlsson  <andersca@apple.com>
1734
1735         Fix build.
1736
1737         * DumpRenderTree/mac/TestRunnerMac.mm:
1738
1739 2015-06-03  Daniel Bates  <dabates@apple.com>
1740
1741         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1742         https://bugs.webkit.org/show_bug.cgi?id=145616
1743
1744         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1745         of the test. Further investigation is needed.
1746
1747         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1748         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1749
1750 2015-06-03  Brady Eidson  <beidson@apple.com>
1751
1752         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1753         https://bugs.webkit.org/show_bug.cgi?id=145580
1754
1755         Reviewed by Mark Lam.
1756
1757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1758         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1759
1760 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1761
1762         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1763
1764         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1765         (TestWebKitAPI::TEST): Update the syntax.
1766
1767 2015-06-02  Mark Lam  <mark.lam@apple.com>
1768
1769         build-jsc's --cloop option is broken.
1770         https://bugs.webkit.org/show_bug.cgi?id=145516
1771
1772         Reviewed by Darin Adler.
1773
1774         * Scripts/build-jsc:
1775         - Make sure to disable the JIT when --cloop is specified.
1776           Did analogous fix for --ftljit.
1777
1778 2015-06-02  Daniel Bates  <dabates@apple.com>
1779
1780         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1781
1782         Rubber-stamped by Alexey Proskuryakov.
1783
1784         * MiniBrowser/mac/Info.plist:
1785         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1786
1787 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1788
1789         Unreviewed, rolling out r185066.
1790         https://bugs.webkit.org/show_bug.cgi?id=145543
1791
1792         it breaks the FTL JIT builds with a local checkout of llvm
1793         (Requested by pizlo on #webkit).
1794
1795         Reverted changeset:
1796
1797         "build-jsc's --cloop option is broken."
1798         https://bugs.webkit.org/show_bug.cgi?id=145516
1799         http://trac.webkit.org/changeset/185066
1800
1801 2015-06-01  Daniel Bates  <dabates@apple.com>
1802
1803         Notify client that we began editing when text field is focused
1804         https://bugs.webkit.org/show_bug.cgi?id=145439
1805         <rdar://problem/21142108>
1806
1807         Reviewed by Anders Carlsson.
1808
1809         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
1810         a text field is focused and defocused.
1811
1812         * TestWebKitAPI/CMakeLists.txt:
1813         * TestWebKitAPI/PlatformEfl.cmake:
1814         * TestWebKitAPI/PlatformGTK.cmake:
1815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1816         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
1817         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
1818         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
1819         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
1820         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1821         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
1822         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
1823         (TestWebKitAPI::TEST_F):
1824         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
1825         (TestWebKitAPI::textFieldDidBeginEditing):
1826         (TestWebKitAPI::textFieldDidEndEditing):
1827         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
1828         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
1829         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
1830
1831 2015-06-01  Alex Christensen  <achristensen@webkit.org>
1832
1833         [Content Extensions] resource-type and load-type should be independent.
1834         https://bugs.webkit.org/show_bug.cgi?id=145528
1835         rdar://problem/21190765
1836
1837         Reviewed by Benjamin Poulain.
1838
1839         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1840         (TestWebKitAPI::TEST_F):
1841
1842 2015-06-01  Daniel Bates  <dabates@apple.com>
1843
1844         Add ATS keys to WebKitTestRunnerApp
1845         https://bugs.webkit.org/show_bug.cgi?id=145519
1846
1847         Reviewed by Alexey Proskuryakov.
1848
1849         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
1850
1851         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1852
1853 2015-06-01  Brady Eidson  <beidson@apple.com>
1854
1855         Add WKTR support for "should open external URLs".
1856         https://bugs.webkit.org/show_bug.cgi?id=145505
1857
1858         Reviewed by Darin Adler.
1859
1860         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
1861           "should open external URLs" bit set.
1862
1863         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
1864           the policy delegate, including whether or not the bit was set.
1865
1866         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1868         (WTR::TestRunner::queueLoad):
1869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1870         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
1871         (WTR::TestRunner::shouldDumpPolicyCallbacks):
1872
1873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1874         (WTR::InjectedBundle::queueLoad):
1875         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1876
1877         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1878         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1879
1880         * WebKitTestRunner/TestInvocation.cpp:
1881         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1882
1883         * WebKitTestRunner/WorkQueueManager.cpp:
1884         (WTR::WorkQueueManager::queueLoad):
1885         * WebKitTestRunner/WorkQueueManager.h:
1886
1887 2015-06-01  Mark Lam  <mark.lam@apple.com>
1888
1889         build-jsc's --cloop option is broken.
1890         https://bugs.webkit.org/show_bug.cgi?id=145516
1891
1892         Reviewed by Darin Adler.
1893
1894         * Scripts/build-jsc:
1895         - Make sure to disable the JIT when --cloop is specified.
1896           Did analogous fix for --ftljit.
1897
1898 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1899
1900         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
1901         https://bugs.webkit.org/show_bug.cgi?id=144959
1902
1903         Reviewed by Darin Adler.
1904
1905         * Scripts/webkitpy/style/checkers/cmake.py:
1906         (CMakeChecker.check): Use enumerate instead of xrange.
1907         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
1908         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1909         (CMakeCheckerTest.test_check): Update the expected results.
1910
1911 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1912
1913         Fix the webkitpy scm unittests after r174051
1914         https://bugs.webkit.org/show_bug.cgi?id=145511
1915
1916         Reviewed by Darin Adler.
1917
1918         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1919         (GitTestWithMock.make_scm):
1920
1921 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1922
1923         EWS provides misleading information for not applyable patches
1924         https://bugs.webkit.org/show_bug.cgi?id=145307
1925
1926         Reviewed by Alexey Proskuryakov.
1927
1928         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
1929
1930 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
1931
1932         Further tweak results of WebKit1.StringTruncator after r184965.
1933
1934         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1935
1936 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1937
1938         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
1939         https://bugs.webkit.org/show_bug.cgi?id=145264
1940
1941         Reviewed by Carlos Garcia Campos.
1942
1943         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
1944
1945 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1946
1947         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
1948
1949         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1950         (BenchmarkResults._lint_subtest_results):
1951         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1952         (test_aggregate_nested_results):
1953         (test_lint_results):
1954         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
1955
1956 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
1957
1958         run-benchmark should print out the results
1959         https://bugs.webkit.org/show_bug.cgi?id=145398
1960
1961         Reviewed by Antti Koivisto.
1962
1963         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
1964         of the output to catch early errors.
1965
1966         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
1967         (BenchmarkResults): Added.
1968         (BenchmarkResults.__init__): Added.
1969         (BenchmarkResults.format): Added.
1970         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
1971         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
1972         Uses the sample standard deviation to compute the significant figures for the value.
1973         (BenchmarkResults._unit_from_metric): Added.
1974         (BenchmarkResults._aggregate_results): Added.
1975         (BenchmarkResults._aggregate_results_for_test): Added.
1976         (BenchmarkResults._flatten_list): Added.
1977         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
1978         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
1979         (BenchmarkResults._aggregate_values): Added.
1980         (BenchmarkResults._lint_results): Added.
1981         (BenchmarkResults._lint_subtest_results): Added.
1982         (BenchmarkResults._lint_aggregator_list): Added.
1983         (BenchmarkResults._lint_configuration): Added.
1984         (BenchmarkResults._lint_values): Added.
1985         (BenchmarkResults._is_numeric): Added.
1986         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
1987         (BenchmarkResultsTest):
1988         (BenchmarkResultsTest.test_init):
1989         (BenchmarkResultsTest.test_format):
1990         (test_format_values_with_large_error):
1991         (test_format_values_with_small_error):
1992         (test_format_values_with_time):
1993         (test_format_values_with_no_error):
1994         (test_format_values_with_small_difference):
1995         (test_aggregate_results):
1996         (test_aggregate_results_with_gropus):
1997         (test_aggregate_nested_results):
1998         (test_lint_results):
1999         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2000         (BenchmarkRunner.execute): Added a call to show_results
2001         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
2002         (BenchmarkRunner.show_results): Added.
2003
2004 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2005
2006         run_benchmark should have an option to specify the number of runs
2007         https://bugs.webkit.org/show_bug.cgi?id=145091
2008
2009         Reviewed by Antti Koivisto.
2010
2011         Added --count option.
2012
2013         * Scripts/run-benchmark:
2014         (main):
2015         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2016         (BenchmarkRunner.__init__):
2017
2018 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2019
2020         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
2021
2022         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2023
2024 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2025
2026         Update results of WebKit1.StringTruncator after r184965.
2027
2028         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2029
2030 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2031
2032         Unreviewed, updated my list of email addresses.
2033
2034         * Scripts/webkitpy/common/config/contributors.json:
2035
2036 2015-05-27  Dean Jackson  <dino@apple.com>
2037
2038         img.currentSrc problem in strict mode with old picturefill
2039         https://bugs.webkit.org/show_bug.cgi?id=144095
2040         <rdar://problem/21087013>
2041
2042         Reviewed by Simon Fraser.
2043
2044         Add a PICTURE_SIZES flag.
2045
2046         * Scripts/webkitperl/FeatureList.pm:
2047
2048 2015-05-26  Dana Burkart  <dburkart@apple.com>
2049
2050         Fixes compatibility issues with recent dashboard cleanup.
2051         https://bugs.webkit.org/show_bug.cgi?id=144814
2052
2053         Reviewed by Alexey Proskuryakov.
2054
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2056         (BuildbotStaticAnalyzerQueueView):
2057         (BuildbotStaticAnalyzerQueueView.prototype.update):
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2059         (documentReady):
2060
2061 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2062
2063         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
2064         https://bugs.webkit.org/show_bug.cgi?id=143091
2065         rdar://problem/19330328
2066
2067         Reviewed by Darin Adler and Timothy Hatcher.
2068
2069         We have many of these, which are hard to fit on the dashboard. Added a view that
2070         collapses to a single green bubble when everything is good, and expands when there
2071         are failures (or manually).
2072
2073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
2074
2075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2076         (Buildbot.prototype.set isAuthenticated):
2077         (Buildbot.prototype._normalizeQueueInfo):
2078         (Buildbot.prototype._normalizeQueuesInfo):
2079         (Buildbot.prototype.updateQueues):
2080         Moved queue info normalization here from BuildbitQueue. The latter is a model class
2081         that shouldn't have to know about presentation, and this lets us leep the knowledge
2082         about combined queues out if it. Later, we can refactor existing code, and move out
2083         all knowledge about headings and such.
2084
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2086         Added the new view. It's not quite universal, and doesn't have as helpful popovers
2087         as other views, but we can extend it when/if we use it for more than JSC.
2088
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2090         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2093         (documentReady): Added support for combined queues. These are currently always ending up
2094         in Other column, but it's easy to customize in the future if we need to.
2095
2096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2097         (WebKitBuildbot): Added JSC queus.
2098
2099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2100         (.combined-queue-popover):
2101         (.combined-queue-popover .revision):
2102         Added styles for the combined view.
2103
2104 2015-05-26  Dan Bernstein  <mitz@apple.com>
2105
2106         Changed a file to use Unix line endings.
2107
2108         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2109
2110 2015-05-26  Dan Bernstein  <mitz@apple.com>
2111
2112         <rdar://problem/21104551> Update build settings
2113
2114         Reviewed by Anders Carlsson.
2115
2116         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2117         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2118         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2119         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2120         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2121         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2122         * asan/asan.xcconfig:
2123
2124 2015-05-26  Anders Carlsson  <andersca@apple.com>
2125
2126         Fix build.
2127
2128         * WebKitTestRunner/mac/EventSenderProxy.mm:
2129         (WTR::EventSenderProxy::mouseForceDown):
2130         (WTR::EventSenderProxy::mouseForceUp):
2131         (WTR::EventSenderProxy::mouseForceChanged):
2132
2133 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2134
2135         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
2136         https://bugs.webkit.org/show_bug.cgi?id=145342
2137
2138         Reviewed by Darin Adler.
2139
2140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2141         (BuildbotIteration.prototype._parseData):
2142
2143 2015-05-26  Milan Crha  <mcrha@redhat.com>
2144
2145         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2146         https://bugs.webkit.org/show_bug.cgi?id=138134
2147
2148         Reviewed by Žan Doberšek.
2149
2150         * gtk/generate-inspector-gresource-manifest.py:
2151         (get_filenames): Command line with expanded resources exceeds 32KB, which
2152         is a limit on Windows. It's better to expand wildcards inside the python script.
2153
2154 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2155
2156         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2157         https://bugs.webkit.org/show_bug.cgi?id=140882
2158
2159         Reviewed by Gustavo Noronha Silva.
2160
2161         Make sure unit tests write IndexedDB databases to the temporary
2162         directory, and add a test case to check that the directory is
2163         correctly created at the expected path.
2164
2165         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2166         (testWebContextConfiguration):
2167         (serverCallback):
2168         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2169         (Test::Test):
2170
2171 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2172
2173         [GTK] Enable IndexedDB
2174         https://bugs.webkit.org/show_bug.cgi?id=98932
2175
2176         Reviewed by Žan Doberšek.
2177
2178         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2179
2180 2015-05-24  Sam Weinig  <sam@webkit.org>
2181
2182         Crash when using a removed ScriptMessageHandler
2183         <rdar://problem/20888499>
2184         https://bugs.webkit.org/show_bug.cgi?id=145359
2185
2186         Reviewed by Dan Bernstein.
2187
2188         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2189         Add tests for removing script message handlers.
2190
2191 2015-05-23  Dan Bernstein  <mitz@apple.com>
2192
2193         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2194         https://bugs.webkit.org/show_bug.cgi?id=145345
2195
2196         Reviewed by Sam Weinig.
2197
2198         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2199         * LayoutTestRelay/Configurations/Base.xcconfig:
2200         * TestWebKitAPI/Configurations/Base.xcconfig:
2201         * WebKitTestRunner/Configurations/Base.xcconfig:
2202
2203 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2204
2205         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2206         https://bugs.webkit.org/show_bug.cgi?id=144848
2207
2208         Reviewed by Darin Adler.
2209
2210         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2211
2212         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2213
2214 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2215
2216         Fix one more merge error in static analyzer support.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2219         (BuildbotStaticAnalyzerQueueView):
2220
2221 2015-05-22  Dana Burkart  <dburkart@apple.com>
2222
2223         Fix internal dashboard breakage from recent commit.
2224         https://bugs.webkit.org/show_bug.cgi?id=144814
2225
2226         Unreviewed build fix.
2227
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2229         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2230         (BuildbotStaticAnalyzerQueueView.prototype.update):
2231
2232 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2233
2234         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2235         https://bugs.webkit.org/show_bug.cgi?id=130463
2236         rdar://problem/20461342
2237
2238         Reviewed by Tim Horton.
2239
2240         This was more of a timing related flakiness than an actual OS version specific bug,
2241         we weren't getting window visibility notifications.
2242
2243         I will look into adding this function call to DumpRenderTree separately, layout tests
2244         might actually rely on the broken behavior.
2245
2246         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2247         (TestWebKitAPI::TEST_F):
2248         * TestWebKitAPI/mac/mainMac.mm:
2249         (main):
2250
2251 2015-05-22  Dana Burkart  <dburkart@apple.com>
2252
2253         Add missing file from r184804 (mis-applied diff).
2254         https://bugs.webkit.org/show_bug.cgi?id=144814
2255
2256         Reviewed by Alexey Proskuryakov.
2257
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2259         (BuildbotStaticAnalyzerQueueView):
2260         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2261         (BuildbotStaticAnalyzerQueueView.prototype.update):
2262
2263 2015-05-22  Dana Burkart  <dburkart@apple.com>
2264
2265         Add support to the botwatchers dashboard for a static analyzer bot.
2266         https://bugs.webkit.org/show_bug.cgi?id=144814
2267
2268         Reviewed by Alexey Proskuryakov.
2269
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2271         scan-build should be considered a productive step.
2272
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2274         (BuildbotQueue):
2275         Adds support for the staticAnalyzer property
2276
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2278         (BuildbotTestResults.prototype._parseResults):
2279         Get bug count from the scan-build step output
2280
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2282         (documentReady):
2283         Rename the performance column 'Other', and merge the current 'Other' column with it.
2284
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2286         (WebKitBuildbot):
2287         Now that performance bots are part of the 'Other' column, give them better headings.
2288
2289 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2290
2291         Turn on autosaving of toolbar configuration in MiniBrowser
2292
2293         Rubber-stamped by Dan Bernstein.
2294
2295         * MiniBrowser/mac/BrowserWindow.xib:
2296
2297 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2298
2299         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2300         https://bugs.webkit.org/show_bug.cgi?id=145297
2301
2302         Reviewed by Tim Horton.
2303
2304         This is a refactoring to simplify code, and to make it more logical.
2305
2306         It is up to the view to decide how to present the queues, and whether to split
2307         them into debug and release, or in some different way.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2310         (BuildbotBuilderQueueView.filterQueues):
2311         (BuildbotBuilderQueueView):
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2313         (BuildbotLeaksQueueView):
2314         (BuildbotLeaksQueueView.prototype.update):
2315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2316         (BuildbotPerformanceQueueView):
2317         (BuildbotPerformanceQueueView.prototype.update):
2318         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2319         (BuildbotQueueView):
2320         (BuildbotQueueView.prototype._updateQueues):
2321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2322         (BuildbotTesterQueueView):
2323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2324         (documentReady):
2325
2326 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2327
2328         Remove action menu support
2329         https://bugs.webkit.org/show_bug.cgi?id=145305
2330         <rdar://problem/21070771>
2331
2332         Reviewed by Anders Carlsson.
2333
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2336         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2337         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2338         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2339         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2340         Remove the tests.
2341
2342 2015-05-22  Dan Bernstein  <mitz@apple.com>
2343
2344         Removed the Use Shrink To Fit button from the toolbar’s default set.
2345
2346         Rubber-stamped by Tim Horton.
2347
2348         * MiniBrowser/mac/BrowserWindow.xib:
2349
2350 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2351
2352         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2353         https://bugs.webkit.org/show_bug.cgi?id=128420
2354
2355         Reviewed by Chris Fleizach.
2356
2357         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2358         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2359
2360 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2361
2362         [EFL] Bump libsoup version to 2.50.0
2363         https://bugs.webkit.org/show_bug.cgi?id=145127
2364
2365         Reviewed by Gyuyoung Kim.
2366
2367         * efl/jhbuild.modules:
2368         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2369         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2370
2371 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2372
2373         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2374         https://bugs.webkit.org/show_bug.cgi?id=145117
2375
2376         Reviewed by Csaba Osztrogonác.
2377
2378         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2379         Tools/TestWebKitAPI/Tests/WTF/glib/.
2380
2381         * TestWebKitAPI/PlatformGTK.cmake:
2382         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2383         (TestWebKitAPI::TEST):
2384
2385 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2386
2387         [EFL] fix efreet error
2388         https://bugs.webkit.org/show_bug.cgi?id=143670
2389
2390         Reviewed by Gyuyoung Kim.
2391
2392         Fix efreet error by using external variable efreet_cache_update.
2393         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2394         efreet error for efreet_cache does not occur.
2395
2396         * MiniBrowser/efl/main.c:
2397         (elm_main):
2398
2399 2015-05-20  Michael Saboff  <msaboff@apple.com>
2400
2401         Add option to run_jsc_stress_tests to disable JIT testing
2402         https://bugs.webkit.org/show_bug.cgi?id=145233
2403
2404         Reviewed by Mark Lam.
2405
2406         Added --no-jit option.
2407
2408         * Scripts/run-jsc-stress-tests:
2409
2410 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2411
2412         Use correct String for StringView in WTF API tests
2413         https://bugs.webkit.org/show_bug.cgi?id=145226
2414         rdar://problem/20361786
2415
2416         Reviewed by Benjamin Poulain.
2417
2418         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2419         (TestWebKitAPI::TEST):
2420         Use patternHolder for pattern.
2421
2422 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2423
2424         [Content Extensions] Relax restrictions on triggers that match everything.
2425         https://bugs.webkit.org/show_bug.cgi?id=145069
2426
2427         Reviewed by Benjamin Poulain.
2428
2429         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2430         (TestWebKitAPI::TEST_F):
2431         Update and add tests for new possibilities with .*
2432
2433 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2434
2435         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2436         https://bugs.webkit.org/show_bug.cgi?id=144992
2437
2438         Reviewed by Gyuyoung Kim.
2439
2440         * MiniBrowser/efl/main.c:
2441         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2442         (on_key_down):
2443         (on_fullscreen_enter):
2444         (on_fullscreen_exit):
2445         (window_create):
2446
2447 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2448
2449         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2450         https://bugs.webkit.org/show_bug.cgi?id=145109
2451
2452         Reviewed by Darin Adler.
2453
2454         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2455         (TestWebKitAPI::TEST):
2456
2457 2015-05-19  Anders Carlsson  <andersca@apple.com>
2458
2459         Add alternate menu items for performing operations on the default data store
2460         https://bugs.webkit.org/show_bug.cgi?id=145184
2461
2462         Reviewed by Sam Weinig.
2463
2464         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2465         associated with a data store.
2466
2467         * MiniBrowser/mac/AppDelegate.m:
2468         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2469         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2470         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2471         * MiniBrowser/mac/MainMenu.xib:
2472
2473 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2474
2475         Fix tautological-compare warning in AtomicString.cpp
2476         https://bugs.webkit.org/show_bug.cgi?id=145120
2477
2478         Reviewed by Alexey Proskuryakov.
2479
2480         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2481         (TestWebKitAPI::TEST): Removed always true assert.
2482
2483 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2484
2485         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2486         https://bugs.webkit.org/show_bug.cgi?id=145123
2487
2488         Reviewed by Gyuyoung Kim.
2489
2490         * MiniBrowser/efl/main.c:
2491         (on_key_down):
2492
2493 2015-05-18  Daniel Bates  <dabates@apple.com>
2494
2495         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2496         when staged non-empty file for commit
2497         https://bugs.webkit.org/show_bug.cgi?id=145082
2498
2499         Reviewed by Darin Adler.
2500
2501         Fixes two issues when running prepare-ChangeLog:
2502             1. The function above a deleted function is reported as changed.
2503             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2504             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2505             included in this patch).
2506
2507         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2508         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2509         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2510         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2511         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2512         VCSUtil::parseChunkRange() has existing test coverage.
2513
2514         * Scripts/prepare-ChangeLog:
2515         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2516         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2517         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2518         examine files that only have deletions. Currently this works as a side effect of the behavior of
2519         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2520         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2521         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2522         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2523         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2524         We return (-1, -1) when the change represents a deletion.
2525         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2526         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2527         We return (-1, -1) when the change represents an addition.
2528         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2529         unit tests.
2530
2531 2015-05-18  Anders Carlsson  <andersca@apple.com>
2532
2533         Add ATS keys to MiniBrowser
2534         https://bugs.webkit.org/show_bug.cgi?id=145141
2535
2536         Reviewed by Sam Weinig.
2537
2538         * MiniBrowser/mac/Info.plist:
2539
2540 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2541
2542         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2543         <http://webkit.org/b/145100>
2544
2545         Reviewed by Darin Adler.
2546
2547         * Scripts/bisect-builds:
2548         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2549         - Switch to using PROMPT_RESPONSE_* constants when testing the
2550           value of $didReproduceBug.
2551         - Add do { } while loops to implement 'retry' mode.
2552         (promptForTest):
2553         - Switch to returning PROMPT_RESPONSE_* constants.
2554         - Add support for 'retry' response.
2555
2556 2015-05-16  Tanay C  <tanay.c@samsung.com>
2557
2558         [EFL][WK2] Minibrowser : Add search icon to search bar
2559         https://bugs.webkit.org/show_bug.cgi?id=139773
2560
2561         Reviewed by Gyuyoung Kim.
2562
2563         * MiniBrowser/efl/main.c:
2564         (search_icon_show): Added.
2565         (search_box_show): Modified.
2566
2567 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2568
2569         run_benchmark should have an option to specify the number of runs
2570         https://bugs.webkit.org/show_bug.cgi?id=145091
2571
2572         Reviewed by Stephanie Lewis.
2573
2574         Added --count option.
2575
2576         * Scripts/run-benchmark:
2577         (main):
2578         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2579         (BenchmarkRunner.__init__):
2580
2581 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2582
2583         Temporarily disable failing API test.
2584
2585         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2586         (TestWebKitAPI::TEST):
2587
2588 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2589
2590         User interruption while running of run-webkit-tests should also generate results.html
2591         https://bugs.webkit.org/show_bug.cgi?id=122154
2592
2593         Reviewed by Csaba Osztrogonác.
2594
2595         Generation of results.html on execution of run-webkit-tests happens only
2596         on completion of entire layout tests run. It should be created even when
2597         the execution has been interrupted - either by user (by pressing Ctrl+C)
2598         or because of other interruptions (like exit-after-n-failures option).
2599
2600         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2601         (LayoutTestRunner.run_tests):
2602         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2603         (Manager.run):
2604         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2605         (TestRunResults.__init__):
2606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2607         (main):
2608         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2609         (RunTest.test_keyboard_interrupt):
2610         (MainTest.test_exception_handling):
2611
2612 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2613
2614         [buildbot] Fix the URL of the performance bots
2615         https://bugs.webkit.org/show_bug.cgi?id=145043
2616
2617         Reviewed by Ryosuke Niwa.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2620
2621 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2622
2623         Add a layout mode that scales down the view to try to fit the document
2624         https://bugs.webkit.org/show_bug.cgi?id=145022
2625         <rdar://problem/19790341>
2626
2627         Reviewed by Dean Jackson.
2628
2629         * MiniBrowser/mac/BrowserWindow.xib:
2630         * MiniBrowser/mac/BrowserWindowController.h:
2631         * MiniBrowser/mac/WK2BrowserWindowController.m:
2632         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2633         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2634         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2635
2636 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2637
2638         [CMake] Don't read the LOCATION property of targets
2639         https://bugs.webkit.org/show_bug.cgi?id=145018
2640
2641         Reviewed by Martin Robinson.
2642
2643         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2644         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2645         be the same at configure-time as it is at generate-time.
2646
2647         * TestWebKitAPI/CMakeLists.txt:
2648
2649 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2650
2651         Add String literal overloads to equalIgnoringASCIICase()
2652         https://bugs.webkit.org/show_bug.cgi?id=145008
2653
2654         Reviewed by Benjamin Poulain.
2655
2656         Test changes to WTF.
2657
2658         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2659         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2660         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2661         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2662         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2663         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2664
2665 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2666
2667         SharedBuffer::createWithContentsOfFile should use map file routines
2668         https://bugs.webkit.org/show_bug.cgi?id=144192
2669
2670         Reviewed by Darin Adler.
2671
2672         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2673
2674         * TestWebKitAPI/PlatformGTK.cmake:
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2677         (TestWebKitAPI::FileSystemTest::tempFilePath):
2678         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2679         (TestWebKitAPI::TEST_F):
2680         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2681         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2682         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2683         (TestWebKitAPI::TEST_F):
2684
2685 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2686
2687         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2688         https://bugs.webkit.org/show_bug.cgi?id=144967
2689
2690         Reviewed by Benjamin Poulain.
2691
2692         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2693         Xcode wanted to fix an alphabetization issue.
2694         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2695         (TestWebKitAPI::TEST_F):
2696         Test interactions that worked but were not explicitly tested before.
2697
2698 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2699
2700         Unreviewed build fix.
2701
2702         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2703
2704         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2705
2706 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2707
2708         Fix the previous commit, which made both bubbles green.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2711         (.status-line.good .bubble):
2712         (.status-line.bad .bubble):
2713         (.status-line.good .message):
2714
2715 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2718         https://bugs.webkit.org/show_bug.cgi?id=144929
2719
2720         Reviewed by Eric Carlson.
2721
2722         Tweaked colors as I see fit.
2723
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2725         (.status-line.good .bubble):
2726         (.status-line.bad .bubble):
2727
2728 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2729
2730         [Mac] Share cookie storage between UI process and secondary processes
2731         https://bugs.webkit.org/show_bug.cgi?id=144820
2732         rdar://problem/20572830
2733
2734         Reviewed by Darin Adler.
2735
2736         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2737         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2738         for testing.
2739
2740 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2741
2742         Fix internal build configuration issues
2743         https://bugs.webkit.org/show_bug.cgi?id=144762
2744
2745         Reviewed by David Kilzer.
2746
2747         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2748
2749         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2750         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2751         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2752         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2753         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2754         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2755         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2756         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2757
2758 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2759
2760         Switch to launching iOS Simulator using bundle ID
2761         <rdar://problem/20916096>
2762
2763         This is required to fix the layout tests on internal bots.
2764
2765         * Scripts/webkitdirs.pm:
2766         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2767         Simulator.  Add FIXME.
2768         (quitIOSSimulator): Add FIXME.
2769         * Scripts/webkitpy/port/ios.py:
2770         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2771         launch iOS Simulator.  Add FIXME.
2772         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2773
2774 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2775
2776         Fix run-javascriptcore-tests step on the WinCairo bot
2777         https://bugs.webkit.org/show_bug.cgi?id=144866
2778
2779         Reviewed by Csaba Osztrogonác.
2780
2781         Catch exception when failing to create soft link, so we can fall back to copy.
2782
2783         * Scripts/run-jsc-stress-tests:
2784
2785 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2786
2787         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2788         https://bugs.webkit.org/show_bug.cgi?id=116971
2789
2790         Reviewed by Chris Fleizach.
2791
2792         Implement rowAtIndex for ATK.
2793
2794         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2795         (WTR::AccessibilityUIElement::rowAtIndex):
2796
2797 2015-05-11  Dan Bernstein  <mitz@apple.com>
2798
2799         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2800
2801         Reviewed by Alexey Proskuryakov.
2802
2803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2804         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2805         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2806         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2807
2808 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
2809
2810         Fix internal build configuration issues
2811         https://bugs.webkit.org/show_bug.cgi?id=144762
2812
2813         Reviewed by Darin Adler.
2814
2815         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
2816
2817         * TestWebKitAPI/Configurations/Base.xcconfig:
2818         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2819         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2820         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2821         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2822         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2823         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2824
2825 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2826
2827         [Win] Move Windows build target to Windows 7 (or newer)
2828         https://bugs.webkit.org/show_bug.cgi?id=144890
2829         <rdar://problem/20707307>
2830
2831         Reviewed by Anders Carlsson.
2832
2833         Update linked SDK and minimal Windows level to be compatible with
2834         Windows 7 or newer.
2835
2836         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2837         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2838         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2839         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2840         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2841         * DumpRenderTree/config.h:
2842         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2843         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2844         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2845         * WinLauncher/stdafx.h:
2846
2847 2015-05-11  Commit Queue  <commit-queue@webkit.org>
2848
2849         Unreviewed, rolling out r184119.
2850         https://bugs.webkit.org/show_bug.cgi?id=144888
2851
2852         broke JSC tests on Apple Windows bots (Requested by kling on
2853         #webkit).
2854
2855         Reverted changeset:
2856
2857         "Fix run-javascriptcore-tests step on the WinCairo bot"
2858         https://bugs.webkit.org/show_bug.cgi?id=144866
2859         http://trac.webkit.org/changeset/184119
2860
2861 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2862
2863         run-benchmark should support Dromaeo
2864         https://bugs.webkit.org/show_bug.cgi?id=144849
2865
2866         Reviewed by Chris Dumez.
2867
2868         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
2869         they can take as much as 15 minutes to run each.
2870
2871         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
2872         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
2873         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
2874         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
2875
2876 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2877
2878         Build fix. jetstream has a local copy, not remote archive.
2879
2880         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2881
2882 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2883
2884         run-benchmark should support SunSpider, Kraken and Octane
2885         https://bugs.webkit.org/show_bug.cgi?id=144840
2886
2887         Reviewed by Darin Adler.
2888
2889         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
2890         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
2891         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
2892         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
2893
2894         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
2895         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
2896
2897         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
2898         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
2899
2900         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
2901         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
2902         now has the ability to run an arbitrary "create script".
2903
2904         * Scripts/run-benchmark:
2905         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
2906         This also overrides the remote archive URL specified in the plan.
2907
2908         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
2909
2910         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
2911         JetStreamBenchmarkBuilder.
2912
2913         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2914         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
2915         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
2916         _runCreateScript and _applyPatch to clean after themselves.
2917         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
2918         JetStream, SunSpider, Kraken all use this feature.
2919         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
2920         the leaf directory name since the latter is not available when a remote ZIP file is used.
2921         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
2922         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
2923         the benchmark name in the patches.
2924
2925         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
2926
2927         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2928         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
2929         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
2930         the browser opens by planName as the plan file no longer contains that.
2931
2932         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
2933         the top directory of JetStream instead of its parent.
2934         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
2935         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
2936         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
2937         the top directory of JetStream instead of its parent.
2938         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
2939         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
2940         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
2941         done in JetStream.patch.
2942         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
2943         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
2944         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
2945         path from the top directory of JetStream as done in JetStream.patch.
2946         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
2947
2948 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
2949
2950         Fix run-javascriptcore-tests step on the WinCairo bot
2951         https://bugs.webkit.org/show_bug.cgi?id=144866
2952
2953         Reviewed by Darin Adler.
2954
2955         * Scripts/run-jsc-stress-tests:
2956
2957 2015-05-11  Alex Christensen  <achristensen@webkit.org>
2958
2959         [Content Extensions] Support domain-specific rules and exceptions.
2960         https://bugs.webkit.org/show_bug.cgi?id=144833
2961
2962         Reviewed by Darin Adler.
2963
2964         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2965         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2966         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2967         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2968         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
2969         (TestWebKitAPI::mainDocumentRequest):
2970         (TestWebKitAPI::subResourceRequest):
2971         (TestWebKitAPI::TEST_F):
2972         (TestWebKitAPI::checkCompilerError):
2973         Added tests for parsing and functionality of if-domain and unless-domain.
2974
2975 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         run-benchmark should support Chrome Canary and Firefox Nightly
2978         https://bugs.webkit.org/show_bug.cgi?id=144850
2979
2980         Reviewed by Darin Adler.
2981
2982         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
2983
2984         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
2985
2986         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
2987         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
2988         (OSXBrowserDriver):
2989         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
2990         (OSXBrowserDriver.closeBrowsers): Ditto.
2991         (OSXBrowserDriver.launchProcess): Ditto.
2992         (OSXBrowserDriver.terminateProcesses): Ditto.
2993         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2994         (OSXChromeDriver): Removed the unused self.chromePreferences.
2995         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
2996         (OSXChromeDriver.closeBrowsers): Ditto.
2997         (OSXChromeDriver.launchUrl):
2998         (OSXChromeCanaryDriver): Added.
2999         (OSXChromeCanaryDriver.launchUrl):
3000         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
3001         (OSXFirefoxDriver): Added.
3002         (OSXFirefoxDriver.launchUrl):
3003         (OSXFirefoxNightlyDriver): Added.
3004         (OSXFirefoxNightlyDriver.launchUrl):
3005         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3006         (OSXSafariDriver):
3007         (OSXSafariDriver.closeBrowsers):
3008
3009 2015-05-11  Tim Horton  <timothy_horton@apple.com>
3010
3011         Page overlay action context override should indicate the source of the request
3012         https://bugs.webkit.org/show_bug.cgi?id=144832
3013         <rdar://problem/20562594>
3014
3015         Reviewed by Darin Adler.
3016
3017         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
3018         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
3019
3020 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
3021
3022         [GTK] fast/events/page-visibility-transition-test.html is timing out
3023         https://bugs.webkit.org/show_bug.cgi?id=114789
3024
3025         Reviewed by Darin Adler.
3026
3027         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3028         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
3029         requests visibility changes.
3030
3031 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3032
3033         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
3034         https://bugs.webkit.org/show_bug.cgi?id=144798
3035
3036         Reviewed by Darin Adler.
3037
3038         * efl/install-dependencies:
3039
3040 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
3041
3042         Make arguments of run-benchmark more user friendly
3043         https://bugs.webkit.org/show_bug.cgi?id=144835
3044
3045         Reviewed by Darin Adler.
3046
3047         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
3048         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
3049         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
3050         default values from --platform and --browser as they are required arguments.
3051
3052         * Scripts/run-benchmark:
3053         (main): Made --build-directory optional, and removed default values from --platform and --browser.
3054         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
3055         are not dynamically obtained via BrowserDriverFactory.
3056         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3057         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
3058         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
3059         run any benchmark in that case.
3060         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
3061         the specified file isn't a valid relative or an absolute path.
3062         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3063         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
3064         and browsers.
3065         (BrowserDriverFactory.available_browsers): Ditto.
3066         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3067         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
3068         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
3069         browserBuildPath was None.
3070         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3071         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
3072         so that we can use locally built WebKit to launch Safari.
3073
3074 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
3075
3076         Remove the PICTURE_SIZES build flag
3077         https://bugs.webkit.org/show_bug.cgi?id=144679
3078
3079         Reviewed by Benjamin Poulain.
3080
3081         Removed the PICTURE_SIZES build time flag.
3082
3083         * Scripts/webkitperl/FeatureList.pm:
3084
3085 2015-05-09  David Kilzer  <ddkilzer@apple.com>
3086
3087         Layout tests broke due to unexpected simctl output
3088
3089         * Scripts/webkitpy/xcode/simulator.py:
3090         (Simulator._parse_devices): Handle new Device Pairs header.
3091         * Scripts/webkitpy/xcode/simulator_unittest.py:
3092         (test_device_pairs): Add unit test for Device Pairs header.
3093
3094 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3095
3096         Remove convenience constructors for TextRun
3097         https://bugs.webkit.org/show_bug.cgi?id=144752
3098
3099         Reviewed by Anders Carlsson.
3100
3101         Test the StringView which takes a StringImpl*.
3102
3103         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3104         (StringView8Bit): Testing is8Bit() on StringView
3105
3106 2015-05-07  Sam Weinig  <sam@webkit.org>
3107
3108         [Content Extensions] Add simple tester that takes an extension and compiles it
3109         https://bugs.webkit.org/show_bug.cgi?id=144781
3110
3111         Reviewed by Dan Bates.
3112
3113         * ContentExtensionTester: Added.
3114         * ContentExtensionTester/Configurations: Added.
3115         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
3116         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
3117         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
3118         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
3119         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
3120         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
3121         * ContentExtensionTester/main.m: Added.
3122         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
3123
3124 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
3125
3126         Build fix.
3127
3128         Reviewed by Dan Bernstein.
3129
3130         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3131         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3132         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
3133         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3134         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3135         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3136         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
3137         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3138
3139 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
3140
3141         [GTK] Some tests fail because they do not assume the popup menu captures click events
3142         https://bugs.webkit.org/show_bug.cgi?id=40601
3143
3144         Reviewed by Carlos Garcia Campos.
3145
3146         Popdown all attached menus when moving between tests and between each new
3147         event sent to the WebView. This prevents context and popup menus from eating
3148         events.
3149
3150         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3151         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3152         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3153         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3154         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3155         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3156         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3157         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3158         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3159         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3160         longer in the platform-independent file.
3161         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3162
3163 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3164
3165         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3166         https://bugs.webkit.org/show_bug.cgi?id=144746
3167
3168         Reviewed by Carlos Garcia Campos.
3169
3170         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3171
3172         * MiniBrowser/gtk/main.c:
3173         (main):
3174
3175 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3176
3177         Unreviewed, rolling out r183996.
3178         https://bugs.webkit.org/show_bug.cgi?id=144806
3179
3180         ASan detected use-after free (Requested by ap on #webkit).
3181
3182         Reverted changeset:
3183
3184         "Remove convenience constructors for TextRun"
3185         https://bugs.webkit.org/show_bug.cgi?id=144752
3186         http://trac.webkit.org/changeset/183996
3187
3188 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3189
3190         Remove convenience constructors for TextRun
3191         https://bugs.webkit.org/show_bug.cgi?id=144752
3192
3193         Reviewed by Anders Carlsson.
3194
3195         Test the StringView which takes a StringImpl*.
3196
3197         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3198         (StringView8Bit): Testing is8Bit() on StringView
3199
3200 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3201
3202         [GTK] WTR doesn't correctly handle the Escape key
3203         https://bugs.webkit.org/show_bug.cgi?id=144788
3204
3205         Reviewed by Martin Robinson.
3206
3207         Correctly handle 0x001B character code in GTK+ event sender to be
3208         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3209         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3210         to dismiss popup menus.
3211
3212         Fixes editing/selection/5354455-1.html.
3213
3214         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3215         (WTR::getGDKKeySymForKeyRef):
3216
3217 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3218
3219         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3220         https://bugs.webkit.org/show_bug.cgi?id=144748
3221
3222         Reviewed by Sergio Villar Senin.
3223
3224         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3225         (testWebKitSettings): Check the new setting is correctly
3226         initialized and updated.
3227         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3228         (testWebContextSecurityFileXHR): Check XHR to local files is
3229         allowed from file URLs after changing the setting.
3230         (beforeAll): Add new test.
3231
3232 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3233
3234         Unreviewed, rolling out r183945.
3235         https://bugs.webkit.org/show_bug.cgi?id=144789
3236
3237         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3238
3239         Reverted changeset:
3240
3241         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3242         https://bugs.webkit.org/show_bug.cgi?id=144746
3243         http://trac.webkit.org/changeset/183945
3244
3245 2015-05-07  Anders Carlsson  <andersca@apple.com>
3246
3247         Build fixes.
3248
3249         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3250         (TestWebKitAPI::TEST):
3251         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3252         (TestWebKitAPI::TEST):
3253         Add casts.
3254
3255 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3256
3257         GC has trouble with pathologically large array allocations
3258         https://bugs.webkit.org/show_bug.cgi?id=144609
3259
3260         Reviewed by Geoffrey Garen.
3261
3262         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3263         and it's a frequently requested feature.
3264
3265         Also add the ability to run a test pretending that your system has a particular RAM size.
3266         This is useful for GC tests, and the new GC test that I added uses this.
3267
3268         * Scripts/run-javascriptcore-tests:
3269         (runJSCStressTests):
3270         * Scripts/run-jsc-stress-tests:
3271
3272 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3273
3274         [EFL] Bump EFL version to 1.14.0
3275         https://bugs.webkit.org/show_bug.cgi?id=144743
3276
3277         Reviewed by Darin Adler.
3278
3279         Bump EFL and elementary version to 1.14.0 and removed
3280         md5sum, because it isn't used at all if hash is present.
3281
3282         * efl/jhbuild.modules:
3283
3284 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3285
3286         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3287         https://bugs.webkit.org/show_bug.cgi?id=144753
3288
3289         Reviewed by Mark Lam.
3290
3291         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3292
3293 2015-05-07  Beth Dakin  <bdakin@apple.com>
3294
3295         New force-related DOM events should fire in WK1 views
3296         https://bugs.webkit.org/show_bug.cgi?id=144663
3297         -and corresponding-
3298         rdar://problem/20281886
3299
3300         Reviewed by Sam Weinig.
3301
3302         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event
3303         now. Just send nil.
3304         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3305         (TestWebKitAPI::buildAndPerformTest):
3306
3307 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3308
3309         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3310         https://bugs.webkit.org/show_bug.cgi?id=144746
3311
3312         Reviewed by Martin Robinson.
3313
3314         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3315
3316         * MiniBrowser/gtk/main.c:
3317         (main):
3318
3319 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3320
3321         Revert "Introducing the Platform Abstraction Layer (PAL)"
3322         https://bugs.webkit.org/show_bug.cgi?id=144751
3323
3324         Unreviewed.
3325
3326         PAL should be a new target inside WebCore, rather than a top-level folder.
3327
3328         * Scripts/build-webkit: Add it to build-webkit.
3329
3330 2015-05-07  Ada Chan  <adachan@apple.com>
3331
3332         Add a test for WKPageCopySessionState() with filtering.
3333         https://bugs.webkit.org/show_bug.cgi?id=144666
3334
3335         Reviewed by Darin Adler.
3336
3337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3338         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3339         (TestWebKitAPI::didFinishLoadForFrame):
3340         (TestWebKitAPI::setPageLoaderClient):
3341         (TestWebKitAPI::filterFirstItemCallback):
3342         (TestWebKitAPI::filterAllItemsCallback):
3343         (TestWebKitAPI::createSessionStates):
3344         (TestWebKitAPI::TEST):
3345
3346 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3347
3348         iOS build fix attempt
3349
3350         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3351
3352         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3353
3354 2015-05-06  Matt Baker  <mattbaker@apple.com>
3355
3356         Unreviewed, updated my list of email addresses.
3357
3358         * Scripts/webkitpy/common/config/contributors.json:
3359
3360 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3361
3362         Do not link tools to WebKit2.framework
3363         https://bugs.webkit.org/show_bug.cgi?id=144699
3364
3365         Unreviewed build fix.
3366
3367         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3368         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3369         These linked to WebKit2 in two ways, eliminating the other one.
3370
3371 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3372
3373         Introducing the Platform Abstraction Layer (PAL)
3374         https://bugs.webkit.org/show_bug.cgi?id=143358
3375
3376         Reviewed by Simon Fraser.
3377
3378         * Scripts/build-webkit: Add it to build-webkit.
3379
3380 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3381
3382         Fix api tests after r183877.
3383
3384         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3385         (TestWebKitAPI::TEST_F):
3386         Generate all DFAs before compiling them.
3387
3388 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3389
3390         Do not link tools to WebKit2.framework
3391         https://bugs.webkit.org/show_bug.cgi?id=144699
3392
3393         Reviewed by Tim Horton.
3394
3395         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3398
3399 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3400
3401         [Content Extensions] Test splitting NFAs by max NFA size.
3402         https://bugs.webkit.org/show_bug.cgi?id=144659
3403
3404         Reviewed by Darin Adler.
3405
3406         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3407         (TestWebKitAPI::createNFAs):
3408         (TestWebKitAPI::TEST_F):
3409         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3410         (TestWebKitAPI::createNFAs):
3411
3412 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3413
3414         Remove the remaining vestiges of SVG feature define
3415         https://bugs.webkit.org/show_bug.cgi?id=144655
3416
3417         Reviewed by Alexey Proskuryakov.
3418
3419         * Scripts/webkitperl/FeatureList.pm:
3420
3421 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3422
3423         Add a layout mode for computing fixed layout size from a minimum size
3424         https://bugs.webkit.org/show_bug.cgi?id=144610
3425         <rdar://problem/19790341>
3426
3427         Reviewed by Simon Fraser.
3428
3429         * MiniBrowser/mac/BrowserWindow.xib:
3430         * MiniBrowser/mac/BrowserWindowController.h:
3431         * MiniBrowser/mac/WK1BrowserWindowController.m:
3432         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3433         * MiniBrowser/mac/WK2BrowserWindowController.m:
3434         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3435         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3436
3437 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3438
3439         [Content Extensions] Release input NSString when finished copying it.
3440         https://bugs.webkit.org/show_bug.cgi?id=144642
3441
3442         Reviewed by Brian Weinstein.
3443
3444         * WebKitTestRunner/mac/TestControllerMac.mm:
3445         (WTR::TestController::platformConfigureViewForTest):
3446         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3447
3448 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3449
3450         Unreviewed test fix after r183798.
3451
3452         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3453         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3454         so we can share results.
3455
3456 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3457
3458         [Content Extensions] Use less memory to store the json input.
3459         https://bugs.webkit.org/show_bug.cgi?id=144604
3460
3461         Reviewed by Benjamin Poulain.
3462
3463         * MiniBrowser/mac/ExtensionManagerWindowController.m:
3464         (-[ExtensionManagerWindowController add:]):
3465         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3466         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3467         * WebKitTestRunner/mac/TestControllerMac.mm:
3468         (WTR::TestController::platformConfigureViewForTest):
3469
3470 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3471
3472         Unreviewed. Make myself a WebKit reviewer.
3473
3474         * Scripts/webkitpy/common/config/contributors.json:
3475
3476 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
3477
3478         [GTK] r183783 breaks build
3479         https://bugs.webkit.org/show_bug.cgi?id=144632
3480
3481         Reviewed by Martin Robinson.
3482
3483         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
3484
3485         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3486         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3487
3488 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3489
3490         [Content Extensions] Combine NFAs properly and free memory as we compile.
3491         https://bugs.webkit.org/show_bug.cgi?id=144485
3492
3493         Reviewed by Benjamin Poulain.
3494
3495         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3496         (TestWebKitAPI::TEST_F):
3497         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
3498         Added tests for deep NFAs.
3499
3500 2015-05-04  Alex Christensen  <achristensen@webkit.org>
3501
3502         [Content Extensions] Use less memory when writing byte code to file
3503         https://bugs.webkit.org/show_bug.cgi?id=144602
3504
3505         Reviewed by Darin Adler.
3506
3507         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3508
3509 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3510
3511         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
3512         https://bugs.webkit.org/show_bug.cgi?id=144541
3513
3514         Reviewed by Žan Doberšek.
3515
3516         Add a test case to WorkQueue unit test, to check that sources of
3517         asynchronous IO operations running in the WorkQueue thread are
3518         dispatched by the WorkQueue main loop.
3519
3520         * TestWebKitAPI/PlatformGTK.cmake:
3521         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
3522         (TestWebKitAPI::TEST):
3523
3524 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3525
3526         Correct '--show-webview' option for Tiled Drawing tests
3527         https://bugs.webkit.org/show_bug.cgi?id=144621
3528
3529         Reviewed by Simon Fraser.
3530
3531         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3532         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3533
3534         * WebKitTestRunner/mac/TestControllerMac.mm:
3535         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3536         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3537
3538 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3539
3540         Large array shouldn't be slow
3541         https://bugs.webkit.org/show_bug.cgi?id=144617
3542
3543         Reviewed by Geoffrey Garen.
3544
3545         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3546         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3547         long-running. So, hash-map sort of belongs here.
3548
3549         * Scripts/run-jsc-benchmarks:
3550
3551 2015-05-04  Doug Russell  <d_russell@apple.com>
3552
3553         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3554         https://bugs.webkit.org/show_bug.cgi?id=144489
3555
3556         Reviewed by Chris Fleizach.
3557
3558         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3559         on the returned control.
3560         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3561         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3562         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3563         Add support for setSelectedVisibleTextRange() in accessibility tests.
3564
3565         * DumpRenderTree/AccessibilityUIElement.cpp:
3566         (setSelectedVisibleTextRangeCallback):
3567         (AccessibilityUIElement::setSelectedVisibleTextRange):
3568         (AccessibilityUIElement::getJSClass):
3569         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3570         * DumpRenderTree/AccessibilityUIElement.h:
3571         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3572         (AccessibilityUIElement::setSelectedVisibleTextRange):
3573         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3574         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3575         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3576         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3577         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3578         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3579         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3580         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3581         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3582         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3583         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3584
3585 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3586
3587         [Win] Implement the "--show-webview" option for Windows
3588         https://bugs.webkit.org/show_bug.cgi?id=144589
3589
3590         Reviewed by Alex Christensen.
3591
3592         Add another runtime flag (--show-webview) that causes DumpRenderTree
3593         to draw its view on-screen, rather than the standard offscreen mode.
3594
3595         * DumpRenderTree/win/DumpRenderTree.cpp:
3596         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3597         (initializeGlobalsFromCommandLineOptions): Recognize the new
3598         command-line argument, and set the global 'showWebView' state if
3599         appropriate.
3600
3601 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3602
3603         Remove dead code from TestInvocationCairo.cpp
3604         https://bugs.webkit.org/show_bug.cgi?id=144564
3605
3606         Reviewed by Gyuyoung Kim.
3607
3608         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3609
3610         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3611         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3612
3613 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3614
3615         [GTK] Add libnotify in gtk install-dependencies
3616         https://bugs.webkit.org/show_bug.cgi?id=144379
3617
3618         Reviewed by Csaba Osztrogonác.
3619
3620         * gtk/install-dependencies:
3621
3622 2015-05-01  Dan Bernstein  <mitz@apple.com>
3623
3624         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3625         https://bugs.webkit.org/show_bug.cgi?id=144501
3626
3627         Reviewed by Darin Adler.
3628
3629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3630         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3631         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3632         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3633
3634 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3635
3636         check-webkit-style fails due to system pylint
3637         https://bugs.webkit.org/show_bug.cgi?id=144360
3638
3639         Reviewed by Darin Adler.
3640
3641         Make sure that the directory containing third party autoinstalled modules
3642         is at the beginning of the search path, to avoid conflicts with other
3643         versions of the same modules installed in the system (e.g. pylint).
3644
3645         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3646         modules directory to sys.path, instead of appending it.
3647
3648 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3649
3650         Unreviewed, updated my list of email addresses.
3651
3652         * Scripts/webkitpy/common/config/contributors.json: Updated.
3653
3654 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3655
3656         USE(...) macro should expect unprefixed variables
3657         https://bugs.webkit.org/show_bug.cgi?id=144454
3658
3659         Reviewed by Daniel Bates.
3660
3661         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3662         * DumpRenderTree/config.h: Ditto.
3663         * TestWebKitAPI/config.h: Ditto.
3664
3665 2015-05-01  Basile Clement  <basile_clement@apple.com>
3666
3667         Unreviewed. Add myself as a commiter in contributors.json.
3668
3669         * Scripts/webkitpy/common/config/contributors.json:
3670
3671 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3672
3673         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3674         https://bugs.webkit.org/show_bug.cgi?id=144487
3675
3676         Reviewed by Ryosuke Niwa.
3677
3678         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3679         (BenchmarkRunner.merge): Fix bug.
3680         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3681
3682 2015-05-01  Brady Eidson  <beidson@apple.com>
3683
3684         Add API to disable meta refreshes.
3685         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3686
3687         Reviewed by Alexey Proskuryakov.
3688
3689         * DumpRenderTree/mac/DumpRenderTree.mm:
3690         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3691
3692 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3693
3694         Provide a runtime flag to run-webkit-tests that shows the test view
3695         https://bugs.webkit.org/show_bug.cgi?id=144079.
3696
3697         Unreviewed correction to r183651.
3698
3699         * WebKitTestRunner/TestController.cpp:
3700         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3701         flag is included in the options dictionary passed to the PlatformWebView.
3702
3703 2015-05-01  Antti Koivisto  <antti@apple.com>
3704
3705         Remove network process load serialization code
3706         https://bugs.webkit.org/show_bug.cgi?id=144448
3707
3708         Reviewed by Alexey Proskuryakov.
3709
3710         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3711         (WTR::InjectedBundle::beginTesting):
3712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3713         (WTR::TestRunner::setSerializeHTTPLoads):
3714         (WTR::TestRunner::dispatchPendingLoadRequests):
3715
3716 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3717
3718         [GTK] Add libhyphen-dev to the build dependencies
3719         https://bugs.webkit.org/show_bug.cgi?id=144452
3720
3721         Reviewed by Martin Robinson.
3722
3723         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3724         dependencies.
3725
3726 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3727
3728         Provide a runtime flag to run-webkit-tests that shows the test view
3729         https://bugs.webkit.org/show_bug.cgi?id=144079.
3730
3731         Reviewed by Dean Jackson.
3732
3733         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3734         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3735         option:
3736
3737         --additional-drt-flag="--show-webview"
3738
3739         * DumpRenderTree/mac/DumpRenderTree.mm:
3740         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
3741         '--show-webview' flag.
3742         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
3743         * WebKitTestRunner/Options.cpp:
3744         (WTR::Options::Options):
3745         (WTR::handleOptionShowWebView):
3746         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
3747         * WebKitTestRunner/Options.h:
3748         * WebKitTestRunner/TestController.cpp:
3749         (WTR::TestController::TestController):
3750         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
3751         * WebKitTestRunner/TestController.h:
3752         (WTR::TestController::shouldShowWebView):
3753         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3754         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
3755         options dictionary. If it is true, display the web view while running the test.
3756
3757 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
3758
3759         r183355 didn't trigger Mac tests
3760         https://bugs.webkit.org/show_bug.cgi?id=144464
3761
3762         Reviewed by Simon Fraser.
3763
3764         Update badly neglected filters and unit tests.
3765
3766         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3767         (_should_file_trigger_build):
3768         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3769         (ShouldBuildTest):
3770         (ShouldBuildTest.test_should_build):
3771
3772 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3773
3774         [GTK] Add libhyphen-dev to the build dependencies
3775         https://bugs.webkit.org/show_bug.cgi?id=144452
3776
3777         Reviewed by Martin Robinson.
3778
3779         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
3780         build dependencies.
3781
3782 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
3783
3784         [GTK] Testing dictionaries are not installed automatically
3785         https://bugs.webkit.org/show_bug.cgi?id=144460
3786
3787         Reviewed by Carlos Garcia Campos.
3788
3789         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
3790
3791 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
3792
3793         Fix return code issue, check return code of safari process and dump results to log
3794         https://bugs.webkit.org/show_bug.cgi?id=144436
3795
3796         Reviewed by Ryosuke Niwa.
3797
3798         * Scripts/run-benchmark:
3799         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3800         (BenchmarkRunner.dump): Correct typo.
3801         (BenchmarkRunner.wrap): Add results to console.
3802         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
3803         (OSXSafariDriver.prepareEnv):
3804         (OSXSafariDriver.launchUrl):
3805         (OSXSafariDriver.closeBrowsers):
3806
3807 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
3808
3809         Should no longer need to worry about very old versions of Xcode
3810         https://bugs.webkit.org/show_bug.cgi?id=144437
3811
3812         Reviewed by Dan Bernstein.
3813
3814         * Scripts/check-for-exit-time-destructors:
3815         * Scripts/check-for-global-initializers:
3816         * Scripts/check-for-weak-vtables-and-externals:
3817
3818 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
3819
3820         REGRESSION(183583): [Mac] make without SDKROOT has issues
3821         https://bugs.webkit.org/show_bug.cgi?id=144431
3822
3823         Reviewed by Dan Bernstein.
3824
3825         * Makefile:
3826         * WebKitTestRunner/Makefile:
3827         Assume an empty SDKROOT means an macosx variant, so only
3828         enable settings if the SDKROOT is not empty and does not
3829         contain "macosx".
3830
3831 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
3832
3833         Expand test infrastructure to support scrolling tests
3834         https://bugs.webkit.org/show_bug.cgi?id=143684
3835         <rdar://problem/20375516>
3836
3837         Reviewed by Simon Fraser.
3838
3839         * DumpRenderTree/mac/DumpRenderTree.mm:
3840         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
3841         reset before the next test run.
3842         * WebKitTestRunner/TestController.cpp:
3843         (WTR::TestController::resetStateToConsistentValues): Ditto."
3844
3845 2015-04-29  Alex Christensen  <achristensen@webkit.org>
3846
3847         Run javascriptcore tests on Windows without cygwin
3848         https://bugs.webkit.org/show_bug.cgi?id=144419
3849
3850         Reviewed by Brent Fulgham.
3851
3852         * Scripts/run-javascriptcore-tests:
3853         (runJSCStressTests):
3854         Just call ruby, not /usr/bin/env ruby.
3855
3856 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
3857
3858         [GTK] Add --enable-shared option to LLVM to build mesa
3859         https://bugs.webkit.org/show_bug.cgi?id=144393
3860
3861         Reviewed by Martin Robinson.
3862
3863         The updated mesa requires the shared LLVM libraries.
3864         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
3865         to LLVM configure script. It will provide shared libraries in addition to static libraries.
3866
3867         * gtk/jhbuild-optional.modules:
3868
3869 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
3870
3871         [GTK] Add support for automatic hyphenation
3872         https://bugs.webkit.org/show_bug.cgi?id=44478
3873
3874         Reviewed by Carlos Garcia Campos.
3875
3876         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
3877         all systems will use the same dictionaries for testing purposes.
3878
3879 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
3880
3881         Failure when building WebKit for appletvsimulator.
3882         https://bugs.webkit.org/show_bug.cgi?id=144356
3883
3884         Reviewed by Alexey Proskuryakov.
3885
3886         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
3887         make TVOS and WatchOS behave correctly.
3888
3889         * Makefile:
3890         * WebKitTestRunner/Makefile:
3891
3892 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
3893
3894         Use-after-free when invalidating WKPageForceRepaint callback
3895         https://bugs.webkit.org/show_bug.cgi?id=144401
3896         rdar://problem/20741111
3897
3898         Reviewed by Tim Horton.
3899
3900         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
3901
3902         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
3903         Don't do anything on error, because the context may be a stale pointer now.
3904
3905 2015-04-29  David Kilzer  <ddkilzer@apple.com>
3906
3907         check-webkit-style: Don't complain about returning value from Objective-C method call in header
3908         <http://webkit.org/b/144395>
3909
3910         Reviewed by Andy Estes.
3911
3912         * Scripts/webkitpy/style/checkers/cpp.py:
3913         (check_spacing): Update regex so 'return' is ignored if it
3914         precedes the whitespace and bracket.  Change category name to
3915         'whitespace/brackets'.  Add period to error message.
3916         (CppChecker): Add 'whitespace/brackets' as a category.
3917         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3918         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
3919         'CppChecker.categories' since that's where the list lives now.
3920         (CppStyleTest.test_spacing_before_brackets): Add tests for
3921         'whitespace/brackets' issues and non-issues.
3922
3923 2015-04-29  Alex Christensen  <achristensen@webkit.org>
3924
3925         Fix WinCairo bot.
3926
3927         * Scripts/webkitdirs.pm:
3928         (determinePassedConfiguration):
3929         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
3930
3931 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
3932
3933         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
3934         https://bugs.webkit.org/show_bug.cgi?id=132159
3935
3936         Reviewed by Darin Adler.
3937
3938         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
3939         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
3940
3941         * DumpRenderTree/mac/DumpRenderTree.mm:
3942         (fontWhitelist):
3943         (adjustFonts):
3944         (createWebViewAndOffscreenWindow):
3945         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3946         (WTR::activateFonts):
3947         * WebKitTestRunner/mac/TestControllerMac.mm:
3948         (WTR::allowedFontFamilySet):
3949         (WTR::systemHiddenFontFamilySet):
3950         (WTR::generateWhitelist):
3951         (WTR::TestController::platformInitializeContext):
3952
3953 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
3954
3955         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
3956         https://bugs.webkit.org/show_bug.cgi?id=144155
3957
3958         Reviewed by Andreas Kling.
3959
3960         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
3961         Make sure that test window is "visible" before each test. While there is no concrete
3962         evidence that this is the problem indeed, the behavior is consistent with what would
3963         happen for an invisible window. Also, WKTR obviously needs to do this to protect
3964         against potential buggy tests that hide the window and don't show it.
3965
3966 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3967
3968         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
3969
3970         Latest changes in the inspector UI made this test fail. We were
3971         relying that the sidebar was always visible and the first 'li'
3972         element of the inspector was the one containing the title. This is
3973         no longer true, so better use document title that is not likely
3974         to change.
3975
3976         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3977         (openRemoteDebuggingSession):
3978
3979 2015-04-29  Andres Gomez  <agomez@igalia.com>
3980
3981         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
3982
3983         * Scripts/webkitpy/common/config/contributors.json:
3984
3985 2015-04-29  Andres Gomez  <agomez@igalia.com>
3986
3987         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
3988
3989         * Scripts/webkitpy/common/config/watchlist:
3990
3991 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
3992
3993         [EFL] Allow to run the tests on the native X display
3994         https://bugs.webkit.org/show_bug.cgi?id=144247
3995
3996         Reviewed by Gyuyoung Kim.
3997
3998         Added the USE_NATIVE_XDISPLAY option for the WTR.
3999         We can select the Xorg driver if environment variable is set up before running the tests.
4000
4001         * Scripts/webkitpy/port/efl.py:
4002         (EflPort._driver_class):
4003
4004 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
4005
4006         [GTK] Add libnotify-dev in gtk install-dependencies
4007         https://bugs.webkit.org/show_bug.cgi?id=144379
4008
4009         Reviewed by Žan Doberšek.
4010
4011         * gtk/install-dependencies:
4012
4013 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
4014
4015         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
4016         https://bugs.webkit.org/show_bug.cgi?id=143001
4017
4018         Reviewed by Gyuyoung Kim.
4019
4020         * WebKitTestRunner/TestController.cpp:
4021         (WTR::shouldUseFixedLayout):
4022
4023 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
4024
4025         Increase stablility of run-benchmark script
4026         https://bugs.webkit.org/show_bug.cgi?id=144361
4027
4028         Reviewed by Ryosuke Niwa.
4029
4030         * Scripts/run-benchmark:
4031         (main):
4032         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
4033         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
4034         (GenericBenchmarkBuilder.clean):
4035         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
4036         (BenchmarkRunner.__init__):
4037         (BenchmarkRunner.execute):
4038         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4039         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
4040         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
4041         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
4042         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
4043         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4044         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
4045         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
4046         (HTTPServerDriver.fetchResult):
4047         (HTTPServerDriver):
4048         (HTTPServerDriver.killServer): Add kill server interface.
4049         (HTTPServerDriver.getReturnCode): Add get return code interface.
4050         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
4051         (SimpleHTTPServerDriver.serve):
4052         (SimpleHTTPServerDriver.fetchResult):
4053         (SimpleHTTPServerDriver):
4054         (SimpleHTTPServerDriver.killServer):
4055         (SimpleHTTPServerDriver.getReturnCode):
4056         * Scripts/webkitpy/benchmark_runner/utils.py:
4057         (forceRemove): Provide python version of 'rm -rf'.
4058
4059 2015-04-28  Sam Weinig  <sam@webkit.org>
4060
4061         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
4062         https://bugs.webkit.org/show_bug.cgi?id=144363
4063
4064         Reviewed by Alex Christensen.
4065
4066         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4067         (TestWebKitAPI::createNFAs):
4068         (TestWebKitAPI::TEST_F):
4069         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
4070         (TestWebKitAPI::countLiveNodes):
4071         (TestWebKitAPI::createNFAs):
4072         (TestWebKitAPI::buildDFAFromPatterns):
4073         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
4074
4075 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4076
4077         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
4078         https://bugs.webkit.org/show_bug.cgi?id=144304
4079
4080         Reviewed by Geoffrey Garen.
4081
4082         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
4083         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
4084         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
4085
4086 2015-04-28  Commit Queue  <commit-queue@webkit.org>
4087
4088         Unreviewed, rolling out r183514.
4089         https://bugs.webkit.org/show_bug.cgi?id=144359
4090
4091         It broke cloop test bots (Requested by mcatanzaro on #webkit).
4092
4093         Reverted changeset:
4094
4095         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
4096         https://bugs.webkit.org/show_bug.cgi?id=144304
4097         http://trac.webkit.org/changeset/183514
4098
4099 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
4100
4101         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
4102         https://bugs.webkit.org/show_bug.cgi?id=144304
4103
4104         Reviewed by Geoffrey Garen.
4105
4106         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
4107         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
4108         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
4109         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
4110
4111 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4112
4113         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
4114         https://bugs.webkit.org/show_bug.cgi?id=144319
4115
4116         Reviewed by Csaba Osztrogonác.
4117
4118         * TestWebKitAPI/CMakeLists.txt:
4119         * TestWebKitAPI/PlatformEfl.cmake:
4120
4121 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
4122
4123         Fix common typo "targetting" => "targeting"
4124         https://bugs.webkit.org/show_bug.cgi?id=144349
4125
4126         Reviewed by Daniel Bates.
4127
4128         * Scripts/webkitdirs.pm:
4129         (execMacWebKitAppForDebugging):
4130
4131 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
4132
4133         [GTK][jhbuild] Mesa build failure with llvm 3.6
4134         https://bugs.webkit.org/show_bug.cgi?id=144250
4135
4136         Reviewed by Žan Doberšek.
4137
4138         Bump the version of Mesa to 10.5.4
4139
4140         * gtk/jhbuild.modules:
4141
4142 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
4143
4144         Disable App Nap in WebKitTestRunner UI process
4145         https://bugs.webkit.org/show_bug.cgi?id=144308
4146
4147         Reviewed by Daniel Bates.
4148
4149         * WebKitTestRunner/mac/main.mm:
4150         (disableAppNapInUIProcess):
4151         (main):
4152
4153 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
4154
4155         [GTK] Update JHBuild Mesa download directory
4156         https://bugs.webkit.org/show_bug.cgi?id=144318
4157
4158         Update the download directory of Mesa module since the previous one
4159         doesn't exist any more.
4160
4161         Reviewed by Žan Doberšek.
4162
4163         * gtk/jhbuild.modules:
4164
4165 2015-04-28  Commit Queue  <commit-queue@webkit.org>
4166
4167         Unreviewed, rolling out r183477.
4168         https://bugs.webkit.org/show_bug.cgi?id=144334
4169
4170         Roll back the Mesa dependency bump in fear of uncaught
4171         regressions while the testing bots are no-op. (Requested by
4172         zdobersek on #webkit).
4173
4174         Reverted changeset:
4175
4176         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
4177         https://bugs.webkit.org/show_bug.cgi?id=144250
4178         http://trac.webkit.org/changeset/183477
4179
4180 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
4181
4182         [GTK][jhbuild] Mesa build failure with llvm 3.6
4183         https://bugs.webkit.org/show_bug.cgi?id=144250
4184
4185         Reviewed by Žan Doberšek.
4186
4187         Bump the version of Mesa to 10.5.4
4188
4189         * gtk/jhbuild.modules:
4190
4191 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
4192
4193         Add '__init__.py' and fix known bug in benchmark runner.
4194         https://bugs.webkit.org/show_bug.cgi?id=144296
4195
4196         Reviewed by Ryosuke Niwa
4197
4198         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
4199         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
4200         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4201         (BenchmarkRunner.__init__):
4202         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
4203         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
4204         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
4205
4206 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
4207
4208         More build fix.
4209
4210         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
4211         (-[AccessibilityNotificationHandler _notificationReceived:]):
4212         Use -objectForKey:, not array subscript.
4213
4214 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
4215
4216         Catch unexpected exits in DumpRenderTree
4217         https://bugs.webkit.org/show_bug.cgi?id=144288
4218
4219         Reviewed by Tim Horton.
4220
4221         * DumpRenderTree/mac/DumpRenderTree.mm:
4222         (atexitFunction):
4223         (DumpRenderTreeMain):
4224
4225 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
4226
4227         Build fix
4228
4229         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
4230         (-[AccessibilityNotificationHandler _notificationReceived:]):
4231         Use -objectForKey:, not array subscript.
4232
4233 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
4234
4235         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
4236         https://bugs.webkit.org/show_bug.cgi?id=144155
4237
4238         Reviewed by Tim Horton.
4239
4240         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
4241         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
4242         and we clearly don't want App Nap while testing.
4243
4244 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
4245
4246         [CMake] Autogenerate cmakeconfig.h.cmake
4247         https://bugs.webkit.org/show_bug.cgi?id=143997
4248
4249         Reviewed by Csaba Osztrogonác.
4250
4251         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
4252         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
4253
4254 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
4255
4256         REGRESSION(r182879): Images and video can no longer be downloaded
4257         https://bugs.webkit.org/show_bug.cgi?id=144267
4258         <rdar://problem/20702844>
4259
4260         Reviewed by Simon Fraser.
4261
4262         Revise tests to check for proper download menu state.
4263         1. Downloading a loal image should be disabled.
4264         2. Downloading a local media file should be disabled.
4265         3. Downloading non-downloadable media should be disabled.
4266
4267         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
4268         (TestWebKitAPI::TEST):
4269
4270 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
4271
4272         Merge run-launcher into run-minibrowser
4273         https://bugs.webkit.org/show_bug.cgi?id=141928
4274
4275         Reviewed by Darin Adler.
4276
4277         * Scripts/run-iexploder-tests:
4278         (runSafariWithIExploder):
4279         * Scripts/run-launcher: Removed.
4280         * Scripts/run-minibrowser:
4281         * Scripts/webkitdirs.pm:
4282         (launcherPath):
4283         * Scripts/webkitpy/port/efl.py:
4284         (EflPort.show_results_html_file):
4285         * Scripts/webkitpy/port/efl_unittest.py:
4286         (EflPortTest.test_show_results_html_file):
4287         * Scripts/webkitpy/port/gtk.py:
4288         (GtkPort.print_leaks_summary):
4289         (GtkPort.show_results_html_file):
4290         (GtkPort): Deleted.
4291         * Scripts/webkitpy/port/gtk_unittest.py:
4292         (GtkPortTest.test_show_results_html_file):
4293
4294 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
4295
4296         [buildbot] Fix the output of perf-test buildstep on timeout
4297         https://bugs.webkit.org/show_bug.cgi?id=144097
4298
4299         Reviewed by Ryosuke Niwa.
4300
4301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4302         (RunAndUploadPerfTests.getText2):
4303         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4304         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
4305         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
4306
4307 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
4308
4309         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
4310         https://bugs.webkit.org/show_bug.cgi?id=143874
4311
4312         Reviewed by Gyuyoung Kim.
4313
4314         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
4315
4316 2015-04-24  Philippe Normand  <pnormand@igalia.com>
4317
4318         [JHBuild] Move to upstream OpenWebRTC
4319         https://bugs.webkit.org/show_bug.cgi?id=144145
4320
4321         Reviewed by Carlos Garcia Campos.
4322
4323         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
4324         and add a new simple patch to gst-plugins-base, required for
4325         OpenWebRTC build.
4326         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
4327         * gtk/jhbuild.modules: Ditto.
4328         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
4329