Update the "combineModules" script to handel more LLVM metadata.
[WebKit-https.git] / Tools / ChangeLog
1 2014-11-13  Juergen Ributzka  <juergen@apple.com>
2
3         Update the "combineModules" script to handel more LLVM metadata.
4         https://bugs.webkit.org/show_bug.cgi?id=138514
5
6         Reviewed by Filip Pizlo.
7
8         * ReducedFTL/combineModules.rb:
9
10 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
11
12         Allow constructing a base PassRef with a derived Ref
13         https://bugs.webkit.org/show_bug.cgi?id=138701
14
15         Reviewed by Andreas Kling
16
17         * TestWebKitAPI/Tests/WTF/Ref.cpp:
18         (TestWebKitAPI::passWithPassRef):
19         (TestWebKitAPI::passWithPassRefPtr):
20         (TestWebKitAPI::TEST):
21
22 2014-11-05  Ada Chan  <adachan@apple.com>
23
24         Implement new plug-in API for muting plug-ins
25         https://bugs.webkit.org/show_bug.cgi?id=138105
26
27         Reviewed by Anders Carlsson.
28
29         Add a new plug-in test for the mute API.
30
31         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
32         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
33         (SetMuted::SetMuted):
34         (SetMuted::isMuted):
35         (SetMuted::cachedIsMuted):
36         (SetMuted::ScriptableObject::hasProperty):
37         (SetMuted::ScriptableObject::getProperty):
38         (SetMuted::ScriptableObject::pluginTest):
39         (SetMuted::NPP_New):
40         (SetMuted::NPP_GetValue):
41         (SetMuted::NPP_SetValue):
42
43 2014-11-12  Philippe Normand  <pnormand@igalia.com>
44
45         Unreviewed, GTK gardening.
46
47         * Scripts/run-gtk-tests:
48         (TestRunner): Skip the UserMediaBasic test because it depends on
49         constraints validation which is going to be fixed in bug #136449.
50
51 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
52
53         [GTK] Expose user script messages to GObject DOM bindings
54         https://bugs.webkit.org/show_bug.cgi?id=138411
55
56         Reviewed by Philippe Normand.
57
58         Add a test case to check that user script messages sent using the
59         DOM bindings API are also received in the UI process.
60
61         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
62         (UserScriptMessageTest::waitUntilMessageReceived):
63         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
64         (testUserContentManagerScriptMessageFromDOMBindings):
65         (beforeAll):
66         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
67         (documentLoadedCallback):
68
69 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
70
71         Unreviewed. Fix GTK+ clean build after r175930.
72
73         Partial rollout of r175930 to not build the new unit test that
74         broke clean builds in GTK+ port.
75
76         * TestWebKitAPI/PlatformGTK.cmake:
77
78 2014-09-01  Philippe Normand  <pnormand@igalia.com>
79
80         [WK2] UserMediaClient support
81         https://bugs.webkit.org/show_bug.cgi?id=123158
82
83         Reviewed by Benjamin Poulain.
84
85         Simple API test for the UserMedia permission request API. The
86         required test infrastructure is also added, inspired by the
87         Geolocation infrastructure.
88
89         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
90         Permission request.
91         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
92         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
93         (TestWebKitAPI::TEST):
94         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
95         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
96         helper method to set the permission request result without user interaction.
97         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
98         (WTR::InjectedBundle::setUserMediaPermission):
99         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
101         (WTR::TestRunner::setUserMediaPermission):
102         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
105         request handler.
106         (WTR::TestController::createOtherPage): Enable the new UserMedia
107         permission request handler.
108         (WTR::TestController::createWebViewWithOptions): Ditto.
109         (WTR::TestController::resetPreferencesToConsistentValues): Enable
110         MediaStream support, this is needed for getUserMedia.
111         (WTR::TestController::resetStateToConsistentValues): clear
112         UserMedia permissions list and flags.
113         (WTR::TestController::setUserMediaPermission): Set permission
114         request result and distpatch it.
115         (WTR::TestController::handleUserMediaPermissionRequest): Save
116         request and dispatch it.
117         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
118         Dispatch cached permission requests.
119         * WebKitTestRunner/TestController.h:
120         * WebKitTestRunner/TestInvocation.cpp:
121         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
122
123 2014-11-11  David Kilzer  <ddkilzer@apple.com>
124
125         webkit-patch --suggest-reviewers is broken with newer versions of git
126         <http://webkit.org/b/138627>
127
128         Reviewed by Michael Saboff with feedback from Daniel Bates.
129
130         * Scripts/webkitpy/common/checkout/scm/git.py:
131         (Git._changes_files_for_commit): Strip blank lines instead of
132         assuming there is always a blank line at the beginning of the
133         list.
134
135 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
136
137         DRT and WKTR touch disk cache
138         https://bugs.webkit.org/show_bug.cgi?id=138622
139
140         Reviewed by Geoffrey Garen.
141
142         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
143         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
144         because this function uses the shared cache.
145
146         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
147         Create an empty shared cache to prevent a default one from being created on disk.
148
149 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
150
151         [CSS Grid Layout] Limit the size of explicit/implicit grid
152         https://bugs.webkit.org/show_bug.cgi?id=136217
153
154         Reviewed by Andreas Kling.
155
156         Added a new unit test for the CSS parser. Right now it only checks
157         that we properly clamp the maximum number of tracks on a grid to a
158         maximum of 1 million.
159
160         * TestWebKitAPI/CMakeLists.txt:
161         * TestWebKitAPI/PlatformEfl.cmake:
162         * TestWebKitAPI/PlatformGTK.cmake:
163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
164         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
165         (TestWebKitAPI::computeNumberOfTracks): Helper function.
166         (TestWebKitAPI::TEST): Added a
167         CSSPropertyParserTest.GridTrackLimits test case.
168
169 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
170
171         webkitpy test fix after r175867
172         https://bugs.webkit.org/show_bug.cgi?id=138607
173
174         Reviewed by Philippe Normand.
175
176         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
177         (GDBCrashLogGeneratorTest.test_generate_crash_log):
178
179 2014-11-10  Philippe Normand  <pnormand@igalia.com>
180
181         webkitpy: demangle C++ symbols from crash log stderr
182         https://bugs.webkit.org/show_bug.cgi?id=138565
183
184         Reviewed by Alexey Proskuryakov.
185
186         * Scripts/webkitpy/port/linux_get_crash_log.py:
187         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
188         with c++filt.
189
190 2014-11-10  Philippe Normand  <pnormand@igalia.com>
191
192         [GTK] fix up the GDB backtrace report tool
193         https://bugs.webkit.org/show_bug.cgi?id=138564
194
195         Reviewed by Carlos Garcia Campos.
196
197         * Scripts/webkitpy/port/gtk.py:
198         (GtkPort._get_crash_log): Match the process name reported by the
199         driver with the GTK port WebProcess executable filename.
200         * Scripts/webkitpy/port/linux_get_crash_log.py:
201         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
202         program.
203         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
204         pattern to workaround the 16 characters size limit of %e.
205
206 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
207
208         Unreviewed, moved myself to the list of committers.
209
210         * Scripts/webkitpy/common/config/contributors.json:
211
212 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
213
214         [EFL] Fix the test font path after r175555.
215
216         Reviewed by Csaba Osztrogonác.
217
218         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
219
220 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
221
222         Fix the exception fuzz helper to generate targets in the correct range
223         https://bugs.webkit.org/show_bug.cgi?id=138544
224
225         Reviewed by Filip Pizlo.
226
227         Currently, the script generates exception fuzz targets in the range of
228         0..($checkCount-1). However, target 0 is never hit, while target 1 is
229         always outside of the outermost try block of the tests, which therefore
230         prints unexpected output and results in false failures when fired at.
231         Additionally, target $checkCount is never generated.
232
233         This patch fixes the script to generate targets in the range of
234         2..$checkCount.
235
236         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
237
238 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
239
240         make-passwords-json.py should generarate everything needed for testing
241         https://bugs.webkit.org/show_bug.cgi?id=138503
242
243         Reviewed by Ryosuke Niwa.
244
245         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
246         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
247         Additionally generate auth.json, credentials.cfg and committers.cfg too.
248         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
249         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
250         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
251         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
252
253 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
254
255         [GTK] generate-gtkdoc should ignore invalid files
256         https://bugs.webkit.org/show_bug.cgi?id=138542
257
258         Reviewed by Darin Adler.
259
260         * gtk/generate-gtkdoc:
261         (files_to_ignore.file_should_be_ignored): Return True to ignore
262         invalid files.
263
264 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
265
266         Delete cookies between tests
267         https://bugs.webkit.org/show_bug.cgi?id=138528
268
269         Reviewed by Sam Weinig.
270
271         * DumpRenderTree/mac/DumpRenderTree.mm:
272         (resetWebPreferencesToConsistentValues):
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::TestController::resetPreferencesToConsistentValues):
275         Do it.
276
277         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
278         (WTR::InjectedBundle::beginTesting):
279         Added a FIXME.
280
281 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
282
283         [GTK] Run layout tests using the network process
284         https://bugs.webkit.org/show_bug.cgi?id=138428
285
286         Reviewed by Martin Robinson.
287
288         Shared secondary process is the default in the GTK+ port, but we
289         should run the tests using the network process to ensure
290         everything works with the network process. In the future, the
291         shared secondary process model might be a special case of multiple
292         processes with 1 as maximum number of processes, but always using
293         the network process.
294
295         * WebKitTestRunner/TestController.cpp:
296         (WTR::TestController::initialize):
297
298 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
299
300         [GTK] Allow to create a view with a related page in WTR
301         https://bugs.webkit.org/show_bug.cgi?id=138501
302
303         Reviewed by Martin Robinson.
304
305         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
306         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
307         related page to WKViewCreate.
308         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
309         (WTR::PlatformWebView::PlatformWebView): Pass the given related
310         page to WKViewCreate.
311
312 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
313
314         WTR crashes after running a test when NetworkProcess enabled
315         https://bugs.webkit.org/show_bug.cgi?id=138500
316
317         Reviewed by Alexey Proskuryakov.
318
319         WebNotificationProvider destructor is calling
320         WKNotificationManagerSetProvider, but m_notificationManager is
321         null because removeNotificationManager was already called.
322
323         * WebKitTestRunner/WebNotificationProvider.cpp:
324         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
325         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
326
327 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
328
329         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
330         regarding incorrect call to PatchAnalysisTask.report_failure
331         https://bugs.webkit.org/show_bug.cgi?id=138229
332
333         Reviewed by Daniel Bates.
334
335         * Scripts/webkitpy/common/net/layouttestresults.py:
336         Makes sure test_results returns a list.
337         (LayoutTestResults.test_results):
338         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
339         Makes unit tests also check to make sure
340         task.results_from_patch_test_run() and
341         task.results_from_test_run_without_patch return instances of
342         LayoutTestResults.
343         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
344         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
345         Condenses duplicate code into _should_defer_patch_or_throw, and
346         removes the now-unused _clean_tree_results member.
347         (PatchAnalysisTask.__init__):
348         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
349         (PatchAnalysisTask._should_defer_patch_or_throw):
350         (PatchAnalysisTask._test_patch):
351         (PatchAnalysisTask.results_from_patch_test_run):
352         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
353         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
354         Removes needless call to results_from_test_run_without_patch
355         (AbstractEarlyWarningSystem._failing_tests_message):
356         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
357         Changes order of test failure messages to be in the order that they
358         appear.
359         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
360         * Scripts/webkitpy/tool/commands/queues.py:
361         Removes needless call to results_from_test_run_without_patch.
362         (CommitQueue._failing_tests_message):
363         * Scripts/webkitpy/tool/commands/queues_unittest.py:
364         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
365
366 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
367
368         Unreviewed. Reorder my e-mail addresses in contributors.json
369
370         * Scripts/webkitpy/common/config/contributors.json:
371
372 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
373
374         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
375         https://bugs.webkit.org/show_bug.cgi?id=138475
376
377         Reviewed by Ryosuke Niwa.
378
379         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
380         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
381         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
382         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
383
384         * Scripts/webkitpy/common/checkout/scm/git.py:
385         (Git._run_git_svn_find_rev):
386         Add comment mentioning that svn_revisions need to begin with 'r'.
387         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
388         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
389         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
390
391 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
392
393         [GTK] Add context menu API to Web Process Extensions
394         https://bugs.webkit.org/show_bug.cgi?id=138311
395
396         Reviewed by Gustavo Noronha Silva.
397
398         Add tests cases for WebKitWebPage::context-menu signal.
399
400         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
401         (testContextMenuWebExtensionMenu):
402         (testContextMenuWebExtensionNode):
403         (beforeAll):
404         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
405         (serializeContextMenu):
406         (serializeNode):
407         (contextMenuCallback):
408         (pageCreatedCallback):
409
410 2014-11-06  Commit Queue  <commit-queue@webkit.org>
411
412         Unreviewed, rolling out r175690.
413         https://bugs.webkit.org/show_bug.cgi?id=138460
414
415         We are not ready to run layout tests using the network process
416         yet (Requested by KaL on #webkit).
417
418         Reverted changeset:
419
420         "[GTK] Run layout tests using the network process"
421         https://bugs.webkit.org/show_bug.cgi?id=138428
422         http://trac.webkit.org/changeset/175690
423
424 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         [GTK] Run layout tests using the network process
427         https://bugs.webkit.org/show_bug.cgi?id=138428
428
429         Reviewed by Martin Robinson.
430
431         Shared secondary process is the default in the GTK+ port, but we
432         should run the tests using the network process to ensure
433         everything works with the network process. In the future, the
434         shared secondary process model might be a special case of multiple
435         processes with 1 as maximum number of processes, but always using
436         the network process.
437
438         * WebKitTestRunner/TestController.cpp:
439         (WTR::TestController::initialize):
440
441 2014-11-05  Dan Bernstein  <mitz@apple.com>
442
443         Remove the unused deletion UI feature
444         https://bugs.webkit.org/show_bug.cgi?id=138442
445
446         Rubber-stamped by Alexey Proskuryakov.
447
448         * DumpRenderTree/mac/EditingDelegate.mm:
449         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
450         delegate method that’s been removed.
451
452 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
453
454         fast/dom/remove-body-during-body-replacement2.html fails on WK2
455         https://bugs.webkit.org/show_bug.cgi?id=138334
456
457         Reviewed by Anders Carlsson.
458
459         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
460         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
461         -makeFirstResponder calls, which may or may not be needed for other reasons, but
462         it also needs to reset internal focus explicitly.
463
464         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
465         WebKit behavior appears wrong, but it matches Firefox.
466
467         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
468         (WTR::InjectedBundlePage::resetAfterTest):
469
470 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
471
472         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
473         https://bugs.webkit.org/show_bug.cgi?id=137862
474
475         Reviewed by Gustavo Noronha Silva.
476
477         Add a test case to check that WebKitWebResource::failed-with-tls-errors
478         is emitted when a subresource load fails due to TLS errors.
479
480         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
481         (TLSSubresourceTest::resourceLoadStartedCallback):
482         (TLSSubresourceTest::TLSSubresourceTest):
483         (TLSSubresourceTest::subresourceFailedCallback):
484         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
485         (TLSSubresourceTest::subresourceLoadStarted):
486         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
487         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
488         (testSubresourceLoadFailedWithTLSErrors):
489         (httpsServerCallback):
490         (httpServerCallback):
491         (beforeAll):
492
493 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
494
495         Build fix for some compiler versions.
496
497         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
498         unhappy because this is a getter, and these shouldn't have side effects.
499
500 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
501
502         Add a method for performing cherrypick-merges.
503         https://bugs.webkit.org/show_bug.cgi?id=138375
504
505         Reviewed by Ryosuke Niwa.
506
507         Adds support for cherrypick-merges.
508
509         * Scripts/webkitpy/common/checkout/scm/git.py:
510         (Git.cherrypick_merge): Added.
511
512 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
513
514         Add a way to ascertain the SVN URL associated with a Git branch.
515         https://bugs.webkit.org/show_bug.cgi?id=138374
516
517         Reviewed by Ryosuke Niwa.
518
519         The svn_url method returns the SVN URL associated with the current Git branch.
520
521         * Scripts/webkitpy/common/checkout/scm/git.py:
522         (Git.svn_url): Added.
523
524 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
525
526         Add the ability to search for modifications that are staged for commit.
527         https://bugs.webkit.org/show_bug.cgi?id=138373
528
529         Reviewed by Ryosuke Niwa and Daniel Bates.
530
531         This makes is easy to do identify files that require merge post-processing,
532         in addition to stand-alone utility.
533
534         * Scripts/webkitpy/common/checkout/scm/git.py:
535         (Git.modifications_staged_for_commit): Added.
536
537 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
538
539         Add a branch keyword argument to _run_git_svn_find_rev.
540         https://bugs.webkit.org/show_bug.cgi?id=138372
541
542         Reviewed by Ryosuke Niwa.
543
544         The addition of this keyword argument allows clients to determine the Git hash
545         of commits made on an SVN branch, provided that branch has been fetched locally.
546
547         * Scripts/webkitpy/common/checkout/scm/git.py:
548         (Git._run_git_svn_find_rev):
549         Add a branch keyword argument that is added to the end of the command, if present.
550
551 2014-11-04  Chris Dumez  <cdumez@apple.com>
552
553         Add ptr() method to Ref class
554         https://bugs.webkit.org/show_bug.cgi?id=138361
555
556         Reviewed by Darin Adler.
557
558         Use the new Ref::ptr() method.
559
560         * TestWebKitAPI/Tests/WTF/Ref.cpp:
561         (TestWebKitAPI::TEST):
562
563 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
564
565         [jhbuild] Make it possible to build GTK/EFL in same repository
566         https://bugs.webkit.org/show_bug.cgi?id=137448
567
568         Reviewed by Martin Robinson.
569
570         * Scripts/webkitdirs.pm:
571         (getJhbuildPath):
572         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
573         (getPlatformFontsPath):
574         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
575         (WTR::getFontsPath):
576         * jhbuild/jhbuild-wrapper:
577         (determine_platform):
578         (install_jhbuild):
579         * jhbuild/jhbuildrc_common.py:
580         (init):
581
582 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
583
584         [EFL] Bump LLVM to version 3.5.0
585         https://bugs.webkit.org/show_bug.cgi?id=138312
586
587         Reviewed by Csaba Osztrogonác.
588
589         * efl/jhbuild.modules:
590         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
591         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
592
593 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
594
595         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
596         https://bugs.webkit.org/show_bug.cgi?id=138257
597
598         Reviewed by Tim Horton.
599         
600         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
601         the user to toggle region page overlays on and off. Two overlays are available,
602         for the non-fast scrollable region, and the region of element with wheel
603         event handlers.
604
605         * MiniBrowser/mac/SettingsController.h:
606         * MiniBrowser/mac/SettingsController.m:
607         (-[SettingsController _populateMenu]):
608         (-[SettingsController validateMenuItem:]):
609         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
610         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
611         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
612         (-[SettingsController toggleDebugOverlay:]):
613         (-[SettingsController debugOverlayVisible:]):
614         * MiniBrowser/mac/WK2BrowserWindowController.m:
615         (-[WK2BrowserWindowController didChangeSettings]):
616
617 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
618
619         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
620         https://bugs.webkit.org/show_bug.cgi?id=138323
621
622         Reviewed by Zalan Bujtas.
623
624         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
625
626 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
627
628         [ninja] Don't remove response files for verbose builds
629         https://bugs.webkit.org/show_bug.cgi?id=137816
630
631         Reviewed by Csaba Osztrogonác.
632
633         * Scripts/webkitdirs.pm:
634         (determineNinjaVersion):
635         (buildCMakeGeneratedProject):
636
637 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
638
639         [GTK] Fix the build of FTL JIT
640         https://bugs.webkit.org/show_bug.cgi?id=138298
641
642         Reviewed by Carlos Garcia Campos.
643
644         * gtk/jhbuild-optional.modules:
645         Bump up LLVM version to 3.5.0 release and apply patches.
646         * gtk/patches/llvm-elf-add-stackmaps.patch:
647         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
648         trunk.
649         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
650         Added. Ensures that PC-relative relocations in EH frames are not
651         truncated to 32 bits on x86_64.
652
653 2014-10-31  Michael Saboff  <msaboff@apple.com>
654
655         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
656         https://bugs.webkit.org/show_bug.cgi?id=138268
657
658         Reviewed by Andreas Kling.
659
660         Added a --arch and --os option to set or override the values that are
661         normally computed based on examining the JavaScriptCore we want to test.
662
663         * Scripts/run-jsc-stress-tests:
664
665 2014-10-31  Dan Bernstein  <mitz@apple.com>
666
667         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
668         https://bugs.webkit.org/show_bug.cgi?id=138259
669
670         Reviewed by Geoff Garen.
671
672         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
673         going to be empty to silence the warning.
674
675 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
676
677         [GTK] Support script message handlers WebKitUserContentManager
678         https://bugs.webkit.org/show_bug.cgi?id=133730
679
680         Reviewed by Carlos Garcia Campos.
681
682         Support user script message handlers in WebKitUserContentManager.
683         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
684         an option is added to the CMake build files. The option is disabled
685         globally by default, and the WebKitGTK port enables it. On the API
686         level, two new methods to register and unregister names are provided
687         in the "window.webkit" namespace, and on message reception the
688         "WebKitUserContentManager::script-message-received" signal is
689         emitted, using the registered names as signal detail.
690
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
692         Add test case for user script message handlers.
693         (scriptMessageReceived):
694         (testUserContentManagerScriptMessageReceived):
695         (beforeAll):
696
697 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
698
699         bisect-builds should support WebKit clients other than Safari
700         https://bugs.webkit.org/show_bug.cgi?id=138225
701
702         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
703
704         The -a / --application optional argument allows the user to specify which application (or application bundle)
705         should be run against the WebKit nightly builds.
706
707         Reviewed by David Kilzer.
708
709         * Scripts/bisect-builds:
710         Swap out $safariPath for the more general $applicationPath
711         Leave --safari-path as a commandline option for backwards compatibility
712         (mountAndRunNightly):
713         Use File::Spec->cat correctly (one directory per argument)
714         Use open --wait-apps instead of running the target application directly
715
716 2014-10-30  Dana Burkart  <dburkart@apple.com>
717
718         <rdar://problem/18821260> Perpare for the mysterious future
719
720         Reviewed by Lucas Forschler.
721
722         * DumpRenderTree/mac/Configurations/Base.xcconfig:
723         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
724         * LayoutTestRelay/Configurations/Base.xcconfig:
725         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
726         * MiniBrowser/Configurations/Base.xcconfig:
727         * MiniBrowser/Configurations/DebugRelease.xcconfig:
728         * TestWebKitAPI/Configurations/Base.xcconfig:
729         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
730         * WebKitLauncher/Configurations/Base.xcconfig:
731         * WebKitTestRunner/Configurations/Base.xcconfig:
732         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
733
734 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
735
736         Update safariVersion to safariVersionString
737         https://bugs.webkit.org/show_bug.cgi?id=138193
738
739         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
740         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
741
742         Rubber-stamped by David Kilzer.
743
744         * Scripts/bisect-builds:
745         (makeNightlyList):
746         Compare safariVersionString to a string literal, instead of safariVersion.
747
748 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
749
750         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
751         https://bugs.webkit.org/show_bug.cgi?id=137775
752
753         Reviewed by Carlos Garcia Campos.
754
755         * MiniBrowser/gtk/BrowserWindow.c:
756         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
757         (browser_window_init):
758
759 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
760
761         CommitQueue and EWS should reject any patches that result in consistent test
762         failures that aren't present on the tree.
763         https://bugs.webkit.org/show_bug.cgi?id=138184
764
765         Reviewed by Alexey Proskuryakov.
766
767         * Scripts/webkitpy/layout_tests/models/test_results.py:
768         Adds a simple hashing function to allow for set operations to handle
769         TestResult objects properly.
770         (TestResult.__hash__):
771         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
772         Adds one unit test, and modifies others to agree with the notion that
773         patches that introduce new test failures (but also have flakyness)
774         should be rejected rather than spin.
775         (MockCommitQueue.report_flaky_tests):
776         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
777         (test_double_flaky_test_failure):
778         (test_two_flaky_tests):
779         (test_very_flaky_patch):
780         (test_very_flaky_patch_with_some_tree_redness):
781         (test_different_test_failures):
782         (test_different_test_failures_with_some_tree_redness):
783         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
784         (test_mildly_flaky_patch):
785         (test_mildly_flaky_patch_with_some_tree_redness):
786         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
787         Makes PatchAnalysisTask reject said patches.
788         (PatchAnalysisTask._test_patch):
789
790 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
791
792         WinCairoRequirements.zip cannot be downloaded from dropbox
793         https://bugs.webkit.org/show_bug.cgi?id=138113
794
795         Reviewed by Alexey Proskuryakov.
796
797         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
798
799 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
800
801         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
802         https://bugs.webkit.org/show_bug.cgi?id=138193
803
804         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
805         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
806
807         It also does a bit of refactoring, including distinguishing between versions and version strings and
808         saving versions to local variables instead of using eval in each conditional.
809
810         Reviewed by David Kilzer.
811
812         * Scripts/bisect-builds:
813         (makeNightlyList):
814         Restrict the set of nightlies to r174650 and above when running Yosemite.
815         Restrict the set of nightlies to r157846 and above when running Mavericks.
816         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
817
818 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
819
820         [EFL] build-webkit should try harder to avoid re-running cmake
821         https://bugs.webkit.org/show_bug.cgi?id=137949
822
823         Reviewed by Martin Robinson.
824
825         * Scripts/webkitdirs.pm:
826         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
827         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
828
829 2014-10-28  Daniel Bates  <dabates@apple.com>
830
831         Unify logic in RunTests.run() to run the Python unit tests
832         https://bugs.webkit.org/show_bug.cgi?id=138160
833
834         Reviewed by Martin Robinson.
835
836         Unify the interactive and non-interactive code path for running the Python unit tests
837         in step RunTests so as to remove duplicate code to compute the the path to the script
838         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
839
840         No new tests since no functionality was changed.
841
842         * Scripts/webkitpy/port/base.py:
843         (Port.python_unittest_results_directory):
844         * Scripts/webkitpy/tool/steps/runtests.py:
845         (RunTests.run):
846
847 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
848
849         Make runtest.py call test-webkitpy with the --json flag when in
850         non-interactive mode.
851         https://bugs.webkit.org/show_bug.cgi?id=137667
852
853         Reviewed by Daniel Bates.
854
855         * Scripts/webkitpy/port/base.py:
856         Adds the python_unittest_results_directory method.
857         (Port.python_unittest_results_directory):
858         * Scripts/webkitpy/tool/steps/runtests.py:
859         Changes RunTests to call test-webkitpy with the --json flag if the
860         --non-interactive flag is set.
861         (RunTests):
862         (RunTests.run):
863
864 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
865
866         import-w3c-tests should use re.escape() wherever it's handling file paths
867         https://bugs.webkit.org/show_bug.cgi?id=137934
868
869         This patch adds re.escape() to a few places where we're doing string
870         conversions. This prevents errors when attribute values coincidentally
871         have character sequences that can be interpreted as regular expressions.
872
873         Reviewed by Bem Jones-Bey.
874
875         * Scripts/webkitpy/w3c/test_converter.py:
876         (_W3CTestConverter.convert_attributes_if_needed):
877
878 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
879
880         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
881         https://bugs.webkit.org/show_bug.cgi?id=138130
882
883         Reviewed by Csaba Osztrogonác.
884
885         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
886
887 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
888
889         Fix link to Arch Linux Wiki
890         https://bugs.webkit.org/show_bug.cgi?id=138010
891
892         Reviewed by Benjamin Poulain.
893
894         * gtk/install-dependencies:
895
896 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
897
898         Test regressions are not detected when image result is missing
899         https://bugs.webkit.org/show_bug.cgi?id=138070
900
901         Reviewed by Simon Fraser.
902
903         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
904         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
905         Count these as regressions, not as flaky tests.
906
907         * Scripts/webkitpy/port/test.py:
908         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
909         Test it.
910
911 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
912
913         Add Conrad Shultz to the contributors list.
914
915         * Scripts/webkitpy/common/config/contributors.json:
916
917 2014-10-24  Dan Bernstein  <mitz@apple.com>
918
919         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
920         https://bugs.webkit.org/show_bug.cgi?id=138046
921
922         Reviewed by Alexey Proskuryakov.
923
924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
925         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
926         401. Otherwise, we’ll retry normally in 45 seconds.
927
928 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
929
930         [GTK] Implement is_selected method on WebKitHitTestResult
931         https://bugs.webkit.org/show_bug.cgi?id=137110
932
933         Reviewed by Tim Horton.
934
935         Add tests for new context SELECTION on WebKitHitTestResult.
936
937         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
938         (testContextMenuDefaultMenu):
939         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
940         (testWebViewMouseTarget):
941
942 2014-10-23  Roger Fong  <roger_fong@apple.com>
943
944         [Win] Skip failing JSC tests following r175078
945         https://bugs.webkit.org/show_bug.cgi?id=130967.
946
947         * Scripts/run-javascriptcore-tests:
948
949 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
950
951         commitqueuetask_unittest.py should be made more concise.
952         https://bugs.webkit.org/show_bug.cgi?id=137985
953
954         Reviewed by Alexey Proskuryakov.
955
956         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
957         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
958         (MockCommitQueue.__init__):
959         (MockCommitQueue.report_flaky_tests):
960         (MockCommitQueue):
961         (MockCommitQueue.get_reported_flaky_tests):
962         (MockSimpleTestPlanCommitQueue.__init__):
963         (MockSimpleTestPlanCommitQueue.run_command):
964         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
965         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
966         (test_land_failure):
967         (test_failed_archive):
968         (test_double_flaky_test_failure):
969         (test_test_failure):
970         (test_red_test_failure):
971         (test_very_red_tree_retry):
972         (test_red_tree_patch_rejection):
973         (test_one_flaky_test):
974         (test_tree_more_red_than_patch):
975         (MockCommitQueue.test_results): Deleted.
976         (test_simple_flaky_test_failure): Deleted.
977         (_expect_validate): Deleted.
978         (_expect_validate.MockDelegate): Deleted.
979         (_expect_validate.MockDelegate.refetch_patch): Deleted.
980         (_expect_validate.MockDelegate.expected_failures): Deleted.
981         (_mock_patch): Deleted.
982         (test_validate): Deleted.
983         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
984         Fixes a bug that slipped through the cracks prior to this change.
985         (PatchAnalysisTask._test_patch):
986
987 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
988
989         Flakiness dashboard should support OS X Yosemite
990         https://bugs.webkit.org/show_bug.cgi?id=137986
991
992         Reviewed by Ryosuke Niwa.
993
994         * TestResultServer/app.yaml:
995         * TestResultServer/static-dashboards/builders.jsonp:
996         * TestResultServer/static-dashboards/flakiness_dashboard.js:
997
998 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
999
1000         commitqueuetask should include more tests to ensure that the behavior
1001         of PatchAnalysisTask._test_patch() is well defined
1002         https://bugs.webkit.org/show_bug.cgi?id=137977
1003
1004         Reviewed by Alexey Proskuryakov.
1005
1006         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1007         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1008         and more readable to define tests that are meant to test the behaviour
1009         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1010         (FailingTestCommitQueue.test_results):
1011         (PatchAnalysisResult):
1012         (MockSimpleTestPlanCommitQueue):
1013         (MockSimpleTestPlanCommitQueue.__init__):
1014         (MockSimpleTestPlanCommitQueue.run_command):
1015         (MockSimpleTestPlanCommitQueue._mock_test_result):
1016         (MockSimpleTestPlanCommitQueue.test_results):
1017         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1018         (test_flaky_test_failure):
1019         (test_failed_archive):
1020         (test_two_flaky_tests):
1021         (test_one_flaky_test):
1022         (test_very_flaky_patch):
1023         (test_very_flaky_patch_with_some_tree_redness):
1024         (test_different_test_failures):
1025         (test_different_test_failures_with_some_tree_redness):
1026         (test_mildly_flaky_patch):
1027         (test_mildly_flaky_patch_with_some_tree_redness):
1028         (test_tree_more_red_than_patch):
1029
1030 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1031
1032         PatchAnalysisTask._test_patch() needs refactoring
1033         https://bugs.webkit.org/show_bug.cgi?id=137904
1034
1035         Reviewed by Alexey Proskuryakov.
1036
1037         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1038         Fixes several small bugs, and makes minor changes to accomodate the
1039         changes in PatchAnalysisTask.
1040         (MockCommitQueue.refetch_patch):
1041         (MockCommitQueue.test_results):
1042         (test_flaky_test_failure):
1043         (test_failed_archive):
1044         (test_very_red_tree_retry):
1045         (_expect_validate.MockDelegate.refetch_patch):
1046         (MockCommitQueue.expected_failures): Deleted.
1047         (_expect_validate.MockDelegate.expected_failures): Deleted.
1048         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1049         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1050         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1051         Removes the unexpected_failures member, adds the _clean_tree_results
1052         member, adds a helper function for _test_patch, and refactors
1053         _test_patch to be more readable.
1054         (PatchAnalysisTask.__init__):
1055         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1056         (PatchAnalysisTask._test_patch):
1057         (PatchAnalysisTask.results_from_test_run_without_patch):
1058         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1059         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1060         (AbstractEarlyWarningSystem.begin_work_queue):
1061         (AbstractEarlyWarningSystem._failing_tests_message):
1062         (AbstractEarlyWarningSystem.command_failed):
1063         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1064         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1065         Makes changes to accomodate the changes made to PatchAnalysisTask.
1066         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1067         * Scripts/webkitpy/tool/commands/perfalizer.py:
1068         Removes Perfalizer's dependancy on ExpectedFailures. 
1069         (PerfalizerTask.refetch_patch):
1070         (PerfalizerTask.expected_failures): Deleted.
1071         * Scripts/webkitpy/tool/commands/queues.py:
1072         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1073         initializer to allow for mock injection.
1074         (CommitQueue.__init__):
1075         (CommitQueue.begin_work_queue):
1076         (CommitQueue.process_work_item):
1077         (CommitQueue._failing_tests_message):
1078         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1079         Removes dependancy on ExpectedFailures, and instead uses mock
1080         injection.
1081         (MockCommitQueueTask):
1082         (MockCommitQueueTask.results_from_patch_test_run):
1083         (MockCommitQueueTask.results_from_test_run_without_patch):
1084         (mock_run_webkit_patch):
1085
1086 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
1087
1088         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1089         https://bugs.webkit.org/show_bug.cgi?id=136736
1090
1091         Reviewed by Gyuyoung Kim.
1092
1093         * MiniBrowser/efl/main.c:
1094         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1095         (window_create):
1096
1097 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1098
1099         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1100         https://bugs.webkit.org/show_bug.cgi?id=137884
1101
1102         Reviewed by Gustavo Noronha Silva.
1103
1104         Move InputMethodFilter test from WebCore tests to WebKit2 tests
1105         and adapt it to use the new InputMethodFilter WebKit class. Instead
1106         of having virtual methods just for testing, it has a testing mode
1107         that logs the events.
1108
1109         * TestWebKitAPI/PlatformGTK.cmake:
1110         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1111         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1112         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1113         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1114         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1115         (TestWebKitAPI::TEST):
1116         (TestWebKitAPI::temporaryGetPreeditStringOverride):
1117         (TestWebKitAPI::temporaryResetOverride):
1118         (TestWebKitAPI::verifyCanceledComposition):
1119
1120 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
1121
1122         build.webkit.org/dashboard: Cannot click on green tester bubbles
1123         https://bugs.webkit.org/show_bug.cgi?id=137909
1124
1125         Reviewed by Darin Adler.
1126
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1128         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1129
1130 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
1131
1132         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1133         https://bugs.webkit.org/show_bug.cgi?id=137932
1134
1135         Reviewed by Simon Fraser.
1136
1137         This is the first step in moving over to native Windows rendering for our layout tests.
1138         Once this change lands, approximately 300 tests will start failing on Windows. I will
1139         rebaseline these changes against our test hardware and update this bug with the
1140         commits related to that work.
1141
1142         * DumpRenderTree/win/DumpRenderTree.cpp:
1143         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1144         we use native Windows drawing style.
1145
1146 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1147
1148         Fix FTL Native Inlining for EFL
1149         https://bugs.webkit.org/show_bug.cgi?id=137774
1150
1151         Reviewed by Michael Saboff.
1152
1153         Added Clang as an optional module to jhbuild.
1154
1155         * efl/jhbuild.modules:
1156
1157 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1158
1159         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1160         https://bugs.webkit.org/show_bug.cgi?id=137832
1161
1162         Reviewed by Carlos Garcia Campos.
1163
1164         Ensure each test sets the TLS errors policy that it really needs.
1165         Have each test except testTLSErrorsPolicy stash and restore the original
1166         TLS errors policy. Update testTLSErrorsPolicy to account for the new
1167         default policy.
1168
1169         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1170         (testSSL):
1171         (testInsecureContent):
1172         (testTLSErrorsPolicy):
1173         (testTLSErrorsRedirect):
1174         (testTLSErrorsHTTPAuth):
1175         (testLoadFailedWithTLSErrors):
1176         (beforeAll):
1177
1178 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         Unreviewed. Unskip inspector server unit tests.
1181
1182         They should pass now.
1183
1184         * Scripts/run-gtk-tests:
1185         (TestRunner):
1186
1187 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1188
1189         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1190         https://bugs.webkit.org/show_bug.cgi?id=132044
1191
1192         Reviewed by Brian Burg.
1193
1194         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1195         (openRemoteDebuggingSession): Remove trailing slash when
1196         concatenating base inspector URL with the page, because the
1197         inspector returns the relative paths with a leading slash.
1198
1199 2014-10-20  Tanay C  <tanay.c@samsung.com>
1200
1201         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1202         https://bugs.webkit.org/show_bug.cgi?id=137023
1203
1204         Reviewed by Gyuyoung Kim.
1205
1206         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1207         (search_box_show): Modified.
1208         (search_box_hide): Modified.
1209         (on_search_field_activated): Modified.
1210         (on_search_backward_button_clicked): Modified.
1211         (on_search_forward_button_clicked): Modified.
1212         (on_search_case_option_changed): Added.
1213         (on_search_word_start_option_changed): Added.
1214         (window_create): Modified.
1215
1216 2014-10-20  Tanay C  <tanay.c@samsung.com>
1217
1218         [GTK][Minibrowser] Escape key does not hide the search box
1219         https://bugs.webkit.org/show_bug.cgi?id=137734
1220
1221         Reviewed by Philippe Normand.
1222
1223         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1224         (stopPageLoad): Modified.
1225
1226 2014-10-18  Antti Koivisto  <antti@apple.com>
1227
1228         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1229         https://bugs.webkit.org/show_bug.cgi?id=137855
1230
1231         Reviewed by Dan Bernstein.
1232
1233         Test and warn if the dumped response mime type differs from the platform response mime type.
1234
1235         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1236         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1237         (WTR::InjectedBundlePage::platformResponseMimeType):
1238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1239         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1240         (WTR::InjectedBundlePage::platformResponseMimeType):
1241
1242 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
1243
1244         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1245         https://bugs.webkit.org/show_bug.cgi?id=137835
1246
1247         Reviewed by Andreas Kling.
1248
1249         * Scripts/run-inspector-perf-tests.py: Removed.
1250         This script is stale, as PerformanceTests/inspector no longer exists.
1251
1252 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1253
1254         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1255
1256         * Scripts/webkitpy/port/ios.py:
1257         (IOSSimulatorPort.default_baseline_search_path):
1258
1259 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1260
1261         [iOS] Simplify test fallback paths for iOS Simulator testing
1262         https://bugs.webkit.org/show_bug.cgi?id=137830
1263
1264         Reviewed by Zalan Bujtas.
1265         
1266         Make the fallback paths be:
1267             ios-simulator -> generic
1268             ios-simulator-wk2->ios-simulator -> generic
1269         
1270         so don't include mac in the fallback path. Also remove the
1271         version handling for simplicity.
1272
1273         * Scripts/webkitpy/port/ios.py:
1274         (IOSSimulatorPort):
1275         (IOSSimulatorPort.default_baseline_search_path):
1276
1277 2014-10-17  Dana Burkart  <dburkart@apple.com>
1278
1279         Fix typos in the dashboard config file.
1280
1281         Unreviewed.
1282
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1284         (WebKitBuildbot):
1285
1286 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
1287
1288         [Win] Allow WinLauncher to specify Custom User Agent strings
1289         https://bugs.webkit.org/show_bug.cgi?id=137828
1290
1291         Reviewed by Dean Jackson.
1292
1293         * WinLauncher/Common.cpp: Add support for custom user agent strings.
1294         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
1295         and set the user agent strings.
1296         * WinLauncher/WinLauncher.h:
1297         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
1298         resources and dialog for setting custom User Agent strings.
1299         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1300
1301 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
1302
1303         [iOS] Turn off font autosizing for iOS WebKitTestRunner
1304         https://bugs.webkit.org/show_bug.cgi?id=137806
1305
1306         Reviewed by Sam Weinig.
1307
1308         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
1309         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
1310         to disable font autosizing.
1311         
1312         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
1313         test controller to set platform-specific prefs.
1314
1315         * WebKitTestRunner/TestController.cpp:
1316         (WTR::TestController::resetPreferencesToConsistentValues):
1317         (WTR::TestController::platformResetPreferencesToConsistentValues):
1318         * WebKitTestRunner/TestController.h:
1319         * WebKitTestRunner/ios/TestControllerIOS.mm:
1320         (WTR::TestController::platformResetPreferencesToConsistentValues):
1321         * WebKitTestRunner/mac/TestControllerMac.mm:
1322         (WTR::TestController::platformResetPreferencesToConsistentValues):
1323
1324 2014-10-16  Dan Bernstein  <mitz@apple.com>
1325
1326         OSObjectPtr is missing leakRef()
1327         https://bugs.webkit.org/show_bug.cgi?id=137798
1328
1329         Reviewed by Sam Weinig.
1330
1331         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1332         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
1333
1334 2014-10-16  Lucas Forschler  <lforschler@apple.com>
1335
1336         Update target platform to remove Leopard, Snow Leopard, Lion.
1337         Add Yosemite. 
1338         
1339         Unreviewed.
1340
1341         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1342         (_should_file_trigger_build):
1343
1344 2014-10-16  David Kilzer  <ddkilzer@apple.com>
1345
1346         commit-queue: fails to replace OO-PS! with reviewer name
1347         <http://webkit.org/b/137795>
1348
1349         Reviewed by Alexey Proskuryakov.
1350
1351         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1352         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
1353         email addresses to unauthenticated page loads, so we must always
1354         authenticate before getting bug data so we get full email
1355         addresses.
1356
1357 2014-10-16  David Kilzer  <ddkilzer@apple.com>
1358
1359         commit-queue: fails to close bugs after successfully landing patches
1360         <http://webkit.org/b/137794>
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1365         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
1366         tell Mechanize to use the second <textarea> on the page with
1367         name="comment".
1368
1369 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
1370
1371         [Win] Update DRT to match Mac Logic
1372         https://bugs.webkit.org/show_bug.cgi?id=137787
1373
1374         Reviewed by Dean Jackson.
1375
1376         * DumpRenderTree/win/DumpRenderTree.cpp:
1377         (initialize): 0 -> nullptr
1378         (runTest): Initialize MSG structure before using.
1379         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
1380         Also, cleanly shut down COM when exiting.
1381         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1382         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
1383         header and add printf to match Mac.
1384         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
1385         * DumpRenderTree/win/FrameLoadDelegate.h:
1386         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
1387         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
1388         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1389         (isLocalhost): Added.
1390         (hostIsUsedBySomeTestsToGenerateError): Added.
1391         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
1392         of certain error and redirect host names.
1393         * DumpRenderTree/win/UIDelegate.cpp:
1394         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
1395         anything should be output to the console. This modifies behavior to match the Mac.
1396         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1397         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1398         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1399         (UIDelegate::webViewAddMessageToConsole): Ditto.
1400         * WinLauncher/PageLoadTestClient.cpp:
1401         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
1402         added last week.
1403
1404 2014-10-16  Commit Queue  <commit-queue@webkit.org>
1405
1406         Unreviewed, rolling out r174754.
1407         https://bugs.webkit.org/show_bug.cgi?id=137789
1408
1409         Speculative fix for Windows test was ineffective. (Requested
1410         by rfong on #webkit).
1411
1412         Reverted changeset:
1413
1414         "[Windows] Add some more logging to debug Windows test
1415         issues."
1416         http://trac.webkit.org/changeset/174754
1417
1418 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1419
1420         Unreviewed, add myself to CoordinatedGraphics watchers.
1421
1422         * Scripts/webkitpy/common/config/watchlist:
1423
1424 2014-10-15  Roger Fong  <roger_fong@apple.com>
1425
1426         [Windows] Speculative Windows test fix.
1427
1428         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
1429
1430 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
1431
1432         import-w3c-test rewrites relative src paths in ref files incorrectly
1433         https://bugs.webkit.org/show_bug.cgi?id=137586
1434
1435         This patch fixes a bug in test_converter.py where src paths were getting 
1436         rewritten as ../../some-path instead of <script src="../../some-path>". 
1437         It also adds support for rewriting src paths in style  elements, which was 
1438         missing before and it adds tests for this case.
1439
1440         Reviewed by Bem Jones-Bey.
1441
1442         * Scripts/webkitpy/w3c/test_converter.py:
1443         (_W3CTestConverter.convert_attributes_if_needed):
1444         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1445         (test_convert_attributes_if_needed):
1446         (verify_reference_relative_paths):
1447
1448 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
1449
1450         Add --json flag to test-webkitpy to emit JSON formatted test results
1451         to stdout
1452         https://bugs.webkit.org/show_bug.cgi?id=137353
1453
1454         Reviewed by Daniel Bates.
1455
1456         * Scripts/webkitpy/port/server_process_unittest.py:
1457         Adds the read method to MockFile to allow the stdout of test_webkitpy
1458         to be redirected without causing erroneous test failures.
1459         In particular,
1460         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
1461         and
1462         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
1463         because when redirecting to a file, the
1464         _wait_for_data_and_update_buffers_using_select method in 
1465         server_process.py will find that there is a read file descriptor in
1466         its call to select.select, which eventually leads to it calling read()
1467         on the MockFile object.
1468         (MockFile.read):
1469         * Scripts/webkitpy/test/main.py:
1470         Adds the _print_results_as_json method and the --json flag which
1471         determines whether _print_results_as_json will get called.
1472         (Tester._parse_args):
1473         (Tester._print_results_as_json):
1474         (Tester._print_results_as_json.result_dict_from_tuple):
1475         (Tester._run_tests):
1476
1477 2014-10-13  David Farler  <dfarler@apple.com>
1478
1479         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
1480         https://bugs.webkit.org/show_bug.cgi?id=137662
1481
1482         Reviewed by Darin Adler.
1483
1484         The layout test harness can close LayoutTestRelay's subprocess
1485         stdout and stderr in the case of a timeout or if a run is
1486         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
1487         finds that no one is listening to its stdout/stderr (broken
1488         pipe), then just exit(1), there is nothing to report.
1489
1490         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1491         (-[LTRelayController didReceiveStdoutData:]):
1492         Add @try/@catch for NSFileHandleOperationException.
1493         (-[LTRelayController didReceiveStderrData:]):
1494         Add @try/@catch for NSFileHandleOperationException.
1495
1496 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
1497
1498         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
1499         https://bugs.webkit.org/show_bug.cgi?id=137060
1500
1501         Reviewed by Philippe Normand.
1502
1503         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
1504
1505         * MiniBrowser/gtk/BrowserWindow.c:
1506         (zoomInCallback):
1507         (zoomOutCallback):
1508         (defaultZoomCallback): Callback for default zoom keyboard support.
1509         (browser_window_init):
1510
1511 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
1512
1513         [Mac] DRT stderr logging after the test completes gets attributed to the next test
1514
1515         Reviewed by Alexey Proskuryakov.
1516         
1517         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
1518         logging to stderr to get associated with the next test.
1519         
1520         Fix by logging #EOF to stderr later, after we've completely finished with this test.
1521
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (dumpTestResults):
1524         (runTest):
1525
1526 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
1527
1528         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
1529
1530         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
1531
1532 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1533
1534         [cmake] Fix the make build after r174683
1535         https://bugs.webkit.org/show_bug.cgi?id=137703
1536
1537         Reviewed by Martin Robinson.
1538
1539         * Scripts/webkitdirs.pm:
1540         (buildCMakeGeneratedProject):
1541
1542 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
1543
1544         Adding myself to the watchlist to CachedFont
1545
1546         Unreviewed.
1547
1548         * Scripts/webkitpy/common/config/watchlist:
1549
1550 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1551
1552         [EFL][GTK] Make it possible to get verbose output with ninja
1553         https://bugs.webkit.org/show_bug.cgi?id=137606
1554
1555         Reviewed by Csaba Osztrogonác.
1556
1557         * Scripts/webkitdirs.pm:
1558         (buildCMakeGeneratedProject):
1559
1560 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1561
1562         [EFL] Make it possible to use ninja for EFL build too
1563         https://bugs.webkit.org/show_bug.cgi?id=137605
1564
1565         Reviewed by Csaba Osztrogonác.
1566
1567         * Scripts/webkitdirs.pm:
1568         (generateBuildSystemFromCMakeProject):
1569         * efl/install-dependencies:
1570
1571 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
1572
1573         [GTK] Minibrowser : Add home buton and keyboard support for home page load
1574         https://bugs.webkit.org/show_bug.cgi?id=137486
1575
1576         Reviewed by Philippe Normand.
1577
1578         * MiniBrowser/gtk/BrowserWindow.c:
1579         (loadHomePage): Callback for home page load.
1580         (browser_window_init):
1581         * MiniBrowser/gtk/BrowserWindow.h:
1582         * MiniBrowser/gtk/main.c:
1583         (main):
1584
1585 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
1586
1587         import-w3c-tests doesn't prefix property values
1588         https://bugs.webkit.org/show_bug.cgi?id=137600
1589
1590         Reviewed by Bem Jones-Bey.
1591
1592         Some property values are prefixed in WebKit. Modified the W3C import
1593         script in order to prefix property values and not only properties.
1594         The patch re-uses most of the already existent logic to prefix
1595         properties.
1596
1597         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
1598         from CSSValueKeywords.in and adapt converter to modify both properties
1599         and property values.
1600         (convert_for_webkit):
1601         (_W3CTestConverter.__init__):
1602         (_W3CTestConverter.output):
1603         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1604         (_W3CTestConverter):
1605         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
1606         (_W3CTestConverter.add_webkit_prefix_following_regex):
1607         (_W3CTestConverter.convert_reference_relpaths):
1608         (_W3CTestConverter.convert_style_data):
1609         (_W3CTestConverter.convert_attributes_if_needed):
1610         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
1611         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
1612         include checks for property values too.
1613         (W3CTestConverterTest.test_read_prefixed_property_list):
1614         (verify_no_conversion_happened):
1615         (verify_prefixed_properties):
1616         (verify_prefixed_property_values):
1617         (generate_test_content_properties_and_values):
1618         (generate_test_content):
1619         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
1620         prefixed property values and inform about them.
1621         (TestImporter.import_tests):
1622         (TestImporter.write_import_log):
1623
1624 2014-10-13  Jer Noble  <jer.noble@apple.com>
1625
1626         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1627         https://bugs.webkit.org/show_bug.cgi?id=137533
1628
1629         Reviewed by Andy Estes.
1630
1631         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
1632
1633         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1634         (TestWebKitAPI::isMSEEnabledCallback):
1635         (TestWebKitAPI::TEST):
1636
1637 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
1638
1639         [Win] Implement a page load profiling tool
1640         https://bugs.webkit.org/show_bug.cgi?id=137673
1641
1642         Reviewed by Dean Jackson.
1643
1644         Add a tool to capture and summarize page load statistics.
1645
1646         * WinLauncher/Common.cpp:
1647         (parseCommandLine): Move from WinMain.cpp so that it can
1648         be shared with internal tools.
1649         * WinLauncher/PageLoadTestClient.cpp: Added.
1650         (PageLoadTestClient::PageLoadTestClient):
1651         (PageLoadTestClient::pageLoadStartedAtTime):
1652         (PageLoadTestClient::didStartProvisionalLoad):
1653         (PageLoadTestClient::didCommitLoad):
1654         (PageLoadTestClient::didFirstLayoutForMainFrame):
1655         (PageLoadTestClient::didHandleOnLoadEvents):
1656         (PageLoadTestClient::didFinishLoad):
1657         (PageLoadTestClient::didFailLoad):
1658         (PageLoadTestClient::didInitiateResourceLoad):
1659         (PageLoadTestClient::didEndResourceLoad):
1660         (PageLoadTestClient::pageLoadEndedAtTime):
1661         (PageLoadTestClient::endPageLoad):
1662         (PageLoadTestClient::clearPageLoadState):
1663         (PageLoadTestClient::shouldConsiderPageLoadEnded):
1664         (PageLoadTestClient::maybeEndPageLoadSoon):
1665         (PageLoadTestClient::setPageURL):
1666         (PageLoadTestClient::dumpRunStatistics):
1667         * WinLauncher/PrintWebUIDelegate.cpp:
1668         (PrintWebUIDelegate::createWebViewWithRequest): Handle
1669         nullptr URL properly.
1670         * WinLauncher/ResourceLoadDelegate.cpp: Added.
1671         (ResourceLoadDelegate::QueryInterface):
1672         (ResourceLoadDelegate::AddRef):
1673         (ResourceLoadDelegate::Release):
1674         (ResourceLoadDelegate::identifierForInitialRequest):
1675         (ResourceLoadDelegate::willSendRequest):
1676         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1677         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
1678         (ResourceLoadDelegate::didReceiveResponse):
1679         (ResourceLoadDelegate::didReceiveContentLength):
1680         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1681         (ResourceLoadDelegate::didFailLoadingWithError):
1682         (ResourceLoadDelegate::plugInFailedWithError):
1683         * WinLauncher/ResourceLoadDelegate.h: Added.
1684         (ResourceLoadDelegate::ResourceLoadDelegate):
1685         * WinLauncher/WinLauncher.cpp:
1686         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
1687         page loading statistics.
1688         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
1689         and set private load delegate state.
1690         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
1691         that sets the view's resource load delegate.
1692         (WinLauncher::loadURL): If no URL is passed, load the test document.
1693         * WinLauncher/WinLauncher.h:
1694         (WinLauncher::pageLoadTestClient):
1695         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
1696         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
1697         * WinLauncher/WinLauncherWebHost.cpp:
1698         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
1699         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
1700         it could be used from other source files.
1701         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
1702         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
1703         (WinLauncherWebHost::didFailLoadWithError): Ditto.
1704         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
1705         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
1706         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
1707         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1708         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
1709         * WinLauncher/WinLauncherWebHost.h:
1710         * WinLauncher/WinMain.cpp:
1711         (wWinMain): Create and use new delegates for gathering page load data.
1712         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
1713
1714 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1715
1716         Improve the test image diffs page
1717         https://bugs.webkit.org/show_bug.cgi?id=137674
1718
1719         Reviewed by Alexey Proskuryakov.
1720         
1721         Don't treat the input file as a format string, otherwise we have to escape special
1722         characters. Just do a couple of replaces.
1723
1724         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1725         (TestResultWriter.write_image_diff_files):
1726
1727 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1728
1729         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
1730         https://bugs.webkit.org/show_bug.cgi?id=137659
1731
1732         Reviewed by Martin Robinson.
1733
1734         * Scripts/webkitpy/port/xvfbdriver.py:
1735         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
1736
1737 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
1738
1739         Add more detailed wait time information to EWS metrics
1740         https://bugs.webkit.org/show_bug.cgi?id=137649
1741
1742         Reviewed by Daniel Bates.
1743
1744         Added average and worst time (we used to only have median), and also a percentage
1745         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
1746
1747         There is always some wait due to the polling nature of the queues, which is well understood
1748         and doesn't need to be measured. What needs to be measured is whether there is enough
1749         bot machines to process patches as soon as they are submitted.
1750
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1752         (Analyzer.prototype._analyzeBubblePerformance):
1753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1754         (MetricsBubbleView.prototype._update):
1755
1756 2014-10-11  Jer Noble  <jer.noble@apple.com>
1757
1758         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
1759         https://bugs.webkit.org/show_bug.cgi?id=137533
1760
1761         Reviewed by Darin Adler.
1762
1763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1764         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1765         (TestWebKitAPI::TEST):
1766         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
1767         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
1768
1769 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
1770
1771         iOS DRT snapshots are limited to the page visible area
1772         https://bugs.webkit.org/show_bug.cgi?id=137650
1773
1774         Reviewed by Daniel Bates.
1775         
1776         LegacyTileCache drawing was limited to the window's visible area, found by
1777         crawling up the layer hierarchy to the root layer. This caused test snapshots to
1778         be missing non-composited content outside the iPhone visible area, which hinders
1779         testing.
1780         
1781         Fix by adding a test-only mode where the window visible area is the entire window.
1782         
1783         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1784         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
1785         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1786         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
1787         for the DRT window.
1788         
1789
1790 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
1791
1792         Page not fully rendered in iOS DRT snapshots
1793         https://bugs.webkit.org/show_bug.cgi?id=137638
1794
1795         Reviewed by Tim Horton.
1796         
1797         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
1798         to ensure that the page has laid out and is rendered by the time we take
1799         the snapshot.
1800
1801         * DumpRenderTree/mac/DumpRenderTree.mm:
1802         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
1803         (-[DumpRenderTree _webThreadInvoked]): Moved.
1804         (-[DumpRenderTree _waitForWebThreadThenDump]):
1805         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
1806         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
1807         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
1808         relies on dispatch_async too, and the inner block won't complete until the outer block
1809         has completed.
1810         (dumpTestResults): Move the guts of dump() here.
1811         (runTest): Whitespace.
1812
1813 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
1814
1815         Adding svn:ignore so that .pyc files don't show up as new.
1816
1817         * Scripts/webkitpy/xcode: Added property svn:ignore.
1818
1819 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
1820
1821         [EFL] Introduce EWebKit_Extension
1822         https://bugs.webkit.org/show_bug.cgi?id=134921
1823
1824         Reviewed by Gyuyoung Kim.
1825
1826         * MiniBrowser/efl/main.c: Added x option to test extension path.
1827         (window_create):
1828         (elm_main):
1829         * Scripts/webkitpy/common/config/watchlist:
1830         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1831         * Scripts/webkitpy/style/checker.py:
1832         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1833
1834 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
1835
1836         After r174628 we send the test process a SIGTERM before the SIGKILL.
1837
1838         * Scripts/webkitpy/common/system/executive_unittest.py:
1839         (ExecutiveTest.serial_test_kill_process):
1840
1841 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
1842
1843         [EFL] Enable WebP support.
1844         https://bugs.webkit.org/show_bug.cgi?id=136156
1845
1846         Reviewed by Gyuyoung Kim.
1847
1848         Include libwebp-dev package to support WebP for WK2 Efl.
1849
1850         * efl/install-dependencies:
1851
1852 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
1855         https://bugs.webkit.org/show_bug.cgi?id=137485
1856
1857         Reviewed by Sergio Villar Senin.
1858
1859         Update GMainLoopSource tests. Most of the tests are now run twice,
1860         first with a GMainLoopSource and then with a
1861         GThreadSafeMainLoopSource, since both should have the same
1862         behaviour. The threading test uses GThreadSafeMainLoopSource and
1863         the delete on destroy test uses GMainLoopSource. The tests
1864         themselves haven't changed, since there's no change in behaviour.
1865
1866         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1867         (TestWebKitAPI::GMainLoopSourceTest::source):
1868         (TestWebKitAPI::basicRescheduling):
1869         (TestWebKitAPI::TEST):
1870         (TestWebKitAPI::reentrantRescheduling):
1871         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1872         (TestWebKitAPI::basicDestroyCallbacks):
1873         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1874         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1875
1876 2014-10-10  Dana Burkart  <dburkart@apple.com>
1877
1878         Fix fat-fingered function name in git-add-reviewer.
1879
1880         Unreviewed.
1881
1882         * Scripts/git-add-reviewer:
1883         (getConfigValue):
1884
1885 2014-10-10  David Farler  <dfarler@apple.com>
1886
1887         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
1888         https://bugs.webkit.org/show_bug.cgi?id=137528
1889
1890         Reviewed by Simon Fraser.
1891
1892         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
1893         and SIGKILL the paired simulator app before exiting cleanly.
1894
1895         webkitpy only uses SIGKILL to kill processes which you cannot
1896         catch. Send SIGTERM to the process and give it chance to do
1897         its thing before sending SIGKILL. Sending a SIGKILL to an already
1898         dead PID is safe.
1899
1900         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
1901         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1902         (-[LTRelayController finish]):
1903         * LayoutTestRelay/LayoutTestRelay/main.m:
1904         (receivedSignal):
1905         (main):
1906
1907 2014-10-10  David Farler  <dfarler@apple.com>
1908
1909         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
1910         https://bugs.webkit.org/show_bug.cgi?id=137527
1911
1912         Reviewed by Simon Fraser.
1913
1914         NSFileHandle doesn't notify of EOF in its readability handler.
1915         Use a dispatch_source_t and an event handler that is called when reading is possible.
1916         In the handler block, do a run-of-the-mill read(2) from standard input and
1917         detect EOF in the usual way by checking that zero bytes were read.
1918
1919         Once an EOF is received, the FIFOs are disconnected, the simulator app
1920         is killed, and the relay exits with status 0.
1921
1922         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1923         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1924         (-[LTRelayController didDisconnect]):
1925         (-[LTRelayController didConnect]):
1926         (-[LTRelayController launchApp]):
1927         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
1928         confusion with this new dispatch source, called "standardInputDispatchSource".
1929         (-[LTRelayController finish]): Added.
1930         (-[LTRelayController readFileHandle:]): Deleted.
1931
1932 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1933
1934         [EFL] Crash on facebook.com
1935         https://bugs.webkit.org/show_bug.cgi?id=137562
1936
1937         Reviewed by Chris Dumez.
1938
1939         Crash occurs on the facebook.com when the webview is resized
1940         after the <select> item is clicked but no item is chosen.
1941         This crash is just caused by the reference of invalidated variable.
1942         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
1943         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
1944         on MiniBrowser is called.
1945         As a result, just set ewk_menu to NULL in order to prevent crash condition.
1946
1947         * MiniBrowser/efl/main.c:
1948         (on_popup_menu_hide):
1949
1950 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1951
1952         A small wording change for clarity.
1953
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1955         (MetricsBubbleView.prototype._update):
1956
1957 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1958
1959         Dashboard metrics page should have EWS statistics
1960         https://bugs.webkit.org/show_bug.cgi?id=137626
1961
1962         Reviewed by Ryosuke Niwa.
1963
1964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1965         (BubbleQueue): Put shortName in the object, so that it's actually useful.
1966
1967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1968         (BubbleQueueServer): Re-ordered queues to match bubble order.
1969         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
1970         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1973         Added analysis for bubble queues.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
1976
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1978         (buildBubbleQueuesTable): Build the UI.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1981         Added JS sources to load.
1982
1983         * QueueStatusServer/app.yaml: To update app version.
1984
1985         * QueueStatusServer/handlers/processingtimesjson.py: Added.
1986
1987         * QueueStatusServer/main.py: Added a handler for processing-times-json.
1988
1989 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1990
1991         REGRESSION: Commit queue doesn't process rollouts
1992         https://bugs.webkit.org/show_bug.cgi?id=137623
1993
1994         Reviewed by Tim Horton.
1995
1996         * QueueStatusServer/app.yaml:
1997         * QueueStatusServer/handlers/updateworkitems.py:
1998         (UpdateWorkItems._work_items_from_request):
1999
2000 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
2001
2002         Fix syntax error after r174601.
2003
2004         * Scripts/run-javascriptcore-tests:
2005
2006 2014-10-10  Michael Saboff  <msaboff@apple.com>
2007
2008         Add ability to select tarfile name in run-jsc-stress-tests
2009         https://bugs.webkit.org/show_bug.cgi?id=137614
2010
2011         Reviewed by Mark Hahnenberg.
2012
2013         Added optional file name argument to the --tarball option.  
2014
2015         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2016         extra test given after the options wont be used for the optional tarball file name.
2017         * Scripts/run-jsc-stress-tests:
2018
2019 2014-10-10  Chris Dumez  <cdumez@apple.com>
2020
2021         Unreviewed, update my information in contributors.json
2022
2023         Use my preferred first name and update my expertise areas.
2024
2025         * Scripts/webkitpy/common/config/contributors.json:
2026
2027 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2028
2029         Fix perl scripts to run with env on Linux
2030         https://bugs.webkit.org/show_bug.cgi?id=137601
2031
2032         Reviewed by Csaba Osztrogonác.
2033
2034         Use of arguments in #! is nonstandard and does not behave the same on
2035         different systems. Linux would look for an executable named "perl -w" 
2036         "use warnings;" does the same things in a more portable way.
2037
2038         * Scripts/commit-log-editor:
2039         * Scripts/num-cpus:
2040         * Scripts/prepare-ChangeLog:
2041         * Scripts/run-launcher:
2042         * Scripts/svn-create-patch:
2043
2044 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2045
2046         [jhbuild] We should be able to disable wiping on configuration change
2047         https://bugs.webkit.org/show_bug.cgi?id=137446
2048
2049         Reviewed by Csaba Osztrogonác.
2050
2051         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2052         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2053         or passing --no-wipe-on-change command line option.
2054
2055         * Scripts/update-webkit-libs-jhbuild:
2056
2057 2014-10-09  Andy Estes  <aestes@apple.com>
2058
2059         Teach webkitpy about OS X Yosemite
2060         https://bugs.webkit.org/show_bug.cgi?id=137585
2061
2062         Reviewed by Simon Fraser.
2063
2064         * Scripts/webkitpy/common/system/platforminfo.py:
2065         (PlatformInfo._determine_mac_version):
2066         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2067         (TestPlatformInfo.test_os_version):
2068         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2069         (TestExpectationParser):
2070         * Scripts/webkitpy/port/builders.py:
2071         * Scripts/webkitpy/port/mac.py:
2072         (MacPort):
2073         * Scripts/webkitpy/port/mac_unittest.py:
2074         (test_versions):
2075         (test_baseline_search_path):
2076         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2077         (TestRebaselineTest.test_baseline_directory):
2078         (TestRebaselineExpectations.test_rebaseline_expectations):
2079
2080 2014-10-09  Dana Burkart  <dburkart@apple.com>
2081
2082         Add Mac OS Yosemite dashboard support.
2083
2084         Rubber-stamped by Lucas Forschler.
2085
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2091
2092 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2093
2094         Add Babak to contributors.json and add historical email addresses for some contributors
2095         https://bugs.webkit.org/show_bug.cgi?id=137546
2096
2097         Reviewed by Christophe Dumez.
2098
2099         contributors.json is used to analyze historical commit data and change logs.
2100
2101         Add back historical email addresses for some contributors and also add Babak (Shafiei).
2102
2103         * Scripts/webkitpy/common/config/contributors.json:
2104
2105 2014-10-09  Lucas Forschler  <lforschler@apple.com>
2106
2107         Add Mac OS Yosemite webkit build infrastructure.
2108         
2109         This patch adds 15 bots to our build.webkit.org configuration.
2110         We are matching the current Mavericks machines 1:1.
2111         
2112         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2113         
2114         Reviewed by Matt Hanson.
2115
2116         * BuildSlaveSupport/build.webkit.org-config/config.json:
2117
2118 2014-10-09  Dana Burkart  <dburkart@apple.com>
2119
2120         Don't use backticks when running commands, as we run into sh-related
2121         interpolation issues. Also, fix our usage of system() to properly
2122         retrieve the status code.
2123         https://bugs.webkit.org/show_bug.cgi?id=137541
2124
2125         Reviewed by Darin Adler.
2126
2127         * Scripts/git-add-reviewer:
2128         (interactive):
2129         (nonInteractive):
2130         (requireCleanWorkTree):
2131         (cherryPick):
2132         (commit):
2133         (addReviewerToFile):
2134         (head):
2135         (isAncestor):
2136         (toCommit):
2137         (changeLogsForCommit):
2138         (resetToCommit):
2139         (getConfigValue):
2140         (runCommandWithOutput):
2141
2142 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2143
2144         Add a WebKit1 preference for selection services
2145         https://bugs.webkit.org/show_bug.cgi?id=137498
2146         <rdar://problem/18572699>
2147
2148         Reviewed by Simon Fraser.
2149
2150         * MiniBrowser/mac/WK1BrowserWindowController.m:
2151         (-[WK1BrowserWindowController awakeFromNib]):
2152         Turn on image and selection services in the Legacy WebKit MiniBrowser.
2153
2154 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
2155
2156         Get the patch scripts running on Haiku
2157         https://bugs.webkit.org/show_bug.cgi?id=137559
2158
2159         Reviewed by Benjamin Poulain.
2160
2161         Use /usr/bin/env instead of hardcoding path to perl.
2162         Declare haiku platform in platforminfo.py to avoid check-webkit-style
2163         failure.
2164
2165         * Scripts/commit-log-editor:
2166         * Scripts/num-cpus:
2167         * Scripts/prepare-ChangeLog:
2168         * Scripts/run-launcher:
2169         * Scripts/svn-create-patch:
2170         * Scripts/webkitpy/common/system/platforminfo.py:
2171         (PlatformInfo._determine_os_name):
2172
2173 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
2174
2175         StyleQueue should throw a PatchIsNotValid exception to achieve
2176         consistency with CommitQueue and EWS
2177         https://bugs.webkit.org/show_bug.cgi?id=137500
2178
2179         Reviewed by Alexey Proskuryakov.
2180
2181         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2182         Adds a call to validate() in run().
2183         (StyleQueueTask.run):
2184         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2185         Adds a return False in the patch is not valid exception statement.
2186         (AbstractEarlyWarningSystem.review_patch):
2187         * Scripts/webkitpy/tool/commands/queues.py:
2188         Adds a return False in the patch is not valid exception statement in
2189         commit queue, and adds an except statement to catch PatchIsNotValid
2190         exceptions in style queue.
2191         (CommitQueue.process_work_item):
2192         (StyleQueue.review_patch):
2193
2194 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2195
2196         Race condition with WebKitWebView:is-loading after starting page load
2197         https://bugs.webkit.org/show_bug.cgi?id=136692
2198
2199         Reviewed by Gustavo Noronha Silva.
2200
2201         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2202         (loadChangedCallback): Only check is-loading is false when load
2203         has finished if the load didn't fail due to a cancellation.
2204         (loadFailedCallback): Only check is-loading is false if the load
2205         didn't fail due to a cancellation.
2206         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2207         (WebViewTest::loadURI): Check is-loading is true and active URI is
2208         the requested one rigth after requesting the load.
2209         (WebViewTest::loadHtml): Ditto.
2210         (WebViewTest::loadPlainText): Ditto.
2211         (WebViewTest::loadBytes): Ditto.
2212         (WebViewTest::loadRequest): Ditto.
2213         (WebViewTest::loadAlternateHTML): Ditto.
2214         (WebViewTest::goBack): Ditto.
2215         (WebViewTest::goForward): Ditto.
2216         (WebViewTest::goToBackForwardListItem): Ditto.
2217
2218 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
2219
2220         [Win] Resolve various static analyzer warnings in Tools.
2221         https://bugs.webkit.org/show_bug.cgi?id=137534
2222
2223         Reviewed by Dean Jackson.
2224
2225         * DumpRenderTree/cg/ImageDiffCG.cpp:
2226         (main): User proper printf specifiers.
2227         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2228         (AccessibilityUIElement::childrenCount): Handle possibility that
2229         gcc_accChildCount returns with an error.
2230         (accessibilityState): Ditto for gcc_accState.
2231         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2232         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2233         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2234         be treated as such.
2235         * DumpRenderTree/win/DumpRenderTree.cpp:
2236         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2237         by comparing an unsigned value as being greater-than zero.
2238         * DumpRenderTree/win/EditingDelegate.cpp:
2239         (dump): Pass proper character pointer type to printf.
2240         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2241         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2242         (EditingDelegate::shouldInsertNode): Ditto.
2243         (EditingDelegate::shouldInsertText): Ditto.
2244         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2245         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2246         (EditingDelegate::shouldApplyStyle): Ditto.
2247         * DumpRenderTree/win/EventSender.cpp:
2248         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2249         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2250         system headers.
2251         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2252         from CreateDIBSection.
2253         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2254         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2255         older versions of MSVC we no longer support.
2256         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
2257         for 64-bit builds.
2258         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
2259         * TestWebKitAPI/TestsController.h: Ditto.
2260         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
2261         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
2262         performing bitwise | before the comparison is done.
2263
2264 2014-10-08  Ada Chan  <adachan@apple.com>
2265
2266         Add a test for WKPageIsPlayingAudio().
2267         https://bugs.webkit.org/show_bug.cgi?id=137048
2268
2269         Reviewed by Darin Adler.
2270
2271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2272         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
2273         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
2274         (TestWebKitAPI::nullJavaScriptCallback):
2275         (TestWebKitAPI::didFinishLoadForFrame):
2276         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
2277         (TestWebKitAPI::setUpClients):
2278         (TestWebKitAPI::TEST):
2279         This test loads a page with a video in it. When the page is loaded, we first check that
2280         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
2281         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
2282         now returns true for the page.
2283         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
2284         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
2285         This is a video copied from LayoutTests/media/content.
2286
2287 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
2288
2289         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
2290         https://bugs.webkit.org/show_bug.cgi?id=137516
2291
2292         Reviewed by Alexey Proskuryakov.
2293
2294         * Scripts/webkitpy/thirdparty/__init__.py:
2295         (AutoinstallImportHook._install_irc):
2296
2297 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2298
2299         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
2300         https://bugs.webkit.org/show_bug.cgi?id=137520
2301
2302         Reviewed by Philippe Normand.
2303
2304         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
2305         For other distributions, we are already installing libjpeg-turbo.
2306         So, do the same for Debian and derivatives.
2307
2308         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
2309
2310 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2311
2312         [webkitpy] Add back the workaround to replace ZipFile.extractall()
2313         https://bugs.webkit.org/show_bug.cgi?id=137519
2314
2315         Reviewed by Csaba Osztrogonác.
2316
2317         It was removed by <http://trac.webkit.org/changeset/174266>,
2318         because the comment stated it is a workaround for buggy python
2319         2.6.1 which shipped on Snow Leopard. But it turned out the bug
2320         is still valid with python 2.7 shipped on the latest Ubuntu
2321         (12.04 and 14.04) and OS X 10.9.
2322
2323         * Scripts/webkitpy/common/system/autoinstall.py:
2324         (AutoInstaller):
2325         (AutoInstaller._extract_all):
2326         (AutoInstaller._unzip):
2327
2328 2014-10-08  Commit Queue  <commit-queue@webkit.org>
2329
2330         Unreviewed, rolling out r174335.
2331         https://bugs.webkit.org/show_bug.cgi?id=137515
2332
2333         It broke EFL layout test totally (Requested by gyuyoung on
2334         #webkit).
2335
2336         Reverted changeset:
2337
2338         "[EFL] Introduce EWebKit_Extension"
2339         https://bugs.webkit.org/show_bug.cgi?id=134921
2340         http://trac.webkit.org/changeset/174335
2341
2342 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2343
2344         [GTK] Make forwarding headers generation depend on source code
2345         https://bugs.webkit.org/show_bug.cgi?id=137394
2346
2347         Reviewed by Philippe Normand.
2348
2349         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
2350         * TestWebKitAPI/PlatformGTK.cmake: Only run
2351         generate-forwarding-headers.pl when source code changes.
2352         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
2353
2354 2014-10-07  Tanay C  <tanay.c@samsung.com>
2355
2356         Remove build warnings in Hashmap API tests
2357         https://bugs.webkit.org/show_bug.cgi?id=137484
2358
2359         Reviewed by Darin Adler.
2360
2361         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2362         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
2363
2364 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
2365
2366         Commit queue doesn't drop obsolete patches sometimes
2367         https://bugs.webkit.org/show_bug.cgi?id=137460
2368
2369         Reviewed by Alexey Proskuryakov.
2370
2371         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2372         Adds another test patch for use in queues_unittest.py.
2373         courtesy of Csaba Osztrogonác <ossy@webkit.org>
2374         (MockBugzilla):
2375         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2376         Raises a PatchIsNotValid exception in the case of validate() returning
2377         false.
2378         (CommitQueueTask.run):
2379         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2380         Raises a PatchIsNotValid exception in the case of validate() returning
2381         false.
2382         (EarlyWarningSystemTask.run):
2383         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2384         Defines PatchIsNotValid exception. 
2385         (PatchIsNotValid):
2386         (PatchIsNotValid.__init__):
2387         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2388         Remove call to validate() and instead catches the PatchIsNotValid
2389         exception.
2390         (AbstractEarlyWarningSystem.review_patch):
2391         * Scripts/webkitpy/tool/commands/queues.py:
2392         Adds logic to catch the PatchIsNotValid exception.
2393         (CommitQueue.process_work_item):
2394         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2395         Adds the test_non_valid_patch test to ensure that invalid patches are
2396         handled properly, and don't just result in indefinite spinning.
2397         courtesy of Csaba Osztrogonác <ossy@webkit.org>
2398         (test_non_valid_patch):
2399
2400 2014-10-07  Daniel Bates  <dabates@apple.com>
2401
2402         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
2403         https://bugs.webkit.org/show_bug.cgi?id=137499
2404
2405         Reviewed by Simon Fraser.
2406
2407         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
2408         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
2409         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
2410         bit simulator builds of iOS WebKit.
2411
2412         * Scripts/webkitpy/port/ios.py:
2413         (IOSSimulatorPort._generate_all_test_configurations):
2414
2415 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2416
2417         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
2418         https://bugs.webkit.org/show_bug.cgi?id=137482
2419
2420         Reviewed by Martin Robinson.
2421
2422         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
2423
2424 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2425
2426         [SOUP] TLS errors should take precedence over HTTP authentication
2427         https://bugs.webkit.org/show_bug.cgi?id=137300
2428
2429         Reviewed by Sergio Villar Senin.
2430
2431         Add a test case to check that authenticate signal is not emitted
2432         in case of TLS errors, and the load fails instead.
2433
2434         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2435         (webViewAuthenticationCallback):
2436         (testTLSErrorsHTTPAuth):
2437         (httpsServerCallback):
2438         (beforeAll):
2439
2440 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         Make webkit-patch find-users useful
2443         https://bugs.webkit.org/show_bug.cgi?id=137475
2444
2445         Reviewed by Alexey Proskuryakov.
2446
2447         Make find-users use the CommitterList instead of accessing Bugzilla.
2448
2449         This essentially exposes the same functionality as webkitbot's whois command.
2450
2451         * Scripts/webkitpy/tool/commands/findusers.py:
2452         (FindUsers.execute):
2453
2454 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
2455
2456         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
2457         https://bugs.webkit.org/show_bug.cgi?id=137289
2458
2459         Unreviewed build fix.
2460
2461         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2462         (AccessibilityUIElement::getChildrenWithRange):
2463
2464 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2465
2466         build.webkit.org/dashboard: Add commit queue
2467         https://bugs.webkit.org/show_bug.cgi?id=137462
2468
2469         Reviewed by Tim Horton.
2470
2471         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
2472         Style queue is still invisible, as it doesn't have an associated platform, and also
2473         we never have problems with it anyway, so it's not worth watching.
2474
2475         The UI now allows for adding more bots to the Other column (such as leaks bot).
2476         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
2477         sources of data in a cell.
2478
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
2480         (BubbleQueue):
2481         (BubbleQueue.prototype.get statusPageURL):
2482         (BubbleQueue.prototype.update):
2483         (BubbleQueue.prototype.loadDetailedStatus):
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
2485         (BubbleQueueServer):
2486         (BubbleQueueServer.prototype.jsonQueueLengthURL):
2487         (BubbleQueueServer.prototype.jsonQueueStatusURL):
2488         (BubbleQueueServer.prototype.queueStatusURL):
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
2490         (BubbleQueueView):
2491         (BubbleQueueView.prototype.update.appendQueue):
2492         (BubbleQueueView.prototype.update):
2493         (BubbleQueueView.prototype._addQueueHeadingToPopover):
2494         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
2495         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2502         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
2503         (.bubble-server-popover .latest-status-no-link):
2504         (.bubble-server-popover .bot-status-description):
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2506
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2508         (buildAggregateTable):
2509         (buildQueuesTable):
2510         Removed dysfunctional support for EWS for now. It will be different.
2511
2512 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2513
2514         One more case of incorrect comparison in recordpatchevent.py
2515         https://bugs.webkit.org/show_bug.cgi?id=137459
2516
2517         Reviewed by Tim Horton.
2518
2519         * QueueStatusServer/app.yaml:
2520         * QueueStatusServer/loggers/recordpatchevent.py:
2521         (RecordPatchEvent.started):
2522
2523 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2524
2525         webkit-queues PatchLog is incorrect for patches that took less than a second
2526         https://bugs.webkit.org/show_bug.cgi?id=137453
2527
2528         Reviewed by Tim Horton.
2529
2530         * QueueStatusServer/app.yaml: Updated app version.
2531
2532         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
2533         Don't bail out for patches that took 0 seconds to process (as frequently happens
2534         when a patch is obsolete).
2535
2536 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
2537
2538         EWS bubble hover shows wrong timestamps
2539         https://bugs.webkit.org/show_bug.cgi?id=137252
2540
2541         Reviewed by Alexey Proskuryakov.
2542
2543         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
2544
2545         * QueueStatusServer/handlers/queuestatusjson.py:
2546         (QueueStatusJSON.get):
2547         * QueueStatusServer/handlers/statusbubble.py:
2548         (StatusBubble._iso_time):
2549
2550 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
2551
2552         Unreviewed, updated list of email addresses in contributors.json
2553
2554         * Scripts/webkitpy/common/config/contributors.json: Added my former
2555         email address in Igalia, for the sake of completeness.
2556
2557 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2558
2559         Unreviewed, moved myself to the list of committers.
2560
2561         * Scripts/webkitpy/common/config/contributors.json:
2562
2563 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
2564
2565         [EFL] Introduce EWebKit_Extension
2566         https://bugs.webkit.org/show_bug.cgi?id=134921
2567
2568         Reviewed by Gyuyoung Kim.
2569
2570         * MiniBrowser/efl/main.c: Added x option to test extension path.
2571         (window_create):
2572         (elm_main):
2573         * Scripts/webkitpy/common/config/watchlist:
2574         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2575         * Scripts/webkitpy/style/checker.py:
2576         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2577
2578 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
2579
2580         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
2581         https://bugs.webkit.org/show_bug.cgi?id=137390
2582
2583         Reviewed by Carlos Garcia Campos.
2584
2585         * Scripts/update-webkit-libs-jhbuild:
2586
2587 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2588
2589         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
2590         https://bugs.webkit.org/show_bug.cgi?id=137391
2591
2592         Reviewed by Martin Robinson.
2593
2594         Add a custom command to only re-generate
2595         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
2596
2597         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2598
2599 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2600
2601         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
2602         https://bugs.webkit.org/show_bug.cgi?id=135502
2603
2604         Reviewed by Martin Robinson.
2605
2606         When writing to stdout/stderr fails due to a UnicodeDecodeError
2607         exception, try again without encoding the output.
2608
2609         * gtk/gtkdoc.py:
2610         (GTKDoc._run_command):
2611
2612 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2613
2614         Bugzilla status bubble displays an exception showing attachment 175738
2615         https://bugs.webkit.org/show_bug.cgi?id=137410
2616
2617         Reviewed by Tim Horton.
2618
2619         * QueueStatusServer/app.yaml: Update version.
2620
2621         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
2622         Don't fail even if expected status message is missing.
2623
2624         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
2625         the field in the same way it's defined in QueueStatus table.
2626
2627 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2628
2629         Record latest message in PatchLog for quick access
2630         https://bugs.webkit.org/show_bug.cgi?id=137405
2631
2632         Fixing a typo.
2633
2634         * QueueStatusServer/app.yaml:
2635         * QueueStatusServer/handlers/releasepatch.py:
2636
2637 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
2638
2639         Record latest message in PatchLog for quick access
2640         https://bugs.webkit.org/show_bug.cgi?id=137405
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         It's no SQL...
2645
2646         * QueueStatusServer/handlers/releasepatch.py:
2647         * QueueStatusServer/handlers/updatestatus.py:
2648         * QueueStatusServer/loggers/recordpatchevent.py:
2649         * QueueStatusServer/model/patchlog.py:
2650
2651 2014-10-02  David Farler  <dfarler@apple.com>
2652
2653         -asan-blacklist option also renamed to generic -fsanitize-blacklist
2654         https://bugs.webkit.org/show_bug.cgi?id=137377
2655
2656         Reviewed by Daniel Bates.
2657
2658         * asan/asan.xcconfig:
2659         -asan-blacklist -> -fsanitize-blacklist
2660
2661         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2662
2663 2014-10-03  Roger Fong  <roger_fong@apple.com>
2664
2665         [Windows] Include batch size argument to layout tests on Windows.
2666
2667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2668         (RunWebKitTests.start): 
2669         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
2670         These crashes seem to happen on random tests though generally in a spread out fashion.
2671         It seems possible that the DRT instance is being clobbered somehow after running too many
2672         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
2673
2674 2014-10-03  Roger Fong  <roger_fong@apple.com>
2675
2676         [Windows] Settle for 2 chid processes running NRWT on Windows.
2677
2678         * Scripts/webkitpy/port/win.py:
2679         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
2680
2681 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
2682
2683         [GTK] Bump up and patch dependencies to allow building for aarch64
2684         https://bugs.webkit.org/show_bug.cgi?id=137147
2685
2686         Reviewed by Martin Robinson.
2687
2688         The currently used versions of pixman, libffi, librsvg, glib,
2689         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
2690         and/or build for aarch64, so they are bumped up and patched where
2691         necessary. Wherever possible, the same versions and patches were used as
2692         for the EFL port bump-up
2693         (https://bugs.webkit.org/show_bug.cgi?id=135885).
2694
2695         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
2696         regression by crashing http/tests/media/video-redirect.html . A patch
2697         already in upstream fixes that bug.
2698
2699         This change does not touch xserver, which also needs bumping up, but 
2700         will be dealt with later.
2701
2702         * gtk/jhbuild.modules:
2703         Specified versions and patches necessary to correctly build for aarch64.
2704         * gtk/patches/gst-events-arent-gstobjects.patch:
2705         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
2706         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
2707         Added. Patches gst-plugins-base to configure correctly for aarch64.
2708         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
2709         Added. Bumps up config.guess and config.sub in librsvg to recognize
2710         aarch64.
2711         * gtk/patches/libxml2-2.9.0-dtd.patch:
2712         Removed. Not necessary for libxml2 v2.9.1 anymore.
2713
2714 2014-09-28  Sam Weinig  <sam@webkit.org>
2715
2716         Remove RefPtrHashMap
2717         https://bugs.webkit.org/show_bug.cgi?id=137200
2718
2719         Reviewed by Darin Adler.
2720
2721         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2722         (TestWebKitAPI::TEST):
2723         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
2724         a minimum of refcount churn occurs.
2725
2726 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2727
2728         Remove workarounds for versions of Python before 2.7
2729         https://bugs.webkit.org/show_bug.cgi?id=137338
2730
2731         Reviewed by Csaba Osztrogonác.
2732
2733         * Scripts/webkitpy/common/system/autoinstall.py:
2734         (AutoInstaller._extract_targz):
2735         (AutoInstaller._unzip):
2736         (AutoInstaller): Deleted.
2737         (AutoInstaller._extract_all): Deleted.
2738         * Scripts/webkitpy/common/webkitunittest.py:
2739         (TestCase.setUp): Deleted.
2740         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2741         (TestConfigurationConverter.collapse_macros):
2742         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2743         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2744         (TestConfigurationConverter):
2745         (TestConfigurationConverter.combinations): Deleted.
2746         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2747         * Scripts/webkitpy/port/base.py:
2748
2749 2014-10-03  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r174264.
2752         https://bugs.webkit.org/show_bug.cgi?id=137392
2753
2754         It broke run-webkit-tests (Requested by ebalazsfalvi on
2755         #webkit).
2756
2757         Reverted changeset:
2758
2759         "Remove workarounds for versions of Python before 2.7"
2760         https://bugs.webkit.org/show_bug.cgi?id=137338
2761         http://trac.webkit.org/changeset/174264
2762
2763 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2764
2765         Remove workarounds for versions of Python before 2.7
2766         https://bugs.webkit.org/show_bug.cgi?id=137338
2767
2768         Reviewed by Csaba Osztrogonác.
2769
2770         * Scripts/webkitpy/common/system/autoinstall.py:
2771         (AutoInstaller._extract_targz):
2772         (AutoInstaller._unzip):
2773         (AutoInstaller): Deleted.
2774         (AutoInstaller._extract_all): Deleted.
2775         * Scripts/webkitpy/common/webkitunittest.py:
2776         (TestCase.setUp): Deleted.
2777         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2778         (TestConfigurationConverter.collapse_macros):
2779         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2780         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2781         (TestConfigurationConverter):
2782         (TestConfigurationConverter.combinations): Deleted.
2783         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2784         * Scripts/webkitpy/port/base.py:
2785         * Scripts/webkitpy/port/driver.py:
2786         (ContentBlock.__init__):
2787         * Scripts/webkitpy/port/server_process.py:
2788         (ServerProcess._reset):
2789
2790 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2791
2792         Remove autoinstaller workaround for python 2.6
2793         https://bugs.webkit.org/show_bug.cgi?id=137343
2794
2795         Reviewed by Daniel Bates.
2796
2797         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
2798         2.6, nor Snow Leopard is supported anymore, so the workaround is not
2799         needed anymore.
2800
2801         * Scripts/webkitpy/common/system/autoinstall.py:
2802         (AutoInstaller.install):
2803         * Scripts/webkitpy/test/main.py:
2804         (Tester._run_tests):
2805         * Scripts/webkitpy/thirdparty/__init__.py:
2806         (AutoinstallImportHook._install_mechanize):
2807         (AutoinstallImportHook._install_pep8):
2808         (AutoinstallImportHook._install_pylint):
2809         (AutoinstallImportHook._install_buildbot):
2810         (AutoinstallImportHook._install_coverage):
2811         (AutoinstallImportHook._install_eliza):
2812         (AutoinstallImportHook._install_irc):
2813         (AutoinstallImportHook._install):
2814         (autoinstall_everything):
2815
2816 2014-10-02  Daniel Bates  <dabates@apple.com>
2817
2818         Use version number 101000 instead of 10100 for OS X Yosemite
2819         https://bugs.webkit.org/show_bug.cgi?id=137372
2820
2821         Reviewed by Mark Rowe.
2822
2823         The version number for OS X Yosemite is 101000.
2824
2825         * DumpRenderTree/mac/TextInputController.m:
2826
2827 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
2828
2829         update-work-items should never delete items
2830         https://bugs.webkit.org/show_bug.cgi?id=137366
2831
2832         Reviewed by Ryosuke Niwa.
2833
2834         As we don't just replace the whole list any more, indicate which items are high
2835         priority, and which are not. Hight priority ones will be prepended to the queue,
2836         others will be appended.
2837
2838         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
2839         But hopefully we will never have many rollouts competing like that.
2840
2841         * QueueStatusServer/app.yaml: Update version.
2842
2843         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
2844         priority and regular items separately. Removed some error handling that used to
2845         end up in returning status 500 - an uncaught exception does that automatically.
2846
2847         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
2848
2849         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
2850
2851         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
2852         priority items.
2853
2854         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2855         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
2856         line that complicated testing.
2857
2858         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
2859
2860         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
2861         priority items into separate lists.
2862
2863         * Scripts/webkitpy/common/net/statusserver_mock.py:
2864         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2865         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2866         Updated tests.
2867
2868 2014-10-02  Brendan Long  <b.long@cablelabs.com>
2869
2870         Annoying build warnings in WTFString API tests
2871         https://bugs.webkit.org/show_bug.cgi?id=137360
2872
2873         Reviewed by Darin Adler.
2874
2875         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2876         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
2877
2878 2014-10-02  Roger Fong  <roger_fong@apple.com>
2879
2880         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
2881
2882         * Scripts/webkitpy/port/win.py:
2883         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
2884
2885 2014-10-02  David Farler  <dfarler@apple.com>
2886
2887         Move ASan arguments from LLVM (-mllvm) to the frontend
2888         https://bugs.webkit.org/show_bug.cgi?id=137365
2889
2890         Reviewed by David Kilzer.
2891
2892         * asan/asan.xcconfig:
2893         Remove the -mllvm prefix to the asan-blacklist argument, moving it
2894         to the clang frontend.
2895
2896         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
2897
2898 2014-10-02  Commit Queue  <commit-queue@webkit.org>
2899
2900         Unreviewed, rolling out r174120.
2901         https://bugs.webkit.org/show_bug.cgi?id=137350
2902
2903         While number of failures is reasonable with 2 processes, test
2904         results seem to be inconsistent between runs (Requested by
2905         rfong on #webkit).
2906
2907         Reverted changeset:
2908
2909         "[Windows] Back to 2 child processes for NRWT on Windows."
2910         http://trac.webkit.org/changeset/174120
2911
2912 2014-10-02  Jeff Miller  <jeffm@apple.com>
2913
2914         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
2915         https://bugs.webkit.org/show_bug.cgi?id=137347
2916
2917         Reviewed by Dan Bernstein.
2918
2919         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2920         Use WebKitSystemInterfaceYosemite on OS X 10.10.
2921
2922         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2923         Ditto.
2924
2925 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2926
2927         [GTK] [JHBuild] Switch sourceware.org mirror to http.
2928
2929         Unreviewed.
2930
2931         The ftp access is recently failing to work as expected, and the
2932         bots fail to download the file.
2933         The same mirror is available via http and seems to work better.
2934
2935         * gtk/jhbuild.modules:
2936
2937 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2938
2939         Unreviewed, rolling out r174185.
2940         https://bugs.webkit.org/show_bug.cgi?id=137334
2941
2942         Patch that adds logging causes webkitpy failures (Requested by
2943         rfong on #webkit).
2944
2945         Reverted changeset:
2946
2947         "commitqueuetasks_unittest references a non-existent member
2948         variable"
2949         https://bugs.webkit.org/show_bug.cgi?id=137303
2950         http://trac.webkit.org/changeset/174185
2951
2952 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2953
2954         EWS and Commit Queue should know better than to spew 500 failed
2955         results in the case of extremely red patches.
2956         https://bugs.webkit.org/show_bug.cgi?id=137324
2957
2958         Reviewed by Alexey Proskuryakov.
2959
2960         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2961         Adds a check for did_exceed_test_failure_limit.
2962         (AbstractEarlyWarningSystem._failing_tests_message):
2963         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2964         Alters the task mock to respond properly to
2965         results_from_patch_test_run(patch)
2966         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2967         * Scripts/webkitpy/tool/commands/queues.py:
2968         Adds a check for did_exceed_test_failure_limit.
2969         (CommitQueue._failing_tests_message):
2970
2971 2014-10-01  Daniel Bates  <dabates@apple.com>
2972
2973         Unreviewed, rolling out r174192.
2974
2975         Revert the unit test fix in r174192 since we reverted r174187
2976         in r174194 due to correctness issues. See
2977         <http://webkit.org/b/137329> for more details.
2978
2979         Reverted changeset:
2980
2981         "Test fix after r174187"
2982         http://trac.webkit.org/changeset/174192
2983
2984 2014-10-01  Mark Rowe  <mrowe@apple.com>
2985
2986         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2987
2988         Reviewed by Dan Bernstein.
2989
2990         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
2991         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
2992         for the LLVM components when on Yosemite.
2993
2994 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2995
2996         Unreviewed, rolling out r174187.
2997         https://bugs.webkit.org/show_bug.cgi?id=137329
2998
2999         webkitpy failures, and thorton says the patch is wrong
3000         (Requested by dethbakin on #webkit).
3001
3002         Reverted changeset:
3003
3004         "[Windows] Increase layout test timeout for Windows following
3005         r174162."
3006         http://trac.webkit.org/changeset/174187
3007
3008 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
3009
3010         Test fix after r174187
3011
3012         * Scripts/webkitpy/port/win_unittest.py:
3013         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
3014
3015 2014-10-01  Roger Fong  <roger_fong@apple.com>
3016
3017         [Windows] Increase layout test timeout for Windows following r174162.
3018
3019         * Scripts/webkitpy/port/win.py:
3020         (WinPort.default_timeout_ms):
3021
3022 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3023
3024         commitqueuetasks_unittest references a non-existent member variable
3025         when mock-reporting flaky tests.
3026         https://bugs.webkit.org/show_bug.cgi?id=137303
3027
3028         Reviewed by Daniel Bates.
3029
3030         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3031         (MockCommitQueue.report_flaky_tests):
3032         Makes the appropriate name change.
3033         (test_simple_flaky_test_failure):
3034         Adds a unit test to make sure that the code is excercised.
3035
3036 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3037
3038         EWS is inconclusively spinning forever on a patch that breaks 500+
3039         tests
3040         https://bugs.webkit.org/show_bug.cgi?id=137223
3041
3042         Reviewed by Tim Horton.
3043
3044         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3045         Checks to see whether the tests have exceeded the failure limit, and
3046         only spins off another test if they have not exceeded the limit.
3047         (PatchAnalysisTask._test_patch):
3048
3049 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
3050
3051         Unreviewed, add Katie Madonna as a contributor.
3052
3053         * Scripts/webkitpy/common/config/contributors.json:
3054
3055 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3056
3057         commitqueuetasks_unittest does not construct FailingTestCommitQueue
3058         objects properly in its test cases.
3059         https://bugs.webkit.org/show_bug.cgi?id=137281
3060
3061         Reviewed by Daniel Bates.
3062
3063         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3064         (FailingTestCommitQueue.test_results):
3065         Adds an assert to make FailingTestCommitQueue harder to mis-use.
3066         (test_double_flaky_test_failure):
3067         Nests the intended test failure strings into one-length lists.
3068         (test_red_test_failure):
3069         Nests the intended test failure strings into one-length lists.
3070
3071 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3072
3073         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
3074         https://bugs.webkit.org/show_bug.cgi?id=136987
3075
3076         Reviewed by Daniel Bates.
3077
3078         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3079         Specify the default encoding for all WebKit developers to get consistent results.
3080
3081 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3082
3083         EWS is too eager to say that a patch does not apply to trunk of repository
3084         https://bugs.webkit.org/show_bug.cgi?id=137290
3085
3086         Reviewed by Ryosuke Niwa.
3087
3088         * QueueStatusServer/app.yaml: Updated app version.
3089
3090         * QueueStatusServer/handlers/statusbubble.py:
3091         (StatusBubble._build_bubble):
3092         (StatusBubble._build_bubbles_for_attachment):
3093         Rewrote to make more sense.
3094
3095 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3096
3097         Remove thirdparty/unittest2 from webkitpy
3098         https://bugs.webkit.org/show_bug.cgi?id=137251
3099
3100         Reviewed by Brent Fulgham.
3101
3102         Additionally ordered imports in related webkitpy files and
3103         removed unnecessary shebangs from unittest files.
3104
3105         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
3106         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3107         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3108         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3109         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3110         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3111         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3112         * Scripts/webkitpy/common/config/committers_unittest.py:
3113         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3114         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
3115         * Scripts/webkitpy/common/config/ports_unittest.py:
3116         * Scripts/webkitpy/common/config/urls_unittest.py:
3117         * Scripts/webkitpy/common/editdistance_unittest.py:
3118         * Scripts/webkitpy/common/find_files_unittest.py:
3119         * Scripts/webkitpy/common/lru_cache_unittest.py:
3120         * Scripts/webkitpy/common/memoized_unittest.py:
3121         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
3122         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3123         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3124         * Scripts/webkitpy/common/net/credentials_unittest.py:
3125         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3126         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3127         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3128         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3129         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3130         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3131         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
3132         * Scripts/webkitpy/common/newstringio_unittest.py:
3133         * Scripts/webkitpy/common/prettypatch_unittest.py:
3134         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
3135         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3136         * Scripts/webkitpy/common/system/environment_unittest.py:
3137         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
3138         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
3139         * Scripts/webkitpy/common/system/executive_unittest.py:
3140         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
3141         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3142         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3143         * Scripts/webkitpy/common/system/logtesting.py:
3144         * Scripts/webkitpy/common/system/logutils_unittest.py:
3145         * Scripts/webkitpy/common/system/outputcapture.py:
3146         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3147         * Scripts/webkitpy/common/system/outputtee_unittest.py:
3148         * Scripts/webkitpy/common/system/path_unittest.py:
3149         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3150         * Scripts/webkitpy/common/system/profiler_unittest.py:
3151         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
3152         * Scripts/webkitpy/common/system/user_unittest.py:
3153         * Scripts/webkitpy/common/system/workspace_unittest.py:
3154         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3155         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
3156         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3157         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
3158         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
3159         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
3160         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3161         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
3162         * Scripts/webkitpy/common/webkitunittest.py:
3163         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3164         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3165         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3166         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3167         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3168         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3169         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3170         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3171         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
3172         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3173         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3174         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3175         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
3176         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3177         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3178         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
3179         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3180         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3181         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3182         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3183         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3184         * Scripts/webkitpy/port/base_unittest.py:
3185         * Scripts/webkitpy/port/builders_unittest.py:
3186         * Scripts/webkitpy/port/config_unittest.py:
3187         * Scripts/webkitpy/port/driver_unittest.py:
3188         * Scripts/webkitpy/port/efl_unittest.py:
3189         * Scripts/webkitpy/port/factory_unittest.py:
3190         * Scripts/webkitpy/port/gtk_unittest.py:
3191         * Scripts/webkitpy/port/http_lock_unittest.py:
3192         * Scripts/webkitpy/port/image_diff_unittest.py:
3193         * Scripts/webkitpy/port/leakdetector_unittest.py:
3194         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
3195         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3196         * Scripts/webkitpy/port/mock_drt_unittest.py:
3197         * Scripts/webkitpy/port/port_testcase.py:
3198         * Scripts/webkitpy/port/server_process_unittest.py:
3199         * Scripts/webkitpy/port/westondriver_unittest.py:
3200         * Scripts/webkitpy/port/win_unittest.py:
3201         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3202         * Scripts/webkitpy/style/checker_unittest.py:
3203         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3204         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3205         * Scripts/webkitpy/style/checkers/common_unittest.py:
3206         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3207         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
3208         * Scripts/webkitpy/style/checkers/js_unittest.py:
3209         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
3210         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
3211         * Scripts/webkitpy/style/checkers/png_unittest.py:
3212         * Scripts/webkitpy/style/checkers/python_unittest.py:
3213         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3214         * Scripts/webkitpy/style/checkers/text_unittest.py:
3215         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
3216         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
3217         * Scripts/webkitpy/style/checkers/xml_unittest.py:
3218         * Scripts/webkitpy/style/error_handlers_unittest.py:
3219         * Scripts/webkitpy/style/filereader_unittest.py:
3220         * Scripts/webkitpy/style/filter_unittest.py:
3221         * Scripts/webkitpy/style/main_unittest.py:
3222         * Scripts/webkitpy/style/optparser_unittest.py:
3223         * Scripts/webkitpy/style/patchreader_unittest.py:
3224         * Scripts/webkitpy/test/finder_unittest.py:
3225         * Scripts/webkitpy/test/main.py: Ordered imports.
3226         * Scripts/webkitpy/test/main_unittest.py:
3227         * Scripts/webkitpy/test/printer.py: Ordered imports.
3228         (Printer.configure):
3229         * Scripts/webkitpy/test/runner_unittest.py:
3230         * Scripts/webkitpy/test/skip_unittest.py:
3231         * Scripts/webkitpy/thirdparty/__init__.py:
3232         (AutoinstallImportHook._install_irc):
3233         (AutoinstallImportHook._install_unittest2): Deleted.
3234         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3235         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
3236         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3237         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3238         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3239         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3240         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3241         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3242         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3243         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3244         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3245         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3246         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3247         * Scripts/webkitpy/tool/commands/download_unittest.py:
3248         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3249         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
3250         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3251         * Scripts/webkitpy/tool/commands/queuestest.py:
3252         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3253         * Scripts/webkitpy/tool/grammar_unittest.py:
3254         * Scripts/webkitpy/tool/mocktool_unittest.py:
3255         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3256         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3257         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3258         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
3259         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
3260         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3261         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3262         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3263         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3264         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
3265         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3266         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3267         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3268         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3269         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3270         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3271         * Scripts/webkitpy/tool/steps/update_unittest.py:
3272         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3273         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3274         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3275         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3276         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3277
3278 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
3279
3280         LayoutTestResults and ExpectedFailures should know about the
3281         interrupted flag from the json results file
3282         https://bugs.webkit.org/show_bug.cgi?id=137229
3283
3284         Reviewed by Daniel Bates.
3285
3286         Changes LayoutTestResults to use the interrupted flag instead of
3287         counting failures.
3288
3289         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3290         (BuilderTest._install_fetch_build._mock_fetch_build):
3291         (BuilderTest.test_latest_layout_test_results):
3292         * Scripts/webkitpy/common/net/layouttestresults.py:
3293         Removes notion of failure_limit_count, and adds
3294         did_exceed_test_failure_limit.
3295
3296         (LayoutTestResults.results_from_string):
3297         (LayoutTestResults.__init__):
3298         (LayoutTestResults.did_exceed_test_failure_limit):
3299         (LayoutTestResults): Deleted.
3300         (LayoutTestResults.set_failure_limit_count): Deleted.
3301         (LayoutTestResults.failure_limit_count): Deleted.
3302         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3303         Removes unit test for failure_limit_count logic.
3304
3305         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
3306         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3307         Instead of providing a class method that returns a list of
3308         TestResults objects, resultsjsonparser now provides a class
3309         ParsedJSONResults that serves as an interface between the results.json
3310         file and the rest of webkitpy.
3311
3312         (ParsedJSONResults):
3313         (ParsedJSONResults.__init__):
3314         (ParsedJSONResults.did_exceed_test_failure_limit):
3315         (ParsedJSONResults.test_results):
3316         (ResultsJSONParser): Deleted.
3317         (ResultsJSONParser.parse_results_json): Deleted.
3318         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3319         Updates the unit test so that it can test the new ResultsJSONParser
3320         class.
3321
3322         (ParsedJSONResultsTest):
3323         (test_basic):
3324         (ResultsJSONParserTest): Deleted.
3325         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3326         Updates the unit test to instantiate ResultsJSONParser objects rather
3327         than simple lists of TestResult objects.
3328
3329         (MockCommitQueue.test_results):
3330         (FailingTestCommitQueue.test_results):
3331         (test_flaky_test_failure):
3332         (test_failed_archive):
3333         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3334         Updates ExpectedFailures to use the did_exceed_test_failure_limit
3335         method rather than counting the number of failed tests.
3336
3337         (ExpectedFailures._should_trust):
3338         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3339         Updates MockResults to more closely resemble the updated
3340         LayoutTestResults class.
3341
3342         (MockResults.__init__):
3343         (MockResults.did_exceed_test_failure_limit):
3344         (ExpectedFailuresTest.test_can_trust_results):
3345         (ExpectedFailuresTest.test_unexpected_failures_observed):
3346         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
3347         (MockResults.failure_limit_count): Deleted.
3348         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3349         Removes a FIXME regarding the use of the
3350         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
3351
3352         (LayoutTestResultsReader.results):
3353         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3354         Updates test to not check the now-nonexistant failure_count_limit
3355         method.
3356
3357         (test_missing_unit_test_results_path):
3358         (test_layout_test_results):
3359         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3360         Accounts for name change: ResultsJSONParserTest ->
3361         ParsedJSONParserTest.
3362
3363         (RebaselineTestTest.test_gather_baselines):
3364
3365 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3366
3367         [EFL] Rename TEST_THEME_DIR macro
3368         https://bugs.webkit.org/show_bug.cgi?id=137244
3369
3370         Reviewed by Csaba Osztrogonác.
3371
3372         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
3373         DEFAULT_THEME_DIR is better than it.
3374
3375         * MiniBrowser/efl/main.c:
3376         (window_create):
3377         * TestWebKitAPI/efl/PlatformWebView.cpp:
3378         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3379         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3380         (WTR::PlatformWebView::PlatformWebView):
3381
3382 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3383
3384         Windows EWS went purple when it failed to build
3385         https://bugs.webkit.org/show_bug.cgi?id=137267
3386
3387         Reviewed by Ryosuke Niwa.
3388
3389         * QueueStatusServer/app.yaml: Update the version.
3390
3391         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
3392         Make it work for style and win-ews queues.
3393
3394 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
3395
3396         It should be fun and easy to run every possible JavaScript benchmark from the command line
3397         https://bugs.webkit.org/show_bug.cgi?id=137245
3398
3399         Reviewed by Oliver Hunt.
3400         
3401         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
3402         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
3403         having their own private scripts for doing benchmark runs, and didn't share them in the open
3404         source community, because of fears about the shady licensing of the benchmarks suites that
3405         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
3406         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
3407         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
3408         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
3409         but some of them are. The non-public tests are exclusively those that were not made by any
3410         WebKit contributor, but which JSC/WebKit devs found useful for testing.
3411
3412         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
3413         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
3414         checked into WebKit svn at all) can be run by passing the path to them via a configuration
3415         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
3416         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
3417         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
3418         probably never be checked in because there is no license text anywhere in that benchmark.
3419         A valid ~/.run-jsc-benchmarks file will just be something like:
3420         
3421             {
3422                 "OctanePath": "/path/to/Octane2",
3423                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
3424             }
3425         
3426         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
3427         run-jsc-benchmarks will just gracefully avoid running that test suite.
3428         
3429         Finally, a word about policy: it is understood that different organizations that do
3430         development on JSC may find themselves having internal benchmarks that they cannot share
3431         because of weird licensing. It happens - usually because the organization doing JSC
3432         development found some test in the wild that is owned by someone else and therefore cannot
3433         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
3434         that add support for some new kind of benchmark suite even if the suite is not made public
3435         as part of the same patch - so long as the patch isn't too invasive. An example of
3436         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
3437         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
3438         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
3439         completely open-sourced and committed to the WebKit repo - but the reality is that this
3440         can't always be done safely.
3441
3442         * Scripts/bencher: Removed.
3443         * Scripts/run-jsc-benchmarks: Added.
3444
3445 2014-09-30  Roger Fong  <roger_fong@apple.com>
3446
3447         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
3448
3449         * Scripts/webkitpy/port/drdiver.py:
3450         (Driver.stop):
3451         * Scripts/webkitpy/port/server_process.py:
3452         (ServerProcess.stop):
3453
3454 2014-09-30  Roger Fong  <roger_fong@apple.com>
3455
3456         [Windows] Back to 2 child processes for NRWT on Windows.
3457
3458         * Scripts/webkitpy/port/win.py:
3459         (WinPort.default_child_processes):
3460         Changing the number of processes to 1 did not have an effect on the layout test results. 
3461         It does introduce an issue with one of the workers hanging indefinitely and causing the 
3462         layout tests to timeout as a whole occasionally, but we should just fix that.
3463
3464 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3465
3466         Remove an accidentally committed line..
3467
3468         * QueueStatusServer/handlers/statusbubble.py:
3469         (StatusBubble._build_bubble):
3470
3471 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3472
3473         build.webkit.org/dashboard: Switch EWS view to using actual retry count
3474         https://bugs.webkit.org/show_bug.cgi?id=137240
3475
3476         Reviewed by Ryosuke Niwa.
3477
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3479         (EWSQueue.prototype.loadDetailedStatus):
3480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3481         (EWSQueueView.prototype._popoverContentForEWSQueue):
3482         Use the new retry_count data member from JSON.
3483
3484         * QueueStatusServer/app.yaml: Updating the version.
3485
3486         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
3487         Instead of message_count, produce retry_count.
3488
3489 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
3490
3491         EWS doesn't need to show all the bubbles when a patch fails to apply
3492         https://bugs.webkit.org/show_bug.cgi?id=137256
3493
3494         Reviewed by Ryosuke Niwa.
3495
3496         * QueueStatusServer/app.yaml: Updated app version.
3497
3498         * QueueStatusServer/handlers/statusbubble.py:
3499         (StatusBubble._build_bubble):
3500         (StatusBubble._build_bubbles_for_attachment):
3501         (StatusBubble.get):
3502         * QueueStatusServer/templates/statusbubble.html:
3503         When some queues fail to apply, and no queues had meaningful output (meaning that
3504         they will almost certainly fail to apply later), we can show a single bubble
3505         telling the user just that.
3506
3507 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3508
3509         [EFL] Bump EFL version to 1.11.2
3510         https://bugs.webkit.org/show_bug.cgi?id=137118
3511
3512         Reviewed by Gyuyoung Kim.
3513
3514         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
3515         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
3516
3517         * efl/jhbuild.modules:
3518         * efl/patches/ecore.patch: Removed.
3519
3520 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3521
3522         REGRESSION(r173929): [GTK] TestInspector fails after r173929
3523         https://bugs.webkit.org/show_bug.cgi?id=137247
3524
3525         Reviewed by Philippe Normand.
3526
3527         Wait until can-attach property changes before trying to attach the
3528         inspector after resizing the view.
3529
3530         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
3531         (testInspectorDefault):
3532
3533 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3534
3535         Require Python 2.7 version
3536         https://bugs.webkit.org/show_bug.cgi?id=137112
3537
3538         Reviewed by Csaba Osztrogonác.
3539
3540         * Scripts/ensure-valid-python:
3541         (checkPythonVersion):
3542         * Scripts/webkitpy/common/version_check.py:
3543
3544 2014-09-30  Martin Hock  <mhock@apple.com>
3545
3546         Skip a JSC test after r174036.
3547         https://bugs.webkit.org/show_bug.cgi?id=137236
3548
3549         Reviewed by Csaba Osztrogonác.
3550
3551         * Scripts/run-javascriptcore-tests:
3552
3553 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3554
3555         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
3556         https://bugs.webkit.org/show_bug.cgi?id=137212
3557
3558         This moves TestNetscapePlugin to a new folder (lib/plugins).
3559         We should not use the same directory for TestNetscapePlugin and
3560         the other libraries, because we end up scanning all the .so in the
3561         lib dir for every test.
3562
3563         Reviewed by Carlos Garcia Campos.
3564
3565         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
3566         * Scripts/webkitpy/port/efl.py:
3567         (EflPort.setup_environ_for_server): Update plugin path.
3568         * Scripts/webkitpy/port/gtk.py:
3569         (GtkPort.setup_environ_for_server): Update plugin path.
3570         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
3571
3572 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3573
3574         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
3575
3576         Rubber-stamped by Tim Horton.
3577
3578         * QueueStatusServer/app.yaml:
3579         * QueueStatusServer/handlers/statusbubble.py:
3580         (StatusBubble._build_bubble):
3581
3582 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3583
3584         Typo fix, suggested by Tim Horton.
3585
3586         * QueueStatusServer/handlers/statusbubble.py:
3587         (StatusBubble._build_message_for_provisional_failure):
3588
3589 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
3590
3591         Improve Bugzilla status bubbles
3592         https://bugs.webkit.org/show_bug.cgi?id=137232
3593
3594         Reviewed by Ryosuke Niwa.
3595
3596         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
3597
3598         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
3599         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
3600         that are stuck, as it was only confusing that they disappeared after 99.
3601
3602         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
3603         by old bubbles. We need a lot more information to determine color, so the implementation
3604         can not be here.
3605
3606         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
3607         always have a link for consistency. Added code to convert timestamps in tooltips
3608         to local time zone.
3609
3610 2014-09-29  Commit Queue  <commit-queue@webkit.org>
3611
3612         Unreviewed, rolling out r174045.
3613         https://bugs.webkit.org/show_bug.cgi?id=137231
3614
3615         Introduced a crash during page loading tests on Mac (Requested
3616         by rniwa on #webkit).
3617
3618         Reverted changeset: