3b944820a50d1b5adb57d96b398edb5d44bc96e3
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4         https://bugs.webkit.org/show_bug.cgi?id=194599
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
9         (StatusBubble._build_bubble):
10
11 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-app] Set Foreign Key in Django build model
14         https://bugs.webkit.org/show_bug.cgi?id=194667
15
16         Reviewed by Lucas Forschler.
17
18         * BuildSlaveSupport/ews-app/ews/models/build.py:
19         (Build):
20
21 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
22
23         [WTF] Add environment variable helpers
24         https://bugs.webkit.org/show_bug.cgi?id=192405
25
26         Reviewed by Michael Catanzaro.
27
28         * DumpRenderTree/mac/DumpRenderTree.mm:
29         (libraryPathForDumpRenderTree):
30         * DumpRenderTree/win/DumpRenderTree.cpp:
31         (libraryPathForDumpRenderTree):
32         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
33         (setUpIOSLayoutTestCommunication):
34         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
35         (TestWebKitAPI::strip):
36         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
37         (beforeAll):
38         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
39         (main):
40         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
41         (WebKitTestBus::run):
42         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
43         (WTR::getOutputDir):
44         (WTR::initializeFontConfigSetting):
45         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
46         (WTR::InjectedBundle::platformInitialize):
47         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
48         (WTR::topLevelPath):
49         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
50         (WTR::topLevelPath):
51         (WTR::getOutputDir):
52         (WTR::activateFonts):
53         * WebKitTestRunner/TestController.cpp:
54         (WTR::TestController::libraryPathForTesting):
55         (WTR::TestController::generateContextConfiguration const):
56         (WTR::TestController::generatePageConfiguration):
57         (WTR::TestController::decideDestinationWithSuggestedFilename):
58         (WTR::TestController::platformAdjustContext):
59         * WebKitTestRunner/TestController.h:
60         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
61         (WTR::TestController::cocoaPlatformInitialize):
62         (WTR::TestController::platformAdjustContext):
63         * WebKitTestRunner/gtk/main.cpp:
64         (main):
65         * WebKitTestRunner/mac/TestControllerMac.mm:
66         (WTR::TestController::configureContentExtensionForTest):
67         * WebKitTestRunner/wpe/main.cpp:
68         (main):
69         Utilize WTF::Environment where possible.
70
71 2019-02-14  Chris Dumez  <cdumez@apple.com>
72
73         [PSON] Introduce a WebContent Process cache
74         https://bugs.webkit.org/show_bug.cgi?id=194594
75         <rdar://problem/46793397>
76
77         Reviewed by Geoff Garen.
78
79         Update API tests to turn on the WebContent Process cache.
80
81         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
82
83 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
84
85         Unreviewed, build fix after r241480
86
87         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
88         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
89         (-[DragAndDropSimulator initWithWebView:]):
90
91 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
92
93         AX: ARIA Reflection was disabled in error
94         https://bugs.webkit.org/show_bug.cgi?id=194647
95         <rdar://problem/48068336>
96
97         Reviewed by Ryosuke Niwa.
98
99         Remove test override now that this feature should be enabled by default.
100
101         * WebKitTestRunner/TestController.cpp:
102         (WTR::TestController::resetPreferencesToConsistentValues):
103
104 2019-02-14  Commit Queue  <commit-queue@webkit.org>
105
106         Unreviewed, rolling out r241486.
107         https://bugs.webkit.org/show_bug.cgi?id=194655
108
109         causing API failures in builds (Requested by ShawnRoberts on
110         #webkit).
111
112         Reverted changeset:
113
114         "[Cocoa] Media elements will restart network buffering just
115         before suspending"
116         https://bugs.webkit.org/show_bug.cgi?id=193691
117         https://trac.webkit.org/changeset/241486
118
119 2019-02-14  Zalan Bujtas  <zalan@apple.com>
120
121         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
122         https://bugs.webkit.org/show_bug.cgi?id=194622
123
124         Reviewed by Antti Koivisto.
125
126         * LayoutReloaded/misc/LFC-passing-tests.txt:
127
128 2019-02-14  Zalan Bujtas  <zalan@apple.com>
129
130         [LFC] Shrink-to-fit-width should be constrained by min/max width
131         https://bugs.webkit.org/show_bug.cgi?id=194653
132
133         Reviewed by Antti Koivisto.
134
135         * LayoutReloaded/misc/LFC-passing-tests.txt:
136
137 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
138
139         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
140         https://bugs.webkit.org/show_bug.cgi?id=194641
141
142         Reviewed by Geoffrey Garen.
143
144         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
145         so that the test would fail without this fix.
146
147         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
148         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
149
150 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
151
152         [ews-app] Change log level for a log statement
153
154         Unreviewed minor fix.
155
156         * BuildSlaveSupport/ews-app/ews/models/patch.py:
157         (Patch.save_patch):
158
159 2019-02-13  Jer Noble  <jer.noble@apple.com>
160
161         [Cocoa] Media elements will restart network buffering just before suspending
162         https://bugs.webkit.org/show_bug.cgi?id=193691
163
164         Reviewed by Eric Carlson.
165
166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
168         (TEST):
169
170 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
171
172         [ews-app] Fetch builder id to name mapping
173         https://bugs.webkit.org/show_bug.cgi?id=194355
174
175         Reviewed by Lucas Forschler.
176
177         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
178         (Buildbot.get_builder_id_to_name_mapping):
179         (Buildbot._get_display_name_from_builder_name):
180
181 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
182
183         Further restricting webarchive loads
184         https://bugs.webkit.org/show_bug.cgi?id=194567
185         <rdar://problem/47610130>
186
187         Reviewed by Youenn Fablet.
188
189         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
190         navigations on drop.
191
192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
193         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
194         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
195         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
196         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
197         (TestWebKitAPI::TEST):
198         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
199         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
200         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
201         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
202         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
203         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
204         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
205
206 2019-02-13  John Wilander  <wilander@apple.com>
207
208         Store Ad Click Attribution requests in the network process
209         https://bugs.webkit.org/show_bug.cgi?id=194510
210         <rdar://problem/47650118>
211
212         Reviewed by Alex Christensen and Daniel Bates.
213
214         This patch adds two TestRunner functions:
215         - dumpAdClickAttribution()
216         - clearAdClickAttribution()
217
218         They call into the network process to dump and clear Ad Click
219         Attribution state, respectively.
220
221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
223         (WTR::TestRunner::dumpAdClickAttribution):
224         (WTR::TestRunner::clearAdClickAttribution):
225         * WebKitTestRunner/InjectedBundle/TestRunner.h:
226         * WebKitTestRunner/TestController.cpp:
227         (WTR::TestController::resetStateToConsistentValues):
228         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
229         (WTR::adClickAttributionStringResultCallback):
230         (WTR::TestController::dumpAdClickAttribution):
231         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
232         (WTR::adClickAttributionVoidCallback):
233         (WTR::TestController::clearAdClickAttribution):
234         * WebKitTestRunner/TestController.h:
235         * WebKitTestRunner/TestInvocation.cpp:
236         (WTR::TestInvocation::dumpResults):
237         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
238         (WTR::TestInvocation::dumpAdClickAttribution):
239         * WebKitTestRunner/TestInvocation.h:
240
241 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
242
243         [ews-app] Generate status-bubble
244         https://bugs.webkit.org/show_bug.cgi?id=194572
245
246         Reviewed by Lucas Forschler.
247
248         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
249         (StatusBubble._build_bubble):
250         (StatusBubble._should_show_bubble_for):
251         (StatusBubble._build_bubbles_for_patch):
252
253 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
254
255         [ews-app] Add status bubble html template
256         https://bugs.webkit.org/show_bug.cgi?id=194571
257
258         Reviewed by Lucas Forschler.
259
260         * BuildSlaveSupport/ews-app/ews/templates: Added.
261         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
262
263 2019-02-12  Chris Dumez  <cdumez@apple.com>
264
265         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
266         https://bugs.webkit.org/show_bug.cgi?id=194568
267         <rdar://problem/47944490>
268
269         Reviewed by Ryosuke Niwa.
270
271         Add API test coverage.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
274         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
275
276 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
277
278         webkitpy: Remove bug_dummy from parsed test expectations
279         https://bugs.webkit.org/show_bug.cgi?id=194562
280         <rdar://problem/47853999>
281
282         Reviewed by Lucas Forschler.
283
284         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
285         (TestExpectationParser):
286         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
287         skipped tests.
288         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
289
290 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-app] Add method to fetch patch
293         https://bugs.webkit.org/show_bug.cgi?id=194518
294
295         Reviewed by Lucas Forschler.
296
297         * BuildSlaveSupport/ews-app/ews/models/patch.py:
298         (Patch.get_patch):
299
300 2019-02-12  Zalan Bujtas  <zalan@apple.com>
301
302         [LFC] Expand tests coverage (60 new tests -> 860)
303
304         Unreviewed test gardening (run-singly, --child-processes=1).
305
306         * LayoutReloaded/misc/LFC-passing-tests.txt:
307
308 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
309
310         Allow pages to trigger programmatic paste from script on iOS
311         https://bugs.webkit.org/show_bug.cgi?id=194271
312         <rdar://problem/47808810>
313
314         Reviewed by Tim Horton.
315
316         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
317
318         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
319         (WTR::UIScriptController::platformSetDidShowMenuCallback):
320         (WTR::UIScriptController::platformSetDidHideMenuCallback):
321         (WTR::UIScriptController::rectForMenuAction const):
322
323         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
324         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
325         for when the menu is shown or hidden.
326
327         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
328         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
329         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
330         (WTR::UIScriptController::setDidShowMenuCallback):
331         (WTR::UIScriptController::didShowMenuCallback const):
332         (WTR::UIScriptController::setDidHideMenuCallback):
333         (WTR::UIScriptController::didHideMenuCallback const):
334         (WTR::UIScriptController::platformSetDidShowMenuCallback):
335         (WTR::UIScriptController::platformSetDidHideMenuCallback):
336         (WTR::UIScriptController::rectForMenuAction const):
337         * TestRunnerShared/UIScriptContext/UIScriptController.h:
338         * WebKitTestRunner/TestController.cpp:
339         (WTR::TestController::resetPreferencesToConsistentValues):
340         (WTR::updateTestOptionsFromTestHeader):
341         * WebKitTestRunner/TestOptions.h:
342
343         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
344         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
345
346         (WTR::TestOptions::hasSameInitializationOptions const):
347         * WebKitTestRunner/UIScriptControllerCocoa.mm:
348         (WTR::UIScriptController::calendarType const):
349         (WTR::UIScriptController::platformUndoManager const):
350         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
351         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
352         (-[TestRunnerWKWebView initWithFrame:configuration:]):
353         (-[TestRunnerWKWebView dealloc]):
354         (-[TestRunnerWKWebView _didShowMenu]):
355         (-[TestRunnerWKWebView _didHideMenu]):
356
357         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
358
359         * WebKitTestRunner/ios/TestControllerIOS.mm:
360         (WTR::handleMenuWillHideNotification):
361         (WTR::handleMenuDidHideNotification):
362         (WTR::TestController::platformInitialize):
363         (WTR::TestController::platformDestroy):
364         (WTR::TestController::platformResetStateToConsistentValues):
365
366         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
367         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
368
369         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
370         (WTR::forEachViewInHierarchy):
371         (WTR::findViewInHierarchyOfType):
372
373         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
374         functions that dig through a given view's hierarchy in search of a view of a given class.
375
376         (WTR::UIScriptController::selectionStartGrabberViewRect const):
377         (WTR::UIScriptController::selectionEndGrabberViewRect const):
378         (WTR::UIScriptController::selectionCaretViewRect const):
379         (WTR::UIScriptController::selectionRangeViewRects const):
380         (WTR::UIScriptController::platformSetDidShowMenuCallback):
381         (WTR::UIScriptController::platformSetDidHideMenuCallback):
382
383         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
384
385         (WTR::UIScriptController::rectForMenuAction const):
386
387         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
388         callout bar) whose label matches the given string.
389
390         (WTR::UIScriptController::platformContentView const):
391
392         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
393         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
394         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
395
396         (WTR::UIScriptController::platformUndoManager const): Deleted.
397         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
398         (WTR::UIScriptController::platformContentView const):
399         (WTR::UIScriptController::platformUndoManager const): Deleted.
400
401 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
402
403         webkitpy: No option to only show unexpected failures in results.html for iPad
404         https://bugs.webkit.org/show_bug.cgi?id=194554
405         <rdar://problem/47922442>
406
407         Rubber-stamped by Aakash Jain.
408
409         Just because a TestExpecations file does not exist for a specific platform does not mean that
410         TestExpecations are not being used, given that platforms inherit test expectations.
411
412         * Scripts/webkitpy/port/base.py:
413         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
414         * Scripts/webkitpy/port/base_unittest.py:
415         (PortTest.test_uses_test_expectations_file):
416
417 2019-02-12  Alex Christensen  <achristensen@webkit.org>
418
419         Remove setDefersLoading infrastructure from WebKit2
420         https://bugs.webkit.org/show_bug.cgi?id=194506
421
422         Reviewed by Brady Eidson.
423
424         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
426         (WTR::TestRunner::setDefersLoading): Deleted.
427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
428
429 2019-02-12  Alex Christensen  <achristensen@webkit.org>
430
431         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
432         https://bugs.webkit.org/show_bug.cgi?id=194522
433         <rdar://problem/47789393>
434
435         Reviewed by Chris Dumez.
436
437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
438         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
439         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
441
442 2019-02-12  Andy Estes  <aestes@apple.com>
443
444         [iOSMac] Enable Parental Controls Content Filtering
445         https://bugs.webkit.org/show_bug.cgi?id=194521
446         <rdar://39732376>
447
448         Reviewed by Tim Horton.
449
450         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
451
452 2019-02-12  Zalan Bujtas  <zalan@apple.com>
453
454         [LFC][IFC] Add intrinsic width support for float boxes.
455         https://bugs.webkit.org/show_bug.cgi?id=194528
456
457         Reviewed by Antti Koivisto.
458
459         Expand tests coverage (2 new tests -> 800).
460         (This is the correct test ordering --runs-singly --child-processes=1)
461
462         * LayoutReloaded/misc/LFC-passing-tests.txt:
463
464 2019-02-12  Rob Buis  <rbuis@igalia.com>
465
466         Implement serializing in MIME type parser
467         https://bugs.webkit.org/show_bug.cgi?id=193909
468
469         Reviewed by Darin Adler.
470
471         Add various tests involving upper case, non-ASCII, control/null characters,
472         various HTTP whitespace, single quotes and an unpaired surrogate.
473
474         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
475         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
476         (TestWebKitAPI::serializeIfValid):
477         (TestWebKitAPI::TEST):
478
479 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
480
481         [Cocoa] Ask platform for generic font family mappings
482         https://bugs.webkit.org/show_bug.cgi?id=187723
483         <rdar://problem/41892438>
484
485         Reviewed by Brent Fulgham.
486
487         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
488
489         * DumpRenderTree/mac/DumpRenderTree.mm:
490         (allowedFontFamilySet):
491         * WebKitTestRunner/mac/TestControllerMac.mm:
492         (WTR::allowedFontFamilySet):
493
494 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
495
496         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
497         https://bugs.webkit.org/show_bug.cgi?id=193622
498
499         Reviewed by Michael Catanzaro.
500
501         This adds support for loading content extension rule sets from the JSON files which
502         accompany the corresponding layout test, using the C API. The Cocoa specific parts
503         of WKTR for this could be removed, but that is left for a follow-up patch with
504         cleanups.
505
506         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
507         * WebKitTestRunner/TestController.cpp:
508         (WTR::testPath): Subtract one from the length when constructing the result std::string to
509         avoid having the null-terminator copied into the result.
510         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
511         part of the preparations to run a test.
512         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
513         (WTR::contentExtensionStoreCallback): Added.
514         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
515         used for content extensions test.
516         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
517         extensions and compiling the JSON rule set for tests involving content extensions.
518         (WTR::TestController::resetContentExtensions): Removes the content extension built for
519         testing and disables content extensions.
520         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
521         resetContentExtensions().
522         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
523         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
524         configureContentExtensionForTest(), and userContentController().
525
526 2019-02-11  Daniel Bates  <dabates@apple.com>
527
528         [iOS] Mouse/Touch/Pointer events are missing modifier keys
529         https://bugs.webkit.org/show_bug.cgi?id=191446
530         <rdar://problem/45929460>
531
532         Reviewed by Tim Horton.
533
534         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
535
536         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
537         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
538         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
539         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
540         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
541         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
542         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
543         * TestRunnerShared/UIScriptContext/UIScriptController.h:
544         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
545         (WTR::arrayLength):
546         (WTR::parseModifierArray):
547         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
548         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
549         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
550         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
551
552 2019-02-11  Commit Queue  <commit-queue@webkit.org>
553
554         Unreviewed, rolling out r241272 and r241276.
555         https://bugs.webkit.org/show_bug.cgi?id=194514
556
557         Broke the Apple Internal build and the fix requires human
558         intervention :( (Requested by dydz on #webkit).
559
560         Reverted changesets:
561
562         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
563         https://bugs.webkit.org/show_bug.cgi?id=191446
564         https://trac.webkit.org/changeset/241272
565
566         "Fix internal iOS build after r241272"
567         https://bugs.webkit.org/show_bug.cgi?id=191446
568         https://trac.webkit.org/changeset/241276
569
570 2019-02-11  Truitt Savell  <tsavell@apple.com>
571
572         Unreviewed, rolling out r241269.
573
574         Caused 5 layout tests crashes on Mac WK1
575
576         Reverted changeset:
577
578         "DumpRenderTree should report unknown options"
579         https://bugs.webkit.org/show_bug.cgi?id=191303
580         https://trac.webkit.org/changeset/241269
581
582 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
583
584         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
585         https://bugs.webkit.org/show_bug.cgi?id=194313
586
587         Reviewed by Tim Horton.
588
589         Add a helper to determine whether the web view is presenting modal UI.
590
591         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
592         (WTR::UIScriptController::isPresentingModally const):
593         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
594         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
595         (WTR::UIScriptController::isPresentingModally const):
596         * TestRunnerShared/UIScriptContext/UIScriptController.h:
597         * WebKitTestRunner/UIScriptControllerCocoa.mm:
598         (WTR::UIScriptController::calendarType const): Deleted.
599         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
600         (WTR::UIScriptController::isPresentingModally const):
601         (WTR::UIScriptController::calendarType const):
602         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
603         (WTR::UIScriptController::calendarType const):
604
605 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
606
607         GCHeapInspector: Show the retained sizes in more places
608         https://bugs.webkit.org/show_bug.cgi?id=194464
609
610         Reviewed by Simon Fraser.
611
612         * GCHeapInspector/gc-heap-inspector.html:
613         * GCHeapInspector/script/interface.js:
614         (HeapInspectorUtils.humanReadableSize):
615         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
616         (HeapInspectorUtils.spanForNode.span.span):
617         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
618         (HeapSnapshotInspector.prototype.buildRoots):
619
620 2019-02-11  Daniel Bates  <dabates@apple.com>
621
622         [iOS] Mouse/Touch/Pointer events are missing modifier keys
623         https://bugs.webkit.org/show_bug.cgi?id=191446
624         <rdar://problem/45929460>
625
626         Reviewed by Tim Horton.
627
628         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
629
630         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
631         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
632         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
633         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
634         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
635         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
636         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
637         * TestRunnerShared/UIScriptContext/UIScriptController.h:
638         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
639         (WTR::arrayLength):
640         (WTR::parseModifierArray):
641         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
642         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
643         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
644         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
645
646 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
647
648         DumpRenderTree should report unknown options
649         https://bugs.webkit.org/show_bug.cgi?id=191303
650
651         Reviewed by Frédéric Wang.
652
653         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
654         to report unknown options.
655         Added and assigned test options which are currently used in tests.
656
657         * DumpRenderTree/TestOptions.cpp:
658         (TestOptions::TestOptions):
659
660 2019-02-11  Truitt Savell  <tsavell@apple.com>
661
662         Unreviewed, rolling out r241229.
663
664         Revision broke internal builds for watchOS.
665
666         Reverted changeset:
667
668         "[Cocoa] Ask platform for generic font family mappings"
669         https://bugs.webkit.org/show_bug.cgi?id=187723
670         https://trac.webkit.org/changeset/241229
671
672 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
673
674         [WinCairo][MiniBrowser] Basic authentication always fails.
675         https://bugs.webkit.org/show_bug.cgi?id=194496
676
677         Reviewed by Don Olmstead.
678
679         * MiniBrowser/win/DialogHelper.h:
680         (Dialog::getText):
681
682 2019-02-11  Philippe Normand  <pnormand@igalia.com>
683
684         [GStreamer] GstMappedBuffer testsuite build fails
685         https://bugs.webkit.org/show_bug.cgi?id=194495
686
687         Reviewed by Carlos Garcia Campos.
688
689         Fix the build by explicitely adding the gstreamer1.0-audio include
690         directories to the include path.
691
692         * TestWebKitAPI/PlatformGTK.cmake:
693         * TestWebKitAPI/PlatformWPE.cmake:
694
695 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
696
697         [GTK][WPE] Add enable-javascript-markup setting
698         https://bugs.webkit.org/show_bug.cgi?id=193439
699
700         Reviewed by Michael Catanzaro.
701
702         Add test cases to check the new setting.
703
704         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
705         (testWebKitSettings):
706         (testWebKitSettingsJavaScriptMarkup):
707         (beforeAll):
708
709 2019-02-10  Darin Adler  <darin@apple.com>
710
711         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
712         https://bugs.webkit.org/show_bug.cgi?id=194485
713
714         Reviewed by Daniel Bates.
715
716         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
717
718 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
719
720         Add more tests for clampTo<>()
721         https://bugs.webkit.org/show_bug.cgi?id=194462
722
723         Reviewed by Geoffrey Garen.
724
725         Darin suggested to test the very last floating point number
726         at the boundaries when truncating to integer.
727         I added test for max/min and max-1/min-1.
728
729         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
730         (TestWebKitAPI::TEST):
731
732 2019-02-09  Darin Adler  <darin@apple.com>
733
734         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
735         https://bugs.webkit.org/show_bug.cgi?id=194021
736
737         Reviewed by Geoffrey Garen.
738
739         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
740         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
741         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
742
743 2019-02-09  Zalan Bujtas  <zalan@apple.com>
744
745         [LFC][IFC] Add intrinsic width support for basic inline containers
746         https://bugs.webkit.org/show_bug.cgi?id=194473
747
748         Reviewed by Antti Koivisto.
749
750         Expand tests coverage (11 new tests -> 798)
751
752         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
753
754 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
755
756         Fix MiniBrowser's entitlements
757         https://bugs.webkit.org/show_bug.cgi?id=192431
758
759         Reviewed by Joseph Pecoraro.
760
761         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
762         files, making it impossible to load any extension.
763
764         * MiniBrowser/MiniBrowser.entitlements:
765
766 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
767
768         [Cocoa] Ask platform for generic font family mappings
769         https://bugs.webkit.org/show_bug.cgi?id=187723
770         <rdar://problem/41892438>
771
772         Reviewed by Brent Fulgham.
773
774         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
775
776         * DumpRenderTree/mac/DumpRenderTree.mm:
777         (allowedFontFamilySet):
778         * WebKitTestRunner/mac/TestControllerMac.mm:
779         (WTR::allowedFontFamilySet):
780
781 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
782
783         [GTK] Implement back/forward touchpad gesture
784         https://bugs.webkit.org/show_bug.cgi?id=193919
785
786         Reviewed by Michael Catanzaro.
787
788         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
789         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
790
791 2019-02-08  Alex Christensen  <achristensen@webkit.org>
792
793         Add SPI to use networking daemon instead of XPC service
794         https://bugs.webkit.org/show_bug.cgi?id=194427
795
796         Reviewed by Geoffrey Garen
797
798         * MiniBrowser/MiniBrowser.entitlements:
799
800 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
801
802         [ews-build] Ensure that every builder in config.json has short name
803         https://bugs.webkit.org/show_bug.cgi?id=194461
804
805         Reviewed by Lucas Forschler.
806
807         * BuildSlaveSupport/ews-build/loadConfig.py:
808         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
809
810 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-build] Add short name to config.json
813         https://bugs.webkit.org/show_bug.cgi?id=194456
814
815         Reviewed by Lucas Forschler.
816
817         * BuildSlaveSupport/ews-build/config.json: Added short name.
818         * BuildSlaveSupport/ews-build/loadConfig.py:
819         (loadBuilderConfig): Set the short name as the builder description.
820
821 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
822
823         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
824         https://bugs.webkit.org/show_bug.cgi?id=194418
825
826         Reviewed by Lucas Forschler.
827
828         Do not include errors trying when finding crashlogs at the end of
829         a run-webkit-tests run since we don't process those errors.
830
831         * Scripts/webkitpy/port/darwin.py:
832         (DarwinPort._look_for_all_crash_logs_in_log_dir):
833         * Scripts/webkitpy/port/ios_device.py:
834         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
835         * Scripts/webkitpy/port/watch_device.py:
836         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
837
838 2019-02-08  Beth Dakin  <bdakin@apple.com>
839
840         Add afterScreenUpdates to WKSnapshotConfiguration
841         https://bugs.webkit.org/show_bug.cgi?id=194362
842         -and corresponding-
843         <rdar://problem/40655528> Please add an "after screen updates" property to 
844         WKSnapshotConfiguration (to solve blank snapshots)
845
846         Reviewed by Tim Horton.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
849         (TEST):
850
851 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
852
853         clampTo(): do not convert the input to double when dealing with integers
854         https://bugs.webkit.org/show_bug.cgi?id=194263
855         <rdar://problem/47692312>
856
857         Reviewed by Darin Adler.
858
859         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
860         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
861         (TestWebKitAPI::testClampFloatingPointToInteger):
862         (TestWebKitAPI::testClampSameSignIntegers):
863         (TestWebKitAPI::testClampUnsignedToSigned):
864         (TestWebKitAPI::testClampSignedToUnsigned):
865
866 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
867
868         webkitpy: Respect --dedicated-simulators flag
869         https://bugs.webkit.org/show_bug.cgi?id=194416
870         <rdar://problem/47894722>
871
872         Reviewed by Lucas Forschler.
873
874         * Scripts/webkitpy/port/device_port.py:
875         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
876         available devices can be safely ignored.
877
878 2019-02-07  Keith Rollin  <krollin@apple.com>
879
880         Remove extra copy of 100x100-red.tga
881         https://bugs.webkit.org/show_bug.cgi?id=194371
882         <rdar://problem/47873465>
883
884         Reviewed by Said Abou-Hallawa.
885
886         In order to help it pass its tests, Bug 194190 added a second copy of
887         the file 100x100-red.tga. However, it turns out that this additional
888         file wasn't actually needed, and that that sole previous copy was
889         sufficient. At the same time, this second copy -- which was copied to
890         the same location in the build output as the first copy -- now caused
891         XCBuild to complain because there were two production rules for the
892         same output file. Address this by removing the newly-added extra copy.
893
894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
895         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
896
897 2019-02-07  Alex Christensen  <achristensen@webkit.org>
898
899         Deprecate WKBundlePageSetDefersLoading
900         https://bugs.webkit.org/show_bug.cgi?id=191394
901
902         Reviewed by Dean Jackson.
903
904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
905         (WTR::TestRunner::setDefersLoading):
906
907 2019-02-07  Zalan Bujtas  <zalan@apple.com>
908
909         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
910         https://bugs.webkit.org/show_bug.cgi?id=194391
911
912         Reviewed by Antti Koivisto.
913
914         * LayoutReloaded/misc/LFC-passing-tests.txt:
915
916 2019-02-06  Keith Rollin  <krollin@apple.com>
917
918         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
919         https://bugs.webkit.org/show_bug.cgi?id=193975
920         <rdar://problem/47643306>
921
922         Reviewed by Tim Horton.
923
924         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
925         the Info.plist file into the bundle. This step is not necessary as the
926         implicit "bundle up all the build products into a framework" build
927         phase does this already. Having the Copy Bundle Resources phase do
928         this causes a conflict under XCBuild, which objects to two build
929         phases producing the same file (Info.plist). Address this by removing
930         Info.plist from the Copy Bundle Resources phase.
931
932         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
933
934 2019-02-06  Keith Rollin  <krollin@apple.com>
935
936         Really enable the automatic checking and regenerations of .xcfilelists during builds
937         https://bugs.webkit.org/show_bug.cgi?id=194357
938         <rdar://problem/47861231>
939
940         Reviewed by Chris Dumez.
941
942         Bug 194124 was supposed to enable the automatic checking and
943         regenerating of .xcfilelist files during the build. While related
944         changes were included in that patch, the change to actually enable the
945         operation somehow was omitted. This patch actually enables the
946         operation. The check-xcfilelist.sh scripts now check
947         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
948         from the checking.
949
950         * DumpRenderTree/Scripts/check-xcfilelists.sh:
951         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
952
953 2019-02-06  David Kilzer  <ddkilzer@apple.com>
954
955         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
956         <https://webkit.org/b/194286>
957         <rdar://problem/47815558>
958
959         Reviewed by Alexey Proskuryakov.
960
961         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
962         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
963         WKRetainPtr<> to avoid leaking the WKDataRef.
964
965 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
966
967         Unreviewed, fix a typo
968
969         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
970
971 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
972
973         [GTK][WPE] force libpsl build to use ICU in jhbuild
974         https://bugs.webkit.org/show_bug.cgi?id=194288
975
976         Reviewed by Carlos Garcia Campos.
977
978         * gtk/jhbuild.modules:
979         Require ICU for libpsl build in jhbuild, like done in WPE.
980
981 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
982
983         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
984         https://bugs.webkit.org/show_bug.cgi?id=194209
985
986         Reviewed by Carlos Garcia Campos.
987
988         Enhance TestCookieManager to ensure this doesn't happen again.
989
990         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
991         (testCookieManagerPersistentStorage):
992         (beforeAll):
993
994 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
997         https://bugs.webkit.org/show_bug.cgi?id=194324
998
999         Reviewed by Andy Estes.
1000
1001         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1002         part of the name is already implicit, since this is in testing code in TestOptions.
1003
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::TestController::generateContextConfiguration const):
1006         (WTR::updateTestOptionsFromTestHeader):
1007         * WebKitTestRunner/TestOptions.h:
1008         (WTR::TestOptions::hasSameInitializationOptions const):
1009
1010 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1011
1012         [ews-build] Allow * as platform for builders and workers
1013         https://bugs.webkit.org/show_bug.cgi?id=188533
1014
1015         Reviewed by Lucas Forschler.
1016
1017         * BuildSlaveSupport/ews-build/loadConfig.py:
1018         (checkWorkersAndBuildersForConsistency):
1019
1020 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1021
1022         [ews-build] Add few bots to config.json
1023         https://bugs.webkit.org/show_bug.cgi?id=194304
1024
1025         Reviewed by Lucas Forschler.
1026
1027         * BuildSlaveSupport/ews-build/config.json:
1028
1029 2019-02-05  Keith Rollin  <krollin@apple.com>
1030
1031         Enable the automatic checking and regenerations of .xcfilelists during builds
1032         https://bugs.webkit.org/show_bug.cgi?id=194124
1033         <rdar://problem/47721277>
1034
1035         Reviewed by Tim Horton.
1036
1037         Bug 193790 add a facility for checking -- during build time -- that
1038         any needed .xcfilelist files are up-to-date and for updating them if
1039         they are not. This facility was initially opt-in by setting
1040         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1041         the process seemed robust. Its now time to enable this facility and
1042         make it opt-out. If there is a need to disable this facility, set and
1043         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1044         running `make` or `build-webkit`, or before running Xcode from the
1045         command line.
1046
1047         Additionally, remove the step that generates a list of source files
1048         going into the UnifiedSources build step. It's only necessarily to
1049         specify Sources.txt and SourcesCocoa.txt as inputs.
1050
1051         * Scripts/generate-xcfilelists:
1052
1053 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1054
1055         [GTK][WPE] force libpsl build to use ICU in jhbuild
1056         https://bugs.webkit.org/show_bug.cgi?id=194288
1057
1058         Reviewed by Philippe Normand.
1059
1060         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1061         This can cause build failures if libidn is detected but libunistring is not available.
1062
1063         Make sure that ICU is used for runtime and builtin PSL data.
1064
1065         * gtk/jhbuild.modules:
1066         * wpe/jhbuild.modules:
1067
1068 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1069
1070         [ews-app] Modified timestamp should be updated on updating data
1071         https://bugs.webkit.org/show_bug.cgi?id=194295
1072
1073         Reviewed by Lucas Forschler.
1074
1075         * BuildSlaveSupport/ews-app/ews/models/build.py:
1076         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1077         * BuildSlaveSupport/ews-app/ews/models/step.py:
1078
1079 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1080
1081         Unreviewed, rolling out r240742.
1082
1083         Causes crashes on iOS simulator.
1084
1085         Reverted changeset:
1086
1087         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1088         not focused in a content-editable element"
1089         https://bugs.webkit.org/show_bug.cgi?id=192824
1090         https://trac.webkit.org/changeset/240742
1091
1092 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1093
1094         run-webkit-tests emits message "...running None" when running tests
1095         https://bugs.webkit.org/show_bug.cgi?id=194133
1096         <rdar://problem/47724738>
1097
1098         Reviewed by Lucas Forschler.
1099
1100         * Scripts/webkitpy/xcode/device_type.py:
1101         (DeviceType.__str__): Use both version mapping tables and use just the variant
1102         name if no version name is available.
1103         * Scripts/webkitpy/xcode/device_type_unittest.py:
1104         (DeviceTypeTest):
1105         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1106         an associated named.
1107
1108 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1109
1110         [WPE] require python3-setuptools for meson build in jhbuild
1111         https://bugs.webkit.org/show_bug.cgi?id=194287
1112
1113         Reviewed by Philippe Normand.
1114
1115         python3-setuptools is needed to build meson in jhbuild.
1116         It is already required by the GTK port.
1117
1118         * wpe/install-dependencies:
1119
1120 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1121
1122         [ews-app] Add method to save BuilderMapping to database
1123         https://bugs.webkit.org/show_bug.cgi?id=194264
1124
1125         Reviewed by Lucas Forschler.
1126
1127         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1128         (BuilderMapping.__str__):
1129         (BuilderMapping):
1130         (BuilderMapping.save_mapping):
1131         (BuilderMapping.update_mapping):
1132         (BuilderMapping.get_existing_mapping):
1133         (BuilderMapping.is_valid_mapping):
1134
1135 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1136
1137         [ews-app] Add timestamp fields for BuilderMappings
1138         https://bugs.webkit.org/show_bug.cgi?id=194266
1139
1140         Reviewed by Lucas Forschler.
1141
1142         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1143         (BuilderMapping):
1144
1145 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1146
1147         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1148         https://bugs.webkit.org/show_bug.cgi?id=174816
1149
1150         Reviewed by Michael Catanzaro.
1151
1152         Add tests for webkit_uri_for_display().
1153
1154         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1155         (testURIForDisplayUnaffected):
1156         (testURIForDisplayAffected):
1157         (beforeAll):
1158         (afterAll):
1159         * TestWebKitAPI/glib/CMakeLists.txt:
1160
1161 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1162
1163         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1164         https://bugs.webkit.org/show_bug.cgi?id=194158
1165         <rdar://problem/47737268>
1166
1167         Rubber-stamped by Aakash Jain.
1168
1169         * Scripts/webkitpy/port/device_port.py:
1170         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1171
1172 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1173
1174         [CG] Enable setAdditionalSupportedImageTypes for WK1
1175         https://bugs.webkit.org/show_bug.cgi?id=194190
1176
1177         Reviewed by Tim Horton.
1178
1179         Add a test similar to the one under WebKit Cocoa but make it create a
1180         WebView instead of a WKWebView.
1181
1182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1183         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1184         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1185         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1186         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1187         (TestWebKitAPI::runTest):
1188         (TestWebKitAPI::TEST):
1189
1190 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1191
1192         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1193         https://bugs.webkit.org/show_bug.cgi?id=194168
1194
1195         Reviewed by Simon Fraser.
1196
1197         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1198
1199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1200         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1201         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1202         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1203         (TEST):
1204         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1205         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1206
1207 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1208
1209         REGRESSION (r237269): webkit-patch what-broke is broken 
1210         https://bugs.webkit.org/show_bug.cgi?id=193025
1211
1212         Reviewed by Aakash Jain.
1213
1214         * Scripts/webkitpy/common/host.py:
1215         (Host.buildbot):
1216         (Host.bugzilla): Renamed to 'buildbot'.
1217
1218 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1219
1220         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1221         https://bugs.webkit.org/show_bug.cgi?id=194207
1222
1223         Reviewed by Tim Horton.
1224
1225         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1226         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1227         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1228         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1229         start and delete forwards to remove the original attachment.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1232         (TestWebKitAPI::TEST):
1233
1234 2019-02-04  Youenn Fablet  <youenn@apple.com>
1235
1236         Capture state should be managed consistently when doing process swapping
1237         https://bugs.webkit.org/show_bug.cgi?id=194122
1238         <rdar://problem/47609293>
1239
1240         Reviewed by Eric Carlson.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1243         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1244         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1245         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1246         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1248         (WTR::TestRunner::isDoingMediaCapture const):
1249         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1250         * WebKitTestRunner/TestController.cpp:
1251         (WTR::TestController::isDoingMediaCapture const):
1252         * WebKitTestRunner/TestController.h:
1253         * WebKitTestRunner/TestInvocation.cpp:
1254         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1255         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1256         (WTR::TestController::isDoingMediaCapture const):
1257
1258 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1259
1260         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1261         https://bugs.webkit.org/show_bug.cgi?id=194142
1262
1263         Reviewed by Ross Kirsling.
1264
1265         There three 'separator' variables in TestController.cpp. Renamed
1266         it 'pathSeparator', and unified them.
1267
1268         * WebKitTestRunner/TestController.cpp:
1269         (WTR::TestController::generateContextConfiguration const):
1270         (WTR::createTestURL):
1271         (WTR::TestController::platformAdjustContext):
1272
1273 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1274
1275         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1276         https://bugs.webkit.org/show_bug.cgi?id=194198
1277
1278         Reviewed by Antti Koivisto.
1279
1280         No need to set the banner heights on navigation now, since Page stores them.
1281
1282         * MiniBrowser/mac/WK2BrowserWindowController.m:
1283         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1284
1285 2019-02-03  John Wilander  <wilander@apple.com>
1286
1287         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1288         https://bugs.webkit.org/show_bug.cgi?id=194104
1289         <rdar://problem/47649991>
1290
1291         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1292
1293         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1294         (TestWebKitAPI::TEST):
1295             Changed numeric types from unsigned short to uint32_t.
1296
1297 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1298
1299         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1300         <https://webkit.org/b/194178>
1301         <rdar://problem/47753473>
1302
1303         Reviewed by Alexey Proskuryakov.
1304
1305         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1306         (WTR::uninstallFakeHelvetica): Pass nullptr into
1307         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1308
1309 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1310
1311         [LFC] Initialize ICB's style with fixed width/height.
1312         https://bugs.webkit.org/show_bug.cgi?id=194188
1313
1314         Reviewed by Antti Koivisto.
1315
1316         * LayoutReloaded/misc/LFC-passing-tests.txt:
1317
1318 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1319
1320         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1321         https://bugs.webkit.org/show_bug.cgi?id=194185
1322
1323         Reviewed by Antti Koivisto.
1324
1325         * LayoutReloaded/misc/LFC-passing-tests.txt:
1326
1327 2018-12-16  Darin Adler  <darin@apple.com>
1328
1329         Convert additional String::format clients to alternative approaches
1330         https://bugs.webkit.org/show_bug.cgi?id=192746
1331
1332         Reviewed by Alexey Proskuryakov.
1333
1334         * WebKitTestRunner/TestController.cpp:
1335         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1336         as an intermediate in code that ultimately constructs a WTF::String.
1337         (WTR::userMediaOriginHash): Use makeString.
1338         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1339         (WTR::TestController::didPerformClientRedirect): Ditto.
1340         (WTR::TestController::didPerformServerRedirect): Ditto.
1341         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1342
1343 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1344
1345         [ews-build] Add unit test to verify builder keys
1346         https://bugs.webkit.org/show_bug.cgi?id=194152
1347
1348         Reviewed by Lucas Forschler.
1349
1350         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1351         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1352
1353 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1354
1355         [LFC] Expand tests coverage (12 new tests -> 787)
1356
1357         Unreviewed test gardening.
1358
1359         * LayoutReloaded/misc/LFC-passing-tests.txt:
1360
1361 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1362
1363         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1364         https://bugs.webkit.org/show_bug.cgi?id=194163
1365
1366         Reviewed by Simon Fraser.
1367
1368         775
1369
1370         * LayoutReloaded/misc/LFC-passing-tests.txt:
1371
1372 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1373
1374         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1375         https://bugs.webkit.org/show_bug.cgi?id=194140
1376         <rdar://problem/47728098>
1377
1378         Reviewed by Tim Horton.
1379
1380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1382         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1383
1384         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1385         test to induce an IPC deadlock when presenting a modal alert during touch start.
1386
1387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1388         * WebKitTestRunner/TestController.cpp:
1389         (WTR::runJavaScriptAlert):
1390
1391         Add a client callback function for running JavaScript alerts.
1392
1393         (WTR::TestController::createOtherPage):
1394         (WTR::TestController::generateContextConfiguration const):
1395
1396         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1397         the fix in this patch.
1398
1399         (WTR::TestController::createWebViewWithOptions):
1400
1401         Plumb TestOptions to generateContextConfiguration.
1402
1403         (WTR::TestController::resetPreferencesToConsistentValues):
1404         (WTR::TestController::resetStateToConsistentValues):
1405         (WTR::updateTestOptionsFromTestHeader):
1406         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1407         (WTR::TestController::handleJavaScriptAlert):
1408         * WebKitTestRunner/TestController.h:
1409         * WebKitTestRunner/TestInvocation.cpp:
1410         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1411         * WebKitTestRunner/TestOptions.h:
1412         (WTR::TestOptions::hasSameInitializationOptions const):
1413
1414 2019-02-01  Chris Dumez  <cdumez@apple.com>
1415
1416         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1417         https://bugs.webkit.org/show_bug.cgi?id=193740
1418         <rdar://problem/47527267>
1419
1420         Reviewed by Alex Christensen.
1421
1422         Add API test coverage.
1423
1424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1425
1426 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1427
1428         [ews-app] Add display name field to BuilderMapping model
1429         https://bugs.webkit.org/show_bug.cgi?id=194153
1430
1431         Reviewed by Lucas Forschler.
1432
1433         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1434         (BuilderMapping):
1435
1436 2019-02-01  Youenn Fablet  <youenn@apple.com>
1437
1438         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1439         https://bugs.webkit.org/show_bug.cgi?id=194155
1440
1441         Reviewed by Eric Carlson.
1442
1443         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1444         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1445         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1446
1447 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1448
1449         [LFC] Adjust replaced element's intrinsic ratio
1450         https://bugs.webkit.org/show_bug.cgi?id=194154
1451
1452         Reviewed by Antti Koivisto.
1453
1454         761
1455
1456         * LayoutReloaded/misc/LFC-passing-tests.txt:
1457
1458 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1459
1460         [WPE] Show test results in minibrowser
1461         https://bugs.webkit.org/show_bug.cgi?id=194150
1462
1463         Reviewed by Žan Doberšek.
1464
1465         * Scripts/webkitpy/port/wpe.py:
1466         (WPEPort.show_results_html_file):
1467
1468 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1469
1470         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1471         https://bugs.webkit.org/show_bug.cgi?id=194151
1472
1473         Reviewed by Žan Doberšek.
1474
1475         ALT + <- go back
1476         ALT + -> go forward
1477
1478         * MiniBrowser/wpe/main.cpp:
1479         (main):
1480
1481 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1482
1483         [LFC] Set intrinsic size on Layout::Replaced
1484         https://bugs.webkit.org/show_bug.cgi?id=194139
1485
1486         Reviewed by Antti Koivisto.
1487
1488         744
1489
1490         * LayoutReloaded/misc/LFC-passing-tests.txt:
1491
1492 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1493
1494         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1495         https://bugs.webkit.org/show_bug.cgi?id=194146
1496
1497         Reviewed by Xabier Rodriguez-Calvar.
1498
1499         It allows to open relative paths.
1500
1501         * MiniBrowser/wpe/main.cpp:
1502         (main):
1503
1504 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1505
1506         Update flakiness dashboard configuration after recent queue changes
1507         https://bugs.webkit.org/show_bug.cgi?id=194127
1508
1509         Rubber-stamped by Aakash Jain.
1510
1511         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1512
1513         * TestResultServer/static-dashboards/builders.jsonp:
1514
1515 2019-01-31  Youenn Fablet  <youenn@apple.com>
1516
1517         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1518         https://bugs.webkit.org/show_bug.cgi?id=194106
1519         <rdar://problem/47676333>
1520
1521         Reviewed by Ryosuke Niwa.
1522
1523         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1524         (TestWebKitAPI::didFinishNavigation):
1525         (TestWebKitAPI::TEST):
1526         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1527
1528 2019-01-31  Chris Dumez  <cdumez@apple.com>
1529
1530         Page zoom level is lost after a process swap or a crash
1531         https://bugs.webkit.org/show_bug.cgi?id=194105
1532         <rdar://problem/47610781>
1533
1534         Reviewed by Alex Christensen.
1535
1536         Add API test coverage.
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1539         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1540
1541 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1542
1543         Revert r238819 which is unneeded and caused a performance regression.
1544         https://bugs.webkit.org/show_bug.cgi?id=192272
1545         <rdar://problem/46664625>
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1548         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1549         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1550
1551 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1552
1553         Formalize WebKitAdditions mechanism of LoadOptimizer
1554         https://bugs.webkit.org/show_bug.cgi?id=193886
1555         <rdar://problem/47696809>
1556
1557         Reviewed by Brent Fulgham.
1558
1559         * MiniBrowser/MiniBrowser.entitlements:
1560         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1561
1562 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1563
1564         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1565         https://bugs.webkit.org/show_bug.cgi?id=194090
1566
1567         Reviewed by Antti Koivisto.
1568
1569         * LayoutReloaded/misc/LFC-passing-tests.txt:
1570
1571 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1572
1573         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1574         https://bugs.webkit.org/show_bug.cgi?id=194074
1575
1576         Reviewed by Antti Koivisto.
1577
1578         * LayoutReloaded/misc/LFC-passing-tests.txt:
1579
1580 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1581
1582         [LFC][BFC] Add support for block level replaced box.
1583         https://bugs.webkit.org/show_bug.cgi?id=194071
1584
1585         Reviewed by Antti Koivisto.
1586
1587         * LayoutReloaded/misc/LFC-passing-tests.txt:
1588
1589 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1590
1591         Fix WebKitTestRunner's testPath with Windows full paths
1592         https://bugs.webkit.org/show_bug.cgi?id=194012
1593
1594         Reviewed by Alex Christensen.
1595
1596         updateTestOptionsFromTestHeader failed to open test files because
1597         testPath returned wrong file paths. It returned a path "/C:/..."
1598         if a URL "file:///C:/..." was given.
1599
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1602
1603 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1604
1605         [WPE] Bump font related dependencies to match the GTK+ port
1606         https://bugs.webkit.org/show_bug.cgi?id=194017
1607
1608         Reviewed by Žan Doberšek.
1609
1610         * wpe/jhbuild.modules:
1611         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1612         * wpe/patches/icudata-stdlibs.patch: Added.
1613
1614 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1615
1616         Enable swipe tests on iOS
1617         https://bugs.webkit.org/show_bug.cgi?id=194076
1618
1619         Reviewed by Geoffrey Garen.
1620
1621         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1622         it causes a debug assertion failure in runUIScript.
1623
1624         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1625         (WTR::UIScriptController::beginBackSwipe):
1626         (WTR::UIScriptController::completeBackSwipe):
1627
1628 2019-01-30  Keith Rollin  <krollin@apple.com>
1629
1630         Use correct printf format specifier
1631         https://bugs.webkit.org/show_bug.cgi?id=194062
1632         <rdar://problem/47686167>
1633
1634         Reviewed by Alexey Proskuryakov.
1635
1636         LayoutTestSpellChecker.mm is trying to format a variable of type
1637         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1638         actually an unsigned long long. Fix this by formatting with %llu.
1639
1640         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1641         (-[LayoutTestTextCheckingResult description]):
1642
1643 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1644
1645         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1646         https://bugs.webkit.org/show_bug.cgi?id=193979
1647
1648         Reviewed by Wenson Hsieh.
1649
1650         Fix the test for iOS. Make the test work with iOS UA string.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1653
1654 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1655
1656         Replace High Sierra LLINT CLoop bot due to hardware failure
1657         https://bugs.webkit.org/show_bug.cgi?id=194066
1658
1659         Reviewed by Aakash Jain.
1660
1661         * BuildSlaveSupport/build.webkit.org-config/config.json:
1662
1663 2019-01-30  Keith Rollin  <krollin@apple.com>
1664
1665         [NSDragItem init] is unavailable
1666         https://bugs.webkit.org/show_bug.cgi?id=194059
1667         <rdar://problem/47685715>
1668
1669         Reviewed by Wenson Hsieh.
1670
1671         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1672         DumpRenderTree and TestWebKitAPI, which both try to create an
1673         NSDragItem in a manner that invokes this method. Address this by using
1674         -initWithPasteboardWriter instead.
1675
1676         Note that the parameter passed to initWithPasteboardWriter is likely
1677         incorrect. In both cases, the object passed does not conform to
1678         NSPasteboardWriting. However, with this fix, we're no worse off than
1679         before, and can now perform builds with newer compilers and SDKs until
1680         a real fix can be crafted. That work is tracked in
1681         https://bugs.webkit.org/show_bug.cgi?id=194060
1682
1683         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1684         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1685         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1686         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1687
1688 2019-01-30  Daniel Bates  <dabates@apple.com>
1689
1690         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1691         https://bugs.webkit.org/show_bug.cgi?id=192824
1692         <rdar://problem/47100332>
1693
1694         Reviewed by Wenson Hsieh.
1695
1696         Fix a bug where the wrong usage code was used for F13 thru F24.
1697
1698         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1699         (keyCodeForDOMFunctionKey):
1700
1701 2019-01-30  Chris Dumez  <cdumez@apple.com>
1702
1703         Regression(PSON) Load hang can occur on history navigation
1704         https://bugs.webkit.org/show_bug.cgi?id=194030
1705         <rdar://problem/47656939>
1706
1707         Reviewed by Antti Koivisto.
1708
1709         Add API test coverage.
1710
1711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1712
1713 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1714
1715         [LFC] Expand tests coverage.
1716
1717         Unreviewed test gardening.
1718
1719         * LayoutReloaded/misc/LFC-passing-tests.txt:
1720
1721 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1722
1723         [Flatpak] Add openjpeg support
1724         https://bugs.webkit.org/show_bug.cgi?id=194019
1725
1726         Reviewed by Michael Catanzaro.
1727
1728         * flatpak/org.webkit.CommonModules.yaml:
1729
1730 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1731
1732         Unreviewed, rolling out r240708.
1733         https://bugs.webkit.org/show_bug.cgi?id=194022
1734
1735         It broke WPE build (Requested by KaL on #webkit).
1736
1737         Reverted changeset:
1738
1739         "[WPE] Bump font related dependencies to match the GTK+ port"
1740         https://bugs.webkit.org/show_bug.cgi?id=194017
1741         https://trac.webkit.org/changeset/240708
1742
1743 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1744
1745         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1746         https://bugs.webkit.org/show_bug.cgi?id=194001
1747
1748         Reviewed by Antti Koivisto.
1749
1750         * LayoutReloaded/misc/LFC-passing-tests.txt:
1751
1752 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1753
1754         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1755         https://bugs.webkit.org/show_bug.cgi?id=194020
1756
1757         Reviewed by Antti Koivisto.
1758
1759         * LayoutReloaded/misc/LFC-passing-tests.txt:
1760
1761 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1762
1763         AX: Support color well on iOS
1764         https://bugs.webkit.org/show_bug.cgi?id=194010
1765
1766         Reviewed by Joanmarie Diggs.
1767
1768         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1769         (WTR::AccessibilityUIElement::stringAttributeValue):
1770
1771 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1772
1773         [WPE] Bump font related dependencies to match the GTK+ port
1774         https://bugs.webkit.org/show_bug.cgi?id=194017
1775
1776         Reviewed by Žan Doberšek.
1777
1778         * wpe/jhbuild.modules:
1779         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1780         * wpe/patches/icudata-stdlibs.patch: Added.
1781
1782 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1783
1784         [Mac] Update window scale API usage
1785         https://bugs.webkit.org/show_bug.cgi?id=193991
1786         rdar://problem/47614795
1787
1788         Reviewed by Tim Horton.
1789
1790         * DumpRenderTree/mac/DumpRenderTree.mm:
1791         (changeWindowScaleIfNeeded):
1792         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1793         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1794         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1795
1796 2019-01-29  Chris Dumez  <cdumez@apple.com>
1797
1798         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1799         https://bugs.webkit.org/show_bug.cgi?id=193977
1800         <rdar://problem/47643716>
1801
1802         Reviewed by Geoff Garen.
1803
1804         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1805         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1806         to the previous provisional committing *before* we make the last load. 
1807
1808         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1809
1810 2019-01-29  Youenn Fablet  <youenn@apple.com>
1811
1812         Adopt new SPI to evaluate server certificate trust
1813         https://bugs.webkit.org/show_bug.cgi?id=193355
1814
1815         Reviewed by Alex Christensen.
1816
1817         Add infrastructure to handle HTTPS server trust evaluation testing.
1818
1819         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1821         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1822         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1823         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::resetPreferencesToConsistentValues):
1827         (WTR::TestController::didReceiveAuthenticationChallenge):
1828         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1829         * WebKitTestRunner/TestController.h:
1830         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1831         * WebKitTestRunner/TestInvocation.cpp:
1832         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1833         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1834         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1835
1836 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1837
1838         [ews-build] Add build step to print bot Configuration
1839         https://bugs.webkit.org/show_bug.cgi?id=193887
1840
1841         Reviewed by Lucas Forschler.
1842
1843         * BuildSlaveSupport/ews-build/steps.py:
1844         (PrintConfiguration): Build step to print configuration.
1845         * BuildSlaveSupport/ews-build/factories.py:
1846
1847 2019-01-29  Chris Dumez  <cdumez@apple.com>
1848
1849         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1850         https://bugs.webkit.org/show_bug.cgi?id=193967
1851         <rdar://problem/47635348>
1852
1853         Reviewed by Alex Christensen.
1854
1855         Add API test coverage.
1856
1857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1858         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1859
1860 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1861
1862         [ews-app] Handle incoming results data
1863         https://bugs.webkit.org/show_bug.cgi?id=193973
1864
1865         Reviewed by Lucas Forschler.
1866
1867         * BuildSlaveSupport/ews-app/ews/views/results.py:
1868
1869 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1870
1871         [ews-app] Make the results url generic
1872         https://bugs.webkit.org/show_bug.cgi?id=193928
1873
1874         Reviewed by Lucas Forschler.
1875
1876         * BuildSlaveSupport/ews-app/ews/urls.py:
1877
1878 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1879
1880         [ews-build] Configure buildbot to send events to ews-app
1881         https://bugs.webkit.org/show_bug.cgi?id=193968
1882
1883         Reviewed by Lucas Forschler.
1884
1885         * BuildSlaveSupport/ews-build/events.py: Added.
1886         * BuildSlaveSupport/ews-build/master.cfg:
1887
1888 2019-01-29  Keith Rollin  <krollin@apple.com>
1889
1890         Add .xcfilelists to Run Script build phases
1891         https://bugs.webkit.org/show_bug.cgi?id=193792
1892         <rdar://problem/47201785>
1893
1894         Reviewed by Alex Christensen.
1895
1896         As part of supporting XCBuild, update the necessary Run Script build
1897         phases in their Xcode projects to refer to their associated
1898         .xcfilelist files.
1899
1900         Note that the addition of these files bumps the Xcode project version
1901         number to something that's Xcode 10 compatible. This change means that
1902         older versions of the Xcode IDE can't read these projects. Nor can it
1903         fully load workspaces that refer to these projects (the updated
1904         projects are shown as non-expandable placeholders). `xcodebuild` can
1905         still build these projects; it's just that the IDE can't open them.
1906
1907         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1908         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1909
1910 2019-01-29  John Wilander  <wilander@apple.com>
1911
1912         Add data abstraction and validation for Ad Click Attribution
1913         https://bugs.webkit.org/show_bug.cgi?id=193916
1914         <rdar://problem/47603481>
1915
1916         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1917
1918         Ad click attribution has two steps. First, the storage of an ad
1919         campaign ID for a click that takes the user to a destination
1920         site. Second, a conversion on the destination site that can be
1921         attributed to the ad click.
1922
1923         This patch adds a class that represents a request for ad click
1924         attribution. Validation makes sure that the bits of entropy
1925         reported through this mechanism is limited.
1926
1927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1928         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1929         (TestWebKitAPI::TEST):
1930
1931 2019-01-29  Chris Dumez  <cdumez@apple.com>
1932
1933         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1934         https://bugs.webkit.org/show_bug.cgi?id=193932
1935         <rdar://problem/47598947>
1936
1937         Reviewed by Brady Eidson.
1938
1939         Add API test coverage.
1940
1941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1942
1943 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1944
1945         Adding new passing LFC tests.
1946
1947         Unreviewed test gardening.
1948
1949         * LayoutReloaded/misc/LFC-passing-tests.txt:
1950
1951 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1952
1953         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1954         https://bugs.webkit.org/show_bug.cgi?id=193964
1955
1956         Reviewed by Antti Koivisto.
1957
1958         * LayoutReloaded/misc/LFC-passing-tests.txt:
1959
1960 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1961
1962         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1963         https://bugs.webkit.org/show_bug.cgi?id=193954
1964
1965         Reviewed by Antti Koivisto.
1966
1967         * LayoutReloaded/misc/LFC-passing-tests.txt:
1968
1969 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1970
1971         WebDriver: add support for running subtests
1972         https://bugs.webkit.org/show_bug.cgi?id=193904
1973
1974         Reviewed by Michael Catanzaro.
1975
1976         pytest already supports it by passing test.py::subtest, so we can do the same.
1977
1978         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1979         (get_item_name): Made this global.
1980         (CollectRecorder.__init__): Receive the parameter to ignore.
1981         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1982         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1983         (collect): Add parameter to ignore.
1984         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1985         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1986         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1987         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1988         (WebDriverTestRunnerSelenium.run): Ditto.
1989         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1990         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1991         (WebDriverTestRunnerW3C.run): Ditto.
1992
1993 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1994
1995         User agent string override for navigator.userAgent should be site specific quirks
1996         https://bugs.webkit.org/show_bug.cgi?id=193950
1997
1998         Reviewed by Brent Fulgham.
1999
2000         Updated per the _WKWebsitePolicies rename.
2001
2002         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2003         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2004
2005 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2006
2007         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2008         https://bugs.webkit.org/show_bug.cgi?id=193941
2009
2010         Reviewed by Alex Christensen.
2011
2012         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2013         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2014         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2015         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2016         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2017         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2018         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2019         * TestWebKitAPI/Tests/WTF/Time.cpp:
2020         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2021         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2022         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2023         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2024
2025 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2026
2027         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2028
2029         * Scripts/webkitpy/common/config/contributors.json:
2030
2031 2019-01-28  Andy Estes  <aestes@apple.com>
2032
2033         [watchOS] Enable Parental Controls content filtering
2034         https://bugs.webkit.org/show_bug.cgi?id=193939
2035         <rdar://problem/46641912>
2036
2037         Reviewed by Ryosuke Niwa.
2038
2039         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2040
2041 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2042
2043         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2044         <https://webkit.org/b/193884>
2045
2046         Reviewed by Jiewen Tan.
2047
2048         * Scripts/webkitpy/style/checkers/cpp.py:
2049         (check_language): Add LocalAuthentication to
2050         `frameworks_with_soft_links`.
2051
2052 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2053
2054         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2055         https://bugs.webkit.org/show_bug.cgi?id=193891
2056
2057         Reviewed by Ross Kirsling.
2058
2059         There were three problems in window sizes of WebView and the host window.
2060         1. The sizes of pixel image output were incorrect.
2061         2. The host window is going to appear after window.resize was invoked.
2062         3. window.resize resized only the host window, not WebView.
2063
2064         This change solves them with a following approach.
2065         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2066         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2067            as well as DumpRenderTree in order to match the client area and the window area.
2068         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2069         d. PlatformWebView::setWindowFrame changes both window sizes.
2070         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2071
2072         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2073         (WTR::PlatformWebView::PlatformWebView): Create the host window
2074         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2075         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2076         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2077
2078 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-app] Add method to save Step data to database
2081         https://bugs.webkit.org/show_bug.cgi?id=193890
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-app/ews/models/step.py:
2086         (Step.save_step): Method to save step data.
2087         (Step.update_step): Method to update step data.
2088         (Step.get_existing_step): Method to fetch existing step from database.
2089         (Step.is_valid_result): Method to validate valid step result.
2090
2091 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2092
2093         [ews-app] Add method to save Build data to database
2094         https://bugs.webkit.org/show_bug.cgi?id=193735
2095
2096         Reviewed by Lucas Forschler.
2097
2098         * BuildSlaveSupport/ews-app/ews/models/build.py:
2099         (Build.save_build): Method to save build information to database.
2100         (Build.get_existing_build): Method to fetch existing build from database.
2101         (Build.is_valid_result): Method to validate build result.
2102         * BuildSlaveSupport/ews-app/ews/common/util.py:
2103         (is_valid_int_id): Method to validate valid id.
2104
2105 2019-01-28  Chris Dumez  <cdumez@apple.com>
2106
2107         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2108         https://bugs.webkit.org/show_bug.cgi?id=193915
2109         <rdar://problem/47560907>
2110
2111         Reviewed by Alex Christensen.
2112
2113         Add API test coverage.
2114
2115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2116
2117 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2118
2119         [ews-app] Rename id variables
2120         https://bugs.webkit.org/show_bug.cgi?id=193883
2121
2122         Reviewed by Lucas Forschler.
2123
2124         * BuildSlaveSupport/ews-app/ews/models/build.py:
2125         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2126         * BuildSlaveSupport/ews-app/ews/models/step.py:
2127         * BuildSlaveSupport/ews-app/ews/urls.py:
2128         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2129         * BuildSlaveSupport/ews-app/ews/views/results.py:
2130         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2131
2132 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2133
2134         [ews-app] Allow certain fields to be empty
2135         https://bugs.webkit.org/show_bug.cgi?id=193892
2136
2137         Reviewed by Lucas Forschler.
2138
2139         * BuildSlaveSupport/ews-app/ews/models/build.py:
2140         * BuildSlaveSupport/ews-app/ews/models/step.py:
2141
2142 2019-01-28  Rob Buis  <rbuis@igalia.com>
2143
2144         Update MIME type parser
2145         https://bugs.webkit.org/show_bug.cgi?id=180526
2146
2147         Reviewed by Frédéric Wang.
2148
2149         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2150         (TestWebKitAPI::TEST):
2151
2152 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2153
2154         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2155         https://bugs.webkit.org/show_bug.cgi?id=193896
2156
2157         Reviewed by Antti Koivisto.
2158
2159         * LayoutReloaded/misc/LFC-passing-tests.txt:
2160
2161 2018-12-15  Darin Adler  <darin@apple.com>
2162
2163         Replace many uses of String::format with more type-safe alternatives
2164         https://bugs.webkit.org/show_bug.cgi?id=192742
2165
2166         Reviewed by Mark Lam.
2167
2168         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2169         (WTR::cacheTestRunnerCallback): Use makeString.
2170         * WebKitTestRunner/TestController.cpp:
2171         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2172         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2173
2174 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2175
2176         Use a load optimizer for some sites
2177         https://bugs.webkit.org/show_bug.cgi?id=193881
2178         <rdar://problem/46325455>
2179
2180         Reviewed by Brent Fulgham.
2181
2182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2183         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2184
2185 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2186
2187         AX: Introduce a static accessibility tree
2188         https://bugs.webkit.org/show_bug.cgi?id=193348
2189         <rdar://problem/47203295>
2190
2191         Reviewed by Ryosuke Niwa.
2192
2193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2194
2195 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2196
2197         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2198         https://bugs.webkit.org/show_bug.cgi?id=193867
2199
2200         Reviewed by Antti Koivisto.
2201
2202         * LayoutReloaded/misc/LFC-passing-tests.txt:
2203
2204 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2205
2206         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2207         https://bugs.webkit.org/show_bug.cgi?id=193865
2208
2209         Reviewed by Antti Koivisto.
2210
2211         * LayoutReloaded/misc/LFC-passing-tests.txt:
2212
2213 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2214
2215         Need a mechanism to override navigator.userAgent
2216         https://bugs.webkit.org/show_bug.cgi?id=193762
2217         <rdar://problem/47504939>
2218
2219         Reviewed by Brent Fulgham.
2220
2221         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2222
2223         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2224         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2225         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2226
2227 2019-01-25  Dean Jackson  <dino@apple.com>
2228
2229         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2230         https://bugs.webkit.org/show_bug.cgi?id=193831
2231         <rdar://problem/47399263>
2232
2233         Reviewed by Chris Dumez.
2234
2235         Two new tests that exercise cross-origin and same-origin System
2236         Previews.
2237
2238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2239
2240 2019-01-25  Keith Rollin  <krollin@apple.com>
2241
2242         Update Xcode projects with "Check .xcfilelists" build phase
2243         https://bugs.webkit.org/show_bug.cgi?id=193790
2244         <rdar://problem/47201374>
2245
2246         Reviewed by Alex Christensen.
2247
2248         Support for XCBuild includes specifying inputs and outputs to various
2249         Run Script build phases. These inputs and outputs are specified as
2250         .xcfilelist files. Once created, these .xcfilelist files need to be
2251         kept up-to-date. In order to check that they are up-to-date or not,
2252         add an Xcode build step that invokes an external script that performs
2253         the checking. If the .xcfilelists are found to be out-of-date, update
2254         them, halt the build, and instruct the developer to restart the build
2255         with up-to-date files.
2256
2257         At this time, the checking and regenerating is performed only if the
2258         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2259         who want to use this facility can set this variable and test out the
2260         checking/regenerating. Once it seems like there are no egregious
2261         issues that upset a developer's workflow, we'll unconditionally enable
2262         this facility.
2263
2264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2265         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2266         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2267         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2268
2269 2019-01-25  Keith Rollin  <krollin@apple.com>
2270
2271         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2272         https://bugs.webkit.org/show_bug.cgi?id=193781
2273         <rdar://problem/47201153>
2274
2275         Reviewed by Alex Christensen.
2276
2277         Part of generating the .xcfilelists used as part of adopting XCBuild
2278         includes running `make DerivedSources.make` from a standalone script.
2279         It’s important for this invocation to have the same environment as
2280         when the actual build invokes `make DerivedSources.make`. If the
2281         environments are different, then the two invocations will provide
2282         different results. In order to get the same environment in the
2283         standalone script, have the script launch xcodebuild targeting the
2284         "Apply Configuration to XCFileLists" build target, which will then
2285         re-invoke our standalone script. The script is now running again, this
2286         time in an environment with all workspace, project, target, xcconfig
2287         and other environment variables established.
2288
2289         The "Apply Configuration to XCFileLists" build target accomplishes
2290         this task via a small embedded shell script that consists only of:
2291
2292             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2293
2294         The process that invokes "Apply Configuration to XCFileLists" first
2295         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2296         evaluated and exports it into the shell environment. When xcodebuild
2297         is invoked, it inherits the value of this variable and can `eval` the
2298         contents of that variable. Our external standalone script can then set
2299         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2300         of command-line parameters needed to restart itself in the appropriate
2301         state.
2302
2303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2304         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2305
2306 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2307
2308         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2309         https://bugs.webkit.org/show_bug.cgi?id=193802
2310         <rdar://problem/46010580>
2311
2312         Reviewed by Andy Estes.
2313
2314         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2315         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2316         (TEST):
2317
2318 2019-01-25  Daniel Bates  <dabates@apple.com>
2319
2320         [iOS] uiController.keyDown() does not translate Control modified key
2321         https://bugs.webkit.org/show_bug.cgi?id=192898
2322
2323         Reviewed by Wenson Hsieh.
2324
2325         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2326         key translation, as applicable. Among other cases, key translation occurs when performing
2327         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2328         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2329         human pressing down and releasing key(s) using a hardware keyboard.
2330
2331         * WebKitTestRunner/ios/HIDEventGenerator.h:
2332         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2333         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2334
2335         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2336         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2337         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2338         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2339         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2340         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2341         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2342         (-[HIDEventGenerator longPress:completionBlock:]):
2343         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2344         Update code for above renaming.
2345
2346         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2347         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2348
2349         (-[HIDEventGenerator keyDown:]): Added.
2350         (-[HIDEventGenerator keyUp:]): Added.
2351         (-[HIDEventGenerator keyPress:completionBlock:]):
2352         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2353         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2354         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2355         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2356         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2357         (WTR::parseModifier): Deleted.
2358
2359 2019-01-25  Keith Rollin  <krollin@apple.com>
2360
2361         Complete the implementation of generate-xcfilelists
2362         https://bugs.webkit.org/show_bug.cgi?id=193782
2363
2364         Reviewed by Alex Christensen.
2365
2366         A preliminary version of generate-xcfilelists was added in r238008.
2367         This patch updates that script in order to:
2368
2369         - Support checking of .xcfilelists
2370         - Perform better execution of `make DerivedSources.make` by
2371           relaunching generate-xcfilelists under xcodebuild
2372         - Support incremental generation and checking of .xcfilelists
2373         - Support supplementary .xcfilelists files from WebKitAdditions
2374         - Support being wrapped by parallel version of generate-xcfilelists in
2375           Internal that adds support for (re)generating WebKit projects in
2376           that repo.
2377         - Support builds that have been performed in WebKitBuild as well as
2378           ~/Library/Developer/code/DerivedData
2379         - Increase robustness and debugging facilities.
2380
2381         * Scripts/generate-xcfilelists:
2382
2383 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2384
2385         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2386         https://bugs.webkit.org/show_bug.cgi?id=193297
2387         <rdar://problem/47158841>
2388
2389         Unreviewed test case fix.
2390
2391         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2392         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2393
2394         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2395         (TEST):
2396
2397 2019-01-25  Keith Rollin  <krollin@apple.com>
2398
2399         Update existing .xcfilelists
2400         https://bugs.webkit.org/show_bug.cgi?id=193791
2401         <rdar://problem/47201706>
2402
2403         Reviewed by Alex Christensen.
2404
2405         Many .xcfilelist files were added in r238824 in order to support
2406         XCBuild. Update these with recent changes to the set of build files
2407         and with the current generate-xcfilelist script.
2408
2409         * DumpRenderTree/DerivedSources-input.xcfilelist:
2410         * DumpRenderTree/DerivedSources-output.xcfilelist:
2411         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2412         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2413
2414 2019-01-25  Keith Rollin  <krollin@apple.com>
2415
2416         Fix missing dependencies in extract-dependencies-from-makefile
2417         https://bugs.webkit.org/show_bug.cgi?id=193783
2418         <rdar://problem/47201571>
2419
2420         Reviewed by Alex Christensen.
2421
2422         The extract-dependencies-from-makefile script generates .xcfilelists
2423         for XCBuild by invoking a makefile in --debug mode, parsing the
2424         dependency information in the output, and extracting information
2425         regarding targets and dependents. However, the way `make` emits this
2426         dependency information is not rigorous, and so we need to determine
2427         what lines to look for and parse by trial and error. This approach
2428         didn't coriginally atch all the information we needed to collect, so
2429         update the script to look for the additional lines we now know to look
2430         for.
2431
2432         * Scripts/extract-dependencies-from-makefile:
2433         (Parser):
2434         (Parser.addTarget):
2435         (Parser.addPrereq):
2436         (Parser.doParse):
2437
2438 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2439
2440         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2441         https://bugs.webkit.org/show_bug.cgi?id=193297
2442         <rdar://problem/47158841>
2443
2444         Reviewed by Alex Christensen.
2445
2446         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2447             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2448         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2449         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2450         activating the message used to trigger the callback when it is set.
2451
2452 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2453
2454         WKWebView.goBack should reload if there is a safe browsing warning
2455         https://bugs.webkit.org/show_bug.cgi?id=193805
2456         <rdar://problem/46908216>
2457
2458         Reviewed by Geoff Garen.
2459
2460         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2461         (+[Simple3LookupContext sharedLookupContext]):
2462         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2463         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2464         (TEST):
2465
2466 2019-01-25  Chris Dumez  <cdumez@apple.com>
2467
2468         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2469         https://bugs.webkit.org/show_bug.cgi?id=193788
2470         <rdar://problem/47531231>
2471
2472         Reviewed by Alex Christensen.
2473
2474         Add API test coverage.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2477         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2478
2479 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2480
2481         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2482         https://bugs.webkit.org/show_bug.cgi?id=193771
2483
2484         Unreviewed infrastructure fix.
2485
2486         * Scripts/webkitpy/port/darwin.py:
2487         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2488
2489 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2490
2491         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2492
2493 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2494
2495         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2496
2497         * Scripts/webkitpy/common/config/contributors.json:
2498
2499 2019-01-25  Chris Dumez  <cdumez@apple.com>
2500
2501         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2502         https://bugs.webkit.org/show_bug.cgi?id=193779
2503         <rdar://problem/46170903>
2504
2505         Reviewed by Antti Koivisto.
2506
2507         Add API test that quickly navigates forward to a previous process without waiting for it to
2508         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2509         the process' previous page when reconnecting the it for the forward navigation.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2512
2513 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2514
2515         Need a way for JavaScript (or bundle) code to participate in undo
2516         https://bugs.webkit.org/show_bug.cgi?id=190009
2517         <rdar://problem/44807048>
2518
2519         Reviewed by Ryosuke Niwa.
2520
2521         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2522         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2523
2524         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2525         (WTR::UIScriptController::lastUndoLabel const):
2526         (WTR::UIScriptController::firstRedoLabel const):
2527         (WTR::UIScriptController::platformUndoManager const):
2528         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2529         (WTR::UIScriptController::lastUndoLabel const):
2530         (WTR::UIScriptController::firstRedoLabel const):
2531         (WTR::UIScriptController::platformUndoManager const):
2532         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2533         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2534         (WTR::UIScriptController::lastUndoLabel const):
2535         (WTR::UIScriptController::firstRedoLabel const):
2536         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2537         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2538         (WTR::UIScriptController::lastUndoLabel const):
2539         (WTR::UIScriptController::firstRedoLabel const):
2540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2541         (WTR::UIScriptController::platformUndoManager const):
2542         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2543         (WTR::UIScriptController::platformUndoManager const):
2544
2545 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2546
2547         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2548         https://bugs.webkit.org/show_bug.cgi?id=193824
2549
2550         Reviewed by Antti Koivisto.
2551
2552         * LayoutReloaded/misc/LFC-passing-tests.txt:
2553
2554 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2555
2556         Update macOS JSC bot configurations
2557         https://bugs.webkit.org/show_bug.cgi?id=193739
2558
2559         Reviewed by Alexey Proskuryakov.
2560
2561         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2563         (BubbleQueueServer): Move JSC EWS to Mojave section.
2564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2565         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2566         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2567
2568 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2569
2570         [Win][WebKitTestRunner] Implement EventSenderProxy
2571         https://bugs.webkit.org/show_bug.cgi?id=193755
2572
2573         Reviewed by Don Olmstead.
2574
2575         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2576         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2577         (WTR::EventSenderProxy::dispatchMessage):
2578         (WTR::EventSenderProxy::EventSenderProxy):
2579         (WTR::EventSenderProxy::mouseDown):
2580         (WTR::EventSenderProxy::mouseUp):
2581         (WTR::EventSenderProxy::mouseMoveTo):
2582         (WTR::EventSenderProxy::mouseScrollBy):
2583         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2584
2585 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2586
2587         Unreviewed fix for API test failure after r240437.
2588
2589         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2590
2591         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2592
2593 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2594
2595         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2596         https://bugs.webkit.org/show_bug.cgi?id=193787
2597         <rdar://problem/47497634>
2598
2599         Reviewed by Alexey Proskuryakov.
2600
2601         * Scripts/webkitdirs.pm:
2602         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2603
2604 2019-01-24  Truitt Savell  <tsavell@apple.com>
2605
2606         Unreviewed, rolling out r240446.
2607
2608         Casued 5 API failures
2609
2610         Reverted changeset:
2611
2612         "Activate the WebResourceLoadStatisticsStore in the
2613         NetworkProcess and deactivate it in the UIProcess."
2614         https://bugs.webkit.org/show_bug.cgi?id=193297
2615         https://trac.webkit.org/changeset/240446
2616
2617 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2618
2619         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2620         https://bugs.webkit.org/show_bug.cgi?id=193741
2621         <rdar://problem/47135030>
2622
2623         Reviewed by Antti Koivisto and Simon Fraser.
2624
2625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2626         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2627         (TestWebKitAPI::TEST):
2628
2629 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2630
2631         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2632         https://bugs.webkit.org/show_bug.cgi?id=193297
2633         <rdar://problem/47158841>
2634
2635         Reviewed by Alex Christensen.
2636
2637         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2638         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2639         activating the message used to trigger the callback when it is set.
2640
2641 2019-01-24  John Wilander  <wilander@apple.com>
2642
2643         Add Ad Click Attribution as an internal/experimental feature
2644         https://bugs.webkit.org/show_bug.cgi?id=193685
2645         <rdar://problem/47450399>
2646
2647         Reviewed by Brent Fulgham.
2648
2649         Added test option adClickAttributionEnabled.
2650
2651         * DumpRenderTree/TestOptions.cpp:
2652         (TestOptions::TestOptions):
2653         * DumpRenderTree/TestOptions.h:
2654         * DumpRenderTree/mac/DumpRenderTree.mm:
2655         (setWebPreferencesForTestOptions):
2656
2657 2019-01-24  Antti Koivisto  <antti@apple.com>
2658
2659         [PSON] Flash on back navigation on Mac
2660         https://bugs.webkit.org/show_bug.cgi?id=193716
2661         <rdar://problem/47148458>
2662
2663         Reviewed by Chris Dumez.
2664
2665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2666
2667         Closing of the previous page is delayed so waiting for didFinishNavigation is
2668         not sufficient to guarantee we have received all the messages. Wait for them.
2669
2670 2019-01-24  Chris Dumez  <cdumez@apple.com>
2671
2672         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2673         https://bugs.webkit.org/show_bug.cgi?id=193761
2674         <rdar://problem/47456405>
2675
2676         Reviewed by Alex Christensen.
2677
2678         Add API test coverage.
2679
2680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2681
2682 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2683
2684         webkitpy: Missing PID in crashlog name should not be fatal
2685         https://bugs.webkit.org/show_bug.cgi?id=193771
2686
2687         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2688         of raising an exception.
2689
2690         Reviewed by Lucas Forschler.
2691
2692         * Scripts/webkitpy/port/darwin.py:
2693         (DarwinPort._merge_crash_logs):
2694
2695 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2696
2697         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2698         https://bugs.webkit.org/show_bug.cgi?id=193746
2699
2700         Reviewed by Youenn Fablet.
2701
2702         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2703         so we'd best just not call it.
2704
2705         * Scripts/webkitpy/w3c/test_exporter.py:
2706         (WebPlatformTestExporter.create_branch_with_patch):
2707
2708 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2709
2710         Move FileSystem to WTF
2711         https://bugs.webkit.org/show_bug.cgi?id=193602
2712
2713         Reviewed by Yusuke Suzuki.
2714
2715         * DumpRenderTree/win/DumpRenderTree.cpp:
2716         * TestWebKitAPI/CMakeLists.txt:
2717         * TestWebKitAPI/PlatformGTK.cmake:
2718         * TestWebKitAPI/PlatformJSCOnly.cmake:
2719         * TestWebKitAPI/PlatformPlayStation.cmake:
2720         * TestWebKitAPI/PlatformWPE.cmake:
2721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2722         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2723         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2724         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2725         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2726         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2727         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2728         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2729         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2730         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2731
2732 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2733
2734         [WPE] Remove hard dependency on subprocess32 for the API tests
2735
2736         Rubber-stamped by Carlos Garcia Campos.
2737
2738         * glib/api_test_runner.py:
2739         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2740         its presence only when running WPEQt tests.
2741
2742 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2743
2744         [GLIB] Expose JavaScriptCore options in GLib public API
2745         https://bugs.webkit.org/show_bug.cgi?id=188742
2746
2747         Reviewed by Michael Catanzaro.
2748
2749         Add a test for the new API.
2750
2751         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2752         (testsJSCOptions):
2753         (main):
2754
2755 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2756
2757         [GTK][WPE] Support JPEG 2000 images
2758         https://bugs.webkit.org/show_bug.cgi?id=186272
2759
2760         Reviewed by Žan Doberšek.
2761
2762         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2763
2764         * gtk/jhbuild.modules:
2765         * wpe/jhbuild.modules:
2766
2767 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2768
2769         check-webkit-style should warn when using soft-linking macros in a header
2770         <https://webkit.org/b/193750>
2771
2772         Reviewed by Darin Adler.
2773
2774         * Scripts/webkitpy/style/checkers/cpp.py:
2775         (check_language): Add softlink/header check by refactoring the
2776         softlink/framework check.
2777         (CppChecker): Enable softlink/header check by default.
2778         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2779         (CppStyleTest.test_softlink_framework): Rename from
2780         CppStyleTest.test_softlink() and change test framework name in
2781         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2782         files. Set file_name for macros that only appear in headers.
2783         (CppStyleTest.test_softlink_header): Add tests for using
2784         soft-link macros in headers.
2785
2786 2019-01-23  Chris Dumez  <cdumez@apple.com>
2787
2788         Deprecate API to limit the maximum number of WebProcesses
2789         https://bugs.webkit.org/show_bug.cgi?id=193725
2790         <rdar://problem/47464879>
2791
2792         Reviewed by Geoff Garen.
2793
2794         Update existing API tests to stop using deprecated API.
2795
2796         * MiniBrowser/mac/AppDelegate.m:
2797         (defaultConfiguration):
2798         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2799         (TestWebKitAPI::TEST):
2800         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2801         (TestWebKitAPI::TEST):
2802         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2803         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2804         (TEST):
2805         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2806         (TEST):
2807
2808 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2809
2810         [ews-app] Rename ews model buildermappings to buildermapping
2811         https://bugs.webkit.org/show_bug.cgi?id=193729
2812
2813         Reviewed by Lucas Forschler.
2814
2815         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2816         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2817         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2818
2819 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-app] Rename ews model steps to step
2822         https://bugs.webkit.org/show_bug.cgi?id=193697
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2827         (Step): Renamed Steps to Step.
2828
2829 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2830
2831         Clean up IndexedDB files between tests
2832         https://bugs.webkit.org/show_bug.cgi?id=192796
2833         <rdar://problem/46824999>
2834
2835         Reviewed by Geoffrey Garen.
2836
2837         * DumpRenderTree/mac/DumpRenderTree.mm:
2838         (runTest):
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::resetStateToConsistentValues):
2841         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2842         (WTR::RemoveAllIndexedDatabasesCallback):
2843         (WTR::TestController::ClearIndexedDatabases):
2844         * WebKitTestRunner/TestController.h:
2845         * WebKitTestRunner/TestInvocation.cpp:
2846         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2847
2848 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2849
2850         [ews-app] Rename ews model Builds to Build
2851         https://bugs.webkit.org/show_bug.cgi?id=193695
2852
2853         Reviewed by Lucas Forschler.
2854
2855         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2856         (Build): Renamed Builds to Build.
2857
2858 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2859
2860         webkitpy: Wait longer when launching WebKitTestRunner
2861         https://bugs.webkit.org/show_bug.cgi?id=193734
2862
2863         Reviewed by Aakash Jain.
2864
2865         * Scripts/webkitpy/port/simulator_process.py:
2866         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2867
2868 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2869
2870         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2871         https://bugs.webkit.org/show_bug.cgi?id=193182
2872         <rdar://problem/47452154>
2873
2874         Reviewed by Tim Horton.
2875
2876         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2877         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2878         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2879
2880         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2881         preventing later tests from recognizing gestures.
2882
2883         * WebKitTestRunner/ios/TestControllerIOS.mm:
2884         (WTR::TestController::platformResetStateToConsistentValues):
2885
2886         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2887
2888 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2889
2890         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2891         https://bugs.webkit.org/show_bug.cgi?id=193722
2892         <rdar://problem/47481475>
2893
2894         Reviewed by Lucas Forschler.
2895
2896         iPhone and iPad ports should both use the iOS config.
2897
2898         * Scripts/webkitpy/port/ios_simulator.py:
2899         (IPhoneSimulatorPort.__init__):
2900         (IPadSimulatorPort.__init__):
2901
2902 2019-01-23  Rob Buis  <rbuis@igalia.com>
2903
2904         Update MIME type parser
2905         https://bugs.webkit.org/show_bug.cgi?id=180526
2906
2907         Reviewed by Frédéric Wang.
2908
2909         Add unit tests for both parse modes of ParsedContentType.
2910
2911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2912         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2913         (TestWebKitAPI::TEST):
2914
2915 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2916
2917         [ews-app] fetch loop should not stop on network issues
2918         https://bugs.webkit.org/show_bug.cgi?id=193666
2919
2920         Reviewed by Lucas Forschler.
2921
2922         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2923         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2924
2925 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2926
2927         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2928         https://bugs.webkit.org/show_bug.cgi?id=189165
2929         <rdar://problem/47433765>
2930
2931         Reviewed by Tim Horton.
2932
2933         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2934         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2935         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2936         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2937         would make its way to the UI process by the time the layer tree commit is finished.
2938
2939         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2940         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2941         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2942         will fail because it asks for -_autofillContext too early.
2943
2944         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2945         is handled in the UI process.
2946
2947         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2948
2949         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2950         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2951         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2952         input session.
2953
2954         (-[AutofillTestView textInputHasAutofillContext]):
2955
2956         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2957
2958         * TestWebKitAPI/cocoa/TestWKWebView.h:
2959         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2960         (nextInputSessionChangeCount):
2961
2962         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2963         This includes changing the focused element from one to another.
2964
2965         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2966         (-[TestWKWebView didStartFormControlInteraction]):
2967         (-[TestWKWebView didEndFormControlInteraction]):
2968         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2969
2970         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2971         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2972         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2973         that doesn't require an input session to one that doesn't.
2974
2975 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2976
2977         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2978         <https://webkit.org/b/193676>
2979
2980         Reviewed by Alexey Proskuryakov.
2981
2982         * Scripts/webkitpy/style/checkers/cpp.py:
2983         (check_member_initialization_list):
2984         - Don't report missing whitespace around colon if the colon at
2985           the start of the line is formatted correctly.
2986         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2987         (WebKitStyleTest.test_member_initialization_list):
2988         - Add a test for a missing permutation of existing tests.
2989         - Add a test this false-positive.
2990         - Add blank lines between subtests to make them easier to read.
2991
2992 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [build.webkit.org] Unit-test failure after r237113
2995         https://bugs.webkit.org/show_bug.cgi?id=193669
2996
2997         Reviewed by Michael Catanzaro.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3000         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3001         multiple or zero flags.
3002
3003 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3004
3005         Cache bytecode to disk
3006         https://bugs.webkit.org/show_bug.cgi?id=192782
3007         <rdar://problem/46084932>
3008
3009         Reviewed by Keith Miller.
3010
3011         Add test helper to execute bytecode-cache tests: it executes each test
3012         twice, the first with JSC_diskCachePath set to a temporary directory
3013         and second with JSC_forceDiskCache=true (in addition to the cache path)
3014         to guarantee that only the disk cache is being used and no new
3015         UnlinkedCodeBlocks are being created.
3016
3017         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3018         * Scripts/run-jsc-stress-tests:
3019
3020 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3021
3022         [css-logical] Implement flow-relative margin, padding and border shorthands
3023         https://bugs.webkit.org/show_bug.cgi?id=188697
3024
3025         Reviewed by Simon Fraser and Antti Koivisto.
3026
3027         * DumpRenderTree/TestOptions.cpp:
3028         (TestOptions::TestOptions):
3029         * DumpRenderTree/TestOptions.h:
3030         * DumpRenderTree/mac/DumpRenderTree.mm:
3031         (setWebPreferencesForTestOptions):
3032         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3033
3034         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3035         (JSONCSSPropertiesChecker.check_codegen_properties):
3036         Allow CSS property definitions to have a 'runtime-flag' parameter which
3037         disables the property when the specified runtime flag is disabled.
3038
3039 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3040
3041         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3042         https://bugs.webkit.org/show_bug.cgi?id=193643
3043
3044         Reviewed by Michael Catanzaro.
3045
3046         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3047         * wpe/jhbuild.modules: Ditto.
3048
3049 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3050
3051         [LFC][Floats] Take float top position into account when computing containing block height.
3052         https://bugs.webkit.org/show_bug.cgi?id=193655
3053
3054         Reviewed by Antti Koivisto.
3055
3056         * LayoutReloaded/misc/LFC-passing-tests.txt:
3057
3058 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3059
3060         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3061         <https://webkit.org/b/193645>
3062         <rdar://problem/47421574>
3063
3064         Reviewed by Alex Christensen.
3065
3066         - Now checks for local soft-linking of all frameworks that have
3067           their own *SoftLinking.{cpp,h,mm} files.
3068         - Changes softlink/uikit warning to softlink/framework.
3069
3070         * Scripts/webkitpy/style/checkers/cpp.py:
3071         (check_language):
3072         (CppChecker):
3073         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3074         (CppStyleTest):
3075
3076 2019-01-20  Saam Barati  <sbarati@apple.com>
3077
3078         Rollout r240210: It broke tests on iOS
3079         https://bugs.webkit.org/show_bug.cgi?id=193640
3080
3081         Unreviewed.
3082
3083         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3084         * Scripts/run-jsc-stress-tests:
3085
3086 2019-01-20  chris fleizach  <cfleizach@apple.com>
3087
3088         AX: Support returning relative frames for accessibility
3089         https://bugs.webkit.org/show_bug.cgi?id=193414
3090         <rdar://problem/47268501>
3091
3092         Reviewed by Zalan Bujtas.
3093
3094         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3095         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3096         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3097         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3098         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3099         (WTR::attributesOfElement):
3100         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3101
3102 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3103
3104         Unreviewed, add my new email address
3105
3106         * Scripts/webkitpy/common/config/contributors.json:
3107
3108 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3109
3110         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3111         https://bugs.webkit.org/show_bug.cgi?id=193617
3112
3113         Reviewed by Antti Koivisto.
3114
3115         * LayoutReloaded/misc/LFC-passing-tests.txt:
3116
3117 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3118
3119         Unreviewed, rolling out r240209.
3120
3121         Broke GTK/WPE injected bundle
3122
3123         Reverted changeset:
3124
3125         "AX: Support returning relative frames for accessibility"
3126         https://bugs.webkit.org/show_bug.cgi?id=193414
3127         https://trac.webkit.org/changeset/240209
3128
3129 2019-01-12  Dan Bernstein  <mitz@apple.com>
3130
3131         [Cocoa] Avoid importing directly from subumbrella frameworks
3132         https://bugs.webkit.org/show_bug.cgi?id=186016
3133         <rdar://problem/40591038>
3134
3135         Reviewed by Sam Weinig.
3136
3137         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3138           LaunchServices header.
3139         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3140           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3141         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3142           when using SDKs earlier than 10.13.
3143         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3144           and OTHER_CPLUSPLUSFLAGS.
3145         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3146           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3147         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3148           LaunchServices header.
3149
3150 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3151
3152         Cache bytecode to disk
3153         https://bugs.webkit.org/show_bug.cgi?id=192782
3154         <rdar://problem/46084932>
3155
3156         Reviewed by Keith Miller.
3157
3158         Add test helper to execute bytecode-cache tests: it executes each test
3159         twice, the first with JSC_diskCachePath set to a temporary directory
3160         and second with JSC_forceDiskCache=true (in addition to the cache path)
3161         to guarantee that only the disk cache is being used and no new
3162         UnlinkedCodeBlocks are being created.
3163
3164         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3165         * Scripts/run-jsc-stress-tests:
3166
3167 2019-01-20  chris fleizach  <cfleizach@apple.com>
3168
3169         AX: Support returning relative frames for accessibility
3170         https://bugs.webkit.org/show_bug.cgi?id=193414
3171         <rdar://problem/47268501>
3172
3173         Reviewed by Zalan Bujtas.
3174
3175         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3176         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3177         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3178         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3179         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3180         (WTR::attributesOfElement):
3181         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3182
3183 2019-01-20  Antoine Quint  <graouts@apple.com>
3184
3185         Add a POINTER_EVENTS feature flag
3186         https://bugs.webkit.org/show_bug.cgi?id=193577
3187         <rdar://problem/47408511>
3188
3189         Unreviewed. Also enable Pointer Events for iosmac.
3190
3191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3192
3193 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3194
3195         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3196         https://bugs.webkit.org/show_bug.cgi?id=193613
3197
3198         Reviewed by Antti Koivisto.
3199
3200         * LayoutReloaded/misc/LFC-passing-tests.txt:
3201
3202 2019-01-19  Antoine Quint  <graouts@apple.com>
3203
3204         Add a POINTER_EVENTS feature flag
3205         https://bugs.webkit.org/show_bug.cgi?id=193577
3206
3207         Reviewed by Dean Jackson.
3208
3209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3210
3211 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3212
3213         Disable the run-jsc-stress-test remote host key check [second round].
3214         https://bugs.webkit.org/show_bug.cgi?id=192988
3215
3216         Reviewed by Dewei Zhu.
3217
3218         * Scripts/run-jsc-stress-tests:
3219
3220 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3221
3222         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3223         https://bugs.webkit.org/show_bug.cgi?id=193597
3224
3225         Reviewed by Lucas Forschler.
3226
3227         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3228
3229 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3230
3231         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3232         https://bugs.webkit.org/show_bug.cgi?id=193595
3233
3234         Reviewed by Lucas Forschler.
3235
3236         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3237         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3238         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3239
3240 2019-01-18  Chris Dumez  <cdumez@apple.com>
3241
3242         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3243         https://bugs.webkit.org/show_bug.cgi?id=193588
3244         <rdar://problem/47131566>
3245
3246         Reviewed by Alex Christensen.
3247
3248         Add layout test coverage.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3251
3252 2019-01-18  Jer Noble  <jer.noble@apple.com>
3253
3254         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3255         https://bugs.webkit.org/show_bug.cgi?id=189553
3256
3257         Reviewed by Tim Horton.
3258
3259         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3260
3261         * ContentExtensionTester/Configurations/Base.xcconfig:
3262         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3263         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3264         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3265         * ImageDiff/cg/Configurations/Base.xcconfig:
3266         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3267         * MiniBrowser/Configurations/Base.xcconfig:
3268         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3269         * MobileMiniBrowser/Configurations/Base.xcconfig:
3270         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3271         * Scripts/webkitpy/style/checker.py:
3272         (_all_categories):
3273         (FileType):
3274         (CheckerDispatcher._file_type):
3275         (CheckerDispatcher._create_checker):
3276         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3277         (SDKVariantChecker):
3278         (SDKVariantChecker.__init__):
3279         (SDKVariantChecker.check):
3280         * TestWebKitAPI/Configurations/Base.xcconfig:
3281         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3282         * WebEditingTester/Configurations/Base.xcconfig:
3283         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3284         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3285         * WebKitTestRunner/Configurations/Base.xcconfig:
3286         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3287         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3288         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3289
3290 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3291
3292         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3293         <https://webkit.org/b/193568>
3294         <rdar://problem/47381130>
3295
3296         Reviewed by Alex Christensen.
3297
3298         Make sure no one re-introduces UIKit soft-linking by adding a
3299         style rule.
3300
3301         * Scripts/webkitpy/style/checkers/cpp.py:
3302         (check_language): Add softlink/uikit check.
3303         (CppChecker): Enable softlink/uikit check.
3304         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3305         (CppStyleTest): Add test for softlink/uikit.
3306
3307 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3308
3309         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3310         https://bugs.webkit.org/show_bug.cgi?id=193584
3311
3312         Change "-dev" to "-devel".
3313
3314         Reviewed by Michael Catanzaro.
3315
3316         * gtk/install-dependencies:
3317
3318 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3319
3320         webkitpy: Add iPhone and iPad ports
3321         https://bugs.webkit.org/show_bug.cgi?id=193537
3322         <rdar://problem/47353390>
3323
3324         Reviewed by Lucas Forschler.
3325
3326         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3327         ports. Note that this separation is optional, the --ios-simulator command remains.
3328
3329         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3330         (RunTest.test_device_type_test_division): Drive-by fix.
3331         (RunTest.test_device_type_specific_listing): Ditto.
3332         (RunTest.test_ipad_test_division):
3333         (RunTest):
3334         (RunTest.test_ipad_listing):
3335         * Scripts/webkitpy/port/factory.py:
3336         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3337         (PortFactory):
3338         * Scripts/webkitpy/port/ios_simulator.py:
3339         (IPhoneSimulatorPort):
3340         (IPadSimulatorPort):
3341
3342 2019-01-18  Chris Dumez  <cdumez@apple.com>
3343
3344         Regression(PSON) Scroll position is not always restored properly when navigating back
3345         https://bugs.webkit.org/show_bug.cgi?id=193578
3346         <rdar://problem/47386331>
3347
3348         Reviewed by Tim Horton.
3349
3350         Add API test coverage.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3353
3354 2019-01-18  Youenn Fablet  <youenn@apple.com>
3355
3356         Add a new SPI to request for cache storage quota increase
3357         https://bugs.webkit.org/show_bug.cgi?id=193323
3358
3359         Reviewed by Alex Christensen.
3360
3361         Implement WebsiteDataStore quota delegate to handle quota requests.
3362         By default, do not update quota.
3363         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3364
3365         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3366         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3367         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3368         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3369         * WebKitTestRunner/TestController.cpp:
3370         (WTR::TestController::allowCacheStorageQuotaIncrease):
3371         * WebKitTestRunner/TestController.h:
3372         * WebKitTestRunner/TestInvocation.cpp:
3373         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3374         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3375         (-[CacheStorageQuotaManager init]):
3376         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3377         (WTR::initializeWebViewConfiguration):
3378         (WTR::TestController::cocoaResetStateToConsistentValues):
3379         (WTR::TestController::allowCacheStorageQuotaIncrease):
3380
3381 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3382
3383         [ews-build] Pass owner to the triggered builds
3384         https://bugs.webkit.org/show_bug.cgi?id=193574
3385
3386         Reviewed by Lucas Forschler.
3387
3388         * BuildSlaveSupport/ews-build/factories.py:
3389         (BuildFactory.propertiesToPassToTriggers):
3390
3391 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3392
3393         [ews-app] Send patch author as a build property
3394         https://bugs.webkit.org/show_bug.cgi?id=193560
3395
3396         Reviewed by Lucas Forschler.
3397
3398         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3399         (BugzillaPatchFetcher.fetch):
3400
3401 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3402
3403         webkitpy: Implement device type specific expected results (Follow-up fix)
3404         https://bugs.webkit.org/show_bug.cgi?id=192162
3405         <rdar://problem/46345449>
3406
3407         Unreviewed infrastructure fix.
3408
3409         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3410         (Manager.run): Don't boot a device if no tests are available to run on it.
3411
3412 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3413
3414         webkitpy: Implement device type specific expected results (Follow-up fix)
3415         https://bugs.webkit.org/show_bug.cgi?id=192162
3416         <rdar://problem/46345449>
3417
3418         Unreviewed infrastructure fix.
3419
3420         * Scripts/webkitpy/api_tests/manager.py:
3421         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3422
3423 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3424
3425         webkitpy: Implement device type specific expected results (Part 2)
3426         https://bugs.webkit.org/show_bug.cgi?id=192162
3427         <rdar://problem/46345449>
3428
3429         Rubber-stamped by Aakash Jain.
3430
3431         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3432         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3433         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3434
3435         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3436         (LayoutTestFinder.find_tests): Pass device_type through.
3437         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3438         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3439         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3440         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3441         (Manager._collect_tests): Pass device type to test finder.
3442         (Manager._needs_web_platform_test):
3443         (Manager._prepare_lists): Index _expectations by device type.
3444         (Manager._test_input_for_file):
3445         (Manager._test_is_slow): Ditto.
3446         (Manager._test_should_dump_jsconsolelog_in_stderr):
3447         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3448         (Manager._get_test_inputs):
3449         (Manager._update_worker_count):
3450         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3451         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3452         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3453         the one which runs the test.
3454         (Manager._run_test_subset):
3455         (Manager._run_tests): Index _expectations by current_device_type.
3456         (Manager._print_expectation_line_for_test): Ditto.
3457         (Manager._print_expectations_for_subset): Ditto.
3458         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3459         Unlike run, this function will behave the same regardless of what devices are available.
3460         (Manager._custom_device_for_test): Deleted.
3461         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3462         (ManagerTest.test_uses_custom_device): Deleted.
3463         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3464         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3465         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3466         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3467         all of the expectations.
3468         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3469         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3470         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3471         (TestExpectations.__init__): Allow device_type to be passed through.
3472         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3473         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3474         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3475         (summarize_results):
3476         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3477         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3478         a test ran with, one must check all expectations to find the first non-skip expectation.
3479         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3480         (RunTest.test_device_type_test_division):
3481         (RunTest):
3482         (RunTest.test_device_type_specific_listing):
3483         * Scripts/webkitpy/port/base.py:
3484         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3485         (Port.supported_device_types): The result of this function will change based on what devices are available.
3486         * Scripts/webkitpy/port/device_port.py:
3487         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3488         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3489         can be used.
3490         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3491         any, or the DEFAULT_DEVICE_TYPES of the port.
3492         * Scripts/webkitpy/port/ios.py:
3493         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3494         * Scripts/webkitpy/port/ios_simulator.py:
3495         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3496         * Scripts/webkitpy/port/watch.py:
3497         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3498         * Scripts/webkitpy/port/watch_simulator.py:
3499         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3500         * Scripts/webkitpy/xcode/device_type.py:
3501         (DeviceType):
3502         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3503
3504 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3505
3506         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3507         https://bugs.webkit.org/show_bug.cgi?id=193575
3508
3509         Reviewed by Michael Catanzaro.
3510
3511         Allow the script to run without explicit port argument because
3512         it's specific to the WPE port anyway.
3513
3514         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3515         and simplify the rest of the code accordingly.
3516
3517 2019-01-18  Charlie Turner  <cturner@igalia.com>
3518
3519         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3520         https://bugs.webkit.org/show_bug.cgi?id=192229
3521
3522         Reviewed by Xabier Rodriguez-Calvar.
3523
3524         * MiniBrowser/wpe/main.cpp:
3525         (main): Enable encrypted-media by default.
3526
3527 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3528
3529         [Flatpak] Missing KeyboardInterrupt exception handler
3530         https://bugs.webkit.org/show_bug.cgi?id=193570
3531
3532         Reviewed by Michael Catanzaro.
3533
3534         * flatpak/flatpakutils.py:
3535         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3536
3537 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3538
3539         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3540         https://bugs.webkit.org/show_bug.cgi?id=193564
3541
3542         Reviewed by Antti Koivisto.
3543
3544         * LayoutReloaded/misc/LFC-passing-tests.txt:
3545
3546 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3547
3548         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3549         https://bugs.webkit.org/show_bug.cgi?id=193562
3550
3551         Reviewed by Antti Koivisto.
3552
3553         * LayoutReloaded/misc/LFC-passing-tests.txt:
3554
3555 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3556
3557         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3558         https://bugs.webkit.org/show_bug.cgi?id=193555
3559
3560         Reviewed by Antti Koivisto.
3561
3562         * LayoutReloaded/misc/LFC-passing-tests.txt:
3563
3564 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3565
3566         [WPE] Add Qt extension
3567         https://bugs.webkit.org/show_bug.cgi?id=191464
3568
3569         Reviewed by Carlos Garcia Campos.
3570
3571         MiniBrowser and API tests for the WPE Qt API. To run the
3572         MiniBrowser a new script is introduced. Example invocation:
3573
3574         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3575
3576         Also note-worthy is the introduction of the python2-subprocess32
3577         dependency to run the GLib API tests.
3578
3579         * MiniBrowser/wpe/CMakeLists.txt:
3580         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3581         * MiniBrowser/wpe/qt/main.cpp: Added.
3582         (main):
3583         * MiniBrowser/wpe/qt/main.qml: Added.
3584         * MiniBrowser/wpe/qt/qml.qrc: Added.
3585         * Scripts/run-gtk-tests:
3586         (GtkTestRunner.is_google_test):
3587         (GtkTestRunner):
3588         (GtkTestRunner.is_qt_test):
3589         * Scripts/run-qt-wpe-minibrowser: Added.
3590         * Scripts/run-wpe-tests:
3591         (WPETestRunner):
3592         (WPETestRunner.is_google_test):
3593         (WPETestRunner.is_qt_test):
3594         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3595         (TestLoad::main):
3596         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3597         (TestLoadHtml::main):
3598         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3599         (TestLoadRequest::main):
3600         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3601         (TestRunJavaScript::main):
3602         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3603         (waitForSignal):
3604         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3605         (LoadSpy::LoadSpy):
3606         (LoadSpy::~LoadSpy):
3607         (LoadSpy::onLoadingChanged):
3608         (LoadStartedCatcher::LoadStartedCatcher):
3609         (LoadStartedCatcher::~LoadStartedCatcher):
3610         (LoadStartedCatcher::onLoadingChanged):
3611         (waitForLoadSucceeded):
3612         (waitForLoadFailed):
3613         * TestWebKitAPI/glib/CMakeLists.txt:
3614         * flatpak/flatpakutils.py:
3615         (WebkitFlatpak.load_from_args):
3616         (WebkitFlatpak.__init__):
3617         (WebkitFlatpak.clean_args):
3618         (WebkitFlatpak.run_in_sandbox):
3619         * flatpak/org.webkit.CommonModules.yaml:
3620         * flatpak/org.webkit.WPE.yaml:
3621         * flatpak/org.webkit.WPEModules.yaml:
3622         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3623         * flatpak/org.webkit.WebKit.yaml:
3624         * glib/api_test_runner.py:
3625         (TestRunner._run_test_qt):
3626         (TestRunner.is_qt_test):
3627         (TestRunner._run_test):
3628
3629 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3630
3631         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3632         https://bugs.webkit.org/show_bug.cgi?id=193494
3633         <rdar://problem/46859627>
3634
3635         Reviewed by Simon Fraser and Tim Horton.
3636
3637         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3638         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3639
3640         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3641         (WTR::UIScriptController::contentOffsetX const):
3642         (WTR::UIScriptController::contentOffsetY const):
3643         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3644         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3645         (WTR::UIScriptController::contentOffsetX const):
3646         (WTR::UIScriptController::contentOffsetY const):
3647         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3648
3649         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3650
3651         * WebKitTestRunner/TestController.cpp:
3652         (WTR::updateTestOptionsFromTestHeader):
3653         * WebKitTestRunner/TestOptions.h:
3654         (WTR::TestOptions::hasSameInitializationOptions const):
3655         * WebKitTestRunner/ios/TestControllerIOS.mm:
3656         (WTR::TestController::platformResetStateToConsistentValues):
3657         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3658         (WTR::UIScriptController::contentOffsetX const):
3659         (WTR::UIScriptController::contentOffsetY const):
3660
3661 2019-01-17  Truitt Savell  <tsavell@apple.com>
3662
3663         Unreviewed, rolling out r240124.
3664
3665         This commit broke an internal build.
3666
3667         Reverted changeset:
3668
3669         "SDK_VARIANT build destinations should be separate from non-
3670         SDK_VARIANT builds"
3671         https://bugs.webkit.org/show_bug.cgi?id=189553
3672         https://trac.webkit.org/changeset/240124
3673
3674 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3675
3676         Fix string concatenation API test after r239920
3677         https://bugs.webkit.org/show_bug.cgi?id=193551
3678         <rdar://problem/47359304>
3679
3680         Reviewed by Youenn Fablet.
3681
3682         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3683         (TestWebKitAPI::TEST):
3684         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3685         in WebKit's build configuration like it apparently is on Linux.
3686
3687 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3688
3689         [ews-build] validate-patch should handle the case when bug_id is None
3690         https://bugs.webkit.org/show_bug.cgi?id=193547
3691
3692         Reviewed by Lucas Forschler.
3693
3694         * BuildSlaveSupport/ews-build/steps.py:
3695         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3696         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3697
3698 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3699
3700         [ews-build] Add patch author information in build
3701         https://bugs.webkit.org/show_bug.cgi?id=193465
3702
3703         Reviewed by Lucas Forschler.
3704
3705         * BuildSlaveSupport/ews-build/steps.py:
3706         (ValidatePatch._is_patch_obsolete):
3707
3708 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3709
3710         [ews-build] Pass bug_id to the triggered builds
3711         https://bugs.webkit.org/show_bug.cgi?id=193548
3712
3713         Reviewed by Lucas Forschler.
3714
3715         * BuildSlaveSupport/ews-build/factories.py:
3716         (BuildFactory.propertiesToPassToTriggers):
3717
3718 2019-01-17  Jer Noble  <jer.noble@apple.com>
3719
3720         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3721         https://bugs.webkit.org/show_bug.cgi?id=189553
3722
3723         Reviewed by Tim Horton.
3724
3725         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3726
3727         * ContentExtensionTester/Configurations/Base.xcconfig:
3728         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3729         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3730         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3731         * ImageDiff/cg/Configurations/Base.xcconfig:
3732         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3733         * MiniBrowser/Configurations/Base.xcconfig:
3734         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3735         * MobileMiniBrowser/Configurations/Base.xcconfig:
3736         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3737         * Scripts/webkitpy/style/checker.py:
3738         (_all_categories):
3739         (FileType):
3740         (CheckerDispatcher._file_type):
3741         (CheckerDispatcher._create_checker):
3742         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3743         (SDKVariantChecker):
3744         (SDKVariantChecker.__init__):
3745         (SDKVariantChecker.check):
3746         * TestWebKitAPI/Configurations/Base.xcconfig:
3747         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3748         * WebEditingTester/Configurations/Base.xcconfig:
3749         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3750         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3751         * WebKitTestRunner/Configurations/Base.xcconfig:
3752         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3753         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3754         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3755
3756 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3757
3758         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3759         https://bugs.webkit.org/show_bug.cgi?id=193534
3760
3761         Reviewed by Antti Koivisto.
3762
3763         * LayoutReloaded/misc/LFC-passing-tests.txt:
3764
3765 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3766
3767         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3768         https://bugs.webkit.org/show_bug.cgi?id=193528
3769
3770         Reviewed by Antti Koivisto.
3771
3772         * LayoutReloaded/misc/LFC-passing-tests.txt:
3773
3774 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3775
3776         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3777         https://bugs.webkit.org/show_bug.cgi?id=193520
3778
3779         Reviewed by Antti Koivisto.
3780
3781         * LayoutReloaded/misc/LFC-passing-tests.txt:
3782
3783 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3784
3785         [ews-build] unapply-patch step should not update source
3786         https://bugs.webkit.org/show_bug.cgi?id=193234
3787
3788         Reviewed by Lucas Forschler.
3789
3790         * BuildSlaveSupport/ews-build/steps.py:
3791         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3792         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3793
3794 2019-01-16  Youenn Fablet  <youenn@apple.com>
3795
3796         Add a new SPI for controlling getUserMedia
3797         https://bugs.webkit.org/show_bug.cgi?id=192793
3798
3799         Reviewed by Eric Carlson.
3800
3801         * MiniBrowser/mac/WK2BrowserWindowController.m:
3802         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3803         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3804         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3805         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3806         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3807         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3808         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3809         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3810         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3811         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3812         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3813         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3814         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3815         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3816
3817 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3818
3819         [LFC][BFC] Inflow non-replaced used width should not be negative.
3820         https://bugs.webkit.org/show_bug.cgi?id=193495
3821
3822         Reviewed by Antti Koivisto.
3823
3824         * LayoutReloaded/misc/LFC-passing-tests.txt:
3825
3826 2019-01-16  Chris Dumez  <cdumez@apple.com>
3827
3828         Regression(PSON) View becomes blank after click a cross-site download link
3829         https://bugs.webkit.org/show_bug.cgi?id=193361
3830         <rdar://problem/47099573>
3831
3832         Reviewed by Geoffrey Garen.
3833
3834         Add API test coverage.
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3837         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3838
3839 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3840
3841         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3842         https://bugs.webkit.org/show_bug.cgi?id=193470
3843
3844         Reviewed by Antti Koivisto.
3845
3846         * LayoutReloaded/misc/LFC-passing-tests.txt:
3847
3848 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3849
3850         [LFC] Adjust margin box verification.
3851         https://bugs.webkit.org/show_bug.cgi?id=193482
3852
3853         Reviewed by Antti Koivisto.
3854
3855         * LayoutReloaded/misc/LFC-passing-tests.txt:
3856
3857 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3858
3859         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3860         https://bugs.webkit.org/show_bug.cgi?id=193451
3861
3862         Reviewed by Geoffrey Garen.
3863
3864         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3865         (TEST):
3866         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3867         (runWebsiteDataStoreCustomPaths):
3868
3869 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3870
3871         webkitpy: Support boolean simctl isAvailable
3872         https://bugs.webkit.org/show_bug.cgi?id=193472
3873         <rdar://problem/47296150>
3874
3875         Reviewed by Ryosuke Niwa.
3876
3877         * Scripts/webkitpy/xcode/simulated_device.py:
3878         (SimulatedDeviceManager._create_runtimes):
3879         (SimulatedDeviceManager._create_device_with_runtime):
3880
3881 2019-01-15  Chris Dumez  <cdumez@apple.com>
3882
3883         Unreviewed, rolling out r239993, r239995, r239997, and
3884         r239999.
3885
3886         Caused assertions under
3887         ViewGestureController::disconnectFromProcess()
3888
3889         Reverted changesets:
3890
3891         "Regression(PSON) View becomes blank after click a cross-site
3892         download link"
3893         https://bugs.webkit.org/show_bug.cgi?id=193361
3894         https://trac.webkit.org/changeset/239993
3895
3896         "Unreviewed iOS build fix after r239993."
3897         https://trac.webkit.org/changeset/239995
3898
3899         "Fix iOS build after r239993"
3900         https://bugs.webkit.org/show_bug.cgi?id=193361
3901         https://trac.webkit.org/changeset/239997
3902
3903         "Unreviewed, revert part of r239997 as it is not needed to fix
3904         the build."
3905         https://trac.webkit.org/changeset/239999
3906
3907 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3908
3909         Cannot tab out of WKWebView on macOS
3910         https://bugs.webkit.org/show_bug.cgi?id=161448
3911         <rdar://problem/28100085>
3912
3913         Reviewed by Dean Jackson.
3914
3915         Add a test that tabbing into and out of WKWebView works correctly.
3916
3917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3918         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3919         (WebKit2_CommandBackForwardTest::SetUp):
3920         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3921         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3922         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3923         (-[FocusableView canBecomeKeyView]):
3924         (TEST):
3925         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3926         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3927         (-[OffscreenWindow initWithSize:]):
3928         (-[OffscreenWindow isKeyWindow]):
3929         (-[OffscreenWindow isVisible]):
3930         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3931         (TestWebKitAPI::PlatformWebView::initialize):
3932         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3933         (-[ActiveOffscreenWindow isVisible]): Deleted.
3934         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3935
3936 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3937
3938         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3939         https://bugs.webkit.org/show_bug.cgi?id=193459
3940
3941         Reviewed by Mark Lam.
3942
3943         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3944         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3945
3946 2019-01-15  Chris Dumez  <cdumez@apple.com>
3947
3948         Regression(PSON) View becomes blank after click a cross-site download link
3949         https://bugs.webkit.org/show_bug.cgi?id=193361
3950         <rdar://problem/47099573>
3951
3952         Reviewed by Geoff Garen.
3953
3954         Add API test coverage.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3957         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3958
3959 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3960
3961         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3962         https://bugs.webkit.org/show_bug.cgi?id=193448
3963
3964         Reviewed by Antti Koivisto.
3965
3966         * LayoutReloaded/misc/LFC-passing-tests.txt:
3967
3968 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3969
3970         webkitpy: Implement device type specific expected results (Part 1)
3971         https://bugs.webkit.org/show_bug.cgi?id=192162
3972
3973         Reviewed by Lucas Forschler.
3974
3975         Device type specific expected results covers two related ideas. The first (covered by this change)
3976         is where to search for -expected.* files. The second is which tests to run based on the
3977         TestExpectations.txt file.
3978
3979         After this change, the baseline search path will be determined by the type of device running a
3980         test. Device type will be passed into any function which picks a file based on the baseline search
3981         path.
3982
3983         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3984         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3985         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3986         (Manager.run): Print baseline search path for each round of devices.
3987         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3988         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3989         (SingleTestRunner._expected_driver_output): Ditto.
3990         (SingleTestRunner._driver_input): Ditto.
3991         * Scripts/webkitpy/layout_tests/views/printing.py:
3992         (Printer.print_config): Move printing of baseline search path to a separate function.
3993         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3994         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3995         (Testprinter.test_print_config):
3996         (Testprinter.test_print_baseline_search_path):
3997         * Scripts/webkitpy/port/base.py:
3998         (Port.baseline_search_path): Pass device_type through.
3999         (Port._expected_baselines_for_suffixes): Ditto.
4000         (Port.expected_baselines): Ditto.
4001         (Port.expected_filename): Ditto.
4002         (Port.expected_checksum): Ditto.
4003         (Port.expected_image): Ditto.
4004         (Port.expected_audio): Ditto.
4005         (Port.expected_text): Ditto.
4006         (Port.reference_files): Ditto.
4007         (Port.tests): Ditto.
4008         (Port._expanded_paths): Ditto.
4009         (Port.skipped_layout_tests): Ditto.
4010         (Port.expectations_dict): Ditto.
4011         (Port._port_specific_expectations_files): Ditto.
4012         (Port.expectations_files): Ditto.
4013         (Port.test_search_path): Ditto.
4014         (Port._tests_for_other_platforms): Ditto.
4015         * Scripts/webkitpy/port/base_unittest.py:
4016         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4017         (PortTest.test_nonexistant_expectations): Ditto.
4018         (test_ref_tests_platform_directory): Ditto.
4019         * Scripts/webkitpy/port/darwin.py:
4020         (DarwinPort._port_specific_expectations_files): Accept device_type.
4021         * Scripts/webkitpy/port/driver.py:
4022         (DriverProxy):
4023         (DriverProxy.host): Expose _target_host for device_type information.
4024         * Scripts/webkitpy/port/gtk.py:
4025         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4026         * Scripts/webkitpy/port/ios.py:
4027         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4028         * Scripts/webkitpy/port/mac.py:
4029         (MacPort. default_baseline_search_path): Ditto.
4030         * Scripts/webkitpy/port/port_testcase.py:
4031         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4032         * Scripts/webkitpy/port/test.py:
4033         * Scripts/webkitpy/port/watch.py:
4034         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4035         * Scripts/webkitpy/port/win.py:
4036         (WinPort.test_search_path): Accept, but do not use, device_type.
4037         * Scripts/webkitpy/port/wpe.py:
4038         (WPEPort._port_specific_expectations_files): Ditto.
4039         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4040         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4041
4042 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4043
4044         [LFC] Use the containing block's padding box to position out-of-flow elements.
4045         https://bugs.webkit.org/show_bug.cgi?id=193431
4046
4047         Reviewed by Antti Koivisto.
4048
4049         * LayoutReloaded/misc/LFC-passing-tests.txt:
4050
4051 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4052
4053         Move a test implementation file that got misplaced in the Xcode project
4054
4055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4056
4057 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4058
4059         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4060         r239913, and r239914.
4061         https://bugs.webkit.org/show_bug.cgi?id=193407
4062
4063         These revisions caused an internal failure (Requested by
4064         Truitt on #webkit).
4065
4066         Reverted changesets:
4067
4068         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4069         https://bugs.webkit.org/show_bug.cgi?id=186016
4070         https://trac.webkit.org/changeset/239901
4071
4072         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4073         https://trac.webkit.org/changeset/239909
4074
4075         "Tried to fix the build."
4076         https://trac.webkit.org/changeset/239910
4077
4078         "Fixed iOS builds after r239910."
4079         https://trac.webkit.org/changeset/239912
4080
4081         "More build fixing."
4082         https://trac.webkit.org/changeset/239913
4083
4084         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4085         https://trac.webkit.org/changeset/239914
4086
4087 2019-01-14  Mark Lam  <mark.lam@apple.com>
4088
4089         Re-enable ability to build --cloop builds.
4090         https://bugs.webkit.org/show_bug.cgi?id=192955
4091         <rdar://problem/46882363>
4092
4093         Reviewed by Saam barati and Keith Miller.
4094
4095         The --cloop build option was being ignored this whole time since r236381.
4096         This patch makes it possible to build CLoop builds again.
4097
4098         * Scripts/build-jsc:
4099         * Scripts/webkitperl/FeatureList.pm:
4100         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4101
4102 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4103
4104         webkitpy: Expose device_type from host-like objects
4105         https://bugs.webkit.org/show_bug.cgi?id=193406
4106         <rdar://problem/47262305>
4107
4108         Reviewed by Lucas Forschler.
4109
4110         Devices should expose device_type. As a result, all host objects should
4111         provide a device_type property, even if they do not yet define a device_type.
4112
4113         * Scripts/webkitpy/common/system/systemhost.py:
4114         (SystemHost):
4115         (SystemHost.device_type):
4116         * Scripts/webkitpy/common/system/systemhost_mock.py:
4117         (MockSystemHost):
4118         (MockSystemHost.device_type):
4119         * Scripts/webkitpy/port/device.py:
4120         (Device):
4121         (Device.device_type):
4122         * Scripts/webkitpy/xcode/simulated_device.py:
4123         (SimulatedDeviceManager._find_exisiting_device_for_request):
4124         (SimulatedDeviceManager._disambiguate_device_type):
4125         (SimulatedDeviceManager._does_fulfill_request):
4126         (SimulatedDeviceManager.device_count_for_type):
4127         (SimulatedDeviceManager.initialize_devices):
4128         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4129         (test_available_devices):
4130         (test_swapping_devices):
4131
4132 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4133
4134         webkitpy: Support alternate simctl device list output (Follow-up fix)
4135         https://bugs.webkit.org/show_bug.cgi?id=193362
4136         <rdar://problem/47122965>
4137
4138         Rubber-stamped by Lucas Forschler.
4139
4140         * Scripts/webkitpy/xcode/simulated_device.py:
4141         (SimulatedDeviceManager.populate_available_devices):
4142
4143 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4144
4145         [iOS] Expose SPI to access the current sentence boundary and selection state
4146         https://bugs.webkit.org/show_bug.cgi?id=193398
4147         <rdar://problem/45893108>
4148
4149         Reviewed by Dean Jackson.
4150
4151         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4152         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4153         expected.
4154
4155         * TestWebKitAPI/EditingTestHarness.h:
4156         * TestWebKitAPI/EditingTestHarness.mm:
4157         (-[EditingTestHarness moveBackward]):
4158         (-[EditingTestHarness moveForward]):
4159         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4160
4161         Add a couple of new helper methods on EditingTestHarness.
4162
4163         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4164         (-[SelectionChangeObserver initWithWebView:]):
4165         (-[SelectionChangeObserver webView]):
4166         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4167         (-[SelectionChangeObserver currentSelectionAttributes]):
4168
4169 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4170
4171         [LFC][BFC] Add basic box-sizing support.
4172         https://bugs.webkit.org/show_bug.cgi?id=193392
4173
4174         Reviewed by Antti Koivisto.
4175
4176         * LayoutReloaded/misc/LFC-passing-tests.txt:
4177
4178 2019-01-14  Charlie Turner  <cturner@igalia.com>
4179
4180         [WPE] API test gardening
4181         https://bugs.webkit.org/show_bug.cgi?id=193319
4182
4183         Reviewed by Michael Catanzaro.
4184
4185         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4186         passing tests.
4187
4188 2019-01-14  Charlie Turner  <cturner@igalia.com>
4189
4190         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4191         https://bugs.webkit.org/show_bug.cgi?id=192977
4192
4193         Reviewed by Carlos Garcia Campos.
4194
4195         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4196         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4197         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4198         (TestWebKitAPI::GStreamerTest::SetUp):
4199         (TestWebKitAPI::GStreamerTest::TearDown):
4200         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4201         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4202         (TestWebKitAPI::TEST_F):
4203
4204 2019-01-14  Charlie Turner  <cturner@igalia.com>
4205
4206         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4207         https://bugs.webkit.org/show_bug.cgi?id=193332
4208
4209         Reviewed by Michael Catanzaro.
4210
4211         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4212         defined as a char16_t, which changed in ICU 59, the
4213         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4214         unsigned short. This test is relying on the behaviour that
4215         UChar=unsigned short, which doesn't hold across platforms and ICU
4216         library versions. The full fix would be a special syntax for
4217         literal characters so that these ambiguities do not arise. That
4218         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4219         (TestWebKitAPI::TEST):
4220
4221 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4222
4223         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4224
4225         * Scripts/make-dist:
4226         (Distcheck.configure):
4227
4228 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4229
4230         [ews-build] Update macOS queue configurations
4231         https://bugs.webkit.org/show_bug.cgi?id=193365
4232         <rdar://problem/47221073>
4233
4234         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4235
4236         * BuildSlaveSupport/ews-build/config.json:
4237
4238 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4239
4240         [LFC] Adjust assert for statically positioned fixed elements
4241         https://bugs.webkit.org/show_bug.cgi?id=193385
4242
4243         Reviewed by Antti Koivisto.
4244
4245         * LayoutReloaded/misc/LFC-passing-tests.txt:
4246
4247 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4248
4249         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4250         https://bugs.webkit.org/show_bug.cgi?id=193387
4251
4252         Reviewed by Carlos Garcia Campos.
4253
4254         * MiniBrowser/wpe/main.cpp:
4255         (main):
4256
4257 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4258
4259         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4260         https://bugs.webkit.org/show_bug.cgi?id=191655
4261         rdar://problem/46074680
4262
4263         Reviewed by Megan Gardner.
4264
4265         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4266         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4267
4268 2019-01-12  Dan Bernstein  <mitz@apple.com>
4269
4270         [Cocoa] Avoid importing directly from subumbrella frameworks
4271         https://bugs.webkit.org/show_bug.cgi?id=186016
4272         <rdar://problem/40591038>
4273
4274         Reviewed by Sam Weinig.
4275
4276         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4277           LaunchServices header.
4278         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4279           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4280         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4281           when using SDKs earlier than 10.13.
4282         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4283           and OTHER_CPLUSPLUSFLAGS.
4284         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4285           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4286         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4287           LaunchServices header.
4288
4289 2019-01-11  John Wilander  <wilander@apple.com>
4290
4291         Compile out Web API Statistics Collection
4292         https://bugs.webkit.org/show_bug.cgi?id=193370
4293         <rdar://problem/45388584>
4294
4295         Reviewed by Brent Fulgham.
4296
4297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4298             Defined ENABLE_WEB_API_STATISTICS, off by default.
4299
4300 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4301
4302         [WPE] Add gtk-doc
4303         https://bugs.webkit.org/show_bug.cgi?id=178900
4304
4305         Reviewed by Michael Catanzaro.
4306
4307         Add Tools/gtkdoc to manifest.txt.in files.
4308         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4309
4310         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4311         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4312
4313 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4314
4315         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4316         https://bugs.webkit.org/show_bug.cgi?id=193364
4317         <rdar://problem/47214117>
4318
4319         Reviewed by Tim Horton.
4320
4321         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4322         precise, whereas dragging near the middle of the textarea does.
4323
4324         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4325         (TestWebKitAPI::TEST):
4326
4327 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4328
4329         webkitpy: Support alternate simctl device list output
4330         https://bugs.webkit.org/show_bug.cgi?id=193362
4331         <rdar://problem/47122965>
4332
4333         Reviewed by Lucas Forschler.
4334
4335         * Scripts/webkitpy/xcode/simulated_device.py:
4336         (SimulatedDeviceManager.populate_available_devices):
4337
4338 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4339
4340         [ews-build] Update macOS queue configurations
4341         https://bugs.webkit.org/show_bug.cgi?id=193365
4342
4343         Reviewed by Lucas Forschler.
4344
4345         * BuildSlaveSupport/ews-build/config.json:
4346
4347 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4348
4349         webkitpy: Incorporate device type into baseline search path
4350         https://bugs.webkit.org/show_bug.cgi?id=193356
4351         <rdar://problem/47215515>
4352
4353         Reviewed by Lucas Forschler.
4354
4355         We need a way to include device type in the baseline search path for iOS to s