Source/WebKit:
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-17  Eric Liang  <ericliang@apple.com>
2
3         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
4         https://bugs.webkit.org/show_bug.cgi?id=200367
5
6         Reviewed by Darin Adler.
7
8         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
12         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
13         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
14         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
15         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
16         (TestWebKitAPI::TEST):
17
18 2019-08-17  Sam Weinig  <weinig@apple.com>
19
20         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
21         https://bugs.webkit.org/show_bug.cgi?id=200756
22
23         Reviewed by Darin Adler.
24
25         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
26         StringBuilder::append(...).
27
28         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
29         (TestWebKitAPI::TEST):
30
31 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
32
33         [iOS WK2] Scroll indicators disappear sometimes
34         https://bugs.webkit.org/show_bug.cgi?id=200791
35
36         Reviewed by Tim Horton.
37
38         Tests that test that scroll indicators survive subview replacement, and that
39         a custom view also survives subview replacement.
40
41         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
42         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
43         (TestWebKitAPI::TEST):
44         * TestWebKitAPI/cocoa/TestWKWebView.h:
45         * TestWebKitAPI/cocoa/TestWKWebView.mm:
46         (-[TestWKWebView performAfterLoading:]):
47         (-[UIView wkFirstSubviewWithClass:]):
48         (-[UIView wkFirstSubviewWithBoundsSize:]):
49         * TestWebKitAPI/ios/composited.html: Added.
50         * TestWebKitAPI/ios/overflow-scroll.html: Added.
51
52 2019-08-16  John Wilander  <wilander@apple.com>
53
54         Add John Wilander as WebKit Reviewer
55         https://bugs.webkit.org/show_bug.cgi?id=200837
56
57         Unreviewed update to contributors.json to change my status to reviewer.
58         See email on reviewers mailing list for proof of granted privileges.
59
60         * Scripts/webkitpy/common/config/contributors.json:
61
62 2019-08-16  Timothy Hatcher  <timothy@apple.com>
63
64         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
65         https://bugs.webkit.org/show_bug.cgi?id=200802
66         rdar://problem/54357818
67
68         Reviewed by Tim Horton.
69
70         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
71         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
72         (-[OpaqueTestWKWebView isOpaque]): Added.
73         (-[NonOpaqueTestWKWebView isOpaque]): Added.
74         (isOpaque): Added.
75         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
76         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
77         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
78
79 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews] Add build steps for Windows Factory
82         https://bugs.webkit.org/show_bug.cgi?id=200813
83
84         Reviewed by Jonathan Bedard.
85
86         * BuildSlaveSupport/ews-build/factories.py:
87         (WindowsFactory.__init__):
88
89 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
90
91         [ews] Report machine uptime in PrintConfiguration
92         https://bugs.webkit.org/show_bug.cgi?id=200812
93
94         Reviewed by Jonathan Bedard.
95
96         * BuildSlaveSupport/ews-build/steps.py:
97         (PrintConfiguration): Added uptime command.
98         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
99
100 2019-08-16  Chris Lord  <clord@igalia.com>
101
102         Add shared-mime-info to WPE WebKit jhbuild
103         https://bugs.webkit.org/show_bug.cgi?id=200768
104
105         Reviewed by Carlos Alberto Lopez Perez.
106
107         * wpe/jhbuild.modules:
108
109 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
110
111         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
112         https://bugs.webkit.org/show_bug.cgi?id=200620
113
114         Reviewed by Geoffrey Garen.
115
116         * DumpRenderTree/AccessibilityController.h:
117         * DumpRenderTree/GCController.h:
118         * DumpRenderTree/win/DRTDataObject.cpp:
119         * DumpRenderTree/win/DRTDataObject.h:
120         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
121         * DumpRenderTree/win/DRTDropSource.h:
122         * DumpRenderTree/win/DraggingInfo.h:
123         * DumpRenderTree/win/EditingDelegate.h:
124         * DumpRenderTree/win/EventSender.cpp:
125         * DumpRenderTree/win/FrameLoadDelegate.h:
126         * DumpRenderTree/win/HistoryDelegate.h:
127         * DumpRenderTree/win/MD5.h:
128         * DumpRenderTree/win/PolicyDelegate.h:
129         * DumpRenderTree/win/ResourceLoadDelegate.h:
130         * DumpRenderTree/win/TextInputController.h:
131         * DumpRenderTree/win/UIDelegate.cpp:
132         * DumpRenderTree/win/UIDelegate.h:
133         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
134         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
135         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
136         * TestWebKitAPI/Counters.h:
137         * TestWebKitAPI/PlatformWebView.h:
138         * TestWebKitAPI/Tests/WTF/Expected.cpp:
139         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
140         (TestWebKitAPI::DerefObserver::ref):
141         (TestWebKitAPI::DerefObserver::deref):
142         (TestWebKitAPI::TEST):
143         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
144         (TestWebKitAPI::DerefObserver::ref):
145         (TestWebKitAPI::DerefObserver::deref):
146         (TestWebKitAPI::TEST):
147         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
148         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
149         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
150         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
151         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
152         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
153         * WebKitTestRunner/EventSenderProxy.h:
154         * WebKitTestRunner/GeolocationProviderMock.h:
155         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
156         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
157         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
158         * WebKitTestRunner/PlatformWebView.h:
159         * WebKitTestRunner/TestInvocation.h:
160
161 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
162
163         Some improvements on web storage
164         https://bugs.webkit.org/show_bug.cgi?id=200373
165
166         Reviewed by Geoffrey Garen.
167
168         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
169         (TEST): update expectation for behavior change.
170
171         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
172         database file.
173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
174         (WTR::TestRunner::syncLocalStorage):
175         * WebKitTestRunner/InjectedBundle/TestRunner.h:
176
177         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
178         (WTR::TestController::resetStateToConsistentValues):
179         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
180         (WTR::StorageVoidCallback):
181         (WTR::TestController::clearIndexedDatabases):
182         (WTR::TestController::clearLocalStorage):
183         (WTR::TestController::syncLocalStorage):
184         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
185         with StorageVoidCallbackContext for general usage.
186         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
187         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
188         * WebKitTestRunner/TestController.h:
189
190         * WebKitTestRunner/TestInvocation.cpp:
191         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
192         SyncLocalStorage.
193
194 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
195
196         results.webkit.org: Add content hook to FlaskRequestsResponse
197         https://bugs.webkit.org/show_bug.cgi?id=200721
198
199         Rubber-stamped by Aakash Jain.
200
201         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
202         (FlaskRequestsResponse):
203         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
204         Response, conforming to request's API.
205
206 2019-08-15  Alex Christensen  <achristensen@webkit.org>
207
208         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
209         https://bugs.webkit.org/show_bug.cgi?id=200750
210         <rdar://problem/54232261> and <rdar://problem/52355829>
211
212         Reviewed by Tim Horton.
213
214         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
215         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
216         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
217         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
218         (contextMenuWebViewDriver):
219         (TEST):
220
221 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
222
223         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
224         https://bugs.webkit.org/show_bug.cgi?id=200726
225
226         Reviewed by Simon Fraser.
227
228         To get the pixels as an array of colors, draw the image into a memory
229         context. The backing memory buffer can then be accessed to get the image
230         pixels' colors.
231
232         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
233         (TestWebKitAPI::TEST):
234
235 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
236
237         Unreviewed, rolling out r248526.
238
239         Caused two IndexedDB perf tests to fail
240
241         Reverted changeset:
242
243         "Remove IDB-specific quota"
244         https://bugs.webkit.org/show_bug.cgi?id=196545
245         https://trac.webkit.org/changeset/248526
246
247 2019-08-14  Keith Rollin  <krollin@apple.com>
248
249         Remove support for macOS < 10.13
250         https://bugs.webkit.org/show_bug.cgi?id=200694
251         <rdar://problem/54278851>
252
253         Reviewed by Youenn Fablet.
254
255         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
256         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
257         101300. This means that expressions like
258         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
259         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
260
261         * MiniBrowser/AppKitCompatibilityDeclarations.h:
262         * MiniBrowser/mac/SettingsController.m:
263         (-[SettingsController init]):
264         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
265         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
266         (TestWebKitAPI::createPlatformFont): Deleted.
267         (TestWebKitAPI::compareFonts): Deleted.
268         (TestWebKitAPI::TEST_F): Deleted.
269         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
270         (TestWebKitAPI::TEST):
271         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
272         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
273         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
274         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
275         (runWebsiteDataStoreCustomPaths):
276         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
277
278 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
279
280         [JSC] Less contended MetaAllocator
281         https://bugs.webkit.org/show_bug.cgi?id=200278
282
283         Reviewed by Mark Lam.
284
285         Update the interface.
286
287         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
288
289 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
290
291         results.webkit.org: 500 errors on API endpoints don't return JSON
292         https://bugs.webkit.org/show_bug.cgi?id=200722
293
294         Reviewed by Aakash Jain.
295
296         * resultsdbpy/resultsdbpy/controller/api_routes.py:
297         (APIRoutes.response_500): We should return the response, instead of abort.
298
299 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
300
301         results.webkit.org: Don't save configuration multiple times in upload
302         https://bugs.webkit.org/show_bug.cgi?id=200719
303
304         Reviewed by Aakash Jain.
305
306         * resultsdbpy/resultsdbpy/model/upload_context.py:
307         (UploadContext.upload_test_results): Move registering of the configuration out
308         of the branch loop.
309
310 2019-08-14  Youenn Fablet  <youenn@apple.com>
311
312         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
313         https://bugs.webkit.org/show_bug.cgi?id=200706
314
315         Reviewed by Alex Christensen.
316
317         Libwebrtc is now soft-linked so we can reenable this test.
318
319         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
320         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
321
322 2019-08-13  Sam Weinig  <weinig@apple.com>
323
324         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
325         https://bugs.webkit.org/show_bug.cgi?id=200675
326
327         Reviewed by Darin Adler.
328
329         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
330         (TestWebKitAPI::TEST):
331         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
332
333 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
334
335         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
336         https://bugs.webkit.org/show_bug.cgi?id=200456
337
338         Reviewed by Jonathan Bedard.
339
340         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
341
342         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
343
344         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
345         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
346         (pointPolygonCollisionDetect): Detact
347         (pointRightRayLineSegmentCollisionDetect):
348         (ColorBatchRender):
349         (ColorBatchRender.prototype.lazyCreateColorSeqs):
350         (ColorBatchRender.prototype.addSeq):
351         (ColorBatchRender.prototype.batchRender):
352         (ColorBatchRender.prototype.clear):
353         (xScrollStreamRenderFactory):
354         (Timeline.CanvasSeriesComponent):
355         (offscreenCachedRenderFactory): Deleted.
356
357 2019-08-13  John Wilander  <wilander@apple.com>
358
359         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
360         https://bugs.webkit.org/show_bug.cgi?id=200642
361         <rdar://problem/53962073>
362
363         Reviewed by Alex Christensen.
364
365         This patch adds test infrastructure to query whether an origin has an
366         isolated NSURLSession or not.
367
368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
370         (WTR::TestRunner::hasStatisticsIsolatedSession):
371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
372         * WebKitTestRunner/TestController.cpp:
373         (WTR::TestController::hasStatisticsIsolatedSession):
374         * WebKitTestRunner/TestController.h:
375         * WebKitTestRunner/TestInvocation.cpp:
376         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
377
378 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
379
380         Update my status in contributors.json to committer.
381
382         Reviewed by Unreviewed
383
384         * Scripts/webkitpy/common/config/contributors.json:
385
386 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
387
388         Adds WebAuthn and AppSSO into watchlist
389         https://bugs.webkit.org/show_bug.cgi?id=200647
390
391         Reviewed by Dewei Zhu.
392
393         * Scripts/webkitpy/common/config/watchlist:
394
395 2019-08-13  Chris Dumez  <cdumez@apple.com>
396
397         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
398         https://bugs.webkit.org/show_bug.cgi?id=200674
399         <rdar://problem/50692748>
400
401         Reviewed by Geoff Garen.
402
403         Add API test coverage.
404
405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
406
407 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
408
409         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
410         https://bugs.webkit.org/show_bug.cgi?id=199857
411
412         Reviewed by Yusuke Suzuki.
413
414         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
415         (TestWebKitAPI::countThreadGroups):
416         (TestWebKitAPI::TEST):
417
418 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
419
420         AX: Homebrew is not allowed to run any script under sudo.
421         https://bugs.webkit.org/show_bug.cgi?id=173801
422
423         Reviewed by Carlos Alberto Lopez Perez.
424
425         Latest versions of Homebrew throw an error when run as root.
426         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
427
428         * gtk/install-dependencies:
429
430 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
431
432         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
433         https://bugs.webkit.org/show_bug.cgi?id=200644
434
435         Reviewed by Aakash Jain.
436
437         * Scripts/webkitpy/port/simulator_process.py:
438         (SimulatorProcess._start): Define system PID after launching app.
439
440 2019-08-12  Sam Weinig  <weinig@apple.com>
441
442         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
443         https://bugs.webkit.org/show_bug.cgi?id=200614
444
445         Reviewed by Darin Adler.
446
447         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
448         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
449         
450         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
451         StringBuilder::appendSubstring(...).
452
453         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
454         (TestWebKitAPI::TEST):
455         Update for renames.
456
457 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
458
459         Fix Crash in Mail Search
460         https://bugs.webkit.org/show_bug.cgi?id=200589
461
462         Reviewed by Tim Horton.
463
464         If you search backwards first in mail, we would crash,
465         this tests that codepath.
466
467         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
468         (TEST):
469
470 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
471
472         [iPadOS] Web pages sometimes load at half width in Safari
473         https://bugs.webkit.org/show_bug.cgi?id=200624
474         <rdar://problem/52694257>
475
476         Reviewed by Simon Fraser.
477
478         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
479         web page is created using the post-animated-resize web view dimensions, rather than the original layout
480         dimensions.
481
482         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
483
484 2019-08-12  Daniel Bates  <dabates@apple.com>
485
486         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
487         https://bugs.webkit.org/show_bug.cgi?id=200548
488
489         Reviewed by Darin Adler.
490
491         Expose infrastructure to simulate a literal raw key down and a literal key up event.
492
493         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
494         * TestRunnerShared/UIScriptContext/UIScriptController.h:
495         (WTR::UIScriptController::rawKeyDown):
496         (WTR::UIScriptController::rawKeyUp):
497         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
498         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
499         (WTR::UIScriptControllerIOS::rawKeyDown):
500         (WTR::UIScriptControllerIOS::rawKeyUp):
501
502 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
503
504         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
505         https://bugs.webkit.org/show_bug.cgi?id=200584
506
507         Reviewed by Philippe Normand.
508
509         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
510         Ignore style libwebrtc optionnal 'style issue'
511
512         * Scripts/webkitpy/style/checker.py:
513         * gstreamer/jhbuild.modules:
514         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
515
516 2019-08-12  Youenn Fablet  <youenn@apple.com>
517
518         Remove IDB-specific quota
519         https://bugs.webkit.org/show_bug.cgi?id=196545
520
521         Reviewed by Alex Christensen.
522
523         * DumpRenderTree/TestRunner.cpp:
524         (TestRunner::staticFunctions):
525         (setIDBPerOriginQuotaCallback): Deleted.
526         * DumpRenderTree/TestRunner.h:
527         * DumpRenderTree/mac/DumpRenderTree.mm:
528         (runTest):
529         * DumpRenderTree/mac/TestRunnerMac.mm:
530         (TestRunner::setIDBPerOriginQuota): Deleted.
531         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
532         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
533         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
534         * WebKitTestRunner/InjectedBundle/TestRunner.h:
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::resetStateToConsistentValues):
537         (WTR::TestController::setIDBPerOriginQuota): Deleted.
538         * WebKitTestRunner/TestController.h:
539         * WebKitTestRunner/TestInvocation.cpp:
540         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
541
542 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
543
544         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
545         https://bugs.webkit.org/show_bug.cgi?id=200621
546
547         Reviewed by Dan Bernstein.
548
549         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
550
551 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
552
553         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
554         https://bugs.webkit.org/show_bug.cgi?id=200604
555         <rdar://problem/51273130>
556
557         Reviewed by Megan Gardner.
558
559         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
560         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
561         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
562         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
563         remains the same.
564
565         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
566         the caret rect at initial scale 1.
567
568         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
569
570 2019-08-09  Ali Juma  <ajuma@chromium.org>
571
572         Don't allow cross-origin iframes to autofocus
573         https://bugs.webkit.org/show_bug.cgi?id=200515
574         <rdar://problem/54092988>
575
576         Reviewed by Ryosuke Niwa.
577
578         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
579         of cross-origin iframes, since it depends on focusing one of the
580         frames.
581
582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
583         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
584         (TestWebKitAPI::TEST):
585         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
586
587 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
590         https://bugs.webkit.org/show_bug.cgi?id=200591
591         <rdar://problem/54102238>
592
593         Reviewed by Ryosuke Niwa and Tim Horton.
594
595         Add a new API test to exercise -supportsImagePaste.
596
597         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
598         (TestWebKitAPI::TEST):
599         * TestWebKitAPI/ios/UIKitSPI.h:
600
601 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
602
603         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
604         [ews-build] Set svn:ignore to various EWS Buildbot files
605         https://bugs.webkit.org/show_bug.cgi?id=200581
606
607         Reviewed by Jonathan Bedard.
608
609         * BuildSlaveSupport/ews-build: Added property svn:ignore.
610
611 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
612
613         [ews-build] Set svn:ignore to various EWS Buildbot files
614         https://bugs.webkit.org/show_bug.cgi?id=200581
615
616         Reviewed by Jonathan Bedard.
617
618         * BuildSlaveSupport/ews-build: Added property svn:ignore.
619
620 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
621
622         [ews] Add buildbot.tac to repository
623         https://bugs.webkit.org/show_bug.cgi?id=200580
624
625         Reviewed by Jonathan Bedard.
626
627         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
628
629 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
630
631         [GTK] Add missing spellchecking packages to dependencies script
632         https://bugs.webkit.org/show_bug.cgi?id=200574
633
634         Reviewed by Philippe Normand.
635
636         These are needed for the spellchecking test in WebContext API tests.
637
638         * gtk/install-dependencies:
639
640 2019-08-08  Jon Lee  <jonlee@apple.com>
641
642         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
643
644 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
645
646         webkitpy: Disable shared clipboard between Simulators
647         https://bugs.webkit.org/show_bug.cgi?id=200546
648
649         Reviewed by Aakash Jain.
650
651         * Scripts/webkitpy/xcode/simulated_device.py:
652         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
653         managed by run-webkit-tests.
654
655 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
656
657         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
658         https://bugs.webkit.org/show_bug.cgi?id=200539
659         <rdar://problem/54082550>
660
661         Reviewed by Dean Jackson.
662
663         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
664         * PlatformFTW.cmake: Added.
665
666 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
667
668         [iOS] Position image information should respect the image orientation
669         https://bugs.webkit.org/show_bug.cgi?id=200487
670
671         Reviewed by Simon Fraser.
672
673         Add an API test to verify the position image information is drawn rotated
674         because of respecting its image orientation.
675
676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
677         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
678         (TestWebKitAPI::TEST):
679         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
680         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
681
682 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
683
684         [GTK] Fix WebContext languages test
685         https://bugs.webkit.org/show_bug.cgi?id=200538
686
687         Reviewed by Alex Christensen.
688
689         This test broke after the format of Accepted-Languages
690         was changed in r238236, update.
691
692         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
693         (testWebContextLanguages):
694
695 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
696
697         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
698         https://bugs.webkit.org/show_bug.cgi?id=200536
699
700         Reviewed by Carlos Alberto Lopez Perez.
701
702         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
703         (testWebsiteDataDatabases): Databases take a moment to be written,
704         wait before fetching the data as it's done in other tests.
705
706 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
707
708         results.webkit.org: Use canvas for timeline
709         https://bugs.webkit.org/show_bug.cgi?id=200172
710
711         Rubber-stamped by Aakash Jain.
712
713         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
714         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
715         (Commit.compare): Ditto.
716         (_CommitBank.commitByUuid): Ditto.
717         (_CommitBank._loadSiblings): Ditto.
718         (_CommitBank._load): Ditto.
719         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
720         (tickForCommit): Deleted.
721         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
722         which encompasses all results. Crucially, this function must exclude an UUIDs which may
723         refer to results excluded because of the limit argument.
724         (renderTimeline): Deleted.
725         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
726         with those results.
727         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
728         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
729         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
730         (inPlaceCombine): Combine result objects together.
731         (statsForSingleResult): Turn a single result into a stat object.
732         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
733         (Dot): Deleted.
734         (TimelineFromEndpoint): Renamed from Timeline.
735         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
736         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
737         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
738         cache contents.
739         (TimelineFromEndpoint.reload): Remove management of nested timelines.
740         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
741         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
742         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
743
744 2019-08-08  Brady Eidson  <beidson@apple.com>
745
746         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
747         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
748
749         Reviewed by Geoff Garen.
750
751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
752         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
753
754 2019-08-08  Rob Buis  <rbuis@igalia.com>
755
756         Add runtime flag for lazy image loading
757         https://bugs.webkit.org/show_bug.cgi?id=199794
758
759         Reviewed by Darin Adler.
760
761         Set lazyImageLoading preference as part of experimental features. Add
762         TestOption for lazy image loading.
763
764         * DumpRenderTree/TestOptions.cpp:
765         (TestOptions::TestOptions):
766         * DumpRenderTree/TestOptions.h:
767         * DumpRenderTree/mac/DumpRenderTree.mm:
768         (enableExperimentalFeatures):
769         (setWebPreferencesForTestOptions):
770         * DumpRenderTree/win/DumpRenderTree.cpp:
771         (enableExperimentalFeatures):
772
773 2019-08-08  Rob Buis  <rbuis@igalia.com>
774
775         Import lazy loading WPT tests
776         https://bugs.webkit.org/show_bug.cgi?id=199795
777
778         Reviewed by Darin Adler.
779
780         Only do loading/ exception for WebKit specific, non WPT tests.
781
782         * DumpRenderTree/mac/DumpRenderTree.mm:
783         (shouldLogFrameLoadDelegates):
784         * WebKitTestRunner/TestInvocation.cpp:
785         (WTR::TestInvocation::TestInvocation):
786
787 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
788
789         [Win][MiniBrowser] Add key accelerators for reload and close window
790         https://bugs.webkit.org/show_bug.cgi?id=200497
791
792         Reviewed by Brent Fulgham.
793
794         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
795
796         * MiniBrowser/win/MainWindow.cpp:
797         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
798         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
799         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
800
801 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
802
803         Add WHLSL and WebGPU to the watchlist file
804         https://bugs.webkit.org/show_bug.cgi?id=200509
805
806         Reviewed by Robin Morisset.
807
808         * Scripts/webkitpy/common/config/watchlist:
809
810 2019-08-07  Keith Rollin  <krollin@apple.com>
811
812         Unreviewed build fix after r248317 -- disable XCBuild because it
813         breaks incremental builds.
814
815         * Scripts/webkitdirs.pm:
816         (canUseXCBuild):
817
818 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
819
820         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
821         https://bugs.webkit.org/show_bug.cgi?id=200465
822
823         Reviewed by Alex Christensen.
824
825         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
826         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
827         finishing the test.
828         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
829         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
830
831 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
832
833         Unreviewed, a build fix after r248308
834
835         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
836
837         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
838
839 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
840
841         Unreviewed, a build fix after r248319
842
843         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
844
845         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
846         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
847         (WTR::TestController::addTestKeyToKeychain):
848         (WTR::TestController::cleanUpKeychain):
849         (WTR::TestController::keyExistsInKeychain):
850
851 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
852
853         Unreviewed, a build fix after r248308
854
855         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
856
857         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
858         (WTR::TestController::addTestKeyToKeychain):
859         (WTR::TestController::cleanUpKeychain):
860         (WTR::TestController::keyExistsInKeychain):
861
862 2019-08-06  Keith Rollin  <krollin@apple.com>
863
864         Enable XCBuild for `make` and `build-webkit` builds
865         https://bugs.webkit.org/show_bug.cgi?id=200476
866         <rdar://problem/50771065>
867
868         Reviewed by Jonathan Bedard.
869
870         All projects have now been tested under XCBuild and successfully
871         build. Enable the use of XCBuild when performing builds with `make` or
872         `build-webkit` and when using a sufficient version of Xcode. We set
873         this version to Xcode 11 since Xcode 10 -- even though it supports
874         XCBuild -- does not support a build facility needed to build WebKit
875         (Bug 197072, Bug 197116, Bug 197340).
876
877         Do not enable XCBuild in the Xcode projects themselves since these
878         projects may need to be used under older versions of Xcode and there's
879         no way to make those project changes sensitive to the version of Xcode
880         being used. This means that builds performed in the Xcode IDE will not
881         use XCBuild.
882
883         * Scripts/webkitdirs.pm:
884         (canUseXCBuild):
885
886 2019-08-06  Chris Dumez  <cdumez@apple.com>
887
888         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
889         https://bugs.webkit.org/show_bug.cgi?id=200475
890
891         Reviewed by Darin Adler.
892
893         * TestWebKitAPI/Tests/WTF/StringView.cpp:
894         (TestWebKitAPI::stringViewFromLiteral):
895         (TestWebKitAPI::stringViewFromUTF8):
896
897 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
898
899         Update my status in contributors.json to reviewer.
900
901         Regained the status after following the procedure for inactive contributors.
902         See r247136 for further explanation.
903
904         * Scripts/webkitpy/common/config/contributors.json:
905
906 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
907
908         [WebAuthN] Enable LocalAuthenticator for macOS
909         https://bugs.webkit.org/show_bug.cgi?id=182772
910         <rdar://problem/43347920>
911
912         Reviewed by Brent Fulgham.
913
914         Add an entitlement file to WebKitTestRunner such that it can access
915         the modern macOS keychain.
916
917         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
918         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
919         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
920         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
921         (WTR::TestController::addTestKeyToKeychain):
922         (WTR::TestController::cleanUpKeychain):
923         (WTR::TestController::keyExistsInKeychain):
924
925 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
926
927         [results.webkit.org Timeline] Performance improvements
928         https://bugs.webkit.org/show_bug.cgi?id=200406
929
930         Reviewed by Jonathan Bedard.
931
932         1. Unhook the scroll event when a series/axis have been removed from the container
933         2. Fix the axis's cache data structure out of sync.
934         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
935         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
936
937
938         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
939         (Signal.prototype.removeListener):
940         (prototype.stopAction): Unregsiter an action handler
941         (Ref):
942         (Ref.prototype.apply):
943         (Ref.prototype.destory):
944         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
945         (ApplyNewChildren):
946         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
947         (Timeline.CanvasSeriesComponent):
948
949 2019-08-06  Jer Noble  <jer.noble@apple.com>
950
951         Add test for behavior introduced in r248174
952         https://bugs.webkit.org/show_bug.cgi?id=200446
953
954         Reviewed by Eric Carlson.
955
956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
957         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
958         (WebKit::configureSecheuristic):
959         (WebKit::TEST):
960
961 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
962
963         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
964         https://bugs.webkit.org/show_bug.cgi?id=200464
965
966         Reviewed by Ross Kirsling.
967
968         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
969         menu, Alt-F4 to close window, and etc) don't work.
970
971         WK1 WebView doesn't have this issue because it processes key events
972         properly.
973
974         * MiniBrowser/win/WebKitBrowserWindow.cpp:
975         (WebKitBrowserWindow::WebKitBrowserWindow):
976         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
977         unhandled key events to the main window.
978         * MiniBrowser/win/WebKitBrowserWindow.h:
979
980 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
981
982         iOS 13: Overflow:hidden on body prevents PDF scroll
983         https://bugs.webkit.org/show_bug.cgi?id=200435
984         rdar://problem/53942888
985
986         Reviewed by Tim Horton.
987
988         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
989         to make sure that the scroll view is scrollable.
990
991         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
992         (TestWebKitAPI::TEST):
993
994 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
995
996         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
997         https://bugs.webkit.org/show_bug.cgi?id=200400
998
999         Reviewed by Jonathan Bedard.
1000
1001         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1002         (StatusBubble._build_bubble):
1003         (StatusBubble._queue_position):
1004
1005 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
1006
1007         run-webkit-tests asserts when the iPhone XR simulator is running
1008         https://bugs.webkit.org/show_bug.cgi?id=200404
1009         <rdar://problem/53878739>
1010
1011         Reviewed by Dean Jackson.
1012
1013         Support unicode in all logging statements tied to device model.
1014
1015         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1016         (Manager.run):
1017         * Scripts/webkitpy/layout_tests/views/printing.py:
1018         (Printer.print_baseline_search_path):
1019         * Scripts/webkitpy/port/device.py:
1020         (Device.__repr__):
1021         * Scripts/webkitpy/port/device_port.py:
1022         (DevicePort._install):
1023         (DevicePort.setup_test_run):
1024         (DevicePort.clean_up_test_run):
1025         (DevicePort.configuration_for_upload):
1026         * Scripts/webkitpy/port/ios.py:
1027         (IOSPort.default_baseline_search_path):
1028         * Scripts/webkitpy/xcode/device_type.py:
1029         (DeviceType.__str__):
1030         * Scripts/webkitpy/xcode/simulated_device.py:
1031         (SimulatedDeviceManager.populate_available_devices):
1032         (SimulatedDeviceManager._find_available_name):
1033         (SimulatedDeviceManager._get_device_identifier_for_type):
1034         (SimulatedDeviceManager._create_or_find_device_for_request):
1035         (SimulatedDeviceManager._does_fulfill_request):
1036         (SimulatedDeviceManager._wait_until_device_in_state):
1037         (SimulatedDeviceManager._wait_until_device_is_usable):
1038         (SimulatedDeviceManager._boot_device):
1039         (SimulatedDeviceManager.initialize_devices):
1040         (SimulatedDeviceManager.max_supported_simulators):
1041         (SimulatedDeviceManager.swap):
1042         (SimulatedDevice.is_usable):
1043         (SimulatedDevice._shut_down):
1044         (SimulatedDevice._delete):
1045         (SimulatedDevice.launch_app):
1046         (SimulatedDevice.__repr__):
1047
1048 2019-08-04  Chris Dumez  <cdumez@apple.com>
1049
1050         Ping loads should not prevent page caching
1051         https://bugs.webkit.org/show_bug.cgi?id=200418
1052         <rdar://problem/53901632>
1053
1054         Reviewed by Darin Adler.
1055
1056         Add TestOption to enable PageCache at UIProcess-level so that we can test
1057         page caching when navigating cross-origin with PSON enabled.
1058
1059         * WebKitTestRunner/TestController.cpp:
1060         (WTR::TestController::resetPreferencesToConsistentValues):
1061         (WTR::updateTestOptionsFromTestHeader):
1062         * WebKitTestRunner/TestOptions.h:
1063         (WTR::TestOptions::hasSameInitializationOptions const):
1064
1065 2019-08-02  Keith Rollin  <krollin@apple.com>
1066
1067         Consistently use Obj-C boolean literals
1068         https://bugs.webkit.org/show_bug.cgi?id=200405
1069         <rdar://problem/53880043>
1070
1071         Reviewed by Simon Fraser, Joseph Pecoraro.
1072
1073         There are places where we use equivalent but different expressions for
1074         Obj-C boolean objects. For example, we use both [NSNumber
1075         numberWithBool:YES] and @YES. There are places where both are used in
1076         the same function, such as -[WebPreferences initialize]. The boolean
1077         literal is in greater use and is more succinct, so standardize on
1078         that. Also, change @(YES/NO) to @YES/NO.
1079
1080         * DumpRenderTree/mac/ObjCController.m:
1081         (-[ObjCController objectOfClass:]):
1082         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1083         (TEST):
1084         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1085         (overrideAddObserverForName):
1086         * TestWebKitAPI/ios/mainIOS.mm:
1087         (main):
1088         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1089         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1090         * TestWebKitAPI/mac/mainMac.mm:
1091         (main):
1092         * WebKitLauncher/WebKitNightlyEnabler.m:
1093         (enableWebKitNightlyBehaviour):
1094
1095 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1096
1097         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
1098         https://bugs.webkit.org/show_bug.cgi?id=200402
1099         <rdar://problem/53823368>
1100
1101         Reviewed by Tim Horton.
1102
1103         Make it possible to run this test using the iPad simulator.
1104
1105         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
1106
1107         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
1108         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
1109         since this would result in differently sized text.
1110
1111         (mainScreenReferenceBoundsOverride):
1112         * TestWebKitAPI/ios/UIKitSPI.h:
1113
1114 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
1115
1116         API tests using permanent credentials should clear credentials left by previous tests
1117         https://bugs.webkit.org/show_bug.cgi?id=199729
1118
1119         Reviewed by Alex Christensen.
1120
1121         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
1122         credentials will not affect tests running after. There is a case where permanent credentials were left on the
1123         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
1124         failure. To prevent this from happening again, add cleanup at the begining of the tests.
1125
1126         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1127         (TEST):
1128         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1129         (TestWebKitAPI::TEST):
1130
1131 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
1132
1133         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
1134         https://bugs.webkit.org/show_bug.cgi?id=200394
1135         <rdar://problem/52914964>
1136
1137         Reviewed by Chris Fleizach.
1138
1139         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
1140
1141         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1142         (WTR::AccessibilityUIElement::isInTableCell const):
1143         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1144         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1145         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1146         (WTR::AccessibilityUIElement::isInTableCell const):
1147
1148 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
1149
1150         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
1151         https://bugs.webkit.org/show_bug.cgi?id=200397
1152
1153         Reviewed by Jonathan Bedard.
1154
1155         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1156
1157 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1158
1159         [macOS 10.15] Image dragged from Safari does not appear in Notes
1160         https://bugs.webkit.org/show_bug.cgi?id=188490
1161         <rdar://problem/39462717>
1162
1163         Reviewed by Andy Estes.
1164
1165         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
1166
1167         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
1168
1169 2019-08-02  Alex Christensen  <achristensen@webkit.org>
1170
1171         Fix API test after r248139
1172         https://bugs.webkit.org/show_bug.cgi?id=200102
1173
1174         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1175         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1176         This was supposed to be removed as part of reverting r245322.
1177
1178 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1179
1180         results.webkit.org: Force update cache when timeline updated
1181         https://bugs.webkit.org/show_bug.cgi?id=200363
1182
1183         Reviewed by Jonathan Bedard.
1184
1185         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1186         (offscreenCachedRenderFactory): Add ability to force the redraw.
1187         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
1188         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
1189
1190 2019-08-01  Alex Christensen  <achristensen@webkit.org>
1191
1192         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
1193         https://bugs.webkit.org/show_bug.cgi?id=200360
1194
1195         Reviewed by Tim Horton.
1196
1197         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1198         (cleanupITPDatabase):
1199         (TEST):
1200
1201 2019-08-01  Alex Christensen  <achristensen@webkit.org>
1202
1203         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
1204         https://bugs.webkit.org/show_bug.cgi?id=200102
1205         <rdar://problem/53275114>
1206
1207         Reviewed by Darin Adler.
1208
1209         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
1210         and because clicking on a TestWKWebView only works on Mac.
1211
1212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1213         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
1214         (-[UploadDelegate initWithDirectory:]):
1215         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1216         (-[UploadDelegate sentDirectory]):
1217         (TEST):
1218         * TestWebKitAPI/cocoa/TestWKWebView.h:
1219         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1220         (-[TestWKWebView sendClickAtPoint:]):
1221
1222 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1223
1224         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
1225         https://bugs.webkit.org/show_bug.cgi?id=200321
1226
1227         Reviewed by Jonathan Bedard.
1228
1229         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1230         Let the axis' height be defined in the option. Timeine component will use this value as
1231         padding-top for headers which allows headers start in the right position, even with multiple
1232         top axises.
1233         (Timeline.CanvasSeriesComponent):
1234         (prototype.Timeline.CanvasContainer):
1235
1236 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1237
1238         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
1239         https://bugs.webkit.org/show_bug.cgi?id=200347
1240
1241         Reviewed by Jonathan Bedard.
1242
1243         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1244         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
1245
1246 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
1247
1248         Improve flakiness of SOAuthorizationRedirect tests
1249         https://bugs.webkit.org/show_bug.cgi?id=200320
1250         <rdar://problem/53767057>
1251
1252         Reviewed by Alex Christensen.
1253
1254         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
1255         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
1256         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
1257         is executed.
1258
1259         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1260         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1261         (resetState):
1262         (TestWebKitAPI::TEST):
1263
1264 2019-08-01  Keith Rollin  <krollin@apple.com>
1265
1266         Update TestWebKitAPI for XCBuild
1267         https://bugs.webkit.org/show_bug.cgi?id=200311
1268         <rdar://problem/53773804>
1269
1270         Reviewed by Alex Christensen.
1271
1272         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
1273         technique. Now update WebKitLegacy to build under XCBuild after those
1274         changes. This work involves adding an "Apply Configuration to
1275         XCFileLists" build target, adding a check-xcfilelists.sh script,
1276         adding a "Check xcfilelists" build phase that calls that script,
1277         adding knowledge of the project to the generate-xcfilelists script,
1278         creating new .xcfilelist files, and adding those to the project.
1279
1280         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1281         (Application.__init__):
1282         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1283         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1284         (TestWebKitAPIGenerator):
1285         (TestWebKitAPIGenerator._get_project_file_path):
1286         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
1287         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
1288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1289         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
1290
1291 2019-08-01  Youenn Fablet  <youenn@apple.com>
1292
1293         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
1294         https://bugs.webkit.org/show_bug.cgi?id=200317
1295
1296         Reviewed by Eric Carlson.
1297
1298         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1301         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
1302         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1303         (TestWebKitAPI::TEST):
1304
1305 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
1306
1307         New EWS: Cannot see build status page when patch is waiting for tester
1308         https://bugs.webkit.org/show_bug.cgi?id=200333
1309
1310         Reviewed by Jonathan Bedard.
1311
1312         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1313         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
1314
1315 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1316
1317         [SOUP] Switch to use libsoup WebSockets API
1318         https://bugs.webkit.org/show_bug.cgi?id=200162
1319
1320         Reviewed by Michael Catanzaro.
1321
1322         Update libsoup version to 2.67.90.
1323
1324         * gtk/jhbuild.modules:
1325         * wpe/jhbuild.modules:
1326
1327 2019-07-31  Andy Estes  <aestes@apple.com>
1328
1329         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
1330         https://bugs.webkit.org/show_bug.cgi?id=200293
1331         <rdar://problem/52937749>
1332
1333         Reviewed by Alex Christensen.
1334
1335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1336         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
1337         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1338         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1339         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
1340         (TEST):
1341
1342 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
1343
1344         [ews-build] Enable all macOS queues on new EWS
1345         https://bugs.webkit.org/show_bug.cgi?id=199944
1346
1347         Reviewed by Jonathan Bedard.
1348
1349         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
1350         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1351         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
1352         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
1354         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
1355
1356 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1357
1358         Unreviewed test gardening, disable failing test for rdar://51752593.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1361
1362 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
1363
1364         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
1365         https://bugs.webkit.org/show_bug.cgi?id=200318
1366
1367         Reviewed by Aakash Jain.
1368
1369         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1370         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
1371         (Timeline.CanvasXAxisComponent): Use getLabel function.
1372
1373 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
1374
1375         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
1376         https://bugs.webkit.org/show_bug.cgi?id=200306
1377
1378         Reviewed by Michael Catanzaro.
1379
1380         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
1381         jsc-glib-4.0-scan for example).
1382
1383         * Scripts/webkitdirs.pm:
1384         (generateBuildSystemFromCMakeProject):
1385
1386 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1387
1388         Unreviewed test gardening, disable failing test for rdar://52355829.
1389
1390         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1391         (TEST):
1392
1393 2019-07-31  Keith Rollin  <krollin@apple.com>
1394
1395         Update WebKitLegacy for XCBuild
1396         https://bugs.webkit.org/show_bug.cgi?id=200310
1397         <rdar://problem/53773708>
1398
1399         Reviewed by Alex Christensen.
1400
1401         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
1402         technique. Now update WebKitLegacy to build under XCBuild after those
1403         changes. This work involves adding an "Apply Configuration to
1404         XCFileLists" build target, adding a check-xcfilelists.sh script,
1405         adding a "Check xcfilelists" build phase that calls that script,
1406         adding knowledge of the project to the generate-xcfilelists script,
1407         creating new .xcfilelist files, and adding those to the project.
1408
1409         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1410         (Application.__init__):
1411         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1412         (JavaScriptCoreGenerator):
1413         (WebCoreGenerator):
1414         (WebKitGenerator):
1415         (WebKitGenerator._get_generate_unified_sources_script):
1416         (WebKitLegacyGenerator):
1417         (WebKitLegacyGenerator._get_project_file_path):
1418         (WebKitLegacyGenerator._get_generate_unified_sources_script):
1419
1420 2019-07-31  Chris Dumez  <cdumez@apple.com>
1421
1422         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1423         https://bugs.webkit.org/show_bug.cgi?id=200086
1424         <rdar://problem/53501721>
1425
1426         Reviewed by Alex Christensen.
1427
1428         re-enable the API test.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1431         (TEST):
1432
1433 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1434
1435         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
1436         https://bugs.webkit.org/show_bug.cgi?id=200291
1437         <rdar://problem/53717946>
1438
1439         Reviewed by Megan Gardner.
1440
1441         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
1442         after closing the web view, while the web view's content view isn't the first responder.
1443
1444         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
1445         * TestWebKitAPI/ios/UIKitSPI.h:
1446
1447 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1448
1449         [GTK] Datalist element support for TextFieldInputType
1450         https://bugs.webkit.org/show_bug.cgi?id=98934
1451
1452         Reviewed by Michael Catanzaro.
1453
1454         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
1455
1456         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1457         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
1458         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
1459
1460 2019-07-30  Tim Horton  <timothy_horton@apple.com>
1461
1462         Remove some needless comments that snuck into the tree
1463
1464         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1465         (WTR::UIScriptController::setHardwareKeyboardAttached):
1466         (WTR::UIScriptController::playBackEventStream):
1467
1468 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1469
1470         [WebKit] Add PageLoadState::Observer C API
1471         https://bugs.webkit.org/show_bug.cgi?id=199848
1472
1473         Reviewed by Alex Christensen.
1474
1475         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1476         (WebKitBrowserWindow::WebKitBrowserWindow):
1477         (WebKitBrowserWindow::didChangeTitle):
1478         (WebKitBrowserWindow::didFinishNavigation): Deleted.
1479         * MiniBrowser/win/WebKitBrowserWindow.h:
1480         * TestWebKitAPI/CMakeLists.txt:
1481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1482         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1483         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1484         (TestWebKitAPI::didChangeActiveURL):
1485         (TestWebKitAPI::didChangeCanGoBack):
1486         (TestWebKitAPI::didChangeCanGoForward):
1487         (TestWebKitAPI::didChangeCertificateInfo):
1488         (TestWebKitAPI::didChangeEstimatedProgress):
1489         (TestWebKitAPI::didChangeHasOnlySecureContent):
1490         (TestWebKitAPI::didChangeIsLoading):
1491         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1492         (TestWebKitAPI::didChangeTitle):
1493         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1494         (TestWebKitAPI::didSwapWebProcesses):
1495         (TestWebKitAPI::willChangeActiveURL):
1496         (TestWebKitAPI::willChangeCanGoBack):
1497         (TestWebKitAPI::willChangeCanGoForward):
1498         (TestWebKitAPI::willChangeCertificateInfo):
1499         (TestWebKitAPI::willChangeEstimatedProgress):
1500         (TestWebKitAPI::willChangeHasOnlySecureContent):
1501         (TestWebKitAPI::willChangeIsLoading):
1502         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1503         (TestWebKitAPI::willChangeTitle):
1504         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1505         (TestWebKitAPI::didFinishNavigation):
1506         (TestWebKitAPI::TEST):
1507
1508 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1509
1510         DumpRenderTree.app: Add CFBundleShortVersionString
1511         https://bugs.webkit.org/show_bug.cgi?id=200269
1512         <rdar://problem/53412596>
1513
1514         Rubber-stamped by Aakash Jain.
1515
1516         * DumpRenderTree/ios/Info.plist:
1517
1518 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1519
1520         Add layout test coverage for <https://webkit.org/b/200215>
1521         https://bugs.webkit.org/show_bug.cgi?id=200245
1522         <rdar://problem/52976965>
1523
1524         Reviewed by Tim Horton.
1525
1526         Add new testing infrastructure. See below for more details.
1527
1528         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1529         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1530         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1531         (WTR::UIScriptController::setWillCreateNewPageCallback):
1532         (WTR::UIScriptController::willCreateNewPageCallback const):
1533
1534         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1535         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1536
1537         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1538         (WTR::UIScriptController::becomeFirstResponder):
1539
1540         Add and implement a Cocoa platform hook to make the web view first responder.
1541
1542         * WebKitTestRunner/TestController.cpp:
1543         (WTR::TestController::createOtherPage):
1544         * WebKitTestRunner/TestInvocation.cpp:
1545         (WTR::TestInvocation::willCreateNewPage):
1546         * WebKitTestRunner/TestInvocation.h:
1547         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1548         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1549         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1550
1551 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1552
1553         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1554         https://bugs.webkit.org/show_bug.cgi?id=200217
1555
1556         Reviewed by Alex Christensen.
1557
1558         * MiniBrowser/win/BrowserWindow.h:
1559         * MiniBrowser/win/MainWindow.cpp:
1560         (MainWindow::init):
1561         (MainWindow::resizeSubViews):
1562         (MainWindow::WndProc):
1563         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
1564         * MiniBrowser/win/MiniBrowserLib.rc:
1565         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
1566         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1567         (WebKitBrowserWindow::reload):
1568         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
1569         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1570         (WebKitLegacyBrowserWindow::reload):
1571         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1572
1573 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1574
1575         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
1576         https://bugs.webkit.org/show_bug.cgi?id=200218
1577
1578         Reviewed by Alex Christensen.
1579
1580         Moved the scheme supplementing logic from
1581         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
1582
1583         * MiniBrowser/win/MainWindow.cpp:
1584         (MainWindow::loadURL):
1585         (MainWindow::onURLBarEnter):
1586         * MiniBrowser/win/MainWindow.h:
1587         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1588         (WebKitLegacyBrowserWindow::loadURL):
1589
1590 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
1591
1592         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1593         https://bugs.webkit.org/show_bug.cgi?id=200254
1594
1595         Unreviewed infrastructure fix.
1596
1597         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
1598
1599 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
1600
1601         [Canvas Timeline] Compact canvas timeline
1602         https://bugs.webkit.org/show_bug.cgi?id=200177
1603
1604         Reviewed by Jonathan Bedard.
1605
1606         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1607         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1608         (Timeline.CanvasSeriesComponent):
1609
1610 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1611
1612         Multiple context menu actions broken for YouTube videos
1613         https://bugs.webkit.org/show_bug.cgi?id=199999
1614
1615         Reviewed by Eric Carlson.
1616
1617         Add a test case to check copy link address, open in new window and download options are not included in the
1618         context menu for non-downloadable media.
1619
1620         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1621         (writeNextChunk):
1622         (serverCallback):
1623         (testContextMenuLiveStream):
1624         (beforeAll):
1625         (afterAll):
1626
1627 2019-07-28  Tim Horton  <timothy_horton@apple.com>
1628
1629         Reorganize UIScriptController into platform-specific subclasses
1630         https://bugs.webkit.org/show_bug.cgi?id=200027
1631
1632         Reviewed by Simon Fraser.
1633
1634         Instead of a mishmash of #ifdefs and extraneous empty functions,
1635         reorganize UIScriptController so that we have a base class
1636         with functions that assert if called (to make it harder to
1637         accidentally write a test that depends on unimplemented
1638         functionality), and override them in platform specific subclasses
1639         as functionality is added.
1640
1641         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1642         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
1643         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1644         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
1645         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1646         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1647         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1648         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1649         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
1650         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
1651         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1652         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
1653         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
1654         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1655         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
1656         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1657
1658 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1659
1660         [Win][MiniBrowser] Remove PageLoadTestClient
1661         https://bugs.webkit.org/show_bug.cgi?id=200155
1662
1663         Reviewed by Brent Fulgham.
1664
1665         It is not used nowadays.
1666
1667         * MiniBrowser/win/CMakeLists.txt:
1668         * MiniBrowser/win/Common.cpp:
1669         (parseCommandLine):
1670         * MiniBrowser/win/Common.h:
1671         * MiniBrowser/win/MainWindow.cpp:
1672         (MainWindow::init):
1673         * MiniBrowser/win/MainWindow.h:
1674         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1675         (MiniBrowserWebHost::updateAddressBar):
1676         (MiniBrowserWebHost::didFinishLoadForFrame):
1677         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
1678         (MiniBrowserWebHost::didFailLoadWithError):
1679         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
1680         (MiniBrowserWebHost::didFirstLayoutInFrame):
1681         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
1682         * MiniBrowser/win/PageLoadTestClient.h: Removed.
1683         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1684         (ResourceLoadDelegate::identifierForInitialRequest):
1685         (ResourceLoadDelegate::willSendRequest):
1686         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1687         (ResourceLoadDelegate::didFailLoadingWithError):
1688         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1689         (WebKitBrowserWindow::create):
1690         (WebKitBrowserWindow::createNewPage):
1691         * MiniBrowser/win/WebKitBrowserWindow.h:
1692         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1693         (WebKitLegacyBrowserWindow::create):
1694         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1695         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
1696         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1697         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
1698         * MiniBrowser/win/WinMain.cpp:
1699         (wWinMain):
1700
1701 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1702
1703         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
1704         https://bugs.webkit.org/show_bug.cgi?id=200150
1705         <rdar://problem/53280170>
1706
1707         Reviewed by Brent Fulgham.
1708
1709         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1710         (TestWebKitAPI::TEST):
1711
1712 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1713
1714         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
1715         https://bugs.webkit.org/show_bug.cgi?id=200090
1716
1717         Unreviewed follow-up fix.
1718
1719         * resultsdbpy/resultsdbpy/view/view_routes.py:
1720         (ViewRoutes.__init__): Keep /search endpoint for existing links
1721
1722 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1723
1724         results.webkit.org: Add switch to filter results by expectation
1725         https://bugs.webkit.org/show_bug.cgi?id=200134
1726
1727         Rubber-stamped by Aakash Jain.
1728
1729         Users of the results database should be able to easily differentiate tests which are expected
1730         to fail verse tests which are unexpectedly failing.
1731
1732         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1733         (Timeline.render): Respect the willFilterExpected variable.
1734         (LegendLabel): Generates html for label in the legend.
1735         (Legend): Add switch for filter results.
1736         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
1737         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1738
1739 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
1740
1741         [ews-build] Use update-webkit script in Style EWS
1742         https://bugs.webkit.org/show_bug.cgi?id=193196
1743
1744         Reviewed by Jonathan Bedard.
1745
1746         * BuildSlaveSupport/ews-build/factories.py:
1747         (StyleFactory): Updated to use CheckOutSource step as well.
1748         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
1749         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1750
1751 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1752
1753         results.webkit.org: Support buildbot 0.8 CI links
1754         https://bugs.webkit.org/show_bug.cgi?id=200146
1755
1756         Reviewed by Aakash Jain.
1757
1758         * resultsdbpy/resultsdbpy/model/ci_context.py:
1759         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
1760         (BuildbotEightURLFactory.__init__):
1761         (BuildbotEightURLFactory.url):
1762         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
1763         (URLFactoryTest.test_old_builder_url):
1764         (URLFactoryTest):
1765         (URLFactoryTest.test_old_worker_url):
1766
1767 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1768
1769         results.webkit.org: Suite results shouldn't be the landing page
1770         https://bugs.webkit.org/show_bug.cgi?id=200090
1771
1772         Reviewed by Aakash Jain.
1773
1774         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
1775         * resultsdbpy/resultsdbpy/view/view_routes.py:
1776         (ViewRoutes.__init__): Make search the landing page instead of suite results.
1777         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1778         (WebSiteUnittest.test_main):
1779
1780 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1781
1782         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
1783         https://bugs.webkit.org/show_bug.cgi?id=200127
1784
1785         Unreviewed follow-up fix.
1786
1787         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1788         (Dot.toString): Use self instead of this in render callback.
1789
1790 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
1791
1792         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
1793         https://bugs.webkit.org/show_bug.cgi?id=200108
1794         <rdar://problem/53521238>
1795
1796         Reviewed by Chris Dumez.
1797
1798         Added an API test.
1799
1800         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1801         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1802         (TEST):
1803
1804 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
1805
1806         results.webkit.org: Color should be the worst result, count should include all results
1807         https://bugs.webkit.org/show_bug.cgi?id=200127
1808
1809         Rubber-stamped by Aakash Jain.
1810
1811         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1812         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
1813
1814 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
1815
1816         [Timeline]: Make timeline header width automatic, instead of fixed width
1817         https://bugs.webkit.org/show_bug.cgi?id=200059
1818
1819         Reviewed by Jonathan Bedard.
1820
1821         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1822         (.dot.crash):
1823         (.timeline>.header): Deleted.
1824         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1825         (.timeline>.content):
1826         (.timeline>.header):
1827
1828 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
1829
1830         [ESNext] Implement nullish coalescing
1831         https://bugs.webkit.org/show_bug.cgi?id=200072
1832
1833         Reviewed by Darin Adler.
1834
1835         * Scripts/run-jsc-stress-tests:
1836
1837 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1838
1839         Add Takashi Komori and Tomoki Imai as contributors
1840
1841         Unreviewed.
1842
1843         * Scripts/webkitpy/common/config/contributors.json:
1844
1845 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
1846
1847         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
1848         https://bugs.webkit.org/show_bug.cgi?id=200103
1849
1850         Reviewed by Mark Lam.
1851
1852         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
1853         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
1854
1855         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
1856         to the future implementation changes while it catches the severe issues we had.
1857
1858         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1859         (assertEmptyPointerSet):
1860         (assertHasOnlyObjects):
1861         (assertClean):
1862         (TEST):
1863         (allocateAndDeallocate):
1864
1865 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1866
1867         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
1868         https://bugs.webkit.org/show_bug.cgi?id=200074
1869
1870         Reviewed by Michael Catanzaro.
1871
1872         There was a latent issue. PluginTest::indicateTestFailure was
1873         using WTF::sleep without linking WTF.
1874
1875         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1876         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
1877
1878 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1879
1880         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
1881         https://bugs.webkit.org/show_bug.cgi?id=200073
1882
1883         Reviewed by Michael Catanzaro.
1884
1885         * TestWebKitAPI/PlatformGTK.cmake:
1886         * TestWebKitAPI/PlatformWPE.cmake:
1887         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
1888
1889 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1890
1891         [webkitperl] runCommand doesn't work in Windows Perl
1892         https://bugs.webkit.org/show_bug.cgi?id=199900
1893
1894         Reviewed by Don Olmstead.
1895
1896         runCommand was always failing implicit fork by using 'open' with
1897         '-|' in Windows Perl. Explicitly specify the command to 'open' not
1898         to do the implicit fork.
1899
1900         There is one more difference between Windows and Unix. 'open'
1901         successes on Windows even for non existent command while it fails
1902         on Unix. So, return the same error code on Unix as well as
1903         Windows.
1904
1905         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1906         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1907         command is not available on Windows. Use Perl ($^X) instead.
1908
1909 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1910
1911         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1912         https://bugs.webkit.org/show_bug.cgi?id=199326
1913         rdar://problem/42816957
1914
1915         Reviewed by Wenson Hsieh.
1916
1917         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1918         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1919         is being properly populated with additional context dictionary.
1920
1921         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1922         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1923         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1924         which will populate the additional autofill context dictionary.
1925
1926         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1927         populates the additional autofill context dictionary.
1928
1929         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1930         context dictionary.
1931
1932         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
1933         input field requires strong password work.
1934
1935         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1936         input field requires strong password work.
1937
1938         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1939         password work.
1940
1941 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1942
1943         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1944         https://bugs.webkit.org/show_bug.cgi?id=199489
1945
1946         Reviewed by Aakash Jain.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1949         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1950         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1951         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1952         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1953         (runTest): Record test binary failure
1954         (reportTestFailures): Report test binary failure
1955         (runJSCStressTests):
1956         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1957         (JscOnlyPort.build_jsc_command):
1958         (JscOnlyPort):
1959         (JscOnlyPort.run_javascriptcore_tests_command):
1960         * Scripts/webkitpy/common/config/ports_unittest.py:
1961         (DeprecatedPortTest.test_jsconly_port):
1962
1963 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1964
1965         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1966         https://bugs.webkit.org/show_bug.cgi?id=200079
1967         <rdar://problem/53474325>
1968
1969         Reviewed by Wenson Hsieh.
1970
1971         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1972
1973         * WebKitTestRunner/ios/TestControllerIOS.mm:
1974         (WTR::TestController::platformResetPreferencesToConsistentValues):
1975
1976 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1977
1978         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1979         https://bugs.webkit.org/show_bug.cgi?id=199927
1980
1981         Reviewed by Alex Christensen.
1982
1983         convertAbsolutepathToWebKitPath was failing to convert paths on
1984         Windows Perl due to path separators mismatch.
1985
1986         Renamed convertAbsolutepathToWebKitPath to
1987         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1988         paths to relative Unix paths.
1989
1990         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1991         (convertAbsolutePathToRelativeUnixPath): Added.
1992         (convertAbsolutepathToWebKitPath): Deleted.
1993
1994 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1995
1996         Fix iOS API test after r247759
1997         https://bugs.webkit.org/show_bug.cgi?id=200045
1998
1999         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2000         (TEST):
2001         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
2002         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
2003
2004 2019-07-23  Keith Rollin  <krollin@apple.com>
2005
2006         Remove rest of NavigatorContentUtils support
2007         https://bugs.webkit.org/show_bug.cgi?id=200052
2008         <rdar://problem/53467357>
2009
2010         Reviewed by Alex Christensen.
2011
2012         Bug 196070 removes most of the support for the never-used
2013         NavigatorContentUtils facility. However, there were still a couple of
2014         left-over references after that change. This patch sweeps those up.
2015
2016         * Scripts/webkitperl/FeatureList.pm:
2017
2018 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2019
2020         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
2021         https://bugs.webkit.org/show_bug.cgi?id=200045
2022
2023         Reviewed by Mark Lam.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2026         (TEST):
2027
2028 2019-07-23  Russell Epstein  <repstein@apple.com>
2029
2030         Unreviewed, rolling out r247745.
2031
2032         This broke API test
2033         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
2034         indicated by EWS
2035
2036         Reverted changeset:
2037
2038         "Move javaScriptConfigurationDirectory SPI from
2039         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
2040         runtime switchable"
2041         https://bugs.webkit.org/show_bug.cgi?id=200045
2042         https://trac.webkit.org/changeset/247745
2043
2044 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2045
2046         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
2047         https://bugs.webkit.org/show_bug.cgi?id=200045
2048
2049         Reviewed by Mark Lam.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2052         (TEST):
2053
2054 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2055
2056         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
2057         https://bugs.webkit.org/show_bug.cgi?id=199972
2058
2059         Reviewed by Jer Noble.
2060
2061         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2062         (TEST):
2063
2064 2019-07-23  Alicia Boya García  <aboya@igalia.com>
2065
2066         [WTF] Add DataMutex and MainThreadData wrappers
2067         https://bugs.webkit.org/show_bug.cgi?id=199831
2068
2069         Reviewed by Alex Christensen.
2070
2071         Added a very simple test that checks that DataMutex<T> indeed takes
2072         the lock and indeed holds data.
2073
2074         * TestWebKitAPI/CMakeLists.txt:
2075         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
2076         (TestWebKitAPI::TEST):
2077
2078 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2079
2080         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
2081         https://bugs.webkit.org/show_bug.cgi?id=200021
2082         <rdar://problem/53301325>
2083
2084         Reviewed by Ryosuke Niwa.
2085
2086         Add support for grabbing the child menu items of a context menu item.
2087
2088         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2089         (WTR::getMenuItemChildrenCallback):
2090
2091 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
2092
2093         WebKit should strip away system font names from the pasted content
2094         https://bugs.webkit.org/show_bug.cgi?id=199975
2095         <rdar://problem/53336353>
2096
2097         Reviewed by Darin Adler.
2098
2099         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
2100
2101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2102         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2103         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
2104
2105 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2106
2107         [ews-build] EWS fails to parse multi-line full_results.json
2108         https://bugs.webkit.org/show_bug.cgi?id=199992
2109
2110         Reviewed by Alexey Proskuryakov.
2111
2112         * BuildSlaveSupport/ews-build/layout_test_failures.py:
2113         (LayoutTestFailures.results_from_string): Concatenate content into single line.
2114         * BuildSlaveSupport/ews-build/steps_unittest.py:
2115         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
2116
2117 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
2118
2119         resultsdbpy: Handle case where the previous commit doesn't have the changelog
2120         https://bugs.webkit.org/show_bug.cgi?id=200015
2121
2122         Reviewed by Aakash Jain.
2123
2124         * resultsdbpy/resultsdbpy/model/repository.py:
2125         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
2126
2127 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2128
2129         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
2130         https://bugs.webkit.org/show_bug.cgi?id=200013
2131         <rdar://problem/52526901>
2132
2133         Reviewed by Simon Fraser.
2134
2135         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
2136
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2138         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
2139         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
2140         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
2141         * TestWebKitAPI/ios/UIKitSPI.h:
2142
2143 2019-07-22  Jer Noble  <jer.noble@apple.com>
2144
2145         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
2146         https://bugs.webkit.org/show_bug.cgi?id=199971
2147         <rdar://problem/51951218>
2148
2149         Reviewed by Alex Christensen.
2150
2151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2152         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
2153         (TestWebKitAPI::TEST):
2154
2155 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2156
2157         [ews-build] Add an EWS to run services tests
2158         https://bugs.webkit.org/show_bug.cgi?id=199994
2159
2160         Reviewed by Jonathan Bedard.
2161
2162         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
2163         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
2164         * BuildSlaveSupport/ews-build/steps.py:
2165         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
2166         (RunEWSUnitTests): Build step to run EWS unit-tests.
2167         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
2168         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2169         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
2170
2171 2019-07-22  Youenn Fablet  <youenn@apple.com>
2172
2173         Disable MediaRecorder for legacy WebKit
2174         https://bugs.webkit.org/show_bug.cgi?id=200001
2175         <rdar://problem/53400030>
2176
2177         Reviewed by Eric Carlson.
2178
2179         Enable MediaRecorder for testing purposes.
2180
2181         * DumpRenderTree/mac/DumpRenderTree.mm:
2182         (createWebViewAndOffscreenWindow):
2183
2184 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
2185
2186         results.webkit.org: Timeline header is too small
2187         https://bugs.webkit.org/show_bug.cgi?id=199955
2188
2189         Reviewed by Aakash Jain.
2190
2191         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
2192         (.timeline>.header): Make timeline header larder to fit configuration names.
2193
2194 2019-07-22  Alex Christensen  <achristensen@webkit.org>
2195
2196         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
2197         https://bugs.webkit.org/show_bug.cgi?id=199954
2198
2199         Reviewed by Geoff Garen.
2200
2201         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2202         (TEST):
2203
2204 2019-07-22  Alex Christensen  <achristensen@webkit.org>
2205
2206         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
2207         https://bugs.webkit.org/show_bug.cgi?id=199917
2208
2209         Reviewed by Sam Weinig.
2210
2211         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2212         (TEST):
2213
2214 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2215
2216         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
2217         https://bugs.webkit.org/show_bug.cgi?id=199980
2218
2219         Reviewed by Jonathan Bedard.
2220
2221         * BuildSlaveSupport/ews-build/steps.py:
2222         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
2223         * BuildSlaveSupport/ews-build/steps_unittest.py:
2224         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
2225         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
2226
2227 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2228
2229         [webkitpy] Add an unit test for setting up the driver environment without starting it.
2230         https://bugs.webkit.org/show_bug.cgi?id=199945
2231
2232         Reviewed by Michael Catanzaro.
2233
2234         This adds an unit test for the change implemented in r247663.
2235
2236         * Scripts/webkitpy/port/driver_unittest.py:
2237         (DriverTest.test_setup_environ_base_vars):
2238         (DriverTest):
2239         (DriverTest.test_setup_environ_without_starting_driver):
2240
2241 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2242
2243         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
2244         https://bugs.webkit.org/show_bug.cgi?id=199993
2245         <rdar://problem/49523528>
2246
2247         Reviewed by Beth Dakin.
2248
2249         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
2250
2251         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2252         (TestWebKitAPI::TEST):
2253         * TestWebKitAPI/cocoa/TestWKWebView.h:
2254
2255 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
2256
2257         Add accessibilityInsertText for text insertion in edit fields.
2258         https://bugs.webkit.org/show_bug.cgi?id=199973
2259
2260         Reviewed by Chris Fleizach.
2261
2262         Renamed accessibilityInsertText to _accessibilityInsertText.
2263
2264         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2265         (AccessibilityUIElement::insertText):
2266         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2267         (AccessibilityUIElement::insertText):
2268         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2269         (WTR::AccessibilityUIElement::insertText):
2270         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2271         (WTR::AccessibilityUIElement::insertText):
2272
2273 2019-07-20  Chris Dumez  <cdumez@apple.com>
2274
2275         Speed up HashTable decoding by reserving capacity and avoiding rehashing
2276         https://bugs.webkit.org/show_bug.cgi?id=199982
2277
2278         Reviewed by Saam Barati.
2279
2280         Add API test coverage.
2281
2282         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2283         (TestWebKitAPI::TEST):
2284
2285 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
2286
2287         Add accessibilityInsertText for text insertion in edit fields.
2288         https://bugs.webkit.org/show_bug.cgi?id=199973
2289
2290         Reviewed by Chris Fleizach.
2291
2292         Glue code to run new LayoutTests.
2293         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2294         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2295         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2296         (WTR::AccessibilityUIElement::insertText):
2297         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2298         (WTR::AccessibilityUIElement::insertText):
2299         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2300         (WTR::AccessibilityUIElement::insertText):
2301         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2302         (WTR::AccessibilityUIElement::insertText):
2303
2304 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2305
2306         Move webkit.css to opensource to support resultsdbpy's frontend
2307         https://bugs.webkit.org/show_bug.cgi?id=199957
2308
2309         Reviewed by Jonathan Bedard.
2310
2311         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
2312         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
2313         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
2314         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
2315
2316 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2317
2318         Move Ref.js to WebKit to support resultsdbpy's frontend
2319         https://bugs.webkit.org/show_bug.cgi?id=199956
2320
2321         Reviewed by Jonathan Bedard.
2322
2323         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2324         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2325         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2326         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
2327         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
2328         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
2329         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
2330         * resultsdbpy/resultsdbpy/view/templates/base.html:
2331         * resultsdbpy/resultsdbpy/view/templates/commits.html:
2332         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
2333         * resultsdbpy/resultsdbpy/view/templates/search.html:
2334         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2335         * resultsdbpy/resultsdbpy/view/view_routes.py:
2336
2337 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2338
2339         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
2340         https://bugs.webkit.org/show_bug.cgi?id=199945
2341
2342         Reviewed by Michael Catanzaro.
2343
2344         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
2345         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
2346         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
2347
2348         * Scripts/webkitpy/port/driver.py:
2349         (Driver._setup_environ_for_driver):
2350         (Driver._create_temporal_directories):
2351         (Driver):
2352         (Driver._start):
2353         (Driver._delete_temporal_directories):
2354         (Driver.stop):
2355         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
2356         (main):
2357         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
2358         (WebDriverTestRunner.__init__):
2359         * glib/api_test_runner.py:
2360         (TestRunner._setup_testing_environment): Ditto.
2361
2362 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
2363
2364         [ews-build] Display pre-existing Layout test failure names in the build summary
2365         https://bugs.webkit.org/show_bug.cgi?id=199941
2366
2367         Reviewed by Jonathan Bedard.
2368
2369         * BuildSlaveSupport/ews-build/steps.py:
2370         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2371
2372 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2373
2374         [GTK][WPE] run-webkit-tests should run with a temporal homedir
2375         https://bugs.webkit.org/show_bug.cgi?id=199738
2376
2377         Reviewed by Michael Catanzaro.
2378
2379         Run the tests with an empty homedir that is created inside the driver tmpdir.
2380         The driver tmpdir is a random directory created for each test runner that is purged after the run.
2381
2382         This is done to ensure that the test results are not affected by the user settings of any library.
2383
2384         * Scripts/webkitpy/port/driver.py:
2385         (Driver._setup_environ_for_driver):
2386         * Scripts/webkitpy/port/driver_unittest.py:
2387         (DriverTest.test_setup_environ_base_vars):
2388         (DriverTest):
2389         (DriverTest.test_create_temporal_home_dir):
2390
2391 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2392
2393         Remove pywebsockets from thirdparty
2394         https://bugs.webkit.org/show_bug.cgi?id=199710
2395
2396         Reviewed by Jonathan Bedard.
2397
2398         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
2399         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
2400
2401         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2402         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
2403         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
2404         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
2405         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
2406         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
2407         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
2408         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
2409         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
2410         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
2411         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
2412         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
2413         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
2414         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
2415         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
2416         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
2417         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
2418         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
2419         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
2420         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
2421         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
2422         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
2423
2424 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
2425
2426         results.webkit.org: Move resultsdbpy to WebKit
2427         https://bugs.webkit.org/show_bug.cgi?id=199837
2428         <rdar://problem/53172130>
2429
2430         Rubber-stamped by Aakash Jain.
2431
2432         Moving the entirety of the resultsdbpy library, which provides utilities to build
2433         a database designed to store, visualize and organize test results, into WebKit.
2434
2435         * Scripts/webkitpy/style/checker.py:
2436         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
2437         * resultsdbpy: Added.
2438         * resultsdbpy/MANIFEST.in: Added.
2439         * resultsdbpy/README.md: Added.
2440         * resultsdbpy/resultsdbpy: Added.
2441         * resultsdbpy/resultsdbpy/__init__.py: Added.
2442         * resultsdbpy/resultsdbpy/controller: Added.
2443         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
2444         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
2445         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
2446         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
2447         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
2448         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
2449         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
2450         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
2451         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
2452         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
2453         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
2454         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
2455         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
2456         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
2457         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
2458         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
2459         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
2460         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
2461         * resultsdbpy/resultsdbpy/flask_support: Added.
2462         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
2463         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
2464         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
2465         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
2466         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
2467         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
2468         * resultsdbpy/resultsdbpy/model: Added.
2469         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
2470         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
2471         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
2472         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
2473         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
2474         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
2475         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
2476         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
2477         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
2478         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
2479         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
2480         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
2481         * resultsdbpy/resultsdbpy/model/docker.py: Added.
2482         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2483         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2484         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2485         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2486         * resultsdbpy/resultsdbpy/model/model.py: Added.
2487         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2488         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2489         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2490         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2491         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2492         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2493         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2494         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2495         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2496         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2497         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2498         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2499         * resultsdbpy/resultsdbpy/run-tests: Added.
2500         * resultsdbpy/resultsdbpy/view: Added.
2501         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2502         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2503         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2504         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2505         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2506         * resultsdbpy/resultsdbpy/view/static: Added.
2507         * resultsdbpy/resultsdbpy/view/static/css: Added.
2508         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2509         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2510         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2511         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2512         * resultsdbpy/resultsdbpy/view/static/js: Added.
2513         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2514         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2515         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2516         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2517         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2518         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2519         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2520         * resultsdbpy/resultsdbpy/view/templates: Added.
2521         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2522         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2523         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2524         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2525         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2526         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2527         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2528         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2529         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2530         * resultsdbpy/setup.py: Added.
2531
2532 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2533
2534         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2535         https://bugs.webkit.org/show_bug.cgi?id=199923
2536
2537         Reviewed by Youenn Fablet.
2538
2539         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2540         (TestWebKitAPI::TEST):
2541
2542 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2543
2544         [ews-build] Enable iOS WK2 tester queue on new EWS
2545         https://bugs.webkit.org/show_bug.cgi?id=199867
2546
2547         Reviewed by Jonathan Bedard.
2548
2549         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2550         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2552         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2553
2554 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2555
2556         [ews-build] Add build step to AnalyzeLayoutTestsResults
2557         https://bugs.webkit.org/show_bug.cgi?id=199877
2558
2559         Reviewed by Jonathan Bedard.
2560
2561         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
2562
2563         * BuildSlaveSupport/ews-build/steps.py:
2564         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
2565         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
2566         (AnalyzeLayoutTestsResults.report_failure):
2567         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2568         (AnalyzeLayoutTestsResults.retry_build):
2569         (AnalyzeLayoutTestsResults._results_failed_different_tests):
2570         (AnalyzeLayoutTestsResults._report_flaky_tests):
2571         (AnalyzeLayoutTestsResults.start):
2572         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2573
2574 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2575
2576         Move NetworkCache ownership from NetworkProcess to NetworkSession
2577         https://bugs.webkit.org/show_bug.cgi?id=199817
2578
2579         Reviewed by Geoff Garen.
2580
2581         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2582         (TEST):
2583         * TestWebKitAPI/cocoa/TestWKWebView.h:
2584         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2585         (-[WKWebView synchronouslyLoadRequest:]):
2586
2587 2019-07-18  Youenn Fablet  <youenn@apple.com>
2588
2589         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
2590         https://bugs.webkit.org/show_bug.cgi?id=199769
2591         <rdar://problem/49390297>
2592
2593         Reviewed by Myles C. Maxfield.
2594
2595         Add a font containing one extended character not found in system fonts.
2596
2597         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2598         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
2599
2600 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
2601
2602         Unreviewed, Add Olivier Blin as contributor
2603
2604         * Scripts/webkitpy/common/config/contributors.json:
2605
2606 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2607
2608         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2609         https://bugs.webkit.org/show_bug.cgi?id=199855
2610
2611         Reviewed by Michael Catanzaro.
2612
2613         The webkitpy drivers for GTK and WPE use their own versions for setting
2614         up the environment and starting/stopping the drivers.
2615         This refactors those drivers to use the base class driver functions.
2616         As a benefit we get some fixes like support for setting the profiler
2617         environment variables, and a simpler code.
2618
2619         * Scripts/webkitpy/port/driver.py:
2620         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2621         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2622         * Scripts/webkitpy/port/headlessdriver.py:
2623         (HeadlessDriver._setup_environ_for_test):
2624         * Scripts/webkitpy/port/waylanddriver.py:
2625         (WaylandDriver._setup_environ_for_test):
2626         * Scripts/webkitpy/port/westondriver.py:
2627         (WestonDriver._setup_environ_for_test):
2628         (WestonDriver.stop):
2629         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2630         (WestonDriverTest.make_driver):
2631         * Scripts/webkitpy/port/xorgdriver.py:
2632         (XorgDriver._setup_environ_for_test):
2633         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2634         (XvfbDriver._setup_environ_for_test):
2635         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2636         (XvfbDriverTest.make_driver):
2637         (XvfbDriverTest.test_start):
2638         (XvfbDriverTest.test_start_arbitrary_worker_number):
2639         * Scripts/webkitpy/w3c/wpt_runner.py:
2640         (main): Start the driver before trying to get its environment to define all the environment variables.
2641         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2642         (WebDriverTestRunner.__init__): Ditto.
2643         * glib/api_test_runner.py:
2644         (TestRunner._setup_testing_environment): Ditto.
2645
2646 2019-07-17  Antoine Quint  <graouts@apple.com>
2647
2648         Disable Pointer Events prior to watchOS 6
2649         https://bugs.webkit.org/show_bug.cgi?id=199890
2650         <rdar://problem/53206113>
2651
2652         Reviewed by Dean Jackson.
2653
2654         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2655
2656 2019-07-17  Christopher Reid  <chris.reid@sony.com>
2657
2658         Bytecode cache should use FileSystem
2659         https://bugs.webkit.org/show_bug.cgi?id=199759
2660
2661         Reviewed by Yusuke Suzuki.
2662
2663         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2664
2665 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
2666
2667         check-webkit-style: Add limited Python3 support
2668         https://bugs.webkit.org/show_bug.cgi?id=199870
2669
2670         Rubber-stamped by Aakash Jain.
2671
2672         Since new services will be added in the near future which are Python 3, we
2673         need to support Python 3 style checks. For now, assume all Python files are
2674         Python 2 unless otherwise specified.
2675
2676         * Scripts/webkitpy/style/checker.py:
2677         (_all_categories): Add pycodestyle to valid categories for testing.
2678         (CheckerDispatcher._create_checker): Check that the provided Python file is in
2679         one of the declared Python 3 directories.
2680         * Scripts/webkitpy/style/checkers/python.py:
2681         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
2682         instead of pep8.
2683         (Python3Checker.__init__):
2684         (Python3Checker.check):
2685         * Scripts/webkitpy/thirdparty/__init__.py:
2686         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
2687         (AutoinstallImportHook._install_pycodestyle):
2688
2689 2019-07-17  Sam Weinig  <weinig@apple.com>
2690
2691         Add StringBuilder member function which allows makeString() style variadic argument construction
2692         https://bugs.webkit.org/show_bug.cgi?id=198997
2693
2694         Reviewed by Darin Adler.
2695
2696         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2697         Add basic test showing that StringBuilder::flexibleAppend can be used to
2698         append one or more string adaptable types.
2699
2700         * TestWebKitAPI/CMakeLists.txt:
2701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2702         Add WTFStringUtilities.cpp
2703
2704         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2705         Add basic test showing that StringBuilder::flexibleAppend can be used to
2706         append one or more string adaptable types.
2707
2708         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2709         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
2710         * TestWebKitAPI/WTFStringUtilities.h:
2711         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
2712         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
2713
2714 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2715
2716         Remove the file superfluously added in r247535.
2717
2718         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
2719         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
2720
2721 2019-07-17  Alex Christensen  <achristensen@webkit.org>
2722
2723         Add a runtime-disabled dialog element skeleton
2724         https://bugs.webkit.org/show_bug.cgi?id=199839
2725
2726         Reviewed by Ryosuke Niwa.
2727
2728         * DumpRenderTree/mac/DumpRenderTree.mm:
2729         (resetWebPreferencesToConsistentValues):
2730         * WebKitTestRunner/TestController.cpp:
2731         (WTR::TestController::resetPreferencesToConsistentValues):
2732         Enable the dialog element for layout tests.
2733
2734 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2735
2736         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
2737         https://bugs.webkit.org/show_bug.cgi?id=199851
2738
2739         Reviewed by Wenson Hsieh.
2740
2741         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
2742         this code is getting directly triggered from UIKeyboard's code.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
2746         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
2747         * TestWebKitAPI/ios/UIKitSPI.h:
2748
2749 2019-07-17  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r247505.
2752         https://bugs.webkit.org/show_bug.cgi?id=199871
2753
2754         "Caused failed ASSERT in stress test" (Requested by creid on
2755         #webkit).
2756
2757         Reverted changeset:
2758
2759         "Bytecode cache should use FileSystem"
2760         https://bugs.webkit.org/show_bug.cgi?id=199759
2761         https://trac.webkit.org/changeset/247505
2762
2763 2019-07-17  Russell Epstein  <russell_e@apple.com>
2764
2765         Adding self to contributors.json
2766
2767         Unreviewed.
2768
2769         * Scripts/webkitpy/common/config/contributors.json:
2770
2771 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
2772
2773         [ews-build] Parse full_results.json for layout-tests
2774         https://bugs.webkit.org/show_bug.cgi?id=199804
2775
2776         Reviewed by Jonathan Bedard.
2777
2778         * BuildSlaveSupport/ews-build/steps.py:
2779         (RunWebKitTests.start): Monitor json output.
2780         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
2781         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
2782         by the patch or are pre-existing.
2783         (ReRunWebKitTests.commandComplete): Ditto.
2784         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
2785         * BuildSlaveSupport/ews-build/steps_unittest.py:
2786         (BuildStepMixinAdditions.getProperty): Added.
2787         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
2788         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
2789
2790 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2791
2792         Unreviewed, rolling out r247512.
2793
2794         Broke API test runners
2795
2796         Reverted changeset:
2797
2798         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
2799         for setting up the environment and start the drivers."
2800         https://bugs.webkit.org/show_bug.cgi?id=199855
2801         https://trac.webkit.org/changeset/247512
2802
2803 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2804
2805         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2806         https://bugs.webkit.org/show_bug.cgi?id=199855
2807
2808         Reviewed by Carlos Garcia Campos.
2809
2810         The webkitpy drivers for GTK and WPE use their own versions for setting
2811         up the environment and starting/stopping the drivers.
2812         This refactors those drivers to use the base class driver functions.
2813         As a benefit we get some fixes like support for setting the profiler
2814         environment variables, and a simpler code.
2815
2816         * Scripts/webkitpy/port/driver.py:
2817         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2818         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2819         * Scripts/webkitpy/port/headlessdriver.py:
2820         (HeadlessDriver._setup_environ_for_test):
2821         * Scripts/webkitpy/port/waylanddriver.py:
2822         (WaylandDriver._setup_environ_for_test):
2823         * Scripts/webkitpy/port/westondriver.py:
2824         (WestonDriver._setup_environ_for_test):
2825         (WestonDriver.stop):
2826         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2827         (WestonDriverTest.make_driver):
2828         * Scripts/webkitpy/port/xorgdriver.py:
2829         (XorgDriver._setup_environ_for_test):
2830         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2831         (XvfbDriver._setup_environ_for_test):
2832         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2833         (XvfbDriverTest.make_driver):
2834         (XvfbDriverTest.test_start):
2835         (XvfbDriverTest.test_start_arbitrary_worker_number):
2836
2837 2019-07-16  Christopher Reid  <chris.reid@sony.com>
2838
2839         Bytecode cache should use FileSystem
2840         https://bugs.webkit.org/show_bug.cgi?id=199759
2841
2842         Reviewed by Yusuke Suzuki.
2843
2844         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2845
2846 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
2847
2848         svn-create-patch duplicates diffs when adding directories
2849         https://bugs.webkit.org/show_bug.cgi?id=199842
2850
2851         Reviewed by Dewei Zhu.
2852
2853         * Scripts/svn-create-patch:
2854         (findKind): Add function which returns what 'kind' of file the provided path is.
2855         (generateFileList): If the path is a directory and being added, don't add it.
2856         Instead, rely on the fact that its children will be added.
2857
2858 2019-07-16  Tim Horton  <timothy_horton@apple.com>
2859
2860         NSTextFinder holes don't scroll with the page
2861         https://bugs.webkit.org/show_bug.cgi?id=199815
2862         <rdar://problem/52280514>
2863
2864         Reviewed by Simon Fraser.
2865
2866         * MiniBrowser/mac/WK2BrowserWindowController.m:
2867         (-[MiniBrowserNSTextFinder performAction:]):
2868         (-[WK2BrowserWindowController awakeFromNib]):
2869         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
2870         -performAction: so that we can intercept the close action and
2871         hide our own find UI, since there is no delegate for that action yet.
2872
2873         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2874         (TEST):
2875
2876 2019-07-15  Keith Miller  <keith_miller@apple.com>
2877
2878         JSGlobalObject type macros should support feature flags and WeakRef should have one
2879         https://bugs.webkit.org/show_bug.cgi?id=199601
2880
2881         Reviewed by Mark Lam.
2882
2883         JSC options need to be set before the window is created for the test.
2884
2885         * DumpRenderTree/mac/DumpRenderTree.mm:
2886         (resetWebViewToConsistentStateBeforeTesting):
2887         * DumpRenderTree/win/DumpRenderTree.cpp:
2888         (setJSCOptions):
2889         (resetWebViewToConsistentStateBeforeTesting):
2890
2891 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2892
2893         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
2894         https://bugs.webkit.org/show_bug.cgi?id=193108
2895
2896         Reviewed by Simon Fraser.
2897
2898         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
2899         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
2900         at the wrong scale.
2901
2902         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2903         (takeWindowSnapshot):
2904         (createBitmapContextFromWebView):
2905
2906 2019-07-15  Brady Eidson  <beidson@apple.com>
2907
2908         Make WKURLSchemeTask thread safe.
2909         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2910
2911         Reviewed by Alex Christensen.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2914
2915 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2916
2917         Unreviewed, a build fix after r247437
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2920         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2921
2922 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2923
2924         [macOS 10.15] Cannot unbold selected text when the system font is used
2925         https://bugs.webkit.org/show_bug.cgi?id=199788
2926         <rdar://problem/52142570>
2927
2928         Reviewed by Tim Horton.
2929
2930         Add a new API test to verify that bolding and unbolding updates the
2931         shared font manager's selected font.
2932
2933         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2934         (TestWebKitAPI::TEST):
2935
2936 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2937
2938         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2939         https://bugs.webkit.org/show_bug.cgi?id=199790
2940         <rdar://problem/52790112>
2941
2942         Reviewed by Brent Fulgham.
2943
2944         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2945
2946         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2947         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2948         (configureSOAuthorizationWebView):
2949         (TestWebKitAPI::TEST):
2950         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2951         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2952         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2953         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2954         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2955
2956 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2957
2958         window.openDatabase is not writable
2959         https://bugs.webkit.org/show_bug.cgi?id=199737
2960         <rdar://problem/52551332>
2961
2962         Reviewed by Chris Dumez.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2965         (TEST):
2966         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2967
2968 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [ews-build] Parse and display layout test failures
2971         https://bugs.webkit.org/show_bug.cgi?id=199709
2972
2973         Rubber-stamped by Jonathan Bedard.
2974
2975         * BuildSlaveSupport/ews-build/steps.py:
2976         (RunWebKitTests.start): Initialize log_observer.
2977         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2978         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2979         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2980         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2981         (RunWebKitTests.getResultSummary): Update build and step summary.
2982         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2983
2984 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2985
2986         Unreviewed, rolling out r247393.
2987         https://bugs.webkit.org/show_bug.cgi?id=199797
2988
2989         broke mips and arm EWS (Requested by guijemont on #webkit).
2990
2991         Reverted changeset:
2992
2993         "run-javascriptcore-tests won't report test results for
2994         testmasm, testair, testb3, testdfg and test api"
2995         https://bugs.webkit.org/show_bug.cgi?id=199489
2996         https://trac.webkit.org/changeset/247393
2997
2998 2019-07-12  Andy Estes  <aestes@apple.com>
2999
3000         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
3001         https://bugs.webkit.org/show_bug.cgi?id=199768
3002         <rdar://problem/52002206>
3003
3004         Reviewed by Geoffrey Garen.
3005
3006         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3007         (TEST):
3008
3009 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3010
3011         [ews-build] Remove wincairo queue from old EWS and dashboard
3012         https://bugs.webkit.org/show_bug.cgi?id=199776
3013
3014         Reviewed by Don Olmstead.
3015
3016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3017         * QueueStatusServer/config/queues.py:
3018
3019 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3020
3021         [ews-build] Enable wincairo queue on new EWS
3022         https://bugs.webkit.org/show_bug.cgi?id=199593
3023
3024         Reviewed by Don Olmstead.
3025
3026         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
3027         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
3028         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3029         (StatusBubble): Enable wincairo status-bubble.
3030
3031 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3032
3033         [ews-app] Enable logging for clicking SubmitToEWS button
3034         https://bugs.webkit.org/show_bug.cgi?id=199757
3035
3036         Unreviewed minor infrastructure fix.
3037
3038         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3039         (SubmitToEWS.post): Change logging level from debug to info.
3040
3041 2019-07-12  Alex Christensen  <achristensen@webkit.org>
3042
3043         Enable client certificate authentication unit test
3044         https://bugs.webkit.org/show_bug.cgi?id=199735
3045
3046         Reviewed by Chris Dumez.
3047
3048         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3049         (TEST):
3050         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
3051         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
3052
3053 2019-07-12  Alex Christensen  <achristensen@webkit.org>
3054
3055         Begin unifying TestWebKitAPI build
3056         https://bugs.webkit.org/show_bug.cgi?id=199728
3057
3058         Reviewed by Keith Miller.
3059
3060         * TestWebKitAPI/Configurations/Base.xcconfig:
3061         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
3062         * TestWebKitAPI/Sources.txt: Added.
3063         * TestWebKitAPI/SourcesCocoa.txt: Added.
3064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065
3066 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
3067
3068         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
3069         https://bugs.webkit.org/show_bug.cgi?id=199489
3070         <rdar://problem/47891081>
3071
3072         Reviewed by Aakash Jain.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3075         (RunJavaScriptCoreTests.countFailures):
3076         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3077         * Scripts/run-javascriptcore-tests:
3078         (runTest):
3079         (reportTestFailures):
3080         (runJSCStressTests):
3081
3082 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3083
3084         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
3085         https://bugs.webkit.org/show_bug.cgi?id=199743
3086
3087         Reviewed by Jonathan Bedard.
3088
3089         * BuildSlaveSupport/ews-build/steps.py:
3090         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3091
3092 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
3093
3094         Unreviewed follow-up fix to r247364.
3095         [ews-build] Add build step to clean up .git/index.lock file
3096         https://bugs.webkit.org/show_bug.cgi?id=199722
3097
3098         * BuildSlaveSupport/ews-build/steps.py:
3099         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
3100         to be run after this step.
3101
3102 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
3103
3104         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
3105         https://bugs.webkit.org/show_bug.cgi?id=199524
3106         <rdar://problem/52783816>
3107
3108         Reviewed by Saam Barati.
3109
3110         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
3111         But this test has several problems.
3112
3113         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
3114            number is calculated by pageSize / sizeof(T), and this does not account the header
3115            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
3116            is very small, we can have many objects in one IsoPage. As a result, we need a large
3117            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
3118            less than numObjects.
3119
3120         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
3121            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
3122            page. This also makes the intention of this test wrong.
3123
3124         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
3125
3126         We make this test robust while we still keep this test white-box one to test the critical feature
3127         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
3128         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
3129         tier live, and check whether the deallocated memory is reused.
3130
3131         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3132         (TEST):
3133
3134 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
3135
3136         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
3137         https://bugs.webkit.org/show_bug.cgi?id=199625
3138
3139         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
3140         with ENABLE(ACCESSIBILITY) in the code.
3141
3142         Additionally, the TestRunner code generator now honors the
3143         Conditional IDL format.
3144
3145         Reviewed by Konstantin Tokarev.
3146
3147         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3148         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3149         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3150         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3151         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3152         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
3153         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
3154         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3155         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3156         (_generateImplementationFile):
3157
3158 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
3159
3160         [ews-build] Add build step to clean up .git/index.lock file
3161         https://bugs.webkit.org/show_bug.cgi?id=199722
3162
3163         Reviewed by Jonathan Bedard.
3164
3165         * BuildSlaveSupport/ews-build/steps.py:
3166         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
3167         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
3168         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
3169         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3170
3171 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
3172
3173         [iOS 13] Enable WebKit build
3174         https://bugs.webkit.org/show_bug.cgi?id=199481
3175         <rdar://problem/52619048>
3176
3177         Reviewed by Tim Horton.
3178
3179         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
3180
3181 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
3182
3183         Add test expectations and baselines for iOS 13
3184         https://bugs.webkit.org/show_bug.cgi?id=199329
3185
3186         Reviewed by Jonathan Bedard.
3187
3188         * Scripts/webkitpy/port/ios.py:
3189         (IOSPort): Increment current version to 13.
3190         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
3191         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
3192         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
3193         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
3194         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
3195         (IOSSimulatorTest.make_port):
3196         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
3197         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
3198         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
3199         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
3200         (IOSTest.make_port):
3201
3202 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
3203
3204         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
3205         https://bugs.webkit.org/show_bug.cgi?id=199692
3206
3207         Reviewed by Chris Fleizach.
3208
3209         Add support for output of AXDeletion and AXInsertion roles for tests.
3210         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
3211         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
3212
3213         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3214         * gtk/jhbuild.modules:
3215         * wpe/jhbuild.modules:
3216
3217 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
3218
3219         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
3220         https://bugs.webkit.org/show_bug.cgi?id=199707
3221
3222         Reviewed by Aakash Jain.
3223
3224         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
3225
3226 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
3227
3228         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
3229         https://bugs.webkit.org/show_bug.cgi?id=199693
3230         rdar://problem/51930364
3231
3232         Reviewed by Tim Horton.
3233
3234         New API tests that test scrollability with various combinations of content, insets,
3235         input accessory bars etc.
3236
3237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3238         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
3239         (TestWebKitAPI::webViewWithAutofocusedInput):
3240         (TestWebKitAPI::TEST):
3241
3242 2019-07-10  Tim Horton  <timothy_horton@apple.com>
3243
3244         Long pressing on attachments will crash the WebContent process
3245         https://bugs.webkit.org/show_bug.cgi?id=199696
3246         <rdar://problem/52920241>
3247
3248         Reviewed by Dean Jackson.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3251         (TestWebKitAPI::TEST):
3252         Add a test that previously crashed.
3253
3254 2019-07-10  Dean Jackson  <dino@apple.com>
3255
3256         Support MacCatalyst in run-webkit-app
3257         https://bugs.webkit.org/show_bug.cgi?id=199690
3258
3259         Reviewed by Tim Horton.
3260
3261         Add a --maccatalyst option to run-webkit-app that
3262         can launch MacCatalyst applications with a built WebKit.
3263
3264         * Scripts/webkitdirs.pm:
3265         (argumentsForConfiguration):
3266         (determineXcodeSDK):
3267         (xcodeSDKPlatformName):
3268         (determineConfigurationProductDir):
3269         (determinePortName):
3270         (isCatalystWebKit):
3271         (isAppleCocoaWebKit):
3272         (willUseCatalystSDK):
3273
3274 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3275
3276         [MacOS] Filter VPA info logged to stdout
3277         https://bugs.webkit.org/show_bug.cgi?id=199673
3278
3279         Reviewed by Eric Carlson.
3280
3281         * Scripts/webkitpy/port/mac.py:
3282         (MacPort.logging_patterns_to_strip):
3283
3284 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3285
3286         Unreviewed, rolling out r247286.
3287
3288         Caused TestWTF.WTF.StringOperators to fail on debug bots
3289
3290         Reverted changeset:
3291
3292         "Add StringBuilder member function which allows makeString()
3293         style variadic argument construction"
3294         https://bugs.webkit.org/show_bug.cgi?id=198997
3295         https://trac.webkit.org/changeset/247286
3296
3297 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
3298
3299         [ews-build] Explicitly use perl or python while invoking scripts
3300         https://bugs.webkit.org/show_bug.cgi?id=199669
3301
3302         Reviewed by Jonathan Bedard.
3303
3304         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
3305         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3306
3307 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
3308
3309         Run tests on mips EWS
3310         https://bugs.webkit.org/show_bug.cgi?id=196854
3311
3312         Reviewed by Carlos Garcia Campos.
3313
3314         * Scripts/webkitpy/common/config/ews.json:
3315
3316 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3317
3318         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
3319         https://bugs.webkit.org/show_bug.cgi?id=199579
3320
3321         Reviewed by Carlos Garcia Campos.
3322
3323         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
3324         (TestWebKitAPI::TEST):
3325
3326 2019-07-09  Chris Dumez  <cdumez@apple.com>
3327
3328         Fix integer type encoding / decoding in WKRemoteObjectCoder
3329         https://bugs.webkit.org/show_bug.cgi?id=199643
3330         <rdar://problem/52732342>
3331
3332         Reviewed by Anders Carlsson.
3333
3334         Update API test coverage.
3335
3336         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3337         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3338         (TEST):
3339         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3340         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
3341         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
3342         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
3343         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
3344
3345 2019-07-09  Sam Weinig  <weinig@apple.com>
3346
3347         Add StringBuilder member function which allows makeString() style variadic argument construction
3348         https://bugs.webkit.org/show_bug.cgi?id=198997
3349
3350         Reviewed by Darin Adler.
3351
3352         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3353         Add basic test showing that StringBuilder::flexibleAppend can be used to
3354         append one or more string adaptable types.
3355
3356 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
3357
3358         Only allow fetching and removing session credentials from WebsiteDataStore
3359         https://bugs.webkit.org/show_bug.cgi?id=199385
3360         <rdar://problem/52622080>
3361
3362         Reviewed by Alex Christensen.
3363
3364         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
3365         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
3366         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
3367
3368         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3369         (TEST):
3370         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3371         (TestWebKitAPI::TEST):
3372
3373 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3374
3375         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
3376         https://bugs.webkit.org/show_bug.cgi?id=199628
3377
3378         Reviewed by Brady Eidson.
3379
3380         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3381         (TestWebKitAPI::TEST_F):
3382
3383 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3384
3385         Remove invalid assertion in URLParser::domainToASCII
3386         https://bugs.webkit.org/show_bug.cgi?id=199624
3387
3388         Reviewed by Brady Eidson.
3389
3390         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3391         (TestWebKitAPI::TEST_F):
3392
3393 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3394
3395         URLParser should reserialize IPv6 addresses that end with a colon
3396         https://bugs.webkit.org/show_bug.cgi?id=199627
3397
3398         Reviewed by Brady Eidson.
3399
3400         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3401         (TestWebKitAPI::TEST_F):
3402
3403 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3404
3405         [ews-build] Do not run unix commands for windows in PrintConfiguration
3406         https://bugs.webkit.org/show_bug.cgi?id=199605
3407
3408         Reviewed by Jonathan Bedard.
3409
3410         * BuildSlaveSupport/ews-build/steps.py:
3411
3412 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3413
3414         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
3415         https://bugs.webkit.org/show_bug.cgi?id=199487
3416
3417         Reviewed by Ross Kirsling.
3418
3419         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
3420         failing to open testglobalscope_constructors_file which was
3421         created by using tempfile.mkstemp() because it keeps the file
3422         open. Use tempfile.mkdtemp() to create temporary files in the
3423         temporary directory instead of tempfile.mkstemp().
3424
3425         * Scripts/webkitpy/bindings/main.py:
3426         (BindingsTests.run_tests):
3427         (BindingsTests.main):
3428         (BindingsTests.close_and_remove): Deleted.
3429
3430 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3431
3432         [ews-build] Add KillOldProcesses step before running API or Layout tests
3433         https://bugs.webkit.org/show_bug.cgi?id=199592
3434
3435         Reviewed by Jonathan Bedard.
3436
3437         * BuildSlaveSupport/ews-build/factories.py:
3438
3439 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
3440
3441         test-webkitpy: Explicitly use Python 2.7 lldb library
3442         https://bugs.webkit.org/show_bug.cgi?id=199578
3443         <rdar://problem/51853557>
3444
3445         Reviewed by Aakash Jain.
3446
3447         * Scripts/webkitpy/common/system/systemhost.py:
3448         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
3449         * Scripts/webkitpy/test/main.py:
3450         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
3451
3452 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
3453
3454         Add test expectations and baselines for Catalina
3455         https://bugs.webkit.org/show_bug.cgi?id=199328
3456
3457         Reviewed by Jonathan Bedard.
3458
3459         * Scripts/webkitpy/port/mac.py:
3460         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
3461
3462 2019-07-08  Christopher Reid  <chris.reid@sony.com>
3463
3464         Implement MappedFileData for Windows
3465         https://bugs.webkit.org/show_bug.cgi?id=198269
3466
3467         Reviewed by Darin Adler.
3468
3469         * TestWebKitAPI/PlatformWin.cmake:
3470
3471 2019-07-08  Charlie Turner  <cturner@igalia.com>
3472
3473         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
3474         https://bugs.webkit.org/show_bug.cgi?id=197558
3475
3476         Reviewed by Xabier Rodriguez-Calvar.
3477
3478         On shutdown we can easily deadlock the web process if we don't
3479         ensure all network operations are completed before comitting state
3480         changes. In HLS, make sure the network operations are cancelled,
3481         and also prevent hlsdemux's retry logic from scuppering our
3482         efforts.
3483
3484         * gstreamer/jhbuild.modules: Include the patch.
3485         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3486
3487 2019-07-08  Antoine Quint  <graouts@apple.com>
3488
3489         [Pointer Events] Enable only on the most recent version of the supported iOS family
3490         https://bugs.webkit.org/show_bug.cgi?id=199562
3491         <rdar://problem/52766511>
3492
3493         Reviewed by Dean Jackson.
3494
3495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3496
3497 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3498
3499         Long hang when loading a cnn.com page on iOS
3500         https://bugs.webkit.org/show_bug.cgi?id=199556
3501
3502         Reviewed by Zalan Bujtas.
3503
3504         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3505         to load a test page of your choice.
3506
3507         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3508         (-[WebViewController viewDidLoad]):
3509
3510 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3511
3512         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3513         https://bugs.webkit.org/show_bug.cgi?id=199503
3514
3515         Reviewed by Wenson Hsieh.
3516
3517         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3518         _requestActivatedElementAtPosition
3519
3520         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3521         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3522         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3523         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3524         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3525         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3526         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3527         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3528         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3529         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3530         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3531         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3532
3533 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3534
3535         Unreviewed, rolling out r247115.
3536
3537         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3538
3539         Reverted changeset:
3540
3541         "[WHLSL] Standard library is too big to directly include in
3542         WebCore"
3543         https://bugs.webkit.org/show_bug.cgi?id=198186
3544         https://trac.webkit.org/changeset/247115
3545
3546 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3547
3548         Unreviewed, rolling out r247123.
3549
3550         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3551         fail.
3552
3553         Reverted changeset:
3554
3555         "Only allow fetching and removing session credentials from
3556         WebsiteDataStore"
3557         https://bugs.webkit.org/show_bug.cgi?id=199385
3558         https://trac.webkit.org/changeset/247123
3559
3560 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3561
3562         Touching media controls sometimes shows software keyboard
3563         https://bugs.webkit.org/show_bug.cgi?id=199490
3564         <rdar://problem/52076270>
3565
3566         Reviewed by Eric Carlson.
3567
3568         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
3569         ChangeLog entries for more detail.
3570
3571         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3572         (WTR::UIScriptController::hasInputSession const):
3573         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3574         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3575         (WTR::UIScriptController::hasInputSession const):
3576         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3577         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3578         (WTR::UIScriptController::hasInputSession const):
3579
3580 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
3581
3582         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
3583         https://bugs.webkit.org/show_bug.cgi?id=199458
3584
3585         Reviewed by Michael Catanzaro.
3586
3587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3588         * QueueStatusServer/config/queues.py:
3589
3590 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3591
3592         [GTK] Fix browserperfdash script after r239522
3593         https://bugs.webkit.org/show_bug.cgi?id=199496
3594
3595         Reviewed by Michael Catanzaro.
3596
3597         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
3598         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
3599
3600 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3601
3602         [webkitpy] test-webkitpy is broken on Linux since r246662
3603         https://bugs.webkit.org/show_bug.cgi?id=199493
3604
3605         Reviewed by Michael Catanzaro.
3606
3607         * Scripts/webkitpy/test/main.py:
3608         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
3609
3610 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3611
3612         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
3613         https://bugs.webkit.org/show_bug.cgi?id=199406
3614
3615         Reviewed by Michael Catanzaro.
3616
3617         Install the Woff2 libraries and headers from the system package
3618         and stop building them on the JHBuild.
3619
3620         * gtk/install-dependencies:
3621         * gtk/jhbuild.modules:
3622         * wpe/install-dependencies:
3623         * wpe/jhbuild.modules:
3624
3625 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3626
3627         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
3628         https://bugs.webkit.org/show_bug.cgi?id=199449
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         * Scripts/webkitdirs.pm:
3633         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
3634
3635 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3636
3637         Unreviewed, GTK a11y tests fix after r247071
3638
3639         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3640         (WTR::AccessibilityUIElement::popupValue const):
3641
3642 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3643
3644         [ews-build] Enable WPE and GTK queues on new EWS
3645         https://bugs.webkit.org/show_bug.cgi?id=199234
3646
3647         Reviewed by Jonathan Bedard.
3648
3649         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
3650         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
3651  &n