3b820a3d8362c5c4100ff6c6a7da7cbebb270e3c
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-22  Daniel Bates  <dabates@apple.com>
2
3         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
4         runtime in simctl output
5         https://bugs.webkit.org/show_bug.cgi?id=140751
6
7         Reviewed by David Kilzer.
8
9         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
10         with an error because it does not know how to parse the output of the simctl tool
11         to identify an Apple Internal runtime.
12
13         * Scripts/webkitpy/xcode/simulator.py:
14         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
15         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
16         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
17         the runtime is an internal runtime.
18         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
19         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
20         appropriate value.
21         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
22         it updates the appropriate Runtime object.
23         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
24         looking up a Runtime object for an internal runtime.
25
26 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
27
28         LeaksViewer doesn't show recent builds if there are less than 10
29         https://bugs.webkit.org/show_bug.cgi?id=140716
30
31         Reviewed by Tim Horton.
32
33         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
34
35 2015-01-22  Lucas Forschler  <lforschler@apple.com>
36
37         Add Apple build slaves.
38         Fixed text alignment for slave list.
39         
40         Unreviewed.
41         
42         * BuildSlaveSupport/build.webkit.org-config/config.json:
43
44 2015-01-21  Lucas Forschler  <lforschler@apple.com>
45
46         Teach build.webkit.org about bot308 and bot309.
47         
48         Unreviewed.
49         
50         * BuildSlaveSupport/build.webkit.org-config/config.json:
51
52 2015-01-21  Lucas Forschler  <lforschler@apple.com>
53
54         Add two Apple Mavericks slaves.
55         
56         Unreviewed.
57         
58         * BuildSlaveSupport/build.webkit.org-config/config.json:
59
60 2015-01-21  Daniel Bates  <dabates@apple.com>
61
62         Add iOS WebKit1 TestExpectation file
63         https://bugs.webkit.org/show_bug.cgi?id=140739
64
65         Reviewed by David Kilzer.
66
67         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
68         expectations in directory LayoutTests/platform/ios-simulator-wk1.
69
70         * Scripts/webkitpy/port/ios.py:
71         (IOSSimulatorPort.default_baseline_search_path):
72
73 2015-01-21  David Kilzer  <ddkilzer@apple.com>
74
75         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
76         <http://webkit.org/b/140704>
77
78         Reviewed by Daniel Bates.
79
80         * Scripts/configure-xcode-for-ios-development:
81         - Update copyright.
82         - Remove FIXME addressed by r178709.
83         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
84         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
85         missing headers from iphonesimulator SDK to iphoneos SDK.
86         (sdkDirectory): Add method that returns SDK directory.
87         (sdkPlatformDirectory): Extract method from
88         xcodeSDKSpecificationsPath() that returns SDK platform
89         directory.
90         (xcodeSDKSpecificationsPath): Update to use
91         sdkPlatformDirectory().
92
93 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
94
95         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
96         https://bugs.webkit.org/show_bug.cgi?id=140731
97
98         Reviewed by Tim Horton.
99
100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
101         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
102
103 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
104
105         [Win] eventSender does not support scalePageBy
106         https://bugs.webkit.org/show_bug.cgi?id=140726
107         <rdar://problem/19549865>
108
109         Reviewed by Dean Jackson.
110
111         * DumpRenderTree/win/EventSender.cpp:
112         (scalePageByCallback): Provide implementation using new WebView method.
113
114 2015-01-21  Lucas Forschler  <lforschler@apple.com>
115
116         Remove Apple Mountain Lion Build & Test slaves.
117         
118         Unreviewed.
119
120         * BuildSlaveSupport/build.webkit.org-config/config.json:
121
122 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
123
124         Remove ENABLE(INSPECTOR) ifdef guards
125         https://bugs.webkit.org/show_bug.cgi?id=140668
126
127         Reviewed by Darin Adler.
128
129         * DumpRenderTree/mac/TestRunnerMac.mm:
130         (TestRunner::showWebInspector):
131         (TestRunner::closeWebInspector):
132         (TestRunner::evaluateInWebInspector):
133         * Scripts/webkitperl/FeatureList.pm:
134         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
135         (WTR::TestRunner::showWebInspector):
136         (WTR::TestRunner::closeWebInspector):
137         (WTR::TestRunner::evaluateInWebInspector):
138         * WebKitTestRunner/TestInvocation.cpp:
139         (WTR::TestInvocation::invoke):
140
141 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
142
143         Update build.webkit.org/dashboard to match current Mac queues.
144
145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
152         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
153         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
154
155 2015-01-20  Lucas Forschler  <lforschler@apple.com>
156
157         Update Apple MountainLion Leaks slave to Yosemite
158         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
159         
160         Unreviewed.
161
162         * BuildSlaveSupport/build.webkit.org-config/config.json:
163
164 2015-01-20  Lucas Forschler  <lforschler@apple.com>
165
166         Update LeaksViewer from MountainLion to Yosemite
167         
168         Reviewed by Alexey Proskuryakov.
169
170         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
171         (LeaksViewer._displayURLPrompt):
172
173 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
174
175         Fix EWS python unit tests and address code comments as per 140476
176         https://bugs.webkit.org/show_bug.cgi?id=140637
177
178         Reviewed by David Kilzer.
179
180         * Scripts/webkitpy/port/base.py:
181         (Port):
182         (Port.__init__):
183         Adds DEFAULT_ARCHITECTURE member.
184         (Port.architecture):
185         Removes architecture member and instead uses
186         self.get_option('architecture'). Also removes redundant architecture
187         method.
188         (Port.set_architecture):
189         Adds a setter for the architecture variable to be able to set a flag
190         upon modification.
191         (Port.test_configuration):
192         Uses self.architecture() instead of self._architecture.
193         * Scripts/webkitpy/port/ios.py:
194         Overrides DEFAULT_ARCHITECTURE.
195         (IOSPort):
196         (IOSPort.determine_full_port_name):
197         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
198         strip. Fixes regex to not match arbitrary characters after the
199         relevent digits are matched.
200         (IOSPort.__init__):
201         Removes old _architecture defaulting strategy.
202         (IOSPort._build_driver_flags):
203         Uses self.architecture() instead of self._architecture.
204         (IOSSimulatorPort):
205         Overrides DEFAULT_ARCHITECTURE.
206         (IOSSimulatorPort.__init__):
207         Removes old _architecture defaulting strategy.
208         * Scripts/webkitpy/port/mac.py:
209         (MacPort):
210         Overrides DEFAULT_ARCHITECTURE.
211         (MacPort.__init__):
212         Removes old _architecture defaulting strategy.
213         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
214         (AbstractEarlyWarningSystem.run_command):
215         Checks the did_override_architecture flag to determine whether to add
216         the --architecture option.
217         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
218         Uses ews.architecture rather than trying to discern the correct
219         architecture using a port object.
220         (EarlyWarningSystemTest._default_expected_logs):
221         * Scripts/webkitpy/tool/commands/queues.py:
222         Removes use of optparse, and removes the import statement.
223         (AbstractQueue.__init__):
224         (PatchProcessingQueue.begin_work_queue):
225
226 2015-01-20  Sam Weinig  <sam@webkit.org>
227
228         Attempt to fix Mountain Lion and EFL tests.
229
230         * WebKitTestRunner/TestController.cpp:
231         (WTR::TestController::initialize):
232         Disable Process-per-tab and network process on Mountain Lion and EFL.
233
234 2015-01-20  Darin Adler  <darin@apple.com>
235
236         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
237         https://bugs.webkit.org/show_bug.cgi?id=140679
238
239         Reviewed by Anders Carlsson.
240
241         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
242         Removed a reference to SVGElementInstanceList.
243
244 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
245
246         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
247         https://bugs.webkit.org/show_bug.cgi?id=140028
248
249         Reviewed by Carlos Garcia Campos.
250
251         This won't work as expected, since this function is called before the
252         WebViewTest constructor completes.
253
254         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
255
256 2015-01-20  David Kilzer  <ddkilzer@apple.com>
257
258         configure-xcode-for-ios-development needs to update iPhoneOS SDK
259         <http://webkit.org/b/140661>
260
261         Reviewed by Daniel Bates.
262
263         * Scripts/configure-xcode-for-ios-development: Add for() loop to
264         run createXcodeSpecificationFilesForSDKIfNeeded() for both
265         "iphoneos" and "iphonesimulator" SDKs.
266         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
267         the main body of the script.
268
269 2015-01-20  Tomas Popela  <tpopela@redhat.com>
270
271         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
272         https://bugs.webkit.org/show_bug.cgi?id=139443
273
274         Reviewed by Carlos Garcia Campos.
275
276         Create the new test cases for setting the editable property on the web
277         view and on the contenteditable enabled document. Also rework the
278         current tests that are expecting that the web view is editable.
279
280         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
281         (loadTestHtml):
282         (testWebViewEditorCutCopyPasteNonEditable):
283         (testWebViewEditorCutCopyPasteEditable):
284         (testWebViewEditorSelectAllNonEditable):
285         (testWebViewEditorSelectAllEditable):
286         (runEditorEditableCutTests):
287         (testWebViewEditorEditableOnNonEditable):
288         (testWebViewEditorEditableOnContentEditable):
289         (testWebViewEditorNonEditable):
290         (beforeAll):
291         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
292         (WebViewTest::isEditable):
293         (WebViewTest::setEditable):
294
295 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
296
297         [GTK] Add an option to create WebKitWebView snapshots with transparent background
298         https://bugs.webkit.org/show_bug.cgi?id=140617
299
300         Reviewed by Gustavo Noronha Silva.
301
302         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
303         (testWebViewSnapshot): Check that the same snapshot with
304         transparent background is different than the default one filled
305         with white.
306
307 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
308
309         [GTK] Add API to change the WebKitWebView background color
310         https://bugs.webkit.org/show_bug.cgi?id=140610
311
312         Reviewed by Gustavo Noronha Silva.
313
314         Add --bg-color command line option to MiniBrowser to be able to
315         manually test the API passing any RGBA color to MiniBrowser.
316         Also add a simple unit test to check that getting and setting
317         colors from the API point of view.
318
319         * MiniBrowser/gtk/BrowserWindow.c:
320         (browser_window_set_background_color):
321         * MiniBrowser/gtk/BrowserWindow.h:
322         * MiniBrowser/gtk/main.c:
323         (createBrowserWindow):
324         (parseBackgroundColor):
325         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
326         (testWebViewBackgroundColor):
327         (beforeAll):
328
329 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
330
331         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
332         https://bugs.webkit.org/show_bug.cgi?id=140665
333
334         Reviewed by Brian Burg.
335
336         * DumpRenderTree/win/UIDelegate.cpp:
337         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
338         match expected test output.
339
340 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
341
342         Remove the support for custom suffixes on ChangeLog
343         https://bugs.webkit.org/show_bug.cgi?id=140648
344
345         Reviewed by David Kilzer.
346
347         Custom suffixes were used for the iOS branch of WebKit.
348         Now that everything is opensource, there is no need for it.
349
350         * Scripts/VCSUtils.pm:
351         (changeLogSuffix): Deleted.
352         (changeLogFileName): Deleted.
353         * Scripts/commit-log-editor:
354         * Scripts/prepare-ChangeLog:
355         (getLatestChangeLogs):
356         (generateNewChangeLogs):
357         (generateFileList):
358         * Scripts/resolve-ChangeLogs:
359         (findChangeLog):
360
361 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
362
363         Adjust naming of action menu SPI
364         https://bugs.webkit.org/show_bug.cgi?id=140644
365         <rdar://problem/19448129>
366
367         Reviewed by Brian Weinstein.
368
369         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
370         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
371         (TestWebKitAPI::TEST):
372
373 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
374
375         [GTK] Generate the make dist manifest from a CMake template file
376         https://bugs.webkit.org/show_bug.cgi?id=139387
377
378         Reviewed by Martin Robinson.
379
380         Remove the code that performs variable substitution on manifest.txt.
381         Replace the custom variables used in that file with CMake variables.
382
383         * gtk/make-dist.py:
384         (Manifest.add_directory):
385         (Manifest.get_full_source_path):
386         (Manifest.process_line):
387         (Manifest.resolve_variables): Deleted.
388         (Manifest.get_full_tarball_path): Deleted.
389         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
390
391 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
392
393         [Win] Correct merge error in last commit.
394
395         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
396         (findAccessibleObjectById): Undo accidental paste made during landing.
397
398 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
399
400         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
401         https://bugs.webkit.org/show_bug.cgi?id=139906
402
403         Reviewed by Dean Jackson.
404
405         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
406         to use them. This patch fixes that.
407
408         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
409         (findAccessibleObjectById):
410         (AccessibilityController::focusedElement):
411         (logEventProc):
412         (notificationListenerProc):
413         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
414         (AccessibilityUIElement::getChildAtIndex):
415         (AccessibilityUIElement::titleUIElement):
416         (self):
417         (AccessibilityUIElement::role):
418         (AccessibilityUIElement::valueDescription):
419         (accessibilityState):
420         (AccessibilityUIElement::isChecked):
421         * DumpRenderTree/win/DumpRenderTree.cpp:
422         (dumpFrameScrollPosition):
423         (dumpFramesAsText):
424         * DumpRenderTree/win/PolicyDelegate.cpp:
425         (PolicyDelegate::decidePolicyForNavigationAction):
426         * DumpRenderTree/win/UIDelegate.cpp:
427         (UIDelegate::exceededDatabaseQuota):
428         * WinLauncher/Common.cpp:
429         (setWindowText):
430
431 2015-01-19  Dean Jackson  <dino@apple.com>
432
433         Add "override" to fix the build with newer clangs.
434
435         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
436         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
437
438 2015-01-19  David Kilzer  <ddkilzer@apple.com>
439
440         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
441         <http://webkit.org/b/140623>
442
443         Reviewed by Daniel Bates.
444
445         * Scripts/build-webkit: Update help for --device switch.
446         * Scripts/webkitdirs.pm:
447         (determineXcodeSDK): When passing --device, prefer the internal
448         iOS SDK if it exists, else fall back to the external iOS SDK.
449         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
450         xcodebuild instead of trying to sanitize values.
451
452 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
453
454         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
455         https://bugs.webkit.org/show_bug.cgi?id=140606
456
457         Reviewed by Csaba Osztrogonác.
458
459         * Scripts/webkitpy/bindings/main.py:
460         (BindingsTests.generate_supplemental_dependency):
461         (BindingsTests.main):
462
463 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
464
465         [GTK] [WK2] TestWebKitWebView snapshot fails
466         https://bugs.webkit.org/show_bug.cgi?id=120404
467
468         Reviewed by Žan Doberšek.
469
470         Rework the test to make sure the snapshot is always created at the
471         desired size.
472
473         * Scripts/run-gtk-tests:
474         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
475         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
476         (testWebViewSnapshot): Use a fixed size for the document, and
477         disable scrollbars to make sure the visible area is always the
478         WebView size.
479         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
480         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
481         and height parameters to create the window with a given size.
482         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
483
484 2015-01-18  David Kilzer  <ddkilzer@apple.com>
485
486         iOS EWS queue name should be consistent
487         <http://webkit.org/b/140585>
488
489         Reviewed by Daniel Bates.
490
491         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
492         to 'ios'.
493         * Scripts/webkitpy/common/config/ports.py: Ditto.
494         (DeprecatedPort.port):
495         (IOSPort):
496         * Scripts/webkitpy/port/ios.py: Ditto.
497         (IOSPort):
498
499         * Scripts/webkitpy/port/factory.py:
500         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
501         appears before ios.IOSPort.  If this is not done,
502         `run-webkit-tests --ios-simulator` will get the wrong Port class
503         (IOSPort instead of IOSSimulatorPort) due to the way that
504         PortFactory.get() uses prefix matching of <Port>.port_name to
505         find the correct class to use.
506
507 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
508
509         build.webkit.org/dashboard: OS X EWS is now on Mavericks
510         https://bugs.webkit.org/show_bug.cgi?id=140595
511
512         Reviewed by Csaba Osztrogonác.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
515         (BubbleQueueServer):
516
517 2015-01-17  David Kilzer  <ddkilzer@apple.com>
518
519         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
520
521         * Scripts/webkitpy/port/ios.py:
522         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
523         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
524         the Mountain Lion and Mavericks bots.
525
526 2015-01-17  David Kilzer  <ddkilzer@apple.com>
527
528         Attempt to fix webkitpy tests on GTK Linux ports
529
530         * Scripts/webkitpy/port/ios.py:
531         (IOSPort.determine_full_port_name): Set a sensible default if
532         not running on a Mac platform or if no iOS SDK is installed.
533
534 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
535
536         Create iOS-EWS client queue
537         https://bugs.webkit.org/show_bug.cgi?id=140476
538
539         Reviewed by Alexey Proskuryakov.
540
541         * EWSTools/start-queue-mac.sh:
542         Adds call to configure-xcode-for-ios-development for iOS EWS.
543         * Scripts/webkitpy/common/config/ews.json:
544         Adds the iOS EWS config entry.
545         * Scripts/webkitpy/common/config/ports.py:
546         (DeprecatedPort.port):
547         Adds IOSPort to the port map.
548         (IOSPort):
549         (IOSPort.build_webkit_command):
550         Adds --sdk=iphoneos to the webkit build command.
551         * Scripts/webkitpy/port/base.py:
552         (Port.architecture):
553         Adds an accessor for the architecture member variable.
554         * Scripts/webkitpy/port/factory.py:
555         (PortFactory):
556         Adds IOSPort to the port class list.
557         * Scripts/webkitpy/port/ios.py:
558         Adds the IOSPort to encapsulate iOS-specific things.
559         (IOSPort):
560         (IOSPort.determine_full_port_name):
561         (IOSPort.__init__):
562         (IOSPort._build_driver_flags):
563         (IOSPort.operating_system):
564         * Scripts/webkitpy/tool/commands/download_unittest.py:
565         Adds the archetecture option to the mock options.
566         (DownloadCommandsTest._default_options):
567         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
568         Appends the archetecture option into calls to webkit-patch.
569         (AbstractEarlyWarningSystem.review_patch):
570         (AbstractEarlyWarningSystem.run_command):
571         (AbstractEarlyWarningSystem.load_ews_classes):
572         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
573         Adds logic to soothe the unittest now that --architecture is being
574         thrown around everywhere.
575         (EarlyWarningSystemTest._default_expected_logs):
576         * Scripts/webkitpy/tool/commands/queues.py:
577         Adds glue code to ferry the --architecture option around.
578         (AbstractQueue.__init__):
579         (PatchProcessingQueue.begin_work_queue):
580         * Scripts/webkitpy/tool/steps/abstractstep.py:
581         Adds the archetecture option to all AbstractSteps so that
582         EarlyWarningSystem doesn't start shoving --architecture into
583         unsuspecting commands.
584         (AbstractStep.options):
585         * Scripts/webkitpy/tool/steps/build.py:
586         Translates the --architecture option into an ARCHS= format to pass to
587         build-webkit.
588         (Build.build):
589         * Scripts/webkitpy/tool/steps/options.py:
590         Adds a definition for the --architecture option.
591         (Options):
592
593 2015-01-16  Sam Weinig  <sam@webkit.org>
594
595         Add a basic configuration object for WKView
596         https://bugs.webkit.org/show_bug.cgi?id=140559
597
598         Reviewed by Anders Carlsson.
599
600         Add tests for WKPageConfigurationRef.
601
602         * TestWebKitAPI/PlatformWebView.h:
603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
604         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
605         (TestWebKitAPI::TEST):
606         (TestWebKitAPI::didFinishLoadForFrame):
607         (TestWebKitAPI::setPageLoaderClient):
608         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
609         (TestWebKitAPI::PlatformWebView::initialize):
610         (TestWebKitAPI::PlatformWebView::PlatformWebView):
611
612 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
613
614         WeakPtr functions crash when created with default constructor
615         https://bugs.webkit.org/show_bug.cgi?id=140479
616
617         Reviewed by Andreas Kling.
618
619         Add WeakPtr API tests.
620
621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
622         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
623         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
624
625 2015-01-16  Chris Dumez  <cdumez@apple.com>
626
627         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
628         https://bugs.webkit.org/show_bug.cgi?id=140568
629
630         Reviewed by Alexey Proskuryakov.
631
632         Fix the script parsing CSSPropertyNames.in to stop splitting lines
633         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
634         e.g. "Longhands=background-position-x|background-position-y".
635         This would confuse the script and treat this as a CSS property:
636         "background-position-x|background-position-y".
637
638         We now split on white space and treat the first string on the line
639         to be the property name (this is the syntax in this file).
640
641         * Scripts/webkitpy/w3c/test_converter.py:
642         (_W3CTestConverter.__init__):
643         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
644
645 2015-01-16  Daniel Bates  <dabates@apple.com>
646
647         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
648         https://bugs.webkit.org/show_bug.cgi?id=135589
649
650         Reviewed by David Kilzer.
651
652         Derived from a patch by David Farler.
653
654         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
655         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
656         in terms of the simctl command line utility.
657
658         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
659         (eraseIOSSimulatorDevice): Added.
660         (bootedIOSSimulatorDevice): Added.
661         (iosSimulatorApplicationsPath): Added.
662         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
663         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
664         (quitIOSSimulator): Added.
665         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
666         the specified name and currently selected iOS runtime.
667         (isIOSSimulatorSystemInstalledApp): Added.
668         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
669         (deleteiOSSimulatorDevice): Deleted.
670         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
671         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
672
673 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
674
675         Resurrect the WinCairo bot.
676         https://bugs.webkit.org/show_bug.cgi?id=139908
677
678         Reviewed by Csaba Osztrogonác.
679
680         * BuildSlaveSupport/build.webkit.org-config/config.json:
681         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
682         (appendCustomBuildFlags):
683         * BuildSlaveSupport/test-result-archive:
684         (archiveTestResults):
685         Add WinCairo buildbot.
686
687 2015-01-16  Chris Dumez  <cdumez@apple.com>
688
689         webkit-patch should auto-install the keyring python module
690         https://bugs.webkit.org/show_bug.cgi?id=140547
691
692         Reviewed by David Kilzer.
693
694         Auto-install the keyring python module. This is the module that
695         webkit-patch uses for cross-platform access to the keyring
696         service.
697
698         Without this module, if the password if not in the keychain,
699         webkit-patch will keep asking for your username / password and
700         never remember them.
701
702         * Scripts/webkitpy/common/net/credentials.py:
703         * Scripts/webkitpy/thirdparty/__init__.py:
704         (AutoinstallImportHook.find_module):
705         (AutoinstallImportHook._install_keyring):
706
707 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
708
709         Remove ENABLE(SQL_DATABASE) guards
710         https://bugs.webkit.org/show_bug.cgi?id=140434
711
712         Reviewed by Darin Adler.
713
714         * Scripts/webkitperl/FeatureList.pm:
715
716 2015-01-15  Daniel Bates  <dabates@apple.com>
717
718         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
719         https://bugs.webkit.org/show_bug.cgi?id=139685
720         <rdar://problem/19281317>
721
722         Reviewed by Simon Fraser.
723
724         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
725         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
726
727         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
728         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
729         before DRT dumps the output of a test. In particular, the WebThread may start a new page
730         load (say, as a result of continued JavaScript execution), which will ultimately lead to
731         dumping the test result again. Instead we want DRT to dump the test result synchronously
732         such that we capture the state of the web page either when the page is loaded or when
733         window.testRunner.notifyDone() is called.
734
735         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
736         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
737         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
738         flush CA transactions to the window.
739         * DumpRenderTree/mac/DumpRenderTree.mm:
740         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
741         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
742         (dump): Renamed; formerly named dumpTestResults().
743         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
744         enabling repaint support on iOS.
745         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
746         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
747         (dumpTestResults): Deleted.
748
749 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
750
751         [Win] Miscellaneous DRT fixes
752         https://bugs.webkit.org/show_bug.cgi?id=116562
753
754         Reviewed by Tim Horton.
755
756         While investigating the cause of several Windows crashes, I found:
757         (1) Messy conversions to and from BSTR types
758         (2) Weird mixes of wide-string and narrow string conversions
759         (3) Passing nullptr to some CoreFoundation routines that do not
760             permit null arguments.
761         (4) Commands to link the executable to the VS2005 runtime.
762
763         This patch cleans up these issues to improve DRT reliability on
764         Windows.
765
766         * DumpRenderTree/cg/ImageDiffCG.cpp:
767         (main): Get rid of VS2005 runtime linking.
768         * DumpRenderTree/win/DumpRenderTree.cpp:
769         (urlSuitableForTestResult): Protect against being asked
770         to process an empty URL.
771         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
772         than converting to/from wchar_t buffers.
773         (runTest): Simplify string and BSTR handling.
774         (createWebViewAndOffscreenWindow): Ditto.
775         (main): Get rid of VS2005 runtime linking.
776         * DumpRenderTree/win/TestRunnerWin.cpp:
777         (jsStringRefToWString): Simplify code.
778         (TestRunner::pathToLocalResource):
779         (TestRunner::setUserStyleSheetLocation):
780         * TestWebKitAPI/win/main.cpp: Get rid of
781         VS2005 runtime linking.
782         * win/DLLLauncher/DLLLauncherMain.cpp:
783         (wWinMain): Ditto.
784
785 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
786
787         Stop hardcoding mac-mountainlion in commit queue
788         https://bugs.webkit.org/show_bug.cgi?id=140492
789
790         Reviewed by Anders Carlsson.
791
792         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
793         there should be no change in behavior, because:
794         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
795         using it to create a port object.
796         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
797         is actually correct to use "mac" for the name there. We only used to get the expected
798         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
799         for unknown deprecated port names.
800
801         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
802
803 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
804
805         Create iOS-EWS server queue
806         https://bugs.webkit.org/show_bug.cgi?id=140473
807
808         Reviewed by Benjamin Poulain.
809
810         * QueueStatusServer/app.yaml: Updates the SVN version number.
811         * QueueStatusServer/config/queues.py: Add ios-ews queue.
812         * QueueStatusServer/model/queues.py:         
813         (Queue.display_name): Makes sure the display name is pretty!
814
815 2015-01-14  Daniel Bates  <dabates@apple.com>
816
817         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
818         https://bugs.webkit.org/show_bug.cgi?id=140301
819         <rdar://problem/19389266>
820
821         Reviewed by Jon Honeycutt.
822
823         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
824         with an unavailable runtime.
825
826         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
827         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
828         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
829         specified runtime cannot be used because it is unavailable.
830         * Scripts/webkitpy/port/ios.py:
831         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
832         which was formerly named testing_device.
833         * Scripts/webkitpy/xcode/simulator.py:
834         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
835         more robust than looking up the simulator device by name and runtime. This approach also
836         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
837         unavailable runtimes under the same iOS heading it would use to show it as available).
838         (Simulator.find_device_by_udid): Added.
839         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
840         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
841         (Simulator.available_runtimes): Added.
842         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
843         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
844         first element of the sorted list is the runtime with the highest version number.
845         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
846
847 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
848
849         Remove WK2 Windows cruft
850         https://bugs.webkit.org/show_bug.cgi?id=140440
851
852         Reviewed by Anders Carlsson.
853
854         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
855         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
856         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
857
858 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
859
860         Fix TestWTF failed in TestWebKitAPI
861         https://bugs.webkit.org/show_bug.cgi?id=140333
862
863         Reviewed by Sam Weinig.
864
865         Clear the std::ostringstream before starting test.
866
867         * TestWebKitAPI/Tests/WTF/RefLogger.h:
868         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
869
870 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
871
872         TestWebKitWebContext depends on British English spellcheck dictionary
873         https://bugs.webkit.org/show_bug.cgi?id=140403
874
875         Reviewed by Martin Robinson.
876
877         Install all English hunspell dictionaries on Fedora and Arch.
878
879         * gtk/install-dependencies:
880
881 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
882
883         [GTK] install-dependencies should grok dnf
884         https://bugs.webkit.org/show_bug.cgi?id=140396
885
886         Reviewed by Martin Robinson.
887
888         Fedora: install dependencies with dnf if yum is not installed.
889
890         * gtk/install-dependencies:
891
892 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
893
894         [EFL][GTK] Fix build after r178309  
895         https://bugs.webkit.org/show_bug.cgi?id=140381
896
897         Reviewed by Gyuyoung Kim.
898
899         * TestWebKitAPI/CMakeLists.txt: Added the API directory
900
901 2015-01-11  Sam Weinig  <sam@webkit.org>
902
903         Remove support for SharedWorkers
904         https://bugs.webkit.org/show_bug.cgi?id=140344
905
906         Reviewed by Anders Carlsson.
907
908         * Scripts/webkitperl/FeatureList.pm:
909
910 2015-01-12  Anders Carlsson  <andersca@apple.com>
911
912         Make delegates conform to formal delegate protocols
913         https://bugs.webkit.org/show_bug.cgi?id=140370
914
915         Reviewed by Dan Bernstein.
916
917         * DumpRenderTree/mac/TestRunnerMac.mm:
918         (TestRunner::numberOfPendingGeolocationPermissionRequests):
919         (TestRunner::setGeolocationPermission):
920
921 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
922
923         build-webkit: silence output of 'which'
924         https://bugs.webkit.org/show_bug.cgi?id=140278
925
926         Reviewed by Daniel Bates.
927
928         Use a more elegent test for the existance of ninja and eclipse.
929
930         * Scripts/webkitdirs.pm:
931         (commandExists): Don't assume the command supports --version
932         (canUseNinja): Use commandExists()
933         (canUseEclipse): Use commandExists()
934
935 2015-01-09  Sam Weinig  <sam@webkit.org>
936
937         Update the output format for run-api-tests
938         https://bugs.webkit.org/show_bug.cgi?id=140332
939
940         Reviewed by Dan Bernstein.
941
942         Changes the output format for run-api-tests be a bit simpler (no longer 
943         indented based on suite, as we were not really using suite very well) but
944         also include details in the case of failure.
945
946         Changes verbose mode to no longer spew out the gtest default printer output,
947         as the custom printer now includes the failure information.
948
949         * Scripts/run-api-tests:
950         (runTestsBySuite):
951         (runTest):
952         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
953         with colorized variants and strip out leaks spew (the leaks can be added back using
954         the new --show-leaks argument).
955
956         * TestWebKitAPI/TestsController.cpp:
957         (TestWebKitAPI::Printer::OnTestPartResult):
958         (TestWebKitAPI::Printer::OnTestEnd):
959         (TestWebKitAPI::TestsController::run):
960         Implement a custom result printer that just prints out the information we want.
961
962 2015-01-09  Sam Weinig  <sam@webkit.org>
963
964         TestWebKitAPI should print out the lists that fail at the end
965         https://bugs.webkit.org/show_bug.cgi?id=140329
966
967         Reviewed by Tim Horton.
968
969         * Scripts/run-api-tests:
970         (runTestsBySuite):
971         Print out failures and timeouts in all modes, not just verbose.
972
973 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
974
975         Make bmalloc work with ASan
976         https://bugs.webkit.org/show_bug.cgi?id=140194
977
978         Reviewed by Mark Lam.
979
980         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
981         ASan automatically (by forwarding to system malloc at runtime).
982
983 2015-01-09  Daniel Bates  <dabates@apple.com>
984
985         [iOS] Make DumpRenderTree build with public SDK
986         https://bugs.webkit.org/show_bug.cgi?id=140311
987
988         Reviewed by Sam Weinig.
989
990         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
991         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
992         Additionally, remove unused header CoreGraphics/CGFontDB.h.
993
994         * DumpRenderTree/mac/DumpRenderTree.mm:
995         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
996
997 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
998
999         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
1000         https://bugs.webkit.org/show_bug.cgi?id=140300
1001
1002         Reviewed by Simon Fraser.
1003
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::TestController::createOtherPage):
1006         (WTR::TestController::updateWindowScaleForTest):
1007         (WTR::TestController::configureViewForTest):
1008         * WebKitTestRunner/TestController.h:
1009
1010 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1011
1012         Unreviewed. Moving myself to the committer section.
1013
1014         * Scripts/webkitpy/common/config/contributors.json:
1015
1016 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1017
1018         Add a script to check for platform layering violations
1019         https://bugs.webkit.org/show_bug.cgi?id=140248
1020
1021         Reviewed by Darin Adler.
1022
1023         It prints all the cases where files inside platform include
1024         headers that are not in platform directory.
1025
1026         * Scripts/check-for-platform-layering-violations: Added.
1027         (get_platform_headers):
1028         (check_source_file):
1029
1030 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1031
1032         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
1033         https://bugs.webkit.org/show_bug.cgi?id=139884
1034
1035         Reviewed by Tim Horton.
1036
1037         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1038         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
1039         what the "nominal resolution" is, but this appears to work in practice.
1040
1041 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
1042
1043         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
1044         https://bugs.webkit.org/show_bug.cgi?id=140256
1045
1046         Reviewed by Anders Carlsson.
1047
1048         * DumpRenderTree/win/DumpRenderTree.cpp:
1049         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
1050         running with heap validation checks.
1051         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
1052         the "svg\\W3C-SVG-1.1" test directory.
1053         (removeFontFallbackIfPresent): Use nullptr instead of 0.
1054         * DumpRenderTree/win/TestRunnerWin.cpp:
1055         (TestRunner::clearPersistentUserStyleSheet): Ditto.
1056
1057 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1058
1059         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1060         https://bugs.webkit.org/show_bug.cgi?id=140218
1061
1062         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
1063         Undone an accidental change - check for self.has_crashed() again. This code path
1064         is for ports that don't have a signal handler printing #CRASHED when main process
1065         crashes.
1066
1067         * Scripts/webkitpy/port/driver_unittest.py:
1068         (DriverTest.test_check_for_driver_crash.assert_crash):
1069         (DriverTest.test_check_for_driver_crash):
1070         Updated the tests, all changes are expected.
1071
1072 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1073
1074         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1075         https://bugs.webkit.org/show_bug.cgi?id=140218
1076
1077         Reviewed by Darin Adler.
1078
1079         * Scripts/webkitpy/port/driver.py:
1080         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
1081         "process crashed" condition. These don't make sense together - it's either a crash
1082         or a timeout, and we should detect those properly at a much lower level.
1083         (Driver.run_test): Ditto.
1084         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
1085         cases.
1086
1087         * WebKitTestRunner/TestController.h:
1088         * WebKitTestRunner/TestController.cpp:
1089         (WTR::TestController::webProcessName): 
1090         (WTR::TestController::processDidCrash):
1091         Factored out hardcoded child process names, as we now use these in two places.
1092
1093         * WebKitTestRunner/TestInvocation.cpp:
1094         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
1095         process name, so that it can be sampled (fixes sampling on Mavericks and above).
1096
1097 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1098
1099         Reorder my list of email addresses, keeping the Bugzilla address at the
1100         top since Bugzilla and other webkitpy scripts rely on that ordering.
1101
1102         * Scripts/webkitpy/common/config/contributors.json:
1103
1104 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1105
1106         Moving myself to the reviewers section and updating
1107         the list of my email addresses.
1108
1109         * Scripts/webkitpy/common/config/contributors.json:
1110
1111 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1112
1113         [GTK] Build gtk-doc without gtkdoc-mktmpl
1114         https://bugs.webkit.org/show_bug.cgi?id=140225
1115
1116         Reviewed by Darin Adler.
1117
1118         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
1119         don't modify the tmpl files that it generates, it's not doing anything
1120         for us.
1121
1122         * gtk/gtkdoc.py:
1123         (GTKDoc.generate):
1124         (GTKDoc._run_gtkdoc_scangobj):
1125         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
1126
1127 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
1128
1129         [GTK][ThreadedCompositor] Add support for threaded compositor.
1130         https://bugs.webkit.org/show_bug.cgi?id=118265
1131
1132         Reviewed by Martin Robinson.
1133
1134         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
1135         autotools build systems. The feature is disabled by default.
1136         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
1137         from the feature flags.
1138
1139         * Scripts/webkitperl/FeatureList.pm:
1140
1141 2015-01-07  Daniel Bates  <dabates@apple.com>
1142
1143         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1144         https://bugs.webkit.org/show_bug.cgi?id=137371
1145
1146         Reviewed by David Kilzer.
1147
1148         Use SPI wrapper headers instead of directly referencing private SPI headers.
1149
1150         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1151         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1152         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1153         to the list of iOS header search directories so that we can include header UIKitSPI.h.
1154         * DumpRenderTree/mac/DumpRenderTree.mm:
1155         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1156         * DumpRenderTree/mac/EventSendingController.mm:
1157         * DumpRenderTree/mac/TestRunnerMac.mm:
1158
1159 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1160
1161         Unreviewed, rolling out r178068.
1162         https://bugs.webkit.org/show_bug.cgi?id=140235
1163
1164         Breaks the iOS build (Requested by enrica on #webkit).
1165
1166         Reverted changeset:
1167
1168         "[iOS] Make WebKit2 build with public iOS SDK and more build
1169         fixes for DRT"
1170         https://bugs.webkit.org/show_bug.cgi?id=137371
1171         http://trac.webkit.org/changeset/178068
1172
1173 2015-01-07  Daniel Bates  <dabates@apple.com>
1174
1175         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1176         https://bugs.webkit.org/show_bug.cgi?id=137371
1177
1178         Reviewed by David Kilzer.
1179
1180         Use SPI wrapper headers instead of directly referencing private SPI headers.
1181
1182         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1183         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1184         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1185         to the list of header search directories so that we can include header UIKitSPI.h.
1186         * DumpRenderTree/mac/DumpRenderTree.mm:
1187         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1188         * DumpRenderTree/mac/EventSendingController.mm:
1189         * DumpRenderTree/mac/TestRunnerMac.mm:
1190
1191 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
1192
1193         [Win] Unreviewed test change to improve run reproducibility
1194
1195         * Scripts/webkitpy/port/win.py:
1196         (WinPort.default_child_processes): Run a single DRT instance to help
1197         identify failures caused by earlier test runs.
1198
1199 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1200
1201         Myles C. Maxfield is a reviewer now
1202         https://bugs.webkit.org/show_bug.cgi?id=140196
1203
1204         Reviewed by Dean Jackson.
1205
1206         * Scripts/webkitpy/common/config/contributors.json:
1207
1208 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1209
1210         Make webkit-patch try harder to find keychain credentials
1211         https://bugs.webkit.org/show_bug.cgi?id=140170
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         When the user manually enters a password into webkit-patch, we hand that off to the
1216         Keyring Python module. However, that module creates a generic password entry instead
1217         of an internet password entry. We should look for both kinds.
1218
1219         * Scripts/webkitpy/common/net/credentials.py:
1220         (Credentials._run_security_tool):
1221         (Credentials._credentials_from_keychain):
1222         * Scripts/webkitpy/common/net/credentials_unittest.py:
1223         (test_security_output_parse_entry_not_found):
1224         (_assert_security_call):
1225
1226 2015-01-06  Anders Carlsson  <andersca@apple.com>
1227
1228         Try to fix the Mountain Lion build.
1229
1230         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1231         (TestWebKitAPI::didGetImageForMatchResult):
1232
1233 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1234
1235         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
1236         https://bugs.webkit.org/show_bug.cgi?id=140095
1237
1238         Reviewed by Anders Carlsson.
1239
1240         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
1241         builds, but not in debug ones.
1242
1243 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
1244
1245         [Win] Extend WinLauncher with support for Page Zoom
1246         https://bugs.webkit.org/show_bug.cgi?id=140152
1247
1248         Reviewed by Anders Carlsson.
1249
1250         * WinLauncher/Common.cpp:
1251         (WndProc):
1252         * WinLauncher/WinLauncher.cpp:
1253         (WinLauncher::resetZoom):
1254         (WinLauncher::zoomIn):
1255         (WinLauncher::zoomOut):
1256         * WinLauncher/WinLauncher.h:
1257         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1258         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1259         * win/DLLLauncher/DLLLauncherMain.cpp:
1260         (wWinMain):
1261
1262 2015-01-06  Anders Carlsson  <andersca@apple.com>
1263
1264         Fix API tests that are broken under HiDPI
1265         https://bugs.webkit.org/show_bug.cgi?id=140146
1266
1267         Reviewed by Tim Horton.
1268
1269         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1270         (TestWebKitAPI::didGetImageForMatchResult):
1271         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
1272
1273         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1274         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1275         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
1276         out in a window that has a backing scale factor of 1.
1277  
1278         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1279         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
1280         Ditto.
1281
1282 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1283
1284         ADDRESS_SANITIZER macro is overloaded
1285         https://bugs.webkit.org/show_bug.cgi?id=140130
1286
1287         Reviewed by Anders Carlsson.
1288
1289         * WebKitTestRunner/TestController.cpp: Use the new macro.
1290
1291 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
1292
1293         Remove some stale class names in check-for-inappropriate-objc-class-names
1294         https://bugs.webkit.org/show_bug.cgi?id=140104
1295
1296         Reviewed by Darin Adler.
1297
1298         * Scripts/check-for-inappropriate-objc-class-names:
1299         These UIWK* classes no longer exist.
1300
1301 2015-01-05  Anders Carlsson  <andersca@apple.com>
1302
1303         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
1304         https://bugs.webkit.org/show_bug.cgi?id=140096
1305         rdar://problem/19368938
1306
1307         Reviewed by Alexey Proskuryakov.
1308
1309         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
1310         since clientInfo points to a web view, not the test controller.
1311
1312         * WebKitTestRunner/TestController.cpp:
1313         (WTR::TestController::createOtherPage):
1314
1315 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
1316
1317         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
1318         https://bugs.webkit.org/show_bug.cgi?id=140077
1319
1320         Reviewed by Csaba Osztrogonác.
1321
1322         WebKit C SPI is available on EFL,GTK.
1323         Changed the define order to pass the API test.
1324
1325         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1326         (TestWebKitAPI::TEST):
1327
1328 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
1329
1330         Simplify WebKitTestRunner timeout tracking
1331         https://bugs.webkit.org/show_bug.cgi?id=140036
1332
1333         Reviewed by Darin Adler.
1334
1335         The code for configuring timeouts was mostly dead, because run-webkit-tests never
1336         passes the --timeout option to WebKitTestRunner.
1337
1338         * WebKitTestRunner/Options.h:
1339         * WebKitTestRunner/Options.cpp:
1340         (WTR::Options::Options):
1341         (WTR::OptionsHandler::OptionsHandler):
1342         (WTR::handleOptionTimeout): Deleted.
1343         Removed support for --timeout. Timeouts are passed for each test individually,
1344         and defaults are good enough for the rare cases where WebKitTestRunner is run
1345         manually without run-webkit-tests.
1346
1347         * WebKitTestRunner/TestController.cpp:
1348         (WTR::TestController::TestController):
1349         (WTR::TestController::initialize):
1350         (WTR::TestController::resetStateToConsistentValues):
1351         (WTR::TestController::reattachPageToWebProcess):
1352         (WTR::TestController::runUntil):
1353         * WebKitTestRunner/TestController.h:
1354         Simplified runUntil by passing the actual timeout, not an enum.
1355         Increased short timeout for ASan enabled builds, as WebProcess launching takes
1356         quite a while.
1357
1358         * WebKitTestRunner/TestInvocation.cpp:
1359         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1360
1361         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1362         (WTR::TestController::platformRunUntil):
1363         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1364         (WTR::TestController::platformRunUntil):
1365         Build fixes.
1366
1367 2015-01-02  Anders Carlsson  <andersca@apple.com>
1368
1369         Remove now unused storage tracker glue from DumpRenderTree
1370         https://bugs.webkit.org/show_bug.cgi?id=140045
1371
1372         Reviewed by Darin Adler.
1373
1374         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1375         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1376         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1377         * DumpRenderTree/TestRunner.cpp:
1378         (TestRunner::staticFunctions):
1379         (syncLocalStorageCallback): Deleted.
1380         (observeStorageTrackerNotificationsCallback): Deleted.
1381         (deleteAllLocalStorageCallback): Deleted.
1382         (deleteLocalStorageForOriginCallback): Deleted.
1383         (localStorageDiskUsageForOriginCallback): Deleted.
1384         (originsWithLocalStorageCallback): Deleted.
1385         * DumpRenderTree/TestRunner.h:
1386         * DumpRenderTree/mac/DumpRenderTree.mm:
1387         (allocateGlobalControllers):
1388         (releaseGlobalControllers):
1389         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1390         * DumpRenderTree/mac/TestRunnerMac.mm:
1391         (TestRunner::syncLocalStorage): Deleted.
1392         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1393         (TestRunner::observeStorageTrackerNotifications): Deleted.
1394         (TestRunner::deleteAllLocalStorage): Deleted.
1395         (TestRunner::originsWithLocalStorage): Deleted.
1396         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1397         * DumpRenderTree/win/TestRunnerWin.cpp:
1398         (TestRunner::syncLocalStorage): Deleted.
1399         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1400         (TestRunner::observeStorageTrackerNotifications): Deleted.
1401         (TestRunner::deleteAllLocalStorage): Deleted.
1402         (TestRunner::originsWithLocalStorage): Deleted.
1403         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1404
1405 2015-01-01  Darin Adler  <darin@apple.com>
1406
1407         We often misspell identifier as "identifer"
1408         https://bugs.webkit.org/show_bug.cgi?id=140025
1409
1410         Reviewed by Michael Saboff.
1411
1412         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1413         * Scripts/webkitdirs.pm:
1414         (appIdentifierFromBundle):
1415         (installAndLaunchIOSWebKitAppInSimulator):
1416         Fix misspellings
1417
1418 2015-01-01  Zalan Bujtas  <zalan@apple.com>
1419
1420         Saturated arithmetics: Incorrect float/double clamping.
1421         https://bugs.webkit.org/show_bug.cgi?id=139888
1422         rdar://problem/19330885
1423
1424         Reviewed by Simon Fraser.
1425
1426         Clamp float and double values correctly when applying saturated arithmetics.
1427
1428         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1429         (TestWebKitAPI::TEST):
1430
1431 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
1432
1433         [EFL] Bump version of ATK used by jhbuild to 2.15.2
1434         https://bugs.webkit.org/show_bug.cgi?id=139816
1435
1436         Reviewed by Gyuyoung Kim.
1437
1438         Bump version of ATK used by jhbuild to 2.15.2
1439
1440         * efl/jhbuild.modules:
1441
1442 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
1443
1444         [jhBuild] cairo build error (-flto)
1445         https://bugs.webkit.org/show_bug.cgi?id=139056
1446
1447         Reviewed by Philippe Normand.
1448
1449         cairo fails to link  with gcc 4.9 due to lto
1450         related issue. This problem has been partially
1451         addressed by cairo:
1452         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
1453         use the cairo --disable-lto option and remove jhbuild
1454         makeargs fixes the issue.
1455
1456         * gtk/jhbuild.modules:
1457         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
1458
1459 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
1460         [Mac] Enable kerning, ligatures, and printer fonts 
1461         https://bugs.webkit.org/show_bug.cgi?id=139970
1462
1463         Rubber stamped by Simon Fraser.
1464
1465         Flip the switch.
1466
1467         * DumpRenderTree/mac/DumpRenderTree.mm:
1468         * WebKitTestRunner/TestController.cpp:
1469         * WebKitTestRunner/mac/main.mm:
1470
1471 2014-12-26  Dan Bernstein  <mitz@apple.com>
1472
1473         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1474         https://bugs.webkit.org/show_bug.cgi?id=139950
1475
1476         Reviewed by David Kilzer.
1477
1478         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1479         in a manner that works with Xcode 5.1.1.
1480
1481 2014-12-24  Dan Bernstein  <mitz@apple.com>
1482
1483         Engineering builds of MiniBrowser ignore deprecated declaration warnings
1484         https://bugs.webkit.org/show_bug.cgi?id=139941
1485
1486         Reviewed by Darin Adler.
1487
1488         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
1489         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
1490         to YES.
1491         * MiniBrowser/mac/AppDelegate.m:
1492         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
1493         deprecated NSOKButton.
1494
1495 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1496
1497         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
1498         https://bugs.webkit.org/show_bug.cgi?id=134763
1499
1500         Reviewed by Ryosuke Niwa.
1501
1502         Adding an option to disable test harness link conversion.
1503
1504         * Scripts/webkitpy/w3c/test_converter.py:
1505         (convert_for_webkit):
1506         (_W3CTestConverter.__init__):
1507         (_W3CTestConverter.convert_attributes_if_needed):
1508         * Scripts/webkitpy/w3c/test_importer.py:
1509         (parse_args):
1510         (TestImporter.import_tests):
1511
1512 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1513
1514         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1515         https://bugs.webkit.org/show_bug.cgi?id=139933
1516
1517         Reviewed by Daniel Bates.
1518
1519         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1520         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1521         until ReportCrash lets it go.
1522
1523         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1524         even get the actual crash log eventually - even when it times out waiting for the log, it
1525         makes a second lookup at the very end, after all tests finish. There may be further
1526         improvements needed here, but this small fix addresses most cases that happen in practice.
1527
1528         * DumpRenderTree/mac/DumpRenderTree.mm:
1529         (writeCrashedMessageOnFatalError):
1530         (dumpRenderTree):
1531         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1532
1533         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1534         unhelpful comment.
1535
1536 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1537
1538         Don't force -O1 for debug ASan builds
1539         https://bugs.webkit.org/show_bug.cgi?id=139926
1540
1541         Reviewed by Darin Adler.
1542
1543         * asan/asan.xcconfig:
1544
1545 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1546
1547         Simplify building with ASan
1548         https://bugs.webkit.org/show_bug.cgi?id=139916
1549
1550         Reviewed by Mark Rowe.
1551
1552         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1553         We could also update Configuration file format, but that's a little scary because
1554         of how many places in code read it.
1555
1556         * Scripts/webkitdirs.pm:
1557         (determineASanIsEnabled): Read it from ASan configuration file.
1558         (argumentsForConfiguration): Added a FIXME.
1559         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1560         (XcodeOptions): Pass the options needed for ASan.
1561
1562         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1563         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1564         that automatically.
1565
1566 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1567
1568         TestWebKitAPI build is broken when ASan is enabled
1569         https://bugs.webkit.org/show_bug.cgi?id=139902
1570
1571         Reviewed by Darin Adler.
1572
1573         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1574         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1575         Inherit linker flags from DebugRelease, which respects ASAN.
1576
1577 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
1578
1579         Sort the Xcode project file.
1580
1581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1582
1583 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1584
1585         Update apple-mac-114 to bot629.
1586         
1587         Unreviewed.
1588         
1589         * BuildSlaveSupport/build.webkit.org-config/config.json:
1590
1591 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1592
1593         Replace Apple bot104 with bot124.
1594         
1595         Unreviewed.
1596         
1597         * BuildSlaveSupport/build.webkit.org-config/config.json:
1598
1599 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1600
1601         URTBF after r177639.
1602
1603         * TestWebKitAPI/CMakeLists.txt:
1604
1605 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1606
1607         [EFL] MiniBrowser steals web view's focus
1608         https://bugs.webkit.org/show_bug.cgi?id=139482
1609
1610         Reviewed by Gyuyoung Kim.
1611
1612         Although we set focus on ewk_view while MiniBrowser initialization
1613         Ecore steals it in a favor of main window. As a result
1614         focused element on web page is unable to receive events.
1615
1616         * MiniBrowser/efl/main.c:
1617         (window_create):
1618         Prevent window from stealing web view's focus on start up.
1619
1620 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1621
1622         [Win] Revise DRT logic to match Mac.
1623
1624         Rubberstamped by Anders Carlsson.
1625
1626         Update the Windows logic to perform initialization of preferences and WebKit
1627         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1628         the same circumstances as the Mac version.
1629
1630         * DumpRenderTree/win/DumpRenderTree.cpp:
1631         (dump):
1632         (resetWebPreferencesToConsistentValues):
1633         (setDefaultsToConsistentValuesForTesting):
1634         (resetWebViewToConsistentStateBeforeTesting):
1635         (sizeWebViewForCurrentTest):
1636         (runTest):
1637         (createWebViewAndOffscreenWindow):
1638         (allocateGlobalControllers):
1639         (prepareConsistentTestingEnvironment):
1640         (main):
1641         (resetDefaultsToConsistentValues): Deleted.
1642
1643 2014-12-19  Roger Fong  <roger_fong@apple.com>
1644
1645         Unreviewed. Rollout r177605.
1646
1647         * EWSTools/start-queue-win.sh:
1648
1649 2014-12-19  Roger Fong  <roger_fong@apple.com>
1650
1651         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1652
1653         * EWSTools/start-queue-win.sh:
1654
1655 2014-12-19  Daniel Bates  <dabates@apple.com>
1656
1657         [iOS] Add WebKitSystemInterface for iOS 8.1
1658         https://bugs.webkit.org/show_bug.cgi?id=139831
1659
1660         Reviewed by Alexey Proskuryakov.
1661
1662         Implement support in copy-webkitlibraries-to-product-directory to copy
1663         WebKitSystemInterface for iOS to the product directory and have build-webkit
1664         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1665
1666         * Scripts/build-webkit:
1667         * Scripts/copy-webkitlibraries-to-product-directory:
1668
1669 2014-12-19  Daniel Bates  <dabates@apple.com>
1670
1671         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1672         https://bugs.webkit.org/show_bug.cgi?id=139829
1673
1674         Reviewed by Alexey Proskuryakov.
1675
1676         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1677         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1678         expects the Xcode SDK to be specified using the --sdk-name command line argument.
1679
1680         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1681         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1682         logic to both avoid duplicating effort and make the command line options for
1683         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1684         with the approach used in other WebKit tools.
1685
1686         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1687         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1688         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1689
1690         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1691         improve the readability of the code.
1692         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1693         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1694         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1695         be included in a library.
1696         (unpackIfNecessary): Modified to call executeRanlib().
1697
1698 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1699
1700         REGRESSION (177368): Some tests started to immediately time out
1701         https://bugs.webkit.org/show_bug.cgi?id=139826
1702
1703         Reviewed by Daniel Bates.
1704
1705         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1706         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1707         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1708         ends in a load failure, we don't dump, so we used to leak the timer.
1709         
1710         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1711         Added a comment.
1712
1713 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1714
1715         [Win] Add accessor for serializing HTTP loads
1716         https://bugs.webkit.org/show_bug.cgi?id=139817
1717
1718         Reviewed by Mark Lam.
1719
1720         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1721         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1722         remove some redundant code from the destructor.
1723
1724 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1725
1726         Clean up a fix for performance test bot failing to build
1727         https://bugs.webkit.org/show_bug.cgi?id=139818
1728
1729         Reviewed by Csaba Osztrogonác.
1730
1731         The "_1" in step name was annoying.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1734         (CleanBuildIfScheduled.start):
1735         (RunAndUploadPerfTests):
1736         (DownloadAndPerfTestFactory.__init__):
1737         (DownloadAndPerfTestWebKit2Factory.__init__):
1738         (CleanBuildUnconditionally): Deleted.
1739         (CleanBuildUnconditionally.start): Deleted.
1740
1741 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
1742
1743         REGRESSION(r177535): It broke the GTK performance bot
1744         https://bugs.webkit.org/show_bug.cgi?id=139811
1745
1746         Reviewed by Carlos Garcia Campos.
1747
1748         Trigger clean build only on mac platform.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1751         (DownloadAndPerfTestFactory.__init__):
1752         (DownloadAndPerfTestWebKit2Factory.__init__):
1753
1754 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
1755
1756         Unreviewed, moved myself to the list of committers.
1757
1758         * Scripts/webkitpy/common/config/contributors.json:
1759
1760 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1761
1762         [Win] Update DumpRenderTree to more closely match Mac version
1763         https://bugs.webkit.org/show_bug.cgi?id=139799
1764
1765         Reviewed by Tim Horton.
1766
1767         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1768         (AccessibilityController::accessibleElementById): Correct
1769         use of BSTR to avoid leak.
1770         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
1771         update to match Mac version more closely.
1772         (dumpFramesAsText):
1773         (dump):
1774         (resetDefaultsToConsistentValues):
1775         (resetWebViewToConsistentStateBeforeTesting):
1776         (sizeWebViewForCurrentTest):
1777         (runTest):
1778         (openWindows):
1779         (windowToWebViewMap):
1780         (createWebViewAndOffscreenWindow):
1781         (sharedCFURLCache):
1782         (initializeGlobalsFromCommandLineOptions):
1783         (main):
1784         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1785         (TestRunner::addDisallowedURL):
1786         (TestRunner::applicationCacheDiskUsageForOrigin):
1787         (TestRunner::syncLocalStorage):
1788         (TestRunner::localStorageDiskUsageForOrigin):
1789         (TestRunner::observeStorageTrackerNotifications):
1790         (TestRunner::clearApplicationCacheForOrigin):
1791         (TestRunner::originsWithApplicationCache):
1792         (TestRunner::deleteAllLocalStorage):
1793         (TestRunner::setStorageDatabaseIdleInterval):
1794         (TestRunner::closeIdleLocalStorageDatabases):
1795         (TestRunner::originsWithLocalStorage):
1796         (TestRunner::deleteLocalStorageForOrigin):
1797         (TestRunner::copyDecodedHostName):
1798         (TestRunner::copyEncodedHostName):
1799         (TestRunner::keepWebHistory):
1800         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1801         (TestRunner::setAppCacheMaximumSize):
1802         (TestRunner::setCustomPolicyDelegate):
1803         (TestRunner::goBack):
1804         (TestRunner::setDefersLoading):
1805         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1806         (TestRunner::setMockDeviceOrientation):
1807         (TestRunner::setMockGeolocationPosition):
1808         (TestRunner::setMockGeolocationPositionUnavailableError):
1809         (TestRunner::setIconDatabaseEnabled):
1810         (TestRunner::setMainFrameIsFirstResponder):
1811         (TestRunner::setSpatialNavigationEnabled):
1812         (TestRunner::setPluginsEnabled):
1813         (TestRunner::setAutomaticLinkDetectionEnabled):
1814         (TestRunner::setUseDashboardCompatibilityMode):
1815         (TestRunner::dispatchPendingLoadRequests):
1816         (TestRunner::findString):
1817         (TestRunner::setCacheModel):
1818         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1819         (TestRunner::setWebViewEditable):
1820         (TestRunner::authenticateSession):
1821         (TestRunner::abortModal):
1822         (TestRunner::setSerializeHTTPLoads):
1823         (TestRunner::addChromeInputField):
1824         (TestRunner::removeChromeInputField):
1825         (TestRunner::focusWebView):
1826         (TestRunner::setBackingScaleFactor):
1827         (TestRunner::grantWebNotificationPermission):
1828         (TestRunner::denyWebNotificationPermission):
1829         (TestRunner::removeAllWebNotificationPermissions):
1830         (TestRunner::simulateWebNotificationClick):
1831
1832 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
1833
1834         Add strong typing to RefCounter interface, return value as a bool.
1835         https://bugs.webkit.org/show_bug.cgi?id=139776
1836
1837         Reviewed by Geoff Garen.
1838
1839         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
1840         This means there is no compile time type checking to prevent mistakes. Update the count()
1841         method to token<>(), templated on type used to identify the token being returned.
1842         Calls to token<T>() will return a result of type RefCounter::Token<T>.
1843
1844         There are a few problems with the fact the counter will return you an exact count of the
1845         number of outstanding tokens:
1846           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
1847             to do so if the value is only readable as a boolean.
1848           - It is desirable to provide the value as an argument to the callback, however to make
1849             this useful for integer values it is also necessary to indicate the direction of change
1850             (0->1 is often interesting where 2->1 is not).
1851           - There is a mismatch between the precision of returning a count, and the inherent
1852             imprecision of a token based mechanism, where it may be difficult to guarantee
1853             absolutely no unnecessary refcount churn, and thus unintentional counter values.
1854
1855         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1856         (TestWebKitAPI::TEST):
1857             - update API test.
1858
1859 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1860
1861         Disable retries on Mac Release WK2 testers
1862         https://bugs.webkit.org/show_bug.cgi?id=139798
1863
1864         Reviewed by Simon Fraser.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/config.json:
1867
1868 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1869
1870         Perf tests frequently fail saying "build not up to date"
1871         https://bugs.webkit.org/show_bug.cgi?id=139786
1872
1873         Illegitimately yet authoritatively reviewed by Lucas Forschler.
1874
1875         Undo the rest of the first fix, and implement the behavior differently.
1876
1877         is_clean isn't automatically forwarded from config.json to properties.
1878
1879         * BuildSlaveSupport/build.webkit.org-config/config.json:
1880         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1881         (CleanBuildUnconditionally):
1882         (CleanBuildUnconditionally.start):
1883         (DownloadAndPerfTestFactory.__init__):
1884         (DownloadAndPerfTestWebKit2Factory.__init__):
1885
1886 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1887
1888         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
1889         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
1890         found nothing.
1891
1892         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1893         (BuildAndPerfTestFactory):
1894         (BuildAndPerfTestWebKit2Factory):
1895
1896 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1897
1898         Perf tests frequently fail saying "build not up to date"
1899         https://bugs.webkit.org/show_bug.cgi?id=139786
1900
1901         Reviewed by Ryosuke Niwa.
1902
1903         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
1904         directory to get rid of stale precompiled headers, and let it rebuild
1905         DumpRenderTree each time, that's fast.
1906
1907         Also, removed unused "build and perf test" code.
1908
1909         * BuildSlaveSupport/build.webkit.org-config/config.json:
1910
1911 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1912
1913         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
1914
1915         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
1916         it easier to see what steps are missing when running under Windows.
1917
1918         * DumpRenderTree/win/TestRunnerWin.cpp:
1919         (TestRunner::callShouldCloseOnWebView):
1920         (TestRunner::clearAllApplicationCaches):
1921         (TestRunner::applicationCacheDiskUsageForOrigin):
1922         (TestRunner::syncLocalStorage):
1923         (TestRunner::localStorageDiskUsageForOrigin):
1924         (TestRunner::observeStorageTrackerNotifications):
1925         (TestRunner::clearApplicationCacheForOrigin):
1926         (TestRunner::originsWithApplicationCache):
1927         (TestRunner::clearAllDatabases):
1928         (TestRunner::deleteAllLocalStorage):
1929         (TestRunner::setStorageDatabaseIdleInterval):
1930         (TestRunner::closeIdleLocalStorageDatabases):
1931         (TestRunner::originsWithLocalStorage):
1932         (TestRunner::deleteLocalStorageForOrigin):
1933         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1934         (jsStringRefToWString):
1935         (TestRunner::setAppCacheMaximumSize):
1936         (TestRunner::setDatabaseQuota):
1937         (TestRunner::goBack):
1938         (TestRunner::setDefersLoading):
1939         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1940         (TestRunner::setAutomaticLinkDetectionEnabled):
1941         (TestRunner::dispatchPendingLoadRequests):
1942         (TestRunner::overridePreference):
1943         (TestRunner::removeAllVisitedLinks):
1944         (TestRunner::waitForPolicyDelegate):
1945         (TestRunner::resetPageVisibility):
1946         (TestRunner::setPageVisibility):
1947         (TestRunner::grantWebNotificationPermission):
1948         (TestRunner::denyWebNotificationPermission):
1949         (TestRunner::removeAllWebNotificationPermissions):
1950         (TestRunner::simulateWebNotificationClick):
1951         (TestRunner::simulateLegacyWebNotificationClick):
1952
1953 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1954
1955         [Win] Correct Windows tests after Bug 139149 (edit)
1956         https://bugs.webkit.org/show_bug.cgi?id=139781
1957
1958         Reviewed by Anders Carlsson.
1959
1960         * DumpRenderTree/win/TestRunnerWin.cpp:
1961         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
1962         interface.
1963
1964 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
1965
1966         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
1967         https://bugs.webkit.org/show_bug.cgi?id=139748
1968
1969         Reviewed by Daniel Bates.
1970         
1971         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
1972         have all been updated.
1973
1974         * Scripts/webkitpy/port/factory.py:
1975         (platform_options):
1976
1977 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
1978
1979         Build more of TestWebKitAPI for iOS
1980         https://bugs.webkit.org/show_bug.cgi?id=139747
1981
1982         Reviewed by Daniel Bates.
1983         
1984         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
1985         which excluded some tests that should be run for iOS.
1986         
1987         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
1988         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
1989         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
1990         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
1991         
1992         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
1993         to share code between Mac and iOS.
1994
1995         * TestWebKitAPI/Configurations/Base.xcconfig:
1996         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1997         * TestWebKitAPI/InjectedBundleController.cpp:
1998         * TestWebKitAPI/InjectedBundleMain.cpp:
1999         * TestWebKitAPI/JavaScriptTest.cpp:
2000         * TestWebKitAPI/PlatformUtilities.cpp:
2001         * TestWebKitAPI/PlatformUtilities.h:
2002         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2003         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2004         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2005         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2006         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2007         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2008         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2009         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2010         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2011         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2012         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2013         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2014         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2015         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2016         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2017         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2018         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2019         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2020         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2021         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2022         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2023         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2024         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2025         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2026         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2027         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2028         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2029         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2030         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2031         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2032         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2033         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2034         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2035         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2036         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2037         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2038         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2039         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2040         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2041         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2042         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2043         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2044         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2045         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2046         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2047         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2048         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2049         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2050         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2051         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2052         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2053         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2054         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2055         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2056         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2057         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2058         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2059         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2060         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2061         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2062         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2063         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2064         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2065         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2066         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2067         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2068         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2069         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2070         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2071         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2072         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2073         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2074         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2075         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2076         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2077         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
2078         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
2079         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2080         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2081         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2082         (TestWebKitAPI::TEST):
2083         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2084         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2085         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2086         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2087         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
2088         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2089         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2090         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2091         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2092         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
2093         (TEST):
2094         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2095         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2096         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2097         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2098         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2099         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2100         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2101         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2102         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2103         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2104         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
2105         (TestWebKitAPI::Util::run):
2106         (TestWebKitAPI::Util::sleep):
2107         (TestWebKitAPI::Util::toSTD):
2108         * TestWebKitAPI/config.h:
2109         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2110         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2111         (TestWebKitAPI::Util::run): Deleted.
2112         (TestWebKitAPI::Util::sleep): Deleted.
2113         (TestWebKitAPI::Util::toSTD): Deleted.
2114
2115 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2116
2117         [GTK] Add support for FTL JIT on ARM64
2118         https://bugs.webkit.org/show_bug.cgi?id=139677
2119
2120         Reviewed by Csaba Osztrogonác.
2121
2122         * gtk/jhbuild-optional.modules:
2123         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2124         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2125
2126 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
2127
2128         [GTK] Implement webkit_web_view_is_playing_audio()
2129         https://bugs.webkit.org/show_bug.cgi?id=138918
2130
2131         Reviewed by Carlos Garcia Campos.
2132
2133         Add test case case for webkit_web_view_is_playing_audio() and the
2134         WebKitWebView::is-playing-audio property.
2135
2136         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2137         (urlForResource): Utility function to get URLs pointing to resources
2138         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
2139         (testWebViewIsPlayingAudio): Added.
2140         (beforeAll):
2141         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2142         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
2143         API tests resources directory, or the WebKit2 C API tests resources
2144         directory. The default value of the flag is to use the WebKit2 GTK
2145         one, to avoid having to change existing tests.
2146         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2147         (isPlayingAudioChanged): Added.
2148         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
2149         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2150
2151 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2152
2153         [GTK] [EFL] Enable per_test_timeout
2154         https://bugs.webkit.org/show_bug.cgi?id=139771
2155
2156         Reviewed by Csaba Osztrogonác.
2157
2158         This is needed to make WKTR use either the default port timeout, or the
2159         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
2160         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
2161
2162         * Scripts/webkitpy/port/efl.py:
2163         (EflPort.supports_per_test_timeout): Enabled.
2164         * Scripts/webkitpy/port/gtk.py:
2165         (GtkPort.supports_per_test_timeout): Enabled.
2166
2167 2014-12-17  Lucas Forschler  <lforschler@apple.com>
2168
2169         Move Apple buildbot slaves to their new home.
2170         
2171         Reviewed by Roger Fong.
2172
2173         * BuildSlaveSupport/build.webkit.org-config/config.json:
2174
2175 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2176
2177         REGRESSION (r177363): Gtk and Efl testing is broken
2178         https://bugs.webkit.org/show_bug.cgi?id=139734
2179
2180         Reviewed by Simon Fraser.
2181
2182         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2183         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2184         affected both script and tool timeout. This is still the right place for this logic,
2185         but it would be a larger refactoring than I can do right now.
2186
2187         * Scripts/webkitpy/port/base.py:
2188         (Port.supports_per_test_timeout): Added a FIXME.
2189         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2190         to avoid making tests take more time.
2191
2192         * Scripts/webkitpy/port/driver.py:
2193         (Driver.run_test): Adjust script timeout here.
2194         (Driver._check_for_driver_timeout): Fix the timeout detection.
2195         (Driver._read_block): Actually use the timeout detection code.
2196
2197         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2198         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2199
2200         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
2201         Update results for the new default.
2202
2203         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2204         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
2205         actually a good one.
2206
2207 2014-12-17  Commit Queue  <commit-queue@webkit.org>
2208
2209         Unreviewed, rolling out r177456.
2210         https://bugs.webkit.org/show_bug.cgi?id=139749
2211
2212         Broke webkitpy and Mac tests (Requested by ap on #webkit).
2213
2214         Reverted changeset:
2215
2216         "REGRESSION (r177363): Gtk and Efl testing is broken"
2217         https://bugs.webkit.org/show_bug.cgi?id=139734
2218         http://trac.webkit.org/changeset/177456
2219
2220 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2221
2222         REGRESSION (r177363): Gtk and Efl testing is broken
2223         https://bugs.webkit.org/show_bug.cgi?id=139734
2224
2225         Reviewed by Simon Fraser.
2226
2227         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2228         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2229         affected both script and tool timeout. This is still the right place for this logic,
2230         but it would be a larger refactoring than I can do right now.
2231
2232         * Scripts/webkitpy/port/base.py:
2233         (Port.supports_per_test_timeout): Added a FIXME.
2234         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2235         to avoid making tests take more time.
2236
2237         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
2238
2239         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2240         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2241
2242 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2243
2244         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
2245         https://bugs.webkit.org/show_bug.cgi?id=139725
2246
2247         Reviewed by Martin Robinson.
2248
2249         The timeout is already in milliseconds, so we don't need to do any conversion.
2250
2251         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2252         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2253
2254 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
2255
2256         [EFL]Fix build warning in MiniBrowser
2257         https://bugs.webkit.org/show_bug.cgi?id=139723
2258
2259         Reviewed by Darin Adler.
2260
2261         The warning is caused by the compiler wanting the first argument to be a
2262         string literal, not a dynamically created string.
2263
2264         * MiniBrowser/efl/main.c:
2265         (quit):
2266
2267 2014-12-16  Sam Weinig  <sam@webkit.org>
2268
2269         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
2270         https://bugs.webkit.org/show_bug.cgi?id=139718
2271
2272         Reviewed by Mark Rowe.
2273
2274         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
2275         files into a static lib which the command line utility can link link against.
2276         This will allow us to create a TestWebKitAPI.app that can run on iOS.
2277
2278         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2279         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
2280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2281
2282 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
2283
2284         Sort out timeout implementations in DRT and WKTR
2285         https://bugs.webkit.org/show_bug.cgi?id=139671
2286
2287         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
2288         with the tool.
2289
2290         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2291         (RunTest.test_hung_thread):
2292
2293 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
2294
2295         Sort out timeout implementations in DRT and WKTR
2296         https://bugs.webkit.org/show_bug.cgi?id=139671
2297
2298         Reviewed by Simon Fraser.
2299
2300         Test timeout implementation had many deficiencies, please see the bug for details.
2301         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
2302         [ Slow ] modifiers should work a lot better.
2303
2304         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
2305         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
2306         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
2307         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
2308         DumpRenderTree already read the --timeout option from command line, and webkitpy
2309         was already configured to pass it on Mac and iOS. Let's actually use it.
2310         TestCommand already had the same 30 second default, so this doesn't change behavior
2311         when DRT is ran manually without the option.
2312         Windows DumpRenderTree will need to be fixed separately (that's easy).
2313
2314         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
2315         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
2316         slightly better to use stderr in both, as this is an out of band message, but
2317         that's a larger refactoring, and the difference is minimal in practice.
2318
2319         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2320         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
2321         different. We want the tool to reliably detect timeouts that can be detected, and
2322         not race with the script for that.
2323
2324         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
2325         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
2326         is honored inmore cases, that could make tests run slower.
2327         * Scripts/webkitpy/port/driver.py:
2328         (Driver.__init__):
2329         (Driver.run_test):
2330         (Driver.cmd_line):
2331         (Driver._check_for_driver_timeout):
2332         Detect tests that have the timeout output, and make these have the proper Timeout result.
2333
2334         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
2335         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
2336
2337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2338         (WTR::TestRunner::setCustomTimeout): Deleted.
2339         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2340         (WTR::TestRunner::setCustomTimeout):
2341         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2342         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2343         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2344         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2345         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2346         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2347         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2348         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2349         Updated to use a timeout passed from UI process, which used to be ignored.
2350
2351         * WebKitTestRunner/TestController.cpp:
2352         (WTR::TestController::TestController):
2353         (WTR::TestController::runUntil):
2354         (WTR::TestController::getCustomTimeout): Deleted.
2355         * WebKitTestRunner/TestController.h:
2356         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
2357         Changed default message timeouts to match new run-webkit-tests timeout. These don't
2358         affect ports where timeout is passed per test (shouldn't they all be like that?).
2359
2360         * WebKitTestRunner/TestInvocation.cpp:
2361         (WTR::TestInvocation::invoke):
2362         (WTR::TestInvocation::setCustomTimeout): Deleted.
2363         * WebKitTestRunner/TestInvocation.h:
2364         (WTR::TestInvocation::setCustomTimeout):
2365         (WTR::TestInvocation::customTimeout):
2366         Ditto.
2367
2368 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2369
2370         [EFL] Add logging domain for MiniBrowser
2371         https://bugs.webkit.org/show_bug.cgi?id=139642
2372
2373         Reviewed by Gyuyoung Kim.
2374
2375         Similarly to EWebKit2, provide logging facility for MiniBrowser
2376         based on Eina Log module to have a convenient way to display
2377         all/subset/none messages for EFL based libraries and MiniBrowser.
2378
2379         Usage:
2380         1. Disable all messages:
2381            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2382
2383         2. Enable all messages:
2384            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2385
2386         3. Enable MiniBrowser and EWebkit2 messages only:
2387            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2388
2389         More information and examples you can find here:
2390         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2391
2392         * MiniBrowser/efl/main.c:
2393         (on_mouse_wheel):
2394         (on_window_resize):
2395         (save_page_contents_callback):
2396         (script_execute_callback):
2397         (on_key_down):
2398         (on_download_request):
2399         (on_download_finished):
2400         (on_download_failed):
2401         (quit):
2402         (on_refresh_button_clicked):
2403         (on_stop_button_clicked):
2404         (navigation_button_longpress_process):
2405         (on_popup_menu_item_clicked):
2406         (popup_menu_populate):
2407         (on_popup_menu_show):
2408         (on_window_create):
2409         (context_menu_item_selected_cb):
2410         (context_menu_populate):
2411         (on_context_menu_show):
2412         (on_context_menu_hide):
2413         (on_navigation_policy_decision):
2414         (window_create):
2415         (parse_cookies_policy):
2416         (elm_main):
2417         (has_scheme):
2418         (list_item_label_get):
2419         (on_popup_menu_hide):
2420         (on_window_close):
2421         (on_home_button_clicked):
2422         Replace locally info() macro with newly introduced
2423         one which uses Eina Log module. There is no logic change.
2424
2425 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2426
2427         [EFL] FTL JIT not working on ARM64
2428         https://bugs.webkit.org/show_bug.cgi?id=139295
2429
2430         Reviewed by Michael Saboff.
2431
2432         Added patches for llvm to add ARM64 support for FTL JIT
2433
2434         * efl/jhbuild.modules:
2435         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2436         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2437
2438 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2439
2440         Move Said to the committers section.
2441
2442         * Scripts/webkitpy/common/config/contributors.json:
2443
2444 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2445
2446         Implement Data Detectors immediate actions for WebKit2
2447         https://bugs.webkit.org/show_bug.cgi?id=139617
2448         <rdar://problem/19198539>
2449
2450         Reviewed by Beth Dakin.
2451
2452         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2453         (TestWebKitAPI::TEST):
2454         Temporarily disable the action menu tests while the
2455         underlying code is in flux.
2456
2457 2014-12-14  Andreas Kling  <akling@apple.com>
2458
2459         Replace PassRef with Ref/Ref&& across the board.
2460         <https://webkit.org/b/139587>
2461
2462         Reviewed by Darin Adler.
2463
2464         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2465         (TestWebKitAPI::passWithRef):
2466         (TestWebKitAPI::TEST):
2467         (TestWebKitAPI::passWithPassRef): Deleted.
2468         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2469         (TestWebKitAPI::TEST):
2470         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2471         (TestWebKitAPI::TEST):
2472         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2473         (TestWebKitAPI::createTestValue):
2474
2475 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2476
2477         [EFL] MiniBrowser's window_create may return NULL
2478         https://bugs.webkit.org/show_bug.cgi?id=139585
2479
2480         Reviewed by Gyuyoung Kim.
2481
2482         Move NULL checking before using object which window_create
2483         returns.
2484
2485         * MiniBrowser/efl/main.c:
2486         (elm_main):
2487
2488 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
2489
2490         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
2491         https://bugs.webkit.org/show_bug.cgi?id=73030
2492
2493         Reviewed by Anders Carlsson.
2494
2495         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
2496         database to empty to avoid having it fetch default favicons at random times.
2497         DumpRenderTree also disables it, and also it has a way for tests to temporarily
2498         enable it.
2499
2500 2014-12-12  Lucas Forschler  <lforschler@apple.com>
2501
2502         Update Apple owned build slaves after infrastructure update.
2503         
2504         Reviewed by Ryosuke Niwa.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/config.json:
2507
2508 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2509
2510         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2511         https://bugs.webkit.org/show_bug.cgi?id=139537
2512
2513         Reviewed by Carlos Garcia Campos.
2514
2515         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2516         of get_dependencies_path().
2517         * jhbuild/jhbuildutils.py:
2518         (get_dependencies_path): Fix the function to return the new
2519         dependencies path: DependenciesPORT.
2520         (enter_jhbuild_environment_if_available): Pass the port name
2521         when invoking get_dependencies_path().
2522
2523 2014-12-10  Lucas Forschler  <lforschler@apple.com>
2524
2525         Update Apple owned build slaves.
2526         
2527         Rubber-stamped by Dana Burkart.
2528         
2529         * BuildSlaveSupport/build.webkit.org-config/config.json:
2530
2531 2014-12-10  Daniel Bates  <dabates@apple.com>
2532
2533         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2534         timeout instead of test failure
2535         https://bugs.webkit.org/show_bug.cgi?id=139525
2536
2537         Reviewed by Zalan Bujtas.
2538
2539         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2540         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2541         output.
2542
2543         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2544         for the WebThread to spin its run loop before dumping its output. A test that
2545         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2546         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2547         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2548         because run-webkit-tests may terminate a DumpRenderTree.app process when it
2549         exceeds its process time limit (defaults to 35ms) regardless of whether such
2550         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2551
2552         * Scripts/webkitpy/port/ios.py:
2553         (IOSSimulatorPort.default_timeout_ms):
2554
2555 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2556
2557         [GTK][WK2] Add HTML5 Notifications support
2558         https://bugs.webkit.org/show_bug.cgi?id=61140
2559
2560         Reviewed by Carlos Garcia Campos.
2561
2562         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2563         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2564         (testWebViewNotification):
2565         (beforeAll):
2566         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2567         (permissionRequestDialogCallback):
2568         (webViewDecidePermissionRequest):
2569         (geolocationRequestDialogCallback): Deleted.
2570
2571 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2572
2573         Fix webkitpy test expectation
2574
2575         Not sure what I messed up, but TOTAL_SKIPS was not right.
2576
2577         * Scripts/webkitpy/port/test.py:
2578
2579 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2580
2581         Remove virtual test support from webkitpy
2582         https://bugs.webkit.org/show_bug.cgi?id=139427
2583
2584         Reviewed by Alexey Proskuryakov.
2585
2586         It seems that the only concrete client of virtual tests is the unit tests :D
2587
2588         This patch tries to clean as much useless code as possible.
2589
2590         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2591         (RunTest.test_tolerance):
2592         (RunTest.test_virtual): Deleted.
2593         * Scripts/webkitpy/layout_tests/views/printing.py:
2594         (Printer._print_test_trace):
2595         * Scripts/webkitpy/port/base.py:
2596         (Port.expected_filename):
2597         (Port.tests):
2598         (Port.test_isfile):
2599         (Port.test_isdir):
2600         (Port.sample_process):
2601         (Port.find_system_pid):
2602         (Port.test_expectations_file_position):
2603         (Port.virtual_test_suites): Deleted.
2604         (Port): Deleted.
2605         (Port.populated_virtual_test_suites): Deleted.
2606         (Port._virtual_tests): Deleted.
2607         (Port.lookup_virtual_test_base): Deleted.
2608         (Port.lookup_virtual_test_args): Deleted.
2609         (VirtualTestSuite): Deleted.
2610         (VirtualTestSuite.__init__): Deleted.
2611         (VirtualTestSuite.__repr__): Deleted.
2612         * Scripts/webkitpy/port/base_unittest.py:
2613         (PortTest.test_test_exists):
2614         (PortTest.test_test_isfile):
2615         (PortTest.test_test_isdir):
2616         (PortTest.test_tests):
2617         * Scripts/webkitpy/port/driver.py:
2618         (DriverProxy.run_test): Deleted.
2619         * Scripts/webkitpy/port/test.py:
2620         (TestPort._skipped_tests_for_unsupported_features):
2621         (TestPort.all_baseline_variants):
2622         (TestPort.virtual_test_suites): Deleted.
2623         * Scripts/webkitpy/tool/commands/queries.py:
2624         (PrintBaselines.__init__):
2625         (PrintBaselines.execute):
2626         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2627         (PrintBaselinesTest.test_basic):
2628         (PrintBaselinesTest.test_multiple):
2629         (PrintBaselinesTest.test_csv):
2630
2631 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2632
2633         Blink Merge: Remove 'http_lock' code from webkitpy
2634         https://bugs.webkit.org/show_bug.cgi?id=136722
2635
2636         Reviewed by Alexey Proskuryakov.
2637
2638         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2639         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2640
2641         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2642         (LayoutTestRunner.__init__):
2643         (LayoutTestRunner.run_tests):
2644         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2645         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2646         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2647         (FakePrinter.flush):
2648         (LayoutTestRunnerTests._runner):
2649         (LayoutTestRunnerTests._run_tests):
2650         (LayoutTestRunnerTests.test_servers_started):
2651         (LockCheckingRunner): Deleted.
2652         (LockCheckingRunner.__init__): Deleted.
2653         (LockCheckingRunner.handle_finished_list): Deleted.
2654         (LayoutTestRunnerTests.test_http_locking): Deleted.
2655         * Scripts/webkitpy/port/base.py:
2656         (Port.__init__):
2657         (Port.to.http_server_supports_ipv6):
2658         (Port.to.stop_websocket_server):
2659         (Port.to.acquire_http_lock): Deleted.
2660         (Port.to.release_http_lock): Deleted.
2661         * Scripts/webkitpy/port/http_lock.py: Removed.
2662         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2663         * Scripts/webkitpy/port/ios.py:
2664         (IOSSimulatorPort.show_results_html_file):
2665         (IOSSimulatorPort.acquire_http_lock): Deleted.
2666         (IOSSimulatorPort): Deleted.
2667         (IOSSimulatorPort.release_http_lock): Deleted.
2668         * Scripts/webkitpy/port/mac.py:
2669         (MacPort.show_results_html_file):
2670         (MacPort): Deleted.
2671         (MacPort.acquire_http_lock): Deleted.
2672         (MacPort.release_http_lock): Deleted.
2673         * Scripts/webkitpy/port/mock_drt.py:
2674         (MockDRTPort.start_websocket_server):
2675         (MockDRTPort.stop_websocket_server):
2676         (MockDRTPort.acquire_http_lock): Deleted.
2677         (MockDRTPort.release_http_lock): Deleted.
2678         * Scripts/webkitpy/port/mock_drt_unittest.py:
2679         (MockDRTPortTest.test_uses_apache):
2680         (MockDRTPortTest.integration_test_http_lock): Deleted.
2681         * Scripts/webkitpy/port/port_testcase.py:
2682         (PortTestCase.assert_servers_are_up):
2683         (PortTestCase.integration_test_http_lock): Deleted.
2684         * Scripts/webkitpy/port/test.py:
2685         (TestPort.start_websocket_server):
2686         (TestPort.stop_websocket_server):
2687         (TestPort.acquire_http_lock): Deleted.
2688         (TestPort.release_http_lock): Deleted.
2689
2690 2014-12-09  Alberto Garcia  <berto@igalia.com>
2691
2692         convertToUTF8String converts null string to empty string
2693         https://bugs.webkit.org/show_bug.cgi?id=133904
2694
2695         Reviewed by Carlos Garcia Campos.
2696
2697         Test that trying to get the value of a non-existent attribute
2698         returns 0 instead of an empty string.
2699
2700         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2701         (WebKitDOMNodeTest::testInsertion):
2702
2703 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
2704
2705         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2706         https://bugs.webkit.org/show_bug.cgi?id=139070
2707
2708         Reviewed by Carlos Garcia Campos.
2709
2710         * gtk/jhbuild.modules:
2711
2712 2014-12-08  Tim Horton  <timothy_horton@apple.com>
2713
2714         Add action menu tests
2715         https://bugs.webkit.org/show_bug.cgi?id=139156
2716
2717         Reviewed by Dean Jackson.
2718
2719         * TestWebKitAPI/PlatformWebView.h:
2720         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2721         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2722         Add a mechanism allowing tests to provide their own WKView subclass.
2723
2724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2725         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2726         Add a file with lots of menu targets.
2727
2728         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2729         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2730         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2731         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2732         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2733
2734         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2735
2736         (TestWebKitAPI::didFinishLoadForFrameCallback):
2737         (TestWebKitAPI::didFinishDownloadCallback):
2738         (TestWebKitAPI::didCreateDownloadDestinationCallback):
2739         Watch downloads and ensure that they match the content we expect.
2740
2741         (TestWebKitAPI::watchPasteboardForString):
2742         (TestWebKitAPI::watchPasteboardForImage):
2743         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
2744         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
2745         (TestWebKitAPI::javaScriptStringCallback):
2746         (TestWebKitAPI::javaScriptBoolCallback):
2747         (TestWebKitAPI::callJavaScriptReturningString):
2748         (TestWebKitAPI::callJavaScriptReturningBool):
2749         (TestWebKitAPI::watchEditableAreaForString):
2750         (TestWebKitAPI::waitForVideoReady):
2751         (TestWebKitAPI::retrieveSelection):
2752         (TestWebKitAPI::retrieveSelectionInElement):
2753         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
2754         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
2755         Add many helpers for testing, especially to make asynchronous things synchronous.
2756
2757         (TestWebKitAPI::windowPointForTarget):
2758         (TestWebKitAPI::inset8):
2759         Hard-code points in action-menu-targets.html for hit testing.
2760
2761         (TestWebKitAPI::TEST):
2762         Add a suite of tests for WebKit2 action menus.
2763
2764         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
2765         (TestWebKitAPI::createActionContextForPhoneNumber):
2766         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
2767         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
2768         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2769         (TestWebKitAPI::ActionMenuTest::drawRect):
2770         (TestWebKitAPI::ActionMenuTest::didCreatePage):
2771         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
2772         so that we can test that infrastructure.
2773
2774 2014-12-08  Philippe Normand  <pnormand@igalia.com>
2775
2776         [GTK] UserMedia Permission Request API
2777         https://bugs.webkit.org/show_bug.cgi?id=136449
2778
2779         Reviewed by Carlos Garcia Campos.
2780
2781         The GTK version of the MiniBrowser has gained UserMedia permission
2782         request support.
2783
2784         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
2785         requires user permission to access audio/video devices.
2786         (permissionRequestDialogCallback):
2787         (webViewDecidePermissionRequest):
2788         (geolocationRequestDialogCallback): Deleted.
2789
2790 2014-12-08  Anders Carlsson  <andersca@apple.com>
2791
2792         Add a stubbed out method for clearing out the website data store
2793         https://bugs.webkit.org/show_bug.cgi?id=139404
2794
2795         Reviewed by Antti Koivisto.
2796
2797         Add a debug menu item for testing clearing of website data.
2798
2799         * MiniBrowser/mac/MainMenu.xib:
2800         * MiniBrowser/mac/WK2BrowserWindowController.m:
2801         (-[WK2BrowserWindowController clearWebsiteData:]):
2802
2803 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
2804
2805         Update style checker to deal with "const override"
2806         https://bugs.webkit.org/show_bug.cgi?id=139371
2807
2808         Reviewed by Csaba Osztrogonác.
2809
2810         check-webkit-style shouldn't complain about an open brace to start a
2811         line after a function definition with const override.
2812
2813         * Scripts/webkitpy/style/checkers/cpp.py:
2814         (check_braces):
2815         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2816         (CppStyleTest.test_brace_at_begin_of_line):
2817
2818 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2819
2820         [GTK] Fix GObject DOM bindings API break tests after r176920
2821         https://bugs.webkit.org/show_bug.cgi?id=139368
2822
2823         Reviewed by Gustavo Noronha Silva.
2824
2825         Remove the @version from the symbol name before comparing.
2826
2827         * gtk/check-for-webkitdom-api-breaks:
2828         (read_expected_api):
2829
2830 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2831
2832         Remove the option to automatically update the GObject DOM bindings symbols file
2833         https://bugs.webkit.org/show_bug.cgi?id=139366
2834
2835         Reviewed by Martin Robinson.
2836
2837         It's currently broken, because symbols now need to be in a
2838         specific order. Now that the symbols file only contains stable
2839         API, it's not a problem to manually update it every time new API
2840         is added.
2841
2842         * gtk/check-for-webkitdom-api-breaks:
2843         (read_expected_api):
2844         (check_api):
2845         (write_expected_api): Deleted.
2846
2847 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2848
2849         [GTK] Use GMainLoopSource in WebKitTestRunner
2850         https://bugs.webkit.org/show_bug.cgi?id=138831
2851
2852         Reviewed by Sergio Villar Senin.
2853
2854         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2855         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2856         (WTR::TestRunner::platformInitialize):
2857         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2858         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2859         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2860         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2861         (WTR::TestController::notifyDone):
2862         (WTR::TestController::platformRunUntil):
2863         (WTR::cancelTimeout): Deleted.
2864
2865 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2866
2867         [GTK] Missing API detected in GObject DOM bindings after r176630
2868         https://bugs.webkit.org/show_bug.cgi?id=139201
2869
2870         Reviewed by Gustavo Noronha Silva.
2871
2872         Handle deprecated symbols again when generating the GObject DOM
2873         bindings documentation.
2874
2875         * gtk/webkitdom.py:
2876         (WebKitDOMDocGenerator):
2877         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
2878         (WebKitDOMDocGenerator.generate):
2879         (WebKitDOMDocGeneratorSections.__init__):
2880         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
2881         (WebKitDOMDocGeneratorSections.write_section):
2882
2883 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
2884
2885         [EFL][jhbuild] Fix libsoup build with clang
2886         https://bugs.webkit.org/show_bug.cgi?id=139088
2887
2888         Reviewed by Gyuyoung Kim.
2889
2890         * efl/jhbuild.modules:
2891         * efl/patches/soup-clang-warning-fix1.patch: Added.
2892         * efl/patches/soup-clang-warning-fix2.patch: Added.
2893
2894 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
2895
2896         [Mac] DumpRenderTree sets storage directory incorrectly
2897         https://bugs.webkit.org/show_bug.cgi?id=139347
2898
2899         Reviewed by Dan Bernstein.
2900
2901         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2902         Don't use user defaults to pass per-instance paths, as user defaults are shared
2903         across all instances.
2904
2905 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
2906
2907         AX: I cannot activate links on the mobile version of news.google.com
2908         https://bugs.webkit.org/show_bug.cgi?id=139330
2909
2910         Reviewed by Simon Fraser.
2911
2912         Implement press for iOS.
2913
2914         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2915         (AccessibilityUIElement::press):
2916
2917 2014-12-05  Daniel Bates  <dabates@apple.com>
2918
2919         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
2920         https://bugs.webkit.org/show_bug.cgi?id=139326
2921
2922         Reviewed by Anders Carlsson.
2923
2924         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
2925         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
2926         using the same scale factor as used in WebKit.
2927
2928         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2929         (createBitmapContextFromWebView):
2930
2931 2014-12-05  Anders Carlsson  <andersca@apple.com>
2932
2933         REGRESSION (r176677): All tests crash on Windows
2934         https://bugs.webkit.org/show_bug.cgi?id=139321
2935
2936         Reviewed by Alexey Proskuryakov.
2937
2938         * DumpRenderTree/win/DumpRenderTree.cpp:
2939         (runTest):
2940         Don't call CFRelease on the url while we have an outstanding pointer to its string,
2941         and use the right number of bytes when allocating the testURL buffer.
2942
2943 2014-12-05  Daniel Bates  <dabates@apple.com>
2944
2945         [iOS] DumpRenderTree produces many reference test mismatches
2946         https://bugs.webkit.org/show_bug.cgi?id=139314
2947
2948         Reviewed by Simon Fraser.
2949
2950         Fixes an issue where the scale factor used to render the snapshot taken by
2951         DumpRenderTree may differ from the device scale factor. In particular, the
2952         scale factor used to render a snapshot of a test may differ from the scale
2953         factor used to render the snapshot of its expected result.
2954
2955         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
2956         snapshot the UIWebBrowserView. This SPI always render using a scale factor
2957         of one when the backing store for the LegacyTileLayer objects were out-of-
2958         date regardless of the device scale factor. Instead we should use UIImage
2959         and CALayer API to perform the snapshot with respect to the device scale
2960         factor.
2961
2962         Additionally write iOS pixel dump support logic in terms of existing
2963         DumpRenderTree abstractions so as to support generating and comparing
2964         pixel dump checksums as well as make the iOS code more consistent with
2965         the logic used by other ports.
2966
2967         * DumpRenderTree/PixelDumpSupport.cpp:
2968         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
2969         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2970         (BitmapContext::createFromUIImage): Added.
2971         (BitmapContext::pixelData): Added.
2972         (BitmapContext::BitmapContext): Added.
2973         (computeMD5HashStringForBitmapContext): Added.
2974         (dumpBitmap): Added.
2975         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
2976         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
2977
2978 2014-12-05  Anders Carlsson  <andersca@apple.com>
2979
2980         Give all web pages a website data store
2981         https://bugs.webkit.org/show_bug.cgi?id=139317
2982
2983         Reviewed by Tim Horton.
2984
2985         * MiniBrowser/mac/AppDelegate.m:
2986         (-[BrowserAppDelegate newPrivateWindow:]):
2987         Don't release the controller - it's implicitly retained by the window.
2988
2989 2014-12-05  Daniel Bates  <dabates@apple.com>
2990
2991         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
2992         https://bugs.webkit.org/show_bug.cgi?id=137581
2993         <rdar://problem/18642906>
2994
2995         Reviewed by Simon Fraser.
2996
2997         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
2998         of the test that proceeded the currently running test.
2999
3000         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3001         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
3002         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
3003         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
3004
3005 2014-12-05  Jer Noble  <jer.noble@apple.com>
3006
3007         [WTF] MediaTime should support round-tripping from and to doubles.
3008         https://bugs.webkit.org/show_bug.cgi?id=139248
3009
3010         Reviewed by Eric Carlson.
3011
3012         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
3013         the MediaTimes after this change.
3014
3015         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3016         (WTF::operator<<):
3017         (TestWebKitAPI::TEST):
3018         * lldb/lldb_webkit.py:
3019         (WTFMediaTime_SummaryProvider):
3020         (WTFMediaTimeProvider.timeValueAsDouble):
3021         (WTFMediaTimeProvider.isIndefinite):
3022         (WTFMediaTimeProvider):
3023         (WTFMediaTimeProvider.hasDoubleValue):
3024
3025 2014-12-05  Anders Carlsson  <andersca@apple.com>
3026
3027         Add a private browsing mode to MiniBrowser
3028         https://bugs.webkit.org/show_bug.cgi?id=139308
3029
3030         Reviewed by Sam Weinig.
3031
3032         * MiniBrowser/mac/AppDelegate.m:
3033         (defaultConfiguration):
3034         (-[BrowserAppDelegate newWindow:]):
3035         (-[BrowserAppDelegate newPrivateWindow:]):
3036         * MiniBrowser/mac/MainMenu.xib:
3037         * MiniBrowser/mac/WK2BrowserWindowController.h:
3038         * MiniBrowser/mac/WK2BrowserWindowController.m:
3039         (-[WK2BrowserWindowController awakeFromNib]):
3040         (-[WK2BrowserWindowController initWithConfiguration:]):
3041         (-[WK2BrowserWindowController dealloc]):
3042         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3043
3044 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3045
3046         Run http tests parallel
3047         https://bugs.webkit.org/show_bug.cgi?id=138958
3048
3049         Reviewed by Daniel Bates.
3050
3051         Remove the concept of "locked shard". Now http tests are just like any other tests.
3052         We start HTTP and WebSocket servers at the start if we need them, and terminate them
3053         when done with all the tests (not when the last http test runs, which is unnecessarily
3054         unpredictable).
3055
3056         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
3057         patch, they used to take over 15 minutes.
3058
3059         As part of the fix, we no longer pass the number of servers to Apache. I don't
3060         think that these parameters did what we wanted them to do; Apache handles the load
3061         just fine without them.
3062
3063         The change applies to all platforms. I fixed everything I could find on Mac, and
3064         Ossy told me that he's been running http tests in parallel for a long time. If
3065         there is increased instability for some ports, it will need to be fixed - there is
3066         generally nothing special about http tests at this point, and most code is
3067         cross-platform in WebKit2.
3068
3069         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3070         (LayoutTestRunner.__init__):
3071         (LayoutTestRunner.run_tests):
3072         (LayoutTestRunner.start_servers_with_lock):
3073         (LayoutTestRunner._handle_started_test):
3074         (Worker.handle):
3075         (Sharder.__init__):
3076         (Sharder.shard_tests):
3077         (Sharder._shard_every_file):
3078         (Sharder._shard_by_directory):
3079         (LayoutTestRunner._handle_finished_test_list): Deleted.
3080         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
3081         (Sharder._shard_in_two): Deleted.
3082         (Sharder): Deleted.
3083         (Sharder._resize_shards): Deleted.
3084         (Sharder._resize_shards.divide_and_round_up): Deleted.
3085         (Sharder._resize_shards.extract_and_flatten): Deleted.
3086         (Sharder._resize_shards.split_at): Deleted.
3087         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3088         (FakePrinter.print_workers_and_shards):
3089         (LayoutTestRunnerTests.test_servers_started.start_http_server):
3090         (LayoutTestRunnerTests.test_servers_started):
3091         (SharderTests.get_shards):
3092         (SharderTests.test_shard_by_dir):
3093         (SharderTests.test_shard_every_file):
3094         (SharderTests): Deleted.
3095         (SharderTests.test_shard_in_two): Deleted.
3096         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
3097         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
3098         (SharderTests.test_multiple_locked_shards): Deleted.
3099         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3100         (ManagerTest.test_needs_servers.get_manager):
3101         (ManagerTest.integration_test_needs_servers.get_manager):
3102         (ManagerTest.test_look_for_new_crash_logs.get_manager):
3103         (ManagerTest):
3104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3105         (_set_up_derived_options):
3106         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3107         (RunTest.test_batch_size):
3108         (RunTest.test_max_locked_shards): Deleted.
3109         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3110         (LayoutTestApacheHttpd.__init__):
3111         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3112         (TestLayoutTestApacheHttpd.test_start_cmd):
3113         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3114         (Lighttpd.__init__):
3115         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3116         (HttpServerBase.__init__):
3117         * Scripts/webkitpy/layout_tests/views/printing.py:
3118         (Printer.print_workers_and_shards):
3119         * Scripts/webkitpy/port/base.py:
3120         (Port.default_child_processes):
3121         (Port.to.start_http_server):
3122         (Port.default_max_locked_shards): Deleted.
3123         * Scripts/webkitpy/port/port_testcase.py:
3124         (PortTestCase.make_port):
3125         (PortTestCase.test_default_max_locked_shards): Deleted.
3126         * Scripts/webkitpy/port/test.py:
3127         (TestPort.start_http_server):
3128
3129 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3130
3131         Don't lock perf tests in run-webkit-tests
3132         https://bugs.webkit.org/show_bug.cgi?id=139264
3133
3134         Reviewed by Daniel Bates.
3135
3136         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3137         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3138         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3139         * Scripts/webkitpy/layout_tests/models/test_input.py:
3140         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3141
3142 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
3143
3144         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
3145         https://bugs.webkit.org/show_bug.cgi?id=139243
3146
3147         Reviewed by Anders Carlsson.
3148
3149         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
3150         chance to allow untrusted certificates.
3151
3152         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
3153         Set up more client objects for secondary windows. We may be able to share some of the
3154         code with main view creation function, but it's not exactly the same (notably, we
3155         do not focus a secondary window when it's done loading).
3156
3157 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
3158
3159         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
3160         https://bugs.webkit.org/show_bug.cgi?id=139071
3161
3162         Reviewed by Chris Fleizach.
3163
3164         Add string value for ATK_ROLE_STATIC in roleToString.
3165
3166         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3167
3168 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
3169
3170         check-webkit-style is confused by ternary expression inside first member initializer
3171         https://bugs.webkit.org/show_bug.cgi?id=136442
3172
3173         Reviewed by Csaba Osztrogonác.
3174
3175         * Scripts/webkitpy/style/checkers/cpp.py:
3176         (check_member_initialization_list):
3177
3178 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3179
3180         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
3181         https://bugs.webkit.org/show_bug.cgi?id=139220
3182
3183         Reviewed by Philippe Normand.
3184
3185         * gtk/jhbuild.modules:
3186         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3187
3188 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3189
3190         Remove unused JSC runtime options
3191         https://bugs.webkit.org/show_bug.cgi?id=133070
3192
3193         Reviewed by Csaba Osztrogonác.
3194
3195         * Scripts/run-jsc-stress-tests:
3196
3197 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3198
3199         [EFL] Add subtle crypto to the build system
3200         https://bugs.webkit.org/show_bug.cgi?id=138612
3201
3202         Reviewed by Csaba Osztrogonác.
3203
3204         * Scripts/webkitperl/FeatureList.pm:
3205
3206 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
3207
3208         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
3209         https://bugs.webkit.org/show_bug.cgi?id=139005
3210
3211         Reviewed by Chris Fleizach.
3212
3213         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3214         Add mapping for ATK_ROLE_CAPTION to roleToString
3215
3216 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3217
3218         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3219         https://bugs.webkit.org/show_bug.cgi?id=139149
3220
3221         Reviewed by Anders Carlsson.
3222
3223         WebKit2 already cleared application caches between runs (although it wasn't entirely
3224         effective without WebCore changes in this patch).
3225
3226         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
3227
3228         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
3229         function is not implemented on Windows, see below).
3230
3231         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
3232         Ameded a FIXME.
3233
3234 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
3235
3236         Generalize PageActivityAssertionToken
3237         https://bugs.webkit.org/show_bug.cgi?id=139106
3238
3239         Reviewed by Sam Weinig.
3240
3241         Add an API test for WTF::RefCounter.
3242
3243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3244         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
3245         (TestWebKitAPI::TEST):
3246             - added RefCounter test.
3247
3248 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3249
3250         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
3251         https://bugs.webkit.org/show_bug.cgi?id=139174
3252
3253         Reviewed by Simon Fraser.
3254
3255         * DumpRenderTree/TestRunner.cpp:
3256         * DumpRenderTree/TestRunner.h:
3257         Renamed testPathOrURL to testURL, because this variable always contains a URL.
3258
3259         * DumpRenderTree/mac/DumpRenderTree.mm:
3260         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
3261         (testPathFromURL): Moved from FrameLoadDelegate.mm.
3262         (runTest): Set crash reporter information here, as we know the exact test URL.
3263
3264         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3265         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
3266         reporter information here.
3267
3268         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3269         * DumpRenderTree/mac/TestRunnerMac.mm:
3270         Updated for testPathOrURL renaming.
3271
3272         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3273         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
3274         test URL until load starts, so save it into TestRunner now. A new TestRunner object
3275         is created for each test.
3276
3277         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3278         (WTR::TestRunner::testURL):
3279         (WTR::TestRunner::setTestURL):
3280         Make TestRunner know the test name. For now, it's good enough to have it once load
3281         starts, but if we ever need it earlier, we can send it with BeginTest message.
3282
3283         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3284         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3285         Use test URL, not currently loading URL for CrashReporter.
3286
3287         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3288         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
3289         (WebKit1 already had it right).
3290
3291         * DumpRenderTree/win/DumpRenderTree.cpp:
3292         (sizeWebViewForCurrentTest):
3293         (runTest):
3294         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3295         (ResourceLoadDelegate::willSendRequest):
3296         Changed Windows DumpRenderTree to also use URL in TestRunner.
3297
3298 2014-12-02  Daniel Bates  <dabates@apple.com>
3299
3300         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
3301         https://bugs.webkit.org/show_bug.cgi?id=139143
3302
3303         Reviewed by David Kilzer.
3304
3305         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
3306         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
3307         crashes. Run-webkit-tests will record as crashing the test associated with the
3308         DumpRenderTree instance that wrote that string.
3309
3310         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
3311         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
3312         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
3313         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
3314         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
3315         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
3316         about a crash.
3317
3318         Additionally, update the crash message format written to standard error when LayoutTestRelay
3319         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
3320         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
3321         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
3322         when they crash in their test machinery logic/UI process code.
3323
3324         * DumpRenderTree/mac/DumpRenderTree.mm:
3325         (writeCrashedMessageOnFatalError): Added.
3326         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
3327         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
3328         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3329         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
3330         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
3331         the crash logs for WebKitTestRunner/DumpRenderTree.app.
3332         * Scripts/webkitpy/port/driver.py:
3333         (Driver.__init__): Update comment.
3334         (Driver._check_for_driver_crash): Ditto.
3335         * Scripts/webkitpy/port/ios.py:
3336         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
3337         regular expression. This constant is used as an optimization to avoid compiling the same
3338         regular expression across invocations of _get_crash_log().
3339         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
3340         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
3341         closer to where they are used.
3342
3343 2014-12-01  Anders Carlsson  <andersca@apple.com>
3344
3345         Remove WKBundleRemoveAllVisitedLinks
3346         https://bugs.webkit.org/show_bug.cgi?id=139163
3347
3348         Reviewed by Sam Weinig.
3349
3350         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
3351
3352         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3353         (WTR::InjectedBundle::beginTesting):
3354         * WebKitTestRunner/TestInvocation.cpp:
3355         (WTR::TestInvocation::invoke):
3356
3357 2014-12-02  Anders Carlsson  <andersca@apple.com>
3358
3359         Fix Windows build.
3360
3361         * DumpRenderTree/win/DumpRenderTree.cpp:
3362         (setAlwaysAcceptCookies):
3363
3364 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3365
3366         [EFL] Remove edbus dependency from jhbuild
3367         https://bugs.webkit.org/show_bug.cgi?id=139130
3368
3369         Reviewed by Gyuyoung Kim.
3370
3371         After http://trac.webkit.org/changeset/176555 we
3372         don't need it anymore.
3373
3374         * efl/jhbuild.modules:
3375
3376 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3377
3378         [jhbuild] wrong Dependencies path
3379         https://bugs.webkit.org/show_bug.cgi?id=139176
3380
3381         Reviewed by Martin Robinson.
3382
3383         * Scripts/webkitpy/port/base.py:
3384         (Port._should_use_jhbuild):
3385
3386 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3387
3388         [GStreamer] Bump internal jhbuild versions to 1.4.4
3389         https://bugs.webkit.org/show_bug.cgi?id=138866
3390
3391         Reviewed by Carlos Garcia Campos.
3392
3393         * gtk/jhbuild.modules:
3394         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3395         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3396         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3397
3398 2014-12-01  Commit Queue  <commit-queue@webkit.org>
3399
3400         Unreviewed, rolling out r176566.
3401         https://bugs.webkit.org/show_bug.cgi?id=139124
3402
3403         It broke the GTK performance tests. (Requested by clopez on
3404         #webkit).
3405
3406         Reverted changeset:
3407
3408         "[GTK] Use GMainLoopSource in WebKitTestRunner"
3409         https://bugs.webkit.org/show_bug.cgi?id=138831
3410         http://trac.webkit.org/changeset/176566
3411
3412 2014-11-29  Anders Carlsson  <andersca@apple.com>
3413
3414         Crash when calling WKPageClose on the originated page from within createNewPage callback
3415         https://bugs.webkit.org/show_bug.cgi?id=139099
3416         <rdar://problem/19052564>
3417
3418         Reviewed by Sam Weinig.
3419
3420         Add a test.
3421
3422         * TestWebKitAPI/PlatformWebView.h:
3423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3424         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
3425         (TestWebKitAPI::runJavaScriptAlert):
3426         (TestWebKitAPI::createNewPage):
3427         (TestWebKitAPI::TEST):
3428         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
3429         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3430         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3431
3432 2014-11-28  Commit Queue  <commit-queue@webkit.org>
3433
3434         Unreviewed, rolling out r176564.
3435         https://bugs.webkit.org/show_bug.cgi?id=139093
3436
3437         massive failures on release test bot (Requested by philn on
3438         #webkit).
3439
3440         Reverted changeset:
3441
3442         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
3443         https://bugs.webkit.org/show_bug.cgi?id=138866
3444         http://trac.webkit.org/changeset/176564
3445
3446 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3447
3448         [GTK] Use GMainLoopSource in WebKitTestRunner
3449         https://bugs.webkit.org/show_bug.cgi?id=138831
3450
3451         Reviewed by Sergio Villar Senin.
3452
3453         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3454         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3455         (WTR::TestRunner::platformInitialize):
3456         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3457         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3458         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3459         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3460         (WTR::TestController::notifyDone):
3461         (WTR::TestController::platformRunUntil):
3462         (WTR::cancelTimeout): Deleted.
3463
3464 2014-11-24  Philippe Normand  <pnormand@igalia.com>
3465
3466         [GStreamer] Bump internal jhbuild versions to 1.4.4
3467         https://bugs.webkit.org/show_bug.cgi?id=138866
3468
3469         Reviewed by Carlos Garcia Campos.
3470
3471         * gtk/jhbuild.modules:
3472         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3473         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3474         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3475
3476 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3477
3478         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
3479         https://bugs.webkit.org/show_bug.cgi?id=138834
3480
3481         Reviewed by Sergio Villar Senin.
3482
3483         It makes everyting simpler and the tests run faster too, since we
3484         don't need to spawn the private bus and wait until the DBus name
3485         is registered. The web extension registers a new JavaSCript class
3486         with a status method to run the tests, similar to the DBus
3487         method. In the UI process side, tests use webkit_web_view_run_java_script()
3488         instead of sending a DBus message.
3489
3490         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3491         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3492         (WebKitDOMNodeFilterTest::create):
3493         (WebKitDOMNodeFilterTest::testTreeWalker):
3494         (WebKitDOMNodeFilterTest::testNodeIterator):
3495         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
3496         (WebKitDOMNodeFilterTest::runTest): Deleted.
3497         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3498         (WebKitDOMNodeTest::create):
3499         (WebKitDOMNodeTest::testHierarchyNavigation):
3500         (WebKitDOMNodeTest::testInsertion):
3501         (WebKitDOMNodeTest::testTagNames):
3502         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
3503         (WebKitDOMNodeTest::runTest): Deleted.
3504         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3505         (WebKitDOMXPathNSResolverTest::create):
3506         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3507         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3508         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
3509         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
3510         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3511         (WebKitFrameTest::create):
3512         (WebKitFrameTest::testMainFrame):
3513         (WebKitFrameTest::testURI):
3514         (WebKitFrameTest::testJavaScriptContext):
3515         (WebKitFrameTest::webPageFromArgs): Deleted.
3516         (WebKitFrameTest::runTest): Deleted.
3517         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3518         (testWebKitDOMNodeHierarchyNavigation):
3519         (testWebKitDOMNodeInsertion):
3520         (testWebKitDOMNodeTagNames):
3521         (beforeAll):
3522         (afterAll):
3523         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3524         (runTest):
3525         (beforeAll):
3526         (afterAll):
3527         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3528         (testWebKitDOMXPathNSResolverNative):
3529         (testWebKitDOMXPathNSResolverCustom):
3530         (beforeAll):
3531         (afterAll):
3532         (runTest): Deleted.
3533         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3534         (webkitFrameTestRun):
3535         (beforeAll):
3536         (afterAll):
3537         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3538         (testsMap):
3539         (WebProcessTest::add):
3540         (WebProcessTest::create):
3541         (runTest):
3542         (windowObjectClearedCallback):
3543         (webkit_web_extension_initialize):
3544         (methodCallCallback): Deleted.
3545         (webkit_web_extension_initialize_with_user_data): Deleted.
3546         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3547         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
3548         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
3549         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3550         (WebViewTest::runWebProcessTest):
3551         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3552
3553 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
3554
3555         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
3556         https://bugs.webkit.org/show_bug.cgi?id=139086
3557
3558         Reviewed by Gyuyoung Kim.
3559
3560         * efl/jhbuild.modules:
3561         * efl/patches/libseccomp-pick-up-CC.patch: Added.
3562
3563 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
3564
3565         [EFL] Add warning if CMake version is too old for building with ninja.
3566         https://bugs.webkit.org/show_bug.cgi?id=139055
3567
3568         Reviewed by Gyuyoung Kim.
3569
3570         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
3571         that version in their repositories.
3572
3573         * efl/install-dependencies:
3574
3575 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
3576
3577         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
3578         https://bugs.webkit.org/show_bug.cgi?id=139044
3579
3580         Reviewed by Chris Fleizach.
3581
3582         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
3583         The proposed solution will enable the use of this method for the object table.
3584         Existing test shows the result.
3585
3586         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3587         (WTR::AccessibilityUIElement::columnHeaders):
3588
3589 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
3590
3591         [EFL] Remove E_Dbus dependency
3592         https://bugs.webkit.org/show_bug.cgi?id=136355
3593
3594         Reviewed by Gyuyoung Kim.
3595
3596         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
3597
3598 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
3599
3600         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
3601         https://bugs.webkit.org/show_bug.cgi?id=139047
3602
3603         Reviewed by Carlos Garcia Campos.
3604
3605         * efl/jhbuild.modules:
3606         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3607         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3608         * gtk/jhbuild-optional.modules:
3609         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
3610         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
3611
3612 2014-11-25  Tanay C  <tanay.c@samsung.com>
3613
3614         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
3615         https://bugs.webkit.org/show_bug.cgi?id=138090
3616
3617         Reviewed by Carlos Garcia Campos.
3618
3619         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
3620         (browserWindowZoomIn): Added.
3621         (browserWindowZoomOut): Added.
3622         (scrollEventCallback): Added.
3623         (zoomInCallback): Modified.
3624         (zoomOutCallback): Modified.
3625         (browserWindowConstructed): Modified.
3626
3627 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
3628
3629         [EFL] REGRESSION(r176514): It made performance tests fail
3630         https://bugs.webkit.org/show_bug.cgi?id=139037
3631
3632         Reviewed by Gyuyoung Kim.
3633
3634         * Scripts/webkitpy/port/efl.py:
3635         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
3636         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
3637         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
3638
3639 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3640
3641         [GTK] update-webkitgtk-libs fails to build fontconfig
3642         https://bugs.webkit.org/show_bug.cgi?id=139032
3643
3644         Reviewed by Martin Robinson.
3645
3646         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
3647         fontconfig will try to generate documentation and fail.
3648
3649         * gtk/install-dependencies:
3650
3651 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         Unreviewed. Fix GTK+ make distcheck.
3654
3655         * gtk/manifest.txt: Remove deleted files.
3656
3657 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
3658
3659         [EFL] Utilize Eail library to support accessibility in EFL
3660         https://bugs.webkit.org/show_bug.cgi?id=137742
3661
3662         Reviewed by Gyuyoung Kim.
3663
3664         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
3665
3666         * efl/jhbuild-optional.modules: Added.
3667         * efl/jhbuild.modules:
3668
3669 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3670
3671         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
3672         https://bugs.webkit.org/show_bug.cgi?id=139023
3673
3674         Reviewed by Sergio Villar Senin.
3675
3676         Rename WebKitWebView/default-context as WebKitWebView/web-context
3677         and check we are always using the right context for new web views.
3678
3679         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3680         (testWebViewWebContext):
3681         (beforeAll):
3682         (testWebViewDefaultContext): Deleted.
3683
3684 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3685
3686         [GTK] Add API to override the default local storage directory
3687         https://bugs.webkit.org/show_bug.cgi?id=138828
3688
3689         Reviewed by Gustavo Noronha Silva.
3690
3691         Add test to check that the local storage directory is created at
3692         the path given on construction.
3693
3694         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3695         (testWebContextConfiguration):
3696         (beforeAll):
3697         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3698         (Test::Test):
3699         (Test::~Test): Deleted.
3700
3701 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3702
3703         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
3704         https://bugs.webkit.org/show_bug.cgi?id=138981
3705
3706         Reviewed by Simon Fraser.
3707
3708         * MiniBrowser/mac/SettingsController.h:
3709         * MiniBrowser/mac/SettingsController.m:
3710         (-[SettingsController _populateMenu]):
3711         (-[SettingsController validateMenuItem:]):
3712         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
3713         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
3714         * MiniBrowser/mac/WK1BrowserWindowController.m:
3715         (-[WK1BrowserWindowController didChangeSettings]):
3716         * MiniBrowser/mac/WK2BrowserWindowController.m:
3717         (-[WK2BrowserWindowController didChangeSettings]):
3718
3719 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
3720
3721         Remove http lock code from webkitperl
3722         https://bugs.webkit.org/show_bug.cgi?id=138959
3723
3724         Reviewed by Alexey Proskuryakov.
3725
3726         * Scripts/webkitperl/httpd.pm:
3727         (cleanUp):
3728         (extractLockNumber): Deleted.
3729         (getLockFiles): Deleted.
3730         (getNextAvailableLockNumber): Deleted.
3731         (getLockNumberForCurrentRunning): Deleted.
3732         (waitForHTTPDLock): Deleted.
3733         (scheduleHttpTesting): Deleted.
3734         (getWaitTime): Deleted.
3735
3736 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
3737
3738         [EFL] The option value of fixed layout is false in MiniBrowser
3739         https://bugs.webkit.org/show_bug.cgi?id=138830
3740
3741         Reviewed by Gyuyoung Kim.
3742
3743         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
3744
3745         * MiniBrowser/efl/main.c:
3746
3747 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
3748
3749         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
3750         https://bugs.webkit.org/show_bug.cgi?id=138871
3751
3752         Reviewed by Carlos Garcia Campos.
3753
3754         Add a test case for the convenience API for posting user messages
3755         added to the DOM bindings.
3756
3757         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3758         (testUserContentManagerMessageFromConvenienceDOMBindings):
3759         (beforeAll):
3760         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3761         (documentLoadedCallback):
3762
3763 2014-11-19  Dana Burkart  <dburkart@apple.com>
3764
3765         Work around the fact that different masters may have different names for their codebases.
3766         https://bugs.webkit.org/show_bug.cgi?id=138878
3767
3768         Reviewed by Mark Rowe.
3769
3770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3771         (parseRevisionProperty): Changed.
3772         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
3773         opensource / internal codebase naming convention.
3774
3775 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
3776
3777         AX: Screen braille input doesn't work on forms.
3778         https://bugs.webkit.org/show_bug.cgi?id=138804
3779
3780         Unreviewed build fix.
3781
3782         * DumpRenderTree/AccessibilityUIElement.cpp:
3783         (AccessibilityUIElement::setValue):
3784
3785 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
3786
3787         AX: Screen braille input doesn't work on forms.
3788         https://bugs.webkit.org/show_bug.cgi?id=138804
3789
3790         Reviewed by Mario Sanchez Prada.
3791
3792         Add a method to setValue through the AX API in DRT.
3793
3794         * DumpRenderTree/AccessibilityUIElement.cpp:
3795         (setValueCallback):
3796         (AccessibilityUIElement::getJSClass):
3797         * DumpRenderTree/AccessibilityUIElement.h:
3798         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3799         (AccessibilityUIElement::setValue):
3800         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3801         (AccessibilityUIElement::setValue):
3802
3803 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
3804
3805         Remove the WinCairo buildbot
3806         https://bugs.webkit.org/show_bug.cgi?id=138805
3807
3808         Reviewed by Alex Christensen.
3809
3810         * BuildSlaveSupport/build.webkit.org-config/config.json:
3811         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3812         (appendCustomBuildFlags):
3813         * BuildSlaveSupport/test-result-archive:
3814         (archiveTestResults):
3815
3816 2014-11-18  Daniel Bates  <dabates@apple.com>
3817
3818         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3819         SPI are not available in public SDK
3820         https://bugs.webkit.org/show_bug.cgi?id=138802
3821
3822         Reviewed by David Kilzer.
3823
3824         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
3825
3826         * DumpRenderTree/mac/CheckedMalloc.cpp:
3827
3828 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3829
3830         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
3831
3832         Forgot to fix this test before landing.
3833
3834         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3835         (testWebViewDefaultContext):
3836
3837 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3838
3839         [GTK] Add API to create a WebKitWebContext
3840         https://bugs.webkit.org/show_bug.cgi?id=138826
3841
3842         Reviewed by Gustavo Noronha Silva.
3843
3844         Use a different WebKitWebContext for every test to ensure test
3845         cases are independent to each other. Tests using DBus to
3846         communicate with the injected bundle extension now use a unique
3847         name for the well known DBus name.
3848
3849         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3850         (beforeAll): Remove comment about the order of the tests and
3851         move the success test before the failed one now that tests don't
3852         depend on each others.
3853         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3854         (beforeAll): Remove call to set the web extensions directory,
3855         since this is now done for all test in the Test constructor.
3856         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
3857         (beforeAll): Do not create a temporary directory, a temporary data
3858         directory is now created for all tests.
3859         (afterAll):
3860         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3861         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
3862         to the web process test runner.
3863         (testWebKitDOMNodeInsertion): Ditto.
3864         (testWebKitDOMNodeTagNames): Ditto.
3865         (beforeAll): Remove call to set the web extensions directory.
3866         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3867         (runTest): Pass the web extension ID to the web process test runner.
3868         (beforeAll): Remove call to set the web extensions directory.
3869         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3870         (runTest): Pass the web extension ID to the web process test runner.
3871         (beforeAll): Remove call to set the web extensions directory.
3872         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3873         (createFileAtDestination): Use Test::dataDirectory() as base dir
3874         for temporary files.
3875         (beforeAll): Do not create a temporary directory.
3876         (afterAll):
3877         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3878         (webkitFrameTestRun): Pass the web extension ID to the web process
3879         test runner.
3880         (beforeAll): Remove call to set the web extensions directory.
3881         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3882         (beforeAll): Remove call to set the web extensions directory.
3883         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3884         (testProcessPerWebView): Use local member instead of global variable.
3885         (testMultiprocessWebViewCreateReadyClose): Ditto.
3886         (beforeAll): Do not connect to initialize-web-extensions, Test now
3887         connects to the signal for all tests and calls a virtual method
3888         that test can override.
3889         (afterAll):
3890         (initializeWebExtensions): Deleted.
3891         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3892         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
3893         for temporary files.
3894         (beforeAll): Do not create a temporary directory.
3895         (afterAll):
3896         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3897         (beforeAll): Remove call to set the web extensions directory.
3898         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3899         (beforeAll): Remove comment about the tests order.
3900         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3901         (testWebExtensionGetTitle): Build the DBus service name using the
3902         web extension ID.
3903         (testDocumentLoadedSignal): Ditto.
3904         (testWebKitWebViewProcessCrashed): Ditto.
3905         (testWebExtensionIsolatedWorld): Ditto.
3906         (beforeAll): Remove initialization-user-data test, since now all
3907         tests are passing user data to the web extension.
3908         (testWebExtensionInitializationUserData): Deleted.
3909         (initializeWebExtensions): Deleted.
3910         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3911         (testSetDirectory): Use the web context member inherited from Test.
3912         (testClearDatabase): Ditto.
3913         (testGetFaviconURI): Ditto.
3914         (beforeAll): Do not create a temporary directory.
3915         (afterAll):
3916         (webkitFaviconDatabaseFinalizedCallback): Deleted.
3917         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3918         (UserContentManagerTest::UserContentManagerTest):
3919         (beforeAll): Remove call to set the web extensions directory.
3920         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3921         (testWebContextDefault): Check also that a newly create web
3922         context is not the default web context.
3923         (testWebContextSpellChecker): Use the web context member inherited
3924         from Test.
3925         (testWebContextLanguages): Ditto.
3926         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3927         (methodCallCallback): Remove GetInitializationUserData method.
3928         (webkit_web_extension_initialize_with_user_data): Always create
3929         the DBus name using the user data provided.
3930         (makeBusName): Deleted.
3931         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3932         (webkit_web_extension_initialize_with_user_data): Create the DBus
3933         name using the user data provided.
3934         (webkit_web_extension_initialize): Deleted.
3935         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3936         (Test::dataDirectory): Return the temporary data directory.
3937         (removeNonEmptyDirectory): Also remove directories recursively.
3938         (main): Remove the disk cache directory initialization, since this
3939         is now done in the Test constructor.
3940         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3941         (Test::initializeWebExtensionsCallback): Call the virtual method
3942         initializeWebExtensions()
3943         (Test::Test): Create a new WebKitWebContext and initialize it.
3944         (Test::~Test): Disconnect initialize-web-extensions signal.
3945         (Test::initializeWebExtensions): Set the web extensions directory
3946         and user data.
3947         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
3948         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
3949         (WebProcessTestRunner::runTest): Build the DBus proxy using a
3950         unique name created with the Test web extension ID.
3951         (WebProcessTestRunner::proxy): Deleted.
3952         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
3953         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3954         (WebViewTest::WebViewTest): Create the web view with the Test web
3955         context.
3956         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
3957         content manager parameter to the constructor.
3958
3959 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
3960
3961         [GTK] Mesa build fails over llvm-3.5
3962         https://bugs.webkit.org/show_bug.cgi?id=138825
3963
3964         Reviewed by Gustavo Noronha Silva.
3965
3966         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
3967
3968         * gtk/jhbuild.modules:
3969         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
3970
3971 2014-11-17  Daniel Bates  <dabates@apple.com>
3972
3973         Unreviewed, rolling out r176232.
3974
3975         Broke the Mac build. Will investigate offline.
3976
3977         Reverted changeset:
3978
3979         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
3980         MobileGestalt"
3981         https://bugs.webkit.org/show_bug.cgi?id=138802
3982         http://trac.webkit.org/changeset/176232
3983
3984 2014-11-17  Daniel Bates  <dabates@apple.com>
3985
3986         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
3987         SPI are not available in public SDK
3988         https://bugs.webkit.org/show_bug.cgi?id=138802
3989
3990         Reviewed by David Kilzer.
3991
3992         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
3993
3994         * DumpRenderTree/mac/CheckedMalloc.cpp:
3995
3996 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
3997
3998         Having 30+ flaky failures breaks EWS
3999         https://bugs.webkit.org/show_bug.cgi?id=138743
4000
4001         Reviewed by Alexey Proskuryakov.
4002
4003         Adds tests to ensure that the problem has been solved.
4004         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4005         (test_first_failure_limit):
4006         (test_first_failure_limit_with_some_tree_redness):
4007         (test_second_failure_limit):
4008         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
4009         (test_first_and_second_failure_limit):
4010         (test_first_and_clean_failure_limit):
4011         (test_first_second_and_clean_failure_limit):
4012         (test_very_red_tree_retry): Deleted.
4013         Really this was renamed to test_first_second_and_clean_failure_limit.
4014         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4015         Makes the appropriate changes to PatchAnalysisTask to make sure that
4016         even when the first test run hits the failure limit, it will still try
4017         a second run.
4018         (PatchAnalysisTask._results_failed_different_tests):
4019         (PatchAnalysisTask._test_patch):
4020         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
4021
4022 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
4023
4024         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
4025         https://bugs.webkit.org/show_bug.cgi?id=136018
4026
4027         Reviewed by Carlos Garcia Campos.
4028
4029         It is possible that the order of -L arguments in the output of
4030         pkg-config is wrong, which causes the linker to find the wrong
4031         version (usually older version) of libraries when running
4032         gtkdoc-scangobj.
4033
4034         * gtk/gtkdoc.py:
4035         (GTKDoc._run_gtkdoc_scangobj):
4036
4037 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4038
4039         Bump EFL version to 1.12.0
4040         https://bugs.webkit.org/show_bug.cgi?id=138733
4041
4042         Reviewed by Gyuyoung Kim.
4043
4044         * efl/jhbuild.modules:
4045
4046 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
4047
4048         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
4049         https://bugs.webkit.org/show_bug.cgi?id=138771
4050
4051         Reviewed by Chris Fleizach.
4052
4053         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
4054
4055         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4056
4057 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
4058
4059         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
4060         https://bugs.webkit.org/show_bug.cgi?id=138767
4061
4062         Reviewed by Chris Fleizach.
4063
4064         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
4065
4066         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4067
4068 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
4069
4070         Add shortcut macros to Mac TestExpectations
4071         https://bugs.webkit.org/show_bug.cgi?id=138729
4072
4073         Reviewed by Simon Fraser.
4074
4075         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
4076         Add version macros for current OS versions.
4077
4078 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
4079
4080         https://bugs.webkit.org/show_bug.cgi?id=138628
4081         A patch that doesn't apply is stuck in commit queue
4082
4083         Rubber-stamped by David Kilzer.
4084
4085         This also hopefully fixes other issues:
4086         - a patch that has cq+ flag set by a non-committer kills commit queue;
4087         - EWS never reports failing tests, and keeps spinning instead.
4088
4089         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4090         (Bugzilla.set_flag_on_attachment):
4091         (Bugzilla.obsolete_attachment):
4092         Apply the fix from r174797 to more places.
4093
4094 2014-11-13  Dan Bernstein  <mitz@apple.com>
4095
4096         Policy client not called for navigations through the page cache
4097         https://bugs.webkit.org/show_bug.cgi?id=138703
4098
4099         Reviewed by Alexey Proskuryakov.
4100
4101         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
4102         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
4103         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4104
4105 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
4106
4107         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
4108         https://bugs.webkit.org/show_bug.cgi?id=137867
4109
4110         Reviewed by Chris Fleizach.
4111
4112         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
4113         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
4114         able to test for the presence of ATK_ROLE_INVALID.
4115
4116         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4117         (WTR::AccessibilityUIElement::role):
4118
4119 2014-11-13  Juergen Ributzka  <juergen@apple.com>
4120
4121         Update the "combineModules" script to handel more LLVM metadata.
4122         https://bugs.webkit.org/show_bug.cgi?id=138514
4123
4124         Reviewed by Filip Pizlo.
4125
4126         * ReducedFTL/combineModules.rb:
4127
4128 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
4129
4130         Allow constructing a base PassRef with a derived Ref
4131         https://bugs.webkit.org/show_bug.cgi?id=138701
4132
4133         Reviewed by Andreas Kling
4134
4135         * TestWebKitAPI/Tests/WTF/Ref.cpp:
4136         (TestWebKitAPI::passWithPassRef):
4137         (TestWebKitAPI::passWithPassRefPtr):
4138         (TestWebKitAPI::TEST):
4139
4140 2014-11-05  Ada Chan  <adachan@apple.com>
4141
4142         Implement new plug-in API for muting plug-ins
4143         https://bugs.webkit.org/show_bug.cgi?id=138105
4144
4145         Reviewed by Anders Carlsson.
4146
4147         Add a new plug-in test for the mute API.
4148
4149         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4150         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
4151         (SetMuted::SetMuted):
4152         (SetMuted::isMuted):
4153         (SetMuted::cachedIsMuted):
4154         (SetMuted::ScriptableObject::hasProperty):
4155         (SetMuted::ScriptableObject::getProperty):
4156         (SetMuted::ScriptableObject::pluginTest):
4157         (SetMuted::NPP_New):
4158         (SetMuted::NPP_GetValue):
4159         (SetMuted::NPP_SetValue):
4160
4161 2014-11-12  Philippe Normand  <pnormand@igalia.com>
4162
4163         Unreviewed, GTK gardening.
4164
4165         * Scripts/run-gtk-tests:
4166         (TestRunner): Skip the UserMediaBasic test because it depends on
4167         constraints validation which is going to be fixed in bug #136449.
4168
4169 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4170
4171         [GTK] Expose user script messages to GObject DOM bindings
4172         https://bugs.webkit.org/show_bug.cgi?id=138411
4173
4174         Reviewed by Philippe Normand.
4175
4176         Add a test case to check that user script messages sent using the
4177         DOM bindings API are also received in the UI process.
4178
4179         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
4180         (UserScriptMessageTest::waitUntilMessageReceived):
4181         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
4182         (testUserContentManagerScriptMessageFromDOMBindings):
4183         (beforeAll):
4184         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
4185         (documentLoadedCallback):
4186
4187 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4188
4189         Unreviewed. Fix GTK+ clean build after r175930.
4190
4191         Partial rollout of r175930 to not build the new unit test that
4192         broke clean builds in GTK+ port.
4193
4194         * TestWebKitAPI/PlatformGTK.cmake:
4195
4196 2014-09-01  Philippe Normand  <pnormand@igalia.com>
4197
4198         [WK2] UserMediaClient support
4199         https://bugs.webkit.org/show_bug.cgi?id=123158
4200
4201         Reviewed by Benjamin Poulain.
4202
4203         Simple API test for the UserMedia permission request API. The
4204         required test infrastructure is also added, inspired by the
4205         Geolocation infrastructure.
4206
4207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
4208         Permission request.
4209         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
4210         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
4211         (TestWebKitAPI::TEST):
4212         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
4213         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
4214         helper method to set the permission request result without user interaction.
4215         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
4216         (WTR::InjectedBundle::setUserMediaPermission):
4217         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
4218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
4219         (WTR::TestRunner::setUserMediaPermission):
4220         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
4221         * WebKitTestRunner/TestController.cpp:
4222         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
4223         request handler.
4224         (WTR::TestController::createOtherPage): Enable the new UserMedia
4225         permission request handler.
4226         (WTR::TestController::createWebViewWithOptions): Ditto.
4227         (WTR::TestController::resetPreferencesToConsistentValues): Enable
4228         MediaStream support, this is needed for getUserMedia.
4229         (WTR::TestController::resetStateToConsistentValues): clear
4230         UserMedia permissions list and flags.
4231         (WTR::TestController::setUserMediaPermission): Set permission
4232         request result and distpatch it.
4233         (WTR::TestController::handleUserMediaPermissionRequest): Save
4234         request and dispatch it.
4235         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
4236         Dispatch cached permission requests.
4237         * WebKitTestRunner/TestController.h:
4238         * WebKitTestRunner/TestInvocation.cpp:
4239         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4240
4241 2014-11-11  David Kilzer  <ddkilzer@apple.com>
4242
4243         webkit-patch --suggest-reviewers is broken with newer versions of git
4244         <http://webkit.org/b/138627>
4245
4246         Reviewed by Michael Saboff with feedback from Daniel Bates.
4247
4248         * Scripts/webkitpy/common/checkout/scm/git.py:
4249         (Git._changes_files_for_commit): Strip blank lines instead of
4250         assuming there is always a blank line at the beginning of the
4251         list.
4252
4253 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
4254
4255         DRT and WKTR touch disk cache
4256         https://bugs.webkit.org/show_bug.cgi?id=138622
4257
4258         Reviewed by Geoffrey Garen.
4259
4260         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
4261         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
4262         because this function uses the shared cache.
4263
4264         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
4265         Create an empty shared cache to prevent a default one from being created on disk.
4266
4267 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
4268
4269         [CSS Grid Layout] Limit the size of explicit/implicit grid
4270         https://bugs.webkit.org/show_bug.cgi?id=136217
4271
4272         Reviewed by Andreas Kling.
4273
4274         Added a new unit test for the CSS parser. Right now it only checks
4275         that we properly clamp the maximum number of tracks on a grid to a
4276         maximum of 1 million.
4277
4278         * TestWebKitAPI/CMakeLists.txt:
4279         * TestWebKitAPI/PlatformEfl.cmake:
4280         * TestWebKitAPI/PlatformGTK.cmake:
4281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4282         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.