3b30143c1d453e2aef685e3c8e1ff57428369a56
[WebKit-https.git] / Tools / ChangeLog
1 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
4         https://bugs.webkit.org/show_bug.cgi?id=142083
5
6         Reviewed by Simon Fraser.
7
8         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
9
10         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
11         (WebPlatformTestServer._copy_webkit_test_files):
12
13 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
14
15         setup-git-clone fails due to the failure to download python-irclib-0.4.8
16         https://bugs.webkit.org/show_bug.cgi?id=141946
17
18         Reviewed by Ryosuke Niwa.
19
20         Check in ircbot.py and irclib.py to avoid network problems in the future.
21
22         * Scripts/webkitpy/common/net/irc/ircbot.py:
23         * Scripts/webkitpy/thirdparty/__init__.py:
24         (AutoinstallImportHook.find_module):
25         (AutoinstallImportHook._install_irc): Deleted.
26         * Scripts/webkitpy/thirdparty/__init___unittest.py:
27         (ThirdpartyTest.test_imports):
28         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
29         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
30         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
31
32 2015-03-06  David Kilzer  <ddkilzer@apple.com>
33
34         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
35
36         See also fix to config.json in r181097.
37
38         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
39         (WebKitBuildbot): Add missing "WK2" to the names of the perf
40         bots.
41
42 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
43
44         run-jsc-stress-tests should determine the architecture from ELF binaries
45         https://bugs.webkit.org/show_bug.cgi?id=142335
46
47         Reviewed by Darin Adler.
48
49         * Scripts/run-jsc-stress-tests:
50
51 2015-03-05  David Kilzer  <ddkilzer@apple.com>
52
53         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
54         <http://webkit.org/b/142226>
55
56         Reviewed by Darin Adler.
57
58         * Scripts/webkitpy/port/ios.py:
59         (IOSSimulatorPort.default_baseline_search_path): Switch the
60         TestExpectations order of ios-simulator-wk2 from this:
61           ios-simulator-wk2, wk2, ios-simulator
62         To this:
63           ios-simulator-wk2, ios-simualtor, wk2
64
65 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
66
67         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
68         https://bugs.webkit.org/show_bug.cgi?id=142370
69
70         Reviewed by Dean Jackson.
71
72         * Scripts/webkitdirs.pm:
73         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
74         logs, one for warnings, the other for errors.
75         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
76         into the standard BuildOutput.htm document.
77
78 2015-03-05  David Kilzer  <ddkilzer@apple.com>
79
80         Dashboard has trouble parsing iOS test output
81         <http://webkit.org/b/142364>
82
83         Reviewed by Alex Christensen.
84
85         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
86         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
87         Add fallback path to build a regex using 'matchString' so that
88         it matches anywhere in the line.  In practice, 'matchString' is
89         a prefix for the label following the number.
90
91 2015-03-05  Alex Christensen  <achristensen@webkit.org>
92
93         Fix linker warnings in TestWebKitAPI.
94         https://bugs.webkit.org/show_bug.cgi?id=141912
95
96         Reviewed by David Kilzer.
97
98         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
99         Do not export TearDownTestCase or SetUpTestCase symbols.
100
101 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
102
103         [Win] Unreviewed EWS fix.
104
105         * Scripts/webkitdirs.pm:
106         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
107         the EWS output more usable.
108
109 2015-03-05  Chris Dumez  <cdumez@apple.com>
110
111         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
112         https://bugs.webkit.org/show_bug.cgi?id=142350
113
114         Reviewed by Michael Saboff and Benjamin Poulain.
115
116         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
117         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
118
119         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
120         (TestWebKitAPI::TEST):
121
122 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
123
124         [Win] Ensure build target directory exists when launching MSBuild
125         https://bugs.webkit.org/show_bug.cgi?id=142360
126
127         Reviewed by Dean Jackson.
128
129         Create the build output directory (if it doesn't exist) before
130         launching MSBuild so that it can immediately begin writing logs.
131
132         * Scripts/webkitdirs.pm:
133         (buildVisualStudioProject):
134
135 2015-03-05  Chris Dumez  <cdumez@apple.com>
136
137         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
138         https://bugs.webkit.org/show_bug.cgi?id=142325
139
140         Reviewed by Csaba Osztrogonác.
141
142         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
143         As a result, "--webkit-test-runner / -2" parameters are replaced by
144         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
145         than WebKitTestRunner.
146
147         * BuildSlaveSupport/build.webkit.org-config/config.json:
148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
149         (RunWebKit1Tests):
150         (RunWebKit1Tests.start):
151         (RunWebKit1LeakTests):
152         (RunWebKit1LeakTests.start):
153         (RunAndUploadPerfTestsWebKit1):
154         (RunAndUploadPerfTestsWebKit1.start):
155         (TestFactory):
156         (TestWebKit1LeaksFactory):
157         (TestWebKit1LeaksFactory.__init__):
158         (TestWebKit1Factory):
159         (TestWebKit1AllButJSCFactory):
160         (TestAllButJSCFactory):
161         (BuildAndPerfTestWebKit1Factory):
162         (BuildAndPerfTestWebKit1Factory.__init__):
163         (BuildAndPerfTestFactory):
164         (BuildAndPerfTestFactory.__init__):
165         (DownloadAndPerfTestWebKit1Factory):
166         (DownloadAndPerfTestWebKit1Factory.__init__):
167         (DownloadAndPerfTestFactory):
168         (DownloadAndPerfTestFactory.__init__):
169         (RunWebKitLeakTests): Deleted.
170         (RunWebKitLeakTests.start): Deleted.
171         (RunWebKit2Tests): Deleted.
172         (RunWebKit2Tests.start): Deleted.
173         (RunAndUploadPerfTestsWebKit2): Deleted.
174         (RunAndUploadPerfTestsWebKit2.start): Deleted.
175         (TestLeaksFactory): Deleted.
176         (TestLeaksFactory.__init__): Deleted.
177         (TestWebKit2Factory): Deleted.
178         (TestWebKit2AndJSCFactory): Deleted.
179         (BuildAndPerfTestWebKit2Factory): Deleted.
180         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
181         (DownloadAndPerfTestWebKit2Factory): Deleted.
182         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
184         (parse_args):
185         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
186         (PerfTestsRunner._parse_args):
187         * Scripts/webkitpy/port/port_testcase.py:
188         (PortTestCase.test_build_driver):
189
190 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
191
192         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
193         https://bugs.webkit.org/show_bug.cgi?id=140845
194
195         Reviewed by David Kilzer.
196
197         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
198         and generate suitable build commands to drive a full build from our
199         existing solution files.
200
201         * Scripts/webkitdirs.pm:
202         (msBuildInstallDir): Added.
203         (determineConfigurationForVisualStudio): Revise to use MSBuild command
204         line arguments to drive the build.
205         (setupCygwinEnv): Warn user if MSBuild cannot be located.
206         (buildVisualStudioProject): Revise to use MSBuild command line arguments
207         to specify build architecture.
208         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
209         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
210         bother looking for CoreUI or SafariTheme build logs.
211
212 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
213
214         [buildbot] mastercfg_unittest.py should be runnable easily
215         https://bugs.webkit.org/show_bug.cgi?id=142219
216
217         Reviewed by Chris Dumez.
218
219         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
220         the last Twisted version works together with this buildbot version.
221
222         * Scripts/webkitpy/common/system/autoinstall.py:
223         (AutoInstaller): Added prepend_to_search_path argument to be able
224         to prefer autoinstalled package to system package.
225         (AutoInstaller.__init__):
226         (AutoInstaller._set_up_target_dir):
227         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
228         (AutoInstaller._prepare_package):
229         (AutoInstaller._extract_targz): Renamed to _extract_tar.
230         * Scripts/webkitpy/thirdparty/__init__.py:
231         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
232
233 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
234
235         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
236         https://bugs.webkit.org/show_bug.cgi?id=131162
237
238         Reviewed by Gyuyoung Kim.
239
240         * MiniBrowser/efl/main.c:
241         (on_download_request):
242         (on_download_finished):
243         (on_download_failed):
244         (window_create):
245         Adapt download callbacks to new callback mechanism
246
247 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
248
249         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
250
251         In r180927 we updated the libsoup version used by the jhbuild. In
252         this new version the sniffer uses image/x-icon instead of
253         image/vnd.microsoft.icon for blank.ico resource.
254
255         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
256         (testWebResourceMimeType):
257
258 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
259
260         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
261         https://bugs.webkit.org/show_bug.cgi?id=142244
262
263         Reviewed by Sergio Villar Senin.
264
265         Check that the SSL server doesn't process any request in case of
266         TLS errors when the policy is set to FAIL.
267
268         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
269         (testTLSErrorsPolicy):
270         (testTLSErrorsRedirect):
271         (testTLSErrorsHTTPAuth):
272         (testLoadFailedWithTLSErrors):
273         (testSubresourceLoadFailedWithTLSErrors):
274         (httpsServerCallback):
275
276 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
277
278         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
279         https://bugs.webkit.org/show_bug.cgi?id=141154
280
281         Reviewed by Jer Noble.
282
283         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
284
285         For the sake of completeness WebKitTestRunner should specify temporary
286         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
287
288         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
289         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
290         to get data storage paths. Only Mac port has an actual implementation of it.
291         However, WebKitTestRunner overrides them in favour of unique temporary dir
292         which is taken from libraryPathForTesting().
293
294         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
295         is not implemented for EFL and GTK ports it returns an empty string.
296         All default data folders besides MediaKeys are overridden in TestRunner
297         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
298         env variable.
299
300         GTK port does not enable encrypted keys by default so
301         WebMediaKeyStorageManager::initialize() code path is never triggered.
302
303         * WebKitTestRunner/TestController.cpp:
304         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
305         WebKit ports.
306
307 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
308
309         [buildbot] Add regression test to check which builder runs which tests
310         https://bugs.webkit.org/show_bug.cgi?id=142166
311
312         Reviewed by Alexey Proskuryakov.
313
314         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
315         (BuildStepsConstructorTest.createTest):
316         (BuildStepsTest):
317         (BuildStepsTest.generateTests):
318         (BuildStepsTest.createTest):
319         (BuildStepsTest.createTest.doTest):
320         (BuildStepsTest.test_unnecessary_expected_results):
321
322 2015-03-04  Commit Queue  <commit-queue@webkit.org>
323
324         Unreviewed, rolling out r181054.
325         https://bugs.webkit.org/show_bug.cgi?id=142320
326
327         Broke the api tests (Requested by sundiamonde on #webkit).
328
329         Reverted changeset:
330
331         "Fix linker warnings in TestWebKitAPI."
332         https://bugs.webkit.org/show_bug.cgi?id=141912
333         http://trac.webkit.org/changeset/181054
334
335 2015-03-04  Alex Christensen  <achristensen@webkit.org>
336
337         Fix linker warnings in TestWebKitAPI.
338         https://bugs.webkit.org/show_bug.cgi?id=141912
339
340         Reviewed by David Kilzer.
341
342         * TestWebKitAPI/Configurations/Base.xcconfig:
343         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
344
345 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
346
347         [Mac] Set SystemUIFontSelect in DRT and WKTR
348         https://bugs.webkit.org/show_bug.cgi?id=142303
349
350         Reviewed by Myles C. Maxfield.
351
352         * DumpRenderTree/mac/DumpRenderTree.mm:
353         (setDefaultsToConsistentValuesForTesting):
354         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
355         (WTR::InjectedBundle::platformInitialize):
356
357 2015-03-04  Chris Dumez  <cdumez@apple.com>
358
359         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
360         https://bugs.webkit.org/show_bug.cgi?id=142314
361         <rdar://problem/20046835>
362
363         Reviewed by Ryosuke Niwa.
364
365         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
366         to get WK2 code coverage.
367
368         * BuildSlaveSupport/build.webkit.org-config/config.json:
369
370 2015-03-04  Alex Christensen  <achristensen@webkit.org>
371
372         Move content extensions test to properly named directory.
373         https://bugs.webkit.org/show_bug.cgi?id=142299
374
375         Reviewed by Tim Horton.
376
377         * WebKitTestRunner/mac/TestControllerMac.mm:
378         (WTR::TestController::platformConfigureViewForTest):
379
380 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
381
382         W3C test importer should use filesystem instead of os.walk
383         https://bugs.webkit.org/show_bug.cgi?id=142085
384
385         Reviewed by Bem Jones-Bey.
386
387         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
388         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
389         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
390
391         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
392         Added a unit test to check that test importer is now black-box testable using a Mock system.
393
394         * Scripts/webkitpy/common/system/filesystem.py:
395         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
396         (FileSystem.dirs_under.filter_all):
397         * Scripts/webkitpy/common/system/filesystem_mock.py:
398         (MockFileSystem.dirs_under):
399         (MockFileSystem.dirs_under.filter_all):
400         (MockFileSystem.getsize):
401         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
402         (MockFileSystemTest.test_dirs_under):
403         (MockFileSystemTest.test_dirs_under.filter_dir):
404         * Scripts/webkitpy/common/system/filesystem_unittest.py:
405         (RealFileSystemTest.test_sep):
406         (RealFileSystemTest):
407         (RealFileSystemTest.test_dirs_under):
408         (RealFileSystemTest.test_dirs_under.filter_this_dir):
409         * Scripts/webkitpy/w3c/test_importer.py:
410         (TestImporter.do_import):
411         (TestImporter.find_importable_tests.should_keep_subdir):
412         (TestImporter.find_importable_tests):
413         (TestImporter.should_keep_subdir): Deleted.
414         (TestImporter.should_skip_file): Deleted.
415         * Scripts/webkitpy/w3c/test_importer_unittest.py:
416         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
417
418 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
419
420         [WebEditingTester] Add support for the find and replace bar
421         https://bugs.webkit.org/show_bug.cgi?id=142247
422
423         Reviewed by Enrica Casucci.
424
425         While it's not hooked up yet in WKWebView, adding support for the
426         find bar to WebEditingTester will help us implement that functionality.
427
428         * WebEditingTester/AppDelegate.h:
429         * WebEditingTester/AppDelegate.m:
430         (-[WebEditingAppDelegate performTextFinderAction:]):
431         * WebEditingTester/MainMenu.xib:
432         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
433
434         * WebEditingTester/WK2WebDocumentController.m:
435         (-[WK2WebDocumentController awakeFromNib]):
436         (-[WK2WebDocumentController performTextFinderAction:]):
437         (-[WK2WebDocumentController findBarView]):
438         (-[WK2WebDocumentController setFindBarView:]):
439         (-[WK2WebDocumentController isFindBarVisible]):
440         (-[WK2WebDocumentController setFindBarVisible:]):
441         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
442         (-[WK2WebDocumentController layout]):
443         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
444         pointing at the WKWebView (currently nothing will work, but the bar will
445         show up). Install and uninstall the bar as needed.
446
447         * WebEditingTester/WebDocument.xib:
448         Don't use a full-size content view. There's no need, and it makes find
449         bar layout harder.
450
451         * WebEditingTester/WebDocumentController.h:
452         * WebEditingTester/WebDocumentController.m:
453         (-[WebDocumentController performTextFinderAction:]):
454
455 2015-03-03  Sam Weinig  <sam@webkit.org>
456
457         [Content Extensions] Split parsing and compiling of content extensions into their own files
458         https://bugs.webkit.org/show_bug.cgi?id=142259
459
460         Reviewed by Anders Carlsson.
461
462         Add basic unit test for the content filter compiler.
463
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
465         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
466         (WebCore::ContentExtensions::operator<<):
467         (TestWebKitAPI::ContentFilterTest::SetUp):
468         (TestWebKitAPI::TEST_F):
469
470 2015-03-04  Matthew Mirman  <mmirman@apple.com>
471
472         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
473         https://bugs.webkit.org/show_bug.cgi?id=142230
474
475         Reviewed by Csaba Osztrogonác.
476
477         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
478         (TestFactory):
479         (TestFactory.getProduct): Added
480         (TestFactory.__init__): moved downloader to getProduct
481         (BuildAndTestFactory):        
482         (BuildAndTestFactory.getProduct): Added
483         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
484         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
485
486 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
487
488         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
489         https://bugs.webkit.org/show_bug.cgi?id=142225
490
491         Reviewed by Carlos Garcia Campos.
492
493         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
494         (testWebViewWebContextLifetime):
495         (beforeAll):
496
497 2015-03-03  David Kilzer  <ddkilzer@apple.com>
498
499         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
500         <http://webkit.org/b/142243>
501
502         Reviewed by Alexey Proskuryakov.
503
504         * WebKitTestRunner/TestController.cpp:
505         (WTR::TestController::webProcessName):
506         (WTR::TestController::networkProcessName):
507         - Return the same process name on iOS and Mac because they both
508           use the same process name for local engineering builds.
509
510 2015-03-03  David Kilzer  <ddkilzer@apple.com>
511
512         check-webkit-style: Add exception for FrameworkSoftLink.h header order
513         <http://webkit.org/b/141872>
514
515         Reviewed by Alex Christensen.
516
517         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
518         semi-colons in various places and fix whitespace.
519         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
520         constants.
521         (_IncludeState.__init__): Add self._visited_soft_link_section
522         boolean state variable.
523         (_IncludeState.visited_soft_link_section): Getter for
524         self._visited_soft_link_section.
525         (_IncludeState.check_next_include_order): Update state machine
526         for soft-link headers.  Add check that soft-link headers always
527         appear last.
528         (_classify_include): Add check for soft-link header type.
529         (check_include_line): Return early if there is a soft-link
530         header error.
531
532         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
533         (OrderOfIncludesTest.test_public_primary_header): Add tests for
534         including soft-link headers.
535         (OrderOfIncludesTest.test_classify_include): Add test for
536         _SOFT_LINK_HEADER type.
537
538 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
539
540         build.webkit.org/dashboard: Don't repeatedly handle each test type
541         https://bugs.webkit.org/show_bug.cgi?id=142211
542
543         Reviewed by Tim Horton and Matt Hanson.
544
545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
546         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
547         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
548         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
549         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
550         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
551         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
552         Removed functions that build a link to test step results. The buildbot provides
553         these links in JSON.
554
555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
556         (BuildbotIteration): Put failing tests into an array, instead of named variables.
557         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
558         We can easily add them to the map as needed.
559         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
560         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
561         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
562         and then build a BuildbotTestResults object, which was strange.
563         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
564
565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
566         Corrected an unrelated assertion that was buggy, and kept firing.
567
568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
569         (BuildbotTestResults):
570         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
571         (BuildbotTestResults.prototype._parseResults):
572         (BuildbotTestResults.prototype.addFullLayoutTestResults):
573         Moved the code for parsing JSON results for a single step here.
574
575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
576         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
577         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
578         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
579         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
580         (BuildbotTesterQueueView.prototype.update): Deleted.
581         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
582         Updated for the new data structures. One behavior change is that we now display individual
583         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
584         test failures, 3 platform api test failures".
585
586 2015-03-03  Matthew Mirman  <mmirman@apple.com>
587
588         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
589         https://bugs.webkit.org/show_bug.cgi?id=142094
590
591         Reviewed by Csaba Osztrogonác.
592
593         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
595         (TestFactory):
596         (TestFactory.__init__): Made running of JSC tests conditional.
597         (TestAllButJSCFactory):
598         (TestJSCFactory): Added.
599         (TestJSCFactory.__init__):
600         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
601
602 2015-03-03  David Kilzer  <ddkilzer@apple.com>
603
604         `build-webkit --help` is wrong about how to build for the iOS simulator
605         <http://webkit.org/b/142223>
606
607         Reviewed by Csaba Osztrogonác.
608
609         * Scripts/build-webkit: Fix help.
610
611 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
612
613         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
614
615         * gtk/jhbuild.modules:
616
617 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
618
619         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
620         https://bugs.webkit.org/show_bug.cgi?id=141508
621
622         Reviewed by Sergio Villar Senin.
623
624         Add a unit test to check that synchronous XHRs load even if the
625         maximum connection limits are reached.
626
627         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
628         (testWebViewSyncRequestOnMaxConns):
629         (serverCallback):
630         (beforeAll):
631         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
632
633 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
634
635         Update the name of ASan build step.
636
637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
638
639 2015-03-02  Jer Noble  <jer.noble@apple.com>
640
641         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
642         https://bugs.webkit.org/show_bug.cgi?id=142121
643
644         Reviewed by Simon Fraser.
645
646         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
647         that the initial and final screen rects for the web content are as expected.
648
649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
650         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
651         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
652         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
653         (runJavaScriptAlert):
654         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
655         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
656         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
657         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
658         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
659         (TestWebKitAPI::TEST_F):
660
661 2015-03-01  David Kilzer  <ddkilzer@apple.com>
662
663         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
664
665         Follow-up fix for:
666
667         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
668         <http://webkit.org/b/142145>
669
670         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
671         (-[LTRelayController _environmentVariables]): Fix think-o.
672
673 2015-03-01  David Kilzer  <ddkilzer@apple.com>
674
675         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
676         <http://webkit.org/b/142145>
677
678         Reviewed by Simon Fraser.
679
680         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
681         (-[LTRelayController _environmentVariables]): Add.
682         (-[LTRelayController launchApp]): Use -_environmentVariables.
683
684 2015-02-28  David Kilzer  <ddkilzer@apple.com>
685
686         [iOS] Stop running webkit-build-directory on every layout test
687
688         This was originally fixed by David Farler for Bug 135409 in
689         r172602.
690
691         * Scripts/webkitpy/port/ios.py:
692         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
693         run webkit-build-directory every time it's called.
694
695 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
696
697         W3C importer should use filesystem instead of shutil/host
698         https://bugs.webkit.org/show_bug.cgi?id=142012
699
700         Reviewed by Bem Jones-Bey.
701
702         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
703
704         * Scripts/webkitpy/w3c/test_importer.py:
705         (main):
706         (TestImporter.do_import):
707         (TestImporter.find_importable_tests):
708         (TestImporter.import_tests):
709         (TestImporter.remove_deleted_files):
710         (TestImporter.write_import_log):
711
712 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
713
714         W3C test importer should use filesystem to read and write files
715         https://bugs.webkit.org/show_bug.cgi?id=142084
716
717         Reviewed by Bem Jones-Bey.
718
719         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
720
721         * Scripts/webkitpy/w3c/test_importer.py:
722         (TestImporter.import_tests):
723         (TestImporter.remove_deleted_files):
724         (TestImporter.write_import_log):
725
726 2015-02-27  Sam Weinig  <sam@webkit.org>
727
728         Add WebKit2 SPI to create a DOM File object
729         https://bugs.webkit.org/show_bug.cgi?id=142109
730
731         Reviewed by Tim Horton.
732
733         Add a test for WKBundleFileHandleRef.
734
735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
736         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
737         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
738         (TestWebKitAPI::didFinishLoadForFrame):
739         (TestWebKitAPI::TEST):
740         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
741         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
742         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
743
744 2015-02-27  Michael Saboff  <msaboff@apple.com>
745
746         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
747         https://bugs.webkit.org/show_bug.cgi?id=142112
748
749         Reviewed by Filip Pizlo.
750
751         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
752         <someDir> as the library path.
753
754         * Scripts/run-jsc-benchmarks:
755
756 2015-02-27  Alex Christensen  <achristensen@webkit.org>
757
758         [WinCairo] Unreviewed build fix.
759
760         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
761         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
762
763 2015-02-27  Anders Carlsson  <andersca@apple.com>
764
765         Add infrastructure for handling website data in the network process
766         https://bugs.webkit.org/show_bug.cgi?id=142092
767
768         Reviewed by Andreas Kling.
769
770         Add a menu item that will fetch all website data, delete the returned data records, and
771         fetch all website data again so we can confirm that it's all empty.
772
773         * MiniBrowser/mac/WK2BrowserWindowController.m:
774         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
775
776 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
777
778         [Win] Remove remaining SafariTheme cruft
779         https://bugs.webkit.org/show_bug.cgi?id=142075
780
781         Reviewed by Anders Carlsson.
782
783         Remove reference to SafariTheme-switching preference.
784
785         * DumpRenderTree/win/DumpRenderTree.cpp:
786         (resetWebPreferencesToConsistentValues):
787         (prepareConsistentTestingEnvironment):
788
789 2015-02-26  Doug Russell  <d_russell@apple.com>
790
791         AX: Expose caret browsing preference to accessibility API
792         https://bugs.webkit.org/show_bug.cgi?id=141862
793
794         Reviewed by Chris Fleizach.
795
796         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
797         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
798
799         * DumpRenderTree/AccessibilityUIElement.cpp:
800         (setBoolAttributeValueCallback):
801         (selectedTextMarkerRangeCallback):
802         (resetSelectedTextMarkerRangeCallback):
803         (AccessibilityUIElement::setBoolAttributeValue):
804         (AccessibilityUIElement::selectedTextMarkerRange):
805         (AccessibilityUIElement::resetSelectedTextMarkerRange):
806         (AccessibilityUIElement::getJSClass):
807         * DumpRenderTree/AccessibilityUIElement.h:
808         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
809         (AccessibilityUIElement::setBoolAttributeValue):
810         (AccessibilityUIElement::selectedTextMarkerRange):
811         (AccessibilityUIElement::resetSelectedTextMarkerRange):
812         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
813         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
814         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
815         (WTR::AccessibilityUIElement::setBoolAttributeValue):
816         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
817         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
818         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
819         (WTR::AccessibilityUIElement::setBoolAttributeValue):
820         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
821         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
822
823 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
824
825         [Win] Remove WebKitExportGenerator project (and related)
826         https://bugs.webkit.org/show_bug.cgi?id=142035
827
828         Reviewed by Dean Jackson.
829
830         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
831         build log from WebKitExportGenerator.
832
833 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
834
835         [EFL] Bump EFL version to 1.13.0
836         https://bugs.webkit.org/show_bug.cgi?id=141708
837
838         Reviewed by Gyuyoung Kim.
839
840         * efl/jhbuild.modules:
841
842 2015-02-26  Sam Weinig  <sam@webkit.org>
843
844         Check in missing WebEditingTester.xcconfig file.
845
846         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
847
848 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
849
850         [webkitpy] Remove skipped file related crufts
851         https://bugs.webkit.org/show_bug.cgi?id=142046
852
853         Reviewed by Ryosuke Niwa.
854
855         * Scripts/webkitpy/port/base.py:
856         (Port.skipped_layout_tests):
857         (Port._tests_from_skipped_file_contents): Deleted.
858         (Port): Deleted.
859         (Port._expectations_from_skipped_files): Deleted.
860         * Scripts/webkitpy/port/mac_unittest.py:
861         (MacTest.test_default_timeout_ms):
862         (MacTest): Deleted.
863         (test_tests_from_skipped_file_contents): Deleted.
864
865 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
866
867         [Win] Unreviewed WinCairo build fix after r180653.
868
869         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
870
871         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
872         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
873         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
874         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
875         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
876
877 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
878
879         [Win] Use WEBCORE_EXPORT instead of Definition file
880         https://bugs.webkit.org/show_bug.cgi?id=141734
881
882         Reviewed by Alex Christensen.
883
884         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
885         Use a precompiled header so we can define our export macros properly.
886         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
887         Visual studio automatic update stuff.
888         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
889         Set up Precompiled Header use for project..
890         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
891         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
892         declarations for building DumpRenderTree as a client of
893         WebCore/WebKit.
894
895 2015-02-25  Mark Lam  <mark.lam@apple.com>
896
897         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
898         <https://webkit.org/b/141672>
899
900         Reviewed by Alexey Proskuryakov.
901
902         ASan does not like the fact that we memcpy the stack for GC scans.  So,
903         we're working around this by using our own memcpy (asanUnsafeMemcpy)
904         implementation that we can tell ASan to ignore.
905
906         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
907         which isn't effective for working around this issue. 
908
909         * asan/webkit-asan-ignore.txt:
910
911 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
912
913         CodeBlock crashes when dumping op_push_name_scope
914         https://bugs.webkit.org/show_bug.cgi?id=141953
915
916         Reviewed by Filip Pizlo.
917
918         * Scripts/run-jsc-stress-tests:
919
920 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
921
922         W3C test importer should use argparse instead of optparse
923         https://bugs.webkit.org/show_bug.cgi?id=142013
924
925         Reviewed by Bem Jones-Bey.
926
927         * Scripts/webkitpy/w3c/test_importer.py:
928         (main): Updating according argparse.
929         (parse_args): Moving from optparse to argparse.
930
931 2015-02-25  Brady Eidson  <beidson@apple.com>
932
933         Get rid of TestInvocation::pathOrURL
934         https://bugs.webkit.org/show_bug.cgi?id=142021
935
936         Reviewed by Tim Horton.
937
938         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
939         but most code that uses it expected an absolute path.
940
941         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
942
943         * WebKitTestRunner/TestController.cpp:
944         (WTR::TestController::updateWebViewSizeForTest):
945         (WTR::TestController::updateWindowScaleForTest):
946         (WTR::shouldUseFixedLayout):
947         (WTR::TestController::updateLayoutTypeForTest):
948
949         * WebKitTestRunner/TestInvocation.cpp:
950         (WTR::TestInvocation::TestInvocation):
951         (WTR::TestInvocation::urlContains):
952         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
953         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
954         (WTR::TestInvocation::invoke):
955         (WTR::shouldLogFrameLoadDelegates): Deleted.
956         (WTR::shouldLogHistoryClientCallbacks): Deleted.
957         * WebKitTestRunner/TestInvocation.h:
958         (WTR::TestInvocation::pathOrURL): Deleted.
959
960         * WebKitTestRunner/ios/TestControllerIOS.mm:
961         (WTR::shouldMakeViewportFlexible):
962         (WTR::TestController::platformConfigureViewForTest):
963
964         * WebKitTestRunner/mac/TestControllerMac.mm:
965         (WTR::shouldUseThreadedScrolling):
966         (WTR::TestController::platformConfigureViewForTest):
967
968 2015-02-25  Brady Eidson  <beidson@apple.com>
969
970         Layout test support for user content filters
971         https://bugs.webkit.org/show_bug.cgi?id=142018
972
973         Reviewed by Tim Horton.
974
975         * WebKitTestRunner/TestController.cpp:
976         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
977
978         * WebKitTestRunner/mac/TestControllerMac.mm:
979         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
980           file before loading the test itself.
981
982 2015-02-24  Sam Weinig  <sam@webkit.org>
983
984         Convert WebEditingTester to use xcconfig files
985         https://bugs.webkit.org/show_bug.cgi?id=141879
986
987         Reviewed by Darin Adler.
988
989         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
990
991         * WebEditingTester/Configurations: Added.
992         * WebEditingTester/Configurations/Base.xcconfig: Added.
993         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
994         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
995
996 2015-02-24  Andy Estes  <aestes@apple.com>
997
998         Teach MiniBrowser how to disable per-window web processes
999         https://bugs.webkit.org/show_bug.cgi?id=141988
1000
1001         Reviewed by Darin Adler.
1002
1003         * MiniBrowser/mac/AppDelegate.m:
1004         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1005         * MiniBrowser/mac/SettingsController.h:
1006         * MiniBrowser/mac/SettingsController.m:
1007         (-[SettingsController _populateMenu]): Added a new Settings menu item.
1008         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1009         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1010         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1011
1012 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
1013
1014         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1015         https://bugs.webkit.org/show_bug.cgi?id=141889
1016
1017         Reviewed by Darin Adler.
1018
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1020
1021 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1022
1023         REGRESSION(r179429): Can't type comments in Facebook
1024         https://bugs.webkit.org/show_bug.cgi?id=141859
1025
1026         Reviewed by Brent Fulgham.
1027
1028         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1029
1030         * DumpRenderTree/mac/DumpRenderTree.mm:
1031         (resetWebPreferencesToConsistentValues):
1032         * DumpRenderTree/win/DumpRenderTree.cpp:
1033         (resetWebPreferencesToConsistentValues):
1034         * WebKitTestRunner/TestController.cpp:
1035         (WTR::TestController::resetPreferencesToConsistentValues):
1036
1037 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1038
1039         Crash loading local file with WebPageProxy::loadAlternateHTMLString
1040         https://bugs.webkit.org/show_bug.cgi?id=141867
1041
1042         Reviewed by Anders Carlsson.
1043
1044         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1045         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1046         be shared with the new test.
1047         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1048         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1049         (testLoadAlternateHTMLForLocalPage):
1050         (beforeAll):
1051
1052 2015-02-24  David Kilzer  <ddkilzer@apple.com>
1053
1054         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1055         <http://webkit.org/b/141900>
1056
1057         Reviewed by Myles C. Maxfield.
1058
1059         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1060         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1061         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1062         - Rename to share code with iOS.
1063         - Add USE(APPKIT) around AppKit-specific headers and code.
1064         - Fix a check-webkit-style warning.
1065         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1066         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1067         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1068         - Remove ios/ActivateFontsIOS.mm.
1069         - Fix InjectedBundle/cocoa group to represent the directory on
1070           disk.  Includes a change to InjectedBundlePageCocoa.mm.
1071
1072 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1073
1074         Unreviewed, rolling out r180547 and r180550.
1075         https://bugs.webkit.org/show_bug.cgi?id=141957
1076
1077         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1078
1079         Reverted changesets:
1080
1081         "REGRESSION(r179429): Can't type comments in Facebook"
1082         https://bugs.webkit.org/show_bug.cgi?id=141859
1083         http://trac.webkit.org/changeset/180547
1084
1085         "Constructor returning null should construct an object instead
1086         of null"
1087         https://bugs.webkit.org/show_bug.cgi?id=141640
1088         http://trac.webkit.org/changeset/180550
1089
1090 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1091
1092         REGRESSION(r179429): Can't type comments in Facebook
1093         https://bugs.webkit.org/show_bug.cgi?id=141859
1094
1095         Reviewed by Geoffrey Garen.
1096
1097         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1098
1099         * DumpRenderTree/mac/DumpRenderTree.mm:
1100         (resetWebPreferencesToConsistentValues):
1101         * WebKitTestRunner/TestController.cpp:
1102         (WTR::TestController::resetPreferencesToConsistentValues):
1103
1104 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
1105
1106         [EFL] fix eo errors
1107         https://bugs.webkit.org/show_bug.cgi?id=141909
1108
1109         Reviewed by Gyuyoung Kim.
1110
1111         Fix eo errors that occur whenever minibrowser is launched.
1112         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1113         - elm_obj_win_resize_object_add's first parameter should be elm_win
1114
1115         * MiniBrowser/efl/main.c:
1116         (window_create):
1117
1118 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1119
1120         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1121
1122         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1123         (TestWebKitAPI::TEST):
1124
1125 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1126
1127         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1128         https://bugs.webkit.org/show_bug.cgi?id=141935
1129
1130         Reviewed by Myles C. Maxfield.
1131
1132         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1133         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1134         tests for assigning from nullptr.
1135
1136 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1137
1138         WTF::WeakPtr should have a 'forget' method.
1139         https://bugs.webkit.org/show_bug.cgi?id=141923
1140
1141         Reviewed by Myles C. Maxfield.
1142
1143         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1144         (TestWebKitAPI::TEST): Added 'Forget' tests case.
1145
1146 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1147
1148         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1149         https://bugs.webkit.org/show_bug.cgi?id=141920
1150
1151         Reviewed by Tim Horton.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1154         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1155         Do the same thing as we do for regular green bubbles.
1156
1157 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1158
1159         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1160         https://bugs.webkit.org/show_bug.cgi?id=141925
1161
1162         Reviewed by Tim Horton.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1165         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1166
1167 2015-02-23  Anders Carlsson  <andersca@apple.com>
1168
1169         Add API for fetching website data records to _WKWebsiteDataStore
1170         https://bugs.webkit.org/show_bug.cgi?id=141926
1171
1172         Reviewed by Beth Dakin.
1173
1174         * MiniBrowser/mac/MainMenu.xib:
1175         * MiniBrowser/mac/WK2BrowserWindowController.m:
1176         (-[WK2BrowserWindowController fetchWebsiteData:]):
1177         Add menu item to fetch and dump website data.
1178
1179 2015-02-23  David Kilzer  <ddkilzer@apple.com>
1180
1181         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1182         <http://webkit.org/b/141884>
1183
1184         Reviewed by Alexey Proskuryakov.
1185
1186         * Scripts/webkitpy/port/leakdetector.py:
1187         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1188         snowleopard, lion and older leaks.  Add known leak for
1189         mavericks, but check Port.operating_system before calling
1190         Port.is_mavericks.
1191         * Scripts/webkitpy/port/mac.py:
1192         (MacPort.is_snowleopard): Delete.
1193         (MacPort.is_lion): Delete.
1194         (MacPort.is_mavericks): Add.
1195
1196 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1197
1198         build.webkit.org/dashboard should filter out commits to other branches
1199         https://bugs.webkit.org/show_bug.cgi?id=140362
1200
1201         Reviewed by Tim Horton.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1204         (BuildbotQueue):
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1206         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1207         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1208         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1209         (BuildbotQueueView.prototype.revisionContentForIteration):
1210         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1211         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1212         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1214         (Trac.prototype.get oldestRecordedRevisionNumber):
1215         (Trac.prototype.commitsOnBranch):
1216         (Trac.prototype._xmlTimelineURL):
1217         (Trac.prototype._convertCommitInfoElementToObject):
1218         (Trac.prototype._update):
1219         (Trac.prototype.startPeriodicUpdates):
1220         (Trac.prototype.loadMoreHistoricalData):
1221         (Trac.prototype.update): Deleted.
1222
1223 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1224
1225         Tests don't work on some bots: Failed to stop wptwk
1226         https://bugs.webkit.org/show_bug.cgi?id=141235
1227
1228         Reviewed by Ryosuke Niwa.
1229
1230         Logging of server subprocesses in launcher script.
1231         Killing of server subprocesses when stopping/before starting.
1232         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
1233
1234         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1235         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
1236         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1237         (WebPlatformTestServer.__init__):
1238         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
1239         (WebPlatformTestServer):
1240         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
1241         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
1242         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1243         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
1244         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
1245         (TestWebPlatformTestServer):
1246         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
1247
1248 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1249
1250         [WebEditingTester] Allow dropping HTML files on the app
1251         https://bugs.webkit.org/show_bug.cgi?id=141834
1252
1253         Reviewed by Simon Fraser.
1254
1255         * WebEditingTester/AppDelegate.m:
1256         (-[WebEditingAppDelegate openDocument:]):
1257         (-[WebEditingAppDelegate application:openFile:]):
1258         Implement application:openFile:, factoring file loading code out of openDocument.
1259
1260         * WebEditingTester/Info.plist:
1261         Register as an editor for HTML files.
1262
1263         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1264         Enrica is not an organization.
1265
1266 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1267
1268         [WebEditingTester] Expand "WK" to "WebKit" in a few places
1269         https://bugs.webkit.org/show_bug.cgi?id=141833
1270
1271         Reviewed by Anders Carlsson.
1272
1273         * WebEditingTester/AppDelegate.h:
1274         * WebEditingTester/AppDelegate.m:
1275         (-[WebEditingAppDelegate newEditor:]):
1276         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
1277         (-[WebEditingAppDelegate validateMenuItem:]):
1278         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1279         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
1280         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1281         (-[WebEditingAppDelegate showOperations:]): Deleted.
1282         * WebEditingTester/MainMenu.xib:
1283         The WK abbreviation is unnaturally grating in menu items for some reason.
1284
1285 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1286
1287         [WebEditingTester] Add a custom protocol for loading canned content
1288         https://bugs.webkit.org/show_bug.cgi?id=141830
1289
1290         Reviewed by Enrica Casucci.
1291
1292         Add a canned:// protocol handler, which can be used to emulate behaviors
1293         in WebKit client apps (like Mail) that use custom protocol handlers,
1294         which can have important effects on editing (mostly, the URLs are only
1295         valid inside of the client application, but not when copied/dragged out).
1296
1297         For now, we only support two canned files:
1298
1299             canned://dice is a PNG of dice (stolen from LayoutTests/)
1300             canned://text is the string "canned text" served as text/html
1301
1302         In the future we could support things like very large (generated) files,
1303         progressive loading, etc. to further simulate conditions in other apps.
1304
1305         * WebEditingTester/AppDelegate.m:
1306         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1307         Register the protocol with CFNetwork, and the scheme with WebKit2.
1308
1309         * WebEditingTester/Canned Content/dice.png: Added.
1310         * WebEditingTester/CannedContent.h: Added.
1311         * WebEditingTester/CannedContent.m: Added.
1312         (-[CannedContent initWithRequest:cachedResponse:client:]):
1313         (+[CannedContent canonicalRequestForRequest:]):
1314         (+[CannedContent canInitWithRequest:]):
1315         We only want to handle canned:// URLs.
1316
1317         (-[CannedContent startLoading]):
1318         For now, immediately load the two files we know about.
1319         Otherwise, immediately fail the load.
1320
1321         (-[CannedContent stopLoading]):
1322         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1323
1324 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1325
1326         [WebEditingTester] Implement an open panel
1327         https://bugs.webkit.org/show_bug.cgi?id=141829
1328
1329         Reviewed by Simon Fraser.
1330
1331         * WebEditingTester/AppDelegate.m:
1332         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
1333         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
1334         (-[WebEditingAppDelegate openDocument:]):
1335         Add an open panel (with radio buttons to pick which WebKit to open with).
1336         Loads the file as an HTML string.
1337
1338 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
1339
1340         [WebEditingTester] @properties, dot syntax, and remember the window position
1341         https://bugs.webkit.org/show_bug.cgi?id=141843
1342
1343         Reviewed by Tim Horton.
1344         
1345         Modernize a bit with more dot syntax, use @property for the web views,
1346         and give the main window an Autosave name so it remembers the widow position.
1347
1348         * WebEditingTester/WK1WebDocumentController.m:
1349         (-[WK1WebDocumentController awakeFromNib]):
1350         (-[WK1WebDocumentController loadHTMLString:]):
1351         * WebEditingTester/WK2WebDocumentController.m:
1352         (-[WK2WebDocumentController awakeFromNib]):
1353         * WebEditingTester/WebDocument.xib:
1354
1355 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1356
1357         [WebEditingTester] Hook up key equivalents for new window action
1358         https://bugs.webkit.org/show_bug.cgi?id=141828
1359
1360         Reviewed by Enrica Casucci.
1361
1362         * WebEditingTester/AppDelegate.h:
1363         * WebEditingTester/AppDelegate.m:
1364         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1365         (-[WebEditingAppDelegate newEditor:]):
1366         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
1367         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1368         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1369         (defaultConfiguration): Deleted.
1370         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1371         Move WKWebViewConfiguration setup into WK2WebDocumentController.
1372         Remove unused application termination code.
1373         Update new-window menu item key equivalents when launching and when
1374         changing the use-WebKit2-by-default setting.
1375         Make WebDocumentController subclasses all initialized the same way,
1376         and use that to factor out alloc/init.
1377         Rename loadContent to loadHTMLString for future use.
1378
1379         * WebEditingTester/MainMenu.xib:
1380         Add default key equivalents.
1381         Cmd-N will always make the default kind of window (controlled by the pref).
1382         Cmd-Opt-N will always make the other kind.
1383         The menu items are configured as alternates so they only show up if you
1384         press alt (just like in MiniBrowser).
1385
1386         * WebEditingTester/WK1WebDocumentController.m:
1387         (-[WK1WebDocumentController loadHTMLString:]):
1388         (-[WK1WebDocumentController loadContent]): Deleted.
1389         * WebEditingTester/WK2WebDocumentController.h:
1390         * WebEditingTester/WK2WebDocumentController.m:
1391         (defaultConfiguration):
1392         (-[WK2WebDocumentController awakeFromNib]):
1393         (-[WK2WebDocumentController loadHTMLString:]):
1394         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
1395         (-[WK2WebDocumentController dealloc]): Deleted.
1396         * WebEditingTester/WebDocumentController.h:
1397         * WebEditingTester/WebDocumentController.m:
1398         (-[WebDocumentController init]):
1399         (-[WebDocumentController initWithWindow:]):
1400         (+[WebDocumentController defaultEditingSource]):
1401         (-[WebDocumentController loadHTMLString:]):
1402         (-[WebDocumentController windowDidLoad]): Deleted.
1403         (-[WebDocumentController defaultEditingSource]): Deleted.
1404         (-[WebDocumentController applicationTerminating]): Deleted.
1405         (-[WebDocumentController loadContent]): Deleted.
1406
1407 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1408
1409         [WebEditingTester] ARC-ify WebEditingTester
1410         https://bugs.webkit.org/show_bug.cgi?id=141827
1411
1412         Reviewed by Sam Weinig.
1413
1414         * WebEditingTester/AppDelegate.m:
1415         (-[WebEditingAppDelegate showOperations:]):
1416         * WebEditingTester/EditingOperations.m:
1417         (editingOperations):
1418         * WebEditingTester/WK1WebDocumentController.m:
1419         (-[WK1WebDocumentController dealloc]): Deleted.
1420         * WebEditingTester/WK2WebDocumentController.m:
1421         (-[WK2WebDocumentController dealloc]): Deleted.
1422         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1423         Turn on ARC and remove a few retain/release/autorelease calls.
1424         We don't need to implement dealloc in either document controller
1425         because WebView and WKWebView's UIDelegate property does not hold a
1426         strong reference.
1427
1428 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1429
1430         [WebEditingTester] Factor out list of editing operations
1431         https://bugs.webkit.org/show_bug.cgi?id=141826
1432
1433         Reviewed by Sam Weinig.
1434
1435         * WebEditingTester/AppDelegate.m:
1436         (-[WebEditingAppDelegate showOperations:]):
1437         * WebEditingTester/EditingOperations.h: Added.
1438         * WebEditingTester/EditingOperations.m: Added.
1439         (editingOperations):
1440         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1441         Move EditingOperations array to its own file, and make it an NSArray
1442         instead of a C array. Adjust accordingly in showOperations:.
1443
1444 2015-02-20  Michael Saboff  <msaboff@apple.com>
1445
1446         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
1447         https://bugs.webkit.org/show_bug.cgi?id=141676
1448
1449         Reviewed by Filip Pizlo.
1450
1451         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
1452         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
1453         large string expression that we want to eval.
1454
1455         * Scripts/run-jsc-stress-tests:
1456
1457 2015-02-19  Daniel Bates  <dabates@apple.com>
1458
1459         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
1460         https://bugs.webkit.org/show_bug.cgi?id=141815
1461         <rdar://problem/19893933>
1462
1463         Reviewed by Simon Fraser.
1464
1465         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
1466         was booted by iOS Simulator in a previous run of run-webkit-test.
1467
1468         * Scripts/webkitpy/port/ios.py:
1469         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
1470         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
1471         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
1472
1473 2015-02-19  David Kilzer  <ddkilzer@apple.com>
1474
1475         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
1476         <http://webkit.org/b/141799>
1477
1478         Reviewed by Alex Christensen.
1479
1480         * Scripts/webkitpy/style/checkers/cpp.py:
1481         (_IncludeState.check_next_include_order): Don't emit a warning
1482         if the primary header exists and the source file name ends with
1483         "SoftLink.cpp".  Add 'filename' argument to method.
1484         (check_include_line): Pass in 'filename'.
1485
1486         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1487         (OrderOfIncludesTest.test_check_next_include_order__no_config):
1488         (OrderOfIncludesTest.test_check_next_include_order__no_self):
1489         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
1490         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
1491         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
1492         - Add test filename arguments for calls to
1493           check_next_include_order().
1494         (OrderOfIncludesTest.test_primary_header): Add test for a file
1495         name ending in "SoftLink.cpp".
1496
1497 2015-02-18  Enrica Casucci  <enrica@apple.com>
1498
1499         Add new tool to test editable Webviews.
1500         https://bugs.webkit.org/show_bug.cgi?id=141772
1501
1502         Reviewed by Tim Horton.
1503
1504         Adding WebEditingTester, a Cocoa application to
1505         test WK1 and Wk2 views in editable mode.
1506
1507         * WebEditingTester: Added.
1508         * WebEditingTester/AppDelegate.h: Added.
1509         * WebEditingTester/AppDelegate.m: Added.
1510         (-[WebEditingAppDelegate init]):
1511         (defaultConfiguration):
1512         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1513         (-[WebEditingAppDelegate applicationWillTerminate:]):
1514         (-[WebEditingAppDelegate newEditor:]):
1515         (-[WebEditingAppDelegate showOperations:]):
1516         (-[WebEditingAppDelegate useWebKit2ByDefault]):
1517         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1518         (-[WebEditingAppDelegate validateMenuItem:]):
1519         * WebEditingTester/Info.plist: Added.
1520         * WebEditingTester/MainMenu.xib: Added.
1521         * WebEditingTester/WK1WebDocumentController.h: Added.
1522         * WebEditingTester/WK1WebDocumentController.m: Added.
1523         (-[WK1WebDocumentController awakeFromNib]):
1524         (-[WK1WebDocumentController loadContent]):
1525         (-[WK1WebDocumentController dealloc]):
1526         (-[WK1WebDocumentController pasteAsMarkup:]):
1527         * WebEditingTester/WK2WebDocumentController.h: Added.
1528         * WebEditingTester/WK2WebDocumentController.m: Added.
1529         (-[WK2WebDocumentController initWithConfiguration:]):
1530         (-[WK2WebDocumentController pasteAsMarkup:]):
1531         (-[WK2WebDocumentController awakeFromNib]):
1532         (-[WK2WebDocumentController dealloc]):
1533         (-[WK2WebDocumentController loadContent]):
1534         * WebEditingTester/WebDocument.xib: Added.
1535         * WebEditingTester/WebDocumentController.h: Added.
1536         * WebEditingTester/WebDocumentController.m: Added.
1537         (-[WebDocumentController initWithWindow:]):
1538         (-[WebDocumentController windowDidLoad]):
1539         (-[WebDocumentController defaultEditingSource]):
1540         (-[WebDocumentController applicationTerminating]):
1541         (-[WebDocumentController loadContent]):
1542         * WebEditingTester/WebEditingTester.xcodeproj: Added.
1543         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
1544         * WebEditingTester/main.m: Added.
1545         (main):
1546
1547 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1548
1549         Run JSC tests on ARM EFL bots
1550         https://bugs.webkit.org/show_bug.cgi?id=141165
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         * BuildSlaveSupport/build.webkit.org-config/config.json:
1555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1556         (RunJavaScriptCoreTests.countFailures):
1557         (RunRemoteJavaScriptCoreTests):
1558         (RunRemoteJavaScriptCoreTests.start):
1559         (BuildAndRemoteJSCTestsFactory):
1560         (BuildAndRemoteJSCTestsFactory.__init__):
1561
1562 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
1563
1564         Streamline unexported function build fixes
1565         https://bugs.webkit.org/show_bug.cgi?id=141761
1566
1567         Reviewed by Alex Christensen.
1568
1569         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
1570         We don't need to ignore symbols that are not exported due to the .unexp file.
1571
1572 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1573
1574         Remove more references to WebCore.exp.in
1575         https://bugs.webkit.org/show_bug.cgi?id=141747
1576
1577         Reviewed by Alexey Proskuryakov.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1580         (ShouldBuildTest):
1581
1582 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
1583
1584         Windows test results should not fall back to mac-mountainlion after r180176
1585         https://bugs.webkit.org/show_bug.cgi?id=141719
1586
1587         Reviewed by Brent Fulgham.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1590         (_should_file_trigger_build):
1591         * Scripts/webkitpy/port/win.py:
1592         (WinPort.default_baseline_search_path):
1593         * Scripts/webkitpy/port/win_unittest.py:
1594         (WinPortTest.test_baseline_search_path):
1595
1596 2015-02-17  Daniel Bates  <dabates@apple.com>
1597
1598         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
1599         https://bugs.webkit.org/show_bug.cgi?id=141718
1600
1601         Reviewed by Alex Christensen.
1602
1603         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
1604
1605         * Scripts/webkitpy/port/ios.py:
1606         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
1607         Log a error and return False if we are unable to boot the simulator device so that the caller can take
1608         appropriate action, say exit(3) before running any layout tests.
1609         * Scripts/webkitpy/xcode/simulator.py:
1610         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
1611         with the specified UDID.
1612         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
1613         with the specified UDID can successfully boot and shut down. We make at most two attempts to
1614         boot and shut down the device, erasing the device between tries so as to restore the device
1615         to a known good state.
1616
1617 2015-02-17  Daniel Bates  <dabates@apple.com>
1618
1619         run_webkit_tests.py should not know about iOS Simulator details
1620         https://bugs.webkit.org/show_bug.cgi?id=141711
1621
1622         Reviewed by Alex Christensen.
1623
1624         Run_webkit_tests.py should only parse the iOS-specific command
1625         line options --runtime and --device-type. Let the port-specific
1626         logic in ios.py validate the parsed options and instantiate
1627         internal data structures.
1628
1629         Currently run_webkit_tests.py parses the iOS-specific command
1630         line options --runtime and --device-type, validates them, and
1631         instantiates internal data structures from the parsed strings.
1632         Instead the validation logic and instantiation of internal
1633         data structures should be handled by the iOS port object.
1634
1635         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1636         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
1637         and instantiate internal data structures for them.
1638         * Scripts/webkitpy/port/driver.py:
1639         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
1640         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
1641         respectively.
1642         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
1643         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
1644         object from --runtime, if specified. Otherwise, instantiates a Runtime
1645         object for the latest installed iphonesimulator SDK version.
1646         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
1647         object from --device-type, if specified. Otherwise, instantiates
1648         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
1649         machine, respectively.
1650         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
1651         runtime is available to use.
1652         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
1653         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
1654         * Scripts/webkitpy/xcode/simulator.py:
1655         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
1656         with a runtime identifier for the specified iOS version.
1657
1658 2015-02-17  Dana Burkart  <dburkart@apple.com>
1659
1660         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
1661         https://bugs.webkit.org/show_bug.cgi?id=141672
1662
1663         Reviewed by David Kilzer.
1664
1665         * asan/webkit-asan-ignore.txt:
1666
1667 2015-02-17  Alex Christensen  <achristensen@webkit.org>
1668
1669         Remove WebCore.exp.in and clean up.
1670         https://bugs.webkit.org/show_bug.cgi?id=141491
1671
1672         Reviewed by Andreas Kling.
1673
1674         * Scripts/sort-export-file: Removed.
1675         * Scripts/webkitpy/style/checker.py:
1676         (_all_categories):
1677         (FileType):
1678         (CheckerDispatcher._file_type):
1679         (CheckerDispatcher._create_checker):
1680         Don't check if the export files are sorted.
1681         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
1682         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
1683
1684 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1685
1686         Unreviewed. Fix GTK+ make distcheck.
1687
1688         Do not exclude bmalloc directory from the tarball.
1689
1690         * gtk/manifest.txt.in:
1691
1692 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1693
1694         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
1695
1696         I forgot to add the return of a bool function.
1697
1698         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1699         (WebKitDOMNodeTest::testDOMCache):
1700
1701 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1702
1703         [GTK] GObject DOM bindings object are cached forever
1704         https://bugs.webkit.org/show_bug.cgi?id=141558
1705
1706         Reviewed by Sergio Villar Senin.
1707
1708         Add checks for all DOM objects to ensure they are not leaked. Also
1709         add a dedicated test for the DOM Object Cache.
1710
1711         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1712         (WebKitDOMNodeFilterTest::testTreeWalker):
1713         (WebKitDOMNodeFilterTest::testNodeIterator):
1714         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1715         (WebKitDOMNodeTest::testHierarchyNavigation):
1716         (WebKitDOMNodeTest::testInsertion):
1717         (WebKitDOMNodeTest::testTagNames):
1718         (WebKitDOMNodeTest::testDOMCache):
1719         (registerTests):
1720         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1721         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1722         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1723         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1724         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1725         (testWebKitDOMObjectCache):
1726         (beforeAll):
1727         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1728         (documentLoadedCallback):
1729
1730 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1731
1732         [GTK] WebKitFrame objects are never released
1733         https://bugs.webkit.org/show_bug.cgi?id=141641
1734
1735         Reviewed by Martin Robinson.
1736
1737         Add a way to check GObjects leaks for WebProcess tests and check
1738         WebKitFrame objects are not leaked.
1739
1740         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1741         (WebKitFrameTest::testMainFrame):
1742         (WebKitFrameTest::testURI):
1743         (WebKitFrameTest::testJavaScriptContext):
1744         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1745         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
1746         (runTest):
1747         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1748
1749 2015-02-16  Tim Horton  <timothy_horton@apple.com>
1750
1751         Fix the MiniBrowser build with newer clang
1752
1753         * MiniBrowser/mac/SettingsController.m:
1754         (-[SettingsController _toggleBooleanDefault:]):
1755         * MiniBrowser/mac/WK1BrowserWindowController.m:
1756         (-[WK1BrowserWindowController windowWillClose:]):
1757         * MiniBrowser/mac/WK2BrowserWindowController.m:
1758         (-[WK2BrowserWindowController windowWillClose:]):
1759         NSApp is id and clang gets confused about which -delegate we're talking about.
1760
1761 2015-02-16  Antti Koivisto  <antti@apple.com>
1762
1763         Develop/Disable Caches does not properly disable disk cache
1764         https://bugs.webkit.org/show_bug.cgi?id=141636
1765
1766         Reviewed by Anders Carlsson.
1767
1768         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
1769         the network process too.
1770
1771         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
1772
1773         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1774         (WTR::InjectedBundle::beginTesting):
1775         (WTR::InjectedBundle::setCacheModel):
1776         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1778
1779             Forward to TestController.
1780
1781         (WTR::TestRunner::setCacheModel):
1782         * WebKitTestRunner/TestInvocation.cpp:
1783         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1784
1785 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
1786
1787         Unreviewed. Add myself as a committer.
1788
1789         * Scripts/webkitpy/common/config/contributors.json:
1790
1791 2015-02-15  David Kilzer  <ddkilzer@apple.com>
1792
1793         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
1794         <http://webkit.org/b/141607>
1795
1796         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
1797         externals in Source/WebCore/Configurations/WebCore.unexp when
1798         building with Xcode 5.x.
1799         (readXcode5SymbolsToIgnore): Add.
1800
1801 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
1802
1803         [EFL] fix Evas GL engine error.
1804         https://bugs.webkit.org/show_bug.cgi?id=141621
1805
1806         Reviewed by Gyuyoung Kim.
1807
1808         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
1809
1810         * MiniBrowser/efl/main.c:
1811         (elm_main):
1812
1813 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
1814
1815         [buildbot] Enable run-api-tests on release Mac bots
1816         https://bugs.webkit.org/show_bug.cgi?id=141518
1817
1818         Reviewed by Darin Adler.
1819
1820         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1821         (RunUnitTests):
1822         (BuildFactory.__init__):
1823         (TestFactory.__init__):
1824         (BuildAndTestFactory.__init__):
1825         (RunUnitTests.start): Deleted.
1826         (unitTestsSupported): Deleted.
1827
1828 2015-02-13  Anders Carlsson  <andersca@apple.com>
1829
1830         Add a move constructor and move assignment operator to Deque
1831         https://bugs.webkit.org/show_bug.cgi?id=141571
1832
1833         Reviewed by Andreas Kling.
1834
1835         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1836         (TestWebKitAPI::TEST):
1837
1838 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1839
1840         run-jsc-stress-tests --remote should skip profiler tests
1841         https://bugs.webkit.org/show_bug.cgi?id=141470
1842
1843         Reviewed by Filip Pizlo.
1844
1845         * Scripts/run-jsc-stress-tests:
1846
1847 2015-02-13  Anders Carlsson  <andersca@apple.com>
1848
1849         Add an initializer list constructor to Deque
1850         https://bugs.webkit.org/show_bug.cgi?id=141565
1851
1852         Reviewed by Andreas Kling.
1853
1854         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1855         (TestWebKitAPI::TEST):
1856
1857 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1858
1859         [buildbot] Remove buildJSCTool cruft from master.cfg
1860         https://bugs.webkit.org/show_bug.cgi?id=141513
1861
1862         Reviewed by Alexey Proskuryakov.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1865         (RunJavaScriptCoreTests):
1866         (RunJavaScriptCoreTests.start):
1867         (RunWebKitTests):
1868         (RunWebKitTests.start):
1869         (TestFactory.__init__):
1870         (TestLeaksFactory.__init__):
1871         (RunJavaScriptCoreTests.__init__): Deleted.
1872         (RunWebKitTests.__init__): Deleted.
1873
1874 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1875
1876         Unreviewed, remove empty directories.
1877
1878         * DumpRenderTree/gtk: Removed.
1879         * DumpRenderTree/gtk/fonts: Removed.
1880         * DumpRenderTree/unix: Removed.
1881         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
1882         * GtkLauncher: Removed.
1883         * TestWebKitAPI/Tests/WebKitGtk: Removed.
1884         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
1885         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
1886         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
1887
1888 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1889
1890         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
1891         https://bugs.webkit.org/show_bug.cgi?id=141519
1892
1893         Reviewed by Alexey Proskuryakov.
1894
1895         * Scripts/build-webkittestrunner:
1896
1897 2015-02-12  Alex Christensen  <achristensen@webkit.org>
1898
1899         Removed empty directory.
1900
1901         * WinCELauncher: Removed.
1902
1903 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
1904
1905         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
1906         https://bugs.webkit.org/show_bug.cgi?id=141202
1907
1908         Reviewed by Darin Adler.
1909
1910         * Scripts/run-jsc-stress-tests:
1911
1912 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
1913
1914         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
1915         https://bugs.webkit.org/show_bug.cgi?id=141517
1916
1917         Reviewed by Anders Carlsson.
1918
1919         We do not need to locate or use the DLL's that came with Safari, so stop
1920         failing when we cannot find them. Also remove some old Qt cruft from this
1921         script.
1922
1923         * BuildSlaveSupport/built-product-archive:
1924         (archiveBuiltProduct): 
1925         (extractBuiltProduct):
1926
1927 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
1928
1929         [Win] [64-bit] Work around MSVC2013 Runtime Bug
1930         https://bugs.webkit.org/show_bug.cgi?id=141498
1931         <rdar://problem/19803642>
1932
1933         Reviewed by Anders Carlsson.
1934
1935         Disable FMA3 instruction use in the MSVC math library to
1936         work around a VS2013 runtime crash. We can remove this
1937         workaround when we switch to VS2015.
1938
1939         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
1940         disable FMA3 support.
1941         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
1942         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
1943         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1944         * Scripts/webkitperl/httpd.pm: Ditto.
1945         * TestWebKitAPI/win/main.cpp: Ditto.
1946         * WinLauncher/Common.cpp: Ditto.
1947         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
1948
1949 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
1950
1951         run-jsc-stress-tests should accept remote host config from JSON file
1952         https://bugs.webkit.org/show_bug.cgi?id=141509
1953
1954         Reviewed by Michael Saboff.
1955
1956         * Scripts/run-javascriptcore-tests:
1957         (runJSCStressTests):
1958         * Scripts/run-jsc-stress-tests:
1959
1960 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1961
1962         [GTK] Add API to allow overriding the default color chooser implementation
1963         https://bugs.webkit.org/show_bug.cgi?id=98935
1964
1965         Reviewed by Gustavo Noronha Silva.
1966
1967         Add a color chooser implementation for MiniBrowser using
1968         GtkPopover when the GTK+ version is recent enough.
1969         And a test case to check the new color chooser API.
1970
1971         * MiniBrowser/gtk/BrowserWindow.c:
1972         (colorChooserRGBAChanged):
1973         (popoverColorClosed):
1974         (colorChooserRequestFinished):
1975         (runColorChooserCallback):
1976         (browserWindowConstructed):
1977         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1978         (testWebViewColorChooserRequest):
1979         (beforeAll):
1980
1981 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
1982
1983         Make run-jsc-stress-tests --remote work with make-based runner
1984         https://bugs.webkit.org/show_bug.cgi?id=141079
1985
1986         Reviewed by Darin Adler.
1987
1988         * Scripts/run-javascriptcore-tests:
1989         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
1990         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
1991         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
1992         to avoid code duplication.
1993
1994 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
1995
1996         run-jsc-stress tests should detect the number of processors on the remote machine too
1997         https://bugs.webkit.org/show_bug.cgi?id=141196
1998
1999         Reviewed by Darin Adler.
2000
2001         * Scripts/run-javascriptcore-tests:
2002         (runJSCStressTests): Pass through the --child-processes argument.
2003         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2004         to detect the number of local and remote processors with the same algorithm.
2005         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2006         same as $numProcessors.
2007
2008 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2009
2010         run-jsc-stress-tests should pass JSC_timeout to remote hosts
2011         https://bugs.webkit.org/show_bug.cgi?id=141164
2012
2013         Reviewed by Darin Adler.
2014
2015         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2016
2017         * Scripts/run-jsc-stress-tests:
2018
2019 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2020
2021         [GTK] Add default color chooser implementation using GtkColorChooserDialog
2022         https://bugs.webkit.org/show_bug.cgi?id=141392
2023
2024         Reviewed by Gustavo Noronha Silva.
2025
2026         Enable INPUT_TYPE_COLOR by default for GTK+ port.
2027
2028         * Scripts/webkitperl/FeatureList.pm:
2029
2030 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2031
2032         run-jsc-stress-tests shell test runner should run tests in fixed order
2033         https://bugs.webkit.org/show_bug.cgi?id=141383
2034
2035         Reviewed by Darin Adler.
2036
2037         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2038
2039 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
2040
2041         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2042         https://bugs.webkit.org/show_bug.cgi?id=140485
2043
2044         Reviewed by Anders Carlsson.
2045
2046         Implement takeFocus() as a way to set focus through accessibility wrappers.
2047
2048         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2049         (AccessibilityUIElement::takeFocus):
2050         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2051         (WTR::AccessibilityUIElement::takeFocus):
2052
2053 2015-02-08  Darin Adler  <darin@apple.com>
2054
2055         Remove the SVG instance tree
2056         https://bugs.webkit.org/show_bug.cgi?id=140602
2057
2058         Reviewed by Dean Jackson.
2059
2060         * Scripts/check-for-global-initializers: Removed special case for
2061         SVGElementInstance.o.
2062
2063 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2064
2065         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2066         <http://webkit.org/b/141365>
2067
2068         Reviewed by Daniel Bates.
2069
2070         * Scripts/webkitpy/xcode/simulator.py:
2071         (Simulator): Add unavailable_version_re precompiled regex.
2072         (Simulator._parse_devices): Check for unavailable versions and
2073         ignore them if found when parsing the output of
2074         `xcrun simctl list`.
2075         * Scripts/webkitpy/xcode/simulator_unittest.py:
2076         (test_unavailable_devices): Add test with output from
2077         `xcrun simctl list` with unavailable runtimes that fails before
2078         the fix.
2079
2080 2015-02-07  Chris Dumez  <cdumez@apple.com>
2081
2082         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2083         https://bugs.webkit.org/show_bug.cgi?id=141321
2084
2085         Reviewed by Darin Adler.
2086
2087         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2088
2089 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2090
2091         [iOS] Make Simulator class testable
2092         <http://webkit.org/b/141358>
2093
2094         Rubber-stamped by Darin Adler.
2095
2096         * Scripts/webkitpy/common/system/platforminfo.py:
2097         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2098         command to here from Simulator.refresh() in xcode/simulator.py
2099         so that the output of the command can be mocked.
2100
2101         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2102         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2103         to None.
2104         (MockPlatformInfo.xcode_simctl_list): Add method that returns
2105         self.expected_xcode_simctl_list expectation.
2106
2107         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2108         and license header.
2109         (Simulator.__init__): Add optional 'host' parameter to make it
2110         possible to pass in a mock object for testing.  Set self._host
2111         to 'host' parameter or create Host() object.
2112         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2113         method.
2114
2115         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2116         for current code.
2117         (SimulatorTest):
2118         (SimulatorTest.setUp):
2119         (SimulatorTest._set_expected_xcrun_simctl_list):
2120         (SimulatorTest.test_simulator_device_types):
2121         (test_invalid_device_types_header):
2122         (test_invalid_runtimes_header):
2123         (test_invalid_devices_header):
2124
2125 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
2126
2127         run-jsc-stress-tests --remote should use the default ssh port
2128         https://bugs.webkit.org/show_bug.cgi?id=141287
2129
2130         Reviewed by Darin Adler.
2131
2132         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2133
2134 2015-02-06  Dana Burkart  <dburkart@apple.com>
2135
2136         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2137         https://bugs.webkit.org/show_bug.cgi?id=141349
2138
2139         Reviewed by Alexey Proskuryakov.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2142         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2143         (BuildbotTesterQueueView.prototype.update):
2144
2145 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
2146
2147         Report network process crashes during layout tests
2148         https://bugs.webkit.org/show_bug.cgi?id=139646
2149
2150         Reviewed by Anders Carlsson.
2151
2152         * WebKitTestRunner/TestController.cpp:
2153         (WTR::TestController::initialize):
2154         (WTR::TestController::networkProcessName):
2155         (WTR::TestController::networkProcessDidCrash):
2156         * WebKitTestRunner/TestController.h:
2157
2158 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2159
2160         run-jsc-stress-tests --remote should create remote directory before copying the bundle
2161         https://bugs.webkit.org/show_bug.cgi?id=141329
2162
2163         Reviewed by Michael Saboff.
2164
2165         * Scripts/run-jsc-stress-tests:
2166
2167 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2168
2169         [GTK] Remove WebKitWebView::close-notification signal
2170         https://bugs.webkit.org/show_bug.cgi?id=141330
2171
2172         Reviewed by Gustavo Noronha Silva.
2173
2174         Update notifications unit tests according to the API changes, and
2175         add a test case to check that onclose event is fired when a
2176         notification is closed by the user.
2177
2178         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2179         (testWebViewNotification):
2180
2181 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2182
2183         Dashboard doesn't consider building ASan a productive step
2184         https://bugs.webkit.org/show_bug.cgi?id=141312
2185
2186         Reviewed by Simon Fraser.
2187
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2189
2190 2015-02-05  Daniel Bates  <dabates@apple.com>
2191
2192         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2193         https://bugs.webkit.org/show_bug.cgi?id=141306
2194
2195         Reviewed by Alexey Proskuryakov.
2196
2197         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2198         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2199         existent runtime.
2200
2201         * Scripts/webkitpy/xcode/simulator.py:
2202         (Runtime.from_identifier):
2203
2204 2015-02-05  Daniel Bates  <dabates@apple.com>
2205
2206         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2207         https://bugs.webkit.org/show_bug.cgi?id=139746
2208         <rdar://problem/19283658>
2209
2210         Reviewed by Alexey Proskuryakov.
2211
2212         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2213         if the simulator device is not in state Booted.
2214
2215         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2216         launching/relaunching the iOS Simulator app and a simulator app can only be installed
2217         on a device that is in the Booted state. LayoutTestRelay may run before the
2218         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
2219         We should defer executing LayoutTestRelay until the simulator device booted by
2220         iOS Simulator is in the Booted state.
2221
2222         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
2223         Simulator methods with the module name, simulator.
2224         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
2225         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
2226         before launching iOS Simulator to boot it.
2227         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
2228         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
2229         * Scripts/webkitpy/xcode/simulator.py:
2230         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
2231         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
2232         interested in the state of the device are more likely interested in the current state of the device as
2233         opposed to the state of the device when the Device object was created.
2234         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
2235         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
2236         from both this function and Simulator.device_state().
2237         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
2238         (Simulator.DeviceState): Added; class of constants.
2239         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
2240         device is in the specified state.
2241         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
2242         (Simulator.device_directory): Added.
2243         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
2244
2245 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2246
2247         Disable retries on Mac debug testers
2248         https://bugs.webkit.org/show_bug.cgi?id=141296
2249
2250         Reviewed by Simon Fraser.
2251
2252         * BuildSlaveSupport/build.webkit.org-config/config.json:
2253
2254 2015-02-05  Dan Bernstein  <mitz@apple.com>
2255
2256         Need a way to force $xcodeSDK in webkitdirs.pm
2257         https://bugs.webkit.org/show_bug.cgi?id=141291
2258
2259         Reviewed by Anders Carlsson.
2260
2261         * Scripts/webkitdirs.pm:
2262         (setXcodeSDK): Added.
2263
2264 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
2265
2266         [Streams API] Implement a barebone ReadableStream interface
2267         https://bugs.webkit.org/show_bug.cgi?id=141045
2268
2269         Reviewed by Benjamin Poulain.
2270
2271         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
2272
2273 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
2274
2275         filter-build-webkit: reduce more unfiltered output
2276         https://bugs.webkit.org/show_bug.cgi?id=141282
2277
2278         Reviewed by Daniel Bates.
2279
2280         * Scripts/filter-build-webkit:
2281         Report CompileDTraceScript and Preprocess lines as successful.
2282
2283 2015-02-04  Dana Burkart  <dburkart@apple.com>
2284
2285         Botwatcher's Dashboard is cramped
2286         https://bugs.webkit.org/show_bug.cgi?id=140273
2287
2288         Reviewed by Alexey Proskuryakov.
2289
2290         Add a heading key which will allow for arbitrary headings in builder queues.
2291
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2293         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2294         (BuildbotBuilderQueueView.prototype.update):
2295         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2297         (BuildbotIteration.prototype._parseData):
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2299         (BuildbotLeaksQueueView.prototype.update):
2300         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2302         (BuildbotPerformanceQueueView.prototype.update):
2303         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2305         (BuildbotQueue):
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2307         (BuildbotQueueView.prototype._unauthorizedAccess):
2308         (BuildbotQueueView.prototype._appendBuild):
2309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2310         (BuildbotTestResults):
2311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2312         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2313         (BuildbotTesterQueueView.prototype.update):
2314         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
2315
2316 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2317
2318         WKTR should not use -mainScreen to pick a color profile
2319         https://bugs.webkit.org/show_bug.cgi?id=141265
2320
2321         Reviewed by Tim Horton.
2322         
2323         -[NSScreen mainScreen] depends on the active window, so use the first screen
2324         (which is the one we put the window on anyway).
2325         
2326         Do some cleanup in DRT that makes the code look similar.
2327
2328         * DumpRenderTree/mac/DumpRenderTree.mm:
2329         (createWebViewAndOffscreenWindow):
2330         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2331         (WTR::PlatformWebView::PlatformWebView):
2332
2333 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2334
2335         LayoutTestHelper should set the color profile of all displays
2336         https://bugs.webkit.org/show_bug.cgi?id=141260
2337
2338         Reviewed by Tim Horton.
2339         
2340         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
2341         which is the screen with the active window. Make things more robust by changing
2342         the colorspace of all displays, not just the main screen, when running layout tests.
2343
2344         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
2345         * DumpRenderTree/mac/LayoutTestHelper.m: 
2346         (originalColorProfileURLs):
2347         (colorProfileURLForDisplay):
2348         (displayUUIDStrings):
2349         (saveDisplayColorProfiles):
2350         (setDisplayColorProfile):
2351         (restoreDisplayColorProfiles):
2352         (installLayoutTestColorProfile):
2353         (restoreUserColorProfile):
2354         (main):        
2355         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
2356         toll-free bridged, sadly). Use the map to restore all profiles on exit.
2357         Convert to use more Obj-C types.
2358
2359 2015-02-04  Daniel Bates  <dabates@apple.com>
2360
2361         test-webkitpy fails on Mac without iphoneos SDK
2362         https://bugs.webkit.org/show_bug.cgi?id=141255
2363         <rdar://problem/19619691>
2364
2365         I inadvertently committed the wrong exception message. Fix up the exception message
2366         to instruct a person to install the iOS SDK when it cannot be found.
2367
2368         * Scripts/webkitpy/port/ios.py:
2369         (IOSPort.determine_full_port_name):
2370
2371 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2372
2373         W3C test importer should sort the list of files when generating the w3c-import.log
2374         https://bugs.webkit.org/show_bug.cgi?id=141156
2375
2376         Reviewed by Bem Jones-Bey.
2377
2378         Sort explicitly the list of imported files written in the w3c-import.log.
2379         Removed logging of the import date.
2380
2381         * Scripts/webkitpy/w3c/test_importer.py:
2382         (TestImporter.write_import_log):
2383
2384 2015-02-04  Daniel Bates  <dabates@apple.com>
2385
2386         test-webkitpy fails on Mac without iphoneos SDK
2387         https://bugs.webkit.org/show_bug.cgi?id=141255
2388         <rdar://problem/19619691>
2389
2390         Reviewed by David Kilzer and Alexey Proskuryakov.
2391
2392         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
2393         should not require the iphoneos SDK to be installed to run the webkitpy tests.
2394
2395         * Scripts/webkitpy/common/system/platforminfo.py:
2396         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
2397         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
2398         to standard output if the SDK is installed to return the empty string if the SDK is
2399         not installed.
2400         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2401         (MockPlatformInfo.xcode_sdk_version): Added.
2402         * Scripts/webkitpy/port/ios.py:
2403         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
2404         to get the version of the iphoneos SDK, if installed.
2405
2406 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2407
2408         run-webkit-tests doesn't always capture ASan violation reports
2409         https://bugs.webkit.org/show_bug.cgi?id=141231
2410
2411         Reviewed by Darin Adler.
2412
2413         * Scripts/webkitpy/port/driver.py:
2414         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
2415         by the driver already (as is the case with ASan violations, which are printed to
2416         stderr).
2417         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
2418         report.
2419         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
2420         a separate variable for reporting.
2421
2422 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2423
2424         [webkitpy] Add platform specific Skipped file mechanism for performance tests
2425         https://bugs.webkit.org/show_bug.cgi?id=141152
2426
2427         Reviewed by Csaba Osztrogonác.
2428
2429         Support a test-expectation-like syntax in performance tests' skipped files.
2430         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
2431
2432         * Scripts/webkitpy/port/base.py:
2433         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
2434
2435         * Scripts/webkitpy/port/base_unittest.py:
2436         (PortTest.test_skipped_perf_tests): Test the new syntax.
2437
2438 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2439
2440         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
2441         https://bugs.webkit.org/show_bug.cgi?id=141236
2442
2443         Reviewed by Sam Weinig.
2444
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2446         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
2447
2448 2015-02-04  Chris Dumez  <cdumez@apple.com>
2449
2450         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
2451         https://bugs.webkit.org/show_bug.cgi?id=141192
2452
2453         Reviewed by Benjamin Poulain.
2454
2455         Add API tests for Vector::removeFirst(value) and
2456         Vector::removeAll(value).
2457
2458         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2459         (TestWebKitAPI::TEST):
2460
2461 2015-02-03  Tim Horton  <timothy_horton@apple.com>
2462
2463         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
2464         https://bugs.webkit.org/show_bug.cgi?id=141217
2465
2466         Reviewed by Sam Weinig.
2467
2468         * WebKitTestRunner/TestController.cpp:
2469         (WTR::copyWebCryptoMasterKey):
2470         (WTR::TestController::createOtherPage):
2471         (WTR::TestController::createWebViewWithOptions):
2472         (WTR::TestController::ensureViewSupportsOptions):
2473         (WTR::TestController::didCommitNavigation):
2474         (WTR::TestController::didFinishNavigation):
2475         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
2476         (WTR::TestController::didReceiveAuthenticationChallenge):
2477         (WTR::TestController::decidePolicyForPluginLoad):
2478         (WTR::TestController::decidePolicyForNavigationAction):
2479         (WTR::TestController::decidePolicyForNavigationResponse):
2480         (WTR::TestController::didCommitLoadForFrame): Deleted.
2481         (WTR::TestController::didFinishLoadForFrame): Deleted.
2482         * WebKitTestRunner/TestController.h:
2483         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
2484
2485 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
2486
2487         Unreviewed. Add myself as a committer.
2488
2489         * Scripts/webkitpy/common/config/contributors.json:
2490
2491 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2492
2493         [Win] Unreviewed test fix.
2494
2495         * DumpRenderTree/win/PolicyDelegate.cpp:
2496         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
2497         so was not matching expected output.
2498
2499 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2500
2501         Unreviewed. Moving myself to the committer section at last.
2502
2503         * Scripts/webkitpy/common/config/contributors.json:
2504
2505 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2506
2507         [Win] Tests fail because DRT reports '(null)' instead of an empty string
2508         https://bugs.webkit.org/show_bug.cgi?id=141205
2509
2510         Reviewed by Anders Carlsson.
2511
2512         * DumpRenderTree/win/HistoryDelegate.cpp:
2513         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
2514         properly so that we match expected DumpRenderTree output.
2515
2516 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2517
2518         [GTK] TestWebKitAccessibility is not skipped
2519         https://bugs.webkit.org/show_bug.cgi?id=141179
2520
2521         Reviewed by Carlos Garcia Campos.
2522
2523         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
2524         skipped, and it apparently works reliably on the bots.
2525
2526         * Scripts/run-gtk-tests:
2527         (TestRunner):
2528
2529 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2530
2531         run-perf-tests: allow to specify a wrapper command.
2532         https://bugs.webkit.org/show_bug.cgi?id=141172
2533
2534         Reviewed by Ryosuke Niwa.
2535
2536         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2537         (parse_args): Update text to indicate is also valid for WTR.
2538         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2539         (PerfTestsRunner._parse_args): Add wrapper command.
2540
2541 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2542
2543         [Win] Correct version parsing warning in update-webkit
2544         https://bugs.webkit.org/show_bug.cgi?id=141200
2545
2546         Reviewed by Anders Carlsson.
2547
2548         * Scripts/webkitdirs.pm:
2549         (setupAppleWinEnv): Strip out any specific version build level
2550         from the Cygwin version information.
2551   
2552
2553 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2554
2555         [Win] Attempt to improve the reliability of HTTP service
2556         https://bugs.webkit.org/show_bug.cgi?id=141191
2557
2558         Reviewed by Darin Adler.
2559
2560         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2561         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
2562         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
2563         when stopping the service doesn't do so on its own (for Windows runs).
2564
2565 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2566
2567         Web platform test server should not need to create __init__.py files
2568         https://bugs.webkit.org/show_bug.cgi?id=141030
2569
2570         Reviewed by Ryosuke Niwa.
2571
2572         W3C TestImporter ensures that copied __init__.py files are not empty.
2573         If needed, a comment is inserted in __init__.py files.
2574         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
2575
2576         * Scripts/webkitpy/common/system/filesystem.py:
2577         (FileSystem.getsize):
2578         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2579         (TestWebPlatformTestServer.test_start_cmd):
2580         (TestWebPlatformTestServer):
2581         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
2582         * Scripts/webkitpy/w3c/test_importer.py:
2583         (TestImporter.import_tests):
2584
2585 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2586
2587         Unreviewed. Moving myself to the committer section.
2588
2589         * Scripts/webkitpy/common/config/contributors.json:
2590
2591 2015-02-02  Saam Barati  <saambarati1@gmail.com>
2592
2593         Create tests for JSC's Control Flow Profiler
2594         https://bugs.webkit.org/show_bug.cgi?id=141123
2595
2596         Reviewed by Filip Pizlo.
2597
2598         * Scripts/run-javascriptcore-tests:
2599         (runJSCStressTests):
2600         * Scripts/run-jsc-stress-tests:
2601
2602 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
2603
2604         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
2605         https://bugs.webkit.org/show_bug.cgi?id=141158
2606
2607         Reviewed by Darin Adler.
2608
2609         * Scripts/run-jsc-stress-tests:
2610
2611 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2612
2613         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
2614         https://bugs.webkit.org/show_bug.cgi?id=141142
2615
2616         Reviewed by Carlos Garcia Campos.
2617
2618         * MiniBrowser/gtk/BrowserWindow.c:
2619         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
2620
2621 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2622
2623         Web platform test server is not always launching properly on Mac EWS bots
2624         https://bugs.webkit.org/show_bug.cgi?id=141141
2625
2626         Unreviewed.
2627
2628         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2629         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
2630
2631 2015-01-31  Sam Weinig  <sam@webkit.org>
2632
2633         Remove even more Mountain Lion support
2634         https://bugs.webkit.org/show_bug.cgi?id=141124
2635
2636         Reviewed by Alexey Proskuryakov.
2637
2638         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2639         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2640         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2641         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2642         * DumpRenderTree/mac/DumpRenderTree.mm:
2643         (activateTestingFonts):
2644         (prepareConsistentTestingEnvironment):
2645         * DumpRenderTree/mac/EventSendingController.mm:
2646         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2647         (-[EventSendingController contextClick]):
2648         * DumpRenderTree/mac/TextInputController.m:
2649         * LayoutTestRelay/Configurations/Base.xcconfig:
2650         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2651         * MiniBrowser/Configurations/Base.xcconfig:
2652         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2653         * MiniBrowser/mac/WK2BrowserWindowController.m:
2654         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2655         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2656         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2657         * TestWebKitAPI/Configurations/Base.xcconfig:
2658         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2659         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2660         (-[DownloadDelegate _downloadDidFinish:]):
2661         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2662         (TestWebKitAPI::TEST):
2663         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2664         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2665         * WebKitLauncher/Configurations/Base.xcconfig:
2666         * WebKitTestRunner/Configurations/Base.xcconfig:
2667         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2668         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2669         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2670         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2671         (WTR::activateFonts):
2672         * WebKitTestRunner/TestController.cpp:
2673         (WTR::TestController::initialize):
2674         (WTR::TestController::webProcessName):
2675         * WebKitTestRunner/mac/EventSenderProxy.mm:
2676         * asan/asan.xcconfig:
2677
2678 2015-01-31  Commit Queue  <commit-queue@webkit.org>
2679
2680         Unreviewed, rolling out r179408.
2681         https://bugs.webkit.org/show_bug.cgi?id=141117
2682
2683         This didn't fully fix the issue (Requested by anttik on
2684         #webkit).
2685
2686         Reverted changeset:
2687
2688         "OSObjectPtr does not work with dispatch_data_t on Maverics"
2689         https://bugs.webkit.org/show_bug.cgi?id=141081
2690         http://trac.webkit.org/changeset/179408
2691
2692 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2693
2694         https://trac.webkit.org/changeset/179439 breaks a python test
2695         https://bugs.webkit.org/show_bug.cgi?id=141114
2696
2697         Unreviewed.
2698
2699         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2700         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
2701
2702 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2703
2704         Import W3C web platform tests infrastructure
2705         https://bugs.webkit.org/show_bug.cgi?id=140934
2706
2707         Reviewed by Ryosuke Niwa.
2708
2709         Loading necessary web platform tests modules before launching server.
2710         Ensuring that some empty __init__.py files are present and create them if necessary. 
2711
2712         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2713         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2714
2715 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
2716
2717         [Win] Another unreviewed test fix.
2718
2719         Correct copy/paste error in buildbot handling.
2720
2721         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2722         (LayoutTestApacheHttpd.__init__):
2723         (LayoutTestApacheHttpd._get_apache_config_file_path):
2724
2725 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
2726
2727         [Win] Unreviewed test fix.
2728
2729         Correct path handling based on failures on test bots to get things running again.
2730
2731         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2732         (LayoutTestApacheHttpd.__init__):
2733         (LayoutTestApacheHttpd._get_apache_config_file_path):
2734
2735 2015-01-30  Chris Dumez  <cdumez@apple.com>
2736
2737         Unreviewed. Fix Windows build after r179409.
2738
2739         * DumpRenderTree/win/TestRunnerWin.cpp:
2740         (TestRunner::notifyDone):
2741         (TestRunner::queueLoad):
2742
2743 2015-01-30  Chris Dumez  <cdumez@apple.com>
2744
2745         Rename shared() static member functions to singleton() for singleton classes.
2746         https://bugs.webkit.org/show_bug.cgi?id=141088
2747
2748         Reviewed by Ryosuke Niwa and Benjamin Poulain.
2749
2750         Rename shared() static member functions to singleton() for singleton
2751         classes as per the recent coding style change.
2752
2753 2015-01-30  Antti Koivisto  <antti@apple.com>
2754
2755         OSObjectPtr does not work with dispatch_data_t on Maverics
2756         https://bugs.webkit.org/show_bug.cgi?id=141081
2757
2758         Reviewed by Pratik Solanki.
2759
2760         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2761         (TestWebKitAPI::TEST):
2762
2763 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
2764
2765         [Win] Switch to Apache on Windows
2766         https://bugs.webkit.org/show_bug.cgi?id=141060
2767
2768         Reviewed by Alexey Proskuryakov.
2769
2770         Update our scripts under Windows (and Cygwin) to locate and use
2771         the XAMPP installation of Apache for running tests.
2772
2773         * Scripts/run-webkit-httpd:
2774         * Scripts/webkitperl/httpd.pm:
2775         (getHTTPDPath):
2776         (getDefaultConfigForTestDirectory):
2777         (getHTTPDConfigPathForTestDirectory):
2778         * Scripts/webkitpy/common/system/executive_unittest.py:
2779         (ExecutiveTest.serial_test_kill_process):
2780         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2781         (LayoutTestApacheHttpd.__init__):
2782         (LayoutTestApacheHttpd._get_apache_config_file_path):
2783         (LayoutTestApacheHttpd._stop_running_server):
2784         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2785         (HttpServerBase._is_server_running_on_all_ports):
2786         * Scripts/webkitpy/port/base.py:
2787         (Port._apache_config_file_name_for_platform):
2788         * Scripts/webkitpy/port/port_testcase.py:
2789         (test_apache_config_file_name_for_platform):
2790         * Scripts/webkitpy/port/win.py:
2791         (WinPort.show_results_html_file):
2792         (WinPort._uses_apache):
2793         (WinPort):
2794         (WinPort._path_to_apache):
2795
2796 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
2797
2798         Built result takes too long to be compressed on bots
2799         https://bugs.webkit.org/show_bug.cgi?id=141056
2800
2801         Reviewed by Daniel Bates.
2802
2803         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
2804
2805         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
2806
2807 2015-01-29  Sam Weinig  <sam@webkit.org>
2808
2809         Remove support for screen font substitution
2810         https://bugs.webkit.org/show_bug.cgi?id=141038
2811
2812         Reviewed by Tim Horton.
2813
2814         * DumpRenderTree/win/DumpRenderTree.cpp:
2815         (resetWebPreferencesToConsistentValues):
2816         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
2817
2818 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2819
2820         Make run-jsc-stress-tests --remote work on Linux too
2821         https://bugs.webkit.org/show_bug.cgi?id=141000
2822
2823         Reviewed by Darin Adler.
2824
2825         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
2826         use bash/dash compatible signal names, use Linux/Mac compatible find options,
2827         use bash/dash compatible functions.
2828         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
2829
2830 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2831
2832         [buildbot] Simplify jscore-test buildstep
2833         https://bugs.webkit.org/show_bug.cgi?id=140821
2834
2835         Reviewed by Alexey Proskuryakov.
2836
2837         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2838         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
2839         (RunJavaScriptCoreTests.countFailures): Added.
2840         (RunJavaScriptCoreTests.commandComplete): Deleted.
2841         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
2842         (RunJavaScriptCoreTests.getText): Deleted.
2843         (RunJavaScriptCoreTests.getText2): Deleted.
2844         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
2845         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
2846         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
2847         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
2848         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
2849
2850 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2851
2852         Unreviewed, revert r179337, we don't need this dependency.
2853
2854         * efl/install-dependencies:
2855         * gtk/install-dependencies:
2856
2857 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
2858
2859         Unreviewed. Moving myself to the committer section.
2860
2861         * Scripts/webkitpy/common/config/contributors.json:
2862
2863 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2864
2865         URTBF after r179326, added uuid-dev package as new dependency.
2866
2867         * efl/install-dependencies:
2868         * gtk/install-dependencies:
2869
2870 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
2871
2872         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
2873         https://bugs.webkit.org/show_bug.cgi?id=140673
2874
2875         Reviewed by Sam Weinig.
2876
2877         * Scripts/dtrace/trace-webkit2-messages.d: Added.
2878         Add a DTrace script that outputs a small blob of JSON per message.
2879
2880 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
2881
2882         Removed fastMallocForbid / fastMallocAllow
2883         https://bugs.webkit.org/show_bug.cgi?id=141012
2884
2885         Reviewed by Mark Hahnenberg.
2886
2887         Fixed a test bug I noticed while testing.
2888
2889         * DumpRenderTree/JavaScriptThreading.cpp:
2890         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
2891         accessing javaScriptThreads -- otherwise, you'll ASSERT.
2892
2893 2015-01-28  Dana Burkart  <dburkart@apple.com>
2894
2895         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
2896         https://bugs.webkit.org/show_bug.cgi?id=141015
2897
2898         Reviewed by Alexey Proskuryakov.
2899
2900         * asan/asan.xcconfig:
2901
2902 2015-01-28  Sam Weinig  <sam@webkit.org>
2903
2904         Fix the build.
2905
2906         * Scripts/copy-webkitlibraries-to-product-directory:
2907
2908 2015-01-28  Lucas Forschler  <lforschler@apple.com>
2909
2910         Increase the FileUpload block size in an attempt to improve network performance.
2911         
2912         Reviewed by Alexey Proskuryakov.
2913         
2914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2915         (UploadBuiltProduct.__init__):
2916
2917 2015-01-28  Dana Burkart  <dburkart@apple.com>
2918
2919         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
2920         https://bugs.webkit.org/show_bug.cgi?id=136765
2921
2922         Reviewed by Alexey Proskuryakov.
2923
2924         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2925         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2926         * LayoutTestRelay/Configurations/Base.xcconfig:
2927         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2928         * MiniBrowser/Configurations/Base.xcconfig:
2929         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2930         * TestWebKitAPI/Configurations/Base.xcconfig:
2931         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2932         * WebKitLauncher/Configurations/Base.xcconfig:
2933         * WebKitTestRunner/Configurations/Base.xcconfig:
2934         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2935
2936 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
2937
2938         AX: [ATK] Implement support for new AtkRole types for MathML
2939         https://bugs.webkit.org/show_bug.cgi?id=140916
2940
2941         Reviewed by Chris Fleizach.
2942
2943         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
2944         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
2945
2946 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2947
2948         [GTK] Stop removing color marks from unit tests output
2949         https://bugs.webkit.org/show_bug.cgi?id=140996
2950
2951         Reviewed by Philippe Normand.
2952
2953         Since r178236 google tests use a custom simplified output without
2954         any colors, so we don't need to handle the case of non ttys to
2955         remove the color marks.
2956
2957         * Scripts/run-gtk-tests:
2958         (TestRunner.__init__):
2959         (TestRunner._run_test_command.parse_line):
2960
2961 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2962
2963         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
2964         https://bugs.webkit.org/show_bug.cgi?id=131731
2965
2966         Reviewed by Žan Doberšek.
2967
2968         A web page loaded offscreen is in prerender state not hidden.
2969
2970         * Scripts/run-gtk-tests:
2971         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
2972         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2973         (testWebViewPageVisibility):
2974
2975 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2976
2977         Partially revert r178802.
2978
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
2981
2982 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2983
2984         build.webkit.org/dashboard asserts on some commits
2985         https://bugs.webkit.org/show_bug.cgi?id=140926
2986
2987         Reviewed by Tim Horton.
2988
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2990         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
2991
2992 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2993
2994         Make flakiness dashboard OS list actually match test_expectations.py
2995         https://bugs.webkit.org/show_bug.cgi?id=140969
2996
2997         Reviewed by Ryosuke Niwa.
2998
2999         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3000
3001 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
3002
3003         [Win] WinLauncher crashes on eleventh site visited
3004         https://bugs.webkit.org/show_bug.cgi?id=140960
3005
3006         Reviewed by Anders Carlsson.
3007
3008         * WinLauncher/WinLauncher.cpp:
3009         (WinLauncher::showLastVisitedSites): Don't access off the end of
3010         the history array.
3011
3012 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3013
3014         [Mac] Disable building Java applets by default
3015         https://bugs.webkit.org/show_bug.cgi?id=140957
3016         rdar://problem/19619529
3017
3018         Reviewed by Anders Carlsson.
3019
3020         It was actually already disabled unconditionally, by accident.
3021
3022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3023         * Scripts/webkitpy/port/mac.py:
3024         (MacPort._check_port_build):
3025         (MacPort._build_java_test_support):
3026
3027 2015-01-27  Daniel Bates  <dabates@apple.com>
3028
3029         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3030         https://bugs.webkit.org/show_bug.cgi?id=140949
3031
3032         Reviewed by Alexey Proskuryakov.
3033
3034         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3035         builders so that run-webkit-tests can lint the appropriate TestExpectation
3036         files.
3037
3038         * Scripts/webkitpy/port/builders.py:
3039         * Scripts/webkitpy/port/ios.py:
3040         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3041         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3042         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3043         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3044         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3045         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3046         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3047
3048
3049 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3050
3051         Update bots on the flakiness dashboard
3052         https://bugs.webkit.org/show_bug.cgi?id=140956
3053
3054         Reviewed by Ryosuke Niwa.
3055
3056         * TestResultServer/static-dashboards/builders.jsonp:
3057         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3058
3059 2015-01-27  Daniel Bates  <dabates@apple.com>
3060
3061         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3062         https://bugs.webkit.org/show_bug.cgi?id=140942
3063
3064         Reviewed by Alexey Proskuryakov.
3065
3066         The directory LayoutTests/platform/wk2 contains test expectations and test results that
3067         are applicable to all WebKit2 ports. We should make use of this information when
3068         running layout tests using iOS WebKit2.
3069
3070         Additionally, make use of the convenience function Port._wk2_port_name() for the name
3071         of the WebKit2 port instead of directly using string concatenation.
3072
3073         * Scripts/webkitpy/port/ios.py:
3074         (IOSSimulatorPort.default_baseline_search_path):
3075
3076 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
3077
3078         [Win] Disable FTL stress tests
3079         https://bugs.webkit.org/show_bug.cgi?id=140932
3080
3081         Reviewed by Brent Fulgham.
3082
3083         * Scripts/run-javascriptcore-tests:
3084
3085 2015-01-27  Daniel Bates  <dabates@apple.com>
3086
3087         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3088         https://bugs.webkit.org/show_bug.cgi?id=140939
3089
3090         Reviewed by Eric Carlson.
3091
3092         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3093
3094         * Scripts/webkitdirs.pm:
3095         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3096         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3097         and define a function called wanted.
3098
3099 2015-01-27  Daniel Bates  <dabates@apple.com>
3100
3101         Teach run-webkit-app --simulator how to install custom built app
3102         https://bugs.webkit.org/show_bug.cgi?id=140691
3103
3104         Fix inadvertent omission of directory test flag in expression to check for the
3105         existence of the iOS simulator device-specific directory for user installed apps.
3106
3107         * Scripts/webkitdirs.pm:
3108         (hasUserInstalledAppInSimulatorDevice):
3109
3110 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
3111
3112         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3113         https://bugs.webkit.org/show_bug.cgi?id=87426
3114         <rdar://problem/11527899>
3115
3116         Reviewed by Darin Adler.
3117
3118         Revise COMPtr to work better with our HashMap implementation. Use
3119         modern loop syntax.
3120
3121         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3122         (AccessibilityController::~AccessibilityController):
3123         (AccessibilityController::winNotificationReceived):
3124         * DumpRenderTree/win/DumpRenderTree.cpp:
3125         (dumpBackForwardListForAllWindows):
3126
3127 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3128
3129         [Win] Enable JSC stress tests by default
3130         https://bugs.webkit.org/show_bug.cgi?id=128307
3131
3132         Reviewed by Brent Fulgham.
3133
3134         * Scripts/run-javascriptcore-tests:
3135
3136 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3137
3138         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
3139         arguments for build and test scripts
3140         https://bugs.webkit.org/show_bug.cgi?id=139748
3141
3142         Reviewed by Daniel Bates.
3143
3144         There was much confusion resulting from the multitude of aliases used to build/test for
3145         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
3146         tests directory.
3147
3148         This fixes an issue where run-api-tests and some other scripts failed when run with
3149         --simulator.
3150
3151         * Scripts/build-webkit:
3152         * Scripts/package-root:
3153         (usage):
3154         * Scripts/webkitdirs.pm:
3155         (argumentsForConfiguration):
3156         (determineXcodeSDK):
3157         * Scripts/webkitpy/port/factory.py:
3158         (platform_options):
3159
3160 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3161
3162         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
3163         https://bugs.webkit.org/show_bug.cgi?id=140203
3164         rdar://problem/19198492
3165
3166         Reviewed by Sam Weinig.
3167
3168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3169         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
3170         (TEST):
3171
3172 2015-01-26  David Kilzer  <ddkilzer@apple.com>
3173
3174         Add iOS EWS to build.webkit.org/dashboard
3175         <http://webkit.org/b/140627>
3176
3177         Reviewed by Alexey Proskuryakov.
3178
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
3181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3182         (BubbleQueueServer): Add ios-ews queue info.
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3184         Add iOS8Device platform.
3185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3186         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
3187         iOS device logo.
3188
3189 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
3190
3191         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
3192         https://bugs.webkit.org/show_bug.cgi?id=140896
3193
3194         Reviewed by Michael Saboff.
3195         
3196         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
3197         makes our script do this.
3198         
3199         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
3200         this would be harder given llvm's autoconf setup.
3201
3202         * Scripts/copy-webkitlibraries-to-product-directory:
3203
3204 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3205
3206         Update bot assignments.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/config.json:
3209
3210 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3211
3212         Integrate WP python server into WebKit test framework
3213         https://bugs.webkit.org/show_bug.cgi?id=127094
3214
3215         Reviewed by Ryosuke Niwa.
3216
3217         This patch adds W3C web server (wptserver) as a new HTTP server.
3218         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
3219         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
3220
3221         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
3222         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
3223         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
3224
3225         * Scripts/webkitpy/common/system/executive_mock.py:
3226         (MockProcess.communicate):
3227         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
3228         (LayoutTestRunner.__init__):
3229         (LayoutTestRunner.run_tests):
3230         (LayoutTestRunner.start_servers):
3231         (LayoutTestRunner.stop_servers):
3232         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
3233         (LayoutTestRunnerTests._run_tests):
3234         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
3235         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
3236         (LayoutTestRunnerTests):
3237         (LayoutTestRunnerTests.test_servers_started):
3238         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
3239         (Manager.__init__):
3240         (Manager._is_http_test):
3241         (Manager._is_web_platform_test):
3242         (Manager._run_tests):
3243         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3244         (ManagerTest.test_needs_servers.get_wpt_doc_root):
3245         (ManagerTest.test_needs_servers.get_manager):
3246         (ManagerTest.test_needs_servers):
3247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
3248         (parse_args):
3249         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
3250         (main):
3251         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
3252         (doc_root):
3253         (base_url):
3254         (WebPlatformTestServer):
3255         (WebPlatformTestServer.__init__):
3256         (WebPlatformTestServer._set_start_cmd):
3257         (WebPlatformTestServer._copy_webkit_test_files):
3258         (WebPlatformTestServer._clean_webkit_test_files):
3259         (WebPlatformTestServer._prepare_config):
3260         (WebPlatformTestServer._spawn_process):
3261         (WebPlatformTestServer._stop_running_server):
3262         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
3263         (TestWebPlatformTestServer):
3264         (TestWebPlatformTestServer.test_start_cmd):
3265         * Scripts/webkitpy/port/base.py:
3266         (Port.__init__):
3267         (Port.to.start_web_platform_test_server):
3268         (Port.to):
3269         (Port.to.web_platform_test_server_doc_root):
3270         (Port.to.web_platform_test_server_base_url):
3271         (Port.to.stop_web_platform_test_server):
3272         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
3273         (Driver.__init__):
3274         (Driver.is_web_platform_test):
3275         (Driver.test_to_uri):
3276         (Driver.uri_to_test):
3277         (Driver._command_from_driver_input):
3278         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
3279         (DriverTest.test_test_to_uri):
3280         (DriverTest.test_uri_to_test):
3281
3282 2015-01-26  Daniel Bates  <dabates@apple.com>
3283
3284         Teach run-webkit-app --simulator how to install custom built app
3285         https://bugs.webkit.org/show_bug.cgi?id=140691
3286
3287         Reviewed by David Kilzer.
3288
3289         We should teach run-webkit-app --simulator how to install a custom built app.
3290
3291         Currently run-webkit-app --simulator can only run a system app or an app that
3292         was installed using the simctl command line tool. For convenience we should
3293         teach run-webkit-app --simulator how to install a custom built app.
3294
3295         As a side effect of this change run-safari --simulator will install and run
3296         a custom built of MobileSafari (if it exists).
3297
3298         * Scripts/webkitdirs.pm:
3299         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
3300         Perl from the structure of the device.plist file.
3301         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
3302         file system check to determine the plist path for a Mac app bundle.
3303         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
3304         it will complain that it cannot find the file: "Domain ... does not exist".
3305         (appDisplayNameFromBundle): Ditto.
3306         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
3307         until a simulator device is the specified state.
3308         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
3309         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
3310         the specified device.
3311         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
3312         As implied by its name, this function will not return until the specified simulator
3313         device UDID is in the shutdown state.
3314         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
3315         device with the specified UDID.
3316         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
3317         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
3318         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
3319         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
3320         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
3321         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
3322         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
3323         (hasUserInstalledAppInSimulatorDevice): Added.
3324         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
3325         "Booted" state.
3326         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
3327         switching between a system installed app and a custom built version of the same app (e.g.
3328         custom build of MobileSafari) will erase all contents and settings in the simulator device.
3329         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
3330         as that was the only caller of this function.
3331         (bootedIOSSimulatorDevice): Deleted.
3332         (openIOSSimulator): Deleted.
3333
3334 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3335
3336         Update bot assignments.
3337
3338         * BuildSlaveSupport/build.webkit.org-config/config.json:
3339
3340 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3341
3342         Leaks bot shouldn't run JSC tests
3343         https://bugs.webkit.org/show_bug.cgi?id=140877
3344
3345         Reviewed by Darin Adler.
3346
3347         Shaves off 48 minutes of time.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3350         (TestLeaksFactory): Slim down the leaks queue.
3351
3352         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3353         * Scripts/webkitpy/port/ios.py:
3354         (IOSSimulatorPort.print_leaks_summary):
3355         * Scripts/webkitpy/port/mac.py:
3356         (MacPort.print_leaks_summary):
3357         Don't yell when leaks are detected.
3358
3359 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3360
3361         Refactor run-javascriptcore-tests
3362         https://bugs.webkit.org/show_bug.cgi?id=140824
3363
3364         Reviewed by Darin Adler.
3365
3366         Separated mozilla, stress test code paths and
3367         determining skipped mozilla tests into subroutines.
3368
3369         * Scripts/run-javascriptcore-tests:
3370         (runMozillaTests):
3371         (runJSCStressTests):
3372         (defaultJsDriverArgsForMozillaTests):
3373
3374 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3375
3376         [buildbot] Fix grammar of TestWithFailureCount
3377         https://bugs.webkit.org/show_bug.cgi?id=140884
3378
3379         Reviewed by Alexey Proskuryakov.
3380
3381         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3382         (TestWithFailureCount):
3383         (TestWithFailureCount.commandComplete):
3384         (TestWithFailureCount.getText2):
3385         (RunUnitTests):
3386         (RunPythonTests):
3387         (RunPerlTests):
3388         (RunLLINTCLoopTests):
3389         (Run32bitJSCTests):
3390         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3391         (RunLLINTCLoopTestsTest.test_failure):
3392         (Run32bitJSCTestsTest.test_failure):
3393         (RunUnitTestsTest.assertFailures):
3394
3395 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3396
3397         Unreviewed. Moving myself to the committer section.
3398
3399         * Scripts/webkitpy/common/config/contributors.json:
3400
3401 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
3402
3403         [GTK] gtkdoc does not appear in DevHelp
3404         https://bugs.webkit.org/show_bug.cgi?id=139369
3405
3406         Reviewed by Philippe Normand.
3407
3408         * gtk/generate-gtkdoc: Create the generators in the main function
3409         and use them to get the local cross renference dependencies. Also
3410         pass the generator module name to webkitdom.write_doc_files().
3411         (get_gtkdoc_module_paths): Receive a list of local cross reference
3412         dependencies.
3413         (get_generator_for_config): Set the main_sgml_file property of the
3414         GtkDoc object from the configuration file.
3415         (generate_documentation): Generate the documentation for the given
3416         generator.
3417         (generate_documentation_for_config): Deleted.
3418         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
3419         * gtk/webkitdom.py:
3420         (write_doc_files): Receive the module name used to build the
3421         -sections.txt filename.
3422
3423 2015-01-26  Commit Queue  <commit-queue@webkit.org>
3424
3425         Unreviewed, rolling out r179107.
3426         https://bugs.webkit.org/show_bug.cgi?id=140880
3427
3428         The GCC in the bots doesn't support the AsyncTask
3429         implementation (Requested by KaL on #webkit).
3430
3431         Reverted changeset:
3432
3433         "[GTK] Enable IndexedDB"
3434         https://bugs.webkit.org/show_bug.cgi?id=98932
3435         http://trac.webkit.org/changeset/179107
3436
3437 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3438
3439         [EFL] Bump libseccomp version to 2.1.1
3440         https://bugs.webkit.org/show_bug.cgi?id=140357
3441
3442         Reviewed by Gyuyoung Kim.
3443
3444         * efl/jhbuild.modules:
3445
3446 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3447
3448         [GTK] Enable IndexedDB
3449         https://bugs.webkit.org/show_bug.cgi?id=98932
3450
3451         Reviewed by Žan Doberšek.
3452
3453         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
3454
3455 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
3456
3457         Would like leaks bot results at build.webkit.org/dashboard
3458         https://bugs.webkit.org/show_bug.cgi?id=122657
3459
3460         Reviewed by Darin Adler.
3461
3462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3463         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
3464         than necessary, could use the ones from buildbot in more places.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3467         (BuildbotQueue): Reflect configuration option for leaks queues.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3470         Add leaks queues to performance column. First, leaks are about performance indeed,
3471         and second, this is where we have some space to spare.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3474         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
3475         least a year.
3476
3477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3478         (table.queue-grid td): Moved height from queue-view - we can now have more than one
3479         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
3480         results - once the results are loaded, all rows are currently higher than that.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3483         (.leaks-popover): Added.
3484
3485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3486         Added.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3489         Load BuildbotLeaksQueueView.js.
3490
3491 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
3492
3493         [Win] Add WebKit message loop interface.
3494         https://bugs.webkit.org/show_bug.cgi?id=140857
3495
3496         Reviewed by Brent Fulgham.
3497
3498         Added message loop interface which will run the message loop,
3499         and perform required tasks (like calling CFRunLoopRunInMode)
3500         on each iteration of the loop.
3501
3502         * WinLauncher/WinMain.cpp:
3503         (wWinMain): Use new message loop interface.
3504
3505 2015-01-24  Dan Bernstein  <mitz@apple.com>
3506
3507         update-webkit’s --internal option is unused
3508         https://bugs.webkit.org/show_bug.cgi?id=140861
3509
3510         Reviewed by Anders Carlsson.
3511
3512         * Scripts/update-webkit: Removed the option.
3513
3514 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
3515
3516         DumpRenderTree needs to run with Windows native controls on Windows
3517         https://bugs.webkit.org/show_bug.cgi?id=25592
3518
3519         Reviewed by Anders Carlsson.
3520
3521         * DumpRenderTree/win/DumpRenderTree.cpp:
3522         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
3523         (prepareConsistentTestingEnvironment): Ditto.
3524
3525 2015-01-23  David Kilzer  <ddkilzer@apple.com>
3526
3527         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
3528         <http://webkit.org/b/140787>
3529
3530         Reviewed by Daniel Bates.
3531
3532         * Scripts/webkitpy/port/ios.py:
3533         (IOSPort.determine_full_port_name): Instead of checking the type
3534         of the current host, test if /usr/bin/xcrun exists before trying
3535         to use it.
3536
3537 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
3538
3539         Fix the false positive build failures on the Windows buildbots
3540         https://bugs.webkit.org/show_bug.cgi?id=140819
3541
3542         Reviewed by Brent Fulgham.
3543
3544         Increase the build timeout (without producing output) to 2 hours for Windows bots,
3545         the default 20 minutes is enough for others since they produce output during the build.
3546
3547         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3548         (BuildFactory.__init__):
3549
3550 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
3551
3552         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
3553         https://bugs.webkit.org/show_bug.cgi?id=140839
3554
3555         Reviewed by Dean Jackson.
3556
3557         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3558         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
3559         from the IA2Locale structure and pass it to DRT.
3560
3561 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
3562
3563         [Win] Update DRT Accessibility implementation to better match Mac.
3564         https://bugs.webkit.org/show_bug.cgi?id=140830
3565
3566         Reviewed by Dean Jackson.
3567
3568         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3569         (AccessibilityUIElement::titleUIElement):
3570         (AccessibilityUIElement::parentElement):
3571         (convertToDRTLabel):
3572         (AccessibilityUIElement::role):
3573         (AccessibilityUIElement::title):
3574         (AccessibilityUIElement::description):
3575         (AccessibilityUIElement::stringValue):
3576         (AccessibilityUIElement::helpText):
3577         (AccessibilityUIElement::isFocused):
3578
3579 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
3580
3581         REGRESSION: run-perf-tests --profiler= seems to have broken
3582         https://bugs.webkit.org/show_bug.cgi?id=113528
3583
3584         Reviewed by Daniel Bates.
3585
3586         The problem is that "perf --record" (or the equivalent call for
3587         other profilers) is never called whenever there is a wrapper
3588         option in the port. We should inject the profiler call first
3589         (should it exists) and then use the port wrapper.
3590
3591         * Scripts/webkitpy/port/driver.py:
3592         (Driver._command_wrapper):
3593         * Scripts/webkitpy/port/driver_unittest.py:
3594         (DriverTest.test_profiler_and_wrapper): New unit test.
3595
3596 2015-01-22  David Kilzer  <ddkilzer@apple.com>
3597
3598         configure-xcode-for-ios-development needs to import webkitdirs.pm
3599         <http://webkit.org/b/140704>
3600
3601         Fixes the following runtime error:
3602
3603             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
3604
3605         * Scripts/configure-xcode-for-ios-development: Add back code to
3606         import webkitdirs.pm for the exitStatus() method.  Not sure why
3607         I removed it before patch review.
3608
3609 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
3610
3611         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
3612         https://bugs.webkit.org/show_bug.cgi?id=140795
3613
3614         Reviewed by Jon Honeycutt.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/config.json:
3617         r178847 accidentally remove the scheduler for this bot. Re-add it to the
3618         Yosemite scheduler.
3619
3620 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
3621
3622         [Win] Expose missing editing features through WebView interface
3623         https://bugs.webkit.org/show_bug.cgi?id=140773
3624         <rdar://problem/19565421>
3625
3626         Reviewed by Dean Jackson.
3627
3628         Connect the various WebView editing delegate methods to our
3629         test infrastructure. Also prefer _bstr_t to raw BSTR types
3630         to simplify life cycle management.
3631
3632         * DumpRenderTree/win/DumpRenderTree.cpp:
3633         (resetWebViewToConsistentStateBeforeTesting):
3634         * DumpRenderTree/win/EditingDelegate.cpp:
3635         (EditingDelegate::QueryInterface):
3636         (dumpPath):
3637         (dump):
3638         (EditingDelegate::shouldBeginEditingInDOMRange):
3639         (EditingDelegate::shouldEndEditingInDOMRange):
3640         (EditingDelegate::shouldInsertNode):
3641         (EditingDelegate::shouldInsertText):
3642         (EditingDelegate::shouldDeleteDOMRange):
3643         (EditingDelegate::shouldChangeSelectedDOMRange):
3644         (EditingDelegate::shouldApplyStyle):
3645         (EditingDelegate::shouldChangeTypingStyle):
3646         (EditingDelegate::doPlatformCommand):
3647         (EditingDelegate::webViewDidBeginEditing):
3648         (EditingDelegate::webViewDidChange):
3649         (EditingDelegate::webViewDidEndEditing):
3650         (EditingDelegate::webViewDidChangeTypingStyle):
3651         (EditingDelegate::webViewDidChangeSelection):
3652         (EditingDelegate::checkSpellingOfString):
3653         (EditingDelegate::onNotify):
3654         * DumpRenderTree/win/EditingDelegate.h:
3655
3656 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
3657
3658         Add a build flag for ES6 class syntax
3659         https://bugs.webkit.org/show_bug.cgi?id=140760
3660
3661         Reviewed by Michael Saboff.
3662
3663         * Scripts/webkitperl/FeatureList.pm:
3664
3665 2015-01-22  Daniel Bates  <dabates@apple.com>
3666
3667         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
3668         runtime in simctl output
3669         https://bugs.webkit.org/show_bug.cgi?id=140751
3670
3671         Reviewed by David Kilzer.
3672
3673         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
3674         with an error because it does not know how to parse the output of the simctl tool
3675         to identify an Apple Internal runtime.
3676
3677         * Scripts/webkitpy/xcode/simulator.py:
3678         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
3679         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
3680         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
3681         the runtime is an internal runtime.
3682         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
3683         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
3684         appropriate value.
3685         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
3686         it updates the appropriate Runtime object.
3687         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
3688         looking up a Runtime object for an internal runtime.
3689
3690 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
3691
3692         LeaksViewer doesn't show recent builds if there are less than 10
3693         https://bugs.webkit.org/show_bug.cgi?id=140716
3694
3695         Reviewed by Tim Horton.
3696
3697         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3698
3699 2015-01-22  Lucas Forschler  <lforschler@apple.com>
3700
3701         Add Apple build slaves.
3702         Fixed text alignment for slave list.
3703         
3704         Unreviewed.
3705         
3706         * BuildSlaveSupport/build.webkit.org-config/config.json:
3707
3708 2015-01-21  Lucas Forschler  <lforschler@apple.com>
3709
3710         Teach build.webkit.org about bot308 and bot309.
3711         
3712         Unreviewed.
3713         
3714         * BuildSlaveSupport/build.webkit.org-config/config.json:
3715
3716 2015-01-21  Lucas Forschler  <lforschler@apple.com>
3717
3718         Add two Apple Mavericks slaves.
3719         
3720         Unreviewed.
3721         
3722         * BuildSlaveSupport/build.webkit.org-config/config.json:
3723
3724 2015-01-21  Daniel Bates  <dabates@apple.com>
3725
3726         Add iOS WebKit1 TestExpectation file
3727         https://bugs.webkit.org/show_bug.cgi?id=140739
3728
3729         Reviewed by David Kilzer.
3730
3731         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
3732         expectations in directory LayoutTests/platform/ios-simulator-wk1.
3733
3734         * Scripts/webkitpy/port/ios.py:
3735         (IOSSimulatorPort.default_baseline_search_path):
3736
3737 2015-01-21  David Kilzer  <ddkilzer@apple.com>
3738
3739         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
3740         <http://webkit.org/b/140704>
3741
3742         Reviewed by Daniel Bates.
3743
3744         * Scripts/configure-xcode-for-ios-development:
3745         - Update copyright.
3746         - Remove FIXME addressed by r178709.
3747         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
3748         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
3749         missing headers from iphonesimulator SDK to iphoneos SDK.
3750         (sdkDirectory): Add method that returns SDK directory.
3751         (sdkPlatformDirectory): Extract method from
3752         xcodeSDKSpecificationsPath() that returns SDK platform
3753         directory.
3754         (xcodeSDKSpecificationsPath): Update to use
3755         sdkPlatformDirectory().
3756
3757 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
3758
3759         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
3760         https://bugs.webkit.org/show_bug.cgi?id=140731
3761
3762         Reviewed by Tim Horton.
3763
3764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3765         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
3766
3767 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
3768
3769         [Win] eventSender does not support scalePageBy
3770         https://bugs.webkit.org/show_bug.cgi?id=140726
3771         <rdar://problem/19549865>
3772
3773         Reviewed by Dean Jackson.
3774
3775         * DumpRenderTree/win/EventSender.cpp:
3776         (scalePageByCallback): Provide implementation using new WebView method.
3777
3778 2015-01-21  Lucas Forschler  <lforschler@apple.com>
3779
3780         Remove Apple Mountain Lion Build & Test slaves.
3781         
3782         Unreviewed.
3783
3784         * BuildSlaveSupport/build.webkit.org-config/config.json:
3785
3786 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
3787
3788         Remove ENABLE(INSPECTOR) ifdef guards
3789         https://bugs.webkit.org/show_bug.cgi?id=140668
3790
3791         Reviewed by Darin Adler.
3792
3793         * DumpRenderTree/mac/TestRunnerMac.mm:
3794         (TestRunner::showWebInspector):
3795         (TestRunner::closeWebInspector):
3796         (TestRunner::evaluateInWebInspector):
3797         * Scripts/webkitperl/FeatureList.pm:
3798         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3799         (WTR::TestRunner::showWebInspector):
3800         (WTR::TestRunner::closeWebInspector):
3801         (WTR::TestRunner::evaluateInWebInspector):
3802         * WebKitTestRunner/TestInvocation.cpp:
3803         (WTR::TestInvocation::invoke):
3804
3805 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
3806
3807         Update build.webkit.org/dashboard to match current Mac queues.
3808
3809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
3810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
3811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
3812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
3813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3814         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3816         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
3817         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
3818
3819 2015-01-20  Lucas Forschler  <lforschler@apple.com>
3820
3821         Update Apple MountainLion Leaks slave to Yosemite
3822         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
3823         
3824         Unreviewed.
3825
3826         * BuildSlaveSupport/build.webkit.org-config/config.json:
3827
3828 2015-01-20  Lucas Forschler  <lforschler@apple.com>
3829
3830         Update LeaksViewer from MountainLion to Yosemite
3831         
3832         Reviewed by Alexey Proskuryakov.
3833
3834         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3835         (LeaksViewer._displayURLPrompt):
3836
3837 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
3838
3839         Fix EWS python unit tests and address code comments as per 140476
3840         https://bugs.webkit.org/show_bug.cgi?id=140637
3841
3842         Reviewed by David Kilzer.
3843
3844         * Scripts/webkitpy/port/base.py:
3845         (Port):
3846         (Port.__init__):
3847         Adds DEFAULT_ARCHITECTURE member.
3848         (Port.architecture):
3849         Removes architecture member and instead uses
3850         self.get_option('architecture'). Also removes redundant architecture
3851         method.
3852         (Port.set_architecture):
3853         Adds a setter for the architecture variable to be able to set a flag
3854         upon modification.
3855         (Port.test_configuration):
3856         Uses self.architecture() instead of self._architecture.
3857         * Scripts/webkitpy/port/ios.py:
3858         Overrides DEFAULT_ARCHITECTURE.
3859         (IOSPort):
3860         (IOSPort.determine_full_port_name):
3861         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
3862         strip. Fixes regex to not match arbitrary characters after the
3863         relevent digits are matched.
3864         (IOSPort.__init__):
3865         Removes old _architecture defaulting strategy.
3866         (IOSPort._build_driver_flags):
3867         Uses self.architecture() instead of self._architecture.
3868         (IOSSimulatorPort):
3869         Overrides DEFAULT_ARCHITECTURE.
3870         (IOSSimulatorPort.__init__):
3871         Removes old _architecture defaulting strategy.
3872         * Scripts/webkitpy/port/mac.py:
3873         (MacPort):
3874         Overrides DEFAULT_ARCHITECTURE.
3875         (MacPort.__init__):
3876         Removes old _architecture defaulting strategy.
3877         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3878         (AbstractEarlyWarningSystem.run_command):
3879         Checks the did_override_architecture flag to determine whether to add
3880         the --architecture option.
3881         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3882         Uses ews.architecture rather than trying to discern the correct
3883         architecture using a port object.
3884         (EarlyWarningSystemTest._default_expected_logs):
3885         * Scripts/webkitpy/tool/commands/queues.py:
3886         Removes use of optparse, and removes the import statement.
3887         (AbstractQueue.__init__):
3888         (PatchProcessingQueue.begin_work_queue):
3889
3890 2015-01-20  Sam Weinig  <sam@webkit.org>
3891
3892         Attempt to fix Mountain Lion and EFL tests.
3893
3894         * WebKitTestRunner/TestController.cpp:
3895         (WTR::TestController::initialize):
3896         Disable Process-per-tab and network process on Mountain Lion and EFL.
3897
3898 2015-01-20  Darin Adler  <darin@apple.com>
3899
3900         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
3901         https://bugs.webkit.org/show_bug.cgi?id=140679
3902
3903         Reviewed by Anders Carlsson.
3904
3905         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3906         Removed a reference to SVGElementInstanceList.
3907
3908 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3909
3910         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
3911         https://bugs.webkit.org/show_bug.cgi?id=140028
3912
3913         Reviewed by Carlos Garcia Campos.
3914
3915         This won't work as expected, since this function is called before the
3916         WebViewTest constructor completes.
3917
3918         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3919
3920 2015-01-20  David Kilzer  <ddkilzer@apple.com>
3921
3922         configure-xcode-for-ios-development needs to update iPhoneOS SDK
3923         <http://webkit.org/b/140661>
3924
3925         Reviewed by Daniel Bates.
3926
3927         * Scripts/configure-xcode-for-ios-development: Add for() loop to
3928         run createXcodeSpecificationFilesForSDKIfNeeded() for both
3929         "iphoneos" and "iphonesimulator" SDKs.
3930         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
3931         the main body of the script.
3932
3933 2015-01-20  Tomas Popela  <tpopela@redhat.com>
3934
3935         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
3936         https://bugs.webkit.org/show_bug.cgi?id=139443
3937
3938         Reviewed by Carlos Garcia Campos.
3939
3940         Create the new test cases for setting the editable property on the web
3941         view and on the contenteditable enabled document. Also rework the
3942         current tests that are expecting that the web view is editable.
3943
3944         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3945         (loadTestHtml):
3946         (testWebViewEditorCutCopyPasteNonEditable):
3947         (testWebViewEditorCutCopyPasteEditable):
3948         (testWebViewEditorSelectAllNonEditable):
3949         (testWebViewEditorSelectAllEditable):
3950         (runEditorEditableCutTests):
3951         (testWebViewEditorEditableOnNonEditable):
3952         (testWebViewEditorEditableOnContentEditable):
3953         (testWebViewEditorNonEditable):
3954         (beforeAll):
3955         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3956         (WebViewTest::isEditable):
3957         (WebViewTest::setEditable):
3958
3959 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3960
3961         [GTK] Add an option to create WebKitWebView snapshots with transparent background
3962         https://bugs.webkit.org/show_bug.cgi?id=140617
3963
3964         Reviewed by Gustavo Noronha Silva.
3965
3966         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3967         (testWebViewSnapshot): Check that the same snapshot with
3968         transparent background is different than the default one filled
3969         with white.
3970
3971 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3972
3973         [GTK] Add API to change the WebKitWebView background color
3974         https://bugs.webkit.org/show_bug.cgi?id=140610
3975
3976         Reviewed by Gustavo Noronha Silva.
3977
3978         Add --bg-color command line option to MiniBrowser to be able to
3979         manually test the API passing any RGBA color to MiniBrowser.
3980         Also add a simple unit test to check that getting and setting
3981         colors from the API point of view.
3982
3983         * MiniBrowser/gtk/BrowserWindow.c:
3984         (browser_window_set_background_color):
3985         * MiniBrowser/gtk/BrowserWindow.h:
3986         * MiniBrowser/gtk/main.c:
3987         (createBrowserWindow):
3988         (parseBackgroundColor):
3989         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3990         (testWebViewBackgroundColor):
3991         (beforeAll):
3992
3993 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
3994
3995         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
3996         https://bugs.webkit.org/show_bug.cgi?id=140665
3997
3998         Reviewed by Brian Burg.
3999
4000         * DumpRenderTree/win/UIDelegate.cpp:
4001         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
4002         match expected test output.
4003
4004 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
4005
4006         Remove the support for custom suffixes on ChangeLog
4007         https://bugs.webkit.org/show_bug.cgi?id=140648
4008
4009         Reviewed by David Kilzer.
4010
4011         Custom suffixes were used for the iOS branch of WebKit.
4012         Now that everything is opensource, there is no need for it.
4013
4014         * Scripts/VCSUtils.pm:
4015         (changeLogSuffix): Deleted.
4016         (changeLogFileName): Deleted.
4017         * Scripts/commit-log-editor:
4018         * Scripts/prepare-ChangeLog:
4019         (getLatestChangeLogs):
4020         (generateNewChangeLogs):
4021         (generateFileList):
4022         * Scripts/resolve-ChangeLogs:
4023         (findChangeLog):
4024
4025 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
4026
4027         Adjust naming of action menu SPI
4028         https://bugs.webkit.org/show_bug.cgi?id=140644
4029         <rdar://problem/19448129>
4030
4031         Reviewed by Brian Weinstein.
4032
4033         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
4034         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
4035         (TestWebKitAPI::TEST):
4036
4037 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4038
4039         [GTK] Generate the make dist manifest from a CMake template file
4040         https://bugs.webkit.org/show_bug.cgi?id=139387
4041
4042         Reviewed by Martin Robinson.
4043
4044         Remove the code that performs variable substitution on manifest.txt.
4045         Replace the custom variables used in that file with CMake variables.
4046
4047         * gtk/make-dist.py:
4048         (Manifest.add_directory):
4049         (Manifest.get_full_source_path):
4050         (Manifest.process_line):
4051         (Manifest.resolve_variables): Deleted.
4052         (Manifest.get_full_tarball_path): Deleted.
4053         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
4054
4055 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
4056
4057         [Win] Correct merge error in last commit.
4058
4059         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4060         (findAccessibleObjectById): Undo accidental paste made during landing.
4061
4062 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
4063
4064         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
4065         https://bugs.webkit.org/show_bug.cgi?id=139906
4066
4067         Reviewed by Dean Jackson.
4068
4069         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
4070         to use them. This patch fixes that.
4071
4072         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4073         (findAccessibleObjectById):
4074         (AccessibilityController::focusedElement):
4075         (logEventProc):
4076         (notificationListenerProc):
4077         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4078         (AccessibilityUIElement::getChildAtIndex):
4079         (AccessibilityUIElement::titleUIElement):
4080         (self):
4081         (AccessibilityUIElement::role):
4082         (AccessibilityUIElement::valueDescription):
4083         (accessibilityState):
4084         (AccessibilityUIElement::isChecked):
4085         * DumpRenderTree/win/DumpRenderTree.cpp:
4086         (dumpFrameScrollPosition):
4087         (dumpFramesAsText):
4088         * DumpRenderTree/win/PolicyDelegate.cpp:
4089         (PolicyDelegate::decidePolicyForNavigationAction):
4090         * DumpRenderTree/win/UIDelegate.cpp:
4091         (UIDelegate::exceededDatabaseQuota):
4092         * WinLauncher/Common.cpp:
4093         (setWindowText):
4094
4095 2015-01-19  Dean Jackson  <dino@apple.com>
4096
4097         Add "override" to fix the build with newer clangs.
4098
4099         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
4100         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
4101
4102 2015-01-19  David Kilzer  <ddkilzer@apple.com>
4103
4104         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
4105         <http://webkit.org/b/140623>
4106
4107         Reviewed by Daniel Bates.
4108
4109         * Scripts/build-webkit: Update help for --device switch.
4110         * Scripts/webkitdirs.pm:
4111         (determineXcodeSDK): When passing --device, prefer the internal
4112         iOS SDK if it exists, else fall back to the external iOS SDK.
4113         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
4114         xcodebuild instead of trying to sanitize values.
4115
4116 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
4117
4118         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
4119         https://bugs.webkit.org/show_bug.cgi?id=140606
4120
4121         Reviewed by Csaba Osztrogonác.
4122
4123         * Scripts/webkitpy/bindings/main.py:
4124         (BindingsTests.generate_supplemental_dependency):
4125         (BindingsTests.main):
4126
4127 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
4128
4129         [GTK] [WK2] TestWebKitWebView snapshot fails
4130         https://bugs.webkit.org/show_bug.cgi?id=120404
4131
4132         Reviewed by Žan Doberšek.
4133
4134         Rework the test to make sure the snapshot is always created at the
4135         desired size.
4136
4137         * Scripts/run-gtk-tests:
4138         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
4139         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4140         (testWebViewSnapshot): Use a fixed size for the document, and
4141         disable scrollbars to make sure the visible area is always the
4142         WebView size.
4143         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
4144         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
4145         and height parameters to create the window with a given size.
4146         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
4147
4148 2015-01-18  David Kilzer  <ddkilzer@apple.com>
4149
4150         iOS EWS queue name should be consistent
4151         <http://webkit.org/b/140585>
4152
4153         Reviewed by Daniel Bates.
4154
4155         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
4156         to 'ios'.
4157         * Scripts/webkitpy/common/config/ports.py: Ditto.
4158         (DeprecatedPort.port):
4159         (IOSPort):
4160         * Scripts/webkitpy/port/ios.py: Ditto.
4161         (IOSPort):
4162
4163         * Scripts/webkitpy/port/factory.py:
4164         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
4165         appears before ios.IOSPort.  If this is not done,
4166         `run-webkit-tests --ios-simulator` will get the wrong Port class
4167         (IOSPort instead of IOSSimulatorPort) due to the way that
4168         PortFactory.get() uses prefix matching of <Port>.port_name to
4169         find the correct class to use.
4170
4171 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
4172
4173         build.webkit.org/dashboard: OS X EWS is now on Mavericks
4174         https://bugs.webkit.org/show_bug.cgi?id=140595
4175
4176         Reviewed by Csaba Osztrogonác.
4177
4178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4179         (BubbleQueueServer):
4180
4181 2015-01-17  David Kilzer  <ddkilzer@apple.com>
4182
4183         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
4184
4185         * Scripts/webkitpy/port/ios.py:
4186         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
4187         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
4188         the Mountain Lion and Mavericks bots.
4189
4190 2015-01-17  David Kilzer  <ddkilzer@apple.com>
4191
4192         Attempt to fix webkitpy tests on GTK Linux ports
4193
4194         * Scripts/webkitpy/port/ios.py:
4195         (IOSPort.determine_full_port_name): Set a sensible default if
4196         not running on a Mac platform or if no iOS SDK is installed.
4197
4198 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
4199
4200         Create iOS-EWS client queue
4201         https://bugs.webkit.org/show_bug.cgi?id=140476
4202
4203         Reviewed by Alexey Proskuryakov.
4204
4205         * EWSTools/start-queue-mac.sh:
4206         Adds call to configure-xcode-for-ios-development for iOS EWS.
4207         * Scripts/webkitpy/common/config/ews.json:
4208         Adds the iOS EWS config entry.
4209         * Scripts/webkitpy/common/config/ports.py:
4210         (DeprecatedPort.port):
4211         Adds IOSPort to the port map.
4212         (IOSPort):
4213         (IOSPort.build_webkit_command):
4214         Adds --sdk=iphoneos to the webkit build command.
4215         * Scripts/webkitpy/port/base.py:
4216         (Port.architecture):
4217         Adds an accessor for the architecture member variable.
4218         * Scripts/webkitpy/port/factory.py:
4219         (PortFactory):
4220         Adds IOSPort to the port class list.
4221         * Scripts/webkitpy/port/ios.py:
4222         Adds the IOSPort to encapsulate iOS-specific things.
4223         (IOSPort):
4224         (IOSPort.determine_full_port_name):
4225         (IOSPort.__init__):
4226         (IOSPort._build_driver_flags):
4227         (IOSPort.operating_system):
4228         * Scripts/webkitpy/tool/commands/download_unittest.py:
4229         Adds the archetecture option to the mock options.
4230         (DownloadCommandsTest._default_options):
4231         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4232         Appends the archetecture option into calls to webkit-patch.
4233         (AbstractEarlyWarningSystem.review_patch):
4234         (AbstractEarlyWarningSystem.run_command):
4235         (AbstractEarlyWarningSystem.load_ews_classes):
4236         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4237         Adds logic to soothe the unittest now that --architecture is being
4238         thrown around everywhere.
4239         (EarlyWarningSystemTest._default_expected_logs):
4240         * Scripts/webkitpy/tool/commands/queues.py:
4241         Adds glue code to ferry the --architecture option around.
4242         (AbstractQueue.__init__):
4243         (PatchProcessingQueue.begin_work_queue):
4244         * Scripts/webkitpy/tool/steps/abstractstep.py:
4245         Adds the archetecture option to all AbstractSteps so that
4246         EarlyWarningSystem doesn't start shoving --architecture into
4247         unsuspecting commands.
4248         (AbstractStep.options):
4249         * Scripts/webkitpy/tool/steps/build.py:
4250         Translates the --architecture option into an ARCHS= format to pass to
4251         build-webkit.
4252         (Build.build):
4253         * Scripts/webkitpy/tool/steps/options.py:
4254         Adds a definition for the --architecture option.
4255         (Options):
4256
4257 2015-01-16  Sam Weinig  <sam@webkit.org>
4258
4259         Add a basic configuration object for WKView
4260         https://bugs.webkit.org/show_bug.cgi?id=140559
4261
4262         Reviewed by Anders Carlsson.
4263
4264         Add tests for WKPageConfigurationRef.
4265
4266         * TestWebKitAPI/PlatformWebView.h:
4267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4268         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
4269         (TestWebKitAPI::TEST):
4270         (TestWebKitAPI::didFinishLoadForFrame):
4271         (TestWebKitAPI::setPageLoaderClient):
4272         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4273         (TestWebKitAPI::PlatformWebView::initialize):
4274         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4275
4276 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
4277
4278         WeakPtr functions crash when created with default constructor
4279         https://bugs.webkit.org/show_bug.cgi?id=140479
4280
4281         Reviewed by Andreas Kling.
4282
4283         Add WeakPtr API tests.
4284
4285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4286         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
4287         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
4288
4289 2015-01-16  Chris Dumez  <cdumez@apple.com>
4290
4291         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
4292         https://bugs.webkit.org/show_bug.cgi?id=140568
4293
4294         Reviewed by Alexey Proskuryakov.
4295
4296         Fix the script parsing CSSPropertyNames.in to stop splitting lines
4297         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
4298         e.g. "Longhands=background-position-x|background-position-y".
4299         This would confuse the script and treat this as a CSS property:
4300         "background-position-x|background-position-y".
4301
4302         We now split on white space and treat the first string on the line
4303         to be the property name (this is the syntax in this file).
4304
4305         * Scripts/webkitpy/w3c/test_converter.py:
4306         (_W3CTestConverter.__init__):