WebKitTestRunner bundleID should not be cleared before every test
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
2
3         WebKitTestRunner bundleID should not be cleared before every test
4         https://bugs.webkit.org/show_bug.cgi?id=208823
5         <rdar://problem/60204539>
6
7         Reviewed by Per Arne Vollan.
8
9         This is causing test failures for layout tests which rely on the Info.plist 
10         bundle identifier (not the one set via the override method).
11
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::createWebViewWithOptions):
14         (WTR::TestController::ensureViewSupportsOptionsForTest):
15         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
16
17 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
18
19         [macOS] Notification observer is not removed
20         https://bugs.webkit.org/show_bug.cgi?id=208834
21
22         Reviewed by Tim Horton.
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
26         (TEST):
27
28 2020-03-06  Brian Burg  <bburg@apple.com>
29
30         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
31         https://bugs.webkit.org/show_bug.cgi?id=208729
32         <rdar://problem/60105447>
33
34         Reviewed by Jonathan Bedard.
35
36         Improve upload.py to look for the svn branch and revision for the 'webkit'
37         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
38
39         * Scripts/webkitpy/common/checkout/scm/git.py:
40         (Git):
41         (Git.git_svn_id_regexp):
42         (Git._field_from_git_svn_id):
43         (Git.svn_revision):
44         (Git.svn_branch):
45         (Git.svn_url):
46         (Git.native_branch):
47         Refactor svn revision, branch, url to use the same regexp and helper code.
48
49         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
50         (StubRepository.svn_branch):
51         Expose a stub since this is used unconditionally by Port.commits_for_upload.
52
53         * Scripts/webkitpy/common/checkout/scm/svn.py:
54         (SVN.svn_branch):
55         (SVN.native_revision):
56         (SVN):
57         (SVN.native_branch):
58         Refactor so the actual implementation is contained in svn_revision / svn_branch.
59         The native_* methods call out to the SVN equivalents since this is an SVN repository.
60
61         * Scripts/webkitpy/port/base.py:
62         (Port.commits_for_upload):
63         Add special git-svn handling for the WebKit repository so that SVN branch and revision
64         is preferred over the git equivalents.
65
66 2020-03-09  Antoine Quint  <graouts@apple.com>
67
68         TestWebKitAPI fails to build on watchOS
69         https://bugs.webkit.org/show_bug.cgi?id=208820
70
71         Reviewed by Tim Horton.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
74
75 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
76
77         resultsdbpy: Add tool to manage resultsdbpy container
78         https://bugs.webkit.org/show_bug.cgi?id=208743
79
80         Rubber-stamped by Aakash Jain.
81
82         Add tool to start, stop and restart the resultsdbpy Docker container.
83
84         * resultsdbpy/resultsdbpy/container: Added.
85
86 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
87
88         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
89         https://bugs.webkit.org/show_bug.cgi?id=208706
90
91         Reviewed by Žan Doberšek.
92
93         Add test case to check surrounding text in multiline context.
94
95         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
96         (testWebKitInputMethodContextSurrounding):
97
98 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
99
100         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
101         https://bugs.webkit.org/show_bug.cgi?id=208783
102
103         Reviewed by Brent Fulgham.
104
105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
106
107 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
108
109         Replace the use of term "rollout" to "revert" in various tools
110         https://bugs.webkit.org/show_bug.cgi?id=208775
111
112         Reviewed by Ryosuke Niwa.
113
114         See this webkit-dev thread for the originating discussion:
115         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
116
117         'rollout' is a confusing term to anyone unacquainted with WebKit;
118         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
119
120         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
121         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
122
123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
131         * BuildSlaveSupport/ews-build/steps.py:
132         * BuildSlaveSupport/ews-build/steps_unittest.py:
133         * Scripts/webkit-tools-completion.sh:
134         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
135         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
136         * Scripts/webkitpy/common/checkout/scm/svn.py:
137         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
138         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
139         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
140         * Scripts/webkitpy/tool/bot/feeders.py:
141         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
142         * Scripts/webkitpy/tool/bot/irc_command.py:
143         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
144         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
145         * Scripts/webkitpy/tool/bot/sheriff.py:
146         * Scripts/webkitpy/tool/commands/download.py:
147         * Scripts/webkitpy/tool/commands/download_unittest.py:
148         * Scripts/webkitpy/tool/commands/newcommitbot.py:
149         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
150         * Scripts/webkitpy/tool/commands/queues_unittest.py:
151         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
152         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
153         * Scripts/webkitpy/tool/steps/__init__.py:
154         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
155         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
156         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
157         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
158
159 2020-03-07  David Quesada  <david_quesada@apple.com>
160
161         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
162         https://bugs.webkit.org/show_bug.cgi?id=208781
163         rdar://problem/60061016
164
165         Reviewed by Alex Christensen.
166
167         Add a test that recreates the conditions of this crash:
168         - Send a message from the injected bundle to the UI process that contains a reply block.
169         - Hold a reference to the reply block.
170         - Let the web view deallocate.
171         - Call the block, and expect not to crash.
172
173         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
174         (localObjectInterface):
175         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
176         (-[LocalObject doSomethingWithCompletionHandler:]):
177         (TEST):
178         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
179         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
180
181 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
182
183         TextManipulationController should work with ARIA labels
184         https://bugs.webkit.org/show_bug.cgi?id=208759
185
186         Reviewed by Wenson Hsieh.
187
188         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
189         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
190         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
191         the expected number of tokens for the first item as the very first image is correctly
192         detected per the code change. 
193         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
194
195 2020-03-07  Alex Christensen  <achristensen@webkit.org>
196
197         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
198         https://bugs.webkit.org/show_bug.cgi?id=208767
199
200         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
201         The frameID of the main frame before loading is only 0 on Mac right now.
202         The test is still good because it validates that execution works in the main frame before loading.
203
204 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
205
206         [ews] commit queue is not skipping layout tests for rollout patches
207         https://bugs.webkit.org/show_bug.cgi?id=208716
208
209         Unreviewed minor fix.
210
211         * BuildSlaveSupport/ews-build/steps.py:
212         (RunWebKitTests.doStepIf):
213         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
214         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
215
216 2020-03-05  Sam Weinig  <weinig@apple.com>
217
218         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
219         https://bugs.webkit.org/show_bug.cgi?id=207436
220         <rdar://problem/59296762>
221
222         Reviewed by Darin Adler.
223
224         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
225         Remove JSC related defines.
226
227 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
228
229         AX: Provide a way to run tests in isolated tree mode
230         https://bugs.webkit.org/show_bug.cgi?id=208629
231         <rdar://problem/60075583>
232
233         Reviewed by Ryosuke Niwa.
234
235         Provide the ability to run tests for accessibility in the isolated tree mode.
236         This sends a flag over to the injected bundle which calls the right HIServices override so that
237         the system thinks it is in isolated mode.
238
239         * Scripts/compare-webkit-configurations:
240         (flag_for_comparison):
241         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
242         (parse_args):
243         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
244         (parse_args):
245         * Scripts/webkitpy/port/driver.py:
246         (Driver.cmd_line):
247         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
248         (WTR::AccessibilityController::AccessibilityController):
249         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
250         (WTR::AccessibilityController::updateIsolatedTreeMode):
251         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
252         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
253         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
254         (WTR::InjectedBundle::didReceiveMessageToPage):
255         (WTR::InjectedBundle::beginTesting):
256         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
257         * WebKitTestRunner/Options.cpp:
258         (WTR::handleOptionAccessibilityIsolatedTreeMode):
259         (WTR::OptionsHandler::OptionsHandler):
260         * WebKitTestRunner/Options.h:
261         * WebKitTestRunner/TestController.cpp:
262         (WTR::TestController::initialize):
263         (WTR::TestController::resetPreferencesToConsistentValues):
264         (WTR::TestController::resetStateToConsistentValues):
265         * WebKitTestRunner/TestController.h:
266         (WTR::TestController::accessibilityIsolatedTreeMode const):
267
268 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
269
270         [Cocoa] Re-enable CFPrefs direct mode
271         https://bugs.webkit.org/show_bug.cgi?id=208690
272
273         Reviewed by Brent Fulgham.
274
275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
276         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
277         (TEST):
278         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
279         (TestWebKitAPI::TEST):
280
281 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
282
283         UIProcess needs mechanism to specify AppBound domains
284         https://bugs.webkit.org/show_bug.cgi?id=208528
285         <rdar://problem/59980340>
286
287         Reviewed by Brent Fulgham.
288
289         Added test app-bound domains to the plist and tested that the domains
290         are properly stored in the website data store after a navigation.
291
292         * TestWebKitAPI/Info.plist:
293         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
294         (TEST):
295
296 2020-03-06  Alex Christensen  <achristensen@webkit.org>
297
298         Add SPI to disable cross origin access control checks
299         https://bugs.webkit.org/show_bug.cgi?id=208748
300
301         Reviewed by Tim Hatcher.
302
303         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
304         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
305
306 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
307
308         [webkitpy] Fix executive on Windows to run wpt server correctly
309         https://bugs.webkit.org/show_bug.cgi?id=208693
310
311         Reviewed by Jonathan Bedard.
312
313         Bug fix for Windows environment a) fixing a typo. b) fixing path
314         c) fix how to kill subprocesses.
315
316         * Scripts/webkitpy/common/system/executive.py:
317         (Executive._windows_kill_command):
318         (Executive.interrupt):
319         (Executive.kill_all):
320         * Scripts/webkitpy/port/base.py:
321         (Port.web_platform_test_server_doc_root):
322
323 2020-03-06  Alex Christensen  <achristensen@webkit.org>
324
325         Evaluating JavaScript in main frame before loading should succeed
326         https://bugs.webkit.org/show_bug.cgi?id=208733
327
328         Reviewed by Tim Horton.
329
330         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
331
332 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
333
334         TextManipulationController should preserve images
335         https://bugs.webkit.org/show_bug.cgi?id=208692
336
337         Reviewed by Wenson Hsieh.
338
339         Added tests for preserving images and their ordering.
340
341         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
342         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
343         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
344         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
345
346 2020-03-06  David Quesada  <david_quesada@apple.com>
347
348         Add _WKResourceLoadInfo.resourceType SPI
349         https://bugs.webkit.org/show_bug.cgi?id=208723
350
351         Reviewed by Alex Christensen.
352
353         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
354         (TEST):
355
356 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
357
358         Stop reporting to webkit-test-results.webkit.org
359         https://bugs.webkit.org/show_bug.cgi?id=207218
360
361         Reviewed by Alexey Proskuryakov.
362
363         * BuildSlaveSupport/build.webkit.org-config/steps.py:
364         (RunWebKitTests):
365
366 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
367
368         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
369         https://bugs.webkit.org/show_bug.cgi?id=208365
370         <rdar://problem/59877296>
371
372         Reviewed by Geoffrey Garen.
373
374         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
375         (TEST):
376
377 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
378
379         EWS should be able to fetch patch status for security bugs while processing them
380         https://bugs.webkit.org/show_bug.cgi?id=206511
381
382         Reviewed by Alexey Proskuryakov.
383
384         * BuildSlaveSupport/ews-build/steps.py:
385         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
386         (BugzillaMixin.get_patch_json): 
387         (BugzillaMixin.get_bug_json):
388         (BugzillaMixin._is_bug_closed):
389         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
390         (TransferToS3.hideStepIf): Ditto.
391
392 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
393
394         [ews] commit-queue should show the trac url for the commit on the build page
395         https://bugs.webkit.org/show_bug.cgi?id=208715
396
397         Reviewed by Jonathan Bedard.
398
399         * BuildSlaveSupport/ews-build/steps.py:
400         (PushCommitToWebKitRepo.evaluateCommand):
401
402 2020-03-06  Alex Christensen  <achristensen@webkit.org>
403
404         Fix ResourceLoadDelegate.LoadInfo API test after r257816
405         https://bugs.webkit.org/show_bug.cgi?id=208550
406
407         * TestWebKitAPI/cocoa/HTTPServer.mm:
408         (TestWebKitAPI::HTTPServer::respondToRequests):
409         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
410         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
411
412 2020-03-06  Lauro Moura <lmoura@igalia.com>
413
414         [WPE][WebDriver] MiniBrowser should react to close session commands
415         https://bugs.webkit.org/show_bug.cgi?id=207529
416
417         Reviewed by Carlos Garcia Campos.
418
419         Do not call g_object_unref on the first created view if it has already
420         been disposed in the "close" signal handler.
421
422         Based on original patch by Yury Semikhatsky.
423
424         * MiniBrowser/wpe/main.cpp:
425         (main):
426
427 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
428
429         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
430         https://bugs.webkit.org/show_bug.cgi?id=208647
431
432         Reviewed by Carlos Garcia Campos.
433
434         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
435         (TestWebKitAPI::TEST):
436
437 2020-03-05  Alex Christensen  <achristensen@webkit.org>
438
439         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
440         https://bugs.webkit.org/show_bug.cgi?id=208670
441
442         Reviewed by Brady Eidson.
443
444         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
445         (-[FrameNavigationDelegate waitForNavigations:]):
446         (-[FrameNavigationDelegate requests]):
447         (-[FrameNavigationDelegate frames]):
448         (-[FrameNavigationDelegate callbacks]):
449         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
450         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
451         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
452         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
453         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
454         (TEST):
455
456 2020-03-05  Alex Christensen  <achristensen@webkit.org>
457
458         Add WKFrameInfo._parentFrameHandle SPI
459         https://bugs.webkit.org/show_bug.cgi?id=208674
460
461         Reviewed by Brady Eidson.
462
463         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
464
465 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
466
467         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
468         https://bugs.webkit.org/show_bug.cgi?id=208626
469         <rdar://problem/60074148>
470
471         Reviewed by Brent Fulgham.
472
473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
475         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
476         (TestWebKitAPI::TEST):
477         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
478         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
479         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
480
481 2020-03-05  Antoine Quint  <graouts@apple.com>
482
483         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
484         https://bugs.webkit.org/show_bug.cgi?id=208644
485         <rdar://problem/60042429>
486
487         Reviewed by Brady Eidson.
488
489         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
490         
491         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
492            empty document has been removed in favor of the document for the requested URL,
493         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
494            correctly does not injected the style sheet.
495
496         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
497
498 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
499
500         [ews] Add build step to push commit to WebKit repository
501         https://bugs.webkit.org/show_bug.cgi?id=208589
502
503         Reviewed by Jonathan Bedard.
504
505         * BuildSlaveSupport/ews-build/steps.py:
506         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
507         (PushCommitToWebKitRepo.start): Initialize log observer.
508         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
509         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
510         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
511         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
512         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
513         * BuildSlaveSupport/ews-build/factories.py:
514
515 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
516
517         [ews] Add unit tests for ValidateCommiterAndReviewer build step
518         https://bugs.webkit.org/show_bug.cgi?id=208262
519
520         Reviewed by Jonathan Bedard.
521
522         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
523
524 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
525
526         commit-queue should run WK2 tests instead of WK1 tests
527         https://bugs.webkit.org/show_bug.cgi?id=208544
528
529         Reviewed by Jonathan Bedard.
530
531         * BuildSlaveSupport/ews-build/factories.py:
532
533 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
534
535         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
536         https://bugs.webkit.org/show_bug.cgi?id=208645
537
538         Reviewed by Alexey Proskuryakov.
539
540         * BuildSlaveSupport/ews-build/steps.py:
541         (ValidateCommiterAndReviewer.load_contributors):
542         (ValidateCommiterAndReviewer.start):
543
544 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
545
546         style-checker: Add UAF to the list of security words to warn about.
547         https://bugs.webkit.org/show_bug.cgi?id=208643
548
549         Reviewed by Jonathan Bedard.
550
551         UAF is a common acronym used for use after free.
552
553         * Scripts/webkitpy/style/checkers/changelog.py:
554         (ChangeLogChecker.check_for_unwanted_security_phrases):
555
556 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
557
558         [MSVC] Add .natvis support of WebKit types
559         https://bugs.webkit.org/show_bug.cgi?id=193119
560
561         Reviewed by Don Olmstead.
562
563         To help the WebKit developer while debugging, this file defines how
564         WebKit types are displayed in debugger of Visual Studio.
565         Very limited set of WebKit types, but it changes the world.
566
567         * VisualStudio/WebKit.natvis: Added.
568
569 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         Add system trace points around display list replay
572         https://bugs.webkit.org/show_bug.cgi?id=208616
573
574         Reviewed by Simon Fraser.
575
576         Add a new "Display list replay" trace point.
577
578         * Tracing/SystemTracePoints.plist:
579
580 2020-03-04  Alex Christensen  <achristensen@webkit.org>
581
582         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
583         https://bugs.webkit.org/show_bug.cgi?id=208615
584         <rdar://problem/59406743>
585
586         Reviewed by Alex Christensen.
587
588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
589         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
590         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
591         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
592         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
593         (TEST):
594         Also make a test written in bug 206310 actually run code.
595
596 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
597
598         [build.webkit.org] Remove leaks queue
599         https://bugs.webkit.org/show_bug.cgi?id=208580
600
601         Reviewed by Jonathan Bedard.
602
603         * BuildSlaveSupport/build.webkit.org-config/config.json:
604         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
606
607 2020-03-04  Alex Christensen  <achristensen@webkit.org>
608
609         Add SPI to evaluate JavaScript in an iframe
610         https://bugs.webkit.org/show_bug.cgi?id=208605
611
612         Reviewed by Brady Eidson.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
615
616 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
617
618         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
619         https://bugs.webkit.org/show_bug.cgi?id=208533
620         <rdar://problem/60010184>
621
622         Reviewed by Alex Christensen.
623
624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
625         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
626         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
627         (TestWebKitAPI::TEST):
628         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
629         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
630
631 2020-03-04  Alex Christensen  <achristensen@webkit.org>
632
633         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
634         https://bugs.webkit.org/show_bug.cgi?id=208593
635
636         Reviewed by Brady Eidson.
637
638         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
639         (TestWebKitAPI::TEST):
640
641 2020-03-04  Alex Christensen  <achristensen@webkit.org>
642
643         WKWebView's frames accessor should return a traversable type
644         https://bugs.webkit.org/show_bug.cgi?id=208591
645
646         Reviewed by Brady Eidson.
647
648         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
649
650 2020-03-04  Antoine Quint  <graouts@apple.com>
651
652         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
653         https://bugs.webkit.org/show_bug.cgi?id=208575
654         <rdar://problem/59773690>
655
656         Reviewed by Brady Eidson.
657
658         Add new tests for the new SPI which check:
659         
660         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
661            specified WKWebView alone,
662         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
663         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
664         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
665         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
666         6. and that the same test also works with PSON enabled.
667
668         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
669
670 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
671
672         [macOS] test-lldb-webkit failing on debug bots
673         https://bugs.webkit.org/show_bug.cgi?id=208545
674
675         Reviewed by Jonathan Bedard.
676
677         The lldb-webkit-test step must pass in the build configuration as an
678         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
679         binary that is downloaded with the rest of the build products. Without this
680         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
681         regardless of their actual build configuration.
682
683         * BuildSlaveSupport/build.webkit.org-config/steps.py:
684         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
685         * Scripts/test-lldb-webkit:
686         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
687
688 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
689
690         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
691         https://bugs.webkit.org/show_bug.cgi?id=208539
692
693         Unreviewed follow-up fix.
694
695         * BuildSlaveSupport/ews-build/steps.py:
696
697 2020-03-04  Daniel Bates  <dabates@apple.com>
698
699         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
700         https://bugs.webkit.org/show_bug.cgi?id=208565
701
702         Reviewed by Wenson Hsieh.
703
704         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
705         of its frame as a means to find all the editable elements in the visible content area
706         of the web view.
707
708         Coincidentally this makes no difference to the test results right now because the web view
709         happens to be located at the origin (0, 0) in the window. However if in the future the
710         web view would be located at some other point then the tests may fail because the rectangle
711         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
712         rectangle for the visible content area.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
715         (TEST):
716
717 2020-03-04  Daniel Bates  <dabates@apple.com>
718
719         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
720         https://bugs.webkit.org/show_bug.cgi?id=208564
721
722         Reviewed by Alex Christensen.
723
724         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
725         to make it easy to run just these tests.
726
727         Currently, the tests are organized under the test case name WebKit. This means you need to
728         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
729         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
730         so that a person can run just these test using:
731         
732                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
733
734         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
735         (TEST):
736
737 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
738
739         [ews] Add build step to create local git commit for commit-queue
740         https://bugs.webkit.org/show_bug.cgi?id=208539
741
742         Reviewed by Jonathan Bedard.
743
744         * BuildSlaveSupport/ews-build/steps.py:
745         (CreateLocalGITCommit): Build step to create local git commit.
746         (CreateLocalGITCommit.start):
747         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
748         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
749         * BuildSlaveSupport/ews-build/factories.py:
750
751 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
752
753         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
754         https://bugs.webkit.org/show_bug.cgi?id=207948
755
756         Reviewed by Zalan Bujtas.
757
758         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
759         so that it receives the wheel events.
760
761         * DumpRenderTree/mac/EventSendingController.mm:
762         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
763         * DumpRenderTree/win/EventSender.cpp:
764         (mouseScrollBy):
765
766 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
767
768         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
769         https://bugs.webkit.org/show_bug.cgi?id=208520
770         <rdar://problem/60000214>
771
772         Reviewed by Chris Fleizach.
773
774         Calling InjectedBundle::singleton().page()->page() in the constructor
775         of the AccessibilityController is having this side effect on iOS.
776         So #if to MAC where it's actually being used.
777
778         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
779         (WTR::AccessibilityController::AccessibilityController):
780
781 2020-03-03  Alex Christensen  <achristensen@webkit.org>
782
783         Add SPI _WKResourceLoadInfo.loadedFromCache
784         https://bugs.webkit.org/show_bug.cgi?id=208554
785
786         Reviewed by Wenson Hsieh.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
789         (TEST):
790
791 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
792
793         Batch observations and completions of text manipulations
794         https://bugs.webkit.org/show_bug.cgi?id=208406
795
796         Reviewed by Wenson Hsieh.
797
798         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
799         multiple paragraphs at once.
800
801         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
802         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
803         (-[TextManipulationDelegate items]):
804         (-[LegacyTextManipulationDelegate init]):
805         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
806         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
807         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
808         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
809         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
810         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
811         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
812
813 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
814
815         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
816         https://bugs.webkit.org/show_bug.cgi?id=208415
817
818         Reviewed by Brent Fulgham.
819
820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
821         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
822         (TEST):
823
824 2020-03-03  Alex Christensen  <achristensen@webkit.org>
825
826         Add response to _WKResourceLoadDelegate didCompleteWithError callback
827         https://bugs.webkit.org/show_bug.cgi?id=208553
828
829         Reviewed by Simon Fraser.
830
831         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
832         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
833         (TEST):
834         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
835
836 2020-03-03  Brady Eidson  <beidson@apple.com>
837
838         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
839         https://bugs.webkit.org/show_bug.cgi?id=198795
840
841         Reviewed by Chris Dumez.
842
843         This test appears to no longer be flaky.
844         
845         Let's re-enable it.
846         
847         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
848         (TestWebKitAPI::TEST):
849
850 2020-03-03  Alex Christensen  <achristensen@webkit.org>
851
852         Requests sent to _WKResourceLoadDelegate should include HTTPBody
853         https://bugs.webkit.org/show_bug.cgi?id=208550
854
855         Reviewed by Tim Hatcher.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
858         (TEST):
859         * TestWebKitAPI/cocoa/HTTPServer.mm:
860         (TestWebKitAPI::HTTPServer::respondToRequests):
861         HTTPServer now looks for Content-Length in its request.
862         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
863
864 2020-03-03  Alex Christensen  <achristensen@webkit.org>
865
866         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
867         https://bugs.webkit.org/show_bug.cgi?id=208522
868
869         Reviewed by Brian Weinstein.
870
871         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
872         (TEST):
873
874 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
875
876         commit-queue should update working directory and reapply patch just before commiting
877         https://bugs.webkit.org/show_bug.cgi?id=208521
878
879         Reviewed by Jonathan Bedard.
880
881         * BuildSlaveSupport/ews-build/factories.py:
882
883 2020-03-03  Matt Lewis  <jlewis3@apple.com>
884
885         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
886         https://bugs.webkit.org/show_bug.cgi?id=208485
887
888         Reviewed by Jonathan Bedard.
889
890         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
891         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
892         that we don't have to recreate the variables that are already created.
893         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
894         from each module, rather than making extra imports that we don't need.
895         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
896         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
897         and not part of the host.
898         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
899         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
900         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
901         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
902         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
903         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
904         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
905         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
906         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
907         if we were geting any value at all
908         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
909         sure we aren't gabking the wrong key:value pair
910         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
911         come with the MockHosts and MockHost inherits from MockSystemHost.
912         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
913         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
914         to the various upload steps.
915
916 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
917
918         [ews] Add build step to find list of modified changelogs
919         https://bugs.webkit.org/show_bug.cgi?id=208514
920
921         Reviewed by Jonathan Bedard.
922
923         * BuildSlaveSupport/ews-build/factories.py:
924         * BuildSlaveSupport/ews-build/steps.py:
925         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
926         (FindModifiedChangeLogs.start): Initialize log observer.
927         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
928         (FindModifiedChangeLogs.evaluateCommand):
929         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
930         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
931         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
932         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
933
934 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
935
936         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
937         https://bugs.webkit.org/show_bug.cgi?id=208451
938
939         Unreviewed test gardening.
940
941         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
942
943 2020-03-03  Jiten Mehta  <jmehta@apple.com>
944
945         Adopt HTTP Alternative Services Storage
946         https://bugs.webkit.org/show_bug.cgi?id=208387
947
948         Reviewed by Alex Christensen.
949
950         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
951         (checkUntilEntryFound):
952         (TEST):
953
954 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
955
956         Check for navigation to app-bound domain during script evaluation
957         https://bugs.webkit.org/show_bug.cgi?id=208319
958         <rdar://problem/57569321>
959
960         Reviewed by Brent Fulgham.
961
962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
963         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
964         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
965         (TEST):
966         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
967         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
968
969 2020-03-03  Commit Queue  <commit-queue@webkit.org>
970
971         Unreviewed, rolling out r257754.
972         https://bugs.webkit.org/show_bug.cgi?id=208513
973
974         Introduced API test failure (Requested by perarne on #webkit).
975
976         Reverted changeset:
977
978         "[Cocoa] Mapping from MIME type to UTI type should be done in
979         the UI process"
980         https://bugs.webkit.org/show_bug.cgi?id=208415
981         https://trac.webkit.org/changeset/257754
982
983 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
984
985         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
986         https://bugs.webkit.org/show_bug.cgi?id=208506
987
988         Reviewed by Carlos Garcia Campos.
989
990         * WebKitTestRunner/TestController.cpp:
991         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
992
993 2020-03-02  Ben Nham  <nham@apple.com>
994
995         Add performance probes for HTML parsing
996         https://bugs.webkit.org/show_bug.cgi?id=208271
997
998         Reviewed by Daniel Bates.
999
1000         This adds probes that show which lines of HTML are have been parsed.
1001
1002         * Tracing/SystemTracePoints.plist:
1003
1004 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1005
1006         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1007         https://bugs.webkit.org/show_bug.cgi?id=208415
1008
1009         Reviewed by Brent Fulgham.
1010
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1013         (TEST):
1014
1015 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1016
1017         Unreviewed, rolling out r257725.
1018
1019         This commit caused 10 API tests to fail
1020
1021         Reverted changeset:
1022
1023         "[Cocoa] Mapping from MIME type to UTI type should be done in
1024         the UI process"
1025         https://bugs.webkit.org/show_bug.cgi?id=208415
1026         https://trac.webkit.org/changeset/257725
1027
1028 2020-03-02  Saam Barati  <sbarati@apple.com>
1029
1030         Don't skip tests unnecessarily on arm64
1031         https://bugs.webkit.org/show_bug.cgi?id=208470
1032         <rdar://problem/59968869>
1033
1034         Reviewed by Tadeu Zagallo.
1035
1036         * Scripts/run-jsc-stress-tests:
1037
1038 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1039
1040         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1041         https://bugs.webkit.org/show_bug.cgi?id=208434
1042
1043         Reviewed by Chris Fleizach.
1044
1045         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1046         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1047         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1048         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1049         (WTR::AccessibilityController::accessibleElementById): Same as above.
1050
1051 2020-03-02  John Wilander  <wilander@apple.com>
1052
1053         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1054         https://bugs.webkit.org/show_bug.cgi?id=208399
1055         <rdar://problem/24731650>
1056
1057         Reviewed by Brent Fulgham.
1058
1059         The majority of the changes in WTR::TestController is (partially) fixing a bug
1060         where the TestRunner would statically use the default website datastore instead
1061         of the website data store configure for the page. This worked for persistent
1062         storage testing but not for ephemeral sessions which is what this patch is all
1063         about. The previous TestController::websiteDataStore() is now called
1064         TestController::defaultWebsiteDataStore() and the new
1065         TestController::websiteDataStore() returns the configured website data store.
1066         Most of the use of the default website data store should probably change but
1067         that's not really for this patch to deal with. I did however move all of
1068         resource load statistics' use to the new TestController::websiteDataStore().
1069
1070         A new TestRunner function was added: isStatisticsEphemeral()
1071         It allows test cases to query the ephemeral status of resource load statistics.
1072
1073         One problem that is mitigated in this patch but not fully fixed is that for
1074         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1075         TestController::generatePageConfiguration() via C API 
1076         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1077         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1078         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1079         I tried removing the latter since one session for all platforms should be
1080         Enough but got broken behavior as a result. So now both are still there
1081         and both enable resource load statistics.
1082
1083         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1084         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1085         (WTR::TestRunner::isStatisticsEphemeral):
1086         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1087         * WebKitTestRunner/TestController.cpp:
1088         (WTR::TestController::defaultWebsiteDataStore):
1089         (WTR::TestController::websiteDataStore):
1090         (WTR::TestController::generatePageConfiguration):
1091         (WTR::TestController::resetPreferencesToConsistentValues):
1092         (WTR::TestController::resetStateToConsistentValues):
1093         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1094         (WTR::TestController::decidePolicyForNavigationAction):
1095         (WTR::TestController::platformAdjustContext):
1096         (WTR::TestController::clearServiceWorkerRegistrations):
1097         (WTR::TestController::clearDOMCache):
1098         (WTR::TestController::clearDOMCaches):
1099         (WTR::TestController::clearIndexedDatabases):
1100         (WTR::TestController::clearLocalStorage):
1101         (WTR::TestController::hasDOMCache):
1102         (WTR::TestController::domCacheSize):
1103         (WTR::TestController::setStatisticsEnabled):
1104         (WTR::TestController::isStatisticsEphemeral):
1105         (WTR::TestController::setStatisticsDebugMode):
1106         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1107         (WTR::TestController::setStatisticsLastSeen):
1108         (WTR::TestController::setStatisticsMergeStatistic):
1109         (WTR::TestController::setStatisticsPrevalentResource):
1110         (WTR::TestController::setStatisticsVeryPrevalentResource):
1111         (WTR::TestController::dumpResourceLoadStatistics):
1112         (WTR::TestController::isStatisticsPrevalentResource):
1113         (WTR::TestController::isStatisticsVeryPrevalentResource):
1114         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1115         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1116         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1117         (WTR::TestController::setStatisticsHasHadUserInteraction):
1118         (WTR::TestController::isStatisticsHasHadUserInteraction):
1119         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1120         (WTR::TestController::setStatisticsGrandfathered):
1121         (WTR::TestController::isStatisticsGrandfathered):
1122         (WTR::TestController::setUseITPDatabase):
1123         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1124         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1125         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1126         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1127         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1128         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1129         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1130         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1131         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1132         (WTR::TestController::statisticsUpdateCookieBlocking):
1133         (WTR::TestController::statisticsSubmitTelemetry):
1134         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1135         (WTR::TestController::setStatisticsIsRunningTest):
1136         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1137         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1138         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1139         (WTR::TestController::setStatisticsGrandfatheringTime):
1140         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1141         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1142         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1143         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1144         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1145         (WTR::TestController::statisticsDeleteCookiesForHost):
1146         (WTR::TestController::isStatisticsHasLocalStorage):
1147         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1148         (WTR::TestController::hasStatisticsIsolatedSession):
1149         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1150         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1151         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1152         (WTR::TestController::statisticsResetToConsistentState):
1153         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1154         * WebKitTestRunner/TestController.h:
1155         * WebKitTestRunner/TestInvocation.cpp:
1156         (WTR::TestInvocation::invoke):
1157         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1158         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1159         (WTR::initializeWebViewConfiguration):
1160         (WTR::TestController::platformCreateWebView):
1161
1162 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1163
1164         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1165         https://bugs.webkit.org/show_bug.cgi?id=208415
1166
1167         Reviewed by Brent Fulgham.
1168
1169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1170         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1171         (TEST):
1172
1173 2020-03-02  Daniel Bates  <dabates@apple.com>
1174
1175         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1176         https://bugs.webkit.org/show_bug.cgi?id=208352
1177         <rdar://problem/59867815>
1178
1179         Reviewed by Wenson Hsieh.
1180
1181         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1182         to actually scroll the web content. This also means we now execute the same code on both Mac and
1183         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1184         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1185         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1188         (TEST):
1189
1190 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1191
1192         Unreviewed, rolling out r257687.
1193
1194         This commit caused debug tests to crash for macOS & iOS
1195
1196         Reverted changeset:
1197
1198         "[Cocoa] Mapping from MIME type to UTI type should be done in
1199         the UI process"
1200         https://bugs.webkit.org/show_bug.cgi?id=208415
1201         https://trac.webkit.org/changeset/257687
1202
1203 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1204
1205         Unreviewed, rolling out r257618.
1206
1207         This allegedly causes Safari to crash when closing a window
1208         (see rdar://problem/59922725).
1209
1210         Reverted changeset:
1211
1212         "UIProcess crash after using _prepareForMoveToWindow, then
1213         deallocating the WKWebView before moving to the window"
1214         https://bugs.webkit.org/show_bug.cgi?id=208365
1215         https://trac.webkit.org/changeset/257618
1216
1217 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1218
1219         Remove std::lock_guard
1220         https://bugs.webkit.org/show_bug.cgi?id=206451
1221
1222         Reviewed by Anders Carlsson.
1223
1224         Add std::lock_guard lint rule to prevent from using it.
1225
1226         * Scripts/webkitpy/style/checkers/cpp.py:
1227         (check_lock_guard):
1228         (check_style):
1229         (CppChecker):
1230         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1231         (WebKitStyleTest.test_lock_guard):
1232         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1233         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1234         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1235         (assertHasObjects):
1236         (assertHasOnlyObjects):
1237         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1238         (WTR::AXThread::dispatch):
1239         (WTR::AXThread::dispatchFunctionsFromAXThread):
1240         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1241         (WTR::AXThread::initializeRunLoop):
1242
1243 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1244
1245         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1246         https://bugs.webkit.org/show_bug.cgi?id=208415
1247
1248         Reviewed by Brent Fulgham.
1249
1250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1251         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1252         (TEST):
1253
1254 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1255
1256         Unreviewed, rolling out r257565.
1257
1258         It broke WinCairo MiniBrowser
1259
1260         Reverted changeset:
1261
1262         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1263         https://bugs.webkit.org/show_bug.cgi?id=206894
1264         https://trac.webkit.org/changeset/257565
1265
1266 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1267
1268         EWS fails to retry build in case of kill-old-processes exception
1269         https://bugs.webkit.org/show_bug.cgi?id=208003
1270
1271         Reviewed by Jonathan Bedard.
1272
1273         * BuildSlaveSupport/ews-build/steps.py:
1274         (KillOldProcesses.evaluateCommand):
1275         (KillOldProcesses.getResultSummary):
1276
1277 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1278
1279         [ews] commit-queue should update the ChangeLog with Reviewer name
1280         https://bugs.webkit.org/show_bug.cgi?id=206535
1281
1282         Reviewed by Jonathan Bedard.
1283
1284         * BuildSlaveSupport/ews-build/steps.py:
1285         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1286
1287 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1288
1289         run-javascriptcore-tests: Make upload format valid
1290         https://bugs.webkit.org/show_bug.cgi?id=208341
1291
1292         Rubber-stamped by Aakash Jain.
1293
1294         * Scripts/run-javascriptcore-tests:
1295         (uploadResults): Remove. FIXME.
1296         * Scripts/webkitdirs.pm:
1297         (splitVersionString): Handle case where the subminor version number has a - in it.
1298         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1299
1300 2020-02-28  youenn fablet  <youenn@apple.com>
1301
1302         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1303         https://bugs.webkit.org/show_bug.cgi?id=208130
1304
1305         Reviewed by Eric Carlson.
1306
1307         * WebKitTestRunner/TestOptions.h:
1308         Use GPU process to capture by default.
1309         We will remove this option once done verifying that every test works smoothly.
1310
1311 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1312
1313         [ews] commit queue should skip building and testing for rollout patches
1314         https://bugs.webkit.org/show_bug.cgi?id=208329
1315
1316         Reviewed by Jonathan Bedard.
1317
1318         * BuildSlaveSupport/ews-build/steps.py:
1319         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1320         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1321         (RunWebKit1Tests.doStepIf): Ditto.
1322         * BuildSlaveSupport/ews-build/steps_unittest.py:
1323         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1324         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1325
1326 2020-02-28  Daniel Bates  <dabates@apple.com>
1327
1328         Update my watch list preferences and contributor's entry.
1329
1330         * Scripts/webkitpy/common/config/contributors.json:
1331         * Scripts/webkitpy/common/config/watchlist:
1332
1333 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1334
1335         Fix WebCore export macros for declspec
1336         https://bugs.webkit.org/show_bug.cgi?id=208363
1337
1338         Reviewed by Konstantin Tokarev.
1339
1340         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1341         files. Removed precompiled headers that were empty.
1342
1343         * DumpRenderTree/DumpRenderTreePrefix.h:
1344         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1345         * MiniBrowser/win/stdafx.h:
1346         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1347         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1348         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1349         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1350         * WebKitTestRunner/PlatformFTW.cmake:
1351         * WebKitTestRunner/PlatformWin.cmake:
1352         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1353
1354 2020-02-27  Tim Horton  <timothy_horton@apple.com>
1355
1356         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1357         https://bugs.webkit.org/show_bug.cgi?id=208365
1358
1359         Reviewed by Alex Christensen.
1360
1361         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1362         (TEST):
1363         Add a test! It was a 100% repro crash before this change.
1364
1365 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
1366
1367         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1368         https://bugs.webkit.org/show_bug.cgi?id=208260
1369         <rdar://problem/59820107>
1370
1371         Reviewed by Tim Horton.
1372
1373         Followed instructions for adding an Info.plist for Single-File Tools
1374         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1375
1376         The default WebsiteDataStore file path will change with this test to
1377         reflect the new bundleID so we must change expectations for any api
1378         tests which rely on knowing the path.
1379
1380         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1382         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1383         (TEST):
1384         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1385         (TEST):
1386         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
1387         (TEST):
1388         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
1389         (TEST):
1390         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1391         (TEST):
1392         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1393         (TEST):
1394         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1395         (TEST):
1396         (defaultWebsiteCacheDirectory):
1397         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
1398         (TEST):
1399         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1400         (TEST):
1401         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1402         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1403         (TEST):
1404         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1405         (TEST):
1406         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1407         (runWebsiteDataStoreCustomPaths):
1408         (TEST):
1409         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1410         (TestWebKitAPI::resetTestState):
1411         Now that we set a bundleID, we have to reset the cache model between
1412         tests, otherwise it gets stored between tests.
1413
1414         (TestWebKitAPI::TEST):
1415         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1416         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1417
1418 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1419
1420         TextManipulationController should not generate a new item for content in manipulated paragraphs
1421         https://bugs.webkit.org/show_bug.cgi?id=208286
1422
1423         Reviewed by Wenson Hsieh.
1424
1425         Added a regression test.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1428         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
1429
1430 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
1431
1432         run-javascriptcore-tests: Make upload format valid
1433         https://bugs.webkit.org/show_bug.cgi?id=208341
1434
1435         Reviewed by Aakash Jain.
1436
1437         * Scripts/run-javascriptcore-tests:
1438         (uploadResults): Print json blob for upload after failure for debugging.
1439
1440 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1441
1442         [CMake] Add WebKit::PAL target
1443         https://bugs.webkit.org/show_bug.cgi?id=198493
1444
1445         Reviewed by Michael Catanzaro.
1446
1447         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
1448
1449         * DumpRenderTree/PlatformWin.cmake:
1450
1451 2020-02-27  Alex Christensen  <achristensen@webkit.org>
1452
1453         Add SPI to query WKFrameInfos in a WKWebView
1454         https://bugs.webkit.org/show_bug.cgi?id=208212
1455
1456         Reviewed by Brady Eidson.
1457
1458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1459         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
1460         * WebKitTestRunner/TestController.cpp:
1461         (WTR::TestController::saltForOrigin):
1462
1463 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
1464
1465         Unreviewed, rolling out r257530.
1466
1467         This commit seems to have broke the build internally for
1468         watchOS
1469
1470         Reverted changeset:
1471
1472         "Add SPI to query WKFrameInfos in a WKWebView"
1473         https://bugs.webkit.org/show_bug.cgi?id=208212
1474         https://trac.webkit.org/changeset/257530
1475
1476 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1477
1478         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
1479         https://bugs.webkit.org/show_bug.cgi?id=206894
1480
1481         Reviewed by Adrian Perez de Castro.
1482
1483         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
1484         MiniBrowsers.
1485
1486         * MiniBrowser/gtk/CMakeLists.txt:
1487         * MiniBrowser/win/CMakeLists.txt:
1488         * MiniBrowser/wpe/CMakeLists.txt:
1489
1490 2020-02-26  Alex Christensen  <achristensen@webkit.org>
1491
1492         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
1493         https://bugs.webkit.org/show_bug.cgi?id=206456
1494
1495         Reviewed by Brady Eidson.
1496
1497         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1498         (TEST):
1499
1500 2020-02-26  Alex Christensen  <achristensen@webkit.org>
1501
1502         _WKUserContentWorld should be a wrapper around WKContentWorld
1503         https://bugs.webkit.org/show_bug.cgi?id=208274
1504
1505         Reviewed by Brady Eidson.
1506
1507         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
1508         (TEST):
1509         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1510         (TEST):
1511
1512 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
1513
1514         Unreviewed, rolling out r257522.
1515
1516         Caused 16 API test failures on the bots
1517
1518         Reverted changeset:
1519
1520         "TestWebKitAPI and WebKitTestRunner should have bundle
1521         identifiers"
1522         https://bugs.webkit.org/show_bug.cgi?id=208260
1523         https://trac.webkit.org/changeset/257522
1524
1525 2020-02-26  Alex Christensen  <achristensen@webkit.org>
1526
1527         Add SPI to query WKFrameInfos in a WKWebView
1528         https://bugs.webkit.org/show_bug.cgi?id=208212
1529
1530         Reviewed by Brady Eidson.
1531
1532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1533         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
1534         * WebKitTestRunner/TestController.cpp:
1535         (WTR::TestController::saltForOrigin):
1536
1537 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
1538
1539         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1540         https://bugs.webkit.org/show_bug.cgi?id=208260
1541         <rdar://problem/59820107>
1542
1543         Reviewed by Tim Horton.
1544
1545         Followed instructions for adding an Info.plist for Single-File Tools
1546         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1547
1548         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1549         * TestWebKitAPI/Info.plist: Added.
1550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1551         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1552         * WebKitTestRunner/Info.plist: Added.
1553         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1554
1555 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
1556
1557         Tests should each use a unique ResourceLoadStatistics file path for its database store
1558         https://bugs.webkit.org/show_bug.cgi?id=208206
1559         <rdar://problem/59690272>
1560
1561         Reviewed by Brady Eidson.
1562
1563         Initialize a default website data store before checking for the ITP
1564         store to ensure the directory exists after the file has been deleted.
1565
1566         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1567         (TEST):
1568
1569 2020-02-26  Christopher Reid  <chris.reid@sony.com>
1570
1571         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
1572         https://bugs.webkit.org/show_bug.cgi?id=197684
1573         <rdar://problem/59467397>
1574
1575         Reviewed by Yusuke Suzuki.
1576
1577         Add test for FileSystem::createFile
1578
1579         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1580
1581 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
1582
1583         [ews] commit-queue should verify patch committer and reviewer
1584         https://bugs.webkit.org/show_bug.cgi?id=206532
1585
1586         Reviewed by Jonathan Bedard.
1587
1588         * BuildSlaveSupport/ews-build/steps.py:
1589         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
1590         (ValidateCommiterAndReviewer._addToLog):
1591         (ValidateCommiterAndReviewer.getResultSummary):
1592         (ValidateCommiterAndReviewer.fail_build):
1593         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
1594         (ValidateCommiterAndReviewer.is_reviewer):
1595         (ValidateCommiterAndReviewer.is_committer):
1596         (ValidateCommiterAndReviewer.full_name_from_email):
1597         (ValidateCommiterAndReviewer.start):
1598
1599 2020-02-26  Daniel Bates  <dabates@apple.com>
1600
1601         [iOS] Send focus update immediately on becoming or resigning first responder
1602         https://bugs.webkit.org/show_bug.cgi?id=208082
1603         <rdar://problem/59688413>
1604
1605         Rubber-stamped by Jer Noble.
1606
1607         Add a test to ensure that selecting a position at a point after the web view
1608         becomes first responder is allowed. Such an operation is only allowed if the
1609         web view is focused.
1610
1611         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1612         (-[TestWKWebView selectPositionAtPoint:]):
1613         (TEST):
1614         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
1615
1616 2020-02-26  Chris Dumez  <cdumez@apple.com>
1617
1618         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
1619
1620         The test was added for macOS and times out on iOS.
1621
1622         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1623         (TEST):
1624
1625 2020-02-26  Youenn Fablet  <youenn@apple.com>
1626
1627         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
1628         https://bugs.webkit.org/show_bug.cgi?id=208238
1629
1630         Reviewed by Eric Carlson.
1631
1632         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1633         (TEST):
1634         Remove use of deleted parameter.
1635
1636 2020-02-25  Devin Rousso  <drousso@apple.com>
1637
1638         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
1639         https://bugs.webkit.org/show_bug.cgi?id=206911
1640         <rdar://problem/58026635>
1641
1642         Reviewed by Brian Burg.
1643
1644         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1645         (TestWebKitAPI::TEST):
1646         Add test for `WTF::HashSet::reserveInitialCapacity`.
1647
1648         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1649         (TestWebKitAPI::TEST):
1650         Actually check the value of `WTF::HashMap::capacity`.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
1653         (-[InspectorDelegate _webView:didAttachInspector:])
1654         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
1655         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1658         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
1659         (TestWebKitAPI::TEST): Deleted.
1660
1661 2020-02-25  Matt Lewis  <jlewis3@apple.com>
1662
1663         Add checkout_root to stubrepository.py
1664         https://bugs.webkit.org/show_bug.cgi?id=208213
1665
1666         Reviewed by Jonathan Bedard.
1667
1668         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1669         (StubRepository.__init__):
1670
1671         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
1672         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
1673
1674 2020-02-25  Daniel Bates  <dabates@apple.com>
1675
1676         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
1677         https://bugs.webkit.org/show_bug.cgi?id=208214
1678
1679         Reviewed by Wenson Hsieh.
1680
1681         Wait until the copy operation completes before loading the second web view and testing paste
1682         to ensure that something was actually copied to the clipboard.
1683
1684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
1685         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1686         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
1687         so that we wait until the command completes.
1688
1689 2020-02-25  Chris Dumez  <cdumez@apple.com>
1690
1691         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
1692         https://bugs.webkit.org/show_bug.cgi?id=208199
1693         <rdar://problem/59746887>
1694
1695         Reviewed by Alex Christensen.
1696
1697         Add API test coverage.
1698
1699         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1700         (TEST):
1701
1702 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1703
1704         spinRunLoop should take a non-zero integer as parameter
1705         https://bugs.webkit.org/show_bug.cgi?id=208148
1706         <rdar://problem/59766682>
1707
1708         Unreviewed iOS build fix.
1709
1710         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1711         (TestWebKitAPI::Util::spinRunLoop):
1712
1713 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1714
1715         spinRunLoop should take a non-zero integer as parameter
1716         https://bugs.webkit.org/show_bug.cgi?id=208148
1717
1718         Reviewed by Darin Adler.
1719
1720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1721         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1722         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1723         (TestWebKitAPI::Util::spinRunLoop):
1724
1725 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1726
1727         [WTF] Add tests for CompactRefPtrTuple
1728         https://bugs.webkit.org/show_bug.cgi?id=208172
1729
1730         Reviewed by Darin Adler.
1731
1732         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
1733         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
1734
1735         * TestWebKitAPI/CMakeLists.txt:
1736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1737         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
1738         (TestWebKitAPI::TEST):
1739
1740 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
1741
1742         [ews] commit-queue should check that patch have appropriate review flag
1743         https://bugs.webkit.org/show_bug.cgi?id=208138
1744
1745         Reviewed by Jonathan Bedard.
1746
1747         * BuildSlaveSupport/ews-build/steps.py:
1748         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
1749         (BugzillaMixin._is_patch_cq_plus):
1750         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
1751         (ValidatePatch.start):
1752
1753 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
1754
1755         [WebAuthn] Implement SPI for the platform authenticator
1756         https://bugs.webkit.org/show_bug.cgi?id=208087
1757         <rdar://problem/59369305>
1758
1759         Reviewed by Brent Fulgham.
1760
1761         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
1762
1763         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
1764         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1766         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1767         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
1768         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
1769         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
1770         (TestWebKitAPI::TEST):
1771         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
1772         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
1773         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
1774         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
1775
1776 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1777
1778         Unreviewed, updating LLDB test for CompactPointerTuple.
1779         https://bugs.webkit.org/show_bug.cgi?id=207827
1780
1781         * lldb/lldb_webkit.py:
1782         (WTFCompactPointerTupleProvider):
1783         (WTFCompactPointerTupleProvider.update):
1784
1785 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
1786
1787         Provide alternate way to name Web Content process
1788         https://bugs.webkit.org/show_bug.cgi?id=205224
1789         rdar://57038084
1790
1791         Reviewed by Alex Christensen.
1792
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1794         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
1795         (TestWebKitAPI::TEST):
1796
1797 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
1798
1799         results.webkit.org: Link to result archives
1800         https://bugs.webkit.org/show_bug.cgi?id=207646
1801         <rdar://problem/59395807>
1802
1803         Rubber-stamped by Aakash Jain.
1804
1805         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
1806         (_ArchiveRouter): Retrieve json from archive-router endpoint.
1807         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
1808         return the most specific value.
1809         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
1810         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
1811         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
1812         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1813         (parametersForInstance): Extract from lambda function.
1814         (testRunLink): Use parametersForInstance instead of a lambda function.
1815         (archiveLink): Return an archive link for data. 
1816         (contentForData): Add archive link to view.
1817         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1818         (TimelineFromEndpoint): Accept both suite and test.
1819         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
1820         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
1821         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
1822         * resultsdbpy/resultsdbpy/view/view_routes.py:
1823         (ViewRoutes.__init__): Add archive_route dictionary.
1824
1825 2020-02-24  Alex Christensen  <achristensen@webkit.org>
1826
1827         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
1828         https://bugs.webkit.org/show_bug.cgi?id=208035
1829         <rdar://problem/58011337>
1830
1831         Reviewed by Tim Hatcher.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1834
1835 2020-02-22  Darin Adler  <darin@apple.com>
1836
1837         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
1838         https://bugs.webkit.org/show_bug.cgi?id=208099
1839
1840         Reviewed by Antti Koivisto.
1841
1842         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1843         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
1844         so we can use the -[NSString createJSStringRef] method.
1845         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
1846         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
1847
1848 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1849
1850         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
1851         https://bugs.webkit.org/show_bug.cgi?id=208096
1852         <rdar://problem/59632008>
1853
1854         Reviewed by Alexey Proskuryakov.
1855
1856         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
1857         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
1858         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
1859
1860         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
1861         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
1862         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
1863         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
1864         in the credit card expiry field.
1865
1866         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
1867
1868         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1869         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1870         (WTR::UIScriptController::setDefaultCalendarType):
1871         * WebKitTestRunner/TestController.h:
1872
1873         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
1874         identifier and calendar locale identifier.
1875
1876         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1877         (WTR::swizzledCalendar):
1878         (WTR::TestController::overriddenCalendarIdentifier const):
1879         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
1880
1881         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
1882
1883         (WTR::TestController::setDefaultCalendarType):
1884
1885         Plumb the new calendar's locale identifier through this method.
1886
1887         (WTR::TestController::cocoaResetStateToConsistentValues):
1888         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
1889         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1890         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1891         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
1892
1893 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
1894
1895         App-bound domains should have separate Network Sessions
1896         https://bugs.webkit.org/show_bug.cgi?id=208026
1897         <rdar://problem/59434006>
1898
1899         Reviewed by Brent Fulgham.
1900
1901         This patch is mostly test infrastructure involving 3 functions.
1902         One sets in-app browser privacy as enabled in the network process
1903         manually for the test. One ensures that setting the WebView category
1904         works properly, and the last one checks for an app-bound session for
1905         an app-bound navigation.
1906
1907         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1908         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1909         (WTR::InjectedBundle::didReceiveMessageToPage):
1910         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1911         (WTR::TestRunner::getWebViewCategory):
1912         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
1913         (WTR::TestRunner::hasAppBoundSession):
1914         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
1915         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
1916         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1917         * WebKitTestRunner/TestController.cpp:
1918         (WTR::TestController::ensureViewSupportsOptionsForTest):
1919         Clearing the bundleID should happen right before setting a new one, 
1920         otherwise it clears the ID after it is set and returns a null ID.
1921
1922         (WTR::TestController::resetStateToConsistentValues):
1923         (WTR::TestController::getWebViewCategory):
1924         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
1925         (WTR::inAppBrowserPrivacyBooleanResultCallback):
1926         (WTR::inAppBrowserPrivacyVoidResultCallback):
1927         (WTR::TestController::hasAppBoundSession):
1928         (WTR::TestController::setInAppBrowserPrivacyEnabled):
1929         * WebKitTestRunner/TestController.h:
1930         * WebKitTestRunner/TestInvocation.cpp:
1931         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1932         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1933         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
1934         (WTR::TestInvocation::didReceivePrevalentDomains):
1935         (WTR::TestInvocation::didReceiveWebViewCategory):
1936         * WebKitTestRunner/TestInvocation.h:
1937         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1938         (WTR::TestController::getWebViewCategory):
1939
1940 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
1941
1942         Build DumpRenderTree and WebKitTestRunner for macCatalyst
1943         https://bugs.webkit.org/show_bug.cgi?id=208068
1944         <rdar://problem/59676596>
1945
1946         Reviewed by Tim Horton.
1947
1948         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
1949         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1950         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
1951         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
1952         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
1953         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
1954         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
1955         * DumpRenderTree/mac/EventSendingController.h: Ditto.
1956         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
1957         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1958         * Makefile: Add DumpRenderTree and WebKitTestRunner.
1959         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1960         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
1961         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1962
1963 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [ews] Add build step to Validate ChangeLog for commit-queue
1966         https://bugs.webkit.org/show_bug.cgi?id=208064
1967
1968         Reviewed by Jonathan Bedard.
1969
1970         * BuildSlaveSupport/ews-build/steps.py:
1971         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
1972         (ValidateChangeLogAndReviewer.start):
1973         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
1974         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
1975
1976 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1977
1978         [ews] Add build step to set cq- flag on bugzilla patch
1979         https://bugs.webkit.org/show_bug.cgi?id=208021
1980
1981         Reviewed by Jonathan Bedard.
1982
1983         * BuildSlaveSupport/ews-build/steps.py:
1984         (BugzillaMixin.set_cq_minus_flag_on_patch):
1985         (SetCommitQueueMinusFlagOnPatch):
1986         (SetCommitQueueMinusFlagOnPatch.start):
1987         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
1988
1989 2020-02-20  Matt Lewis  <jlewis3@apple.com>
1990
1991         Stub repositories fail to upload some results due to missing head svn revision
1992         https://bugs.webkit.org/show_bug.cgi?id=207684
1993
1994         Reviewed by Jonathan Bedard.
1995
1996         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
1997         (MockHost.__init__):
1998         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1999         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2000         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2001         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
2002         * Scripts/webkitpy/port/base.py:
2003         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
2004         from using mock SCMs and more
2005         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
2006
2007 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
2008
2009         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
2010         https://bugs.webkit.org/show_bug.cgi?id=208051
2011
2012         Reviewed by Carlos Alberto Lopez Perez.
2013
2014         Verbose flag prints out each test name executed. Without this flag
2015         stdout prints out one or two periods.
2016
2017         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2018         (RunJavaScriptCoreTests.start):
2019
2020 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2021
2022         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2023         https://bugs.webkit.org/show_bug.cgi?id=207984
2024
2025         Reviewed by Daniel Bates.
2026
2027         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2028         (TestWebKitAPI::TEST):
2029
2030 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2031
2032         [GTK] Improve user agent quirk for Google Docs and Google Drive
2033         https://bugs.webkit.org/show_bug.cgi?id=206506
2034
2035         Reviewed by Carlos Garcia Campos.
2036
2037         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2038         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2039         (TestWebKitAPI::TEST):
2040
2041 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2042
2043         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2044         https://bugs.webkit.org/show_bug.cgi?id=207380
2045
2046         Reviewed by Jonathan Bedard.
2047
2048         Added a new rule 'build/export_macro'.
2049
2050         Removed a obsolete rule 'readability/webkit_export' which was used
2051         only by Chromium port (r148185).
2052
2053         * Scripts/webkitpy/style/checkers/cpp.py:
2054         (_FunctionState.export_macro):
2055         (check_function_definition):
2056         (_unix_path): Added.
2057         (is_generated_file): Use _unix_path.
2058         (check_has_config_header): Ditto.
2059         (CppChecker):
2060         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2061         (WebKitStyleTest.test_export_macro_check):
2062         (WebKitStyleTest.test_webkit_export_check): Deleted.
2063
2064 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2065
2066         [Win][MiniBrowser] Add prettier toolbar button icons
2067         https://bugs.webkit.org/show_bug.cgi?id=207999
2068
2069         Reviewed by Ross Kirsling.
2070
2071         Use a custom toolbar button icons instead of system stock icons.
2072
2073         Fixed a bug toolbar button dropdown arrows always looked being
2074         hovered. TBSTYLE_FLAT should be given.
2075
2076         Removed the window border line of Progress Indicator.
2077
2078         * MiniBrowser/win/MainWindow.cpp:
2079         (MainWindow::createToolbar):
2080         * MiniBrowser/win/MiniBrowserLib.rc:
2081         * MiniBrowser/win/MiniBrowserLibResource.h:
2082         * MiniBrowser/win/toolbar.bmp: Added.
2083
2084 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2085
2086         Update run-webkit-tests help description for skip-failing-tests
2087         https://bugs.webkit.org/show_bug.cgi?id=208031
2088
2089         Reviewed by Alexey Proskuryakov.
2090
2091         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2092
2093 2020-02-20  Chris Dumez  <cdumez@apple.com>
2094
2095         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2096         https://bugs.webkit.org/show_bug.cgi?id=208015
2097         <rdar://problem/59591630>
2098
2099         Reviewed by Geoffrey Garen.
2100
2101         Add API test coverage.
2102
2103         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2104         (TEST):
2105
2106 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2107
2108         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2109         https://bugs.webkit.org/show_bug.cgi?id=207998
2110         <rdar://problem/40942425>
2111
2112         Reviewed by Sam Weinig.
2113
2114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2115         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2116         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2117         (TestWebKitAPI::TEST):
2118         Add some tests for top content insets.
2119
2120 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2121
2122         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2123         https://bugs.webkit.org/show_bug.cgi?id=207910
2124
2125         Unreviewed infrastructure fix.
2126
2127         * Scripts/run-javascriptcore-tests:
2128         (configurationForUpload): Use the major version instead of the sub-minor version
2129         for version name.
2130
2131 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2132
2133         [CMake] Add WPE::libwpe target
2134         https://bugs.webkit.org/show_bug.cgi?id=207970
2135
2136         Reviewed by Adrian Perez de Castro.
2137
2138         Use the WPE::libwpe target.
2139
2140         * MiniBrowser/wpe/CMakeLists.txt:
2141         * TestWebKitAPI/PlatformWPE.cmake:
2142         * TestWebKitAPI/glib/PlatformWPE.cmake:
2143         * wpe/backends/CMakeLists.txt:
2144
2145 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2146
2147         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2148         https://bugs.webkit.org/show_bug.cgi?id=207749
2149
2150         Reviewed by Ross Kirsling.
2151
2152         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2153
2154         * MiniBrowser/win/MainWindow.cpp:
2155         (MainWindow::createToolbar):
2156         (MainWindow::WndProc):
2157         (MainWindow::setDefaultURLToCurrentURL):
2158         (MainWindow::goHome): Added.
2159         (MainWindow::onURLBarEnter):
2160         * MiniBrowser/win/MainWindow.h:
2161         * MiniBrowser/win/MiniBrowserLib.rc:
2162         * MiniBrowser/win/MiniBrowserLibResource.h:
2163         * MiniBrowser/win/MiniBrowserReplace.h:
2164         * MiniBrowser/win/WinMain.cpp:
2165         (wWinMain):
2166
2167 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2168
2169         Fix check-webkit-style errors related to AVFoundationSPI.h
2170         https://bugs.webkit.org/show_bug.cgi?id=207834
2171
2172         Reviewed by Daniel Bates.
2173
2174         Revert the change in r256770 regarding the headers ordering.
2175         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2176
2177         * Scripts/webkitpy/style/checkers/cpp.py:
2178         (check_include_line):
2179
2180 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2181
2182         results.webkit.org: Correctly report JSC tests for windows
2183         https://bugs.webkit.org/show_bug.cgi?id=207910
2184
2185         Rubber-stamped by Aakash Jain.
2186
2187         * Scripts/run-javascriptcore-tests:
2188         (configurationForUpload): Give Windows a version name.
2189         * Scripts/webkitdirs.pm:
2190         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2191         Version dictionary.
2192
2193 2020-02-19  Chris Dumez  <cdumez@apple.com>
2194
2195         Unreviewed, fix assertions in storage access API layout tests after r256882.
2196
2197         Drop dead testRunner code to toggle storage access API feature.
2198
2199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2201         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2202         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2203         * WebKitTestRunner/TestInvocation.cpp:
2204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2205
2206 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2207
2208         [WPE] Support 2D axis, smooth-motion events
2209         https://bugs.webkit.org/show_bug.cgi?id=207881
2210
2211         Reviewed by Carlos Garcia Campos.
2212
2213         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2214
2215 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2216
2217         Unreviewed, rolling out r256851.
2218
2219         Broke internal bots
2220
2221         Reverted changeset:
2222
2223         "Stub repositories fail to upload some results due to missing
2224         head svn revision"
2225         https://bugs.webkit.org/show_bug.cgi?id=207684
2226         https://trac.webkit.org/changeset/256851
2227
2228 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2229
2230         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2231         https://bugs.webkit.org/show_bug.cgi?id=207883
2232
2233         Reviewed by Ross Kirsling.
2234
2235         Unlike other mouse buttons, 4th and 5th mouse buttons are
2236         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2237         WM_XBUTTONUP events to the window under the mouse cursor.
2238         Unhandled WM_XBUTTONUP events are automatically converted to
2239         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2240         parent window.
2241         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2242
2243         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2244         handled.
2245
2246         * MiniBrowser/win/BrowserWindow.h:
2247         * MiniBrowser/win/MainWindow.cpp:
2248         (MainWindow::WndProc):
2249         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2250         (WebKitBrowserWindow::navigateForwardOrBackward):
2251         * MiniBrowser/win/WebKitBrowserWindow.h:
2252         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2253         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2254         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2255
2256 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2257
2258         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2259         https://bugs.webkit.org/show_bug.cgi?id=207912
2260         <rdar://problem/59556922>
2261
2262         Reviewed by Brian Weinstein.
2263
2264         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2265         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2266         (TEST):
2267         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2268         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2269
2270 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2271
2272         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2273         https://bugs.webkit.org/show_bug.cgi?id=207899
2274         <rdar://problem/55658207>
2275
2276         Reviewed by Tim Horton and Simon Fraser.
2277
2278         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2279
2280         * WebKitTestRunner/TestController.cpp:
2281         (WTR::updateTestOptionsFromTestHeader):
2282         * WebKitTestRunner/TestOptions.h:
2283         (WTR::TestOptions::hasSameInitializationOptions const):
2284         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2285         (WTR::TestController::platformCreateWebView):
2286
2287 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2288
2289         Stub repositories fail to upload some results due to missing head svn revision
2290         https://bugs.webkit.org/show_bug.cgi?id=207684
2291
2292         Reviewed by Jonathan Bedard.
2293
2294         * Scripts/webkitpy/api_tests/run_api_tests.py:
2295         (main): Added initializing the scm to the host object.
2296         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2297         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2298         it in line with modern code.
2299         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2300         (main): Added inializing the scm to the host object.
2301         * Scripts/webkitpy/port/base.py:
2302         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2303         from using mock SCMs and more
2304         * Scripts/webkitpy/test/main.py:
2305         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2306         and converted the webkit_root variable to the SCM checkout root.
2307         (Tester._run_tests):
2308
2309 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2310
2311         Move [UIDevice currentDevice] calls to UI process
2312         https://bugs.webkit.org/show_bug.cgi?id=204320
2313
2314         Reviewed by Darin Adler.
2315
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2318         (TEST):
2319
2320 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2321
2322         Move from "layer flush" terminology to "rendering update"
2323         https://bugs.webkit.org/show_bug.cgi?id=207870
2324
2325         Reviewed by Tim Horton.
2326
2327         Rename various functions and member variables to move away from the legacy "layer flush"
2328         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2329         that we have layers is an implementation detail.
2330         
2331         Change LayerFlushThrottlingState to be an OptionSet<>.
2332
2333         * Tracing/SystemTracePoints.plist:
2334
2335 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2336
2337         [Webkit.css] Adding popover style element
2338         This help to prevent us reinventing the wheel ever again
2339         https://bugs.webkit.org/show_bug.cgi?id=207787
2340
2341         Reviewed by Dean Jackson.
2342
2343         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2344         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2345         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2346         (.popover):
2347         (.popover>.content):
2348         (.popover.display):
2349         (.popover .arrow):
2350         (.popover .arrow.point-top):
2351         (.popover .arrow.point-bottom):
2352         (.popover .arrow.point-left):
2353         (.popover .arrow.point-right):
2354         (@media (prefers-color-scheme: dark) .popover>.content):
2355         (@media (prefers-color-scheme: dark) .popover.display):
2356         (@media (prefers-color-scheme: dark) .popover .arrow):
2357         (.popover>.content>.section): Deleted.
2358         (.popover:focus>.content, .popover:hover>.content): Deleted.
2359         (.popover.right>.content): Deleted.
2360         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
2361         (.popover.left>.content): Deleted.
2362         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
2363         (.popover.bottom>.content): Deleted.
2364         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
2365
2366 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
2367
2368         Update WebKit Tools to issue mach extensions as needed
2369         https://bugs.webkit.org/show_bug.cgi?id=207850
2370         <rdar://problem/59521019>
2371
2372         Reviewed by Per Arne Vollan.
2373
2374         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
2375         to its child processes (WebContent, GPU, Network, etc.) as needed.
2376
2377         * MiniBrowser/MiniBrowser.entitlements:
2378         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
2379         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2381         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
2382
2383 2020-02-17  Peng Liu  <peng.liu6@apple.com>
2384
2385         Fix check-webkit-style errors related to AVFoundationSPI.h
2386         https://bugs.webkit.org/show_bug.cgi?id=207834
2387
2388         Reviewed by Eric Carlson.
2389
2390         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
2391         Soft-link headers can be included as either "file.h" or <file.h>.
2392
2393         * Scripts/webkitpy/style/checkers/cpp.py:
2394         (_classify_include):
2395         (check_include_line):
2396
2397 2020-02-17  Keith Rollin  <krollin@apple.com>
2398
2399         Unreviewed build fix after r256715.
2400
2401         Fix tvOS and watchOS builds.
2402
2403         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2404
2405 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
2406
2407         Use CF prefs direct mode in the WebContent process
2408         https://bugs.webkit.org/show_bug.cgi?id=203420
2409
2410         Reviewed by Brent Fulgham.
2411
2412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2413         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
2414         (TEST):
2415
2416 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
2417
2418         EWS should be able to file Bugzilla bugs
2419         https://bugs.webkit.org/show_bug.cgi?id=207845
2420
2421         Reviewed by Alexey Proskuryakov.
2422
2423         * BuildSlaveSupport/ews-build/steps.py:
2424         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
2425
2426 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
2427
2428         EWS should be able to comment on Bugzilla
2429         https://bugs.webkit.org/show_bug.cgi?id=201927
2430
2431         Reviewed by Jonathan Bedard.
2432
2433         * BuildSlaveSupport/ews-build/steps.py:
2434         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
2435         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
2436         (BugzillaMixin.close_bug): Ditto.
2437         (CommentOnBug): Build step to comment on bugzilla bug.
2438
2439 2020-02-17  Antti Koivisto  <antti@apple.com>
2440
2441         [macOS] Add trace points for layer flush runloop observer
2442         https://bugs.webkit.org/show_bug.cgi?id=207837
2443
2444         Reviewed by Sam Weinig.
2445
2446         * Tracing/SystemTracePoints.plist:
2447
2448 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
2449
2450         [CMake] Use builtin targets
2451         https://bugs.webkit.org/show_bug.cgi?id=205166
2452
2453         Reviewed by Darin Adler.
2454
2455         * TestWebKitAPI/PlatformWin.cmake:
2456
2457 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
2458
2459         [ews] add SetBuildSummary step for Windows EWS
2460         https://bugs.webkit.org/show_bug.cgi?id=207556
2461
2462         Reviewed by Jonathan Bedard.
2463
2464         * BuildSlaveSupport/ews-build/factories.py:
2465         (WindowsFactory.__init__):
2466         (GTKBuildAndTestFactory.__init__):
2467         * BuildSlaveSupport/ews-build/factories_unittest.py:
2468         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
2469
2470 2020-02-17  Alberto Garcia  <berto@igalia.com>
2471
2472         [WPE] Change the QML plugin install path
2473         https://bugs.webkit.org/show_bug.cgi?id=207761
2474
2475         Reviewed by Philippe Normand.
2476
2477         * Scripts/run-qt-wpe-minibrowser:
2478         * glib/api_test_runner.py:
2479         (TestRunner._run_test_qt):
2480
2481 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2482
2483         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
2484         https://bugs.webkit.org/show_bug.cgi?id=207746
2485
2486         Reviewed by Don Olmstead.
2487
2488         * MiniBrowser/win/stdafx.h:
2489
2490 2020-02-16  Brady Eidson  <beidson@apple.com>
2491
2492         Expose "allowsContentJavaScript" on WKWebpagePreferences
2493         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
2494
2495         Reviewed by Darin Adler.
2496
2497         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2498         (TEST):
2499         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2500         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2501         (TEST):
2502         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
2503         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2504         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2505         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
2506         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
2507         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
2508         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2509         * TestWebKitAPI/cocoa/TestWKWebView.h:
2510         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2511         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
2512
2513 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
2514
2515         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
2516         https://bugs.webkit.org/show_bug.cgi?id=207747
2517
2518         Reviewed by Keith Miller.
2519
2520         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
2521         (TestWebKitAPI::TEST):
2522
2523 2020-02-14  Alex Christensen  <achristensen@webkit.org>
2524
2525         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
2526         https://bugs.webkit.org/show_bug.cgi?id=207360
2527         <rdar://problem/57825317>
2528
2529         Reviewed by Ryosuke Niwa.
2530
2531         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2532         (TestWebKitAPI::TEST):
2533
2534 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
2535
2536         [CMake] Add Fontconfig::Fontconfig target
2537         https://bugs.webkit.org/show_bug.cgi?id=207730
2538
2539         Reviewed by Adrian Perez de Castro.
2540
2541         Use the Fontconfig::Fontconfig target.
2542
2543         * WebKitTestRunner/PlatformGTK.cmake:
2544
2545 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
2546
2547          Expose prevalent domains on a per-page basis
2548          https://bugs.webkit.org/show_bug.cgi?id=207523
2549          <rdar://problem/59270758>
2550
2551         Reviewed by Chris Dumez.
2552
2553         Added WebKitTestRunner functions so this functionality can be tested.
2554         clearPrevalentDomains should be called between tests to reset the
2555         state.
2556
2557         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2558         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2559         (WTR::InjectedBundle::didReceiveMessageToPage):
2560         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2561         (WTR::TestRunner::getPrevalentDomains):
2562         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
2563         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2564         * WebKitTestRunner/TestController.cpp:
2565         (WTR::TestController::resetStateToConsistentValues):
2566         (WTR::TestController::getPrevalentDomains):
2567         (WTR::TestController::clearPrevalentDomains):
2568         * WebKitTestRunner/TestController.h:
2569         * WebKitTestRunner/TestInvocation.cpp:
2570         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2571         (WTR::TestInvocation::didReceivePrevalentDomains):
2572         * WebKitTestRunner/TestInvocation.h:
2573         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2574         (WTR::TestController::getPrevalentDomains):
2575         (WTR::TestController::clearPrevalentDomains):
2576
2577 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2578
2579         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
2580         https://bugs.webkit.org/show_bug.cgi?id=207682
2581
2582         Reviewed by Ross Kirsling.
2583
2584         The toolbar placed button common controls as the toolbar buttons.
2585         However, because these buttons are focusable, shortcut keys don't
2586         work after clicking them.
2587
2588         Added Home button, Add to Bookmarks button, dropdown buttons of
2589         back and forward buttons, but they aren't implemented yet. Just
2590         placeholders at the moment.
2591
2592         * MiniBrowser/win/MainWindow.cpp:
2593         (MainWindow::createToolbar): Added.
2594         (MainWindow::resizeToolbar): Added.
2595         (MainWindow::rescaleToolbar): Added.
2596         (MainWindow::init):
2597         (MainWindow::resizeSubViews):
2598         (MainWindow::updateDeviceScaleFactor):
2599         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
2600
2601 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2602
2603         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
2604         https://bugs.webkit.org/show_bug.cgi?id=207676
2605
2606         Reviewed by Wenson Hsieh and Timothy Hatcher.
2607
2608         Added regression tests for pasting content with -apple-system-label and outdenting content.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2611         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
2612         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
2613
2614 2020-02-13  Alex Christensen  <achristensen@webkit.org>
2615
2616         _WKResourceLoadInfo should conform to NSSecureCoding
2617         https://bugs.webkit.org/show_bug.cgi?id=207667
2618
2619         Reviewed by Brady Eidson.
2620
2621         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2622         (TEST):
2623
2624 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
2625
2626         [PlayStation] Add Buildbots for Debug/Release builds
2627         https://bugs.webkit.org/show_bug.cgi?id=199454
2628
2629         Reviewed by Aakash Jain.
2630
2631         * BuildSlaveSupport/build.webkit.org-config/config.json:
2632         Add PlayStation slaves, builders
2633         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2634         Use higher timeout for playstation as with win bot
2635         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2636         Set PlayStation category for playstation platform
2637         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2638         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
2639         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2640         Add PlayStation expectations
2641
2642 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
2643
2644         [iOS] Check if PIP is supported in the UI process
2645         https://bugs.webkit.org/show_bug.cgi?id=207406
2646
2647         Reviewed by Brent Fulgham.
2648
2649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2650         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
2651         (TEST):
2652
2653 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2654
2655         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
2656         https://bugs.webkit.org/show_bug.cgi?id=207397
2657         <rdar://problem/59268128>
2658
2659         Reviewed by Jer Noble.
2660
2661         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2662         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2663
2664 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2665
2666         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
2667         https://bugs.webkit.org/show_bug.cgi?id=207696
2668
2669         Reviewed by Tim Horton.
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2672
2673 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2674
2675         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
2676         https://bugs.webkit.org/show_bug.cgi?id=207680
2677         <rdar://problem/59340940>
2678
2679         Reviewed by Tim Horton.
2680
2681         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
2682         the current selection works.
2683
2684         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2685         (-[TestWKWebView updateSelectionWithExtentPoint:]):
2686         * TestWebKitAPI/ios/UIKitSPI.h:
2687
2688 2020-02-13  Said Abou-Hallawa  <said@apple.com>
2689
2690         Unreviewed, rolling out r255158, 255405 and r255486
2691
2692         Caused test flakiness and PLT regression.
2693
2694         * DumpRenderTree/mac/DumpRenderTree.mm:
2695         (resetWebPreferencesToConsistentValues):
2696         * DumpRenderTree/win/DumpRenderTree.cpp:
2697         (enableExperimentalFeatures):
2698         * WebKitTestRunner/TestController.cpp:
2699         (WTR::TestController::resetPreferencesToConsistentValues):
2700
2701 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2702
2703         run-javascriptcore-tests: Allow insecure requests on upload
2704         https://bugs.webkit.org/show_bug.cgi?id=207662
2705
2706         Rubber-stamped by Aakash Jain.
2707
2708         * Scripts/run-javascriptcore-tests:
2709         (uploadResults): Allow insecure curl request when posting results.
2710
2711 2020-02-12  Truitt Savell  <tsavell@apple.com>
2712
2713         Unreviewed, rolling out r256463.
2714
2715         Caused major flakiness on Mac wk2
2716
2717         Reverted changeset:
2718
2719         "REGRESSION (r255158): http/tests/frame-throttling/raf-
2720         throttle-in-cross-origin-subframe.html is a flaky failure"
2721         https://bugs.webkit.org/show_bug.cgi?id=206839
2722         https://trac.webkit.org/changeset/256463
2723
2724 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2725
2726         results.webkit.org: Remove debug JS logging
2727         https://bugs.webkit.org/show_bug.cgi?id=207663
2728
2729         Reviewed by Aakash Jain.
2730
2731         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2732         (elapsed):
2733         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2734         (_ToolTip.prototype.toString):
2735         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2736         (prototype.addWithDelay):
2737         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
2738
2739 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
2740
2741         Remove CSS_DEVICE_ADAPTATION
2742         https://bugs.webkit.org/show_bug.cgi?id=203479
2743
2744         Reviewed by Tim Horton.
2745         
2746         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
2747         so remove the code.
2748
2749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2750
2751 2020-02-12  Said Abou-Hallawa  <said@apple.com>
2752
2753         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
2754         https://bugs.webkit.org/show_bug.cgi?id=206839
2755
2756         Reviewed by Simon Fraser.
2757
2758         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
2759
2760         * DumpRenderTree/mac/DumpRenderTree.mm:
2761         (resetWebPreferencesToConsistentValues):
2762         * DumpRenderTree/win/DumpRenderTree.cpp:
2763         (enableExperimentalFeatures):
2764         * WebKitTestRunner/TestController.cpp:
2765         (WTR::TestController::resetPreferencesToConsistentValues):
2766
2767 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2768
2769         results.webkit.org: Cache archive content
2770         https://bugs.webkit.org/show_bug.cgi?id=207589
2771
2772         Reviewed by Aakash Jain.
2773
2774         * resultsdbpy/resultsdbpy/flask_support/util.py:
2775         (cache_for): Add decorator function which sets the cache values on the returned response.
2776         * resultsdbpy/resultsdbpy/view/archive_view.py:
2777         (ArchiveView): Cache archive content client-side for 12 hours.
2778         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
2779         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
2780
2781 2020-02-12  Youenn Fablet  <youenn@apple.com>
2782
2783         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2784         https://bugs.webkit.org/show_bug.cgi?id=207537
2785
2786         Reviewed by Chris Dumez.
2787
2788         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2789
2790 2020-02-11  Rob Buis  <rbuis@igalia.com>
2791
2792         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
2793         <https://webkit.org/b/207424>
2794         <rdar://problem/59250384>
2795
2796         Reviewed by Rob Buis.
2797
2798         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2799         (TestWebKitAPI::TEST): Add more tests.
2800
2801 2020-02-11  Commit Queue  <commit-queue@webkit.org>
2802
2803         Unreviewed, rolling out r256314.
2804         https://bugs.webkit.org/show_bug.cgi?id=207594
2805
2806         It is breaking an API test (Requested by youenn on #webkit).
2807
2808         Reverted changeset:
2809
2810         "WebSWServerConnection::registerServiceWorkerClient is not
2811         sending IPC message to UIProcess when it should"
2812         https://bugs.webkit.org/show_bug.cgi?id=207537
2813         https://trac.webkit.org/changeset/256314
2814
2815 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
2816
2817         results.webkit.org: Configuration documentation should include architecture
2818         https://bugs.webkit.org/show_bug.cgi?id=207584
2819
2820         Reviewed by Aakash Jain.
2821
2822         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
2823
2824 2020-02-11  Youenn Fablet  <youenn@apple.com>
2825
2826         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
2827         https://bugs.webkit.org/show_bug.cgi?id=207325
2828         <rdar://problem/59224810>
2829
2830         Reviewed by Eric Carlson.
2831
2832         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2833         (TestWebKitAPI::TEST):
2834         Add a test validating that RTCRtpSender.getCapabilities does not return null.
2835         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2836
2837 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2838
2839         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
2840         https://bugs.webkit.org/show_bug.cgi?id=207557
2841
2842         Reviewed by Jonathan Bedard.
2843
2844         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
2845         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
2846         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
2847         around this by focusing an empty select element instead (for which we won't attempt to create and select any
2848         table view cells).
2849
2850         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2851
2852 2020-02-11  Alex Christensen  <achristensen@webkit.org>
2853
2854         Add WKHTTPCookieStore._getCookiesForURL SPI
2855         https://bugs.webkit.org/show_bug.cgi?id=207527
2856
2857         Reviewed by Brady Eidson.
2858
2859         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2860         (TEST):
2861
2862 2020-02-11  Youenn Fablet  <youenn@apple.com>
2863
2864         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2865         https://bugs.webkit.org/show_bug.cgi?id=207537
2866
2867         Reviewed by Chris Dumez.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2870
2871 2020-02-11  Lauro Moura  <lmoura@igalia.com>
2872
2873         [WPE][WebDriver] MiniBrowser should react to close session commands
2874         https://bugs.webkit.org/show_bug.cgi?id=207529
2875
2876         Reviewed by Carlos Garcia Campos.
2877
2878         WebDriver delete session command asks to close the WebView associated to the
2879         current automation session. We must react to it to avoid lots of
2880         timeouts and errors.
2881
2882         * MiniBrowser/wpe/main.cpp:
2883         (main): Listen to "close" signal on the main WebView.
2884
2885 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2886
2887         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
2888         https://bugs.webkit.org/show_bug.cgi?id=207525
2889         <rdar://problem/59110543>
2890
2891         Reviewed by Tim Horton.
2892
2893         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
2894         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
2895         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
2896         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
2897         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
2898         causing us to crash upon trying to create the dictionary.
2899
2900         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
2901         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
2902         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
2903         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
2904         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
2905         beginning of each API test.
2906
2907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2908         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2909         (overrideBundleIdentifier):
2910
2911         Move this to the top of the file, so it can be shared.
2912
2913         (+[WKWebView initialize]):
2914
2915         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
2916         internal class method that calls into the internal helper function, with no other side effects.
2917
2918         * TestWebKitAPI/ios/UIKitSPI.h:
2919
2920 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2921
2922         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
2923         https://bugs.webkit.org/show_bug.cgi?id=207501
2924         <rdar://problem/59323414>
2925
2926         Reviewed by Alex Christensen.
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2929         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
2930         The same behavior.
2931
2932 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
2933
2934         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
2935         https://bugs.webkit.org/show_bug.cgi?id=207352
2936         <rdar://problem/59115798>
2937
2938         Reviewed by Alex Christensen.
2939
2940         Add a test to exercise the new SPI.
2941
2942         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
2943         a webpage that contains text in subframes.
2944
2945
2946 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2947
2948         [iOS] Crash when granting access to asset services
2949         https://bugs.webkit.org/show_bug.cgi?id=207520
2950
2951         Reviewed by Brent Fulgham.
2952
2953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2954         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
2955         (TEST):
2956
2957 2020-02-10  Chris Dumez  <cdumez@apple.com>
2958
2959         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
2960         https://bugs.webkit.org/show_bug.cgi?id=207481
2961
2962         Reviewed by Alexey Proskuryakov.
2963
2964         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
2965         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
2966         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
2967
2968         * DumpRenderTree/mac/DumpRenderTree.mm:
2969         (resetWebViewToConsistentStateBeforeTesting):
2970         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
2971         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
2972         over internal settings.
2973
2974 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2975
2976         [watchOS] Notification listener is never unregistered
2977         https://bugs.webkit.org/show_bug.cgi?id=207459
2978
2979         Reviewed by Maciej Stachowiak.
2980
2981         Add a test which tests that posting a backlight level change notification will not cause a crash.
2982
2983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2984         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
2985         (TEST):
2986
2987 2020-02-10  James Howard  <jameshoward@mac.com>
2988
2989         Standard gamepad mapping for GameControllerGamepads
2990         https://bugs.webkit.org/show_bug.cgi?id=206033
2991
2992         Reviewed by Dean Jackson.
2993
2994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2996         (WTR::TestRunner::setMockGamepadDetails):
2997         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2998         * WebKitTestRunner/TestInvocation.cpp:
2999         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3000
3001 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3002
3003         [ews] Display flaky layout test names in build summary
3004         https://bugs.webkit.org/show_bug.cgi?id=207504
3005
3006         Reviewed by Jonathan Bedard.
3007
3008         * BuildSlaveSupport/ews-build/steps.py:
3009         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
3010         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
3011         (AnalyzeLayoutTestsResults.start):
3012
3013 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3014
3015         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
3016         https://bugs.webkit.org/show_bug.cgi?id=207492
3017
3018         Reviewed by Jonathan Bedard.
3019
3020         * BuildSlaveSupport/ews-build/steps.py:
3021         (RunWebKitTests.evaluateCommand):
3022         (ReRunWebKitTests.evaluateCommand):
3023         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3024         * BuildSlaveSupport/ews-build/factories.py:
3025         (TestFactory.__init__):
3026
3027 2020-02-10  Truitt Savell  <tsavell@apple.com>
3028
3029         Unreviewed, rolling out r256091.
3030
3031         Broke internal builds
3032
3033         Reverted changeset:
3034
3035         "Move trivial definitions from FeatureDefines.xcconfig to
3036         PlatformEnableCocoa.h"
3037         https://bugs.webkit.org/show_bug.cgi?id=207155
3038         https://trac.webkit.org/changeset/256091
3039
3040 2020-02-10  Truitt Savell  <tsavell@apple.com>
3041
3042         Unreviewed, rolling out r256103.
3043
3044         This patch is blocking the rollout of r256091
3045
3046         Reverted changeset:
3047
3048         "Move JavaScriptCore related feature defines from
3049         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
3050         https://bugs.webkit.org/show_bug.cgi?id=207436
3051         https://trac.webkit.org/changeset/256103
3052
3053 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3054
3055         results.webkit.org: Abstract archive storage solutions
3056         https://bugs.webkit.org/show_bug.cgi?id=207277
3057
3058         Rubber-stamped by Aakash Jain.
3059
3060         * resultsdbpy/resultsdbpy/model/archive_context.py:
3061         (ArchiveContext):
3062         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
3063         (ArchiveContext.__init__): Add archiver member.
3064         (ArchiveContext.__enter__): archiver is a context manager.
3065         (ArchiveContext.__exit__): Ditto.
3066         (ArchiveContext.register): The archiver member owns saving an archive.
3067         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
3068         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
3069         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
3070         (Archiver): Base class for all Archiving systems.
3071         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
3072         (Archiver.archive_size): Given a file-like archive, calculate it's size.
3073         (Archiver.save):
3074         (Archiver.retrieve):
3075         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
3076         (CassandraArchiver):
3077         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
3078         (CassandraArchiver.__init__):
3079         (CassandraArchiver.__enter__):
3080         (CassandraArchiver.__exit__):
3081         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
3082         from ArchiveContext.
3083         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
3084         from ArchiveContext.
3085
3086 2020-02-09  Lauro Moura  <lmoura@igalia.com>
3087
3088         [GTK][WPE] Expose allowTopNavigationToDataURL
3089         https://bugs.webkit.org/show_bug.cgi?id=207384
3090
3091         Reviewed by Adrian Perez de Castro.
3092
3093         Updates with new "allow-top-navigation-to-data-urls" property.
3094
3095         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3096         (testWebViewAllowModalDialogs): This test requires this property to be
3097         set.
3098         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3099         (testWebKitSettings): Added tests for getter/setter.
3100
3101 2020-02-08  Sam Weinig  <weinig@apple.com>
3102
3103         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3104         https://bugs.webkit.org/show_bug.cgi?id=207436
3105
3106         Reviewed by Tim Horton.
3107
3108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3109         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
3110
3111 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
3112
3113         [WTF] Try using 75% load factor for HashTable
3114         https://bugs.webkit.org/show_bug.cgi?id=207183
3115
3116         Reviewed by Mark Lam.
3117
3118         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3119         (TestWebKitAPI::testInitialCapacity):
3120
3121 2020-02-08  Sam Weinig  <weinig@apple.com>
3122
3123         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3124         https://bugs.webkit.org/show_bug.cgi?id=207155
3125
3126         Reviewed by Tim Horton.
3127
3128         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3129         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3130         also has a default value in PlatformEnable.h
3131
3132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3133
3134 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3135
3136         Several iOS API tests that call -makeKeyWindow assert after r255907
3137         https://bugs.webkit.org/show_bug.cgi?id=207411
3138
3139         Reviewed by Tim Horton.
3140
3141         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
3142         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
3143         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
3144         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
3145
3146         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3147         (TestWebKitAPI::TEST):
3148         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
3149         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3150         (overrideBundleIdentifier):
3151         (setOverriddenApplicationKeyWindow):
3152
3153 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3154
3155         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
3156         https://bugs.webkit.org/show_bug.cgi?id=207405
3157
3158         Reviewed by Wenson Hsieh.
3159
3160         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3161
3162 2020-02-07  Alex Christensen  <achristensen@apple.com>
3163
3164         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
3165         https://bugs.webkit.org/show_bug.cgi?id=207409
3166         rdar://problem/59275641
3167
3168         Reviewed by Chris Dumez.
3169
3170         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3171         (TestWebKitAPI::TEST):
3172
3173 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
3174
3175         Unreviewed, rolling out r256051.
3176
3177         Broke internal builds.
3178
3179         Reverted changeset:
3180
3181         "Move trivial definitions from FeatureDefines.xcconfig to
3182         PlatformEnableCocoa.h"
3183         https://bugs.webkit.org/show_bug.cgi?id=207155
3184         https://trac.webkit.org/changeset/256051
3185
3186 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3187
3188         iPad testers failing to launch processes
3189         https://bugs.webkit.org/show_bug.cgi?id=207401
3190         <rdar://problem/58184777>
3191
3192         Unreviewed infrastructure fix.
3193
3194         This is a speculative fix because I've had problems reproducing this error.
3195         The only time I managed to reproduce the problem was immediately after killing the 
3196         SimulatorTrampoline and CoreSimulator.xpc processes.
3197
3198         * BuildSlaveSupport/kill-old-processes:
3199         (main): Only kill Simulator.app, not all associated simulator processes.
3200
3201 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
3202
3203         [WebAuthn] Report CTAP Client Pin Error to clients
3204         https://bugs.webkit.org/show_bug.cgi?id=205837
3205         <rdar://problem/58356872>
3206
3207         Reviewed by Brent Fulgham.
3208
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3211         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3212         (TestWebKitAPI::TEST):
3213         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3214         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
3215         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3216         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3217         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
3218         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
3219         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
3220         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
3221
3222 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3223
3224         run-safari Doesn't work with the latest Xcode version and iOS
3225         https://bugs.webkit.org/show_bug.cgi?id=207394
3226
3227         Reviewed by Ryosuke Niwa.
3228
3229         * Scripts/webkitdirs.pm:
3230         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
3231         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
3232
3233 2020-02-07  Daniel Bates  <dabates@apple.com>
3234
3235         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
3236         https://bugs.webkit.org/show_bug.cgi?id=207366
3237
3238         Reviewed by Brent Fulgham.
3239
3240         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
3241         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
3242         as the actual test instead of under a platform-specific directory even when the tests' behavior
3243         depends on the link-time version of WebKit.
3244
3245         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
3246         and toggling them in a test.
3247
3248         * DumpRenderTree/mac/DumpRenderTree.mm:
3249         (setDefaultsToConsistentValuesForTesting):
3250
3251 2020-02-03  Sam Weinig  <weinig@apple.com>
3252
3253         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
3254         https://bugs.webkit.org/show_bug.cgi?id=207155
3255
3256         Reviewed by Tim Horton.
3257
3258         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
3259         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
3260         also has a default value in PlatformEnable.h
3261
3262         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3263
3264 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
3265
3266         Update WebView category name to be more accurate
3267         https://bugs.webkit.org/show_bug.cgi?id=207334
3268         <rdar://problem/59224855>
3269
3270         Reviewed by Brent Fulgham.
3271
3272         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
3273         (TEST):
3274
3275 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
3276
3277         [ews] add commit-queue build step to close the bug
3278         https://bugs.webkit.org/show_bug.cgi?id=207387
3279
3280         Reviewed by Jonathan Bedard.
3281
3282         * BuildSlaveSupport/ews-build/steps.py:
3283         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
3284         (CloseBug): Build step to close bugzilla bug.
3285
3286 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
3287
3288         [ews] add commit-queue build step to clear flags on patch
3289         https://bugs.webkit.org/show_bug.cgi?id=206536
3290
3291         Reviewed by Jonathan Bedard.
3292
3293         * BuildSlaveSupport/ews-build/steps.py:
3294         (BugzillaMixin): Class for common bugzilla related methods.
3295         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
3296         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
3297         (ValidatePatch):
3298         (RemoveFlagsOnPatch): Class to remove flags on patch.
3299         (RemoveFlagsOnPatch.start):
3300         (ValidatePatch._addToLog): Moved.
3301         (ValidatePatch.fetch_data_from_url): Moved.
3302         (ValidatePatch.get_patch_json): Moved.
3303         (ValidatePatch.get_bug_json): Moved.
3304         (ValidatePatch.get_bug_id_from_patch): Moved.
3305         (ValidatePatch._is_patch_obsolete): Moved.
3306         (ValidatePatch._is_patch_review_denied): Moved.
3307         (ValidatePatch._is_patch_cq_plus): Moved.
3308         (ValidatePatch._is_bug_closed): Moved.
3309
3310 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
3311
3312         EWS should run resultsdbpy tests
3313         https://bugs.webkit.org/show_bug.cgi?id=201928
3314
3315         Reviewed by Aakash Jain.
3316
3317         * BuildSlaveSupport/ews-build/factories.py:
3318         (ServicesFactory.__init__): Add RunResultsdbpyTests.
3319         * BuildSlaveSupport/ews-build/factories_unittest.py:
3320         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
3321         * BuildSlaveSupport/ews-build/steps.py:
3322         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
3323         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
3324         * BuildSlaveSupport/ews-build/steps_unittest.py:
3325         (TestRunResultsdbpyTests):
3326         (TestRunResultsdbpyTests.setUp):
3327         (TestRunResultsdbpyTests.tearDown):
3328         (TestRunResultsdbpyTests.test_success):
3329         (TestRunResultsdbpyTests.test_failure):
3330
3331 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
3332
3333         Adding myself to contributors.json
3334         
3335         Unreviewed
3336
3337         * Scripts/webkitpy/common/config/contributors.json:
3338
3339 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
3340
3341         Adding myself to contributors.json
3342         
3343         Unreviewed
3344
3345         * Scripts/webkitpy/common/config/contributors.json:
3346
3347 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
3348
3349         [GTK][WPE] Add same-site cookie support
3350         https://bugs.webkit.org/show_bug.cgi?id=204137
3351
3352         Reviewed by Carlos Garcia Campos.
3353
3354         Update libsoup to 2.69.90 in JHBuild.
3355
3356         * gtk/jhbuild.modules:
3357         * wpe/jhbuild.modules:
3358
3359 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
3360
3361         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
3362         https://bugs.webkit.org/show_bug.cgi?id=207183
3363
3364         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3365         (TestWebKitAPI::testInitialCapacity):
3366
3367 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3368
3369         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
3370         https://bugs.webkit.org/show_bug.cgi?id=207350
3371         <rdar://problem/59239914>
3372
3373         Reviewed by Tim Horton.
3374
3375         Add a test to exercise the corner case in the SPI.
3376
3377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
3379
3380 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
3381
3382         Adopt new SOAuthorizationOption constants
3383         https://bugs.webkit.org/show_bug.cgi?id=207186
3384         <rdar://problem/48909336>
3385
3386         Reviewed by Brent Fulgham.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3389         (checkAuthorizationOptions):
3390
3391 2020-02-06  Brady Eidson  <beidson@apple.com>
3392
3393         Cleanup and promote WKContentWorld and its clients in WKWebView.
3394         https://bugs.webkit.org/show_bug.cgi?id=207351
3395
3396         Reviewed by Alex Christensen.
3397
3398         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3401         (TEST):
3402         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3403         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
3404
3405 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3406
3407         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
3408         https://bugs.webkit.org/show_bug.cgi?id=207250
3409
3410         Reviewed by Alex Christensen.
3411
3412         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
3413         reload. However, they don't work unless the main window is
3414         focused.
3415
3416         Ctrl-W should be processed differently. Ctrl-W should be handled
3417         without dispatching to WebKit, others should be handled only when
3418         WebKit didn't consume. So, this change split the accelerator table
3419         into two, one is for Ctrl-W, another is for other shortcut keys.
3420
3421         For Ctrl-W, key events are processed before dispatching to
3422         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
3423         dispatched to WebView. WebKit2 WebView bubbles up unhandled
3424         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
3425         in the main window's WndProc. However, it doesn't work for WebKit1
3426         because this change doesn't add the bubbling up code to WebKit1
3427         WebView.
3428
3429         For other shortcut keys, for example Ctrl-R, key events are
3430         dispatched to WebView without accelerator key translations. Then,
3431         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
3432         aren't consumed. didNotHandleKeyEvent posts the messasge to the
3433         main window. The message loop processed key events dispatched to
3434         the main window with another accelerator table. However, it
3435         doesn't work for WebKit1, because WebKit1 doesn't have a API
3436         equivalent to didNotHandleKeyEvent.
3437
3438         After switching the active window by pressing Alt-Tab and
3439         reactivating the main window, the main window got the focus. This
3440         was the reason shortcut keys worked only after reactivating the
3441         main window. But, this is not the desired behavior after this
3442         change because other shortcut keys don't work if the main window
3443         is focused. So. set the focus to the brower window when
3444         WM_ACTIVATE of the main window.
3445
3446         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
3447         effective only for keyboard numpad. Add VK_OEM_MINUS and
3448         VK_OEM_PLUS for them.
3449
3450         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
3451
3452         * MiniBrowser/win/MainWindow.cpp:
3453         (MainWindow::isInstance):
3454         (MainWindow::WndProc):
3455         * MiniBrowser/win/MainWindow.h:
3456         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
3457         IDR_ACCELERATORS_PRE for Ctrl-W.
3458         * MiniBrowser/win/MiniBrowserLibResource.h:
3459         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3460         (WebKitBrowserWindow::didNotHandleKeyEvent):
3461         * MiniBrowser/win/WinMain.cpp:
3462         (wWinMain):
3463
3464 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
3465
3466         results.webkitorg: Dead CI links
3467         https://bugs.webkit.org/show_bug.cgi?id=207340
3468
3469         Reviewed by Alexey Proskuryakov.
3470
3471         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
3472         (Configuration.prototype.toParams): Version name and version number often duplicate the
3473         same information, exception version number is often more specific than is useful.
3474
3475 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
3476
3477         Prevent navigating top level frames to Data URLs
3478         https://bugs.webkit.org/show_bug.cgi?id=206962
3479         <rdar://problem/56770676>
3480
3481         Reviewed by Youenn Fablet.
3482
3483         Revise test running code to allow data URL navigations by default, since they are so frequently
3484         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
3485         function.
3486
3487         * DumpRenderTree/TestOptions.cpp:
3488         (TestOptions::TestOptions):
3489         * DumpRenderTree/TestOptions.h:
3490         * DumpRenderTree/mac/DumpRenderTree.mm:
3491         (setWebPreferencesForTestOptions):
3492         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3493         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
3494         (StartDownloadWithDownloadAttribute): Ditto.
3495         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3496         (WebViewWillPerformClientRedirect): Ditto.
3497         (WebViewDidCancelClientRedirect): Ditto.
3498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3499         (NavigateToDataURLThenBack): Ditto.
3500         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
3501         * WebKitTestRunner/TestController.cpp:
3502         (WTR::TestController::resetPreferencesToConsistentValues):
3503         (WTR::updateTestOptionsFromTestHeader):
3504         * WebKitTestRunner/TestOptions.h:
3505         (WTR::TestOptions::hasSameInitializationOptions const):
3506         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3507         (WTR::initializeWebViewConfiguration):
3508         (WTR::TestController::platformCreateWebView):
3509
3510 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3511
3512         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
3513         https://bugs.webkit.org/show_bug.cgi?id=207272
3514         <rdar://problem/59190828>
3515
3516         Reviewed by Tim Horton.
3517
3518         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
3519         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
3520         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
3521
3522         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3523         (TestWebKitAPI::overrideBundleIdentifier):
3524         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3525         (setOverriddenApplicationKeyWindow):
3526         (applicationKeyWindowOverride):
3527         (-[TestWKWebViewHostWindow makeKeyWindow]):
3528         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3529         * TestWebKitAPI/ios/UIKitSPI.h:
3530
3531         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
3532         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
3533
3534 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
3535
3536         [PlayStation] Build a shared JavaScriptCore
3537         https://bugs.webkit.org/show_bug.cgi?id=198446
3538
3539         Reviewed by Fujii Hironori.
3540
3541         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
3542
3543         * TestWebKitAPI/PlatformPlayStation.cmake:
3544
3545 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
3546
3547         [WinCairo] Set up fonts for layout tests for test bot image
3548         https://bugs.webkit.org/show_bug.cgi?id=207223
3549
3550         Reviewed by Fujii Hironori.
3551
3552         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
3553           Implement activateFonts to load fonts for test
3554
3555 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
3556
3557         [PlayStation] Miscellaneous build fixes February 2020 edition
3558         https://bugs.webkit.org/show_bug.cgi?id=207312
3559
3560         Unreviewed build fix.
3561
3562         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
3563
3564 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
3565
3566         [WTF] Try using 75% load factor for HashTable
3567         https://bugs.webkit.org/show_bug.cgi?id=207183
3568
3569         Reviewed by Mark Lam.
3570
3571         Fix load-factor assumption in existing tests.
3572
3573         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3574         (TestWebKitAPI::testInitialCapacity):
3575
3576 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3577
3578         resulsdbpy: Fix unit tests
3579         https://bugs.webkit.org/show_bug.cgi?id=207304
3580
3581         Reviewed by Aakash Jain.
3582
3583         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
3584         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
3585         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
3586         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
3587         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
3588         (FailureContextTest.test_unexpected_failures): Ditto.
3589         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
3590         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
3591         of knowing how expensive the callback may be.
3592
3593 2020-02-05  Chris Dumez  <cdumez@apple.com>
3594
3595         Unreviewed, another build fix after r255846
3596
3597         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3598
3599 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3600
3601         Unreviewed infrastructure fix.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3604         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
3605
3606 2020-02-05  Chris Dumez  <cdumez@apple.com>
3607
3608         Unreviewed build fix after r255846.
3609
3610         * TestWebKitAPI/cocoa/HTTPServer.h:
3611
3612 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
3613
3614         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
3615         https://bugs.webkit.org/show_bug.cgi?id=207173
3616         <rdar://problem/55669065>
3617
3618         Reviewed by Brent Fulgham.
3619
3620         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3623         (-[TestWKWebView _setUpTestWindow:]):
3624         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
3625
3626 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3627
3628         results.webkit.org: Apply ttl to archive shards
3629         https://bugs.webkit.org/show_bug.cgi?id=207295
3630
3631         Rubber-stamped by Aakash Jain.
3632
3633         * resultsdbpy/resultsdbpy/model/archive_context.py:
3634         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
3635         (ArchiveContext.ArchiveChunks): Use new table.
3636         (ArchiveContext.register): Add ttl to archive shards.
3637
3638 2020-02-05  Alex Christensen  <achristensen@webkit.org>
3639
3640         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
3641         https://bugs.webkit.org/show_bug.cgi?id=207207
3642
3643         Reviewed by Chris Dumez.
3644
3645         HTTPServer now supports HTTPS. Tell your friends!
3646
3647