[WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients...
[WebKit-https.git] / Tools / ChangeLog
1 2020-06-19  Jiewen Tan  <jiewen_tan@apple.com>
2
3         [WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid
4         https://bugs.webkit.org/show_bug.cgi?id=213404
5         <rdar://problem/64543894>
6
7         Reviewed by Brent Fulgham.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
11         (TestWebKitAPI::TEST):
12         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-fake-pin-invalid-error-retry.html: Added.
13
14 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
15
16         Bring up watchOS/tvOS on build.webkit.org
17         https://bugs.webkit.org/show_bug.cgi?id=213402
18         <rdar://problem/64542588>
19
20         Reviewed by Aakash Jain.
21
22         * BuildSlaveSupport/build.webkit.org-config/config.json: Add AppleTV and watchOS builders.
23         * BuildSlaveSupport/build.webkit.org-config/factories.py:
24         (BuildFactory.__init__): Support AppleTV and watchOS.
25         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13.png: Added.
26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13@2x.png: Added.
27         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator.png: Added.
28         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator@2x.png: Added.
29         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6.png: Added.
30         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6@2x.png: Added.
31         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6.png: Added.
32         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Added.
33         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
34         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
35         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
36         * BuildSlaveSupport/build.webkit.org-config/steps.py:
37         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
38
39 2020-06-19  Saam Barati  <sbarati@apple.com>
40
41         Have a memory monitor thread in jsc shell when running tests using --memory-limited
42         https://bugs.webkit.org/show_bug.cgi?id=213389
43
44         Reviewed by Mark Lam.
45
46         * Scripts/run-jsc-stress-tests:
47         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
48         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
49
50 2020-06-19  Chris Fleizach  <cfleizach@apple.com>
51
52         AX: Make isolated tree enablement status dependent on client preference
53         https://bugs.webkit.org/show_bug.cgi?id=213355
54         <rdar://problem/64506577>
55
56         Reviewed by Zalan Bujtas.
57
58         * MiniBrowser/mac/AppDelegate.m:
59         (-[BrowserAppDelegate defaultConfiguration]):
60
61 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
62
63         Improve handling of trac downtime by commit-queue
64         https://bugs.webkit.org/show_bug.cgi?id=213377
65
66         Reviewed by Jonathan Bedard.
67
68         * BuildSlaveSupport/ews-build/steps.py: Load contributors.json from disk when loading from trac fails.
69         (ValidateCommiterAndReviewer.load_contributors_from_disk):
70         (ValidateCommiterAndReviewer.load_contributors_from_trac):
71         (ValidateCommiterAndReviewer.load_contributors):
72         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test
73
74 2020-06-19  Lauro Moura  <lmoura@igalia.com>
75
76         [WPE] Warn potential issues when creating WindowViewBackend
77         https://bugs.webkit.org/show_bug.cgi?id=213326
78
79         Reviewed by Philippe Normand.
80
81         Make it easier to debug eventual GL issues when starting up MiniBrowser in
82         windowed mode.
83
84         * wpe/backends/WindowViewBackend.cpp:
85         (WPEToolingBackends::WaylandEGLConnection::singleton):
86         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
87
88 2020-06-19  Lauro Moura  <lmoura@igalia.com>
89
90         [webkitpy][WPE] Default to headless if _display_server is xfvb
91         https://bugs.webkit.org/show_bug.cgi?id=213327
92
93         Reviewed by Philippe Normand.
94
95         Xvfb is used as the default display server for some scripts, and the
96         equivalent for WPE is the headless one.
97
98         WTR and the API tests already create only HeadlessViewBackends, but the
99         WebDriver tests create them through MiniBrowser, which requires the
100         '--headless' parameter.
101
102         * Scripts/run-webdriver-tests: Do not override _display_server
103         * Scripts/webkitpy/port/base.py:
104         (Port.__init__): Define _display_server for all ports to avoid
105         eventually needing to override it.
106         * Scripts/webkitpy/port/wpe.py:
107         (WPEPort.__init__): Default to 'headless' if _display_server is 'xvfb'
108         * Scripts/webkitpy/w3c/wpt_runner.py:
109         (main): Dot not override _display_server
110
111 2020-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         Add support for fetching registrable domains with resource load statistics
114         https://bugs.webkit.org/show_bug.cgi?id=213291
115
116         Reviewed by Adrian Perez de Castro.
117
118         Update GLib ITP unit test to check also fetch and remove.
119
120         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
121         (testWebsiteDataITP):
122
123 2020-06-19  Tomoki Imai  <Tomoki.Imai@sony.com>
124
125         Change my (Tomoki Imai's) status to committer
126
127         Unreviewed, just updating contributors.json for myself.
128
129         * Scripts/webkitpy/common/config/contributors.json:
130
131 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
132
133         Add SPI to preconnect to a server (Follow-up fix)
134         https://bugs.webkit.org/show_bug.cgi?id=213109
135         <rdar://problem/64184412>
136
137         Unreviewed build-fix.
138
139         * TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm: HTTPServer does not exist if HAVE(NETWORK_FRAMEWORK) is false.
140
141 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
142
143         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions (build-fix)
144         https://bugs.webkit.org/show_bug.cgi?id=213183
145         <rdar://problem/64273483>
146
147         Unreviewed build fix.
148
149         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
150         (webViewWithAutofocusedInput): bool may not be the same type as BOOL.
151
152 2020-06-18  Saam Barati  <sbarati@apple.com>
153
154         call skip when skipping JetStream2 wasm test
155         https://bugs.webkit.org/show_bug.cgi?id=213354
156
157         Reviewed by Yusuke Suzuki.
158
159         So we can see the logging that we're skipping.
160
161         * Scripts/run-jsc-stress-tests:
162
163 2020-06-18  Joonghun Park  <jh718.park@samsung.com>
164
165     Unreviewed. Remove the build warning below since r262971.
166     warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
167
168         * WebKitTestRunner/TestController.cpp:
169         (WTR::getAllStorageAccessEntriesCallback):
170
171 2020-06-18  Ross Kirsling  <ross.kirsling@sony.com>
172
173         [Intl] Enable RelativeTimeFormat and Locale by default
174         https://bugs.webkit.org/show_bug.cgi?id=213324
175
176         Reviewed by Yusuke Suzuki.
177
178         * Scripts/run-jsc-stress-tests:
179         Remove feature flags.
180
181 2020-06-18  Andy Estes  <aestes@apple.com>
182
183         Unreviewed build fix after r263194
184
185         * WebKitTestRunner/ios/TestControllerIOS.mm:
186         (WTR::TestController::platformResetStateToConsistentValues): Guarded code that mentions
187         UIContextMenuInteraction with USE(UICONTEXTMENU).
188
189 2020-06-18  Ryan Haddad  <ryanhaddad@apple.com>
190
191         Unreviewed infrastructure fix, temporarily remove ews116 due to hardware failure tracked with rdar://64424245
192
193         * BuildSlaveSupport/ews-build/config.json:
194
195 2020-06-18  Carlos Garcia Campos  <cgarcia@igalia.com>
196
197         [GTK][WPE] Add API to configure and handle service worker registrations to WebKitWebsiteDataManager
198         https://bugs.webkit.org/show_bug.cgi?id=213290
199
200         Reviewed by Michael Catanzaro.
201
202         Handle new website data in MiniBrowser and add a unit test.
203
204         * MiniBrowser/gtk/main.c:
205         (gotWebsiteDataCallback):
206         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
207         (serverCallback):
208         (testWebsiteDataConfiguration):
209         (testWebsiteDataEphemeral):
210         (testWebsiteDataITP):
211         (testWebsiteDataServiceWorkerRegistrations):
212         (beforeAll):
213         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
214         (Test::Test):
215
216 2020-06-17  Fujii Hironori  <Hironori.Fujii@sony.com>
217
218         RebaselineServer: "Rebaseline queue" button is placed behind the footer
219         https://bugs.webkit.org/show_bug.cgi?id=213258
220
221         Reviewed by Zalan Bujtas.
222
223         * Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html: Moved 'log' and 'queue' elements after 'footer' element.
224         * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
225         (#queue): Changed 'bottom' property from 3em to 4em.
226
227 2020-06-17  Wenson Hsieh  <wenson_hsieh@apple.com>
228
229         [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
230         https://bugs.webkit.org/show_bug.cgi?id=213320
231         <rdar://problem/63831962>
232
233         Reviewed by Tim Horton.
234
235         Add a new API test to verify that preventing the "keypress" event for shift+tab in an SPI-editable web view
236         causes us to avoid relinquishing focus.
237
238         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
239
240 2020-06-17  Andy Estes  <aestes@apple.com>
241
242         REGRESSION (r258092): fast/forms/ios/file-upload-panel.html fails when HAVE(UICONTEXTMENU_LOCATION)
243         https://bugs.webkit.org/show_bug.cgi?id=213314
244         <rdar://problem/60339129>
245
246         Reviewed by Maciej Stachowiak.
247
248         fast/forms/ios/file-upload-panel.html sets the shouldHandleRunOpenPanel and
249         shouldPresentPopovers test options to false so that WKTR will (a) not register a
250         runOpenPanel UI delegate callback, causing WebKit to create a WKFileUploadPanel instead, and
251         (b) swizzle two UIKit view controller presentation methods to prevent the document picker
252         menu from being presented. The test merely wants the WKFileUploadPanel instance to exist in
253         order to query its available actions, not for it to show UI.
254
255         In r258092, WKFileUploadPanel now sometimes uses a UIContextMenuInteraction instance to
256         present the document picker menu, but -[UIContextMenuInteraction _presentMenuAtLocation:]
257         fails due to WKTR's above-mentioned swizzling. When this failure occurs,
258         UIContextMenuInteraction calls -contextMenuInteraction:willEndForConfiguration:animator: on
259         its delegate (the WKFileUploadPanel), which dismisses the open panel before the test has had
260         a chance to query the available actions.
261
262         Fixed this by swizzling -[UIContextMenuInteraction _presentMenuAtLocation:] when the
263         shouldPresentPopovers test option is false.
264
265         * WebKitTestRunner/ios/TestControllerIOS.mm:
266         (overridePresentMenuOrPopoverOrViewController): Renamed from
267         overridePresentViewControllerOrPopover.
268         (WTR::TestController::platformResetStateToConsistentValues): Swizzled
269         -[UIContextMenuInteraction _presentMenuAtLocation:] with
270         overridePresentMenuOrPopoverOrViewController when the shouldPresentPopovers test option is
271         false.
272         (overridePresentViewControllerOrPopover): Renamed to
273         overridePresentMenuOrPopoverOrViewController.
274
275 2020-06-17  Sihui Liu  <sihui_liu@apple.com>
276
277         REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
278         https://bugs.webkit.org/show_bug.cgi?id=213311
279         <rdar://problem/64456413>
280
281         Reviewed by Wenson Hsieh.
282
283         TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long 
284         enough to make sure TextManipulationController gets notified about the insertion and starts observing.
285
286         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
287         (TestWebKitAPI::TEST):
288
289 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
290
291         Delete code for old ews bindings queue
292         https://bugs.webkit.org/show_bug.cgi?id=213315
293
294         Rubber-stamped by Alexey Proskuryakov.
295
296         * Scripts/webkitpy/common/config/ews.json:
297         * Scripts/webkitpy/common/config/ports.py:
298         (DeprecatedPort.run_bindings_tests_command): Deleted.
299         (WinPort.run_bindings_tests_command): Deleted.
300         * Scripts/webkitpy/common/config/ports_mock.py:
301         (MockPort.run_bindings_tests_command): Deleted.
302         * Scripts/webkitpy/common/net/generictestresults.py: Removed.
303         * Scripts/webkitpy/common/net/generictestresults_unittest.py: Removed.
304         * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Removed.
305         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
306         (PatchAnalysisTask._retry_bindings_tests): Deleted.
307         * Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
308         (MockBindingsEarlyWarningSystem): Deleted.
309         (MockBindingsEarlyWarningSystem.__init__): Deleted.
310         (MockBindingsEarlyWarningSystem.test_results): Deleted.
311         (BindingsEarlyWarningSystemTest): Deleted.
312         (BindingsEarlyWarningSystemTest._results_indicate_all_passed): Deleted.
313         (BindingsEarlyWarningSystemTest._create_task): Deleted.
314         (BindingsEarlyWarningSystemTest.test_success_case): Deleted.
315         (BindingsEarlyWarningSystemTest.test_test_failure): Deleted.
316         (BindingsEarlyWarningSystemTest.test_fix): Deleted.
317         (BindingsEarlyWarningSystemTest.test_ineffective_patch): Deleted.
318         (BindingsEarlyWarningSystemTest.test_partially_effective_patch): Deleted.
319         (BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Deleted.
320         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
321         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
322         (TestBindingsEWS): Deleted.
323         (AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Deleted.
324         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
325         * Scripts/webkitpy/tool/steps/runtests.py:
326         (RunTests._run_bindings_tests): Deleted.
327         * Scripts/webkitpy/tool/steps/steps_unittest.py:
328         (test_patch_relevant_bindings): Deleted.
329         (test_runtests_api): Deleted.
330
331 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
332
333         Delete code for old ews style queue
334         https://bugs.webkit.org/show_bug.cgi?id=213297
335
336         Rubber-stamped by Alexey Proskuryakov.
337
338         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Removed.
339         * Scripts/webkitpy/tool/commands/queues.py:
340         (StyleQueue): Deleted.
341         (StyleQueue.__init__): Deleted.
342         (StyleQueue.review_patch): Deleted.
343         (StyleQueue.run_command): Deleted.
344         (StyleQueue.expected_failures): Deleted.
345         (StyleQueue.refetch_patch): Deleted.
346         * Scripts/webkitpy/tool/commands/queues_unittest.py:
347         (TestReviewQueue): Deleted.
348
349 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
350
351         Delete code for old ews webkitpy queue
352         https://bugs.webkit.org/show_bug.cgi?id=213299
353
354         Reviewed by Jonathan Bedard.
355
356         * Scripts/webkitpy/common/config/ews.json:
357         * Scripts/webkitpy/common/net/generictestresults.py:
358         (WebkitpyTestResults): Deleted.
359         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
360         * Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Removed.
361         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
362         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
363         (TestWebkitpyEWS): Deleted.
364         (AbstractEarlyWarningSystemTest.test_failing_webkitpy_tests_message): Deleted.
365         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
366         * Scripts/webkitpy/tool/steps/runtests.py:
367         (RunTests._run_webkitpy_tests): Deleted.
368         * Scripts/webkitpy/tool/steps/steps_unittest.py:
369         (test_runtests_webkitpy): Deleted.
370         (test_patch_not_relevant_bindings): Deleted.
371         (test_runtests_api_debug): Deleted.
372
373 2020-06-17  Keith Miller  <keith_miller@apple.com>
374
375         WebKitTestRunner should not crash on alert with invalid utf16 strings
376         https://bugs.webkit.org/show_bug.cgi?id=213269
377
378         Reviewed by Simon Fraser.
379
380         * WebKitTestRunner/StringFunctions.h:
381         (WTR::toWTFString):
382
383 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
384
385         Delete old ews client side code - part 2
386         https://bugs.webkit.org/show_bug.cgi?id=213262
387
388         Reviewed by Alexey Proskuryakov.
389
390         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
391         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
392         (PatchAnalysisTaskDelegate.command_passed): Deleted.
393         (PatchAnalysisTaskDelegate.command_failed): Deleted.
394         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
395         (AbstractEarlyWarningSystem.command_passed): Deleted.
396         (AbstractEarlyWarningSystem.command_failed): Deleted.
397         * Scripts/webkitpy/tool/commands/perfalizer.py:
398         (PerfalizerTask.command_passed): Deleted.
399         (PerfalizerTask.command_failed): Deleted.
400         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
401         * Scripts/webkitpy/tool/commands/queues.py:
402         (AbstractPatchQueue._next_patch): Deleted.
403         (AbstractPatchQueue._did_error): Deleted.
404         (AbstractPatchQueue._did_skip): Deleted.
405         (AbstractPatchQueue._unlock_patch): Deleted.
406         (StyleQueue.command_passed): Deleted.
407         (StyleQueue.command_failed): Deleted.
408
409 2020-06-17  Paulo Matos  <pmatos@igalia.com>
410
411         Add new Igalia EWS workers for ARM/MIPS
412         https://bugs.webkit.org/show_bug.cgi?id=212803
413
414         Reviewed by Aakash Jain.
415
416         * BuildSlaveSupport/ews-build/config.json:
417
418 2020-06-16  Mark Lam  <mark.lam@apple.com>
419
420         TestWebKitAPI.WebCore.WildcardStringMatching needs to initialize Options before accessing them.
421         https://bugs.webkit.org/show_bug.cgi?id=213270
422         <rdar://problem/64427499>
423
424         Reviewed by Yusuke Suzuki.
425
426         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
427         (TestWebKitAPI::TEST):
428
429 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
430
431         Text manipulation should not re-extract elements whose children have been manipulated
432         https://bugs.webkit.org/show_bug.cgi?id=213276
433         <rdar://problem/64193446>
434
435         Reviewed by Tim Horton.
436
437         Add a new API test where we start and complete text manipulation, and then hide and show the manipulated
438         element. This test verifies that the new item callbacks are *not* called after element is shown again.
439
440         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
441         (TestWebKitAPI::TEST):
442
443 2020-06-16  Saam Barati  <sbarati@apple.com>
444
445         Fix two typos "signifcant" and "signficance". Should be "significant" and "significance"
446
447         * Scripts/compare-results:
448         (displayStr):
449         (computeMultipleHypothesesSignificance):
450         (dumpBreakdowns):
451         (writeCSV):
452         (computeMultipleHypothesesSignficance): Deleted.
453
454 2020-06-16  Andres Gonzalez  <andresg_22@apple.com>
455
456         Fix for accessibility/textarea-selected-text-range.html in isolated tree mode.
457         https://bugs.webkit.org/show_bug.cgi?id=213257
458
459         Reviewed by Chris Fleizach.
460
461         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
462         (WTR::setAttributeValue):
463         (WTR::AccessibilityUIElement::selectedTextRange): Dispatch call into
464         WebAccessibilityWrapper onto AX secondary thread to simulate isolated
465         tree mode.
466
467 2020-06-16  Saam Barati  <sbarati@apple.com>
468
469         Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
470         https://bugs.webkit.org/show_bug.cgi?id=213219
471
472         Reviewed by Mark Lam.
473
474         My previous patch here used Bonferroni to do multiple hypotheses correction.
475         Bonferroni does a good job at reducing false positive rate (type I error,
476         saying something is significant when it's not, e.g, rejecting the null
477         hypothesis when we shouldn't), but at the expense of also having a high
478         false negative rate (type II error, saying something is not significant when
479         it is, e.g, not rejecting the null hypothesis when we should).
480         
481         After doing a bit more reading, it seems like using a technique called False
482         Discovery Rate (FDR) is better. It still does a good job at controlling type
483         I error rate, but without sacrificing a high type II error rate. FDR is based
484         on a technique for "estimating the proportion of wrongly rejected null hypotheses" [2].
485         
486         This patch uses Benjamini and Hochberg estimation of FDR, which relies
487         on hypotheses being independent. We know subtests in a benchmark aren't
488         fully independent variables, but it's a good enough approximation.
489         
490         You can read more about FDR:
491         1. https://www.stat.berkeley.edu/~mgoldman/Section0402.pdf
492         2. https://besjournals.onlinelibrary.wiley.com/doi/10.1111/j.2041-210X.2010.00061.x
493         3. https://en.wikipedia.org/wiki/False_discovery_rate
494
495         * Scripts/compare-results:
496         (displayStr):
497         (computeMultipleHypothesesSignficance):
498         (dumpBreakdowns):
499         (writeCSV):
500
501 2020-06-16  David Kilzer  <ddkilzer@apple.com>
502
503         REGRESSION (r262994): Web Inspector is killed when context-clicking anywhere
504         <https://webkit.org/b/213224>
505         <rdar://problem/64383320>
506
507         Reviewed by Darin Adler.
508
509         * TestWebKitAPI/CMakeLists.txt:
510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
511         - Add ContextMenuAction.cpp to build systems.
512         * TestWebKitAPI/Tests/WebCore/ContextMenuAction.cpp: Add.
513         (TestWebKitAPI::TEST):
514         - Add TestWebKitAPI.WebCore.ContextMenuAction_IsValidEnum.
515
516 2020-06-16  Fujii Hironori  <Hironori.Fujii@sony.com>
517
518         [Win] Mouse dragging tests are failing because WebKitTestRunner dispatches WM_MOUSELEAVE to the hidden WebView
519         https://bugs.webkit.org/show_bug.cgi?id=213239
520
521         Reviewed by Don Olmstead.
522
523         There are two problems:
524         1. Windows EventSenderProxy::mouseMoveTo doesn't set WPARAM of WM_MOUSEMOVE
525         2. Unexpected WM_MOUSELEAVE discontinues the mouse dragging events
526
527         WPARAM of WM_MOUSEMOVE should represent pressed mouse buttons while dragging.
528
529         WM_MOUSELEAVE is unexpectedly dispatched because the mouse cursor
530         is always out of the hidden WebView. The unexpected WM_MOUSELEAVE
531         discontinues dragging events. WM_MOUSELEAVE shouldn't be
532         dispatched in WebKitTestRunner. Ignore it.
533
534         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
535         (WTR::EventSenderProxy::mouseDown):
536         (WTR::EventSenderProxy::mouseUp):
537         (WTR::EventSenderProxy::mouseMoveTo): Set MK_LBUTTON to WPARAM of
538         WM_MOUSEMOVE while dragging.
539         * WebKitTestRunner/win/TestControllerWin.cpp:
540         (WTR::runRunLoopUntil): Ignore WM_MOUSELEAVE.
541
542 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
543
544         Text manipulation should handle nested item boundary elements
545         https://bugs.webkit.org/show_bug.cgi?id=213251
546         <rdar://problem/63371514>
547
548         Reviewed by Sihui Liu.
549
550         Add a new API test to exercise this scenario.
551
552         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
553
554 2020-06-16  Charlie Turner  <cturner@igalia.com>
555
556         [GTK] Disable video autoplay
557         https://bugs.webkit.org/show_bug.cgi?id=184845
558
559         Reviewed by Carlos Garcia Campos.
560
561         Update the various callsites for constructing a view to take into
562         account the default policies. I chose the default as autoplay
563         allow without sound, which is in keeping with WebCore's choice.
564
565         * MiniBrowser/gtk/BrowserWindow.c:
566         (webViewDecidePolicy):
567         (newTabCallback):
568         (openPrivateWindow):
569         (browser_window_get_or_create_web_view_for_automation):
570         (browser_window_create_web_view_in_new_tab_for_automation):
571         * MiniBrowser/gtk/main.c:
572         (createBrowserTab):
573         (main):
574         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Add
575         autoplay policy tests, and use modern class initializers.
576         (testAutoplayPolicy):
577         (beforeAll):
578
579 2020-06-16  Philippe Normand  <pnormand@igalia.com>
580
581         [Flatpak SDK] Subversion perl bindings unusable
582         https://bugs.webkit.org/show_bug.cgi?id=213241
583
584         Reviewed by Sergio Villar Senin.
585
586         * buildstream/elements/sdk/subversion.bst: The svn swig perl library wasn't correctly
587         installed, leading to undefined symbols when importing it from the bindings. A new
588         integration command now tests this.
589
590 2020-06-16  Philippe Normand  <pnormand@igalia.com>
591
592         [Flatpak SDK] Update to Qt 5.15
593         https://bugs.webkit.org/show_bug.cgi?id=213192
594
595         Reviewed by Sergio Villar Senin.
596
597         The new patch comes from the upstream KDE SDK: https://github.com/KDE/flatpak-kde-runtime/tree/qt5.15lts/patch
598         
599         * buildstream/elements/qt5/qtbase.bst:
600         * buildstream/elements/qt5/qtdeclarative.bst:
601         * buildstream/elements/qt5/qtquickcontrols.bst:
602         * buildstream/elements/qt5/qtquickcontrols2.bst:
603         * buildstream/elements/qt5/qtwayland.bst:
604         * buildstream/elements/qt5/qtx11extras.bst:
605         * buildstream/patches/qtbase-make-sure-to-correctly-construct-base-platform-theme.patch: Added.
606         * buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Removed.
607         * buildstream/project.conf:
608
609 2020-06-16  Carlos Garcia Campos  <cgarcia@igalia.com>
610
611         [GTK][WPE] Add API to configure and enable resource load statistics
612         https://bugs.webkit.org/show_bug.cgi?id=177943
613
614         Reviewed by Michael Catanzaro.
615
616         Add --enable-itp command line version to MiniBrowser and unit tests to check the new API.
617
618         * MiniBrowser/gtk/main.c:
619         (gotWebsiteDataCallback):
620         (activate):
621         * MiniBrowser/wpe/main.cpp:
622         (main):
623         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
624         (serverCallback):
625         (testWebsiteDataConfiguration):
626         (testWebsiteDataEphemeral):
627         (testWebsiteDataITP):
628         (beforeAll):
629         * TestWebKitAPI/glib/TestExpectations.json:
630         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
631         (Test::Test):
632         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
633         (directoryChangedCallback):
634         (WebViewTest::waitUntilFileChanged):
635         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
636
637 2020-06-16  Philippe Normand  <pnormand@igalia.com>
638
639         REGRESSION(r263029): [Flatpak SDK] Broke initial SDK installation
640
641         Rubber-stamped by Žan Doberšek.
642
643         * flatpak/flatpakutils.py:
644         (FlatpakObject.version): Gracefully return an empty version when the flatpak info command
645         fails. This usually means the app has not been installed yet.
646
647 2020-06-15  Megan Gardner  <megan_gardner@apple.com>
648
649         Text form controls can scroll by 1px when value is the same length as size. No scrolling should happen.
650         https://bugs.webkit.org/show_bug.cgi?id=212856
651         <rdar://problem/63541707>
652
653         Reviewed by Zalan Bujtas.
654
655         Rebased to reflect new sizes.
656
657         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
658         (TEST):
659         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
660         (TestWebKitAPI::TEST):
661
662 2020-06-15  Jonathan Bedard  <jbedard@apple.com>
663
664         Follow-up fix: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
665         https://bugs.webkit.org/show_bug.cgi?id=213144
666         <rdar://problem/64316743>
667
668         Unreviewed build fix.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Guard didFinishNavigation declaration with HAVE(NETWORK_FRAMEWORK).
671
672 2020-06-15  Alex Christensen  <achristensen@webkit.org>
673
674         Provide alternatively-named SPI for user style sheets and scripts
675         https://bugs.webkit.org/show_bug.cgi?id=213206
676
677         Reviewed by Brady Eidson.
678
679         * DumpRenderTree/mac/DumpRenderTree.mm:
680         (fontAllowList):
681         (createWebViewAndOffscreenWindow):
682         (resetWebViewToConsistentStateBeforeTesting):
683         (fontWhitelist): Deleted.
684         * DumpRenderTree/mac/TestRunnerMac.mm:
685         (TestRunner::addOriginAccessWhitelistEntry):
686         (TestRunner::removeOriginAccessWhitelistEntry):
687         (TestRunner::addUserScript):
688         (TestRunner::addUserStyleSheet):
689         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
690         (TEST):
691         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
692         (TEST):
693         * WebKitTestRunner/mac/TestControllerMac.mm:
694         (WTR::generateFontAllowList):
695         (WTR::TestController::platformInitializeContext):
696         (WTR::generateWhitelist): Deleted.
697
698 2020-06-15  Alex Christensen  <achristensen@webkit.org>
699
700         Add SPI to preconnect to a server
701         https://bugs.webkit.org/show_bug.cgi?id=213109
702         <rdar://problem/64184412>
703
704         Reviewed by Geoff Garen.
705
706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
707
708 2020-06-15  Keith Miller  <keith_miller@apple.com>
709
710         Signal handlers should have a two phase installation.
711         https://bugs.webkit.org/show_bug.cgi?id=213160
712
713         Reviewed by Mark Lam.
714
715         * TestWebKitAPI/Tests/WTF/Signals.cpp:
716         (TEST):
717
718 2020-06-15  Sihui Liu  <sihui_liu@apple.com>
719
720         Text manipulation does not observe newly displayed element inside previously observed content
721         https://bugs.webkit.org/show_bug.cgi?id=213156
722
723         Reviewed by Darin Adler.
724
725         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
726         (TestWebKitAPI::TEST):
727
728 2020-06-15  Philippe Normand  <pnormand@igalia.com>
729
730         [Flatpak SDK] Bump Subversion and enable Perl bindings
731         https://bugs.webkit.org/show_bug.cgi?id=213189
732
733         Reviewed by Žan Doberšek.
734
735         * buildstream/elements/sdk-build-depends/swig.bst: Added.
736         * buildstream/elements/sdk/subversion.bst: Enable Perl bindings so that git svn can be used within the sandbox.
737
738 2020-06-15  Philippe Normand  <pnormand@igalia.com>
739
740         [Flatpak SDK] flatpak update still not displayed
741         https://bugs.webkit.org/show_bug.cgi?id=213180
742
743         Reviewed by Žan Doberšek.
744
745         Added a new --version option to the script. We no longer gather the flatpak update command
746         output to know if something was updated or not. Instead we get the version of the SDK prior
747         to the update operation and compare that with the version after the update.
748
749         * flatpak/flatpakutils.py:
750         (FlatpakObject.version):
751         (WebkitFlatpak.load_from_args):
752         (WebkitFlatpak.main):
753
754 2020-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         [GTK][WPE] Add API to expose UIClient::requestStorageAccessConfirm
757         https://bugs.webkit.org/show_bug.cgi?id=210422
758
759         Reviewed by Michael Catanzaro.
760
761         Handle WebKitWebsiteDataAccessPermissionRequest in MiniBrowser.
762
763         * MiniBrowser/gtk/BrowserTab.c:
764         (decidePermissionRequest):
765
766 2020-06-15  Philippe Normand  <pnormand@igalia.com>
767
768         [Flatpak SDK] Add libavif
769         https://bugs.webkit.org/show_bug.cgi?id=212964
770         <rdar://problem/64291035>
771
772         Reviewed by Žan Doberšek.
773
774         Because of the ABI bump of dav1d, which ffmpeg depends on, ffmpeg needs to be rebuilt. So
775         this is a good opportunity to include it in the SDK and not rely on the ffmpeg-full
776         extension anymore, because it doesn't provide debug symbols.
777
778         * buildstream/elements/flatpak/platform.bst:
779         * buildstream/elements/flatpak/sdk.bst:
780         * buildstream/elements/freedesktop-sdk.bst:
781         * buildstream/elements/sdk-platform.bst:
782         * buildstream/elements/sdk/ffmpeg.bst: Added.
783         * buildstream/elements/sdk/gst-libav.bst:
784         * buildstream/elements/sdk/libavif.bst: Added.
785         * buildstream/elements/sdk/ruby-highline.bst: Remove the spec source, un-needed.
786         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
787         * buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Removed.
788         * buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Removed.
789         * buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Removed.
790         * buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Removed.
791         * buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Removed.
792         * buildstream/project.conf:
793         * flatpak/flatpakutils.py:
794         (WebkitFlatpak._get_packages):
795
796 2020-06-15  Philippe Normand  <pnormand@igalia.com>
797
798         [Flatpak SDK] Remove webkit-build-directory dependency from flatpakutils
799         https://bugs.webkit.org/show_bug.cgi?id=213179
800
801         Reviewed by Žan Doberšek.
802
803         This makes webkit-flatpak usable without installing additional perl modules (version) on the host OS.
804
805         * flatpak/flatpakutils.py:
806         (WebkitFlatpak.load_from_args): Make --release and --debug mutually exclusive, and default to Release builds.
807         (WebkitFlatpak.__init__):
808         (WebkitFlatpak.clean_args): No need to pull in webkitpy which pulls webkitdirs.pm only to
809         determine the default configuration. Assume we use Release by default.
810
811 2020-06-15  Paulo Matos  <pmatos@igalia.com>
812
813         Properly propagate TZ to the remote test devices
814         https://bugs.webkit.org/show_bug.cgi?id=212816
815
816         Reviewed by Philippe Normand.
817
818         * Scripts/run-jsc-stress-tests:
819
820 2020-06-14  Wenson Hsieh  <wenson_hsieh@apple.com>
821
822         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
823         https://bugs.webkit.org/show_bug.cgi?id=213183
824         <rdar://problem/64273483>
825
826         Reviewed by Tim Horton.
827
828         On recent versions of the iOS SDK, iOS simulators that are not shown on-screen are treated as if the hardware
829         keyboard is not available (that is, `+[UIIKeyboard isInHardwareKeyboardMode]` returns `NO`). When running API
830         tests while `Simulator.app` is already launched, an iOS simulator is presented on-screen, whereas the simulator
831         is not visible when running API tests without launching `Simulator.app` beforehand.
832
833         This discrepancy causes two iOS API tests to fail (i.e. `CaretSelectionRectAfterRestoringFirstResponder` and
834         `RangedSelectionRectAfterRestoringFirstResponder`), due to the fact that `-[WKWebView becomeFirstResponder]` no
835         longer causes an input session to begin.
836
837         Interestingly, these tests already attempt to circumvent this by using `webViewWithAutofocusedInput()`, which
838         creates and loads a `WKWebView` with a single autofocusing input element, with a `_WKInputDelegate` that
839         unconditionally allows input sessions to begin. However, this doesn't work as intended in these tests, because
840         nothing keeps the delegate (a `TestInputDelegate`) alive past the scope of the call to
841         `webViewWithAutofocusedInput()`. Since `[WKWebView _inputDelegate]` is a weak property, the input delegate
842         simply disappears after we finish waiting for the load to finish (and the autofocused input element begins its
843         input session). This causes us to erroneously fall back to default behavior (i.e.
844         `_WKFocusStartsInputSessionPolicyAuto`) for subsequent calls to show the keyboard for the focused element, as is
845         the case when these two API tests call `-becomeFirstResponder`. The end result is that the keyboard doesn't
846         appear and text selection views are not created and laid out, but only when API tests are run without having
847         launched the Simulator app beforehand.
848
849         To fix this, refactor `webViewWithAutofocusedInput()` into `webViewAndInputDelegateWithAutofocusedInput()`,
850         which returns both the new `WKWebView` as well as the `TestInputDelegate` of the web view. The call site is then
851         responsible for keeping the input delegate around for as long as it needs.
852
853         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
854         (webViewWithAutofocusedInput):
855
856         Drive-by fix: fix a potential stack smasher by using an Objective-C block when setting the input delegate's
857         policy handler, and by using `__block` for the `doneWaiting` boolean flag. This is now a problem becuase this
858         block may be invoked multiple times.
859
860         (webViewAndInputDelegateWithAutofocusedInput):
861
862 2020-06-13  Saam Barati  <sbarati@apple.com>
863
864         compare-results should have an option to print a breakdown and to save the breakdown as csv file
865         https://bugs.webkit.org/show_bug.cgi?id=213140
866
867         Reviewed by Filip Pizlo.
868
869         In this patch, compare-results has a new --breakdown feature which will
870         break down the results for -a and -b per subtest. It will also show you
871         p values with a significance threshold determined using the Bonferroni
872         correction for testing multiple hypotheses:
873         https://en.wikipedia.org/wiki/Bonferroni_correction
874         
875         And there is also now a --csv option to generate a csv file containing
876         the same per subtest breakdown.
877         
878         --breakdown will print out results like:
879         
880         ------------------------------------------------------------------------------------------------------------
881         |               subtest                |     ms       |     ms       |  b / a   | pValue, alpha = 0.003125 |
882         ------------------------------------------------------------------------------------------------------------
883         | Elm-TodoMVC                          |616.625000    |583.625000    |0.946483  | 0.065002                 |
884         | VueJS-TodoMVC                        |89.425000     |83.225000     |0.930668  | 0.039102                 |
885         | EmberJS-TodoMVC                      |695.875000    |664.000000    |0.954194  | 0.088901                 |
886         | Flight-TodoMVC                       |263.600000    |257.600000    |0.977238  | 0.249259                 |
887         | BackboneJS-TodoMVC                   |213.025000    |201.550000    |0.946133  | 0.000636 (significant)   |
888         | Preact-TodoMVC                       |48.800000     |47.550000     |0.974385  | 0.502768                 |
889         | AngularJS-TodoMVC                    |745.300000    |704.275000    |0.944955  | 0.011779                 |
890         | Inferno-TodoMVC                      |607.900000    |354.800000    |0.583649  | 0.000000 (significant)   |
891         | Vanilla-ES2015-TodoMVC               |214.950000    |200.575000    |0.933124  | 0.005018                 |
892         | Angular2-TypeScript-TodoMVC          |191.575000    |187.025000    |0.976250  | 0.542229                 |
893         | VanillaJS-TodoMVC                    |162.075000    |160.375000    |0.989511  | 0.747186                 |
894         | jQuery-TodoMVC                       |855.275000    |833.825000    |0.974920  | 0.103439                 |
895         | EmberJS-Debug-TodoMVC                |2056.250000   |1952.050000   |0.949325  | 0.000003 (significant)   |
896         | React-TodoMVC                        |475.225000    |428.950000    |0.902625  | 0.007566                 |
897         | React-Redux-TodoMVC                  |791.100000    |736.675000    |0.931203  | 0.066091                 |
898         | Vanilla-ES2015-Babel-Webpack-TodoMVC |208.050000    |202.000000    |0.970920  | 0.152470                 |
899         ------------------------------------------------------------------------------------------------------------
900
901         * Scripts/compare-results:
902         (readJSONFile):
903         (speedometer2Breakdown):
904         (jetStream2Breakdown):
905         (motionMarkBreakdown):
906         (plt5Breakdown):
907         (displayStr):
908         (dumpBreakdowns):
909         (writeCSV):
910         (detectMotionMark1_1):
911         (detectMotionMark1_1_1):
912         (motionMarkResults):
913         (detectBenchmark):
914         (getOptions):
915         (main):
916         (motionMark1_1Results): Deleted.
917
918 2020-06-13  Sam Weinig  <weinig@apple.com>
919
920         Extended Color: Experiment with strongly typed ColorComponents
921         https://bugs.webkit.org/show_bug.cgi?id=212396
922
923         Reviewed by Darin Adler.
924
925         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
926         (TestWebKitAPI::TEST):
927         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
928         (TestWebKitAPI::TEST):
929         Update for changed names (e.g. toSRGBAComponentsLossy() -> toSRGBALossy())
930         and use of explicit types.
931
932 2020-06-13  Diego Pino Garcia  <dpino@igalia.com>
933
934         Unreviewed, fix configuration setting of WPE Debug (Tests JS) bot
935         https://bugs.webkit.org/show_bug.cgi?id=213164
936
937         The bot was meant to run as Debug.
938
939         * BuildSlaveSupport/build.webkit.org-config/config.json:
940
941 2020-06-12  Keith Miller  <keith_miller@apple.com>
942
943         Tests expecting a crash should use a signal handler in the JSC CLI process
944         https://bugs.webkit.org/show_bug.cgi?id=212479
945
946         Reviewed by Yusuke Suzuki.
947
948         Crashing tests should now exit with status zero.
949
950         * Scripts/run-jsc-stress-tests:
951         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
952         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
953         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
954
955 2020-06-12  Alex Christensen  <achristensen@webkit.org>
956
957         Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
958         https://bugs.webkit.org/show_bug.cgi?id=213144
959
960         Reviewed by Geofferey Garen.
961
962         Most changes are straightforward moving to HTTPServer, which is more tolerant of different numbers of connections except these two:
963
964         The ResourceLoadDelegate.Challenge API test was checking the output of _WKResourceLoadDelegate.didReceiveChallenge
965         by using a server trust challenge.  Now that preconnecting happens, the server trust evaluation would happen with a
966         PreconnectTask, not the main resource load.  The WKNavigationDelegate still gets the challenge and there is no problem
967         here, but in order to continue to test _WKResourceLoadDelegate.didReceiveChallenge I use a basic authentication challenge
968         instead of a server trust evaluation.
969
970         The WebKit.FastServerTrust API test now has two failed attempts (one from the preconnect attempt, one from the main resource load attempt),
971         but only when _strictTrustEvaluate is not available.
972
973         * TestWebKitAPI/TCPServer.cpp:
974         (TestWebKitAPI::TCPServer::TCPServer):
975         * TestWebKitAPI/TCPServer.h:
976         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
977         (TEST):
978         (TestWebKitAPI::TEST):
979         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
980         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
981         * TestWebKitAPI/cocoa/HTTPServer.h:
982         * TestWebKitAPI/cocoa/HTTPServer.mm:
983         (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
984
985 2020-06-12  Diego Pino Garcia  <dpino@igalia.com>
986
987         [buildbot] [GTK][WPE] Move WebDriver test to own bot
988         https://bugs.webkit.org/show_bug.cgi?id=212527
989
990         Reviewed by Carlos Alberto Lopez Perez.
991
992         Move 'webdriver-test' step from GTK Release and GTK Debug test bots
993         to separated bots.
994
995         For bots that require a Wayland display (WPE and GTK Wayland),
996         'webdriver-test' step is run on the corresponding general test bot,
997         since it's not possible at the moment to run tests that require a 
998         Wayland display in a bot set as a container.
999
1000         * BuildSlaveSupport/build.webkit.org-config/config.json:
1001         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1002         (TestFactory.__init__):
1003         (TestWebDriverFactory):
1004         (TestWebDriverFactory.__init__):
1005         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1006
1007 2020-06-12  Takashi Komori  <Takashi.Komori@sony.com>
1008
1009         [Curl] Implement functions to use ResourceLoadStatistics.
1010         https://bugs.webkit.org/show_bug.cgi?id=207692
1011
1012         Reviewed by Don Olmstead.
1013
1014         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
1015
1016         Tests: http/tests/resourceLoadStatistics/
1017
1018         * WebKitTestRunner/TestController.cpp:
1019         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
1020         (WTR::getAllStorageAccessEntriesCallback):
1021         (WTR::TestController::getAllStorageAccessEntries):
1022
1023 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
1024
1025         Support building test runners for watchOS and tvOS
1026         https://bugs.webkit.org/show_bug.cgi?id=213128
1027         <rdar://problem/64298006>
1028
1029         Reviewed by Tim Horton.
1030
1031         * DumpRenderTree/mac/Configurations/Base.xcconfig: Link against framework stubs.
1032         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Apply iOS rules to all embedded sdks.
1033         * WebKitTestRunner/Configurations/Base.xcconfig: Link against framework stubs.
1034         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Apply iOS rules to all embedded sdks.
1035         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Use watchOS entitlements for tvOS.
1036
1037 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
1038
1039         TestWebKitAPI: Build for watchOS and tvOS
1040         https://bugs.webkit.org/show_bug.cgi?id=213127
1041         <rdar://problem/64297979>
1042
1043         Reviewed by Tim Horton.
1044
1045         * TestWebKitAPI/Configurations/Base.xcconfig: Link against framework stubs.
1046         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Apply iOS rules to all embedded sdks.
1047         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Ditto.
1048         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Link against framework stubs.
1049         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Apply iOS rules to all embedded sdks.
1050         * TestWebKitAPI/config.h: WatchOS uses SSL.
1051
1052 2020-06-12  Commit Queue  <commit-queue@webkit.org>
1053
1054         Unreviewed, reverting r262942.
1055         https://bugs.webkit.org/show_bug.cgi?id=213132
1056
1057         Broke gst-libav due to dav1d ABI bump
1058
1059         Reverted changeset:
1060
1061         "[Flatpak SDK] Add libavif"
1062         https://bugs.webkit.org/show_bug.cgi?id=212964
1063         https://trac.webkit.org/changeset/262942
1064
1065 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1066
1067         Unreviewed. Fix GTK WebDriver tests after r262938
1068
1069         Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.
1070
1071         * MiniBrowser/gtk/BrowserWindow.c:
1072         (browserWindowCreateBackForwardMenu):
1073
1074 2020-06-12  Philippe Normand  <pnormand@igalia.com>
1075
1076         [Flatpak SDK] Update GTK4 to 3.98.5
1077
1078         Rubber-stamped by Carlos Alberto Lopez Perez.
1079
1080         * buildstream/elements/sdk/gtk.bst:
1081
1082 2020-06-12  Philippe Normand  <pnormand@igalia.com>
1083
1084         [Flatpak SDK] Add libavif
1085         https://bugs.webkit.org/show_bug.cgi?id=212964
1086
1087         Reviewed by Carlos Alberto Lopez Perez.
1088
1089         * buildstream/elements/freedesktop-sdk.bst:
1090         * buildstream/elements/sdk-platform.bst:
1091         * buildstream/elements/sdk/libavif.bst: Added.
1092         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
1093
1094 2020-06-12  Philippe Normand  <pnormand@igalia.com>
1095
1096         [Flatpak SDK] Add libkate
1097         https://bugs.webkit.org/show_bug.cgi?id=212865
1098
1099         Reviewed by Carlos Alberto Lopez Perez.
1100
1101         The GStreamer kate decoder is required for some media/track tests being re-enabled in bug
1102         120665.
1103
1104         * buildstream/elements/sdk-platform.bst:
1105         * buildstream/elements/sdk/gst-plugins-bad.bst:
1106         * buildstream/elements/sdk/libkate.bst: Added.
1107
1108 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1109
1110         [GTK4] Get MiniBrowser ready for GTK4
1111         https://bugs.webkit.org/show_bug.cgi?id=210276
1112
1113         Reviewed by Adrian Perez de Castro.
1114
1115         Port MiniBrowser to GTK4. BrowserSearchBar has been renamed as BrowserSearchBox, because in GTK GtkSearchBar is
1116         final class, so we derive from GtkBox and to be used as contents of a GtkSearchBar.
1117
1118         * MiniBrowser/gtk/BrowserCellRendererVariant.c:
1119         (browserCellRendererVariantCellRendererSnapshot):
1120         (browser_cell_renderer_variant_class_init):
1121         * MiniBrowser/gtk/BrowserCellRendererVariant.h:
1122         * MiniBrowser/gtk/BrowserSearchBar.c: Removed.
1123         * MiniBrowser/gtk/BrowserSearchBox.c: Added.
1124         (setFailedStyleForEntry):
1125         (doSearch):
1126         (searchNext):
1127         (searchPrevious):
1128         (searchEntryMenuIconPressedCallback):
1129         (searchEntryClearIconReleasedCallback):
1130         (searchEntryChangedCallback):
1131         (searchEntryActivatedCallback):
1132         (searchPreviousButtonCallback):
1133         (searchNextButtonCallback):
1134         (searchMenuCheckButtonToggledCallback):
1135         (findControllerFailedToFindTextCallback):
1136         (findControllerFoundTextCallback):
1137         (browserSearchBoxFinalize):
1138         (browserSearchBoxDispose):
1139         (browserSearchBoxSizeAllocate):
1140         (browser_search_box_class_init):
1141         (browser_search_box_new):
1142         (browser_search_box_get_entry):
1143         * MiniBrowser/gtk/BrowserSearchBox.h: Renamed from Tools/MiniBrowser/gtk/BrowserSearchBar.h.
1144         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1145         (browser_settings_dialog_init):
1146         (browser_settings_dialog_new):
1147         * MiniBrowser/gtk/BrowserSettingsDialog.h:
1148         * MiniBrowser/gtk/BrowserTab.c:
1149         (loadChanged):
1150         (createInfoBarQuestionMessage):
1151         (tlsErrorsDialogResponse):
1152         (loadFailedWithTLSerrors):
1153         (permissionRequestDialogResponse):
1154         (decidePermissionRequest):
1155         (colorChooserRequestFinished):
1156         (runColorChooserCallback):
1157         (tabCloseClicked):
1158         (browserTabConstructed):
1159         (browserTabIsSearchBarOpen):
1160         (browser_tab_start_search):
1161         (browser_tab_stop_search):
1162         (browser_tab_enter_fullscreen):
1163         (browser_tab_leave_fullscreen):
1164         * MiniBrowser/gtk/BrowserWindow.c:
1165         (settingsCallback):
1166         (resetEntryProgress):
1167         (webViewLoadProgressChanged):
1168         (browserWindowCreateBackForwardMenu):
1169         (browserWindowUpdateNavigationMenu):
1170         (navigationButtonPressed):
1171         (navigationButtonPressCallback):
1172         (scrollEventCallback):
1173         (webViewIsLoadingChanged):
1174         (searchCallback):
1175         (insertImageDialogResponse):
1176         (insertImageCommandCallback):
1177         (insertLinkDialogResponse):
1178         (insertLinkCommandCallback):
1179         (typingAttributesChanged):
1180         (browserWindowSaveSession):
1181         (browserWindowFinalize):
1182         (browserWindowDispose):
1183         (addToolbarButton):
1184         (browserWindowSwitchTab):
1185         (browserWindowTabAddedOrRemoved):
1186         (browserWindowBuildPopoverMenu):
1187         (browserWindowCloseRequest):
1188         (browserWindowDeleteEvent):
1189         (browser_window_class_init):
1190         (browser_window_append_view):
1191         (browser_window_set_background_color):
1192         * MiniBrowser/gtk/CMakeLists.txt:
1193
1194 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1195
1196         [GTK] MiniBrowser: stop using GtkToolbar
1197         https://bugs.webkit.org/show_bug.cgi?id=212898
1198
1199         Reviewed by Adrian Perez de Castro.
1200
1201         GtkToolbar iss no longer available in GTK4, use a GtkBox with buttons instead. Also use symbolic icons and move
1202         some of the actions to a gear menu.
1203
1204         * MiniBrowser/gtk/BrowserWindow.c:
1205         (browserWindowHistoryItemActivated):
1206         (browserWindowCreateBackForwardMenu):
1207         (browserWindowUpdateNavigationMenu):
1208         (navigationButtonPressCallback):
1209         (browserWindowCanZoomDefault):
1210         (browserWindowUpdateZoomActions):
1211         (webViewIsLoadingChanged):
1212         (addToolbarButton):
1213         (browserWindowBuildPopoverMenu):
1214         (resetStatusText): Deleted.
1215         (browserWindowHistoryItemSelected): Deleted.
1216         (browserWindowSetupEditorToolbarItem): Deleted.
1217
1218 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1219
1220         [GTK] MiniBrowser: stop using GtkToolbar for the search bar
1221         https://bugs.webkit.org/show_bug.cgi?id=212817
1222
1223         Reviewed by Adrian Perez de Castro.
1224
1225         Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4. Also use a GtkPopover for the
1226         options menu instead of the GtkMenu.
1227
1228         * MiniBrowser/gtk/BrowserSearchBar.c:
1229         (setFailedStyleForEntry):
1230         (doSearch):
1231         (searchEntryMenuIconPressedCallback):
1232         (searchEntryChangedCallback):
1233         (searchMenuCheckButtonToggledCallback):
1234         (browserSearchBarFinalize):
1235         (browser_search_bar_new):
1236         (browser_search_bar_open):
1237         (browser_search_bar_close):
1238         (browser_search_bar_is_open):
1239         (searchCloseButtonClickedCallback): Deleted.
1240         (searchEntryClearIconReleasedCallback): Deleted.
1241         * MiniBrowser/gtk/BrowserSearchBar.h:
1242         * MiniBrowser/gtk/BrowserTab.c:
1243         (browser_tab_start_search):
1244         (browser_tab_stop_search):
1245
1246 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1247
1248         [GTK4] Make WebDriver work
1249         https://bugs.webkit.org/show_bug.cgi?id=212316
1250
1251         Reviewed by Adrian Perez de Castro.
1252
1253         Stop connecting to WebKitWebView::close signal twice for newaly created windows.
1254
1255         * MiniBrowser/gtk/BrowserWindow.c:
1256         (webViewCreate):
1257
1258 2020-06-11  Saam Barati  <sbarati@apple.com>
1259
1260         Skip wasm-js2 test on memory limited devices
1261         https://bugs.webkit.org/show_bug.cgi?id=213099
1262
1263         Reviewed by Yusuke Suzuki.
1264
1265         * Scripts/run-jsc-stress-tests:
1266
1267 2020-06-11  Alex Christensen  <achristensen@webkit.org>
1268
1269         Re-enable download resume tests
1270         https://bugs.webkit.org/show_bug.cgi?id=213098
1271         <rdar://problem/63512518>
1272
1273         Reviewed by Geoffrey Garen.
1274
1275         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1276
1277 2020-06-11  Commit Queue  <commit-queue@webkit.org>
1278
1279         Unreviewed, reverting r262696.
1280         https://bugs.webkit.org/show_bug.cgi?id=213097
1281
1282         It broke running JSC tests on watchOS
1283
1284         Reverted changeset:
1285
1286         "Allow run-jsc-stress-tests still run if some of the remote
1287         hosts are not available"
1288         https://bugs.webkit.org/show_bug.cgi?id=201426
1289         https://trac.webkit.org/changeset/262696
1290
1291 2020-06-11  Sihui Liu  <sihui_liu@apple.com>
1292
1293         REGRESSION (r262879): 3 TestWebKitAPI.TextManipulation tests are failing
1294         https://bugs.webkit.org/show_bug.cgi?id=213079
1295         <rdar://problem/64256870>
1296
1297         Reviewed by Wenson Hsieh.
1298
1299         Update a few tests after behavior change in r262879. From r262879, we no longer use visible positions of element
1300         to calculate range to observe. Instead, we use the first and end position in the element to decide the range. In
1301         previous implementation, the range can be extended to outside of the element, like some visible positon before 
1302         or after the element.
1303
1304         TextManipulation.StartTextManipulationFindNewlyDisplayedParagraph: Different elements would make separate ranges 
1305         because we create range with the boundaries of element. We can consider merging adjacent ranges later.
1306         TextManipulation.StartTextManipulationFindSameParagraphWithNewContent: The newly observing range only includes
1307         the newly inserted element now.
1308         TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem: The p element
1309         is not manipulated as it is the common ancestor of manipulated elements. And we want to make sure the newly
1310         inserted element is child of a manipulated element.
1311
1312         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1313         (TestWebKitAPI::TEST):
1314
1315 2020-06-11  Andy Estes  <aestes@apple.com>
1316
1317         [iOS] nullptr deref in FileInputType::iconLoaded when the input's type attribute is modified by a change event listener
1318         https://bugs.webkit.org/show_bug.cgi?id=208244
1319         <rdar://problem/41855350>
1320
1321         Reviewed by Wenson Hsieh.
1322
1323         * DumpRenderTree/TestRunner.cpp:
1324         (SetOpenPanelFilesMediaIconCallback):
1325         (TestRunner::staticFunctions):
1326         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1327         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1328
1329 2020-06-11  Sergio Villar Senin  <svillar@igalia.com>
1330
1331         Unreviewed, updated libsoup dependency in jhbuild.
1332
1333         * wpe/jhbuild.modules:
1334
1335 2020-06-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1336
1337         [macOS]: The File Picker of the <input> file element should show the selection filter
1338         https://bugs.webkit.org/show_bug.cgi?id=212485
1339
1340         Reviewed by Darin Adler.
1341
1342         Create a view with an NSPopupButton for the file extensions filter. Set
1343         this view as the AccessoryView of the OpenPanel. Create a customized target
1344         for the NSPopupButton to respond to changing its selection.
1345
1346         * MiniBrowser/mac/WK2BrowserWindowController.m:
1347         (-[FileExtensionsPopupTarget initWithOpenPanel:allowedFileExtensions:]):
1348         (-[FileExtensionsPopupTarget popupAction:]):
1349         (-[FileExtensionsPopupTarget dealloc]):
1350         (-[WK2BrowserWindowController dealloc]):
1351         (-[WK2BrowserWindowController createFilterView:popupTarget:]):
1352         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1353
1354 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
1355
1356         Generalize configure-xcode-for-ios-development (Part 2)
1357         https://bugs.webkit.org/show_bug.cgi?id=207043
1358         <rdar://problem/63946933>
1359
1360         Reviewed by Darin Adler.
1361
1362         * EWSTools/start-queue-mac.sh: Use configure-xcode-for-embedded-development over configure-xcode-for-ios-development.
1363         * Scripts/configure-xcode-for-ios-development: Removed.
1364
1365 2020-06-10  Sihui Liu  <sihui_liu@apple.com>
1366
1367         Text manipulation does not observe inserted elements that are invisible
1368         https://bugs.webkit.org/show_bug.cgi?id=213057
1369         <rdar://problem/63768253>
1370
1371         Reviewed by Wenson Hsieh.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1374         (TestWebKitAPI::TEST):
1375
1376 2020-06-10  Geoffrey Garen  <ggaren@apple.com>
1377
1378         Some style improvements to main thread code
1379         https://bugs.webkit.org/show_bug.cgi?id=213051
1380
1381         Reviewed by Darin Adler.
1382
1383         Updated for rename.
1384         
1385         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1386         (TestWebKitAPI::TEST):
1387         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1388         (TestWebKitAPI::TEST):
1389         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1390         (TestWebKitAPI::TEST):
1391         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1392         (ApplicationManifestParserTest::SetUp):
1393         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1394         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1395         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1396         (TestWebKitAPI::ContentExtensionTest::SetUp):
1397         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
1398         (TestWebKitAPI::TEST):
1399         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1400         (TestWebKitAPI::TEST_F):
1401         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1402         (initializeInAppBrowserPrivacyTestSettings):
1403         * WebKitTestRunner/TestController.cpp:
1404         (WTR::TestController::initialize):
1405
1406 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
1407
1408         results.webkit.org: Health check should access redis and Cassandra
1409         https://bugs.webkit.org/show_bug.cgi?id=212899
1410         <rdar://problem/64118077>
1411
1412         Reviewed by Stephanie Lewis.
1413
1414         * resultsdbpy/resultsdbpy/example/main.py:
1415         (health): Check the health status of the model.
1416         * resultsdbpy/resultsdbpy/model/model.py:
1417         (Model.HealthTable):
1418         (Model.__init__): Construct a Cassandra table used to check the health of our Cassandra connection.
1419         (Model.healthy): Make both a read and write connection to our two database dependencies so that if
1420         our connection to those databases fails, an instance will be forced to restart.
1421         * resultsdbpy/resultsdbpy/model/model_unittest.py: Added.
1422         (ModelTest):
1423         (ModelTest.init_database):
1424         (ModelTest.test_health):
1425
1426 2020-06-10  Keith Miller  <keith_miller@apple.com>
1427
1428         run-jsc-stress-tests should skip tests marked as slow in quick mode.
1429         https://bugs.webkit.org/show_bug.cgi?id=213042
1430
1431         Reviewed by Yusuke Suzuki.
1432
1433         * Scripts/run-jsc-stress-tests:
1434
1435 2020-06-10  Antoine Quint  <graouts@webkit.org>
1436
1437         Subframes should not autosize independently
1438         https://bugs.webkit.org/show_bug.cgi?id=212984
1439         <rdar://problem/64175493>
1440
1441         Reviewed by Simon Fraser.
1442
1443         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1444         (TEST): Added test for <object>.
1445
1446 2020-06-09  Ryan Haddad  <ryanhaddad@apple.com>
1447
1448         [Mojave] Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
1449         https://bugs.webkit.org/show_bug.cgi?id=206956
1450
1451         Unreviewed test gardening.
1452
1453         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Disable this test for Mojave.
1454
1455 2020-06-10  Alex Christensen  <achristensen@webkit.org>
1456
1457         Revert r259770
1458         https://bugs.webkit.org/show_bug.cgi?id=210097
1459         <rdar://problem/64175992>
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1462         (TEST):
1463
1464 2020-06-10  Commit Queue  <commit-queue@webkit.org>
1465
1466         Unreviewed, reverting r262807.
1467         https://bugs.webkit.org/show_bug.cgi?id=213019
1468
1469         It is breaking JSC queues (Requested by caiolima on #webkit).
1470
1471         Reverted changeset:
1472
1473         "Add a timeout monitor for JSC stress test"
1474         https://bugs.webkit.org/show_bug.cgi?id=211978
1475         https://trac.webkit.org/changeset/262807
1476
1477 2020-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1478
1479         Unreviewed, reverting r262791.
1480
1481         WinCairo WebKit1 is crashing.
1482
1483         Reverted changeset:
1484
1485         "[Curl] Implement functions to use ResourceLoadStatistics."
1486         https://bugs.webkit.org/show_bug.cgi?id=207692
1487         https://trac.webkit.org/changeset/262791
1488
1489 2020-06-09  Zhifei Fang  <zhifei_fang@apple.com>
1490
1491         Add a timeout monitor for JSC stress test
1492         https://bugs.webkit.org/show_bug.cgi?id=211978
1493
1494         Reviewed by Jonathan Bedard.
1495
1496         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working
1497
1498 2020-06-09  Tim Horton  <timothy_horton@apple.com>
1499
1500         WebKit.ShrinkToFit is failing on some bots
1501         https://bugs.webkit.org/show_bug.cgi?id=212932
1502         <rdar://problem/60972407>
1503
1504         Reviewed by Simon Fraser.
1505
1506         TestWebKitAPI was failing to stabilize the overlay scrollbar preference,
1507         because the only stabilization attempt was in the injected bundle 
1508         initialization code, and most tests (including ShrinkToFit) do not have
1509         an injected bundle.
1510
1511         Because this preference is manually propagated to the Web Content process,
1512         we can set the default in the volatile domain in the UI process at startup.
1513
1514         We can't move other preferences yet, because they are not manually propagated,
1515         and WebKit's NSUserDefault synchronization mechanism ignores defaults in the
1516         volatile domain (and the initial preference load reads from disk, not
1517         from the UI process, so it wouldn't find them anyway).
1518
1519         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
1520         (TEST):
1521         Explain why the final value of the test is different than the starting value.
1522
1523         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1524         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1525         Leave a FIXME for future generations.
1526
1527         * TestWebKitAPI/mac/mainMac.mm:
1528         (main):
1529         Override overlay scrollbar preferences in the UI process, so it affects all tests.
1530
1531         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1532         This test is also affected by using non-overlay scrollbars; we now have less space, so take up more pages.
1533
1534 2020-06-09  Youenn Fablet  <youenn@apple.com>
1535
1536         BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
1537         https://bugs.webkit.org/show_bug.cgi?id=212970
1538
1539         Reviewed by Eric Carlson.
1540
1541         Add an option to capture in UI process so that the same test can run on both MacOS and iOS.
1542         This eases the testing infra to be able to get audio capture unit state in WebProcess as is the case in iOS.
1543
1544         * WebKitTestRunner/TestController.cpp:
1545         (WTR::TestController::resetPreferencesToConsistentValues):
1546         (WTR::updateTestOptionsFromTestHeader):
1547         * WebKitTestRunner/TestOptions.h:
1548         (WTR::TestOptions::hasSameInitializationOptions const):
1549
1550 2020-06-09  Takashi Komori  <Takashi.Komori@sony.com>
1551
1552         [Curl] Implement functions to use ResourceLoadStatistics.
1553         https://bugs.webkit.org/show_bug.cgi?id=207692
1554
1555         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
1556
1557         Tests: http/tests/resourceLoadStatistics/
1558
1559         Reviewed by Don Olmstead.
1560
1561         * WebKitTestRunner/TestController.cpp:
1562         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
1563         (WTR::getAllStorageAccessEntriesCallback):
1564         (WTR::TestController::getAllStorageAccessEntries):
1565
1566 2020-06-09  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1567
1568         [Flatpak][GStreamer] enhance GST_ environment variable passing
1569         https://bugs.webkit.org/show_bug.cgi?id=212905
1570
1571         Reviewed by Philippe Normand.
1572
1573         Handle the passing of several GST environment variables,
1574         particularly GST_DEBUG, which, when using * symbol, python adds
1575         quotes, but they break the parsing in GStreamer.
1576
1577         Also the variables are handled by gst-env.py when using
1578         GST_BUILD_PATH, so they are filtered out when it's exported,
1579         avoiding duplication. But it GST_BUILD_PATH is not defined, the
1580         variables are passed to flatpak.
1581
1582         * flatpak/flatpakutils.py:
1583         (WebkitFlatpak.setup_gstbuild):
1584         (WebkitFlatpak.run_in_sandbox):
1585
1586 2020-06-09  Sihui Liu  <sihui_liu@apple.com>
1587
1588         TextManipulationController range of paragraph may be wrong after r262601
1589         https://bugs.webkit.org/show_bug.cgi?id=212874
1590
1591         Reviewed by Wenson Hsieh.
1592
1593         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1594         (TestWebKitAPI::TEST):
1595
1596 2020-06-08  Sihui Liu  <sihui_liu@apple.com>
1597
1598         TextManipulation should only convert text from Node's text content to tokens
1599         https://bugs.webkit.org/show_bug.cgi?id=212928
1600
1601         Reviewed by Wenson Hsieh.
1602
1603         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1604         (TestWebKitAPI::TEST):
1605
1606 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
1607
1608         [webkitpy] Check 'bug-search' returns a non null result before parsing
1609         https://bugs.webkit.org/show_bug.cgi?id=212906
1610
1611         Reviewed by Jonathan Bedard.
1612
1613         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1614         (BugzillaQueries._parse_result_count): Check quick-search query
1615         response is non-null and a non-empty text.
1616
1617 2020-06-08  Sam Weinig  <weinig@apple.com>
1618
1619         Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
1620         https://bugs.webkit.org/show_bug.cgi?id=212917
1621
1622         Reviewed by Darin Adler.
1623
1624         Addresses feedback from Darin.
1625
1626         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1627         (TestWebKitAPI::TEST):
1628
1629 2020-06-08  Sam Weinig  <weinig@apple.com>
1630
1631         Fix test results after r262733.
1632
1633         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1634         (TestWebKitAPI::TEST):
1635
1636 2020-06-08  David Kilzer  <ddkilzer@apple.com>
1637
1638         [IPC] Adopt enum class for DragOperation
1639         <https://webkit.org/b/212870>
1640         <rdar://problem/64069940>
1641
1642         Reviewed by Darin Adler.
1643
1644         * Scripts/do-webcore-rename:
1645         - Do DragOperation renames.
1646
1647 2020-06-08  Commit Queue  <commit-queue@webkit.org>
1648
1649         Unreviewed, reverting r262685.
1650         https://bugs.webkit.org/show_bug.cgi?id=212914
1651
1652         caused flakey crashes in an iOS test
1653
1654         Reverted changeset:
1655
1656         "Clear WebPageProxy event state between tests"
1657         https://bugs.webkit.org/show_bug.cgi?id=212864
1658         https://trac.webkit.org/changeset/262685
1659
1660 2020-06-08  Sam Weinig  <weinig@apple.com>
1661
1662         Extended Color: Unify rounding / clamping conversions between 0-1 float components and 0-255 byte components
1663         https://bugs.webkit.org/show_bug.cgi?id=212871
1664
1665         Reviewed by Simon Fraser.
1666
1667         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1668         (TestWebKitAPI::TEST):
1669         Switch to using makeSimpleColor(hslToSRGB(...)) directly.
1670
1671 2020-06-08  Sam Weinig  <weinig@apple.com>
1672
1673         Extended Color: Replace uses of differenceSquared() with luminance based computations
1674         https://bugs.webkit.org/show_bug.cgi?id=212872
1675
1676         Reviewed by Darin Adler.
1677
1678         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1679         (TestWebKitAPI::TEST):
1680         Add basic tests for Color::luminance(), ensuring white == 1, black == 0, and 
1681         darken() and lighten() creat colors with less than / greater than luminance.
1682
1683 2020-06-08  Per Arne Vollan  <pvollan@apple.com>
1684
1685         [Cocoa] CFPrefs synchronization does not always work for global preference changes
1686         https://bugs.webkit.org/show_bug.cgi?id=212783
1687
1688         Reviewed by Tim Horton.
1689
1690         Add API test, and add some synchronization to avoid flakiness.
1691
1692         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1693         (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
1694         (TEST):
1695         (sharedInstanceMethodOverride):
1696
1697 2020-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1698
1699         [iOS] Hit-testing on icloud.com is offset after closing a tab
1700         https://bugs.webkit.org/show_bug.cgi?id=212890
1701         <rdar://problem/58775297>
1702
1703         Reviewed by Simon Fraser.
1704
1705         Add a new API test to verify that the scroll position doesn't get stuck at -30px after shifting both the top
1706         content inset and top obscured inset by 30px. See WebKit ChangeLog for more details.
1707
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WebKitCocoa/overflow-hidden.html: Added.
1710         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1711         (-[ScrollViewDelegate scrollViewDidScroll:]):
1712         (TestWebKitAPI::TEST):
1713         * TestWebKitAPI/ios/UIKitSPI.h:
1714
1715 2020-06-08  Philippe Normand  <pnormand@igalia.com>
1716
1717         [Flatpak SDK] Add flatpak-run-nightly
1718         https://bugs.webkit.org/show_bug.cgi?id=212882
1719
1720         Reviewed by Carlos Alberto Lopez Perez.
1721
1722         This new script is able to download WPE and GTK builds from the Igalia servers and run the
1723         corresponding binaries (like MiniBrowser, jsc) within the Flatpak SDK.
1724
1725         Unzipped builds will be saved in /tmp and can be reused in further runs (by providing the
1726         path with the -p argument).
1727
1728         Example:
1729         $ webkit-flatpak-run-nightly --wpe MiniBrowser https://webkit.org
1730         <SDK installs to ~/.cache/wk-nightly>
1731         Downloading build release_r262699_b33885.zip from https://wpewebkit-release.igalia.com/built-products/
1732         Extracting build to /tmp/wpewebkit-release-b33885
1733         <MiniBrowser starts>
1734
1735         $ webkit-flatpak-run-nightly --wpe -p /tmp/wpewebkit-release-b33885 jsc
1736         Looking for updates…
1737         Nothing to do.
1738         >>> 2+2
1739         4
1740
1741         * Scripts/webkit-flatpak-run-nightly: Added.
1742
1743 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
1744
1745         [webkitpy] Make 'webkit-path rebaseline' to not update expectations file by default
1746         https://bugs.webkit.org/show_bug.cgi?id=212835
1747
1748         Reviewed by Carlos Alberto Lopez Perez.
1749
1750         `webkit-patch rebaseline` let us add or update a test baseline
1751         from a test bot. By default, the command also updates the
1752         corresponding expectations file. This update is actually a brand-new
1753         generation of an expectations file based on the results of the bot,
1754         which in most cases messes up the current contents of the file.
1755
1756         This patch makes the default to not update the expectations file and
1757         adds a new option '--update-expectations' to explicitly request an
1758         update.
1759
1760         * Scripts/webkitpy/tool/commands/rebaseline.py:
1761         (AbstractRebaseliningCommand):
1762         (RebaselineTest.__init__):
1763         (RebaselineTest._rebaseline_tests):
1764         (RebaselineTest.execute):
1765         (AbstractParallelRebaselineCommand._rebaseline_commands):
1766         (RebaselineExpectations.__init__):
1767         (RebaselineExpectations.execute):
1768         (Rebaseline.__init__):
1769         (RebaselineTest._rebaseline_test_and_update_expectations): Deleted.
1770         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1771         (TestRebaselineTest.setUp):
1772
1773 2020-06-08  Youenn Fablet  <youenn@apple.com>
1774
1775         File URLs with hostnames are misleading
1776         https://bugs.webkit.org/show_bug.cgi?id=212739
1777         <rdar://problem/63754917>
1778
1779         Reviewed by Alex Christensen.
1780
1781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1782         * TestWebKitAPI/Tests/WebKit/open-window-with-file-url-with-host.html: Added.
1783         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1784         (TEST):
1785
1786 2020-06-07  Caio Lima  <ticaiolima@gmail.com>
1787
1788         Allow run-jsc-stress-tests still run if some of the remote hosts are not available
1789         https://bugs.webkit.org/show_bug.cgi?id=201426
1790
1791         Reviewed by Saam Barati.
1792
1793         This patch allows run-jsc-stress-tests to keep on running if some of
1794         the remote hosts are not available. To do this, we created a new
1795         function `checkAndPrepareRemoteHosts` that is responsible to check the
1796         connection and read/write permissions of given remote hosts list. It
1797         filters out every unavailable remote host.
1798         These checks and filter happen in the beginning of the script and is
1799         excuted only once, in the beggining of the script. It means that if
1800         some remote device becomes unavailable after the check and preparation
1801         is done, the script execution will be interupted.
1802
1803         * Scripts/run-jsc-stress-tests:
1804
1805 2020-06-07  Philippe Normand  <pnormand@igalia.com>
1806
1807         Remove ENABLE_VIDEO_TRACK ifdef guards
1808         https://bugs.webkit.org/show_bug.cgi?id=212568
1809
1810         Reviewed by Youenn Fablet.
1811
1812         * Scripts/webkitperl/FeatureList.pm:
1813         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1814
1815 2020-06-06  Simon Fraser  <simon.fraser@apple.com>
1816
1817         Clear WebPageProxy event state between tests
1818         https://bugs.webkit.org/show_bug.cgi?id=212864
1819
1820         Reviewed by Anders Carlsson.
1821
1822         Make sure that event state doesn't leak between tests via events queued in WebPageProxy.
1823
1824         * WebKitTestRunner/TestController.cpp:
1825         (WTR::TestController::resetStateToConsistentValues):
1826
1827 2020-06-06  Peng Liu  <peng.liu6@apple.com>
1828
1829         REGRESSION (r262456): [iOS Debug] TestWebKitAPI.WKWebViewCloseAllMediaPresentations.PictureInPicture is frequently timing out
1830         https://bugs.webkit.org/show_bug.cgi?id=212777
1831
1832         Unreviewed test gardening.
1833
1834         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
1835         Disable the PictureInPicture test for old iOS devices.
1836
1837 2020-06-05  Ryan Haddad  <ryanhaddad@apple.com>
1838
1839         [iOS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
1840         https://bugs.webkit.org/show_bug.cgi?id=208451
1841
1842         Unreviewed test gardening.
1843
1844         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable this test again because it is still failing on certain bots.
1845
1846 2020-06-05  Daniel Bates  <dabates@apple.com>
1847
1848         -_focusTextInputContext should reposition the caret if called for an already focused text input context
1849         https://bugs.webkit.org/show_bug.cgi?id=212830
1850         <rdar://problem/64032956>
1851
1852         Reviewed by Wenson Hsieh.
1853
1854         Re-purpose some existing tests to check for the new behavior.
1855
1856         In TextInteraction_FocusingAssistedElementShouldScrollToReveal, keep in mind that the caret position is
1857         changing: on iOS, calling input.focus() places the caret at the end of the field's content.
1858
1859         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1860         (TestWebKitAPI::TEST):
1861
1862 2020-06-05  Jonathan Bedard  <jbedard@apple.com>
1863
1864         Generalize configure-xcode-for-ios-development (Part 1)
1865         https://bugs.webkit.org/show_bug.cgi?id=207043
1866
1867         Rubber-stamped by David Kilzer.
1868
1869         Patch by Keith Rollin and Jonathan Bedard.
1870
1871         Replace configure-xcode-for-ios-development with a Python script that works for iOS,
1872         watchOS and tvOS.
1873
1874         * Scripts/configure-xcode-for-embedded-development: Added.
1875
1876 2020-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1877
1878         Text manipulation should exclude characters outside of the unicode private use area
1879         https://bugs.webkit.org/show_bug.cgi?id=212800
1880         <rdar://problem/63736417>
1881
1882         Reviewed by Sihui Liu.
1883
1884         Add a new API test to verify the new behavior when extracting PUA characters.
1885
1886         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1887         (TestWebKitAPI::TEST):
1888
1889 2020-06-05  Dean Jackson  <dino@apple.com>
1890
1891         REGRESSION (r262366): [ Mac wk1 ] webgl/webgl-backing-store-size-update.html is failing
1892         https://bugs.webkit.org/show_bug.cgi?id=212647
1893         <rdar://problem/63882960>
1894
1895         Reviewed by Eric Carlson.
1896
1897         Drive-by comment from Simon. Remove some useless braces.
1898
1899         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:
1900
1901 2020-06-05  Saam Barati  <sbarati@apple.com>
1902
1903         Try to reduce jetsams further on iOS devices running jsc stress tests
1904         https://bugs.webkit.org/show_bug.cgi?id=212786
1905
1906         Reviewed by Mark Lam.
1907
1908         * Scripts/run-jsc-stress-tests:
1909
1910 2020-06-05  Peng Liu  <peng.liu6@apple.com>
1911
1912         REGRESSION (r262456?): [macOS] media/picture-in-picture/picture-in-picture-api tests are flaky timeouts
1913         https://bugs.webkit.org/show_bug.cgi?id=212762
1914
1915         Reviewed by Eric Carlson.
1916
1917         Skip the Picture-in-Picture test if Picture-in-Picture is not supported and add playsinline attribute
1918         to the video element.
1919
1920         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
1921         (TEST):
1922
1923 2020-06-05  Andy Estes  <aestes@apple.com>
1924
1925         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
1926         https://bugs.webkit.org/show_bug.cgi?id=212541
1927         <rdar://problem/63781452>
1928
1929         Reviewed by Darin Adler.
1930
1931         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
1932
1933         * Scripts/webkitperl/FeatureList.pm:
1934         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1935
1936 2020-06-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1937
1938         [GTK] MiniBrowser: use GAction API for actions and shortcuts in preparation for GTK4
1939         https://bugs.webkit.org/show_bug.cgi?id=212740
1940
1941         Reviewed by Adrian Perez de Castro.
1942
1943         Make MiniBrowser a GtkApplication and BrowserWindow a GtkApplicationWindow to easily install actions and shortcuts.
1944
1945         * MiniBrowser/gtk/BrowserMain.c: Removed.
1946         * MiniBrowser/gtk/BrowserMain.h: Removed.
1947         * MiniBrowser/gtk/BrowserSearchBar.c:
1948         (searchPreviousButtonCallback):
1949         (searchNextButtonCallback):
1950         * MiniBrowser/gtk/BrowserSearchBar.h:
1951         * MiniBrowser/gtk/BrowserTab.c:
1952         * MiniBrowser/gtk/BrowserTab.h:
1953         * MiniBrowser/gtk/BrowserWindow.c:
1954         (reloadOrStopCallback):
1955         (goBackCallback):
1956         (goForwardCallback):
1957         (settingsCallback):
1958         (browserWindowUpdateNavigationMenu):
1959         (browserWindowTryCloseCurrentWebView):
1960         (browserWindowTryClose):
1961         (webViewCreate):
1962         (browserWindowUpdateZoomActions):
1963         (webViewZoomLevelChanged):
1964         (zoomInCallback):
1965         (zoomOutCallback):
1966         (defaultZoomCallback):
1967         (searchCallback):
1968         (newTabCallback):
1969         (toggleWebInspector):
1970         (openPrivateWindow):
1971         (focusLocationBar):
1972         (reloadPage):
1973         (reloadPageIgnoringCache):
1974         (stopPageLoad):
1975         (loadHomePage):
1976         (toggleFullScreen):
1977         (printPage):
1978         (editingActionCallback):
1979         (typingAttributesChanged):
1980         (browserWindowFinalize):
1981         (browserWindowSetupEditorToolbarItem):
1982         (browserWindowSetupToolbarItem):
1983         (browserWindowDeleteEvent):
1984         (browser_window_new):
1985         (browser_window_append_view):
1986         (browser_window_get_or_create_web_view_for_automation):
1987         (browser_window_create_web_view_in_new_tab_for_automation):
1988         * MiniBrowser/gtk/BrowserWindow.h:
1989         * MiniBrowser/gtk/CMakeLists.txt:
1990         * MiniBrowser/gtk/main.c:
1991         (createWebViewForAutomationInWindowCallback):
1992         (createWebViewForAutomationInTabCallback):
1993         (automationStartedCallback):
1994         (startup):
1995         (activate):
1996         (main):
1997
1998 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
1999
2000         Text manipulation: first and last unit in a paragraph should not contain only excluded tokens
2001         https://bugs.webkit.org/show_bug.cgi?id=212759
2002
2003         Reviewed by Wenson Hsieh.
2004
2005         Modify existing test for changed behavior that leading and trailing excluded units are not included in paragraph
2006         now.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2009         (TestWebKitAPI::TEST):
2010
2011 2020-06-04  Chris Dumez  <cdumez@apple.com>
2012
2013         UIProcess may crash after its prewarmed WebProcess gets terminated
2014         https://bugs.webkit.org/show_bug.cgi?id=212790
2015         <rdar://problem/63696191>
2016
2017         Reviewed by Geoffrey Garen.
2018
2019         Add API test coverage.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2022         (TEST):
2023
2024 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
2025
2026         REGRESSION: (r262398) Text manipulation crashes when content is added
2027         https://bugs.webkit.org/show_bug.cgi?id=212785
2028
2029         Reviewed by Ryosuke Niwa.
2030
2031         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2032         (TestWebKitAPI::TEST):
2033
2034 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2035
2036         Improve watchlist logic for comments on patches touching imported WPT tests.
2037         https://bugs.webkit.org/show_bug.cgi?id=212597
2038
2039         Reviewed by Youenn Fablet.
2040
2041         On r262295 I added a watchlist comment for patches touching the imported WPT tests.
2042         However, this is commenting on patches that are importing WPT tests.
2043
2044         To avoid this situations, this patch adds a new rule to detect if the changes modify
2045         any of the w3c-import.log files, and then changes the logic to make the comment only
2046         for patches that modify the WPT imported tests but not the w3c-import.log files.
2047
2048         In order to support this new logic, watchlist rule parsing is improved to support
2049         the "and" and "not" operators. Previously it only supported the "or" operator.
2050
2051         * Scripts/webkitpy/common/config/watchlist:
2052         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2053         (WatchListParser._rule_definitions_as_set):
2054         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2055         (WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion):
2056         (WatchListParserTest):
2057         (WatchListParserTest.test_cc_rule_with_complex_logic):
2058         * Scripts/webkitpy/common/watchlist/watchlistrule.py:
2059         (WatchListRule.__init__):
2060         (WatchListRule._match_test_definitions):
2061         (WatchListRule.match):
2062         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2063         (WatchListRuleTest.test_complex_definition_or):
2064         (WatchListRuleTest):
2065         (WatchListRuleTest.test_complex_definition_and):
2066         (WatchListRuleTest.test_complex_definition_not):
2067         (WatchListRuleTest.test_complex_definition_combined):
2068
2069 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2070
2071         svn-apply command is too slow with big patches
2072         https://bugs.webkit.org/show_bug.cgi?id=212766
2073
2074         Reviewed by Darin Adler.
2075
2076         The script svn-apply was calling a "git add" or "svn add" command
2077         after adding each new file. This caused the git or svn command to
2078         re-check the internal SCM database each time they were called, and
2079         this was really slow when lot of new files are added.
2080         Instead of doing this, we queue the list of new files in memory,
2081         and at the end we call "git add" or "svn add" once (or a few times).
2082
2083         On top of that, another optimization is added for the case of git,
2084         to avoid calling scmKnowsOfFile() inside addDirectoriesIfNeeded(),
2085         which is a slow operation and gets called a lot (once per file).
2086         Doing that for git is totally unneeded, as the only thing we have
2087         to take care about, is of ensuring that the directory is created.
2088         See: https://wkb.ug/86973
2089
2090         This reduces the time spent in the large test patch that caused
2091         this issue (see bug):
2092          - Git: 8 hours (before) -> 8 minutes (now).
2093          - SVN: 25 minutes (before) -> 5 minutes (now).
2094
2095         * Scripts/svn-apply:
2096         (addDirectoriesIfNeeded):
2097         (handleBinaryChange):
2098         (handleGitBinaryChange):
2099         (patch):
2100         (scmRemove):
2101         (scmAddQueued):
2102         (scmCommitQueueAdded):
2103         (scmToggleExecutableBitQueued):
2104         (scmCommitQueueToggledExecutableBit):
2105
2106 2020-06-04  Jonathan Bedard  <jbedard@apple.com>
2107
2108         Add watchOS and tvOS to build-webkit
2109         https://bugs.webkit.org/show_bug.cgi?id=212719
2110         <rdar://problem/63951600>
2111
2112         Reviewed by Tim Horton.
2113
2114         * Scripts/build-webkit: Add tvOS and watchOS flags, generalize embedded if statements.
2115         * Scripts/webkitdirs.pm:
2116         (determineArchitecture): Add tvOS and watchOS architectures.
2117         (argumentsForConfiguration): Add tvOS and watchOS flags.
2118         (extractNonMacOSHostConfiguration): Ditto.
2119
2120 2020-06-04  Tim Horton  <timothy_horton@apple.com>
2121
2122         Work around broken system version macro
2123         https://bugs.webkit.org/show_bug.cgi?id=212726
2124
2125         Reviewed by Dan Bernstein.
2126
2127         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2128         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2129         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2130         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2131         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2132         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2133         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2134         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
2135
2136 2020-06-04  Andy Estes  <aestes@apple.com>
2137
2138         [watchOS] Re-enable content filtering in the simulator build
2139         https://bugs.webkit.org/show_bug.cgi?id=212711
2140         <rdar://problem/63938350>
2141
2142         Reviewed by Wenson Hsieh.
2143
2144         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2145
2146 2020-06-04  Philippe Normand  <pnormand@igalia.com>
2147
2148         [Flatpak SDK] Update definitions
2149         https://bugs.webkit.org/show_bug.cgi?id=212698
2150
2151         Reviewed by Žan Doberšek.
2152
2153         * buildstream/elements/freedesktop-sdk.bst: Update to FDO 19.08.11
2154         * buildstream/elements/sdk/gtk.bst: Update GTK4
2155         * buildstream/patches/fdo/0001-Pango-Bump-to-1.45-master.patch: Added. Needed for GTK4
2156         * buildstream/patches/fdo/0001-Add-Jack.patch: Removed. This will be used when we update to the 20.08 FDO SDK.
2157         * buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Removed. Ditto.
2158         * buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Removed. Ditto.
2159
2160 2020-06-03  Tadeu Zagallo  <tzagallo@apple.com>
2161
2162         Disable B3 hoistLoopInvariantValues by default
2163         https://bugs.webkit.org/show_bug.cgi?id=212511
2164         <rdar://problem/63813245>
2165
2166         Reviewed by Mark Lam.
2167
2168         Enable the B3 hoistLoopInvariantValues pass in one of our existing configurations to
2169         avoid bit rot since we'd like to re-enable it eventually.
2170
2171         * Scripts/run-jsc-stress-tests:
2172
2173 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2174
2175         [Text manipulation] Extract the value attribute in inputs of type "text" and "search"
2176         https://bugs.webkit.org/show_bug.cgi?id=212706
2177         <rdar://problem/63876969>
2178
2179         Reviewed by Tim Horton.
2180
2181         Add a new test case (similar to the existing test `StartTextManipulationExtractsValuesFromButtonInputs`) to
2182         verify that we extract text from the `value` of inputs of type "text" and "search".
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2185         (TestWebKitAPI::TEST):
2186
2187 2020-06-03  Michael Saboff  <msaboff@apple.com>
2188
2189         [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug simulator builds
2190         https://bugs.webkit.org/show_bug.cgi?id=211650
2191
2192         Reviewed by Saam Barati.
2193
2194         The prior change to disable this test for Debug actually enabled it
2195         only for Debug IOS builds of any type, simulator or real HW.
2196
2197         This test has intermittently failed or timed out on Debug simulator
2198         builds for for almost a year.  We want to test Release builds as well as
2199         hardware builds. Therefore we should disable Debug simulator builds,
2200         and test all other variants.
2201
2202         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2203
2204 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2205
2206         dataTransfer.types is empty when handling the "dragstart" event
2207         https://bugs.webkit.org/show_bug.cgi?id=212685
2208         <rdar://problem/61368402>
2209
2210         Reviewed by Andy Estes.
2211
2212         Adds new API tests and test infrastructure to verify that DataTransfer types and data are accessible during
2213         the "dragstart" event. See below for more details.
2214
2215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2216         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2217         (-[TestWKWebView selectElementWithID:]):
2218         (-[DragAndDropSimulator dragFromElementWithID:to:]):
2219
2220         Add a few (very specialized) helper methods to assist with simulating drags over the various elements in the new
2221         drag and drop test harness page below (dragstart-data.html).
2222
2223         (runDragStartDataTestCase):
2224
2225         Test the following scenarios (split between three API tests) by dumping the resulting DataTransfer types and
2226         their data strings, and observing the results:
2227
2228         - Dragging a normal text selection.
2229         - Dragging a normal text selection, and then adding a URL string.
2230         - Dragging a normal text selection, and then adding a custom pasteboard type.
2231         - Dragging a normal text selection, but then replacing the data with just a URL string.
2232         - Dragging a normal text selection, but then replacing the data with just a custom data type.
2233         - Dragging an image element.
2234         - Dragging an image element, and then overriding the plain text data.
2235         - Dragging a link (anchor element).
2236         - Dragging a link, and then adding a custom type.
2237
2238         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-data.html: Added.
2239
2240         Add a new test harness to help test DataTransfer types when starting a drag. This test page can also be used as
2241         a manual test harness, by simply opening the test page, starting drags on the various elements and observing the
2242         output in the textarea.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
2245
2246         Tweak this test page to replace the DataTransfer with custom data (rather than simply append it) by calling
2247         `DataTransfer.clearData()` prior to writing the custom types.
2248
2249         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2250         * TestWebKitAPI/cocoa/TestWKWebView.h:
2251         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2252         (-[TestWKWebViewHostWindow initWithWebView:contentRect:styleMask:backing:defer:]):
2253
2254         Add a `__weak` reference on TestWKWebViewHostWindow back to the TestWKWebView, so that we can consult
2255         `-eventTimestamp` when synthesizing mouse events on macOS during API tests.
2256
2257         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2258         (-[TestWKWebViewHostWindow _mouseUpAtPoint:clickCount:]):
2259         (-[TestWKWebViewHostWindow initWithWebView:frame:]):
2260         (-[TestWKWebView _setUpTestWindow:]):
2261         (-[TestWKWebView setEventTimestampOffset:]):
2262         (-[TestWKWebView eventTimestamp]):
2263
2264         Add a mechanism to offset synthetic event timestamps by a given time interval (i.e. the event timestamp offset).
2265
2266         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
2267         (-[TestWKWebView _mouseEventWithType:atLocation:]):
2268         (-[TestWKWebView typeCharacter:]):
2269         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2270         (-[DragAndDropSimulator runFrom:to:]):
2271
2272         While simulating drag and drop on macOS, use `-setEventTimestampOffset:` to "leap forward" in time, so that the
2273         150 millisecond delay when dragging a text selection doesn't prevent drags from beginning.
2274
2275 2020-06-03  Sihui Liu  <sihui_liu@apple.com>
2276
2277         Text manipulation sometimes fails to replace text in attributes
2278         https://bugs.webkit.org/show_bug.cgi?id=212701
2279
2280         Reviewed by Wenson Hsieh.
2281
2282         Modify TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens to cover text 
2283         manipulation for attributes.
2284
2285         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2286         (TestWebKitAPI::TEST):
2287
2288 2020-06-03  Diego Pino Garcia  <dpino@igalia.com>
2289
2290         [WPE] lint-test-expectations doesn't work when platform is WPE
2291         https://bugs.webkit.org/show_bug.cgi?id=212700
2292
2293         Reviewed by Carlos Alberto Lopez Perez.
2294
2295         When passing arguments '--wpe' or '--platform=wpe*',
2296         lint-test-expectations does nothing for WPE, despite currently 
2297         there are many lint errors in WPE's TestExpectations file.
2298
2299         As a side-effect of this patch, now `Tools/Scripts/webkit-path
2300         rebaseline` lists the WPE Release and Debug bots.
2301
2302         * Scripts/webkitpy/port/builders.py: Add WPE to the list of
2303         exact_matches and fuzzy_matches.
2304         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2305
2306 2020-06-03  Jonathan Bedard  <jbedard@apple.com>
2307
2308         Allow using web processes for service workers even though they loaded about URLs (Follow-up fix)
2309         https://bugs.webkit.org/show_bug.cgi?id=212464
2310
2311         Unreviewed build fix.
2312
2313         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: didFinishNavigation is now used unconditionally.
2314
2315 2020-06-02  Keith Rollin  <krollin@apple.com>
2316
2317         Revert FEATURES_DEFINES related changes
2318         https://bugs.webkit.org/show_bug.cgi?id=212664
2319         <rdar://problem/63893033>
2320
2321         Reviewed by Andy Estes.
2322
2323         Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to
2324         FEATURE_DEFINES and how the values there relate to those found in the
2325         Platform*.h files. Those changes break XCBuild (by removing the
2326         .xcfilelist related to UnifiedSources and the process for generating
2327         them), and so are being reverted.
2328
2329         * Scripts/webkitperl/FeatureList.pm:
2330         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2331         (WebCoreGenerator):
2332         (WebCoreGenerator._get_generate_unified_sources_script):
2333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2334
2335 2020-06-02  Peng Liu  <peng.liu6@apple.com>
2336
2337         Stressing webkitSetPresentationMode leads to wrong inline video dimensions
2338         https://bugs.webkit.org/show_bug.cgi?id=202425
2339
2340         Reviewed by Eric Carlson.
2341
2342         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2343         (TEST):
2344
2345 2020-06-02  Youenn Fablet  <youenn@apple.com>
2346
2347         Allow using web processes for service workers even though they loaded about URLs
2348         https://bugs.webkit.org/show_bug.cgi?id=212464
2349
2350         Reviewed by Chris Dumez.
2351
2352         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2353
2354 2020-06-02  Diego Pino Garcia  <dpino@igalia.com>
2355
2356         [buildbot] [GTK][WPE] Move JavaScript related tests to own bot
2357         https://bugs.webkit.org/show_bug.cgi?id=212481
2358
2359         Reviewed by Carlos Alberto Lopez Perez.
2360
2361         Currently GTK and WPE tests bots run too many tests. This makes
2362         the total running time for each build very long.
2363
2364         This patch moves JavaScript related tests (jscore-test and
2365         test262-test) to a separated bot which will be triggered by the
2366         corresponding build bot of each platform.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/config.json:
2369         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2370         (TestFactory.__init__):
2371         (TestJSFactory):
2372         (TestJSFactory.__init__):
2373         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2374
2375 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2376
2377         [GTK4] Make popup menus work
2378         https://bugs.webkit.org/show_bug.cgi?id=211178
2379
2380         Reviewed by Adrian Perez de Castro.
2381
2382         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2383         (WTR::PlatformWebView::dismissAllPopupMenus):
2384
2385 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2386
2387         [GTK4] Make it possible to run layout tests
2388         https://bugs.webkit.org/show_bug.cgi?id=212328
2389
2390         Reviewed by Carlos Alberto Lopez Perez.
2391
2392         Build WTR with GTK4.
2393
2394         * PlatformGTK.cmake:
2395         * Scripts/webkitdirs.pm:
2396         (builtDylibPathForName): Try with both 4 and 5 API versions.
2397         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2398         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2399         (WTR::PlatformWebView::PlatformWebView):
2400         (WTR::PlatformWebView::~PlatformWebView):
2401         (WTR::PlatformWebView::setWindowIsKey):
2402         (WTR::PlatformWebView::windowFrame):
2403         (WTR::PlatformWebView::setWindowFrame):
2404         (WTR::PlatformWebView::addToWindow):
2405         (WTR::PlatformWebView::removeFromWindow):
2406         (WTR::PlatformWebView::windowSnapshotImage):
2407         (WTR::PlatformWebView::dismissAllPopupMenus):
2408         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
2409         (WTR::UIScriptControllerGtk::copyText):
2410
2411 2020-06-01  Noam Rosenthal  <noam@webkit.org>
2412
2413         Make unicode-bidi:isolate the default for an element with a dir attribute (instead of unicode-bidi:embed)
2414         https://bugs.webkit.org/show_bug.cgi?id=134630
2415
2416         Reviewed by Simon Fraser.
2417
2418         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
2419         (TEST):
2420                 Test was expecting unicode-bidi:embed, changed expectation.
2421
2422 2020-06-01  Sihui Liu  <sihui_liu@apple.com>
2423
2424         TextManipulationController should put one Node in only one paragraph
2425         https://bugs.webkit.org/show_bug.cgi?id=212548
2426
2427         Reviewed by Wenson Hsieh.
2428
2429         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2430         (TestWebKitAPI::TEST):
2431
2432 2020-06-01  Alex Christensen  <achristensen@webkit.org>
2433
2434         Make CustomDisplayName and DefaultDisplayName API tests fail instead of timing out when something changes
2435         https://bugs.webkit.org/show_bug.cgi?id=212480
2436
2437         This saves time when debugging and running all the tests.
2438
2439         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
2440         (TestWebKitAPI::checkUntilDisplayNameIs):
2441
2442 2020-06-01  Philippe Normand  <pnormand@igalia.com>
2443
2444         [Flatpak SDK] Install and update don't provide any terminal output
2445         https://bugs.webkit.org/show_bug.cgi?id=212579
2446
2447         Reviewed by Žan Doberšek.
2448
2449         The `show_output` option was removed from the process execution routines. We now assume the
2450         output will be displayed, unless the call-site asks `gather_output`. This change makes
2451         webkit-flatpak more chatty, which is nice during install/update operations.
2452
2453         * flatpak/flatpakutils.py:
2454         (run_sanitized):
2455         (FlatpakObject.flatpak):
2456         (FlatpakPackage.install):
2457         (FlatpakPackage.update):
2458         (WebkitFlatpak.setup_builddir):
2459         (WebkitFlatpak.run_in_sandbox):
2460
2461 2020-06-01  Chris Dumez  <cdumez@apple.com>
2462
2463         ASSERTION FAILURE (r220931): !m_function in ~CompletionHandler() after switch tabs
2464         https://bugs.webkit.org/show_bug.cgi?id=212537
2465         <rdar://problem/63766838>
2466
2467         Reviewed by Alex Christensen.
2468
2469         Add API test coverage.
2470
2471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspension.mm: Added.
2473         (TEST):
2474
2475 2020-06-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2476
2477         [EWS] Add a special case for running the layout test step without aborting in case of many failures for WPT tests
2478         https://bugs.webkit.org/show_bug.cgi?id=212381
2479
2480         Reviewed by Jonathan Bedard.
2481
2482         Add a special case for patches uploaded by the bugzilla user that would be used
2483         for prototyping a bot that helps automating the import of WPT tests. For patches
2484         uploaded by this user don't pass the parameters that make the step abort early in
2485         case of many errors, and only run the layout tests inside the WPT import directory.
2486
2487         * BuildSlaveSupport/ews-build/steps.py:
2488         (RunWebKitTests):
2489         (RunWebKitTests.start):
2490         * BuildSlaveSupport/ews-build/steps_unittest.py:
2491         (test_success):
2492         (test_warnings):
2493         (test_parse_results_json_regression):
2494         (test_parse_results_json_flakes):
2495         (test_parse_results_json_flakes_and_regressions):
2496         (test_parse_results_json_with_newlines):
2497         (test_unexpected_error):
2498         (test_failure):
2499         (test_success_wpt_import_bot):
2500         (TestRunWebKitTestsWithoutPatch.test_success):
2501         (TestRunWebKitTestsWithoutPatch.test_failure):
2502         (TestRunWebKit1Tests.test_success):
2503         (TestRunWebKit1Tests.test_failure):
2504
2505 2020-06-01  Sam Weinig  <weinig@apple.com>
2506
2507         Extended Color: Replace Color constructors taking numeric values with type specific factory functions
2508         https://bugs.webkit.org/show_bug.cgi?id=212576
2509
2510         Reviewed by Tim Horton.
2511
2512         Replaces all remaining implicit and explicit uses of the Color constructors taking numeric
2513         values with explicit calls to makeSimpleColor/makeSimpleColorFromFloats/makeExtendedColor,
2514         giving us a consistent way to create colors. Also addes use constexpr SimpleColors where possible.
2515
2516         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
2519         (TestWebKitAPI::TEST):
2520         (TestWebKitAPI::makeColor):
2521         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2522         (TestWebKitAPI::TEST):
2523         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
2524         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
2525
2526 2020-05-31  Dean Jackson  <dino@apple.com>
2527
2528         AutoTrader crashed while browsing search results
2529         https://bugs.webkit.org/show_bug.cgi?id=212461
2530         rdar://60733185
2531
2532         Reviewed by Sam Weinig.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm: Added.
2536         (-[WebGLPrepareDisplayOnWebThreadDelegate webViewDidFinishLoad:]):
2537         (-[WebGLPrepareDisplayOnWebThreadDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2538         (TestWebKitAPI::TEST):
2539         * TestWebKitAPI/Tests/WebKitLegacy/ios/webgl.html: Added.
2540
2541 2020-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2542
2543         Unreviewed. Fix GTK4 build with current GTK
2544
2545         * MiniBrowser/gtk/BrowserTab.c:
2546         (audioMutedChanged):
2547
2548 2020-05-30  Sam Weinig  <weinig@apple.com>
2549
2550         Extended Color: Additional color cleanups
2551         https://bugs.webkit.org/show_bug.cgi?id=212567
2552
2553         Reviewed by Simon Fraser.
2554
2555         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
2556         (TestWebKitAPI::TEST):
2557         Update for rename from ExtendedColor::channels() to ExtendedColor::components()
2558
2559 2020-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2560
2561         [GTK] WebDriver: stop using GdkEvent API in preparation for GTK4
2562         https://bugs.webkit.org/show_bug.cgi?id=212465
2563
2564         Reviewed by Adrian Perez de Castro.
2565
2566         Update to the new webkitWebViewBaseSynthesizeKeyEvent() API.
2567
2568         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2569         (WTR::EventSenderProxy::keyDown):
2570
2571 2020-05-29  Alex Christensen  <achristensen@webkit.org>
2572
2573         Use correct encoding when converting a WTF::URL to CFURLRef
2574         https://bugs.webkit.org/show_bug.cgi?id=212486
2575
2576         Reviewed by Darin Adler.
2577
2578         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2579         (TestWebKitAPI::TEST):
2580
2581 2020-05-29  Andy Estes  <aestes@apple.com>
2582
2583         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
2584         https://bugs.webkit.org/show_bug.cgi?id=212541
2585
2586         Reviewed by Darin Adler.
2587
2588         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
2589
2590         * Scripts/webkitperl/FeatureList.pm:
2591         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2592
2593 2020-05-29  Jan-Michael Brummer  <jan.brummer@tabos.org>
2594
2595         [GTK][WPE] API for WebView audio mute support
2596         https://bugs.webkit.org/show_bug.cgi?id=176119
2597
2598         Reviewed by Michael Catanzaro.
2599
2600         * MiniBrowser/gtk/BrowserTab.c:
2601         (audioClicked):
2602         (audioMutedChanged):
2603         (browserTabConstructed):
2604         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2605         (testWebViewIsAudioMuted):
2606         (beforeAll):
2607
2608 2020-05-29  Darin Adler  <darin@apple.com>
2609
2610         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
2611         https://bugs.webkit.org/show_bug.cgi?id=212418
2612
2613         Rubber-stamped by Simon Fraser.
2614
2615         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add back ENABLE_CSS_CONIC_GRADIENTS,
2616         removed by accident.
2617
2618 2020-05-29  Pavel  <pavel.feldman@gmail.com>
2619
2620         [Win] Allow compiling with the TOUCH_EVENTS enabled
2621         https://bugs.webkit.org/show_bug.cgi?id=212528
2622
2623         Reviewed by Fujii Hironori.
2624
2625         Aligning Win with GTK, adding missing EventSenderProxy stubs.
2626         This allows compiling Win with TOUCH_EVENTS and unlocks event
2627         injection / processing by the automation drivers
2628
2629         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2630         (WTR::EventSenderProxy::addTouchPoint):
2631         (WTR::EventSenderProxy::updateTouchPoint):
2632         (WTR::EventSenderProxy::setTouchModifier):
2633         (WTR::EventSenderProxy::setTouchPointRadius):
2634         (WTR::EventSenderProxy::touchStart):
2635         (WTR::EventSenderProxy::touchMove):
2636         (WTR::EventSenderProxy::touchEnd):
2637         (WTR::EventSenderProxy::touchCancel):
2638         (WTR::EventSenderProxy::clearTouchPoints):
2639         (WTR::EventSenderProxy::releaseTouchPoint):
2640         (WTR::EventSenderProxy::cancelTouchPoint):
2641
2642 2020-05-27  Darin Adler  <darin@apple.com>
2643
2644         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
2645         https://bugs.webkit.org/show_bug.cgi?id=212418
2646
2647         Reviewed by Andy Estes.
2648
2649         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Removed 83 of the 119 things
2650         defined in this file. There are 36 more that are slightly more complex that we can
2651         remove carefully later.
2652
2653 2020-05-29  Darin Adler  <darin@apple.com>
2654
2655         Make generate-unified-sources.sh not depend on features being listed in FEATURE_DEFINES environment variable
2656         https://bugs.webkit.org/show_bug.cgi?id=212420
2657
2658         Reviewed by Andy Estes.
2659
2660         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2661         (WebCoreGenerator._get_generate_derived_sources_script): Removed the code
2662         to generate UnifiedSources-output.xcfilelist.
2663
2664 2020-05-29  Keith Rollin  <krollin@apple.com>
2665
2666         Revert switch to XCBuild
2667         https://bugs.webkit.org/show_bug.cgi?id=212530
2668         <rdar://problem/63764632>
2669
2670         Unreviewed build fix.
2671
2672         Bug 209890 enabled the use of XCBuild by default. Since then, some
2673         build issues have shown up. While addressing them, temporarily turn
2674         off the use of XCBuild by default.
2675
2676         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2677         * Scripts/build-webkit:
2678         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2679
2680 2020-05-29  Philippe Normand  <pnormand@igalia.com>
2681
2682         [Flatpak][GStreamer] all commands, except webkit-build, fails if GST_BUILD_PATH is set
2683         https://bugs.webkit.org/show_bug.cgi?id=212408
2684
2685         Reviewed by Žan Doberšek.
2686
2687         Don't run gst-env.py in the sandbox because that can lead to command-line options clashing
2688         with build-webkit and other WebKit scripts. So instead we now parse the output of the
2689         environment variables gst-build requires and we forward those to the sandbox.
2690
2691         * flatpak/flatpakutils.py:
2692         (run_sanitized):
2693         (check_flatpak):
2694         (FlatpakObject.flatpak):
2695         (WebkitFlatpak.execute_command):
2696         (WebkitFlatpak.setup_gstbuild):
2697         (WebkitFlatpak.run_in_sandbox):
2698         (flatpak_run_sanitized): Deleted.
2699
2700 2020-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2701
2702         Add watchlist comment for patches touching imported WPT tests.
2703         https://bugs.webkit.org/show_bug.cgi?id=212362
2704
2705         Reviewed by Youenn Fablet.
2706
2707         Add a watchlist trigger to comment on patches touching imported WPT tests
2708         with a link to documentation about the export process.
2709
2710         * Scripts/webkitpy/common/config/watchlist:
2711
2712 2020-05-29  Lauro Moura  <lmoura@igalia.com>
2713
2714         [Flatpak] Fix os.system return code for better signal handling.
2715
2716         Rubber-stamped by Philippe Normand.
2717
2718         The previous fix in r262270 correctly fixed the return code issue
2719         but made signal handling pass through python. For example, when you
2720         ctlr+C running MiniBrowser, you'd get a python stacktrace deep inside
2721         subprocess.call.
2722
2723         So, revert back to os.system but fixing the return code.
2724
2725         * flatpak/webkit-bwrap:
2726
2727 2020-05-29  Philippe Normand  <pnormand@igalia.com>
2728
2729         [Flatpak SDK] Update OpenXR
2730         https://bugs.webkit.org/show_bug.cgi?id=212518
2731
2732         Reviewed by Žan Doberšek.
2733
2734         Upstream now builds fine with GCC 9.3.0. Removing downstream patch.
2735         
2736         * buildstream/elements/sdk/openxr.bst:
2737         * buildstream/patches/openxr-0001-cmake-Check-for-C-17-and-conditionally-enable-it.patch: Removed.
2738
2739 2020-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2740
2741         REGRESSION (r261812): editing/async-clipboard/clipboard-item-get-type-basic.html is flaky
2742         https://bugs.webkit.org/show_bug.cgi?id=212281
2743         <rdar://problem/63554912>
2744
2745         Reviewed by Tim Horton.
2746
2747         On some shipping versions of iOS, returning `NO` from `-supportsImagePaste` still results in UIKit keyboard
2748         code pinning temporary items to the general pasteboard, which increments the change count of the pasteboard.
2749         If this happens in the middle of an attempt to read from the pasteboard, we end up falsely denying access to the
2750         contents of the pasteboard, since we believe that the contents of the pasteboard have changed.
2751
2752         This has the potential to affect any test that attempts to read from the pasteboard on iOS, though the titular
2753         layout test seems to trigger the bug more frequently than other tests.
2754
2755         This item pinning was added in support of being able to insert Memojis from the software keyboard, and works by
2756         pretending to copy a temporary PNG image, asking the delegate whether it `-canPerformAction:withSender:`, and
2757         then restoring the items previously on the pasteboard. To work around this in the test runner, we can simply
2758         swizzle out `-[UIKeyboardImpl delegateSupportsImagePaste]` to always return `NO`, which has the same effect as
2759         disabling the Memoji keyboard.
2760
2761         * WebKitTestRunner/TestController.h:
2762         * WebKitTestRunner/ios/TestControllerIOS.mm:
2763         (overrideKeyboardDelegateSupportsImagePaste):
2764         (WTR::TestController::platformResetStateToConsistentValues):
2765
2766 2020-05-28  Myles C. Maxfield  <mmaxfield@apple.com>
2767
2768         Make fast/text/user-installed-fonts/extended-character.html more robust
2769         https://bugs.webkit.org/show_bug.cgi?id=212487
2770         <rdar://problem/63235370>
2771
2772         Unreviewed.
2773
2774         Update the font to use the new character.
2775
2776         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf:
2777
2778 2020-05-28  Lauro Moura  <lmoura@igalia.com>
2779
2780         [Flatpak] Use subprocess.call instead of os.system to forward the return code correctly.
2781
2782         os.system reports error codes from the child process like wait(),
2783         which seems to not be playing well with flatpak/bwrap.
2784
2785         This was causing flatpak to return 0 to some failed commands (like
2786         build-webkit), making failures show as successes in the bots.
2787
2788         Unreviewed build fix.
2789
2790         * flatpak/webkit-bwrap:
2791
2792 2020-05-28  Tim Horton  <timothy_horton@apple.com>
2793
2794         makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean
2795         https://bugs.webkit.org/show_bug.cgi?id=212456
2796
2797         Reviewed by Anders Carlsson.
2798
2799         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2800         (WTR::makeValueRefForValue):
2801         Apply the fix from r260515 to this second copy of the code too.
2802
2803 2020-05-27  Saam Barati  <sbarati@apple.com>
2804
2805         revert logging for detecting failures in run-jsc-stress-tests
2806         https://bugs.webkit.org/show_bug.cgi?id=212447
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * Scripts/run-jsc-stress-tests:
2811
2812 2020-05-27  Tim Horton  <timothy_horton@apple.com>
2813
2814         REGRESSION (PSON): Resizing WKWebView during cross-site navigation results in the page laying out at the wrong size
2815         https://bugs.webkit.org/show_bug.cgi?id=212434
2816         <rdar://problem/51621621>
2817
2818         Reviewed by Chris Dumez.
2819
2820         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2821         Add a test ensuring that we correctly update the view size if it changes
2822         during the provisional phase of the navigation.
2823
2824 2020-05-27  Lauro Moura  <lmoura@igalia.com>
2825
2826         Unreviewed. A couple transformations missing from r262214.
2827
2828         Was making fast/events/touch/tap-highlight-color.html to fail.
2829
2830         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2831         (WTR::EventSenderProxy::keyDown):
2832         (WTR::EventSenderProxy::addTouchPoint):
2833
2834 2020-05-27  Kenneth Russell  <kbr@chromium.org>
2835
2836         Update MobileMiniBrowser project settings to current Xcode
2837         https://bugs.webkit.org/show_bug.cgi?id=212428
2838
2839         Reviewed by Dean Jackson.
2840
2841         Apply suggestions from Dean to automatically switch between the
2842         internal and public SDKs.
2843
2844         * MobileMiniBrowser/Configurations/Base.xcconfig:
2845
2846 2020-05-27  Lauro Moura  <lmoura@igalia.com>
2847
2848         [WPE] Avoid possible WTR event timing going back in time and fix conversion from s to ms
2849         https://bugs.webkit.org/show_bug.cgi?id=212338
2850
2851         Reviewed by Michael Catanzaro.
2852
2853         Make sure we cast the double m_time timestamp from seconds to uint32_t
2854         milliseconds expected by WPE input events.
2855
2856         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2857         (WTR::secToMsTimestamp):
2858         (WTR::EventSenderProxy::EventSenderProxy): Use monotonic time instead
2859         of zero as the time origin. This is used only in a relative manner,
2860         and we need monotonic behavior so conversion to DOM event timestamps
2861         makes sense.
2862         (WTR::EventSenderProxy::mouseDown):
2863         (WTR::EventSenderProxy::mouseUp):
2864         (WTR::EventSenderProxy::mouseMoveTo):
2865         (WTR::EventSenderProxy::mouseScrollBy):
2866         (WTR::EventSenderProxy::updateTouchPoint):
2867         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2868         (WTR::EventSenderProxy::releaseTouchPoint):
2869
2870 2020-05-27  Kate Cheney  <katherine_cheney@apple.com>
2871
2872         Make sure bundle identifier testing override is set in the network process
2873         https://bugs.webkit.org/show_bug.cgi?id=212288
2874         <rdar://problem/63539061>
2875
2876         Reviewed by Chris Dumez.
2877
2878         Set the bundle identifier in the network process if a layout test
2879         updates it. This value usually only gets updated when a new network
2880         process is initialized, which does not happen for every test. So it
2881         should be set/cleared as needed.
2882
2883         * WebKitTestRunner/TestController.cpp:
2884         (WTR::TestController::createWebViewWithOptions):
2885         (WTR::TestController::updateBundleIdentifierInNetworkProcess):
2886         * WebKitTestRunner/TestController.h:
2887
2888 2020-05-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2889
2890         [Clipboard API] Support reading "image/png" on ClipboardItem
2891         https://bugs.webkit.org/show_bug.cgi?id=212339
2892         <rdar://problem/63588957>
2893
2894         Reviewed by Tim Horton.
2895
2896         Add a new API test to verify that TIFF images on the system pasteboard on macOS are automatically converted to
2897         PNG data, and is accessible through `ClipboardItem` through the "image/png" type.
2898
2899         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2900
2901 2020-05-27  Per Arne Vollan  <pvollan@apple.com>
2902
2903         Unreviewed, reverting r260840.
2904
2905         This patch is no longer needed after preferences root cause
2906         has been fixed.
2907
2908         Reverted changeset:
2909
2910         "[Cocoa] Global preferences are not accessible in the
2911         WebContent process when CFPrefs direct mode is enabled"
2912         https://bugs.webkit.org/show_bug.cgi?id=211075
2913         https://trac.webkit.org/changeset/260840
2914
2915 2020-05-27  Devin Rousso  <drousso@apple.com>
2916
2917         Web Inspector: replace `featureGuard` and `availability` with a combined `condition` that accepts any macro
2918         https://bugs.webkit.org/show_bug.cgi?id=210014
2919
2920         Reviewed by Brian Burg.
2921
2922         Previously, the generated InspectorBackendCommands.js would include code for things that the
2923         backend doesn't actually support. By using actual macros and preprocessing that file, we can
2924         ensure that the frontend doesn't incorrectly think that something is supported by the page
2925         being inspected:
2926          - the `Canvas` commands and events related to shader programs/pipelines should only exist
2927            when the corresponding context type exists, namely `ENABLE(WEBGL)` and `ENABLE(WEBGPU)`.
2928          - iOS doesn't support showing rulers, so create a variant of `DOM.setInspectModeEnabled`
2929            that only exists for `PLATFORM(IOS_FAMILY)` that doesn't have the `showRulers` optional
2930            parameter, as well as removing `Page.setShowRulers` entirely.
2931          - setting the forced appearance should only be possible if dark mode is supported.
2932          - web archives only exist if CF is used.
2933
2934         * Configurations/FeatureDefines.xcconfig:
2935         Add `ENABLE_WEB_ARCHIVE` since it's always enabled in wtf/PlatformEnableCocoa.h.
2936
2937         * Scripts/webkitpy/inspector/main.py:
2938         (InspectorGeneratorTests.generate_from_json):
2939         (InspectorGeneratorTests.run_tests):
2940         (InspectorGeneratorTests.main):
2941
2942 2020-05-27  Philippe Normand  <pnormand@igalia.com>
2943
2944         [Flatpak SDK] Update openxr recipe
2945         https://bugs.webkit.org/show_bug.cgi?id=212403
2946
2947         Reviewed by Sergio Villar Senin.
2948
2949         * buildstream/elements/sdk/openxr.bst: Explicitely list dependencies and bump to latest git master.
2950
2951 2020-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2952
2953         [GTK][WTR] EventSender: stop using GdkEvent API in preparation for GTK4
2954         https://bugs.webkit.org/show_bug.cgi?id=212298
2955
2956         Reviewed by Adrian Perez de Castro.
2957
2958         Use WebKitWebViewBase internal API to synthesize events instead of GdkEvents. The touch events support has been
2959         removed because we are no longer testing touch events, since they need an actual touchscreen.
2960
2961         * WebKitTestRunner/EventSenderProxy.h:
2962         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2963         (WTR::getGDKKeySymForKeyRef):
2964         (WTR::toWebKitGLibAPI):
2965         (WTR::EventSenderProxy::keyDown):
2966         (WTR::EventSenderProxy::mouseDown):
2967         (WTR::EventSenderProxy::mouseUp):
2968         (WTR::EventSenderProxy::mouseMoveTo):
2969         (WTR::EventSenderProxy::mouseScrollBy):
2970         (WTR::EventSenderProxy::continuousMouseScrollBy):
2971         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2972         (WTR::EventSenderProxy::leapForward):
2973         (WTR::EventSenderProxy::addTouchPoint):
2974         (WTR::EventSenderProxy::updateTouchPoint):
2975         (WTR::EventSenderProxy::touchStart):
2976         (WTR::EventSenderProxy::touchMove):
2977         (WTR::EventSenderProxy::touchEnd):
2978         (WTR::EventSenderProxy::touchCancel):
2979         (WTR::EventSenderProxy::clearTouchPoints):
2980         (WTR::EventSenderProxy::releaseTouchPoint):
2981         (WTR::EventSenderProxy::cancelTouchPoint):
2982         (WTR::EventSenderProxy::setTouchPointRadius):
2983         (WTR::EventSenderProxy::setTouchModifier):
2984
2985 2020-05-26  Alex Christensen  <achristensen@webkit.org>
2986
2987         UTF-8 encode strings of invalid URLs when converting WTF::URL to NSURL instead of truncating the UTF-16 encoding
2988         https://bugs.webkit.org/show_bug.cgi?id=212393
2989         <rdar://problem/63095503>
2990
2991         Reviewed by Tim Horton.
2992
2993         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2994         (TestWebKitAPI::TEST):
2995
2996 2020-05-26  Mark Lam  <mark.lam@apple.com>
2997
2998         Enhance Bitmap::setEachNthBit() to also take an end index.
2999         https://bugs.webkit.org/show_bug.cgi?id=212386
3000         <rdar://problem/63643324>
3001
3002         Reviewed by Robin Morisset.
3003
3004         * TestWebKitAPI/Tests/WTF/Bitmap.cpp:
3005         (TestWebKitAPI::testBitmapSetEachNthBitImpl):
3006
3007 2020-05-26  Fujii Hironori  <Hironori.Fujii@sony.com>
3008
3009         [WinCairo][WK2] Use GraphicsLayerTextureMapper for Accelerated Compositing mode
3010         https://bugs.webkit.org/show_bug.cgi?id=211883
3011
3012         Reviewed by Don Olmstead.
3013
3014         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3015         (WebKitBrowserWindow::setPreference): Call WKPreferencesSet* for
3016         menu items IDM_ACC_COMPOSITING, IDM_COMPOSITING_BORDERS and
3017         IDM_DEBUG_INFO_LAYER.
3018
3019 2020-05-26  Sam Weinig  <weinig@apple.com>
3020
3021         Extended Color Cleanup: Remove red()/green()/blue() accessors from ExtendedColor in preperation for supporting non-RGB based ColorSpaces
3022         https://bugs.webkit.org/show_bug.cgi?id=212366
3023
3024         Reviewed by Simon Fraser.
3025
3026         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3027         (TestWebKitAPI::TEST):
3028         Update tests to pull values from the channels rather than from the red()/green()/blue() accessors.
3029
3030 2020-05-26  Peng Liu  <peng.liu6@apple.com>
3031
3032         ASSERTION FAILED: m_clientCounts.contains(contextId) - WebKit::VideoFullscreenManagerProxy::removeClientForContext()
3033         https://bugs.webkit.org/show_bug.cgi?id=212308
3034
3035         Disable TestWebKitAPI.PictureInPicture.ExitPiPOnSuspendVideoElement for old iOS versions
3036         due to an issue of AVKit.
3037
3038         In addition, don't run the test if Picture-in-Picture is not supported.
3039
3040         Reviewed by Jer Noble.
3041
3042         * TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:
3043         (TestWebKitAPI::TEST):
3044
3045 2020-05-26  Keith Rollin  <krollin@apple.com>
3046
3047         Enable the use of XCBuild by default in Apple builds
3048         https://bugs.webkit.org/show_bug.cgi?id=209890
3049         <rdar://problem/44182078>
3050
3051         Reviewed by Darin Adler.
3052
3053         Switch from the "legacy" Xcode build system to the "new" build system
3054         (also known as "XCBuild"). Switching to the new system speeds up
3055         builds by a small percentage, better validates projects for
3056         build-related issues (such as dependency cycles), lets WebKit benefit
3057         from future improvements in XCBuild such as those coming from the
3058         underlying llbuild open source project, and prepares us for any other
3059         tools built for this new ecosystem.
3060
3061         Specific changes:
3062
3063         - Remove Xcode project and workspace settings that selected the Build
3064           system, allowing the default to take hold (which is currently the
3065           New build system).
3066         - Updated webkitdirs.pm with a terser check for Xcode version.
3067         - Update build-webkit and Makefile.shared to be explicit when using
3068           the old build system (no longer treat it as a default or fall-back
3069           configuration).
3070         - Update various xcconfig files similarly to treat the default as
3071           using the new build system.
3072         - Update various post-processing build steps to check for Xcode 11.4
3073           and to no longer treat the default as using the old build system.
3074
3075         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3076         * Scripts/build-webkit:
3077         * Scripts/webkitdirs.pm:
3078         (canUseXCBuild):
3079         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3080
3081 2020-05-26  Jonathan Bedard  <jbedard@apple.com>
3082
3083         webkitpy: simctl list may have stderr logging
3084         https://bugs.webkit.org/show_bug.cgi?id=212376
3085         <rdar://problem/63517635>
3086
3087         Unreviewed infrastructure fix.
3088
3089         * Scripts/webkitpy/xcode/simulated_device.py:
3090         (SimulatedDeviceManager.populate_available_devices): Only parse stdout, log error when
3091         json decoding fails.
3092         (SimulatedDevice.is_usable): Only parse stdout.
3093         (SimulatedDevice.launch_app): Ditto.
3094
3095 2020-05-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3096
3097         [iOS] ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink is failing consistently
3098         https://bugs.webkit.org/show_bug.cgi?id=212363
3099         <rdar://problem/63508866>
3100
3101         Reviewed by Tim Horton.
3102
3103         This test began to consistently throw an exception after <https://trac.webkit.org/r261157>, due to how
3104         UserInterfaceSwizzler always instantiates the shared UIApplication. This apparently causes -[WKContentView
3105         resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:] to return `nil` instead of a replica view. As a
3106         result, we crash under `createFallbackTargetedPreview` as we're attempting to assemble a targeted preview for
3107         the context menu interaction.
3108
3109         Since this seems to only affect this particular API test, work around it by swizzling out
3110         `-resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:` in this API test to return a non-null UIView.
3111
3112         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3113         (TestWebKitAPI::swizzledResizableSnapshotViewFromRect):
3114         (TestWebKitAPI::TEST):
3115
3116 2020-05-24  Sam Weinig  <weinig@apple.com>
3117
3118         Extended Color Cleanup: Use the name SimpleColor consistently
3119         https://bugs.webkit.org/show_bug.cgi?id=212337
3120
3121         Reviewed by Anders Carlsson.
3122
3123         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
3124         (TestWebKitAPI::TEST):
3125         Update test for rename of makeRGBAFromHSLA to makeSimpleColorFromHSLA.
3126
3127 2020-05-25  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3128
3129         [Flatpak][GStreamer] compilation fails when GST_BUILD_PATH is defined
3130         https://bugs.webkit.org/show_bug.cgi?id=212343
3131
3132         Reviewed by Philippe Normand.
3133
3134         Flatpak's command has to be expressed before gst-env declaration.
3135
3136         * flatpak/flatpakutils.py:
3137         (WebkitFlatpak.run_in_sandbox):
3138
3139 2020-05-25  Adrian Perez de Castro  <aperez@igalia.com>
3140
3141         [WPE][WKTR] Fix typo in EventSenderProxyWPE
3142         https://bugs.webkit.org/show_bug.cgi?id=212340
3143
3144         Reviewed by Carlos Garcia Campos.
3145
3146         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3147         (WTR::wpeKeySymForKeyRef): Fix typo rightArror -> rightArrow.
3148
3149 2020-05-25  Philippe Normand  <pnormand@igalia.com>
3150
3151         REGRESSION(r262057): [Flatpak SDK] sccache-dist server no longer starting
3152         https://bugs.webkit.org/show_bug.cgi?id=212326
3153
3154         Reviewed by Žan Doberšek.
3155
3156         A few mount points were missing in the sandbox created by
3157         `flatpak run` preventing the sccache-dist server to start and keep running.
3158
3159         * flatpak/flatpakutils.py:
3160         (WebkitFlatpak.run_in_sandbox):
3161         * flatpak/webkit-bwrap:
3162
3163 2020-05-25  Philippe Normand  <pnormand@igalia.com>
3164
3165         [Flatpak SDK] Fixup icecc support
3166         https://bugs.webkit.org/show_bug.cgi?id=212301
3167
3168         Reviewed by Žan Doberšek.
3169
3170         * flatpak/flatpakutils.py:
3171         (WebkitFlatpak.run_in_sandbox): Allow homedir access from the
3172         sandbox, this is needed because the icecc toolchains paths refer
3173         to the host environment, not the sandbox.
3174         (WebkitFlatpak.pack_toolchain): Fix byte-string formatting issue, happening in Python3.
3175
3176 2020-05-25  Philippe Normand  <pnormand@igalia.com>
3177
3178         [GTK4] SDK contains too old GTK4
3179         https://bugs.webkit.org/show_bug.cgi?id=212334
3180
3181         Reviewed by Adrian Perez de Castro.
3182
3183         * buildstream/elements/sdk/gtk.bst: Update GTK4 to 3.98.4.
3184
3185 2020-05-24  Sam Weinig  <weinig@apple.com>
3186
3187         Extended Color Cleanup: Stop allowing direct access to the underlying SimpleColor (it is almost always incorrect with respect to extended colors)
3188         https://bugs.webkit.org/show_bug.cgi?id=212184
3189
3190         Reviewed by Dean Jackson.
3191
3192         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
3193         (TestWebKitAPI::TEST):
3194         Use toSRGBASimpleColorLossy() to get access to color components.
3195
3196 2020-05-22  Alex Christensen  <achristensen@webkit.org>
3197
3198         Make download resume workaround forgiving of changes in CFNetwork
3199         https://bugs.webkit.org/show_bug.cgi?id=212273
3200
3201         Reviewed by Geoffrey Garen.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3204
3205 2020-05-22  Paulo Matos  <pmatos@igalia.com>
3206
3207         Add support for [no-]use-ccache option in build-jsc
3208         https://bugs.webkit.org/show_bug.cgi?id=212259
3209
3210         Reviewed by Mark Lam.
3211
3212         * Scripts/build-jsc:
3213
3214 2020-05-22  Alex Christensen  <achristensen@webkit.org>
3215
3216         Add SPI to unblock third party cookies from WKWebViews with ResourceLoadStatistics turned on
3217         https://bugs.webkit.org/show_bug.cgi?id=212058
3218         <rdar://problem/60595539>
3219
3220         Reviewed by John Wilander.
3221
3222         I also add _test_waitForAlert to make tests less verbose.
3223
3224         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3225         (TEST):
3226         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
3227         (TEST):
3228         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
3229         (TestWebKitAPI::TEST):
3230         * TestWebKitAPI/cocoa/HTTPServer.h:
3231         (TestWebKitAPI::Connection::Connection):
3232         * TestWebKitAPI/cocoa/HTTPServer.mm:
3233         (TestWebKitAPI::HTTPServer::HTTPServer):
3234         (TestWebKitAPI::dataFromString):
3235         (TestWebKitAPI::nullTerminatedRequest):
3236         (TestWebKitAPI::HTTPServer::request const):
3237         (TestWebKitAPI::Connection::receive const):
3238         (TestWebKitAPI::Connection::send const):
3239         * TestWebKitAPI/cocoa/TestUIDelegate.h:
3240         * TestWebKitAPI/cocoa/TestUIDelegate.mm:
3241         (-[WKWebView _test_waitForAlert]):
3242
3243 2020-05-22  Chris Dumez  <cdumez@apple.com>
3244
3245         [WKTR] Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank
3246         https://bugs.webkit.org/show_bug.cgi?id=212268
3247         <rdar://problem/63493074>
3248
3249         Reviewed by Geoffrey Garen.
3250
3251         Make TestController::resetStateToConsistentValues() more robust against failures to navigate to about:blank.
3252
3253         In <rdar://problem/63493074>, we have evidence that TestController::resetStateToConsistentValues() sometimes
3254         fails to load about:blank, likely due to an unresponsive WebProcess. When this happens, WebKitTestRunner
3255         reports the test as timing out and logs this on stderr:
3256         """
3257         <unknown> - TestController::run - Failed to reset state to consistent values
3258         #PROCESS UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 57421)
3259         """
3260
3261         This is unfortunate because this does not indicate that anything is particularly wrong with the test in
3262         question. Rather, it indicates that the WebProcess is unresponsive (likely due to a hang caused by a
3263         previous test), which prevents WebKitTestRunner to reset the state in order to run the test.
3264
3265         I propose that if we fail to load about:blank once, we log an error message to stderr but then terminate
3266         the WebProcess and try once again, to make WebKitTestRunner more robust.
3267         I have verified the change locally, by injecting a script in resetStateToConsistentValues() that causes
3268         a WebProcess hang. Before my change, the test would time out and the same logging as in
3269         <rdar://problem/63493074> would show. After my change though, the test would pass successfully despite the
3270         WebProcess hang.
3271
3272         * WebKitTestRunner/TestController.cpp:
3273         (WTR::TestController::resetStateToConsistentValues):
3274
3275 2020-05-22  ChangSeok Oh  <changseok@webkit.org>
3276
3277         [GTK] jhbuild is broken with GCC 10.0
3278         https://bugs.webkit.org/show_bug.cgi?id=212256
3279
3280         Reviewed by Carlos Alberto Lopez Perez.
3281
3282         GCC 10.0 enables -fno-common as default, so many 'multiple definitions' failures occur
3283         in building dependencies via jhbuild. This patch addresses them by back-porting patches
3284         from corresponding source repositories.
3285
3286         * gstreamer/jhbuild.modules:
3287         * gstreamer/patches/libsrtp-Fix-building-with-gcc-10.patch: Added.
3288         * gstreamer/patches/orc-satisfy-fno-common-under-gcc10.patch: Added.
3289         * gtk/jhbuild.modules:
3290         * gtk/patches/at-spi2-atk-tests-Replace-common-variable-with-usual-external.patch: Added.
3291         * gtk/patches/at-spi2-atk-tests-fix-child_pid-reference.patch: Added.
3292         * gtk/patches/mesa-gallium-build-fix-to-make-gcc-10-happy.patch: Added.
3293         * gtk/patches/xserver-Fix-building-with-fno-common.patch: Added.
3294
3295 2020-05-22  Philippe Normand  <pnormand@igalia.com>
3296
3297         [Flatpak SDK] Add bubblewrap ... wrapper
3298         https://bugs.webkit.org/show_bug.cgi?id=212077
3299
3300         Reviewed by Carlos Alberto Lopez Perez.
3301
3302         The bind-mounts are now handled through webkit-bwrap.
3303
3304         * flatpak/flatpakutils.py:
3305         (WebkitFlatpak.execute_command):
3306         (WebkitFlatpak.run_in_sandbox):
3307         * flatpak/webkit-bwrap: Added.
3308
3309 2020-05-22  Javier Fernandez  <jfernandez@igalia.com>
3310
3311         [Flatpak SDK] CCACHE_ env vars are not forwarded to the sandbox environment
3312         https://bugs.webkit.org/show_bug.cgi?id=212257
3313
3314         Reviewed by Philippe Normand.
3315
3316         Added the "CCACHE" prefix to the ones the SDK should keep from the
3317         user's environment, and forwarded to the Flatpak sandbox.
3318
3319         * flatpak/flatpakutils.py:
3320         (WebkitFlatpak.run_in_sandbox):
3321
3322 2020-05-22  Tim Horton  <timothy_horton@apple.com>
3323
3324         iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back
3325         https://bugs.webkit.org/show_bug.cgi?id=212243
3326         <rdar://problem/59127764>
3327
3328         Reviewed by Wenson Hsieh.
3329
3330         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3331         (-[FocusDelegate _webView:takeFocus:]):
3332         (-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3333         (TEST):
3334
3335 2020-05-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3336
3337         DataTransfer.files contains multiple files when pasting a single image with multiple representations
3338         https://bugs.webkit.org/show_bug.cgi?id=212245
3339         <rdar://problem/60240436>
3340
3341         Reviewed by Tim Horton.
3342
3343         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3344         (-[LocalPasteboard _clearContentsWithoutUpdatingChangeCount]):
3345         (-[LocalPasteboard _addTypesWithoutUpdatingChangeCount:owner:]):
3346         (-[LocalPasteboard writeObjects:]):
3347         (-[LocalPasteboard pasteboardItems]):
3348
3349         Adjust DumpRenderTree's LocalPasteboard so that it lazily populates the pasteboard when constructing
3350         NSPasteboardItems. To do this, we need to make a few adjustments:
3351
3352         1.      When reifying NSPasteboardItems from LocalPasteboard, ask the owner (WebHTMLView) to provide pasteboard
3353                 data for each pasteboard type that was promised by WebKit, but was not eagerly written to the pasteboard.
3354
3355         2.      Cache pasteboard items that were created, so that we don't repeatedly ask WebHTMLView to provide
3356                 pasteboard data. WebHTMLView doesn't currently support this, and suffers from a bug where TIFF data may
3357                 only be provided once. This was fixed for WebKit2, but not for WebKit1.
3358
3359         3.      Maintain a separate hash list of original pasteboard types (which may not be UTIs) that were handed to
3360                 LocalPasteboard by WebKit. We use these original types in step (1).
3361
3362         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3363
3364         Add a new API test to verify that one file is exposed via the DataTranfer when the pasteboard contains a single
3365         image with two image representations, but two files are exposed when the pasteboard contains two images, each
3366         with a single representation.
3367
3368         (writeImageDataToPasteboard):
3369
3370         Overload this helper method with two additional variants: one that takes a dictionary of pasteboard types to
3371         data, and another that takes an array of dictionaries, each representing a single item's types and data.
3372
3373 2020-05-21  Robin Morisset  <rmorisset@apple.com>
3374
3375         Various compile-time boolean flags could/should be marked constexpr
3376         https://bugs.webkit.org/show_bug.cgi?id=212244
3377
3378         Reviewed by Mark Lam.
3379
3380         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3381
3382 2020-05-21  Mark Lam  <mark.lam@apple.com>
3383
3384         Rename some variables in Bitmap API test for consistency and better readability.
3385         https://bugs.webkit.org/show_bug.cgi?id=212235
3386
3387         Reviewed by Saam Barati.
3388
3389         This patch renames the following:
3390             bitmap0 => bitmapZeroes
3391             bitmapFilled => bitmapOnes
3392             bitmap3 => bitmap2Clone
3393             bitmapSmallZeroed => smallBitmapZeroes
3394             bitmapSmallFilled => smallBitmapOnes
3395             bitmapSmall1 => smallBitmap1
3396             bitmapSmall2 => smallBitmap2
3397
3398         Apart from these renamings, there are no other code changes.
3399
3400         * TestWebKitAPI/Tests/WTF/Bitmap.cpp:
3401         (TestWebKitAPI::testBitmapSize):
3402         (TestWebKitAPI::testBitmapConstructedEmpty):
3403         (TestWebKitAPI::testBitmapSetGet):
3404         (TestWebKitAPI::testBitmapTestAndSet):
3405         (TestWebKitAPI::testBitmapTestAndClear):
3406         (TestWebKitAPI::testBitmapConcurrentTestAndSet):
3407         (TestWebKitAPI::testBitmapConcurrentTestAndClear):
3408         (TestWebKitAPI::testBitmapClear):
3409         (TestWebKitAPI::testBitmapClearAll):
3410         (TestWebKitAPI::testBitmapInvert):
3411         (TestWebKitAPI::testBitmapFindRunOfZeros):
3412         (TestWebKitAPI::testBitmapCount):
3413         (TestWebKitAPI::testBitmapIsEmpty):
3414         (TestWebKitAPI::testBitmapIsFull):
3415         (TestWebKitAPI::testBitmapMerge):
3416         (TestWebKitAPI::testBitmapFilter):
3417         (TestWebKitAPI::testBitmapExclude):
3418         (TestWebKitAPI::testBitmapConcurrentFilter):
3419         (TestWebKitAPI::testBitmapSubsumes):
3420         (TestWebKitAPI::testBitmapForEachSetBit):
3421         (TestWebKitAPI::testBitmapFindBit):
3422         (TestWebKitAPI::testBitmapIteration):
3423         (TestWebKitAPI::testBitmapMergeAndClear):
3424         (TestWebKitAPI::testBitmapSetAndClear):
3425         (TestWebKitAPI::testBitmapSetEachNthBit):
3426         (TestWebKitAPI::testBitmapOperatorEqual):
3427         (TestWebKitAPI::testBitmapOperatorNotEqual):
3428         (TestWebKitAPI::testBitmapOperatorAssignment):
3429         (TestWebKitAPI::testBitmapOperatorBitOrAssignment):
3430         (TestWebKitAPI::testBitmapOperatorBitAndAssignment):
3431         (TestWebKitAPI::testBitmapOperatorBitXorAssignment):
3432         (TestWebKitAPI::testBitmapHash):
3433
3434 2020-05-20  Mark Lam  <mark.lam@apple.com>
3435
3436         Add more Bitmap methods.
3437         https://bugs.webkit.org/show_bug.cgi?id=212190
3438         <rdar://problem/63481333>
3439
3440         Reviewed by Robin Morisset.
3441
3442         Added test coverage for the new WTF::Bitmap methods.
3443
3444         * TestWebKitAPI/Tests/WTF/Bitmap.cpp:
3445         (TestWebKitAPI::testBitmapSetEachNthBit):
3446         (TestWebKitAPI::testBitmapOperatorAssignment):
3447         (TestWebKitAPI::testBitmapOperatorBitOrAssignment):
3448         (TestWebKitAPI::testBitmapOperatorBitAndAssignment):
3449         (TestWebKitAPI::testBitmapOperatorBitXorAssignment):
3450         (TestWebKitAPI::TEST):
3451
3452 2020-05-21  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
3453
3454         [PlayStation] Add minimal WKView API to enable TestWebKitAPI
3455         https://bugs.webkit.org/show_bug.cgi?id=211868
3456
3457         Reviewed by Alex Christensen.
3458
3459         Enable TestWebKitAPI
3460
3461         * TestWebKitAPI/PlatformPlayStation.cmake:
3462         * TestWebKitAPI/PlatformWebView.h:
3463         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp:
3464         (TestWebKitAPI::Util::createInjectedBundlePath):
3465         (TestWebKitAPI::Util::createURLForResource):
3466         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp:
3467         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3468         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3469         (TestWebKitAPI::PlatformWebView::initialize):
3470         (TestWebKitAPI::PlatformWebView::resizeTo):
3471         (TestWebKitAPI::PlatformWebView::page const):
3472         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3473         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3474         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3475         (TestWebKitAPI::PlatformWebView::simulateButtonClick):
3476         * TestWebKitAPI/playstation/main.cpp:
3477         (loadLibraryOrExit):
3478         (main):
3479         Add PlayStation Platform support.
3480
3481         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3482         (TestWebKitAPI::TEST):
3483         Use the same expected default font preferences as GTK's.
3484
3485 2020-05-21  Alex Christensen  <achristensen@webkit.org>
3486
3487         [macOS] TestWebKitAPI.WebKit.HTTPReferer is a flaky failure
3488         https://bugs.webkit.org/show_bug.cgi?id=212180
3489
3490         Reviewed by Darin Adler.
3491
3492         Sometimes an HTTP request takes more than one call to nw_connection_receive to receive entirely.
3493         Add a new abstraction Connection that wraps an nw_connection_t and knows how to read an entire request.
3494         Use strnstr instead of null terminating and using strstr.
3495
3496         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3497         (TEST):
3498         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
3499         (TEST):
3500         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
3501         (TestWebKitAPI::TEST):
3502         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3503         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerTCPServer.h:
3504         * TestWebKitAPI/cocoa/HTTPServer.h:
3505         (TestWebKitAPI::Connection::receiveHTTPRequest):
3506         (TestWebKitAPI::Connection::Connection):
3507         * TestWebKitAPI/cocoa/HTTPServer.mm:
3508         (TestWebKitAPI::HTTPServer::HTTPServer):
3509         (TestWebKitAPI::dataFromString):
3510         (TestWebKitAPI::vectorFromData):
3511         (TestWebKitAPI::HTTPServer::respondToRequests):
3512         (TestWebKitAPI::HTTPServer::request const):
3513         (TestWebKitAPI::Connection::receiveHTTPRequest const):
3514         (TestWebKitAPI::Connection::send const):
3515         (TestWebKitAPI::Connection::terminate const):
3516         (TestWebKitAPI::nullTerminatedRequest): Deleted.
3517
3518 2020-05-21  Enrique Ocaña González  <eocanha@igalia.com>
3519
3520         [GStreamer][GTK][WPE] Expose and honor the media content types requiring hardware support setting
3521         https://bugs.webkit.org/show_bug.cgi?id=211950
3522
3523         Reviewed by Adrian Perez de Castro.
3524
3525         Exercise the new mediaContentTypesRequiringHardwareSupport setting.
3526
3527         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3528         (testWebKitSettings):
3529
3530 2020-05-20  Simon Fraser  <simon.fraser@apple.com>
3531
3532         [macOS] Scrolling synchronization part 1: Have the scrolling thread wait half a frame for the main thread to complete the rendering update
3533         https://bugs.webkit.org/show_bug.cgi?id=212168
3534
3535         Reviewed by Tim Horton.
3536
3537         Some new trace points for scrolling thread activity.
3538
3539         * Tracing/SystemTracePoints.plist:
3540
3541 2020-05-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3542
3543         [iOS] Layout tests in editing/pasteboard sporadically crash
3544         https://bugs.webkit.org/show_bug.cgi?id=212169
3545         <rdar://problem/63361966>
3546
3547         Reviewed by Tim Horton.
3548
3549         Add some missing entitlements.
3550
3551         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
3552         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
3553
3554 2020-05-20  Sam Weinig  <weinig@apple.com>
3555
3556         Replace Color::getHSL() with sRGBToHSL to ensure it at least gives somewhat sensible results for ExtendedColors and reduce code duplication
3557         https://bugs.webkit.org/show_bug.cgi?id=212143
3558
3559         Reviewed by Simon Fraser.
3560
3561         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
3562         (TestWebKitAPI::TEST):
3563         Update tests to use sRGBToHSL instead of Color::getHSL() and add testing of WebCore::lightness() and 
3564         round tripping. Update results for hue to be 0->1 rather than 0->6 which allows the round tripping to succeed.
3565
3566 2020-05-20  ChangSeok Oh  <changseok@webkit.org>
3567
3568         [GTK] Implement connected and disconnected events of GAMEPAD API with libmanette
3569         https://bugs.webkit.org/show_bug.cgi?id=133854
3570
3571         Reviewed by Carlos Garcia Campos.
3572
3573         This patch brings initial GAMEPAD API support to the gtk port. We use libmanette,
3574         a simple GObject game controller library to handle gamepad connection and input.
3575         In particular, we use libmanette-0.2.4 which is the latest version and minimum
3576         version to build in c++.
3577
3578         * gtk/jhbuild.modules:
3579
3580 2020-05-20  Kate Cheney  <katherine_cheney@apple.com>
3581
3582         Support operating dates in ResourceLoadStatisticsDatabaseStore
3583         https://bugs.webkit.org/show_bug.cgi?id=212034
3584         <rdar://problem/63349242>
3585
3586         Reviewed by Brent Fulgham.
3587
3588         Add a testing function to insert an expired statistic.
3589
3590         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3591         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3592         (WTR::InjectedBundle::didReceiveMessageToPage):
3593         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3594         (WTR::TestRunner::setStatisticsExpiredStatistic):
3595         (WTR::TestRunner::statisticsCallDidSetExpiredStatisticCallback):
3596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3597         * WebKitTestRunner/TestController.cpp:
3598         (WTR::TestController::setStatisticsExpiredStatistic):
3599         * WebKitTestRunner/TestController.h:
3600         * WebKitTestRunner/TestInvocation.cpp:
3601         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3602         (WTR::TestInvocation::didSetExpiredStatistic):
3603         * WebKitTestRunner/TestInvocation.h:
3604
3605 2020-05-20  Chris Dumez  <cdumez@apple.com>
3606
3607         Deprecate WKBundlePageSetPolicyClient() Injected bundle C API
3608         https://bugs.webkit.org/show_bug.cgi?id=212166
3609
3610         Reviewed by Alex Christensen.
3611
3612         * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
3613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3614         (WTR::InjectedBundlePage::InjectedBundlePage):
3615
3616 2020-05-20  Myles C. Maxfield  <mmaxfield@apple.com>
3617
3618         [iPadOS] -webkit-text-size-adjust:percentage doesn't work in native apps
3619         https://bugs.webkit.org/show_bug.cgi?id=212122
3620         <rdar://problem/54560875>