3a77e0ee9247c040f5ad28c4bf74b22c5fdf2785
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed WPE gardening. Mark some known unit test failures.
4
5         * TestWebKitAPI/glib/TestExpectations.json:
6
7 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
8
9         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
10         https://bugs.webkit.org/show_bug.cgi?id=181724
11
12         Reviewed by Philippe Normand.
13
14         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
15         reason to use different names. This way we can refer to the same test names for both and we can share the
16         expectations in the TestExpectations.json file.
17
18         * TestWebKitAPI/glib/TestExpectations.json:
19         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
20
21 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
22
23         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
24
25         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
26         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
27
28         * glib/api_test_runner.py:
29         (TestRunner._run_test_glib):
30         (TestRunner._run_google_test):
31
32 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
33
34         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
35         https://bugs.webkit.org/show_bug.cgi?id=179914
36
37         Reviewed by Žan Doberšek.
38
39         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
40         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
41         all symbols listed in the script are present in the library.
42
43         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
44         (bss_symbols):
45         * Scripts/check-for-invalid-symbols-in-version-script: Added.
46         (script_symbols):
47         * Scripts/make-dist:
48         (Distcheck.build):
49         (Distcheck):
50         (Distcheck.check_symbols):
51         (Distcheck.check):
52
53 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
54
55         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
56         https://bugs.webkit.org/show_bug.cgi?id=181722
57
58         Reviewed by Žan Doberšek.
59
60         I forgot to pass the parameters to run() when restarting.
61
62         * glib/glib_test_runner.py:
63         (GLibTestRunner.run):
64
65 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
66
67         [CMake] Remove WebCoreDerivedSources library target
68         https://bugs.webkit.org/show_bug.cgi?id=181664
69
70         Reviewed by Carlos Garcia Campos.
71
72         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
73         * TestWebKitAPI/PlatformWin.cmake: Ditto.
74
75 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
76
77         Move Debug Test262, Release Test262 and Performance queues to Sierra
78         https://bugs.webkit.org/show_bug.cgi?id=181692
79
80         Unreviewed
81
82 2018-01-16  Zach Li  <zachli@apple.com>
83
84         Add pop-up policy support in website policies.
85         https://bugs.webkit.org/show_bug.cgi?id=181544.
86         rdar://problem/30521400.
87
88         Reviewed by Alex Christensen.
89
90         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
91         Added pop-up-check.html.
92
93         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
94
95         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
96         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
97         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
98         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
99         (TEST):
100
101 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
102
103         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
104         https://bugs.webkit.org/show_bug.cgi?id=181638
105         <rdar://problem/36508702>
106
107         Reviewed by Dan Bernstein.
108
109         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
110         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
111
112         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
113         (-[AttachmentUpdateObserver init]):
114         (-[AttachmentUpdateObserver sourceForIdentifier:]):
115         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
116         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
117         (TestWebKitAPI::TEST):
118         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
119
120 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
121
122         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
123
124         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
125
126         * glib/api_test_runner.py:
127         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
128         * glib/glib_test_runner.py:
129         (GLibTestRunner.run): Use given env.
130
131 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
132
133         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
134         https://bugs.webkit.org/show_bug.cgi?id=181676
135
136         Reviewed by Carlos Alberto Lopez Perez.
137
138         The option was removed in r226967.
139
140         * BuildSlaveSupport/build.webkit.org-config/steps.py:
141         (RunGtkAPITests):
142         (RunWPEAPITests):
143
144 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
145
146         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
147
148         The bots are still passing that option and the step is failing because it was removed in r226967.
149
150         * glib/api_test_runner.py:
151         (add_options):
152
153 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
154
155         [GTK][WPE] Improve the way glib tests are run
156         https://bugs.webkit.org/show_bug.cgi?id=181674
157
158         Reviewed by Žan Doberšek.
159
160         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
161         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
162         tests failing due to an expected assert in the test and unexpected crashes.
163         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
164         not showing the subtest name in stdout in case of timeouts.
165         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
166         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
167         of every test case.
168
169         * glib/api_test_runner.py:
170         (TestRunner._run_test_glib): Use GLibTestRunner.
171         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
172         (add_options):
173         * glib/glib_test_runner.py: Added.
174         (TestTimeout):
175         (Message):
176         (Message.__init__):
177         (Message.create):
178         (Message.create.read_unsigned):
179         (Message.create.read_double):
180         (Message.create.read_string):
181         (GLibTestRunner):
182         (GLibTestRunner.__init__):
183         (GLibTestRunner._process_data):
184         (GLibTestRunner._process_message):
185         (GLibTestRunner._read_from_pipe):
186         (GLibTestRunner._read_from_stderr):
187         (GLibTestRunner._start_timeout):
188         (GLibTestRunner._start_timeout._alarm_handler):
189         (GLibTestRunner._stop_timeout):
190         (GLibTestRunner._subtest_start):
191         (GLibTestRunner._subtest_message):
192         (GLibTestRunner._subtest_stderr):
193         (GLibTestRunner._subtest_end):
194         (GLibTestRunner.run):
195
196 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
197
198         Unreviewed, add Thibault to contributors.json
199
200         It's a bit weird to add someone here before their first contribution, but this affects
201         Bugzilla autocomplete, and that is serious business.
202
203         * Scripts/webkitpy/common/config/contributors.json:
204
205 2018-01-15  JF Bastien  <jfbastien@apple.com>
206
207         Remove makePoisonedUnique
208         https://bugs.webkit.org/show_bug.cgi?id=181630
209         <rdar://problem/36498623>
210
211         Reviewed by Mark Lam.
212
213         Update tests.
214
215         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
216         (TestWebKitAPI::TEST):
217         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
218         (TestWebKitAPI::TEST):
219
220 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
221
222         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
223         https://bugs.webkit.org/show_bug.cgi?id=181476
224
225         Reviewed by Michael Catanzaro.
226
227         Update to xorg-server 1.19.6 which depends on libxfont2, and change
228         the lists of packages to install libxfont2-devel (or equivalent).
229
230         * gtk/install-dependencies:
231         * gtk/jhbuild.modules:
232
233 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
234
235         [GTK][WPE] Add support for unit test expectations
236         https://bugs.webkit.org/show_bug.cgi?id=181589
237
238         Reviewed by Michael Catanzaro.
239
240         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
241         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
242         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
243         script itself is not a good idea either.
244
245         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
246         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
247         convenient methods to query them.
248
249         * Scripts/run-gtk-tests:
250         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
251         * Scripts/run-wpe-tests:
252         (WPETestRunner): Ditto.
253         * Scripts/webkitpy/common/test_expectations.py: Added.
254         (TestExpectations):
255         (TestExpectations.__init__):
256         (TestExpectations._port_name_for_expected):
257         (TestExpectations._expected_value):
258         (TestExpectations.skipped_tests):
259         (TestExpectations.skipped_subtests):
260         (TestExpectations._expectation_value):
261         (TestExpectations.is_slow):
262         (TestExpectations.get_expectation):
263         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
264         (MockTestExpectations):
265         (MockTestExpectations.__init__):
266         (MockTestExpectations.is_skip):
267         (ExpectationsTest):
268         (assert_exp):
269         (assert_not_exp):
270         (assert_bad_exp):
271         (assert_skip):
272         (test_basic):
273         (test_skip):
274         (test_flaky):
275         (test_build_type):
276         * TestWebKitAPI/glib/TestExpectations.json: Added.
277         * glib/api_test_runner.py:
278         (TestRunner): Remove SkippedTest implementation.
279         (TestRunner.__init__): Create a TestExpectations.
280         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
281         (TestRunner._should_run_test_program): Ditto.
282         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
283         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
284         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
285         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
286         (TestRunner.run_tests.report): Helper to write report to stdout.
287
288 2018-01-13  Mark Lam  <mark.lam@apple.com>
289
290         Replace all use of ConstExprPoisoned with Poisoned.
291         https://bugs.webkit.org/show_bug.cgi?id=181542
292         <rdar://problem/36442138>
293
294         Reviewed by JF Bastien.
295
296         1. Converted tests to using new uintptr_t& poison type.
297         2. Added tests for Poisoned comparison operators.
298
299         * TestWebKitAPI/CMakeLists.txt:
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
301         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
302         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
303         (TestWebKitAPI::TEST):
304         (TestWebKitAPI::initializeTestPoison): Deleted.
305         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
306         (TestWebKitAPI::TEST):
307         (TestWebKitAPI::passWithRef):
308         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
309         (TestWebKitAPI::TEST):
310         (TestWebKitAPI::f1):
311         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
312         (TestWebKitAPI::TEST):
313         (TestWebKitAPI::poisonedPtrFoo):
314         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
315         (TestWebKitAPI::TEST):
316         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
317         (TestWebKitAPI::TEST):
318
319 2018-01-13  David Kilzer  <ddkilzer@apple.com>
320
321         check-webkit-style: false positive for [whitespace/braces] with os_log format string
322         <https://webkit.org/b/181606>
323
324         Reviewed by Darin Adler.
325
326         * Scripts/webkitpy/style/checkers/cpp.py:
327         (check_spacing): Modify regular expression to ignore
328         os_log format strings like '%{public}'.
329         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
330         (CppStyleTest.test_spacing_before_braces): Add os_log
331         format string test.
332
333 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
334
335         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
336         https://bugs.webkit.org/show_bug.cgi?id=181626
337
338         Reviewed by Joseph Pecoraro.
339
340         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
341         Additionally, write a new API test covering the change in r226915.
342
343         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
344         (webViewForTestingAttachments):
345         (TestWebKitAPI::TEST):
346
347 2018-01-12  Alex Christensen  <achristensen@webkit.org>
348
349         History state should be updated during client redirects with asynchronous policy decisions
350         https://bugs.webkit.org/show_bug.cgi?id=181358
351         <rdar://problem/35547689>
352
353         Reviewed by Andy Estes.
354
355         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
356         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
357         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
358         (TEST):
359
360 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
361
362         webkitpy: Refactor simulator code (Part 4)
363         https://bugs.webkit.org/show_bug.cgi?id=180555
364         <rdar://problem/36131381>
365
366         Reviewed by Aakash Jain.
367
368         Move new_simulated_device.py to simulated_device.py.
369
370         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
371         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
372         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
373         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
374         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
375
376 2018-01-12  Alex Christensen  <achristensen@webkit.org>
377
378         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
379         https://bugs.webkit.org/show_bug.cgi?id=181595
380
381         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
382         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
383         I change the < and > to $ to make this test pass and continue to test what it used to.
384
385         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
386         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
387         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
388
389 2018-01-11  Keith Miller  <keith_miller@apple.com>
390
391         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
392         https://bugs.webkit.org/show_bug.cgi?id=181573
393
394         Reviewed by Simon Fraser.
395
396         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
397
398 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
399
400         [WebAuthN] Import a CBOR coder from Chromium
401         https://bugs.webkit.org/show_bug.cgi?id=181522
402         <rdar://problem/36055729>
403
404         Reviewed by Brent Fulgham.
405
406         This patch also imports all unit tests into our API tests to ensure all
407         workarounds and modification against the original codebase doesn't change
408         any original functionalities.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
412         (TestWebKitAPI::TEST):
413         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
414         (TestWebKitAPI::TEST):
415         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
416         (TestWebKitAPI::eq):
417         Workarounds applied.
418         (TestWebKitAPI::TEST):
419
420 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
421
422         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
423         https://bugs.webkit.org/show_bug.cgi?id=181538
424         <rdar://problem/36440580>
425
426         Reviewed by Aakash Jain.
427
428         When disambiguating a device type, it is possible that the provided device type is sufficiently
429         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
430         will result in a failure to disambiguate the type.
431
432         * Scripts/webkitpy/xcode/new_simulated_device.py:
433         (SimulatedDeviceManager._disambiguate_device_type):
434
435 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
436
437         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
438         https://bugs.webkit.org/show_bug.cgi?id=181136
439         <rdar://problem/36116604>
440
441         Reviewed by Chris Dumez.
442
443         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
444         browsing sessions.
445
446         * Scripts/run-gtk-tests:
447         (GtkTestRunner): Unskip test now that it passes.
448         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
449         (TEST): Add new WebsiteDataStoreEphemeral test.
450
451 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
452
453         Unreviewed, rolling out r226816.
454
455         This change broke LayoutTests on the bots.
456
457         Reverted changeset:
458
459         "run-webkit-tests fails when there is a curly brace in Xcode
460         build output"
461         https://bugs.webkit.org/show_bug.cgi?id=181254
462         https://trac.webkit.org/changeset/226816
463
464 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
465
466         webkitpy: Fix flakey webserver tests
467         https://bugs.webkit.org/show_bug.cgi?id=181555
468         <rdar://problem/36448273>
469
470         Reviewed by Aakash Jain.
471
472         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
473         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
474         determine if a specific server is running.
475
476 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
477
478         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
479         https://bugs.webkit.org/show_bug.cgi?id=181561
480         <rdar://problem/36452652>
481
482         Reviewed by Aakash Jain.
483
484         BeautifulSoup.find may return None, this case should be gracefully handled.
485
486         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
487         (BugzillaQueries._parse_result_count):
488         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
489
490 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
491
492         run-webkit-tests fails when there is a curly brace in Xcode build output
493         https://bugs.webkit.org/show_bug.cgi?id=181254
494
495         Reviewed by Daniel Bates.
496
497         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
498         (MeteredStream.write):
499
500 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
501
502         webkitpy: Reimplement simulator code (Part 3)
503         https://bugs.webkit.org/show_bug.cgi?id=180555
504         <rdar://problem/36131381>
505
506         Reviewed by Aakash Jain.
507
508         Remove old simulator code.
509
510         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
511         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
512         * Scripts/webkitpy/xcode/simulator.py: Removed.
513         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
514
515 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
516
517         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
518         https://bugs.webkit.org/show_bug.cgi?id=181337
519         <rdar://problem/36324813>
520
521         Reviewed by Tim Horton.
522
523         Add 3 new API tests for attachment element dragging.
524
525         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
526         (-[TestWKWebView expectElementTag:toComeBefore:]):
527         (-[NSItemProvider expectType:withData:]):
528         (TestWebKitAPI::TEST):
529
530 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
531
532         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
533         https://bugs.webkit.org/show_bug.cgi?id=179621
534         <rdar://problem/35589585>
535
536         Unreviewed infrastructure fix.
537
538         * Scripts/webkitpy/port/mac.py:
539         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
540         list if we are the VERSION_MAX, which usually corresponds with future.
541
542 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
543
544         CodeBlocks should be in IsoSubspaces
545         https://bugs.webkit.org/show_bug.cgi?id=180884
546
547         Reviewed by Saam Barati.
548         
549         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
550         shouldn't take a long time due to benchmarks we don't optimize for.
551         
552         * Scripts/run-jsc-benchmarks:
553
554 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
555
556         Test gardening for GTK.
557         https://bugs.webkit.org/show_bug.cgi?id=181477
558
559         Unreviewed test gardening.
560
561         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
562         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
563
564 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
565
566         Add the new JSCOnly bot to the scheduler.
567         https://bugs.webkit.org/show_bug.cgi?id=181487
568
569         Unreviewed follow-up patch after r226729
570
571         On r226729 I missed to add the new JSCOnly bot the default scheduler.
572         This is needed to make the bot automatically pick each commit for testing.
573
574         * BuildSlaveSupport/build.webkit.org-config/config.json:
575
576 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
577
578         [Attachment Support] Support dragging attachment elements out as files on iOS
579         https://bugs.webkit.org/show_bug.cgi?id=181199
580         <rdar://problem/36299316>
581
582         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
583
584         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
585         attachment API tests.
586
587         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
588         (-[NSItemProvider expectType:withData:]):
589         (TestWebKitAPI::TEST):
590
591         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
592         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
593         -expectType:withData: helper to inspect the item providers created from the drag source.
594
595         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
596         (TestWebKitAPI::TEST):
597         * TestWebKitAPI/ios/DataInteractionSimulator.h:
598         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
599         (-[MockDragSession localContext]):
600         (-[MockDragSession setLocalContext:]):
601         (-[DataInteractionSimulator _resetSimulatedState]):
602         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
603         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
604         (-[DataInteractionSimulator _advanceProgress]):
605         (-[DataInteractionSimulator endDataTransfer]):
606
607         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
608         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
609         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
610         MockDragSession to hold on to a localContext.
611
612 2018-01-11  Ali Juma  <ajuma@chromium.org>
613
614         Unreviewed. Add Ali Juma as contributor
615
616         * Scripts/webkitpy/common/config/contributors.json:
617
618 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
619
620         Unreviewed. Update Selenium WebDriver imported tests.
621
622         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
623         environment variables.
624
625         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
626         (collect): Reorder the arguments to make pytest happy.
627         (run): Ditto.
628         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
629         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
630
631 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
632
633         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
634         https://bugs.webkit.org/show_bug.cgi?id=181492
635         <rdar://problem/36359679>
636
637         Reviewed by Alexey Proskuryakov. 
638
639 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
640
641         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
642         https://bugs.webkit.org/show_bug.cgi?id=181475
643
644         Reviewed by Michael Catanzaro.
645
646         * gtk/install-dependencies: Update package list for Arch Linux, extend
647         message shown at end of installation with additional tips.
648
649 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
650
651         REGRESSION(r222507): Composition highlight doesn't render when using IME
652         https://bugs.webkit.org/show_bug.cgi?id=181485
653         <rdar://problem/35896516>
654
655         Reviewed by Ryosuke Niwa.
656
657         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
658         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
659         allow rendering composition backgrounds (see InlineTextBox::paint).
660
661         * DumpRenderTree/ios/TextInputControllerIOS.m:
662         (+[TextInputController isSelectorExcludedFromWebScript:]):
663         (+[TextInputController webScriptNameForSelector:]):
664         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
665         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
666         * DumpRenderTree/mac/TextInputControllerMac.m:
667         (+[TextInputController isSelectorExcludedFromWebScript:]):
668         (+[TextInputController webScriptNameForSelector:]):
669         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
670         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
671         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
672         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
673         (WTR::TextInputController::setMarkedText):
674         * WebKitTestRunner/InjectedBundle/TextInputController.h:
675
676 2018-01-10  JF Bastien  <jfbastien@apple.com>
677
678         Poison small JSObject derivatives which only contain pointers
679         https://bugs.webkit.org/show_bug.cgi?id=181483
680         <rdar://problem/36407127>
681
682         Reviewed by Mark Lam.
683
684         Test the new move-assign and move-copy from unique_ptr, as well as
685         nullptr_t ctors.
686
687         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
688         (TestWebKitAPI::TEST):
689         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
690         (TestWebKitAPI::TEST):
691         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
692         (TestWebKitAPI::TEST):
693
694 2018-01-10  Chris Dumez  <cdumez@apple.com>
695
696         Multiple http/wpt/beacon/contentextensions/ test are flaky.
697         https://bugs.webkit.org/show_bug.cgi?id=179256
698         <rdar://problem/35401978>
699
700         Reviewed by Alex Christensen.
701
702         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
703         instance gets its own folder to avoid conflicts and flakiness.
704
705         * WebKitTestRunner/mac/TestControllerMac.mm:
706         (WTR::TestController::platformConfigureViewForTest):
707
708 2018-01-10  Tim Horton  <timothy_horton@apple.com>
709
710         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
711         https://bugs.webkit.org/show_bug.cgi?id=181269
712         <rdar://problem/35110344>
713
714         Reviewed by Simon Fraser.
715
716         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
717         (WTR::UIScriptController::beginBackSwipe):
718         (WTR::UIScriptController::completeBackSwipe):
719         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
720         (WTR::UIScriptController::beginBackSwipe):
721         (WTR::UIScriptController::completeBackSwipe):
722         (WTR::UIScriptController::overridePreference):
723         (WTR::UIScriptController::replaceTextAtRange):
724         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
725         (WTR::PlatformWebView::setNavigationGesturesEnabled):
726         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
727         (WTR::UIScriptController::beginBackSwipe):
728         (WTR::UIScriptController::completeBackSwipe):
729         Implement beginBackSwipe and completeBackSwipe on iOS (they already
730         exist on Mac) in terms of the new WKWebView testing SPI.
731
732 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
733
734         REGRESSION (r226715): ignore WARNING output in linter tests
735         https://bugs.webkit.org/show_bug.cgi?id=181486
736         <rdar://problem/36408847>
737
738         Reviewed by Aakash Jain.
739
740         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
741
742         * Scripts/webkitpy/common/system/outputcapture.py:
743         (OutputCapture.__init__): Pass logging level to be captured.
744         * Scripts/webkitpy/style/main_unittest.py:
745         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
746         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
747         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
748         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
749         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
750         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
751         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
752         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
753
754 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
755
756         Add a JSCOnly MIPS buildbot
757         https://bugs.webkit.org/show_bug.cgi?id=181487
758
759         Reviewed by Michael Catanzaro.
760
761         Add the new bot configs definitions for the master and update the unit tests.
762
763         * BuildSlaveSupport/build.webkit.org-config/config.json:
764         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
765
766 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
767
768         REGRESSION (r226715): don't re-check number of simulators in child processes
769         https://bugs.webkit.org/show_bug.cgi?id=181484
770         <rdar://problem/36407151>
771
772         Reviewed by Aakash Jain.
773
774         * Scripts/webkitpy/port/ios_simulator.py:
775         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
776         are already initialized.
777
778 2018-01-10  Commit Queue  <commit-queue@webkit.org>
779
780         Unreviewed, rolling out r226667 and r226673.
781         https://bugs.webkit.org/show_bug.cgi?id=181488
782
783         This caused a flaky crash. (Requested by mlewis13 on #webkit).
784
785         Reverted changesets:
786
787         "CodeBlocks should be in IsoSubspaces"
788         https://bugs.webkit.org/show_bug.cgi?id=180884
789         https://trac.webkit.org/changeset/226667
790
791         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
792         https://bugs.webkit.org/show_bug.cgi?id=180884
793         https://trac.webkit.org/changeset/226673
794
795 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
796
797         Follow-up fix to r226715
798         https://bugs.webkit.org/show_bug.cgi?id=180555
799         <rdar://problem/36131381>
800
801         Unreviewed infrastructure fix.
802
803         * Scripts/webkitpy/xcode/new_simulated_device.py:
804         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
805         of delete.
806
807 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
808
809         webkitpy: Refactor simulator code (Part 2)
810         https://bugs.webkit.org/show_bug.cgi?id=180555
811         <rdar://problem/36131381>
812
813         Reviewed by Aakash Jain.
814
815         The patch leverages the SimulatedDeviceManager when running layout tests.
816         This patch is primarily code removal, since much of the IOSSimulatorPort
817         was dedicated to managing simulators. The removed code is either now owned by the
818         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
819         boot multiple simulators which was made obsolete in Xcode 9.
820
821         * Scripts/webkitpy/layout_tests/controllers/manager.py:
822         (Manager._custom_device_for_test.in): Device names now have spaces in them,
823         strip those spaces.
824         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
825         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
826         * Scripts/webkitpy/port/ios.py:
827         (IOSPort.__init__): The _current_device idiom is no longer required since the
828         SimulatedDeviceManager keeps track of any previously booted devices.
829         (IOSPort.target_host): Even when only a single device is used, it will be accessed
830         through the array of managed devices.
831         (IOSPort.using_multiple_devices): Deleted.
832         * Scripts/webkitpy/port/ios_device.py:
833         (IOSDevicePort.using_multiple_devices): Deleted.
834         * Scripts/webkitpy/port/ios_simulator.py:
835         (IOSSimulatorPort): Remove constants required to manage simulators, change device
836         class strings so they can be parsed by the DeviceType class.
837         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
838         the number of simulators currently booted, the number of child processes specified
839         and the maximum number of simulators supported by this system.
840         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
841         devices owned by the SimulatedDeviceManager.
842         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
843         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
844         the maximum number of supported simulators on this system.
845         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
846         request for each child process and send this list to the SimulatedDeviceManager to
847         initialize the devices.
848         (IOSSimulatorPort.clean_up_test_run):
849         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
850         specified version of iOS.
851         (IOSSimulatorPort.reset_preferences):
852         (IOSSimulatorPort.simulator_runtime): Deleted.
853         (IOSSimulatorPort.simulator_device_type): Deleted.
854         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
855         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
856         (IOSSimulatorPort._create_simulators): Deleted.
857         (IOSSimulatorPort._quit_ios_simulator): Deleted.
858         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
859         (IOSSimulatorPort.using_multiple_devices): Deleted.
860         (IOSSimulatorPort._create_device): Deleted.
861         (IOSSimulatorPort.get_simulator_path): Deleted.
862         (IOSSimulatorPort._createSimulatorApps): Deleted.
863         (IOSSimulatorPort._createSimulatorApp): Deleted.
864         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
865         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
866         maximum number of simulators run on this system.
867         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
868         * Scripts/webkitpy/xcode/new_simulated_device.py:
869         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
870
871 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
872
873         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
874         https://bugs.webkit.org/show_bug.cgi?id=181474
875
876         Reviewed by Carlos Alberto Lopez Perez.
877
878         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
879         name as the name.
880
881         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
882         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
883         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
884
885 2018-01-09  Andy Estes  <aestes@apple.com>
886
887         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
888         https://bugs.webkit.org/show_bug.cgi?id=181459
889
890         Reviewed by Dan Bernstein.
891
892         * ImageDiff/cg/Configurations/Base.xcconfig:
893
894 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
895
896         font-display:fallback can cause a visual flash (which is supposed to be impossible)
897         https://bugs.webkit.org/show_bug.cgi?id=181374
898
899         Reviewed by Simon Fraser.
900
901         The test requires Palatino.
902
903         * DumpRenderTree/mac/DumpRenderTree.mm:
904         (allowedFontFamilySet):
905         * WebKitTestRunner/mac/TestControllerMac.mm:
906         (WTR::allowedFontFamilySet):
907
908 2018-01-09  Saam Barati  <sbarati@apple.com>
909
910         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
911         https://bugs.webkit.org/show_bug.cgi?id=181449
912
913         Reviewed by JF Bastien.
914
915         This allows me to Cmd+f in my terminal to search for things without
916         having the results become misaligned.
917
918         * Scripts/display-profiler-output:
919
920 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
921
922         [webkitpy] PlatformInfo should have default argument for casual use
923         https://bugs.webkit.org/show_bug.cgi?id=180827
924
925         Reviewed by David Kilzer.
926
927         PlatformInfo should be the only way to check platform specific thing instead
928         of sys.platform or other various checks. If there is something you want to check,
929         it should be placed in PlatformInfo.
930
931         Currently to instantiate PlatformInfo, it requires arguments, which is usually
932         sys, platform and Executive(). They are straight forward and should be handled
933         by default arguments. Then we can instantiate PlatformInfo more casual.
934
935         * Scripts/webkitpy/common/system/platforminfo.py:
936         (PlatformInfo): Use relative module path import
937         (PlatformInfo.__init__):
938         (PlatformInfo.executive): Lazy instantiation of Executive()
939         (PlatformInfo.total_bytes_memory): Accessing via above property
940         (PlatformInfo.xcode_sdk_version): Ditto
941         (PlatformInfo.xcode_simctl_list): Ditto
942         (PlatformInfo.xcode_version): Ditto
943         (PlatformInfo._win_version_str): Ditto
944         * Scripts/webkitpy/common/system/systemhost.py:
945         (SystemHost.__init__):
946         * Scripts/webkitpy/common/system/user.py:
947         (User.__init__):
948
949 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
950
951         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
952         https://bugs.webkit.org/show_bug.cgi?id=176443
953
954         Reviewed by Darin Adler.
955
956         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
957         (TEST):
958
959 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
960
961         check-webkit-style: Verify syntax for WK_API_AVAILABLE
962         https://bugs.webkit.org/show_bug.cgi?id=181394
963
964         Reviewed by Darin Adler.
965
966         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
967         as the second parameter instead of ios(WK_IOS_TBA). This generally
968         builds for iOS on EWS but not when using the public SDK. See r224057,
969         r223207 and r226211 for example. This patch adds a basic style check
970         for that macro to prevent this kind of mistake.
971
972         * Scripts/webkitpy/style/checkers/cpp.py:
973         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
974         (check_style): Run new style check.
975         (CppChecker): Add build type for the new style check.
976         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
977         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
978
979 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
980
981         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
982         https://bugs.webkit.org/show_bug.cgi?id=181420
983         <rdar://problem/36365827>
984
985         Reviewed by Alex Christensen.
986
987         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
988         of corresponding _WKAttachments.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
991         (TestWebKitAPI::TEST):
992
993 2018-01-08  Alex Christensen  <achristensen@webkit.org>
994
995         Add WKNavigationDelegate SPI exposing WebProcess crash reason
996         https://bugs.webkit.org/show_bug.cgi?id=181410
997         <rdar://problem/36167199>
998
999         Reviewed by Wenson Hsieh.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1002         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1003         (TEST):
1004
1005 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1006
1007         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1008         https://bugs.webkit.org/show_bug.cgi?id=181408
1009         <rdar://problem/35884960>
1010
1011         Reviewed by Tim Horton.
1012
1013         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1014         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1015
1016 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1017
1018         [Attachment Support] Expose file name and content type of WKAttachment
1019         https://bugs.webkit.org/show_bug.cgi?id=181390
1020         <rdar://problem/36336837>
1021
1022         Reviewed by Tim Horton.
1023
1024         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1027         (-[_WKAttachment synchronouslyRequestInfo:]):
1028         (-[_WKAttachment synchronouslyRequestData:]):
1029
1030         Reimplement this in terms of -synchronouslyRequestInfo:.
1031
1032         (-[_WKAttachment expectRequestedDataToBe:]):
1033         (TestWebKitAPI::TEST):
1034
1035 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1036
1037         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1038         https://bugs.webkit.org/show_bug.cgi?id=181365
1039         <rdar://problem/36340647>
1040
1041         Reviewed by Tim Horton.
1042
1043         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1044         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1045         detail.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1048         (TestWebKitAPI::TEST):
1049
1050 2018-01-08  Youenn Fablet  <youenn@apple.com>
1051
1052         navigator.onLine does not work inside service workers
1053         https://bugs.webkit.org/show_bug.cgi?id=181079
1054         <rdar://problem/36178606>
1055
1056         Reviewed by Darin Adler.
1057
1058         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1059         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1060
1061 2018-01-07  Saam Barati  <sbarati@apple.com>
1062
1063         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1064         https://bugs.webkit.org/show_bug.cgi?id=181372
1065
1066         Reviewed by Filip Pizlo.
1067
1068         Adding these sorting modes makes it easier to analyze functions
1069         that recompile a lot and exit a lot.
1070
1071         * Scripts/display-profiler-output:
1072
1073 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1074
1075         Unreviewed, remove my Cisco email from contributors.json
1076
1077         * Scripts/webkitpy/common/config/contributors.json:
1078
1079 2018-01-05  JF Bastien  <jfbastien@apple.com>
1080
1081         WebAssembly: poison JS object's secrets
1082         https://bugs.webkit.org/show_bug.cgi?id=181339
1083         <rdar://problem/36325001>
1084
1085         Reviewed by Mark Lam.
1086
1087         Update tests for swap(Poisoned<k, T>, T*)
1088
1089         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1090         (TestWebKitAPI::TEST):
1091         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1092         (TestWebKitAPI::TEST):
1093         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1094         (TestWebKitAPI::TEST):
1095
1096 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1097
1098         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1099         https://bugs.webkit.org/show_bug.cgi?id=181359
1100
1101         Reviewed by Tim Horton.
1102
1103         Ensure that these tests still pass using older SDKs.
1104
1105         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1106         (TestWebKitAPI::TEST):
1107
1108 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1109
1110         Rebase API test after r226469
1111         https://bugs.webkit.org/show_bug.cgi?id=181308
1112
1113         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1114         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1115         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1116
1117 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1118
1119         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1120         https://bugs.webkit.org/show_bug.cgi?id=181217
1121
1122         Reviewed by Tim Horton.
1123
1124         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1125         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1126         (TEST):
1127
1128 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1129
1130         Add WKBundleFrameCreateFrameHandle
1131         https://bugs.webkit.org/show_bug.cgi?id=181232
1132         <rdar://problem/35926696>
1133
1134         Reviewed by Tim Horton.
1135
1136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1137         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1138         (mouseDidMoveOverElement):
1139         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1140         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1141         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1142         (TEST):
1143
1144 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1145
1146         iOS: Build fix after r226432.
1147         
1148         Unreviewed. Stop duplicating speakAs symbols for iOS.
1149
1150         * DumpRenderTree/AccessibilityUIElement.cpp:
1151         (AccessibilityUIElement::speakAs):
1152
1153 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1154
1155         Unreviewed, added myself as WebKit reviewer
1156
1157         * Scripts/webkitpy/common/config/contributors.json:
1158
1159 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1160
1161         WPE: Build fix after r226432.
1162
1163         Unreviewed. Rename ::speak() to ::speakAs().
1164         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1165         (WTR::AccessibilityUIElement::speakAs):
1166         (WTR::AccessibilityUIElement::speak): Deleted.
1167
1168 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1169
1170         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1171         https://bugs.webkit.org/show_bug.cgi?id=180361
1172
1173         Reviewed by Zalan Bujtas.
1174
1175         * DumpRenderTree/AccessibilityUIElement.cpp:
1176         (speakAsCallback):
1177         (AccessibilityUIElement::speakAs):
1178         (AccessibilityUIElement::getJSClass):
1179         (speakCallback): Deleted.
1180         (AccessibilityUIElement::speak): Deleted.
1181         * DumpRenderTree/AccessibilityUIElement.h:
1182         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1183         (AccessibilityUIElement::speakAs):
1184         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1185         (AccessibilityUIElement::speakAs):
1186         (AccessibilityUIElement::speak): Deleted.
1187         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1188         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1189         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1190         (WTR::AccessibilityUIElement::speakAs):
1191         (WTR::AccessibilityUIElement::speak): Deleted.
1192         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1193         (WTR::AccessibilityUIElement::speakAs):
1194         (WTR::AccessibilityUIElement::speak): Deleted.
1195
1196 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1197
1198         REGRESSION (r226395): test-webkitperl test expectations incorrect
1199         https://bugs.webkit.org/show_bug.cgi?id=181307
1200         <rdar://problem/36306558>
1201
1202         Rubber-stamped by Aakash Jain.
1203
1204         r226395 added two lines towards the beginning of
1205         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1206         numbers in the test expectations need to update.
1207
1208         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1209
1210 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1211
1212         WKWebView loses minimum layout size overrides that happen while the process is terminated
1213         https://bugs.webkit.org/show_bug.cgi?id=181306
1214         <rdar://problem/34398288>
1215
1216         Reviewed by Dan Bernstein.
1217
1218         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1219         (TEST):
1220         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1221         while the process is terminated results in the page getting the correct
1222         minimum layout size.
1223
1224 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1225
1226         [MediaStream] Add Mock screen capture source
1227         https://bugs.webkit.org/show_bug.cgi?id=181291
1228         <rdar://problem/36298164>
1229
1230         Reviewed by Dean Jackson.
1231
1232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1233         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1234         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1235
1236 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1237
1238         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1239
1240         Reviewed by Ling Ho.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1243
1244 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1245
1246         [Attachment Support] Create attachment elements when dropping files on iOS
1247         https://bugs.webkit.org/show_bug.cgi?id=181192
1248         <rdar://problem/36280945>
1249
1250         Reviewed by Tim Horton.
1251
1252         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1253         switch is enabled. See below for more details.
1254
1255         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1256         (-[NSItemProvider registerData:type:]):
1257         (platformCopyPNG):
1258         (TestWebKitAPI::TEST):
1259         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1260
1261         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1262         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1263         kUTTypeRTF instead.
1264
1265         (TestWebKitAPI::TEST):
1266
1267         Tests a few cases of inserting attachment elements via drop:
1268         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1269             Instead of inserting the contents as inline web content, this should generate attachment elements.
1270         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1271             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1272             back to inserting the content as an attachment.
1273         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1274             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1275             or at the end).
1276
1277         * TestWebKitAPI/cocoa/TestWKWebView.h:
1278         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1279         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1280
1281         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1282         -stringByEvaluatingJavaScript to just turn around and call this.
1283
1284         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1285
1286 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1287
1288         Replace hard-coded paths in shebangs with #!/usr/bin/env
1289         https://bugs.webkit.org/show_bug.cgi?id=181040
1290
1291         Reviewed by Alex Christensen.
1292
1293         * BuildSlaveSupport/build-launcher-app:
1294         * BuildSlaveSupport/build-launcher-dmg:
1295         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1296         * BuildSlaveSupport/built-product-archive:
1297         * BuildSlaveSupport/clean-build:
1298         * BuildSlaveSupport/delete-stale-build-files:
1299         * BuildSlaveSupport/download-built-product:
1300         * BuildSlaveSupport/gtk/buildbot/log/run:
1301         * BuildSlaveSupport/gtk/buildbot/run:
1302         * BuildSlaveSupport/gtk/pulseaudio/run:
1303         * BuildSlaveSupport/kill-old-processes:
1304         * BuildSlaveSupport/test-result-archive:
1305         * BuildSlaveSupport/win/kill-old-processes:
1306         * Scripts/SpacingHeuristics.pm:
1307         * Scripts/add-include:
1308         * Scripts/build-api-tests:
1309         * Scripts/build-dumprendertree:
1310         * Scripts/build-imagediff:
1311         * Scripts/build-jsc:
1312         * Scripts/build-webkit:
1313         * Scripts/build-webkittestrunner:
1314         * Scripts/check-Xcode-source-file-types:
1315         * Scripts/check-dom-results:
1316         * Scripts/check-for-exit-time-destructors:
1317         * Scripts/check-for-global-initializers:
1318         * Scripts/check-for-inappropriate-objc-class-names:
1319         * Scripts/check-for-weak-vtables-and-externals:
1320         * Scripts/clean-header-guards:
1321         * Scripts/compare-timing-files:
1322         * Scripts/configure-xcode-for-ios-development:
1323         * Scripts/copy-webkitlibraries-to-product-directory:
1324         * Scripts/create-exports:
1325         * Scripts/debug-minibrowser:
1326         * Scripts/debug-safari:
1327         * Scripts/debug-test-runner:
1328         * Scripts/do-file-rename:
1329         * Scripts/do-webcore-rename:
1330         * Scripts/dump-webkit-tests-run:
1331         * Scripts/ensure-valid-python:
1332         * Scripts/execAppWithEnv:
1333         * Scripts/extract-localizable-js-strings:
1334         * Scripts/filter-build-webkit:
1335         * Scripts/find-extra-includes:
1336         * Scripts/fix-blink-patch:
1337         * Scripts/generate-coverage-data:
1338         * Scripts/git-add-reviewer:
1339         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1340         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1341         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1342         * Scripts/make-new-script-test:
1343         * Scripts/make-script-test-wrappers:
1344         * Scripts/package-root:
1345         * Scripts/parse-malloc-history:
1346         * Scripts/report-include-statistics:
1347         * Scripts/resolve-ChangeLogs:
1348         * Scripts/run-api-tests:
1349         * Scripts/run-bindings-tests:
1350         * Scripts/run-content-extension-tester:
1351         * Scripts/run-iexploder-tests:
1352         * Scripts/run-javascriptcore-tests:
1353         * Scripts/run-jsc:
1354         * Scripts/run-leaks:
1355         * Scripts/run-mangleme-tests:
1356         * Scripts/run-minibrowser:
1357         * Scripts/run-pageloadtest:
1358         * Scripts/run-regexp-tests:
1359         * Scripts/run-safari:
1360         * Scripts/run-sunspider:
1361         * Scripts/run-test-runner:
1362         * Scripts/run-webkit-app:
1363         * Scripts/run-webkit-httpd:
1364         * Scripts/run-webkit-websocketserver:
1365         * Scripts/set-webkit-configuration:
1366         * Scripts/show-pretty-diff:
1367         * Scripts/sort-Xcode-project-file:
1368         * Scripts/split-file-by-class:
1369         * Scripts/sunspider-compare-results:
1370         * Scripts/svn-apply:
1371         * Scripts/svn-unapply:
1372         * Scripts/test-webkit-scripts:
1373         * Scripts/test-webkitperl:
1374         * Scripts/update-iexploder-cssproperties:
1375         * Scripts/update-javascriptcore-test-results:
1376         * Scripts/update-webkit:
1377         * Scripts/update-webkit-auxiliary-libs:
1378         * Scripts/update-webkit-dependency:
1379         * Scripts/update-webkit-libs-jhbuild:
1380         * Scripts/update-webkit-localizable-strings:
1381         * Scripts/update-webkit-support-libs:
1382         * Scripts/update-webkitgtk-libs:
1383         * Scripts/update-webkitwpe-libs:
1384         * Scripts/webkit-build-directory:
1385         * Scripts/webkitperl/LoadAsModule.pm:
1386         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1387         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1388         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1389         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1390         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1391         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1392         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1393         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1394         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1395         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1396         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1397         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1398         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1399         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1400         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1401         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1402         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1403         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1404         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1405         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1406         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1407         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1408         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1409         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1410         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1411         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1412         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1413         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1414         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1415         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1416         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1417         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1418         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1419         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1420         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1421         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1422         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1423         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1424         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1425         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1426         * ccache/ccache-clang:
1427         * ccache/ccache-clang++:
1428         * ccache/ccache-wrapper:
1429         * gtk/install-dependencies:
1430         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1431         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1432         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1433         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1434         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1435         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1436         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1437         * iExploder/iexploder-1.7.2/src/webserver.rb:
1438         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1439         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1440         * wpe/install-dependencies:
1441
1442 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1443
1444         filter-build-webkit filters out useful compiler error lines
1445         https://bugs.webkit.org/show_bug.cgi?id=179864
1446
1447         Reviewed by Tim Horton.
1448
1449         Don't filter out lines that contain information about build errors by always showing lines
1450         after a line that contains "note:" or "error:".
1451
1452         * Scripts/filter-build-webkit:
1453         (shouldShowSubsequentLine):
1454         (shouldIgnoreLine):
1455
1456 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1457
1458         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1459         https://bugs.webkit.org/show_bug.cgi?id=173915
1460
1461         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1462         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1463         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1464         empty string in this case.
1465
1466         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1467         (emitFormSubmissionEvent):
1468
1469 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1470
1471         [GTK] Add web process API to detect when form is submitted via JavaScript
1472         https://bugs.webkit.org/show_bug.cgi?id=173915
1473
1474         Reviewed by Carlos Garcia Campos.
1475
1476         Test it.
1477
1478         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1479         (FormSubmissionTest::FormSubmissionTest):
1480         (FormSubmissionTest::~FormSubmissionTest):
1481         (FormSubmissionTest::testFormSubmissionResult):
1482         (FormSubmissionTest::willSendDOMEventCallback):
1483         (FormSubmissionTest::willCompleteCallback):
1484         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1485         (testWebExtensionFormSubmissionSteps):
1486         (beforeAll):
1487         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1488         (DelayedSignal::DelayedSignal):
1489         (emitFormSubmissionEvent):
1490         (handleFormSubmissionCallback):
1491         (willSubmitFormCallback):
1492         (pageCreatedCallback):
1493
1494 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1495
1496         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1497         https://bugs.webkit.org/show_bug.cgi?id=181251
1498
1499         * Scripts/run-gtk-tests:
1500         (GtkTestRunner):
1501
1502 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1503
1504         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1505         https://bugs.webkit.org/show_bug.cgi?id=181136
1506
1507         * Scripts/run-gtk-tests:
1508         (GtkTestRunner):
1509
1510 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1511
1512         [macOS, iOS] Adopt new secure coding APIs in WebKit
1513         https://bugs.webkit.org/show_bug.cgi?id=181085
1514         <rdar://problem/34837397>
1515
1516         Reviewed by Tim Horton.
1517
1518         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1519         capable of supporting NSSecureCoding, so pass through the current coding routines.
1520
1521         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1522         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1523         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1524         routines if necessary.
1525         (TEST): Updated for NSSecureCoding.
1526         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1527         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1528
1529 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1530
1531         Remove std::chrono completely
1532         https://bugs.webkit.org/show_bug.cgi?id=181186
1533
1534         Reviewed by Alex Christensen.
1535
1536         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1537         (WTR::TestController::platformRunUntil):
1538
1539 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1540
1541         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1542         https://bugs.webkit.org/show_bug.cgi?id=181231
1543
1544         Reviewed by Alex Christensen.
1545
1546         Implement TestController APIs needed by ResourceLoadStatistics tests.
1547
1548         * WebKitTestRunner/TestController.cpp:
1549         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1550         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1551
1552 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1553
1554         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1555         https://bugs.webkit.org/show_bug.cgi?id=181219
1556
1557         Reviewed by Wenson Hsieh.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1560
1561 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1562
1563         Add a WebAuthentication runtime feature flag
1564         https://bugs.webkit.org/show_bug.cgi?id=181220
1565         <rdar://problem/36055305>
1566
1567         Reviewed by Brent Fulgham.
1568
1569         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1570
1571         * DumpRenderTree/TestOptions.h:
1572         * DumpRenderTree/TestOptions.mm:
1573         (TestOptions::TestOptions):
1574         * DumpRenderTree/mac/DumpRenderTree.mm:
1575         (enableExperimentalFeatures):
1576         (setWebPreferencesForTestOptions):
1577         * WebKitTestRunner/TestController.cpp:
1578         (WTR::TestController::resetPreferencesToConsistentValues):
1579         (WTR::updateTestOptionsFromTestHeader):
1580         * WebKitTestRunner/TestOptions.h:
1581         (WTR::TestOptions::hasSameInitializationOptions const):
1582
1583 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1584
1585         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1586         https://bugs.webkit.org/show_bug.cgi?id=181143
1587         <rdar://problem/36200381>
1588
1589         Reviewed by Tim Horton.
1590
1591         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1592         attachment elements are enabled.
1593
1594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1595         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1596         (TestWebKitAPI::TEST):
1597
1598 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1599
1600         Update Credential Management API for WebAuthentication
1601         https://bugs.webkit.org/show_bug.cgi?id=181082
1602         <rdar://problem/36055239>
1603
1604         Reviewed by Brent Fulgham.
1605
1606         Enable Credential Management API for testing.
1607
1608         * DumpRenderTree/TestOptions.h:
1609         * WebKitTestRunner/TestOptions.h:
1610
1611 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1612
1613         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1614         https://bugs.webkit.org/show_bug.cgi?id=168194
1615
1616         Reviewed by Carlos Garcia Campos.
1617
1618         Fix an assertion and unskip the test. The order that form controls are associated is not
1619         guaranteed.
1620
1621         * Scripts/run-gtk-tests:
1622         (GtkTestRunner):
1623         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1624         (didAssociateFormControlsCallback):
1625
1626 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1627
1628         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1629         https://bugs.webkit.org/show_bug.cgi?id=180897
1630         <rdar://problem/35535328>
1631
1632         Reviewed by Brent Fulgham.
1633
1634         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1635
1636         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1637         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1638         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1639         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1640         (websiteDataStoreTestWebView):
1641         (TEST):
1642
1643 == Rolled over to ChangeLog-2018-01-01 ==